Timeline



Feb 22, 2009:

10:22 PM Changeset in webkit [41129] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/5966123> REGRESSION (r30741): Generic Sun Applet loading logo appears half off screen
  • WebCoreSupport/WebFrameLoaderClient.mm: Correct a copy & paste error in r30741, and assign the height value, rather than the width, to the "height" parameter.
4:53 PM Changeset in webkit [41128] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Build fix?

  • GNUmakefile.am:
4:34 PM Changeset in webkit [41127] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • GNUmakefile.am:
3:26 PM Changeset in webkit [41126] by ggaren@apple.com
  • 40 edits
    2 copies in trunk

JavaScriptCore:

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Next step in splitting JIT functionality out of the Interpreter class:
Created a JITStubs class and renamed Interpreter::cti_* to JITStubs::cti_*.


Also, moved timeout checking into its own class, located in JSGlobalData,
so both the Interpreter and the JIT could have access to it.

  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.scons:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • interpreter/Register.h:
  • jit/JIT.cpp: (JSC::): (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArithSlow_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/TimeoutChecker.cpp: Copied from interpreter/Interpreter.cpp. (JSC::TimeoutChecker::TimeoutChecker): (JSC::TimeoutChecker::reset): (JSC::TimeoutChecker::didTimeOut):
  • runtime/TimeoutChecker.h: Copied from interpreter/Interpreter.h. (JSC::TimeoutChecker::setTimeoutInterval): (JSC::TimeoutChecker::ticksUntilNextCheck): (JSC::TimeoutChecker::start): (JSC::TimeoutChecker::stop):

WebCore:

2009-02-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore changes to timeout checking.

  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): (WebCore::JSDOMWindowBase::commonJSGlobalData):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval):
2:37 AM Changeset in webkit [41125] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.

Reviewed by Oliver Hunt.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
than of an arbitrary existing method on the class.

Feb 21, 2009:

11:32 AM Changeset in webkit [41124] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-21 Anders Carlsson <​andersca@apple.com>

Fix build.


  • Plugins/Hosted/WebTextInputWindowController.m:
11:20 AM Changeset in webkit [41123] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit

..:

2009-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add new files.


  • WebKit.xcodeproj/project.pbxproj:

../mac:

2009-02-20 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add a shared floating text input window implementation, to be used by the hosted plug-in view.


  • Plugins/Hosted/WebTextInputWindowController.h: Added.
  • Plugins/Hosted/WebTextInputWindowController.m: Added.
1:25 AM Changeset in webkit [41122] by dimich@chromium.org
  • 3 edits
    12 adds in trunk

WebCore:
2009-02-21 Hironori Bono <​hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23786
[Chromium] line-break characters in a complex text are treated as zero-width spaces

This change prevents the UniscribeHelper class from treating the line-break characters
as whitespaces.

  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::adjustSpaceAdvances): Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces, so does when Chromium renders a simple text.

LayoutTests:
2009-02-21 Hironori Bono <​hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23786
[Chromium] line-break characters in a complex text are treated as zero-width spaces

Added tests which verifies line-break characters in a complex text are treated as defined in CSS 2.1.

  • fast/text/international/bidi-linebreak-001.html: Added.
  • fast/text/international/bidi-linebreak-002.html: Added.
  • fast/text/international/bidi-linebreak-003.html: Added.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt: Added.
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt: Added.
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt: Added.

Feb 20, 2009:

6:05 PM Changeset in webkit [41121] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by andersca.


<rdar://problem/6496140> Safari sometimes hangs in WKSetMetadataURL for several seconds after downloading a file


Spawn a background thread for WKSetMetadataURL because this function will not return until mds has journaled the data
we are trying to set. Depending on what other I/O is going on, it can take some time.

  • Misc/WebNSFileManagerExtras.m: Import pthread.h and FoundationExtras.h (setMetaData): Added. Calls WKSetMetadataURL(). (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Call setMetaData on a background thread
4:15 PM Changeset in webkit [41120] by jchaffraix@webkit.org
  • 15 edits in trunk/WebCore

2009-02-20 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore

Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
unneeded.

It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
enables us to use some generated QualifiedName.

  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • dom/Document.cpp: (WebCore::Document::setTitle):
  • dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • editing/CompositeEditCommand.cpp: (WebCore::createBlockPlaceholderElement):
  • editing/htmlediting.cpp: (WebCore::createTabSpanElement):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): (WebCore::FTPDirectoryTokenizer::createTDForFilename): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::createBasicDocument):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
  • loader/MediaDocument.cpp: (WebCore::MediaTokenizer::createDocumentStructure):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
  • page/Frame.cpp: (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::styleForSelectionStart): Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
  • page/DragController.cpp: (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
1:19 PM Changeset in webkit [41119] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24060
Fix up to accommodate for CanvasPixelArray return.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::getImageData): Added an extra data() to call. (WebCore::ImageBuffer::putImageData): Ditto.
1:12 PM Changeset in webkit [41118] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-02-19 Eric Carlson <​eric.carlson@apple.com>

Simon Fraser

​https://bugs.webkit.org/show_bug.cgi?id=24042
Bug 24042: MediaPlayer should cache plug-in proxy


The changes in ​https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
MediaPlayer will always have created the private media player object before
the plug-in is instantiated and calls back with the proxy object. This is not
true on all platforms because of threading latency, so MediaPlayer should
cache the plug-in proxy so it can pass it to the media engine at a later time.

  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods. (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto. (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto. (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy. (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine. (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
  • platform/graphics/MediaPlayer.h: Declare m_playerProxy.
1:10 PM Changeset in webkit [41117] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-02-20 Eric Carlson <​eric.carlson@apple.com>

Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24063
Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions. Initialize m_internalCall. (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load(). (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out. (WebCore::HTMLMediaElement::loadInternal): New, guts of old load() (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943 (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out. (WebCore::HTMLMediaElement::playInternal): New, guts of old play() (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out. (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause() (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
  • html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall, add RequireUserGestureRateChangeRestriction.
1:08 PM Changeset in webkit [41116] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-20 Darin Fisher <​darin@chromium.org>

Fix build bustage in FileSystemWin.cpp.

Need to return CString() instead of 0 since there are now two CString
constructors that take a pointer type.

  • platform/win/FileSystemWin.cpp: (WebCore::openTemporaryFile):
12:55 PM Changeset in webkit [41115] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-02-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=23999
Change license headers to accurately reflect code history.

  • platform/ContentType.cpp:
  • platform/ContentType.h:
12:52 PM Changeset in webkit [41114] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-02-20 Sam Weinig <​sam@webkit.org>

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Update results.
12:36 PM Changeset in webkit [41113] by Dimitri Glazkov
  • 13 edits
    2 adds in trunk/WebCore

2009-02-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=23999
Split off MIME type parsing into its own class.

  • GNUmakefile.am: Added ContentType sources.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLMediaElement.cpp: Changed to use ContentType. (WebCore::HTMLMediaElement::selectMediaURL):
  • platform/ContentType.cpp: Added. (WebCore::ContentType::ContentType): (WebCore::ContentType::parameter): (WebCore::ContentType::type):
  • platform/ContentType.h: Added. (WebCore::ContentType::raw):
  • platform/MIMETypeRegistry.cpp:
  • platform/MIMETypeRegistry.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
  • rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
  • rendering/style/RenderStyleConstants.h: Ditto. (WebCore::):
12:32 PM Changeset in webkit [41112] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-02-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix.

Use CString() instead of 0.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile):
  • platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
12:10 PM Changeset in webkit [41111] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

When dealing with local files, use a path instead of an URI. GFile
has problems decoding URIs with percent signs on them.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
11:41 AM Changeset in webkit [41110] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Protect the ResourceHandle instance from being destroyed by
didReceiveData inside the GIO readCallback call, so that
cancelling caused by scripts is handled correctly.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback):
11:27 AM Changeset in webkit [41109] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors

Reviewed by Sam Weinig.

  • loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL(). (WebCore::IconDatabase::open): Commented out unused parameter. (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto. (WebCore::IconDatabase::iconForPageURL): Ditto. (WebCore::IconDatabase::iconURLForPageURL): Ditto. (WebCore::IconDatabase::defaultIcon): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconDataForIconURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::setEnabled): Ditto. (WebCore::IconDatabase::pageURLMappingCount): Added stub. (WebCore::IconDatabase::retainedPageURLCount): Ditto. (WebCore::IconDatabase::iconRecordCount): Ditto. (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
8:27 AM Changeset in webkit [41108] by ddkilzer@apple.com
  • 30 edits in trunk/WebKitSite

Bug 23983: Remove illegal HTML tags from Sunspider web pages

<​https://bugs.webkit.org/show_bug.cgi?id=23983>

Reviewed by Alexey Proskuryakov.

  • perf/sunspider-0.9/3d-cube.html: Removed </link> tag.
  • perf/sunspider-0.9/3d-morph.html: Ditto.
  • perf/sunspider-0.9/3d-raytrace.html: Ditto.
  • perf/sunspider-0.9/access-binary-trees.html: Ditto.
  • perf/sunspider-0.9/access-fannkuch.html: Ditto.
  • perf/sunspider-0.9/access-nbody.html: Ditto.
  • perf/sunspider-0.9/access-nsieve.html: Ditto.
  • perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Ditto.
  • perf/sunspider-0.9/bitops-bits-in-byte.html: Ditto.
  • perf/sunspider-0.9/bitops-bitwise-and.html: Ditto.
  • perf/sunspider-0.9/bitops-nsieve-bits.html: Ditto.
  • perf/sunspider-0.9/controlflow-recursive.html: Ditto.
  • perf/sunspider-0.9/crypto-aes.html: Ditto.
  • perf/sunspider-0.9/crypto-md5.html: Ditto.
  • perf/sunspider-0.9/crypto-sha1.html: Ditto.
  • perf/sunspider-0.9/date-format-tofte.html: Ditto.
  • perf/sunspider-0.9/date-format-xparb.html: Ditto.
  • perf/sunspider-0.9/math-cordic.html: Ditto.
  • perf/sunspider-0.9/math-partial-sums.html: Ditto.
  • perf/sunspider-0.9/math-spectral-norm.html: Ditto.
  • perf/sunspider-0.9/regexp-dna.html: Ditto.
  • perf/sunspider-0.9/string-base64.html: Ditto.
  • perf/sunspider-0.9/string-fasta.html: Ditto.
  • perf/sunspider-0.9/string-tagcloud.html: Ditto.
  • perf/sunspider-0.9/string-unpack-code.html: Ditto.
  • perf/sunspider-0.9/string-validate-input.html: Ditto.
  • perf/sunspider-0.9/sunspider-driver.html: Ditto.
  • perf/sunspider-0.9/sunspider-results.html: Removed </link> and </input> tags.
  • perf/sunspider-0.9/sunspider.html: Removed </link> tag.
8:23 AM Changeset in webkit [41107] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Add comment to generated code when shadowing a built-in object

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm: Added comment to generated code output.
7:34 AM Changeset in webkit [41106] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-20 Avi Drissman <​avi@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24036
Keyboard events need disambiguation on the Linux platform too.

  • platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
7:31 AM Changeset in webkit [41105] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-19 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24046

Several improvements to CString:
1- Make it possible to initialize a CString from a CStringBuffer
2- Make it possible to get a CStringBuffer from a CString
3- Change CStringBuffer::data() to return a const pointer to ward off mutation
4- Remove unused releaseBuffer() methods.
5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.

  • platform/text/CString.cpp: (WebCore::CString::init): (WebCore::CString::mutableData): (WebCore::CString::newUninitialized): (WebCore::CString::copyBufferIfNeeded):
  • platform/text/CString.h: (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::mutableData): (WebCore::CString::CString): (WebCore::CString::buffer):
5:25 AM Changeset in webkit [41104] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix after r41100.

  • GNUmakefile.am:
5:14 AM Changeset in webkit [41103] by oliver@apple.com
  • 7 edits in trunk

<rdar://problem/6606660> 2==null returns true in 64bit jit

Reviewed by Mark Rowe

Code for op_eq_null and op_neq_null was incorrectly performing
a 32bit compare, which truncated the type tag from an integer
immediate, leading to incorrect behaviour.

Feb 19, 2009:

11:23 PM Changeset in webkit [41102] by dimich@chromium.org
  • 8 edits in trunk/WebCore

2009-02-19 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24017
Remove some usage of Document in Worker.

  • dom/WorkerContext.h: (WebCore::WorkerContext::userAgent):
  • dom/Document.cpp: (WebCore::Document::userAgent):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: Added virtual ScriptExecutionContext::userAgent(const KURL&). Document implementation uses FrameLoader::userAgent and WorkerContext receives the string on creation and stores it in a member.
  • dom/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • dom/Worker.h: (WebCore::Worker::create): Instead of Document the Worker constructor now gets a ScriptExecutionContext. Start using some methods on SEC (like completeURL() and userAgent()). For others, explicitly case to Document and add a FIXME. Remove Worker::document() too.
10:20 PM Changeset in webkit [41101] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Holger Freyther.

Do not set httpStatus to SOUP_STATUS_OK when serving local files
to match other ports' behavior, fixing xmlhttprequest test
regressions.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::queryInfoCallback):
10:04 PM Changeset in webkit [41100] by ggaren@apple.com
  • 9 edits
    2 copies in trunk/JavaScriptCore

2009-02-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.


First step in splitting JIT functionality out of the Interpreter class:
Created JITStubs.h/.cpp, and moved Interpreter::cti_* into JITStubs.cpp.


Functions that the Interpreter and JITStubs share moved to Operations.h/.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::checkTimeout): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • jit/JITStubs.cpp: Copied from interpreter/Interpreter.cpp. (JSC::Interpreter::cti_op_resolve_base):
  • jit/JITStubs.h: Copied from interpreter/Interpreter.h.
  • runtime/Operations.cpp: (JSC::jsAddSlowCase): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType):
  • runtime/Operations.h: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::cachePrototypeChain): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::resolveBase):
6:02 PM Changeset in webkit [41099] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

6:02 PM Changeset in webkit [41098] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.16

New tag.

5:54 PM Changeset in webkit [41097] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r41091.

5:41 PM Changeset in webkit [41096] by mitz@apple.com
  • 9 edits in trunk

WebCore:

Reviewed by Sam Weinig.

Undo the iChat-specific quirk added in
<​http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
cache client callbacks during attach() and recalcStyle().

  • WebCore.base.exp: Removed Settings::setNeedsIChatMemoryCacheCallsQuirk().
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory cache client callbacks and remember to enable them afterwards if needed. (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory cache client callbacks if they were disabled in suspendPostAttachCallbacks(). (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and resumePostAttachCallbacks().
  • dom/ContainerNode.h: Made suspendPostAttachCallbacks() and resumePostAttachCallbacks() non-static.
  • dom/Document.cpp: (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific workaround.
  • page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and related code. (WebCore::Settings::Settings):
  • page/Settings.h:

WebKit/mac:

Reviewed by Sam Weinig.

5:38 PM Changeset in webkit [41095] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-19 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix.

Build fix after r41092. Make the memoryUsage method
public. It will be shadowed by cf/mac and for curl/soup/qt
the implementation from ResourceResponseBase will be used.

  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::memoryUsage):
5:23 PM Changeset in webkit [41094] by Beth Dakin
  • 3 edits in trunk/WebCore

2009-02-19 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6077775> Should be able to specify
inactive ::selection color

This patch makes the ::selction pseudo-element work with
the :window-inactive pseudo type. This was, a user can specify a
different ::selection style when a window is inactive.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor):
4:38 PM Changeset in webkit [41093] by weinig@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

2009-02-19 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=24044
Update querySelector/querySelectorAll to match the latest spec

Update querySelector and querySelectorAll to match the latest version
of the Selectors API spec. We now stringify null and undefined to "null"
and "undefined" respectively instead of to "".

Test: fast/dom/SelectorAPI/undefined-null-stringify.html

  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:

LayoutTests:

2009-02-19 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=24044
Update querySelector/querySelectorAll to match the latest spec

  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Updated. We now fail 17 tests due to not throwing an exception when no arguments are passed to querySelector or querySelectorAll.
  • fast/dom/SelectorAPI/resources/undefined-null-stringify.js: Added.
  • fast/dom/SelectorAPI/undefined-null-stringify-expected.txt: Added.
  • fast/dom/SelectorAPI/undefined-null-stringify.html: Added.
4:31 PM Changeset in webkit [41092] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=23732
Rework CachedResource overhead accounting to allow platforms to diverge
in numbers.

  • loader/CachedResource.cpp: (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse for its size and to use actual URL size.
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::size): Added default size method.
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::size): Added Win/CF size method
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::size): Added Mac size method.
3:53 PM Changeset in webkit [41091] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-02-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

  • Fix for <rdar://problem/6604968>

On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
2:52 PM Changeset in webkit [41090] by hyatt@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

2009-02-19 David Hyatt <​hyatt@apple.com>

Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
also consider reflections to be part of their visual overflow. This had already been done for blocks
and lines, but it wasn't being done yet for replaced elements.

Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
layer it pushed until we're done painting the real object (rather than the reflection).

Reviewed by Dan Bernstein

Added fast/reflections/reflection-masks-opacity.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
  • rendering/RenderReplaced.h:

LayoutTests:

2009-02-19 David Hyatt <​hyatt@apple.com>

Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
also consider reflections to be part of their visual overflow. This had already been done for blocks
and lines, but it wasn't being done yet for replaced elements.

Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
layer it pushed until we're done painting the real object (rather than the reflection).

Reviewed by Dan Bernstein

  • fast/reflections/reflection-masks-opacity.html: Added.
  • platform/mac/fast/reflections/reflection-direction-expected.txt:
  • platform/mac/fast/reflections/reflection-masks-expected.txt:
  • platform/mac/fast/reflections/reflection-masks-opacity-expected.checksum: Added.
  • platform/mac/fast/reflections/reflection-masks-opacity-expected.png: Added.
  • platform/mac/fast/reflections/reflection-masks-opacity-expected.txt: Added.
2:51 PM Changeset in webkit [41089] by barraclough@apple.com
  • 14 edits in trunk/JavaScriptCore

2009-02-19 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for x86-64. Where the JavaScriptCore text segment lies outside
a 2gb range of the heap containing JIT generated code, callbacks
from JIT code to the stub functions in Interpreter will be incorrectly
linked.

No performance impact on Sunspider, 1% regression on v8-tests,
due to a 3% regression on richards.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::Call): (JSC::AbstractMacroAssembler::Jump::link): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::differenceBetween):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::tailRecursiveCall): (JSC::MacroAssembler::makeTailRecursiveCall):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::call):
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::moveWithPatch): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch):
  • assembler/X86Assembler.h: (JSC::X86Assembler::jmp_r): (JSC::X86Assembler::linkJump): (JSC::X86Assembler::patchJump): (JSC::X86Assembler::patchCall): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::patchAddress):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompilePutByIdReplace):
2:35 PM Changeset in webkit [41088] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-19 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
<​https://bugs.webkit.org/show_bug.cgi?id=23980>

WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.

  • When WorkerRunLoop::runInMode is called, only task for that mode will run.
  • When WorkerRunLoop::run is called (or the default mode is used), then all tasks will run regardless of their posted mode.

Here's a demonstration of the api:

RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);

Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
 for any tasks that need to be run during this loop.
nameResolution->setTaskMode("MyCoolMode");

nameResolution->start();
while (!nameResolution->done()) {

Only tasks which are posted for "MyCoolMode" will run.
workerRunLoop.runInMode(context, "MyCoolMode");

}

No observable change in behavior, so no test.

  • dom/WorkerRunLoop.cpp: (WebCore::ModePredicate::ModePredicate): (WebCore::ModePredicate::operator()): (WebCore::WorkerRunLoop::WorkerRunLoop): (WebCore::WorkerRunLoop::~WorkerRunLoop): (WebCore::WorkerRunLoop::setSharedTimer): (WebCore::WorkerRunLoop::resetSharedTimer): (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::runInMode): (WebCore::WorkerRunLoop::postTask): (WebCore::WorkerRunLoop::postTaskForMode):
  • dom/WorkerRunLoop.h: (WebCore::WorkerRunLoop::Task::create): (WebCore::WorkerRunLoop::Task::mode): (WebCore::WorkerRunLoop::Task::performTask): (WebCore::WorkerRunLoop::Task::Task):
2:13 PM Changeset in webkit [41087] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

2009-02-19 Jay Campan <​jcampan@google.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23959
LayoutTests/fast/dom/navigator-detached-no-crash.html may fail with other JS engines.

  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/dom/navigator-detached-no-crash.html:
1:41 PM Changeset in webkit [41086] by christian@webkit.org
  • 2 edits in trunk

Add GLIB_LIBS to unit test library flags.

Rubber-stamped by Holger Freyther.

1:36 PM Changeset in webkit [41085] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24034
Fix up Selection->VisibleSelection change.

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection to VisibleSelection.
1:33 PM Changeset in webkit [41084] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24041
Correct Skia type conversion issues, fix Chromium Linux build.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.
12:35 PM Changeset in webkit [41083] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-02-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Simplified .call and .apply in preparation for optimizing them. Also,
a little cleanup.

  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall): No need to do any specific conversion on 'this' -- op_convert_this will do it if necessary.
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): Slightly relaxed the rules on toThisObject to allow for 'undefined', which can be passed through .call and .apply.
12:12 PM Changeset in webkit [41082] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-02-19 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20531
Chromium-part follow-up to the patch landed in r40636
for bug 20531.
Remove a static member function alternateFamilyName
from Chromium's Win/Linux ports of FontCache. In r40636,
alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
So, there's no more need for the static member function per
platform.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:
  • platform/graphics/chromium/FontCacheLinux.cpp:
11:40 AM Changeset in webkit [41081] by levin@chromium.org
  • 3 edits in trunk/JavaScriptCore

2009-02-19 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23976: MessageQueue needs a way to wait for a message that satisfies an arbitrary criteria.
<​https://bugs.webkit.org/show_bug.cgi?id=23976>

  • wtf/Deque.h: (WTF::Deque<T>::findIf):
  • wtf/MessageQueue.h: (WTF::MessageQueue<T>::waitForMessageFiltered):
11:20 AM Changeset in webkit [41080] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-02-19 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Call documentWillBecomeInactive() from Document::detach to ensure that
media elements are shut down, because they may be kept alive by references
from JS past document teardown.

documentWillBecomeInactive() calls renderView()->willMoveOffscreen(), so no
need to do that in detach() as well.

We no longer need to call documentWillBecomeInactive() from ~Page() (which
was added for <​https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
supersedes that change.

  • dom/Document.cpp: (WebCore::Document::detach):
  • page/Page.cpp: (WebCore::Page::~Page):
11:19 AM Changeset in webkit [41079] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24012
Clarify objective of the test and clean up.

  • fast/forms/inline-ignored-on-legend-expected.txt:
  • fast/forms/inline-ignored-on-legend.html:
11:14 AM Changeset in webkit [41078] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24028
Fix up Skia path changes.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
  • platform/graphics/skia/PathSkia.cpp: (WebCore::boundingBoxForCurrentStroke): Changed call name.
7:37 AM Changeset in webkit [41077] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

Ignore ports on local URLs. This fixes a regression in
fast/loader/file-URL-with-port-number.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
7:18 AM Changeset in webkit [41076] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

Make setPort remove port if 0 is given to it, as promised by the
comment in KURL's header.

  • platform/KURL.cpp: (WebCore::KURL::setPort):

Feb 18, 2009:

7:36 PM Changeset in webkit [41075] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

7:35 PM Changeset in webkit [41074] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.15.2

New tag.

7:34 PM Changeset in webkit [41073] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

7:34 PM Changeset in webkit [41072] by mrowe@apple.com
  • 7 edits in branches/Safari-6528

Merge r41071.

6:04 PM Changeset in webkit [41071] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Brady Eidson.

  • WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle

The crash results from re-entry into
CSSMutableStyleDeclaration::setCssText, which in turn is caused by
the first style change causing a cached image to load from the memory
cache, causing load delegate dispatch, and iChat's delegate method
calling back into WebKit.

The workaround is to use defer delegate callbacks for memory cache. In
this case, deferring callbacks during image load event dispatch was
found to be sufficient.

The crash is a regression. See also the discussion in
<​https://bugs.webkit.org/show_bug.cgi?id=22521>.

  • WebCore.base.exp: Added Settings::setNeedsIChatMemoryCacheCallsQuirk().
  • dom/Document.cpp: (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is enabled, defer memory cache callbacks during image load event dispatch.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsIChatMemoryCacheCallsQuirk. (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this setter.
  • page/Settings.h: (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.

WebKit/mac:

Reviewed by Brady Eidson.

  • WebKit part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Activate the WebCore workaround for this crash in iChat.
5:46 PM Changeset in webkit [41070] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6542390>


There's no need to call setDefersLoading here - we already defer anything a plug-in can do that
would cause a load to begin.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
4:13 PM Changeset in webkit [41069] by Dimitri Glazkov
  • 2 edits
    1 add
    3 deletes in trunk/LayoutTests

2009-02-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24012
Convert inline-ignored-on-legend to text-only test.

  • fast/forms/inline-ignored-on-legend-expected.txt: Added.
  • fast/forms/inline-ignored-on-legend.html: Changed to text-only.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Removed.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Removed.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Removed.
3:26 PM Changeset in webkit [41068] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-02-18 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23974: Deque::Remove would be a useful method.
<​https://bugs.webkit.org/show_bug.cgi?id=23974>

Add Deque::remove and DequeIteratorBase<T>::operator=.

Why was operator= added? Every concrete iterator (DequeIterator..DequeConstReverseIterator)
was calling DequeIteratorBase::assign(), which called Base::operator=(). Base::operator=()
was not implemented. This went unnoticed because the iterator copy code has been unused.

  • wtf/Deque.h: (WTF::Deque<T>::remove): (WTF::DequeIteratorBase<T>::removeFromIteratorsList): (WTF::DequeIteratorBase<T>::operator=): (WTF::DequeIteratorBase<T>::~DequeIteratorBase):
2:59 PM Changeset in webkit [41067] by Adam Roben
  • 6 edits in trunk

Add SPI to get WebKit's custom pointing-hand cursor

WebCore:

Export WebCore::handCursor and Cursor.h

Reviewed by John Sullivan.

  • WebCore.base.exp: Added WebCore::handCursor.
  • WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.

WebKit/mac:

Add SPI to get WebKit's custom pointing-hand cursor

Reviewed by John Sullivan.

  • WebView/WebView.mm: (+[WebView _pointingHandCursor]): Added. Returns the custom pointing-hand cursor that WebKit uses.
  • WebView/WebViewPrivate.h: Added +_pointingHandCursor.
2:12 PM Changeset in webkit [41066] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-18 Ojan Vafai <​ojan@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23992
REGRESSION: crash on windows loading ​http://www.stickam.com/liveStreams.do

Unable to reduce to a layout test.

  • page/Frame.cpp: (WebCore::Frame::contentRenderer):
2:07 PM Changeset in webkit [41065] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-18 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23861
Stroke font outlines on chromium linux

TEST=LayoutTests/svg/custom/pointer-events-text.svg

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
2:05 PM Changeset in webkit [41064] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-18 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23860
Resync some graphics/skia files with their chromium counterparts

This comes from chromium patches <​http://codereview.chromium.org/17633>
and <​http://codereview.chromium.org/17454>

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::addPath): (PlatformContextSkia::currentPath):
  • platform/graphics/skia/PlatformContextSkia.h:
1:56 PM Changeset in webkit [41063] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed.

Build fix after r41060.

  • GNUmakefile.am:
12:19 PM Changeset in webkit [41062] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Rubber-stamped by Alexey Proskuryakov.

Add a few ignores to make-js-test-wrappers.

  • Scripts/make-js-test-wrappers:
11:20 AM Changeset in webkit [41061] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24005
Add an include to fix Chromium build.

  • page/animation/AnimationController.cpp: Add UnusedParam.h include.
11:18 AM Changeset in webkit [41060] by kov@webkit.org
  • 6 edits in trunk

2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Fix symbols.filter location, and add other missing files to the
autotools build, so that make dist works.

  • GNUmakefile.am:
8:45 AM Changeset in webkit [41059] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-18 Zan Dobersek <​zandobersek@gmail.com>

Rubber-stamped by Holger Hans Peter Freyther.

Allow POST method for local requests.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
8:36 AM Changeset in webkit [41058] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-02-18 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Hans Peter Freyther.

Use KURL in startGio instead of passing a string with the URL, so
that we can handle removing refs and queries more elegantly. This
is fixing more regressions that came from the curl->soup switch.

Original work by Zan Dobersek.

  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::startGio):
7:02 AM Changeset in webkit [41057] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp

The implementation is needed to have synchronous loading, e.g. for
JavaScript interaction. This is fixing various regressions that
came from the curl->soup switch.

6:58 AM Changeset in webkit [41056] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-17 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Alexey Proskuryakov.

Prepend ​file:// to the test result filename to make
GtkLauncher display the result page.

  • Scripts/run-webkit-tests:
4:17 AM Changeset in webkit [41055] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-02-18 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=23989

Based on a patch by Bo Yang <​techrazy.yang@gmail.com>

Make the cursor cache global, that's all we really need and
otherwise we can miss cursor transitions in some situations (see
the bug for one testcase). Also remove some now useless code.

  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setCursor):
Note: See TracTimeline for information about the timeline view.