Timeline
Jun 21, 2009:
- 11:35 PM Changeset in webkit [44931] by
-
- 6 edits in trunk
Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>
Reviewed by Darin Adler
Add support for the standard Date.toJSON function.
- 11:17 PM Changeset in webkit [44930] by
-
- 4 edits in trunk/WebCore
2009-06-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
- 10:08 PM Changeset in webkit [44929] by
-
- 3 edits3 adds in trunk
Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>
Reviewed by Sam Weinig
Add support for Date.toISOString.
- 9:59 PM Changeset in webkit [44928] by
-
- 7 edits3 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
Test: fast/dom/event-attribute-availability.html
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
- fast/dom/event-attribute-availability-expected.txt: Added.
- fast/dom/event-attribute-availability.html: Added.
- fast/dom/resources/event-attribute-availability.js: Added.
- 6:39 PM Changeset in webkit [44927] by
-
- 4 edits3 adds in trunk
WebCore:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fix to enable XSSAuditor on child windows.
Test: http/tests/security/xssAuditor/link-opens-new-window.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
- page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.
LayoutTests:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor (if enabled) prevents script execution in child window.
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- http/tests/security/xssAuditor/link-opens-new-window.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
- 5:23 PM Changeset in webkit [44926] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- make repaint tests more reliable when run in Safari
- fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
- 5:03 PM Changeset in webkit [44925] by
-
- 2 edits in trunk/WebKitTools
Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(userAgentStringForSparkle):
(initializeSparkle):
- 4:32 PM Changeset in webkit [44924] by
-
- 2 edits in trunk/JavaScriptCore
Fix build by removing dead code.
- 4:02 PM Changeset in webkit [44923] by
-
- 7 edits3 adds in trunk
Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>
Reviewed by Darin Adler and Cameron Zwarich.
Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.
- 3:46 PM Changeset in webkit [44922] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative build fix for windows).
Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.
- wtf/Assertions.cpp:
- 3:16 PM Changeset in webkit [44921] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative windows build fix (idea by Mark Rowe).
- WebCore.vcproj/WebCore.vcproj:
- 3:03 PM Changeset in webkit [44920] by
-
- 2 edits2 adds in trunk/WebKitTools
Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
- WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
- 3:02 PM Changeset in webkit [44919] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative gtk build fix).
- GNUmakefile.am:
- 2:56 PM Changeset in webkit [44918] by
-
- 3 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative tiger build fix and a windows build fix.
More fixes may still be in order.
- WebCore.vcproj/WebCoreCommon.vsprops:
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- 2:46 PM Changeset in webkit [44917] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative tiger build fix).
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
- 2:32 PM Changeset in webkit [44916] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
- dom/MessagePort.h:
- dom/MessagePortProxyWrapper.h:
- dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
- dom/default/MessagePortProxy.h:
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
New tests for MessagePort GC cases that weren't previously covered.
- fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
- fast/events/message-channel-gc-4.html-disabled: Added.
- 2:32 PM Changeset in webkit [44915] by
-
- 23 edits1 move7 adds2 deletes in trunk
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.
- wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):
Added API to test whether the queue was empty before adding an element.
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.
Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.
Created a thread-safe default PlatformMessagePortChannel implementation.
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.
- GNUMakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added MessagePortChannel/PlatformMessagePortChannel files.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
Changed ports to not mark their entangled pair as reachable, per the spec.
- bindings/v8/custom/V8MessagePortCustom.cpp:
- dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):
Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
- dom/MessagePort.h:
Renamed isQueueOpen() to started().
- dom/MessagePort.idl:
Removed startConversation and onclose.
- dom/MessagePortProxy.h: Removed.
- dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
- dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):
Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):
- dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
Renamed isQueueOpen() to started().
- dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
- dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.
- fast/events/message-channel-gc-2-expected.txt:
- fast/events/message-channel-gc-2.html-disabled:
- fast/events/message-channel-gc-3-expected.txt:
- fast/events/message-channel-gc-3.html-disabled:
- fast/events/message-channel-gc-expected.txt:
- fast/events/message-channel-gc.html-disabled:
- fast/events/message-port-clone-expected.txt: Added.
- fast/events/message-port-clone.html-disabled: Added.
- fast/events/message-port-expected.txt:
- fast/events/message-port-no-wrapper-expected.txt: Added.
- fast/events/message-port-onclose-expected.txt: Removed.
- fast/events/message-port-onclose.html-disabled: Removed.
- fast/events/message-port.html-disabled:
- 1:56 PM Changeset in webkit [44914] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
Test: fast/css/resize-single-axis.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
- fast/css/resize-single-axis-expected.txt: Added.
- fast/css/resize-single-axis.html: Added.
- 1:47 PM Changeset in webkit [44913] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel
Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
Test: fast/events/event-trace.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
- fast/events/event-trace-expected.txt: Added.
- fast/events/event-trace.html: Added.
- 1:16 PM Changeset in webkit [44912] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
Test: fast/css/resize-value-compared.html
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
- fast/css/resize-value-compared-expected.txt: Added.
- fast/css/resize-value-compared.html: Added.
- 12:19 AM Changeset in webkit [44911] by
-
- 2 edits in trunk/LayoutTests
2009-06-21 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip one more test.
Jun 20, 2009:
- 11:19 PM Changeset in webkit [44910] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip some new tests.
- 11:15 PM Changeset in webkit [44909] by
-
- 2 edits in trunk/WebKit/win
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 10:42 PM Changeset in webkit [44908] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Can't test this bug with an automated layout test since it requires b/f caching
- manual-tests/animated-gif-bfcache-crash.html: Added.
- manual-tests/resources/containsAnimatedGif.html: Added.
Adding checks for hostWindow() since there is no guarantee that the Page is alive
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):
LayoutTests:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html
- http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
- 7:43 PM Changeset in webkit [44907] by
-
- 2 edits in trunk/WebKit/win
Roll out the Windows portion of r44905 as it broke the build.
- 7:05 PM Changeset in webkit [44906] by
-
- 6 edits in trunk
WebCore:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent
- page/DOMWindow.idl:
LayoutTests:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Test writing to parent and top.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 4:07 PM Changeset in webkit [44905] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
WebKit/win:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 2:57 PM Changeset in webkit [44904] by
-
- 6 edits in trunk
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 2:56 PM Changeset in webkit [44903] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517
Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing
- tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
- 2:54 PM Changeset in webkit [44902] by
-
- 3 edits2 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
Reviewed by Dan Bernstein.
We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.
Test: editing/selection/user-drag-element-and-user-select-none.html
- dom/Node.cpp:
(WebCore::Node::canStartSelection):
Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
- editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
- editing/selection/user-drag-element-and-user-select-none.html: Added.
- 1:34 PM Changeset in webkit [44901] by
-
- 5 edits in trunk
WebCore:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.
LayoutTests:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
- editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
- 11:06 AM Changeset in webkit [44900] by
-
- 2 edits in trunk/JavaScriptCore
Fix namespace comment in SegmentedVector.h
- wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
- 6:27 AM Changeset in webkit [44899] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.
- wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
- 6:20 AM Changeset in webkit [44898] by
-
- 3 edits1 add in trunk
2009-06-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Initial test case for loading statuses.
- tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
- 6:14 AM Changeset in webkit [44897] by
-
- 8 edits1 move in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"
Additional build file updates by David Kilzer.
- GNUmakefile.am: Updated path to SegmentedVector.h.
- JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
- JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
- bytecompiler/BytecodeGenerator.h: Updated #include path to
- SegmentedVector.h and prepended WTF
- namespace to its use.
- parser/Lexer.h: Ditto.
- wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
- 5:34 AM Changeset in webkit [44896] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Jan Alonzo.
Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.
- webkit/webkitwebframe.h:
- 2:48 AM Changeset in webkit [44895] by
-
- 2 edits in trunk/WebCore
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by NOBODY.
Speculative Qt build fix - add HTMLDataGridColElement to the build script.
- WebCore.pro:
- 2:20 AM Changeset in webkit [44894] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
- bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
- 1:11 AM Changeset in webkit [44893] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip new accessibility test, we still lack and accessibilityController.
- platform/gtk/Skipped:
- 1:00 AM Changeset in webkit [44892] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
We don't seem to support these new HTTP tests either, skip them.
- platform/gtk/Skipped:
- 12:53 AM Changeset in webkit [44891] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip test that requires eventSender.
- platform/gtk/Skipped:
Jun 19, 2009:
- 11:21 PM Changeset in webkit [44890] by
-
- 2 edits in trunk/WebKit/win
2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit
Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.
- WebView.cpp: (WebView::initWithFrame):
- 6:29 PM Changeset in webkit [44889] by
-
- 9 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 6:29 PM Changeset in webkit [44888] by
-
- 2 edits in trunk/WebKitTools
2009-06-19 Darin Adler <Darin Adler>
- Scripts/do-webcore-rename: More renaming ideas.
- 6:19 PM Changeset in webkit [44887] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
- jit/JIT.h:
- jit/JITInlineMethods.h:
- 6:07 PM Changeset in webkit [44886] by
-
- 12 edits in trunk/JavaScriptCore
2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 5:52 PM Changeset in webkit [44885] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fixed the changelog, copied the same thing into both on accident.
- 5:49 PM Changeset in webkit [44884] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix armv7 JIT build issues.
Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.
- Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
- Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 5:35 PM Changeset in webkit [44883] by
-
- 7 edits1 add in trunk
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
- 5:27 PM Changeset in webkit [44882] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-19 Ryosuke Niwa <rniwa@google.com>
Reviewed by Maciej Stachowiak.
This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.
- 4:54 PM Changeset in webkit [44881] by
-
- 2 edits in trunk/WebCore
Fixed a build error, which only shows up in the i386 compile
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 4:35 PM Changeset in webkit [44880] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.
When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
- 4:14 PM Changeset in webkit [44879] by
-
- 2 edits in trunk/WebCore
Adding XSSAuditor.cpp to the wx build.
- 3:43 PM Changeset in webkit [44878] by
-
- 2 edits in trunk/WebCore
If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 3:32 PM Changeset in webkit [44877] by
-
- 5 edits in trunk/WebCore
2009-06-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>
Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.
This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.
- bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
- 3:23 PM Changeset in webkit [44876] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan
<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent
Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.
- 3:16 PM Changeset in webkit [44875] by
-
- 2 edits in trunk/WebCore
2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix. Adding missing HTMLDataGrid* files to the build.
- GNUmakefile.am:
- 2:49 PM Changeset in webkit [44874] by
-
- 7 edits in trunk/WebCore
2009-06-19 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.
This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
- 2:31 PM Changeset in webkit [44873] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Blind attempt at build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:09 PM Changeset in webkit [44872] by
-
- 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp
Add missed file.
- 2:07 PM Changeset in webkit [44871] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.
- wtf/HashCountedSet.h:
- 1:57 PM Changeset in webkit [44870] by
-
- 6 edits6 adds in trunk
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.
- 1:38 PM Changeset in webkit [44869] by
-
- 6 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.
- WebCore/bindings/js/ScriptController.cpp:
- WebCore/bindings/js/ScriptSourceCode.h:
- WebCore/bindings/v8/ScriptController.cpp:
- WebCore/page/XSSAuditor.cpp:
- WebCore/page/XSSAuditor.h:
- 1:30 PM Changeset in webkit [44868] by
-
- 3 edits1 add in trunk
009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
- wtf/HashCountedSet.h:
- 1:17 PM Changeset in webkit [44867] by
-
- 16 edits3 adds in trunk
WebCore:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColElement.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
- html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
- html/HTMLDataGridColElement.idl: Added.
- html/HTMLDataGridElement.h:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
LayoutTests:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColELement.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:09 PM Changeset in webkit [44866] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.
- runtime/DateConstructor.cpp:
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
- 12:54 PM Changeset in webkit [44865] by
-
- 2 edits in trunk/WebCore
2009-06-19 Chris Evans <scarybeasts@gmail.com>
Reviewed by Eric Seidel.
There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.
- loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
- 12:37 PM Changeset in webkit [44864] by
-
- 4 edits in trunk
Versioning.
- 12:35 PM Changeset in webkit [44863] by
-
- 1 copy in tags/Safari-6531
New tag.
- 11:48 AM Changeset in webkit [44862] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6988973> ScopeChain leak in interpreter builds
Reviewed by Maciej Stachowiak
Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.
- 11:25 AM Changeset in webkit [44861] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.
implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.
- dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
- 11:22 AM Changeset in webkit [44860] by
-
- 2 edits in trunk/WebCore
2009-06-19 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>
- platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
- 11:14 AM Changeset in webkit [44859] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
Test: editing/selection/move-by-line-005.html
The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.
- dom/Position.cpp: (WebCore::searchAheadForBetterMatch):
LayoutTests:
Reviewed by Dave Hyatt.
- text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
- editing/selection/move-by-line-005-expected.txt: Added.
- editing/selection/move-by-line-005.html: Added.
- 10:46 AM Changeset in webkit [44858] by
-
- 2 edits1 add in trunk/WebCore
2009-06-18 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin
Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.
A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- manual-tests/non-bmp.html: Added.
- 10:01 AM Changeset in webkit [44857] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
- 9:52 AM Changeset in webkit [44856] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
- update test results after r44806
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- 8:47 AM Changeset in webkit [44855] by
-
- 3 edits in trunk/WebCore
2009-06-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
V8 Bindings: return proper state from the script stack.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
- 8:34 AM Changeset in webkit [44854] by
-
- 2 edits in trunk/WebCore
2009-06-19 Jessie Berlin <jberlin@apple.com>
Reviewed by Simon Fraser.
Windows build fix.
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 7:28 AM Changeset in webkit [44853] by
-
- 3 edits in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Build fix after 44825.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
- platform/graphics/qt/ImageDecoderQt.h:
- 5:18 AM Changeset in webkit [44852] by
-
- 2 edits in trunk/WebKit/qt
2009-06-19 Daniel Teske <qt-info@nokia.com>
Reviewed by Simon Hausmann.
Remove warnings for QString() constructions from const char *
By explicitly wrapping it with QLatin1String() / QLatin1Char()
- 2:58 AM Changeset in webkit [44851] by
-
- 2 edits in trunk/WebKitTools
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Tor Arne Vestbø.
Only pass --makeargs along if an argument is given.
- 2:23 AM Changeset in webkit [44850] by
-
- 6 edits in trunk
2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>
Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.
Test: fast/canvas/image-object-in-canvas.html:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 2:06 AM Changeset in webkit [44849] by
-
- 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp
Fix copy/paste error.
- 1:57 AM Changeset in webkit [44848] by
-
- 4 edits in trunk/WebCore
2009-06-19 abarth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- 1:29 AM Changeset in webkit [44847] by
-
- 3 edits in trunk/WebKitTools
2009-06-19 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix Windows build.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 1:12 AM Changeset in webkit [44846] by
-
- 35 edits7 adds in trunk
WebCore:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added an experimental reflective XSS filter. The filter is disabled by
default.
Test: http/tests/security/xssAuditor/script-tag.html
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
- page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
- page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):
WebKit/mac:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
WebKit/win:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
WebKitTools:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add support for testing the XSSAuditor.
- DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):
LayoutTests:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added a basic test for the XSSAuditor.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
- http/tests/security/xssAuditor/script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag.html: Added.
- 12:59 AM Changeset in webkit [44845] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 David Levin <levin@chromium.org>
Reviewed by NOBODY (Windows build fix).
Add export for Windows corresponding to OSX export done in r44844.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:10 AM Changeset in webkit [44844] by
-
- 11 edits in trunk/JavaScriptCore
Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>
Reviewed by Gavin "Viceroy of Venezuela" Barraclough.
We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:
- Every native function needs a codeblock to track the link information
- To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
- Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
Jun 18, 2009:
- 10:39 PM Changeset in webkit [44843] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 10:06 PM Changeset in webkit [44842] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Timezone calculation incorrect in Venezuela.
https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3
The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.
No performance impact.
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 10:06 PM Changeset in webkit [44841] by
-
- 3 edits4 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feOffset and objectBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=26441
If we use objectBoundingBox for primitiveUnits, the fractions given
to dx or dy of feOffset must be multiplied with the referenced objects
objectBoundingBox size.
Test: svg/filters/feOffset.svg
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
Test for feOffset with the primitiveUnits objectBoundingBox
and userSpaceOnUse.
- platform/mac/svg/filters/feOffset-expected.checksum: Added.
- platform/mac/svg/filters/feOffset-expected.png: Added.
- platform/mac/svg/filters/feOffset-expected.txt: Added.
- svg/filters/feOffset.svg: Added.
- 10:00 PM Changeset in webkit [44840] by
-
- 6 edits8 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feTile implementation missing
https://bugs.webkit.org/show_bug.cgi?id=26419
Implementation of feTile, a pattern effect for SVG filters. It was
necessary to modify FilterEffect since source inputs need a secial
logic and we have to identify if an effect is a source input.
Tests: svg/batik/filters/feTile.svg
svg/filters/feTile.svg
- platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::isSourceInput):
- platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
- platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
Reviewed by Oliver Hunt.
Added a test of batik and a own one to check behavior of the
new feTile effect in SVG.
- platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
- platform/mac/svg/batik/filters/feTile-expected.png: Added.
- platform/mac/svg/batik/filters/feTile-expected.txt: Added.
- platform/mac/svg/filters/feTile-expected.checksum: Added.
- platform/mac/svg/filters/feTile-expected.png: Added.
- platform/mac/svg/filters/feTile-expected.txt: Added.
- svg/batik/filters/feTile.svg: Added.
- svg/filters/feTile.svg: Added.
- 9:44 PM Changeset in webkit [44839] by
-
- 4 edits4 adds in trunk
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
feMerge implementation
https://bugs.webkit.org/show_bug.cgi?id=26480
Added feMerge to the SVG Filter system.
Test: svg/filters/feMerge.svg
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::uniteChildEffectSubregions): (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
Check the feMerge implementation.
- platform/mac/svg/filters/feMerge-expected.checksum: Added.
- platform/mac/svg/filters/feMerge-expected.png: Added.
- platform/mac/svg/filters/feMerge-expected.txt: Added.
- svg/filters/feMerge.svg: Added.
- 7:32 PM Changeset in webkit [44838] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).
(Reintroducing patch added in r44492, and reverted in r44796.)
Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).
- jit/JITStubs.cpp: (JSC::):
Add ctiOpThrowNotCaught definitions.
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
Change cti_op_throw to always change its return address.
- jit/JITStubs.h:
Add ctiOpThrowNotCaught declaration.
- 6:51 PM Changeset in webkit [44837] by
-
- 2 edits in trunk/WebCore
Speculative Windows build fix.
- page/win/FrameCGWin.cpp: Add missing #include.
- 6:21 PM Changeset in webkit [44836] by
-
- 8 edits in trunk
WebCore:
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=26425
Final refactorings, picking up a few places where BitmapInfo
could be used.
- page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
- platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
WebKit/win:
2009-06-18 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Dave Levin.
Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425
- WebFrame.cpp: (WebFrame::spoolPages):
- WebIconDatabase.cpp: (createDIB):
- WebKit.vcproj/WebKit.sln:
- WebNodeHighlight.cpp: (WebNodeHighlight::update):
- WebView.cpp: (WebView::ensureBackingStore):
- 6:20 PM Changeset in webkit [44835] by
-
- 4 edits2 adds in trunk
Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522
- 6:18 PM Changeset in webkit [44834] by
-
- 2 edits in trunk/WebCore
wx build fix after recent RenderTheme changes.
- 6:14 PM Changeset in webkit [44833] by
-
- 7 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part two
Attempt to minimize diff of following functional change by first landing
non-functional change to:
- Make readUintX() public and static (since they will need to be once BMPImageReader is included in *ImageDecoder via composition rather than inheritance). Add wrappers in each class so callers can be simpler. In the next patch, these wrappers will be beefed up slightly and the callers will get even simpler.
- Change direct setting of m_failed to use setFailed(), since in the next patch much of this code won't even have direct access to m_failed
- Add a helper function in ICOImageDecoder to determine the image type instead of simply doing it inline
- Rewrap lines that used to be <=80 cols and slipped over it during the original landing of these decoders
- Other misc. changes, e.g. adding constructor definitions, reordering functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no functional effect but minimize the subsequent diff for readability
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::getInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16Helper): (WebCore::BMPImageReader::readUint32Helper): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::getComponent): (WebCore::BMPImageReader::setI): (WebCore::BMPImageReader::setRGBA): (WebCore::BMPImageReader::fillRGBA):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::decodeImage): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::isBetterEntry): (WebCore::ICOImageDecoder::processImageType):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
- 3:52 PM Changeset in webkit [44832] by
-
- 2 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Fix build bustage.
- platform/image-decoders/gif/GIFImageDecoder.h:
- 3:34 PM Changeset in webkit [44831] by
-
- 11 edits in trunk
2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
- Exposed functions now needed by WebCore.
- JavaScriptCore.exp:
WebCore:
2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
Convert intptr_t to Strings so that we don't loose bits in the
conversion to JS. Previously they were being put into 32bit ints.
- inspector/InspectorController.cpp: Convert the String back to an intptr_t. (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint):
- inspector/InspectorController.h:
- inspector/InspectorController.idl: Use strings in JS to avoid 32bit truncation.
- inspector/InspectorFrontend.cpp: Make the intptr_t into a String. (WebCore::InspectorFrontend::parsedScriptSource):
- platform/text/PlatformString.h: Implemented the necessary conversion functions to be able to convert to and from an intptr_t.
- platform/text/String.cpp: Ditto. (WebCore::String::toIntPtrStrict): (WebCore::String::toIntPtr): (WebCore::charactersToIntPtrStrict): (WebCore::charactersToIntPtr):
- platform/text/StringImpl.cpp: Ditto. (WebCore::StringImpl::toIntPtrStrict): (WebCore::StringImpl::toIntPtr):
- platform/text/StringImpl.h: Ditto.
- 3:15 PM Changeset in webkit [44830] by
-
- 3 edits2 adds8 deletes in trunk/LayoutTests
2009-06-18 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/insertHTML-expected.txt: Added.
- editing/execCommand/insertHTML.html:
- editing/execCommand/switch-list-type-expected.txt: Added.
- editing/execCommand/switch-list-type.html:
- platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
- platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
- platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
- platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
- platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
- platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.
- 3:04 PM Changeset in webkit [44829] by
-
- 3 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Final cleanups in this refactoring:
(1) Move WindowsBitmap implementation from CG-specific file to
the platform-common GraphicsContextWin.cpp, since it is
equally useful on both platforms.
(2) Revise the TransformationMatrix logic as suggested by
Adam Roben in his review comments to Part #2 of this
refactoring.
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- 2:44 PM Changeset in webkit [44828] by
-
- 3 edits in trunk/WebKit/mac
2009-06-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6926859>
NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen
When inverting Y, use the height of the first screen instead of the screen the window is on.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::mouseEvent):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- 2:39 PM Changeset in webkit [44827] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez and Christian Dywan.
Add a new load status to report that the first visually non-empty
layout has been done.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- webkit/webkitwebframe.h:
- 2:39 PM Changeset in webkit [44826] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Fix parameters of navigation-policy-decision-requested callback,
to be correct in number and type
- tests/testhttpbackend.c: (navigation_policy_decision_requested_cb):
- 2:29 PM Changeset in webkit [44825] by
-
- 12 edits in trunk/WebCore
2009-06-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part one
Make isSizeAvailable non-const, since it's not logically const (it
triggers lazy decoding), and simplify all the implementations (without
changing behavior; just make less verbose). Remove some other
inappropriate consts, which enables the removal of all the mutable
declarations in the decoders.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::isSizeAvailable):
- platform/image-decoders/ico/ICOImageDecoder.h:
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::decode):
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::decode):
- platform/image-decoders/png/PNGImageDecoder.h:
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::isSizeAvailable): (WebCore::XBMImageDecoder::frameBufferAtIndex): (WebCore::XBMImageDecoder::decode):
- platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.
- 2:25 PM Changeset in webkit [44824] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
2009-06-18 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5207369-expected.txt: Added.
- editing/execCommand/5207369.html:
- editing/execCommand/5210032-expected.txt: Added.
- editing/execCommand/5210032.html:
- editing/execCommand/5432254-1-expected.txt: Added.
- editing/execCommand/5432254-1.html:
- platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
- platform/mac/editing/execCommand/5207369-expected.png: Removed.
- platform/mac/editing/execCommand/5207369-expected.txt: Removed.
- platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
- platform/mac/editing/execCommand/5210032-expected.png: Removed.
- platform/mac/editing/execCommand/5210032-expected.txt: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
- platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5207369-expected.txt: Removed.
- platform/qt/editing/execCommand/5210032-expected.txt: Removed.
- platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.
- 2:21 PM Changeset in webkit [44823] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5142012-3-expected.txt: Added.
- editing/execCommand/5142012-3.html:
- editing/execCommand/5144139-1-expected.txt: Added.
- editing/execCommand/5144139-1.html:
- editing/execCommand/5164796-expected.txt: Added.
- editing/execCommand/5164796.html:
- platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
- platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
- platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
- platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
- platform/mac/editing/execCommand/5164796-expected.png: Removed.
- platform/mac/editing/execCommand/5164796-expected.txt: Removed.
- platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
- platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5164796-expected.txt: Removed.
- 2:13 PM Changeset in webkit [44822] by
-
- 4 edits3 adds12 deletes in trunk/LayoutTests
Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests.
This
fixes the bug 26336 partially.
- editing/execCommand/4916583-expected.txt: Added.
- editing/execCommand/4916583.html:
- editing/execCommand/5119244-expected.txt: Added.
- editing/execCommand/5119244.html:
- editing/execCommand/5120591-expected.txt: Added.
- editing/execCommand/5120591.html:
- platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
- platform/mac/editing/execCommand/4916583-expected.png: Removed.
- platform/mac/editing/execCommand/4916583-expected.txt: Removed.
- platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
- platform/mac/editing/execCommand/5119244-expected.png: Removed.
- platform/mac/editing/execCommand/5119244-expected.txt: Removed.
- platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
- platform/mac/editing/execCommand/5120591-expected.png: Removed.
- platform/mac/editing/execCommand/5120591-expected.txt: Removed.
- platform/qt/editing/execCommand/4916583-expected.txt: Removed.
- platform/qt/editing/execCommand/5119244-expected.txt: Removed.
- platform/qt/editing/execCommand/5120591-expected.txt: Removed.
- 1:47 PM Changeset in webkit [44821] by
-
- 6 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Move some common functions out of platform files and into
the common implementation.
https://bugs.webkit.org/show_bug.cgi?id=26425.
Add a new platform context method (flush) so that the
getWindowsContext method can be consolidated into the common
GraphicsContextWin.cpp file.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::flush):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::flush):
- platform/graphics/win/GraphicsContextCGWin.cpp: Remove getWindowContext method.
- platform/graphics/win/GraphicsContextCairoWin.cpp: Remove getWindowContext method and fillWithClearColor methods.
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::fillWithClearColor): Moved from *CairoWin.cpp (WebCore::GraphicsContext::getWindowsContext): Moved from *CairoWin.cpp
- 1:44 PM Changeset in webkit [44820] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::loadDone): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static function loadDone to emit "load-done" and update the status and update the relevent places. We missed some status notifications before.
- 1:30 PM Changeset in webkit [44819] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Be consistent in always using the term URI instead of URL in the
documentation of WebKitWebView signals.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 1:28 PM Changeset in webkit [44818] by
-
- 2 edits in trunk/WebCore
2009-06-18 Ojan Vafai <ojan@chromium.org>
Reviewed by Oliver Hunt.
Remove code that I accidentally committed in r44811.
- editing/markup.cpp: (WebCore::createMarkup):
- 1:25 PM Changeset in webkit [44817] by
-
- 3 edits2 adds in trunk
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/6983207> Non-layer content is not re-rendered when transition
starts sometimes (with hardware acceleration).
When deciding which RenderLayers should be composited, when a layer goes into
compositing mode we repaint the old location. However, we did that before
we'd looked at all the factors that may force a layer to composite, so missed
some cases. Fix by doing the repaint once we really know whether it's going
to composite.
Test: compositing/repaint/become-overlay-composited-layer.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 12:58 PM Changeset in webkit [44816] by
-
- 2 edits8 adds in trunk/LayoutTests
Reviewed by Maciej Stachowiak and Dave Levin.
https://bugs.webkit.org/show_bug.cgi?id=26510
Add tests for authentication behavior with cross-origin XMLHttpRequest
- http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
- http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
- http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
- http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
- platform/mac-tiger/Skipped:
- 12:21 PM Changeset in webkit [44815] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2009-06-18 Darin Adler <Darin Adler>
Rubber stamped by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression tests. The close method can be called on a window that's already closed so we can't assert here.
- 12:19 PM Changeset in webkit [44814] by
-
- 3 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
the Tiger build where QTMovieLayer does not exist.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering): (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
- 12:18 PM Changeset in webkit [44813] by
-
- 12 edits in trunk
2009-06-17 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429
For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."
- runtime/Collector.cpp: (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
- runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
- runtime/CommonIdentifiers.h: Ditto.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
- runtime/JSGlobalData.h: Added firstStringifierToMark.
- runtime/JSONObject.cpp: Cut down the includes to the needed ones only. (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string objects to get their number and string values. (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used to wrap an identifier or integer so we don't have to do any work unless we actually call a replacer. (JSC::ReplacerPropertyName::value): Added. (JSC::gap): Added. Helper function for the Stringifier constructor. (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added. The class is used to wrap an identifier or integer so we don't have to allocate a number or string until we actually call toJSON or a replacer. (JSC::PropertyNameForFunctionCall::asJSValue): Added. (JSC::Stringifier::Stringifier): Updated and moved out of the class definition. Added code to hook this into a singly linked list for marking. (JSC::Stringifier::~Stringifier): Remove from the singly linked list. (JSC::Stringifier::mark): Mark all the objects in the holder stacks. (JSC::Stringifier::stringify): Updated. (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit. (JSC::Stringifier::toJSON): Renamed from toJSONValue. (JSC::Stringifier::appendStringifiedValue): Renamed from stringify. Added code to use the m_holderStack to do non-recursive stringify of objects and arrays. This code also uses the timeout checker since in pathological cases it could be slow even without calling into the JavaScript virtual machine. (JSC::Stringifier::willIndent): Added. (JSC::Stringifier::indent): Added. (JSC::Stringifier::unindent): Added. (JSC::Stringifier::startNewLine): Added. (JSC::Stringifier::Holder::Holder): Added. (JSC::Stringifier::Holder::appendNextProperty): Added. This is the function that handles the format of arrays and objects. (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom of the file so the JSONObject class is not interleaved with the Stringifier class. (JSC::JSONObject::markStringifiers): Added. Calls mark. (JSC::JSONProtoFuncStringify): Streamlined the code here. The code to compute the gap string is now a separate function.
- runtime/JSONObject.h: Made everything private. Added markStringifiers.
LayoutTests:
2009-06-17 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429
- fast/js/JSON-stringify-expected.txt: Updated.
- fast/js/resources/JSON-stringify.js: Changed the infinite object and infinite array tests to instead just test something a fixed number of levels deep. Otherwise we end up with an infinite loop in the test, which would lead to the slow-script dialog in the production web browser. Also raised the number from 512 to 2048 since there's no fixed limit any more.
- 12:14 PM EFLWebKit edited by
- (diff)
- 12:06 PM Changeset in webkit [44812] by
-
- 2 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::currentRenderingMode): (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
- 11:58 AM Changeset in webkit [44811] by
-
- 6 edits3 adds in trunk
2009-06-17 Erik Arvidsson <arv@chromium.org>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=15189
Adds the HTML5 input event support for textarea.
Also, moves the oninput attribute parse handling to HTMLElement so that
it can be set on any HTML element so that bubbling events can be handled
using HTML attribute handlers.
Test: fast/forms/textarea-input-event.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
- 11:53 AM Changeset in webkit [44810] by
-
- 6 edits in trunk/WebCore
2009-06-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Share code between filterEffects
https://bugs.webkit.org/show_bug.cgi?id=26479
Share more code of filter effects. The imageBuffer creation can move to
FilterEffect ant every effect asks for the GraphicsContext. Move the
drawingRect calculation to FilterEffect.
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingRect): (WebCore::FilterEffect::getEffectContext):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- 11:52 AM Changeset in webkit [44809] by
-
- 14 edits in trunk/WebCore
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Support hardware-accelerationed rendering of video elements.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): (WebCore::HTMLMediaElement::mediaPlayerRepaint): Just move these methods to group the render-related methods together.
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Call out method to ask the RenderLayerCompositor if presentation of this video
can be acclerated. It might say no, if, for example, the video has a reflection.
(WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.
- html/HTMLMediaElement.h: Reordered the rendering-related methods, and added two methods related to video acceleration.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::acceleratedRenderingStateChanged): Called by the rendering system when it determines that the video must go into, or fall off of the hardware-accelerated path.
(WebCore::MediaPlayer::supportsAcceleratedRendering):
Method to say whether the media engine supports accelerated rendering.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): (WebCore::MediaPlayerClient::mediaPlayerSizeChanged): Moved.
(WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
(WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
New methods to ask the client if the rendering system can support accelerated
rendering, and to get a GraphicsLayer to plug the movie layer into.
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged): Forwarding methods from MediaPlayer.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::destroyQTMovieLayer): Methods to create and destroy the QTMovieLayer.
(WebCore::MediaPlayerPrivate::currentRenderingMode):
(WebCore::MediaPlayerPrivate::preferredRenderingMode):
Methods to clarify the code that decides which of the 3 rendering modes to use.
(WebCore::MediaPlayerPrivate::setUpVideoRendering):
Changed to use the new rendering mode methods.
(WebCore::MediaPlayerPrivate::tearDownVideoRendering):
Destroy the layer if we have one.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
Small utility method.
(WebCore::MediaPlayerPrivate::updateStates):
Move the call to setUpVideoRendering() to before we send out the state notifications,
so that we will have created the rendering objects already.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
Return true if we have QTMovieLayer.
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
We've been told that we went into or out of accelerated mode; maybe reset
the renderer, and set the layer if we have to.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged): We may need to udpate compositing layers if the video went into accelerated mode.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseDirectCompositing): Add smarts to deal with video, which allows us to avoid extra backing store.
(WebCore::RenderLayerBacking::contentsBox):
Use the videoBox to use the content layer for video layers.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): Poke the RenderVideo if the state changed.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Handle an edge case when the video element itself is a stacking context
because of opacity or transform.
(WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
Allow video to throw us into compositing mode if the media engine supports it.
- rendering/RenderLayerCompositor.h: New methods related to video.
- rendering/RenderVideo.h:
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call rendererContentChanged() to give the compositor a change to throw the video into compositing mode.
(WebCore::RenderVideo::supportsAcceleratedRendering):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::videoGraphicsLayer):
Methods to allow the MediaPlayer to do rendering-related stuff via the media element.
- 11:40 AM Changeset in webkit [44808] by
-
- 4 edits4 adds in trunk
Reviewed by Niko.
https://bugs.webkit.org/show_bug.cgi?id=26385
Root SVG element is not checked on requiredFeatures, requiredExtension like other elements
Also do the isValid check for outer <svg>.
Test: svg/custom/outer-svg-unknown-feature.svg
- 11:08 AM Changeset in webkit [44807] by
-
- 2 edits in trunk/LayoutTests
2009-06-18 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
New expected results after making <video> elements get RenderLayers.
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- 10:54 AM Changeset in webkit [44806] by
-
- 6 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
Test: fast/forms/search-vertical-alignment.html
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): Vertically center the
the search field's inner block.
LayoutTests:
Reviewed by Darin Adler.
- test and updated result for <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on apple.com cuts entered text
- fast/forms/search-vertical-alignment.html: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
- platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
- platform/mac/fast/forms/search-zoomed-expected.checksum:
- platform/mac/fast/forms/search-zoomed-expected.png:
- platform/mac/fast/forms/search-zoomed-expected.txt:
- 9:30 AM EFLWebKit edited by
- (diff)
- 9:28 AM EFLWebKit edited by
- (diff)
- 8:08 AM Changeset in webkit [44805] by
-
- 2 edits in trunk/WebCore
2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Fix compilation with Symbian WINSCW compiler, which produced
multiple definitions of the CSSPrimitiveValue conversion operators.
It turns out that they are defined inline but not declared inline.
Adding the inline keyword to the declaration fixes the build.
- 7:45 AM Changeset in webkit [44804] by
-
- 2 edits in trunk/WebKit/qt
2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed by Simon Hausmann.
Fixed MinGW compilation.
- 7:41 AM Changeset in webkit [44803] by
-
- 4 edits in trunk
2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausman.
Clarify in docs how to compile with debug information.
- 7:40 AM EFLWebKit edited by
- (diff)
- 6:42 AM Changeset in webkit [44802] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] When writing an URL to the clipboard, save the corresponding title
in the mime data as well.
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeURL):
- 6:40 AM Changeset in webkit [44801] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jakub Wieczorek <faw217@gmail.com>
[Qt] Fix build. Add HTMLDataGridElement.
- WebCore.pro:
- 3:25 AM Changeset in webkit [44800] by
-
- 2 edits in trunk/WebCore
2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix.
Add HTMLDataGridElement header and IDL to the build script.
- GNUmakefile.am:
- 12:55 AM Changeset in webkit [44799] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454
Test: fast/parser/eightdigithexentity.html
- html/HTMLTokenizer.cpp: fix off-by-ones.
LayoutTests:
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454
- fast/parser/eightdigithexentity-expected.txt: Added.
- fast/parser/eightdigithexentity.html: Added.
- 12:08 AM Changeset in webkit [44798] by
-
- 2 edits in trunk/WebCore
2009-06-18 David Levin <levin@chromium.org>
Fix chromium linux build.
Fixes a mistake that happened during the complicated merge for
landing r44775, r44776, r44777.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::create):
Jun 17, 2009:
- 11:40 PM Changeset in webkit [44797] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com
Reviewed by Gavin Barraclough
Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.
- 10:50 PM Changeset in webkit [44796] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe.
Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw):
- jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- 7:37 PM Changeset in webkit [44795] by
-
- 5 edits in trunk
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit
On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.
No performance impact.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift):
LayoutTests:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Add tests to check shifts by non-constant amounts.
- fast/js/kde/operators-expected.txt:
- fast/js/kde/resources/operators.js:
- 6:49 PM Changeset in webkit [44794] by
-
- 12 edits in trunk
2009-06-17 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
First step to making video rendering be hardware-accelerated:
make <video> elements get self-painting RenderLayers, and add
an isVideo() virtual method to RenderObject.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
- rendering/RenderObject.h: (WebCore::RenderObject::isVideo):
- rendering/RenderVideo.h: (WebCore::RenderVideo::requiresLayer): (WebCore::RenderVideo::isVideo):
- 6:22 PM Changeset in webkit [44793] by
-
- 6 edits1 add in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
(1) Create TransformationMatrix XFORM casting operator, and
switch various XFORM structure uses to utilize it.
(2) Push concatCTM call to GraphicsContextWin now that the
TransformationMatrix can directly create XFORM (rather
than converting to CGAffineTransform/cairo_matrix_t first.)
- WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
- 6:05 PM Changeset in webkit [44792] by
-
- 12 edits6 copies1 add in trunk/LayoutTests
2009-06-17 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Update results after enabling 3d rendering on SnowLeopard.
- platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
- platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
- platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
- platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
- platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt. Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.
- platform/mac/fast/media/mq-transform-02-expected.checksum:
- platform/mac/fast/media/mq-transform-02-expected.png:
- platform/mac/fast/media/mq-transform-02-expected.txt:
- platform/mac/fast/media/mq-transform-03-expected.checksum:
- platform/mac/fast/media/mq-transform-03-expected.png:
- platform/mac/fast/media/mq-transform-03-expected.txt: New "mac" results for 3d rendering enabled.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Update the results now that these tests are active.
- 5:41 PM Changeset in webkit [44791] by
-
- 20 edits in trunk
WebKit/win:
2009-06-17 Steve Falkenburg <sfalken@apple.com>
Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.
Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
Reviewed by Adam Roben.
- Interfaces/IWebFrameLoadDelegate.idl:
- Interfaces/IWebFrameLoadDelegatePrivate.idl:
- Interfaces/IWebResourceLoadDelegatePrivate.idl:
- Interfaces/IWebUIDelegate.idl:
- Interfaces/IWebUIDelegatePrivate.idl:
- Interfaces/WebKit.idl:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebContextMenuClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebInspectorDelegate.h:
- WebFrame.cpp:
- WebView.cpp:
WebKitTools:
2009-06-17 Steve Falkenburg <sfalken@apple.com>
Updated for consolidated WebKit COM interfaces.
Reviewed by Adam Roben.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.h:
- DumpRenderTree/win/UIDelegate.cpp:
- DumpRenderTree/win/UIDelegate.h:
- WinLauncher/WinLauncher.h:
- 5:37 PM Changeset in webkit [44790] by
-
- 2 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Non-CG Windows build fix after @r44758.
- rendering/RenderThemeWin.cpp: (WebCore::RenderTheme::themeForPage):
- 5:32 PM Changeset in webkit [44789] by
-
- 8 edits2 adds in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor a few common routines in the various Windows ports
and reduce some duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=26425.
Refactor use of BITMAPINFO for the new BitmapInfo structure.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/BitmapInfo.cpp: Added. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
- platform/win/BitmapInfo.h: Added.
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/TransformationMatrixWin.cpp: Added. (WebCore::TransformationMatrix::operator XFORM): New operator
- platform/win/DragImageCGWin.cpp: (WebCore::allocImage):
- platform/win/DragImageCairoWin.cpp: (WebCore::allocImage):
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
- 5:28 PM Changeset in webkit [44788] by
-
- 4 copies1 add in releases/Apple/Safari 4.0.1
Create Safari 4.0.1 release tag, consisting of version 5530.18 of WebCore and WebKit. JavaScriptCore and JavaScriptGlue remain unchanged.
- 5:21 PM Changeset in webkit [44787] by
-
- 4 copies1 add in releases/Apple/Safari 4.0
Create Safari 4.0 release tag, consisting of version x530.17 of each project.
- 3:37 PM Changeset in webkit [44786] by
-
- 3 edits in trunk/WebCore
Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL
Reviewed by Mark Rowe.
- platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and an unnecessary parameter name.
- platform/win/SoftLinking.h: Removed the unused 6th parameter.
- 3:10 PM Changeset in webkit [44785] by
-
- 3 edits in trunk/WebCore
Make Settings::shouldPaintNativeControls default to true
This matches the default up in WebKit (that was changed in r43318).
Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
form controls
<https://bugs.webkit.org/show_bug.cgi?id=26493>
Reviewed by Darin Adler and Dave Hyatt.
No test possible since DRT always uses Mac-style form controls.
- page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.
- 2:42 PM WebKit Team edited by
- (diff)
- 2:26 PM Changeset in webkit [44784] by
-
- 1 edit in trunk/LayoutTests/fast/js/global-constructors-expected.txt
Update layout test results for addition of datagrid element.
- 2:24 PM Changeset in webkit [44783] by
-
- 2 edits in trunk/WebCore
2009-06-17 David Levin <levin@chromium.org>
Fix chromium Windows build.
A mistake that happened during the complicated merge for
landing r44775, r44776, r44777.
- rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
- 2:17 PM EFLWebKit edited by
- (diff)
- 2:16 PM Changeset in webkit [44782] by
-
- 2 edits in trunk/WebCore
2009-06-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent
- rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto.
- 2:03 PM EFLWebKit edited by
- (diff)
- 2:02 PM EFLWebKit edited by
- (diff)
- 1:51 PM EFLWebKit edited by
- (diff)
- 1:46 PM EFLWebKit edited by
- (diff)
- 1:45 PM EFLWebKit edited by
- (diff)
- 1:31 PM EFLWebKit edited by
- (diff)
- 1:11 PM Changeset in webkit [44781] by
-
- 2 edits in trunk/WebKitSite
2009-06-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
- security/index.html: Fix some typos.
- 1:05 PM Changeset in webkit [44780] by
-
- 3 edits in trunk/WebCore
2009-06-17 David Hyatt <hyatt@apple.com>
Fix Windows build. There's no HTMLDataGridElement.cpp file yet.
- html/HTMLElementsAllInOne.cpp:
- 12:56 PM Changeset in webkit [44779] by
-
- 2 edits1 move in trunk/WebKitSite
2009-06-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move security policy to security/index.html so that
webkit.org/security/ works.
- nav.inc:
- security/index.html: Copied from security/security-policy.html.
- security/security-policy.html: Removed.
- 12:33 PM Changeset in webkit [44778] by
-
- 15 edits2 adds in trunk
WebCore:
2009-06-17 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben and Anders Carlsson.
Stub out the HTMLDataGridElement.
- DerivedSources.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
- editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing):
- html/HTMLDataGridElement.h: Added. (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::tagPriority):
- html/HTMLDataGridElement.idl: Added.
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
- html/HTMLTagNames.in:
LayoutTests:
2009-06-17 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Update window properties layout test for HTMLDataGridElement addition.
- fast/dom/Window/window-properties-expected.txt:
- 12:31 PM Changeset in webkit [44777] by
-
- 2 edits in trunk/WebCore
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY (chromium build fix).
Fix typo in previous changes.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
- 12:18 PM Changeset in webkit [44776] by
-
- 7 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Remove common code from RenderThemeChromiumWin that is shared with
RenderThemeChromiumSkia.
Also move supportsControlTints to RenderThemeChromiumLinux since it
is linux specific.
There are no tests changed because this just removes functions with
duplicate implementations between the base and derived classes.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::supportsControlTints):
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::systemFont): (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
- rendering/RenderThemeChromiumWin.h:
- 12:18 PM Changeset in webkit [44775] by
-
- 5 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Move RenderThemeChromiumSkia into its own file. This is purely a code move.
- rendering/RenderThemeChromiumLinux.cpp:
- rendering/RenderThemeChromiumLinux.h:
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::): (WebCore::setSizeIfAuto): (WebCore::mediaElementParent): (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::brightenColor): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
- rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::supportsControlTints):
- 12:17 PM Changeset in webkit [44774] by
-
- 3 edits in trunk/WebCore
2009-06-17 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26148
Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux. This
is mostly a code shuffle. The non-suffle changes are:
1) Creation of a caretBlinkIntervalInternal.
2) Moving of some inline functions into the implementation files.
3) Changing of defaultGUIFont into a static class constant from a
static function. Also the type is changed to String.
4) Changing of defaultFontSize into a static class constant from a
static variable in the file scope.
5) The static supportsFocus function was collapsed into
supportsFocusRing.
6) Split the extraDefaultStyleSheet into Skia and Linux versions.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumSkia::defaultGUIFont): (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia): (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet): (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet): (WebCore::RenderThemeChromiumSkia::supportsHover): (WebCore::RenderThemeChromiumSkia::supportsFocusRing): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor): (WebCore::RenderThemeChromiumSkia::caretBlinkInterval): (WebCore::RenderThemeChromiumSkia::systemFont): (WebCore::RenderThemeChromiumSkia::minimumMenuListSize): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::RenderThemeChromiumSkia::setRadioSize): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom): (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal): (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::systemColor): (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
- rendering/RenderThemeChromiumLinux.h:
- 12:07 PM Changeset in webkit [44773] by
-
- 2 edits3 adds in trunk/WebKitSite
2009-06-13 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
Add WebKit Security Policy and member list of the WebKit Security Group.
- nav.inc:
- security: Added.
- security/security-group-members.html: Added.
- security/security-policy.html: Added.
- 12:02 PM Changeset in webkit [44772] by
-
- 3 edits in trunk/WebCore
Add a SOFT_LINK_OPTIONAL macro
This macro is useful when soft-linking functions that are present in
only some versions of a particular library (e.g., APIs added in
Windows Vista that aren't available on Windows XP).
Reviewed by Ada Chan.
- platform/graphics/win/ColorSafari.cpp: (WebCore::focusRingColor): Use the SoftLinking.h macros instead of doing the soft-link ourselves. Also removed an unused call to focusRingColor.isValid().
- platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.
- 11:25 AM Changeset in webkit [44771] by
-
- 2 edits in trunk/WebCore
2009-06-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Gustavo Noronha Silva.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
The use of zero-width or zero-height rectangles in generating
gradients caused Windows Cairo to crash, and webkitgtk to
produce invalid images.
- 11:22 AM Changeset in webkit [44770] by
-
- 2 edits in trunk/WebCore
2009-06-17 Ojan Vafai <ojan@chromium.org>
Reviewed by NOBODY (OOPS!).
If loading a font fails because of the sandbox, we ask the browser process to
try to load it by calling ensureFontLoaded. If it still fails after
ensureFontLoaded, we hit a ASSERT_NOT_REACHED.
This case happens once in a while during browser shutdown. The browser will
queue a message to the renderer to shutdown, and will then stop answering sync
messages from the renderer. If the renderer is still loading a page during this
time, it might try to call the browser process to ask to load a font. The
browser process will ignore the request, and the font will fail to load, even
after the second try.
This is unfortunate, but there is no real risk here, since the renderer will be
going away as soon as it processes another message.
This can't be layout tested as it depends on the sandbox.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter):
- 11:21 AM Changeset in webkit [44769] by
-
- 3 edits in trunk/WebCore
2009-06-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=26482
<rdar://problem/6978590> When setting playback rate to 0, the audio element stops
playing (doesn't resume later)
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setRate): Ditto.
- 10:13 AM Changeset in webkit [44768] by
-
- 2 edits in trunk/WebCore
Add all the generated JS*.cpp files back to WebCore.vcproj
They are not compiled by the vcproj directly. Instead they are
compiled as part of DerivedSources.cpp. Having them listed in the
vcproj makes them be included in Project Find, etc.
Rubber-stamped in advance by Steve Falkenburg.
- WebCore.vcproj/WebCore.vcproj:
- 10:01 AM Changeset in webkit [44767] by
-
- 2 edits in trunk/WebCore
2009-06-17 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Don't fire redundant 'change' events for a file upload form.
https://bugs.webkit.org/show_bug.cgi?id=26471
- platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): Suppress change event if the existing selected files and the incoming selected files are equal. (WebCore::FileChooser::chooseIcon): Returns 0 if there is no selected files.
- 9:45 AM Changeset in webkit [44766] by
-
- 4 edits in trunk
2009-06-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- 9:39 AM Changeset in webkit [44765] by
-
- 15 edits in trunk
2009-06-17 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
- 8:54 AM Changeset in webkit [44764] by
-
- 3 edits in trunk/LayoutTests
Fix Skipped file format after r44519
- platform/qt/Skipped:
- platform/win/Skipped: Removed bogus ": Added."s in these files.
- 8:42 AM Changeset in webkit [44763] by
-
- 5 edits in trunk/WebCore
Speculative Mac build fix
- page/Page.h: Forward-declare RenderTheme instead of including RenderTheme.h so that we don't need to make RenderTheme.h a private header for WebKit's benefit.
- editing/SelectionController.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderObject.cpp: Added #includes of RenderTheme.h.
- 8:32 AM Changeset in webkit [44762] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- rendering/RenderThemeMac.mm: (WebCore::RenderTheme::create): Added.
- 8:26 AM Changeset in webkit [44761] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- rendering/RenderThemeMac.mm: (WebCore::RenderTheme::themeForPage): Remove the name of an unused parameter.
- 8:14 AM Changeset in webkit [44760] by
-
- 2 edits in trunk/WebCore
Speculative Mac build fix
- page/Page.cpp: (WebCore::Page::Page): Change the initializer order to match the declaration order.
- 7:52 AM Changeset in webkit [44759] by
-
- 3 edits in trunk/WebCore
2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Follow up to bug https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page
Make the Qt implementation of RenderTheme create a theme per page,
and use the QStyle associated with the view of each page, in order
to make the QWidget setStyle() method work as advertised.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::findFrameLineWidth): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::adjustRepaintRect): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::setPopupPadding):
- platform/qt/RenderThemeQt.h:
- 7:52 AM Changeset in webkit [44758] by
-
- 39 edits in trunk
2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Dave Hyatt and Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=26278
Patch that make WebCore have a RenderTheme per page
Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.
This change was suggested and discussed with Dave Hyatt.
More detailed:
1) Create a theme per page or one global one, depending on the needs
of the platform.
2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through
RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.
4) Modify all RenderTheme platform implementations to work with the
above changes, still creating only one global theme.
- 2:11 AM Changeset in webkit [44757] by
-
- 8 edits in trunk
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::hasOwnPropertyForWrite):
- runtime/JSObject.h:
- runtime/JSStaticScopeObject.cpp:
- runtime/JSStaticScopeObject.h:
- runtime/PropertySlot.h:
WebCore:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
JSDOMWindowCustom was using PropertySlot::putValue, however this interface
appears to be fundaementally incorrect - PropertySlots are only used to get
values, all puts use PutPropertySlot. However PutPropertySlot cannot be
used in the fashion desired here - it only reports the caching type of a
write that has been performed.
(This caused a bug where the put should have triggered a transition, and
failed to do so.)
Removing the faulty case from the optimization leads to a ~0.5% progression
on in-browser SunSpider (presumably the very first case was not being hit
often, and the simplification here is beneficial).
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::put):
- 1:48 AM Changeset in webkit [44756] by
-
- 2 edits in trunk/WebKit/qt
2009-06-17 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
QWebPage: Don't call supportsSsl()
This stops QWebPage from loading the OpenSSL libs,
certificates etc. when they are not needed for the non-HTTPS case.
Loading the SSL libraries can be a very slow operation.
- 12:41 AM Changeset in webkit [44755] by
-
- 8 edits3 deletes in trunk
WebCore:
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.
Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.
- dom/Document.cpp: (WebCore::Document::detach):
- page/FrameView.cpp:
- page/FrameView.h:
- platform/Scrollbar.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderScrollbar.h:
LayoutTests:
2009-06-17 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=26326
This reverts commit r44751.
Once that change was checked scrollbars/scrollbar-orientation.html started
crashing on Windows.
- scrollbars/resources/page-with-custom-scrollbars.html: Removed.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Removed.
- scrollbars/scrollbar-crash-on-refresh.html: Removed.
