Timeline
Oct 4, 2009:
- 10:27 PM Changeset in webkit [49082] by
-
- 7 edits1 add in trunk/WebCore
2009-10-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
Syntax Highlighting CSS shouldn't be duplicated.
Refactor syntax highlighting CSS into a new file, add it to the
projects, and have SourceFrame.js and inspector.html include the
new CSS file.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspectorSyntaxHighlight.css: Added.
- inspector/front-end/WebKit.qrc:
- 9:16 PM Changeset in webkit [49081] by
-
- 3 edits in trunk/WebCore
2009-10-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
Inspector should syntax highlight JS/CSS in elements view.
Add syntax highlighting of CSS and JavaScript tags to the elements panel.
Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
or style tag.
- inspector/front-end/inspector.css:
- inspector/front-end/utilities.js:
- 7:52 PM Changeset in webkit [49080] by
-
- 4 edits in trunk
2009-10-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel
Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917
- WebCore.gyp/WebCore.gyp:
2009-10-04 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel
Enable Web Sockets in chromium build.
https://bugs.webkit.org/show_bug.cgi?id=29917
- chromium/features.gypi:
- 4:43 PM Changeset in webkit [49079] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Cameron Zwarich.
- WebView/WebPreferenceKeysPrivate.h: Added new key.
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Leave plug-in halting disabled by default. (-[WebPreferences pluginHalterEnabled]): Added. (-[WebPreferences setPluginHalterEnabled:]): Ditto.
- WebView/WebPreferencesPrivate.h: Added above new methods.
- 2:12 PM Changeset in webkit [49078] by
-
- 3 edits in trunk/WebKitTools
2009-10-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Levin.
check-webkit-style misses whitespace errors for operators:
<<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, . - Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=.
- 1:01 PM Changeset in webkit [49077] by
-
- 5 edits4 adds in trunk
WebCore:
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by NOBODY (OOPS!).
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.
Test: http/tests/navigation/postredirect-reload.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
LayoutTests:
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by NOBODY (OOPS!).
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.
- http/tests/navigation/postredirect-reload-expected.txt: Added.
- http/tests/navigation/postredirect-reload.html: Added.
- http/tests/navigation/resources/postresult.pl:
- http/tests/navigation/resources/reloadresult.pl: Added.
- http/tests/navigation/resources/redirect-reload.html: Added.
- http/tests/navigation/resources/success200.html:
- http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
- 11:14 AM Changeset in webkit [49076] by
-
- 6 edits3 deletes in trunk
Revert previous patch, as the newly added test breaks other tests.
- 10:17 AM Changeset in webkit [49075] by
-
- 6 edits3 adds in trunk
WebCore:
2009-10-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
Update the HTTP method in the request stored by willSendRequest
after a redirect, since it could have changed.
Test: http/tests/navigation/postredirect-reload.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
LayoutTests:
2009-10-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] performs a POST when refreshing a view that was obtained with a GET
https://bugs.webkit.org/show_bug.cgi?id=29761
New test that checks that a reload after a redirect to a page with
a GET method from one with a POST method will use GET and not
POST.
- http/tests/navigation/postredirect-reload-expected.txt: Added.
- http/tests/navigation/postredirect-reload.html: Added.
- http/tests/navigation/resources/postresult.pl:
- http/tests/navigation/resources/reloadresult.pl: Added.
- http/tests/navigation/resources/success200.html:
- http/tests/navigation/resources/testcode.js: (submitFormWithPostRedirectReload): (runRedirectReloadTest):
- 10:12 AM Changeset in webkit [49074] by
-
- 4 edits in trunk/WebCore
2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Fixed Function leak in V8LazyEventListener.
(Should fix the remaning leak in
https://bugs.webkit.org/show_bug.cgi?id=29093).
V8LazyEventListeners used to create FunctionTemplates for each
wrapped listener which in turn created Functions that were cached
forever in V8 Context. Now there is at most one such Function per
Context.
https://bugs.webkit.org/show_bug.cgi?id=30060
Added new hidden property name to store toString result:
- bindings/v8/V8HiddenPropertyName.cpp:
- bindings/v8/V8HiddenPropertyName.h:
Switched to static FunctionTemplate:
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::prepareListenerObject):
Oct 3, 2009:
- 8:46 PM Changeset in webkit [49073] by
-
- 2 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359
Support for WebKit's CSS Variables @variables and var()
- inspector/front-end/SourceFrame.js: (WebInspector.CSSSourceSyntaxHighligher):
- 8:14 PM Changeset in webkit [49072] by
-
- 3 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Inspector should remember preferences for docked/undocked etc
https://bugs.webkit.org/show_bug.cgi?id=29089
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
- inspector/front-end/inspector.js: (WebInspector._loadPreferences): factored out loading preferences (WebInspector.loaded):
- 7:50 PM Changeset in webkit [49071] by
-
- 3 edits in trunk/WebCore
2009-10-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
CSS Source View Should be Syntax Highlighted
https://bugs.webkit.org/show_bug.cgi?id=14359
Trigger the Syntax Highlighter for CSS files.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
Factored out the Syntax Highlighting procedure into a "Class"
Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter
(WebInspector.SourceSyntaxHighligher):
(WebInspector.SourceSyntaxHighligher.prototype.createSpan):
(WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
(WebInspector.SourceSyntaxHighligher.prototype.process):
(WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
(WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter
- 5:41 PM Changeset in webkit [49070] by
-
- 2 edits in trunk/WebKit/qt
2009-10-03 Adam Barth <abarth@webkit.org>
Unreview build fix. I wish I had a try server...
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction):
- 5:36 PM Changeset in webkit [49069] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-03 Adam Barth <abarth@webkit.org>
More build fixing.
- webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward): (webkit_web_view_can_go_back_or_forward):
- 5:26 PM Changeset in webkit [49068] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-03 Adam Barth <abarth@webkit.org>
Unreviewed build fix.
- webkit/webkitwebview.cpp: (webkit_web_view_go_back_or_forward):
- 5:17 PM Changeset in webkit [49067] by
-
- 12 edits in trunk
2009-10-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Factor back-forward list methods out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30037
This change moves these back-forward related methods from FrameLoader
to Page. It's possible we should move these methods into some kind of
"page controller" object, but we can figure that out in a future patch.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMWindow.cpp: (WebCore::DOMWindow::close):
- page/History.cpp: (WebCore::History::length):
- page/Page.cpp: (WebCore::Page::canGoBackOrForward): (WebCore::Page::goBackOrForward): (WebCore::Page::getHistoryLength):
- page/Page.h:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
2009-10-03 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Factor PageController out of FrameLoader and Page
https://bugs.webkit.org/show_bug.cgi?id=30037
- webkit/webkitwebview.cpp: (webkit_web_view_can_go_back_or_forward):
- 1:50 PM Changeset in webkit [49066] by
-
- 2 edits in trunk/LayoutTests
2009-10-03 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Remove 5 tests from the Skipped list that pass after the addition
of layoutTestController.overridePreference().
- platform/qt/Skipped:
- 10:01 AM Changeset in webkit [49065] by
-
- 7 edits in trunk/JavaScriptCore
Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.
1.3% speedup on SunSpider.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):
- runtime/JSArray.h:
(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.
- 3:27 AM Changeset in webkit [49064] by
-
- 11 edits in trunk/WebCore
2009-10-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: prepare InspectorController for being used from layout tests.
This change adds evaluateForTestInFrontend method with the callback that
allows evaluating arbitrary code in the frontend context.
- WebCore.Inspector.exp:
- WebCore.order:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::evaluateForTestInFrontend):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.evaluateForTestInFrontend):
Oct 2, 2009:
- 11:31 PM Changeset in webkit [49063] by
-
- 2 edits in trunk/WebCore
2009-10-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Node search mode is not getting reset on element selection.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
- 10:24 PM Changeset in webkit [49062] by
-
- 2 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
Should be able to resize Cookie Columns.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.resize):
- 10:10 PM Changeset in webkit [49061] by
-
- 2 edits in trunk/WebKitLibraries
Windows build fix.
Re-apply lost changes to auto-version.sh.
- win/tools/scripts/auto-version.sh:
- 7:51 PM Changeset in webkit [49060] by
-
- 12 edits in trunk/WebCore
Make WebCore::PluginView participate in plug-in halting.
Reviewed by Sam Weinig.
WebCore:
Have plug-ins opt in to automatic halting.
Reviewed by NOBODY (OOPS!).
- platform/graphics/BitmapImage.h:
Declare a create() function that takes an HBITMAP.
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.
- plugins/PluginView.cpp:
(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):
- plugins/PluginView.h:
Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.
- rendering/RenderWidget.h:
Declare showSubstituteImage(). Added a member to store the substitute
image.
- 7:10 PM Changeset in webkit [49059] by
-
- 8 edits2 adds in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move PolicyCheck out of FrameLoader.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=30035
Purely code motion (and adding a destructor).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/PolicyCheck.cpp:
- loader/PolicyCheck.h:
- 6:47 PM Changeset in webkit [49058] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.
- Scripts/modules/committers.py:
- 5:47 PM Changeset in webkit [49057] by
-
- 5 edits in trunk/WebKit/mac
Roll out r49044 as it breaks many tests.
- 4:35 PM Changeset in webkit [49056] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>
Reviewed by Darin Adler.
Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
https://bugs.webkit.org/show_bug.cgi?id=29956
- wtf/RandomNumber.cpp: (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
- 4:27 PM Changeset in webkit [49055] by
-
- 3 edits in trunk/LayoutTests
2009-10-02 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Update pixel test image for fast/table/vertical-align-baseline.html.
Expected render tree dump for this test was modified in r40146
<http://trac.webkit.org/changeset/40146>, but the image was not updated with it.
- platform/mac/fast/table/vertical-align-baseline-expected.checksum:
- platform/mac/fast/table/vertical-align-baseline-expected.png:
- 4:20 PM Changeset in webkit [49054] by
-
- 2 edits in trunk/WebCore
2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
Plugin error message was:
ERROR: failed to initialize brower-side RPC events listener
https://bugs.webkit.org/show_bug.cgi?id=25053
(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::load):
- 4:12 PM Changeset in webkit [49053] by
-
- 2 edits in trunk/WebCore
2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] X sync our XEmbed container window creation before sending the
xid to plugins.
https://bugs.webkit.org/show_bug.cgi?id=25053
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
- 4:02 PM Changeset in webkit [49052] by
-
- 4 edits4 adds in trunk
2009-10-02 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Setting zero size on a container of a video element doesn't hide the controller
https://bugs.webkit.org/show_bug.cgi?id=30031
Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
positioned layers. This resulted in enclosingCompositingLayer() giving back a different
answer to the logic used to actually parent compositing layers, so layer positions
and layer hierarchy would be out of agreement.
Test: compositing/geometry/clipped-video-controller.html
- rendering/RenderLayer.cpp: (WebCore::compositingContainer): (WebCore::RenderLayer::enclosingCompositingLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingParent):
- 3:49 PM Changeset in webkit [49051] by
-
- 7 edits in trunk/WebCore
2009-10-02 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
- Move the following methods of HTMLInputElement and HTMLTextAreaElement to HTMLTextFormControlElement.
setSelectionStart()
setSelectionEnd()
select()
setSelectionRange()
selectionStart()
selectionEnd()
selection()
- Introduce cachedSelectionStart() and cachedSelectionEnd().
- Unify HTMLInputElement::isTextFieldWithRenderer() and HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().
- Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout): (WebCore::HTMLTextFormControlElement::setSelectionStart): (WebCore::HTMLTextFormControlElement::setSelectionEnd): (WebCore::HTMLTextFormControlElement::select): (WebCore::HTMLTextFormControlElement::setSelectionRange): (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd): (WebCore::HTMLTextFormControlElement::selection): (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::cachedSelectionStart): (WebCore::HTMLInputElement::cachedSelectionEnd):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
- html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cachedSelectionStart): (WebCore::HTMLTextAreaElement::cachedSelectionEnd):
- 3:40 PM Changeset in webkit [49050] by
-
- 14 edits in trunk/WebCore
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Disconnect event listeners on navigation.
Fixes http://crbug.com/23597.
https://bugs.webkit.org/show_bug.cgi?id=30027
Added V8ListenerGuard that is shared by listeners and proxy. On
navigation proxy sets a flag in the guard turning off listeners.
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8ListenerGuard::create): (WebCore::V8ListenerGuard::isDisconnected): (WebCore::V8ListenerGuard::disconnectListeners): (WebCore::V8ListenerGuard::V8ListenerGuard): (WebCore::V8AbstractEventListener::disconnected):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getEventListener):
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners): (WebCore::V8Proxy::clearForNavigation):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::listenerGuard):
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
- bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
- bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create):
- 3:33 PM Changeset in webkit [49049] by
-
- 2 edits in trunk/WebCore
2009-10-02 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Fix WebGL build after CustomGetter constructor changes
https://bugs.webkit.org/show_bug.cgi?id=30020
- page/DOMWindow.idl: Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.
- 3:23 PM Changeset in webkit [49048] by
-
- 2 edits in trunk/WebCore
2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: text in a "Request Payload" section disappears on selection
https://bugs.webkit.org/show_bug.cgi?id=29967
No new tests.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestPayload):
- 3:15 PM Changeset in webkit [49047] by
-
- 3 edits2 adds in trunk
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
Test that having infinite recursion in XMLHttpRequest event handler does not crash.
https://bugs.webkit.org/show_bug.cgi?id=29974
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.
2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Recursion guard for V8Proxy::callFunction.
Fixes http://crbug.com/23278.
https://bugs.webkit.org/show_bug.cgi?id=29974
Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
- 2:59 PM Changeset in webkit [49046] by
-
- 2 edits in trunk/WebCore
Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:55 PM Changeset in webkit [49045] by
-
- 2 edits1 delete in trunk/LayoutTests
2009-10-02 Victor Wang <victorw@chromium.org>
Reviewed by Adam Barth.
Patch http://trac.webkit.org/changeset/35290 adds win support for
JPEG and GIF for toDataURL encoding canvases and the test was
rewritten to not output the encoded image data, it should pass
on Win now.
- platform/win/Skipped:
- platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
- 2:53 PM Changeset in webkit [49044] by
-
- 5 edits in trunk/WebKit/mac
WebKit side of <rdar://problem/7179166>
Reviewed by Kevin Decker and Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add an m_pluginIsWaitingForDraw member variable.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.
(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.
(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.
- Plugins/Hosted/WebKitPluginHost.defs:
Add PHPluginInstanceDidDraw.
- 2:49 PM Changeset in webkit [49043] by
-
- 3 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
Fix test breakages by adding null checks, and putting inspector code in
ENABLE(INSPECTOR).
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- 2:39 PM Changeset in webkit [49042] by
-
- 2 edits in trunk/WebCore
Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 2:34 PM Changeset in webkit [49041] by
-
- 3 edits2 adds in trunk
WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.
Test: editing/selection/replace-selection-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.
LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.
- editing/selection/replace-selection-crash-expected.txt: Added.
- editing/selection/replace-selection-crash.html: Added.
- 2:15 PM Changeset in webkit [49040] by
-
- 13 edits3 adds in trunk
2009-10-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991
I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.
I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)
Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).
Test: storage/domstorage/localstorage/quota.html
- page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota):
- page/Settings.h: (WebCore::Settings::localStorageQuota):
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::create): (WebCore::StorageAreaImpl::StorageAreaImpl): (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
- storage/StorageMap.cpp: (WebCore::StorageMap::create): (WebCore::StorageMap::StorageMap): (WebCore::StorageMap::copy): (WebCore::StorageMap::setItem): (WebCore::StorageMap::removeItem): (WebCore::StorageMap::importItem):
- storage/StorageMap.h: (WebCore::StorageMap::quota):
- storage/StorageNamespace.cpp: (WebCore::StorageNamespace::localStorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::localStorageNamespace): (WebCore::StorageNamespaceImpl::sessionStorageNamespace): (WebCore::StorageNamespaceImpl::StorageNamespaceImpl): (WebCore::StorageNamespaceImpl::copy): (WebCore::StorageNamespaceImpl::storageArea):
- storage/StorageNamespaceImpl.h:
2009-10-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Implement per-storage-area quotas for LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=29991
I put 90% of the code in StorageMap since the decision to allow an update is
closely tied to quota tracking. The quota is set via a page's Settings class.
Like with the local storage path and whether it's enabled, it's assumed that
all pages in the same group will have the same settings. The setting defaults
to 5mb which is what the spec suggests, but it can easily be changed to
anything else--including StorageMap::noQuota. Any values in LocalStorage are
grandfathered in regarudless of quota, so importItem only tracks (and will
never block) imports.
I believe this change is a good transition to more complex quota management.
For example, if we wanted to track quotas in the SQLite DB, then we'd just add
a function to the StorageMap that sets the quota. This would be fine since all
use of LocalStorage is blocked on the import completing, so you'd never hit a
quota error in the mean time. Also, if embedders wanted to ask the user
whether to expand the quota whenever it's hit (before deciding whether or not
to raise an exception), a callback via the chrome client should be fairly easy.
That said, I think it's best to add these features in steps rather than one
huge patch. (Both of these are on my TODO list, btw.)
Included is a layout test that verifies the behavior. It assumes the default
quota is 5mb (since that's what Settings defaults to).
- storage/domstorage/localstorage/quota-expected.txt: Added.
- storage/domstorage/localstorage/quota.html: Added.
- storage/domstorage/script-tests/quota.js: Added. (runTest):
- 1:09 PM Changeset in webkit [49039] by
-
- 2 edits in trunk/WebCore
2009-10-02 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Database Inspector crashes Safari when table has more than 21 columns
https://bugs.webkit.org/show_bug.cgi?id=29924
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.
- 1:07 PM Changeset in webkit [49038] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 1:07 PM Changeset in webkit [49037] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 1:01 PM Changeset in webkit [49036] by
-
- 11 edits in trunk/WebCore
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Timothy Hatcher.
Fixes <http://webkit.org/b/14370>.
Inspector's timeline should record when certain DOM events fired.
This patch adds calls into the Web Inspector when the main frame
fires an load event, and when the document fires its DOMContent
event. Once these values are passed in, they are sent to the Web Inspector
as a timing change, and these are denoted by vertical lines in the resources
panel (blue for DOM Content, red for load event).
- English.lproj/localizedStrings.js: Added tooltip text.
- dom/Document.cpp: (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
- inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event. (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): Added new variables. (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js. (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event. (WebCore::InspectorResource::markLoadEventTime): Ditto.
- inspector/InspectorResource.h:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings. (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.
- 1:00 PM Changeset in webkit [49035] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Fix Windows bustage.
- 12:57 PM Changeset in webkit [49034] by
-
- 2 edits in trunk/WebKitTools/DumpRenderTree
Update DUmpRenderTree to account for new API.
- 12:42 PM Changeset in webkit [49033] by
-
- 17 edits in trunk
Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
Reviewed by Adam Roben.
WebCore:
- WebCore.base.exp:
- dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
- page/PageGroup.h:
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matchesPatterns):
- page/UserContentURLPattern.h:
- page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):
- page/UserStyleSheet.h:
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):
WebKit/mac:
- WebView/WebView.mm:
(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):
- WebView/WebViewPrivate.h:
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
- WebView.h:
- 11:41 AM Changeset in webkit [49032] by
-
- 2 edits1 add in trunk/WebKit
2009-10-02 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Added gyp_webkit that does a subset of the things gyp_chromium does
plus some specialization for an upstream chromium build.
- chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
- chromium/gyp_webkit: A new python file.
- 11:08 AM Changeset in webkit [49031] by
-
- 2 edits in trunk/WebKitLibraries
2009-10-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
<rdar://problem/7271334>
Rename MediaControllerThemeQT to MediaControllerThemeQuickTime
- WebKitSystemInterface.h: MediaControllerThemeQT -> MediaControllerThemeQuickTime
- 11:06 AM Changeset in webkit [49030] by
-
- 6 edits in trunk/JavaScriptCore
Rolled back in r49004 with the debug 64bit build fixed
- 11:02 AM Changeset in webkit [49029] by
-
- 2 edits in trunk/WebCore
2009-10-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Build fix when SVG is not enabled
https://bugs.webkit.org/show_bug.cgi?id=30011
Move TextRenderingMode related functions out from
the ENABLE(SVG) guard.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextRenderingMode):
- 10:57 AM Changeset in webkit [49028] by
-
- 2 edits in trunk/WebKitTools
2009-10-02 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
this will help the patch merging process when TryBots are used.
- Scripts/svn-create-patch:
- 10:49 AM Changeset in webkit [49027] by
-
- 3 edits2 adds in trunk
WebGL crashes with recent CanvasArray change
https://bugs.webkit.org/show_bug.cgi?id=30018
- 10:22 AM Changeset in webkit [49026] by
-
- 8 edits1 delete in trunk
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code
Reviewed by Mark Rowe.
For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
WebCore:
- WebCore.vcproj/QTMovieWin.rc:
WebKit/win:
- WebKit.vcproj/WebKit.rc:
WebKitLibraries:
- win/tools/scripts/PRODUCTVERSION: Removed.
- win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.
- 10:19 AM Changeset in webkit [49025] by
-
- 2 edits in trunk/WebCore
Enable two point radial gradients in Chromium/Skia.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=30017
Covered by the following tests:
LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html
- platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):
- 9:14 AM Changeset in webkit [49024] by
-
- 4 edits in trunk/WebKitTools
2009-10-02 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement layoutTestController.overridePreference().
https://bugs.webkit.org/show_bug.cgi?id=29970
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/jsobjects.h:
- 8:49 AM Changeset in webkit [49023] by
-
- 5 edits in trunk
2009-10-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.
- Api/qgraphicswebview.cpp:
- Api/qwebview.cpp:
2009-10-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
Otherwise, it is inconsistent with class declaration of QCursor.
No new tests.
- platform/qt/QWebPageClient.h:
- 8:40 AM Changeset in webkit [49022] by
-
- 2 edits in trunk/JavaScriptCore
Fix the Qt on Mac OS X build.
Rubber-stamped by Simon Hausmann.
- wtf/FastMalloc.cpp:
- 5:05 AM QtBackLog edited by
- (diff)
- 5:04 AM QtBackLog edited by
- (diff)
- 4:32 AM Changeset in webkit [49021] by
-
- 2 edits in trunk/WebCore
2009-10-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] missing support for anamorphic PAR video size
https://bugs.webkit.org/show_bug.cgi?id=29717
cleanup of caps handling in the video sink
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_set_caps):
- 4:18 AM Changeset in webkit [49020] by
-
- 34 edits in trunk
.: Disable a few more harmless MSVC warnings.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- WebKit.pri:
WebCore: Fix compiler warnings about unused function arguments.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- bridge/qt/qt_class.h:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
- dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::initializeParserContext):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):
- platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):
- platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFiles):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::destroyDecodedData):
- platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::lookedUp):
- platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::setPlatformDescription):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
- platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):
- platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::platformAddChild):
- platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
- platform/qt/TemporaryLinkStubs.cpp:
(WebCore::signedPublicKeyAndChallengeString):
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::paint):
- xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):
- xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):
WebKit/qt: Fix compiler warnings about unused function arguments.
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::scrollBarMinimum):
- Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):
- WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::downloadURL):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):
- 4:14 AM Changeset in webkit [49019] by
-
- 3 edits in trunk/WebCore
2009-10-02 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer.
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836
Scale the cairo surface of the video sink depending on the
pixel-aspect-ratio of the video buffer to paint. Also
destruct/re-create the surface when setSize() is called with a new
size.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::paint):
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
- 3:19 AM Changeset in webkit [49018] by
-
- 4 edits4 adds in trunk
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836
WebCore:
Reviewed by David Kilzer.
Tests: storage/change-version-handle-reuse.html
storage/change-version.html
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.
- storage/Database.cpp:
(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.
LayoutTests:
Reviewed by David Kilzer.
- storage/change-version-expected.txt: Added.
- storage/change-version-handle-reuse-expected.txt: Added.
- storage/change-version-handle-reuse.html: Added.
- storage/change-version.html: Added.
- 1:34 AM Changeset in webkit [49017] by
-
- 2 edits in trunk/WebCore
Partial WINSCW build fix.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.
Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.
- loader/CachedResourceHandle.h:
- 1:22 AM Changeset in webkit [49016] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Roll out accidential r49015 commit
- 1:21 AM Changeset in webkit [49015] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW
Relative includes don't work properly with WINSCW
- 1:20 AM Changeset in webkit [49014] by
-
- 2 edits in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Unreviewed attempted build fix by Xcode magic.
- WebCore.xcodeproj/project.pbxproj:
- 1:03 AM Changeset in webkit [49013] by
-
- 1 edit2 adds in trunk/WebCore
2009-10-02 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Actually add the new files.
- loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
- loader/RedirectScheduler.h: Added.
- 12:57 AM Changeset in webkit [49012] by
-
- 9 edits in trunk/WebCore
2009-10-01 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move RedirectScheduler to its own file
https://bugs.webkit.org/show_bug.cgi?id=29952
This change is purely code motion.
No behavior change.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/RedirectScheduler.cpp: Added. (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
- loader/RedirectScheduler.h: Added.
- 12:41 AM Changeset in webkit [49011] by
-
- 2 edits in trunk/WebCore
2009-10-02 Dave MacLachlan <dmaclach@gmail.com>
Reviewed by David Levin.
Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971
Gets rid of warnings on gcc about using anonymous namespaces
warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace
and
warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace
No tests required.
- bindings/v8/npruntime.cpp:
- 12:31 AM Changeset in webkit [49010] by
-
- 2 edits in trunk/JavaScriptCore
Allow enabling and disabling of the JIT through a qmake variable.
Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.
Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.
- JavaScriptCore.pri:
Oct 1, 2009:
- 9:01 PM Changeset in webkit [49009] by
-
- 3 edits in trunk/LayoutTests
2009-10-01 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29698
- fast/workers/worker-cloneport-expected.txt:
- fast/workers/worker-cloneport.html:
- 7:50 PM Changeset in webkit [49008] by
-
- 6 edits in trunk
Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.
- 5:58 PM Changeset in webkit [49007] by
-
- 2 edits in trunk
2009-10-01 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Symbian build break after r48976.
unix is set for Symbian in the Qt build system.
- WebKit.pri:
- 5:25 PM Changeset in webkit [49006] by
-
- 30 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off
This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.
- 4:49 PM Changeset in webkit [49005] by
-
- 6 edits in trunk/JavaScriptCore
Roll out r49004 since it broke the debug build.
- 4:32 PM Changeset in webkit [49004] by
-
- 6 edits in trunk/JavaScriptCore
Take one branch instead of two to test for JSValue().
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.
1.1% SunSpider speedup.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.
- runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.
(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.
(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
- 4:00 PM Changeset in webkit [49003] by
-
- 14 edits in trunk
WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):
LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927
Reviewed by Dan Bernstein.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:21 PM Changeset in webkit [49002] by
-
- 2 edits in trunk/WebKit
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Make it possible to override the list of feature defines when building
downstream.
- chromium/features.gypi:
- 2:56 PM Changeset in webkit [49001] by
-
- 2 edits in trunk/LayoutTests
2009-10-01 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Added fast/inline/relative-positioned-overflow.html to Skipped list because
it hits an asssert in Windows debug builds. Assertion failure is being tracked
by <https://bugs.webkit.org/show_bug.cgi?id=29966>.
- platform/win/Skipped:
- 2:24 PM Changeset in webkit [49000] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Appeasing the Bot.
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- 2:19 PM Changeset in webkit [48999] by
-
- 3 edits1 add in trunk/LayoutTests
2009-10-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Beth Dakin.
Update expected Windows results after new CSS Text Kerning changes.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/text-rendering-expected.txt: Added.
- 1:46 PM Changeset in webkit [48998] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-01 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Set the type for the fake event, otherwise the test ASSERTs in
debug builds.
- tests/testhittestresult.c: (load_status_cb):
- 1:44 PM Changeset in webkit [48997] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.
- platform/qt/Skipped:
- 1:27 PM Changeset in webkit [48996] by
-
- 3 edits in trunk/LayoutTests
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344
Reviewed by Eric Seidel.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.
- fast/workers/resources/worker-util.js:
(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.
- 1:24 PM Changeset in webkit [48995] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Sam Weinig.
At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!
- WebCore.xcodeproj/project.pbxproj:
- 1:12 PM Changeset in webkit [48994] by
-
- 13 edits in trunk/WebCore
2009-10-01 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove FrameLoader::schedule* APIs
https://bugs.webkit.org/show_bug.cgi?id=29950
Change clients of FrameLoader::schedule* to call redirectScheduler
directly.
No behavior change.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::JSDOMWindow::open):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
- bindings/v8/V8Utilities.cpp: (WebCore::navigateIfAllowed):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedFirstData):
- loader/FrameLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
- 1:08 PM Changeset in webkit [48993] by
-
- 2 edits in trunk/WebCore
Just removing a comment I accidentally committed earlier.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):
- 12:54 PM Changeset in webkit [48992] by
-
- 3 edits in trunk/WebCore
2009-09-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Clean up use of const and mutable in StorageMap
https://bugs.webkit.org/show_bug.cgi?id=29933
What's the point of having every single member variable be mutable and nearly
every method be const? Let's clean it up.
- storage/StorageMap.cpp: (WebCore::StorageMap::setIteratorToIndex): (WebCore::StorageMap::key): (WebCore::StorageMap::importItem):
- storage/StorageMap.h:
- 12:32 PM Changeset in webkit [48991] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.
- platform/qt/Skipped:
- 12:21 PM Changeset in webkit [48990] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.
- platform/qt/Skipped:
- 12:19 PM Changeset in webkit [48989] by
-
- 29 edits8 adds in trunk
WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136
Reviewed by Dave Hyatt.
This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:
auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning
Add new file TextRenderingMode.h to the project files.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
CSS support for the new CSSPropertyTextRendering
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
- css/SVGCSSValueKeywords.in:
FontDescription stores the m_textRendering bit.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):
We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache):
Now takes a TextRenderingMode as a parameter.
- platform/graphics/SimpleFontData.h:
New header for the enum.
- platform/graphics/TextRenderingMode.h: Added.
(WebCore::):
getCFStringAttributes() now takes a TextRenderingMode as an
attribute.
- platform/graphics/mac/CoreTextController.cpp:
(WebCore::CoreTextController::collectCoreTextRunsForCharacters):
Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision
- platform/graphics/mac/FontMacATSUI.mm:
(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):
More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136
Reviewed by Dave Hyatt.
New tests.
- fast/css/parsing-text-rendering-expected.txt: Added.
- fast/css/parsing-text-rendering.html: Added.
- fast/css/resources/parsing-text-rendering.js: Added.
(test):
- fast/css/text-rendering.html: Added.
- platform/mac/fast/css/text-rendering-expected.checksum: Added.
- platform/mac/fast/css/text-rendering-expected.png: Added.
- platform/mac/fast/css/text-rendering-expected.txt: Added.
New and improved results.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:18 PM Changeset in webkit [48988] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
bug regarding templated classes.
The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
The change will be reverted when the above bug is fixed in winscw compiler.
- wtf/ListRefPtr.h: (WTF::::~ListRefPtr):
- 12:10 PM Changeset in webkit [48987] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Simon Hausmann.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.
- platform/qt/Skipped:
- 11:29 AM Changeset in webkit [48986] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-01 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Add baseline pngs for a couple of tests that currently only have checksums.
- platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
- platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
- 11:14 AM Changeset in webkit [48985] by
-
- 4 edits in trunk
Rubberstamped by Simon Hausmann.
WebKitTools:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt
- Scripts/run-webkit-tests:
LayoutTests:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.
- platform/qt/Skipped:
- 11:08 AM Changeset in webkit [48984] by
-
- 4 edits in trunk
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Added windows-specific dependencies, updated some revisions and
re-organized file to make revision tracking easier. Also removed
extensions/v8 dependency that is no longer needed upstream.
- chromium/DEPS:
2009-10-01 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
build-webkit --chromium now also works on cygwin.
- Scripts/webkitdirs.pm:
- 10:41 AM Changeset in webkit [48983] by
-
- 2 edits in trunk/WebCore
2009-10-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Use isClosure property of scope proxy to decide whether the
scope is a closure.
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- 10:29 AM Changeset in webkit [48982] by
-
- 3 edits2 adds in trunk
2009-10-01 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Odd color transitions on anchors with transition-property: all
https://bugs.webkit.org/show_bug.cgi?id=29911
When transitioning maybe-invalid colors, if the source and destination
color are both invalid, then don't animate.
This fixes an issue where a child element of an element running a color
transition, with -webkit-transition-property:all, would show a color change.
This happened because the "maybe invalid color" logic copied the color style
into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
to animate while the transition ran, and to then to disappear when the transition
finished.
Test: transitions/color-transition-all.html
- page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperMaybeInvalidColor::equals): (WebCore::PropertyWrapperMaybeInvalidColor::blend):
- 10:25 AM Changeset in webkit [48981] by
-
- 3 edits3 adds in trunk
2009-10-01 Victor Wang <victorw@chromium.org>
Reviewed by Oliver Hunt.
Allow dragging a node who has child nodes.
- fast/events/drag-parent-node-expected.txt: Added.
- fast/events/drag-parent-node.html: Added.
- fast/events/resources/bookmark.gif: Added.
2009-10-01 Victor Wang <victorw@chromium.org>
Reviewed by Oliver Hunt.
Allow dragging a node who has child nodes.
Test: fast/events/drag-parent-node.html
- page/EventHandler.cpp: (WebCore::EventHandler::shouldDragAutoNode):
- 10:17 AM Changeset in webkit [48980] by
-
- 2 edits in trunk/WebCore
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] media player: better mute support
https://bugs.webkit.org/show_bug.cgi?id=29960
Handle volume and mute state with the two corresponding properties
of playbin2.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setVolume):
- 10:09 AM Changeset in webkit [48979] by
-
- 2 edits in trunk/WebCore
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] video sink pad template colorspace is wrong
https://bugs.webkit.org/show_bug.cgi?id=29953
Set sink pad template colorspace depending on byte order.
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func):
- 10:01 AM Changeset in webkit [48978] by
-
- 37 edits4 deletes in trunk/WebCore
2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Refactored V8 event listeners:
(This change should fix http://crbug.com/21079 and
https://bugs.webkit.org/show_bug.cgi?id=29093.)
o All listeners use weak handles to JS objects to avoid creating
cycles and leaking memory.
o "Object" variants of listeners removed.
o All event accessor callbacks are generated.
o Custom event accessors removed.
o All wrappers have hidden dependencies on their listeners to
prevent listeners from being collected.
o All variats of getEventListener function grouped in V8DOMWrapper.
o Pointers to C++ EventListener wrappers are stored in JS objects
instead of event listener lists.
- WebCore.gypi: Removed "Object" listeners.
- bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
- bindings/v8/DOMObjectsInclude.h:
V8AbstractEventListener manages weak JS handle:
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::weakEventListenerCallback): (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::~V8AbstractEventListener): (WebCore::V8AbstractEventListener::handleEvent): (WebCore::V8AbstractEventListener::disposeListenerObject): (WebCore::V8AbstractEventListener::setListenerObject):
- bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::cast): (WebCore::V8AbstractEventListener::isLazy): (WebCore::V8AbstractEventListener::getListenerObject): (WebCore::V8AbstractEventListener::getExistingListenerObject): (WebCore::V8AbstractEventListener::hasExistingListenerObject): (WebCore::V8AbstractEventListener::disconnectFrame): (WebCore::V8AbstractEventListener::disconnected): (WebCore::V8AbstractEventListener::prepareListenerObject): (WebCore::V8AbstractEventListener::lineNumber): (WebCore::V8AbstractEventListener::virtualisAttribute):
Grouped getEventListener functions:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::getEventListener):
- bindings/v8/V8DOMWrapper.h:
Removed most event listener objects bookkeeping:
- bindings/v8/V8EventListenerList.cpp:
- bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findWrapper): (WebCore::V8EventListenerList::clearWrapper): (WebCore::V8EventListenerList::doFindWrapper): (WebCore::V8EventListenerList::getHiddenProperty): (WebCore::V8EventListenerList::findOrCreateWrapper):
Added hidden properties for storing EventListener wrappers:
- bindings/v8/V8HiddenPropertyName.cpp: (WebCore::V8HiddenPropertyName::listener): (WebCore::V8HiddenPropertyName::attributeListener):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::callListenerFunction): (WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::isLazy):
- bindings/v8/V8ObjectEventListener.cpp: Removed.
- bindings/v8/V8ObjectEventListener.h: Removed.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::disconnectFrame): (WebCore::V8Proxy::disconnectEventListeners):
- bindings/v8/V8Proxy.h:
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/V8WorkerContextEventListener.h:
- bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
- bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
- bindings/v8/custom/V8CustomEventListener.h:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NodeCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8SVGElementInstanceCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WebSocketCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerCustom.cpp:
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
- 9:59 AM Changeset in webkit [48977] by
-
- 3 edits in trunk/WebKit/qt
Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
- Api/qwebpage_p.h:
- 9:22 AM Changeset in webkit [48976] by
-
- 8 edits in trunk
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Allow custom memory allocation control for the whole JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27029
Since in JavaScriptCore almost every class which has been instantiated by operator new is
inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
when USE_SYSTEM_MALLOC=0.
Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
(It's needed for the functionality of TCmalloc.)
Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.
- JavaScriptCore.pri:
- wtf/FastMalloc.cpp: (WTF::sleep):
- wtf/FastMalloc.h:
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Don't use TCmalloc in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=27029
Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
- DumpRenderTree/qt/DumpRenderTree.pro:
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
https://bugs.webkit.org/show_bug.cgi?id=27029
Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
so these Qt-ports will use TCmalloc as other ports.
- WebKit.pri:
- 8:35 AM Changeset in webkit [48975] by
-
- 1 edit2 adds in trunk/LayoutTests
Land expected failure results for two tests on Windows
These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.
Rubber-stamped in advance by Eric Carlson.
- platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
Added.
- platform/win/fast/forms/basic-inputs-expected.txt: Added.
- 8:28 AM Changeset in webkit [48974] by
-
- 7 edits2 copies2 moves1 add1 delete in trunk
Rename QWebGraphicsItem to QGraphicsWebView
Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.
- 8:26 AM Changeset in webkit [48973] by
-
- 2 edits in trunk/WebCore
2009-10-01 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Read-only transactions do not change file sizes and therefore
should not trigger quota updates.
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::openTransactionAndPreflight): (WebCore::SQLTransaction::runStatements):
- 7:31 AM Changeset in webkit [48972] by
-
- 4 edits in trunk/WebKit/qt
2009-09-28 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29248
[Qt] [API] Make it possible to have 'invisible' loads
Make QWebFrame's setHtml and setContent methods to not change
session and global history at all.
- Api/qwebframe.cpp: (QWebFrame::setHtml): (QWebFrame::setContent):
- tests/qwebframe/qwebframe.pro:
- tests/qwebframe/tst_qwebframe.cpp:
- 6:18 AM Changeset in webkit [48971] by
-
- 5 edits in trunk/WebCore
Fix list box scrolling by correctly overriding the scroll()
function on RenderBox.
<rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
of listboxes is broken (29756)
Reviewed by Dan Bernstein.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scroll):
- rendering/RenderListBox.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scroll):
- rendering/RenderTextControlSingleLine.h:
- 6:17 AM Changeset in webkit [48970] by
-
- 2 edits in trunk/WebCore
2009-10-01 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Make a copy of listeners array before dispatching an event in
WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
listener removes itself from the array next listener will be skipped.
- inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event
- 6:02 AM Changeset in webkit [48969] by
-
- 2 edits in trunk/LayoutTests
2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.
- platform/qt/Skipped:
- 5:43 AM Changeset in webkit [48968] by
-
- 3 edits in trunk/WebKit/qt
Fixed software input panel support on web input elements.
Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.
Send the RequestSoftwareInputPanel event if the element supports focus
and the element is clicked.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseReleaseEvent):
- Api/qwebpage_p.h:
- 5:43 AM Changeset in webkit [48967] by
-
- 4 edits in trunk/WebKit/qt
Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent
Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29681
Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:
- Fixed surrounding text to exclude preedit string
- Avoid emission of microFocusChanged during setComposition()
- Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
(QWebPage::inputMethodQuery):
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::respondToChangedSelection):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
- 4:28 AM QtWebKitProfilingSetup edited by
- (diff)
- 3:43 AM Changeset in webkit [48966] by
-
- 5 edits in trunk
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement eventSender.scheduleAsynchronousClick().
- platform/qt/Skipped:
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement eventSender.scheduleAsynchronousClick().
- DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick):
- DumpRenderTree/qt/jsobjects.h:
- 3:35 AM Changeset in webkit [48965] by
-
- 5 edits in trunk
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.
- platform/qt/Skipped:
2009-10-01 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
fast/events/open-window-from-another-frame.html from the Skipped list.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled):
- DumpRenderTree/qt/jsobjects.h:
- 2:02 AM Changeset in webkit [48964] by
-
- 8 edits1 add in trunk
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Add new key event test ensuring that IME keypresses are handled.
- GNUmakefile.am:
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Re-enable skipped tests which were previously failing.
- platform/gtk/Skipped:
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.
No tests added. Instead previously skipped tests have been enabled.
- platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode): (WebCore::singleCharacterString):
2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] GtkIMContext filtering interferes with DOM key events
https://bugs.webkit.org/show_bug.cgi?id=28733
Ensure that keyboard events filtered by the GtkIMContext still create
the proper DOM events.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::clearPendingIMData): (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged): (WebKit::EditorClient::shouldBeginEditing): (WebKit::EditorClient::shouldEndEditing): (WebKit::interpretEditorCommandKeyEvent): (WebKit::handleCaretBrowsingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent): (WebKit::EditorClient::handleInputMethodKeydown):
- tests/testkeyevents.c: Added. (test_info_new): (test_info_destroy): (key_event_fixture_setup): (key_event_fixture_teardown): (key_press_event_cb): (key_release_event_cb): (load_status_cb): (map_event_cb): (test_keypress): (main):
- 1:19 AM Changeset in webkit [48963] by
-
- 7 edits2 adds in trunk
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
Check presence of gstreamer-pbutils-0.10.
- configure.ac:
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
Re-enable media/audio-data-url.html.
- platform/gtk/Skipped:
2009-10-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] data: uri support in media player
https://bugs.webkit.org/show_bug.cgi?id=29842
New GStreamer element to handle data: uris. For now only base64
encoded data is supported. Decoded data is handed over to
giostreamsrc.
- GNUmakefile.am:
- platform/graphics/gtk/DataSourceGStreamer.cpp: Added. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
- platform/graphics/gtk/DataSourceGStreamer.h: Added.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mimeTypeCache):
Sep 30, 2009:
- 11:24 PM Changeset in webkit [48962] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Added myself to the list of committers.
- Scripts/modules/committers.py:
- 10:56 PM Changeset in webkit [48961] by
-
- 10 edits7 adds in trunk
2009-09-30 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Reduces false positives in the XSSAuditor by explicitly allowing requests
that do not contain illegal URI characters.
As a side effect of this change, the tests property-inject.html,
property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html
fail because these attacks do not contain any illegal URI characters and
thus are now allowed by the XSSAuditor, where previously they weren't. A future
change may reinstate this functionality.
Tests: http/tests/security/xssAuditor/script-tag-safe2.html
http/tests/security/xssAuditor/script-tag-safe3.html
- page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Added method. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::findInRequest): Added parameter allowRequestIfNoIllegalURICharacters.
- page/XSSAuditor.h:
2009-09-30 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that the XSSAuditor allows requests that do not contain illegal URI
characters.
Added a notice regarding the failure of tests property-inject.html,
property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html,
and rebased the expected results of these tests.
- http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
- http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
- http/tests/security/xssAuditor/property-escape-noquotes.html:
- http/tests/security/xssAuditor/property-inject-expected.txt:
- http/tests/security/xssAuditor/property-inject.html:
- http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added.
- http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added.
- http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added.
- http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe2.html: Added.
- http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe3.html: Added.
- 10:52 PM Changeset in webkit [48960] by
-
- 2 edits1 add in trunk/WebCore
reproducible freeze and crash on closing form popup at bosch-home.nl
https://bugs.webkit.org/show_bug.cgi?id=28948
Reviewed by Maciej Stachowiak.
showModalDialog calls getDirect on what is actually a window shell,
so ends up not getting a value (since no value can ever be placed
directly on the shell), which leads to incorrect behaviour.
We use a manual test rather than automatic as it was not
possible to get a modal run loop to work inside DRT.
- 10:49 PM Changeset in webkit [48959] by
-
- 8 edits6 adds in trunk
2009-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add ValidityState.tooLong support for <input> and <textarea>.
https://bugs.webkit.org/show_bug.cgi?id=27454
- fast/forms/ValidityState-tooLong-input-expected.txt: Added.
- fast/forms/ValidityState-tooLong-input.html: Added.
- fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
- fast/forms/ValidityState-tooLong-textarea.html: Added.
- fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
- fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.
2009-09-30 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Adds ValidityState.tooLong support for <input> and <textarea>.
Introduces tooLong() in HTMLFormControlElement and it always returns false.
HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
length and maxLength. tooLong() should work only for `dirty' values.
So, introduces m_isDirty flag for HTMLTextAreaElement, and
!m_data.value().isNull() works as a dirty flag for HTMLInputElement.
Renames parameter names of setMaxLength().
Tests: fast/forms/ValidityState-tooLong-input.html
fast/forms/ValidityState-tooLong-textarea.html
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::tooLong):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): (WebCore::HTMLInputElement::setMaxLength):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::setMaxLength): (WebCore::HTMLTextAreaElement::tooLong):
- html/HTMLTextAreaElement.h:
- html/ValidityState.h: (WebCore::ValidityState::tooLong):
- 10:12 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:11 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:06 PM QtWebKitProfilingSetup edited by
- (diff)
- 10:04 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:52 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:42 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:39 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:37 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:30 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:25 PM Changeset in webkit [48958] by
-
- 5 edits in trunk/WebCore
2009-09-30 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Factor RedirectScheduler out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=29948
This change introduces a new sub-object of Frame, redirectScheduler.
The redirectScheduler is responsible for scheduling redirects.
This change leaves the code for the redirectScheduler in
FrameLoader.cpp. A future change will move the class into its own
file.
No behavior change (hopefully!).
- loader/FrameLoader.cpp: (WebCore::RedirectScheduler::RedirectScheduler): (WebCore::RedirectScheduler::~RedirectScheduler): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::FrameLoader::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::FrameLoader::scheduleRefresh): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::open):
- loader/FrameLoader.h: (WebCore::FrameLoader::committedFirstRealDocumentLoad):
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::redirectScheduler):
- page/Frame.h:
- 9:22 PM QtWebKitProfilingSetup edited by
- (diff)
- 9:02 PM QtWebKitProfilingSetup created by
- 8:37 PM Changeset in webkit [48957] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
- 8:18 PM QtBackLog edited by
- (diff)
- 8:17 PM QtWebKitPerformanceWork edited by
- (diff)
- 8:14 PM Changeset in webkit [48956] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
- 8:12 PM QtWebKitMirrorGuide edited by
- (diff)
- 7:59 PM Changeset in webkit [48955] by
-
- 11 edits3 adds in trunk/WebCore
2009-09-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be.
Only Audio, Image, and Option should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=29940
Test: fast/dom/dom-constructor.html
- WebCore.gypi: Added new files to project.
- bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement and HTMLAudioElement construction.
- bindings/v8/V8HTMLAudioElementConstructor.h: Added.
- bindings/v8/V8HTMLImageElementConstructor.h: Added.
- bindings/v8/V8HTMLOptionElementConstructor.h: Added.
- bindings/v8/V8Index.cpp: Added new headers.
- bindings/v8/V8Index.h: Added Audio, Image and Option decls.
- bindings/v8/custom/V8CustomBinding.h: Ditto.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER): Added custom constructors.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator.
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto.
- 6:13 PM Changeset in webkit [48954] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by George Staikos.
Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122
Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.
Modified by George Wright <gwright@rim.com> to correctly work
with the RVCT-defined TARGET_ARCH_ARM and TARGET_ARCH_THUMB
compiler macros, as well as adding readability changes.
- wtf/Platform.h:
- 6:09 PM Changeset in webkit [48953] by
-
- 7 edits in trunk
2009-09-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943
Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
Test: http/tests/loading/resources/redirect-methods-result.php
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Pass along http body and Content-Type header.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto
2009-09-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
307 redirects should pass along http body and Content-Type header
https://bugs.webkit.org/show_bug.cgi?id=29943
Follow-up fix for:
<rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET
- http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/loading/resources/redirect-methods-result.php:
- 5:40 PM Changeset in webkit [48952] by
-
- 4 edits in trunk/WebCore
Fixed https://bugs.webkit.org/show_bug.cgi?id=29941
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30
Reviewed by Mark Rowe.
Forgot to implement a destructor for JSDOMWindowBaseData, so it was
leaking its RefPtr data member.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData):
- bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData):
- 5:13 PM Changeset in webkit [48951] by
-
- 2 edits in trunk/WebCore
Make sure the removal of user stylesheets results in all of the WebViews being updated to
reflect the changes.
Reviewed by Tim Hatcher.
- page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
- 3:30 PM Changeset in webkit [48950] by
-
- 3 edits1 move in trunk/LayoutTests
2009-09-30 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Use a script-tests directory rather than a resources directory for DOM Storage
https://bugs.webkit.org/show_bug.cgi?id=29938
Use a script-tests directory rather than a resources directory for DOM Storage.
This matches up with what's been done elsewhere in the tree.
- storage/domstorage/localstorage/clear.html:
- storage/domstorage/resources: Removed.
- storage/domstorage/resources/clear.js: Removed.
- storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
- storage/domstorage/sessionstorage/clear.html:
- 3:06 PM Changeset in webkit [48949] by
-
- 2 edits in trunk/WebKitTools
2009-09-30 Eric Seidel <eric@webkit.org>
No review, just adding Geoff to the list of reviewers.
- Scripts/modules/committers.py:
- 2:42 PM WikiStart edited by
- Point the coding style guidelines to the offical on the WebKit website. (diff)
- 2:32 PM Changeset in webkit [48948] by
-
- 2 edits in trunk/JavaScriptCore
Devirtualise array toString conversion
Reviewed by Geoff Garen.
Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.
- 2:15 PM Changeset in webkit [48947] by
-
- 4 edits2 adds in trunk
REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
https://bugs.webkit.org/show_bug.cgi?id=29209
Reviewed by Sam Weinig.
WebCore:
Test: fast/inline/relative-positioned-overflow.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
inlines to overflow to ensure that they are included in hit-testing.
LayoutTests:
- fast/inline/relative-positioned-overflow-expected.txt: Added.
- fast/inline/relative-positioned-overflow.html: Added.
- platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
- 1:56 PM Changeset in webkit [48946] by
-
- 7 edits in trunk/WebKit
Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
Reviewed by Dan Bernstein.
WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _allowsFollowingLink:]):
- WebView/WebFramePrivate.h:
WebKit/win:
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
(WebFrame::allowsFollowingLink):
- WebFrame.h:
- 1:19 PM Changeset in webkit [48945] by
-
- 3 edits1 add in trunk/WebCore
2009-09-30 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
transforms/3d tests are not run in Release builds
https://bugs.webkit.org/show_bug.cgi?id=29827
Make sure we export the WebCoreHas3DRendering symbol in Release builds,
because this symbols is used by run-webkit-tests (via 'nm') to detect whether
WebCore was built with ENABLE_3D_RENDERING turned on.
- DerivedSources.make:
- WebCore.3DRendering.exp: Added.
- WebCore.xcodeproj/project.pbxproj:
- 12:44 PM Changeset in webkit [48944] by
-
- 1 edit2 adds in trunk/WebKitTools
Added the WebKit Layout Tests fonts that are referenced in
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
Reviewed by Sam Weinig.
- DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
- DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
- 12:38 PM Changeset in webkit [48943] by
-
- 3 edits in trunk/WebKit/qt
Add the failed URL to the ErrorPageExtension, as it is quite
useful for creating error pages.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30
Reviewed by David Hyatt.
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
- 12:33 PM Changeset in webkit [48942] by
-
- 2 edits in trunk/WebCore
Build fix for QT. Didn't know WebCore.pro existed.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30
- WebCore.pro:
- 12:25 PM Changeset in webkit [48941] by
-
- 11 edits in trunk
WebCore: Add a method for removal of user scripts and stylesheets by URL from a specific world.
Reviewed by Adam Roben.
- page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentURLForWorld):
- page/PageGroup.h:
WebKit/mac: Add the ability to remove user stylesheets and scripts by URL.
Reviewed by Adam Roben.
- WebView/WebView.mm:
(+[WebView _removeUserContentFromGroup:url:worldID:]):
- WebView/WebViewPrivate.h:
WebKit/win: Add the ability to remove user stylesheets and scripts by URL.
Reviewed by Adam Roben.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeUserContentWithURLFromGroup):
- WebView.h:
- 12:01 PM Changeset in webkit [48940] by
-
- 2 edits in trunk/WebCore
2009-09-30 Chris Hawk <hawk@chromium.org>
Reviewed by Dimitri Glazkov.
Fix for conditionals in the WebCore gyp file, which contained two separate
'conditions' values for the webcore target. The first entry was ignored,
resulting in some missine defines.
https://bugs.webkit.org/show_bug.cgi?id=29907
- WebCore.gyp/WebCore.gyp:
- 11:52 AM Changeset in webkit [48939] by
-
- 10 edits in trunk/WebCore
2009-09-21 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed.
https://bugs.webkit.org/show_bug.cgi?id=29265
DOM Storage needs to be more careful about where "ThreadSafe" objects are
destroyed. With the current code, there actually isn't a race condition, but
it sure would be easy for someone to introduce one. A bunch of
ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared
objects. If it were possible any of these objects' destructors to be fired off
the main thread, then the you'd have a race condition. The code should be more
clear and self-documenting about how things related to each other.
Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread
which is bounded by the StorageSyncManager, StorageAreaImpl, and
StorageAreaSync, there's no reason for LocalStorageTask to store anything other
than pointers. By breaking this dependency, we can eliminate the risk.
Note that we _could_ have LocalStorageThread's task queue just store
LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to
manually take care of deleting. It'd probably also be possible to change
LocalStorageThread around so that it needn't hold onto a reference of itself
and have a more deterministic shutdown, but my initial attempts to do so
failed, and I decided it wasn't worth changing. The queue is killed before
hand, so the thread is 100% impotent before the main thread continues anyway.
The constructors and destructors of StorageSyncManager, StorageAreaImpl, and
StorageAreaSync now have ASSERTs to verify they're running on the main thread.
I'm fairly positive that it'd be impossible to hit these asserts and the fact
that these classes are no longer ThreadSafeShared should make it clear how
they're meant to be used, but I think it's worth it to be extra sure. Of
course, ideally, we'd have such an assert every time a ref is incremented or
decremented.
Behavior should be unchanged and this is just an internal code cleanup, so no
new tests.
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync): (WebCore::LocalStorageTask::createTerminate):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
- storage/LocalStorageThread.h:
- storage/StorageArea.h:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::~StorageAreaImpl): (WebCore::StorageAreaImpl::StorageAreaImpl):
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::~StorageAreaSync):
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 11:26 AM Changeset in webkit [48938] by
-
- 2 edits in trunk/JavaScriptCore
Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30
Reviewed by Geoffrey Garen.
After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
- Declaration of "OperandTypes types" moved before first use.
- Typos fixed: dst modified to result, regT2 added.
- Unreachable code removed.
(JSC::JIT::emitSlow_op_add):
- Missing declaration of "OperandTypes types" added.
- 11:17 AM Changeset in webkit [48937] by
-
- 9 edits1 copy in trunk/WebCore
2009-09-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Chromium needs to be able to override the way storage events are delivered
https://bugs.webkit.org/show_bug.cgi?id=29655
Chromium needs to be able to override the way storage events are delivered.
This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
faster (no vtables and extra allocation) and somewhat cleaner (no dependency
injection). This is necessary because Chromium needs to transport events across
a process barrier and then dispatch them without use of a Frame*.
Behavior should not change with this, so no updates to tests.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
- storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp. (WebCore::StorageEventDispatcher::dispatch):
- storage/StorageEventDispatcher.h: Added. (Well, technically in the other half of this patch.)
- 11:15 AM Changeset in webkit [48936] by
-
- 4 edits in trunk
Versioning.
- 11:11 AM Changeset in webkit [48935] by
-
- 1 copy in tags/Safari-532.1
New tag.
- 10:52 AM Changeset in webkit [48934] by
-
- 3 edits2 adds in trunk
Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929
Reviewed by Darin Adler.
WebCore:
Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
LayoutTests:
Add a new test for the bug.
- http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
- http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.
- 10:33 AM Changeset in webkit [48933] by
-
- 38 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png.
- 10:21 AM Changeset in webkit [48932] by
-
- 6 edits4 adds in trunk
2009-09-29 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
ASSERTION FAILED: !repaintContainer repaintContainer == this Generalize the fix for this bug to account for cases where there may be multiple
containing blocks between the repaint container, and the container of the element
being repainted.
Test: compositing/repaint/opacity-between-absolute2.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): Call offsetFromAncestorContainer() to get the correct offset.
(WebCore::RenderBox::computeRectForRepaint): Ditto
- rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint): Ditto.
- rendering/RenderObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::offsetFromAncestorContainer): New method that computes an offset from some object in the ancestor container() chain.
- 10:15 AM Changeset in webkit [48931] by
-
- 4 edits in trunk/WebKitTools
2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by David Kilzer.
Make sunspider scripts work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=29656
- Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
- Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
- Scripts/webkitdirs.pm: currentPerlPath() added.
- 10:13 AM Changeset in webkit [48930] by
-
- 2 edits in trunk/WebKit
2009-09-30 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
- Keeping up with downstream revisions.
- Turning off v8 snapshot build step.
- chromium/DEPS
- 8:35 AM Changeset in webkit [48929] by
-
- 2 edits in trunk/WebCore
2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0.
This fixes https://bugs.webkit.org/show_bug.cgi?id=29736.
- platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
- 7:20 AM Changeset in webkit [48928] by
-
- 2 edits in trunk/JavaScriptCore
Reduce heap size on Symbian from 64MB to 8MB.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.
This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.
- runtime/Collector.h:
- 5:41 AM QtWebKitMirrorGuide edited by
- (diff)
- 5:33 AM QtWebKitMirrorGuide edited by
- (diff)
- 5:31 AM QtWebKitTodo edited by
- (diff)
- 5:16 AM Changeset in webkit [48927] by
-
- 10 edits in trunk/LayoutTests
[Qt] Update Skipped after #48873 and some expected files, whose
problems are the same (default font size reconciliation
16px/13px), but the previous update didn't contain them.
Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
Reviewed by Simon Hausmann.
- platform/qt/Skipped:
- platform/qt/css2.1/t040103-ident-04-c-expected.txt:
- platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
- platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
- platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
- platform/qt/css2.1/t1202-counter-05-b-expected.txt:
- platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
- platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
- platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- 5:02 AM Changeset in webkit [48926] by
-
- 3 edits1 move in trunk/LayoutTests
2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Move message-port-multi.js from resources to script-tests
https://bugs.webkit.org/show_bug.cgi?id=29798
Revert r48823. message-port-multi.js needs custom HTML.
- fast/events/message-port-multi-expected.txt:
- fast/events/message-port-multi.html:
- fast/events/resources/message-port-multi.js: Added. (channel.port2.onmessage):
- fast/events/script-tests/message-port-multi.js: Removed.
- 4:47 AM QtWebKitMirrorGuide edited by
- (diff)
- 3:49 AM Changeset in webkit [48925] by
-
- 18 edits in trunk/LayoutTests
2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Kilzer.
Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=12140
Fixes for JS files.
- fast/js/date-preserve-milliseconds-expected.txt:
- fast/js/script-tests/array-float-delete.js:
- fast/js/script-tests/array-tostring-ignore-separator.js:
- fast/js/script-tests/date-big-setmonth.js:
- fast/js/script-tests/date-negative-setmonth.js:
- fast/js/script-tests/date-preserve-milliseconds.js:
- fast/js/script-tests/number-tofixed.js:
- fast/js/script-tests/object-extra-comma.js:
- fast/js/script-tests/object-prototype-constructor.js:
- fast/js/script-tests/object-prototype-toLocaleString.js:
- fast/js/script-tests/regexp-lastindex.js:
- fast/js/script-tests/regexp-stack-overflow.js:
- fast/js/script-tests/string-split-ignore-case.js:
- fast/js/script-tests/toString-exception.js:
- fast/js/script-tests/toString-overrides.js:
- fast/js/script-tests/toString-stack-overflow.js:
- fast/js/toString-stack-overflow-expected.txt:
- 1:55 AM Changeset in webkit [48924] by
-
- 39 edits1 add in trunk/LayoutTests
2009-09-30 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Geolocation LayoutTests should use an HTML template.
https://bugs.webkit.org/show_bug.cgi?id=29179
Updates Geolocation LayoutTests to correctly use an HTML template so that
individual HTML files can be generated using make-script-test-wrappers.
This requires a new js-test-post.js which allows for asynchronous tests.
- fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.
- fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
- fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
- fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
- fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.
- fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
- fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
- fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.
- 1:38 AM QtWebKitMirrorGuide created by
- 1:13 AM Changeset in webkit [48923] by
-
- 2 edits in trunk/SunSpider
2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin Adler.
Platform specific null device replaced with a platform independent.
https://bugs.webkit.org/show_bug.cgi?id=29544
- sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.
- 1:06 AM QtWebKitPerformanceWork edited by
- (diff)
- 12:48 AM Changeset in webkit [48922] by
-
- 2 edits in trunk/JavaScriptCore
Fix CRASH() macro for Symbian build.
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.
- wtf/Assertions.h: Added missing }
- 12:03 AM QtWebKitPerformanceUtilities edited by
- (diff)
