Timeline
Oct 14, 2009:
- 11:41 PM Changeset in webkit [49610] by
-
- 3 edits3 adds in trunk
2009-10-14 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Adam Barth.
[HTML5] Add document.head
https://bugs.webkit.org/show_bug.cgi?id=30232
Test is fast/dom/document-head.html
- dom/Document.idl: added readonly attribute head
- 11:12 PM Changeset in webkit [49609] by
-
- 2 edits in trunk/WebCore
2009-10-14 Matt Mueller <mattm@chromium.org>
Reviewed by Darin Adler.
Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit. See http://crbug.com/20939.
https://bugs.webkit.org/show_bug.cgi?id=30347
https://bugs.webkit.org/show_bug.cgi?id=22772
Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 10:15 PM Changeset in webkit [49608] by
-
- 6 edits in trunk/WebCore
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Move scrolling code from FrameLoader to FrameView
https://bugs.webkit.org/show_bug.cgi?id=30370
This code is about controlling the Frame's view, not about loading
stuff into the frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::scrollToAnchor):
- page/FrameView.cpp: (WebCore::FrameView::scrollToFragment): (WebCore::FrameView::scrollToAnchor):
- page/FrameView.h:
- 8:24 PM Changeset in webkit [49607] by
-
- 44 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Geoff Garen.
Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
- 7:39 PM Changeset in webkit [49606] by
-
- 2 edits in trunk/WebKitSite
2009-10-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Document what state the build tree is expected to be in after a patch.
- coding/contributing.html:
- 7:14 PM Changeset in webkit [49605] by
-
- 3 edits4 adds in trunk
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Test that we allow sites to load scripts from their own domain as long
as they don't use query strings.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Reduce XSS auditor false positives by always letting pages load scripts
from their own host. We don't actually know of any false positives
that this prevents, but it seems like a good idea.
One subtly is that we don't add this exception for scripts that have a
query string because (1) URLs with query strings are more apt to
confuse servers and (2) it is much less common to load scripts with a
query string.
Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
http/tests/security/xssAuditor/script-tag-with-source-same-host.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- 5:33 PM Changeset in webkit [49604] by
-
- 2 edits in trunk/WebKit/mac
Unbreak the world.
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::restart):
- 5:14 PM Changeset in webkit [49603] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson and Jon Honeycutt
<rdar://problem/7304295> snapshots of halted plug-ins are missing
- Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition. (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view. (WebHaltablePlugin::restart): Clear the substitute image.
- 4:54 PM Changeset in webkit [49602] by
-
- 48 edits in trunk/WebCore
2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Kill virtual contextElement() method spread all over SVG code
https://bugs.webkit.org/show_bug.cgi?id=30183
Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.
Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
and remove vim modelines on all files I touched. No change in functionality, thus no new tests.
- svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
- svg/SVGAnimatedProperty.h: (WebCore::::synchronize): (WebCore::::startAnimation): (WebCore::::stopAnimation):
- svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGCircleElement.h: Ditto.
- svg/SVGClipPathElement.h: Ditto.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGDefsElement.h: Ditto.
- svg/SVGEllipseElement.h: Ditto.
- svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
- svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFELightElement.h: Remove virtual contextElement() method.
- svg/SVGFEMergeNodeElement.h: Ditto.
- svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element. (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
- svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
- svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGForeignObjectElement.h: Ditto.
- svg/SVGGElement.h: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGLineElement.h: Ditto.
- svg/SVGMPathElement.h: Ditto. Fix license indention.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGMaskElement.h: Ditto.
- svg/SVGPathElement.h: Ditto.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
- svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGRectElement.h: Ditto.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGScriptElement.h: Ditto.
- svg/SVGSwitchElement.h: Ditto.
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTRefElement.h: Remove virtual contextElement() method.
- svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTextPathElement.h: Remove virtual contextElement() method.
- svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute(). (WebCore::SVGViewSpec::parseViewSpec): Ditto.
- svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.
- 4:48 PM Changeset in webkit [49601] by
-
- 1 edit1 delete in trunk/LayoutTests
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
- platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 4:29 PM Changeset in webkit [49600] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:27 PM Changeset in webkit [49599] by
-
- 1 copy in tags/Safari-6531.21
New tag.
- 4:21 PM Changeset in webkit [49598] by
-
- 3 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 4:14 PM Changeset in webkit [49597] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Jon Honeycutt.
Export a few more showSubstituteImage() related methods.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- 4:11 PM Changeset in webkit [49596] by
-
- 1 edit2 deletes in trunk/LayoutTests
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
Reviewed by Mark Rowe.
Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- platform/win/fast/css/opacity-float-expected.txt: Removed.
- 4:04 PM Changeset in webkit [49595] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:00 PM Changeset in webkit [49594] by
-
- 2 edits in trunk/LayoutTests
Disable plugins/private-browsing-mode.html on Snow Leopard.
Reviewed by Sam Weinig.
- platform/mac-snowleopard/Skipped:
- 3:42 PM Changeset in webkit [49593] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r47620.
- 3:38 PM Changeset in webkit [49592] by
-
- 11 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.
- editing/execCommand/paste-1.html:
- editing/execCommand/paste-2.html:
- editing/pasteboard/subframe-dragndrop-1.html:
- editing/selection/4776665.html:
- editing/selection/4975120.html:
- editing/selection/5136696.html:
- editing/selection/drag-to-contenteditable-iframe.html:
- platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- 2:46 PM Changeset in webkit [49591] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48531.
- 2:46 PM Changeset in webkit [49590] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48529.
- 2:46 PM Changeset in webkit [49589] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48446.
- 2:46 PM Changeset in webkit [49588] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48396.
- 2:46 PM Changeset in webkit [49587] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48375.
- 2:46 PM Changeset in webkit [49586] by
-
- 10 edits in branches/safari-4-branch/WebCore
Merge r48370.
- 2:45 PM Changeset in webkit [49585] by
-
- 10 edits in trunk
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.
Patch by Darin Adler <Darin Adler> on 2009-10-14
- wtf/MathExtras.h: Added llround and llroundf for Windows.
WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
- 2:41 PM Changeset in webkit [49584] by
-
- 2 edits in trunk/WebCore
2009-10-14 Mark Seaborn <mseaborn@google.com>
Reviewed by Darin Adler.
Check error return value in Perl build script
https://bugs.webkit.org/show_bug.cgi?id=30316
- css/makevalues.pl: Die if gperf fails.
- 1:39 PM Changeset in webkit [49583] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r49580 as it is completely wrong and breaks the Mac builds.
- 1:30 PM Changeset in webkit [49582] by
-
- 12 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG wrong filterRegions for userSpaceOnUse and percentage values
https://bugs.webkit.org/show_bug.cgi?id=30330
Some clean-up of the SVG filter calculation code. This clean-up
also fixes the problem with percentage and userSpaceInUse mode.
Test: svg/filters/subRegion-in-userSpace.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::prepareFilter):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::create):
- svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h:
Reviewed by Nikolas Zimmermann.
Check if the percentage of effect values takes user space as reference and
not the FilterRect.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- svg/filters/subRegion-in-userSpace.svg: Added.
- 12:32 PM Changeset in webkit [49581] by
-
- 4 edits in trunk
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.
Reviewed by Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
LayoutTests: Un-skip a test that now passes.
Reviewed by Sam Weinig.
- platform/win/Skipped:
- 12:01 PM Changeset in webkit [49580] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.
- 11:51 AM Changeset in webkit [49579] by
-
- 3 edits in trunk/WebKitTools
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
- 11:41 AM Changeset in webkit [49578] by
-
- 2 edits in trunk/WebCore
The last change fixed the problem, removing diagnostic printfs.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 11:34 AM BuildingOnWindows edited by
- Add (non-ideal) workaround for Visual Studio 2005 missing Crypt32.lib error (diff)
- 11:31 AM Changeset in webkit [49577] by
-
- 3 edits in trunk/WebCore
CURL build fix for versions < 7.18.
- 11:30 AM Changeset in webkit [49576] by
-
- 1 edit1 add in trunk/LayoutTests
2009-10-14 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
When I landed r49569 for Victor, I failed to svn add one of the required files.
This should fix the redness on the Windows test bots.
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 11:18 AM Changeset in webkit [49575] by
-
- 2 edits in trunk/WebCore
One more round of changes to figure out why the webgl
tests are crashing on the build bot. Here I am trying
to see if we can create a software renderer. I am also
printing the found pixel formats.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:42 AM Changeset in webkit [49574] by
-
- 8 edits7 adds in trunk/WebCore
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-14
Reviewed by
Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>,
Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
<norbert.leser@nokia.com>
- 10:34 AM Changeset in webkit [49573] by
-
- 8 edits in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: skip inspector tests that were recently added
until harness is fixed in release mode.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:29 AM Changeset in webkit [49572] by
-
- 2 edits in trunk/LayoutTests
Skip my two new failures while I'm actively looking at them.
- platform/win/Skipped:
- 10:18 AM Changeset in webkit [49571] by
-
- 2 edits in trunk/WebCore
More changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:11 AM Changeset in webkit [49570] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.
- 10:02 AM Changeset in webkit [49569] by
-
- 2 edits in trunk/LayoutTests
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add paste-xml test back for Win.
The result difference between Mac and Win is due to the
platform dependent implementation. The diff is expected
with current implementation.
See bug for more deails:
- platform/win/Skipped:
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 9:39 AM Changeset in webkit [49568] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 9:26 AM Changeset in webkit [49567] by
-
- 16 edits2 adds in trunk
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by David Hyatt.
Round non-integer line height values.
Change webkit to rounding non-integer line height values
instead of truncating them. This fixes a layout test
failure on Windows and matches the calculation in IE and Firefox.
- 9:23 AM Changeset in webkit [49566] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).
- 9:21 AM Changeset in webkit [49565] by
-
- 9 edits in trunk/WebCore
2009-10-13 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Removes the persistent setting for InspectorTimelineAgent and renames timeline related
interfaces to be more consistent with the JavaScript profiler.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::startTimelineProfiler): (WebCore::InspectorBackend::stopTimelineProfiler): (WebCore::InspectorBackend::timelineProfilerEnabled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineProfilerWasStarted): (WebCore::InspectorFrontend::timelineProfilerWasStopped):
- inspector/InspectorFrontend.h:
- inspector/front-end/TimelineAgent.js: (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- 9:03 AM Changeset in webkit [49564] by
-
- 20 edits6 adds in trunk
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905
Reviewed by Sam Weinig.
WebKit/win:
-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.
- Interfaces/IWebHistoryDelegate.idl: Added.
- Interfaces/IWebHistoryPrivate.idl:
- Interfaces/IWebNavigationData.idl: Added.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):
- WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
- WebView.h:
- WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
- WebHistory.h:
- WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
- WebNavigationData.h: Added.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):
- DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
- DumpRenderTree/win/DumpRenderTree.vcproj:
Add the IWebHistoryDelegate to DRT Windows:
- DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
- DumpRenderTree/win/HistoryDelegate.h: Added.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
- platform/win/Skipped: Enable globalhistory tests.
- 9:02 AM Changeset in webkit [49563] by
-
- 4 edits in trunk/WebKitTools
2009-10-14 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement support for setPOSIXLocale on Qt.
https://bugs.webkit.org/show_bug.cgi?id=30268
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPOSIXLocale):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 8:48 AM Changeset in webkit [49562] by
-
- 3 edits3 adds in trunk
2009-10-02 Yong Li <yong.li@torchmobile.com>
Reviewed by Adele Peterson.
Fixed crash when loading invalid image data.
Also added a test case that loads an invalid image to make sure
we don't crash in this situation.
https://bugs.webkit.org/show_bug.cgi?id=29980
WebCore:
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText):
LayoutTests:
- fast/images/image-invalid-data-expected.txt: Added.
- fast/images/image-invalid-data.html: Added.
- fast/images/resources/invalid.jpg: Added.
- 8:40 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 8:30 AM QtBackLog edited by
- (diff)
- 8:02 AM Changeset in webkit [49561] by
-
- 3 edits2 adds in trunk
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
Test: fast/canvas/canvas-toDataURL-crash.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
- fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
- fast/canvas/canvas-toDataURL-crash.html: Added.
- 7:54 AM Changeset in webkit [49560] by
-
- 14 edits in trunk/WebCore
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, reverting r49558 since it broke profiler tests.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 7:10 AM Changeset in webkit [49559] by
-
- 3 edits in trunk/WebCore
ImageDecoderQt: Minor tweaks to the decoder
- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more than four byte.
- 6:32 AM Changeset in webkit [49558] by
-
- 14 edits in trunk/WebCore
2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 2:14 AM Changeset in webkit [49557] by
-
- 4 edits in trunk/WebCore
2009-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Don't collect call frame properties until they're needed for completion.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties. (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
- inspector/front-end/ScriptsPanel.js:
Oct 13, 2009:
- 10:14 PM Changeset in webkit [49556] by
-
- 2 edits in trunk/WebCore
2009-10-13 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=29106
[Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
compiler aggressively resolve inheritance of class R.
The winscw compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in winscw compiler.
- loader/CachedResourceHandle.h: (WebCore::::CachedResourceHandle):
- 9:43 PM Changeset in webkit [49555] by
-
- 8 edits1 copy in trunk
2009-10-13 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49554, because it broke Win and Chromium builds.
http://trac.webkit.org/changeset/49554
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
- 9:09 PM Changeset in webkit [49554] by
-
- 8 edits1 delete in trunk
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
- css/CSSPrimitiveValue.cpp: (WebCore::appendCSSDouble): (WebCore::formatWithUnits): (WebCore::CSSPrimitiveValue::cssText):
- 8:52 PM Changeset in webkit [49553] by
-
- 2 edits in trunk/WebCore
2009-10-13 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
While we're rebaselining scrollbars, fix an off by one in the vertical
scrollbar rendering too.
Tests: this is covered by every pixel test involving scrollbars.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
- 8:37 PM Changeset in webkit [49552] by
-
- 3 edits in trunk/LayoutTests
2009-10-13 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
[LayoutTests][Gtk] Set a common Gtk theme as default and update the results
https://bugs.webkit.org/show_bug.cgi?id=30223
Update test results to reflect the usage of the default theme.
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- 8:16 PM Changeset in webkit [49551] by
-
- 3 edits2 adds in trunk
WebCore: Fix issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
Test: fast/events/clientXY-in-zoom-and-scroll.html
- dom/MouseRelatedEvent.cpp:
(WebCore::contentsX): Take page zoom into account.
(WebCore::contentsY): Ditto.
LayoutTests: Test issue where clientX and clientY on MouseEvents were wrong when
the page was zoomed and scrolled.
Reviewed by David Hyatt.
- fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- fast/events/clientXY-in-zoom-and-scroll.html: Added.
- 7:42 PM Changeset in webkit [49550] by
-
- 2 edits in trunk/WebKit/win
Fix more WebView bustage.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 7:22 PM Changeset in webkit [49549] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r48770.
- 7:22 PM Changeset in webkit [49548] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r48689.
- 7:22 PM Changeset in webkit [49547] by
-
- 2 edits in trunk/WebKit/win
Fix build bustage on Windows.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
- 7:03 PM Changeset in webkit [49546] by
-
- 2 edits in branches/safari-4-branch/WebKit/win
Merge r48324.
- 7:03 PM Changeset in webkit [49545] by
-
- 10 edits in branches/safari-4-branch
Merge r48308.
- 6:54 PM Changeset in webkit [49544] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, adding myself to reviewers list.
- Scripts/modules/committers.py:
- 6:52 PM Changeset in webkit [49543] by
-
- 2 edits in trunk/WebKitTools
Fix null assignment so root tests work again.
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm:
- 6:38 PM Changeset in webkit [49542] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Fix DumpRenderTree to account for API changes in the user script stuff.
- 6:37 PM Changeset in webkit [49541] by
-
- 11 edits in trunk
WebCore: Change the order of arguments on some of the user stylesheet/script functions. Split the removal functions
out into separate ones for scripts and stylesheets.
Reviewed by Adam Roben.
- WebCore.base.exp:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
(WebCore::PageGroup::userScripts):
(WebCore::PageGroup::userStyleSheets):
WebKit/mac: Change the order of arguments on some methods. Split removal for user stylesheets and script into
separate functions based off the type of object being removed.
Reviewed by Adam Roben.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:worldID:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:worldID:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:worldID:url:]):
(+[WebView _removeUserStyleSheetFromGroup:worldID:url:]):
(+[WebView _removeUserScriptsFromGroup:worldID:]):
(+[WebView _removeUserStyleSheetsFromGroup:worldID:]):
- WebView/WebViewPrivate.h:
WebKit/win: Split removal functions for user scripts and stylehseets based on type.
Reviewed by Adam Roben..
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
- WebView.h:
- 6:16 PM Changeset in webkit [49540] by
-
- 2 edits in trunk/WebCore
Chrome's "Skia" theme paints select controls backwards in RTL.
Patch by Evan Martin <evan@chromium.org> on 2009-10-13
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=30320
Test: fast/text/international/bidi-menulist.html
(The test is about something else, but it includes RTL selects.)
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
- 6:15 PM Changeset in webkit [49539] by
-
- 12 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=30318
ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
into EventListener constructor but did not remove the code pulling ScriptExecutionContext.
Reviewed by Alexey Proskuryakov.
WebCore:
Tests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
All changes in files below are the same - remove the code that calls
EventTarget::scriptExecutionContext and checks it for NULL.
- bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
- bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
LayoutTests:
Test adds event listener to a DocumentType Node which is created without a document
and then dispatches the event after attaching a node to the tree. Event
should fire when node is attached to the tree.
- fast/events/add-event-without-document-expected.txt: Added.
- fast/events/add-event-without-document.html: Added.
- 6:04 PM Changeset in webkit [49538] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r48733.
- 6:04 PM Changeset in webkit [49537] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46725.
- 6:04 PM Changeset in webkit [49536] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46724.
- 6:04 PM Changeset in webkit [49535] by
-
- 3 edits in branches/safari-4-branch/JavaScriptCore
Merge r46648.
- 6:04 PM Changeset in webkit [49534] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r46511.
- 6:04 PM Changeset in webkit [49533] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46387.
- 5:41 PM Changeset in webkit [49532] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Jon Honeycutt.
Add trailing newline to the Windows Skipped List.
- platform/win/Skipped:
- 5:36 PM Changeset in webkit [49531] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Add bug number to previous ChangeLog entry.
- 5:34 PM Changeset in webkit [49530] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Add plugins/private-browsing-mode.html to the Windows Skipped
list because the feature is not implemented on Windows.
- platform/win/Skipped:
- 5:33 PM Changeset in webkit [49529] by
-
- 4 edits3 adds in branches/safari-4-branch
Merge r48590.
- 5:24 PM Changeset in webkit [49528] by
-
- 24 edits in branches/safari-4-branch
Merge r46645.
- 4:58 PM Changeset in webkit [49527] by
-
- 2 edits in trunk/WebCore
2009-10-13 Simon Fraser <Simon Fraser>
Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 4:39 PM Changeset in webkit [49526] by
-
- 13 edits in trunk
Enable SHARED_WORKERS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=30289
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by David Levin.
WebCore:
Cleaned up bitrot in SharedWorker V8 bindings.
- WebCore.gypi:
Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
- bindings/v8/DerivedSourcesAllInOne.cpp:
Added V8SharedWorkerContext.cpp.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getTemplate):
Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
- bindings/v8/V8Index.cpp:
Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
- bindings/v8/V8Index.h:
Added definition for SHAREDWORKERCONTEXT wrapper.
- bindings/v8/WorkerContextExecutionProxy.cpp:
Added includes for SharedWorker.h and SharedWorkerContext.h.
- bindings/v8/custom/V8CustomBinding.h:
Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
Also added field indexes for SharedWorkers.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
Added runtime enabler for the SharedWorker constructor.
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Cleaned up bitrot (various APIs have changed since this file was written).
- page/DOMWindow.idl:
Added EnabledAtRuntime flag to window.SharedWorker.
WebKit:
- chromium/features.gypi:
Turned on ENABLE_SHARED_WORKERS by default. This doesn't actually turn on
SharedWorkers yet, as Chromium overrides this flag in its feature_overrides.gypi.
- 4:36 PM Changeset in webkit [49525] by
-
- 2 edits in trunk/WebCore
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=30345
HTTP tests for credential handling fail on Tiger
We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
let it do its work without intervention. Once again, we pass explicitly passed credentials
in URL, fixing regressions from Safari 3.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential):
- 4:19 PM Changeset in webkit [49524] by
-
- 2 edits in trunk/WebCore
2009-10-13 Roland Steiner <rolandsteiner@google.com>
Reviewed by Adam Barth.
Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface
Reworked and added to the getter/setter interface in ChromiumDataObject:
- added contains...() methods to just query the state
- added containsValid...URL() methods for URL data members
- removed takeFileNames() as this was too type-dependent
- changed return type of fileNames() to Vector<String>
- added interface methods to allow appending to and iteration over file names
No new tests (no functional behavior changed).
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::containsMainURL): (WebCore::ChromiumDataObject::containsValidMainURL): (WebCore::ChromiumDataObject::containsMainURLTitle): (WebCore::ChromiumDataObject::containsTextPlain): (WebCore::ChromiumDataObject::containsTextHTML): (WebCore::ChromiumDataObject::containsHTMLBaseURL): (WebCore::ChromiumDataObject::containsValidHTMLBaseURL): (WebCore::ChromiumDataObject::containsContent): (WebCore::ChromiumDataObject::containsContentFileExtension): (WebCore::ChromiumDataObject::containsContentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::containsFileNames): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::clearFileNames): (WebCore::ChromiumDataObject::countFileNames): (WebCore::ChromiumDataObject::fileNameAt): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::appendToFileNames): (WebCore::ChromiumDataObject::popFileName):
- 4:05 PM Changeset in webkit [49523] by
-
- 7 edits in branches/safari-4-branch
Merge r49111.
- 4:03 PM Changeset in webkit [49522] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r47534.
- 3:57 PM Changeset in webkit [49521] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r49133.
- 3:53 PM Changeset in webkit [49520] by
-
- 4 edits4 adds in trunk
2009-10-13 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Visibility:visible inside a compositing layer doesn't make the element visible
https://bugs.webkit.org/show_bug.cgi?id=30339
When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
only consulted hasVisibleContent(), which does not take into a account child layers which
may be visible. We also have to consult hasVisibleDescendant() as well.
Test: compositing/compositing-visible-descendant.html
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleDescendant):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 3:51 PM Changeset in webkit [49519] by
-
- 8 edits4 copies3 adds in trunk/WebKitTools
2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
This is done in preparation of implementing missing features in DRT.
No functionality changes made yet.
- DumpRenderTree/qt/DumpRenderTree.cpp:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/EventSenderQt.cpp: Added. (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::keyDown): (EventSender::contextClick): (EventSender::scheduleAsynchronousClick): (EventSender::frameUnderMouse):
- DumpRenderTree/qt/EventSenderQt.h: Added. (EventSender::clearKillRing):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::windowCount): (LayoutTestController::clearBackForwardList): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::provisionalLoad): (LayoutTestController::timerEvent): (LayoutTestController::encodeHostName): (LayoutTestController::decodeHostName): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setFixedContentsSize): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::disableImageLoading): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::overridePreference):
- DumpRenderTree/qt/LayoutTestControllerQt.h: Added. (LayoutTestController::isLoading): (LayoutTestController::setLoading): (LayoutTestController::shouldDumpAsText): (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::shouldDumpChildrenAsText): (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::shouldWaitUntilDone): (LayoutTestController::canOpenWindows): (LayoutTestController::shouldDumpTitleChanges): (LayoutTestController::waitForPolicy): (LayoutTestController::dumpAsText): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setCanOpenWindows): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::display): (LayoutTestController::dumpTitleChanges): (LayoutTestController::dumpSelectionRect):
- DumpRenderTree/qt/TextInputControllerQt.cpp: Added. (TextInputController::TextInputController): (TextInputController::doCommand):
- DumpRenderTree/qt/TextInputControllerQt.h: Added.
- DumpRenderTree/qt/WorkQueue.cpp:
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
- DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
- DumpRenderTree/qt/jsobjects.h:
- 3:50 PM Changeset in webkit [49518] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r49433.
- 3:50 PM Changeset in webkit [49517] by
-
- 5 edits in branches/safari-4-branch
Merge r48492.
- 3:37 PM Changeset in webkit [49516] by
-
- 8 edits1 delete in branches/safari-4-branch
Merge r49026.
- 3:17 PM Changeset in webkit [49515] by
-
- 7 edits in trunk
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API
support is not enabled.
Remove notImplemented() from PluginPackageNone.cpp and
PluginDataNone.cpp make them just empty functions.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins): (WebCore::PluginData::refresh):
- plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::determineQuirks): (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
- wtf/Platform.h:
- 3:02 PM Changeset in webkit [49514] by
-
- 2 edits in trunk/WebKitTools
Not reviewed, adding myself to the list of reviewers.
- Scripts/modules/committers.py:
- 3:02 PM Changeset in webkit [49513] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30150
<rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types
Test: editing/pasteboard/crash-accessing-clipboardData-types.html
- platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String class doesn't have operator bool, it's operator NSString* that is invoked instead, and it converts null strings to non-null @"".
- 2:59 PM Changeset in webkit [49512] by
-
- 16 edits2 adds in trunk
<rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
Reviewed by Sam Weinig.
WebKit/mac:
Listen for WebPreferences notifications and update the _isPrivateBrowsingEnabled ivar
when the value changes. Also call -[WebBaseNetscapePluginView privateBrowsingModeDidChange] when the
value changes. In process this just calls NPP_SetValue, and OOP it sends a MIG message to the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::privateBrowsingModeDidChange):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView privateBrowsingModeDidChange]):
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView privateBrowsingModeDidChange]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
(-[WebNetscapePluginView getVariable:value:]):
WebKitTools:
Make the private browsing mode testable by the test plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_SetValue):
LayoutTests:
Add test.
- platform/mac-snowleopard/Skipped:
Remove now passing tests that was fixed by https://bugs.webkit.org/show_bug.cgi?id=30295.
- plugins/private-browsing-mode-expected.txt: Added.
- plugins/private-browsing-mode.html: Added.
- 2:54 PM Changeset in webkit [49511] by
-
- 3 edits5 adds in branches/safari-4-branch
Merge r47494.
- 2:44 PM Changeset in webkit [49510] by
-
- 7 edits in trunk/WebCore
window attributes (like localStorage) that are disabled at runtime are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240
Patch by Drew Wilson <atwilson@atwilson-macpro.local> on 2009-10-13
Reviewed by Dimitri Glazkov.
Adding codegen/bindings to support runtime disabling of attributes.
No new tests (only supported by chrome currently)
- bindings/scripts/CodeGeneratorV8.pm:
Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
- bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes):
Refactored attribute setting code into a common inline routine.
- bindings/v8/V8Proxy.h:
(WebCore::configureAttribute):
Inline function which configures a single attribute given a BatchedAttribute struct.
- bindings/v8/custom/V8CustomBinding.h:
Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
- page/DOMWindow.idl:
Added [EnabledAtRuntime] extended attribute to the Audio attribute.
- 2:24 PM Changeset in webkit [49509] by
-
- 5 edits in trunk/JavaScriptCore
2009-10-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034
Change reinterpret_cast<void*> to regular C style (void*) cast
for the ARM RVCT compiler.
- assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr):
- jit/JITOpcodes.cpp: Cast to FunctionPtr first
instead of directly casting to reinterpret_cast
- jit/JITStubCall.h: Ditto + change the type of m_stub from void* to FunctionPtr. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::call):
- jit/JITStubs.cpp: Ditto. (JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):
- 1:53 PM Changeset in webkit [49508] by
-
- 4 edits3 adds in trunk
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Test case for static email validation on type=email input elements as
per HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
- fast/forms/ValidityState-typeMismatch-email-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-email.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-email.js: Added. ():
2009-10-13 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27457
Added support for static validation on type=email input elements as per
HTML5 specs:
http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
Test: fast/forms/ValidityState-typeMismatch-email.html
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch performs validation on type=email input elements now. (WebCore::ValidityState::isValidEmailAddress): simple validation method
- html/ValidityState.h:
- 1:27 PM Changeset in webkit [49507] by
-
- 5 edits7 adds in trunk
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
- http/tests/security/resources/has-window-events.html: Added.
- http/tests/security/window-events-clear-domain-expected.txt: Added.
- http/tests/security/window-events-clear-domain.html: Added.
- http/tests/security/window-events-clear-port-expected.txt: Added.
- http/tests/security/window-events-clear-port.html: Added.
- http/tests/security/window-events-pass-expected.txt: Added.
- http/tests/security/window-events-pass.html: Added.
2009-10-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Event listeners installed on a window object returned from window.open() don't work
https://bugs.webkit.org/show_bug.cgi?id=28716
Tests: http/tests/security/window-events-clear-domain.html
http/tests/security/window-events-clear-port.html
http/tests/security/window-events-pass.html
- dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all window event handlers when implicitOpen is called. It is called in 2 cases - on committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).
(WebCore::Document::open): in addition to calling implicitOpen it also removes window
event handlers, to preserve the behavior of document.open().
(WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
does not remove window event handlers.
- dom/Document.h: Removed clear().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers if we transition from temporary empty document to a loaded one.
(WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
(WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.
- 1:03 PM Changeset in webkit [49506] by
-
- 3 edits in trunk/WebCore
Fix a leak in the inspector by calling didRemoveNode with
an error code when it fails, instead of returning from the
Backend.
Reviewed by Pavel Feldman.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/front-end/ElementsTreeOutline.js:
- 12:01 PM Changeset in webkit [49505] by
-
- 8 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
Web Inspector: Should be able to delete nodes from the Elements Tree.
Reviewed by Timothy Hatcher.
When the delete key is pressed and a element is selected in the tree,
the element should be deleted from the Elements Tree and the DOM.
- inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::removeNode):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didRemoveNode):
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):
- 10:08 AM Changeset in webkit [49504] by
-
- 2 edits in trunk/WebCore
Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
Reviewed by Timothy Hatcher.
Set pointer-events: none on the new overlay so mouseover events are passed
to the resources graph so we can show timings.
- inspector/front-end/inspector.css:
- 10:04 AM Changeset in webkit [49503] by
-
- 2 edits in trunk/WebKitTools
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
No review, just adding self to the list of reviewers.
- Scripts/modules/committers.py:
- 7:27 AM Changeset in webkit [49502] by
-
- 8 edits in trunk
2009-10-13 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/qt/QWebPageClient.h:
- plugins/qt/PluginViewQt.cpp: (WebCore::setSharedXEventFields): (WebCore::PluginView::initXEvent): (WebCore::PluginView::getValue): (WebCore::PluginView::platformStart):
2009-10-13 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Simon Hausmann.
[Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
This is a bug for two reasons:
- Everytime we use winId(), we end up creating a native widget. This causes an unnecessary copy of contents from the backing store to the native widget.
- Neither windowed nor windowless plugins require the winId of the QWebView or QGraphicsView.
Introduce ownerWidget() which returns a QWidget * without creating a native widget
(as opposed to QWidget::find(winId)).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::ownerWidget):
- Api/qwebview.cpp: (QWebViewPrivate::ownerWidget):
- 6:26 AM Changeset in webkit [49501] by
-
- 2 edits in trunk/WebCore
Unreviewed fix for typo in filename
- 5:14 AM Changeset in webkit [49500] by
-
- 1 edit7 deletes in trunk/LayoutTests
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Layout test fix, reverting previous change.
Reverting r49499 as it caused several layout test failures.
- inspector/console-tests-expected.txt: Removed.
- inspector/console-tests.html: Removed.
- inspector/elements-panel-structure-expected.txt: Removed.
- inspector/elements-panel-structure.html: Removed.
- inspector/evaluate-in-frontend-expected.txt: Removed.
- inspector/evaluate-in-frontend.html: Removed.
- inspector/evaluate-in-frontend.js: Removed.
- 4:53 AM Changeset in webkit [49499] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-10-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 4:35 AM Changeset in webkit [49498] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Add some initial autotests for QWebPage's ErrorPageExtention
https://bugs.webkit.org/show_bug.cgi?id=30296
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
(ErrorPage::ErrorPage):
(ErrorPage::supportsExtension):
(ErrorPage::extension):
(tst_QWebPage::errorPageExtension):
- 3:57 AM Changeset in webkit [49497] by
-
- 3 edits in trunk/WebKit/qt
[Qt] better handle possible edge cases on qwebframe::requestedUrl use
https://bugs.webkit.org/show_bug.cgi?id=30216
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
QWebFrame::requestedUrl can be called at any time during the load
process, including:
- An error handling (whereas an alternate error page for unsuccessful load is being set);
- A ssl error exception call;
- Navigation notifications (titleChanged, urlChanged, progresses, addHistoryEntry, etc);
- Among others.
This patch makes requestedUrl calls to fallback to FrameLoaderClient
m_loadError's failingURL when an error has occurred, unless it is
null/empty.
Also, m_loadError is now being reset at each the main frame starts a
load, in order to avoid previous load errors footprints.
- Api/qwebframe.cpp:
(QWebFrame::requestedUrl):
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
- 1:28 AM Changeset in webkit [49496] by
-
- 2 edits in trunk/WebKitTools
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Roben.
Web Inspector: Use proper web view in inspector layout
tests for windows.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 1:26 AM Changeset in webkit [49495] by
-
- 3 edits in trunk/WebCore
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Alter profile link format to enable multiple profile types
https://bugs.webkit.org/show_bug.cgi?id=30253
The new profile URL includes the profile type along with the
profile title and uid.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.linkifyStringAsFragment):
- 1:19 AM Changeset in webkit [49494] by
-
- 2 edits in trunk/WebCore
2009-10-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Fix same-named profiles grouping in the Profiles panel.
The tree node re-parenting while adding a new group node was broken.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfile):
- 1:16 AM Changeset in webkit [49493] by
-
- 2 edits in trunk/WebCore
2009-10-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enforce async interaction between inspector controller and frontend.
- inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch):
Oct 12, 2009:
- 11:11 PM Changeset in webkit [49492] by
-
- 6 edits in trunk
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- platform/qt/Skipped:
2009-10-12 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Missing default value for the default text encoding.
https://bugs.webkit.org/show_bug.cgi?id=30311
QtWebKit has provided a default, hardcoded value for default charset but since
the addition of the defaultTextEncoding setting in QWebSettings, that hardcoded
value has had no effect.
Added a regression test and unskipped fast/dom/Document/document-charset.html,
which is passing now.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::defaultTextEncoding):
- 10:38 PM Changeset in webkit [49491] by
-
- 2 edits in trunk/WebKitSite
Change <a name> to id="" to fix styling problems
https://bugs.webkit.org/show_bug.cgi?id=30283
Reviewed by Eric Seidel.
This prevents the headings from being styled like links.
- coding/contributing.html:
- 9:59 PM Changeset in webkit [49490] by
-
- 7 edits in trunk
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
- fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
- fast/dom/elementFromPoint-relative-to-viewport.html:
2009-10-12 Xiaomei Ji <xji@chromium.org>
Reviewed by Sam Weinig.
Fix issue caretRangeFromPoint() returns wrong result for a zoomed and
scrolled page.
https://bugs.webkit.org/show_bug.cgi?id=30034
- dom/Document.cpp: (WebCore::Document::elementFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled. (WebCore::Document::caretRangeFromPoint): calculate the correct point relative to document when the page is zoomed and scrolled.
- 9:22 PM Changeset in webkit [49489] by
-
- 5 edits in trunk/LayoutTests
2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed. Fix 4 layout test failures by webkit r49488
WebKit r49488 enables window.WebSocket back.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 6:44 PM Changeset in webkit [49488] by
-
- 9 edits6 adds in trunk
WebCore: JavaScript bindings of WebSocket addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
Test: fast/websockets/websocket-event-target.html
- bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
- websockets/WebSocket.idl:
WebKitTools: Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
LayoutTests: Add a test to verify WebSocket's EventTarget methods.
https://bugs.webkit.org/show_bug.cgi?id=29841
Patch by Fumitoshi Ukai <ukai@chromium.org> on 2009-10-06
Reviewed by NOBODY (OOPS!).
- fast/websockets/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
- fast/websockets/script-tests/websocket-event-target.js: Added.
(openListener):
(messageListener):
(closeListener):
- fast/websockets/websocket-event-target-expected.txt: Added.
- fast/websockets/websocket-event-target.html: Added.
- 5:47 PM Changeset in webkit [49487] by
-
- 5 edits13 deletes in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
<rdar://problem/7288221>
Reviewed by Darin Adler.
WebCore:
Add a mechanism to blacklist certain codecs. Initially, just blacklist UTF-7 as HTML5 encourages.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
LayoutTests:
Test the lack of UTF-7 support. Remove old UTF-7 tests.
- fast/encoding/char-decoding-expected.txt:
- fast/encoding/char-decoding.html:
- http/tests/misc/submit-get-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-get-in-utf7.html: Removed.
- http/tests/misc/submit-post-in-utf7-expected.txt: Removed.
- http/tests/misc/submit-post-in-utf7.html: Removed.
- http/tests/misc/url-in-utf7-expected.txt: Removed.
- http/tests/misc/url-in-utf7.html: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/http-equiv-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-encoded.html: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Removed.
- 5:37 PM Changeset in webkit [49486] by
-
- 9 edits2 adds in trunk
Add support for the beforeload event to frames. Complete support of the beforeload event by making sure
its wrapper gets properly constructed (so that the URL field of the event can be accessed). Add support
for the Objective-C wrapper class as well.
Reviewed by Darin Adler.
Added fast/dom/beforeload/frame-before-load.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMEvents.mm:
(kitClass):
- dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::isBeforeLoadEvent):
- dom/Event.cpp:
(WebCore::Event::isBeforeLoadEvent):
- dom/Event.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- 5:27 PM Changeset in webkit [49485] by
-
- 5 edits in trunk
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- chromium/DEPS: Added gtest dep required by windows and incremented some of the deps revisions.
2009-10-12 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium Port - Windows
https://bugs.webkit.org/show_bug.cgi?id=29969
- Scripts/pdevenv: removed msvc's /useenv for chromium builds
- Scripts/webkitdirs.pm:
- 5:15 PM BuildingQtOnLinux edited by
- added error relating to phonon (diff)
- 4:49 PM Changeset in webkit [49484] by
-
- 4 edits2 adds in trunk
WebCore: Fix <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
Test: fast/dynamic/position-absolute-to-fixed-crash.html
The crash was caused by stale positioned objects lists following an
object transitioning from being absolutely position to being fixed
positioned.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): In case of a transition between
absolute and fixed position, mark the parent as having a child needing
layout, so that this object will get inserted into its new container's
positioned objects list.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange): Changed a condition to cover
this transition, so that this object gets removed from its current
container's positioned objects list.
LayoutTests: Test for <rdar://problem/7094146> Reproducible crash at
RenderObject::localToAbsolute()
Reviewed by Simon Fraser.
- fast/dynamic/position-absolute-to-fixed-crash-expected.txt: Added.
- fast/dynamic/position-absolute-to-fixed-crash.html: Added.
- 4:20 PM Changeset in webkit [49483] by
-
- 5 edits in trunk
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Add a palette() method that is needed by our RenderTheme.
- platform/qt/QWebPageClient.h:
2009-10-12 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Implement the new palette() methods on the page clients
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::palette):
- Api/qwebview.cpp: (QWebViewPrivate::palette):
- 4:16 PM Changeset in webkit [49482] by
-
- 1 edit in branches/safari-4-branch/WebCore/dom/Element.cpp
Fix release builds.
- 4:05 PM Changeset in webkit [49481] by
-
- 9 edits4 adds in trunk
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Three old test results give back the absolute position instead of the realtive position.
The new test will check the correct behavior of gradients in userSpaceOnUse mode and
values in percentage.
- platform/mac/svg/custom/gradient-attr-update-expected.txt:
- platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/mac/svg/custom/text-gradient-no-content-expected.txt:
- svg/custom/gradient-userSpaceOnUse-with-percentage.svg: Added.
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Gradients can't handle percentage values in userSpaceOnUse mode
https://bugs.webkit.org/show_bug.cgi?id=30286
Fixed *GradientAttributes to take SVGLength instead of double. This casues
the problem, that we can't calculate the correct size of a gradient on
userSpaceOnUse mode with percentage values.
Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg
- svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2):
- svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): (WebCore::SVGLinearGradientElement::collectGradientProperties):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): (WebCore::SVGRadialGradientElement::collectGradientProperties):
- 3:39 PM Changeset in webkit [49480] by
-
- 4 edits in branches/safari-4-branch/WebCore
Merge r49218.
- 3:33 PM Changeset in webkit [49479] by
-
- 3 edits in trunk/WebCore
Fixes <http://webkit.org/b/30315>.
Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.
Reviewed by Timothy Hatcher.
Add tooltip text to the Load event and DOM Content event lines through
a new layer that allows these lines to be on top of the view.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
(WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
- inspector/front-end/inspector.css:
- 3:32 PM Changeset in webkit [49478] by
-
- 7 edits in branches/safari-4-branch/WebKit
Merge r48946.
- 3:32 PM Changeset in webkit [49477] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r47883.
- 3:25 PM Changeset in webkit [49476] by
-
- 6 edits in trunk/WebKitTools
jsc scripts cleanup and Qt/GTK fix
https://bugs.webkit.org/show_bug.cgi?id=30288
Patch by Csaba Osztrogonac <Csaba Osztrogonác> on 2009-10-12
Reviewed by Darin Adler.
Duplicated jscPath() moved to webkitdirs.pm.
New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
Configuration added (release/debug) to path for Qt-port on Windows.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc:
- Scripts/run-sunspider:
- Scripts/sunspider-compare-results:
- Scripts/webkitdirs.pm:
- 3:25 PM Changeset in webkit [49475] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48787.
- 3:25 PM Changeset in webkit [49474] by
-
- 6 edits in branches/safari-4-branch
Merge r48775.
- 2:30 PM Changeset in webkit [49473] by
-
- 2 edits in trunk/WebCore
2009-10-12 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49429, because it broke layout tests.
http://trac.webkit.org/changeset/49429
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 2:15 PM Changeset in webkit [49472] by
-
- 3 edits4 adds in trunk
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
SVG - crash on feMerge when input not available
https://bugs.webkit.org/show_bug.cgi?id=30297
Make a early return in SVGFEMergeElement if the needed
filter effect doesn't exist.
Test: svg/filters/feMerge-wrong-input.svg
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
2009-10-12 Dirk Schulze <krit@webkit.org>
Reviewed by Eirc Seidel.
feMergeNod has a reference to an effect that doesn't exist. This test will
check if SVGFEMergeElement handles this correctly and stops the filter process.
- svg/filters/feMerge-wrong-input-expected.checksum: Added.
- svg/filters/feMerge-wrong-input-expected.png: Added.
- svg/filters/feMerge-wrong-input-expected.txt: Added.
- svg/filters/feMerge-wrong-input.svg: Added.
- 2:07 PM Changeset in webkit [49471] by
-
- 3 edits18 adds in branches/safari-4-branch
Merge r48572.
- 2:07 PM Changeset in webkit [49470] by
-
- 7 edits2 adds in branches/safari-4-branch
Merge r47801.
- 2:07 PM Changeset in webkit [49469] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r47771.
- 2:00 PM Changeset in webkit [49468] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48848.
- 2:00 PM Changeset in webkit [49467] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48547.
- 2:00 PM Changeset in webkit [49466] by
-
- 5 edits4 adds in branches/safari-4-branch
Merge r48546.
- 2:00 PM Changeset in webkit [49465] by
-
- 3 edits8 adds in branches/safari-4-branch
Merge r47900.
- 2:00 PM Changeset in webkit [49464] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r48743.
- 1:49 PM Changeset in webkit [49463] by
-
- 10 edits4 adds in branches/safari-4-branch
Merge r46136.
- 1:49 PM Changeset in webkit [49462] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r47509.
- 1:42 PM Changeset in webkit [49461] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
2009-10-12 Csaba Osztrogonac <Csaba Osztrogonác>
Unreviewed. Added myself to committers.py.
- Scripts/modules/committers.py:
- 1:42 PM Changeset in webkit [49460] by
-
- 6 edits24 adds in branches/safari-4-branch
Merge r48647.
- 1:42 PM Changeset in webkit [49459] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46521.
- 1:38 PM Changeset in webkit [49458] by
-
- 6 edits in branches/safari-4-branch
Merge r47551.
- 1:38 PM Changeset in webkit [49457] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r47300.
- 1:34 PM Changeset in webkit [49456] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48957.
- 1:34 PM Changeset in webkit [49455] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48956.
- 1:34 PM Changeset in webkit [49454] by
-
- 7 edits in branches/safari-4-branch
Merge r48953.
- 1:33 PM Changeset in webkit [49453] by
-
- 4 edits4 adds in branches/safari-4-branch
Merge r46548.
- 1:19 PM Changeset in webkit [49452] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48369.
- 1:19 PM Changeset in webkit [49451] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r47657.
- 1:19 PM Changeset in webkit [49450] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r46058.
- 1:19 PM Changeset in webkit [49449] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r45945.
- 1:19 PM Changeset in webkit [49448] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48725.
- 1:03 PM WebKit Team edited by
- (diff)
- 1:00 PM Changeset in webkit [49447] by
-
- 19 edits3 adds in trunk
Added automatic flush before compositing
https://bugs.webkit.org/show_bug.cgi?id=30236
This causes image to always render correctly. In writing a testcase
I needed to implement readPixels. This exposed a bug in reading back
values from a CanvasArray subclass, so I fixed that as well. Now when
you wrap a CanvasArray in a JSValue it actually wraps the specific
subclass. To do this I need to add virtual methods to each CanvasArray
subclass to determine the type and a custom toJS method for CanvasArray
to create the proper wrapper.
Test: fast/canvas/webgl/triangle.html
- 12:38 PM Changeset in webkit [49446] by
-
- 2 edits in trunk/LayoutTests
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Update Fedora httpd.conf settings to closely match the generic httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30302
Closely match the default httpd.conf for layout tests.
- http/conf/fedora-httpd.conf:
- 11:09 AM Changeset in webkit [49445] by
-
- 2 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix 0 sentinel for g_object_set() function call.
- platform/graphics/gtk/DataSourceGStreamer.cpp: (webkit_data_src_uri_set_uri): 0 is passed as 32 bit value on x86-64 in vararg functions, but g_object_set() expects a 64 bit 0. This will cause crashes.
- 11:05 AM Changeset in webkit [49444] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Remove unnecessary self-include.
- webkit/webkitsecurityorigin.h:
- 9:29 AM Changeset in webkit [49443] by
-
- 2 edits in trunk/WebKit/mac
2009-10-12 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Video keeps playing after going fullscreen, then closing window
https://bugs.webkit.org/show_bug.cgi?id=30164
Clear the QTMovie on the QTMovieView when coming out of fullscreen,
to fix issue where the underlying movie keeps playing.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]):
- 8:52 AM Changeset in webkit [49442] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-10-12 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Add expected files for new passing fast tests.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- platform/qt/fast/css/text-rendering-expected.txt: Added.
- platform/qt/fast/forms/basic-buttons-expected.txt: Added.
- platform/qt/fast/forms/basic-inputs-expected.txt: Added.
- platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Added.
- 8:26 AM Changeset in webkit [49441] by
-
- 7 edits3 adds in trunk
2009-10-12 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
Test: svg/dom/feFlood-no-in1.html
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
- svg/graphics/filters/SVGFEFlood.h:
LayoutTest:
Drop in="" from <feFlood>
https://bugs.webkit.org/show_bug.cgi?id=29001
This makes <feFlood in="bogus"> have an effect, too.
http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
- svg/dom/feFlood-no-in1-expected.txt: Added.
- svg/dom/feFlood-no-in1.html: Added.
- svg/dom/script-tests/feFlood-no-in1.js: Added.
- 8:05 AM Changeset in webkit [49440] by
-
- 3 edits in trunk/WebKit/qt
2009-10-12 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QWebPage's createViewlessPlugin autotest crash fix.
It is possible that plugins that are QWidgets or QGraphicsWidgets
are created before a view has been assigned to a QWebPage. The
plug-ins won't be fully functional, as by design, they should
visualise something, but they won't crash and will stay in memory.
An autotest that covers this use-case, is included.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPageWidget::PluginTrackedPageWidget): (PluginTrackedPageGraphicsWidget::PluginTrackedPageGraphicsWidget): (PluginTrackedPageGraphicsWidget::createPlugin): (tst_QWebPage::destroyPlugin): (tst_QWebPage::createViewlessPlugin):
- 7:34 AM Changeset in webkit [49439] by
-
- 2 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Scale video to completely fill the target surface while
keeping the aspect ratio. This fixes displaying of the
YouTube HTML5 sample website.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Scale video to completely fill the target surface, keep the aspect ratio and center it.
- 7:18 AM Changeset in webkit [49438] by
-
- 5 edits in trunk/WebCore
2009-10-12 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fixes double memcpy of all rendered video frames.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
- platform/graphics/gtk/VideoSinkGStreamer.h: Directly pass the buffers up to the MediaPlayerPrivate::paint() method instead of rendering them first to an intermediate cairo surface. This should increase performance and peak memory usage.
- 7:15 AM Changeset in webkit [49437] by
-
- 3 edits in trunk/WebKit/gtk
2009-10-12 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
[GTK] Crash when right-clicking misspelled word
https://bugs.webkit.org/show_bug.cgi?id=29772
Make sure the dictionary exist before adding it to the list of
dictionaries.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property):
- 4:56 AM Changeset in webkit [49436] by
-
- 2 edits in trunk
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubberstamped by Eric Seidel.
[Gtk] Fix icu CFLAG for Darwin
https://bugs.webkit.org/show_bug.cgi?id=29517
Don't escape the srcdir variable. Also use $host instead of the
os_foo variables.
- autotools/webkit.m4:
- 4:55 AM Changeset in webkit [49435] by
-
- 2 edits in trunk
2009-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Use the SQLite3 headers from WebKitLibraries if sqlite3 is undetected
https://bugs.webkit.org/show_bug.cgi?id=29518
- configure.ac:
- 3:14 AM QtBackLog edited by
- Add new items and pointers to them (diff)
Oct 11, 2009:
- 11:50 PM Changeset in webkit [49434] by
-
- 5 edits6 adds in trunk
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue where JavaScript URLs that are URL-encoded twice can
bypass the XSSAuditor.
JavaScript URLs that are completed by method Document::completeURL have added
URL-encoded characters such that a direct comparison with the URL-decoded
outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing
HTTP parameters must be URL-decoded before comparison.
Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor the URL-decoded source code for the JavaScript URL.
- page/XSSAuditor.cpp: (WebCore::isIllegalURICharacter): Minor syntactical change to the comment. (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added parameter decodeURLEscapeSequencesTwice. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::decodeURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
- page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.
2009-10-11 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that JavaScript URLs that are twice URL encoded do not bypass the XSSAuditor.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html: Added.
- 9:17 PM Changeset in webkit [49433] by
-
- 3 edits2 adds in trunk
WebKit/mac: <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and video chat
doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
Test: plugins/setProperty.html
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::setFieldValue): Fixed a typo. The function
should return early if m_instanceProxy is null.
LayoutTests: Test for <rdar://problem/7294267> REGRESSION (r48492): Gmail voice and
video chat doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30295
Reviewed by Darin Adler.
- plugins/setProperty-expected.txt: Added.
- plugins/setProperty.html: Added.
- 8:30 PM Changeset in webkit [49432] by
-
- 7 edits in trunk/WebCore
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Fixes a build break in the V8 bindings caused by revision 49420.
https://bugs.webkit.org/show_bug.cgi?id=30294
Revision 49420 introduces an IDL-defined CanvasActiveInfo
type. This causes a build break in the V8 bindings where
CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
non-ref type.
- WebCore.gypi: Include CanvasActiveInfo.idl in build.
- bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref ptr type.
- bindings/v8/DOMObjectsInclude.h: Include generated CanvasActiveInfo files.
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:15 PM Changeset in webkit [49431] by
-
- 2 edits in trunk/WebCore
2009-10-11 Collin Jackson <collinj@webkit.org>
Reviewed by Adam Barth.
Log mixed content warnings to console
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
- 7:53 PM Changeset in webkit [49430] by
-
- 2 edits in trunk/WebKitTools
2009-10-11 Adam Barth <abarth@webkit.org>
Unreviewed. Add Collin to committers.py.
- Scripts/modules/committers.py:
- 7:36 PM QtBackLog edited by
- (diff)
- 3:48 PM Changeset in webkit [49429] by
-
- 2 edits in trunk/WebCore
2009-10-11 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Adam Barth.
[V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
https://bugs.webkit.org/show_bug.cgi?id=30250
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
- 3:34 PM Changeset in webkit [49428] by
-
- 2 edits in trunk/WebCore
2009-10-11 Lyon Chen <lyon.chen@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Correct the position of #endif sentence inside WebCore::Document::finishedParsing().
This change requires no test case as it fix a compiling error.
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- 3:17 PM Changeset in webkit [49427] by
-
- 3 edits in trunk/WebCore
2009-10-11 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Sets a 500K stack limit for JavaScript workers in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=29797
Runaway recursion in JavaScript workers crashes the Chromium
worker process on OS X. This is because V8's default stack limit
is 512K on ia32 or 1M on x64, but the worker process runs workers
on a thread with the OS X default stack size--512K. Because there
are already some C++ frames on the stack when V8 establishes its
512K default stack limit, and V8 doesn't precisely enforce the
stack limit, runaway recursion in V8 workers overflows the OS
stack and segfaults, killing the worker process. This is described
in Chromium bug 21653 <http://crbug.com/21653>.
This patch sets the V8 stack limit for worker JavaScript in
Chromium to a more conservative 500K on all platforms. This allows
some "headroom" for the C++ stack in use when the limit is set up,
and some "legroom" for the V8 helper functions which in practice
briefly flout the V8 stack limit.
Test: LayoutTests/fast/workers/use-machine-stack.html
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- bindings/v8/WorkerContextExecutionProxy.h:
- 2:30 PM Changeset in webkit [49426] by
-
- 2 edits in trunk/JavaScriptCore
Re-enable the JIT.
- 1:01 PM Changeset in webkit [49425] by
-
- 4 edits in trunk
wx build fixes, adding bindings to include/source dirs and fixing wxMac 2.9 compilation.
- 2:46 AM Changeset in webkit [49424] by
-
- 10 edits3 adds in trunk
Allow [Reflect] on SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=28936
Reviewed by Sam Weinig.
Update the JS binding generators to reference SVGNames instead of
HTMLNames, if [Reflect]ing an attribute on an SVG element. Make
SVGElement::id use [Reflect].
Also make [Reflect] on an attribute with a setter exception work in ObjC
bindings.
WebCore:
Test: svg/dom/id-reflect.html
- bindings/scripts/CodeGenerator.pm: Add a function to determine the
appropriate C++ namespace for attribute name constants.
- bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling
code for [Reflect] on an attribute with a setter exception.
- bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of
"HTMLNames" when appropriate.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/SVGElement.cpp: Remove getter and setter methods for id.
- svg/SVGElement.h: Ditto.
- svg/SVGElement.idl: Add [Reflect] to id.
LayoutTests:
- svg/dom/script-tests/id-reflect.js: Added.
- svg/dom/id-reflect-expected.txt: Added.
- svg/dom/id-reflect.html: Added.
Oct 10, 2009:
- 8:47 PM Changeset in webkit [49423] by
-
- 3 edits3 adds in trunk
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590
Reviewed by Maciej Stachowiak.
Implement trim, trimLeft, and trimRight
- 3:10 PM Changeset in webkit [49422] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r49414): Rebaseline needed for Windows / Gtk Linux
https://bugs.webkit.org/show_bug.cgi?id=30279
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-10
Reviewed by Eric Seidel.
- platform/gtk/editing/style/5228141-expected.txt: Same rebaseline done for Mac in r49414
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: two i tags are merged properly
- 2:46 PM Changeset in webkit [49421] by
-
- 2 edits in trunk/WebCore
Fix paths in xcode.
- 2:16 PM Changeset in webkit [49420] by
-
- 10 edits2 copies8 adds in trunk
Implement getActiveAttrib and getActiveUniform
https://bugs.webkit.org/show_bug.cgi?id=30276
Reviewed by Eric Carlson.
Implements the getActiveAttrib and getActiveUniform APIs.
Rather simple patch, adds CanvasActiveInfo definition and implementation
and adds forwarding to the GraphicsContext3D.
Test: fast/canvas/webgl/getActiveTest.html
- 12:21 PM Changeset in webkit [49419] by
-
- 2 edits in trunk/WebCore
2009-10-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Adding new attributes in Element Panel is
counterintuitive.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype.set hovered): (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
- 9:19 AM Changeset in webkit [49418] by
-
- 4 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275
In addition to fixing the build break with guards
remove notImplemented() from PluginViewNone.cpp and
make them just just be empty functions.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::handlePostReadFile): (WebCore::PluginView::getValue): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::updatePluginWidget):
- 8:56 AM Changeset in webkit [49417] by
-
- 2 edits in trunk/WebCore
2009-10-10 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add HistoryController.cpp to the build.
- WebCore.pro:
- 6:53 AM Changeset in webkit [49416] by
-
- 2 edits in trunk/WebCore
2009-10-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
[Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
https://bugs.webkit.org/show_bug.cgi?id=30262
This is not testable from WebKit since WebKit never uses the member
function form of protocolIs with input that can be controlled from a
web page. It always passes string literals lacking hyphens.
- platform/KURLGoogle.cpp: (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would transform the input character.
- 3:04 AM BuildingQtOnWindows edited by
- (diff)
- 2:11 AM Changeset in webkit [49415] by
-
- 8 edits2 adds in trunk/WebCore
2009-10-10 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Move HistoryController to its own file
https://bugs.webkit.org/show_bug.cgi?id=30272
Purely mechanical.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/HistoryController.cpp: Added.
- loader/HistoryController.h: Added.
