Timeline
Oct 20, 2009:
- 9:56 PM Changeset in webkit [49898] by
-
- 3 edits in trunk/WebCore
2009-10-20 Eric Z. Ayers <zundel@google.com>
Reviewed by Timothy Hatcher.
Changes TimelineItems to be created with raw timestamps as opposed
to a time relative to a start of session. Normalized timestamps cause
problems when monitoring a browsing session across multiple page
transitions.
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- inspector/InspectorTimelineAgent.h:
- 8:37 PM Changeset in webkit [49897] by
-
- 7 edits in trunk/LayoutTests
2009-10-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simple console tests do not require testing harness.
- inspector/uncaught-dom1-exception-expected.txt:
- inspector/uncaught-dom1-exception.html:
- inspector/uncaught-dom3-exception-expected.txt:
- inspector/uncaught-dom3-exception.html:
- inspector/uncaught-dom8-exception-expected.txt:
- inspector/uncaught-dom8-exception.html:
- 7:31 PM Changeset in webkit [49896] by
-
- 2 edits in trunk/WebCore
Fix leak of WebSocketChannel by adopting the newly-created reference.
Reviewed by Oliver Hunt.
- websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
- 5:42 PM Changeset in webkit [49895] by
-
- 3 edits2 deletes in trunk
Roll out r49876 as it causes many assertion failures during regression tests on SnowLeopard.
- 5:40 PM Changeset in webkit [49894] by
-
- 6 edits in trunk/WebCore
DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-20
Reviewed by Adam Barth.
Part 1/2. Removing sessionStorageEnabled in next patch after the
Chromium side of the changes lands.
Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- storage/Storage.cpp:
(WebCore::Storage::setLocalStorageAvailable):
(WebCore::Storage::localStorageAvailable):
(WebCore::Storage::setSessionStorageAvailable):
(WebCore::Storage::sessionStorageAvailable):
- storage/Storage.h:
- 5:22 PM Changeset in webkit [49893] by
-
- 8 edits in trunk/WebCore
Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409
Patch by John Gregg <johnnyg@google.com> on 2009-10-20
Reviewed by David Levin.
This code only affects chromium, and is all behind a compile time
flag current turned off, so no new tests.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::setIsAvailable):
(WebCore::NotificationCenter::isAvailable):
- notifications/NotificationCenter.h:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 5:08 PM Changeset in webkit [49892] by
-
- 3 edits in trunk/WebCore
2009-10-20 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Fixes RefPtr initialization in the V8 implementation of WebCore::ScriptString to use the ::create() idiom and
use adoptRef() properly. I failed to read the RefPtr docs the first time through :(
No new tests, error was caught by valgrind on the Chromium builders.
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator=):
- bindings/v8/ScriptStringImpl.h: (WebCore::ScriptStringImpl::create):
- 4:10 PM Changeset in webkit [49891] by
-
- 4 edits in trunk/WebCore
2009-10-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: populate child nodes before sorting them.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
- inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
- 2:56 PM Changeset in webkit [49890] by
-
- 2 edits in trunk/WebCore
Remove redundant String ref/deref calls in generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30579
Patch by Jens Alfke <snej@chromium.org> on 2009-10-20
Reviewed by Eric Seidel.
- bindings/v8/V8Binding.h:
(WebCore::toString): Fix return type of 'toString' to make it truly a no-op
instead of constructing/destructing a String.
- 2:56 PM Changeset in webkit [49889] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: updated variable name.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- 2:55 PM Changeset in webkit [49888] by
-
- 2 edits in trunk/JavaScriptCore
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Slightly tweaked this #ifdef to match the
size of a JSValue because m_jsStrings is an array of JSValues.
Reviewed by Mark Rowe.
- 2:49 PM Changeset in webkit [49887] by
-
- 2 edits in trunk/JavaScriptCore
Fixed a 64-bit regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=30570.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Mark Rowe.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Use TimesEight stepping on 64-bit, since
64-bit pointers are eight bytes long.
- 2:39 PM Changeset in webkit [49886] by
-
- 4 edits in trunk/JavaScriptCore
Refactored DateInstance::msToGregorianDateTime so that a DateInstance's
caller doesn't need to supply the DateInstance's own internal value to
the DateInstance.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-20
Reviewed by Sam Weinig.
- runtime/DateInstance.cpp:
(JSC::DateInstance::getGregorianDateTime): Renamed from "msToGregorianDateTime".
- runtime/DateInstance.h:
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Also renamed "utc" to "outputIsUTC", for clarity.
- 2:20 PM Changeset in webkit [49885] by
-
- 2 edits in trunk/WebCore
2009-10-20 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25411
[GTK] ATK accessible ancestry broken
Work around for the problem of bogus additional objects in the ancestry.
We now set the parent when we ref the child, then ask the Atk child if
it knows its parent. This solves the bulk of the cases. For those it
doesn't, fall back to the existing logic.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent): (webkit_accessible_ref_child):
- 1:56 PM Changeset in webkit [49884] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
<rdar://problem/7319749> REGRESSION(r49806): Contextual Menu items missing
https://bugs.webkit.org/show_bug.cgi?id=30568
Revert accidental change from r49806.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- 1:50 PM Changeset in webkit [49883] by
-
- 2 edits in trunk/WebCore
Fixes <http://webkit.org/b/30421>.
Web Inpsector: Local Files can show up on Cookies List with Cookies from other Domain.
Reviewed by Alice Liu.
When a page like Google generates an about:blank, it shows up as a local file on
the list of Cookie domains, but has all of the cookies of Google. When we are adding
cookie domains to the inspector, we should only add the domain is the URL of the resource
is in the HTTP protocol family or a file URL.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didFinishLoading):
- 1:38 PM Changeset in webkit [49882] by
-
- 2 edits3 adds in trunk/WebCore
2009-10-20 Mark Mentovai <mark@chromium.org>
Reviewed by Darin Fisher.
Use a version of libWebKitSystemInterface with global symbols marked
private_extern for Chromium Mac.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/mac: Added.
- WebCore.gyp/mac/Empty.cpp: Added.
- WebCore.gyp/mac/adjust_visibility.sh: Added.
- 1:12 PM Changeset in webkit [49881] by
-
- 2 edits in trunk/WebCore
2009-10-20 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for WebCore's CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=30564
Inherits CSSProperty class from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:367.
- css/CSSProperty.h:
- 1:03 PM Changeset in webkit [49880] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 12:52 PM Changeset in webkit [49879] by
-
- 2 edits in trunk/WebKit/qt
Reviewed By Adam Barth.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Add some actions to the menu for cursor debugging.
GraphicsView based launcher only.
- QGVLauncher/main.cpp:
(MainView::setWaitCursor):
(MainView::resetCursor):
(MainView::flip):
(MainWindow::setWaitCursor):
(MainWindow::resetCursor):
(MainWindow::buildUI):
- 12:08 PM Changeset in webkit [49878] by
-
- 2 edits in trunk/WebCore
2009-10-20 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Hide Chromium's media slider thumb if no source has been loaded.
Covered by existing layout tests, notably:
LayoutTests/media/controls-rendering.html
LayoutTests/media/unsupported-tracks.html
LayoutTests/media/video-src-none.html
- rendering/RenderMediaControlsChromium.cpp: (WebCore::hasSource): Returns true if an HTMLMediaElement has a valid source set. (WebCore::paintMediaMuteButton): Refactored to use hasSource(). (WebCore::paintMediaPlayButton): Ditto. (WebCore::paintMediaSliderThumb): Add call to hasSource() to determine if we should paint the thumb.
- 12:02 PM Changeset in webkit [49877] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 12:00 PM Changeset in webkit [49876] by
-
- 3 edits2 adds in trunk
2009-10-20 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
- fast/text/international/japanese-kana-letters-expected.txt: Added.
- fast/text/international/japanese-kana-letters.html: Added.
2009-10-20 Satoshi Nakagawa <psychs@limechat.net>
Reviewed by Darin Adler.
Fixed Japanese text search problems.
Treat small kana letters and kana letters as different characters in search.
Do not ignore diacritic marks in search for Japanese texts.
Test: fast/text/international/japanese-kana-letters.html
- editing/TextIterator.cpp: (WebCore::createCollator): (WebCore::collator): (WebCore::createSearcher):
- 11:46 AM Changeset in webkit [49875] by
-
- 1 edit2 adds4 deletes in trunk/LayoutTests
2009-10-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
fast/css/getComputedStyle/marginComputedStyle is missing
https://bugs.webkit.org/show_bug.cgi?id=30566
- fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
- fast/css/getComputedStyle/marginComputedStyle.html: Added.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Removed.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Removed.
- platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Removed.
- platform/qt/fast/css/marginComputedStyle-expected.txt: Removed.
- 11:41 AM Changeset in webkit [49874] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-20 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
The op_next_pname should use 4 bytes addressing mode in case of JSValue32
https://bugs.webkit.org/show_bug.cgi?id=30570
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_next_pname):
- 11:20 AM Changeset in webkit [49873] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Another batch of skipped tests with links to their bugs.
- platform/gtk/Skipped:
- 11:17 AM Changeset in webkit [49872] by
-
- 2 edits in trunk/WebCore
2009-10-20 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Added getter for FrameLoader:m_suppressOpenerInNewFrame.
This will allow Chromium to more intelligently detect
noreferrer links and therefore open them in a new process.
- loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame): Added.
- 10:46 AM Changeset in webkit [49871] by
-
- 2 edits in trunk/WebKitTools
2009-10-20 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Add {ager,antonm,yurys}@chromium.org into committers.py
https://bugs.webkit.org/show_bug.cgi?id=30560
- Scripts/modules/committers.py:
- 10:45 AM Changeset in webkit [49870] by
-
- 4 edits in trunk/WebKit/qt
Remove clipRenderToViewport as agreed upon in
https://bugs.webkit.org/show_bug.cgi?id=29843
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Rubberstamped by Adam Barth.
- Api/qwebframe.cpp:
- Api/qwebframe.h:
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- 10:37 AM Changeset in webkit [49869] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip 3 failing xmlhttprequest tests.
- platform/gtk/Skipped:
- 10:22 AM Changeset in webkit [49868] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip two failing security canvas tests.
- platform/gtk/Skipped:
- 10:10 AM Changeset in webkit [49867] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing editing test.
- platform/gtk/Skipped:
- 10:03 AM Changeset in webkit [49866] by
-
- 2 edits in trunk/WebKit/qt
Update the tests to test the new render functionality, and take
into consideration that render() clips to the frame itself as well
as the viewport.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.
QWebFrame::render() now always clips, so the old tests were bogus.
Rendering pure contents (no scrollbars etc) without clipping can now
be accomplished using QWebFrame::documentElement()->render(...)
- Api/qwebframe.cpp:
- Api/qwebframe.h:
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- tests/qwebframe/tst_qwebframe.cpp:
- 10:03 AM Changeset in webkit [49865] by
-
- 2 edits in trunk/WebKit/qt
As we do not support rendering a QWebFrame without it being clipped
the the frame as well as the viewport, we now set the viewport size
to the size of the contents.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Adam Barth.
Rendering pure contents (no scrollbars etc) without clipping can be
acomplished using QWebFrame::documentElement()->render(...)
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::render):
- 9:43 AM Changeset in webkit [49864] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a bunch of failing DnD tests.
- platform/gtk/Skipped:
- 9:40 AM Changeset in webkit [49863] by
-
- 2 edits in trunk/WebCore
2009-10-20 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore's CSSParserFunction
https://bugs.webkit.org/show_bug.cgi?id=30563
Inherits CSSParserFunction struct from FastAllocBase because it has been
instantiated by 'new' in WebCore/css/CSSParser.cpp:4827.
- css/CSSProperty.h:
- 9:29 AM Changeset in webkit [49862] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip two zoom related tests.
- platform/gtk/Skipped:
- 8:55 AM Changeset in webkit [49861] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a couple of failing media tests.
- platform/gtk/Skipped:
- 8:47 AM Changeset in webkit [49860] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing a11y test while we investigate what's going on.
- platform/gtk/Skipped:
- 8:41 AM Changeset in webkit [49859] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip tests expecting new results.
- platform/gtk/Skipped:
- 8:30 AM Changeset in webkit [49858] by
-
- 2 edits in trunk/WebCore
2009-10-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Watched Expressions Buttons Do Not Match Inspector Styles
https://bugs.webkit.org/show_bug.cgi?id=30554
- inspector/front-end/inspector.css: added style to pane buttons
- 8:29 AM Changeset in webkit [49857] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip media/restore-from-page-cache.html since we are missing some
of the needed API for the test.
- platform/gtk/Skipped:
- 8:06 AM Changeset in webkit [49856] by
-
- 3 edits in trunk/WebCore
=fix for 30559
- 8:00 AM Changeset in webkit [49855] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip another failing test because we don't currently support
changing the locale after gtk_init has been called.
Also, add another test to the list of libxml2 issues.
- platform/gtk/Skipped:
- 7:25 AM Changeset in webkit [49854] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Tor Arne Vestbø.
[Qt] Remove http/tests/xmlhttprequest tests
from skiplist, and add only now failing tests.
- platform/qt/Skipped:
- 7:18 AM Changeset in webkit [49853] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip a bunch of tests failing in the debug bots because WebKit
does not work correctly with very recent versions of libxml2. The
tracker bug for the issue is
https://bugs.webkit.org/show_bug.cgi?id=30508
- platform/gtk/Skipped:
- 7:15 AM Changeset in webkit [49852] by
-
- 2 edits in trunk/WebKitTools
Make the Netscape Test plugin available to the Qt launcher.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø
- Scripts/run-launcher:
- 7:14 AM Changeset in webkit [49851] by
-
- 2 edits in trunk/WebKit/qt
Add menu item to dump the plugin list to the console,
which can be handy for debugging.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-20
Reviewed by Tor Arne Vestbø.
- QtLauncher/main.cpp:
(MainWindow::dumpPlugins):
(MainWindow::setupUI):
- 7:14 AM Changeset in webkit [49850] by
-
- 4 edits in trunk/WebKit/qt
Introduce new render method on QWebFrame, which supports specifying
which layers to render (scrollbars, contents, pan-icon).
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Tor Arne Vestbø.
Deprecate render().
- Api/qwebframe.cpp:
(QWebFramePrivate::renderPrivate):
(QWebFrame::render):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- 5:16 AM Changeset in webkit [49849] by
-
- 2 edits in trunk/LayoutTests
[Qt] Enable previously disabled fast/css tests after r48873 landed which
fixed https://bugs.webkit.org/show_bug.cgi?id=28288
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
Reviewed by Ariya Hidayat.
- platform/qt/Skipped:
- 4:18 AM Changeset in webkit [49848] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip failing test, with comment pointing to the bug to track it.
- platform/gtk/Skipped:
- 3:44 AM Changeset in webkit [49847] by
-
- 2 edits in trunk/LayoutTests
2009-10-20 Xan Lopez <xlopez@igalia.com>
Skip plugins/private-browsing-mode.html, since our plugin
implementation lacks that feature.
- platform/gtk/Skipped:
- 2:54 AM Changeset in webkit [49846] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Infinite loop (leading to crash) when setting cursor in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30549
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Ariya Hidayat.
Patch reimplements QGraphicsItem's itemChange method, and make
CursorChange event to be emitted after cursor has already been
set.
QWidget::setCursor send the event just after it sets the cursor,
then patch makes both behaviors compatible.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::itemChange):
- Api/qgraphicswebview.h:
- 2:42 AM Changeset in webkit [49845] by
-
- 3 edits in trunk/JavaScriptCore
Move OverridesMarkChildren flag from DatePrototype to its parent class
https://bugs.webkit.org/show_bug.cgi?id=30372
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-20
Reviewed by Oliver Hunt.
- runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
- runtime/DatePrototype.h:
- 1:52 AM Changeset in webkit [49844] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix.
[Qt] Add FEGaussianBlur.h and FEGaussianBlur.cpp which were refactored in r49778 to WebCore.pro.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
- WebCore.pro:
- 12:36 AM Changeset in webkit [49843] by
-
- 27 edits in trunk
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Set EnabledAtRuntime for WebSocket in DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=29896
Supported by chromium/v8 only.
Add WebSocket::isAvailable()/setIsAvailable(bool) to control v8
bindings.
Remove Settings::experimentalWebSocketsEnabled() and
setExperimentalWebSocketsEnabled(bool).
- WebCore.base.exp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::setIsAvailable): (WebCore::WebSocket::isAvailable):
- websockets/WebSocket.h:
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::experimentalNotificationsEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 12:23 AM Changeset in webkit [49842] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-20
[Qt] Skip failing tests introduced by disabling Phonon support in Buildbot's Qt version
until a proper solution for the Phonon related craches and timeouts is found.
- platform/qt/Skipped:
Oct 19, 2009:
- 11:56 PM Changeset in webkit [49841] by
-
- 2 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Sam Weinig.
Whoops, make prototype bindings actually use the StructureFlags.
- 10:01 PM Changeset in webkit [49840] by
-
- 4 edits2 copies in trunk/WebCore
2009-10-19 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Better implementation of WebCore::ScriptString for the V8 bindings.
WebCore::ScriptString is used for XMLHttpRequest's responseText attribute which is
shared with JavaScript. Thus, simply using a WebCore::String and copying the value
is pretty inefficient, especially since responseText is built up with a sequence of
operator+= calls. JSC builds use a JSC::UString to share the buffer when possible,
this patch adopts a similar approach for V8.
No new tests, behavior is unchanged and covered by LayoutTests/http/tests/xmlhttprequest
- WebCore.gypi:
- bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=): (WebCore::ScriptString::v8StringOrNull):
- bindings/v8/ScriptStringImpl.cpp: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::~ScriptStringImpl): (WebCore::ScriptStringImpl::toString): (WebCore::ScriptStringImpl::isNull): (WebCore::ScriptStringImpl::size): (WebCore::ScriptStringImpl::append):
- bindings/v8/ScriptStringImpl.h: Added. (WebCore::ScriptStringImpl::ScriptStringImpl): (WebCore::ScriptStringImpl::v8StringHandle):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER):
- 9:46 PM Changeset in webkit [49839] by
-
- 3 edits1 delete in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
No review, rolling out r49837.
http://trac.webkit.org/changeset/49837
- page/Settings.cpp: (WebCore::Settings::setStandardFontFamily): (WebCore::Settings::setFixedFontFamily): (WebCore::Settings::setSerifFontFamily): (WebCore::Settings::setSansSerifFontFamily): (WebCore::Settings::setCursiveFontFamily): (WebCore::Settings::setFantasyFontFamily):
- page/Settings.h: (WebCore::Settings::standardFontFamily): (WebCore::Settings::fixedFontFamily): (WebCore::Settings::serifFontFamily): (WebCore::Settings::sansSerifFontFamily): (WebCore::Settings::cursiveFontFamily): (WebCore::Settings::fantasyFontFamily):
- platform/text/UScriptCode.h: Removed.
- 9:39 PM Changeset in webkit [49838] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.
https://bugs.webkit.org/show_bug.cgi?id=30473
vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of
PLALTFORM(WIN_OS) guards.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 9:37 PM Changeset in webkit [49837] by
-
- 3 edits1 add in trunk/WebCore
2009-10-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
Make generic font family getters/setters accept an additional
argument (script code). It has a default value so that if an embedder
does not have/want a per-script font family setting, call-sites
don't have to be changed.
This is to prepare for fixing bug 10874 (font selection is not
language-dependent) and bug 18085.
There should be no change in layout and no new layout test
is added.
- WebCore.base.exp:
- page/Settings.cpp:
- page/Settings.h:
- platform/text/UScriptCode.h: Added. This is for ports that do not use ICU. the part of ICU's common/unicode/uscript.h that defines script code enum was copied. To keep enums compatible with those in ICU, we don't generate the list out of Scripts.txt of the Unicode Data base or CLDR's data.
- 9:28 PM Changeset in webkit [49836] by
-
- 2 edits in trunk/WebCore
2009-10-19 Evan Stade <estade@chromium.org>
Reviewed by Darin Adler.
Clarify usage of SuddenTermination API. No code change.
- platform/SuddenTermination.h:
- 9:05 PM Changeset in webkit [49835] by
-
- 10 edits in trunk/WebCore
REGRESSION: Dromaeo DOM test is 14% slower
https://bugs.webkit.org/show_bug.cgi?id=30273
Reviewed by Gavin Barraclough.
Make DOM bindings automatically inherit correct structure
flags rather than being needlessly conservative. This is
done by making the bindings generator use the same model
for TypeInfo flags that we now use in JSC.
This gains us about 1% of this regression back.
- 9:01 PM Changeset in webkit [49834] by
-
- 2 edits in trunk/WebKit
2009-10-19 John Gregg <johnnyg@google.com>
Reviewed by Dimitri Glazkov.
set ENABLE_NOTIFICATIONS=1 for Chromium
https://bugs.webkit.org/show_bug.cgi?id=29949
- chromium/features.gypi:
- 8:19 PM Changeset in webkit [49833] by
-
- 3 edits2 adds in trunk
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Add a layout test for nested SVG <use> element which has a child.
https://bugs.webkit.org/show_bug.cgi?id=26117
- svg/custom/use-on-use-with-child-expected.txt: Added.
- svg/custom/use-on-use-with-child.svg: Added.
2009-10-19 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Fixed a bug on nested SVG <use> elements.
https://bugs.webkit.org/show_bug.cgi?id=26117
When a <use> element refer to another <use> element which has
child/children, the instance tree built for this <use> element
is incorrect (more nodes than expected).
Test: svg/dom/use-on-use-with-child.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
- 7:59 PM Changeset in webkit [49832] by
-
- 2 edits in trunk/WebCore
Small changes to fully invalidate and update the JavaScriptCallFrame.
Patch by Oliver Hunt <oliver@apple.com> on 2009-10-19
<rdar://problem/7020755> JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146
Reviewed by Timothy Hatcher.
- inspector/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::update):
- 7:51 PM Changeset in webkit [49831] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Fix fallout from last change.
https://bugs.webkit.org/show_bug.cgi?id=30550
Update init-events to match reality. I only ran the domstorage layout tests
and thus missed one in fast/events/. This addresses fallout from
https://bugs.webkit.org/show_bug.cgi?id=30536
- fast/events/init-events-expected.txt:
- fast/events/script-tests/init-events.js:
- 6:32 PM Changeset in webkit [49830] by
-
- 17 edits in trunk
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
This was removed because it makes it introduces synchronous access that can
cross the event loop boundry (since a storage event can fire from one process
and be handled in another).
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent):
- storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
- storage/StorageEvent.h: (WebCore::StorageEvent::uri):
- storage/StorageEvent.idl:
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2009-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dmitri Titov.
Remove "source" from storage events
https://bugs.webkit.org/show_bug.cgi?id=30536
Remove "source" from storage events per
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
- storage/domstorage/localstorage/iframe-events-expected.txt:
- storage/domstorage/localstorage/iframe-events.html:
- storage/domstorage/localstorage/resources/iframe-events-second.html:
- storage/domstorage/localstorage/simple-events-expected.txt:
- storage/domstorage/localstorage/simple-events.html:
- storage/domstorage/sessionstorage/iframe-events-expected.txt:
- storage/domstorage/sessionstorage/iframe-events.html:
- storage/domstorage/sessionstorage/resources/iframe-events-second.html:
- storage/domstorage/sessionstorage/simple-events-expected.txt:
- storage/domstorage/sessionstorage/simple-events.html:
- 6:29 PM Changeset in webkit [49829] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove ResourceLoadNotifier::activeDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=30533
Removing this method from ResourceLoadNotifier better decouples the
notifier from FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::requestFromDelegate):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didReceiveResponse):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
- 6:28 PM Changeset in webkit [49828] by
-
- 5 edits in trunk/WebCore
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move sendRemainingDelegateMessages to ResourceLoadNotifier
https://bugs.webkit.org/show_bug.cgi?id=30531
This method is about notifying folks and doesn't interact with the rest
of FrameLoader.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::willLoadMediaElementURL): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- loader/FrameLoader.h:
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- 6:19 PM Changeset in webkit [49827] by
-
- 7 edits2 adds in trunk
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Test that a fake event can't get around the popup blocker.
- http/tests/security/popup-blocked-from-fake-event-expected.txt: Added.
- http/tests/security/popup-blocked-from-fake-event.html: Added.
2009-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Bypass popup blocker using click event
https://bugs.webkit.org/show_bug.cgi?id=21501
Keep track of which events were generated by JavaScript and use that
inforation when figuring out if we're processing a user gesture.
Test: http/tests/security/popup-blocked-from-fake-event.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- dom/Document.cpp: (WebCore::Document::createEvent):
- dom/Event.cpp: (WebCore::Event::Event):
- dom/Event.h: (WebCore::Event::createdByDOM): (WebCore::Event::setCreatedByDOM):
- 6:09 PM Changeset in webkit [49826] by
-
- 2 edits in trunk/WebCore
Fixing a typo.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-19
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30543
- platform/sql/SQLiteDatabase.h:
- 6:05 PM Changeset in webkit [49825] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Adding myself to committers.py.
- 5:41 PM Changeset in webkit [49824] by
-
- 1 edit1 add in trunk/WebCore
Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
https://bugs.webkit.org/show_bug.cgi?id=30544
Reviewed by Darin Adler.
- manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
- 5:38 PM Changeset in webkit [49823] by
-
- 3 edits in trunk/WebCore
2009-10-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Flash at end of opacity/transform transition sometimes
https://bugs.webkit.org/show_bug.cgi?id=30501
When a transition finishes, there window of time between when the animation is
removed, and the final style set on the GraphicsLayer. This caused the layer to revert
to its old appearance for one or two frames. To avoid this, we set the final
transform or opacity at the start of the transition; we know that the animation
will override the final value for as long as its running.
No test because this is a very transient effect that can't be captured
in a test.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateLayerOpacity): (WebCore::RenderLayerBacking::updateLayerTransform): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::startTransition):
- rendering/RenderLayerBacking.h:
- 5:12 PM Changeset in webkit [49822] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Added one more style rule
- 5:03 PM Changeset in webkit [49821] by
-
- 1 add in trunk/WebKitSite/blog-files/webgl/resources/blogpost.css
Moved WebGL blog CSS to a separate file
- 3:59 PM Changeset in webkit [49820] by
-
- 3 edits in trunk/JavaScriptCore
Tightened up some put_by_id_transition code generation.
https://bugs.webkit.org/show_bug.cgi?id=30539
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Oliver Hunt.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition): No need to do object type
checks or read Structures and prototypes from objects: they're all known
constants at compile time.
- 3:44 PM Changeset in webkit [49819] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Jason Yan <tailofthesun@gmail.com>
Reviewed by Eric Seidel.
Fixed issue with LayoutTests/fast/cookies/local-file-can-set-cookies.html
which can fail when the system under test has local file cookies set already.
https://bugs.webkit.org/show_bug.cgi?id=30281
- fast/cookies/local-file-can-set-cookies-expected.txt: Modified. Updated expected results.
- fast/cookies/local-file-can-set-cookies.html: Modified. Check for existing cookie and set non-persistent cookie.
- 3:36 PM Changeset in webkit [49818] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Language tag should include both language and country sub-tags,
case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=30440
- fast/js/navigator-language-expected.txt:
- fast/js/navigator-language.html:
- 3:28 PM Changeset in webkit [49817] by
-
- 2 edits in trunk/WebKitLibraries
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Eric Seidel.
added cairo include and lib directories to debug_wincairo.vsprops
https://bugs.webkit.org/show_bug.cgi?id=29831
- win/tools/vsprops/debug_wincairo.vsprops:
- 3:10 PM Changeset in webkit [49816] by
-
- 2 edits in trunk/WebKitSite
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Replace boolean operator indentation example with an if statement.
- coding/coding-style.html: Replace boolean indenting example to use "if"
- 3:00 PM Changeset in webkit [49815] by
-
- 2 edits in trunk/WebCore
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add more stop characters into console completions.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
- 3:00 PM Changeset in webkit [49814] by
-
- 2 edits in trunk/WebKit/win
Fix crashes/assertions when calling WebLocalizedString from multiple threads concurrently
Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
from multiple threads concurrently
Reviewed by John Sullivan.
- WebLocalizableStrings.cpp:
(mainBundleLocStringsMutex):
(frameworkLocStringsMutex):
Added these new getters.
(findCachedString):
(cacheString):
Lock the relevant mutex before accessing each string map. Otherwise
bad things could happen if two threads end up here at the same time.
- 3:00 PM Changeset in webkit [49813] by
-
- 2 edits in trunk/WebKit/win
Get rid of a few static initializers/exit-time destructors in WebLocalizableStrings
Reviewed by Dan Bernstein.
- WebLocalizableStrings.cpp:
(mainBundleLocStrings):
(frameworkLocStrings):
Added these functions instead of file-scope variables.
(findCachedString):
(cacheString):
Updated to use the new functions.
- 2:41 PM Changeset in webkit [49812] by
-
- 4 edits in trunk/WebKit
2009-10-19 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Update call to FrameLoader::loadFrameRequest() in qt and
FrameLoader::urlSelected() in win.
- 2:39 PM Changeset in webkit [49811] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Added the test case for bug #30266 to the Windows skip list because
event.dataTransfer.types does not behave correctly. See bug #30527.
- platform/win/Skipped: Added test case to Windows skipped list.
- 2:31 PM Changeset in webkit [49810] by
-
- 2 edits in trunk/WebCore
2009-10-19 Marshall Culpepper <mculpepper@appcelerator.com>
Reviewed by Adam Roben.
implemented ClipboardWin::files()
https://bugs.webkit.org/show_bug.cgi?id=29666
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
- 2:15 PM Changeset in webkit [49809] by
-
- 13 edits11 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Alexey Proskuryakov.
Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".
- 2:08 PM Changeset in webkit [49808] by
-
- 2 edits in trunk/WebKit/mac
Documentation fix for -[NSObject(WebResourceLoadDelegate) webView:resource:willSendRequest:redirectResponse:fromDataSource:]
Reviewed by Dan Bernstein.
- WebView/WebResourceLoadDelegate.h: Prepended "webView:" to the
@method declaration of
-webView:resource:willSendRequest:redirectResponse:fromDataSource:
which was absent before r3953 and was missed during the great
documentation clean up of r4269.
- 2:01 PM Changeset in webkit [49807] by
-
- 2 edits in trunk/WebKit/mac
Fix build.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
- 1:30 PM Changeset in webkit [49806] by
-
- 8 edits in trunk/WebKit/mac
Split assertions of conjunctions into separate statements or remove
redundant assertions.
Reviewed by Anders Carlsson.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView halt]):
(-[WebBaseNetscapePluginView resumeFromHalt]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::checkTextOfParagraph):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _reflectSelection]):
- 1:25 PM Changeset in webkit [49805] by
-
- 2 edits in trunk/LayoutTests
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Geoffrey Garen.
Add plugins/netscape-invoke-failures.html to Snow Leopard skipped list.
- platform/mac-snowleopard/Skipped: Add plugins/netscape-invoke-failures.html.
- 1:25 PM Changeset in webkit [49804] by
-
- 3 edits in trunk/WebCore
Refactor out some of the code in paint() into paintPanScrollIcon()
and paintScrollbars() in preparation of some Qt API changes.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by David Hyatt.
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
- platform/ScrollView.h:
- 1:18 PM Changeset in webkit [49803] by
-
- 4 edits in trunk/WebCore
[v8] typeof(HTMLMediaElement) should return undefined if media
engine is not available
https://bugs.webkit.org/show_bug.cgi?id=30343
Patch by Alpha Lam <hclam@chromium.org> on 2009-10-19
Reviewed by Dimitri Glazkov (Dimitri Glazkov).
Check for availability of the media engine to disable
HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
in runtime.
Try runs and review in Chromium:
http://codereview.chromium.org/276011
Test: manual-tests/chromium/media-player-not-available.html
The above test can work work in Chromium. Testing procedures:
- Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
- Open Chromium with above test page
- Verify the test results according to the test page
- bindings/v8/custom/V8CustomBinding.h:
Declare enabler methods.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Report enabled only if media player is available.
- manual-tests/chromium/media-player-not-available.html: Added.
Manual test, following instruction in this test for procedures.
- page/DOMWindow.idl:
Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
as enabled at runtime.
- 12:59 PM Changeset in webkit [49802] by
-
- 9 edits1 add in trunk/JavaScriptCore
Added a private API for getting a global context from a context, for
clients who want to preserve a context for a later callback.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-19
Reviewed by Sam Weinig.
- API/APICast.h:
(toGlobalRef): Added an ASSERT, since this function is used more often
than before.
- API/JSContextRef.cpp:
- API/JSContextRefPrivate.h: Added. The new API.
- API/tests/testapi.c:
(print_callAsFunction):
(main): Test the new API.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Build and export the new API.
- 12:38 PM Changeset in webkit [49801] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Alexey Proskuryakov.
[Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
https://bugs.webkit.org/show_bug.cgi?id=30358
Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).
- webkit/webkitapplicationcache.cpp:
- 12:24 PM Changeset in webkit [49800] by
-
- 2 edits in trunk/WebCore
Make the local static panScrollIcon into a Image* instead
of a RefPtr<Image>.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-19
Reviewed by Adam Roben.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- 12:19 PM Changeset in webkit [49799] by
-
- 2 edits in trunk/WebCore
Forcefully set antialiasing for Chromium media controls.
Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-19
Reviewed by NOBODY (OOPS!).
https://bugs.webkit.org/show_bug.cgi?id=30521
Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider): Added setShouldAntialias(true).
- 12:11 PM Changeset in webkit [49798] by
-
- 11 edits in trunk/WebCore
2009-10-19 Jens Alfke <jens@mooseyard.com>
Reviewed by Darin Adler.
Optimize string upper/lowercasing
https://bugs.webkit.org/show_bug.cgi?id=30261
- Added AtomicString::upper() and lower()
- Further optimized StringImpl::lower()
- Removed StringImpl::isLower()
- Added QualifiedName::localNameUpper(), which is cached, thereby saving thousands of upper() calls and string allocations.
- dom/Element.cpp: (WebCore::Element::setAttribute): Call AtomicString::lower()
- dom/QualifiedName.cpp: (WebCore::QualifiedName::localNameUpper): New method
- dom/QualifiedName.h: Added localNameUpper() method
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Call AtomicString::lower()
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
- html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Call localNameUpper()
- platform/text/AtomicString.cpp: (WebCore::AtomicString::lower): New method (WebCore::AtomicString::upper): New method
- platform/text/AtomicString.h: Added lower() and upper()
- platform/text/StringImpl.cpp: Removed isLower() (WebCore::StringImpl::lower): Further optimization of initial loop
- platform/text/StringImpl.h: Removed isLower()
- 11:59 AM Changeset in webkit [49797] by
-
- 19 edits1 delete in trunk/LayoutTests
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Update test results and Skipped list after changes in r49791.
Some test results were accidentally committed in r49192. At that time
results were incorrect, but testing still succeeded because of
unimplemented features. After r49791 tests, though generating semantically
equal output to Mac's render trees, started to fail and need to have
generated results updated. This patch does just that.
- platform/gtk/Skipped: Skip a test that does not generate semantically equal render trees.
- platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/gtk/editing/pasteboard/select-element-1-expected.txt: Removed.
- 11:50 AM Changeset in webkit [49796] by
-
- 6 edits2 adds in trunk
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Test that the proper exception is thrown into JS when a plugin
invoke call returns false.
- plugins/netscape-invoke-failure-expected.txt: Added.
- plugins/netscape-invoke-failure.html: Added.
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
If a call to a plugin's invokeMethod, invokeDefault or construct
returns false, throw an exception into JS.
Test: plugins/netscape-invoke-failure.html
- bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct. (npObjectInvokeImpl):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): Check return value (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value (JSC::Bindings::CInstance::invokeConstruct): Check return value
2009-10-19 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add testFail() to test plugin so we can test our handling of a
plugin invoke call returning false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). (pluginInvoke): (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
- 11:47 AM Changeset in webkit [49795] by
-
- 2 edits in trunk/JavaScriptCore
Tightened up some instanceof code generation.
https://bugs.webkit.org/show_bug.cgi?id=30488
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-17
Reviewed by Oliver Hunt.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): No need to do object type checks -
cell type checks and ImplementsDefaultHasIntance checks implicitly
supersede object type checks.
- 11:38 AM Changeset in webkit [49794] by
-
- 3 edits4 adds in trunk
WebCore: Fix for chromium/skia canvas arc start/end positions, when the arc is
360 degrees.
https://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
Covered by new test:
LayoutTests/fast/canvas/arc360.html
- platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::addArc):
LayoutTests: New test for 360 degree arc endpoints, and expected results.
http://bugs.webkit.org/show_bug.cgi?id=30449
Reviewed by Adam Barth.
- fast/canvas/arc360.html: Added.
- platform/mac/fast/canvas/arc360-expected.checksum: Added.
- platform/mac/fast/canvas/arc360-expected.png: Added.
- platform/mac/fast/canvas/arc360-expected.txt: Added.
- 11:14 AM Changeset in webkit [49793] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add tests that have never passed on Windows to the Skipped list, and reopen
bugs.
- platform/win/Skipped:
- 10:35 AM Changeset in webkit [49792] by
-
- 2 edits in trunk/WebCore
2009-10-19 Kent Tamura <tkent@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix uninitialized variable reference in Element::removeAttribute().
https://bugs.webkit.org/show_bug.cgi?id=30502
- dom/Element.cpp: (WebCore::Element::removeAttribute):
- 10:25 AM Changeset in webkit [49791] by
-
- 7 edits in trunk
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable tests that pass when DOM pasting is allowed.
- platform/gtk/Skipped:
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to allow DOM pastes to be performed.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-10-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable DOM pasting when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 10:13 AM Changeset in webkit [49790] by
-
- 11 edits in trunk
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- dom/EventNames.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::noneSupported): Ditto. (WebCore::HTMLMediaElement::mediaEngineError): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
2009-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=30463
Remove HTML5 media element 'loadend' event
- media/event-attributes-expected.txt:
- media/event-attributes.html: Switch from 'loadend' to 'canplaythrough'.
- media/media-load-event-expected.txt:
- media/media-load-event.html: Ditto.
- media/progress-event-at-least-one-expected.txt:
- media/progress-event-at-least-one.html: Ditto.
- 9:26 AM Changeset in webkit [49789] by
-
- 3 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Adam Barth.
[Qt] Remove deletion of outgoing FormData object when reply is finished.
The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 9:18 AM Changeset in webkit [49788] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
fastRealloc edge case.
https://bugs.webkit.org/show_bug.cgi?id=29313
No test, the crash shows up occasionally in crash dumps, we weren't able
to reproduce it locally.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to
avoid calling fastRealloc with the size of 0.
- 9:08 AM Changeset in webkit [49787] by
-
- 2 edits in trunk/WebCore
2009-10-19 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Use fillRect() instead of drawRect() to fix Chromium media controls rendering.
Chromium Mac layout tests will need to be rebaselined. Existing layout tests for Linux/Win still pass.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
- 9:00 AM Changeset in webkit [49786] by
-
- 2 edits in trunk/WebCore
2009-10-19 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Barth.
Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
https://bugs.webkit.org/show_bug.cgi?id=29832
Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.
I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.
- page/Frame.cpp: (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
- 8:53 AM Changeset in webkit [49785] by
-
- 5 edits1 add in trunk/WebKit/qt
2009-10-19 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Ariya Hidayat.
Add QWebElement::render API which allows rendering of single
element.
- Api/qwebelement.cpp: (QWebElement::render):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::render):
- tests/qwebelement/qwebelement.qrc:
- tests/qwebelement/image.png: Added.
- 8:16 AM Changeset in webkit [49784] by
-
- 2 edits in trunk/WebKit/qt
QWebPage: Doc: setNetworkAccessManager should only be called once.
Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2009-10-19
Reviewed by Ariya Hidayat.
- 8:02 AM Changeset in webkit [49783] by
-
- 2 edits in trunk/WebCore
2009-10-19 Csaba Osztrogonác <Csaba Osztrogonác>
Unreviewed build warning fix.
[Qt] Apply changes to WebCore.pro introduced in r49778
- WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
- 8:01 AM Changeset in webkit [49782] by
-
- 2 edits in trunk/WebKit/qt
Wrong ifdef combination in QGraphicsWebView's event method.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-19
Reviewed by Tor Arne.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 7:42 AM Changeset in webkit [49781] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip failing tests for now and add test-specific information about the cause to the Skipped list.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/Skipped:
- 7:16 AM Changeset in webkit [49780] by
-
- 2 edits in trunk/WebKit/gtk
Make WebKitHitTestResult actually appear in the index
- 7:00 AM Changeset in webkit [49779] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Add platform expected file for canvas test.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-19
Reviewed by Tor Arne Vestbø.
- platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt: Added.
- 5:57 AM Changeset in webkit [49778] by
-
- 7 edits2 moves in trunk/WebCore
2009-10-19 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Move feGaussianBlur from WebCore/svg to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=30495
This patch moves SVGFRGaussianBlur from svg/graphics/filters
to platform/graphics/filters/FEGaussianBlur. This is needed
for shadow support on Qt and Cairo.
No change in functionality, therfore no new test case needed.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FEGaussianBlur.cpp: Added.
- platform/graphics/filters/FEGaussianBlur.h: Added.
- svg/SVGFEGaussianBlurElement.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed.
- svg/graphics/filters/SVGFEGaussianBlur.h: Removed.
- 5:49 AM Changeset in webkit [49777] by
-
- 1 edit in trunk/WebCore/ChangeLog
Unreviewed.
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-19
Added reviewer name to r49574.
- 5:48 AM Changeset in webkit [49776] by
-
- 3 edits in trunk/LayoutTests
2009-10-19 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Update outdated metrics for these passing tests.
- platform/qt/css1/font_properties/font-expected.txt:
- platform/qt/fast/xsl/document-function-expected.txt:
- 4:58 AM Changeset in webkit [49775] by
-
- 2 edits in trunk/WebCore
2009-10-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30489
[Gtk] The document frame/html container claims to be parentless
Work around for the parentless claim made by the accessible associated
with the embedded WebView. When we identify this condition, get the
widget's parent, and then get the AtkObject from that. Admittedly an ugly
hack, but we'll need it for Yelp and other Gtk+/GNOME applications which
plan to switch over to WebKit.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
- 4:51 AM Changeset in webkit [49774] by
-
- 2 edits in trunk/WebCore
2009-10-19 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
Handle duration queries properly
https://bugs.webkit.org/show_bug.cgi?id=29999
Previously duration queries failed to handle unknown duration
and didn't treat the returned duration as an unsigned.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 4:50 AM Changeset in webkit [49773] by
-
- 2 edits in trunk/WebKit/gtk/po
2009-10-19 Daniel Macks <dmacks@netspace.org>
Reviewed by Adam Barth.
Inconsistent handling of gettext domain can cause compile failure
https://bugs.webkit.org/show_bug.cgi?id=30292
- GNUmakefile.am: Use DOMAIN variable instead of hard-coded value
- 4:28 AM Changeset in webkit [49772] by
-
- 2 edits in trunk/WebCore
2009-10-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix build on Windows.
- plugins/win/PluginViewWin.cpp: (windowHandleForPageClient):
- 4:17 AM Changeset in webkit [49771] by
-
- 5 edits2 adds in trunk
Windowed Plugins: Don't crash when client is 0.
Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView.
In addition, setFrameRect()/updatePluginWidget() is called even if the
plugin was not succesfully loaded. updatePluginWidget() updates the
window rect which is, in theory, useful to draw something that indicates
that we didn't load successfully.
So, a status check is added to setNPWindowIfNeeded.
- 3:44 AM Changeset in webkit [49770] by
-
- 7 edits in trunk
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::~PluginContainerQt):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
2009-10-19 Girish Ramakrishnan <Girish Ramakrishnan>
Reviewed by Holger Freyther.
[Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
Fixes various sources of crashes:
- The PluginContainer is a child of QWebView. When the view gets deleted, the PluginView is not notified about the deletion of PluginContainer.
- QWebView destructor does not set client to 0.
- Sometimes pending paint events are sent after the plugin has died, so add a check in PluginView::setNPWindowIfNeeded.
- Api/qwebview.cpp: (QWebView::~QWebView):
- tests/qwebview/qwebview.pro:
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage_data): (tst_QWebView::reusePage):
- 12:17 AM Changeset in webkit [49769] by
-
- 7 edits in trunk
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=29042
Allow one to customize the minimal and maximal shrink factors used when printing.
- page/PrintContext.cpp: (WebCore::PrintContext::begin):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setPrintingMinimumShrinkFactor): (WebCore::Settings::setPrintingMaximumShrinkFactor):
- page/Settings.h: (WebCore::Settings::printingMinimumShrinkFactor): (WebCore::Settings::printingMaximumShrinkFactor):
2009-10-19 Jakob Truelsen <antialize@gmail.com>
Reviewed by Adam Barth.
Allow one to costumize the minimal and maximal shrink factors,
Added methods setPrintingMinimumShrinkFactor, printingMinimumShrinkFactor,
setPrintingMaximumShrinkFactor, printingMaximumShrinkFactor to QWebSettings.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings): (QWebSettings::setPrintingMinimumShrinkFactor): (QWebSettings::printingMinimumShrinkFactor): (QWebSettings::setPrintingMaximumShrinkFactor): (QWebSettings::printingMaximumShrinkFactor):
- Api/qwebsettings.h:
- 12:04 AM Changeset in webkit [49768] by
-
- 1 edit in trunk/WebKit/qt/ChangeLog
Fix ChangeLog spelling.
Oct 18, 2009:
- 11:59 PM Changeset in webkit [49767] by
-
- 3 edits10 adds in trunk
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
- 11:51 PM Changeset in webkit [49766] by
-
- 7 edits in trunk
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.
- Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):
- 11:50 PM QtBackLog edited by
- (diff)
- 11:46 PM QtBackLog edited by
- Move QtWebKit problems into a table. (diff)
- 11:43 PM Changeset in webkit [49765] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474
stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.
- wtf/StringExtras.h: (strncasecmp): (strcasecmp):
- 11:42 PM QtBackLog edited by
- Change Qt items into a table (diff)
- 11:34 PM QtBackLog edited by
- Add completed items to the bottom (diff)
- 8:53 PM Changeset in webkit [49764] by
-
- 2 edits in trunk/WebCore
CURL build fix, use proper header name.
- 7:38 PM Changeset in webkit [49763] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.
Reviewed by Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.
- 7:09 PM Changeset in webkit [49762] by
-
- 9 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Properties on Arrays and NodeLists are not logged correctly.
WebCore:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):
LayoutTests:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- 6:20 PM Changeset in webkit [49761] by
-
- 2 edits in trunk/WebCore
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.
Web Inspector: frontend files are not deployed in Windows
incremental build.
- inspector/InspectorDOMAgent.cpp:
- 5:20 PM Changeset in webkit [49760] by
-
- 6 edits6 adds in trunk/LayoutTests
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make console tests more granular.
- inspector/console-dir-expected.txt: Added.
- inspector/console-dir.html: Added.
- inspector/console-dirxml-expected.txt: Added.
- inspector/console-dirxml.html: Added.
- inspector/console-format-expected.txt: Added.
- inspector/console-format.html: Added.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:48 PM Changeset in webkit [49759] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:17 PM Changeset in webkit [49758] by
-
- 4 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Title of dir(["test", "test2"]) should be Array
Test: inspector/console-tests.html
- inspector/front-end/InjectedScript.js:
- 2:15 PM Changeset in webkit [49757] by
-
- 9 edits in trunk
2009-10-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480
Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.
*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg
Some tests needed new pixel tests because of the new color space.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- 12:55 PM Changeset in webkit [49756] by
-
- 2 edits in trunk/WebCore
2009-10-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493
- bindings/scripts/CodeGeneratorV8.pm:
- 12:29 PM Changeset in webkit [49755] by
-
- 5 edits5 adds in trunk
2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487
Add --enable-mathml to configure.
- configure.ac:
Add MathML sources if MathML support is enabled.
- GNUmakefile.am:
Include layout test baseline for Gtk.
- platform/gtk/mathml/presentation/sub-expected.txt: Added.
- platform/gtk/mathml/presentation/sup-expected.txt: Added.
- platform/gtk/mathml/presentation/tables-expected.txt: Added.
- 11:21 AM Changeset in webkit [49754] by
-
- 2 edits in trunk/WebCore
Non-PCH build fix. Added missing header.
- 10:17 AM Changeset in webkit [49753] by
-
- 7 edits4 adds in trunk
2009-10-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425
When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.
Test: compositing/geometry/partial-layout-update.html
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- rendering/RenderLayerBacking.h:
- 10:02 AM Changeset in webkit [49752] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Add the ability to specify a proxy for wxWebKit.
https://bugs.webkit.org/show_bug.cgi?id=30446
- 9:23 AM Changeset in webkit [49751] by
-
- 2 edits in trunk/WebCore
2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez
https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 9:08 AM Changeset in webkit [49750] by
-
- 4 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add basic database support to wx API
https://bugs.webkit.org/show_bug.cgi?id=30445
- 9:00 AM Changeset in webkit [49749] by
-
- 2 edits in trunk/LayoutTests
2009-10-18 Eric Carlson <eric.carlson@apple.com>
Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.
- platform/mac/Skipped:
- 7:50 AM QtBackLog edited by
- (diff)
- 2:35 AM QtWebKitPlugins edited by
- (diff)
Oct 17, 2009:
- 11:27 PM Changeset in webkit [49748] by
-
- 2 edits in trunk/LayoutTests
2009-10-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Fix inefficient string concatenation.
LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.
fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
https://bugs.webkit.org/show_bug.cgi?id=30436
- fast/css/large-list-of-rules-crash.html:
- 6:46 PM QtBackLog edited by
- (diff)
- 6:41 PM QtBackLog edited by
- (diff)
- 6:22 PM QtBackLog edited by
- (diff)
- 6:15 PM QtBackLog edited by
- (diff)
- 4:07 PM Changeset in webkit [49747] by
-
- 4 edits in trunk
Versioning.
- 4:06 PM Changeset in webkit [49746] by
-
- 1 copy in tags/Safari-532.2
New tag.
- 3:52 PM Changeset in webkit [49745] by
-
- 13 edits2 adds in trunk/WebCore
2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Cleanup SVGElement code, preparing for animVal support
https://bugs.webkit.org/show_bug.cgi?id=30466
Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
be used to control the start/end state of an animated property.
We're currently tracking animated properties that need synchronization, generalize this concept and use
it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
of synchronization (no SVG DOM object wrappers, no synchronization needed).
No change in functionality, thus no tests.
- GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimatedProperty.h: Add registerProperty() function (WebCore::::SVGAnimatedProperty): Call registerProperty() function (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
- svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. (WebCore::lookupOrCreateWrapper):
- svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
- svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::viewTarget):
- svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
- svg/SynchronizablePropertyController.cpp: Added. (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
- svg/SynchronizablePropertyController.h: Added. (WebCore::SynchronizableProperty::SynchronizableProperty): (WebCore::SynchronizableProperty::isHashTableDeletedValue): (WebCore::SynchronizableProperty::operator==): (WebCore::SynchronizablePropertyHash::hash): (WebCore::SynchronizablePropertyHash::equal): (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):
- 3:38 PM Changeset in webkit [49744] by
-
- 2 edits in trunk/BugsSite
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
- 1:00 PM Changeset in webkit [49743] by
-
- 2 edits in trunk/WebCore
2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25413
[GTK] Please expose the level of headings
Exposes the heading level as an attribute of the AtkObject.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (addAttributeToSet): (webkit_accessible_get_attributes): (webkit_accessible_class_init):
- 8:54 AM Changeset in webkit [49742] by
-
- 2 edits in trunk/WebCore
2009-10-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472
Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.
- page/EventHandler.cpp:
- 8:49 AM Changeset in webkit [49741] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Optionally allow the user to zoom text using the mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=30444
- 8:45 AM Changeset in webkit [49740] by
-
- 2 edits in trunk/WebCore
2009-10-17 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Seidel.
[chromium] Video controls not zoomed / transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=30461
Draw the images in the controls scaled.
No new tests. With this change Chromium will pass the following tests:
LayoutTests/media/video-controls-zoomed.html
LayoutTests/media/video-controls-transformed.html
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): Pass along the target rect directly. (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): Adjust the thumb slide applied with the scale factor.
- 12:53 AM Changeset in webkit [49739] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Gtk] Build fix for WebKitGtk after r49723.
Add bindings/js/JSExceptionBase.* to the build.
- GNUmakefile.am:
- 12:46 AM Changeset in webkit [49738] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add bindings/js/JSExceptionBase.cpp to the build.
- WebCore.pro:
- 12:32 AM Changeset in webkit [49737] by
-
- 3 edits in trunk/LayoutTests
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: reduce inspector console test size - it times out.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
Oct 16, 2009:
- 11:59 PM Changeset in webkit [49736] by
-
- 2 edits in trunk/BugsSite
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user click again.
- 11:50 PM WebKit Team edited by
- Added Drag and Drop to my section. (diff)
- 11:29 PM Changeset in webkit [49735] by
-
- 12 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.
Reviewed by Dan Bernstein.
WebCore:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
- platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKit/win:
- WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops:
Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
- DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
- 10:52 PM Changeset in webkit [49734] by
-
- 98 edits1 add in trunk
Rolled back in r49717 with the build maybe working now?
- 10:15 PM Changeset in webkit [49733] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Jon Honeycutt.
<rdar://problem/7304575>
- Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted. (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
- WebView/WebView.mm: (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
- WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.
- 9:38 PM Changeset in webkit [49732] by
-
- 8 edits in trunk
Add SPI to determine whether a plug-in has ever been halted.
Part of <rdar://problem/7312158>.
Reviewed by Dan Bernstein.
WebCore:
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.
- plugins/PluginView.h:
(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_hasBeenHalted.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().
- WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().
- WebView.h:
Declare hasPluginForNodeBeenHalted().
- 9:23 PM Changeset in webkit [49731] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Simon Fraser <Simon Fraser>
Skip this test:
compositing/animation/animated-composited-inside-hidden.html
because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.
- platform/mac/Skipped:
- 8:54 PM Changeset in webkit [49730] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.
- Api/qwebpage.cpp:
(QWebPage::view):
- Api/qwebpage_p.h:
- QGVLauncher/main.cpp:
(SharedScene::SharedScene):
(SharedScene::~SharedScene):
- 8:51 PM Changeset in webkit [49729] by
-
- 3 edits in trunk/WebKit/qt
[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::hoverMoveEvent):
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
- 8:35 PM Changeset in webkit [49728] by
-
- 4 edits in trunk/LayoutTests
Updated expected results of tests that give CONSOLE messages for
new verbose output.
- fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
- fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
- platform/mac/fast/dynamic/015-expected.txt:
- 8:10 PM Changeset in webkit [49727] by
-
- 3 edits12 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Apparently we're supposed to tolerate whitespace before the charset
rule so folks can write code like this:
<style>
@charset "utf-8"
...
</style>
I'm told this is one of the top compatability problems in China.
Tests: fast/css/comment-before-charset-external.html
fast/css/comment-before-charset.html
fast/css/many-spaces-before-charset.html
fast/css/space-before-charset-external.html
fast/css/space-before-charset.html
- css/CSSGrammar.y:
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Test that we allow whitespace and comments before the charset rule.
These test results all match Firefox.
- fast/css/comment-before-charset-expected.txt: Added.
- fast/css/comment-before-charset-external-expected.txt: Added.
- fast/css/comment-before-charset-external.html: Added.
- fast/css/comment-before-charset.html: Added.
- fast/css/many-spaces-before-charset-expected.txt: Added.
- fast/css/many-spaces-before-charset.html: Added.
- fast/css/resources/comment-before-charset.css: Added.
- fast/css/resources/space-before-charset.css: Added.
- fast/css/space-before-charset-expected.txt: Added.
- fast/css/space-before-charset-external-expected.txt: Added.
- fast/css/space-before-charset-external.html: Added.
- fast/css/space-before-charset.html: Added.
- 7:31 PM Changeset in webkit [49726] by
-
- 29 edits in trunk
Roll out r49717 as it broke the build.
- 6:23 PM Changeset in webkit [49725] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.
- platform/win/Skipped:
- 6:20 PM Changeset in webkit [49724] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: apparently we shouldn't export those symbols?
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:18 PM Changeset in webkit [49723] by
-
- 10 edits8 adds in trunk
WebCore: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.
This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.
Tests: inspector/uncaught-dom1-exception.html
inspector/uncaught-dom3-exception.html
inspector/uncaught-dom8-exception.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- bindings/js/JSExceptionBase.cpp: Added.
(WebCore::toExceptionBase):
- bindings/js/JSExceptionBase.h: Added.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
- dom/ExceptionBase.h:
(WebCore::ExceptionBase::description):
- dom/ExceptionCode.cpp:
(WebCore::):
(WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
LayoutTests: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).
- inspector/uncaught-dom1-exception-expected.txt: Added.
- inspector/uncaught-dom1-exception.html: Added.
- inspector/uncaught-dom3-exception-expected.txt: Added.
- inspector/uncaught-dom3-exception.html: Added.
- inspector/uncaught-dom8-exception-expected.txt: Added.
- inspector/uncaught-dom8-exception.html: Added.
- 6:09 PM Changeset in webkit [49722] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: export some symbols.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:06 PM Changeset in webkit [49721] by
-
- 30 edits in trunk/JavaScriptCore
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468
Reviewed by Gavin Barraclough.
Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.
- 5:45 PM Changeset in webkit [49720] by
-
- 2 edits in trunk/WebCore
Build fix: forgot to check in this #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- bridge/runtime_root.h:
- 5:40 PM Changeset in webkit [49719] by
-
- 2 edits in trunk/WebKitSite
- coding/RefPtr.html: Minor revision, updating a link and tweaking
wording a bit in few places.
- 5:32 PM Changeset in webkit [49718] by
-
- 1 copy in tags/Safari-6531.21.3
New tag.
- 5:28 PM Changeset in webkit [49717] by
-
- 27 edits in trunk/JavaScriptCore
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.
1.024x as fast on SunSpider (fasta: 1.43x as fast).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
- bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)
- interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.
(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.
- parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.
- runtime/JSValue.h:
(JSC::asCell):
- runtime/MarkStack.h: Make those mischievous #include gods happy.
- runtime/ObjectConstructor.cpp:
- runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.
- runtime/Protect.h:
- runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.
- runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.
- runtime/StructureChain.cpp:
- runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.
- 5:27 PM Changeset in webkit [49716] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r48971.
- 5:27 PM Changeset in webkit [49715] by
-
- 8 edits in branches/safari-4-branch
Merge r48683.
- 5:27 PM Changeset in webkit [49714] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:20 PM Changeset in webkit [49713] by
-
- 3 edits5 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transform layer gets stuck with the wrong transform after an animation ends
<rdar://problem/7311662>
Work around a CoreAnimation bug which causes an animated transform layer to
end up with a stale transform.
Test: compositing/animation/state-at-end-event-transform-layer.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
- 5:20 PM Changeset in webkit [49712] by
-
- 2 edits in trunk/WebKit/wx
wxMSW non-precomp headers build fix.
- 5:17 PM Changeset in webkit [49711] by
-
- 4 edits20 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
After running a transition with an end event listener, can't change the transform
https://bugs.webkit.org/show_bug.cgi?id=30454
Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
the animations would not get cleaned up correctly, which broke subsequent changes of transform.
Now, we always clean up the animations right after queuing up the end events.
Tests: animations/state-at-end-event.html
transitions/move-after-transition.html
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::onAnimationEnd):
- 5:11 PM Changeset in webkit [49710] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Small code cleanup
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt]. (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt] (-[WebBaseNetscapePluginView halt]): (-[WebBaseNetscapePluginView resumeFromHalt]):
- WebView/WebView.mm: (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.
- 5:08 PM Changeset in webkit [49709] by
-
- 2 edits in trunk/WebCore
2009-10-15 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428
TextNode => Edit Text Node
Has Attributes => Edit First Attribute
No Attributes => Start Editing New Attribute
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element
- 5:04 PM Changeset in webkit [49708] by
-
- 4 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue status bot should list which buildbot is blocking the queue
https://bugs.webkit.org/show_bug.cgi?id=30452
Add new methods and testing.
- Scripts/bugzilla-tool:
- Scripts/modules/buildbot.py:
- Scripts/modules/buildbot_unittest.py:
- 4:57 PM Changeset in webkit [49707] by
-
- 3 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-webkit-tests fails when CWD is not inside a WebKit checkout
https://bugs.webkit.org/show_bug.cgi?id=30451
- Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
- Scripts/modules/scm_unittest.py:
- Remove use of original_path (we don't need to restore the CWD).
- Don't use '.' to find the webkit checkout, use file instead.
- 4:44 PM Changeset in webkit [49706] by
-
- 7 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix header indent style for FrameLoader and friends
https://bugs.webkit.org/show_bug.cgi?id=30430
- loader/FrameLoader.h: (WebCore::FrameLoader::frame): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::notifier): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::client): (WebCore::FrameLoader::url): (WebCore::FrameLoader::isLoadingFromCachedPage): (WebCore::FrameLoader::committingFirstRealLoad): (WebCore::FrameLoader::committedFirstRealDocumentLoad): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- loader/HistoryController.h: (WebCore::HistoryController::currentItem): (WebCore::HistoryController::provisionalItem):
- loader/PolicyCallback.h: (WebCore::PolicyCallback::request):
- loader/PolicyChecker.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
- loader/RedirectScheduler.h:
- loader/ResourceLoadNotifier.h:
- 3:31 PM Changeset in webkit [49705] by
-
- 32 edits1 add in trunk
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.
WebCore:
- WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
- WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
WebKit/win:
- WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
- WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
- WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
- WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops: Added.
Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.
- win/tools/vsprops/debug_internal.vsprops:
Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.
WebKitTools:
- DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
- DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.
- FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
- WinLauncher/WinLauncher.vcproj:
Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.
- 3:28 PM Changeset in webkit [49704] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin
- 3:07 PM Changeset in webkit [49703] by
-
- 3 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49693, because it broke Chromium build.
http://trac.webkit.org/changeset/49693
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 3:03 PM Changeset in webkit [49702] by
-
- 5 edits4 adds in trunk
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
- media/video-play-pause-exception-expected.txt:
- media/video-play-pause-exception.html:
- media/video-src-empty-expected.txt: Added.
- media/video-src-empty.html: Added.
- media/video-src-none-expected.txt: Added.
- media/video-src-none.html: Added.
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
Noticable changes:
- Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
- Empty string ("") is now considered a valid URL resolving to the current page and will be loaded
Tests: media/video-src-empty.html
media/video-src-none.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.
- 2:33 PM Changeset in webkit [49701] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-16 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that the JavaScript array event.dataTransfer.types can be accessed
within an ondrop handler without causing a crash.
Although this issue has been resolved as of nightly r49550 we should add a
test case so that we can prevent a regression of this issue.
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.
- 2:30 PM Changeset in webkit [49700] by
-
- 3 edits3 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
- http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
Added the missing check.
Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
- 2:26 PM Changeset in webkit [49699] by
-
- 4 edits in trunk/WebKit/win
Add SPI to restart a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Kevin Decker.
- Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().
- WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().
- WebView.h:
Declare restartHaltedPluginForNode().
- 2:21 PM Changeset in webkit [49698] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Set autobuffer to true and schedule load in V8 audio element constructor.
Covered by existing tests.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.
- 2:06 PM Changeset in webkit [49697] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.
Covered by existing media layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Removed round() and FIXME.
- 2:01 PM BuildingOnWindows edited by
- Added note about error PRJ0002 - i.e. cannot find mspdb80.dll (diff)
- 1:57 PM Changeset in webkit [49696] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Last part of:
<rdar://problem/7273354>
- WebView/WebView.mm: (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin (+[WebView _isNodeHaltedPlugin:]): Made this a class method. (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
- WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.
- 1:56 PM Changeset in webkit [49695] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Fix Chromium media controls to render a disabled play button when the element is unintialized.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
- 1:39 PM Changeset in webkit [49694] by
-
- 40 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Gavin Barraclough.
Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.
- 1:37 PM Changeset in webkit [49693] by
-
- 3 edits in trunk/WebCore
2009-10-16 Steven Knight <sgk@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.
Chrome should still build and test successfully.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 1:28 PM Changeset in webkit [49692] by
-
- 2 edits in trunk/WebCore
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453
The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.
No test, because it's not possible from a test to know whether a transition is accelerated or not.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition):
- 1:21 PM Changeset in webkit [49691] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
https://bugs.webkit.org/show_bug.cgi?id=30434
- fast/loader/local-JavaScript-from-local.html:
- 11:46 AM Changeset in webkit [49690] by
-
- 3 edits in trunk/WebKitTools
check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362
Patch by Carol Szabo <carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.
The few other things include:
+ check-webkit-style does not require spaces around the equal sign
inside 'if' statements and around binary operators that take
numeric literals.
+ check-webkit-style reports false errors for the / operator
when part of a filename in the #include directive.
- Scripts/modules/cpp_style.py:
Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.
- Scripts/modules/cpp_style_unittest.py:
Added test cases for the newly supported checks and modified old
test cases to match the new guidelines
- 11:33 AM Changeset in webkit [49689] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Anders.
<rdar://problem/7273354>
- Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Call -halt instead of -stop. (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start. (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted. (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted. (-[WebBaseNetscapePluginView isHalted]): Added.
- WebView/WebView.mm: (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
- WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.
- 11:23 AM Changeset in webkit [49688] by
-
- 6 edits in trunk
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.
- 10:46 AM Changeset in webkit [49687] by
-
- 1 edit1 add in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Add back MIMETypeRegistryChromium with the right
casing.
- platform/chromium/MIMETypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- 10:41 AM Changeset in webkit [49686] by
-
- 2 edits1 delete in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 10:35 AM Changeset in webkit [49685] by
-
- 2 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Change EmptyPluginHalterClient in SVGImage to be non-static, to
match changes made http://trac.webkit.org/changeset/49385.
https://bugs.webkit.org/show_bug.cgi?id=30403
Run the following layout test sequence:
LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
LayoutTests/svg/carto.net/scrollbar.svg
LayoutTests/svg/carto.net/selectionlist.svg
selectionlist.svg should not crash.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.
- 10:27 AM Changeset in webkit [49684] by
-
- 2 edits in trunk/WebCore
2009-10-16 Victor Wang <victorw@chromium.org>
Reviewed by David Levin.
Add beforeload event support to V8DOMWrapper
LayoutTests/fast/dom/beforeload/frame-before-load.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- 9:41 AM Changeset in webkit [49683] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 9:20 AM Changeset in webkit [49682] by
-
- 2 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Chrome doesn't set Content-Type for file upload when the file extension
is not recognized
https://bugs.webkit.org/show_bug.cgi?id=30433
Apparently, getMIMETypeForPath is supposed to return
application/octet-stream when it doesn't have a better MIME type.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath):
- 8:58 AM Changeset in webkit [49681] by
-
- 4 edits in trunk
Pull out r49676 as it caused build breakges on Symbian
- 8:53 AM Changeset in webkit [49680] by
-
- 1 edit5 adds in trunk/LayoutTests
[Qt] Add empty skipped lists for the platform-specific results
Reviewed by Ariya Hidayat.
- platform/qt-linux/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-win/Skipped:
- 8:45 AM Changeset in webkit [49679] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-10-16 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946
Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.
- JavaScriptCore.pri:
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorSymbian.cpp: Added. (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):
- 7:35 AM BuildingQtOnWindows edited by
- (diff)
- 6:26 AM Changeset in webkit [49678] by
-
- 2 edits in trunk/LayoutTests
[Qt] Update outdated platform dependent expected file.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:
- 6:26 AM Changeset in webkit [49677] by
-
- 1 edit in trunk/WebCore/ChangeLog
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 6:18 AM Changeset in webkit [49676] by
-
- 4 edits in trunk
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Inform the application when a plugin is created or destroyed, but only if the
application registered for these notifications.
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static methods for the application to hook up for
receiving notifications when a plugin is created or destroyed.
- Api/qwebpage.cpp:
- 5:47 AM Changeset in webkit [49675] by
-
- 3 edits2 adds in trunk
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653
Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"
The test case checks if the first two letters are "en"
when system locale is set to "en_US.iso88591".
- fast/js/navigator-language-expected.txt: Added.
- fast/js/navigator-language.html: Added.
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Default language translation should be determined by locale settings,
e.g., "en-US".
https://bugs.webkit.org/show_bug.cgi?id=29653
Test: fast/js/navigator-language.html
- platform/qt/Localizations.cpp: (WebCore::defaultLanguage):
- 3:58 AM QtWebKitPlugins edited by
- (diff)
- 3:53 AM NetscapePluginsOnMacNotes created by
- 3:42 AM QtWebKitPlugins edited by
- (diff)
- 3:35 AM Changeset in webkit [49674] by
-
- 2 edits in trunk/WebCore
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 1:02 AM QtWebKitPlugins edited by
- (diff)
- 12:53 AM QtWebKitPlugins created by
