Timeline



Nov 4, 2009:

11:53 PM Changeset in webkit [50548] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=31114

Reviewed by Eric Seidel.

Inherits CachedResource class from Noncopyable because its (its child
class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
and it is no need to be copyable.

  • loader/CachedResource.h:
11:07 PM Changeset in webkit [50547] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

svn-apply's fixChangeLogPatch function seems broken
​https://bugs.webkit.org/show_bug.cgi?id=30683

Update fixChangeLogPatch to be able to handle patches which
don't start at line 1.
Add unit tests for svn-apply to scm_unittest.py.

  • Scripts/VCSUtils.pm:
  • Scripts/modules/scm_unittest.py:
10:52 PM Changeset in webkit [50546] by eric@webkit.org
  • 4 edits in trunk

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Mark Rowe.

Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
BUILDING_ON_TIGER and BUILDING_ON_LEOPARD. The TARGETING_ macros
consider the deployment target; the BUILDING_ON_ macros consider the
headers being built against.

  • wtf/Platform.h:

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Mark Rowe.

Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
which is true when targeting 10.6 or later.

HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
is present in the CGInterpolationQuality enum, and must be handled
by a switch that has cases for each enumerated value.

USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
on 10.6 or later, and that CoreGraphics will understand when
InterpolationMedium is mapped to kCGInterpolationMedium at runtime.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
10:39 PM Changeset in webkit [50545] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Dan Kegel <​dank@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
​https://bugs.webkit.org/show_bug.cgi?id=31138

Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind

  • page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
10:27 PM Changeset in webkit [50544] by timothy@apple.com
  • 3 edits in trunk/WebCore

Update the Web Inspector Timeline panel to better match the mock-up.

​https://bugs.webkit.org/show_bug.cgi?id=31150

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype._dragWindow):
(WebInspector.TimelinePanel.prototype._resizeWindowLeft):
(WebInspector.TimelinePanel.prototype._resizeWindowRight):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
(WebInspector.TimelineCategoryGraph):

  • inspector/front-end/inspector.css:
9:33 PM Changeset in webkit [50543] by justin.garcia@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos.

9:25 PM Changeset in webkit [50542] by justin.garcia@apple.com
  • 6 edits
    6 adds in trunk

WebCore:

2009-11-02 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

Added editing/deleting/25439-{1,2,3}.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot be made inline with other content. Instead of merging, just move the caret to just before the selection we deleted.
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Added a FIXME. This function begins iterating up from pos.node(), which doesn't necessarily contain pos (suppose pos was [img, 0]). (WebCore::lastInSpecialElement): Ditto. (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp. Added a check for non-inline images.
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Use moved/renamed function. Removed FIXME. The problem causing 5027702 is now squarely in first/lastInSpecialElement (WebCore::endOfParagraph): Ditto.

LayoutTests:

2009-11-03 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

  • editing/deleting/delete-before-block-image-1-expected.txt: Added.
  • editing/deleting/delete-before-block-image-1.html: Added.
  • editing/deleting/delete-before-block-image-2-expected.txt: Added.
  • editing/deleting/delete-before-block-image-2.html: Added.
  • editing/deleting/delete-before-block-table-expected.txt: Added.
  • editing/deleting/delete-before-block-table.html: Added.
9:02 PM Changeset in webkit [50541] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect – ConditionEQ won't
branch on unordered operands. Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.

Fix these, and fill out the missing DoubleConditions.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):

7:29 PM Changeset in webkit [50540] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Rubber Stamped by Oliver Hunt.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Enable native call optimizations on ARMv7. (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).

  • jit/JITOpcodes.cpp:
  • wtf/Platform.h:
7:04 PM Changeset in webkit [50539] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Add a missing assert to the ARMv7 JIT.

  • assembler/ARMv7Assembler.h:

(JSC::ARMThumbImmediate::ARMThumbImmediate):

6:22 PM Changeset in webkit [50538] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove bogus op_ prefix on dumped version of three opcodes.

Rubber-stamped by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

6:22 PM Changeset in webkit [50537] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.

Reviewed by Sam Weinig.

We do this by having the registerName function return information about the constant if the register
number corresponds to a constant. This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved. The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.

  • bytecode/CodeBlock.cpp:

(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isConstantRegisterIndex):

5:42 PM Changeset in webkit [50536] by enrica@apple.com
  • 4 edits
    2 adds in trunk

WebCore: Hang in Mail on attempting to change indent level.
<rdar://problem/7131805>
​https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

The hang was caused by an infinite loop inside outdentRegion.
The code did not account for the fact that, when a list item
cointains multiple paragraphs, outdent moves all paragraphs at
once, invalidating some of the position we keep track of in the loop.
Some code refactoring has also been done to minimize duplicate code.

Test: editing/execCommand/outdent-multiparagraph-list.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
outdentRegion to doApply.
(WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
(WebCore::IndentOutdentCommand::doApply): Some code refactoring.

  • editing/IndentOutdentCommand.h: Added VisiblePosition parameters to

indentRegion and outdentRegion.

LayoutTests: Hang in Mail on attempting to change indent level
<rdar://problem/7131805>
​https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

Added test to cover all the different code paths.

  • editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
  • editing/execCommand/outdent-multiparagraph-list.html: Added.
4:50 PM Changeset in webkit [50535] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Alpha Lam <​hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider doesn't have a thumb
​https://bugs.webkit.org/show_bug.cgi?id=31135

Fixed an incorrect if statement that prevents volume slider
being updated.

The statement checks if the slider value equals to the current
volume value of the media control to avoid updating the volume
slider. Updating the volume slider control shouldn't be within
this condition because we explicitly set them to be equals
during creation of the controls and also when mouse events are
received on the volume control.

No new tests because existing code breaks:
LayoutTests/media/video-volume-slider.html

It should now start passing on Chromium.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Update the volume slider regardless of the current volume value of the media control.
4:35 PM Changeset in webkit [50534] by levin@chromium.org
  • 6 edits in trunk/WebCore

Need to properly disable applicationCache at runtime
​https://bugs.webkit.org/show_bug.cgi?id=30417

Patch by Jenn Braithwaite <​jennb@chromium.org> on 2009-11-04
Reviewed by David Levin.

Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.

No new exposed functionality, so no new tests.

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

  • page/DOMWindow.idl:
4:12 PM Changeset in webkit [50533] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-11-04 Pavel Heimlich <​tropikhajma@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=30647
Solaris build failure due to strnstr.

  • wtf/StringExtras.h: Enable strnstr on Solaris, too.
3:59 PM Changeset in webkit [50532] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2009-11-04 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30266


Changed data format type from "text" to "text/plain" to pass Chrome tests.

  • fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
  • fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
3:59 PM Changeset in webkit [50531] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.

Patch by Gavin Barraclough <​barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

  • Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
  • Refactor double to int conversion out into the MacroAssembler.
  • Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
  • Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jfalse):

3:48 PM Changeset in webkit [50530] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=31143
Assertion failure in CredentialStorage::set() when proxy credentials are being set

No test, cannot test proxy behavior.

  • platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the possibility of null url. Release mode changes are likely inconsequential - e.g. we used to add ":" to origin set, which is weird, but safe.
2:21 PM Changeset in webkit [50529] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: Leftover Breakpoints in the Sidebar Pane
​https://bugs.webkit.org/show_bug.cgi?id=30659

No new tests.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
1:44 PM Changeset in webkit [50528] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-11-04 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Timothy Hatcher.

WebInspector: Use a different method to identify the webkit port in
InspectorBackent::platform().
This corrects the inspector expected behavior with Qt on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=31116

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::platform): (WebCore::InspectorBackend::port):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/InspectorControllerStub.js: (.WebInspector.InspectorControllerStub.prototype.port):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.toolbarDragStart):
1:00 PM Changeset in webkit [50527] by eric@webkit.org
  • 7 edits in trunk

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

​https://bugs.webkit.org/show_bug.cgi?id=19266

  • configure.ac:

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

Also remove all conditional code and workarounds for older versions of
Cairo.
In particular, gain image quality by removing the use of
CAIRO_FILTER_NEAREST when rendering images and use the default
bilinear filter instead.
​https://bugs.webkit.org/show_bug.cgi?id=19266

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawPattern):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty): (WebCore::Path::boundingRect):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
12:46 PM Changeset in webkit [50526] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Restore removed string conversion after cleanup.

12:22 PM Changeset in webkit [50525] by eric@webkit.org
  • 15 edits
    2 adds in trunk

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

  • accessibility/aria-combobox.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-combobox-expected.txt: Added.
  • platform/win/Skipped:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

Test: accessibility/aria-combobox.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isComboBox): (WebCore::AccessibilityObject::isExpanded): (WebCore::AccessibilityObject::expandObject): (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::expandObject): (WebCore::AccessibilityRenderObject::isExpanded): (WebCore::createARIARoleMap):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
  • html/HTMLAttributeNames.in:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
​https://bugs.webkit.org/show_bug.cgi?id=31096

  • DumpRenderTree/AccessibilityUIElement.cpp: (showMenuCallback): (getIsExpandedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
12:12 PM Changeset in webkit [50524] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Fixes naming inconsistencies in TimelineRecordFactory.
​https://bugs.webkit.org/show_bug.cgi?id=31132

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord): (WebCore::TimelineRecordFactory::createXHRLoadRecord): (WebCore::TimelineRecordFactory::createEvaluateScriptRecord): (WebCore::TimelineRecordFactory::createMarkTimelineRecord): (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord): (WebCore::TimelineRecordFactory::createPaintRecord):
  • inspector/TimelineRecordFactory.h:
12:04 PM Changeset in webkit [50523] by eric@webkit.org
  • 9 edits in trunk/WebCore

2009-11-04 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Followon to bug 31080, which protects Timeline
instrumentation in the case where InspectorTimelineAgent
is enabled or disabled during an event dispatch.

​https://bugs.webkit.org/show_bug.cgi?id=31121

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::inspectorTimelineAgent): (WebCore::DOMWindow::dispatchEvent):
  • page/DOMWindow.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
11:55 AM Changeset in webkit [50522] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix an assert on shutdown when wxWebView has captured the mouse,
and make sure wxWebView's right click handling is only active when
the WebCore popup menu is used.

​https://bugs.webkit.org/show_bug.cgi?id=31131

11:35 AM Changeset in webkit [50521] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

Revert 50519 while I work out what went wrong.

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2009-11-04

  • storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::create):
(WebCore::LocalStorageThread::LocalStorageThread):
(WebCore::LocalStorageThread::start):
(WebCore::LocalStorageThread::localStorageThreadStart):
(WebCore::LocalStorageThread::localStorageThread):
(WebCore::LocalStorageThread::scheduleImport):
(WebCore::LocalStorageThread::scheduleSync):
(WebCore::LocalStorageThread::terminate):
(WebCore::LocalStorageThread::performTerminate):

  • storage/LocalStorageThread.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):

  • storage/StorageSyncManager.h:
11:32 AM Changeset in webkit [50520] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add basic support for resource events and marks.
Couple of drive-by fixes. Enabling the panel!

​https://bugs.webkit.org/show_bug.cgi?id=31130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
11:11 AM Changeset in webkit [50519] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2009-11-03 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Simplify LocalStorageThread
​https://bugs.webkit.org/show_bug.cgi?id=30935

On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.

No behavior should have changed.

  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
  • storage/LocalStorageThread.h:
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
  • storage/StorageSyncManager.h:
10:28 AM Changeset in webkit [50518] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is crashing when trying to reject patches after unknown failures
​https://bugs.webkit.org/show_bug.cgi?id=31091

  • Scripts/bugzilla-tool:
    • patchid was a copy/paste mistake. This code has no 'patch' variable so we have to find out what the current patch is by asking bugzilla again.
    • Discovered that this code was also leaking file descriptors, so fixed that.
10:21 AM Changeset in webkit [50517] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-11-04 Mark Mentovai <​mark@chromium.org>

Reviewed by Eric Seidel.

Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp. This is supposed
to be set as needed only in wtf/Platform.h.

10:13 AM Changeset in webkit [50516] by eric@webkit.org
  • 4 edits in trunk

2009-11-04 Vadim Zeitlin <​vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):

2009-11-04 Vadim Zeitlin <​vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

  • WebFrame.cpp: (wxWebFrame::SetPageSource): (wxWebFrame::LoadURL):
9:17 AM Changeset in webkit [50515] by eric@webkit.org
  • 7 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Pavel Feldman.

Adds lightweight network resources to InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=31065

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord): (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
9:08 AM Changeset in webkit [50514] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
​https://bugs.webkit.org/show_bug.cgi?id=31077

Allow sending the response body under the same conditions that we
allow it to finish without reporting an error.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
8:58 AM Changeset in webkit [50513] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make run-webkit-tests work for the Debug_Internal Windows configuration

In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
suffix.

Fixes <​http://webkit.org/b/31123>.

Reviewed by Sam Weinig.

  • Scripts/run-webkit-tests: Don't add the _debug suffix in

Debug_Internal, either.

8:13 AM Changeset in webkit [50512] by Adam Roben
  • 2 edits in trunk/WebCore

Sort WebCore.base.exp

Rubber-stamped by Dan Bernstein.

  • WebCore.base.exp: Sorted.
4:12 AM Changeset in webkit [50511] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Put test into skiplist added in r50489 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04

  • platform/qt/Skipped: inspector/timeline-trivial.html added.
3:27 AM Changeset in webkit [50510] by Csaba Osztrogonác
  • 6 edits
    1 add
    3 deletes in trunk

Unreviewed rollout.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04
Revert r50496 because it broke all layout tests on QtBuildBot.

WebCore:

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::fontCache):
(WebCore::FontCache::FontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKey::hash):
(WebCore::FontPlatformDataCacheKey::computeHash):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontPlatformDataCacheKeyHash::equal):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::addClient):
(WebCore::FontCache::removeClient):
(WebCore::FontCache::invalidate):

  • platform/graphics/qt/FontFallbackListQt.cpp: Added.

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformData::pixelSize):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

  • svg/text/resources: Removed.
  • svg/text/resources/text-font-invalid.svg: Removed.
  • svg/text/text-font-invalid-expected.txt: Removed.
  • svg/text/text-font-invalid.html: Removed.
2:35 AM Changeset in webkit [50509] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=31044
[Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfWebView): (webkit_accessible_get_index_in_parent): (webkit_accessible_get_parent):
2:28 AM Changeset in webkit [50508] by eric@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2009-11-04 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib

Initial version of this patch by Jürg Billeter and Naiem Shaik.
Patch 2/4 - Moving TextCodecs to GLib

Added probing for a hard-coded lists of text encodings.
The basis of this list is taken from the encodings supported by iconv,
then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
a number of Chinese ones.

Probing is necessary with the current design of text codecs
as iconv/GLib do not support enumerating available encodings.

  • GNUmakefile.am:
  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
  • platform/text/gtk/TextCodecGtk.cpp: Added. (WebCore::): (WebCore::newTextCodecGtk): (WebCore::TextCodecGtk::isEncodingAvailable): (WebCore::TextCodecGtk::registerEncodingNames): (WebCore::TextCodecGtk::registerCodecs): (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs): (WebCore::TextCodecGtk::registerExtendedEncodingNames): (WebCore::TextCodecGtk::registerExtendedCodecs): (WebCore::TextCodecGtk::TextCodecGtk): (WebCore::TextCodecGtk::~TextCodecGtk): (WebCore::TextCodecGtk::releaseIConv): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder): (WebCore::TextCodecGtk::decode): (WebCore::TextCodecGtk::encode):
  • platform/text/gtk/TextCodecGtk.h: Added.
2:19 AM Changeset in webkit [50507] by eric@webkit.org
  • 9 edits in trunk

2009-11-04 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Unify redudant methods which will always return the same value.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/gtk/PasteboardHelper.h:

2009-11-04 Martin Robinson <​martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
​https://bugs.webkit.org/show_bug.cgi?id=30623

Move handling of target list to PasteboardHelperGtk.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::fullTargetList):
  • WebCoreSupport/PasteboardHelperGtk.h:
  • webkit/webkitprivate.cpp: (WebKit::pasteboardHelperInstance): (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_init): (webkit_web_view_get_copy_target_list): (webkit_web_view_get_paste_target_list):
1:31 AM Changeset in webkit [50506] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
Any app or AT can attempt to ref a child at a bogus index.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_ref_child):
1:15 AM Changeset in webkit [50505] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

committers.py needs a way to store non-bugzilla email addresses
​https://bugs.webkit.org/show_bug.cgi?id=31037

Make Committer and Reviewer constructors take a single email or a list of emails.
Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
Expose reviewers(), used by validate-committer-lists on bug 30970.

  • Scripts/modules/committers.py:
  • Scripts/modules/committers_unittest.py: Added tests for the new code.
12:58 AM Changeset in webkit [50504] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-04 Benjamin Otte <​otte@gnome.org>

Reviewed by Jan Alonzo.

[gtk] Use gst_element_class_set_details_simple()

Cosmetic change, just code simplification

  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
12:50 AM Changeset in webkit [50503] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-11-04 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

[Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.
​https://bugs.webkit.org/show_bug.cgi?id=30979

Decouple QWebViewPrivate from QWebPageClient, and automatically create
QWebPageWidgetClient whenever the view is QWidget based.

  • Api/qwebpage.cpp: (QWebPageWidgetClient::QWebPageWidgetClient): (QWebPageWidgetClient::scroll): (QWebPageWidgetClient::update): (QWebPageWidgetClient::setInputMethodEnabled): (QWebPageWidgetClient::setInputMethodHint): (QWebPageWidgetClient::cursor): (QWebPageWidgetClient::updateCursor): (QWebPageWidgetClient::palette): (QWebPageWidgetClient::screenNumber): (QWebPageWidgetClient::ownerWidget): (QWebPageWidgetClient::pluginParent): (QWebPage::setView):
  • Api/qwebview.cpp: (QWebView::~QWebView): (QWebView::setPage): (QWebView::event):
12:42 AM Changeset in webkit [50502] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-11-04 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Adds paint rectangle information to TimelineAgent's didPaint callback.
​https://bugs.webkit.org/show_bug.cgi?id=31087

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
12:33 AM Changeset in webkit [50501] by eric@webkit.org
  • 12 edits in trunk

2009-11-04 Jaime Yap <​jaimeyap@google.com>

Reviewed by Timothy Hatcher.

This patch adds API to the console object for annotating the
inspector timeline. This allows developers to mark logical
checkpoints in their apps and have them overlaid in the event
record tree.

tests updated: LayoutTests/fast/dom/Window/window-properties.html
​https://bugs.webkit.org/show_bug.cgi?id=31082

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markTimeline):
  • inspector/InspectorController.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkTimeline):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • page/Console.cpp: (WebCore::Console::markTimeline):
  • page/Console.h:
  • page/Console.idl:

Nov 3, 2009:

11:50 PM Changeset in webkit [50500] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Yuzo Fujishima <​yuzo@google.com>

Reviewed by David Levin.

Start/Stop Web Socket and Web Socket Secure servers for layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=27491

The test path determination logic is changed to handle websocket and websocket/ssl cases.
The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.

Functions to start or stop Web Socket servers are added.

  • Scripts/run-webkit-tests:
10:09 PM Changeset in webkit [50499] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed build fix for WebInspector with Qt build.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

  • inspector/front-end/WebKit.qrc:
9:52 PM Changeset in webkit [50498] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

(on IRC)

Reviewed by Mark Rowe.

add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.

no new tests.

  • platform/mac/Skipped:
8:29 PM Changeset in webkit [50497] by Darin Adler
  • 190 edits in trunk/WebKitSite

Set the MIME type for all PNG files in this directory.

WebKitSite:

Patch by Darin Adler <Darin Adler> on 2009-11-03

  • blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
  • blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
  • blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
  • blog-files/acid3-100.png: Modified property svn:mime-type.
  • blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
  • blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
  • blog-files/acid3-screenshot.png: Modified property svn:mime-type.
  • blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
  • blog-files/acid3-timing.png: Modified property svn:mime-type.
  • blog-files/bounce.png: Added property svn:mime-type.
  • blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
  • blog-files/inspector-closure-scope.png: Added property svn:mime-type.
  • blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
  • blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
  • blog-files/inspector-databases-panel.png: Added property svn:mime-type.
  • blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
  • blog-files/inspector-elements-panel.png: Added property svn:mime-type.
  • blog-files/inspector-event-scope.png: Added property svn:mime-type.
  • blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
  • blog-files/inspector-resources-panel.png: Added property svn:mime-type.
  • blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
  • blog-files/inspector-searching-elements.png: Added property svn:mime-type.
  • blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
  • blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
  • blog-files/inspector-toolbar.png: Added property svn:mime-type.
  • blog-files/inspector-with-scope.png: Added property svn:mime-type.
  • blog-files/inspector/breakpoints.png: Added property svn:mime-type.
  • blog-files/inspector/colors.png: Added property svn:mime-type.
  • blog-files/inspector/cookies.png: Added property svn:mime-type.
  • blog-files/inspector/css_selectors.png: Added property svn:mime-type.
  • blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
  • blog-files/inspector/dom_storage.png: Added property svn:mime-type.
  • blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
  • blog-files/inspector/enable.png: Added property svn:mime-type.
  • blog-files/inspector/event_listeners.png: Added property svn:mime-type.
  • blog-files/inspector/form_data.png: Added property svn:mime-type.
  • blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
  • blog-files/inspector/inorder.png: Added property svn:mime-type.
  • blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
  • blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
  • blog-files/inspector/load_lines.png: Added property svn:mime-type.
  • blog-files/inspector/nodelist.png: Added property svn:mime-type.
  • blog-files/inspector/scope_bar.png: Added property svn:mime-type.
  • blog-files/inspector/watched_expression.png: Added property svn:mime-type.
  • blog-files/kate-circle.png: Modified property svn:mime-type.
  • blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
  • blog-files/kate-gradient.png: Modified property svn:mime-type.
  • blog-files/kate-reflected.png: Modified property svn:mime-type.
  • blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
  • blog-files/kate.png: Modified property svn:mime-type.
  • blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
  • blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
  • blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
  • blog-files/maskspeedracer.png: Modified property svn:mime-type.
  • blog-files/pulse.png: Added property svn:mime-type.
  • blog-files/scrollbarpicture.png: Modified property svn:mime-type.
  • blog-files/sfx-perf.png: Modified property svn:mime-type.
  • blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
  • blog-files/squirrelfish.png: Modified property svn:mime-type.
  • blog-files/vignette-mask.png: Modified property svn:mime-type.
  • blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
  • blog-files/wsj-nopreload.png: Modified property svn:mime-type.
  • blog-files/wsj-preload.png: Modified property svn:mime-type.
  • blog-files/wsj-vs.png: Modified property svn:mime-type.
  • blog/wp-admin/images/align-center.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-left.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-none.png: Added property svn:mime-type.
  • blog/wp-admin/images/align-right.png: Added property svn:mime-type.
  • blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
  • blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
  • blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
  • blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
  • blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/fav.png: Added property svn:mime-type.
  • blog/wp-admin/images/generic.png: Added property svn:mime-type.
  • blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/icons32.png: Added property svn:mime-type.
  • blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/list.png: Added property svn:mime-type.
  • blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
  • blog/wp-admin/images/marker.png: Added property svn:mime-type.
  • blog/wp-admin/images/mask.png: Added property svn:mime-type.
  • blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
  • blog/wp-admin/images/menu.png: Added property svn:mime-type.
  • blog/wp-admin/images/no.png: Added property svn:mime-type.
  • blog/wp-admin/images/se.png: Added property svn:mime-type.
  • blog/wp-admin/images/wheel.png: Added property svn:mime-type.
  • blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
  • blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
  • blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
  • blog/wp-admin/images/yes.png: Added property svn:mime-type.
  • blog/wp-content/Picture9.png: Modified property svn:mime-type.
  • blog/wp-content/chucknorris.png: Modified property svn:mime-type.
  • blog/wp-content/databaseexample.png: Modified property svn:mime-type.
  • blog/wp-content/drosera.png: Modified property svn:mime-type.
  • blog/wp-content/hitlist.png: Modified property svn:mime-type.
  • blog/wp-content/rotate.png: Modified property svn:mime-type.
  • blog/wp-content/svgtext.png: Modified property svn:mime-type.
  • blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
  • blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
  • blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
  • blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
  • blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
  • blog/wp-content/webInspector.png: Modified property svn:mime-type.
  • blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
  • blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
  • blog/wp-includes/images/rss.png: Modified property svn:mime-type.
  • blog/wp-includes/images/upload.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
  • blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
  • blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
  • blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
  • blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
  • blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
  • demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
  • demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
  • demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
  • demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
  • demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
  • demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
  • demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
  • demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
  • demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
  • demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
  • demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
  • demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
  • images/DroseraPic.png: Modified property svn:mime-type.
  • misc/drosera/drosera.png: Modified property svn:mime-type.
  • perf/slickspeed/logo.png: Modified property svn:mime-type.

WebKitSite/specs/CSSVisualEffects:

Patch by Darin Adler <Darin Adler> on 2009-11-03

  • css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
  • css3-2d-transforms/transform1.png: Modified property svn:mime-type.
  • css3-2d-transforms/transform2.png: Modified property svn:mime-type.
  • css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
  • css3-3d-transforms/transform1.png: Modified property svn:mime-type.
  • css3-3d-transforms/transform2.png: Modified property svn:mime-type.
  • css3-animations/animation1.png: Modified property svn:mime-type.
  • css3-animations/sandwich.png: Modified property svn:mime-type.
  • css3-transitions/TimingFunction.png: Modified property svn:mime-type.
  • css3-transitions/transition1.png: Modified property svn:mime-type.
7:37 PM Changeset in webkit [50496] by Simon Hausmann
  • 6 edits
    4 adds
    1 delete in trunk

WebCore: [Qt] Handle fonts like the other ports

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

​https://bugs.webkit.org/show_bug.cgi?id=29856

Test: svg/text/text-font-invalid.html

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/qt/FontFallbackListQt.cpp:

Removed. We now use the implementation from FontFallbackList.cpp

  • platform/graphics/qt/FontPlatformData.h:

Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
​https://bugs.webkit.org/show_bug.cgi?id=29856

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

  • svg/text/text-font-invalid-expected.txt: Added.
  • svg/text/resources/text-font-invalid.svg: Added.
  • svg/text/text-font-invalid.html: Added.
7:26 PM Changeset in webkit [50495] by rolandsteiner@chromium.org
  • 1 edit
    65 adds in trunk/LayoutTests

Bug 28420 - Implement HTML5 <ruby> rendering
(​https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support - layout tests.

New layout tests: basic rendering:

  • fast/ruby/ruby-empty-rt.html: Added.
  • fast/ruby/ruby-length.html: Added.
  • fast/ruby/ruby-run-break.html: Added.
  • fast/ruby/ruby-runs-spans.html: Added.
  • fast/ruby/ruby-runs.html: Added.
  • fast/ruby/ruby-simple-rp.html: Added.
  • fast/ruby/ruby-simple.html: Added.
  • fast/ruby/ruby-trailing.html: Added.


New layout tests: DOM manipulation within <ruby>

  • fast/ruby/rubyDOM-insert-rt.html: Added.
  • fast/ruby/rubyDOM-insert-text1.html: Added.
  • fast/ruby/rubyDOM-insert-text2.html: Added.
  • fast/ruby/rubyDOM-insert-text3.html: Added.
  • fast/ruby/rubyDOM-remove-rt1.html: Added.
  • fast/ruby/rubyDOM-remove-rt2.html: Added.
  • fast/ruby/rubyDOM-remove-text1.html: Added.
  • fast/ruby/rubyDOM-remove-text2.html: Added.


New layout tests results:

  • platform/mac/fast/ruby: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
  • platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-length-expected.png: Added.
  • platform/mac/fast/ruby/ruby-length-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.png: Added.
  • platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.png: Added.
  • platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
  • platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
6:18 PM Web Inspector Update.ja created by casey.hattori@gmail.com
6:09 PM Changeset in webkit [50494] by Joseph Pecoraro
  • 1 edit
    19 adds in trunk/WebKitSite

2009-11-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Adding images for an upcoming blog post.

  • blog-files/inspector/breakpoints.png: Added.
  • blog-files/inspector/colors.png: Added.
  • blog-files/inspector/cookies.png: Added.
  • blog-files/inspector/css_selectors.png: Added.
  • blog-files/inspector/css_syntax_highlight.png: Added.
  • blog-files/inspector/dom_storage.png: Added.
  • blog-files/inspector/edit_attributes.png: Added.
  • blog-files/inspector/enable.png: Added.
  • blog-files/inspector/event_listeners.png: Added.
  • blog-files/inspector/form_data.png: Added.
  • blog-files/inspector/inline_highlight.png: Added.
  • blog-files/inspector/inorder.png: Added.
  • blog-files/inspector/inspect_inspector.png: Added.
  • blog-files/inspector/inspect_inspector_small.png: Added.
  • blog-files/inspector/load_lines.png: Added.
  • blog-files/inspector/nodelist.png: Added.
  • blog-files/inspector/scope_bar.png: Added.
  • blog-files/inspector/watched_expression.png: Added.
5:34 PM Changeset in webkit [50493] by mitz@apple.com
  • 2 edits in trunk/WebCore

Leopard build fix

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::core):

5:25 PM Changeset in webkit [50492] by oliver@apple.com
  • 6 edits
    1 move in trunk/LayoutTests

2009-11-03 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Add overridePreference call to all WebGL layout tests
​https://bugs.webkit.org/show_bug.cgi?id=31088

  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/getActiveTest.html:
  • fast/canvas/webgl/gl-get-calls.html:
  • fast/canvas/webgl/incorrect-context-object-behaviour.html:
  • fast/canvas/webgl/null-object-behaviour.html:
  • fast/canvas/webgl/resources/shader-test.js: Removed.
  • fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.
5:11 PM Changeset in webkit [50491] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.

Reviewed by Steve Falkenburg.

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

5:02 PM Changeset in webkit [50490] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac

Reviewed by Alexey Proskuryakov.

  • platform/network/mac/AuthenticationMac.mm:
4:00 PM Changeset in webkit [50489] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2009-11-03 Eric Z. Ayers <​zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test for turning on the timeline profiler. This caused
a crash because profiling was enabled in the middle of processing
an event.

​https://bugs.webkit.org/show_bug.cgi?id=31080

  • inspector/timeline-trivial-expected.txt: Added.
  • inspector/timeline-trivial.html: Added.

2009-11-03 Eric Z. Ayers <​zundel@google.com>

Reviewed by Timothy Hatcher.

Fixes a problem where the timeline instrumentation crashes if
timeline profiling is enabled or disabled in the middle of an
event dispatch.

​https://bugs.webkit.org/show_bug.cgi?id=31080

Test: inspector/timeline-trivial.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::processingUserGestureEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  • page/DOMTimer.cpp: (WebCore::DOMTimer::fired):
3:34 PM Changeset in webkit [50488] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <​eric@webkit.org>

No review, just changing wording of log message.

Change log string to say "failed" instead of "rejected"
when a commit fails due to an out of date checkout.
This makes grepping the commit-queue log for rejected patches easier.

  • Scripts/bugzilla-tool:
2:14 PM Changeset in webkit [50487] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <​eric@webkit.org>

No review, adding commonly known committers missing from the file.

  • Scripts/modules/committers.py: Add committers found by looking at SVN records.
2:07 PM Changeset in webkit [50486] by mitz@apple.com
  • 4 edits in trunk/WebCore

Allow a frame to go back to copy-on-scroll when it ceases being overlapped

Reviewed by Dave Hyatt.

The code was not testing slow-scrolling frames for overlappedness, thinking the answer
would not matter. That is not the case if the only reason for the slow-scrolling is
being overlapped.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
reason besides being overlapped that the frame would need to fully repaint on scroll.

  • page/FrameView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().

2:04 PM Changeset in webkit [50485] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <​eric@webkit.org>

No review, just sort-order cleanup.

  • Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2:04 PM Changeset in webkit [50484] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to try and fix Windows nightlies.

1:39 PM Changeset in webkit [50483] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, Qt build fix.

Need to use right capitalization for include file.

  • page/Navigator.cpp:
1:34 PM Changeset in webkit [50482] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate from top bar filters to check boxes in Timeline.

​https://bugs.webkit.org/show_bug.cgi?id=31081

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
  • inspector/front-end/inspector.css:
1:30 PM Changeset in webkit [50481] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clear overview on Clear action and panel reset.

​https://bugs.webkit.org/show_bug.cgi?id=31078

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):
1:24 PM Changeset in webkit [50480] by eric@webkit.org
  • 2 edits
    9 adds in trunk/WebCore

2009-11-03 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Imported action and rules python files that WebCore.gyp depends on.
These files used to live in chromium.org and deal mostly with auto-generation
of code by wrapping existing webkit perl scripts.

​https://bugs.webkit.org/show_bug.cgi?id=31071

  • WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
  • WebCore.gyp/scripts/action_csspropertynames.py: Added.
  • WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
  • WebCore.gyp/scripts/action_makenames.py: Added.
  • WebCore.gyp/scripts/action_maketokenizer.py: Added.
  • WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
  • WebCore.gyp/scripts/rule_binding.py: Added.
  • WebCore.gyp/scripts/rule_bison.py: Added.
  • WebCore.gyp/scripts/rule_gperf.py: Added.
1:18 PM Changeset in webkit [50479] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

1:18 PM Changeset in webkit [50478] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.21.9

New tag.

1:12 PM Changeset in webkit [50477] by dimich@chromium.org
  • 14 edits
    4 adds in trunk

WebCore: Implement window.navigator.registerProtocolHandler in webkit,
​https://bugs.webkit.org/b/29651

Patch by Bradley Green <​brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

Also implemented its sister API window.navigator.registerContentHandler.

These methods are as described in the HTML5 specification which can be
found here,
​http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
​http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler

As specified in the document, the behavior of the browser is determined
by the current registered handler. The state of a registered handler
can change at any time, with the user clearing a registered handler,
registering a different page as handler, or deferring the hander to the
OS. If webkit was to track the state of the currently registered
handlers, it would need more APIs and complexity to keep in sync with
user actions reported to webkit from the UA. For simplicity, the state
of protocol handlers should be kept isolated from webkit and webkit only
notifies the UA that a page has made the call. The UA is then
responsible for correctly handling the registerProtocolHandler call and
the redirects which result from registration.

We do however follow the specification in insuring that the reserved
schemes and mimeTypes are not passed to the UA as custom handler
registration tests. We also insure that the "%s" token is present as
required by the specification.

Updated test expectations for window.clientInformation and navigator
objects.

Tests: fast/dom/registerContentHandler.html

fast/dom/registerProtocolHandler.html

  • page/Chrome.cpp:

(WebCore::Chrome::registerProtocolHandler):
(WebCore::Chrome::registerContentHandler):

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::registerProtocolHandler):
(WebCore::ChromeClient::registerContentHandler):

  • page/Navigator.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
(WebCore::verifyProtocolHandlerMimeType):
(WebCore::Navigator::registerContentHandler):

  • page/Navigator.h:
  • page/Navigator.idl:

LayoutTests: Updating test expectations for implementation of
window.navigator.registerProtocolHandler and
window.navigator.registerContentHandler.

Patch by Bradley Green <​brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

There is a default implimentation for these APIs, hence all platforms
with the navigator-detached-no-crash-expect and
window-properties-expected tests needed to be updated. While
isolatedWorlds has a window-properties-expected test, it has no window
object and hence does not need to be updaetd.

We add two fast/dom tests to insure that the proper exceptions are
thrown when bad syntax or security violations are made by calling the
methods.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/dom/navigator-detached-no-crash.html:
  • fast/dom/registerContentHandler-expected.txt: Added.
  • fast/dom/registerContentHandler.html: Added.
  • fast/dom/registerProtocolHandler-expected.txt: Added.
  • fast/dom/registerProtocolHandler.html: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
1:06 PM Changeset in webkit [50476] by beidson@apple.com
  • 8 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h

Reviewed by Darin Adler.

No new tests. (No change in functionality)

  • dom/Document.cpp:

(WebCore::Document::inspectorTimelineAgent): Moved from Document.h

  • dom/Document.h:

Include "Page.h" directly:

  • html/HTMLVideoElement.cpp:
  • loader/RedirectScheduler.cpp:
  • page/History.cpp:
  • rendering/MediaControlElements.cpp:
  • storage/StorageAreaImpl.cpp:
12:59 PM Changeset in webkit [50475] by senorblanco@chromium.org
  • 2 edits in trunk/WebKitTools

(Unreviewed).

Add myself to committers.py.

  • Scripts/modules/committers.py:
12:56 PM Changeset in webkit [50474] by mrowe@apple.com
  • 6 edits in branches/safari-4-branch

Merge r50443.

12:04 PM Changeset in webkit [50473] by kevino@webkit.org
  • 1 edit
    8 adds in trunk/WebKitTools

Reviewed by Kevin Ollviier.

Add packaging scripts for Debian-based Linux distros.

​https://bugs.webkit.org/show_bug.cgi?id=31075

11:38 AM Changeset in webkit [50472] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: hover over JS "things" in source and see their values
​https://bugs.webkit.org/show_bug.cgi?id=30913

  • inspector/front-end/SourceFrame.js:
11:24 AM Changeset in webkit [50471] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: update timeline content boundaries on timer.

​https://bugs.webkit.org/show_bug.cgi?id=31072

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._setWindowPosition):
11:07 AM Changeset in webkit [50470] by mitz@apple.com
  • 10 edits
    4 adds in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=31070
Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

Tests: plugins/attach-during-destroy.html

plugins/destroy-reentry.html

These crashes were caused by plug-in code running during detach(),
causing re-entry into RenderWidget::destroy() in one case and a call
into attach() in the other. The fix is to prevent plug-in code from
being called at certain unsafe times (during attach(), detach(), and
recalcStyle()) by deferring changes to the widget hierarchy.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle): Suspend widget hierarchy updates

during style recalculation.

  • dom/Element.cpp:

(WebCore::Element::attach): Suspend widget hierarchy updates during

attach().

(WebCore::Element::detach): Suspend widget hierarchy updates during

detach().

  • rendering/RenderWidget.cpp:

(WebCore::widgetNewParentMap): Returns a static map of pending changes

to the widget hierarchy.

(WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the

suspend count.

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the

suspend count. If the count is going to be zero, updates the widget
hierarchy by executing the pending changes stored in the map.

(WebCore::moveWidgetToParentSoon): Updates the widget hierarchy

immediately or makes or updates an entry in the map, depending on
whether updates are suspended.

(WebCore::RenderWidget::destroy): Removed earlier bandaid fix for

<rdar://problem/6937089>.

(WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates

are not suspended, because this function updates the widget’s
bounds, which can result in arbitrary native and JavaScript code
execution. I think this assertion is true thanks to some deferred-
update mechanisms that have already been deployed in other places
in the code.

(WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead

of changing the widget hierarchy directly.

  • rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()

and resumeWidgetHierarchyUpdates().

WebKitTools: ​https://bugs.webkit.org/show_bug.cgi?id=31070

Reviewed by Anders Carlsson and Beth Dakin.

Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
destroyed, it executes the value of the 'ondestroy' parameter as a
script.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginAllocate): Initialize onDestroy.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define

onDestroy.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
specified.
(NPP_Destroy): Execute the value of 'ondestroy' as a script.

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=31070
Test for <rdar://problem/7194735> Crashes at RenderText::RenderText()
Test for <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

  • plugins/attach-during-destroy-expected.txt: Added.
  • plugins/attach-during-destroy.html: Added.
  • plugins/destroy-reentry-expected.txt: Added.
  • plugins/destroy-reentry.html: Added.
11:06 AM Changeset in webkit [50469] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: only show timeline records that contribute
to the current window.

​https://bugs.webkit.org/show_bug.cgi?id=31069

10:45 AM Changeset in webkit [50468] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Watch expression editor should stay open after Add button was clicked
​https://bugs.webkit.org/show_bug.cgi?id=31049

No new tests, was a regression, use existing manual test.

  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression):
10:37 AM Changeset in webkit [50467] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-03 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

A test that reproduces a hard-to-trigger memory corruption in the
CSS lexer.

​https://bugs.webkit.org/show_bug.cgi?id=30827

  • fast/css/end-of-buffer-crash.html: Added.

2009-11-03 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

Fix an off-by-one in the CSS lexer that causes memory corruption in
hard-to-trigger circumstances.

​https://bugs.webkit.org/show_bug.cgi?id=30827

Test: fast/css/end-of-buffer-crash.html

  • css/maketokenizer: Add comments, fix off-by-one.
10:23 AM Changeset in webkit [50466] by Darin Adler
  • 4 edits
    2 adds in trunk

Crash due to double-destroy related to CSS run-in property
​https://bugs.webkit.org/show_bug.cgi?id=31034
rdar://problem/7328458

Patch by Darin Adler <Darin Adler> on 2009-11-02
Reviewed by Dan Bernstein.

WebCore:

Test: fast/css/run-in-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy): Reorder destruction so the
continuation is destroyed after anonymous children. See comment
in the code for more details of why this is right.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy): Ditto.

LayoutTests:

  • fast/css/run-in-crash-expected.txt: Added.
  • fast/css/run-in-crash.html: Added.
10:22 AM Changeset in webkit [50465] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix exception in ElementsPanel.js when moving pointer out of crumbs and window

There might be no new node under mouse if the pointer is moved out of the window
in which case we get an exception.
​https://bugs.webkit.org/show_bug.cgi?id=31061

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
10:09 AM Changeset in webkit [50464] by zoltan@webkit.org
  • 7 edits in trunk/WebCore

Allow custom memory allocation control for the dom directory of WebCore
​https://bugs.webkit.org/show_bug.cgi?id=31053

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and these are no need to be copyable:

class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51
struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552

Inherits QualifiedName class from FastAllocBase because it is
instantiated by 'new' in WebCore/editing/markup.cpp:319

  • dom/Document.cpp:
  • dom/EventNames.h:
  • dom/EventTarget.h:
  • dom/MessagePortChannel.h:
  • dom/NodeRareData.h:
  • dom/QualifiedName.h:
9:59 AM Changeset in webkit [50463] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement timeline summary panel.

​https://bugs.webkit.org/show_bug.cgi?id=31064

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineGraph.prototype.refresh):
  • inspector/front-end/inspector.css:
9:56 AM Changeset in webkit [50462] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Toggle off 'Search for node' when the Inspector window is closing

Searching for node should be toggled off when the Inspector window is closed,
in a platform-independent manner.
​https://bugs.webkit.org/show_bug.cgi?id=31059

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
9:49 AM Changeset in webkit [50461] by Nate Chapin
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-11-03 Victor Wang <​victorw@chromium.org>

Reviewed by Eric Seidel.

"​http://trac.webkit.org/changeset/50315" makes links mouse
focusable only on GTK and QT, so win has same behavior as mac now
Remove the win specific expected results for tests failed
due to the patch.

​https://bugs.webkit.org/show_bug.cgi?id=30968

  • platform/win/fast/events/click-focus-anchor-expected.txt: Removed.
  • platform/win/fast/inline: Removed.
  • platform/win/fast/inline/dirtyLinesForInline-expected.txt: Removed.
9:47 AM Changeset in webkit [50460] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-11-03 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Prepare for heap profiles upstreaming:

  • pass profile type id from InspectorController;
  • this makes WebInspector.CPUProfile redundant---removed;
  • support multiple profile types when populating profiles.

​https://bugs.webkit.org/show_bug.cgi?id=31052

  • inspector/InspectorController.cpp: (WebCore::InspectorController::createProfileHeader):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
  • inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
9:26 AM Changeset in webkit [50459] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-11-03 Dan Kegel <​dank@chromium.org>

Reviewed by Dimitri Glazkov.

UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
​https://bugs.webkit.org/show_bug.cgi?id=31063

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
9:06 AM Changeset in webkit [50458] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-11-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Timeline Window, wire it to the bottom timeline.

​https://bugs.webkit.org/show_bug.cgi?id=31056

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.get items): (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider): (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addExtraDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.get _resources):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._resizeWindow): (WebInspector.TimelinePanel.prototype._windowResizeDragging): (WebInspector.TimelinePanel.prototype._dragWindow): (WebInspector.TimelinePanel.prototype._windowDragging): (WebInspector.TimelinePanel.prototype._resizeWindowLeft): (WebInspector.TimelinePanel.prototype._resizeWindowRight): (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelinePanel.prototype._endWindowDragging): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue):
  • inspector/front-end/inspector.css:
8:13 AM Changeset in webkit [50457] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix build of unit-test after r50454.

Patch by Andras Becsi <​becsi.andras@stud.u-szeged.hu> on 2009-11-03
Reviewed by Simon Hausmann.

  • tests/qwebpage/tst_qwebpage.cpp:
7:54 AM Changeset in webkit [50456] by Simon Hausmann
  • 9 edits
    1 move in trunk

Make QWebPluginDatabase private API for now.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=30775

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/headers.pri:
  • Api/qwebplugindatabase.cpp:
  • Api/qwebplugindatabase_p.h: Renamed from WebKit/qt/Api/qwebplugindatabase.h.
  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • QtLauncher/main.cpp:

(MainWindow::setupUI):

  • tests/tests.pro:
7:06 AM Changeset in webkit [50455] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Rubber-stamped by Tor Arne Vestbø.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Oops, also remove the API docs of the removed networkRequestStarted() signal.

  • Api/qwebpage.cpp:
6:50 AM Changeset in webkit [50454] by Simon Hausmann
  • 8 edits in trunk

WebCore: Extended the conversion of the WebCore ResourceRequest to the
QNetworkRequest with a mandatory originating object argument,
which is meant to be the QWebFrame the request belongs to.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=29975

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

WebKit/qt: Replace the QWebPage::networkRequestStarted() signal with the originatingObject
property set to the QWebFrame that belongs to the request.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=29975

  • Api/qwebpage.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadFinished):
(TestNetworkManager::createRequest):
(tst_QWebPage::originatingObjectInNetworkRequests):

6:48 AM Changeset in webkit [50453] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: monitorEvent should be monitorEvents
​https://bugs.webkit.org/show_bug.cgi?id=31042

  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
5:04 AM Changeset in webkit [50452] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/plugins/PluginDatabase.cpp

[Qt] Windows CE build fix

4:32 AM Changeset in webkit [50451] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Add files to skiplist depend on phonon support,
which is disabled on the Qt buildbot for now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03

  • platform/qt/Skipped:
4:12 AM Changeset in webkit [50450] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03
Remove now passing tests from skiplist.

  • platform/qt/Skipped:
3:56 AM Changeset in webkit [50449] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Build fix for Windows CE

Rubber-stamped by Antti Koivisto.

  • plugins/PluginDatabase.cpp:
3:50 AM Changeset in webkit [50448] by vestbo@webkit.org
  • 1 edit in trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro

[Qt] Build fix for Mac OS X when building as framework

WTFReportAssertionFailure is not exported, so building DRT in debug
mode against QtWebKit built as a framework failes to link.

2:40 AM Changeset in webkit [50447] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Put test into skiplist added in r50411 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03

  • platform/qt/Skipped: inspector/css-syntax-highlight.html added
2:00 AM Changeset in webkit [50446] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Chris Fleizach <Chris Fleizach>

Reviewed by David Levin.

fix accessibility webkit-style-check errors
​https://bugs.webkit.org/show_bug.cgi?id=29672

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::platformGenerateAXID): (WebCore::AXObjectCache::removeAXID):
  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::enableAccessibility): (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility): (WebCore::AXObjectCache::accessibilityEnabled): (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled): (WebCore::AXObjectCache::isIDinUse): (WebCore::AXObjectCache::objectFromAXID): (WebCore::AXObjectCache::): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
  • accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityList.h: (WebCore::AccessibilityList::isList):
  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h: (WebCore::AccessibilityListBox::isListBox):
  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h: (WebCore::AccessibilityListBoxOption::isListBoxOption):
  • accessibility/AccessibilityMediaControls.h: (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl): (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline): (WebCore::AccessibilityMediaTimeline::isMediaTimeline): (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer): (WebCore::AccessibilityMediaControlsContainer::roleValue): (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored): (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay): (WebCore::AccessibilityMediaTimeDisplay::roleValue):
  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::replacedNodeNeedsCharacter): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::actionVerb):
  • accessibility/AccessibilityObject.h: (WebCore::PlainTextRange::isNull): (WebCore::AccessibilityObject::isAccessibilityRenderObject): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isAttachment): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::isLink): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isNativeImage): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isNativeTextControl): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isCheckboxOrRadio): (WebCore::AccessibilityObject::isListBox): (WebCore::AccessibilityObject::isFileUploadButton): (WebCore::AccessibilityObject::isProgressIndicator): (WebCore::AccessibilityObject::isSlider): (WebCore::AccessibilityObject::isControl): (WebCore::AccessibilityObject::isList): (WebCore::AccessibilityObject::isDataTable): (WebCore::AccessibilityObject::isTableRow): (WebCore::AccessibilityObject::isTableColumn): (WebCore::AccessibilityObject::isTableCell): (WebCore::AccessibilityObject::isFieldset): (WebCore::AccessibilityObject::isGroup): (WebCore::AccessibilityObject::isChecked): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::isSelected): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::isHovered): (WebCore::AccessibilityObject::isIndeterminate): (WebCore::AccessibilityObject::isLoaded): (WebCore::AccessibilityObject::isMultiSelect): (WebCore::AccessibilityObject::isOffScreen): (WebCore::AccessibilityObject::isPressed): (WebCore::AccessibilityObject::isReadOnly): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isRequired): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists): (WebCore::AccessibilityRenderObject::parentObject): (WebCore::AccessibilityRenderObject::isMenuRelated): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::doAXStringForRange): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::canHaveChildren): (WebCore::AccessibilityRenderObject::actionVerb): (WebCore::shouldReturnTagNameAsRoleForMSAA):
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
  • accessibility/AccessibilitySlider.h: (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren):
  • accessibility/AccessibilityTableRow.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.h:
1:44 AM CommitterTips edited by Csaba Osztrogonác
(diff)
12:52 AM CommitterTips edited by eric@webkit.org
(diff)
12:50 AM CommitterTips created by eric@webkit.org
12:27 AM WikiStart edited by eric@webkit.org
(diff)

Nov 2, 2009:

11:51 PM Changeset in webkit [50445] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-02 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Get the correct Gtk+ object before attempting to turn it into an AtkObject.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement):
11:01 PM Changeset in webkit [50444] by Chris Fleizach
  • 23 edits in trunk/WebCore

fix accessibility webkit-style-check errors
​https://bugs.webkit.org/show_bug.cgi?id=29672

Reviewed by David Levin.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityList.h:

(WebCore::AccessibilityList::isList):

  • accessibility/AccessibilityListBox.cpp:
  • accessibility/AccessibilityListBox.h:

(WebCore::AccessibilityListBox::isListBox):

  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::isListBoxOption):

  • accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):

  • accessibility/AccessibilityObject.h:

(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

  • accessibility/AccessibilityTableColumn.cpp:
  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/AccessibilityTableRow.cpp:
  • accessibility/mac/AccessibilityObjectWrapper.h:
10:49 PM Changeset in webkit [50443] by oliver@apple.com
  • 6 edits in trunk

REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
​https://bugs.webkit.org/show_bug.cgi?id=31045

Reviewed by Gavin Barraclough.

Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.

9:51 PM Changeset in webkit [50442] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-11-02 Darin Fisher <​darin@chromium.org>

Fixing JSC build bustage.

  • bindings/js/ScriptController.cpp: Added missing #include
9:47 PM Changeset in webkit [50441] by darin@chromium.org
  • 7 edits in trunk/WebCore

2009-10-30 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=30967

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
  • bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
  • bindings/v8/V8Proxy.h: Ditto
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowJavaScript):
  • platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function
8:40 PM Changeset in webkit [50440] by beidson@apple.com
  • 2 edits in trunk/WebCore

Rubberstamped by Mark Rowe.

Fix a typo in Mark's last commit.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

8:00 PM Changeset in webkit [50439] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Re-enable support for web archives on Windows. It was mistakenly disabled in r50438.

Rubber-stamped by Brady Eidson.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

7:24 PM Changeset in webkit [50438] by eric@webkit.org
  • 10 edits in trunk

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
​https://bugs.webkit.org/show_bug.cgi?id=23671

  • wtf/Platform.h: Turn on CF support if both QT and DARWIN platforms are defined.

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
​https://bugs.webkit.org/show_bug.cgi?id=23671

  • WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp to the Darwin build.
  • loader/archive/ArchiveFactory.cpp: Change the support for legacy WebArchive from all CF platforms to Mac and Chromium CF platforms. (WebCore::archiveMIMETypes):
  • platform/text/AtomicString.h: Remove PLATFORM(QT) && PLATFORM(DARWIN) test as it is redundant now.
  • platform/text/PlatformString.h: Ditto.
  • platform/text/StringImpl.h: Ditto.
  • platform/text/cf/StringCF.cpp: Ditto.
  • platform/text/cf/StringImplCF.cpp: Ditto.
6:35 PM Changeset in webkit [50437] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2009-11-02 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

[Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
​https://bugs.webkit.org/show_bug.cgi?id=30985

Our current code does not conform to our style guide.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/MIMETypeRegistryChromium.cpp:
  • plugins/chromium/PluginDataChromium.cpp:
  • plugins/chromium/PluginDataChromium.h: Added.
6:07 PM Changeset in webkit [50436] by adele@apple.com
  • 3 edits in trunk/WebCore

Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)

Reviewed by Darin Adler.

This bug is timing dependent, and not always reproducible. I could not think of a way to add a
layout test that would demonstrate the problem and fix.

  • platform/mac/ThemeMac.mm:

(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here. Consider that when deciding if the button should have the default style in RenderTheme.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active. This fixes

a problem I noticed where the button would flicker crazily if the page with the default button was in the background.

5:44 PM Changeset in webkit [50435] by mitz@apple.com
  • 3 edits in trunk/WebCore

Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.

Reviewed by Anders Carlsson.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().

  • rendering/RenderWidget.h:
5:39 PM QtBackLog edited by zecke@selfish.org
Mention #31009 (diff)
5:38 PM Changeset in webkit [50434] by dumi@chromium.org
  • 1 edit
    6 adds in trunk/WebCore

Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.

Patch by Dumitru Daniliuc <​dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=30701

  • storage/chromium: Added.
  • storage/chromium/DatabaseObserver.h: Added.
  • storage/chromium/DatabaseTrackerChromium.cpp: Added.
  • storage/chromium/QuotaTracker.cpp: Added.
  • storage/chromium/QuotaTracker.h: Added.
  • storage/chromium/SQLTransactionClientChromium.cpp: Added.
5:06 PM Changeset in webkit [50433] by enrica@apple.com
  • 4 edits
    2 adds in trunk

Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
​https://bugs.webkit.org/show_bug.cgi?id=31023

Reviewed by Adele Peterson and Dan Bernstein.

WebCore:

Test: editing/execCommand/align-in-span.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.

  • rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.

LayoutTests:

  • editing/execCommand/align-in-span-expected.txt: Added.
  • editing/execCommand/align-in-span.html: Added.
4:04 PM Changeset in webkit [50432] by cmarrin@apple.com
  • 8 edits in trunk

Exception checks were being too aggressive
​https://bugs.webkit.org/show_bug.cgi?id=31005

Several calls in CanvasRenderingContext3D are allowed to
have a null value passed, which indicated that the
object is being unbound. Handle this case and the corresponding
null handling in GraphicsContext3DMac.

2:53 PM Changeset in webkit [50431] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-11-02 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Each JS execution in console adds extra item into "scripts" combo
​https://bugs.webkit.org/show_bug.cgi?id=30212

Added manual test

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • manual-tests/inspector/hidden-evals.html: Added.
2:26 PM Changeset in webkit [50430] by eric@webkit.org
  • 2 edits in trunk

2009-11-02 Estêvão Samuel Procópio <​tevaum@gmail.com>

Reviewed by Gustavo Noronha.

[Build] make install ignores --prefix option for gobject-introspection.
​https://bugs.webkit.org/show_bug.cgi?id=31025

Make the build system use the --prefix path also when installing
gobject-introspection files.

  • configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR
2:03 PM Changeset in webkit [50429] by eric.carlson@apple.com
  • 6 edits in trunk/WebKit

2009-11-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values


Fix localized strings for media controller time values.

  • English.lproj/Localizable.strings:

2009-11-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaTimeDescription:]):

2009-11-02 Eric Carlson <​eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

  • WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
2:02 PM Changeset in webkit [50428] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
​https://bugs.webkit.org/show_bug.cgi?id=31030

  • dom/Node.cpp: (WebCore::eventHasListeners): Checks DOMWindow for listeners. (WebCore::Node::dispatchGenericEvent):
1:31 PM Changeset in webkit [50427] by dimich@chromium.org
  • 29 edits in trunk

Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
​https://bugs.webkit.org/show_bug.cgi?id=30612

Reviewed by David Levin.

JavaScriptCore:

  • wtf/MessageQueue.h:

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.

  • wtf/Threading.cpp:

(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for ​https://bugs.webkit.org/show_bug.cgi?id=30890

WebCore:

No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.

There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.

ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.

  • dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):

  • dom/ScriptExecutionContext.h:
  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):

  • dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):

  • loader/FrameLoader.cpp:

(WebCore::HashChangeEventTask::create):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):

  • storage/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):

  • storage/DatabaseThread.h:
  • storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):

  • storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::localStorageThread):

  • storage/LocalStorageThread.h:
  • websockets/WebSocket.cpp:

(WebCore::ProcessWebSocketEventTask::create):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):

  • workers/GenericWorkerTask.h:

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::postTask):

  • workers/WorkerContext.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerRunLoop.h:

(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):

1:14 PM Changeset in webkit [50426] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Made the remaining time display show negative zero at the end of the
video.

Reviewed by Anders Carlsson.

Made other cleanup.

  • WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of

_timeline and _volumeSlider to the more generic NSControl.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.

12:14 PM Changeset in webkit [50425] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
​https://bugs.webkit.org/show_bug.cgi?id=30589

  • platform/gtk/Skipped: Unskip fixed test.
11:34 AM Changeset in webkit [50424] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-02 Philippe Normand <​pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
​https://bugs.webkit.org/show_bug.cgi?id=30589

new m_seekTime attribute to keep track of the seek position

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
11:25 AM Changeset in webkit [50423] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove Referer when redirecting to non-secure site
​https://bugs.webkit.org/show_bug.cgi?id=31021

Remove referer from HTTP headers when redirecting to a non-secure
site.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
11:10 AM Changeset in webkit [50422] by xan@webkit.org
  • 2 edits in trunk

2009-11-02 Xan Lopez <​xlopez@igalia.com>

Bump version before release (or post-release, depending on your
point of view) so that we can make applications depending on
unreleased APIs in WebKit svn fail at configure time when the
requirements are not met.

  • configure.ac:
11:00 AM Changeset in webkit [50421] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=18539
multipart/form-data not being parsed correctly on server due to '+' in boundary string

No test - the characters that the boundary is made of are not deterministic.

  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as they cause problems on many web sites.
10:52 AM Changeset in webkit [50420] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-11-02 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Eric Carlson.

Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

Also fix call to logResult() as parameters were reversed, resulting in
printing an error message of "false".

​https://bugs.webkit.org/show_bug.cgi?id=31017

  • media/video-currentTime-set.html: Timeout increased to 2000ms.
10:41 AM Changeset in webkit [50419] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=30969
A no-prefix XPath node test should not match no-namespace elements in HTML document

Test: fast/xpath/null-namespace-in-html.html

  • xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements in HTML documents (as these are the ones that can have null namespace).
10:32 AM Changeset in webkit [50418] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-11-02 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] No timeline marks on resources panel.

​https://bugs.webkit.org/show_bug.cgi?id=31013

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
10:26 AM Changeset in webkit [50417] by levin@chromium.org
  • 2 edits in trunk/WebCore

Possible crash in RenderSlider::layout.
​https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <​levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

10:17 AM Changeset in webkit [50416] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-11-02 Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix Qt build on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=30905

  • WebCore.pro:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::create):
10:09 AM Changeset in webkit [50415] by eric@webkit.org
  • 5 edits
    4 adds in trunk

2009-11-02 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

​https://bugs.webkit.org/show_bug.cgi?id=29425

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):

2009-11-02 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

​https://bugs.webkit.org/show_bug.cgi?id=29425

  • tests/qwebview/tst_qwebview.cpp: (WebViewCrashTest::WebViewCrashTest): (WebViewCrashTest::loading): (tst_QWebView::crashTests):
10:01 AM Changeset in webkit [50414] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix a leftover from profiles panel generalization.

​https://bugs.webkit.org/show_bug.cgi?id=31010

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get searchableViews):
9:53 AM Changeset in webkit [50413] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Kai Koehne <​kai.koehne@nokia.com>

Reviewed by Holger Freyther.

Remove implementation of ImageDecocerQt::clearFrameBufferCache.
The implementation was buggy, and will visually break repeating
animations anyway.

​https://bugs.webkit.org/show_bug.cgi?id=31009

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::clearFrameBufferCache):
9:35 AM Changeset in webkit [50412] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-02 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Provides access to the reported content language.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_document_get_locale):
9:27 AM Changeset in webkit [50411] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2009-11-02 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
​https://bugs.webkit.org/show_bug.cgi?id=30907

  • inspector/css-syntax-highlight-expected.txt: Added.
  • inspector/css-syntax-highlight.html: Added.
  • inspector/javascript-syntax-highlight-expected.txt:

2009-11-02 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
​https://bugs.webkit.org/show_bug.cgi?id=30907

Test: inspector/css-syntax-highlight.html

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/inspectorSyntaxHighlight.css:
9:03 AM Changeset in webkit [50410] by mitz@apple.com
  • 7 edits in trunk

WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

  • WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary

#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.

  • WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import

statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
8:57 AM Changeset in webkit [50409] by Chris Fleizach
  • 21 edits
    4 adds in trunk

Support ARIA "tab" roles
​https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore:

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html

accessibility/aria-tab-roles.html

  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • html/HTMLAttributeNames.in:

WebKit:

Add a localizable string for tab panel.

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt:

WebKit/mac:

  • WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests:

  • accessibility/aria-controls-with-tabs-expected.txt: Added.
  • accessibility/aria-controls-with-tabs.html: Added.
  • accessibility/aria-tab-roles.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
  • platform/win/Skipped:
7:27 AM Changeset in webkit [50408] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium. The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not. In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test. This change brings Chromium in line with
the CG path.
​https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

4:36 AM BuildingQtOnOSX edited by vestbo@webkit.org
(diff)
1:37 AM Changeset in webkit [50407] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2009-11-01 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Adds window event dispatches to InspectorTimelineAgent.
​https://bugs.webkit.org/show_bug.cgi?id=31002

  • English.lproj/localizedStrings.js:
  • dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent. (WebCore::Node::dispatchGenericEvent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed. (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
1:25 AM Surfin' Safari Translations edited by casey.hattori@gmail.com
(diff)
1:25 AM Changeset in webkit [50406] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2009-11-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Convert script tag event into a more generic
script eval event in timeline.

​https://bugs.webkit.org/show_bug.cgi?id=30999

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
1:22 AM Surfin' Safari Translations created by casey.hattori@gmail.com

Nov 1, 2009:

10:36 PM newpage edited by casey.hattori@gmail.com
(diff)
10:34 PM newpage created by casey.hattori@gmail.com
10:21 PM Changeset in webkit [50405] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

  • dom/Node.cpp:

(WebCore::eventHasListeners):

10:07 PM QtBackLog edited by zecke@selfish.org
(diff)
10:03 PM Changeset in webkit [50404] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Re-fix the Mac build. Sorry :-(.

9:57 PM Changeset in webkit [50403] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Change ssize_t to unsigned to try and fix Windows build.

7:53 PM Changeset in webkit [50402] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]):

7:30 PM Changeset in webkit [50401] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-01 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

buildbots should use --exit-after-N-failures
​https://bugs.webkit.org/show_bug.cgi?id=30809

Make the bots exit after 20 failures to prevent never-ending
test runs where every test spends a minute crashing.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
7:23 PM Changeset in webkit [50400] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-11-01 Kelly Norton <​knorton@google.com>

Reviewed by Timothy Hatcher.

Does not send DOM dispatches to the InspectorTimelineAgent if there
are no event listeners.
​https://bugs.webkit.org/show_bug.cgi?id=30995

  • dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
7:14 PM Changeset in webkit [50399] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

6:50 PM Changeset in webkit [50398] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebCore

No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
​https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

  • WebCore.vcproj/WebCore.vcproj:
5:52 PM Changeset in webkit [50397] by rolandsteiner@chromium.org
  • 12 edits
    8 adds in trunk

Bug 28420 - Implement HTML5 <ruby> rendering
(​https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore:

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element

1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting

0-n inline object(s)

0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base

1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.

New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:

CSS

  • css/html.css: Added <ruby> and <rt>

Existing render files:

  • rendering/RenderBlock.cpp: make moveChild a member function moveChildTo

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name

  • rendering/RenderObject.h: add query methods for ruby renderers

(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:

  • rendering/RenderRuby.cpp: Added.

(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

  • rendering/RenderRuby.h: Added.

(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):

  • rendering/RenderRubyBase.cpp: Added.

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):

  • rendering/RenderRubyBase.h: Added.

(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):

  • rendering/RenderRubyRun.cpp: Added.

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderRubyRun.h: Added.

(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):

  • rendering/RenderRubyText.cpp: Added.

(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):

  • rendering/RenderRubyText.h: Added.

(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests:

Further layout tests will be committed in a follow-up patch under fast/ruby.

  • fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>
5:00 PM Changeset in webkit [50396] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null

Test: fast/dom/Node/default-namespace-empty-argument.html

  • dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.
1:38 PM Changeset in webkit [50395] by eric@webkit.org
  • 4 edits in trunk

2009-11-01 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
​https://bugs.webkit.org/show_bug.cgi?id=30971

Updating the expected result to reflect the change.

  • fast/loader/url-parse-1-expected.txt:

2009-11-01 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
​https://bugs.webkit.org/show_bug.cgi?id=30971

Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

  • platform/KURL.cpp: (WebCore::KURL::parse):
1:30 PM Changeset in webkit [50394] by oliver@apple.com
  • 4 edits in trunk/WebCore

Fix layering violations in GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

1:22 PM Changeset in webkit [50393] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Implements what has been implemented in AT-SPI.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):
12:49 PM Changeset in webkit [50392] by eric@webkit.org
  • 9 edits in trunk

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
​https://bugs.webkit.org/show_bug.cgi?id=30958

  • WebKit.pri: Turn on warnings for the GCC compiler

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
​https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
​https://bugs.webkit.org/show_bug.cgi?id=30958

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
​https://bugs.webkit.org/show_bug.cgi?id=30958

  • DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN
12:41 PM Changeset in webkit [50391] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

[Regression] monitorEvent doesn't work

  • inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
12:33 PM Changeset in webkit [50390] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
​https://bugs.webkit.org/show_bug.cgi?id=30990

  • inspector/front-end/SourceFrame.js:
12:04 PM Changeset in webkit [50389] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title

Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.
8:18 AM Changeset in webkit [50388] by eric@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

2009-11-01 Hironori Bono <​hbono@chromium.org>

Reviewed by Darin Adler.

Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
​https://bugs.webkit.org/show_bug.cgi?id=30902

  • fast/text/international/thai-cursor-position-expected.txt: Added.
  • fast/text/international/thai-cursor-position.html: Added.
  • platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
8:11 AM Changeset in webkit [50387] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Double clicking on a breakpoints should not select text
​https://bugs.webkit.org/show_bug.cgi?id=30950

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
8:03 AM Changeset in webkit [50386] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-11-01 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
​https://bugs.webkit.org/show_bug.cgi?id=30944

  • fast/css/list-item-pseudo-nocrash-expected.txt: Added.
  • fast/css/list-item-pseudo-nocrash.html: Added.

2009-11-01 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
​https://bugs.webkit.org/show_bug.cgi?id=30944

Test: fast/css/list-item-pseudo-nocrash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
7:54 AM Changeset in webkit [50385] by eric@webkit.org
  • 4 edits in trunk

2009-11-01 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

  • platform/gtk/Skipped: Unskip fixed test.

2009-11-01 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):
7:25 AM Changeset in webkit [50384] by jberlin@webkit.org
  • 2 edits in trunk/WebKitTools

2009-11-01 Jessie Berlin <​jberlin@webkit.org>

Adding myself to the committers list.

  • Scripts/modules/committers.py:

Oct 31, 2009:

4:22 PM Changeset in webkit [50383] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

4:10 PM Changeset in webkit [50382] by oliver@apple.com
  • 2 edits in trunk/WebCore

Remove obsolete null checks from CanvasRenderingContext3DMac
​https://bugs.webkit.org/show_bug.cgi?id=30983

Reviewed by Darin Adler

3:19 PM Changeset in webkit [50381] by oliver@apple.com
  • 6 edits
    6 adds in trunk

WebGL allows objects to be used with the wrong context
​https://bugs.webkit.org/show_bug.cgi?id=30981

Reviewed by Jon Honeycutt.

Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.

Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html

fast/canvas/webgl/null-object-behaviour.html

2:54 PM BuildingOnWindows edited by jberlin@webkit.org
(diff)
Note: See TracTimeline for information about the timeline view.