Timeline
Dec 18, 2009:
- 11:14 PM Changeset in webkit [52381] by
-
- 2 edits9 adds1 delete in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Split QueueStatus server into modules
https://bugs.webkit.org/show_bug.cgi?id=32768
One monolithic file is no good.
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/handlers/patchstatus.py: Added.
- QueueStatusServer/handlers/recentstatus.py: Added.
- QueueStatusServer/handlers/showresults.py: Added.
- QueueStatusServer/handlers/statusbubble.py: Added.
- QueueStatusServer/handlers/updatestatus.py: Added.
- QueueStatusServer/main.py: Added.
- QueueStatusServer/model.py: Added.
- QueueStatusServer/queue_status.py: Removed.
- 11:12 PM Changeset in webkit [52380] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
[Chromium] Eliminate redundant data copy in GraphicsContext3D readback
https://bugs.webkit.org/show_bug.cgi?id=32763
Eliminated useless creation of a CGBitmapContext and from there a
CGImage. Now create CGImage directly from data. Also changed
readPixels parameters and CGImage alpha info to try to avoid byte
swapping, and disabled interpolation when drawing the GL content.
Some test cases run twice as fast with these changes, though more
work is needed to achieve desired performance.
No test case; performance optimization only. Ran WebGL demos from
Khronos site to verify changes.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint):
- 10:40 PM Changeset in webkit [52379] by
-
- 2 edits in trunk/WebCore
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Simon Fraser.
Add a comment about some confusing code that otherwise would look like
it might be a bug.
https://bugs.webkit.org/show_bug.cgi?id=32534
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 10:33 PM Changeset in webkit [52378] by
-
- 3 edits2 moves in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Rubber stamped by Eric Seidel.
Renamed WorkQueue to QueueEngine. WorkQueue is not a queue.
- Scripts/modules/commands/queues.py:
- Scripts/modules/queueengine.py: Added.
- Scripts/modules/queueengine_unittest.py: Added.
- Scripts/modules/stepsequence.py:
- Scripts/modules/workqueue.py: Removed.
- Scripts/modules/workqueue_unittest.py: Removed.
- 10:05 PM Changeset in webkit [52377] by
-
- 4 edits in trunk/WebKitTools
2009-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767
dglazkov wanted to be added.
- Scripts/modules/bugzilla.py:
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- 10:02 PM Changeset in webkit [52376] by
-
- 2 edits in trunk/WebKit
Updated localizable strings after r52368
- English.lproj/Localizable.strings:
- 9:14 PM Changeset in webkit [52375] by
-
- 2 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Messed up the XCode file, trying to fix.
- WebCore.xcodeproj/project.pbxproj:
- 8:44 PM Changeset in webkit [52374] by
-
- 2 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, fix typos in WebCore.xcodeproj.
- WebCore.xcodeproj/project.pbxproj:
- 8:34 PM Changeset in webkit [52373] by
-
- 26 edits in trunk/WebCore
2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
SVGAngle / SVGPreserveAspectRatio should be POD types
https://bugs.webkit.org/show_bug.cgi?id=32758
Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
like it has been done for SVGMatrix / SVGLength before.
This patch prepares removing the special DOMObjectWithSVGContext hack.
No change in functionality, thus no new tests.
- 6:34 PM Changeset in webkit [52372] by
-
- 2 edits in trunk/WebCore
Chromium build fix, no review.
- storage/chromium/DatabaseTrackerChromium.cpp:
- 6:04 PM Changeset in webkit [52371] by
-
- 2 edits in trunk/WebCore
Build fix, no review.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Correct my typo
on the CG build.
- 6:03 PM Changeset in webkit [52370] by
-
- 2 edits in trunk/WebCore
Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32627
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):
- 5:59 PM Changeset in webkit [52369] by
-
- 3 edits in trunk/WebCore
Build fix, no review.
- page/win/FrameCairoWin.cpp: Add missing include.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData): Conditionalize
Safari-only call.
- 5:56 PM Changeset in webkit [52368] by
-
- 8 edits5 adds in trunk/WebKit
Add Mac WebKit side of the client based geolocation provider.
Reviewed by Dan Bernstein.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- Misc/WebKitErrors.m:
(registerErrors): Add Geolocation errors.
- Misc/WebKitErrorsPrivate.h:
- WebCoreSupport/WebGeolocationControllerClient.h: Added.
(WebGeolocationControllerClient::webView):
- WebCoreSupport/WebGeolocationControllerClient.mm: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.
- WebView/WebGeolocationPosition.h: Added.
- WebView/WebGeolocationPosition.mm: Added.
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
- WebView/WebGeolocationPositionInternal.h: Added.
Add an Objective-C wrapper for GeolocationPosition.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
- 5:27 PM Changeset in webkit [52367] by
-
- 2 edits in trunk/WebCore
Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=32626
- storage/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::close):
- 4:47 PM Changeset in webkit [52366] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-18 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=32756
- public/WebAccessibilityRole.h: (WebKit::):
- src/AssertMatchingEnums.cpp:
- 4:40 PM Changeset in webkit [52365] by
-
- 2 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52344.
- 4:40 PM Changeset in webkit [52364] by
-
- 2 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52342.
- 4:40 PM Changeset in webkit [52363] by
-
- 4 edits in tags/Safari-532.7.1/WebKit/mac
Merge r52338.
- 4:40 PM Changeset in webkit [52362] by
-
- 7 edits in tags/Safari-532.7.1/WebKit
Merge r52336.
- 4:40 PM Changeset in webkit [52361] by
-
- 4 edits in tags/Safari-532.7.1/WebCore
Merge r52331.
- 4:40 PM Changeset in webkit [52360] by
-
- 2 edits in tags/Safari-532.7.1/WebCore
Merge r52330.
- 4:40 PM Changeset in webkit [52359] by
-
- 10 edits in tags/Safari-532.7.1
Merge r52325.
- 4:39 PM Changeset in webkit [52358] by
-
- 4 edits in tags/Safari-532.7.1
Merge r52298.
- 4:39 PM Changeset in webkit [52357] by
-
- 4 edits in tags/Safari-532.7.1
Versioning.
- 4:33 PM Changeset in webkit [52356] by
-
- 2 edits in trunk/WebKit/mac
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(52325) Chromium build broken due to link failure
https://bugs.webkit.org/show_bug.cgi?id=32753
- WebCoreSupport/WebSystemInterface.m:
- Chromium Mac builds use this file, but do not enable Pre-compiled Header (PCH) files so that Chromium build bots can take advantage of the faster distcc 3. Eventually all mac builds will likely use distcc, but for now we'll add Platform.h here and document its usage so it's not removed by accident.
- 4:29 PM Changeset in webkit [52355] by
-
- 10 edits in trunk/JavaScriptCore
2009-12-18 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956
- JavaScriptCore.pri: Compile files unconditionally
- jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
- runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
- runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
- runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
- wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
- wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
- wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)
- 4:22 PM Changeset in webkit [52354] by
-
- 3 edits2 adds in trunk
2009-12-18 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
https://bugs.webkit.org/show_bug.cgi?id=31559
Fix an array bounds error when accessing the CSS value for a shorthand property that takes
a comma-separated list, after the list for one of the component properties has been set to a different length.
Test: fast/css/shorthand-mismatched-list-crash.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
- 4:09 PM Changeset in webkit [52353] by
-
- 1 copy in tags/Safari-532.7.1
New tag.
- 4:05 PM Changeset in webkit [52352] by
-
- 4 edits2 adds in trunk
REGRESSION(r52233): MSAA: Accessibility role of lists is wrong
https://bugs.webkit.org/show_bug.cgi?id=32736
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-role.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.
LayoutTests:
- platform/win/accessibility/list-role-expected.txt: Added.
- platform/win/accessibility/list-role.html: Added.
Verify that lists return the "list" role.
- 4:05 PM Changeset in webkit [52351] by
-
- 6 edits2 adds in trunk
MSAA: Accessibility role of list items is wrong
https://bugs.webkit.org/show_bug.cgi?id=32688
Reviewed by Adam Roben.
WebCore:
Test: platform/win/accessibility/list-item-role.html
- accessibility/AccessibilityObject.h:
(WebCore::):
Add a ListItemRole to the enum.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list item role map to the MSAA list item role.
LayoutTests:
- platform/win/accessibility/list-item-role-expected.txt: Added.
- platform/win/accessibility/list-item-role.html: Added.
Verify that the list item role is "list item".
- 4:05 PM Changeset in webkit [52350] by
-
- 3 edits2 adds in trunk
MSAA: Accessibility role of list markers is wrong
https://bugs.webkit.org/show_bug.cgi?id=32687
Reviewed by Adam Roben.
WebKit/win:
- AccessibleBase.cpp:
(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.
LayoutTests:
- platform/win/accessibility/list-marker-role-expected.txt: Added.
- platform/win/accessibility/list-marker-role.html: Added.
Verify that the list marker role is "text".
- 4:00 PM Changeset in webkit [52349] by
-
- 2 edits in trunk/WebCore
2009-12-18 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.
- WebCore.xcodeproj/project.pbxproj:
- 3:57 PM Changeset in webkit [52348] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix part II, this time it's personal.x
- 3:46 PM Changeset in webkit [52347] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.
- 2:59 PM Changeset in webkit [52346] by
-
- 13 edits in trunk/JavaScriptCore
Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.
Reviewed by Sam Weinig.
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
- API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
- JavaScriptCore.exp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/JSString.h:
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):
- runtime/UString.h:
(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):
- 2:51 PM Changeset in webkit [52345] by
-
- 6 edits1 add in trunk/WebCore
Fix mac Geolocation build.
- DerivedSources.make:
- WebCore.ClientBasedGeolocation.exp: Added.
- WebCore.xcodeproj/project.pbxproj:
- page/Geolocation.h:
- page/GeolocationError.h:
(WebCore::GeolocationError::GeolocationError):
- page/GeolocationPosition.h:
- 2:44 PM Changeset in webkit [52344] by
-
- 2 edits in trunk/WebKit/mac
Fix preference key name.
Reviewed by Anders Carlsson.
- WebView/WebPreferenceKeysPrivate.h:
- 2:18 PM Changeset in webkit [52343] by
-
- 3 edits in trunk/JavaScriptCore
Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)
Reviewed by Cameron Zwarich and Gavin Barraclough.
In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.
- interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.
- interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.
- 2:05 PM Changeset in webkit [52342] by
-
- 2 edits in trunk/WebKit/mac
Pass preference to plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
- 1:57 PM Changeset in webkit [52341] by
-
- 5 edits6 adds in trunk
Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.
Reviewed by Adam Roben.
WebCore:
The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.
Tests: platform/win/fast/events/panScroll-image-no-scroll.html
platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html
- dom/Node.cpp:
(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):
- dom/Node.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
LayoutTests:
Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.
- platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-image-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
- platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.
- 1:55 PM Changeset in webkit [52340] by
-
- 2 edits in trunk/WebKit/qt
2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>
Build fix, not reviewed.
- QtLauncher/main.cpp: (MainWindow::setTouchMocking): Leave setTouchMocking as an empty function for Qt < 4.6 so that moc still creates a slot for that. Otherwise, it would have generated a linker error.
- 1:45 PM Changeset in webkit [52339] by
-
- 2 edits in trunk/WebKitTools
2009-12-18 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
move bugzilla.py off of urllib2
https://bugs.webkit.org/show_bug.cgi?id=32729
- Scripts/modules/bugzilla.py: use mechanize for all url fetching.
- 1:43 PM Changeset in webkit [52338] by
-
- 4 edits in trunk/WebKit/mac
Add WKPCRunSyncOpenPanel implementation.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 1:18 PM Changeset in webkit [52337] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.
Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.
- wtf/Assertions.h:
- 1:17 PM Changeset in webkit [52336] by
-
- 7 edits in trunk/WebKit
Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.
Reviewed by Sam Weinig.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):
- WebView/WebPreferencesPrivate.h:
- 12:50 PM Changeset in webkit [52335] by
-
- 4 edits in trunk
[GTK] RemoveDashboard support. It's useless.
- configure.ac:
- 12:46 PM Changeset in webkit [52334] by
-
- 5 edits1 add in trunk/JavaScriptCore
Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.
Reviewed by Adam Roben.
Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):
- API/JSClassRef.h: Use WeakGCPtr.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/WeakGCPtr.h: Added.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.
- 12:45 PM Changeset in webkit [52333] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Add a needed export to fix the Windows build.
- 12:42 PM Changeset in webkit [52332] by
-
- 2 edits in trunk/WebCore
2009-12-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546
Omit SearchWeb from the context menu in the GTK+ port.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- 12:41 PM Changeset in webkit [52331] by
-
- 4 edits in trunk/WebCore
Add export the new symbol in WebCoreSystemInterface.
Reviewed by Anders Carlsson.
- WebCore.base.exp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:26 PM Changeset in webkit [52330] by
-
- 2 edits in trunk/WebCore
Forward declare NSMutableArray when not compiling for Objective-C.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- 12:02 PM Changeset in webkit [52329] by
-
- 7 edits1 add in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Reviewed by Sam Weinig.
- JavaScriptCore.exp:
- Remove exports for UString::append
- JavaScriptCore.xcodeproj/project.pbxproj:
- Make StringBuilder a private header (was project).
WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/StringBuilder.h: Added.
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- bridge/jni/jni_runtime.cpp:
(appendClassName):
(JavaMethod::signature):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
- 11:55 AM Changeset in webkit [52328] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709
Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.
- wtf/gtk/GRefPtr.h: (WTF::GRefPtr::operator=):
- 11:43 AM Changeset in webkit [52327] by
-
- 3 edits2 adds in trunk
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
- fast/canvas/webgl/bug-32692-expected.txt: Added.
- fast/canvas/webgl/bug-32692.html: Added.
2009-12-18 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692
Test: fast/canvas/webgl/bug-32692.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
- 11:36 AM Changeset in webkit [52326] by
-
- 5 edits in trunk
2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Disable page cache for tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey): (LayoutTestController::overridePreference):
- 11:22 AM Changeset in webkit [52325] by
-
- 10 edits in trunk
WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.
Reviewed by Anders Carlsson.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 11:16 AM Changeset in webkit [52324] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.
- platform/win/fast/dom/Element: Added.
- platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- 10:48 AM Changeset in webkit [52323] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix gtk-doc of webkit_web_resource_new.
- webkit/webkitwebresource.cpp:
- 10:35 AM Changeset in webkit [52322] by
-
- 2 edits in trunk/WebCore
GTK build fix
- plugins/gtk/PluginViewGtk.cpp: Added #include.
- 10:00 AM Changeset in webkit [52321] by
-
- 8 edits in trunk
Build fixes
WebCore: Chromium build fix
- platform/chromium/PopupMenuChromium.cpp: Added #include.
WebKit/chromium: Chromium build fix
- src/ChromiumBridge.cpp:
- src/WebPluginContainerImpl.cpp:
- src/WebViewImpl.cpp:
Added #includes.
WebKit/qt: Qt build fix
- Api/qwebpage.cpp: Added #include.
- 9:54 AM Changeset in webkit [52320] by
-
- 2 edits in trunk/WebCore
Chromium build fix
- html/HTMLLinkElement.cpp: Added #include.
- 9:52 AM Changeset in webkit [52319] by
-
- 6 edits in trunk
Qt build fix
WebCore:
- platform/qt/RenderThemeQt.cpp:
- plugins/qt/PluginDataQt.cpp:
- plugins/qt/PluginViewQt.cpp:
Added #includes.
WebKit/qt:
- Api/qwebpage.cpp:
Added #includes.
- 9:47 AM Changeset in webkit [52318] by
-
- 3 edits in trunk/WebKitTools
2009-12-18 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Check one space before end of line comments.
https://bugs.webkit.org/show_bug.cgi?id=32597
Fix to check one space before end of line comments in whitespace and build/header_guard.
Also fix build/header_guard to use WebKit header guard defines.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 9:47 AM Changeset in webkit [52317] by
-
- 2 edits in trunk/WebCore
V8 build fix
- bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.
- 9:45 AM Changeset in webkit [52316] by
-
- 2 edits in trunk/WebKit/gtk
GTK build fix
- webkit/webkitprivate.cpp: Added #include.
- 9:42 AM Changeset in webkit [52315] by
-
- 2 edits in trunk/WebCore
GTK (and others?) build fix
- platform/text/StringImpl.h: Added #include.
- 9:38 AM Changeset in webkit [52314] by
-
- 68 edits in trunk
Reduce #includes in a few high-use headers
Removed unnecessary #includes in these headers:
- Frame.h
- FrameWin.h
- Node.h
- Page.h
- StringImpl.h
The rest of the patch is all adding #includes to source files that now
require them.
Fixes <http://webkit.org/b/32718>.
Rubber-stamped by Anders Carlsson.
WebCore:
- dom/Node.h:
- page/Frame.h:
- page/Page.h:
- page/win/FrameWin.h:
- platform/text/StringImpl.h:
Removed unnecessary #includes.
- accessibility/win/AXObjectCacheWin.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- dom/Document.cpp:
- dom/InputElement.cpp:
- dom/Node.cpp:
- dom/SelectElement.cpp:
- editing/EditorCommand.cpp:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLParser.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLVideoElement.cpp:
- inspector/InspectorController.cpp:
- loader/FrameLoader.cpp:
- loader/HistoryController.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- page/Console.cpp:
- page/EventHandler.cpp:
- page/Frame.cpp:
- page/FrameView.cpp:
- page/Navigator.cpp:
- page/PageGroup.cpp:
- page/Settings.cpp:
- page/mac/EventHandlerMac.mm:
- platform/KURL.h:
- platform/ScrollbarThemeComposite.cpp:
- platform/cf/BinaryPropertyList.cpp:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- platform/mac/PopupMenuMac.mm:
- platform/mac/WidgetMac.mm:
- platform/network/cf/DNSCFNet.cpp:
- platform/text/StringImpl.cpp:
- platform/win/FileSystemWin.cpp:
- platform/win/PlatformScreenWin.cpp:
- platform/win/PopupMenuWin.cpp:
- platform/win/WidgetWin.cpp:
- plugins/PluginView.cpp:
- plugins/win/PluginViewWin.cpp:
- rendering/InlineTextBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderObject.cpp:
- rendering/RootInlineBox.cpp:
- storage/DatabaseTracker.cpp:
- storage/DatabaseTracker.h:
- storage/SQLTransactionClient.cpp:
- svg/graphics/SVGImage.cpp:
Added now-needed #includes.
WebKit/mac:
Add #includes needed after WebCore clean-up
- WebView/WebFrame.mm:
- WebView/WebFrameView.mm:
- WebView/WebView.mm:
WebKit/win:
Add #includes needed after WebCore clean-up
- WebCoreSupport/WebContextMenuClient.cpp:
- WebDataSource.cpp:
- WebHTMLRepresentation.cpp:
- WebView.cpp:
- WebView.h:
- 9:06 AM Changeset in webkit [52313] by
-
- 6 edits in trunk
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=32716
.:
- WebKit.pri: Use standalone_package instead of QTDIR_build
- pcre/pcre.pri: Use standalone_package instead of QTDIR_build
WebCore:
Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.
Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.
- WebCore.pro:
- 8:56 AM QtWebKitPerformanceWork edited by
- Minor spelling correction (diff)
- 8:40 AM Changeset in webkit [52312] by
-
- 36 edits20 adds in trunk
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
New test cases for isId support.
https://bugs.webkit.org/show_bug.cgi?id=5578
- dom/xhtml/level3/core/attrisid04-expected.txt:
- dom/xhtml/level3/core/attrisid04.js: (setUpPage):
- dom/xhtml/level3/core/attrisid05-expected.txt:
- dom/xhtml/level3/core/attrisid05.js: (setUpPage):
- fast/dom/Element/attrisid-extra01-expected.txt: Added.
- fast/dom/Element/attrisid-extra01.html: Added.
- fast/dom/Element/id-in-applet-expected.txt: Added.
- fast/dom/Element/id-in-applet.html: Added.
- fast/dom/Element/id-in-deletebutton-expected.txt: Added.
- fast/dom/Element/id-in-deletebutton.html: Added.
- fast/dom/Element/id-in-formcollection-expected.txt: Added.
- fast/dom/Element/id-in-formcollection.html: Added.
- fast/dom/Element/id-in-frame-expected.txt: Added.
- fast/dom/Element/id-in-frame.html: Added.
- fast/dom/Element/id-in-frameset-expected.txt: Added.
- fast/dom/Element/id-in-frameset.html: Added.
- fast/dom/Element/id-in-getelement01-expected.txt: Added.
- fast/dom/Element/id-in-getelement01.html: Added.
- fast/dom/Element/id-in-insert-hr-expected.txt: Added.
- fast/dom/Element/id-in-insert-hr.html: Added.
- fast/dom/Element/id-in-map-expected.txt: Added.
- fast/dom/Element/id-in-map.html: Added.
- fast/dom/Element/id-in-param-expected.txt: Added.
- fast/dom/Element/id-in-param.html: Added.
2009-12-18 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Darin Adler.
Implemented isId as specified by DOM Level 3. See detailed description below.
https://bugs.webkit.org/show_bug.cgi?id=5578
Added isId property and implementation:
Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
fast/dom/Element/attrisid-extra01.html
- dom/Attr.cpp: (WebCore::Attr::isId):
- dom/Attr.h:
- dom/Attr.idl:
Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
for the reason that id attribute name could be customized to a different
string other than "id". A test case is associated to each code change.
- dom/Document.cpp: (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
- dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::formatForDebugger): (WebCore::Element::rareIDAttributeName):
- dom/Element.h: Added function idAttributeName(). (WebCore::Element::idAttributeName):
- dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData. (WebCore::ElementRareData::ElementRareData):
- dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::NamedNodeMap::setNamedItem): (WebCore::NamedNodeMap::removeNamedItem): (WebCore::NamedNodeMap::setAttributes):
- dom/Node.cpp: Removed ASSERT as it may not hold any more. (WebCore::Node::querySelector):
- dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more. (WebCore::createSelectorNodeList):
- dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::StyledElement::parseMappedAttribute):
- editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::DeleteButtonController::createDeletionUI):
- editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html (WebCore::executeInsertHorizontalRule):
- html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::nextNamedItem): (WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html (WebCore::HTMLFrameElementBase::parseMappedAttribute): (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html (WebCore::HTMLMapElement::parseMappedAttribute):
- html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html (WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html (WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html (WebCore::HTMLParamElement::parseMappedAttribute):
- loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html (WebCore::CachedFont::getSVGFontById):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
- rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg (WebCore::writeRenderResources):
- svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html (WebCore::SVGElement::insertedIntoDocument):
- svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg (WebCore::SVGStyledElement::isKnownAttribute):
- wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute):
- 7:04 AM Changeset in webkit [52311] by
-
- 6 edits2 adds in trunk/WebKit/qt
2009-12-18 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
then checking current frame and then ancestors
https://bugs.webkit.org/show_bug.cgi?id=32668
- Api/qwebframe.cpp: (QWebFramePrivate::scrollOverflow): (QWebFrame::scrollRecursively):
- Api/qwebframe.h:
- Api/qwebframe_p.h:
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/testiframe.html: Added.
- tests/qwebframe/testiframe2.html: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:03 AM Changeset in webkit [52310] by
-
- 2 edits in trunk/WebCore
[Qt] Fix the build on Symbian.
Reviewed by Tor Arne Vestbø.
Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.
Functionally they should be equivalent, according to the source.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 6:01 AM Changeset in webkit [52309] by
-
- 2 edits in trunk/WebCore
2009-12-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] segfault during controls initialization if not GTK theme is present.
https://bugs.webkit.org/show_bug.cgi?id=32705
Create empty images for the controls if no GTK theme is set.
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::getThemeIconFileName): (WebCore::loadImageFromFile):
- 5:38 AM Changeset in webkit [52308] by
-
- 3 edits in trunk/WebCore
Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.
- 5:32 AM Changeset in webkit [52307] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix infinite recursion in touch mocking.
Reviewed by Tor Arne Vestbø.
Don't send the fake touch events to the view, as that'll trigger the
event filter again.
- QtLauncher/main.cpp:
(MainWindow::sendTouchEvent):
- 4:00 AM Changeset in webkit [52306] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
- 2:51 AM Changeset in webkit [52305] by
-
- 3 edits in trunk/WebCore
Remove the fragment identifier from url before passing it to libsoup.
In newer releases libsoup emits a warning when it gets handed a
fragment.
- 2:37 AM Changeset in webkit [52304] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703
Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.
- wtf/gtk/GRefPtr.cpp: (WTF::refGPtr):
- 1:50 AM Changeset in webkit [52303] by
-
- 3 edits2 adds in trunk
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Added test showing the problem described in the bug.
- editing/selection/wrapped-line-caret-3.html:
- editing/selection/wrapped-line-caret-3-expected.txt:
2009-12-18 Alejandro G. Castro <alex@igalia.com>
Reviewed by Darin Adler.
REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920
Moving up from a position after the end of the previous lines
should use UPSTREAM affinity to render the caret in the previous
line.
Test: editing/selection/wrapped-line-caret-3.html
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
Dec 17, 2009:
- 11:17 PM Changeset in webkit [52302] by
-
- 2 edits in trunk/WebCore
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
https://bugs.webkit.org/show_bug.cgi?id=32675
Use the double constant 2.0 instead of static_cast<double>(2).
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch):
- 10:39 PM Changeset in webkit [52301] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstreaming an XSS test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32685
- http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
- http/tests/security/xss-DENIED-assign-location-href-javascript.html: Added.
- 10:12 PM Changeset in webkit [52300] by
-
- 3 edits2 adds in trunk
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/text/text-font-uri-invalid-expected.txt: Added.
- svg/text/text-font-uri-invalid.svg: Added.
2009-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Dan Bernstein.
Bug 32357: SVG test case crashes WebKit (invalid font URL)
https://bugs.webkit.org/show_bug.cgi?id=32357
Added check for NULL return value from DocLoader::requestFont()
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
- 9:42 PM Changeset in webkit [52299] by
-
- 5 edits2 adds in trunk
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
- fast/inline/inline-marquee-crash-expected.txt: Added.
- fast/inline/inline-marquee-crash.html: Added.
2009-12-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dan Bernstein.
marquee with display:inline causes crash
https://bugs.webkit.org/show_bug.cgi?id=32374
Test: fast/inline/inline-marquee-crash.html
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume): (WebCore::HTMLMarqueeElement::renderMarquee):
- html/HTMLMarqueeElement.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- 8:14 PM Changeset in webkit [52298] by
-
- 4 edits in trunk
JavaScriptCore: Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
Reviewed by Mark Rowe.
- wtf/Platform.h:
WebKitTools: Add BUILDING_ON_SNOW_LEOPARD #define.
Reviewed by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- 8:12 PM Changeset in webkit [52297] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Unskip websocket tests
New pywebsocket (0.4.5) landed at WebKit r52296, so
sub-protocol-with-space.html should pass.
- platform/mac/Skipped: delete websocket/tests/sub-protocol-with-space.html
- platform/win/Skipped: delete websocket/tests/sub-protocol-with-space.html
- 6:38 PM Changeset in webkit [52296] by
-
- 6 edits2 copies in trunk/WebKitTools
2009-12-17 Yuzo Fujishima <yuzo@google.com>
Reviewed by Alexey Proskuryakov.
Update pywebsocket to 0.4.5 and make handshake checking stricter
https://bugs.webkit.org/show_bug.cgi?id=32249
- Scripts/run-webkit-tests:
- pywebsocket/mod_pywebsocket/handshake.py:
- pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py:
- pywebsocket/setup.py:
- pywebsocket/test/test_handshake.py:
- pywebsocket/test/test_memorizingfile.py: Added.
- 5:28 PM Changeset in webkit [52295] by
-
- 6 edits in trunk/WebKitTools
2009-12-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Command.show_in_main_help should default to False
https://bugs.webkit.org/show_bug.cgi?id=32686
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queries.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/multicommandtool.py:
- 4:51 PM Changeset in webkit [52294] by
-
- 4 edits in trunk/WebCore
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for inspector's classes
https://bugs.webkit.org/show_bug.cgi?id=32660
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
class ConsoleMessage - inspector/InspectorController.cpp:329
class InspectorController - page/Page.cpp:119
- inspector/ConsoleMessage.h:
- inspector/InspectorController.h:
- inspector/JavaScriptDebugServer.h:
- 3:22 PM Changeset in webkit [52293] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Eric Seidel <eric@webkit.org>
No review, rolling out r52291.
http://trac.webkit.org/changeset/52291
https://bugs.webkit.org/show_bug.cgi?id=32618
Darin Fisher points out that this will likely break
the SSL security indicator in Chromium. Rolling out for now.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 2:37 PM Changeset in webkit [52292] by
-
- 2 edits in trunk/WebCore
2009-12-17 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
https://bugs.webkit.org/show_bug.cgi?id=32675
Build fix only, no new tests.
- html/HTMLInputElement.cpp: Modified. (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'
- 2:14 PM Changeset in webkit [52291] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Eric Seidel.
Disable memory cache client calls so that a new identifier isn't created
for the same resource on reload.
With the calls enabled, duplicate entries for cached resources are created
in the Web Inspector. Safari for Windows disables the calls near the point of the
Frame instance creation, and we just follow this for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=32618
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- 2:10 PM Changeset in webkit [52290] by
-
- 4 edits in trunk
Versioning.
- 2:09 PM Changeset in webkit [52289] by
-
- 1 copy in tags/Safari-532.7
New tag.
- 1:52 PM Changeset in webkit [52288] by
-
- 9 edits in trunk/WebCore
2009-12-17 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Eric Seidel.
Fix link failure on LTCG builds on Windows for chromium port.
Reenable SVGAllInOne.cpp. This required some fixups.
Namely, there was conflicts in constants between HTMLNames and
SVGNames, and conflicts between static functions names.
No new tests as functionality has not changed.
- WebCore.gyp/WebCore.gyp:
- svg/SVGAllInOne.cpp:
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache): (WebCore::SVGGlyphElement::buildGlyphIdentifier):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): (WebCore::SVGStyleElement::setType): (WebCore::SVGStyleElement::media): (WebCore::SVGStyleElement::setMedia): (WebCore::SVGStyleElement::title): (WebCore::SVGStyleElement::setTitle): (WebCore::SVGStyleElement::parseMappedAttribute):
- svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
- svg/SVGStyledElement.h:
- 1:38 PM Changeset in webkit [52287] by
-
- 2 edits in trunk/WebCore
Chromium build fix VI
- svg/animation/SMILTimeContainer.h: Added now-needed #include.
- 1:37 PM Changeset in webkit [52286] by
-
- 2 edits in trunk/WebCore
Chromium build fix V
- platform/KURLGoogle.cpp: Added now-needed #include.
- 1:29 PM Changeset in webkit [52285] by
-
- 2 edits in trunk/WebCore
Chromium build fix IV
- loader/CrossOriginPreflightResultCache.h: Added now-needed
- 1:26 PM Changeset in webkit [52284] by
-
- 3 edits in trunk/WebKitTools
2009-12-17 Alejandro G. Castro <alex@igalia.com>
Reviewed by Eric Seidel.
Added the key WebKitEnableCaretBrowsing to the
layoutTestController.overridePreference in order to activate caret
browsing.
https://bugs.webkit.org/show_bug.cgi?id=32612
- DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of the setting.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new key in the keytable.
- 1:19 PM Changeset in webkit [52283] by
-
- 2 edits in trunk/WebCore
Chromium build fix III
- platform/graphics/Font.h: Added now-needed #include.
- 1:10 PM Changeset in webkit [52282] by
-
- 2 edits in trunk/WebCore
Chromium build fix II
- dom/EventTarget.h: Added now-needed #include.
- 1:09 PM Changeset in webkit [52281] by
-
- 4 edits in trunk/WebCore
2009-12-17 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for js bindings
https://bugs.webkit.org/show_bug.cgi?id=32655
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class ScriptCachedFrameData - history/CachedFrame.cpp:117
class WebCoreJSClientData - bindings/js/JSDOMWindowBase.cpp:162
class ScheduledAction - bindings/js/ScheduledAction.cpp:58
- bindings/js/JSDOMBinding.h:
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCachedFrameData.h:
- 12:56 PM Changeset in webkit [52280] by
-
- 2 edits in trunk/WebCore
Chromium build fix
- dom/QualifiedName.h: Added now-needed #include of HashTraits.h
(which itself #includes HashFunctions.h).
- 12:53 PM Changeset in webkit [52279] by
-
- 6 edits in trunk
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
2009-12-17 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Incorrect Doctype.
REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
https://bugs.webkit.org/show_bug.cgi?id=32671
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- 12:38 PM Changeset in webkit [52278] by
-
- 2 edits in trunk/WebCore
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
Reduces code size of Gtk build by another 5%.
- platform/text/PlatformString.h:
- 12:32 PM Changeset in webkit [52277] by
-
- 2 edits in trunk/WebKit/mac
Mac build fix
- WebView/WebVideoFullscreenController.mm: Added now-needed #import.
- 12:22 PM Changeset in webkit [52276] by
-
- 4 edits in trunk/WebCore
Mac/Qt build fixes
- platform/graphics/mac/Canvas3DLayer.mm:
- platform/graphics/mac/GraphicsContext3DMac.cpp:
- platform/qt/Localizations.cpp:
Added missing #includes.
- 12:00 PM Changeset in webkit [52275] by
-
- 6 edits in trunk
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
Patch by Benjamin Otte <otte@gnome.org> on 2009-12-17
Reviewed by Adam Roben.
WebCore:
PlatformString.h included almost all of JSC via runtime/Identifier.h.
This patch gets rid of this include by forward-declaring the required
classes instead.
This reduces the build size of the object files on a Gtk debug build
by 10%. The resulting libwebkit.so gets 5% smaller.
No new tests as it's just a build improvement.
- platform/gtk/LocalizedStringsGtk.cpp:
include math.h here (it used to be pulled by JSC)
- platform/text/PlatformString.h:
- platform/text/String.cpp:
WebKit/win:
- WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.
- 11:59 AM Changeset in webkit [52274] by
-
- 2 edits in trunk/WebCore
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Always use all WebCore include paths in GtkWebKit.
With this patch, I can disable all optional features and still build.
- GNUmakefile.am:
- 11:58 AM Changeset in webkit [52273] by
-
- 2 edits in trunk/LayoutTests
Unreviewed layout test fix.
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
The test for this patch shouldn't be run on Tiger.
- platform/mac-tiger/Skipped:
- 11:48 AM Changeset in webkit [52272] by
-
- 6 edits in trunk/WebKitTools
AX: DRT needs to support URL for accessibility
https://bugs.webkit.org/show_bug.cgi?id=32666
Reviewed by David Kilzer.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getURLCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::url):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::url):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::url):
- 11:36 AM Changeset in webkit [52271] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- Scripts/modules/committers.py:
- 11:23 AM Changeset in webkit [52270] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
More make distcheck fixes. Use a more robust solution to making
sure we are in the correct directory for running these tests.
- tests/testmimehandling.c: (main):
- tests/testwebview.c: (main):
- 11:21 AM Changeset in webkit [52269] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- 11:18 AM Changeset in webkit [52268] by
-
- 17 edits13 adds in trunk
2009-12-17 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Added WebPageSerializer to WebKit API and enriched the WebNode hierarchy to support
downstream unit-testing of serialization.
WebPageSerializer was adapted from Chromium's dom_serializer, originally authored by Johnny Ding.
- WebKit.gyp:
- public/WebDocument.h: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::assign):
- public/WebElement.h:
- public/WebFormElement.h: (WebKit::WebFormElement::operator=):
- public/WebFrame.h:
- public/WebNode.h: (WebKit::WebNode::): (WebKit::WebNode::toConstElement):
- public/WebNodeCollection.h: Added. (WebKit::WebNodeCollection::~WebNodeCollection): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::operator=):
- public/WebNodeList.h: Added. (WebKit::WebNodeList::~WebNodeList): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::operator=):
- public/WebPageSerializer.h: Added.
- public/WebPageSerializerClient.h: Added. (WebKit::WebPageSerializerClient::): (WebKit::WebPageSerializerClient::WebPageSerializerClient): (WebKit::WebPageSerializerClient::~WebPageSerializerClient):
- public/WebString.h:
- public/WebView.h:
- src/AssertMatchingEnums.cpp:
- src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute):
- src/DOMUtilitiesPrivate.h:
- src/WebDocument.cpp: Added. (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator WTF::PassRefPtr<Document>): (WebKit::WebDocument::frame): (WebKit::WebDocument::isHTMLDocument): (WebKit::WebDocument::baseURL): (WebKit::WebDocument::body): (WebKit::WebDocument::head): (WebKit::WebDocument::all): (WebKit::WebDocument::completeURL):
- src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::hasAttribute): (WebKit::WebElement::getAttribute):
- src/WebEntities.cpp: Added. (WebKit::populateMap): (WebKit::): (WebKit::WebEntities::WebEntities): (WebKit::WebEntities::entityNameByCode): (WebKit::WebEntities::convertEntitiesInString):
- src/WebEntities.h: Added.
- src/WebFrameImpl.cpp: (WebKit::WebFrame::fromFrameOwnerElement): (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::document): (WebKit::WebFrameImpl::fromFrameOwnerElement):
- src/WebFrameImpl.h:
- src/WebNode.cpp: (WebKit::WebNode::nodeType): (WebKit::WebNode::nodeValue): (WebKit::WebNode::document): (WebKit::WebNode::firstChild): (WebKit::WebNode::lastChild): (WebKit::WebNode::previousSibling): (WebKit::WebNode::nextSibling): (WebKit::WebNode::hasChildNodes): (WebKit::WebNode::childNodes): (WebKit::WebNode::createMarkup): (WebKit::WebNode::isTextNode): (WebKit::WebNode::isElementNode):
- src/WebNodeCollection.cpp: Added. (WebKit::WebNodeCollection::reset): (WebKit::WebNodeCollection::assign): (WebKit::WebNodeCollection::WebNodeCollection): (WebKit::WebNodeCollection::length): (WebKit::WebNodeCollection::nextItem): (WebKit::WebNodeCollection::firstItem):
- src/WebNodeList.cpp: Added. (WebKit::WebNodeList::reset): (WebKit::WebNodeList::assign): (WebKit::WebNodeList::WebNodeList): (WebKit::WebNodeList::length): (WebKit::WebNodeList::item):
- src/WebPageSerializer.cpp: Added. (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateMarkOfTheWebDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
- src/WebPageSerializerImpl.cpp: Added. (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeEndTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag): (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer): (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): (WebKit::WebPageSerializerImpl::buildContentForNode): (WebKit::WebPageSerializerImpl::WebPageSerializerImpl): (WebKit::WebPageSerializerImpl::collectTargetFrames): (WebKit::WebPageSerializerImpl::serialize):
- src/WebPageSerializerImpl.h: Added.
- src/WebString.cpp: (WebKit::WebString::WebString): (WebKit::WebString::operator=):
- src/WebViewImpl.cpp:
- 11:14 AM Changeset in webkit [52267] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
[GTK] Don't assume downloads are always synchronous
http://bugs.webkit.org/show_bug.cgi?id=32359
- tests/testdownload.c: (download_requested_cb): (set_filename): (test_webkit_download_perform): (test_webkit_download_synch): (test_webkit_download_asynch): (main): Test downloads synchronously and asynchronously.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_request_download): Only try to start a requested download if the destination URI is set and clarify the documentation.
- 11:13 AM Changeset in webkit [52266] by
-
- 8 edits8 adds in trunk
Merge branch 'bug/26304' into staging
- 11:12 AM Changeset in webkit [52265] by
-
- 2 edits in trunk/JavaScriptCore
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the source tree
Fixes <http://webkit.org/b/32665>.
Reviewed by Ada Chan.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.
- 11:12 AM Changeset in webkit [52264] by
-
- 7 edits4 deletes in trunk/JavaScriptCore
Remove HeavyProfile and TreeProfile completely
These were mostly removed in r42808, but the empty files were left in
place.
Fixes <http://webkit.org/b/32664>.
Reviewed by John Sullivan.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.
- profiler/HeavyProfile.cpp: Removed.
- profiler/HeavyProfile.h: Removed.
- profiler/TreeProfile.cpp: Removed.
- profiler/TreeProfile.h: Removed.
- 11:12 AM Changeset in webkit [52263] by
-
- 2 edits in trunk/WebKit/win
Remove WebKit.sln's Debug_All and Debug_Internal configurations
These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.
Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.
Rubber-stamped by Dan Bernstein.
- WebKit.vcproj/WebKit.sln:
- 11:09 AM Changeset in webkit [52262] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-17 Christian Dywan <christian@twotoasts.de>
Reviewed by Xan Lopez.
Deprecate the title-changed signal of WebKitWebFrame.
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- 10:39 AM Changeset in webkit [52261] by
-
- 3 edits2 adds in trunk/WebCore
2009-12-17 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] support navigator.onLine and ononline/onoffline events.
https://bugs.webkit.org/show_bug.cgi?id=32555
Hooked up Bearer Management to NetworkStateNotifier. This solution is available
only if QtMobility's Bearer Management is installed.
- WebCore.pro:
- platform/network/NetworkStateNotifier.h:
- platform/network/qt/NetworkStateNotifierPrivate.h: Added.
- platform/network/qt/NetworkStateNotifierQt.cpp: Added. (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifierPrivate::onlineStateChanged): (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate): (WebCore::NetworkStateNotifier::updateState): (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- 10:25 AM Changeset in webkit [52260] by
-
- 3 edits in trunk/WebCore
2009-12-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Switch to 11px as default for source-code in WebKit.
- inspector/front-end/inspector.css:
- 9:57 AM Changeset in webkit [52259] by
-
- 2 edits in trunk/WebCore
[Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
make sure we pick up the header file from QtCore. That is where the implementation
is compiled.
Reviewed by Tor Arne Vestbø.
- dom/XMLTokenizer.h:
- 9:44 AM Changeset in webkit [52258] by
-
- 9 edits2 copies2 adds in trunk
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 9:21 AM Changeset in webkit [52257] by
-
- 2 edits in trunk/WebKit/qt
2009-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with Q(GV)Launcher
https://bugs.webkit.org/show_bug.cgi?id=32434
The event delivery should go through QCoreApplication::sendEvent()
- QtLauncher/main.cpp: (MainWindow::sendTouchEvent):
- 9:09 AM Changeset in webkit [52256] by
-
- 3 edits in trunk/WebKit/qt
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for touch events in QWebView and QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=32432
- Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::sceneEvent):
- Api/qwebview.cpp: (QWebView::QWebView): (QWebView::event):
- 9:06 AM Changeset in webkit [52255] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-17 Yury Semikhatsky <yurys@chromium.org>
Reviewed by David Levin.
Provide explicit implementation of 'non-template' WebVector<T>::operator=
- public/WebVector.h:
- 7:56 AM Changeset in webkit [52254] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings):
- 7:34 AM Changeset in webkit [52253] by
-
- 6 edits in trunk/WebCore
2009-12-17 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Advice links to source code in CPU profiler to open in debugger,
not in resources tab.
Also work around the case when resources are disabled, but scripts are present.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.updateMainViewWidth): (WebInspector.Panel.prototype.canShowSourceLineForURL): (WebInspector.Panel.prototype.showSourceLineForURL):
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL): (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.scriptForURL): (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL): (WebInspector.ScriptsPanel.prototype.showSourceLineForURL): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLineForURL): (WebInspector.canShowSourceLineForURL): (WebInspector.showSourceLineForURL):
- 6:42 AM Changeset in webkit [52252] by
-
- 2 edits in trunk/LayoutTests
Skipping one test that needs overriding of standard preferences,
and a new one.
- platform/gtk/Skipped:
- 6:27 AM Changeset in webkit [52251] by
-
- 3 edits in trunk/WebCore
Reviewed by Xan Lopez.
[GTK] display FPS stats for video element
https://bugs.webkit.org/show_bug.cgi?id=32560
Display FPS statistics if WEBKIT_DEBUG environment variable
contains the Media log category. This feature requires a very
recent (>= 0.10.18) version of gst-plugins-bad.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 6:01 AM Changeset in webkit [52250] by
-
- 2 edits in trunk/WebKit/qt
2009-12-17 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
[Qt] Add support for mocking touch events with QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=32434
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::sendTouchEvent): (MainWindow::eventFilter): (MainWindow::setTouchMocking): (MainWindow::setupUI):
- 5:05 AM Changeset in webkit [52249] by
-
- 9 edits3 deletes in trunk
Reverting 52246 and 52248 because they crash tests.
- 4:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:43 AM QtWebKitContrib edited by
- (diff)
- 4:43 AM QtWebKitReleases edited by
- (diff)
- 4:41 AM QtWebKitReleases created by
- 4:31 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:30 AM Changeset in webkit [52248] by
-
- 2 edits3 adds in trunk
Build fix. Landing files I forgot to commit.
- 4:13 AM Changeset in webkit [52247] by
-
- 3 edits in trunk/WebCore
2009-12-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] segfault during volume notification
https://bugs.webkit.org/show_bug.cgi?id=32603
Emit volumeChanged and durationChanged upon notification from
GStreamer. Also don't reset the volume property on playbin, it is
not needed as it is 1.0 by default both on playbin and in the
MediaPlayer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2009-11-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
https://bugs.webkit.org/show_bug.cgi?id=30377
Emit volumeChanged and durationChanged upon notification from
GStreamer.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateVolumeCallback): (WebCore::notify_volume_idle_cb): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 4:02 AM Changeset in webkit [52246] by
-
- 9 edits in trunk
WebCore
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Add GRefPtr support for GTK types to WebCore, as JSC does not link against
GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
No new tests as functionality has not changed.
- GNUmakefile.am:
- platform/PopupMenu.h:
- platform/gtk/GRefPtrGtk.cpp: Added. (WTF::refGPtr): (WTF::derefGPtr):
- platform/gtk/GRefPtrGtk.h: Added.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::menuRemoveItem):
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
- GNUmakefile.am:
- wtf/gtk/GOwnPtr.cpp: (WTF::GDir):
- wtf/gtk/GRefPtr.h: Added. (WTF::): (WTF::GRefPtr::GRefPtr): (WTF::GRefPtr::~GRefPtr): (WTF::GRefPtr::clear): (WTF::GRefPtr::get): (WTF::GRefPtr::operator*): (WTF::GRefPtr::operator->): (WTF::GRefPtr::operator!): (WTF::GRefPtr::operator UnspecifiedBoolType): (WTF::GRefPtr::hashTableDeletedValue): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): (WTF::adoptGRef): (WTF::refGPtr): (WTF::derefGPtr):
WebKit/gtk
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Convert a use of GOwnPtr for a reference counted type to GRefPtr.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
- 3:48 AM Changeset in webkit [52245] by
-
- 2 edits in trunk/WebCore
2009-12-17 Evan Martin <evan@chromium.org>
Reviewed by Xan Lopez.
gtk: always use standard include paths, regardless of settings.
WebKit style is to wrap the body of a header in #if ENABLE(FOO),
so they're always safe to include whether the features are enabled or
not.
This fixes building with --disable-database and other flags.
- GNUmakefile.am:
- 3:33 AM Changeset in webkit [52244] by
-
- 6 edits in trunk
Unreviewed. Build fixes for make distcheck.
- 3:14 AM Changeset in webkit [52243] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Gustavo Noronha Silva.
Trivial WebKit coding style fix.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
- 12:27 AM Changeset in webkit [52242] by
-
- 4 edits in trunk/WebKitTools
2009-12-17 Adam Barth <abarth@webkit.org>
Rubber stamp by Seidel.
Clean up exception handling in WorkQueue. Basically, a bunch of the
delegate messages can throw exceptions because of network errors. We
want the queues to keep on ticking instead of erroring out. That means
we want to catch generic exceptions and continue looping.
Also, cleaned up the exception handling in the EWS to properly log
failures.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/workqueue.py:
Dec 16, 2009:
- 11:52 PM Changeset in webkit [52241] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make UpdateStep quiet
https://bugs.webkit.org/show_bug.cgi?id=32599
- Scripts/modules/buildsteps.py:
- Scripts/modules/buildsteps_unittest.py:
- 11:41 PM Changeset in webkit [52240] by
-
- 4 edits in trunk/WebKitTools
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Add Gtk to the early warning system WebKit port list.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 11:40 PM Changeset in webkit [52239] by
-
- 9 edits1 copy in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
post-diff is failing with exception under guess_reviewer_from_bug
https://bugs.webkit.org/show_bug.cgi?id=32642
Also refactor output capturing code into
OutputCapture.assert_outputs to share more code between tests.
- Scripts/modules/buildsteps.py:
- Add the missing include.
- Give guess_reviewer_from_bug a private underscore.
- Scripts/modules/buildsteps_unittest.py: Added.
- Test to make sure _guess_reviewer_from_bug works as expected.
- Scripts/modules/commands/commandtest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/commands/queues_unittest.py:
- ditto
- Scripts/modules/credentials_unittest.py:
- ditto
- Scripts/modules/mock_bugzillatool.py:
- fetch_reviewed_patches_from_bug can never return None
- Scripts/modules/multicommandtool_unittest.py:
- Custom code is now obsoleted by OutputCapture.assert_outputs
- Scripts/modules/outputcapture.py:
- Add assert_outputs to share more code between tests.
- Scripts/run-webkit-unittests:
- Add buildsteps_unittest.py
- 11:37 PM Changeset in webkit [52238] by
-
- 2 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Unreviewed. Added a default argument to _update_status so that callers
don't have to explictly pass None when they don't have a patch object.
- Scripts/modules/commands/queues.py:
- 11:17 PM Changeset in webkit [52237] by
-
- 3 edits in trunk/WebKit/chromium
Unreviewed, build fix.
[Chromium] Add EditableTextRole to catch up with
http://trac.webkit.org/changeset/52233
- public/WebAccessibilityRole.h:
(WebKit::): Added WebAccessibilityRoleEditableText
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 11:05 PM Changeset in webkit [52236] by
-
- 2 edits in trunk/LayoutTests
[Qt] Put test into skiplist because of missing layoutTestController.setSmartInsertDeleteEnabled().
- platform/qt/Skipped: editing/selection/doubleclick-beside-cr-span.html added.
- 10:30 PM Changeset in webkit [52235] by
-
- 3 edits2 adds in trunk
2009-12-15 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
Test: editing/selection/doubleclick-beside-cr-span.html
- editing/TextIterator.cpp: (WebCore::collapsedSpaceLength): (WebCore::maxOffsetIncludingCollapsedSpaces): (WebCore::SimplifiedBackwardsTextIterator::advance):
2009-12-16 MORITA Hajime <morrita@gmail.com>
Reviewed by Eric Seidel.
Bug 28306: double-clicking a word inside <b> beside newline select two words
https://bugs.webkit.org/show_bug.cgi?id=28306
SimplifiedBackwardsTextIterator missed trailing whitespaces just
before folding line-break, which is used to detect word
boundaries. This fix checks strings on RenderText and expand text
range on SimplifiedBackwardsTextIterator to include trailing
whitespaces if availble.
- editing/selection/doubleclick-beside-cr-span-expected.txt: Added.
- editing/selection/doubleclick-beside-cr-span.html: Added.
- 10:19 PM Changeset in webkit [52234] by
-
- 3 edits in trunk/WebCore
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix flakiness in WebSocket handshake console message.
https://bugs.webkit.org/show_bug.cgi?id=32598
In chromium, LayoutTests/websocket/tests/handshake-error.html is
flaky, because it outputs the following console message several times:
CONSOLE MESSAGE: line 0: Unexpected response code:101
Update m_mode in WebSocketHandshake correctly: Once it finds
error in handshake message, set m_mode to Failed and don't try
reading handshake message again. If handshake message is not yet
fully received, set m_mode to Incomplete, so next didReceiveData()
will try to check handshake message again.
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
- 9:58 PM Changeset in webkit [52233] by
-
- 7 edits2 adds in trunk
2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of text nodes is wrong
https://bugs.webkit.org/show_bug.cgi?id=32631
<rdar://problem/7369084>
Reviewed by Alice Liu.
Test: platform/win/accessibility/text-role.html
WebCore/:
- accessibility/AccessibilityObject.h: (WebCore::): Add a new role to the enum. (WebCore::AccessibilityObject::roleValueForMSAA): Declare a function to return the accessibility role for MSAA; the base implementation returns the old role value.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): Initialize m_roleForMSAA. (WebCore::AccessibilityRenderObject::roleValueForMSAA): If m_roleForMSAA has been set, return it. If the renderer is a RenderText, set the role to EditableTextRole to match IE and Firefox. Otherwise, set the role for MSAA to the old role value.
- accessibility/AccessibilityRenderObject.h: Add a member to hold the role for MSAA, and declare an override of roleValueForMSAA().
WebKit/win/:
- AccessibleBase.cpp: (MSAARole): If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT. (AccessibleBase::role): Call roleValueForMSAA().
LayoutTests/:
- platform/win/accessibility/text-role-expected.txt: Added.
- platform/win/accessibility/text-role.html: Added. Check that the role of the text node that is the first child of the <a> tag has the "editable text" role.
- 9:30 PM Changeset in webkit [52232] by
-
- 5 edits3 adds in trunk/WebKitTools
2009-12-16 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
check-webkit-style supports for TAB check against text files.
https://bugs.webkit.org/show_bug.cgi?id=32538
- Scripts/check-webkit-style: Move process_patch() to style.py.
- Scripts/modules/cpp_style.py: Add can_handle().
- Scripts/modules/cpp_style_unittest.py: Add tests for can_handle().
- Scripts/modules/style.py: Added. This is a front-end of cpp_style and text_style. It dispatches files to an appropriate linter.
- Scripts/modules/text_style.py: Added. This is a linter module for generic text files. It supports only for TAB checking at this moment.
- Scripts/modules/text_style_unittest.py: Added. Tests for text_style.py.
- Scripts/run-webkit-unittests: Add text_style_unittest.
- 7:50 PM Changeset in webkit [52231] by
-
- 4 edits in trunk/JavaScriptCore
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code
Reviewed by Oliver Hunt.
This patch cuts Interpreter stack use by about a third.
- bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.
(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.
- 4:44 PM Changeset in webkit [52230] by
-
- 3 edits in trunk/LayoutTests
2009-12-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Darin Adler.
Fix LayoutTests/websocket/tests/url-with-query-for-no-query.html
https://bugs.webkit.org/show_bug.cgi?id=32606
It should test with /websocket/tests/no-query
- websocket/tests/script-tests/url-with-query-for-no-query.js:
- websocket/tests/url-with-query-for-no-query-expected.txt:
- 4:41 PM Changeset in webkit [52229] by
-
- 14 edits in trunk/WebCore
2009-12-16 Eric Seidel <eric@webkit.org>
No review, rolling out r52206.
http://trac.webkit.org/changeset/52206
https://bugs.webkit.org/show_bug.cgi?id=31187
This broke pixel tests on Mac. Presumably the code in
ImageCG is wrong here.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 4:40 PM Changeset in webkit [52228] by
-
- 3 edits1 add in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635
Centralize our import logic.
- Scripts/modules/bugzilla.py: use webkit_mechanize
- Scripts/modules/statusbot.py: use webkit_mechanize
- Scripts/modules/webkit_mechanize.py: Added.
- 4:31 PM Changeset in webkit [52227] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
Test was refactored by r52226, and now it passes.
- platform/qt/Skipped: unskip editing/selection/empty-cell-right-click.html.
- 4:15 PM Changeset in webkit [52226] by
-
- 3 edits in trunk/LayoutTests
Revised version of the test for:
<rdar://problem/5565465
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Adele Peterson.
- editing/selection/empty-cell-right-click-expected.txt:
- editing/selection/empty-cell-right-click.html:
- 4:07 PM Changeset in webkit [52225] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] editing/selection/empty-cell-right-click.html introduced in r52220 failed.
https://bugs.webkit.org/show_bug.cgi?id=32639
- platform/qt/Skipped: editing/selection/empty-cell-right-click.html added until fix.
- 4:03 PM Changeset in webkit [52224] by
-
- 3 edits in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32637
[V8] Generate most named property getters.
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.
- 3:52 PM Changeset in webkit [52223] by
-
- 5 edits in trunk/WebCore
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Abstract popup menu factory.
A static method from QtAbstractPopupMenu is used to create its instances. If a factory
has been suplied to class QtAbstractPopupMenu the factory will be used to create the
objects. If not an instance of QtFallbackPopupMenu will be created.
The objective is to make it easy to replace the combobox popup at WebCore layer providing
support to the combobox popup delegation API. Future patches will make it possible to
replace the combobox popup at WebKit layer.
No behavior changes.
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::setFactory): (WebCore::QtAbstractWebPopup::create):
- platform/qt/QtAbstractWebPopup.h:
- platform/qt/QtFallbackWebPopup.cpp:
- 3:39 PM Changeset in webkit [52222] by
-
- 8 edits in trunk
Build fix. Disable debug variants of WebKit frameworks.
- 2:19 PM Changeset in webkit [52221] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Generalize commit-queue recent status page for all queues
https://bugs.webkit.org/show_bug.cgi?id=32633
- QueueStatusServer/index.html:
- Generalize to support other queues.
- QueueStatusServer/queue_status.py:
- Generalize MainPage to support other queues.
- 2:02 PM Changeset in webkit [52220] by
-
- 6 edits2 adds in trunk
WebCore: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
Avoid extending the selection to the next cell if we start from an empty cell.
Test: editing/selection/empty-cell-right-click.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
with a call to the new function.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
selection only if we are not starting from an empty table cell.
- editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
- editing/htmlediting.h: Added isEmptyTableCell declaration.
LayoutTests: Right clicking in a table cell creates a selection that extends into the next cell.
<rdar://problem/5565465>
https://bugs.webkit.org/show_bug.cgi?id=32622
Reviewed by Eric Seidel.
- editing/selection/empty-cell-right-click-expected.txt: Added.
- editing/selection/empty-cell-right-click.html: Added.
- 1:56 PM Changeset in webkit [52219] by
-
- 10 edits in trunk
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
The previous test only checked if feMerge works on empty node
without a last effect. In this case we get a source image and
everything works fine. This test also covers the case if there
is a last effect.
- platform/mac/svg/custom/empty-merge-expected.checksum:
- platform/mac/svg/custom/empty-merge-expected.png:
- platform/mac/svg/custom/empty-merge-expected.txt:
- svg/custom/empty-merge.svg:
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMerge crahses if feMergeNodes attribute in is empty
https://bugs.webkit.org/show_bug.cgi?id=32489
SVGFEMergeElement only stored pointers to all effects of it's nodes
in a list. But it should store the RefPtr otherwise the effects get
dereferenced and WebKit crashes.
I also made a short clean-up in SVGFilterBuilder. No change in
functionality.
Test: I updated svg/custom/empty-merge.svg to cover this problem.
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::mergeInputs): (WebCore::FEMerge::setMergeInputs):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::SVGFilterBuilder::add):
- 1:24 PM Changeset in webkit [52218] by
-
- 2 edits in trunk/WebKitTools
2009-12-16 Evan Martin <evan@chromium.org>
Reviewed by Adam Barth.
Early warning system server should display output as UTF-8.
- QueueStatusServer/queue_status.py:
- 1:17 PM Changeset in webkit [52217] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/32568>.
Web Inspector: Context Menus should be used in more places.
Reviewed by Timothy Hatcher.
Add a context menu entry in the console to clear the console. This
is only shown when there is no user selection of text, because if
there is selection of the text, then we want to give the user the Copy +
Spell Check context menu that they are used to.
- English.lproj/localizedStrings.js: Added "Clear Console".
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
- 1:17 PM Changeset in webkit [52216] by
-
- 4 edits in trunk/WebKitTools
2009-12-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add error handling to the early warning system
https://bugs.webkit.org/show_bug.cgi?id=32594
This should be the last step in making the EWS operational. When we
have a build error, we post the log to QueueStatusServer and add a link
to the bug.
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/executive.py:
- 1:15 PM Changeset in webkit [52215] by
-
- 8 edits in trunk/WebKit/gtk
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Deprecate the old loading signals load-started, load-committed,
load-finished, load-progress-changed and change unit tests to use
load-status instead.
- tests/testmimehandling.c: (idle_quit_loop_cb): (test_mime_type): use notify::load-status
- tests/testwebdatasource.c: (notify_load_status_unreachable_cb): (notify_load_status_cb): (test_webkit_web_data_source): (test_webkit_web_data_source_unreachable_uri): Remove uses of g_main_loop_is_running. It's an error if the loop is wrongly terminated.
- tests/testwebresource.c: (notify_load_status_cb): (test_web_resource_loading): (notify_load_status_sub_cb): (test_web_resource_sub_resource_loading): use notify::load-status
- tests/testwebview.c: (idle_quit_loop_cb): (test_webkit_web_view_icon_uri):
- tests/testwindow.c: (notify_load_status_cb): (test_webkit_window_scrollbar_policy): use notify::load-status
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): Deprecate old load signals.
- 12:59 PM Changeset in webkit [52214] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching
from / to resources panel.
Reviewed by Pavel Feldman.
Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
to cover the scope bar.
- inspector/front-end/inspector.css:
- 12:14 PM Changeset in webkit [52213] by
-
- 5 edits2 deletes in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Switch all indexers to be generated.
https://bugs.webkit.org/show_bug.cgi?id=32569
Covered by existing tests.
- WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
as they are now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
FileList, and DataGridColumnList templates.
- bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
- bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
- bindings/v8/custom/V8FileListCustom.cpp: Removed.
- 11:34 AM Changeset in webkit [52212] by
-
- 2 edits in trunk/WebCore
2009-12-16 anton muhin <antonm@chromium.org>
Reviewed by Darin Adler.
[dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
https://bugs.webkit.org/show_bug.cgi?id=32617
- dom/Node.cpp: (WebCore::Node::dumpStatistics):
- 11:25 AM Changeset in webkit [52211] by
-
- 6 edits1 delete in trunk/WebCore
2009-12-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
[V8] There is no such thing as HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=32616
Refactoring, covered by existing tests.
- WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
- bindings/v8/V8Collection.h: Removed one-off template.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
to HTMLSelectElement.
- bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
V8HTMLSelectElementCollectionCustom.cpp
- 11:20 AM Changeset in webkit [52210] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing bug number in ChangeLog
- 11:15 AM Changeset in webkit [52209] by
-
- 2 edits in trunk/WebKit
Brought this file up to date, sans review.
- StringsNotToBeLocalized.txt:
- 11:14 AM Changeset in webkit [52208] by
-
- 6 edits in trunk
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- configure.ac: require libsoup 2.28.2 for SoupContentDecoder
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Content-Encoding support
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): Don't force "Accept-Encoding: identity" any more
2009-12-16 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
Content-Encoding support
- webkit/webkitprivate.cpp: (webkit_init): add a SoupContentDecoder feature to the session
- 11:03 AM Changeset in webkit [52207] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-16 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Take into account favicon.ico in the webresource test.
- tests/testwebresource.c: (test_web_resource_sub_resource_loading):
- 11:00 AM Changeset in webkit [52206] by
-
- 14 edits in trunk/WebCore
2009-12-16 Benjamin Otte <otte@gnome.org>
Reviewed by Darin Adler.
Get rid of the phase argument to Image::drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=31187
The argument can be expressed equally well as part of the
patternTransform. All backends but the Qt one did exactly that
manually anyway.
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- 10:50 AM Changeset in webkit [52205] by
-
- 5 edits in trunk/WebCore
2009-12-16 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Performance problems with index validation code for drawElements
https://bugs.webkit.org/show_bug.cgi?id=32466
Added a cache of the maximum index for each element type to
WebGLBuffer, querying it before iterating through the indices in
the client-side copy of the buffer's data. Hoisted checks of the
size of the element array itself into validateElementArraySize to
avoid duplicating code.
The performance improvement has been measured with manual tests.
Existing layout tests cover the index validation functionality
and continue to pass as before.
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData): (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex): (WebCore::WebGLBuffer::clearCachedMaxIndices):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawElements):
- html/canvas/WebGLRenderingContext.h:
- 10:43 AM Changeset in webkit [52204] by
-
- 7 edits in trunk/WebCore
2009-12-16 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32261
Added ability to separate the autocomplete suggestion previewing from
the actual accepting of the suggested value in HTMLInputElement.
This element (it's single line text incarnation) can now
be put in suggestion mode where renderer might display the suggested
value without making it automatically exposed to JavaScript.
No new tests. This new methods are not exposed yet. It's use will be
platform specific. PopupMenu and Chromium specific changes will be
separated based on Darin Adler's comments.
- dom/InputElement.h: (WebCore::InputElementData::suggestedValue): (WebCore::InputElementData::setSuggestedValue):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::suggestedValue): (WebCore::HTMLInputElement::setSuggestedValue): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer):
- html/HTMLInputElement.h:
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::suggestedValue):
- wml/WMLInputElement.h:
- 10:24 AM Changeset in webkit [52203] by
-
- 6 edits in trunk/WebCore
2009-12-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make Elements tree, properties section and resources
view monospace.
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.css:
- 10:12 AM Changeset in webkit [52202] by
-
- 3 edits4 adds in trunk
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
Check if the GraphicsContex get adjusted, if the source rect is clipped
to the filter rect.
- platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
- platform/mac/svg/filters/filter-source-position-expected.png: Added.
- platform/mac/svg/filters/filter-source-position-expected.txt: Added.
- svg/filters/filter-source-position.svg: Added.
2009-12-16 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
https://bugs.webkit.org/show_bug.cgi?id=32575
On SVG Filters, the rest of the source graphic gets clipped to the filter
rest. This helps us to minimize the size of intermediate ImageBuffers. If
the position moves to the right or to the bottom, we have to adjust the
GraphicContext of this intermediate ImageBuffer.
This patch fixes the adjustment of the context, according to the clipping.
Test: svg/filters/filter-source-position.svg
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter):
- 9:59 AM Changeset in webkit [52201] by
-
- 3 edits2 adds in trunk
CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
<rdar://problem/7467108>
https://bugs.webkit.org/show_bug.cgi?id=32590
Reviewed by Adele Peterson.
WebCore:
If the element is a button there is no need to look at the children to calculate the caret position.
Test: editing/selection/button-right-click.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
when starting from a button element.
LayoutTests:
- editing/selection/button-right-click-expected.txt: Added.
- editing/selection/button-right-click.html: Added.
- 9:37 AM Changeset in webkit [52200] by
-
- 2 edits in trunk/WebKit/gtk
Rubber-stamped by Xan Lopez.
Add tab_key_cycles_through_elements to copies of
WebKitWebSettings.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_copy):
- 9:27 AM Changeset in webkit [52199] by
-
- 4 edits2 copies2 moves in trunk/WebCore
2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement combobox delegate for Qt
https://bugs.webkit.org/show_bug.cgi?id=32550
Refactoring of class QWebPopup.
Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
Both new classes are now in corresponding files and files QWebPopup.* have been removed.
Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
public QtWebKit combobox popup delegation API.
Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
It needs to be improved to provide standard features that are missing like style or indentation.
No behavior changes.
- WebCore.pro:
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu):
- platform/qt/QWebPopup.cpp: Removed.
- platform/qt/QWebPopup.h: Removed.
- platform/qt/QtAbstractWebPopup.cpp: Added. (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::client):
- platform/qt/QtAbstractWebPopup.h: Added.
- platform/qt/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged):
- platform/qt/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
- 9:04 AM Changeset in webkit [52198] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] webkit_web_navigation_action_get_button() documentation
https://bugs.webkit.org/show_bug.cgi?id=25555
Small documentation improvement for webkit_web_navigation_action_get_button.
- webkit/webkitwebnavigationaction.cpp:
- 6:21 AM Changeset in webkit [52197] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=31332
[Qt] After http://trac.webkit.org/changeset/52192
there are a failing and a timeouter test.
- platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
- platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.
- 6:02 AM QtWebKit/CodeCamp200912 edited by
- Update day2 and day3 (diff)
- 5:57 AM QtWebKit/CodeCamp200912 edited by
- link to the presentation to freya and mozAfterPaint (diff)
- 5:54 AM QtWebKit/CodeCamp200912 edited by
- Update performance day 1 summary (diff)
- 2:42 AM Changeset in webkit [52196] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
of DumpRenderTree. The previously wrong expected file updated.
- platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.
- 2:25 AM Changeset in webkit [52195] by
-
- 2 edits in trunk/LayoutTests
Skipping a new test, and a test that fails only on the release bot,
apparently because of rouding errors.
- platform/gtk/Skipped:
- 2:06 AM Changeset in webkit [52194] by
-
- 4 edits in trunk
WebKitTools: Fix crash with tests that use custom font faces.
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=32600
In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
that custom font faces between tests don't influence each other. Calling this
function in Qt however also invalidates all existing handles with QFontDatabase.
In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
which implies a call to WebCore::FontCache::fontCache()->invalidate().
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.
Reviewed by Holger Freyther.
- platform/qt/Skipped:
- 2:05 AM Changeset in webkit [52193] by
-
- 4 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: beautify HTTP info section.
- English.lproj/localizedStrings.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._refreshURL): (WebInspector.ResourceView.prototype._refreshHTTPInformation):
- inspector/front-end/inspector.css:
- 1:54 AM Changeset in webkit [52192] by
-
- 3 edits in trunk/WebKitTools
2009-12-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Maintain button state between mouse events.
This allows eventSender to generate drag events.
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo):
- DumpRenderTree/qt/EventSenderQt.h:
- 1:52 AM Changeset in webkit [52191] by
-
- 3 edits in trunk/WebCore
Revert r52085, because it causes crashes on media tests in the release
bot.
- 1:41 AM QtWebKit edited by
- (diff)
- 1:09 AM QtWebKitContrib edited by
- (diff)
- 1:08 AM QtWebKit edited by
- (diff)
- 12:56 AM Changeset in webkit [52190] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/css/font-face-unused-source-loaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=32600
Reviewed by Simon Hausmann.
The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.
- platform/qt/Skipped: fast/css/font-face-multiple-families.html added.
- 12:53 AM QtWebKitTodo edited by
- (diff)
Dec 15, 2009:
- 11:54 PM Changeset in webkit [52189] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Code clean-up in check-webkit-style as described below.
The only functional changes are minor improvements to the
script's help output.
- Scripts/check-webkit-style:
- Added the module docstring from cpp_style.py.
- Improved wording of the --help output and added some of the default values as substitution strings.
- Called cpp_style.exit_with_usage instead of sys.stderr.write in main function.
- Made changes caused by changes to cpp_style.py.
- Scripts/modules/cpp_style.py:
- Removed module docstring, as well as redundant _USAGE string and main() function obsoleted by check-webkit-style.
- Moved specification of default script values from within a function definition to global variables.
- Moved the default webkit filter rules to be near the other global variables.
- Renamed "FILTER" global variables to "FILTER_RULES" to establish unambiguous terminology.
- Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
- Changed _STYLE_CATEGORIES from a string to a list.
- Added default webkit filter rules to --filter= output.
- Renamed "print_" methods to "exit_with_" since they exist and added a temporary display_help parameter.
- Added a temporary display_help parameter to parse_arguments.
- Scripts/modules/cpp_style_unittest.py:
- Made changes caused by changes to cpp_style.py.
- Lower-cased ErrorCollector's ERROR_CATEGORIES instance variables since they are not global.
- 11:21 PM Changeset in webkit [52188] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue.
Typo: _updates_status -> _update_status
We need to improve our testing infrastructure for the queues.
- Scripts/modules/commands/queues.py:
- 11:05 PM Changeset in webkit [52187] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix for the style-queue. I suspect this is a recent
regression from Eric's change below.
- Scripts/modules/commands/queues.py:
- 7:12 PM Changeset in webkit [52186] by
-
- 5 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adele Peterson.
Make SunSpider version more prominent in the title
https://bugs.webkit.org/show_bug.cgi?id=32574
- hosted/sunspider.html:
- hosted/versions.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:26 PM Changeset in webkit [52185] by
-
- 3 edits in trunk/SunSpider
2009-12-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Make SunSpider refuse to compare results across content versions
https://bugs.webkit.org/show_bug.cgi?id=32573
The results URL now includes a version indicator, and compare mode
will refuse to compare between versions.
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 6:02 PM Changeset in webkit [52184] by
-
- 4 edits2 adds in trunk
Fix crash when encountering illegal HTML within a continuation inside <ruby>.
(https://bugs.webkit.org/show_bug.cgi?id=32316)
Reviewed by Adam Barth.
Avoid having the anonymous blocks utilized in the ruby renderers being
re-used as continuation blocks.
Avoid having ruby runs collected as "leftover blocks".
Test: fast/ruby/ruby-illegal.html
WebCore:
- rendering/RenderRuby.h:
(WebCore::RenderRubyAsInline::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsInline::isRuby): made private
(WebCore::RenderRubyAsInline::renderName): made private
(WebCore::RenderRubyAsInline::createsAnonymousWrapper): return true
(WebCore::RenderRubyAsBlock::removeLeftoverAnonymousBlock): mustn't be called
(WebCore::RenderRubyAsBlock::isRuby): made private
(WebCore::RenderRubyAsBlock::renderName): made private
(WebCore::RenderRubyAsBlock::createsAnonymousWrapper): return true
- rendering/RenderRubyRun.h:
(WebCore::RenderRubyRun::removeLeftoverAnonymousBlock): avoid
(WebCore::RenderRubyRun::isRubyRun): made private
(WebCore::RenderRubyRun::renderName): made private
(WebCore::RenderRubyRun::createsAnonymousWrapper): return true
LayoutTests:
- fast/ruby/ruby-illegal-expected.txt: Added.
- fast/ruby/ruby-illegal.html: Added.
- 4:51 PM Changeset in webkit [52183] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
update-webkit-chromium to auto-install gclient
- Scripts/update-webkit-chromium:
- 4:04 PM Changeset in webkit [52182] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32498
<rdar://problem/7471495>
REGRESSION(r51978-r52039): AJAX "Mark This Forum Read" function no longer
works
Reviewed by Sam "r=me" Weinig.
Fixed a tyop.
- runtime/Operations.h:
(JSC::jsAdd): Use the '&&' operator, not the ',' operator.
- 3:53 PM Changeset in webkit [52181] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/WebKit.vcproj
Add delay load of QuartzCore.dll and QuartzCoreInterface.dll to fix Windows build
- 3:47 PM Changeset in webkit [52180] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
https://bugs.webkit.org/show_bug.cgi?id=32546
You can see an example of this working in:
https://bugs.webkit.org/show_bug.cgi?id=32585#c3
- QueueStatusServer/queue_status.py:
- Output the id of the newly created status.
- Scripts/modules/commands/queues.py:
- Tweak the commit-queue logging to include a full status link.
- Scripts/modules/statusbot.py:
- update_status should return the newly created status id.
- 3:44 PM Changeset in webkit [52179] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix the windows build: don't export this inlined function.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:33 PM Changeset in webkit [52178] by
-
- 4 edits in trunk/JavaScriptCore
Inlined JSCell's operator new.
Reviewed by Beth Dakin.
3.7% speedup on bench-allocate-nonretained.js.
- JavaScriptCore.exp:
- runtime/JSCell.cpp:
- runtime/JSCell.h:
(JSC::JSCell::operator new):
- 3:02 PM BuildingQtOnWindows edited by
- Replaced outdated Trolltech website link to Qt download with Nokia link (diff)
- 3:02 PM Changeset in webkit [52177] by
-
- 14 edits in trunk/WebCore
2009-12-15 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
Rename skipCanLoadCheck to skipSecurityCheck in a bunch of places in WebCore/loader.
- loader/Cache.cpp: (WebCore::Cache::requestUserCSSStyleSheet):
- loader/CachedImage.cpp: (WebCore::CachedImage::load):
- loader/CachedResource.cpp: (WebCore::CachedResource::load):
- loader/CachedResource.h: (WebCore::CachedResource::load):
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/FrameLoaderTypes.h: (WebCore::):
- loader/Request.cpp: (WebCore::Request::Request):
- loader/Request.h: (WebCore::Request::shouldDoSecurityCheck):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 2:40 PM Changeset in webkit [52176] by
-
- 7 edits in trunk/JavaScriptCore
Removed the number heap, replacing it with a one-item free list for
numbers, taking advantage of the fact that two number cells fit inside
the space for one regular cell, and number cells don't require destruction.
Reviewed by Oliver Hunt.
SunSpider says 1.6% faster in JSVALUE32 mode (the only mode that
heap-allocates numbers).
SunSpider says 1.1% faster in JSVALUE32_64 mode. v8 says 0.8% faster
in JSVALUE32_64 mode. 10% speedup on bench-alloc-nonretained.js. 6%
speedup on bench-alloc-retained.js.
There's a lot of formulaic change in this patch, but not much substance.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlockPtr):
(JSC::Heap::freeBlocks):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
(JSC::Heap::sweep):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics):
(JSC::Heap::isBusy):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
- runtime/Collector.h:
(JSC::): Removed all code pertaining to the number heap, and changed all
heap template functions and classes to non-template functions and classes.
(JSC::Heap::allocateNumber): A new optimization to replace the number
heap: allocate half-sized number cells in pairs, returning the first
cell and caching the second cell for the next allocation.
- runtime/CollectorHeapIterator.h:
(JSC::LiveObjectIterator::LiveObjectIterator):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::DeadObjectIterator):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::ObjectIterator):
(JSC::ObjectIterator::operator++):
- runtime/JSCell.h:
(JSC::JSCell::isNumber): Removed all code pertaining to the number heap,
and changed all heap template functions and classes to non-template functions
and classes.
- 2:18 PM Changeset in webkit [52175] by
-
- 1 edit in trunk/WebKitSite/blog-files/webgl/resources/utils3d.js
updated WebGL demos to latest spec
- 2:12 PM Changeset in webkit [52174] by
-
- 4 edits2 adds in trunk
<rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
https://bugs.webkit.org/show_bug.cgi?id=32257
Reviewed by Darin Adler.
WebCore:
Test: fast/css/font-face-unused-source-loaded.html
The loading of a font resource caused a CSSFontFace that had the resource in one of its
sources, but wasn’t using it (due to using an earlier source) to invalidate its
CSSSegmentedFontFaces. This caused FontData for the active source (the one that did not just
finish loading) to be deleted, but that went unnoticed by Font::operator==(), since the
corresponding FontFallbackLists were not in the loading state. The fix is for CSSFontFace to
ignore loads from unused sources.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Bail out if the loaded source is not the active source.
(WebCore::CSSFontFace::getFontData): Set m_activeSource to the source that supplied the
FontData.
- css/CSSFontFace.h:
(WebCore::CSSFontFace::CSSFontFace): Initialize m_activeSource.
LayoutTests:
- fast/css/font-face-unused-source-loaded-expected.txt: Added.
- fast/css/font-face-unused-source-loaded.html: Added.
- 2:12 PM Changeset in webkit [52173] by
-
- 1 delete in trunk/WebCore/manual-tests/webgl
Getting rid of out of date WebGL tests
- 2:07 PM Changeset in webkit [52172] by
-
- 4 edits in trunk/WebCore
2009-12-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Cannot load flash files from a local file.
https://bugs.webkit.org/show_bug.cgi?id=32572
When loading the main resource and its mime type is application/octet-stream,
use the file extenstion to check if it is a supported plugin.
No new tests were added since any existing swf file can be used as a manual test.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- loader/MainResourceLoader.h:
- plugins/PluginDatabase.h:
- 1:55 PM Changeset in webkit [52171] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WeakGCMap class
https://bugs.webkit.org/show_bug.cgi?id=32547
Inherits WeakGCMap from FastAllocBase because it is instantiated by
'new' at: WebCore/dom/Document.cpp:512.
- runtime/WeakGCMap.h:
- 1:52 PM Changeset in webkit [52170] by
-
- 5 edits4 deletes in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
REGRESSION: Tips are not shown for resources anymore.
Reviewed by Timothy Hatcher.
As discussed in the bug, Tips are not coming back, and the feature
will be moved to the audits panel. This patch is to remove the Tips
code and the resources that it needed.
- WebCore.gypi: Removed tips files.
- inspector/front-end/Images/tipBalloon.png: Removed.
- inspector/front-end/Images/tipBalloonBottom.png: Removed.
- inspector/front-end/Images/tipIcon.png: Removed.
- inspector/front-end/Images/tipIconPressed.png: Removed.
- inspector/front-end/Resource.js: Removed tips code.
(WebInspector.Resource.prototype.set finished):
- inspector/front-end/WebKit.qrc: Removed tips files.
- inspector/front-end/inspector.css: Removes tips style rules.
- 1:44 PM Changeset in webkit [52169] by
-
- 4 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Display request headers for main resource
having redirects.
- inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest):
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::createCached): (WebCore::InspectorResource::updateRequest):
- inspector/InspectorResource.h: (WebCore::InspectorResource::create):
- 1:35 PM Changeset in webkit [52168] by
-
- 2 edits in trunk/WebCore
Fixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
Web Inspector: No Need for ?="" now that we have context menus.
Reviewed by Timothy Hatcher.
Remove the toggleNewAttributeButton function and callers to it, as
we don't need this behavior anymore, now that we have context menus.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.set hovered):
(WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
(WebInspector.ElementsTreeElement.prototype._startEditing):
- 12:15 PM Changeset in webkit [52167] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Fixed typos
- 11:55 AM Changeset in webkit [52166] by
-
- 4 edits in trunk/WebCore
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate trivial named property getters.
https://bugs.webkit.org/show_bug.cgi?id=32562
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationNamedPropertyGetter.
- bindings/v8/V8Collection.h: (WebCore::getNamedPropertyOfCollection): Fixed a booboo by using AtomicString like we're supposed to.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed code that's now generated.
- 11:51 AM Changeset in webkit [52165] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/32568>.
New Web Inspector: The Context Menu should be used in more places.
Reviewed by Timothy Hatcher.
Add support for context menu entries for editing and deleting elements
in the datagrid. This gives support to deleting cookies, and editing and
deleting session storage and local storage.
- English.lproj/localizedStrings.js: Added "Edit" and "Add New" entries (delete was already there)
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid): Added context menu listener.
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- 11:08 AM Changeset in webkit [52164] by
-
- 10 edits in trunk
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- fast/canvas/webgl/error-reporting-expected.txt:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/script-tests/error-reporting.js:
- fast/canvas/webgl/script-tests/null-object-behaviour.js:
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D):
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bindFramebuffer):
2009-12-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Don't allow default framebuffer to be mutated
https://bugs.webkit.org/show_bug.cgi?id=32391
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3D::bindFramebuffer):
- 10:50 AM Changeset in webkit [52163] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for FontPlatformDataCacheKey class
https://bugs.webkit.org/show_bug.cgi?id=32552
Inherits the following struct from FastAllocBase because it is instantiated by 'new':
struct name - instantiated at: WebCore/'location'
struct FontPlatformDataCacheKey - platform/graphics/FontCache.cpp:118
- platform/graphics/FontCache.cpp:
- 10:43 AM Changeset in webkit [52162] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for dtoa's P5Node struct
https://bugs.webkit.org/show_bug.cgi?id=32544
Inherits P5Node struct from Noncopyable because it is instantiated by
'new' at wtf/dtoa.cpp:588 and don't need to be copyable.
- wtf/dtoa.cpp:
- 10:14 AM Changeset in webkit [52161] by
-
- 3 edits in trunk/WebKit/chromium
2009-12-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Add TreeGridRole to catch up with
http://trac.webkit.org/changeset/52159.
- public/WebAccessibilityRole.h: (WebKit::): Added WebAccessibilityRoleTreeGrid.
- src/AssertMatchingEnums.cpp: Added matching compile assert.
- 10:13 AM Changeset in webkit [52160] by
-
- 7 edits in trunk
Bug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
https://bugs.webkit.org/show_bug.cgi?id=31090
Reviewed by Dmitry Titov.
The proposal to whatwg can be found here:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022118.html
WebCore:
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp:
(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::setData):
WebKit/chromium:
- public/WebDragData.h:
- src/WebDragData.cpp:
(WebKit::WebDragData::downloadURL):
(WebKit::WebDragData::setDownloadURL):
- 10:13 AM BuildBot edited by
- (diff)
- 10:07 AM Changeset in webkit [52159] by
-
- 13 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 9:09 AM Changeset in webkit [52158] by
-
- 2 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for EmptyEditorClient and EmptyInspectorClient
https://bugs.webkit.org/show_bug.cgi?id=32557
Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class EmptyEditorClient - svg/graphics/SVGImage.cpp:230
class EmptyInspectorClient - svg/graphics/SVGImage.cpp:241
- loader/EmptyClients.h:
- 9:02 AM Changeset in webkit [52157] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/inspector directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32556
Inherits the following class from Noncopyable because these are instantiated
by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class InspectorFrontend - inspector/InspectorController.cpp:538
class InspectorTimelineAgent - inspector/InspectorController.cpp:1097
- inspector/InspectorFrontend.h:
- inspector/InspectorTimelineAgent.h:
- 8:54 AM Changeset in webkit [52156] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WebCore/platform/network directory's classes
https://bugs.webkit.org/show_bug.cgi?id=32553
Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
struct CrossThreadResourceResponseData - platform/network/ResourceResponseBase.cpp:109
Inherits the following classes from FastAllocBase because these are
instantiated by 'new':
class ResourceResponseBase - (its child class) platform/network/ResourceResponseBase.cpp:90
class ResourceRequestBase - (its child class) loader/DocumentThreadableLoader.cpp:88
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- 8:44 AM Changeset in webkit [52155] by
-
- 3 edits in trunk/WebCore
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
https://bugs.webkit.org/show_bug.cgi?id=32549
Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:
class/struct name - instantiated at: WebCore/'location'
AnimationControllerPrivate - page/animation/AnimationController.cpp:439
FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464
- page/animation/AnimationBase.cpp:
- page/animation/AnimationControllerPrivate.h:
- 8:36 AM Changeset in webkit [52154] by
-
- 7 edits in trunk/WebCore
2009-12-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not lose HTTP redirect information, display it
in the Resources Panel.
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::appendRedirect): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject): (WebCore::InspectorResource::type):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::Changes::setAll):
- inspector/front-end/inspector.js: (WebInspector._addResource): (WebInspector.updateResource):
- 8:17 AM Changeset in webkit [52153] by
-
- 2 edits in trunk/WebCore
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=32113
For Qt versions prior to 4.6.1 we will need to use QueuedConnection
for the signal and slot connection to avoid running into a bug in.
Add a comment that we want to remove one signal to forward
queued items when moving our minimum requirements.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
- 8:17 AM Changeset in webkit [52152] by
-
- 4 edits1 add in trunk
[Qt] Fix JavaScript prompt behavior for empty/null strings.
https://bugs.webkit.org/show_bug.cgi?id=30914
The patch is based on the work done by Gupta Manish.
In the default implementation of the JavaScript prompt
we are using a QInputDialog to get the text and this has
one quirk with regard to not entering any text.
In other WebKit ports and in Firefox an empty string is
returned but in the Qt case it is a null string.
Change the API documentation in QWebPage to mention we want to
have a non null string but do the fixup in the ChromeClientQt
to support existing code.
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPage::javaScriptPrompt): Change API documentation
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fixup null QString
WebCore:
- manual-tests/qt/java-script-prompt.html: Added.
- 8:13 AM Changeset in webkit [52151] by
-
- 5 edits in trunk/WebCore
2009-12-15 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Moving list populate methods from PopupMenuQt to QWebPopup.
In preparation to future implementation of a delegation API for the combobox.
- platform/PopupMenu.h:
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
- platform/qt/QWebPopup.cpp: (WebCore::QWebPopup::show): (WebCore::QWebPopup::populate):
- platform/qt/QWebPopup.h: (WebCore::QWebPopup::hide):
- 6:18 AM Changeset in webkit [52150] by
-
- 5 edits5 moves in trunk/WebKitTools
[Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-15
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTree.h: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Updated.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
- DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
(GCController::GCController):
- DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/WorkQueueItem.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
- DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
- DumpRenderTree/qt/jsobjects.cpp: Removed.
- DumpRenderTree/qt/jsobjects.h: Removed.
- DumpRenderTree/qt/main.cpp: Updated includes.
- 4:20 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 4:14 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 4:08 AM QtWebKit/CodeCamp200912Teams edited by
- (diff)
- 3:29 AM Changeset in webkit [52149] by
-
- 6 edits1 copy in trunk/WebCore
2009-12-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Extract WebInspector.Section from WebInspector.PropertiesSection.
https://bugs.webkit.org/show_bug.cgi?id=32523
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/Section.js: Added. (WebInspector.Section): (WebInspector.Section.prototype.get title): (WebInspector.Section.prototype.set title): (WebInspector.Section.prototype.get subtitle): (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get expanded): (WebInspector.Section.prototype.set expanded): (WebInspector.Section.prototype.get populated): (WebInspector.Section.prototype.set populated): (WebInspector.Section.prototype.expand): (WebInspector.Section.prototype.collapse): (WebInspector.Section.prototype.toggleExpanded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 3:12 AM Changeset in webkit [52148] by
-
- 3 edits1 delete in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
We have two mark-fixed commands
https://bugs.webkit.org/show_bug.cgi?id=32073
- Scripts/mark-bug-fixed: Removed.
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 2:39 AM Changeset in webkit [52147] by
-
- 4 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
https://bugs.webkit.org/show_bug.cgi?id=28286
- QueueStatusServer/index.html:
- Show [results] links if a results log was uploaded.
- QueueStatusServer/queue_status.py:
- Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
- Scripts/modules/commands/queues.py:
- Post to the status bot when a patch fails and include the failure log as a results file.
- 2:32 AM QtWebKit/CodeCamp200912Teams created by
- 2:18 AM Changeset in webkit [52146] by
-
- 12 edits2 deletes in trunk
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- platform/mac/accessibility/aria-treegrid-expected.txt: Removed.
- platform/mac/accessibility/aria-treegrid.html: Removed.
2009-12-15 Eric Seidel <eric@webkit.org>
No review, rolling out r52140.
http://trac.webkit.org/changeset/52140
https://bugs.webkit.org/show_bug.cgi?id=31299
The commit broke the Leopard bots and unfortunately
Chris wasn't around to fix them, so I'm rolling the change
out after 3 hours so that the bots can roll green again. :)
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridRow.cpp:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isMultiSelect): (WebCore::AccessibilityRenderObject::setIsExpanded): (WebCore::AccessibilityRenderObject::setSelectedRows): (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows): (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren): (WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- 2:07 AM Changeset in webkit [52145] by
-
- 8 edits in trunk/WebKitTools
2009-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queue sub-commands need --status-host so they can report status
https://bugs.webkit.org/show_bug.cgi?id=32313
Make --status-bot a global option and make
run_bugzilla_tool pass --status-bot to sub-commands.
- Scripts/bugzilla-tool:
- Rename _status to status_bot and make it non-lazy.
- Scripts/modules/commands/queues.py:
- Move status updates out of WorkQueue and into individual queues.
- Scripts/modules/commands/queues_unittest.py:
- Test that --status-host is passed to bugzilla-tool when run as subcommand.
- Scripts/modules/mock_bugzillatool.py:
- Add a MockStatusBot
- Scripts/modules/workqueue.py:
- Remove status_host and work_work_logs_directory callbacks.
- Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
- Scripts/modules/workqueue_unittest.py:
- Update unit tests to reflect new callbacks.
- 1:29 AM Changeset in webkit [52144] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Do not disable the inspector on show and hide
https://bugs.webkit.org/show_bug.cgi?id=31851
On Qt/X11 with some window managers the window will be
hidden when switching windows. In this case all the results
are gone when coming back to the window.
Attempt to use the CloseEvent to figure out if the window
was closed and withdrawn as this is more friendly to the
user of the inspector client.
- Api/qwebinspector.cpp:
(QWebInspector::hideEvent):
(QWebInspector::closeEvent):
- Api/qwebinspector.h:
- 1:29 AM Changeset in webkit [52143] by
-
- 2 edits in trunk/WebCore
[Qt] Remove dead code from FontPlatformDataQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=32540
In r51758 the code that used familyNames was removed
and we should remove the creation of the familyNames
as well.
- platform/graphics/qt/FontPlatformDataQt.cpp:
- 12:57 AM Changeset in webkit [52142] by
-
- 2 edits in trunk/WebKitTools
2009-12-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm_unittest.py is too slow
https://bugs.webkit.org/show_bug.cgi?id=31818
Now we don't run the SCM unit tests unless we get the --all flag on the
command line. Eric and I were commenting out this test because it was
too painful to run.
- Scripts/run-webkit-unittests:
- 12:17 AM Changeset in webkit [52141] by
-
- 10 edits in trunk
Reviewed by Adam Roben.
WebCore:
WebCore part of <rdar://problem/7173515> Use LOGFONT support in Core
Graphics when available
When using a version of Core Graphics with LOGFONT support, this fixes
<rdar://problem/5764844> First-time launch is painfully slow due to font
plist creation
and <rdar://problem/6576281> 12px synthetic-italics Tahoma text is less
readable in Safari than in Firefox/IE due to poorly-spaced letters
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): No longer call drawGDIGlyphs for stroked text.
- platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added a synthesizeItalic parameter. When set to true, if italics are desired but the best match lacks italics, creates and returns a synthetic italics font. (WebCore::FontCache::createFontPlatformData): Ask to synthesize italics if needed.
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Updated an assertion, and changed to create the CGFont from the LOGFONT. (WebCore::createFontCustomPlatformData): Changed cgFont to be a RetainPtr. Do not create a CGFont from the font data if it can be created from the LOGFONT in fontPlatformData().
- platform/graphics/win/FontDatabase.cpp: (WebCore::populateFontDatabase): Avoid font database work if fonts are not going to be looked up by name.
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit): Create the CGFont from a LOGFONT based on the HFONT.
WebKitLibraries:
WebKitSystemInterface part of <rdar://problem/7173515> Use LOGFONT support in
Core Graphics when available
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Declared
wkCanCreateCGFontWithLOGFONT().
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
Dec 14, 2009:
- 11:31 PM Changeset in webkit [52140] by
-
- 12 edits2 adds in trunk
WAI-ARIA: implement treegrid
https://bugs.webkit.org/show_bug.cgi?id=31299
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/aria-treegrid.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::supportsSelectedRows):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isARIATreeGridRow):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
(WebCore::AccessibilityTable::supportsSelectedRows):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
LayoutTests:
- platform/mac/accessibility/aria-treegrid-expected.txt: Added.
- platform/mac/accessibility/aria-treegrid.html: Added.
- 10:44 PM Changeset in webkit [52139] by
-
- 6 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Some Browser-hosted SunSpider files are not valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=32536
Made various fixes to validate as HTML5 with no warnings (mainly removing bogus
close tags and adding a meta charset declaration).
- hosted/sunspider.html:
- hosted/versions.html:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html:
- 10:25 PM Changeset in webkit [52138] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Fix failing unittest.
- Scripts/modules/bugzilla_unittest.py:
- 10:24 PM Changeset in webkit [52137] by
-
- 4 edits in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Make sunspider-0.9.1 the default content set (both command-line and hosted)
https://bugs.webkit.org/show_bug.cgi?id=32537
- hosted/sunspider.html: Change default suite link.
- sunspider: Change default suite.
- sunspider-compare-results: Likewise.
- 10:16 PM Changeset in webkit [52136] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Kill _create_step_sequence
https://bugs.webkit.org/show_bug.cgi?id=32539
It's cleaner to represent not having these sequences as an empty
sequence instead of None.
- Scripts/modules/commands/download.py:
- Scripts/modules/stepsequence.py:
- 10:00 PM Changeset in webkit [52135] by
-
- 3 edits2 adds in trunk/WebKitTools
2009-12-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move Credential handling out into a separate module
https://bugs.webkit.org/show_bug.cgi?id=32531
- Scripts/modules/bugzilla.py:
- Scripts/modules/credentials.py: Added.
- Scripts/modules/credentials_unittest.py: Added.
- Scripts/run-webkit-unittests:
- 9:53 PM Changeset in webkit [52134] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Unreviewed. Address reviewer comments from an earlier patch. I didn't
do this earlier because I was worried about conflicts in dependent
patches.
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52133] by
-
- 3 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Make download commands declarative
https://bugs.webkit.org/show_bug.cgi?id=32469
This patch "properly" factors most of the download commands. These
commands are now largely declarative, which is the final step of this
grand refactoring.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- 9:38 PM Changeset in webkit [52132] by
-
- 2 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Add AbstractPatchSequencingCommand to remove redundant code
https://bugs.webkit.org/show_bug.cgi?id=32468
Redundant code is bad. This patch moves us towards more declarative
commands.
- Scripts/modules/commands/download.py:
- 9:32 PM Changeset in webkit [52131] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill WebKitApplyingScripts
https://bugs.webkit.org/show_bug.cgi?id=32467
Ah! I've been wanting to do this for a long time. This patch brings
the applying commands into the patch processing fold.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:31 PM Changeset in webkit [52130] by
-
- 5 edits in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Convert rollout to StepSequence
https://bugs.webkit.org/show_bug.cgi?id=32406
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/download_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:21 PM Changeset in webkit [52129] by
-
- 5 edits1 delete in trunk/WebKitTools
2009-12-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Kill LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=32464
Removes LandingSequence in favor of StepSequence. This required
changing the Step API slightly to carry a general notion of state
instead of carrying patches specifically.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/queues.py:
- Scripts/modules/landingsequence.py: Removed.
- Scripts/modules/stepsequence.py:
- 7:27 PM Changeset in webkit [52128] by
-
- 4 edits1 delete in trunk/SunSpider
2009-12-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
in-browser SunSpider suffers excessive penalty under power management
https://bugs.webkit.org/show_bug.cgi?id=32505
I have made a few changes to address this:
1) Change how browser-hosted SunSpider loads tests - preload the content and write it in with
document.write to reduce triggering of progress UI.
2) Reduce time between tests to 10ms from 500ms, so that power management doesn't keep the CPU
stepped all the way down the whole time.
3) Run the test cycle an extra time for warmup before the runs that count.
- hosted/sunspider-record-result.js: Removed.
- make-hosted:
- resources/TEMPLATE.html:
- resources/driver-TEMPLATE.html:
- 7:05 PM Changeset in webkit [52127] by
-
- 3 edits4 adds in trunk
<rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
https://bugs.webkit.org/show_bug.cgi?id=32382
Reviewed by Darin Adler.
WebCore:
Test: fast/block/float/in-margin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
they are in the margin) do not need to be cleared.
LayoutTests:
- fast/block/float/in-margin.html: Added.
- platform/mac/fast/block/float/in-margin-expected.checksum: Added.
- platform/mac/fast/block/float/in-margin-expected.png: Added.
- platform/mac/fast/block/float/in-margin-expected.txt: Added.
- 5:14 PM Changeset in webkit [52126] by
-
- 3 edits2 adds in trunk
Pressing backspace inside a table cell erases all empty rows below it.
<rdar://problem/5565461>
https://bugs.webkit.org/show_bug.cgi?id=32526
Reviewed by John Sullivan.
WebCore:
No deletion is performed when the caret selection is on an empty table cell.
Test: editing/deleting/delete-empty-table.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
case of caret selection.
LayoutTests:
- editing/deleting/delete-empty-table-expected.txt: Added.
- editing/deleting/delete-empty-table.html: Added.
- 4:19 PM Changeset in webkit [52125] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Brady Eidson.
Add two http iFrame dynamic form tests to the Windows Skipped
list.
- platform/win/Skipped:
- 2:45 PM Changeset in webkit [52124] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-14 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=32347
Chromium: Context menu launched by menu key has funky behavior
Make the context menu's position depend on the selection only when an
editable field has focus. Also, don't send multiple context menu events
for a single keypress.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent):
- 2:38 PM Changeset in webkit [52123] by
-
- 1 edit2 adds in trunk/WebCore
2009-12-14 Andrei Popescu <andreip@google.com>
Reviewed by Darin Adler.
[Android] Android needs ResourceHandle implementation
https://bugs.webkit.org/show_bug.cgi?id=32515
Adds implementation of ResourceHandle on Android.
No new tests needed, this is platform-specific code, so existing
tests are sufficient.
- platform/network/android/ResourceHandleAndroid.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked): (WebCore::SyncLoader::SyncLoader): (WebCore::SyncLoader::~SyncLoader): (WebCore::SyncLoader::didReceiveResponse): (WebCore::SyncLoader::didReceiveData): (WebCore::SyncLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/android/ResourceLoaderAndroid.h: Added. (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid): (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
- 2:30 PM Changeset in webkit [52122] by
-
- 2 edits in trunk/WebCore
2009-12-14 Marco Martin <notmart@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
In the Scrollbar painting of the Qt theme integration,
intersects any previous clip rects with the one needed to paint the scrollbar.
This fixes the painting in QGraphicsview, when the parent of the widget that
paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
a piece of the scrollbar should be cipped away
https://bugs.webkit.org/show_bug.cgi?id=30366
No new tests.
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):
- 2:23 PM Changeset in webkit [52121] by
-
- 2 edits in trunk/WebKit/win
Provide working printing support for WinCairo port.
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Conditionalize initialization of
PlatformGraphicsContext handling for CG vs. Cairo.
(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.
- 2:17 PM Changeset in webkit [52120] by
-
- 4 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
[V8] Generate bindings for trivial indexers.
https://bugs.webkit.org/show_bug.cgi?id=32455
Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
Added detecting indexers and generating code for them.
- bindings/v8/V8Collection.h: Removed code that's now generated.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Ditto.
- 2:16 PM Changeset in webkit [52119] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Kinuko Yasuda <kinuko@chromium.com>
Reviewed by Darin Fisher.
Make changing-frame-hierarchy-in-onload.html less flaky and
platform-independent.
https://bugs.webkit.org/show_bug.cgi?id=32319
- http/tests/navigation/changing-frame-hierarchy-in-onload.html:
- 2:09 PM Changeset in webkit [52118] by
-
- 6 edits in trunk
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- platform/qt/Skipped:
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Amend the behaviour of DRT::notifyDone to dump only when
the page has finished loading.
This fix permits removal of the following tests from the Qt skipped list:
fast/forms/textarea-linewrap-dynamic.html
fast/forms/textarea-setvalue-submit.html
fast/forms/textarea-hard-linewrap-empty.html
fast/forms/submit-to-url-fragment.html
http/tests/misc/percent-sign-in-form-field-name.html
http/tests/security/escape-form-data-field-names.html
However it also requires the following two to be added to the skipped list:
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
svg/custom/use-instanceRoot-as-event-target.xhtml
It appears the behaviour of notifyDone was masking problems with these two
tests.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::notifyDone): (LayoutTestController::provisionalLoad):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::resetLoadFinished):
- 1:57 PM Changeset in webkit [52117] by
-
- 4 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
Bug 32519 - mouseEvent fires mutiple times in
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml
Add test to Qt skipped list (was passing due to bug in DRT, see
https://bugs.webkit.org/show_bug.cgi?id=32437). Updated detail on bug
in gtk and win skipped lists.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:47 PM Changeset in webkit [52116] by
-
- 7 edits2 adds in trunk
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=31660
REGRESSION (r49394): Image load event fires before the document fragment is attached.
Test: fast/images/image-load-event-in-fragment.html
We cannot fire load events immediately after parsing a fragment - an element inserted via
innerHTML or equivalent should be reachable via getElementById() by the time its load event
fires.
- dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents() and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just preserving existing behavior.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): Load events for elements that have just been parsed cannot be dispatched yet, we should give the elements a chance to be inserted into a document first. There is no compatibility baggage for beforeload, so it seems OK to dispatch it right away.
- loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): (WebCore::ImageLoader::dispatchPendingLoadEvents):
- loader/ImageLoader.h: Separated dispatchPendingEvents() into individual functions for each event kind.
- 1:27 PM Changeset in webkit [52115] by
-
- 3 edits in trunk/WebCore
2009-12-14 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Simon Fraser.
Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
https://bugs.webkit.org/show_bug.cgi?id=30442
This enables optimizations for distinguishing between
arbitrary FloatQuads and rectilinear ones.
- platform/graphics/FloatQuad.cpp: (WebCore::FloatQuad::isRectilinear):
- platform/graphics/FloatQuad.h:
- 1:08 PM Changeset in webkit [52114] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add two XSS tests that intermittently time out to the Windows
Skipped list.
- platform/win/Skipped:
- 12:57 PM Changeset in webkit [52113] by
-
- 13 edits in trunk
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Extend basic touch event test with a simple keyboard modifier test.
- fast/events/basic-touch-events-expected.txt:
- fast/events/script-tests/basic-touch-events.js: (singleTouchSequence):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to TouchEvent
Similar to other ui events with keyboard state, get the alt, shift,
meta and ctrl modifiers straight from the platform event.
- dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
- dom/TouchEvent.h: (WebCore::TouchEvent::create):
- dom/TouchEvent.idl:
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
- platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::shiftKey): (WebCore::PlatformTouchEvent::ctrlKey): (WebCore::PlatformTouchEvent::altKey): (WebCore::PlatformTouchEvent::metaKey):
- platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2009-12-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger Freyther.
[Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::setTouchModifier): (EventSender::clearTouchPoints): (EventSender::sendTouchEvent):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:49 PM Changeset in webkit [52112] by
-
- 2 edits in trunk/WebCore
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] crash when clicking "Sign out" in GMail
https://bugs.webkit.org/show_bug.cgi?id=32300
When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.
This complete r29515
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 12:42 PM Changeset in webkit [52111] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216
Refactor tst_qwebelement to remove the qWait()
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
- 12:35 PM Changeset in webkit [52110] by
-
- 2 edits in trunk/WebKit/qt
2009-12-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
Fix the QWebPage inputMethods() autotest after r51758
to compare the Qt::ImFont property's family against an explicitly
previously configured family.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
- 12:28 PM Changeset in webkit [52109] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
access-control-basic-denied-preflight-cache.html fails manual testing.
LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
fails manual testing. It passes the automatic layout tests in Qt due to a bug with
notifyDone (see https://bugs.webkit.org/show_bug.cgi?id=32437).
Performing the test manually in QtLauncher shows that an exception is received.
Add access-control-basic-denied-preflight-cache.html to the Qt skipped list.
- platform/qt/Skipped:
- 12:21 PM Changeset in webkit [52108] by
-
- 3 edits in trunk/WebCore
2009-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
https://bugs.webkit.org/show_bug.cgi?id=32517
- inspector/front-end/InjectedScript.js: (InjectedScript.evaluateOnSelf):
- inspector/front-end/InjectedScriptAccess.js:
- 12:13 PM Changeset in webkit [52107] by
-
- 3 edits in trunk/WebCore
2009-12-14 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML enabled builds.
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::setValueForUser):
- wml/WMLInputElement.h:
- 12:06 PM Changeset in webkit [52106] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Add missing newline at end of test result.
- platform/mac-tiger/media/video-no-audio-expected.txt:
- 12:01 PM Changeset in webkit [52105] by
-
- 1 edit3 adds in trunk/WebCore
[Android] Android needs ResourceError, ResourceResponse and
ResourceRequest implementation.
https://bugs.webkit.org/show_bug.cgi?id=32522
Patch by Andrei Popescu <andreip@google.com> on 2009-12-14
Reviewed by Darin Adler.
Add implementation of ResourceError, ResourceResponse and ResourceRequest.
No new tests needed, the existing tests should be sufficient.
- platform/network/android/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
- platform/network/android/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setUserGesture):
(WebCore::ResourceRequest::getUserGesture):
- platform/network/android/ResourceResponse.h: Added.
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::doUpdateResourceResponse):
- 11:38 AM Changeset in webkit [52104] by
-
- 3 edits in trunk/WebCore
Fix the build.
- page/Geolocation.cpp:
- page/Geolocation.h:
- 11:26 AM Changeset in webkit [52103] by
-
- 24 edits5 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider
Reviewed by Dan Bernstein.
Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.
WebCore:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/Geolocation.cpp:
(WebCore::createGeopositionFromGeolocationPosition):
(WebCore::createPositionErrorFromGeolocationError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::fatalErrorOccurred):
(WebCore::Geolocation::requestTimedOut):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::makeSuccessCallbacks):
(WebCore::Geolocation::errorOccurred):
(WebCore::Geolocation::geolocationServicePositionChanged):
(WebCore::Geolocation::geolocationServiceErrorOccurred):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- page/Geolocation.h:
- page/GeolocationController.cpp: Added.
(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::lastPosition):
- page/GeolocationController.h: Added.
- page/GeolocationControllerClient.h: Added.
(WebCore::GeolocationControllerClient::~GeolocationControllerClient):
- page/GeolocationError.h: Added.
(WebCore::GeolocationError::):
(WebCore::GeolocationError::create):
(WebCore::GeolocationError::code):
(WebCore::GeolocationError::message):
- page/GeolocationPosition.h: Added.
(WebCore::GeolocationPosition::create):
(WebCore::GeolocationPosition::timestamp):
(WebCore::GeolocationPosition::latitude):
(WebCore::GeolocationPosition::longitude):
(WebCore::GeolocationPosition::accuracy):
(WebCore::GeolocationPosition::altitude):
(WebCore::GeolocationPosition::altitudeAccuracy):
(WebCore::GeolocationPosition::heading):
(WebCore::GeolocationPosition::speed):
(WebCore::GeolocationPosition::canProvideAltitude):
(WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
(WebCore::GeolocationPosition::canProvideHeading):
(WebCore::GeolocationPosition::canProvideSpeed):
(WebCore::GeolocationPosition::GeolocationPosition):
- page/Geoposition.h:
(WebCore::Geoposition::create):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::geolocationController):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
WebKit/win:
- WebView.cpp:
(WebView::initWithFrame):
- 11:10 AM QtWebKit/CodeCamp200912 edited by
- (diff)
- 10:45 AM Changeset in webkit [52102] by
-
- 3 edits3 adds in trunk
2009-12-14 Adam Langley <agl@google.com>
Reviewed by Darin Adler.
Test that an image's size is valid before reading it.
Previously, an image that failed to load (m_failed == true) would
trigger an assertion failure when WebKit tried to get its size.
https://bugs.webkit.org/show_bug.cgi?id=32176
http://code.google.com/p/chromium/issues/detail?id=28566
Test: fast/images/size-failure.html
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 10:40 AM Changeset in webkit [52101] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests
Reviewed by Simon Fraser.
- wtf/StdLibExtras.h:
(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.
- 10:04 AM Changeset in webkit [52100] by
-
- 3 edits2 adds in trunk
<rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
RenderWidget::setWidgetGeometry()
Reviewed by Darin Adler.
WebCore:
Test: fast/forms/defer-updateFromElement.html
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback): Added this post-attach callback
that invokes updateFromElement().
(WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
updateFromElement(), enqueue a post-attach (in this case, post-style
recalc) callback to do it. updateFromElement() can cause the selection
to change, and in turn trigger synchronous layout, so it must not be
called during style recalc.
LayoutTests:
- fast/forms/defer-updateFromElement-expected.txt: Added.
- fast/forms/defer-updateFromElement.html: Added.
- 10:01 AM Changeset in webkit [52099] by
-
- 18 edits in trunk/WebCore
2009-12-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [regression] inspector deletes nodes when editing css.
Now all the treeoutlines are focusable, sections and their titles
are also focusable. Change contains couple of drive-by fixes such as
canceling of the attribute edit nuking attr info and maintaining proper
selection while deleting nodes.
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype._keyDown):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.get defaultFocusedElement): (WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.get defaultFocusedElement):
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype.handleShortcut):
- inspector/front-end/SidebarPane.js: (WebInspector.SidebarPane): (WebInspector.SidebarPane.prototype.toggleExpanded): (WebInspector.SidebarPane.prototype._onTitleKeyDown):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.documentCanCopy): (WebInspector.documentCopy): (WebInspector._searchFieldManualFocus): (WebInspector._searchKeyDown): (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):
- inspector/front-end/treeoutline.js: (TreeOutline): (TreeOutline._removeChildAtIndex): (TreeOutline.prototype._treeKeyDown): (TreeElement.prototype.deselect):
- inspector/front-end/utilities.js: ():
- 9:46 AM Changeset in webkit [52098] by
-
- 2 edits in trunk/WebKit/win
Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
Reviewed by Steve Falkenburg.
Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly
- Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
of the interface so the vtable that Safari 4.0.4 sees is unchanged.
- 9:43 AM Changeset in webkit [52097] by
-
- 1 edit11 adds in trunk/LayoutTests
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Update Tiger media test results after r52094.
- platform/mac-tiger/accessibility: Added.
- platform/mac-tiger/accessibility/media-element-expected.txt: Added.
- platform/mac-tiger/media/audio-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/controls-after-reload-expected.txt: Added.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Added.
- platform/mac-tiger/media/controls-strict-expected.txt: Added.
- platform/mac-tiger/media/controls-styling-expected.txt: Added.
- platform/mac-tiger/media/video-controls-rendering-expected.txt: Added.
- platform/mac-tiger/media/video-display-toggle-expected.txt: Added.
- platform/mac-tiger/media/video-no-audio-expected.txt: Added.
- platform/mac-tiger/media/video-zoom-controls-expected.txt: Added.
- 9:20 AM Changeset in webkit [52096] by
-
- 3 edits in trunk/WebCore
2009-12-14 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Guard all of JSC's wrapper cache-related members on Document.
- dom/Document.cpp: (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
- dom/Document.h: Added JSC guards to wrapper cache-related members.
- 8:25 AM Changeset in webkit [52095] by
-
- 5 edits2 adds in trunk
AX: there's an infinite loop going on for some webpages - facebook.com
https://bugs.webkit.org/show_bug.cgi?id=32501
Reviewed by Adele Peterson.
WebCore:
The problem is that parentObjectUnignored() cannot be called
while in accessibilityIsIgnored, because it leads to
recursiveness. Specifically, there were checks to determine
if an object was within a ARIA tree. That check should
1) be moved to all platforms, and 2) not call parentObjectUnignored().
Test: accessibility/hang-in-isignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
- accessibility/hang-in-isignored-expected.txt: Added.
- accessibility/hang-in-isignored.html: Added.
- 8:16 AM Changeset in webkit [52094] by
-
- 18 edits9 adds in trunk
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Use MediaControllerThemeQuickTime on Leopard.
- rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):
2009-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
Regenerate layout and pixel test results for the new UI.
- platform/mac-leopard/Skipped:
- platform/mac-leopard/accessibility/media-element-expected.txt:
- platform/mac-leopard/media/audio-controls-rendering-expected.checksum:
- platform/mac-leopard/media/audio-controls-rendering-expected.txt:
- platform/mac-leopard/media/controls-after-reload-expected.checksum: Added.
- platform/mac-leopard/media/controls-after-reload-expected.png: Added.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-drag-timebar-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.checksum: Added.
- platform/mac-leopard/media/controls-strict-expected.png: Added.
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-strict-mode-expected.txt: Added.
- platform/mac-leopard/media/controls-styling-expected.checksum: Added.
- platform/mac-leopard/media/controls-styling-expected.png: Added.
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.checksum:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.checksum:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.checksum: Added.
- platform/mac-leopard/media/video-no-audio-expected.png: Added.
- platform/mac-leopard/media/video-no-audio-expected.txt:
- platform/mac-leopard/media/video-zoom-controls-expected.checksum:
- platform/mac-leopard/media/video-zoom-controls-expected.txt:
- 7:44 AM Changeset in webkit [52093] by
-
- 2 edits in trunk/WebKit/win
Build fix
- WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
libpath for all non-Cairo configurations (it was missing from most of
them).
- 7:38 AM Changeset in webkit [52092] by
-
- 2 edits1 add in trunk/WebCore
Move QuartzCore-related build settings into a vsprops file
Fixes <http://webkit.org/b/32518>
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added
WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
other QuartzCore-related build settings from here...
- WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
- 7:21 AM Changeset in webkit [52091] by
-
- 3 edits in trunk/WebCore
2009-12-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
handling scripts can block UI
https://bugs.webkit.org/show_bug.cgi?id=27612
Break execution of external scrips to smaller chunks.
No new tests since no new functionality was introduced.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady): (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired): (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
- html/HTMLTokenizer.h:
- 6:13 AM Changeset in webkit [52090] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed trivial buildfix.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-12-14
Fix crosses initialization of usedPrimaryBlocks for JSValue32
- runtime/Collector.cpp:
(JSC::Heap::markConservatively):
- 3:09 AM Changeset in webkit [52089] by
-
- 2 edits in trunk/WebCore
[Qt] Connect QNetworkReply via direct connections.
https://bugs.webkit.org/show_bug.cgi?id=32113
In the past we have switched from auto connections to queued
connections to get some more stability. The problem with the
Queued connections is latency. Even when running simple loading
tests the time it takes to runs highly varies and by using
direct connections these tests produce a stable result.
We will have to look out for crashes coming from within the
QNetworkAccessManager due this patch and address them then.
- 3:03 AM Changeset in webkit [52088] by
-
- 2 edits in trunk/LayoutTests
2009-12-14 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
media/video-played-collapse.html is failing
https://bugs.webkit.org/show_bug.cgi?id=31434
- platform/gtk/Skipped: Give this test another chance, we believe the bug above has been fixed in a previous commit.
- 2:51 AM Changeset in webkit [52087] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
New setting to allow applications to completely supress the
default context menu that is generated by WebKit. This allows them
to still pass the vent to the default handler without needing to
use ugly hacks such as handling populate-popup, and removing all
the items from the default context menu.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event):
- 2:48 AM Changeset in webkit [52086] by
-
- 2 edits in trunk/WebCore
[Qt] QtWebKit should use QImageReader::setQuality(49)
https://bugs.webkit.org/show_bug.cgi?id=30740
Using QImageReader::setQuality(49) will influence the JPEG
decoder of Qt to use the JDCT_IFAST routines for decompressing. This
is showing a 5% improvement in a reduction that decodes all images
used during the page loading test. The libjpeg documentation mentions
that the IFAST routine is not as accurate as other routines but in
our tests we couldn't see a difference.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
- 2:01 AM Changeset in webkit [52085] by
-
- 3 edits in trunk/WebCore
emit volumeChanged and durationChanged upon notification from GStreamer.
- 1:56 AM Changeset in webkit [52084] by
-
- 2 edits in trunk/JavaScriptCore
GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &
Reviewed by Simon Hausmann.
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 12:39 AM Changeset in webkit [52083] by
-
- 1 edit2 adds in trunk/LayoutTests
RS by Maciej Stachowiak.
Adding platform specific results for these test as part of reverting changes from http://trac.webkit.org/changeset/49585 to fix:
<rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
https://bugs.webkit.org/show_bug.cgi?id=32078
- platform/win/fast/css/large-number-round-trip-expected.txt: Added.
- platform/win/fast/css/opacity-float-expected.txt: Added.
- 12:13 AM Changeset in webkit [52082] by
-
- 33 edits2 adds in trunk
JavaScriptCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
- API/JSBase.cpp:
(JSGarbageCollect):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
- jsc.cpp:
(functionGC): Updated for rename.
- runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
- runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
- runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
- runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
- runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
- runtime/Tracing.d:
- runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
- runtime/UString.h: Updated for renames.
- runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
- wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- JavaScriptGlue.cpp:
(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.
WebCore: Changed GC from mark-sweep to mark-allocate.
Reviewed by Sam Weinig.
- ForwardingHeaders/runtime/WeakGCMap.h: Added.
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.
- bindings/js/JSDOMBinding.cpp:
(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
- bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.
- bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
- bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
wrappers.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.
- bindings/js/JSSVGPODTypeWrapper.h:
(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.h: Adopted changes above.
