Timeline
Dec 23, 2009:
- 11:18 PM Changeset in webkit [52543] by
-
- 4 edits in trunk/WebKitTools
2009-12-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool should accept global options anywhere
https://bugs.webkit.org/show_bug.cgi?id=26912
- Scripts/bugzilla-tool:
- Use the new global_options class property.
- Add a handle_global_options callback to avoid needing callbacks for each global option.
- Scripts/modules/multicommandtool.py:
- Make the code use one combined option parser. This allows us to accept global options anywhere and individual command options before commands.
- Add a handle_global_options callback to avoid needing callbacks for each global option.
- Make the Command hold the option parser, but allow the tool to override it.
- The default option parser is used for help printing and when Commands are run stand alone, but are otherwise not used.
- Add Command.main to codify the idea that Commands should support being run stand-alone.
- Change _split_args to _split_command_name_from_args now that args are unified.
- Scripts/modules/multicommandtool_unittest.py:
- Test that "tool" and "tool help" show the same help.
- Test that args are accepted before commands
- 9:49 PM Changeset in webkit [52542] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32905
With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion
Test: platform/mac/editing/input/selection-change-closes-typing.html
- editing/Editor.cpp: (WebCore::Editor::confirmComposition): If this function wasn't allowed to change selection, it needs to close the current typing command - otherwise, its idea of selection would be used for future typing.
- 9:31 PM Changeset in webkit [52541] by
-
- 6 edits in trunk/WebKitTools
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by David Levin.
Moved some sections of code in preparation to refactor
check-webkit-style's argument parser to avoid setting
global variables.
- Scripts/check-webkit-style:
- Moved _USAGE string to style.py.
- Addressed FIXME by eliminating dependencies on cpp_style.py.
- Scripts/modules/cpp_style.py:
- Moved default arguments and style categories to style.py.
- Moved exit_with_usage(), exit_with_categories(), and parse_arguments() to style.py.
- Removed references in _CppStyleState to the global variables now in style.py.
- Scripts/modules/cpp_style_unittest.py:
- Moved parse_arguments() unit tests to style_unittest.py.
- Scripts/modules/style.py:
- Added _USAGE string from check-webkit-style.
- Added default arguments and style categories from cpp_style.py.
- Added exit_with_usage(), exit_with_categories(), and parse_arguments() from cpp_sstyle.py.
- Scripts/modules/style_unittest.py: Added.
- Added parse_arguments() unit tests from cpp_style_unittest.py.
- Scripts/run-webkit-unittests:
- Added unit tests from style_unittest.py.
- 6:31 PM Changeset in webkit [52540] by
-
- 3 edits in trunk/WebKitTools
2009-12-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should mention bug 30084 when rejecting patches until it can be fixed
https://bugs.webkit.org/show_bug.cgi?id=32911
- Scripts/modules/bugzilla.py: Make the message even more fancy.
- Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
- 6:23 PM Changeset in webkit [52539] by
-
- 2 edits in trunk/WebCore
2009-12-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.
This method should limit the current painting window to the bounds of the given
image, but it did not. Due to this bug, unnecessary contents were rendered in
some (limited) situations.
[Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
https://bugs.webkit.org/show_bug.cgi?id=32817
No new tests, because this is a fix of an existing test which is currently failing in
Chromium.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.
- 6:15 PM Changeset in webkit [52538] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
Include stddef.h for ptrdiff_t
https://bugs.webkit.org/show_bug.cgi?id=32891
ptrdiff_t is typedef-ed in stddef.h.
Include stddef.h in jit/ExecutableAllocator.h.
- jit/ExecutableAllocator.h:
- 5:45 PM Changeset in webkit [52537] by
-
- 198 edits in trunk/WebCore
2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Eric Seidel.
Remove all references to "GenerateConstructor", as this is the default behaviour now.
- 5:38 PM Changeset in webkit [52536] by
-
- 2 edits in trunk/WebCore
A new database should be registered with the Document,
DatabaseTracker and DatabaseThread only after it was successfully
opened and its version was successfully verified.
Reviewed by Eric Seidel.
Fixes a regression introduced by
http://trac.webkit.org/changeset/52530.
LayoutTests/storage/open-database-while-transaction-in-progress.html
should pass again (or rather, it should pass again when run after
open-database-set-empty-version.html).
https://bugs.webkit.org/show_bug.cgi?id=32913
- storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
- 5:15 PM Changeset in webkit [52535] by
-
- 7 edits2 deletes in trunk
2009-12-23 David Levin <levin@chromium.org>
REGRESSION (r52494): Assertion failure in Frame::caretBlinkTimerFired() (selection()->isCaret())
https://bugs.webkit.org/show_bug.cgi?id=32903
No review but ok'ed by Darin Adler. Rolling out r52494 due to above regression.
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
- fast/forms/selection-layout-reentry-strange-case.html: Removed.
- platform/mac/accessibility/frame-with-title-expected.txt:
WebCore:
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection):
- editing/SelectionController.h:
- page/Frame.cpp: (WebCore::Frame::setCaretVisible): (WebCore::Frame::selectionLayoutChanged):
- page/FrameView.cpp: (WebCore::FrameView::needsLayout):
- 4:55 PM Changeset in webkit [52534] by
-
- 75 edits in trunk
2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Reverse JS GenerateConstructor logic
https://bugs.webkit.org/show_bug.cgi?id=32910
Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
old default behaviour: do not generate JSFoobarConstructor class.
No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
classes have to be exposed, most of them are missing JS constructors so far.
As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html
- 4:34 PM Changeset in webkit [52533] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Eric Seidel.
Added Windows specific results for a test that was committed in r52505.
- platform/win/fast/forms/basic-textareas-quirks-expected.txt: Added.
- 3:22 PM Changeset in webkit [52532] by
-
- 4 edits in trunk
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
https://bugs.webkit.org/show_bug.cgi?id=32908
Update expected results to show that we don't raise an alarm in this case.
- http/tests/security/xssAuditor/object-src-inject-expected.txt:
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
https://bugs.webkit.org/show_bug.cgi?id=32908
Don't block direct injections into the object src attribute unless
there's an illegal character (like < or ") in the URL. This change
lets some very unusual vulnerabilities through the filter but removes a
false positive that we've seen several times.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
- 2:34 PM Changeset in webkit [52531] by
-
- 2 edits in trunk/WebKitTools
2009-12-23 Laszlo Gombos <Laszlo Gombos>
Not reviewed, adding myself to the reviewers list.
- Scripts/modules/committers.py:
- 2:33 PM Changeset in webkit [52530] by
-
- 2 edits in trunk/WebCore
Remove pointers to a database that failed to open from the
DatabaseTracker and Document.
Reviewed by Dmitry Titov.
https://bugs.webkit.org/show_bug.cgi?id=32885
- storage/Database.cpp:
(WebCore::Database::openDatabase):
- 1:03 PM Changeset in webkit [52529] by
-
- 2 edits in trunk/JavaScriptCore
2009-12-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix after r47092.
- wtf/wince/MemoryManager.cpp: (WTF::tryFastMalloc): (WTF::tryFastZeroedMalloc): (WTF::tryFastCalloc): (WTF::tryFastRealloc):
- 12:40 PM Changeset in webkit [52528] by
-
- 7 edits in trunk/WebKitTools
2009-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Create a prepare-diff command that creates a bug and a ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=32895
The workflow Maciej and I discussed is as follows:
1) Write code.
2) bugzilla-tool prepare-diff
3) Edit ChangeLogs
4) bugzilla-tool post-diff
We might want to experimenting with combining 2-4 into a single
command, but that might be stressful to edit the ChangeLogs modally.
Removed submit-patch since it has the modal ChangeLog editing but none
oof the bug creating fun.
- Scripts/modules/bugzilla.py:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- 11:49 AM Changeset in webkit [52527] by
-
- 3 edits2 adds in trunk
<rdar://problem/7487164> First line of text cannot be selected
https://bugs.webkit.org/show_bug.cgi?id=32749
Reviewed by Darin Adler.
WebCore:
Test: fast/text/remove-zero-length-run.html
- rendering/RenderText.cpp:
(WebCore::RenderText::positionLineBox): Changed code that assumed that if a box was being
removed, it was the only box in the RenderText. Instead, correctly preserve the list of
text boxes.
(WebCore::RenderText::checkConsistency): Updated for earlier rename.
LayoutTests:
- fast/text/remove-zero-length-run-expected.txt: Added.
- fast/text/remove-zero-length-run.html: Added.
- 5:35 AM WebKit Team edited by
- (diff)
- 5:32 AM Changeset in webkit [52526] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to the committers list.
- Scripts/modules/committers.py:
- 5:19 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:52 AM Changeset in webkit [52525] by
-
- 8 edits3 adds in trunk
Fix for newlines turning into missing-gyphs when using SVG fonts
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32710
Font::drawText() has three code paths:
- drawTextUsingSVGFont()
- drawSimpleText()
- drawComplexText()
The latter two both have logic to replace newlines and tabs, as well
as a few other control characters that are considered spaces, with
spaces, before actually drawing the text. Previously the SVG font
path did not have this kind of logic.
This change introduces two helper functions in Font to do this space
replacement, which are then used for the simple path, the SVG path,
and the Qt implementation of the complex path.
Test: svg/custom/svg-fonts-in-html-linebreaks.html
WebCore:
- platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces): Helper function
- platform/graphics/Font.h:
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): Use helper
- platform/graphics/qt/FontQt.cpp:
(WebCore::fromRawDataWithoutRef): Rename from "qstring"
(WebCore::Font::drawComplexText): Use helper
(WebCore::Font::floatWidthForComplexText): Use helper
(WebCore::Font::offsetForPositionForComplexText): Use helper
(WebCore::Font::selectionRectForComplexText): Use helper
- platform/text/CharacterNames.h: Add enum for 0x0020
- svg/SVGFont.cpp: Use helper to fix bug
(WebCore::SVGTextRunWalker::walk):
LayoutTests:
- svg/custom/resources/ABCFont.svg: Added. Font for test case
- svg/custom/svg-fonts-in-html-linebreaks-expected.txt: Added.
- svg/custom/svg-fonts-in-html-linebreaks.html: New test case
- 3:05 AM Changeset in webkit [52524] by
-
- 10 edits18 adds in trunk
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
To implement the valueAsDate getter,
- Add a method to calculate milliseconds from 1970-01-01 to ISODateTime.
- Introduce m_type field to ISODateTime.
Tests: fast/forms/input-valueasdate-date.html
fast/forms/input-valueasdate-datetime.html
fast/forms/input-valueasdate-datetimelocal.html
fast/forms/input-valueasdate-month.html
fast/forms/input-valueasdate-time.html
fast/forms/input-valueasdate-week.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Implement it with ISODateTime::millisecondsSinceEpoch(). (WebCore::HTMLInputElement::formStringToISODateTime): Early exit for a null String. This avoids assertion failures in ISODateTime::parse*().
- html/ISODateTime.cpp: (WebCore::ISODateTime::parseMonth): Sets m_type. (WebCore::ISODateTime::parseDate): ditto. (WebCore::ISODateTime::parseWeek): ditto. (WebCore::ISODateTime::parseTime): ditto. (WebCore::ISODateTime::parseDateTimeLocal): ditto. (WebCore::ISODateTime::parseDateTime): ditto. (WebCore::ISODateTime::millisecondsSinceEpochForTime): Added. (WebCore::ISODateTime::millisecondsSinceEpoch): Added.
- html/ISODateTime.h: (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::invalidMilliseconds):
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
Tests for the valueAsDate getter with various types.
- fast/forms/input-valueasdate-date-expected.txt: Added.
- fast/forms/input-valueasdate-date.html: Added.
- fast/forms/input-valueasdate-datetime-expected.txt: Added.
- fast/forms/input-valueasdate-datetime.html: Added.
- fast/forms/input-valueasdate-datetimelocal-expected.txt: Added.
- fast/forms/input-valueasdate-datetimelocal.html: Added.
- fast/forms/input-valueasdate-month-expected.txt: Added.
- fast/forms/input-valueasdate-month.html: Added.
- fast/forms/input-valueasdate-time-expected.txt: Added.
- fast/forms/input-valueasdate-time.html: Added.
- fast/forms/input-valueasdate-week-expected.txt: Added.
- fast/forms/input-valueasdate-week.html: Added.
- fast/forms/script-tests/input-valueasdate-date.js: Added.
- fast/forms/script-tests/input-valueasdate-datetime.js: Added.
- fast/forms/script-tests/input-valueasdate-datetimelocal.js: Added.
- fast/forms/script-tests/input-valueasdate-month.js: Added.
- fast/forms/script-tests/input-valueasdate-time.js: Added.
- fast/forms/script-tests/input-valueasdate-week.js: Added.
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
Expose dateToDaysFrom1970().
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/DateMath.cpp: (WTF::dateToDaysFrom1970):
- wtf/DateMath.h:
- 12:52 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:46 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:00 AM Changeset in webkit [52523] by
-
- 3 edits in trunk/WebKitTools
2009-12-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[bzt] Don't call create-patch twice during post-diff
https://bugs.webkit.org/show_bug.cgi?id=32893
If we call create-patch to get the bug number, cache the diff in the
state so we don't need to call it again.
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/upload.py:
Dec 22, 2009:
- 11:54 PM Changeset in webkit [52522] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Fixes an issue in builtDylibPathForName so that it returns the correct
path to the built QtWebKit library on the Qt Windows port. Currently,
it returns the path to the file named QtWebKit.dll but this file does
not exist on the Qt Windows build. Instead, the file is named
QtWebKit4.dll.
- Scripts/webkitdirs.pm:
- 11:28 PM Changeset in webkit [52521] by
-
- 6 edits in trunk/WebCore
2009-12-22 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Renames enums in RenderStyleConstants::EListStyleType to conform to
the WebKit Code Style Guidelines.
No functionality was changed. So, no new tests.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EListStyleType):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
- rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialListStyleType):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- 10:08 PM Changeset in webkit [52520] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Adam Roben.
Remove the only dependency on perl-libwin32 in cygwin
- Scripts/num-cpus:
- 7:59 PM Changeset in webkit [52519] by
-
- 2 edits in trunk/WebCore
2009-12-22 James Su <suzhe@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Keyboard shortcut in dropdown not working.
https://bugs.webkit.org/show_bug.cgi?id=32008
Consider PlatformKeyboardEvent::Char type event as character type
event on all platforms. It fixes the "type ahead find" feature
of the popup listbox on Linux and Mac platforms.
Merge the case-sensitive type ahead find fix from
WebCore/dom/SelectElement.cpp. See
https://bugs.webkit.org/show_bug.cgi?id=29103
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent):
- 7:52 PM QtWebKitBackportingFixes edited by
- (diff)
- 6:26 PM Changeset in webkit [52518] by
-
- 2 edits in trunk/WebCore
2009-12-22 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Eric Seidel.
[Qt] The "Search" input type is not rendered correctly when styled.
https://bugs.webkit.org/show_bug.cgi?id=32417
There are no new tests because only pixel tests may be affected by
this change and those changes can only be done on the build bot.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSearchField): Since currently we paint the Search control as a QLineEdit, I have deferred painting to WebCore, as in the case of the text input so that the painting is consistent.
- 6:19 PM Changeset in webkit [52517] by
-
- 3 edits3 adds in trunk
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888
- fast/canvas/webgl/bug-32888-expected.txt: Added.
- fast/canvas/webgl/bug-32888.html: Added.
- fast/canvas/webgl/resources/bug-32888-texture.png: Added.
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888
Test: fast/canvas/webgl/bug-32888.html (works in Safari / DumpRenderTree)
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D):
- 6:11 PM Changeset in webkit [52516] by
-
- 3 edits in trunk/WebCore
2009-12-22 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=32121
[Qt] implement ImageDecoderQt::clearFrameBufferCache().
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::initializeDecoder): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::clearFrameBufferCache):
- platform/graphics/qt/ImageDecoderQt.h:
- 6:04 PM Changeset in webkit [52515] by
-
- 2 edits in trunk/WebCore
2009-12-22 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Eric Seidel.
Fix assert failure with WML pages having 'Refresh' task in
'onenterforward' event.
Writing Layout test is not possible. Please refer to the discussion
in bug id #30989. A sample test case is attached in BugZilla.
- wml/WMLCardElement.cpp: (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
- 5:34 PM Changeset in webkit [52514] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-22 Adam Langley <agl@google.com>
Build fix: not reviewed.
r52504 (https://bugs.webkit.org/show_bug.cgi?id=32845) broke the
Chromium build on Windows and Mac due to a misplaced #endif. The
buildbot didn't find the problem because it runs on Linux.
Have verified this patch with the author of the above.
- src/GraphicsContext3D.cpp:
- 5:20 PM Changeset in webkit [52513] by
-
- 5 edits in trunk/LayoutTests
Removed DataGrid from results.
- fast/dom/Window/window-properties-expected.txt: Removed DataGrid classes.
- fast/dom/prototype-inheritance-2-expected.txt: Ditto.
- fast/dom/prototype-inheritance-expected.txt: Ditto.
- fast/js/global-constructors-expected.txt: Ditto.
- 5:18 PM Changeset in webkit [52512] by
-
- 1 edit4 moves in trunk/LayoutTests
Disabled DataGrid tests.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-basic.html.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom.html.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Removed.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html.
- 4:49 PM Changeset in webkit [52511] by
-
- 3 edits4 adds in trunk
ASSERTION FAILED: m_numNodeListCaches
https://bugs.webkit.org/show_bug.cgi?id=19526
<rdar://problem/7431572>
Reviewed by Sam Weinig.
WebCore:
Test: fast/dom/NodeList/adoptNode-node-list-cache.html
- dom/Node.cpp:
(WebCore::Node::setDocument): Call removeNodeListCache on the old
document and addNodeListCache on the new one if moving a node that
has node lists.
LayoutTests:
- fast/dom/NodeList/adoptNode-node-list-cache-expected.txt: Added.
- fast/dom/NodeList/adoptNode-node-list-cache.html: Added.
- fast/dom/NodeList/resources: Added.
- fast/dom/NodeList/resources/adoptNode-node-list-cache-subframe.html: Added.
- 4:48 PM Changeset in webkit [52510] by
-
- 2 edits in trunk/WebKit/win
Another try at fixing Windows build.
- WebKitPrefix.cpp: Touch it.
- 4:36 PM EFLWebKit edited by
- (diff)
- 4:26 PM Changeset in webkit [52509] by
-
- 2 edits in trunk/WebCore
First cut at fixing Windows build.
- WebCorePrefix.cpp: Touch it.
- 3:59 PM Changeset in webkit [52508] by
-
- 2 edits in trunk/WebKitTools
- pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
generated ".pyc" files.
- 3:53 PM Changeset in webkit [52507] by
-
- 13 edits in trunk
Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
WebCore:
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
- WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
- WebCore.vcproj/build-generated-files.sh: Ditto.
- page/DOMWindow.idl: Sorted things here to touch the file to give
the Windows build a slightly better chance of success.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
WebKit/win:
- WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
WebKitTools:
- Scripts/build-webkit: Turn off datagrid by default.
- 3:50 PM Changeset in webkit [52506] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream platform-specific variant of
plugins/get-url-with-blank-target.html . There is some uncertainty
over which behavior is correct - Chromium's and Safari/Win in this
test, or Safari/Mac in the generic test. See
https://bugs.webkit.org/show_bug.cgi?id=32886 for the bug to converge
the two.
This patch is bug https://bugs.webkit.org/show_bug.cgi?32762 .
- platform/chromium/plugins/get-url-with-blank-target-expected.txt: Added.
- platform/chromium/plugins/get-url-with-blank-target.html: Added.
- 3:35 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:31 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:19 PM QtWebKitBackportingFixes edited by
- (diff)
- 3:12 PM Changeset in webkit [52505] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream a bunch of forms tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32755
- fast/forms/basic-selects.html: Added.
- fast/forms/basic-textareas-quirks.html: Added.
- fast/forms/document-write-empty-expected.txt: Added.
- fast/forms/document-write-empty.html: Added.
- fast/forms/form-action-expected.txt: Added.
- fast/forms/form-action.html: Added.
- fast/forms/lazy-event-listener-scope-chain-expected.txt: Added.
- fast/forms/lazy-event-listener-scope-chain.html: Added.
- fast/forms/resources/logo.gif: Added.
- fast/forms/selected-index-value-expected.txt: Added.
- fast/forms/selected-index-value.html: Added.
- fast/forms/style-display-none-expected.txt: Added.
- fast/forms/style-display-none.html: Added.
- platform/mac/fast/forms/basic-selects-expected.checksum: Added.
- platform/mac/fast/forms/basic-selects-expected.png: Added.
- platform/mac/fast/forms/basic-selects-expected.txt: Added.
- platform/mac/fast/forms/basic-textareas-quirks-expected.checksum:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- 3:00 PM Changeset in webkit [52504] by
-
- 2 edits in trunk/WebKit/chromium
2009-12-22 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
[Chromium] WebGL crashes intermittently on Linux
https://bugs.webkit.org/show_bug.cgi?id=32845
The dlclose'ing of libGL.so.1 and dlopen'ing of it each time a
GraphicsContext3D was created was occasionally causing it to be
re-mapped at a different base address. Since GLEW is not
re-initialized every time, primarily for performance reasons, its
cached function pointers were pointing to garbage. Stopped closing
and re-opening libGL.so.1 each time; now it is loaded lazily, when
the first 3D context is created. Also reused the X display
connection since the GLX routines' correctness might hinge upon it
not resulting in a change of GL implementation.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::tryLoad): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
- 2:33 PM Changeset in webkit [52503] by
-
- 3 edits1 copy in trunk/JavaScriptCore
2009-12-22 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Updates Android's scheduleDispatchFunctionsOnMainThread() to use new
AndroidThreading class, rather than using JavaSharedClient directly.
This fixes the current layering violation.
https://bugs.webkit.org/show_bug.cgi?id=32651
The pattern is copied from Chromium, which uses the ChromiumThreading
class. This patch also fixes the style in ChromiumThreading.h.
- wtf/android/AndroidThreading.h: Added. Declares AndroidThreading.
- wtf/android/MainThreadAndroid.cpp: Modified (WTF::scheduleDispatchFunctionsOnMainThread): Uses AndroidThreading.
- wtf/chromium/ChromiumThreading.h: Modified. Fixes style.
- 2:26 PM Changeset in webkit [52502] by
-
- 4 edits16 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741
- platform/chromium/fast/dom/interval-expected.txt: Added.
- platform/chromium/fast/dom/interval.html: Added.
- 2:18 PM Changeset in webkit [52501] by
-
- 2 edits in trunk/WebKitTools
2009-12-22 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
validate-committer-lists fails when run from an SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=31974
- Scripts/validate-committer-lists:
- Make it print a warning message instead of throwing an exception when running from an SVN checkout.
- 2:05 PM Changeset in webkit [52500] by
-
- 3 edits in trunk/JavaScriptCore
Fix a couple of problems with UntypedPtrAndBitfield.
Reviewed by Sam Weinig.
Add a m_leaksPtr to reduce false positives from leaks in debug builds
(this isn't perfect because we'd like a solution for release builds,
but this is now at least as good as a PtrAndFlags would be).
Switch SmallStringsto use a regular string for the base, rather than
a static one. UntypedPtrAndBitfield assumes all strings are at least
8 byte aligned; this migt not be true of static strings. Shared buffers
are heap allocated, as are all UStringImpls other than static strings.
Static strings cannot end up being the owner string of substrings,
since the only static strings are length 0.
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UStringImpl::UStringImpl):
- 1:59 PM Changeset in webkit [52499] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Dan Bernstein.
- page/FrameView.h: Removed incorrect comment.
- 1:47 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:44 PM Changeset in webkit [52498] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741
- platform/chromium/fast/dom/interval-expected.txt: Added.
- platform/chromium/fast/dom/interval.html: Added.
- 1:42 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:40 PM QtWebKitBackportingFixes edited by
- (diff)
- 1:36 PM Changeset in webkit [52497] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Attempting to upstream xss-inactive-closure test from the Chromium
test suite. https://bugs.webkit.org/show_bug.cgi?id=32691 .
- http/tests/security/listener/resources/xss-inactive-closure-child-2.html: Added.
- http/tests/security/listener/resources/xss-inactive-closure-child.html: Added.
- http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
- http/tests/security/listener/xss-inactive-closure.html: Added.
- 1:18 PM Changeset in webkit [52496] by
-
- 3 edits in trunk/WebKitTools
2009-12-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Adam Barth.
check-webkit-style should not warn about NULL usage in g_object_{get,set}
https://bugs.webkit.org/show_bug.cgi?id=32858
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 12:09 PM Changeset in webkit [52495] by
-
- 9 edits in trunk
2009-12-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simplify highlighter definition.
WebCore:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: (WebInspector.CSSSourceSyntaxHighlighter):
- inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: (WebInspector.JavaScriptSourceSyntaxHighlighter.): (WebInspector.JavaScriptSourceSyntaxHighlighter):
- inspector/front-end/SourceSyntaxHighlighter.js: (WebInspector.SourceSyntaxHighlighter.prototype.lex):
- inspector/front-end/utilities.js: ():
LayoutTests:
- inspector/syntax-highlight-css-expected.txt:
- inspector/syntax-highlight-javascript-expected.txt:
- inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
- 11:26 AM Changeset in webkit [52494] by
-
- 7 edits2 adds in trunk
Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974
Reviewed by Sam Weinig.
WebCore:
Test: fast/forms/selection-layout-reentry-strange-case.html
Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.
- editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.
- editing/SelectionController.h: Added setNeedsDisplayUpdate,
needsDisplayUpdate, and m_needsDisplayUpdate.
- page/Frame.cpp:
(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function.
- page/FrameView.cpp:
(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.
LayoutTests:
- fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
- fast/forms/selection-layout-reentry-strange-case.html: Added.
- platform/mac/accessibility/frame-with-title-expected.txt: Updated since
the number of layouts is now different.
- 11:17 AM QtWebKitPerformanceWork edited by
- Added WebKit and Git prerequisite (diff)
- 11:17 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:58 AM Changeset in webkit [52493] by
-
- 2 edits1 add in trunk/JavaScriptCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
RVCT (ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp
https://bugs.webkit.org/show_bug.cgi?id=32857
Add implementation of strcasecmp and strncasecmp for RVCT < 4.0
because earlier versions of RVCT 4.0 does not provide these functions.
- wtf/StringExtras.cpp: Added. (strcasecmp): (strncasecmp):
- wtf/StringExtras.h:
- 10:51 AM Changeset in webkit [52492] by
-
- 2 edits in trunk/WebCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Allocate RemoteFontStream on the heap
https://bugs.webkit.org/show_bug.cgi?id=32850
RemoteFontStream is allocated on the stack, so its memory is freed
immediately when FontCustomPlatformData::createFontCustomPlatformData
returns.
SkTypeface::CreateFromStream increments the reference count, but it keeps
the pointer to the memory allocated on the stack which is not valid
anymore.
RemoteFontStream is a descendant of SkRefCount and SkRefCount::unref
invokes SkDELETE(this) internally once the reference count reaches zero.
This means that SkRefCount-ed instances must be allocated on the heap.
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
- 10:43 AM Changeset in webkit [52491] by
-
- 2 edits in trunk/WebCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
when condition COMPILER(RVCT) is fulfilled, we are trying to free a pointer to array allocated on the stack
https://bugs.webkit.org/show_bug.cgi?id=32861
Don't free the pointer for COMPILER(RVCT).
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 10:38 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:36 AM Changeset in webkit [52490] by
-
- 3 edits in trunk/JavaScriptCore
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to forceinline for RVCT
https://bugs.webkit.org/show_bug.cgi?id=32853
Use forceinline forces RVCT to compile a C or C++ function
inline. The compiler attempts to inline the function, regardless of
the characteristics of the function.
- wtf/AlwaysInline.h:
- wtf/FastMalloc.h:
- 10:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:28 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:05 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:40 AM QtWebKitBackportingFixes edited by
- (diff)
- 9:39 AM Changeset in webkit [52489] by
-
- 8 edits in trunk/WebCore
Rubber-stamped by Dan Bernstein.
Remove no longer necessary experimental single view #ifdefs from Widget and
ScrollView.
- page/Chrome.h:
- page/mac/ChromeMac.mm:
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/Widget.cpp:
- platform/Widget.h:
- platform/mac/ScrollViewMac.mm:
- platform/mac/WidgetMac.mm:
- 9:33 AM Changeset in webkit [52488] by
-
- 5 edits in trunk/WebKit/chromium
2009-12-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
autoComplete and getElementById methods for WebKit API
- public/WebDocument.h:
- public/WebInputElement.h:
- src/WebDocument.cpp: (WebKit::WebDocument::getElementById):
- src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete):
- 9:32 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:21 AM Changeset in webkit [52487] by
-
- 4 edits in trunk/WebCore
2009-12-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not lose original request for non-main resource redirects.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::appendRedirect):
- inspector/front-end/Resource.js: (WebInspector.Resource):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 5:13 AM Changeset in webkit [52486] by
-
- 5 edits1 move in trunk
Rubber-stamped by Holger Freyther.
.:
Adjusted path to QtLauncher.
- WebKit.pro:
WebKit/qt:
Moved QtLauncher to WebKitTools/
- QtLauncher: Removed.
- QtLauncher/QtLauncher.pro: Removed.
- QtLauncher/main.cpp: Removed.
WebKitTools:
Moved QtLauncher from WebKit/qt.
- QtLauncher: Copied from WebKit/qt/QtLauncher.
- QtLauncher/QtLauncher.pro:
Dec 21, 2009:
- 11:46 PM Changeset in webkit [52485] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip layoutTestController.notifyDone() related test until fix.
https://bugs.webkit.org/show_bug.cgi?id=31626
- platform/qt/Skipped: http/tests/misc/set-window-opener-to-null.html added.
- 11:04 PM Changeset in webkit [52484] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Upstream chrome/fast/events/iframe-onload-remove-self-no-crash.html .
https://bugs.webkit.org/show_bug.cgi?id=32742 .
- fast/frames/iframe-onload-remove-self-no-crash-expected.txt: Added.
- fast/frames/iframe-onload-remove-self-no-crash.html: Added.
- fast/frames/resources/iframe-onload-remove-self-no-crash-child.html: Added.
- fast/frames/resources/iframe-onload-remove-self-no-crash.js: Added. (onWindowLoad):
- 10:57 PM Changeset in webkit [52483] by
-
- 3 edits in trunk/WebCore
2009-12-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use ASSERT instead of assert in image-decoders
https://bugs.webkit.org/show_bug.cgi?id=32852
Other decoders use WTF's ASSERT macro.
Follow this convention.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
- 10:54 PM Changeset in webkit [52482] by
-
- 2 edits in trunk/JavaScriptCore
Prospective GTK build fix: Add UStringImpl.cpp/h to the build.
- GNUmakefile.am:
- 10:53 PM Changeset in webkit [52481] by
-
- 2 edits in trunk/JavaScriptCore
Fix the Qt build, add UStringImpl.cpp to the build.
- JavaScriptCore.pri:
- 10:46 PM Changeset in webkit [52480] by
-
- 7 edits1 copy in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Automate the process of calling prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=32816
This patch automates the process of creating a bug and patch and
uploading it to bugzilla. The first cut just calls
prepare-ChangeLog.
This patch required some refactoring of upload.py to the Step
model, but that's worth doing anyway.
- Scripts/bugzilla-tool:
- Scripts/modules/buildsteps.py:
- Scripts/modules/commands/download.py:
- Scripts/modules/commands/upload.py:
- Scripts/modules/commands/upload_unittest.py:
- Scripts/modules/mock_bugzillatool.py:
- 9:44 PM Changeset in webkit [52479] by
-
- 2 edits in trunk/WebCore
2009-12-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Use vsnprintf instead of vasprintf for RVCT.
https://bugs.webkit.org/show_bug.cgi?id=32851
RVCT does not support vasprint, so use vsnprintf instead.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
- 8:47 PM Changeset in webkit [52478] by
-
- 6 edits in trunk
2009-12-21 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
- websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
- websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80
- websocket/tests/url-parsing-expected.txt:
2009-12-21 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.
- websockets/WebSocket.cpp: (WebCore::encodeProtocolString): (WebCore::WebSocket::connect):
- 8:31 PM Changeset in webkit [52477] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstream a test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32761
- http/tests/misc/resources/content-iframe.html: Added.
- http/tests/misc/set-window-opener-to-null-expected.txt: Added.
- http/tests/misc/set-window-opener-to-null.html: Added.
- 7:36 PM Changeset in webkit [52476] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix for Windows Debug, if this breaks Release I will roll it out.
- 7:01 PM Changeset in webkit [52475] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Should be final part of the Windows build fix.
- 7:00 PM Changeset in webkit [52474] by
-
- 2 edits in trunk/WebKit/mac
Don't allocate a WebGeolocationControllerClient unless that compile-time setting is enabled.
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
- 6:49 PM Changeset in webkit [52473] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Reviewed by Samuel Weinig.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 6:41 PM Changeset in webkit [52472] by
-
- 3 edits in trunk
Hopefully closer to a build fix. JavaScriptCore will build now.
- 6:25 PM Changeset in webkit [52471] by
-
- 2 edits in trunk/JavaScriptCore
Windows Build fix part 5.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 6:04 PM Changeset in webkit [52470] by
-
- 2 edits in trunk/JavaScriptCore
Fix breakage of world introduced in build fix to r52463.
Reviewed by NOBODY (build fix).
- runtime/UStringImpl.h:
- 6:03 PM Changeset in webkit [52469] by
-
- 2 edits in trunk/WebCore
Make sure that we check for the right thread.
Reviewed by Sam Weinig.
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCScheduleDeallocateOnMainThread):
- 5:35 PM QtWebKitPerformanceWork edited by
- Change formatting to outline mode (diff)
- 5:31 PM QtWebKitPerformanceWork edited by
- Add section Common Windows Errors and describe port 80 already in use error (diff)
- 5:28 PM Changeset in webkit [52468] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #4
- 5:21 PM Changeset in webkit [52467] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #3
- 5:08 PM Changeset in webkit [52466] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
unreviewed windows build fix #2
- 4:57 PM Changeset in webkit [52465] by
-
- 5 edits in trunk
WebCore: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843
Reviewed by Maciej Stachowiak.
The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843
Reviewed by Maciej Stachowiak.
The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.
- editing/execCommand/indent-with-style2-expected.txt:
- editing/execCommand/indent-with-style2.html:
- 4:53 PM Changeset in webkit [52464] by
-
- 1 edit in trunk/JavaScriptCore/runtime/UStringImpl.h
unreviewed windows build fix #1
- 4:47 PM QtWebKitPerformanceWork edited by
- Rewrote the sentence that starts "When starting the 'http_server'...", … (diff)
- 4:41 PM QtWebKitPerformanceWork edited by
- Added section Prerequisites to mention (diff)
- 4:38 PM Changeset in webkit [52463] by
-
- 10 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=32831
Replace UString::Rep implementation, following introduction of ropes to JSC.
Reviewed by Darin Adler.
- Remove redundant overcapacity mechanisms.
- Reduce memory cost of Rep's.
- Add an inline storage mechanism akin to that in WebCore's StringImpl.
~1% Sunspider progression.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::createRep):
(JSC::UString::createFromUTF8):
(JSC::UString::createUninitialized):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::ascii):
(JSC::UString::operator=):
(JSC::UString::toStrictUInt32):
(JSC::equal):
- runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::cost):
(JSC::makeString):
- runtime/UStringImpl.cpp: Added.
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::destroy):
(JSC::UStringImpl::computeHash):
- runtime/UStringImpl.h: Added.
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createCopying):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::size):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::computedHash):
(JSC::UStringImpl::setHash):
(JSC::UStringImpl::identifierTable):
(JSC::UStringImpl::setIdentifierTable):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::allocChars):
(JSC::UStringImpl::copyChars):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::null):
(JSC::UStringImpl::empty):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::operator new):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
JavaScriptGlue:
- ForwardingHeaders/wtf/PossiblyNull.h: Added.
- add forwarding header.
WebCore:
- ForwardingHeaders/runtime/UStringImpl.h: Added.
- add forwarding header.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::ustring):
- order of arguments to UString::Rep constructor for shared strings changed.
- 3:50 PM Changeset in webkit [52462] by
-
- 1 edit16 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Upstream a bunch of platform-specific Chromium plugin tests.
https://bugs.webkit.org/show_bug.cgi?id=32751
- platform/chromium/plugins/call-as-function-expected.txt: Added.
- platform/chromium/plugins/call-as-function.html: Added.
- platform/chromium/plugins/get-url-with-iframe-target-no-crash-expected.txt: Added.
- platform/chromium/plugins/get-url-with-iframe-target-no-crash.html: Added.
- platform/chromium/plugins/multiple-plugins-expected.txt: Added.
- platform/chromium/plugins/multiple-plugins.html: Added.
- platform/chromium/plugins/nested-plugin-objects-expected.txt: Added.
- platform/chromium/plugins/nested-plugin-objects.html: Added.
- platform/chromium/plugins/refcount-leaks-expected.txt: Added.
- platform/chromium/plugins/refcount-leaks.html: Added.
- platform/chromium/plugins/return-npobject-expected.txt: Added.
- platform/chromium/plugins/return-npobject.html: Added.
- platform/chromium/plugins/script-object-invoke-expected.txt: Added.
- platform/chromium/plugins/script-object-invoke.html: Added.
- 3:42 PM Changeset in webkit [52461] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test to ensure we handle variations on "javascript:" URL
correctly.
- fast/dom/xss-DENIED-javascript-variations-expected.txt: Added.
- fast/dom/xss-DENIED-javascript-variations.html: Added.
- 3:39 PM Changeset in webkit [52460] by
-
- 5 edits in trunk/WebKitLibraries
Update WebKitSystemInterface.
Reviewed by Samuel Weinig.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:15 PM Changeset in webkit [52459] by
-
- 66 edits1 add in trunk/WebCore
2009-12-18 Nate Chapin <Nate Chapin>
Reviewed by Adam barth.
Generate V8 bindings non-constructor callback declarations
in CodeGeneratorV8.pm instead of manually declaring them in
V8CustomBinding.h.
- 3:00 PM Changeset in webkit [52458] by
-
- 1 edit5 deletes in trunk/LayoutTests
2009-12-21 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Cleared instead of deleted some layout test files, making them fail. Delete them for real.
- http/tests/navigation/image-load-in-beforeunload-handler-expected.txt: Removed.
- http/tests/navigation/image-load-in-beforeunload-handler.html: Removed.
- http/tests/navigation/image-load-in-unload-handler-expected.txt: Removed.
- http/tests/navigation/image-load-in-unload-handler.html: Removed.
- http/tests/navigation/resources/wait-then-notify-done.html: Removed.
- 2:52 PM Changeset in webkit [52457] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Did a rename, so checking in the
version of the script I used.
- 2:39 PM Changeset in webkit [52456] by
-
- 15 edits in trunk
2009-12-21 Nate Chapin <Nate Chapin>
Rubber-stamped by Darin Adler.
Revert r52446 due to crashiness.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::pageHidden):
- loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame):
- loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
- loader/Request.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
- 2:12 PM Changeset in webkit [52455] by
-
- 3 edits in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update status-bubble to show all the queues
https://bugs.webkit.org/show_bug.cgi?id=32838
Also, move statusbubble over to use memcache.
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/templates/statusbubble.html:
- 1:26 PM Changeset in webkit [52454] by
-
- 5 edits in trunk/WebCore
Add support for V8 Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32699
Patch by Kent Tamura <tkent@chromium.org> on 2009-12-19
Reviewed by Adam Barth.
This implements the same behavior as the recent change of
CodeGeneratorJS.pm and JSDOMBinding.cpp.
- bindings/scripts/CodeGeneratorV8.pm: Produce toWebCoreDate() or v8DateOrNull() for Date type.
- bindings/v8/V8Binding.cpp:
(WebCore::toWebCoreDate):
Converts a JavaScript object to a double representing Date.
(WebCore::v8DateOrNull):
Converts a double representing Date to a JavaScript Date object or null.
- bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
- html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.
- 12:19 PM Changeset in webkit [52453] by
-
- 3 edits1 copy1 add in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete the boring "Empty queue" status messages in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=32818
- QueueStatusServer/app.yaml:
- QueueStatusServer/cron.yaml:
- QueueStatusServer/handlers/gc.py:
- QueueStatusServer/main.py:
- 12:18 PM Changeset in webkit [52452] by
-
- 2 edits in trunk/WebKit/qt
Doc: Minor fixes to language.
Patch by David Boddie <dboddie@trolltech.com> on 2009-12-21
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
- 12:15 PM Changeset in webkit [52451] by
-
- 5 edits in trunk/WebCore
Renamed m_sel to m_selection. Used do-webcore-rename.
Reviewed by Mark Rowe.
- editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::willBeModified):
(WebCore::SelectionController::directionOfEnclosingBlock):
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingLeft):
(WebCore::SelectionController::modifyMovingBackward):
(WebCore::SelectionController::modify):
(WebCore::SelectionController::expandUsingGranularity):
(WebCore::SelectionController::xPosForVerticalArrowNavigation):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
(WebCore::SelectionController::layout):
(WebCore::SelectionController::caretRenderer):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
(WebCore::SelectionController::debugRenderer):
(WebCore::SelectionController::contains):
(WebCore::SelectionController::selectAll):
(WebCore::SelectionController::formatForDebugger):
(WebCore::SelectionController::showTreeForThis):
- editing/SelectionController.h:
- editing/gtk/SelectionControllerGtk.cpp:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Let the script do its thing. Made sure no tests broke.
- 12:11 PM Changeset in webkit [52450] by
-
- 4 edits in trunk/WebCore
2009-12-21 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type.
https://bugs.webkit.org/show_bug.cgi?id=31814
No new tests because there are no functional changes in this patch.
- rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::computeCountInParent): (WebCore::showTreeAndMark):
- rendering/RenderCounter.cpp: (WebCore::planCounter): (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText): Changed to use identifier instead of counterName and actsAsReset or hasResetType, as appropriate instead of isReset.
- rendering/CounterNode.h: (WebCore::CounterNode::actsAsReset): (WebCore::CounterNode::hasResetType):
- 12:00 PM Changeset in webkit [52449] by
-
- 8 edits in trunk
2009-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler and Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This patch makes SVG Masking faster. The luminance calculaton of the ImageBuffer,
that is created by pixel manipulation, got optimized. The ImageBuffer and it's
luminance is created once now, not on every call of applyMask.
The size of the intermediate ImageBuffer depends on the visible area now and is
clipped by the mask rect.
The patch doesn't change functionality so no new tests needed.
The new ImageBuffer handling in Mask causes two updates of test results. The pixel
tests and LayoutTests pass, but the checksum doesn't match.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
2009-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler and Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
Update pixel test results for two SVG masking operations. They don't fail
and there is no noticable difference between the old and new results. But
Masking uses smaller ImageBuffers now and that changed the checksum.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- 10:58 AM Changeset in webkit [52448] by
-
- 5 edits2 adds in trunk
2009-12-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Test that dragging an SVG as <img> doesn't crash the browser.
Note that this only works in debug mode as it's a failing assert.
- fast/images/drag-svg-as-image.html: Added.
- platform/qt/Skipped: fast/images/drag-svg-as-image.html added.
2009-12-21 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Fix assertion failure when dragging an SVG image.
https://bugs.webkit.org/show_bug.cgi?id=32511
Test: fast/images/drag-svg-as-image.html
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::filenameExtension): Return "svg"
- svg/graphics/SVGImage.h:
- 9:58 AM Changeset in webkit [52447] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661
Removed useless calls to the G_OBJECT() macro and replaced NULL
occurences with a SENTINEL macro.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- 9:51 AM UsingGitWithWebKit edited by
- Explain why one might want to "track the Subversion repository" (diff)
- 8:55 AM Changeset in webkit [52446] by
-
- 10 edits5 adds in trunk
2009-12-21 Nate Chapin <Nate Chapin>
Reviewed by Darin Adler.
If an image load is started during an unload or beforeunload event, run it
asynchronously (and allow it to outlive its page) so navigation can continue
while the load completes.
Tests: http/tests/navigation/image-load-in-beforeunload-handler.html
http/tests/navigation/image-load-in-unload-handler.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp: Rename m_unloadEventBeingDispatched to m_isDispatchingUnloadEvent. (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Set m_isDispatchingBeforeUnloadEvent. (WebCore::FrameLoader::pageHidden):
- loader/FrameLoader.h: (WebCore::FrameLoader::isDispatchingUnloadFamilyEvent): Added.
- loader/Request.cpp: (WebCore::Request::Request): Add OutlivePagePolicy to constructor parameters
- loader/Request.h: (WebCore::): Add OutlivePagePolicy enum. (WebCore::Request::shouldOutlivePage): Added. (WebCore::Request::frame): Added.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Change one of the security checks to an outlive page check.
- loader/SubresourceLoader.h:
- loader/loader.cpp: (WebCore::Loader::load): Add OutlivePagePolicy to Request constructor call,
ensure requests that should outlive page are done asynchronously.
(WebCore::Loader::cancelRequests): Remove ending ASSERT since it will now be hard to predict how
many requests might possibly outlive a cancel in every case.
(WebCore::Loader::Host::servePendingRequests): Use the correct frame in the case of a request outliving its page.
(WebCore::Loader::Host::cancelPendingRequests): Ensure we don't cancel request that should outlive their page.
(WebCore::Loader::Host::cancelRequests): Ensure we don't cancel request that should outlive their page.
- 8:34 AM Changeset in webkit [52445] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Xan Lopez.
- platform/gtk/Skipped: Unskip test fixed by patch from Bug 24001.
- 7:06 AM Changeset in webkit [52444] by
-
- 18 edits13 copies10 moves9 adds7 deletes in trunk/WebKit/qt
[Qt] Clean up the WebKit layer unit-tests
Reviewed by Simon Hausmann.
- Use tests.pri for common options
- Standardize file naming
- Move all resources to 'resources' subdir
- Standardize how TESTS_SOURCE_DIR is used
- Get rid of UID3 for symbian (autogenerated)
- Don't build app bundles on Mac OS X
- tests/benchmarks/loading/loading.pro: Added.
- tests/benchmarks/loading/tst_loading.pro: Removed.
- tests/benchmarks/painting/painting.pro: Added.
- tests/benchmarks/painting/tst_painting.pro: Removed.
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebelement/qwebelement.qrc: Removed.
- tests/qwebelement/resources/image.png: Renamed from WebKit/qt/tests/qwebelement/image.png.
- tests/qwebelement/resources/style.css: Renamed from WebKit/qt/tests/qwebelement/style.css.
- tests/qwebelement/resources/style2.css: Renamed from WebKit/qt/tests/qwebelement/style2.css.
- tests/qwebelement/tst_qwebelement.qrc: Added.
- tests/qwebframe/qwebframe.pro:
- tests/qwebframe/qwebframe.qrc: Removed.
- tests/qwebframe/resources/image.png: Renamed from WebKit/qt/tests/qwebframe/image.png.
- tests/qwebframe/resources/style.css: Renamed from WebKit/qt/tests/qwebframe/style.css.
- tests/qwebframe/resources/test1.html: Renamed from WebKit/qt/tests/qwebframe/test1.html.
- tests/qwebframe/resources/test2.html: Renamed from WebKit/qt/tests/qwebframe/test2.html.
- tests/qwebframe/resources/testiframe.html: Renamed from WebKit/qt/tests/qwebframe/testiframe.html.
- tests/qwebframe/resources/testiframe2.html: Renamed from WebKit/qt/tests/qwebframe/testiframe2.html.
- tests/qwebframe/tst_qwebframe.cpp:
- tests/qwebframe/tst_qwebframe.qrc: Added.
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistory/resources/page1.html: Renamed from WebKit/qt/tests/qwebhistory/data/page1.html.
- tests/qwebhistory/resources/page2.html: Renamed from WebKit/qt/tests/qwebhistory/data/page2.html.
- tests/qwebhistory/resources/page3.html: Renamed from WebKit/qt/tests/qwebhistory/data/page3.html.
- tests/qwebhistory/resources/page4.html: Renamed from WebKit/qt/tests/qwebhistory/data/page4.html.
- tests/qwebhistory/resources/page5.html: Renamed from WebKit/qt/tests/qwebhistory/data/page5.html.
- tests/qwebhistory/resources/page6.html: Renamed from WebKit/qt/tests/qwebhistory/data/page6.html.
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::):
- tests/qwebhistory/tst_qwebhistory.qrc:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebpage/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebpage/frametest/frame_a.html.
- tests/qwebpage/resources/iframe.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe.html.
- tests/qwebpage/resources/iframe2.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe2.html.
- tests/qwebpage/resources/iframe3.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe3.html.
- tests/qwebpage/resources/index.html: Renamed from WebKit/qt/tests/qwebpage/frametest/index.html.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::backActionUpdate):
(tst_QWebPage::frameAt):
(tst_QWebPage::errorPageExtensionInFrameset):
(tst_QWebPage::screenshot):
- tests/qwebpage/tst_qwebpage.qrc:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
- tests/qwebview/qwebview.pro:
- tests/qwebview/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebview/data/frame_a.html.
- tests/qwebview/resources/index.html: Renamed from WebKit/qt/tests/qwebview/data/index.html.
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::reusePage):
(tst_QWebView::crashTests):
- tests/qwebview/tst_qwebview.qrc:
- tests/resources/image2.png: Renamed from WebKit/qt/tests/qwebframe/resources/image2.png.
- tests/tests.pri: Added.
- tests/tests.pro:
- 6:44 AM Changeset in webkit [52443] by
-
- 2 edits in trunk/WebKit/win
Fix non-ACCELERATED_COMPOSITING builds
- WebPreferences.cpp:
(WebPreferences::acceleratedCompositingEnabled): Guard use of
WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
- 6:36 AM Changeset in webkit [52442] by
-
- 7 edits in trunk/WebKit/win
Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
Fixes <http://webkit.org/b/32745>.
Reviewed by Ada Chan.
- Interfaces/IWebPreferencesPrivate.idl: Added
[set]AcceleratedCompositingEnabled.
- Interfaces/WebKit.idl: Touched to force a build.
- WebPreferenceKeysPrivate.h: Added
WebKitAcceleratedCompositingEnabledPreferenceKey.
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Make accelerated
compositing be on by default.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.
- WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.
- 6:36 AM Changeset in webkit [52441] by
-
- 2 edits in trunk/WebCore
Fix Windows build warnings
- WebCore.vcproj/WebCore.vcproj: Exclude SVG files from the build that
are compiled via SVGAllInOne.cpp.
- 3:10 AM Changeset in webkit [52440] by
-
- 4 edits in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Can’t copy outer html of selected node.
Also adds "Copy as HTML" context menu item.
- English.lproj/localizedStrings.js:
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/inspector.js: (WebInspector.documentCanCopy):
- 3:00 AM Changeset in webkit [52439] by
-
- 6 edits3 adds in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Eric Seidel.
Web Inspector: extract syntax highlighters into separate files.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/CSSSourceSyntaxHighlighter.js: Added. (WebInspector.CSSSourceSyntaxHighlighter):
- inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Added. (WebInspector.JavaScriptSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter.):
- inspector/front-end/SourceFrame.js:
- inspector/front-end/SourceSyntaxHighlighter.js: Added. (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.createSpan): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:48 AM Changeset in webkit [52438] by
-
- 3 edits in trunk/WebCore
defersLoading is disabled in current libcURL.
https://bugs.webkit.org/show_bug.cgi?id=32707
Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2009-12-18
Reviewed by Darin Adler.
Basically this change reverts r49577 that was totally wrong.
According to curlver.h, LIBCURL_VERSION_NUM is a
"6-digit (24 bits) hexadecimal number".
The check should be against 0x071200 (7.18) as it was originally the case.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle): Use the right check.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setDefersLoading): Ditto. Also removed a print
to use a LOG_ERROR instead.
- 1:07 AM Changeset in webkit [52437] by
-
- 4 edits in trunk/WebKitTools
2009-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Exception on queue status server
https://bugs.webkit.org/show_bug.cgi?id=32812
Turns out we need to pass the id to the filter.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/templates/patch.html:
- QueueStatusServer/templates/recentstatus.html:
Dec 20, 2009:
- 11:29 PM Changeset in webkit [52436] by
-
- 1 edit1 add in trunk/WebKitTools
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Created "style" folder for code supporting check-webkit-style.
- Scripts/modules/style: Added.
- 11:24 PM Changeset in webkit [52435] by
-
- 3 edits in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: error when running commit-queue
https://bugs.webkit.org/show_bug.cgi?id=32806
Fix typo and add test!
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- 10:20 PM Changeset in webkit [52434] by
-
- 8 edits3 adds in trunk
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
A test for Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
- fast/forms/input-valueasdate-expected.txt: Added.
- fast/forms/input-valueasdate.html: Added.
- fast/forms/script-tests/input-valueasdate.js: Added.
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add support for JavaScriptCore Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698
This is needed for HTMLInputElement::valueAsDate and
HTMLTimeElement::valueAsDate.
A Date instance is mapped to a double value in C++.
- If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
- If a getter C++ function returns NaN or infinity, a JavaScript property returns null.
Test: fast/forms/input-valueasdate.html
- bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
- bindings/js/JSDOMBinding.h: Declare them.
- bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Declare valueAsDate.
- 10:16 PM Changeset in webkit [52433] by
-
- 2 edits in trunk/WebKitSite
2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Darin Adler.
Removed outdated contact information from bug life cycle page.
- quality/lifecycle.html:
- 8:57 PM Changeset in webkit [52432] by
-
- 11 edits in trunk/WebCore
2009-12-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Introduce the followings:
- ::-webkit-inner-spin-button pseudo CSS selector
- ::-webkit-outer-spin-button pseudo CSS selector
- new appearance type: inner-spin-button
- new appearance type: outer-spin-button
They're going to be used for <input type=number> UI.
https://bugs.webkit.org/show_bug.cgi?id=31821
Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.
The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.
This change has no tests. The following changes with tests will cover.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSValueKeywords.in:
- css/html.css:
- platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
- rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.
- 7:17 PM Changeset in webkit [52431] by
-
- 4 edits in trunk/WebCore
2009-12-20 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Darin Adler.
Fix for compilation errors in WML module, due to the changeset #52314.
https://bugs.webkit.org/show_bug.cgi?id=32786
No new tests, this is compilation error fix.
- wml/WMLDocument.cpp:
- wml/WMLPageState.cpp:
- wml/WMLPageState.h:
- 6:57 PM Changeset in webkit [52430] by
-
- 8 edits1 copy1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] Optimize status updates for new dashboard
https://bugs.webkit.org/show_bug.cgi?id=32797
This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!
- Scripts/modules/commands/early_warning_system.py:
- Scripts/modules/commands/early_warning_system_unittest.py: Added.
- Scripts/modules/commands/queues.py:
- Scripts/modules/commands/queues_unittest.py:
- Scripts/modules/commands/queuestest.py: Added.
- Scripts/modules/mock_bugzillatool.py:
- Scripts/modules/patchcollection.py:
- Scripts/modules/queueengine.py:
- Scripts/run-webkit-unittests:
- 6:42 PM Changeset in webkit [52429] by
-
- 3 edits2 adds1 delete in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Prepare QueueStatusServer for new status messages
https://bugs.webkit.org/show_bug.cgi?id=32805
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/index.html: Removed.
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py: Added.
- QueueStatusServer/templates/recentstatus.html: Added.
- 3:51 PM Changeset in webkit [52428] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):
- 2:00 PM QtWebKitAPI edited by
- (diff)
- 12:50 PM Changeset in webkit [52427] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=32775
Reviewed by Mark Rowe.
- inspector/front-end/inspector.css: Use the default monospace family
and size.
- 12:07 PM Changeset in webkit [52426] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Remove emission of signal that does not exist.
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):
- 11:31 AM Changeset in webkit [52425] by
-
- 3 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Provides a new API to copy WebKitWebHistoryItem objects.
- webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_copy):
- webkit/webkitwebhistoryitem.h:
- 10:46 AM Changeset in webkit [52424] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Disable the page cache by default since:
- It was previously off by default.
- There are still some issues when enabling it.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 10:22 AM Changeset in webkit [52423] by
-
- 3 edits in trunk/WebKitTools
2009-12-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 10:07 AM Changeset in webkit [52422] by
-
- 3 edits in trunk/WebKit/gtk
2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
- tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):
- 9:39 AM Changeset in webkit [52421] by
-
- 9 edits in trunk/WebCore
2009-12-20 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Xan Lopez.
[GTK] Remove more GTK+ and GLib headers from WebCore
https://bugs.webkit.org/show_bug.cgi?id=32795
Remove most GTK+ and GLib includes from WebCore headers.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
- platform/gtk/PasteboardHelper.h:
- platform/gtk/RenderThemeGtk.cpp:
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/ScrollbarGtk.cpp:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/gtk/gtk2drawing.c:
- platform/gtk/gtkdrawing.h:
- 9:06 AM Changeset in webkit [52420] by
-
- 8 edits in trunk
[wx] build fixes after recent changes.
- 8:26 AM Changeset in webkit [52419] by
-
- 5 edits in trunk
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Avoid using fixed values when moving mouse.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788
Do not increase the click count if we are using a different button.
- DumpRenderTree/gtk/EventSender.cpp:
- 7:53 AM Changeset in webkit [52418] by
-
- 4 edits in trunk/WebKit/gtk
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001
Original patch by Bobby Powers <bobby@laptop.org>
Added new API to specify cache models for GTK port.
- webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.
- 7:45 AM Changeset in webkit [52417] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.
fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html
- platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::setGtkAdjustments):
- 4:58 AM Changeset in webkit [52416] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Revert the previous patch, it introduces some failures in the
bots.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 4:41 AM Changeset in webkit [52415] by
-
- 7 edits in trunk/WebCore
2009-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Adler.
Web Inspector: Constrain the number of messages the inspector shows.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):
- 4:27 AM Changeset in webkit [52414] by
-
- 2 edits in trunk/WebKit/gtk
2009-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] crash when loading new page
https://bugs.webkit.org/show_bug.cgi?id=32752
Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 4:18 AM Changeset in webkit [52413] by
-
- 3 edits in trunk/LayoutTests
2009-12-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Gustavo Noronha Silva.
- platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
- platform/gtk/editing/pasteboard/middle-button-paste.html:
- 4:02 AM Changeset in webkit [52412] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.
- WebCoreSupport/DocumentLoaderGtk.cpp:
(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):
- 2:46 AM Changeset in webkit [52411] by
-
- 2 edits in trunk/WebKit/gtk
Rubber-stamped by Xan Lopez.
Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.
- webkit/webkitprivate.cpp:
(webkit_init):
- 2:27 AM Changeset in webkit [52410] by
-
- 1 edit5 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstreaming two plugin tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32750
- plugins/get-file-url-expected.txt: Added.
- plugins/get-file-url.html: Added.
- plugins/get-url-with-iframe-target-expected.txt: Added.
- plugins/get-url-with-iframe-target.html: Added.
- plugins/resources/get-file-url-subframe.html: Added.
- 2:18 AM Changeset in webkit [52409] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
https://bugs.webkit.org/show_bug.cgi?id=32743
- fast/dom/document-clear-expected.txt: Added.
- fast/dom/document-clear.html: Added.
- fast/dom/resources/document-clear.js: Added.
- 2:10 AM Changeset in webkit [52408] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@chromium.org>
Reviewed by Darin Adler.
Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.
- svg/custom/new-image-is-html-element-expected.txt: Added.
- svg/custom/new-image-is-html-element.svg: Added.
- 2:01 AM Changeset in webkit [52407] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-12-20 Dirk Pranke <dpranke@fila-macpro.mtv.corp.google.com>
Reviewed by Darin Adler.
upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.
- fast/text/fake-italic.html: Added.
- platform/mac/fast/text/fake-italic-expected.checksum: Added.
- platform/mac/fast/text/fake-italic-expected.png: Added.
- platform/mac/fast/text/fake-italic-expected.txt: Added.
- 1:52 AM Changeset in webkit [52406] by
-
- 3 edits2 copies in trunk/WebCore
2009-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Adam Barth.
[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
https://bugs.webkit.org/show_bug.cgi?id=32559
Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().
No new tests, this is platform code.
- platform/android/PlatformBridge.h:
- platform/network/android/AuthenticationChallenge.h: Added.
- platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
- 1:47 AM Changeset in webkit [52405] by
-
- 7 edits1 copy1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[QueueStatusServer] Add a per-patch details page
https://bugs.webkit.org/show_bug.cgi?id=32784
This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/patch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/patch.html: Added.
- 12:27 AM Changeset in webkit [52404] by
-
- 4 edits1 add in trunk/WebKitTools
2009-12-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/model/attachment.py: Added.
Dec 19, 2009:
- 11:48 PM Changeset in webkit [52403] by
-
- 5 edits in trunk/WebCore
2009-12-19 Eric Seidel <eric@webkit.org>
No review, rolling out r52395.
http://trac.webkit.org/changeset/52395
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 11:36 PM Changeset in webkit [52402] by
-
- 6 edits in trunk
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websocket/tests/bad-sub-protocol-expected.txt:
- websocket/tests/script-tests/url-parsing.js:
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Adam Barth <abarth@webkit.org>
No review, rolling out r52399.
http://trac.webkit.org/changeset/52399
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 11:22 PM Changeset in webkit [52401] by
-
- 3 edits2 adds in trunk
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a test for window.open and JavaScript URLs.
- http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt: Added.
- http/tests/security/xss-DENIED-window-open-javascript-url.html: Added.
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Added a missing "not".
Test: http/tests/security/xss-DENIED-window-open-javascript-url.html
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
- 10:55 PM Changeset in webkit [52400] by
-
- 6 edits2 adds in trunk/WebKitTools
Provide an example implementation for printing under Windows.
http://bugs.webkit.org/show_bug.cgi?id=32504.`
Reviewed by Adam Roben.
- WinLauncher/PrintWebUIDelegate.cpp: Added.
(PrintWebUIDelegate::QueryInterface):
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):
(PrintWebUIDelegate::webViewPrintingMarginRect):
- WinLauncher/PrintWebUIDelegate.h: Added.
(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):
- WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.
- WinLauncher/WinLauncher.h:
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
- WinLauncher/WinLauncher.rc: Add menu entry for printing.
- WinLauncher/WinLauncher.vcproj: Add new files.
- WinLauncher/resource.h: Add menu entry for printing.
- 7:30 PM Changeset in webkit [52399] by
-
- 6 edits in trunk
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700
- websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
- websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
- websocket/tests/url-parsing-expected.txt:
2009-12-19 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700
Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- 6:40 PM Changeset in webkit [52398] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed. Tweak the CSS to make the dashboard prettier.
- QueueStatusServer/stylesheets/dashboard.css:
- QueueStatusServer/templates/dashboard.html:
- 6:32 PM Changeset in webkit [52397] by
-
- 2 edits in trunk/WebCore
REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776
Reviewed by Darin Adler.
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.
- 5:37 PM Changeset in webkit [52396] by
-
- 8 edits3 moves6 adds in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769
Here is a first cut at the dashboard. There's a lot left to do.
- QueueStatusServer/filters/webkit_extras.py:
- QueueStatusServer/handlers/dashboard.py: Added.
- QueueStatusServer/handlers/patchstatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/showresults.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
- QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
- QueueStatusServer/stylesheets/dashboard.css: Added.
- QueueStatusServer/templates/dashboard.html: Added.
- QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
- QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
- 5:30 PM BuildingOnWindows edited by
- Add notice of change made in changeset 51399 that requires Safari … (diff)
- 1:58 PM Changeset in webkit [52395] by
-
- 5 edits in trunk/WebCore
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738
This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.
No change in functionality. So no new test.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMaskElement.h:
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/SVGResourceMasker.h:
- 1:35 PM Changeset in webkit [52394] by
-
- 3 edits4 adds in trunk
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
Tests the right order of filter and clipper/masker aplied to a SVG
object.
- platform/mac/svg/filters/filter-clip-expected.checksum: Added.
- platform/mac/svg/filters/filter-clip-expected.png: Added.
- platform/mac/svg/filters/filter-clip-expected.txt: Added.
- svg/filters/filter-clip.svg: Added.
2009-12-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010
The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements
Test: svg/filters/filter-clip.svg
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- 12:53 PM Changeset in webkit [52393] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Daniel Bates <dbates@webkit.org>
Reviewed by Timothy Hatcher.
Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 10:55 AM Changeset in webkit [52392] by
-
- 2 edits in trunk/WebCore
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)
- GNUmakefile.am:
- 10:52 AM Changeset in webkit [52391] by
-
- 2 adds in trunk/LayoutTests/platform/gtk/svg/css
add forgotten file
- 10:45 AM Changeset in webkit [52390] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Rebaselined test after revision 52335.
- 10:37 AM Changeset in webkit [52389] by
-
- 4 edits2 adds in trunk
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
- LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed
2009-12-19 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153
- WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
- WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
- 10:30 AM Changeset in webkit [52388] by
-
- 3 edits3 adds in trunk
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
- fast/dom/Range/31684-expected.txt: Added.
- fast/dom/Range/31684.html: Added.
- fast/dom/Range/script-tests/31684.js: Added.
2009-12-19 MORITA Hajime <morrita@gmail.com>
Reviewed by Darin Adler.
WebCore::Range::surroundContents NULL pointer crash.
Test: fast/dom/Range/31684.html
- dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.
- 10:24 AM Changeset in webkit [52387] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Xan Lopez.
Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.
- webkit/webkitdownload.cpp:
(webkit_download_error):
- 10:08 AM Changeset in webkit [52386] by
-
- 2 edits in trunk/WebCore
2009-12-19 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha Silva.
Don't use an icon for all spelling guess menu items.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- 9:23 AM Changeset in webkit [52385] by
-
- 3 edits in trunk/WebKitTools
2009-12-19 Adam Barth <abarth@webkit.org>
Unreviewed fixes for me being terrible at python.
- Scripts/modules/bugzilla.py:
- Scripts/run-webkit-unittests:
- 8:24 AM Changeset in webkit [52384] by
-
- 2 edits in trunk/WebCore
2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix. Missing \.
- GNUmakefile.am:
- 7:16 AM Changeset in webkit [52383] by
-
- 2 edits in trunk
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Add a couple of WebKitGtk files to .gitignore.
- .gitignore:
- 3:52 AM Changeset in webkit [52382] by
-
- 2 edits in trunk/WebCore
2009-12-19 Evan Martin <evan@chromium.org>
Reviewed by Gustavo Noronha Silva.
Make --disable-geolocation and --disable-svg work, by conditionally
building the relevant files.
- GNUmakefile.am:
