Timeline



Dec 26, 2009:

11:36 PM Changeset in webkit [52569] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-26 Eric Seidel <​eric@webkit.org>

No review, rolling out r52554.
​http://trac.webkit.org/changeset/52554

​https://bugs.webkit.org/show_bug.cgi?id=32955
The original change was covered under
​https://bugs.webkit.org/show_bug.cgi?id=32913

r52554 was itself a rollout of r52536.
However it caused two layout tests to fail on Leopard:
storage/open-database-while-transaction-in-progress.html
svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)

So I'm rolling out the rollout in an attempt to get the bots green.
r52554 did not explain why it was rolled out, so I do not know
what might fail for Chromium after this change. I warned the folks
in #chromium that it was coming.

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
10:50 PM Changeset in webkit [52568] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make the qt build go fast
​https://bugs.webkit.org/show_bug.cgi?id=32951

Make use of multiple cores, if available.

  • Scripts/modules/webkitport.py:
7:35 PM QtBackLog edited by zecke@selfish.org
(diff)
5:28 PM Changeset in webkit [52567] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

5:27 PM Changeset in webkit [52566] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47255): Extra Large Amount of Empty Space
​https://bugs.webkit.org/show_bug.cgi?id=32690

Reviewed by Sam Weinig.

WebCore:

Test: fast/block/float/clear-to-fit.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.

LayoutTests:

  • fast/block/float/clear-to-fit-expected.checksum: Added.
  • fast/block/float/clear-to-fit-expected.png: Added.
  • fast/block/float/clear-to-fit-expected.txt: Added.
  • fast/block/float/clear-to-fit.html: Added.
1:40 AM Changeset in webkit [52565] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Skipping some flakey tests.
​https://bugs.webkit.org/show_bug.cgi?id=32946

  • platform/qt/Skipped:
    • http/tests/cookies/simple-cookies-expired.html added.
    • storage/database-lock-after-reload.html added.
    • storage/empty-statement.html added.
    • storage/execute-sql-args.html added.
    • storage/hash-change-with-xhr.html added.

Dec 25, 2009:

9:26 PM Changeset in webkit [52564] by tkent@chromium.org
  • 7 edits
    5 adds in trunk

2009-12-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
​https://bugs.webkit.org/show_bug.cgi?id=32936

<section> should behave the same as <nav>.

Test: fast/html/section-element.html

  • css/html.css: Add section as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add sectionTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag. (WebCore::blockTagList): Add sectionTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add sectionTag.
  • html/HTMLTagNames.in: Add section.

2009-12-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
​https://bugs.webkit.org/show_bug.cgi?id=32936

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/script-tests/TEMPLATE.html: Added.
  • fast/html/script-tests/section-element.js: Added.
  • fast/html/section-element-expected.txt: Added.
  • fast/html/section-element.html: Added.
8:34 PM Changeset in webkit [52563] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
3:58 PM Changeset in webkit [52562] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-25 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32682

Fixes an issue where checkFrameworks always dies with an error under Windows
since the clause "unless (-x $path)" is always satisfied because files under
Windows do not have an explict executable bit.

  • Scripts/webkitdirs.pm:
3:32 PM Changeset in webkit [52561] by dbates@webkit.org
  • 3 edits in trunk/WebCore

2009-12-25 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=32938

Cleans up XSSAuditor.

Currently, we pass various parameters through to XSSAuditor::findInRequest
that are used to determine how to decode the HTTP input parameters so that
we can perform a match against the script source. Instead, we have defined
a structure XSSAuditor::FindTask that can hold all of these parameters.

No functionality was changed. So, no new tests.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): Modified to use struct XSSAuditor::FindTask. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto. (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto. (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::FindTask::FindTask): Added.
3:11 PM Changeset in webkit [52560] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.

​https://bugs.webkit.org/show_bug.cgi?id=32941

  • platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
  • platform/qt/fast/js/global-constructors-expected.txt: updated.
3:08 PM BuildingGtk edited by jgeboski@gmail.com
(diff)
1:03 PM Changeset in webkit [52559] by Nikolas Zimmermann
  • 11 edits
    3 adds in trunk

2009-12-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

DOMWindow is missing lots of SVG* constructor objects
​https://bugs.webkit.org/show_bug.cgi?id=20430

Expose all implemented SVG 1.1 constructors.

Test: svg/custom/global-constructors.js

  • bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
  • bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
  • page/DOMWindow.idl: Add a bunch of new SVG object ctors.
  • svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
  • svg/SVGAnimatedPoints.idl: Ditto.
6:58 AM Changeset in webkit [52558] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-12-25 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

AuditsPanel for Web Inspector (hidden, no preset audits).

​https://bugs.webkit.org/show_bug.cgi?id=31665

6:37 AM Changeset in webkit [52557] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.

  • platform/qt/Skipped: inspector/settings-set-get.html removed.
6:24 AM Changeset in webkit [52556] by pfeldman@chromium.org
  • 15 edits in trunk/WebCore

2009-12-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Edit Inner HTML action.

​https://bugs.webkit.org/show_bug.cgi?id=32924

  • English.lproj/localizedStrings.js:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): ():
  • inspector/front-end/InjectedScript.js: (InjectedScript.getNodePropertyValue): (InjectedScript.setOuterHTML): (InjectedScript.performSearch.addNodesToResults): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript.pushNodeToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):

Dec 24, 2009:

11:23 PM BuildingGtk edited by dbates@webkit.org
Added notice about required libsoup >= 2.28.2 due to change-set 52208 (diff)
10:07 PM Changeset in webkit [52555] by mitz@apple.com
  • 2 edits in trunk/WebCore

Web Inspector: Console should force long URLs to wrap
​https://bugs.webkit.org/show_bug.cgi?id=32927

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Added "word-wrap: break-word;" to

the #console-messages rule.

7:25 PM Changeset in webkit [52554] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2009-12-24 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed Chromium test fix by reverting r52536.

Do not a new Database pointer to any structure until its version has been verified
​https://bugs.webkit.org/show_bug.cgi?id=32913

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
5:15 PM Changeset in webkit [52553] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-24 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

Remove LayoutTests/storage/change-version.html from Qt Skipped list


LayoutTests/storage/change-version.html now passes.
Probably related to the fix in ​https://bugs.webkit.org/show_bug.cgi?id=32437.


​https://bugs.webkit.org/show_bug.cgi?id=32917

  • platform/qt/Skipped:
11:41 AM Changeset in webkit [52552] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

Reviewed by Gustavo Noronha.

Doc : QGraphicsWebView::zoomFactor was introduced in 4.6.

9:34 AM Changeset in webkit [52551] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-12-24 Laszlo Gombos <Laszlo Gombos>

Unreviewed; revert of r52550.

The change regressed the following LayoutTests for QtWebKit.

fast/workers/worker-call.html -> crashed
fast/workers/worker-close.html -> crashed

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
9:03 AM Changeset in webkit [52550] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-24 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix memory leak by deleting instance of ThreadPrivate
in function waitForThreadCompletion(), synchronously, or in
detachThread(), asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=32614

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
6:12 AM Changeset in webkit [52549] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-24
[Qt] Skip failing test until a solution for layoutTestController.notifyDone() is found.
​https://bugs.webkit.org/show_bug.cgi?id=31626

  • platform/qt/Skipped: inspector/console-clear.html skipped
5:46 AM Changeset in webkit [52548] by jberlin@webkit.org
  • 7 edits
    7 adds in trunk

Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
should not show cut off text
​https://bugs.webkit.org/show_bug.cgi?id=29968


Reviewed by Dan Bernstein.

Also fixes the issue on both Mac OS X and Windows where the highlight
would extend only partway into the ellipsis based on the size of the
characters being truncated.

Test: editing/selection/select-text-overflow-ellipsis.html

WebCore:

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): When the ellipsis have been selected, paints them with the color for selected text. (WebCore::EllipsisBox::selectionRect): Returns the selection rect for the ellipsis text. (WebCore::EllipsisBox::paintSelection): Paints the selection highlight around the ellipsis text.
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): Default the selection state of the EllipsisBox to SelectionNone. (WebCore::EllipsisBox::setSelectionState): Allow the selection state to be explicitly set by the InlineTextBox that it is associated with, since the selection state depends on the position of the selection within the truncated text. (WebCore::EllipsisBox::selectionState): Return the cached selection state.


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): If the text is truncated and the selection extends into the truncation where there are ellipsis, set the selection state on the EllipsisBox. (WebCore::paintTextWithShadows): Allow for an upper bound to be specified on the maximum length of the text to be painted. (WebCore::InlineTextBox::paint): Make sure the text that is drawn gets appropriately truncated. This was not an issue before on Mac OS X because it wasn't necessary to draw the selected text separately (the selected text had the same color as the non-selected text). (WebCore::InlineTextBox::paintSelection): If the text is being truncated, let whatever is being painted in the space after the truncated text paint its own highlight.


  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::truncation): Allow RenderText to access the truncation status.


  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRectForRepaint): Make sure that any ellipsis box that falls within the selection also gets repainted.


Places the expected results under the mac and win platforms separately
because they are pixel test results and also the size of the
RenderBlocks are showing up as slightly different between mac and win.

LayoutTests:

  • editing/selection/select-text-overflow-ellipsis.html: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
4:33 AM Changeset in webkit [52547] by pfeldman@chromium.org
  • 24 edits
    1 add
    2 deletes in trunk

2009-12-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add Settings.js class that would manage
frontend settings.

This change:

  • Splits preferences and settings
  • Pushes settings to the frontend on load
  • Stores settings on each change
  • Stores showInheritedStyles as setting.

​https://bugs.webkit.org/show_bug.cgi?id=32832

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveFrontendSettings):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateFrontendSettings):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.saveFrontendSettings): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._setLargerResources):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  • inspector/front-end/Settings.js: Added. (WebInspector.populateFrontendSettings): (WebInspector.Settings): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._installSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
3:12 AM Changeset in webkit [52546] by pfeldman@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r52545, adding missing tests.

  • inspector/console-clear-expected.txt: Added.
  • inspector/console-clear.html: Added.
3:05 AM Changeset in webkit [52545] by pfeldman@chromium.org
  • 15 edits in trunk

2009-12-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] console's clear command does not work.

​https://bugs.webkit.org/show_bug.cgi?id=32897

Test: inspector/console-clear.html

WebCore:

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::clearConsoleMessages):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.requestClearConsoleMessages): (WebInspector.ConsoleView.prototype.clearConsoleMessages): (WebInspector.ConsoleView.prototype._clearButtonClicked):
  • inspector/front-end/InjectedScript.js: (InjectedScript.clearConsoleMessages): (InjectedScript._ensureCommandLineAPIInstalled):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/inspector.js: (WebInspector.clearConsoleMessages): (WebInspector.reset):

LayoutTests:

  • inspector/console-clear-expected.txt: Added.
  • inspector/console-clear.html: Added.
  • inspector/console-tests.js: (dumpConsoleMessages.callback): (dumpConsoleMessages):
2:38 AM Changeset in webkit [52544] by pfeldman@chromium.org
  • 10 edits in trunk

2009-12-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console dumps strings in escaped form.

​https://bugs.webkit.org/show_bug.cgi?id=32488

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatIndividualValue):
  • inspector/console-format-expected.txt:

Dec 23, 2009:

11:18 PM Changeset in webkit [52543] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should accept global options anywhere
​https://bugs.webkit.org/show_bug.cgi?id=26912

  • Scripts/bugzilla-tool:
    • Use the new global_options class property.
    • Add a handle_global_options callback to avoid needing callbacks for each global option.
  • Scripts/modules/multicommandtool.py:
    • Make the code use one combined option parser. This allows us to accept global options anywhere and individual command options before commands.
    • Add a handle_global_options callback to avoid needing callbacks for each global option.
    • Make the Command hold the option parser, but allow the tool to override it.
    • The default option parser is used for help printing and when Commands are run stand alone, but are otherwise not used.
    • Add Command.main to codify the idea that Commands should support being run stand-alone.
    • Change _split_args to _split_command_name_from_args now that args are unified.
  • Scripts/modules/multicommandtool_unittest.py:
    • Test that "tool" and "tool help" show the same help.
    • Test that args are accepted before commands
9:49 PM Changeset in webkit [52542] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32905
With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion

Test: platform/mac/editing/input/selection-change-closes-typing.html

  • editing/Editor.cpp: (WebCore::Editor::confirmComposition): If this function wasn't allowed to change selection, it needs to close the current typing command - otherwise, its idea of selection would be used for future typing.
9:31 PM Changeset in webkit [52541] by hamaji@chromium.org
  • 6 edits in trunk/WebKitTools

2009-12-20 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by David Levin.

Moved some sections of code in preparation to refactor
check-webkit-style's argument parser to avoid setting
global variables.

​https://bugs.webkit.org/show_bug.cgi?id=32592

  • Scripts/check-webkit-style:
    • Moved _USAGE string to style.py.
    • Addressed FIXME by eliminating dependencies on cpp_style.py.
  • Scripts/modules/cpp_style.py:
    • Moved default arguments and style categories to style.py.
    • Moved exit_with_usage(), exit_with_categories(), and parse_arguments() to style.py.
    • Removed references in _CppStyleState to the global variables now in style.py.
  • Scripts/modules/cpp_style_unittest.py:
    • Moved parse_arguments() unit tests to style_unittest.py.
  • Scripts/modules/style.py:
    • Added _USAGE string from check-webkit-style.
    • Added default arguments and style categories from cpp_style.py.
    • Added exit_with_usage(), exit_with_categories(), and parse_arguments() from cpp_sstyle.py.
  • Scripts/modules/style_unittest.py: Added.
    • Added parse_arguments() unit tests from cpp_style_unittest.py.
  • Scripts/run-webkit-unittests:
    • Added unit tests from style_unittest.py.
6:31 PM Changeset in webkit [52540] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should mention bug 30084 when rejecting patches until it can be fixed
​https://bugs.webkit.org/show_bug.cgi?id=32911

  • Scripts/modules/bugzilla.py: Make the message even more fancy.
  • Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
6:23 PM Changeset in webkit [52539] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-23 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.


This method should limit the current painting window to the bounds of the given
image, but it did not. Due to this bug, unnecessary contents were rendered in
some (limited) situations.

[Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
​https://bugs.webkit.org/show_bug.cgi?id=32817


No new tests, because this is a fix of an existing test which is currently failing in
Chromium.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.
6:15 PM Changeset in webkit [52538] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Laszlo Gombos.

Include stddef.h for ptrdiff_t
​https://bugs.webkit.org/show_bug.cgi?id=32891

ptrdiff_t is typedef-ed in stddef.h.
Include stddef.h in jit/ExecutableAllocator.h.

  • jit/ExecutableAllocator.h:
5:45 PM Changeset in webkit [52537] by Nikolas Zimmermann
  • 198 edits in trunk/WebCore

2009-12-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Eric Seidel.

Remove all references to "GenerateConstructor", as this is the default behaviour now.

5:38 PM Changeset in webkit [52536] by dumi@chromium.org
  • 2 edits in trunk/WebCore

A new database should be registered with the Document,
DatabaseTracker and DatabaseThread only after it was successfully
opened and its version was successfully verified.

Reviewed by Eric Seidel.

Fixes a regression introduced by
​http://trac.webkit.org/changeset/52530.

LayoutTests/storage/open-database-while-transaction-in-progress.html
should pass again (or rather, it should pass again when run after
open-database-set-empty-version.html).

​https://bugs.webkit.org/show_bug.cgi?id=32913

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

5:15 PM Changeset in webkit [52535] by levin@chromium.org
  • 7 edits
    2 deletes in trunk

2009-12-23 David Levin <​levin@chromium.org>

REGRESSION (r52494): Assertion failure in Frame::caretBlinkTimerFired() (selection()->isCaret())
​https://bugs.webkit.org/show_bug.cgi?id=32903

No review but ok'ed by Darin Adler. Rolling out r52494 due to above regression.

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
  • fast/forms/selection-layout-reentry-strange-case.html: Removed.
  • platform/mac/accessibility/frame-with-title-expected.txt:

WebCore:

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection):
  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::setCaretVisible): (WebCore::Frame::selectionLayoutChanged):
  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
4:55 PM Changeset in webkit [52534] by Nikolas Zimmermann
  • 75 edits in trunk

2009-12-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reverse JS GenerateConstructor logic
​https://bugs.webkit.org/show_bug.cgi?id=32910

Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
old default behaviour: do not generate JSFoobarConstructor class.

No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
classes have to be exposed, most of them are missing JS constructors so far.

As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html

4:34 PM Changeset in webkit [52533] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Eric Seidel.

Added Windows specific results for a test that was committed in r52505.

  • platform/win/fast/forms/basic-textareas-quirks-expected.txt: Added.
3:22 PM Changeset in webkit [52532] by abarth@webkit.org
  • 4 edits in trunk

2009-12-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
​https://bugs.webkit.org/show_bug.cgi?id=32908

Update expected results to show that we don't raise an alarm in this case.

  • http/tests/security/xssAuditor/object-src-inject-expected.txt:

2009-12-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

"Refused to execute a JavaScript script" error when embedding SWF with
a URL that is also a query parameter
​https://bugs.webkit.org/show_bug.cgi?id=32908

Don't block direct injections into the object src attribute unless
there's an illegal character (like < or ") in the URL. This change
lets some very unusual vulnerabilities through the filter but removes a
false positive that we've seen several times.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
2:34 PM Changeset in webkit [52531] by Laszlo Gombos
  • 2 edits in trunk/WebKitTools

2009-12-23 Laszlo Gombos <Laszlo Gombos>

Not reviewed, adding myself to the reviewers list.

  • Scripts/modules/committers.py:
2:33 PM Changeset in webkit [52530] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Remove pointers to a database that failed to open from the
DatabaseTracker and Document.

Reviewed by Dmitry Titov.

​https://bugs.webkit.org/show_bug.cgi?id=32885

  • storage/Database.cpp:

(WebCore::Database::openDatabase):

1:03 PM Changeset in webkit [52529] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Buildfix after r47092.

  • wtf/wince/MemoryManager.cpp: (WTF::tryFastMalloc): (WTF::tryFastZeroedMalloc): (WTF::tryFastCalloc): (WTF::tryFastRealloc):
12:40 PM Changeset in webkit [52528] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2009-12-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Create a prepare-diff command that creates a bug and a ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=32895

The workflow Maciej and I discussed is as follows:

1) Write code.
2) bugzilla-tool prepare-diff
3) Edit ChangeLogs
4) bugzilla-tool post-diff

We might want to experimenting with combining 2-4 into a single
command, but that might be stressful to edit the ChangeLogs modally.

Removed submit-patch since it has the modal ChangeLog editing but none
oof the bug creating fun.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
11:49 AM Changeset in webkit [52527] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7487164> First line of text cannot be selected
​https://bugs.webkit.org/show_bug.cgi?id=32749

Reviewed by Darin Adler.

WebCore:

Test: fast/text/remove-zero-length-run.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionLineBox): Changed code that assumed that if a box was being

removed, it was the only box in the RenderText. Instead, correctly preserve the list of
text boxes.

(WebCore::RenderText::checkConsistency): Updated for earlier rename.

LayoutTests:

  • fast/text/remove-zero-length-run-expected.txt: Added.
  • fast/text/remove-zero-length-run.html: Added.
5:35 AM WebKit Team edited by loki@webkit.org
(diff)
5:32 AM Changeset in webkit [52526] by loki@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed; added myself to the committers list.

  • Scripts/modules/committers.py:
5:19 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
4:52 AM Changeset in webkit [52525] by vestbo@webkit.org
  • 8 edits
    3 adds in trunk

Fix for newlines turning into missing-gyphs when using SVG fonts

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32710

Font::drawText() has three code paths:

  • drawTextUsingSVGFont()
  • drawSimpleText()
  • drawComplexText()

The latter two both have logic to replace newlines and tabs, as well
as a few other control characters that are considered spaces, with
spaces, before actually drawing the text. Previously the SVG font
path did not have this kind of logic.

This change introduces two helper functions in Font to do this space
replacement, which are then used for the simple path, the SVG path,
and the Qt implementation of the complex path.

Test: svg/custom/svg-fonts-in-html-linebreaks.html

WebCore:

  • platform/graphics/Font.cpp:

(WebCore::Font::normalizeSpaces): Helper function

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): Use helper

  • platform/graphics/qt/FontQt.cpp:

(WebCore::fromRawDataWithoutRef): Rename from "qstring"
(WebCore::Font::drawComplexText): Use helper
(WebCore::Font::floatWidthForComplexText): Use helper
(WebCore::Font::offsetForPositionForComplexText): Use helper
(WebCore::Font::selectionRectForComplexText): Use helper

  • platform/text/CharacterNames.h: Add enum for 0x0020
  • svg/SVGFont.cpp: Use helper to fix bug

(WebCore::SVGTextRunWalker::walk):

LayoutTests:

  • svg/custom/resources/ABCFont.svg: Added. Font for test case
  • svg/custom/svg-fonts-in-html-linebreaks-expected.txt: Added.
  • svg/custom/svg-fonts-in-html-linebreaks.html: New test case
3:05 AM Changeset in webkit [52524] by tkent@chromium.org
  • 10 edits
    18 adds in trunk

2009-12-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate getter support.
​https://bugs.webkit.org/show_bug.cgi?id=32876

To implement the valueAsDate getter,

  • Add a method to calculate milliseconds from 1970-01-01 to ISODateTime.
  • Introduce m_type field to ISODateTime.

Tests: fast/forms/input-valueasdate-date.html

fast/forms/input-valueasdate-datetime.html
fast/forms/input-valueasdate-datetimelocal.html
fast/forms/input-valueasdate-month.html
fast/forms/input-valueasdate-time.html
fast/forms/input-valueasdate-week.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Implement it with ISODateTime::millisecondsSinceEpoch(). (WebCore::HTMLInputElement::formStringToISODateTime): Early exit for a null String. This avoids assertion failures in ISODateTime::parse*().
  • html/ISODateTime.cpp: (WebCore::ISODateTime::parseMonth): Sets m_type. (WebCore::ISODateTime::parseDate): ditto. (WebCore::ISODateTime::parseWeek): ditto. (WebCore::ISODateTime::parseTime): ditto. (WebCore::ISODateTime::parseDateTimeLocal): ditto. (WebCore::ISODateTime::parseDateTime): ditto. (WebCore::ISODateTime::millisecondsSinceEpochForTime): Added. (WebCore::ISODateTime::millisecondsSinceEpoch): Added.
  • html/ISODateTime.h: (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::invalidMilliseconds):

2009-12-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate getter support.
​https://bugs.webkit.org/show_bug.cgi?id=32876

Tests for the valueAsDate getter with various types.

  • fast/forms/input-valueasdate-date-expected.txt: Added.
  • fast/forms/input-valueasdate-date.html: Added.
  • fast/forms/input-valueasdate-datetime-expected.txt: Added.
  • fast/forms/input-valueasdate-datetime.html: Added.
  • fast/forms/input-valueasdate-datetimelocal-expected.txt: Added.
  • fast/forms/input-valueasdate-datetimelocal.html: Added.
  • fast/forms/input-valueasdate-month-expected.txt: Added.
  • fast/forms/input-valueasdate-month.html: Added.
  • fast/forms/input-valueasdate-time-expected.txt: Added.
  • fast/forms/input-valueasdate-time.html: Added.
  • fast/forms/input-valueasdate-week-expected.txt: Added.
  • fast/forms/input-valueasdate-week.html: Added.
  • fast/forms/script-tests/input-valueasdate-date.js: Added.
  • fast/forms/script-tests/input-valueasdate-datetime.js: Added.
  • fast/forms/script-tests/input-valueasdate-datetimelocal.js: Added.
  • fast/forms/script-tests/input-valueasdate-month.js: Added.
  • fast/forms/script-tests/input-valueasdate-time.js: Added.
  • fast/forms/script-tests/input-valueasdate-week.js: Added.

2009-12-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate getter support.
​https://bugs.webkit.org/show_bug.cgi?id=32876

Expose dateToDaysFrom1970().

12:52 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:50 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:46 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:00 AM Changeset in webkit [52523] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-22 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

[bzt] Don't call create-patch twice during post-diff
​https://bugs.webkit.org/show_bug.cgi?id=32893

If we call create-patch to get the bug number, cache the diff in the
state so we don't need to call it again.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/upload.py:

Dec 22, 2009:

11:54 PM Changeset in webkit [52522] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-22 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32680

Fixes an issue in builtDylibPathForName so that it returns the correct
path to the built QtWebKit library on the Qt Windows port. Currently,
it returns the path to the file named QtWebKit.dll but this file does
not exist on the Qt Windows build. Instead, the file is named
QtWebKit4.dll.

  • Scripts/webkitdirs.pm:
11:28 PM Changeset in webkit [52521] by dbates@webkit.org
  • 6 edits in trunk/WebCore

2009-12-22 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32799

Renames enums in RenderStyleConstants::EListStyleType to conform to
the WebKit Code Style Guidelines.

No functionality was changed. So, no new tests.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EListStyleType):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
  • rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialListStyleType):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
10:08 PM Changeset in webkit [52520] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-22 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Adam Roben.

Remove the only dependency on perl-libwin32 in cygwin

  • Scripts/num-cpus:
7:59 PM Changeset in webkit [52519] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 James Su <​suzhe@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Keyboard shortcut in dropdown not working.
​https://bugs.webkit.org/show_bug.cgi?id=32008

Consider PlatformKeyboardEvent::Char type event as character type
event on all platforms. It fixes the "type ahead find" feature
of the popup listbox on Linux and Mac platforms.

Merge the case-sensitive type ahead find fix from
WebCore/dom/SelectElement.cpp. See
​https://bugs.webkit.org/show_bug.cgi?id=29103

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent):
7:52 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
6:26 PM Changeset in webkit [52518] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Eric Seidel.

[Qt] The "Search" input type is not rendered correctly when styled.
​https://bugs.webkit.org/show_bug.cgi?id=32417

There are no new tests because only pixel tests may be affected by
this change and those changes can only be done on the build bot.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSearchField): Since currently we paint the Search control as a QLineEdit, I have deferred painting to WebCore, as in the case of the text input so that the painting is consistent.
6:19 PM Changeset in webkit [52517] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-22 Kenneth Russell <​kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] Garbage in transparent regions of images uploaded as textures
​https://bugs.webkit.org/show_bug.cgi?id=32888

  • fast/canvas/webgl/bug-32888-expected.txt: Added.
  • fast/canvas/webgl/bug-32888.html: Added.
  • fast/canvas/webgl/resources/bug-32888-texture.png: Added.

2009-12-22 Kenneth Russell <​kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] Garbage in transparent regions of images uploaded as textures
​https://bugs.webkit.org/show_bug.cgi?id=32888

Test: fast/canvas/webgl/bug-32888.html (works in Safari / DumpRenderTree)

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D):
6:11 PM Changeset in webkit [52516] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-22 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

​https://bugs.webkit.org/show_bug.cgi?id=32121
[Qt] implement ImageDecoderQt::clearFrameBufferCache().

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::initializeDecoder): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::clearFrameBufferCache):
  • platform/graphics/qt/ImageDecoderQt.h:
6:04 PM Changeset in webkit [52515] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix assert failure with WML pages having 'Refresh' task in
'onenterforward' event.

​https://bugs.webkit.org/show_bug.cgi?id=30989

Writing Layout test is not possible. Please refer to the discussion
in bug id #30989. A sample test case is attached in BugZilla.

  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
5:34 PM Changeset in webkit [52514] by agl@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-12-22 Adam Langley <​agl@google.com>

Build fix: not reviewed.

r52504 (​https://bugs.webkit.org/show_bug.cgi?id=32845) broke the
Chromium build on Windows and Mac due to a misplaced #endif. The
buildbot didn't find the problem because it runs on Linux.

Have verified this patch with the author of the above.

  • src/GraphicsContext3D.cpp:
5:20 PM Changeset in webkit [52513] by Darin Adler
  • 5 edits in trunk/LayoutTests

Removed DataGrid from results.

  • fast/dom/Window/window-properties-expected.txt: Removed DataGrid classes.
  • fast/dom/prototype-inheritance-2-expected.txt: Ditto.
  • fast/dom/prototype-inheritance-expected.txt: Ditto.
  • fast/js/global-constructors-expected.txt: Ditto.
5:18 PM Changeset in webkit [52512] by Darin Adler
  • 1 edit
    4 moves in trunk/LayoutTests

Disabled DataGrid tests.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-basic.html.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom.html.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html.
4:49 PM Changeset in webkit [52511] by Darin Adler
  • 3 edits
    4 adds in trunk

ASSERTION FAILED: m_numNodeListCaches
​https://bugs.webkit.org/show_bug.cgi?id=19526
<rdar://problem/7431572>

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/NodeList/adoptNode-node-list-cache.html

  • dom/Node.cpp:

(WebCore::Node::setDocument): Call removeNodeListCache on the old
document and addNodeListCache on the new one if moving a node that
has node lists.

LayoutTests:

  • fast/dom/NodeList/adoptNode-node-list-cache-expected.txt: Added.
  • fast/dom/NodeList/adoptNode-node-list-cache.html: Added.
  • fast/dom/NodeList/resources: Added.
  • fast/dom/NodeList/resources/adoptNode-node-list-cache-subframe.html: Added.
4:48 PM Changeset in webkit [52510] by Darin Adler
  • 2 edits in trunk/WebKit/win

Another try at fixing Windows build.

  • WebKitPrefix.cpp: Touch it.
4:36 PM EFLWebKit edited by afonso.costa@openbossa.org
(diff)
4:26 PM Changeset in webkit [52509] by Darin Adler
  • 2 edits in trunk/WebCore

First cut at fixing Windows build.

  • WebCorePrefix.cpp: Touch it.
3:59 PM Changeset in webkit [52508] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore

generated ".pyc" files.

3:53 PM Changeset in webkit [52507] by Darin Adler
  • 13 edits in trunk

Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.

Reviewed by Mark Rowe.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.

WebCore:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
  • page/DOMWindow.idl: Sorted things here to touch the file to give

the Windows build a slightly better chance of success.

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.

WebKit/win:

  • WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.

WebKitTools:

  • Scripts/build-webkit: Turn off datagrid by default.
3:50 PM Changeset in webkit [52506] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream platform-specific variant of
plugins/get-url-with-blank-target.html . There is some uncertainty
over which behavior is correct - Chromium's and Safari/Win in this
test, or Safari/Mac in the generic test. See
​https://bugs.webkit.org/show_bug.cgi?id=32886 for the bug to converge
the two.
This patch is bug ​https://bugs.webkit.org/show_bug.cgi?32762 .

  • platform/chromium/plugins/get-url-with-blank-target-expected.txt: Added.
  • platform/chromium/plugins/get-url-with-blank-target.html: Added.
3:35 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
3:31 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
3:19 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
3:12 PM Changeset in webkit [52505] by eric@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2009-12-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream a bunch of forms tests from chromium.org.
​https://bugs.webkit.org/show_bug.cgi?id=32755

  • fast/forms/basic-selects.html: Added.
  • fast/forms/basic-textareas-quirks.html: Added.
  • fast/forms/document-write-empty-expected.txt: Added.
  • fast/forms/document-write-empty.html: Added.
  • fast/forms/form-action-expected.txt: Added.
  • fast/forms/form-action.html: Added.
  • fast/forms/lazy-event-listener-scope-chain-expected.txt: Added.
  • fast/forms/lazy-event-listener-scope-chain.html: Added.
  • fast/forms/resources/logo.gif: Added.
  • fast/forms/selected-index-value-expected.txt: Added.
  • fast/forms/selected-index-value.html: Added.
  • fast/forms/style-display-none-expected.txt: Added.
  • fast/forms/style-display-none.html: Added.
  • platform/mac/fast/forms/basic-selects-expected.checksum: Added.
  • platform/mac/fast/forms/basic-selects-expected.png: Added.
  • platform/mac/fast/forms/basic-selects-expected.txt: Added.
  • platform/mac/fast/forms/basic-textareas-quirks-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
3:00 PM Changeset in webkit [52504] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-22 Kenneth Russell <​kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] WebGL crashes intermittently on Linux
​https://bugs.webkit.org/show_bug.cgi?id=32845

The dlclose'ing of libGL.so.1 and dlopen'ing of it each time a
GraphicsContext3D was created was occasionally causing it to be
re-mapped at a different base address. Since GLEW is not
re-initialized every time, primarily for performance reasons, its
cached function pointers were pointing to garbage. Stopped closing
and re-opening libGL.so.1 each time; now it is loaded lazily, when
the first 3D context is created. Also reused the X display
connection since the GLX routines' correctness might hinge upon it
not resulting in a change of GL implementation.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::tryLoad): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
2:33 PM Changeset in webkit [52503] by eric@webkit.org
  • 3 edits
    1 copy in trunk/JavaScriptCore

2009-12-22 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Updates Android's scheduleDispatchFunctionsOnMainThread() to use new
AndroidThreading class, rather than using JavaSharedClient directly.
This fixes the current layering violation.
​https://bugs.webkit.org/show_bug.cgi?id=32651

The pattern is copied from Chromium, which uses the ChromiumThreading
class. This patch also fixes the style in ChromiumThreading.h.

  • wtf/android/AndroidThreading.h: Added. Declares AndroidThreading.
  • wtf/android/MainThreadAndroid.cpp: Modified (WTF::scheduleDispatchFunctionsOnMainThread): Uses AndroidThreading.
  • wtf/chromium/ChromiumThreading.h: Modified. Fixes style.
2:26 PM Changeset in webkit [52502] by eric@webkit.org
  • 4 edits
    16 adds in trunk/LayoutTests

2009-12-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add platform-specific chromium test.
​https://bugs.webkit.org/show_bug.cgi?id=32741

  • platform/chromium/fast/dom/interval-expected.txt: Added.
  • platform/chromium/fast/dom/interval.html: Added.
2:18 PM Changeset in webkit [52501] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-22 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

validate-committer-lists fails when run from an SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=31974

  • Scripts/validate-committer-lists:
    • Make it print a warning message instead of throwing an exception when running from an SVN checkout.
2:05 PM Changeset in webkit [52500] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix a couple of problems with UntypedPtrAndBitfield.

Reviewed by Sam Weinig.

Add a m_leaksPtr to reduce false positives from leaks in debug builds
(this isn't perfect because we'd like a solution for release builds,
but this is now at least as good as a PtrAndFlags would be).

Switch SmallStringsto use a regular string for the base, rather than
a static one. UntypedPtrAndBitfield assumes all strings are at least
8 byte aligned; this migt not be true of static strings. Shared buffers
are heap allocated, as are all UStringImpls other than static strings.
Static strings cannot end up being the owner string of substrings,
since the only static strings are length 0.

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/UStringImpl.h:

(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UStringImpl::UStringImpl):

1:59 PM Changeset in webkit [52499] by Darin Adler
  • 2 edits in trunk/WebCore

Rubber stamped by Dan Bernstein.

  • page/FrameView.h: Removed incorrect comment.
1:47 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
1:44 PM Changeset in webkit [52498] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Add platform-specific chromium test.
​https://bugs.webkit.org/show_bug.cgi?id=32741

  • platform/chromium/fast/dom/interval-expected.txt: Added.
  • platform/chromium/fast/dom/interval.html: Added.
1:42 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
1:40 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
1:36 PM Changeset in webkit [52497] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Barth.

Attempting to upstream xss-inactive-closure test from the Chromium
test suite. ​https://bugs.webkit.org/show_bug.cgi?id=32691 .

  • http/tests/security/listener/resources/xss-inactive-closure-child-2.html: Added.
  • http/tests/security/listener/resources/xss-inactive-closure-child.html: Added.
  • http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • http/tests/security/listener/xss-inactive-closure.html: Added.
1:18 PM Changeset in webkit [52496] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-22 Philippe Normand <​pnormand@igalia.com>

Reviewed by Adam Barth.

check-webkit-style should not warn about NULL usage in g_object_{get,set}
​https://bugs.webkit.org/show_bug.cgi?id=32858

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
12:09 PM Changeset in webkit [52495] by pfeldman@chromium.org
  • 9 edits in trunk

2009-12-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simplify highlighter definition.

​https://bugs.webkit.org/show_bug.cgi?id=32869

WebCore:

  • inspector/front-end/CSSSourceSyntaxHighlighter.js: (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: (WebInspector.JavaScriptSourceSyntaxHighlighter.): (WebInspector.JavaScriptSourceSyntaxHighlighter):
  • inspector/front-end/SourceSyntaxHighlighter.js: (WebInspector.SourceSyntaxHighlighter.prototype.lex):
  • inspector/front-end/utilities.js: ():

LayoutTests:

  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
11:26 AM Changeset in webkit [52494] by Darin Adler
  • 7 edits
    2 adds in trunk

Reentrancy problem with selection in some edge cases.
​https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Sam Weinig.

WebCore:

Test: fast/forms/selection-layout-reentry-strange-case.html

Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.

  • editing/SelectionController.h: Added setNeedsDisplayUpdate,

needsDisplayUpdate, and m_needsDisplayUpdate.

  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function.

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
  • fast/forms/selection-layout-reentry-strange-case.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt: Updated since

the number of layouts is now different.

11:17 AM QtWebKitPerformanceWork edited by dbates@webkit.org
Added WebKit and Git prerequisite (diff)
11:17 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:58 AM Changeset in webkit [52493] by eric@webkit.org
  • 2 edits
    1 add in trunk/JavaScriptCore

2009-12-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

RVCT (ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp
​https://bugs.webkit.org/show_bug.cgi?id=32857

Add implementation of strcasecmp and strncasecmp for RVCT < 4.0
because earlier versions of RVCT 4.0 does not provide these functions.

  • wtf/StringExtras.cpp: Added. (strcasecmp): (strncasecmp):
  • wtf/StringExtras.h:
10:51 AM Changeset in webkit [52492] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Allocate RemoteFontStream on the heap
​https://bugs.webkit.org/show_bug.cgi?id=32850

RemoteFontStream is allocated on the stack, so its memory is freed
immediately when FontCustomPlatformData::createFontCustomPlatformData
returns.

SkTypeface::CreateFromStream increments the reference count, but it keeps
the pointer to the memory allocated on the stack which is not valid
anymore.

RemoteFontStream is a descendant of SkRefCount and SkRefCount::unref
invokes SkDELETE(this) internally once the reference count reaches zero.
This means that SkRefCount-ed instances must be allocated on the heap.

  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
10:43 AM Changeset in webkit [52491] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

when condition COMPILER(RVCT) is fulfilled, we are trying to free a pointer to array allocated on the stack
​https://bugs.webkit.org/show_bug.cgi?id=32861

Don't free the pointer for COMPILER(RVCT).

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
10:38 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:36 AM Changeset in webkit [52490] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-12-22 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to forceinline for RVCT
​https://bugs.webkit.org/show_bug.cgi?id=32853

Use forceinline forces RVCT to compile a C or C++ function
inline. The compiler attempts to inline the function, regardless of
the characteristics of the function.

  • wtf/AlwaysInline.h:
  • wtf/FastMalloc.h:
10:32 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:32 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:28 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:05 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
9:40 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
9:39 AM Changeset in webkit [52489] by weinig@apple.com
  • 8 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Remove no longer necessary experimental single view #ifdefs from Widget and
ScrollView.

  • page/Chrome.h:
  • page/mac/ChromeMac.mm:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Widget.cpp:
  • platform/Widget.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/WidgetMac.mm:
9:33 AM Changeset in webkit [52488] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2009-12-22 Yaar Schnitman <​yaar@chromium.org>

Reviewed by Darin Fisher.

autoComplete and getElementById methods for WebKit API

​https://bugs.webkit.org/show_bug.cgi?id=32866

  • public/WebDocument.h:
  • public/WebInputElement.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::getElementById):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete):
9:32 AM QtWebKitBackportingFixes edited by yael.aharon@nokia.com
(diff)
8:21 AM Changeset in webkit [52487] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-12-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not lose original request for non-main resource redirects.

​https://bugs.webkit.org/show_bug.cgi?id=32678

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::appendRedirect):
  • inspector/front-end/Resource.js: (WebInspector.Resource):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
5:13 AM Changeset in webkit [52486] by Simon Hausmann
  • 5 edits
    1 move in trunk

Rubber-stamped by Holger Freyther.

.:

Adjusted path to QtLauncher.

  • WebKit.pro:

WebKit/qt:

Moved QtLauncher to WebKitTools/

  • QtLauncher: Removed.
  • QtLauncher/QtLauncher.pro: Removed.
  • QtLauncher/main.cpp: Removed.

WebKitTools:

Moved QtLauncher from WebKit/qt.

  • QtLauncher: Copied from WebKit/qt/QtLauncher.
  • QtLauncher/QtLauncher.pro:
Note: See TracTimeline for information about the timeline view.