Timeline



Dec 28, 2009:

10:49 PM Changeset in webkit [52610] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-28 Andrei Popescu <​andreip@google.com>

Reviewed by Dmitry Titov.

On Android, ResourceHandle instances make use of a pointer to a
ResourceLoaderAndroid pointer. This needs to be stored in order to later cancel
the load, if necessary. Since this pointer is an internal implementation
details of ResourceHandle on Android, it needs to be stored in the
ResourceHandleInternal class. This patch adds this pointer.
​https://bugs.webkit.org/show_bug.cgi?id=32873

No new tests needed, this is platform-specific code.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
10:41 PM Changeset in webkit [52609] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-12-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
since with XHTMLMP enabled, it's not checking create Errors, and then contents inside
<noscript> are always parsed and rendered.
​https://bugs.webkit.org/show_bug.cgi?id=32706

Tests: fast/parser/noscript-with-javascript-disabled.html

fast/parser/noscript-with-javascript-enabled.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):

2009-12-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Add test cases for <noscript> with both Javascript enabled and disabled
​https://bugs.webkit.org/show_bug.cgi?id=32706

  • fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
  • fast/parser/noscript-with-javascript-disabled.html: Added.
  • fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
  • fast/parser/noscript-with-javascript-enabled.html: Added.
10:33 PM Changeset in webkit [52608] by eric@webkit.org
  • 10 edits
    3 adds in trunk

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for chromium/Mac to correctly report
keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent):

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • platform/mac/KeyEventMac.mm: (WebCore::isKeypadEvent):

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Added a layout-test that tests if numeric pad arrow key
events are correctly reported with keyLocation as
DOM_KEY_LOCATION_NUMPAD. Currently this test only passes on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=28247

  • fast/events/keydown-numpad-keys-expected.txt: Added.
  • fast/events/keydown-numpad-keys.html: Added.
  • fast/events/script-tests/keydown-numpad-keys.js: Added. (recordKeyEvent): (testKeyEventWithLocation):
  • platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/win/Skipped: fast/events/keydown-numpad-keys.html added.

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Extended EventSender.keyDown method to take another (3rd) argument
for indicating the keyLocation to make numeric pad key events testable.
Expected values for the argument is one of the KeyLocationCode
specified in DOM Level 3
(​http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDown:withModifiers:withLocation:]):
10:25 PM Changeset in webkit [52607] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-28 Mike Moretti <​webkit9@mordent.com>

Reviewed by Darin Adler.

Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

Test: fast/dom/insert-span-into-long-text-bug-28245.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

2009-12-28 Mike Moretti <​webkit9@mordent.com>

Reviewed by Darin Adler.

Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

  • fast/dom/insert-span-into-long-text-bug-28245-expected.txt: Added.
  • fast/dom/insert-span-into-long-text-bug-28245.html: Added.
8:57 PM QtWebKitContrib edited by dbates@webkit.org
Added subsections "Dependencies" and "Installing dependencies on … (diff)
7:43 PM TinOS created by xuchao@vtins.com
7:33 PM WikiStart edited by xuchao@vtins.com
(diff)
3:46 PM Changeset in webkit [52606] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Skip test that is failing since it was checked in, and some tests
that need results.

  • platform/gtk/Skipped:
3:34 PM Changeset in webkit [52605] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-12-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Follow Apple's decision to disable HTML DataGrid by default.

  • GNUmakefile.am:
3:32 PM Changeset in webkit [52604] by ariya@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-28 Ariya Hidayat <​ariya.hidayat@gmail.com>

Unreviewed, update my email address.

  • Scripts/modules/committers.py:
3:15 PM Changeset in webkit [52603] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-12-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Ariya Hidayat.

Fix warnings when generating files using gperf. The warnings are
currently harmless, but some changes in the build system may make
them fatal.

[GTK] Build time must be reduced
​https://bugs.webkit.org/show_bug.cgi?id=32921

  • GNUmakefile.am:
12:28 PM Changeset in webkit [52602] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-28 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Delete ThreadPrivate instance after it is finished.
​https://bugs.webkit.org/show_bug.cgi?id=32614

  • wtf/qt/ThreadingQt.cpp: (WTF::ThreadMonitor::instance): (WTF::ThreadMonitor::threadFinished): (WTF::createThreadInternal): (WTF::detachThread):
12:05 PM QtWebKitBackportingFixes edited by norbert.leser@nokia.com
(diff)
11:15 AM Changeset in webkit [52601] by eric@webkit.org
  • 7 edits in trunk

2009-12-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Adam Barth.

[Qt] Fix build break for Qt 4.4
​https://bugs.webkit.org/show_bug.cgi?id=30327

No new tests, as there is no new functionality.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Use intersected() instead of operator &, which was only introduced in Qt version 4.5.
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner): Pass ColorSpace argument to fillColor() introduced in r50760

2009-12-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Adam Barth.

[Qt] Fix build break for Qt 4.4
​https://bugs.webkit.org/show_bug.cgi?id=30327

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
  • QtLauncher/main.cpp: (MainWindow::MainWindow): Qt::WA_TranslucentBackground was introduced in Qt version 4.5
9:35 AM Changeset in webkit [52600] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add an edit-changelog command
​https://bugs.webkit.org/show_bug.cgi?id=32986

This command makes it easier to edit ChangeLogs. It's similar to
prepare-ChangeLog -o, except it works with already existing ChangeLogs.

  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
9:06 AM Changeset in webkit [52599] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2009-12-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Create an ASAD command for uploading a patch
​https://bugs.webkit.org/show_bug.cgi?id=32979

The create-review command goes through the whole process of preparing a
code review, including creating a bug, editing the ChangeLogs, and
uploading the patch. It is indeed the All Sing, All Dance upload
command.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/user.py:
8:58 AM Changeset in webkit [52598] by eric@webkit.org
  • 4 edits in trunk

2009-12-28 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Maciej Stachowiak.

Cleanup of #define JS_EXPORT.

  • API/JSBase.h:

2009-12-28 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Maciej Stachowiak.

Use JS_NO_EXPORT for JSBase.h.

  • wxwk-settings.bkl:
8:48 AM Changeset in webkit [52597] by eric@webkit.org
  • 2 edits in trunk

2009-12-28 Estêvão Samuel Procópio <​tevaum@gmail.com>

Reviewed by Gustavo Noronha Silva.

Bug 32940: [GTK] Changing the download throttle conditions.
​https://bugs.webkit.org/show_bug.cgi?id=32716

The WebKitDownload progress notification was taking long to
update. This fix makes notification happens each 0.7 secs
or when the progress ups in 1%.

  • WebKit/gtk/webkit/webkitdownload.cpp:
5:48 AM Changeset in webkit [52596] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2009-12-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <article> element.
​https://bugs.webkit.org/show_bug.cgi?id=32942

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/article-element-expected.txt: Added.
  • fast/html/article-element.html: Added.
  • fast/html/script-tests/article-element.js: Added.

2009-12-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <article> element.
​https://bugs.webkit.org/show_bug.cgi?id=32936

<article> should behave the same as <nav> and <section>.

Test: fast/html/article-element.html

  • css/html.css: Add article as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add articleTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for articleTag. (WebCore::blockTagList): Add articleTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add articleTag.
  • html/HTMLTagNames.in: Add article.
12:22 AM Changeset in webkit [52595] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-28 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix (with test!).

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:

Dec 27, 2009:

11:59 PM Changeset in webkit [52594] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-27 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
​https://bugs.webkit.org/show_bug.cgi?id=32980

  • Scripts/modules/bugzilla.py:
    • Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
    • Replace fetch_title_from_bug with a new fetch_bug call instead.
    • Use list comprehensions where possible to reduce code duplication.
  • Scripts/modules/bugzilla_unittest.py:
    • Add a minimal bug parsing test.
    • Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
  • Scripts/modules/commands/upload.py:
    • Use fetch_bug(bug_id)title instead of fetch_title_from_bug
11:05 PM Changeset in webkit [52593] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Status bubble shouldn't be transparent for bots that haven't run yet
​https://bugs.webkit.org/show_bug.cgi?id=32977

  • QueueStatusServer/templates/statusbubble.html:
10:58 PM Changeset in webkit [52592] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[QueueStatusServer] Run gc cron job less often
​https://bugs.webkit.org/show_bug.cgi?id=32958

Now that we've cleaned out the backlog of idle messages, we don't need
to run the gc job every half hour. We could also stop logging the idle
messages, but this seems easier for the time being.

  • QueueStatusServer/cron.yaml:
8:58 PM Changeset in webkit [52591] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

Rubber stamped by Adam Barth.

Put media/audio-delete-while-step-button-clicked.html back in the mac skipped list because
I think it's making other media tests fail sporadically.

  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
7:39 PM Changeset in webkit [52590] by eric@webkit.org
  • 5 edits in trunk

2009-12-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] Support upload progress events in XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=32969

Make QNetworkReplyHandler report the upload progress to the client.

Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html

which have been unskipped.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::uploadProgress): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:

2009-12-27 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] Support upload progress events in XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=32969

Make QNetworkReplyHandler report the upload progress to the client.

Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html

which have been unskipped.

  • platform/qt/Skipped:
7:17 PM Changeset in webkit [52589] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Rubber stamped by Adam Barth.

Add media/audio-delete-while-step-button-clicked.html back to the Tiger skipped list.

  • platform/mac-tiger/Skipped:
6:28 PM Changeset in webkit [52588] by mjs@apple.com
  • 3 edits
    6 adds in trunk/LayoutTests

Rubber stamped by Adam Barth.

Removed some tests from the skipped list that are not failing on my system.

  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-style-color-expected.png: Added.
  • platform/mac/fast/forms/menulist-style-color-expected.txt: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.txt: Added.
6:01 PM Changeset in webkit [52587] by dbates@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2009-12-27 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=32896

Fixes an issue where bugzilla-tool tries to read the username and password from
Git regardless of whether Git is installed. In particular, if Git is not
installed then bugzilla-tool dies (with a trace) when it attempts to query Git
for the authentication credentials to log into bugs.webkit.org.

Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
the specified error handler. For instance, the specified error handler will now
be called when the command does not exist (i.e. OSError errno 2).

  • Scripts/modules/credentials.py: Added check for Git.
  • Scripts/modules/credentials_unittest.py: Added test method test_read_credentials_with_SVN.
  • Scripts/modules/executive.py: Modified method run_command to catch OSError exceptions (i.e [Errno 2] No such file or directory) and call the specified error handler.
  • Scripts/modules/executive_unittest.py: Added.
  • Scripts/run-webkit-unittests: Added import executive_unittest.py.
5:25 PM Changeset in webkit [52586] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Rubber stamped by Cameron Zwarich.

Skip fast/images/size-failure.html on SnowLeopard because it
tickles a CG bug that makes it time out.

  • platform/mac-snowleopard/Skipped:
3:48 PM Changeset in webkit [52585] by mjs@apple.com
  • 4 edits
    3 copies in trunk/LayoutTests

2009-12-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

fast/forms/basic-selects.html is failing on SnowLeopard
​https://bugs.webkit.org/show_bug.cgi?id=32960

The recently added fast/forms/basic-selects.html is failing on SnowLeopard; the
result checked in is only valid for Leopard and earlier, because SnowLeopard
slightly changed the disabled text color.


Move the pre-SL result to platform/mac-leopard and generate new
SnowLeopard results in platform/mac.


  • platform/mac-leopard/fast/forms/basic-selects-expected.checksum: Copied from platform/mac/fast/forms/basic-selects-expected.checksum.
  • platform/mac-leopard/fast/forms/basic-selects-expected.png: Copied from platform/mac/fast/forms/basic-selects-expected.png.
  • platform/mac-leopard/fast/forms/basic-selects-expected.txt: Copied from platform/mac/fast/forms/basic-selects-expected.txt.
  • platform/mac/fast/forms/basic-selects-expected.checksum:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.txt:
2:22 PM Changeset in webkit [52584] by krit@webkit.org
  • 19 edits
    4 adds in trunk

2009-12-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG: Stop rendering of objects with empty mask and filter content
​https://bugs.webkit.org/show_bug.cgi?id=32968

It's not neccessary to continue rendering of an object and its' childs
if the mask clips the complete content away.
The same for filters, if the filter rendering is discontinued or either
width or height are zero.
We might also stop rendering if repaintRectInLocalCoordinates is empty.
But it needs to be fixed first.

Test: svg/custom/empty-mask.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:

2009-12-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG: Stop rendering of objects with empty mask and filter content
​https://bugs.webkit.org/show_bug.cgi?id=32968

Check if the content is not drawn, if the mask clips the complete
content away.
mask-excessive-malloc needed an update. This patch stops rendering
if there is no content in mask. But it's intention is to test
big masking images.

  • platform/mac/svg/custom/empty-mask-expected.checksum: Added.
  • platform/mac/svg/custom/empty-mask-expected.png: Added.
  • platform/mac/svg/custom/empty-mask-expected.txt: Added.
  • platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.png:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • svg/custom/empty-mask.svg: Added.
  • svg/custom/mask-excessive-malloc.svg:
11:25 AM Changeset in webkit [52583] by dbates@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-12-27 Daniel Bates <​dbates@webkit.org>

Unreviewed. Added missing file style_unittest.py that wasn't committed
in change set 52541 (​http://trac.webkit.org/changeset/52541) as part of
the patch for bug #32592.

  • Scripts/modules/style_unittest.py: Added.
11:12 AM Changeset in webkit [52582] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-27 Daniel Bates <​dbates@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32964

[bzt] Updated the unit test based on the change made in bug #32951.

The change made in bug #32951 added the command-line argument:
--makeargs="-j8" to the build-webkit command. However, the associated
unit test was not updated.

  • Scripts/modules/webkitport_unittest.py:
10:19 AM Changeset in webkit [52581] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-12-27 Christian Dywan <​christian@twotoasts.de>

Reviewed by Eric Seidel.

[GTK] Spell Check Suggestions (Do not work)
​https://bugs.webkit.org/show_bug.cgi?id=30908

  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): Implement the 'title' member and set the title from the native menu item.
9:08 AM Changeset in webkit [52580] by krit@webkit.org
  • 34 edits
    4 adds in trunk

2009-12-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Mask result wrong, if two different objects call the same mask id
​https://bugs.webkit.org/show_bug.cgi?id=32787

At the moment we create one resource per maskId. Some resources (like mask)
create ImageBuffers and depends on the properties of the RenderObject,
thus we can't use it for a second object.
This patch stores multiple mask resources for one maskId and different
RenderObject can use the same maskId.
Clipper, Filter and Patterns also need to store multiple resources later.

Test: svg/custom/mask-on-multiple-objects.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderResources):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
  • svg/SVGClipPathElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::canvasResource):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::canvasResource):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::canvasResource):
  • svg/SVGPatternElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::getPaintServerById): (WebCore::SVGPaintServer::fillPaintServer): (WebCore::SVGPaintServer::strokePaintServer):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/SVGResource.cpp: (WebCore::getResourceById):
  • svg/graphics/SVGResource.h:
  • svg/graphics/SVGResourceClipper.cpp: (WebCore::getClipperById):
  • svg/graphics/SVGResourceClipper.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::getFilterById):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::getMarkerById):
  • svg/graphics/SVGResourceMarker.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::getMaskerById):
  • svg/graphics/SVGResourceMasker.h:

2009-12-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Mask result wrong, if two different objects call the same mask id
​https://bugs.webkit.org/show_bug.cgi?id=32787

Two rects with different sizes and positions call the same mask id. Both
rects should be masked to two circles, dependent on the properties of the
rects.

  • platform/mac/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.png: Added.
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • svg/custom/mask-on-multiple-objects.svg: Added.
6:38 AM Changeset in webkit [52579] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2009-12-27 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup RenderPath code, related to markers. Pass around
PaintInfo objects instead of GraphicsContext directly, to
avoid having to recreate a new PaintInfo object in
SVGResourceMarker::draw().

No layout test changes.

5:27 AM Changeset in webkit [52578] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] DRT sideeffect (authentication)
​https://bugs.webkit.org/show_bug.cgi?id=32961

  • platform/qt/Skipped: http/tests/xmlhttprequest/failed-auth.html added temorarily (until fix).
5:15 AM Changeset in webkit [52577] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <​robert@roberthogan.net> on 2009-12-27
Remove successful tests from qt skipped list

​https://bugs.webkit.org/show_bug.cgi?id=32948

  • platform/qt/Skipped:
2:48 AM QtBackLog edited by zecke@selfish.org
Add OProfile JIT agent to the list of things to do (diff)
1:42 AM Changeset in webkit [52576] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <​robert@roberthogan.net> on 2009-12-27
Remove duplicate entries from Qt skipped list

​https://bugs.webkit.org/show_bug.cgi?id=32947

  • platform/qt/Skipped:
1:11 AM Changeset in webkit [52575] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-27 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

check-webkit-style should not mark moc files inclusion as errors
​https://bugs.webkit.org/show_bug.cgi?id=32669

Add a new header type for moc files, and skip them when checking the order of header files.

  • Scripts/modules/cpp_style.py:
12:55 AM Changeset in webkit [52574] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-27 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

WinCE buildfix (added missing header)

  • platform/text/wince/TextBreakIteratorWince.cpp:
12:47 AM Changeset in webkit [52573] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-27 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Buildfix after r50760 and some style fixes.

  • rendering/RenderThemeWince.cpp: (WebCore::RenderThemeWince::paintSearchFieldCancelButton): (WebCore::RenderThemeWince::paintSliderTrack): (WebCore::RenderThemeWince::paintSliderThumb): (WebCore::RenderThemeWince::paintMediaMuteButton): (WebCore::RenderThemeWince::paintMediaPlayButton):
12:39 AM Changeset in webkit [52572] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-27 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Barth.

WinCE buildfixes (missing headers and unsupported HWND_MESSAGE)

  • platform/wince/MIMETypeRegistryWince.cpp:
  • platform/wince/SearchPopupMenuWince.cpp:
  • platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
12:32 AM Changeset in webkit [52571] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-27 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Barth.

WinCE buildfix (HWND_MESSAGE isn't supported there)

  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
12:24 AM Changeset in webkit [52570] by eric@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2009-12-27 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Barth.

Added a file with WinMain function to link agains in WinCE.

  • os-win32/WinMain.cpp: Added. (convertToUtf8): (WinMain):

Dec 26, 2009:

11:36 PM Changeset in webkit [52569] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-26 Eric Seidel <​eric@webkit.org>

No review, rolling out r52554.
​http://trac.webkit.org/changeset/52554

​https://bugs.webkit.org/show_bug.cgi?id=32955
The original change was covered under
​https://bugs.webkit.org/show_bug.cgi?id=32913

r52554 was itself a rollout of r52536.
However it caused two layout tests to fail on Leopard:
storage/open-database-while-transaction-in-progress.html
svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)

So I'm rolling out the rollout in an attempt to get the bots green.
r52554 did not explain why it was rolled out, so I do not know
what might fail for Chromium after this change. I warned the folks
in #chromium that it was coming.

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
10:50 PM Changeset in webkit [52568] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make the qt build go fast
​https://bugs.webkit.org/show_bug.cgi?id=32951

Make use of multiple cores, if available.

  • Scripts/modules/webkitport.py:
7:35 PM QtBackLog edited by zecke@selfish.org
(diff)
5:28 PM Changeset in webkit [52567] by mitz@apple.com
  • 2 edits in trunk

Added Radar URLs

5:27 PM Changeset in webkit [52566] by mitz@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r47255): Extra Large Amount of Empty Space
​https://bugs.webkit.org/show_bug.cgi?id=32690

Reviewed by Sam Weinig.

WebCore:

Test: fast/block/float/clear-to-fit.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.

LayoutTests:

  • fast/block/float/clear-to-fit-expected.checksum: Added.
  • fast/block/float/clear-to-fit-expected.png: Added.
  • fast/block/float/clear-to-fit-expected.txt: Added.
  • fast/block/float/clear-to-fit.html: Added.
1:40 AM Changeset in webkit [52565] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Skipping some flakey tests.
​https://bugs.webkit.org/show_bug.cgi?id=32946

  • platform/qt/Skipped:
    • http/tests/cookies/simple-cookies-expired.html added.
    • storage/database-lock-after-reload.html added.
    • storage/empty-statement.html added.
    • storage/execute-sql-args.html added.
    • storage/hash-change-with-xhr.html added.

Dec 25, 2009:

9:26 PM Changeset in webkit [52564] by tkent@chromium.org
  • 7 edits
    5 adds in trunk

2009-12-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
​https://bugs.webkit.org/show_bug.cgi?id=32936

<section> should behave the same as <nav>.

Test: fast/html/section-element.html

  • css/html.css: Add section as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add sectionTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag. (WebCore::blockTagList): Add sectionTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add sectionTag.
  • html/HTMLTagNames.in: Add section.

2009-12-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Implement HTML5 section element.
​https://bugs.webkit.org/show_bug.cgi?id=32936

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/script-tests/TEMPLATE.html: Added.
  • fast/html/script-tests/section-element.js: Added.
  • fast/html/section-element-expected.txt: Added.
  • fast/html/section-element.html: Added.
8:34 PM Changeset in webkit [52563] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
3:58 PM Changeset in webkit [52562] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-25 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32682

Fixes an issue where checkFrameworks always dies with an error under Windows
since the clause "unless (-x $path)" is always satisfied because files under
Windows do not have an explict executable bit.

  • Scripts/webkitdirs.pm:
3:32 PM Changeset in webkit [52561] by dbates@webkit.org
  • 3 edits in trunk/WebCore

2009-12-25 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=32938

Cleans up XSSAuditor.

Currently, we pass various parameters through to XSSAuditor::findInRequest
that are used to determine how to decode the HTTP input parameters so that
we can perform a match against the script source. Instead, we have defined
a structure XSSAuditor::FindTask that can hold all of these parameters.

No functionality was changed. So, no new tests.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): Modified to use struct XSSAuditor::FindTask. (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto. (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto. (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::findInRequest): Ditto.
  • page/XSSAuditor.h: (WebCore::XSSAuditor::FindTask::FindTask): Added.
3:11 PM Changeset in webkit [52560] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.

​https://bugs.webkit.org/show_bug.cgi?id=32941

  • platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
  • platform/qt/fast/js/global-constructors-expected.txt: updated.
3:08 PM BuildingGtk edited by jgeboski@gmail.com
(diff)
1:03 PM Changeset in webkit [52559] by Nikolas Zimmermann
  • 11 edits
    3 adds in trunk

2009-12-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

DOMWindow is missing lots of SVG* constructor objects
​https://bugs.webkit.org/show_bug.cgi?id=20430

Expose all implemented SVG 1.1 constructors.

Test: svg/custom/global-constructors.js

  • bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
  • bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
  • page/DOMWindow.idl: Add a bunch of new SVG object ctors.
  • svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
  • svg/SVGAnimatedPoints.idl: Ditto.
6:58 AM Changeset in webkit [52558] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-12-25 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

AuditsPanel for Web Inspector (hidden, no preset audits).

​https://bugs.webkit.org/show_bug.cgi?id=31665

6:37 AM Changeset in webkit [52557] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.

  • platform/qt/Skipped: inspector/settings-set-get.html removed.
6:24 AM Changeset in webkit [52556] by pfeldman@chromium.org
  • 15 edits in trunk/WebCore

2009-12-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Edit Inner HTML action.

​https://bugs.webkit.org/show_bug.cgi?id=32924

  • English.lproj/localizedStrings.js:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): ():
  • inspector/front-end/InjectedScript.js: (InjectedScript.getNodePropertyValue): (InjectedScript.setOuterHTML): (InjectedScript.performSearch.addNodesToResults): (InjectedScript._inspectObject): (InjectedScript._copy): (InjectedScript.pushNodeToFrontend):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels): (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.startEditing.keyDownEventListener): (WebInspector.startEditing):

Dec 24, 2009:

11:23 PM BuildingGtk edited by dbates@webkit.org
Added notice about required libsoup >= 2.28.2 due to change-set 52208 (diff)
10:07 PM Changeset in webkit [52555] by mitz@apple.com
  • 2 edits in trunk/WebCore

Web Inspector: Console should force long URLs to wrap
​https://bugs.webkit.org/show_bug.cgi?id=32927

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Added "word-wrap: break-word;" to

the #console-messages rule.

7:25 PM Changeset in webkit [52554] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2009-12-24 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed Chromium test fix by reverting r52536.

Do not a new Database pointer to any structure until its version has been verified
​https://bugs.webkit.org/show_bug.cgi?id=32913

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
5:15 PM Changeset in webkit [52553] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-24 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

Remove LayoutTests/storage/change-version.html from Qt Skipped list


LayoutTests/storage/change-version.html now passes.
Probably related to the fix in ​https://bugs.webkit.org/show_bug.cgi?id=32437.


​https://bugs.webkit.org/show_bug.cgi?id=32917

  • platform/qt/Skipped:
11:41 AM Changeset in webkit [52552] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

Reviewed by Gustavo Noronha.

Doc : QGraphicsWebView::zoomFactor was introduced in 4.6.

9:34 AM Changeset in webkit [52551] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2009-12-24 Laszlo Gombos <Laszlo Gombos>

Unreviewed; revert of r52550.

The change regressed the following LayoutTests for QtWebKit.

fast/workers/worker-call.html -> crashed
fast/workers/worker-close.html -> crashed

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
9:03 AM Changeset in webkit [52550] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-24 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix memory leak by deleting instance of ThreadPrivate
in function waitForThreadCompletion(), synchronously, or in
detachThread(), asynchronously.
​https://bugs.webkit.org/show_bug.cgi?id=32614

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): (WTF::detachThread):
6:12 AM Changeset in webkit [52549] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-24
[Qt] Skip failing test until a solution for layoutTestController.notifyDone() is found.
​https://bugs.webkit.org/show_bug.cgi?id=31626

  • platform/qt/Skipped: inspector/console-clear.html skipped
5:46 AM Changeset in webkit [52548] by jberlin@webkit.org
  • 7 edits
    7 adds in trunk

Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
should not show cut off text
​https://bugs.webkit.org/show_bug.cgi?id=29968


Reviewed by Dan Bernstein.

Also fixes the issue on both Mac OS X and Windows where the highlight
would extend only partway into the ellipsis based on the size of the
characters being truncated.

Test: editing/selection/select-text-overflow-ellipsis.html

WebCore:

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): When the ellipsis have been selected, paints them with the color for selected text. (WebCore::EllipsisBox::selectionRect): Returns the selection rect for the ellipsis text. (WebCore::EllipsisBox::paintSelection): Paints the selection highlight around the ellipsis text.
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): Default the selection state of the EllipsisBox to SelectionNone. (WebCore::EllipsisBox::setSelectionState): Allow the selection state to be explicitly set by the InlineTextBox that it is associated with, since the selection state depends on the position of the selection within the truncated text. (WebCore::EllipsisBox::selectionState): Return the cached selection state.


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): If the text is truncated and the selection extends into the truncation where there are ellipsis, set the selection state on the EllipsisBox. (WebCore::paintTextWithShadows): Allow for an upper bound to be specified on the maximum length of the text to be painted. (WebCore::InlineTextBox::paint): Make sure the text that is drawn gets appropriately truncated. This was not an issue before on Mac OS X because it wasn't necessary to draw the selected text separately (the selected text had the same color as the non-selected text). (WebCore::InlineTextBox::paintSelection): If the text is being truncated, let whatever is being painted in the space after the truncated text paint its own highlight.


  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::truncation): Allow RenderText to access the truncation status.


  • rendering/RenderText.cpp: (WebCore::RenderText::selectionRectForRepaint): Make sure that any ellipsis box that falls within the selection also gets repainted.


Places the expected results under the mac and win platforms separately
because they are pixel test results and also the size of the
RenderBlocks are showing up as slightly different between mac and win.

LayoutTests:

  • editing/selection/select-text-overflow-ellipsis.html: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
4:33 AM Changeset in webkit [52547] by pfeldman@chromium.org
  • 24 edits
    1 add
    2 deletes in trunk

2009-12-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add Settings.js class that would manage
frontend settings.

This change:

  • Splits preferences and settings
  • Pushes settings to the frontend on load
  • Stores settings on each change
  • Stores showInheritedStyles as setting.

​https://bugs.webkit.org/show_bug.cgi?id=32832

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveFrontendSettings):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateFrontendSettings):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.saveFrontendSettings): (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub): (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._setLargerResources):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  • inspector/front-end/Settings.js: Added. (WebInspector.populateFrontendSettings): (WebInspector.Settings): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._installSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
3:12 AM Changeset in webkit [52546] by pfeldman@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-12-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r52545, adding missing tests.

  • inspector/console-clear-expected.txt: Added.
  • inspector/console-clear.html: Added.
3:05 AM Changeset in webkit [52545] by pfeldman@chromium.org
  • 15 edits in trunk

2009-12-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] console's clear command does not work.

​https://bugs.webkit.org/show_bug.cgi?id=32897

Test: inspector/console-clear.html

WebCore:

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::clearConsoleMessages):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.requestClearConsoleMessages): (WebInspector.ConsoleView.prototype.clearConsoleMessages): (WebInspector.ConsoleView.prototype._clearButtonClicked):
  • inspector/front-end/InjectedScript.js: (InjectedScript.clearConsoleMessages): (InjectedScript._ensureCommandLineAPIInstalled):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/inspector.js: (WebInspector.clearConsoleMessages): (WebInspector.reset):

LayoutTests:

  • inspector/console-clear-expected.txt: Added.
  • inspector/console-clear.html: Added.
  • inspector/console-tests.js: (dumpConsoleMessages.callback): (dumpConsoleMessages):
2:38 AM Changeset in webkit [52544] by pfeldman@chromium.org
  • 10 edits in trunk

2009-12-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console dumps strings in escaped form.

​https://bugs.webkit.org/show_bug.cgi?id=32488

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatIndividualValue):
  • inspector/console-format-expected.txt:
Note: See TracTimeline for information about the timeline view.