Timeline
Feb 25, 2010:
- 11:40 PM Changeset in webkit [55270] by
-
- 2 edits in trunk/WebCore
<rdar://problem/7688455> REGRESSION(r55205): Crash inside dispatchEventsOnWindowAndFocusedNode when clicking link from bookmarks view
Reviewed by Brady Eidson.
Null-check the document's page to avoid dereferencing a null page.
No regression test is added as this appears to be dependent on an interaction with Safari's bookmarks view that is
not testable from within DumpRenderTree.
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
- 10:49 PM Changeset in webkit [55269] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-25 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Remove deprecated cookie methods.
https://bugs.webkit.org/show_bug.cgi?id=35420
- public/WebFrameClient.h:
- public/WebKitClient.h:
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled):
- 8:56 PM QtWebKitMediaElementSupport edited by
- Added information about QtMultimedia Integration (diff)
- 5:32 PM Changeset in webkit [55268] by
-
- 4 edits1 add in trunk/WebKitTools
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a 'passing' port implementation to new-run-webkit-tests that
acts as a wrapper around an existing implementation but stubs out
the actual test invocations (instead, the expected results are echoed
back to the harness). This is useful for coverage and perf testing
of the harness (especially perf testing as it essentially provides
a lower bound on how fast the harness can run).
Also added a --nostart-helper flag to new-run-webkit-tests so that
you can skip starting the layout_test_helper and actually run the
harness even if you don't have a build of that port.
Also fix a bug in the 'test' port implementation to actually
create the results directory under /tmp instead of /.
- Scripts/webkitpy/layout_tests/port/factory.py: Modified.
- Scripts/webkitpy/layout_tests/port/passing.py: Added.
- Scripts/webkitpy/layout_tests/port/test.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
- 5:14 PM Changeset in webkit [55267] by
-
- 2 edits in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Fix typo in my last change. No review.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests:
- 5:06 PM Changeset in webkit [55266] by
-
- 3 edits in trunk/WebCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Multiple repaints on apple.com
https://bugs.webkit.org/show_bug.cgi?id=35409
apple.com was triggering the fast scaling path for background images due to
repeated repaints as more content came in. This occured due to a two problems
in the logic to detect scaling. The first is that the main context is flipped
on mac so fails the identity or translation check. We work around this by adding
an function that allows the scaling for a flipped CTM. The other problem was that
we were looking at the destination rect size instead of the destination tile size
when deciding if the size we were drawn at would cause scaling.
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslationOrFlipped):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 4:55 PM Changeset in webkit [55265] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-25 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Test whether or not we preserve the hash fragments for "about:blank"
URLs. (Note that currently WebKit passes this but Chromium doesn't).
- fast/loader/about-blank-hash-kept-expected.txt: Added.
- fast/loader/about-blank-hash-kept.html: Added.
- 4:49 PM Changeset in webkit [55264] by
-
- 1 edit2 moves in trunk/WebKitTools
2010-02-25 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
https://bugs.webkit.org/show_bug.cgi?id=35408
- Scripts/new-run-webkit-tests: Added.
- Scripts/run-chromium-webkit-tests: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
- 4:43 PM Changeset in webkit [55263] by
-
- 20 edits2 adds6 deletes in trunk
Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand).
https://bugs.webkit.org/show_bug.cgi?id=30946
<rdar://problem/7639184>
Reviewed by Adele Peterson.
WebCore:
Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
This patch was originally made by Justin Garcia.
Test: editing/inserting/rebalance-whitespace-1.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
just pushed the code that determined the extent of whitespace surrounding a position
to its own helper function.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added. Find
whitespace surrounding the insertion position, add the text to insert, rebalance that entire
string, then insert it into the document.
(WebCore::InsertTextCommand::input):
- editing/InsertTextCommand.h:
- editing/htmlediting.cpp:
(WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
(WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
function. Obtains the offset of the start and end of whitespace around a particular position.
- editing/htmlediting.h:
LayoutTests:
There are now regular spaces where nbsps were used unnecessarily before. Also,
multi-character insertions now have their whitespace rebalanced, and this is
reflected in a few tests.
- editing/execCommand/5142012-3-expected.txt:
- editing/inserting/rebalance-whitespace-1-expected.txt: Added.
- editing/inserting/rebalance-whitespace-1.html: Added.
- editing/pasteboard/5521237-expected.txt:
- platform/mac/editing/execCommand/5482023-expected.checksum:
- platform/mac/editing/execCommand/5482023-expected.png: Removed.
- platform/mac/editing/execCommand/5482023-expected.txt:
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum:
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt:
- platform/mac/editing/inserting/editable-html-element-expected.checksum:
- platform/mac/editing/inserting/editable-html-element-expected.png: Removed.
- platform/mac/editing/inserting/editable-html-element-expected.txt:
- platform/mac/editing/pasteboard/4989774-expected.checksum:
- platform/mac/editing/pasteboard/4989774-expected.png: Removed.
- platform/mac/editing/pasteboard/4989774-expected.txt:
- platform/mac/editing/selection/4983858-expected.checksum:
- platform/mac/editing/selection/4983858-expected.png: Removed.
- platform/mac/editing/selection/4983858-expected.txt:
- 4:22 PM Changeset in webkit [55262] by
-
- 10 edits2 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35406
<rdar://problem/6945502> Make generic array methods work with JavaArray
Test: java/array-sort.html
Made RuntimeArray inherit from JSArray, keeping the promise given in ClassInfo.
- bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray): (JSC::RuntimeArray::~RuntimeArray):
- bridge/runtime_array.h: (JSC::RuntimeArray::classInfo): (JSC::RuntimeArray::getConcreteArray):
- 3:21 PM Changeset in webkit [55261] by
-
- 2 edits in trunk/WebCore
Fixed a regression introduced in r44243, which made the assertion in checkListItems()
ineffective.
Reviewed by Alexey Proskuryakov.
- dom/SelectElement.cpp:
(WebCore::SelectElementData::checkListItems): Copy the items vector before recomputing it,
then assert that the newly-computed vector is equal to the copy.
- 3:04 PM Changeset in webkit [55260] by
-
- 8 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
This makes the base class RenderSVGInline of RenderSVGTSpan and RenderSVGInlineText
dependent on SVGBaseRenderer.
The SVG spec want as to use the object bounding box of the text root as the bounding box
for text-childs. So we search for the text root and use it's bounding box, stroke rect and
repaint rect for further calculations.
Test: svg/filters/filter-on-tspan.svg
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): Find the text root and give back it's bounding box. (WebCore::RenderSVGInline::strokeBoundingBox): same for stroke rect (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): same for repaint rect
- rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::toSVGRenderBase): RenderSVGInline is part of SVGRenderBase now.
- rendering/RenderSVGTSpan.h: (WebCore::RenderSVGTSpan::renderName): Removed bounding box code. Was just a hack for filters and maskers.
- rendering/SVGRenderSupport.cpp: (WebCore::findTextRootObject): Search for the text root.
- rendering/SVGRenderSupport.h:
- svg/graphics/SVGPaintServerGradient.cpp: moved findTextRootObject to SVGRenderSupport
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
https://bugs.webkit.org/show_bug.cgi?id=35354
Check if filters work for tspan according to the SVG Spec. The test shouldn't
throw an assert now and a green rect should be visible.
- platform/mac/svg/filters/filter-on-tspan-expected.checksum: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.png: Added.
- platform/mac/svg/filters/filter-on-tspan-expected.txt: Added.
- svg/filters/filter-on-tspan.svg: Added.
- 3:02 PM Changeset in webkit [55259] by
-
- 4 edits4 adds in trunk
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
If the use element is a child of clipPath, any settings on x, y or transform does not
transform the clipPath it references.
The use-element just misses this transformation in toClipPath.
Test: svg/custom/use-on-clip-path-with-transformation.svg
- platform/graphics/cairo/PathCairo.cpp: Gtk port translated the path to the wrong direction. (WebCore::Path::translate):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
2010-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use-element doesn't transform clipPath
https://bugs.webkit.org/show_bug.cgi?id=35375
Check if the clipPath gets transformed on setting a transform or translation for use.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
- platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
- svg/custom/use-on-clip-path-with-transformation.svg: Added.
- 2:52 PM Changeset in webkit [55258] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
JSC crashes like crazy in the JSPropertyNameIterator destructor
Add back null check of m_cachedStructure. Curse last minute changes.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
- 2:30 PM Changeset in webkit [55257] by
-
- 7 edits in trunk
File.type support.
https://bugs.webkit.org/show_bug.cgi?id=35361
Reviewed by Dmitry Titov.
WebCore:
Test: LayoutTests/editing/pasteboard/file-input-files-access.html
- html/File.cpp:
(WebCore::File::File):
- html/File.h:
(WebCore::File::type):
- html/File.idl:
LayoutTests:
Update the layout test to test File.type.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/script-tests/file-input-files-access.js:
(fileListShouldBe):
(runTest):
- 2:15 PM Changeset in webkit [55256] by
-
- 7 edits in trunk
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
JSPropertyNameIterator and Structure have a cyclic dependency that they
manage by clearing the appropriate reference in each other during their
destruction. However if the Structure is destroyed while the
JSPropertyNameIterator is dead but not yet finalized the Structures
WeakGCPtr will return null, and so prevent Structure from clearing
the m_cachedStructure pointer of the iterator. When the iterator is
then finalised the m_cachedStructure is invalid, and the attempt to
clear the structures back reference fails.
To fix this we simply make JSPropertyNameIterator keep the Structure
alive, using the weak pointer to break the ref cycle.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::~JSPropertyNameIterator): The iterator now keeps m_cachedStructure alive itself, so no longer needs to check for it being cleared
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::setCachedStructure): Add an assertion to ensure correct usage (JSC::JSPropertyNameIterator::cachedStructure): Add .get()
- runtime/Structure.cpp: (JSC::Structure::~Structure): Add an assertion that our iterator isn't already dead, and remove the now unnecessary attempt to clear the ref in the iterator
- runtime/WeakGCPtr.h: (JSC::WeakGCPtr::hasDeadObject): An assert-only function to allow us to assert correct behaviour in the Structure destructor
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
Add test to ensure that this race condition doesn't occur.
- fast/js/script-tests/for-in-cached.js: (cacheClearing):
- 2:14 PM Changeset in webkit [55255] by
-
- 2 edits in trunk/WebCore
2010-02-25 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Javascript console should not attempt to scroll to end of console if console is not visible
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype.addMessage):
- 1:56 PM Changeset in webkit [55254] by
-
- 2 edits2 adds in trunk/WebKit/chromium
2010-02-25 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebLabelElement.
- WebKit.gyp:
- public/WebLabelElement.h: Added.
- src/WebLabelElement.cpp: Added.
- 1:04 PM Changeset in webkit [55253] by
-
- 3 edits in trunk/WebCore
Qt and Gtk build fixes.
- GNUmakefile.am:
- WebCore.pro: Added CRuntimeObject.{c,cpp}.
- 1:00 PM Changeset in webkit [55252] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- WebCore.vcproj/WebCore.vcproj: Added CRuntimeObject.{c,cpp}.
- 12:56 PM Changeset in webkit [55251] by
-
- 2 edits in trunk/LayoutTests
Tiger build fix.
- java/Makefile: I can't get $(or ...) work on Tiger, so changed to use a single condition.
- 12:23 PM Changeset in webkit [55250] by
-
- 33 edits10 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35394
<rdar://problem/7685262> Make passing objects between Java and plug-ins work
- WebCore.PluginHostProcess.exp: WebKit now subclasses RuntimeObject, so it needed more exports.
- bridge/runtime_object.cpp: (JSC::Bindings::callRuntimeObject): (JSC::Bindings::callRuntimeConstructor): Assert that a runtime object is passed as function.
- bridge/runtime_object.h: Moved RuntimeObject into Bindings namespace, matching other related classes.
- bridge/jni/jni_jsobject.mm: (JavaJSObject::toString): Pass rootObject to convertValueToJValue(). It's not needed when constructing a string, but this function now takes it for the sake of Object. (JavaJSObject::convertValueToJObject): Check that object class is JavaRuntimeObject, not just RuntimeObject.
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::setValueToInstance): Pass rootObject to convertValueToJValue(). (JavaArray::setValueAt): Ditto.
- bridge/jni/jsc/JNIUtilityPrivate.h: convertValueToJValue() now takes a RootObject argument, because one is needed to gcProtect an object ghtat is wrapped into JSObject.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Convert JavaScript objects to Java JSObject ones. This was already happening in other code paths, which we should change to use common code.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::newRuntimeObject): Create an appropriate RuntimeObject subclass, which is JavaRuntimeObject for Java. (JavaInstance::invokeMethod): Unwrap returned JavaObjects that contain JS objects.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/c/CRuntimeObject.cpp: Added. (JSC::Bindings::CRuntimeObject::CRuntimeObject): (JSC::Bindings::CRuntimeObject::~CRuntimeObject): (JSC::Bindings::CRuntimeObject::getInternalCInstance):
- bridge/c/CRuntimeObject.h: Added. (JSC::Bindings::CRuntimeObject::classInfo):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::newRuntimeObject):
- bridge/c/c_instance.h:
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/jsc/JavaRuntimeObject.cpp: Added. (JSC::Bindings::): (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::~JavaRuntimeObject): (JSC::Bindings::JavaRuntimeObject::getInternalJavaInstance):
- bridge/jni/jsc/JavaRuntimeObject.h: Added. (JSC::Bindings::JavaRuntimeObject::classInfo):
- bridge/jsc/BridgeJSC.h:
- bridge/objc/ObjCRuntimeObject.h: Added. (JSC::Bindings::ObjCRuntimeObject::classInfo):
- bridge/objc/ObjCRuntimeObject.mm: Added. (JSC::Bindings::): (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::~ObjCRuntimeObject): (JSC::Bindings::ObjCRuntimeObject::getInternalObjCInstance):
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm: (ObjcInstance::newRuntimeObject):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_root.h: Added RuntimeObject subclasses for each instance type, and use them for type casting.
- 10:57 AM Changeset in webkit [55249] by
-
- 20 edits in trunk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Adopt the same string as the one that is expected by
fast/parser/fragment-parser.html for the description used by the
<isindex> element.
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::searchableIndexIntroduction):
- 10:46 AM Changeset in webkit [55248] by
-
- 12 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: evaluate-on-hover does not work on HTML files.
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.get subTokenizer): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._highlightLine):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
- 10:27 AM Changeset in webkit [55247] by
-
- 5 edits in trunk/JavaScriptCore
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
Patch by Jochen Eisinger <jochen@chromium.org> on 2010-02-25
Reviewed by Jeremy Orlow.
When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemChromium*.cpp
This patch will allow you to get from anywhere within webkit a pointer
to the Thread object that actually created the thread you're currently
on (in case of the database, this can be either a thread forked of
from the main thread or from a worker thread), and query the object
for context information.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::threadContext):
- wtf/ThreadingPthreads.cpp:
(WTF::):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
(WTF::threadContext):
- wtf/ThreadingWin.cpp:
(WTF::):
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::threadContext):
- 10:20 AM Changeset in webkit [55246] by
-
- 5 edits in trunk/JavaScriptCore
Reverting to re-submit with better change log.
- wtf/Threading.h:
- wtf/ThreadingNone.cpp:
(WTF::isMainThread):
- wtf/ThreadingPthreads.cpp:
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
- wtf/ThreadingWin.cpp:
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::createThreadInternal):
- 10:18 AM Changeset in webkit [55245] by
-
- 3 edits in trunk/WebKit/gtk
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Gtk] crashed when destroying
https://bugs.webkit.org/show_bug.cgi?id=31271
NULL-check the page before relaying the focus out event, since
this might happen when destroying the widget without destroying
its parent, and we currently crash.
- tests/testwebview.c: (delayed_destroy): (test_webkit_web_view_destroy): (main):
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event):
- 10:16 AM Changeset in webkit [55244] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Simple style cleanups.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugRemovedCallback): (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 10:16 AM Changeset in webkit [55243] by
-
- 3 edits in trunk/WebKitTools
2010-02-25 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
EWS leaks memory slowly
https://bugs.webkit.org/show_bug.cgi?id=35395
The EWS bots leak memory very slowly. If you run them for about a
month, each one will take up around 1 GB of virutal memory. If you run
several of them on one machine, you'll eventually exhaust all available
memory and grind the bots to a halt.
This patch introduces a --exit-after-iteration option to the queues so
that we run them for a finite amount of time. Once they exit and
restart, they'll reclaim the leaked memory. I'm not sure how many
iterations I'll end up running them for. I'll need to sort that out
operationally, but my initial guess is around 1000.
- Scripts/webkitpy/commands/queues.py:
- Scripts/webkitpy/commands/queues_unittest.py:
- 10:13 AM Changeset in webkit [55242] by
-
- 2 edits in trunk/WebCore
2010-02-25 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Darin Adler.
Optimize decoding of Latin-1 text by exploiting the fact that most of it will
be ASCII-only data.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
- 9:55 AM Changeset in webkit [55241] by
-
- 6 edits in trunk
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
Web Inspector: make script lines count calculation lazy.
- inspector/front-end/Script.js: (WebInspector.Script): (WebInspector.Script.prototype.get linesCount):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- 9:20 AM Changeset in webkit [55240] by
-
- 5 edits in trunk/WebCore
Change hardcoded gcc paths to be Solaris friendly
https://bugs.webkit.org/show_bug.cgi?id=35213
Patch by James Choi <jchoi42@pha.jhu.edu> on 2010-02-25
Reviewed by David Levin.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/IDLParser.pm:
- css/make-css-file-arrays.pl:
- dom/make_names.pl:
- 9:13 AM Changeset in webkit [55239] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-24 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add a missing WebString.h include.
https://bugs.webkit.org/show_bug.cgi?id=35360
This is required since some of the methods have implementations that
return a WebString.
- public/WebCookieJar.h:
- 9:04 AM Changeset in webkit [55238] by
-
- 2 edits in trunk/WebCore
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Workaround Java plugins not drawing themselves properly on first
expose by doing a late size-allocate after 'plug-added' has been
emitted on the embedding GtkSocket. It's unclear to me if this is
a bug in our side or theirs, but this should be pretty safe and
fixes the annoyance while we investigate it further.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::plugAddedCallback): (WebCore::PluginView::platformStart):
- 8:05 AM Changeset in webkit [55237] by
-
- 3 edits in trunk/WebCore
Add missing include guards
Reviewed by Tor Arne Vestbø.
- loader/CrossOriginPreflightResultCache.h:
- loader/MainResourceLoader.h:
- 8:04 AM Changeset in webkit [55236] by
-
- 2 edits in trunk/WebCore
[Qt] Restrict the optimization flags for Symbian to release builds.
Reviewed by Tor Arne Vestbø.
- WebCore.pro:
- 7:06 AM Changeset in webkit [55235] by
-
- 9 edits1 add in trunk
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds GraphicsContext3D QtWebKit implementation.
https://bugs.webkit.org/show_bug.cgi?id=35153
- WebCore.pri:
- WebCore.pro:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp: Added. (WebCore::GraphicsContext3DInternal::isValid): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getProcAddress): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds enabling and disabling of WebGL support to QWebSettings.
https://bugs.webkit.org/show_bug.cgi?id=35153
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>
Reviewed by Kenneth Rohde Christiansen.
Qt WebGL support
Adds toggling of WebGL support to QtLauncher.
https://bugs.webkit.org/show_bug.cgi?id=35153
- QtLauncher/main.cpp: (LauncherWindow::toggleWebGL): (LauncherWindow::setupUI):
- 6:52 AM BuildingQtOnSymbian edited by
- (diff)
- 6:50 AM BuildingQtOnSymbian edited by
- (diff)
- 6:49 AM Changeset in webkit [55234] by
-
- 5 edits in trunk/JavaScriptCore
2010-02-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
- wtf/Threading.h:
- wtf/ThreadingNone.cpp: (WTF::threadContext):
- wtf/ThreadingPthreads.cpp: (WTF::): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::currentThread): (WTF::threadContext):
- wtf/ThreadingWin.cpp: (WTF::): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::contextForIdentifier): (WTF::createThreadInternal): (WTF::threadContext):
- 6:34 AM Changeset in webkit [55233] by
-
- 4 edits2 moves in trunk/WebCore
2010-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Swap images for activate and deactivate breakpoints.
- WebCore.gypi:
- inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png.
- inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 6:19 AM Changeset in webkit [55232] by
-
- 2 edits in trunk/WebCore
2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Go back on symlink resolution if we are loading the flash plugin,
and the path contains /netscape/, following what Chromium does.
Thanks to Evan Martin for the help on this!
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- 5:45 AM Changeset in webkit [55231] by
-
- 8 edits in trunk/WebCore
2010-02-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh.
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.canShowSourceLine): (WebInspector.Panel.prototype.showSourceLine):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
- inspector/front-end/Script.js: (WebInspector.Script):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.get searchableViews): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine): (WebInspector.ScriptsPanel.prototype.showView): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector._choosePanelToShowSourceLine): (WebInspector.canShowSourceLine): (WebInspector.showSourceLine):
- 5:24 AM Changeset in webkit [55230] by
-
- 10 edits3 adds in trunk
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- fast/events/touch/basic-single-touch-events-expected.txt: Update expected target element.
- fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
- fast/events/touch/script-tests/touch-target.js: Added.
- fast/events/touch/touch-target-expected.txt: Added.
- fast/events/touch/touch-target.html: Added.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
Currently the target of a touch is set to the resulting node of the hit test where the touch currently
is. This does not match the behavior of iPhone or Android. This patch uses a hashmap on the EventHandler
to keep track of the target element when a touch is first started. This target is then used as the target
for subsequent touches with the same id. This matches observed behavior on iPhone and Android.
Tests:
fast/events/touch/touch-target.html: Added.
fast/events/touch/basic-single-touch-events.html: Updated.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Store the originating target element of a touch in a hashmap
so that we can reuse that target for future events caused by that touch. This matches observed behavior
on iPhone and Android.
- page/EventHandler.h: Add hashmap as a member.
- platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::id): Store the touch point id as unsigned.
- platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Cast platform touch id from signed to unsigned. Qt API
docs state that it will always be >= 0.
2010-02-25 Ben Murdoch <benm@google.com>
Reviewed by Kenneth Rohde Christiansen.
The target element of a Touch should be the target where that touch originated, not where it is now.
https://bugs.webkit.org/show_bug.cgi?id=34585
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
- 4:49 AM Changeset in webkit [55229] by
-
- 2 edits in trunk/LayoutTests
2010-02-25 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unskip a bunch of (AFAICT) non-flakey HTTP tests that we currently
pass.
- platform/gtk/Skipped:
- 3:48 AM Changeset in webkit [55228] by
-
- 2 edits in trunk/WebCore
Add a convenient center() method to IntRect
https://bugs.webkit.org/show_bug.cgi?id=35346
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
As it is a convenience method, and implemention is
based on FloatRect's one, patch does not provide a
layout test.
- platform/graphics/IntRect.h:
(WebCore::IntRect::center):
- 3:24 AM Changeset in webkit [55227] by
-
- 11 edits1 add in trunk/WebCore
2010-02-25 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Fake workers implementation that simulates workers using iframe and timer,
needed to support workers debugging. Also, a facility to inject scripts into
inspected page upon load.
https://bugs.webkit.org/show_bug.cgi?id=35148
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::addScriptToEvaluateOnLoad): (WebCore::InspectorBackend::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addScriptToEvaluateOnLoad): (WebCore::InspectorController::removeAllScriptsToEvaluateOnLoad):
- inspector/InspectorController.h:
- inspector/front-end/InjectedFakeWorker.js: Added. (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onmessageWrapper): (InjectedFakeWorker.FakeWorker.prototype._dispatchMessage): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.handler): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.URL): (InjectedFakeWorker.URL.prototype.urlRegEx.split): (InjectedFakeWorker.URL.prototype.mockLocation): (InjectedFakeWorker.URL.prototype.completeWith): (InjectedFakeWorker.URL.prototype.sameOrigin): (InjectedFakeWorker.DOMCoreException.formatError): (InjectedFakeWorker.DOMCoreException): (InjectedFakeWorker.noop):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource): (.WebInspector.InspectorBackendStub.prototype.addScriptToEvaluateOnLoad): (.WebInspector.InspectorBackendStub.prototype.removeAllScriptsToEvaluateOnLoad):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 2:04 AM BuildingQtOnWindows edited by
- (diff)
Feb 24, 2010:
- 11:30 PM Changeset in webkit [55226] by
-
- 5 edits in trunk
2010-02-24 Sam Kerner <skerner@chromium.org>
Reviewed by Darin Fisher.
Expose WebFrame::setCanHaveScrollbars(). This allows a view
which is being resized to not need scroll bars to ensure that
they are not drawn.
Existing function setAllowsScrolling() was renamed
setCanHaveScrollbars(), to be consistant with change 37159:
http://trac.webkit.org/changeset/37159
- WebKit/chromium/public/WebFrame.h:
- WebKit/chromium/src/ChromeClientImpl.cpp:
- WebKit/chromium/src/WebFrameImpl.cpp:
- WebKit/chromium/src/WebFrameImpl.h:
- 11:14 PM Changeset in webkit [55225] by
-
- 4 edits in trunk/WebCore
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Add mediaPlayerOwningDocument() to MediaPlayerClient.
https://bugs.webkit.org/show_bug.cgi?id=35374
No new tests. These are interface changes only.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Implementation for media element.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerOwningDocument): New virtual method.
- 10:56 PM Changeset in webkit [55224] by
-
- 2 edits in trunk/WebCore
2010-02-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Optimized Font::normalizeSpaces() by caching the String::characters()
instead of repeatedly calling operator[]
- platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
- 10:32 PM Changeset in webkit [55223] by
-
- 2 edits in trunk/WebCore
2010-02-24 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin.
[Chromium] Traditional Chinese Chrome on Windows should use PMingLiu instead of Simsun for Han characters
https://bugs.webkit.org/show_bug.cgi?id=35319
No visible change in the layout test.
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::):
- 10:28 PM Changeset in webkit [55222] by
-
- 4 edits in trunk/WebKit/gtk
2010-02-24 Krzysztof Kotlenga <pocek@users.sf.net>
Reviewed by Gustavo Noronha Silva.
[Gtk] Creation of a WebkitWebView widget is very slow
https://bugs.webkit.org/show_bug.cgi?id=30032
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts' to reflect the fact that the list just holds Enchant dictionaries now. (WebKit::EditorClient::learnWord): Ditto. (WebKit::EditorClient::checkSpellingOfString): Ditto. (WebKit::EditorClient::getGuessesForWord): Ditto.
- webkit/webkitprivate.h: Remove the now unused SpellLanguage struct.
- webkit/webkitwebsettings.cpp: Change function call to reflect new webkit_web_settings_get_enchant_dicts name. (get_enchant_broker): Add this method which returns the enchant broker singleton. (free_spell_checking_language): The list contents have changed, so change the way each element is freed. (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list' to 'enchant_dicts' member name change. (webkit_web_settings_set_property): Use the broker singleton here instead of making a new one for each language. The Enchant dictionary is now the list payload. (webkit_web_settings_copy): More name-change updates. (webkit_web_settings_get_enchant_dicts): Ditto.
- 10:15 PM Changeset in webkit [55221] by
-
- 2 edits in trunk/WebCore
2010-02-24 Anthony Ricaud <rik@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: Reduce the timer to show the eval popover
https://bugs.webkit.org/show_bug.cgi?id=35344
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove):
- 9:40 PM Changeset in webkit [55220] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-24 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Add test for SVG that used to cause crash.
It has been fixed on trunk for a while, thanks to the <use> rewrite,
but we want to make sure we do not regress.
- svg/dom/use-transform.svg: Added.
- svg/dom/use-transform-expected.txt: Added.
- 9:24 PM Changeset in webkit [55219] by
-
- 3 edits1 add in trunk
2010-02-24 Jay Campan <jcampan@google.com>
Reviewed by David Levin.
Don't show the autofill popup when the input text is disabled or read only.
Test: manual-tests/chromium/no-autofill-on-readonly.html
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
- manual-tests/chromium/no-autofill-on-readonly.html: Added.
2010-02-24 Jay Campan <jcampan@google.com>
Reviewed by David Levin.
Don't show the autofill popup when the input text is disabled or read only.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
- 9:07 PM Changeset in webkit [55218] by
-
- 2 edits in trunk/WebKitTools
2010-02-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher has a border when running on QGraphicsView mode
https://bugs.webkit.org/show_bug.cgi?id=35352
Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
- 8:43 PM Changeset in webkit [55217] by
-
- 8 edits in trunk/WebCore
2010-02-24 Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed by Jeremy Orlow.
Wraps includes of SVG headers so that it's possible to
compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
https://bugs.webkit.org/show_bug.cgi?id=35345
No new tests.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/custom/V8CSSValueCustom.cpp:
- bindings/v8/custom/V8DocumentCustom.cpp:
- bindings/v8/custom/V8ElementCustom.cpp:
- bindings/v8/custom/V8EventCustom.cpp:
- bindings/v8/custom/V8SVGElementCustom.cpp:
- 8:15 PM Changeset in webkit [55216] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
Fix gtk build.
Include JSC headers as runtime/ instead of JavaScriptCore/
- bindings/js/JSDOMWrapper.h:
- bindings/js/ScriptWrappable.h:
- 8:07 PM Changeset in webkit [55215] by
-
- 12 edits2 adds in trunk/WebCore
2010-02-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
7.4% speedup on Dromaeo DOM Core tests.
2.3% speedup on Hixie DOM Core tests.
This fixes the following things from the last attempt:
- Now builds in both debug and release and passes all tests
- Properly use a WeakGCPtr, not just a raw pointer, in ScriptWrappable
- Properly look in the appropriate per-document or per-world map
- Added an assert that would have caught any of the problems I found
- Handle clearing the inline cache properly in all cases
- bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMObjectWrapper): Adjust for name changes. (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
- bindings/js/JSDOMBinding.h: (WebCore::Document::getWrapperCache): Inlined. (WebCore::domObjectWrapperMapFor): Renamed to start with lowercase. Moved to header to inline.
- bindings/js/JSDOMWrapper.h: Added. (WebCore::DOMObject::DOMObject): Factored this out of JSDOMBinding.h to avoid include cycle. I think the class should be renamed, I picked a forward-looking header name because we already have a DOMObject.h
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
- bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved from JSDOMBinding.cpp and moved here, so it could inline everywhere without creating an include cycle. Consider inline cache. (WebCore::toJS): Moved to header to inline.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (Using a WeakGCPtr). (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
- dom/Node.idl: Add CustomHeader directive.
Add new files to build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 7:51 PM Changeset in webkit [55214] by
-
- 3 edits in trunk/WebCore
2010-02-24 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Expose Database object of currently active task on the database thread
https://bugs.webkit.org/show_bug.cgi?id=35341
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
- storage/DatabaseThread.h: (WebCore::DatabaseThread::getDatabaseOfCurrentTask):
- 7:34 PM Changeset in webkit [55213] by
-
- 4 edits in trunk/WebCore
2010-02-24 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
supportsMuting() should be an internal interface between MediaPlayer and MediaPlayerPrivate.
https://bugs.webkit.org/show_bug.cgi?id=35327
No new tests. Refactoring Only.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Do not check supportsMuting() (WebCore::HTMLMediaElement::updateVolume): Set volume and muted
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): Check supportsMuting() (WebCore::MediaPlayer::setMuted): Check supportsMuting()
- platform/graphics/MediaPlayer.h: Remove supportsMuting()
- 6:46 PM Changeset in webkit [55212] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
Keep this test’s behavior the same after r55203.
- fast/dom/script-tests/prototype-inheritance-2.js: Explicitly set the inner document’s body
display property to “none”. Before r55203, this happened as a side effect of parsing the
<frameset> tag.
- 5:09 PM Changeset in webkit [55211] by
-
- 4 edits in trunk
Versioning.
- 5:07 PM Changeset in webkit [55210] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-02-23 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
When the run-chromium-webkit-tests code was landed and the code was
refactored into the 'port' package, I accidentally broke using
http_server.py or websocket_server.py as command-line scripts
(the constructors needed a port object they weren't getting). This
change fixes them so that --server start|stop actually works.
As a part of this, the two files need to be able to call port.get(),
but doing that is awkward from a file inside the package, so I moved
get() into factory.py and imported that into init.py so that
http_server.py and websocket_server.py can just import factory.
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 5:06 PM Changeset in webkit [55209] by
-
- 1 copy in tags/Safari-533.1
New tag.
- 4:58 PM Changeset in webkit [55208] by
-
- 4 edits in trunk/WebKitTools
2010-02-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Fix the function signature for check_sys_deps on the mac port, and
fix the ordering of port_obj.check_sys_deps() and
port_obj.start_helper() (helper needs to be started before we check
the system configuration).
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- 4:24 PM Changeset in webkit [55207] by
-
- 31 edits in trunk
[Chromium API] Disambiguate allowJavaScript from didNotAllowScript
https://bugs.webkit.org/show_bug.cgi?id=35205
Patch by Adam Barth <abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.
WebCore:
For clients that want to show a user interface element when JavaScript
was blocked on a page, we need to disambiguate between querying the
client for whether JavaScript is enabled from actually failing to
execute some script.
This patch adds a new FrameLoaderClient callback for when WebCore would
like to execute JavaScript but fails to because JavaScript is disabled.
This patch also touches every client of canExecuteScripts so they can
indicate whether we should make this callback. I was hoping there was
a better choke point, but my first two attempts were wrong in subtle
ways. pkasting points out that this will be easy to screw up in the
future, so it's better to make all the clients be explicit.
- WebCore.PluginHostProcess.exp:
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.h:
(WebCore::):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setJavaScriptPaused):
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptController.h:
(WebCore::):
- bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieve):
- dom/ScriptElement.cpp:
(WebCore::ScriptElementData::evaluateScript):
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::startElementNs):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls):
- html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::processToken):
- inspector/InspectorController.cpp:
(WebCore::canPassNodeToJavaScript):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::didNotAllowScript):
WebKit/chromium:
Plumb didNotAllowScript through Chromium's WebKit API.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didNotAllowScript):
- src/DebuggerAgentImpl.cpp:
(WebKit::DebuggerAgentImpl::createUtilityContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didNotAllowScript):
- src/FrameLoaderClientImpl.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::bindToWindowObject):
WebKit/mac:
Make these two callsites explicit about not running script immediately.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
- 4:17 PM Changeset in webkit [55206] by
-
- 6 edits in trunk/WebCore
Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
https://bugs.webkit.org/show_bug.cgi?id=34997
Patch by Adam Barth <abarth@webkit.org> on 2010-02-24
Reviewed by Darin Fisher.
If we want to let the FrameLoaderClient override arePluginsEnabled,
then we need to call out to the FrameLoaderClient every time we read
the setting.
We don't have testing infrustructure for these changes, which is lame.
I'm supposed to fix that in Bug 33991.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
- loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
- page/Page.cpp:
(WebCore::Page::pluginData):
- plugins/MimeType.cpp:
(WebCore::MimeType::enabledPlugin):
- 3:19 PM CommitQueue edited by
- commiters.py is now in webkitpy (diff)
- 3:17 PM Changeset in webkit [55205] by
-
- 2 edits2 adds in trunk/WebCore
2010-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Dmitry Titov.
Do not fire focus events while a modal dialog is up.
https://bugs.webkit.org/show_bug.cgi?id=33962
Modifies the FocusController to check the frame's page's defersLoading() flag before firing blur/focus events.
This flag is set while a modal dialog (like a window.alert or window.confirm) is up. Firing the events causes
assertion failures, since when the dialog is dismissed the PageGroupLoadDeferrer assumes that no script has run.
Manual tests only as DumpRenderTree does not support modal dialogs
- manual-tests/modal-dialog-blur-selfclose.html: Added.
- manual-tests/modal-dialog-blur.html: Added.
- page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode):
- 2:58 PM Changeset in webkit [55204] by
-
- 2 edits in trunk/WebKitTools
2010-02-24 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Provide default username parameter to SVN.commit_with_message().
- Scripts/webkitpy/scm.py:
- 2:48 PM Changeset in webkit [55203] by
-
- 3 edits3 adds in trunk
<rdar://problem/7018611> innerHTML applies meta/link/title tags from a detached html element
Reviewed by Anders Carlsson.
WebCore:
Test: fast/parser/fragment-parser.html
Ensure that fragment parsing has no side effects on the fragment’s owner
document.
- html/HTMLParser.cpp:
(WebCore::HTMLParser::insertNode): Don’t call
dispatchDocumentElementAvailable() for fragments.
(WebCore::HTMLParser::handleError): Don’t copy attributes to the owner
document’s <html> and <body> elements when a redundant <html> or <body>
is encountered while parsing a fragment.
(WebCore::HTMLParser::framesetCreateErrorCheck): Don’t change the owner
document’s <body> element’s style when parsing a fragment.
(WebCore::HTMLParser::createHead): Don’t attach the new <head> to the
ownder document of a fragment.
LayoutTests:
- fast/parser/fragment-parser-expected.txt: Added.
- fast/parser/fragment-parser.html: Added.
- fast/parser/script-tests/fragment-parser.js: Added.
- 2:31 PM Changeset in webkit [55202] by
-
- 2 edits in trunk/WebKitTools
squash for checkin
- 2:09 PM Changeset in webkit [55201] by
-
- 7 edits2 adds in trunk/WebCore
Need to create a CanvasSurface base class for HTMLCanvasElement.
https://bugs.webkit.org/show_bug.cgi?id=35322
Reviewed by Darin Adler.
This is an initial step in making the OffscreenCanvas object.
No new functionality so no new tests.
- GNUmakefile.am: Added CanvasSurface to the build.
- WebCore.gypi: ditto
- WebCore.pro: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- dom/CanvasSurface.cpp: Added.
- dom/CanvasSurface.h: Added.
- html/HTMLCanvasElement.h: Made HTMLCanvasElement inherit from CanvasSurface.
- 1:58 PM Changeset in webkit [55200] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35357
Two editing tests fail after DumpRenderTree run loop changes
AppKit decided that it wanted to group all editing commands for some reason (and thus undo
reverted them all at once).
- DumpRenderTree/mac/DumpRenderTree.mm: (dump): Reverted the change that made DumpRenderTree use -[NSApplication run]. (runTest): Ditto. (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always returns YES. This is another way to make the Java plug-in work.
- 1:52 PM Changeset in webkit [55199] by
-
- 2 edits in trunk/WebCore
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
Reviewed by Adam Barth.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 1:20 PM Changeset in webkit [55198] by
-
- 6 edits in trunk
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=35335
compileGetDirectOffset modifies the contents of the object register
when the object is not using the inline storage array. As the object
register contains our 'this' pointer we can't allow it to be clobbered.
The fix is simply to copy the register into a separate scratch register
when we're loading off an object that doesn't use inline storage.
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdSelfList):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdSelfList):
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=35335
Add tests for caching getter lookup on large objects (eg. those not
using the inline storage array).
- fast/js/pic/cached-getter-setter-expected.txt:
- fast/js/pic/cached-getter-setter.html:
- 1:15 PM Changeset in webkit [55197] by
-
- 2 edits in trunk/LayoutTests
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Unskip 3 passing cookies tests.
- platform/gtk/Skipped:
- 12:51 PM Changeset in webkit [55196] by
-
- 3 edits4 adds in trunk
<rdar://problem/7682827> Text with :first-letter lingers after being removed
Reviewed by Simon Fraser.
WebCore:
Test: fast/css/first-letter-set-text.html
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setTextInternal): Set this back as the
text node’s renderer, as removing the first letter has resets the node’s
renderer.
LayoutTests:
- fast/css/first-letter-set-text-expected.checksum: Added.
- fast/css/first-letter-set-text-expected.png: Added.
- fast/css/first-letter-set-text-expected.txt: Added.
- fast/css/first-letter-set-text.html: Added.
- 11:31 AM Changeset in webkit [55195] by
-
- 2 edits in trunk/LayoutTests
2010-02-24 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] DRT implement execCommand()
https://bugs.webkit.org/show_bug.cgi?id=35351
Skip test that fails in GTK+.
- platform/gtk/Skipped:
- 10:15 AM Changeset in webkit [55194] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-24 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r55159.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Added.
- 8:20 AM Changeset in webkit [55193] by
-
- 2 edits in trunk/WebCore
2010-02-24 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle fill without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35337
- platform/graphics/qt/GraphicsContextQt.cpp:
- 7:39 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 7:05 AM Changeset in webkit [55192] by
-
- 3 edits1 delete in trunk
[Qt] Remove QGVLauncher
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-02-19
Reviewed by Kenneth Rohde Christiansen.
- 6:04 AM Changeset in webkit [55191] by
-
- 2 edits in trunk
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Enable SharedWorkers by default, since that's been the default for
a long time in our build-webkit configuration.
- configure.ac:
- 6:01 AM Changeset in webkit [55190] by
-
- 2 edits in trunk/WebCore
[Qt] Corrects build break of QtLauncher on Windows.
The VERSION variable was not set anymore while building in trunk.
Reviewed by nobody, build fix.
- WebCore.pro:
- 5:46 AM Changeset in webkit [55189] by
-
- 2 edits in trunk/WebCore
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Get rid of an extra call to
setNPWindowIfNeeded. updatePluginWidget already calls this for us
if needed.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
- 5:43 AM Changeset in webkit [55188] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Adam Roben <Adam Roben>
Make commit-log-editor find just-added ChangeLog files
Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
just-added ChangeLog files
Reviewed by Dave Levin.
- Scripts/commit-log-editor: (top level): Modified the regular expression that's used to find modified ChangeLog files to also look for just-added ChangeLog files.
- 5:21 AM Changeset in webkit [55187] by
-
- 6 edits in trunk/WebCore
2010-02-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Activate/Deactivate breaks does not look consistent with rest of the toolbar.
Fix style and add the new images to the related file sets.
https://bugs.webkit.org/show_bug.cgi?id=35307
- WebCore.gypi:
- inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png:
- inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 4:44 AM Changeset in webkit [55186] by
-
- 2 edits in trunk/WebCore
2010-02-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Try to sanitize a bit the geometry management of plugins.
Stop doing contradictory things in updatePluginWidget (we were at
the same time pretending the geometry setting was delayed until
::paint and setting the geometry not once but twice) and just set
it any time the windowRect or clipRect for the plugin has changed.
This is closer to what the Mac port does, and fixes instances of
the plugins not being drawn until the window is resized or
scrolled. Other than that all manual and layout tests seems to
still work.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::setNPWindowIfNeeded):
- 4:20 AM BuildingQtOnWindows edited by
- (diff)
- 4:17 AM BuildingQtOnWindows edited by
- (diff)
- 1:02 AM Changeset in webkit [55185] by
-
- 7 edits in trunk/JavaScriptCore
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Speed up getter performance in the jit
https://bugs.webkit.org/show_bug.cgi?id=35332
Implement getter lookup caching in the interpreter.
The getter stubs are generated through basically the
same code paths as the normal get_by_id caching.
Instead of simply loading a property and returning,
we load the getter slot, and pass the getter, base value
and return address to a shared stub used for getter
dispatch.
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::):
- runtime/GetterSetter.h:
- 12:51 AM Changeset in webkit [55184] by
-
- 3 edits in trunk/WebKitTools
2010-02-24 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
check-webkit-style false positive for WebCore forwarding header
https://bugs.webkit.org/show_bug.cgi?id=34604
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
Feb 23, 2010:
- 11:40 PM Changeset in webkit [55183] by
-
- 2 edits1 add in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] editing/execCommand/delete-image-in-anchor.html skipped
because of missing layoutTestController.execCommand()
Qt specific expected file added for editing/execCommand/insert-list-xml.xhtml
introduced in r55167, because of different font types.
- platform/qt/Skipped: editing/execCommand/delete-image-in-anchor.html skipped.
- platform/qt/editing/execCommand/insert-list-xml-expected.txt: Added.
- 11:14 PM Changeset in webkit [55182] by
-
- 3 edits in trunk/WebCore
2010-02-23 Geoff Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplify animation lifetime handling. Previously we manually
determined whether our base element was safe when we unregistered
our listener, now we simply ensure that the base element itself
registers and unregisters the animation listener.
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::disconnectAnimation): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::operator==): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions):
- svg/animation/SVGSMILElement.h:
- 8:27 PM Changeset in webkit [55181] by
-
- 5 edits in trunk
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
op_get_by_id_getter_chain was not passing the correct this parameter.
The bug was caused by incorrect use of baseCell instead of baseValue,
baseValue contains the original object for the lookup (and hence the
correct this object), baseCell is clobbered as part of walking the
prototype chain.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
Add thorough testing of getter access to hit the various
possible caching scenarios.
- fast/js/pic/cached-getter-setter-expected.txt:
- fast/js/pic/cached-getter-setter.html:
- 7:43 PM Google Summer of Code 2010 edited by
- (diff)
- 6:05 PM Changeset in webkit [55180] by
-
- 3 edits in trunk/WebCore
Chromium: Use V8::TerminateExecution to actually terminate workers.
https://bugs.webkit.org/show_bug.cgi?id=35137
Reviewed by David Levin.
Test: existing fast/workers/stress-js-execution.html which is currently failing
on Mac and Linux bots for Chromium.
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- 5:53 PM Changeset in webkit [55179] by
-
- 3 edits2 adds in trunk
REGRESSION: WebKit crashes when deleting images on blogger.com (34957)
<rdar://problem/7651935>
https://bugs.webkit.org/show_bug.cgi?id=34957
Reviewed by Simon Fraser.
WebCore:
Fixing a regression introduced with revision 53085. Anchor elements should not be considered
in editable content when calculating the position in the parent before the node.
Test: editing/execCommand/delete-image-in-anchor.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
LayoutTests:
- editing/execCommand/delete-image-in-anchor-expected.txt: Added.
- editing/execCommand/delete-image-in-anchor.html: Added.
- 5:46 PM Changeset in webkit [55178] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 5:22 PM Changeset in webkit [55177] by
-
- 7 edits7 adds4 deletes in trunk
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22602
Enable Java in DumpRenderTree (on Mac)
LayoutTests:
- fast/dom/java-applet-calls-expected.txt: Removed.
- fast/dom/java-applet-calls.html: Removed.
- fast/dom/resources/TestApplet.class: Removed.
- fast/dom/resources/TestApplet.java: Removed. This test was added in a failing form, even though it never worked. The new tests cover everything it was meant to cover.
- java/SharedApplet.java: Added. This class will have methods for simple tests, but it's also possible to just add new source files.
- java/Makefile: Added. Compile all .java files in the directory.
- java: Added.
- java/argument-to-object-type-expected.txt: Added.
- java/argument-to-object-type.html: Added.
- java/array-return-expected.txt: Added.
- java/array-return.html: Added. Added tests for recently fixed bugs.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped: Java tests only work on Mac currently.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (exitApplicationRunLoop): (dump): (runTest): DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in can start without freezing.
- Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
- 4:56 PM Changeset in webkit [55176] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Add expected result
- svg/custom/animate-use-crash-expected.txt: Added.
- 4:49 PM Changeset in webkit [55175] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Add a testcase for an old bug to ensure it doesn't return.
- svg/custom/animate-use-crash.xhtml: Added.
- 3:34 PM Google Summer of Code 2010 edited by
- (diff)
- 3:01 PM Google Summer of Code 2010 created by
- GSoC 2010 page - in case we want to participate
- 2:59 PM Changeset in webkit [55174] by
-
- 3 edits in trunk
2010-02-23 James Choi <jchoi42@pha.jhu.edu>
Add Solaris definitions
https://bugs.webkit.org/show_bug.cgi?id=35214
- WebKit/chromium/src/WebViewImpl.cpp
- WebKit/chromium/src/WebFrameImpl.cpp
- 2:43 PM Changeset in webkit [55173] by
-
- 4 edits2 adds in trunk
2010-02-23 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: testwebview does not work when called with absolute path
https://bugs.webkit.org/show_bug.cgi?id=34940
When testwebview is called as absolute path, chdir to executable
directory before searching resource files.
- GNUmakefile.am:
- 2:39 PM Changeset in webkit [55172] by
-
- 12 edits in trunk
Regression (r55107) - WebInspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274
Reviewed by Tim Hatcher and Pavel Feldman.
WebCore:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Use the minimum height for this calculation,
not the preferred height.
(WebCore::InspectorController::attachWindow): attachWindow() shouldn't decide the policy, as it is
often called partway through the show or dock procedure after some of the initial conditions have
changed. Let the front-end itself and the InspectorClient's make the policy decision at the start
of the show/dock operation.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canAttachWindow):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/inspector.js:
(WebInspector.toggleAttach): Before attaching, ask the front-end-host if attaching is allowed.
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
to get the expected behavior.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
to get the expected behavior.
LayoutTests:
- inspector/timeline-event-dispatch.html: Actually click in the right place now that the inspector isn't docked anymore.
- 2:17 PM Changeset in webkit [55171] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-23 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebDocument::getElementsByTagName.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::getElementsByTagName):
- 2:03 PM Changeset in webkit [55170] by
-
- 2 edits in trunk/WebKitSite
2010-02-23 Jessie Berlin <jberlin@webkit.org>
Reviewed by Eric Seidel and Adam Roben.
Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari.
https://bugs.webkit.org/show_bug.cgi?id=35098
- building/debug.html: Add instructions on how to build and run WebKit from within Visual Studio.
- 2:01 PM Changeset in webkit [55169] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/35287> ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading
Reviewed by Geoff Garen.
CGImageSourceGetStatusAtIndex claims that all frames of a multi-frame image are incomplete when we've not yet received the
complete data for an image that is using an incremental data source (<rdar://problem/7679174>). We work around this by
special-casing all frames except the last in an image and treating them as complete if they are present and reported as
being incomplete. We do this on the assumption that loading new data can only modify the existing last frame or append new
frames. The last frame is only treated as being complete if the image source reports it as such. This ensures that it is
truly the last frame of the image rather than just the last that we currently have data for.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
- 1:31 PM Changeset in webkit [55168] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Mario Blättermann <mariobl@freenet.de>
Reviewed by Gustavo Noronha.
German translation update.
- de.po:
- 1:31 PM Changeset in webkit [55167] by
-
- 6 edits2 adds in trunk
WebCore: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
createFragmentFromMarkup did not handle correctly the case where documentElement is
not an HTMLElement. The static cast to HTMLElement was causing createContextualFragment to
crash.
Test: editing/execCommand/insert-list-xml.xhtml
- dom/Element.cpp:
(WebCore::Element::createContextualFragment): Added.
- dom/Element.h: Added createContextualFragment virtual function.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup): Removed static cast to HTMLElement.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment): Modified to perform only checks
that are specific for an HTMLElement object. The rest of the logic has been moved to the
corresponding method in the Element class.
LayoutTests: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
- editing/execCommand/insert-list-xml-expected.txt: Added.
- editing/execCommand/insert-list-xml.xhtml: Added.
- 1:25 PM Changeset in webkit [55166] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Daniel Nylander <po@danielnylander.se>
Reviewed by Gustavo Noronha.
Swedish translation update.
- sv.po:
- 1:20 PM Changeset in webkit [55165] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-02-23 Ankit Patel <ankit@redhat.com>
Reviewed by Gustavo Noronha.
Gujarati translation.
- gu.po: Added.
- 1:13 PM Changeset in webkit [55164] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
WebKit coding style fixes.
- QtLauncher/main.cpp: (LauncherWindow::resetZoom):
- 12:39 PM Changeset in webkit [55163] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::init): (LauncherWindow::cloneWindow): (LauncherWindow::setupUI):
- 12:07 PM Changeset in webkit [55162] by
-
- 2 edits in trunk/WebCore
2010-02-23 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebCore should stop throwing away the CGImageSourceRef on Windows to improve GIF performance
https://bugs.webkit.org/show_bug.cgi?id=35309
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- 10:15 AM Changeset in webkit [55161] by
-
- 2 edits in trunk/WebKitTools
fix check_wdiff_install
- 10:07 AM Changeset in webkit [55160] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Dimitri Glazkov.
Chromium build fix.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 9:54 AM Changeset in webkit [55159] by
-
- 3 edits4 adds in trunk
WebKit/mac: <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
Reviewed by Simon Fraser.
Test: fast/repaint/repaint-during-scroll.html
NSClipView offsets any rects marked as needing display during scrolling
by the scroll offset. Compensate for this when -setNeedsDisplay: is called
during scrolling.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
around to call to FrameView::scrollPositionChanged().
(-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
LayoutTests: Rubber-stamped by Simon Fraser.
<rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
- fast/repaint/repaint-during-scroll.html: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.png: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.txt: Added.
- 9:52 AM Changeset in webkit [55158] by
-
- 10 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Changes references of GOwnPtr to reflect their new place.
http://webkit.org/b/35084
- 9:41 AM Changeset in webkit [55157] by
-
- 9 edits5 adds in trunk
HTTP 307 after a 303 after a POST re-sends POST data from the original request.
<rdar://problem/7390251> and https://bugs.webkit.org/show_bug.cgi?id=31410
Reviewed by Alexey Proskuryakov.
WebCore:
Test: http/tests/loading/307-after-303-after-post.html
Remember the last HTTP method send out during a redirect chain for a resource handle:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::lastHTTPMethod):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Refer to the last HTTP method used instead of the original method:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::willSendRequest):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
LayoutTests:
- http/tests/loading/307-after-303-after-post.html: Added.
- http/tests/loading/resources/303-to-307-target.php: Added.
- http/tests/loading/resources/307-post-output-target.php: Added.
- http/tests/loading/resources/post-to-303-target.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 9:27 AM Changeset in webkit [55156] by
-
- 2 edits in trunk/WebCore
2010-02-23 Crystal Zhang <haizhang@rim.com>
Unreviewed build fix.
Fix build error when enable plugin proxy: 'toRenderEmbeddedObject' identifier not found.
As RenderEmbeddedObject inherits RenderPartObject and 'toRenderEmbeddedObject' belongs
to former one.
- html/HTMLMediaElement.cpp:
- 8:53 AM Changeset in webkit [55155] by
-
- 3 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] fix previous SVG-disabling patch
https://bugs.webkit.org/show_bug.cgi?id=35298
- WebCore.gypi: rename variable
- WebCore.gyp/WebCore.gyp: actually use the variable
- 8:32 AM Changeset in webkit [55154] by
-
- 2 edits in trunk/WebCore
2010-02-23 Michael Lotz <mmlr@mlotz.ch>
Reviewed by David Levin.
[Haiku] Fix conversion from BString to String
https://bugs.webkit.org/show_bug.cgi?id=35082
The previous patch to this file was broken (sorry). First of all,
the conversion from UTF8 was accidentally removed. Second, for
empty strings, we need to point the implementation at StringImpl::empty().
Covered by existing tests.
- platform/text/haiku/StringHaiku.cpp: (WebCore::String::String):
- 8:00 AM Changeset in webkit [55153] by
-
- 2 edits in trunk/WebCore
[Qt] Prevent the media backend from handling non-audio or -video mime types
Reviewed by Eric Carlson.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
- 7:46 AM Changeset in webkit [55152] by
-
- 5 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Allow building without SVG
https://bugs.webkit.org/show_bug.cgi?id=31522
- WebCore.gyp/WebCore.gyp, WebCore.gypi: test enable_svg flag.
- bindings/v8/custom/V8SVGDocumentCustom.cpp, bindings/v8/custom/V8SVGPathSegCustom.cpp: test ENABLE(SVG).
- 7:28 AM Changeset in webkit [55151] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Fix false positives for 'delete *pointer' statements.
http://webkit.org/b/35235
- WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
- 7:21 AM Changeset in webkit [55150] by
-
- 7 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
again.
http://webkit.org/b/35084
- 6:35 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 6:21 AM Changeset in webkit [55149] by
-
- 2 edits4 moves1 add in trunk/JavaScriptCore
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Adding the EFL implementation of JavaScriptCore.
See https://bugs.webkit.org/show_bug.cgi?id=35084 for details.
- GNUmakefile.am: Updated to reflect the new location of GOwnPtr and
GRefPtr.
- wtf/efl/MainThreadEfl.cpp: Added.
- wtf/gobject/GOwnPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GOwnPtr.h: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.h: Moved from wtf/gtk.
- 6:17 AM Changeset in webkit [55148] by
-
- 2 edits in trunk/WebCore
2010-02-23 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle drawing without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35267
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect):
- 6:05 AM Changeset in webkit [55147] by
-
- 7 edits in trunk
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
No new tests, removing dead code only.
- page/Settings.cpp:
- page/Settings.h:
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
This removes Chromium's WebSettings::setGeolocationEnabled
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
- 5:12 AM Changeset in webkit [55146] by
-
- 8 edits in trunk
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
Update layout tests to reflect the WebCore changes in this bug.
- fast/events/touch/basic-multi-touch-events-expected.txt: Updated.
- fast/events/touch/basic-single-touch-events-expected.txt: Updated.
- fast/events/touch/script-tests/basic-multi-touch-events.js: (verifyTouchEvent): Add checking of TouchEvent.pageX/Y
- fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouchEvent): ditto.
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
The co-ordinates attached to a touch event are not used for tracking touch motion, rather the co-ordinates attached to Touches within the touch event should be used. Set the co-ordinates on the event itself to 0 to avoid confusion and match observed iPhone behavior.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Set the pageX/Y and screenX/Y co-ordinates attached to the touch event to 0,0 to match observed behavior on the iPhone.
- page/EventHandler.h: Remove now unused members m_firstTouchScreenPos and m_firstTouchPagePos.
- 4:53 AM Changeset in webkit [55145] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Various improvements to EventHandlerHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fix the build by not including PlatformScrollBar.h.
- page/haiku/EventHandlerHaiku.cpp: (WebCore::isKeyboardOptionTab):
Use the correct keycode for tab keys.
(WebCore::EventHandler::focusDocumentView):
Use proper locking. In any case, Haiku doesn't append platform
widgets to WebCore widgets. But if it did, this implementation
would be correct.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
Implemented.
(WebCore::EventHandler::eventActivatedView):
Removed notImplemented() and added note.
(WebCore::EventHandler::passMousePressEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseMoveEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Implemented.
(WebCore::EventHandler::accessKeyModifiers):
Added note.
- 4:43 AM Changeset in webkit [55144] by
-
- 7 edits in trunk
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- platform/gtk/Skipped:
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_number_of_pages):
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- 4:27 AM Changeset in webkit [55143] by
-
- 3 edits2 deletes in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/pasteboard/paste-list-004-expected.txt: Removed.
- editing/pasteboard/paste-list-004.html: Removed.
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 4:07 AM Changeset in webkit [55142] by
-
- 7 edits2 adds in trunk/WebCore
Adds cache to store Geolocation positions between browser sessions.
https://bugs.webkit.org/show_bug.cgi?id=34084
Reviewed by Ariya Hidayat.
This is required to fully implement the Geolocation maximumAge property.
See Bug 30676.
No new tests, will add tests for maximumAge once complete.
- Android.mk: Modified. Added GeolocationPositionCache.cpp
- GNUmakefile.am: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.gypi: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.pro: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationPositionCache.[cpp|h]
- page/GeolocationPositionCache.cpp: Added.
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::~GeolocationPositionCache):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::readFromDB):
(WebCore::GeolocationPositionCache::writeToDB):
- page/GeolocationPositionCache.h: Added.
- 4:04 AM Changeset in webkit [55141] by
-
- 3 edits2 adds in trunk
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
- fast/inline-block/inline-block-vertical-align-2.html: Added.
- fast/inline-block/inline-block-vertical-align-2-expected.txt: Added.
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
Test: fast/inline-block/inline-block-vertical-align-2.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition): Fixed vpos calculation. We cannot cut corners for inline blocks, since they may have their own text metrics.
- 3:43 AM Changeset in webkit [55140] by
-
- 3 edits in trunk/WebCore
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
- 3:25 AM Changeset in webkit [55139] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219
- webkit/webkitsoupauthdialog.c: (show_auth_dialog): Server message is displayed, messageLabel and message variables were renamed to avoid confusion.
- 3:09 AM Changeset in webkit [55138] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix various issues in keyboard event generation.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed backspace keycode.
Fixed using the appropriate fields from the Haiku event for mapping
to the VK_* codes and added mapping a great deal more codes.
Added extraction of modifier key flags.
Completed implementation of disambiguateKeyDownEvent()
Implemented currentCapsLockState().
- platform/haiku/PlatformKeyboardEventHaiku.cpp: (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- 2:53 AM Changeset in webkit [55137] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-23 Dmitriy Belenko <dbelenko@google.com>
Reviewed by Darin Fisher.
Chromium: Need to be able to get the bounds of selection
rectangle(s)
https://bugs.webkit.org/show_bug.cgi?id=34915
This change will enable about 30 test cases to pass in Chromium.
All of these test cases are related to selection rect boundaries.
This change will enable the test cases to retrieve the selection
rect boundary rectangle for the current selection.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect):
- src/WebFrameImpl.h:
- 2:35 AM Changeset in webkit [55136] by
-
- 20 edits in trunk
Adds Client::cancelGeolocationPermissionRequestForFrame and ChromeClient::cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=34962
These methods are required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.
- 2:19 AM Changeset in webkit [55135] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 2:03 AM Changeset in webkit [55134] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
https://bugs.webkit.org/show_bug.cgi?id=35248
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 1:55 AM Changeset in webkit [55133] by
-
- 2 edits in trunk/WebCore
[Qt] Correct build problems while building QtWebKit inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=34975
Reviewed by Laszlo Gombos.
- WebCore.pro: Change the condition !standalone_package to !QTDIR_build
- 1:47 AM Changeset in webkit [55132] by
-
- 5 edits in trunk/WebCore
2010-02-23 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Connect video with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=35276
MediaControlPrivate and GraphicsLayer are patched together via
a shared PlatformLayer (QGraphicsItem). This patch makes sure that the
QGraphicsVideoItem from MediaControl becomes part of the scene
associsated with GraphicsLayer
Test: http://double.co.nz/video_test/test1.html with AC turned on
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): mediaLayer member (WebCore::GraphicsLayerQtImpl::opaqueArea): video is opaque (WebCore::GraphicsLayerQtImpl::paint): don't paint video (WebCore::GraphicsLayerQtImpl::flushChanges): flush mediaLayer (WebCore::GraphicsLayerQt::setContentsToMedia): notify
- platform/graphics/qt/GraphicsLayerQt.h: reimp setContentsToMedia
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): m_compositing (WebCore::MediaPlayerPrivate::paint): don't paint if compositing (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): reimp from MediaPlayerPrivateInterface to support AC (WebCore::MediaPlayerPrivate::platformLayer): ditto
- platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): ditto
- 1:31 AM Changeset in webkit [55131] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Prompts a person for their SVN username if not already cached (by Subversion).
Currently, webkit-patch is unable to commit to the SVN repo. unless the
WebKit SVN username is already cached (from of a prior commit by hand)
because "svn commit" (called by webkit-patch) defaults to using the system
login name unless the username is already cached or specified on the
command line.
- Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and modified SVN.commit_with_message to call it. Added optional username parameter to method SVN.commit_with_message.
- Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
- 1:14 AM Changeset in webkit [55130] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformWheelEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed coding style violations.
Synced extracting the correct coordinates with Haiku WebKit implementation.
Added extracting modifier key flags.
- platform/haiku/PlatformWheelEventHaiku.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 1:02 AM Changeset in webkit [55129] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not do unnecessary work during size_allocate.
FrameView::resize will already queue a layout, so there's no need
to force one ourselves. On top of that, the layout function
already adjusts the view size when needed, so there's no need to
do that manually either. No change in the layout tests or unit
tests after this.
- webkit/webkitwebview.cpp: (webkit_web_view_size_allocate):
- 12:58 AM Changeset in webkit [55128] by
-
- 4 edits in trunk/WebCore
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix for PluginView
https://bugs.webkit.org/show_bug.cgi?id=35230
No new tests, build fix only.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
- 12:42 AM Changeset in webkit [55127] by
-
- 2 edits in trunk
2010-02-23 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Eric Seidel.
[gtk] missing libsoup-2.4 package in gir generation
https://bugs.webkit.org/show_bug.cgi?id=35199
Include libsoup-2.4 package in gobject introspection .gir generation.
- GNUmakefile.am:
- 12:26 AM Changeset in webkit [55126] by
-
- 1 edit1 add in trunk/WebCore
2010-02-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port ScriptController::createScriptInstanceForWidget
https://bugs.webkit.org/show_bug.cgi?id=34413
- bindings/js/ScriptControllerBrew.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
- 12:19 AM Changeset in webkit [55125] by
-
- 3 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=34933
Original patch by Eric Carlson.
- media/content/test-par-16-9.mp4: Change the width of the video track from 426.666 to 426.
- platform/mac-leopard/Skipped: Unskip the test, it should pass now.
- 12:09 AM Changeset in webkit [55124] by
-
- 2 edits in trunk/WebCore
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Webkit crashes when using orca
https://bugs.webkit.org/show_bug.cgi?id=35169
Made webkit_accessible_text_get_caret_offset check if end selection
node is null.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
Feb 22, 2010:
- 11:53 PM Changeset in webkit [55123] by
-
- 7 edits in trunk/WebKitTools
2010-02-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Add more checking for missing binaries and packages to check_sys_deps()
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- 11:37 PM Changeset in webkit [55122] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implemented PopupMenu support.
https://bugs.webkit.org/show_bug.cgi?id=35078
Covered by existing tests.
The implementation is currently very simple: Added a PopupMenuHaiku
class that derives from a native BPopUpMenu. It attaches a BHandler
derivative to the BApplication (WebCore main thread) which receives
the item invokation and menu hidden events and informs the PopupMenuClient
accordingly.
- platform/PopupMenu.h:
Changed type of m_menu for Haiku.
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHandler::PopupMenuHandler): (WebCore::PopupMenuHandler::MessageReceived): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::Hide): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
Removed bogus code.
(WebCore::PopupMenu::show):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::hide):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::updateFromElement):
Implemented.
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
Implemented according to Gtk port.
- 10:28 PM Changeset in webkit [55121] by
-
- 3 edits in trunk/WebKitTools
2010-02-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
[Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
https://bugs.webkit.org/show_bug.cgi?id=35229
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 9:03 PM Changeset in webkit [55120] by
-
- 8 edits in trunk/JavaScriptCore
Remove auto_ptr usage in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=35221
Reviewed by Darin Adler.
- parser/Nodes.h: Removed now unneeded adopt method.
- parser/Parser.cpp: Removed <memory> include as it is not required anymore.
- wtf/OwnPtr.h: Removed the constructor from auto_ptr.
- wtf/VectorTraits.h: Removed a template specialization for auto_ptr.
- wtf/unicode/Collator.h: Made userDefault return a PassOwnPtr.
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Changed the method to match the next signature.
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault): Ditto.
- 8:50 PM Changeset in webkit [55119] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 James Robinson <jamesr@chromium.org>
Unreviewed. Adding myself to committers list.
- Scripts/webkitpy/committers.py:
- 8:29 PM Changeset in webkit [55118] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Remove DRT hack that turns off hardware acceleration with older QuickTimes
https://bugs.webkit.org/show_bug.cgi?id=35275
Now that WebKit does a version check to avoid a QuickTime-related
crash (r55100), DumpRenderTree does not need to.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 5:55 PM Changeset in webkit [55117] by
-
- 5 edits in trunk
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
- wtf/Platform.h:
- 5:29 PM Changeset in webkit [55116] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformMouseEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Mapping Haiku button constants (bit field) to WebCore buttons was broken.
Extracting event time was broken (supposed to be in seconds).
Wrong coordinate was being extracted, needs to be content local.
Added extracting modifier key flags.
- platform/haiku/PlatformMouseEventHaiku.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 5:12 PM Changeset in webkit [55115] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implement creating and filling platform gradients.
https://bugs.webkit.org/show_bug.cgi?id=34683
Covered by existing tests.
- platform/graphics/Gradient.h:
Typedef PlatformGradient to BGradient
- platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::platformDestroy):
Delete the cached BGradient object.
(WebCore::Gradient::platformGradient):
Create a BGradient object according to the type of Gradient.
Return the cached object.
(WebCore::Gradient::fill):
use BView API to fill with the platform gradient.
- 5:01 PM Changeset in webkit [55114] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-22 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Add test for https://bugs.webkit.org/show_bug.cgi?id=32842
It has been fixed on trunk for a while, but we want to make sure we
do not regress.
- fast/text/find-layout-crash.html: Added.
- fast/text/find-layout-crash-expected.txt: Added.
- 4:55 PM Changeset in webkit [55113] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Build fix for debug builds of GlyphPageTreeNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=34528
Covered by existing tests.
- platform/graphics/GlyphPageTreeNode.cpp:
include <stdio.h> since printf() is used if NDEBUG is not defined.
- 4:45 PM Changeset in webkit [55112] by
-
- 6 edits in trunk/WebKit/win
WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
- WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
- WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
- WebKitGraphics.h: Removed WebKitSystemParameterChanged.
- WebView.cpp:
(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
- 4:12 PM Changeset in webkit [55111] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.
CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.
- bindings/scripts/CodeGeneratorV8.pm:
- 3:28 PM Changeset in webkit [55110] by
-
- 1 edit1 delete in trunk/LayoutTests
Rubber-stamped by Alexey Proskuryakov.
[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263
Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.
Qt specific expected file is removed to make buildbot green,
but it needs more investigation.
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.
- 3:27 PM Changeset in webkit [55109] by
-
- 21 edits in trunk
Rubber-stamped by Geoff Garen.
Rename RuntimeObjectImp to RuntimeObject.
- 3:23 PM Changeset in webkit [55108] by
-
- 3 edits3 adds in trunk
Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167
Reviewed by Eric Seidel.
WebCore:
Test: fast/images/bad-png.html
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):
LayoutTests:
- fast/images/bad-png-expected.txt: Added.
- fast/images/bad-png.html: Added.
- fast/images/resources/bad-png.png: Added.
- 3:20 PM BuildingOnWindows edited by
- (diff)
- 3:10 PM Changeset in webkit [55107] by
-
- 8 edits in trunk
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
Reviewed by Tim Hatcher.
WebCore:
- WebCore.base.exp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
- inspector/InspectorController.h:
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
- 2:32 PM Changeset in webkit [55106] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!
- 2:25 PM Changeset in webkit [55105] by
-
- 2 edits in trunk/WebCore
Undo a small part of the previous commit.
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local variable as RefPtr for safety.
- 2:21 PM Changeset in webkit [55104] by
-
- 12 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35260
Eliminate apple_runtime_object
No change in functionality, so no tests.
- WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.cpp:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl: These objects no longer need overriding name getters, as they no longer intercept the apple_runtime_object property.
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in this file, and now it's also used elsewhere when calling plug-in methods. (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting name getters.
- bindings/js/JSPluginElementFunctions.h: Export pluginInstance().
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Take plug-in element's instance directly, without relying on fake attribute lookup. One change resulting from this is that RuntimeObjectImp may not be created in some cases - this code only needs an instance, but the old code had to pass the instance wrapped into RuntimeObjectImp.
- 2:17 PM Changeset in webkit [55103] by
-
- 5 edits3 adds in trunk/LayoutTests
2010-02-22 Robert Hogan <robert@roberthogan.net>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=32937
LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.
The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
precisely defined by the Unicode specification, so different platforms may legitimately
have different results.
Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
to protect against regressions in each platform's decoding behaviour.
- fast/encoding/invalid-UTF-8-2-expected.txt: Added.
- fast/encoding/invalid-UTF-8-2.html: Added.
- fast/encoding/invalid-UTF-8.html:
- platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
- platform/mac/fast/encoding/invalid-UTF-8-expected.png:
- platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:
- 1:07 PM Changeset in webkit [55102] by
-
- 3 edits in trunk/LayoutTests
Bug 35186 - AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Fixing layout test failure.
- 12:59 PM Changeset in webkit [55101] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index
Reviewed by Tim Hatcher.
No new tests because this code path is not used for JS-initiated changes.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.
- 12:51 PM Changeset in webkit [55100] by
-
- 2 edits in trunk/WebKit/mac
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan.
<rdar://problem/7285392>
On Leopard, we have to disable hardware acceleration if we detect that the
installed Core Video framework has bug <rdar://problem/7228836>.
- WebView/WebView.mm: (coreVideoHas7228836Fix): (-[WebView _preferencesChangedNotification:]):
- 12:18 PM Changeset in webkit [55099] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.22
Tagging 1.1.22.
- 12:05 PM Changeset in webkit [55098] by
-
- 3 edits2 adds in trunk
Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060
Reviewed by Dan Bernstein.
WebCore:
Test: editing/selection/extend-byline-withfloat.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.
LayoutTests:
- editing/selection/extend-byline-withfloat-expected.txt: Added.
- editing/selection/extend-byline-withfloat.html: Added.
- 12:03 PM Changeset in webkit [55097] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
- bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.
- 11:53 AM Changeset in webkit [55096] by
-
- 27 edits5 deletes in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Streamline V8 event listener code. Merge all the variants of
V8DOMWrapper::getEventListner() into a single version and generate
addEventListener() and removeEventListener() bindings for all objects
except DOMWindow.
- 11:29 AM Changeset in webkit [55095] by
-
- 3 edits2 adds in trunk
AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/element-focus.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
LayoutTests:
- platform/mac/accessibility/element-focus-expected.txt: Added.
- platform/mac/accessibility/element-focus.html: Added.
- 11:24 AM Changeset in webkit [55094] by
-
- 2 edits in trunk/WebKit/qt
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed Symbian build fix.
[Qt] Updated the def file with new exports to enable
building DumpRenderTree.
- symbian/eabi/QtWebKitu.def:
- 11:12 AM Changeset in webkit [55093] by
-
- 5 edits in trunk/JavaScriptCore
JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.
Reviewed by Oliver Hunt.
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
- wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):
- 11:07 AM Changeset in webkit [55092] by
-
- 4 edits in trunk
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump library versioning for 1.1.22 release.
- configure.ac:
WebKit/gtk:
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for release.
- NEWS:
- 11:02 AM Changeset in webkit [55091] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-02-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570
Use MALLOC macro instead of the standard malloc function.
Although RVCT provides malloc, we can't use it in BREW
because the loader does not initialize the base address properly.
- wtf/FastMalloc.cpp:
- wtf/brew/SystemMallocBrew.h: Added. (mallocBrew): (callocBrew): (freeBrew): (reallocBrew):
- 10:48 AM Changeset in webkit [55090] by
-
- 11 edits in trunk/WebCore
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Darin Adler.
Remove addScrolledContentOffset/subtractScrolledContentOffset
https://bugs.webkit.org/show_bug.cgi?id=35225
Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
methods, and instead use the existing scrolledContentOffset(), and use
IntSize and IntPoint instead of lots of x, y variables.
Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
which is needed in a few places.
- page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
- platform/graphics/IntPoint.h: (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderLayer.h: (WebCore::RenderLayer::size):
- rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
- 10:36 AM Changeset in webkit [55089] by
-
- 12 edits3 copies in trunk
2009-02-22 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.
This patch adds support for querying this via ChromiumBridge.
- platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::queryStyle): add code to query fontconfig via ChromiumBridge
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 10:11 AM Changeset in webkit [55088] by
-
- 4 edits in trunk
Build fix for make distcheck.
- 9:25 AM Changeset in webkit [55087] by
-
- 2 edits in trunk/WebCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- wml/WMLVariables.cpp: (WebCore::substituteVariableReferences):
- 9:01 AM Changeset in webkit [55086] by
-
- 8 edits in trunk
WebCore
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 8:40 AM Changeset in webkit [55085] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build the DRT in debug on Mac OS X
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 8:17 AM Changeset in webkit [55084] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
https://bugs.webkit.org/show_bug.cgi?id=35238
No new tests, build fix only.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow):
- 7:16 AM Changeset in webkit [55083] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix for RVCT.
Fix after r55024. The "-i" option is for perl not for the
script.
- DerivedSources.pro:
- 7:12 AM Changeset in webkit [55082] by
-
- 6 edits in trunk
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- WebKit.pro:
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/main.cpp: (main):
- 6:26 AM Changeset in webkit [55081] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Simon Fraser.
Simplifies calculation of the transform in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=35101
No new tests, optimization only.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 6:21 AM Changeset in webkit [55080] by
-
- 2 edits in trunk/BugsSite
2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Maciej Stachowiak.
Don't reset the assignee back to default on component change
There's a risk of reseting a valid assignee for example when
triaging a bug. All components in WebKit have the default
assignee set to webkit-unassigned@webkit.org so this should
not cause problems for people relying on this functionality.
- template/en/custom/bug/edit.html.tmpl:
- 5:42 AM Changeset in webkit [55079] by
-
- 6 edits2 adds in trunk/WebCore
[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=34631
No new tests. This patch only affects multimedia backend.
- WebCore.pro: Build depends on Qt version.
- css/mediaControlsQt.css: Updated media controls.
- platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
- platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
- platform/qt/RenderThemeQt.h: Reimplemented a few more methods.
- 5:02 AM Changeset in webkit [55078] by
-
- 2 edits in trunk/WebCore
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Not reviewed: mac build fix
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer):
- 4:14 AM Changeset in webkit [55077] by
-
- 15 edits2 adds in trunk
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217
WebCore:
- English.lproj/localizedStrings.js:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::setBreakpointsActivated):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::setBreakpointsActivated):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::activateBreakpoints): (WebCore::InspectorBackend::deactivateBreakpoints):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
- inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints): (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get breakpointsActivated): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/inspector.css:
- inspector/front-end/textViewer.css:
WebKit/chromium:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.setBreakpointsActivated): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.activateBreakpoints): (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):
- 3:18 AM Changeset in webkit [55076] by
-
- 2 edits in trunk/WebCore
REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>
Rubber-stamped by Sam Weinig and Maciej Stachowiak.
Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 2:31 AM Changeset in webkit [55075] by
-
- 12 edits1 delete in trunk/WebCore
Not reviewed, build fix.
Revert the previous change.
- 1:28 AM Changeset in webkit [55074] by
-
- 12 edits1 add in trunk/WebCore
2010-02-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
8.8% speedup on Dromaeo DOM Core tests.
3.3% speedup on Hixie DOM Core tests.
- bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWrapperMapFor):
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
- bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined. (WebCore::toJS): Moved here so it can be inlined.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
- dom/Node.idl: Add CustomHeader directive.
Add new files to build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 1:13 AM Changeset in webkit [55073] by
-
- 9 edits1 add in trunk/WebCore
2010-02-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix.
- 12:08 AM Changeset in webkit [55072] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 2 of Windows build fix.
Feb 21, 2010:
- 11:59 PM Changeset in webkit [55071] by
-
- 34 edits1 move2 deletes in trunk
2010-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: stop on inline breakpoints on reload.
- ScriptBreakpoint struct has been introduced and reused in InspectorController and debug server.
- JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
There were no changes to semantics, only some mechanical changes:
- addBreakpoint and updateBreakpoint were merged into setBreakpoint
- ScriptDebugServer now operates ScriptBreakpoint instances instead of BreakpointInfo.
- It no longer allocates maps and breakpoint info in heap - all done on stack.
- JavaScriptDebugListener is now ScriptDebugServer::Listener
- Listener methods no longer have ExecState (was unused).
- addListener/removeListener pair wuth no page argument removed (was unused).
- InspectorController now binds sourceID to url and maintains a map of 'sticky'
breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
Front-end no longer stores map of sticky breakpoints.
- setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
- A bunch of if(USE_JSC/V8/other) forks removed.
- InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::isActivation):
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::hasListenersInterestedInPage): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::toPage): (WebCore::ScriptDebugServer::detach): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::setJavaScriptPaused): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener): (WebCore::ScriptDebugServer::didRemoveLastListener):
- bindings/js/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::hasListeners): (WebCore::ScriptDebugServer::hasGlobalListeners):
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptionsState): (WebCore::InspectorBackend::setPauseOnExceptionsState):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/ScriptBreakpoint.h: Added. (WebCore::InspectorBreakpoint::InspectorBreakpoint):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::restoredBreakpoint): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::resumedScript):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptDebugListener.h: Removed.
- inspector/JavaScriptDebugServer.cpp: Removed.
- inspector/JavaScriptDebugServer.h: Removed.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
- page/Page.cpp: (WebCore::Page::Page):
- platform/android/TemporaryLinkStubs.cpp:
- 11:56 PM Changeset in webkit [55070] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 1 of Windows build fix.
- 10:50 PM Changeset in webkit [55069] by
-
- 7 edits in trunk
JavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.
Reviewed by Oliver Hunt.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):
- wtf/OwnFastMallocPtr.h:
(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
WebCore: Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.
Reviewed by Oliver Hunt.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
- 10:12 PM Changeset in webkit [55068] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-21 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
HashMapTranslatorAdapter::translate() needs to set the mapped value.
HTTPHeaderMap::add(const char*, const String&) does not work
https://bugs.webkit.org/show_bug.cgi?id=35227
- wtf/HashMap.h: (WTF::HashMapTranslatorAdapter::translate):
- 8:12 PM Changeset in webkit [55067] by
-
- 4 edits3 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
- printing/page-break-always-for-overflow-expected.txt: Added.
- printing/page-break-always-for-overflow.html: Added.
- printing/script-tests/page-break-always-for-overflow.js: Added.
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
Test: printing/page-break-always-for-overflow.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
- rendering/RenderBlock.h:
- 3:40 PM Changeset in webkit [55066] by
-
- 19 edits in trunk/WebCore
Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157
Reviewed by Eric Seidel.
The changes consists of:
- Changing auto_ptr arguments or return types to PassOwnPtr.
- Replacing local auto_ptr by OwnPtr.
- Removing now unneeded <memory> inclusion.
- css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):
- loader/WorkerThreadableLoader.h:
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
- loader/icon/IconLoader.h:
- platform/ContextMenu.cpp:
(WebCore::separatorItem):
- platform/CrossThreadCopier.h:
(WebCore::):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
- workers/GenericWorkerTask.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
- 1:47 PM Changeset in webkit [55065] by
-
- 4 edits in trunk/WebCore
2010-02-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22215
Avoid calling absoluteClippedOverflowRect() so many times
RenderLayer::updateLayerPositions() computes the clipped overflow rect
and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
which can compute the same rects all over again. Avoid this by passing
these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
reduces the time spent in updateLayerPositions() for some content.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
- 1:19 PM Changeset in webkit [55064] by
-
- 2 edits in trunk/WebKit/mac
False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218
Reviewed by Darin Adler.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.
- 12:20 PM Changeset in webkit [55063] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=35215
<rdar://problem/7673157>
The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
would incorrectly pass the source URL of the plug-in resource.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the real base URL for the WebPlugInBaseURLKey key.
- 3:32 AM Changeset in webkit [55062] by
-
- 3 edits17 adds in trunk
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- perf/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/json2.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-analyze-results.js: Added.
- perf/sunspider-0.9.1/sunspider-compare-results.js: Added.
- perf/sunspider-0.9.1/sunspider.css: Added.
- perf/sunspider-0.9.1/sunspider.html: Added.
- perf/sunspider-0.9.1/versions.html: Added.
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- hosted/sunspider.css: Remove tabs, which I noticed where present while copying to the WebKitSite directory.
