Timeline
Apr 22, 2010:
- 10:59 PM Changeset in webkit [58151] by
-
- 2 edits in trunk
Fix up my immediately previous ChangeLogs.
- 10:47 PM Changeset in webkit [58150] by
-
- 6 edits6 adds in trunk
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Links around blocks (e.g. divs) results in too many VoiceOver call outs
https://bugs.webkit.org/show_bug.cgi?id=37079
The basic change is to modify the AccessibilityRenderObject tree
traversal methods to account for inline continuations in the
render tree and make the accessibility tree look as if
continuations didn't exist - the same as if CSS blocks could just
sit in CSS inlines. This is slightly tricky code but creates a
much saner accessibility tree.
Tests: accessibility/image-link-inline-cont.html
accessibility/image-link.html
accessibility/inline-continuations.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations. (WebCore::firstChildInContinuation): ditto (WebCore::firstChildConsideringContinuation): ditto (WebCore::lastChildConsideringContinuation): ditto (WebCore::startOfContinuations): ditto (WebCore::endOfContinuations): ditto (WebCore::childBeforeConsideringContinuations): ditto (WebCore::firstChildIsInlineContinuation): ditto (WebCore::lastChildHasContinuation): ditto (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations. (WebCore::AccessibilityRenderObject::lastChild): ditto (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations and their anonymous block parents. (WebCore::AccessibilityRenderObject::nextSibling): ditto (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations. (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
- rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
2010-04-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Links around blocks (e.g. divs) results in too many VoiceOver call outs
https://bugs.webkit.org/show_bug.cgi?id=37079
The new test cases verify the accessibility tree created by an image inside a link, and verify
that adding a div with role=presentation now has no effect on the accessibility tree (as expected).
- accessibility/image-link-inline-cont-expected.txt: Added.
- accessibility/image-link-inline-cont.html: Added.
- accessibility/image-link.html: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/image-link-expected.txt: Added.
- platform/win/Skipped:
Test to check that accessibility tree doesn't get duplicate content in the presence
of inline continuations (this was a bug in an earlier version of this patch).
- accessibility/inline-continuations-expected.txt: Added.
- accessibility/inline-continuations.html: Added.
- 9:51 PM Changeset in webkit [58149] by
-
- 5 edits in trunk
2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
- platform/chromium/test_expectations.txt:
2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
REGRESSION: TextIterator may use freed memory
https://bugs.webkit.org/show_bug.cgi?id=37973
Added TextIterator::m_text to hold the returned String.
No new tests because there are no behavior change, but
copy-backslash-with-euc.html on chromium-win should test this.
- editing/TextIterator.cpp: (WebCore::TextIterator::emitText):
- editing/TextIterator.h:
- 9:48 PM Changeset in webkit [58148] by
-
- 2 edits in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
The new review tools shouldn't clear the comment box automatically
https://bugs.webkit.org/show_bug.cgi?id=38004
Instead, we now have a button for doing that explicitly. If people
like this tool, we can look at fancier solutions.
Also, tried to make the tool work on the edit page as well as the review page.
- PrettyPatch/PrettyPatch.rb:
- 9:32 PM Changeset in webkit [58147] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
- 9:29 PM Changeset in webkit [58146] by
-
- 6 edits in trunk/WebKitTools
2010-04-22 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Revert 58077 and follow-ups. It's broken.
https://bugs.webkit.org/show_bug.cgi?id=37664
- Scripts/new-run-webkit-httpd:
- Scripts/new-run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 9:20 PM Changeset in webkit [58145] by
-
- 2 edits in trunk/WebCore
2010-04-22 Michael Forney <mforney@mforney.org>
Reviewed by Adam Barth.
Only include JSDatabase.h and JSDatabaseCallback.h when database is
enabled. This partially fixes building with --disable-database.
- bindings/js/JSDOMWindowCustom.cpp: Add a check for database around database-related headers.
- 8:39 PM Changeset in webkit [58144] by
-
- 2 edits in trunk/WebCore
2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
Reviewed by Darin Adler.
In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
this by changing shouldUseInputMethod to use internal methods to
check that the field is a text field that isn't a password field.
No new tests.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
- 8:30 PM Changeset in webkit [58143] by
-
- 2 edits1 add1 delete in trunk
2010-04-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731
- bindings/v8/test/run_tests.py: Removed.
2010-04-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731
- Scripts/run-bindings-tests: Added.
- 8:10 PM Changeset in webkit [58142] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
- wtf/MathExtras.h:
- 7:52 PM Changeset in webkit [58141] by
-
- 4 edits in trunk/WebKit/qt
2010-04-22 John Pavan <john.pavan@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates.
https://bugs.webkit.org/show_bug.cgi?id=37163
QWebPage::inputMethodQuery is modified so that it
returns coordinates in the widget's coordinate system.
Tests are added for QGraphicsWebView and QWebView
to verify that this behavior is correct after the webpage
has been scrolled.
- Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::microFocusCoordinates):
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::microFocusCoordinates):
- 7:07 PM Changeset in webkit [58140] by
-
- 10 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=37872
- html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant(). (WebCore::WebGLRenderingContext::isGLES2Compliant):
- html/canvas/WebGLRenderingContext.h: Ditto.
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Add isGLES2Compliant to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=37872
- public/WebGraphicsContext3D.h: Add isGLES2Compliant().
- src/GraphicsContext3D.cpp: Ditto.
- src/WebGraphicsContext3DDefaultImpl.cpp: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
- src/WebGraphicsContext3DDefaultImpl.h: Ditto.
- 6:55 PM Changeset in webkit [58139] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Remove the assert() since our ServerProcess code does not always seem to be reading the full stderr output (or we're not waiting for it to).
- 6:32 PM Changeset in webkit [58138] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed build fix.
- wtf/MD5.cpp: fix include path of CString.h
- 6:31 PM Changeset in webkit [58137] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 Yuzo Fujishima <yuzo@google.com>
Unreviewed. Chromium test expectation change.
Mark fast/events/touch/send-oncancel-event.html as failing (TEXT).
https://bugs.webkit.org/show_bug.cgi?id=38020
- platform/chromium/test_expectations.txt:
- 6:13 PM Changeset in webkit [58136] by
-
- 9 edits3 adds in trunk
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/MD5.cpp: Added.
- wtf/MD5.h: Added.
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
- ForwardingHeaders/wtf/MD5.h: Added.
- 5:44 PM Changeset in webkit [58135] by
-
- 2 edits in trunk/WebKit2
Remove an assert. (It's not valid when resizing).
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):
- 5:16 PM Changeset in webkit [58134] by
-
- 2 edits in trunk/JavaScriptCore
Errk, accidentally committed commenting out two ASSERTs! reverting.
Reviewed by NOBODY (build fix).
- runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
- 5:11 PM Changeset in webkit [58133] by
-
- 8 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable
Reviewed by Geoff Garen.
Presently JSC's IdentifierTables are owned by the JSGlobalData. For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData. This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.
- API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
- API/JSContextRef.cpp:
(JSContextGroupCreate):
- runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h:
(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):
- runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- 5:08 PM Changeset in webkit [58132] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38012
REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard
- platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified characters, to avoid falling through to virtual key code lookup for Roman characters.
- 5:07 PM Changeset in webkit [58131] by
-
- 2 edits in trunk/JavaScriptGlue
Do not get the globaldata for the APIShim via the
global object; global object construction creates identifiers
which results in the ASSERTs checking the thread data's
identifierTable has been set failing.
Rubber stamped by Sam Weinig
- JSUtils.cpp:
(unprotectGlobalObject):
(getThreadGlobalData):
(getThreadGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPICallback::~JSGlueAPICallback):
- 5:02 PM Changeset in webkit [58130] by
-
- 5 edits in trunk
Versioning.
- 5:00 PM Changeset in webkit [58129] by
-
- 1 copy in tags/Safari-533.6
New tag.
- 4:46 PM Changeset in webkit [58128] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add code to help debug new-run-webkit-test hangs on the Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=38011
I can see no reasonable way to test this change.
Stubbing out sys._current_frames() and traceback.extract_stack
seems folly. Dumping real data would have line number
(and possibly other call stack) variance between runs.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Add _dump_thread_states and _dump_thread_states_if_necessary to have our main thread dump the states of all threads every 60 seconds when running in verbose mode.
- Better document what is going on in our main loop.
- 4:40 PM Changeset in webkit [58127] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-04-22 James Robinson <jamesr@chromium.org>
Unreviewed, expectations only change.
Land chromium platform-specific results for fast/text/format-control.html
- platform/chromium-linux/fast/text/format-control-expected.checksum: Added.
- platform/chromium-linux/fast/text/format-control-expected.png: Added.
- platform/chromium-mac/fast/text/format-control-expected.checksum: Added.
- platform/chromium-win/fast/text/format-control-expected.checksum: Added.
- platform/chromium-win/fast/text/format-control-expected.png: Added.
- platform/chromium-win/fast/text/format-control-expected.txt: Added.
- 4:37 PM Changeset in webkit [58126] by
-
- 4 edits in trunk/WebCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Darin Adler.
Fix the MSVC 64bit build.
https://bugs.webkit.org/show_bug.cgi?id=37980
- platform/text/TextStream.cpp:
- platform/text/TextStream.h:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::platformStart):
- 4:35 PM Changeset in webkit [58125] by
-
- 4 edits1 delete in trunk/WebKit2
Merge the prefix headers.
Reviewed by Anders Carlsson.
- Configurations/BaseTarget.xcconfig:
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2Prefix.h:
- WebKit2_Prefix.pch: Removed.
- 4:00 PM Changeset in webkit [58124] by
-
- 2 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Implement findThemePath to locate the correct theme file instead of
relying on a hardcoded location.
http://webkit.org/b/37996
- efl/EWebLauncher/main.c: (findThemePath): Fix to locate the correct theme files. (main): Use findThemePath() instead of a hardcoded one.
- 3:58 PM Changeset in webkit [58123] by
-
- 4 edits in trunk/WebKit2
Don't pass the new size when calling didSetSize, it's possible to get
the size from the update chunk.
Reviewed by Sam Weinig.
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
- 3:51 PM Changeset in webkit [58122] by
-
- 2 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update efl/ewebkit.pc.in to match the variable substitution syntax
of CMake.
http://webkit.org/b/37999
- efl/ewebkit.pc.in: Updated.
- 3:41 PM Changeset in webkit [58121] by
-
- 3 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update EWebKit (EFL port) to match recent API changes.
http://webkit.org/b/37997
- efl/ewk/ewk_frame.cpp: (ewk_frame_zoom_set): Change to use WebCore::ZoomMode. (ewk_frame_zoom_text_only_set): Change to use WebCore::ZoomMode. (_ewk_frame_handle_key_scrolling): s/WebCore::VK_/VK_/g (ewk_frame_plugin_create): Disable temporarily PluginView-related code until a proper plugin implementation is made.
- efl/ewk/ewk_view.cpp: Fix typo in _parent_sc declaration. (ewk_view_selection_get): Fix a reference to WebCore::CString to WTF::CString.
- 3:33 PM Changeset in webkit [58120] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Mark Rowe.
<rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
for now. Clients rely on the old behavior, so a fix that changes it will need to account for
those.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL instead of baseURL again.
- 3:09 PM Changeset in webkit [58119] by
-
- 5 edits in trunk/WebKit2
Rename SetFrame and DidSetFrame to SetSize and DidSetSize.
Reviewed by Sam Weinig.
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
(DrawingAreaMessage::):
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
(DrawingAreaProxyMessage::):
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::drawRectIntoContext):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
- 2:44 PM Changeset in webkit [58118] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58110.
http://trac.webkit.org/changeset/58110
https://bugs.webkit.org/show_bug.cgi?id=38007
Caused an internal compiler error on Qt (Requested by abarth
on #webkit).
- wtf/MathExtras.h:
- 1:56 PM Changeset in webkit [58117] by
-
- 21 edits1 copy3 adds in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
Add rudimentary statistics gathering for WebKit2
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
- UIProcess/API/C/WKContextPrivate.h: Copied from WebKit2/UIProcess/API/C/WKContext.h.
- UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetContext):
- UIProcess/API/C/WKPageNamespace.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::getStatistics):
- UIProcess/WebContext.h:
- UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::getStatistics):
- UIProcess/WebPageNamespace.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getStatistics):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::numberOfPages):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
WebKitTools:
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate showStatisticsWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
- MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
- MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
- MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
(-[BrowserStatisticsWindowController windowDidLoad]):
(-[BrowserStatisticsWindowController refreshStatistics:]):
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/English.lproj/MainMenu.xib:
- MiniBrowser/mac/MiniBrowser_Prefix.pch:
- 1:50 PM Changeset in webkit [58116] by
-
- 2 edits in trunk/JavaScriptCore
- API/JSWeakObjectMapRefPrivate.cpp:
Reviewed by NOBODY (windows build fix).
- 1:42 PM Changeset in webkit [58115] by
-
- 3 edits in trunk/JavaScriptCore
- API/JSBase.cpp:
- API/JSCallbackObject.cpp:
Reviewed by NOBODY (windows build fix).
- 1:31 PM Changeset in webkit [58114] by
-
- 15 edits1 add in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37978
Unify JSC::IdentifierTable and WebCore::AtomicStringTable implementations.
Reviewed by Geoff Garen.
These two classes both implement a HashSet of uniqued StringImpls, with
translator classes to avoid unnecessary object creation. The only difference
between the classes is which flag (isIdentifier or inTable) is set.
Combine the two classes using a template predicated on which flag to use.
New class AtomicStringTable created, containing all the goodness from
IdentifierTable & AtomicStringTable, expect for Identifier's literalTable,
which has been moved onto JSGlobalData. Removed duplicate string translator
classes. Renamed StringImpl's inTable flag to more explicit 'isAtomic',
and set this on the empty string (which matches Identifier behaviour, and
removes a redundant check for zero-length).
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Identifier.cpp:
(JSC::createLiteralTable):
(JSC::deleteLiteralTable):
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
- runtime/Identifier.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- wtf/WTFThreadData.h:
(WTF::WTFThreadData::atomicStringTable):
- wtf/text/AtomicString.cpp:
(WebCore::table):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):
- wtf/text/AtomicStringTable.h: Added.
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::IdentifierOrAtomicStringTable::remove):
(WTF::::~IdentifierOrAtomicStringTable):
(WTF::::add):
(WTF::::find):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
(WebCore::equal):
- wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase):
- 1:17 PM Changeset in webkit [58113] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 MORITA Hajime <morrita@google.com>
Not reviewed.
Picked a review feedback left on:
https://bugs.webkit.org/show_bug.cgi?id=37056
LayoutTests/editing/selection/move-left-right.html is slow
- editing/selection/move-left-right.html:
- 1:12 PM Changeset in webkit [58112] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
when PluginsEnabled is false.
2010-04-22 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Fix createPlugin() tests in tst_qwebpage to match behaviour of Qt plugins
when PluginsEnabled is false.
tst_qwebpage should have been updated as part of r56662.
(See https://bugs.webkit.org/show_bug.cgi?id=32196)
Updated documentation of QWebPage::createPlugin and QWebSetting::pluginsEnabled
to match the new behaviour.
- Api/qwebpage.cpp: Update docs.
- Api/qwebsettings.cpp: Update docs.
- tests/qwebpage/tst_qwebpage.cpp: (createPlugin): (tst_QWebPage::createPluginWithPluginsEnabled): (tst_QWebPage::createPluginWithPluginsDisabled):
- 1:03 PM Changeset in webkit [58111] by
-
- 39 edits2 adds in trunk
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Add test for icon change notifications.
- fast/dom/icon-url-property-expected.txt: Added.
- fast/dom/icon-url-property.html: Added.
- Skipped on all platforms but Win
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Test: fast/dom/icon-url-property.html
- dom/Document.cpp: (WebCore::Document::setIconURL):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setIconURL):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::iconURL):
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- public/WebFrameClient.h: (WebKit::WebFrameClient::didChangeIcons):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
- src/FrameLoaderClientImpl.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/FrameLoaderClientGtk.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons): (WebCore::FrameLoaderClientQt::didChangeTitle):
- WebCoreSupport/FrameLoaderClientQt.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
- Interfaces/IWebFrameLoadDelegatePrivate2.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp: (WebFrame::didChangeIcons):
- WebFrame.h:
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Add test support for icon changes.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpIconChangesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpIconChanges): (LayoutTestController::setDumpIconChanges):
- DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didChangeIcons):
- DumpRenderTree/win/FrameLoadDelegate.h:
- WinLauncher/WinLauncher.h: (WinLauncherWebHost::didChangeIcons):
- 12:55 PM Changeset in webkit [58110] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
- wtf/MathExtras.h:
- 12:46 PM Changeset in webkit [58109] by
-
- 3 edits in trunk/LayoutTests
2010-04-22 Eric Carlson <eric.carlson@apple.com>
Test fix, no review.
https://bugs.webkit.org/show_bug.cgi?id=38000
r58107 causes video-play-stall and video-play-stall-seek to fail
Skip http/tests/media/video-play-stall.html and http/tests/media/video-play-stall-seek.html
until we can figure out how to work around QuickTime bug.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 12:39 PM Changeset in webkit [58108] by
-
- 10 edits2 adds in trunk
WebCore:
2010-04-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Extend the bindings to cover most of Document.idl
- GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
- bindings/gobject/WebKitDOMBinding.h:
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Added. (WebKit::createAnchorWrapper): (WebKit::createAppletWrapper): (WebKit::createAreaWrapper): (WebKit::createBaseWrapper): (WebKit::createBaseFontWrapper): (WebKit::createBlockquoteWrapper): (WebKit::createBodyWrapper): (WebKit::createBRWrapper): (WebKit::createButtonWrapper): (WebKit::createCanvasWrapper): (WebKit::createTableCaptionWrapper): (WebKit::createTableColWrapper): (WebKit::createModWrapper): (WebKit::createDirectoryWrapper): (WebKit::createDivWrapper): (WebKit::createDListWrapper): (WebKit::createEmbedWrapper): (WebKit::createFieldSetWrapper): (WebKit::createFontWrapper): (WebKit::createFormWrapper): (WebKit::createFrameWrapper): (WebKit::createFrameSetWrapper): (WebKit::createHeadingWrapper): (WebKit::createHeadWrapper): (WebKit::createHRWrapper): (WebKit::createHtmlWrapper): (WebKit::createIFrameWrapper): (WebKit::createImageWrapper): (WebKit::createInputWrapper): (WebKit::createIsIndexWrapper): (WebKit::createLabelWrapper): (WebKit::createLegendWrapper): (WebKit::createLIWrapper): (WebKit::createLinkWrapper): (WebKit::createMapWrapper): (WebKit::createMarqueeWrapper): (WebKit::createMenuWrapper): (WebKit::createMetaWrapper): (WebKit::createObjectWrapper): (WebKit::createOListWrapper): (WebKit::createOptGroupWrapper): (WebKit::createOptionWrapper): (WebKit::createParagraphWrapper): (WebKit::createParamWrapper): (WebKit::createPreWrapper): (WebKit::createQuoteWrapper): (WebKit::createScriptWrapper): (WebKit::createSelectWrapper): (WebKit::createStyleWrapper): (WebKit::createTableWrapper): (WebKit::createTableSectionWrapper): (WebKit::createTableCellWrapper): (WebKit::createTextAreaWrapper): (WebKit::createTitleWrapper): (WebKit::createTableRowWrapper): (WebKit::createUListWrapper): (WebKit::createHTMLElementWrapper):
- bindings/gobject/WebKitHTMLElementWrapperFactory.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
- dom/Node.idl:
WebKit/gtk:
2010-04-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Add webkit_web_view_get_document to retrieve the WebKitDOMDocument
from a WebKitWebView, and a very simple test for it.
- tests/testwebview.c:
- webkit/webkitwebview.cpp: (webkit_web_view_get_document):
- webkit/webkitwebview.h:
- 11:06 AM Changeset in webkit [58107] by
-
- 3 edits in trunk/WebCore
2010-04-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Do not pause movie when readyState drops below HAVE_FUTURE_DATA
https://bugs.webkit.org/show_bug.cgi?id=37991
<rdar://problem/7893937>
No new tests, we don't have infrastructure in DRT to test with streamed
movies.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_readyStateMaximum. (WebCore::HTMLMediaElement::prepareForLoad): Reset m_readyStateMaximum. (WebCore::HTMLMediaElement::setReadyState): Maintain m_readyStateMaximum. (WebCore::HTMLMediaElement::potentiallyPlaying): Also return true if the readyState was previously >= HAVE_FUTURE_DATA.
- html/HTMLMediaElement.h:
- 10:57 AM Changeset in webkit [58106] by
-
- 4 edits in trunk/WebKit
2010-04-22 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Update EFL port files to match recent API changes.
http://webkit.org/b/37876
- efl/WebCoreSupport/ChromeClientEfl.cpp: (kit): Added. (WebCore::ChromeClientEfl::ChromeClientEfl): Coding style fix. (WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel): Coding style fix. (WebCore::ChromeClientEfl::mouseDidMoveOverElement): Coding style fix. (WebCore::ChromeClientEfl::runOpenPanel): Implemented. (WebCore::ChromeClientEfl::cancelGeolocationPermissionRequestForFrame): Stubbed. (WebCore::ChromeClientEfl::cancelGeolocationPermissionForFrame): Stubbed. (WebCore::ChromeClientEfl::invalidateContents): Stubbed. (WebCore::ChromeClientEfl::invalidateWindow): Stubbed. (WebCore::ChromeClientEfl::invalidateContentsAndWindow): Implemented. (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll): Implemented. (WebCore::ChromeClientEfl::scroll): Updated. (WebCore::ChromeClientEfl::iconForFiles): Stubbed. (WebCore::ChromeClientEfl::chooseIconForFiles): Stubbed.
- efl/WebCoreSupport/ChromeClientEfl.h: Add new method prototypes.
- efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::committedLoad): Call setEncoding() from FrameLoader::writer. (WebCore::FrameLoaderClientEfl::finishedLoading): Ditto. (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): Ditto. (WebCore::FrameLoaderClientEfl::setMainDocumentError): Ditto.
- 10:32 AM Changeset in webkit [58105] by
-
- 2 edits in trunk/WebKit/qt
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove translatable strings from the hybridPixmap test.
https://bugs.webkit.org/show_bug.cgi?id=37867
- tests/hybridPixmap/widget.ui:
- 10:13 AM Changeset in webkit [58104] by
-
- 3 edits in trunk/JavaScriptCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove dependency of JSC to QtGui
https://bugs.webkit.org/show_bug.cgi?id=37867
The patch also make sure that hal.h is in the include path on Symbian.
The dependency to QtGui took care of that before.
Patch by Thiago Macieira <thiago.macieira@nokia.com>
and Rohan McGovern <rohan.mcgovern@nokia.com>
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- 10:04 AM Changeset in webkit [58103] by
-
- 5 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression: framebufferRenderbuffer crashes with null renderBuffer
https://bugs.webkit.org/show_bug.cgi?id=37963
- fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Adding test cases for null renderbuffer input.
- fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Regression: framebufferRenderbuffer crashes with null renderBuffer
https://bugs.webkit.org/show_bug.cgi?id=37963
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Dealing with null renderbuffer input.
- 9:54 AM Changeset in webkit [58102] by
-
- 8 edits in trunk
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- fast/canvas/webgl/read-pixels-expected.txt: Add test case for the other supported format/type in readPixels (besides RGBA/UNSIGNED_BYTE); also, changed to a simpler test framework.
- fast/canvas/webgl/read-pixels.html: Ditto.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Remove error check because two enums are supported now. (WebCore::WebGLRenderingContext::getParameter): Add two enums. (WebCore::WebGLRenderingContext::readPixels): Fix a tiny bug.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getIntegerv): Emulate two enums.
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
https://bugs.webkit.org/show_bug.cgi?id=37281
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two enums.
- 9:50 AM Changeset in webkit [58101] by
-
- 2 edits in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed. Turns out we need to do more escaping because Ruby was
explanding our newlines, creating a syntax error.
- PrettyPatch/PrettyPatch.rb:
- 9:38 AM Changeset in webkit [58100] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Corrects symbols visibility for JavaScriptCore.
- JavaScriptCore.pro:
- 9:28 AM Changeset in webkit [58099] by
-
- 3 edits in trunk/LayoutTests
2010-04-22 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Enable LayoutTests for EventSource on chromium
https://bugs.webkit.org/show_bug.cgi?id=37863
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:46 AM Changeset in webkit [58098] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK_ROLE_COMBO_BOX.
- tests/testatkroles.c: (test_webkit_atk_get_role_combobox): (main):
- 8:36 AM Changeset in webkit [58097] by
-
- 2 edits in trunk/WebCore
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[GTK] Mute/unmute button on <video> elements are backwards
https://bugs.webkit.org/show_bug.cgi?id=33967
Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling):
- 7:56 AM Changeset in webkit [58096] by
-
- 13 edits in trunk/WebKit/qt
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix autotests .qrc file paths when built in Qt.
Compiling auto-tests from qt/tests/auto/qweb* produced
failing tests since these .pro files include the
ones in WebKit/qt/tests and the .qrc file was
not added to RESOURCES
- tests/benchmarks/loading/loading.pro:
- tests/benchmarks/painting/painting.pro:
- tests/qgraphicswebview/qgraphicswebview.pro:
- tests/qwebelement/qwebelement.pro:
- tests/qwebframe/qwebframe.pro:
- tests/qwebhistory/qwebhistory.pro:
- tests/qwebhistoryinterface/qwebhistoryinterface.pro:
- tests/qwebinspector/qwebinspector.pro:
- tests/qwebpage/qwebpage.pro:
- tests/qwebplugindatabase/qwebplugindatabase.pro:
- tests/qwebview/qwebview.pro:
- tests/tests.pri:
- 7:46 AM Changeset in webkit [58095] by
-
- 2 edits in trunk/WebCore
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Eric Seidel.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r58043 with fix for EFL.
- plugins/PluginViewNone.cpp:
- 7:36 AM Changeset in webkit [58094] by
-
- 3 edits in trunk/WebCore
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_COMBO_BOX.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- 6:50 AM Changeset in webkit [58093] by
-
- 15 edits11 moves1 delete in trunk/WebCore
2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986
No functional changes, just move the SVGPaintServer* classes from svg/graphics/ to rendering/, the new location for the RenderSVGResource* classes.
This is a preparation for the real patch which follows soon.
- Android.mk: Rename files and move to the right location.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderSVGResource.cpp: Copied from svg/graphics/SVGPaintServer.cpp.
- rendering/RenderSVGResourceGradient.cpp: Copied from svg/graphics/SVGPaintServerGradient.cpp.
- rendering/RenderSVGResourceGradient.h: Copied from svg/graphics/SVGPaintServerGradient.h.
- rendering/RenderSVGResourceLinearGradient.cpp: Copied from svg/graphics/SVGPaintServerLinearGradient.cpp.
- rendering/RenderSVGResourceLinearGradient.h: Copied from svg/graphics/SVGPaintServerLinearGradient.h.
- rendering/RenderSVGResourcePattern.cpp: Copied from svg/graphics/SVGPaintServerPattern.cpp.
- rendering/RenderSVGResourcePattern.h: Copied from svg/graphics/SVGPaintServerPattern.h.
- rendering/RenderSVGResourceRadialGradient.cpp: Copied from svg/graphics/SVGPaintServerRadialGradient.cpp.
- rendering/RenderSVGResourceRadialGradient.h: Copied from svg/graphics/SVGPaintServerRadialGradient.h.
- rendering/RenderSVGResourceSolidColor.cpp: Copied from svg/graphics/SVGPaintServerSolid.cpp.
- rendering/RenderSVGResourceSolidColor.h: Copied from svg/graphics/SVGPaintServerSolid.h.
- rendering/SVGRenderTreeAsText.cpp: Change include file names.
- svg/SVGFont.cpp: Ditto.
- svg/SVGGradientElement.cpp: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGLinearGradientElement.cpp: Ditto.
- svg/SVGPatternElement.cpp: Ditto.
- svg/SVGPatternElement.h: Ditto.
- svg/SVGRadialGradientElement.cpp: Ditto.
- svg/graphics/SVGPaintServer.cpp: Removed.
- svg/graphics/SVGPaintServerGradient.cpp: Removed.
- svg/graphics/SVGPaintServerGradient.h: Removed.
- svg/graphics/SVGPaintServerLinearGradient.cpp: Removed.
- svg/graphics/SVGPaintServerLinearGradient.h: Removed.
- svg/graphics/SVGPaintServerPattern.cpp: Removed.
- svg/graphics/SVGPaintServerPattern.h: Removed.
- svg/graphics/SVGPaintServerRadialGradient.cpp: Removed.
- svg/graphics/SVGPaintServerRadialGradient.h: Removed.
- svg/graphics/SVGPaintServerSolid.cpp: Removed.
- svg/graphics/SVGPaintServerSolid.h: Removed.
- svg/graphics/SVGResourceListener.h: Removed.
- 6:34 AM Changeset in webkit [58092] by
-
- 2 edits in trunk/WebCore
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Hide the OpenGL and QtMultimedia dependencies from syncqt.
This prevents the dependent headers from being included by
qt/include/QtWebKit/QtWebKit
- WebCore.pro:
- 6:24 AM Changeset in webkit [58091] by
-
- 4 edits in trunk/JavaScriptCore
2010-04-22 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Use BLX and BX to keep happy the return stack predictor above ARMv4
https://bugs.webkit.org/show_bug.cgi?id=37862
Inspired by Jacob Bramley's patch from JaegerMonkey
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h: (JSC::ARMAssembler::): (JSC::ARMAssembler::bx): (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::jmp): (JSC::ARMAssembler::getLdrImmAddress):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::jump): (JSC::MacroAssemblerARM::nearCall): (JSC::MacroAssemblerARM::call): (JSC::MacroAssemblerARM::ret): (JSC::MacroAssemblerARM::prepareCall): (JSC::MacroAssemblerARM::call32):
- 5:28 AM Changeset in webkit [58090] by
-
- 2 edits in trunk/LayoutTests
2010-04-22 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Turn on antialias and stencil as default canvas attributes.
https://bugs.webkit.org/show_bug.cgi?id=36972
- fast/canvas/webgl/resources/webgl-test.js: (create3DContext): Turn on antialias and stencil as default canvas attributes.
- 5:09 AM Changeset in webkit [58089] by
-
- 2 edits in trunk/WebCore
2010-04-22 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
EFL does not support PluginDatabase yet.
http://webkit.org/b/37854
No behavior changes, so no new tests were added.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 5:08 AM Changeset in webkit [58088] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Script fix. Will ask dpranke to look tomorrow.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
The bots are seeing cases where .error is sometimes empty.
Lets make the code not crash in that case for now.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 4:21 AM Changeset in webkit [58087] by
-
- 4 edits in trunk/WebCore
2010-04-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Timeline scrolling speed is slow if it has more than 1k timeline marks.
https://bugs.webkit.org/show_bug.cgi?id=37924
- inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDividers):
- inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateEventDividers): (WebInspector.TimelinePanel.prototype._refresh):
- 4:15 AM Changeset in webkit [58086] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
- 4:11 AM Changeset in webkit [58085] by
-
- 24 edits in trunk
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Unreviewed expected results update.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/media/print-restores-previous-mediatype-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
2010-04-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::styleMedia):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 3:41 AM Changeset in webkit [58084] by
-
- 2 edits in trunk/WebCore
2010-04-22 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Do not pass empty handle into SetHiddenValue which would crash.
https://bugs.webkit.org/show_bug.cgi?id=37801
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): add couple of asserts to check for unexpected paths (WebCore::V8AbstractEventListener::invokeEventHandler): bail out of jsEvent is empty handle
- 3:31 AM Changeset in webkit [58083] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK_ROLE_SEPARATOR.
- tests/testatkroles.c: (test_webkit_atk_get_role_separator): (main):
- 3:19 AM Changeset in webkit [58082] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
- 3:00 AM Changeset in webkit [58081] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
- 2:59 AM Changeset in webkit [58080] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Restore the Leopard bots to using
old-run-webkit-tests for now.
- Scripts/run-webkit-tests:
- 2:48 AM Changeset in webkit [58079] by
-
- 2 edits in trunk/WebKitTools
Unreviewed fix.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
- 2:38 AM Changeset in webkit [58078] by
-
- 3 edits in trunk/WebCore
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Implement ImageBuffer support
https://bugs.webkit.org/show_bug.cgi?id=35288
Covered by existing tests.
Complete implementation of ImageBuffer for Haiku. Uses StillImage
class to export a WebCore::Image and associated GraphicsContext
to perform arbitrary drawing in the offscreen BBitmap buffer.
- platform/graphics/haiku/ImageBufferData.h:
- platform/graphics/haiku/ImageBufferHaiku.cpp, (WebCore::ImageBufferData::ImageBufferData), (WebCore::ImageBufferData::~ImageBufferData), (WebCore::ImageBuffer::ImageBuffer), (WebCore::ImageBuffer::~ImageBuffer), (WebCore::ImageBuffer::context), (WebCore::ImageBuffer::image):
Implementation uses offscreen BBitmap and BView, wraps StillImage
around those to provide WebCore::Image interface.
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::convertFromData):
Method just performs BGRA <-> RGBA conversion.
(WebCore::convertFromInternalData):
Method just performs BGRA <-> RGBA conversion and handles
pre-multiplying the color values if requested.
(WebCore::convertToInternalData):
Method just performs BGRA <-> RGBA conversion and handles
de.multiplying the color values if requested.
(WebCore::getImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::getUnmultipliedImageData),
(WebCore::ImageBuffer::getPremultipliedImageData):
Implemented.
(WebCore::putImageData):
Common code for the next two methods.
(WebCore::ImageBuffer::putUnmultipliedImageData),
(WebCore::ImageBuffer::putPremultipliedImageData):
Implemented.
(WebCore::ImageBuffer::toDataURL):
Uses Haiku "Translation Kit" to convert image data to data
of the requested mime type.
- 2:34 AM Changeset in webkit [58077] by
-
- 6 edits in trunk/WebKitTools
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664
Move cygwin setup logic in chromium_win.py.
- Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
- Scripts/new-run-webkit-websocketserver: add --chromium flag
- Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
- Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
- Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
- 2:20 AM Changeset in webkit [58076] by
-
- 3 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Fix the log message to explain that this is stderr output, not test output.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Be sure to reset the server_process.error after reading (seems like the wrong place to do this, but at least this fixes the bug and dpranke and I can talk about better designs later).
- Also remove the #EOF from the stderr output before returning it.
- 2:12 AM Changeset in webkit [58075] by
-
- 2 edits1 add in trunk/BugsSite
2010-04-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Hack up PrettyDiff to allow line-by-line comments
https://bugs.webkit.org/show_bug.cgi?id=37886
Admittedly a bit of a hack, this is a basic line-by-line editor we can
play with thanks to Andrew Scherkus. It's meant to integrate with the
"review" page at bugs.webkit.org.
I changed a few things from Andrew's original version:
1) Trigger text boxes on single click to make iPhone/iPad reviewing
easier.
2) Clear the main text box on load.
3) Reference a version of prototype.js on bugs.webkit.org.
- PrettyPatch/PrettyPatch.rb:
- prototype.js: Added.
- 1:29 AM Changeset in webkit [58074] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing new-run-webkit-tests on the bots.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Fixing _compat_shim_option to take variable keyword args.
- Turns out that nargs + callback is ignored unless type is specified. So I added the type so that the option was properly consumed. This was why new-run-webkit-tests couldn't find any tests, it was looking for them under "20" because that was the argument which should have been consumed by --exit-after-n-failures.
- 1:03 AM Changeset in webkit [58073] by
-
- 2 edits in trunk/WebKitTools
2010-04-22 Tony Chang <tony@chromium.org>
Not reviewed, build fix for chromium Windows.
[chromium] fix ImageDiff compile on windows
https://bugs.webkit.org/show_bug.cgi?id=37979
- DumpRenderTree/chromium/ImageDiff.cpp:
- 12:50 AM Changeset in webkit [58072] by
-
- 42 edits3 deletes in trunk
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- editing/execCommand/clipboard-access-expected.txt: Removed.
- editing/execCommand/clipboard-access.html: Removed.
- editing/execCommand/script-tests/clipboard-access.js: Removed.
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- WebCore.base.exp:
- editing/EditorCommand.cpp: (WebCore::supportedPaste): (WebCore::createCommandMap):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::overridePreference):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- 12:40 AM Changeset in webkit [58071] by
-
- 4 edits in trunk/WebKitTools
2010-04-22 Eric Seidel <eric@webkit.org>
Unreviewed. Just adding logging.
Adding logging to help debug why the Leopard Bot
can't find any tests to run.
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Make it a fatal error to have no tests to run.
- 12:40 AM Changeset in webkit [58070] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-22 Tony Chang <tony@chromium.org>
Reviewed by Shinichiro Hamaji.
[chromium] roll chromium deps to pick up some windows build fixes
https://bugs.webkit.org/show_bug.cgi?id=37972
- DEPS:
- 12:37 AM Changeset in webkit [58069] by
-
- 42 edits3 adds in trunk
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Manual test to verify that javascript cannot access clipboard.
https://bugs.webkit.org/show_bug.cgi?id=27751
- editing/execCommand/clipboard-access-expected.txt: Added.
- editing/execCommand/clipboard-access.html: Added.
- editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled): (runTest):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
Test: editing/execCommand/clipboard-access.html
- WebCore.base.exp:
- editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
- page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
- src/WebSettingsImpl.h:
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
https://bugs.webkit.org/show_bug.cgi?id=27751
- DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
- 12:29 AM Changeset in webkit [58068] by
-
- 2 edits in trunk/WebCore
2010-04-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
[Haiku] Improve SimpleFontDataHaiku
https://bugs.webkit.org/show_bug.cgi?id=37411
Covered by existing tests.
- platform/graphics/haiku/SimpleFontDataHaiku.cpp:
- Cleaned up includes
- Removed prototype "charUnicodeToUTF8HACK"
(WebCore::SimpleFontData::platformInit):
- Use const BFont pointer
(WebCore::SimpleFontData::smallCapsFontData):
- "fontPlatformData" was leaked. It is only used as the key for the font cache lookup.
(WebCore::SimpleFontData::platformMetricsForGlyph):
- Use existing WebCore encoding infrastructure instead of adding a hack for Haiku.
- 12:11 AM Changeset in webkit [58067] by
-
- 3 edits in trunk/WebKit/win
Reference count WebView's backing store bitmap to prevent
deleteBackingStore() from freeing the bitmap while it is still being
referenced by Core Animation.
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37954
- WebView.cpp:
(WebView::ensureBackingStore):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::updateBackingStore):
(WebView::paint):
(WebView::backingStore):
(releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
Animation has dropeed its reference to the memory.
(WebView::updateRootLayerContents): ref m_backingStoreBitmap before
passing the memory to Core Animation to prevent deleteBackingStore()
from freeing it while it is still referenced by CA.
- WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
Apr 21, 2010:
- 11:59 PM Changeset in webkit [58066] by
-
- 3 edits in trunk/WebKitTools
2010-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch can't fetch attachments on security bugs
https://bugs.webkit.org/show_bug.cgi?id=37975
Instead of calling CURL, we just need to use our Mechanize object,
which understand bugs.webkit.org authentication.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/net/bugzilla.py:
- 11:50 PM Changeset in webkit [58065] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-21 Tony Chang <tony@chromium.org>
Reviewed by Shinichiro Hamaji.
[chromium] gyp_webkit should be executable
https://bugs.webkit.org/show_bug.cgi?id=37971
- gyp_webkit: Added property svn:executable.
- 11:49 PM Changeset in webkit [58064] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
URL LayoutTests don't run on Firefox
https://bugs.webkit.org/show_bug.cgi?id=37974
It turns out Firefox doesn't handle base URLs properly if we go through
the DOM to create the <base> and <a> elements. If we switch to
document.write, we can run the tests in Firefox (even though
document.write is lame).
- fast/url/resources/utilities.js: (canonicalize): (setBaseURL):
- 11:48 PM Changeset in webkit [58063] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Temporary commit, will roll-out before morning.
Turning on new-run-webkit-tests for the Leopard build bot
for testing of the harness.
Users should not noctice (except for the results.html difference).
- Scripts/run-webkit-tests:
- 11:38 PM Changeset in webkit [58062] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Fix typo in my previous fix attempt.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
More on-the-bot debugging, sigh. I wish I had a local build.
- Scripts/webkitpy/layout_tests/port/base.py:
- 11:32 PM Changeset in webkit [58061] by
-
- 3 edits in trunk/WebCore
2010-04-21 Steve Block <steveblock@google.com>
Reviewed by Kenneth Rohde Christiansen.
Replace Geolocation::suspend()/resume() which are required by Android.
https://bugs.webkit.org/show_bug.cgi?id=37942
These methods were removed in Bug 36255.
Build fix only, no new tests.
- page/Geolocation.cpp: (WebCore::Geolocation::suspend): (WebCore::Geolocation::resume):
- page/Geolocation.h:
- 11:29 PM Changeset in webkit [58060] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Fix typo in my previous fix attempt.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/port/base.py:
- Add self. to class variable access.
- 11:18 PM Changeset in webkit [58059] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Another attempt to fix NRWT for chromium.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/port/base.py:
- wdiff_text was returning a byte array instead of a unicode string. The simple fix was to just decode the result. However, seeing so much duplicated code with Executive made me cry, so I re-wrote the function to be more like pretty_patch_text and use run_command (which already knows how to handle unicode).
- 11:02 PM Changeset in webkit [58058] by
-
- 3 edits in trunk/LayoutTests
2010-04-21 Ben Murdoch <benm@google.com>
Reviewed by Jeremy Orlow.
send-oncancel-event touch test should use js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=37830
Restore reference to js-test-post-function removed erroneously in copy
when this test was move in http://trac.webkit.org/changeset/54253
and the corresponding call to the isSuccessfullyParsed function.
- fast/events/touch/script-tests/send-oncancel-event.js: (touchcancelHandler): Call isSuccessfullyParsed.
- fast/events/touch/send-oncancel-event.html: Add js-test-post-function.js back.
- 10:49 PM Changeset in webkit [58057] by
-
- 2 edits in trunk/WebCore
2010-04-21 Ray Rischpater <Raymond.Rischpater@Nokia.com>
In HTMLInputElement.cpp there are numerous style
violations.
This patch includes style changes to fix existing style
deviations in this file.
Rubber stamped by Darin Adler.
- html/HTMLInputElement.cpp:
- 10:49 PM Changeset in webkit [58056] by
-
- 3 edits in trunk/WebKitTools
2010-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Windows tests buildbots are too slow to be core builders
https://bugs.webkit.org/show_bug.cgi?id=37970
It's 10:45. The Windows test bots are still hours behind. They're too
slow to be core builders. When they get fast, we can add them back.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 10:49 PM Changeset in webkit [58055] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt one more time to fix NRWT for chromium.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
I'm debugging in the blind because I don't have a chromium
build on this laptop.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Apply the previous fix to a second caller.
- 10:40 PM Changeset in webkit [58054] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt one more time to fix NRWT for chromium.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Fix handling of test_shell output so that we always decode it as utf-8. Unlike DumpRenderTree test_shell does not ever return pixel data. It spits out the pixel dumps in a separate file, thus all output over stdout is utf-8 text.
- 10:39 PM Changeset in webkit [58053] by
-
- 1 edit1 add in trunk/WebCore
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
Add missing EFL WebCore file.
http://webkit.org/b/37854
No behavior changes, so no new tests were added.
- bindings/js/ScriptControllerEfl.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
- 9:45 PM Changeset in webkit [58052] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=37964
Fix a typo in comments - Korean encoding name is windows-949, not windows-939
- WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
- 9:38 PM Changeset in webkit [58051] by
-
- 2 edits in trunk/WebCore
2010-04-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Printing Core Animation-based plug-ins is broken
https://bugs.webkit.org/show_bug.cgi?id=37967
When we do a "flattening" paint because of printing, we need to stash
the flattening flag in the FrameView's m_paintBehavior, because
WebBaseNetscapePluginView needs to find it there to decide whether
to grab a bitmap for printing, for CA plug-ins.
- page/FrameView.cpp: (WebCore::FrameView::paintContents):
- 9:30 PM Changeset in webkit [58050] by
-
- 4 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt one more time to fix NRWT for chromium.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Pass encoding to _save_baseline_data and write_output_files
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Make _save_baseline_data and write_output_files take an encoding.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- Pass encoding to _save_baseline_data and write_output_files
- 8:47 PM Changeset in webkit [58049] by
-
- 2 edits in trunk/WebCore
2010-04-21 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Fix to take into account a change made in "StringImpl".
https://bugs.webkit.org/show_bug.cgi?id=37763
- mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
- 8:40 PM Changeset in webkit [58048] by
-
- 3 edits in trunk/LayoutTests
2010-04-21 MORITA Hajime <morrita@google.com>
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=37056
LayoutTests/editing/selection/move-left-right.html is slow
Reduced style change that would trigger relayout. Note that You
might find that expectation looks storange. It is due to Bug
37016.
- editing/selection/move-left-right.html:
- platform/mac/editing/selection/move-left-right-expected.txt:
- 8:31 PM Changeset in webkit [58047] by
-
- 4 edits2 adds in trunk/WebKitTools
2010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher: make FPS measurement accurate
https://bugs.webkit.org/show_bug.cgi?id=37934
Instead of counting paints, which are not interchangeable with frames that
the user sees, we now set an arbitrary timer for FPS measurements. The idea is
that if the main thread is delayed for any reason, that timer would be delayed
as well.
- QtLauncher/QtLauncher.pro:
- QtLauncher/fpstimer.cpp: Added. (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::start): (FpsTimer::stop): (FpsTimer::timerEvent):
- QtLauncher/fpstimer.h: Added.
- QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled): (WebViewGraphicsBased::updateFrameRate): (WebViewGraphicsBased::paintEvent):
- QtLauncher/webview.h:
- 8:22 PM Changeset in webkit [58046] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-21 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Don't notify the WebView that a popup was
opened when the popup is handled externally, as the popup
is in that case transparent to the WebView.
The notification was causing an ASSERT on Mac (where
the popup is handled externally) as there would be no
notification that the popup was closed.
https://bugs.webkit.org/show_bug.cgi?id=37825
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
- 8:18 PM Changeset in webkit [58045] by
-
- 8 edits1 move in trunk
JavaScriptCore: Export WTF::deleteOwnedPtr(HFONT).
Rubber stamped by Mark Rowe.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
WebCore: Create a template for creating reference-counted Windows GDI handles.
Refactor RefCountedHFONT to use this template.
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37952
No change in behavior.
- WebCore.vcproj/WebCore.vcproj: Add RefCountedHFONT.h
- platform/graphics/cairo/FontPlatformData.h:
(WebCore::FontPlatformData::hfont): Refactor to return m_hfont->handle() instead of m_hfont->hfont().
- platform/graphics/cg/FontPlatformData.h:
(WebCore::FontPlatformData::hfont): Same.
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Instantiate m_hfont with a RefCountedGDIHandle<HFONT>.
- platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Same.
- platform/graphics/win/RefCountedGDIHandle.h: Added. Interface is identical to RefCountedHFONT with exception of renaming hfont() to handle().
(WebCore::RefCountedGDIHandle::create):
(WebCore::RefCountedGDIHandle::createDeleted):
(WebCore::RefCountedGDIHandle::~RefCountedGDIHandle):
(WebCore::RefCountedGDIHandle::handle): Return the GDI handle.
(WebCore::RefCountedGDIHandle::hash):
(WebCore::RefCountedGDIHandle::RefCountedGDIHandle):
- platform/graphics/win/RefCountedHFONT.h: Removed.
- 8:16 PM Changeset in webkit [58044] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, just adding missing ":" in python file.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
new-run-webkit-tests --chromium was borked.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 7:51 PM Changeset in webkit [58043] by
-
- 4 edits in trunk/WebCore
2010-04-21 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621
No new tests, this is a build fix.
Re-submit r56585 with fix for Chromium.
- plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
- plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
- plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC) or PLATFORM(CHROMIUM)
- 7:48 PM Changeset in webkit [58042] by
-
- 6 edits4 adds in trunk
2010-04-21 David Yonge-Mallo <davinci@chromium.org>
Reviewed by Dan Bernstein.
ZWNJ - Display non-printing, invisible character
https://bugs.webkit.org/show_bug.cgi?id=16131
Fix the (non)display of glyphs for ZWJ and ZWNJ in simple font code path.
Tests: fast/text/format-control.html
fast/text/zero-width-characters.html
- platform/graphics/Font.h: (WebCore::Font::operator!=): (WebCore::Font::treatAsZeroWidthSpace): treat ZWNJ and ZWJ as ZWSP.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): added ZWNJ and ZWJ.
- platform/text/CharacterNames.h: added ZWNJ and ZWJ.
2010-04-21 David Yonge-Mallo <davinci@chromium.org>
Reviewed by Dan Bernstein.
ZWNJ - Display non-printing, invisible character
https://bugs.webkit.org/show_bug.cgi?id=16131
Added tests for the handling of ZWJ and ZWNJ characters in simple font
path. These characters have zero width but may change the widths of text
around them. Furthermore, their glyphs should not be displayed in
simple static text.
- fast/text/format-control.html: Added.
- fast/text/zero-width-characters.html: modified to test ZWSP, ZWJ, and ZWNJ.
- platform/mac/fast/text/format-control-expected.checksum: Added.
- platform/mac/fast/text/format-control-expected.png: Added.
- platform/mac/fast/text/format-control-expected.txt: Added.
- 7:41 PM Changeset in webkit [58041] by
-
- 2 edits in trunk/WebCore
2010-04-21 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
Fix webkit build problem when xhtmlmp enabled, which is introduced by revision 57927, for
bug fix of 37175 , which seperates DocumentWriter from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37915
No new tests since this only fixes the build problem.
- dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
- 7:17 PM Changeset in webkit [58040] by
-
- 6 edits in trunk/WebCore
2010-04-21 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Call sites of TextIterator constructor are difficult to read
https://bugs.webkit.org/show_bug.cgi?id=37909
Now we use enum parameters instead of boolean parameters and
boolean version of constructors are eliminated.
This change also changes the names of boolean members so they are
now third person singular.
No new tests because this is just a refactoring.
- WebCore.base.exp:
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleReplacedElement): (WebCore::TextIterator::shouldRepresentNodeOffsetZero): (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::TextIterator::emitCharacter): (WebCore::TextIterator::emitText): (WebCore::CharacterIterator::CharacterIterator): (WebCore::TextIterator::rangeLength): (WebCore::TextIterator::rangeFromLocationAndLength): (WebCore::findPlainText):
- editing/TextIterator.h: (WebCore::):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
- editing/visible_units.cpp: (WebCore::nextBoundary):
- 6:58 PM Changeset in webkit [58039] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Qt] Enable notifications layout tests that are passing.
Qt port has a partial implementation of Notifications,
see r57408.
- platform/qt/Skipped:
- 6:56 PM Changeset in webkit [58038] by
-
- 4 edits2 adds in trunk
2010-04-21 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Add PageClientQt files.
[Qt] PageClientQt specific implementation for QWidget
https://bugs.webkit.org/show_bug.cgi?id=37858
- WebCore.pro:
2010-04-21 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Add PageClientQWidget implementation based on the old
QWebPageWidgetClient to PageClientQt files. Also fix
QWebPage::setView() to use PageClientQWidget.
[Qt] PageClientQt specific implementation for QWidget
https://bugs.webkit.org/show_bug.cgi?id=37858
- Api/qwebpage.cpp: (QWebPage::setView):
- WebCoreSupport/PageClientQt.cpp: Added. (WebCore::PageClientQWidget::scroll): (WebCore::PageClientQWidget::update): (WebCore::PageClientQWidget::setInputMethodEnabled): (WebCore::PageClientQWidget::inputMethodEnabled): (WebCore::PageClientQWidget::setInputMethodHint): (WebCore::PageClientQWidget::cursor): (WebCore::PageClientQWidget::updateCursor): (WebCore::PageClientQWidget::palette): (WebCore::PageClientQWidget::screenNumber): (WebCore::PageClientQWidget::ownerWidget): (WebCore::PageClientQWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQWidget::pluginParent): (WebCore::PageClientQWidget::style):
- WebCoreSupport/PageClientQt.h: Added. (WebCore::PageClientQWidget::PageClientQWidget): (WebCore::PageClientQWidget::isQWidgetClient):
- 6:46 PM Changeset in webkit [58037] by
-
- 3 edits in trunk/WebCore
2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_SEPARATOR.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- 6:34 PM Changeset in webkit [58036] by
-
- 48 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
Third time is the charm. I've fixed all the
new-run-webkit-tests regressions from previous attempts.
I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.
This fixes our Executive.run_command code to work around a Popen
bug http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.
Following the advice of:
http://farmdev.com/talks/unicode/
I have changed all of webkitpy to use unicode() objects as strings
instead of str objects (which in Python 3 are renamed "bytes").
String literals were left as "foo" instead of converting to u"foo"
as u"foo" is only required if the string has a non-ascii code point.
Python is smart about comparing str() and unicode() values and will
log an error to the console if the comparison is ever invalid.
Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.
I removed several uses of StringIO. StringIO should generally always be
passed a unicode() value.
Likewise I replaced most calls to open() with codecs.open().
codecs.open() matches Python 3 open semantics in requiring an encoding
parameter. Files opened with codecs.open() with a unicode-compatible
encoding will vend unicode() objects from their read() calls, like how
StringIO created with a unicode() object will do.
I also deployed "with" statements wider (now that the project has
settled on Python 2.5) to close a bunch of file descriptor leaks.
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Read/write utf-8 files instead of ascii.
- Update the tests to use test for proper unicode() handling.
- Scripts/webkitpy/common/checkout/changelog.py:
- Document that parse_latest_entry_from_file expects file-like objects which return unicode strings.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Use unicode() strings instead of str() byte arrays.
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Remove unneeded import.
- Scripts/webkitpy/common/checkout/scm.py:
- Remove use of str().
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Read/write utf-8 files and use unicode() strings in testing.
- Scripts/webkitpy/common/config/committers.py:
- Use \u instead of \x to make slightly clearer what we're doing.
- Scripts/webkitpy/common/net/bugzilla.py:
- Add a new _string_contents() method and explain why
we have to call unicode() on the result of soup.string
and why it's safe to do so w/o needing to pass a codec name.
- Remove the (unused) support for passing a file object to add_patch_to_bug().
- Scripts/webkitpy/common/net/buildbot.py:
- Use unicode() instead of str() when needing to coax a
NavigableString object into a unicode() object.
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Add a test which contains a unicode builder name.
- Scripts/webkitpy/common/net/statusserver.py:
- Remove use of str()
- Scripts/webkitpy/common/prettypatch.py:
- Write out the patch file as utf-8.
- Scripts/webkitpy/common/system/autoinstall.py:
- Write out files with a explicit encodings.
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/common/system/deprecated_logging.py:
- Write out log files as utf-8.
- Scripts/webkitpy/common/system/executive.py:
- Make run* properly take and return unicode() objects.
- Cleaned up input handling in run_command a little by adding a _compute_input() method which can return early instead of having such a long/cluttered if-block.
- Scripts/webkitpy/common/system/executive_unittest.py:
- Added a unit test to make sure we don't break Tor again!
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Write out the test list as utf-8.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Write out json files as utf-8.
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
- Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
- Scripts/webkitpy/layout_tests/port/mac.py: ditto.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Make the skipped file parsing test unicode.
- Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
- Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Make explicit the encodings of log files and pid files.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Make encodings explicit and deploy "with".
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
- Scripts/webkitpy/style/filereader_unittest.py: ditto.
- Scripts/webkitpy/thirdparty/init.py: ditto.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Removed extra import.
- Scripts/webkitpy/tool/commands/queues.py:
- No need to map args to strings now that run_command does.
- Update test results to match args changes.
- Document our global argument hacks.
- Scripts/webkitpy/tool/commands/upload.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/mocktool.py:
- Rename add_patch_to_bug argument to match bugzilla.py
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Executive.run_* now require lists instead of strings. The lack of this change was what broke webkit-patch for svn users the first time this was landed.
- Scripts/webkitpy/tool/steps/postdiff.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
- Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Fixed spurious logging seen when running test-webkitpy
- 6:30 PM Changeset in webkit [58035] by
-
- 2 edits in trunk/WebCore
2010-04-21 David Leong <david.leong@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian apps crash on exit due to a bad qObject_cast.
Added check for NULL to avoid the crash. Reworked to fix memory leak
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformDestroy):
- 6:03 PM Changeset in webkit [58034] by
-
- 1 edit11 adds in trunk/WebKit
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Nikolas Zimmermann.
Add missing EFL WebKit/efl theme files.
http://webkit.org/b/37854
- efl/DefaultTheme/default.edc: Added.
- efl/DefaultTheme/widget/button/button.edc: Added.
- efl/DefaultTheme/widget/check/check.edc: Added.
- efl/DefaultTheme/widget/combo/combo.edc: Added.
- efl/DefaultTheme/widget/entry/entry.edc: Added.
- efl/DefaultTheme/widget/file/file.edc: Added.
- efl/DefaultTheme/widget/radio/radio.edc: Added.
- efl/DefaultTheme/widget/scrollbar/scrollbar.edc: Added.
- efl/DefaultTheme/widget/search/cancel/search_cancel.edc: Added.
- efl/DefaultTheme/widget/search/decoration/search_decoration.edc: Added.
- efl/DefaultTheme/widget/search/field/search_field.edc: Added.
- 5:55 PM Changeset in webkit [58033] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 James Robinson <jamesr@chromium.org>
Unreviewed. Updating chromium test expecations.
- platform/chromium/test_expectations.txt:
- 5:27 PM Changeset in webkit [58032] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58028.
http://trac.webkit.org/changeset/58028
https://bugs.webkit.org/show_bug.cgi?id=37962
broke the chromium build (Requested by tonywork on #webkit).
- DEPS:
- 5:25 PM Changeset in webkit [58031] by
-
- 15 edits8 adds in trunk
aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112
Reviewed by Alexey Proskuryakov.
WebCore:
Change the method that DRT uses to monitor AX notifications so that its robust
by just sending out NSNotification that can be listened to by anyone, instead
of keeping a static function pointer around.
This change is aimed to avoid flakiness seen in DRT when the notification handlers
are not being called at the appropriate time.
Tests: platform/mac/accessibility/aria-liveregions-addedelement.html
platform/mac/accessibility/aria-liveregions-changedalt.html
platform/mac/accessibility/aria-liveregions-changedtext.html
platform/mac/accessibility/aria-liveregions-removedelement.html
- accessibility/mac/AccessibilityObjectWrapper.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):
WebKitTools:
Change the way that notifications are listened for by forcing clients
to call a remove listener as well to match the add listener. DRT will
assert if those are not done in the correct order.
- DumpRenderTree/AccessibilityUIElement.cpp:
(removeNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::removeNotificationListener):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(-[AccessibilityNotificationHandler initWithPlatformElement:]):
(-[AccessibilityNotificationHandler dealloc]):
(-[AccessibilityNotificationHandler _notificationReceived:]):
(-[AccessibilityNotificationHandler setCallback:]):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::removeNotificationListener):
LayoutTests:
Add four more tests that test specific live region functionality. Having these
four tests run in order seems to stress the notification mechanism and will expose issues
more frequently.
Modify tests that use notification listeners to also "removeNotificationListener".
- platform/mac-leopard/Skipped:
- platform/mac/accessibility/aria-listbox-selectedchildren-change.html:
- platform/mac/accessibility/aria-liveregion-on-image.html:
- platform/mac/accessibility/aria-liveregions-addedelement-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-addedelement.html: Added.
- platform/mac/accessibility/aria-liveregions-changedalt-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-changedalt.html: Added.
- platform/mac/accessibility/aria-liveregions-changedtext-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-changedtext.html: Added.
- platform/mac/accessibility/aria-liveregions-notifications.html:
- platform/mac/accessibility/aria-liveregions-removedelement-expected.txt: Added.
- platform/mac/accessibility/aria-liveregions-removedelement.html: Added.
- platform/mac/accessibility/change-notification-on-scroll.html:
- 5:18 PM Changeset in webkit [58030] by
-
- 3 edits in trunk/LayoutTests
2010-04-21 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Fix up notifications request permission test.
https://bugs.webkit.org/show_bug.cgi?id=37959
- fast/notifications/notifications-request-permission-expected.txt:
- fast/notifications/notifications-request-permission.html:
- 5:16 PM Changeset in webkit [58029] by
-
- 2 edits in trunk/WebCore
Remove old exports.
Reviewed by NOBODY (Leopard build fix).
- WebCore.base.exp:
- 5:15 PM Changeset in webkit [58028] by
-
- 2 edits in trunk/WebKit/chromium
2010-04-21 Evan Martin <evan@chromium.org>
Unreviewed, just a dependency change.
[chromium] roll skia forward to r538
https://bugs.webkit.org/show_bug.cgi?id=37960
This will cause a bunch of pixel tests to fail due to bulleted
lists rendering slightly differently. I will grab new baselines
from the bots and check them in in a followup.
- DEPS:
- 4:59 PM Changeset in webkit [58027] by
-
- 3 edits in trunk/WebCore
Bug 37949 - Do no copy strings into a shared buffer when converting UStrings to Strings
UString and String now have the same internal representation; Just re-wrap the internal impl.
Reviewed by Darin Adler.
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase):
- bindings/js/JSDOMBinding.h:
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
- 4:59 PM Changeset in webkit [58026] by
-
- 3 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Make SmallStrings store an array of RefPtr<StringImpl>,
instead of a direct array of StringImpls. This allows
us to remove a friend (and a layering violation) from
WTF::StringImpl, and makes it so that all StringImpls
are individually heap allocated.
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::rep):
(JSC::SmallStringsStorage::SmallStringsStorage):
- wtf/text/StringImpl.h:
- 4:54 PM Changeset in webkit [58025] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
Tweaked the test to pass on Tiger.
- http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html: Tiger synchronous loader wrongfully terats 401 response as a failure. While this causes incorrect behavior for XMLHttpRequest, it's acceptable for the purposes of this test.
- 4:39 PM Changeset in webkit [58024] by
-
- 4 edits in trunk/WebKitTools
2010-04-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add debug menu items to show/hide the Web View.
https://bugs.webkit.org/show_bug.cgi?id=37958
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController showHideWebView:]): (-[BrowserWindowController removeReinsertWebView:]): (-[BrowserWindowController validateMenuItem:]):
- MiniBrowser/mac/English.lproj/MainMenu.xib:
- 4:22 PM Changeset in webkit [58023] by
-
- 47 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed. Rolling out unicode() changes as they broke NRWT for chromium.
Rolling out:
http://trac.webkit.org/changeset/58014
http://trac.webkit.org/changeset/58016
http://trac.webkit.org/changeset/58020
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/common/prettypatch.py:
- Scripts/webkitpy/common/system/autoinstall.py:
- Scripts/webkitpy/common/system/deprecated_logging.py:
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/qt.py:
- Scripts/webkitpy/layout_tests/port/server_process.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- Scripts/webkitpy/style/filereader_unittest.py:
- Scripts/webkitpy/thirdparty/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/postdiff.py:
- Scripts/webkitpy/tool/steps/postdiffforcommit.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 4:20 PM Changeset in webkit [58022] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix.
- Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
- 4:16 PM Changeset in webkit [58021] by
-
- 5 edits7 moves in trunk/LayoutTests
2010-04-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Enable the notifications layout tests, but skip them on the ports that don't
implement notifications.
https://bugs.webkit.org/show_bug.cgi?id=37667
- fast/notifications/notifications-check-permission.html: Added.
- fast/notifications/notifications-check-permission.html-disabled: Removed.
- fast/notifications/notifications-display-close-events.html: Added.
- fast/notifications/notifications-display-close-events.html-disabled: Removed.
- fast/notifications/notifications-double-show.html: Added.
- fast/notifications/notifications-double-show.html-disabled: Removed.
- fast/notifications/notifications-no-icon.html: Added.
- fast/notifications/notifications-no-icon.html-disabled: Removed.
- fast/notifications/notifications-request-permission.html: Added.
- fast/notifications/notifications-request-permission.html-disabled: Removed.
- fast/notifications/notifications-with-permission.html: Added.
- fast/notifications/notifications-with-permission.html-disabled: Removed.
- fast/notifications/notifications-without-permission.html: Added.
- fast/notifications/notifications-without-permission.html-disabled: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 4:12 PM Changeset in webkit [58020] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, fixing NRWT for real this time.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Add a hack to fix new-run-webkit-tests my understanding of codecs.open(encoding=None) must have been wrong.
- 4:11 PM Changeset in webkit [58019] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-21 Evan Stade <estade@chromium.org>
Reviewed by Darin Fisher.
[chromium] Web page serializer saves tag names in upper case
https://bugs.webkit.org/show_bug.cgi?id=37940
Simply convert all tags to lower case.
This is tested by chrome tests:
- save page browser tests
- encoding ui tests
- web page serializer test shell tests
- src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString):
- 4:07 PM Changeset in webkit [58018] by
-
- 3 edits1 add in trunk
<rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
Reviewed by Eric Carlson.
WebCore:
A manual test case is required here as the Flip4Mac plug-in displays an alert, and some manual tweaking of the plug-in's
preference file on disk is often required to reproduce the bug.
- manual-tests/plugins/flip4mac-update-alert-over-navigation.html: Added.
WebKit/mac:
Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).
The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
no other references to keep the object alive.
We work around this bug by patching the following two messages:
1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]
Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.
Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).
These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.
- Plugins/WebPluginController.mm:
(-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
install our workaround if it is.
(isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
(WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
(WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
delegate if this NSAlert belongs to the Flip4Mac plug-in.
(installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
the method we're interested in. In that case we want to bail out before patching any methods.
- 4:07 PM Changeset in webkit [58017] by
-
- 3 edits2 adds in trunk
<rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
Reviewed by Maciej Stachowiak.
WebCore:
This is a manual test case as I was not able to construct an automated test that reproduced the same issue without displaying
a modal dialog on-screen.
- manual-tests/plugins/timeout-dialog-displayed-over-navigation.html: Added.
- manual-tests/plugins/timeout-dialog-displayed-over-navigation.swf: Added.
WebKit/mac:
An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCInvalidateRect):
(WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
is already processing requests. This ensures that there will be no plug-in code on the stack when
the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
a modal dialog is displayed.
- 3:51 PM Changeset in webkit [58016] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing exception seen on builders.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Pass and encoding to _write_into_file_at_path
- 3:06 PM Changeset in webkit [58015] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 Simon Fraser <Simon Fraser>
Unreviewed; fix assertion in LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=37932
Assertion in transitions/transition-end-event-destroy-iframe.html
Now that composited iframes cause their parent document to enter compositing mode,
iframe painting via NSView does't send the required -viewWillDraw, which causes
this assertion. Disable the test until we figure out a solution.
- platform/mac-snowleopard/Skipped:
- 3:04 PM Changeset in webkit [58014] by
-
- 47 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.
This fixes our Executive.run_command code to work around a Popen
bug http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.
Following the advice of:
http://farmdev.com/talks/unicode/
I have changed all of webkitpy to use unicode() objects as strings
instead of str objects (which in Python 3 are renamed "bytes").
String literals were left as "foo" instead of converting to u"foo"
as u"foo" is only required if the string has a non-ascii code point.
Python is smart about comparing str() and unicode() values and will
log an error to the console if the comparison is ever invalid.
Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.
I removed several uses of StringIO. StringIO should generally always be
passed a unicode() value.
Likewise I replaced most calls to open() with codecs.open().
codecs.open() matches Python 3 open semantics in requiring an encoding
parameter. Files opened with codecs.open() with a unicode-compatible
encoding will vend unicode() objects from their read() calls, like how
StringIO created with a unicode() object will do.
I also deployed "with" statements wider (now that the project has
settled on Python 2.5) to close a bunch of file descriptor leaks.
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Read/write utf-8 files instead of ascii.
- Update the tests to use test for proper unicode() handling.
- Scripts/webkitpy/common/checkout/changelog.py:
- Document that parse_latest_entry_from_file expects file-like objects which return unicode strings.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Use unicode() strings instead of str() byte arrays.
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Remove unneeded import.
- Scripts/webkitpy/common/checkout/scm.py:
- Remove use of str().
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Read/write utf-8 files and use unicode() strings in testing.
- Scripts/webkitpy/common/config/committers.py:
- Use \u instead of \x to make slightly clearer what we're doing.
- Scripts/webkitpy/common/net/bugzilla.py:
- Add a new _string_contents() method and explain why
we have to call unicode() on the result of soup.string
and why it's safe to do so w/o needing to pass a codec name.
- Remove the (unused) support for passing a file object to add_patch_to_bug().
- Scripts/webkitpy/common/net/buildbot.py:
- Use unicode() instead of str() when needing to coax a
NavigableString object into a unicode() object.
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Add a test which contains a unicode builder name.
- Scripts/webkitpy/common/net/statusserver.py:
- Remove use of str()
- Scripts/webkitpy/common/prettypatch.py:
- Write out the patch file as utf-8.
- Scripts/webkitpy/common/system/autoinstall.py:
- Write out files with a explicit encodings.
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/common/system/deprecated_logging.py:
- Write out log files as utf-8.
- Scripts/webkitpy/common/system/executive.py:
- Make run* properly take and return unicode() objects.
- Cleaned up input handling in run_command a little by adding a _compute_input() method which can return early instead of having such a long/cluttered if-block.
- Scripts/webkitpy/common/system/executive_unittest.py:
- Added a unit test to make sure we don't break Tor again!
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Write out the test list as utf-8.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Write out json files as utf-8.
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
- Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
- Scripts/webkitpy/layout_tests/port/mac.py: ditto.
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Make the skipped file parsing test unicode.
- Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
- Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Deploy "with" to close file descriptor leaks.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Make explicit the encodings of log files and pid files.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Make encodings explicit and deploy "with".
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
- Scripts/webkitpy/style/filereader_unittest.py: ditto.
- Scripts/webkitpy/thirdparty/init.py: ditto.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Removed extra import.
- Scripts/webkitpy/tool/commands/queues.py:
- No need to map args to strings now that run_command does.
- Update test results to match args changes.
- Document our global argument hacks.
- Scripts/webkitpy/tool/commands/upload.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/mocktool.py:
- Rename add_patch_to_bug argument to match bugzilla.py
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Executive.run_* now require lists instead of strings. The lack of this change was what broke webkit-patch for svn users the first time this was landed.
- Scripts/webkitpy/tool/steps/postdiff.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
- Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Fixed spurious logging seen when running test-webkitpy
- 2:17 PM Changeset in webkit [58013] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 James Robinson <jamesr@chromium.org>
Unreviewed. Updating chromium test expecations.
- platform/chromium/test_expectations.txt:
- 1:59 PM Changeset in webkit [58012] by
-
- 14 edits in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=37937
Wean JavaScriptCore off calls to isMainThread()
Reviewed by Geoffrey Garen.
- Replace use of isMainThread() for interpreter reentry checks with a stored value on the JSGlobalData.
- Replace use of isMainThread() for useMainThread only check in the collector with a stored exclusive thread.
- API/JSContextRef.cpp:
(JSContextGroupCreate):
Always default to a small stack type for uses of the JSC API. It is
unlikely that the interpreter reentry required on the web will be as
important for other uses of JavaScriptCore.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Update exports.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().
- interpreter/Interpreter.h:
Rename MaxMainThreadReentryDepth to MaxLargeThreadReentryDepth and
MaxSecondaryThreadReentryDepth to MaxSmallThreadReentryDepth.
- jsc.cpp:
(main): Use the a large stack for jsc since it is always using the
main thread.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().
- runtime/Collector.cpp:
(JSC::Heap::registerThread):
Use the concept of making JSC run on an exclusiveThread instead of
forcing a mainThreadOnly assertion.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h:
Add ThreadStackType argument to JSGlobalData constructors and set
maxReentryDepth based on it.
WebCore:
No change in behavior.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
Explicitly set a large stack type for the common JSGlobalData and
set the currently running thread as the exclusive thread for its
execution.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
Explicitly set a small stack type for the workers JSGlobalData.
- 1:28 PM Changeset in webkit [58011] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed.
Add myself in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 1:08 PM Changeset in webkit [58010] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix pt. 3).
- 1:05 PM Changeset in webkit [58009] by
-
- 3 edits in trunk/JavaScriptGlue
<rdar://problem/7879485> Leopard: Crash after opening Software Update dialog
Reviewed by Sam Weinig.
- JSUtils.cpp:
(unprotectGlobalObject): Use the version of JSGlueAPIEntry that doesn't
call pthread_getspecific, since it's not safe to call pthread_getspecific
from a thread-specific data destructor. (<rdar://problem/7889842>
pthread_getspecific returns 0 when called from thread-specific data
destructor function)
(getThreadGlobalObject): Make sure to set the currentIdentifierTable
when first constructing our JSGlobalObject, since JSGlueAPIEntry has not
yet had an opportunity to do so.
(JSGlueAPIEntry::JSGlueAPIEntry):
- JSUtils.h: New version of JSGlueAPIEntry that doesn't call
pthread_getspecific.
- 12:56 PM Changeset in webkit [58008] by
-
- 1 edit1 add in trunk/JavaScriptGlue
Errk! tree on fire, add fwd!
Reviewed by NOBODY (build fix).
- ForwardingHeaders/wtf/text/StringHash.h: Added.
- 12:52 PM Changeset in webkit [58007] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix pt. 2).
- 12:49 PM Changeset in webkit [58006] by
-
- 6 edits1 move in trunk
JavaScriptCore: * JavaScriptCore.gypi:
- JavaScriptCore.pro:
- wtf/qt/StringQt.cpp: Copied from WebCore/platform/text/qt/StringQt.cpp.
Reviewed by NOBODY (Qt build fix).
WebCore: * WebCore.gypi:
- WebCore.pro:
- platform/text/qt/StringQt.cpp: Removed.
Reviewed by NOBODY (Qt build fix).
- 12:49 PM Changeset in webkit [58005] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Dirk Pranke <dpranke@chromium.org>
Reviewed by Dimitri Glazkov.
new-run-webkit-tests: fix a bug in the Chromium port where we would
try to talk to a crashed test_shell and raise exceptions that weren't
being caught.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 12:41 PM Changeset in webkit [58004] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 James Robinson <jamesr@chromium.org>
Updating chromium expectations for tests that need new layoutTestController
functionality.
- platform/chromium/test_expectations.txt:
- 12:40 PM Changeset in webkit [58003] by
-
- 7 edits in trunk/JavaScriptCore
- API/JSValueRef.cpp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
- runtime/Identifier.h:
- wtf/WTFThreadData.h:
(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
Reviewed by NOBODY (windows build fix).
- 12:19 PM Changeset in webkit [58002] by
-
- 2 edits in trunk/LayoutTests
Not reviewed. Sheriffing cleanup.
[chromium] Add bug numbers for expectations created during sheriffing.
- platform/chromium/test_expectations.txt:
- 12:13 PM Changeset in webkit [58001] by
-
- 21 edits2 adds1 delete in trunk
JavaScriptCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Reviewed by Oliver Hunt, Darin Adler.
JSC::UStringImpl and WebCore::StringImpl (soon to be renamed to
WTF::StringImpl) are almost identical. Remove duplication of code by unifying
the two, move missing features from UStringImpl into StringImpl & delete the
class UStringImpl.
- API/JSClassRef.cpp:
- API/JSContextRef.cpp:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/EvalCodeCache.h:
- bytecode/JumpTable.cpp:
- profiler/ProfileNode.cpp:
- runtime/Identifier.cpp:
(JSC::Identifier::add):
- runtime/Identifier.h:
(JSC::Identifier::equal):
- runtime/UString.cpp:
- runtime/UString.h:
(WTF::):
- runtime/UStringImpl.cpp: Removed.
- runtime/UStringImpl.h:
- wtf/text/StringHash.h:
(WebCore::StringHash::equal):
(WebCore::CaseFoldingHash::equal):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::empty):
(WebCore::StringImpl::sharedBuffer):
(WebCore::equal):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
(WebCore::StringImpl::cost):
(WebCore::StringImpl::isIdentifier):
(WebCore::StringImpl::setIsIdentifier):
(WebCore::StringImpl::computeHash):
(WebCore::StringImpl::copyChars):
(WebCore::StringImpl::):
JavaScriptGlue: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add forwarding header.
Reviewed by Oliver Hunt, Darin Adler.
- ForwardingHeaders/wtf/ASCIICType.h: Added.
- ForwardingHeaders/wtf/text/StringImpl.h: Added.
WebCore: Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
Add include for StringHash.h.
Reviewed by Oliver Hunt, Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
- bridge/c/c_class.cpp:
- 12:08 PM Changeset in webkit [58000] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Qt] [Symbian] Build fix.
Work around a Qt quirk. Some versions of Symbian port Qt
QFontDatabase::removeAllApplicationFonts symbol is not available.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
- 11:32 AM Changeset in webkit [57999] by
-
- 3 edits in trunk/WebKitTools
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
a real implementation may or may not be necessary for the one test that currently uses it
to pass.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::authenticateSession):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:29 AM Changeset in webkit [57998] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixed bug URL
- 11:14 AM Changeset in webkit [57997] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
- platform/qt/Skipped: Skip the new test on Qt. There is nothing special about it, existing related tests are skipped already.
- 11:11 AM Changeset in webkit [57996] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::createNSURLConnection): Fixed a typo, named an argument. (WebCore::ResourceHandle::start): Moved shouldUseCredentialStorage out of #if, since it's now passed to createNSURLConneciton() on all platforms (and then ignored on Tiger).
- 11:07 AM Changeset in webkit [57995] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Windows build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: Declare CFURLConnectionCreateWithProperties for now, as it's mistakenly missing from WebKitSupportLibrary headers.
- 10:34 AM Changeset in webkit [57994] by
-
- 2 edits in trunk/WebCore
2010-04-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r57292): Safari/Win and Chromium/Win no longer pass the acid3 test.
https://bugs.webkit.org/show_bug.cgi?id=37902
The issue is due to MSVC creating enums as signed. The fix is to store the value
as unsigned.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags): Changed type of _insideLink to unsigned.
- 10:33 AM Changeset in webkit [57993] by
-
- 11 edits2 adds in trunk
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=37933
<rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
Test: http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html
This improves integration between ResourceHandle and Apple networking libraries.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createConnectionProperties): A new helper for creating connection properties dictionary. (WebCore::ResourceHandle::start): Pass connection properties. (WebCore::WebCoreSynchronousLoader::load): Ditto.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::createNSURLConnection): Factor out OS version dependent code for creating NSURLConnection. Tell NSURLConnection about credential policy upfront. (WebCore::ResourceHandle::start): Use the new function. (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Ditto.
- 10:30 AM Changeset in webkit [57992] by
-
- 2 edits1 add in trunk/WebCore
2010-04-21 Xiaomei Ji <xji@chromium.org>
Reviewed by Dimitri Glazkov
This patch fixes [chromium] RTL <select> dropdown box expands to right
instead of left.
https://bugs.webkit.org/show_bug.cgi?id=37232
No automatic test is possible.
- manual-tests/select_dropdown_box_alignment.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layout): Adjust the x-axis of dropdown box for RTL.
- 10:21 AM Changeset in webkit [57991] by
-
- 3 edits in trunk/WebCore
2010-04-21 anton muhin <antonm@google.com>
Reviewed by Adam Barth.
[v8] Bail out if fetching of Object.prototype fails.
https://bugs.webkit.org/show_bug.cgi?id=37661
If for any reason we failed to fetch Object.prototype, context cannot
be properly initialized and we bail out.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): bail out if installHiddenObjectPrototype failed (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): bail out if failed to fetch Object.prototype
- bindings/v8/V8DOMWindowShell.h: return false if installHiddenObjectPrototype failed
- 9:40 AM Changeset in webkit [57990] by
-
- 2 edits in trunk/WebCore
Make UserContentURLPattern correctly check for subdomains and the URL
has the same suffix as the pattern. Also improve the parsing of the host.
https://bugs.webkit.org/show_bug.cgi?id=37357
Reviewed by Darin Adler.
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Simplify the subdomain pattern parsing to
simply check for "*" only or a "*." prefix and then do a substring.
(WebCore::UserContentURLPattern::matchesHost): Check that the host has a "." in the
position before the suffix to ensure it a subdomain and not just a suffix match.
- 9:02 AM Changeset in webkit [57989] by
-
- 3 edits in trunk/LayoutTests
2010-04-21 Jakub Wieczorek <jwieczorek@webkit.org>
Unreviewed.
Skip the new fast/lists tests on Mac and Windows until these ports
implement LayoutTestController::markerTextForListItem().
- platform/mac/Skipped:
- platform/win/Skipped:
- 8:57 AM Changeset in webkit [57988] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Make DRT compilable in Chromium tree
https://bugs.webkit.org/show_bug.cgi?id=37923
We need to use different GYPs in a case of WebKit-only checkout
and a case of whole Chromium checkout because the relative paths
from webkit/ to WebKit/chromium/features.gypi are different in
these cases and we can't use 'conditions' for 'includes' in GYPs.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 8:43 AM Changeset in webkit [57987] by
-
- 2 edits in trunk/WebCore
2010-04-21 Xan Lopez <xlopez@igalia.com>
Try to fix compilation on GTK+ debug bots.
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper):
- 8:41 AM Changeset in webkit [57986] by
-
- 23 edits13 adds in trunk
List item markers are not always updated after changes in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=37060
Reviewed by Darin Adler.
WebCore:
In particular, they would not be updated when adding/removing an item
that is not a direct child of the list element.
Tests: fast/lists/ol-nested-items-dynamic-insert.html
fast/lists/ol-nested-items-dynamic-remove.html
fast/lists/ol-nested-items.html
fast/lists/ol-nested-list-dynamic-insert.html
fast/lists/ol-nested-list-dynamic-remove.html
fast/lists/ol-nested-list.html
- rendering/RenderListItem.cpp:
(WebCore::updateListMarkerNumbers): Change it to traverse the whole subtree of a list, not only siblings of an item.
- rendering/RenderListItem.h:
- rendering/RenderObject.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObject::addChild): Move the code updating list markers to RenderObjectChildList for consistency.
- rendering/RenderObjectChildList.cpp: Move the updateListMarkerNumbers function to RenderListItem.cpp.
(WebCore::RenderObjectChildList::removeChildNode): Pass the actual node being removed, not the next sibling.
(WebCore::RenderObjectChildList::appendChildNode): Pass the actual node being added, not the next sibling.
(WebCore::RenderObjectChildList::insertChildNode): Pass the actual node being added, not the next sibling.
- rendering/RenderTreeAsText.cpp:
(WebCore::markerTextForListItem):
WebKit/gtk:
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
(webkit_web_frame_marker_text_for_list_item): Add a private API to get the marker text for a list item.
WebKit/qt:
- Api/qwebelement.h: Make DumpRenderTreeSupportQt a friend class.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::markerTextForListItem): Add a private API to get the marker text for a list item.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(markerTextForListItemCallback): A function that returns the marker text for a given list item.
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::markerTextForListItem): Implement it in the GTK port.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::markerTextForListItem): Add a stub.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::markerTextForListItem): Implement it in the Qt port.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::markerTextForListItem): Add a stub.
LayoutTests:
- fast/lists/dump-list.js:
(indent):
(dumpListHelper): A recursive function to dump nested lists.
(dumpList): A function that dumps a readable plain text representation of a list.
- fast/lists/ol-nested-items-dynamic-insert-expected.txt: Added.
- fast/lists/ol-nested-items-dynamic-insert.html: Added.
- fast/lists/ol-nested-items-dynamic-remove-expected.txt: Added.
- fast/lists/ol-nested-items-dynamic-remove.html: Added.
- fast/lists/ol-nested-items-expected.txt: Added.
- fast/lists/ol-nested-items.html: Added.
- fast/lists/ol-nested-list-dynamic-insert-expected.txt: Added.
- fast/lists/ol-nested-list-dynamic-insert.html: Added.
- fast/lists/ol-nested-list-dynamic-remove-expected.txt: Added.
- fast/lists/ol-nested-list-dynamic-remove.html: Added.
- fast/lists/ol-nested-list-expected.txt: Added.
- fast/lists/ol-nested-list.html: Added.
- platform/mac/Skipped: Skip the tests until this port implements the new LayoutTestController function.
- platform/win/Skipped: Skip the tests until this port implements the new LayoutTestController function.
- 8:24 AM Changeset in webkit [57985] by
-
- 6 edits9 adds in trunk
2010-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Adam Barth.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Add build bits for the GObject DOM bindings.
- GNUmakefile.am:
2010-04-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Adam Barth.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Initial version of the GObject DOM bindings.
Only bindings for Node.idl and a few of its dependencies are
provided, without public API to access them at the
moment. References to the Document interfaces and to
EventListeners in Node.idl are ignored for GObject to make the
initial patch as small as possible, but will be enabled in a
follow-up patch.
- GNUmakefile.am:
- bindings/gobject/ConvertToUTF8String.cpp: Added. (convertToUTF8String):
- bindings/gobject/ConvertToUTF8String.h: Added.
- bindings/gobject/WebKitDOMBinding.cpp: Added. (WebKit::domObjects): (WebKit::DOMObjectCache::get): (WebKit::DOMObjectCache::put): (WebKit::DOMObjectCache::forget): (WebKit::createWrapper): (WebKit::kit):
- bindings/gobject/WebKitDOMBinding.h: Added.
- bindings/gobject/WebKitDOMObject.cpp: Added. (webkit_dom_object_init): (webkit_dom_object_class_init):
- bindings/gobject/WebKitDOMObject.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm: Added.
- bindings/scripts/gobject-generate-headers.pl: Added.
- dom/Node.idl:
- 8:18 AM Changeset in webkit [57984] by
-
- 2 edits in trunk/WebCore
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Xan Lopez.
Wrong header being included in FontPlatformDataCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=37829
No behavior changes, so no new tests were added.
- platform/graphics/cairo/FontPlatformDataCairo.cpp:
- 8:08 AM Changeset in webkit [57983] by
-
- 2 edits in trunk/WebKitTools
Exclude leaks in CGGradientCreateWithColorComponents from run-webkit-tests leaks output
The leak in CG is covered by <rdar://problem/7888492>.
Fixes <http://webkit.org/b/37927>.
Reviewed by Eric Carlson.
- Scripts/old-run-webkit-tests:
(sub countAndPrintLeaks): Exclude leaks in
CGGradientCreateWithColorComponents on certain OSs.
- 8:08 AM Changeset in webkit [57982] by
-
- 2 edits in trunk/WebKit/qt
2010-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Check the request empty or not in ChromeClientQt::createWindow()
https://bugs.webkit.org/show_bug.cgi?id=37821
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
- 7:43 AM Changeset in webkit [57981] by
-
- 5 edits2 adds in trunk/WebKitTools
2010-04-21 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[DRT/Chromium] Import MockSpellCheck from Chromium
https://bugs.webkit.org/show_bug.cgi?id=37910
Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add ICU explicitly because WTFString.h includes ICU headers. Add MockSpellCheck.{cpp,h}.
- DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
- DumpRenderTree/chromium/MockSpellCheck.h: Added.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
- DumpRenderTree/chromium/WebViewHost.h:
- DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
- 7:42 AM Changeset in webkit [57980] by
-
- 2 edits in trunk/WebCore
Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
Fixes <http://webkit.org/b/37922>.
Reviewed by Dave Hyatt.
- rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
hold the heap-allocated FilterData object, so that we won't leak it
when we bail out of this function on error.
- 7:34 AM Changeset in webkit [57979] by
-
- 2 edits in trunk/WebCore
2010-04-21 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] startAnimation() is not needed to preceede nativeImageForCurrentFrame()
https://bugs.webkit.org/show_bug.cgi?id=37844
nativeImageForCurrentFrame() resets the m_decoder parameter under Qt,
which is required by startAnimation() to detect frame and repetition counts.
Hence, Image::drawTiled cannot start animations under Qt:
<html><body background="animated.gif"></body></html> does not work
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
- 7:09 AM Changeset in webkit [57978] by
-
- 9 edits in trunk/JavaScriptCore
2010-04-21 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Added missing #include "Lookup.h" in LUT source files.
https://bugs.webkit.org/show_bug.cgi?id=XXXXX
- runtime/ArrayPrototype.cpp:
- runtime/DatePrototype.cpp:
- runtime/JSONObject.cpp:
- runtime/MathObject.cpp:
- runtime/NumberConstructor.cpp:
- runtime/RegExpConstructor.cpp:
- runtime/RegExpObject.cpp:
- runtime/StringPrototype.cpp:
- 6:52 AM Changeset in webkit [57977] by
-
- 3 edits1 add in trunk/WebKitTools
2010-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add webkit-patch pretty-diff
https://bugs.webkit.org/show_bug.cgi?id=37892
This is slightly lame because it asks you whether the diff is correct,
but it's a starting point.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/prettydiff.py: Added.
- Scripts/webkitpy/tool/main.py:
- 6:42 AM Changeset in webkit [57976] by
-
- 2 edits in trunk/LayoutTests
[Qt] media/video-source-add-src.html was removed from tree
by r57820, so it's time to remove it from Qt Skipped list.
- platform/qt/Skipped: media/video-source-add-src.html removed.
- 6:42 AM Changeset in webkit [57975] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove mention of non-existant --no-build option
https://bugs.webkit.org/show_bug.cgi?id=37893
The option doesn't exist!
- Scripts/webkitpy/tool/commands/stepsequence.py:
- 6:32 AM Changeset in webkit [57974] by
-
- 4 edits in trunk/WebKitTools
2010-04-21 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
https://bugs.webkit.org/show_bug.cgi?id=37198
- QtLauncher/main.cpp: (LauncherWindow::toggleInterruptingJavaScriptEnabled): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
- QtLauncher/webpage.cpp: (WebPage::WebPage): (WebPage::shouldInterruptJavaScript):
- QtLauncher/webpage.h: (WebPage::setInterruptingJavaScriptEnabled):
- 6:17 AM Changeset in webkit [57973] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK_ROLE_FORM.
- tests/testatkroles.c: (test_webkit_atk_get_role_form): (main):
- 6:08 AM Changeset in webkit [57972] by
-
- 3 edits in trunk/WebKit/qt
2010-04-21 Shu Chang <chang.shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix Symbian build where QT_NO_SYSTEMTRAYICON is defined.
https://bugs.webkit.org/show_bug.cgi?id=37442
- WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show):
- WebCoreSupport/NotificationPresenterClientQt.h:
- 5:57 AM Changeset in webkit [57971] by
-
- 5 edits16 adds in trunk
2010-04-21 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Simon Fraser.
Update of fixed elements is not made correctly when the page has been scrolled
https://bugs.webkit.org/show_bug.cgi?id=36783
- fast/repaint/fixed-child-move-after-scroll.html: Added.
- fast/repaint/fixed-child-of-fixed-move-after-scroll.html: Added.
- fast/repaint/fixed-child-of-transformed-move-after-scroll.html: Added.
- fast/repaint/fixed-move-after-scroll.html: Added.
- platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
- platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
- platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
- platform/mac/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/fixed-move-after-scroll-expected.png: Added.
- platform/mac/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
2010-04-21 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Simon Fraser.
Update of fixed elements is not made correctly when the page has been scrolled
https://bugs.webkit.org/show_bug.cgi?id=36783
When a fixed element was updated, the old geometry was not repainted correctly
because the repaint rect was cached during the layout and not updated when
scrolling.
The rect is now updated while scrolling so the region updated correspond to the
region of the element on the screen.
The method RenderLayer::updateRepaintRectsAfterScroll() updates
the repaint rect of all fixed tree after scroll.
Tests: fast/repaint/fixed-child-move-after-scroll.html
fast/repaint/fixed-child-of-fixed-move-after-scroll.html
fast/repaint/fixed-child-of-transformed-move-after-scroll.html
fast/repaint/fixed-move-after-scroll.html
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateRepaintRectsAfterScroll):
- rendering/RenderLayer.h:
- 5:32 AM Changeset in webkit [57970] by
-
- 9 edits in trunk
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
Update EFL port to match recent API changes.
http://webkit.org/b/37853
No behavior changes, so no new tests were added.
- platform/efl/FileSystemEfl.cpp:
- platform/efl/LocalizedStringsEfl.cpp: (WebCore::missingPluginText): (WebCore::crashedPluginText):
- platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- platform/graphics/efl/ImageEfl.cpp:
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Adam Roben.
Update EFL port to match recent API changes.
http://webkit.org/b/37853
- efl/WebCoreSupport/EditorClientEfl.cpp:
- efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument): (WebCore::FrameLoaderClientEfl::objectContentType): (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons): (WebCore::FrameLoaderClientEfl::canShowMIMEType):
- efl/WebCoreSupport/FrameLoaderClientEfl.h:
- 5:22 AM Changeset in webkit [57969] by
-
- 2 edits in trunk/WebCore
2010-04-21 Avi Drissman <avi@chromium.org>
Reviewed by Simon Fraser.
JPG images fail to print in Chromium
https://bugs.webkit.org/show_bug.cgi?id=37796
Image sources of JPG data with final=false fail to draw into PDF contexts even if later updated (<rdar://problem/7874035>). Therefore, destroy and re-create the image source when the final data arrives.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
- 5:11 AM Changeset in webkit [57968] by
-
- 1 edit2 adds in trunk/JavaScriptCore
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Nikolas Zimmermann.
Add missing EFL JavaScriptCore file.
http://webkit.org/b/37854
- wtf/efl: Added.
- wtf/efl/MainThreadEfl.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::timeoutFired): (WTF::scheduleDispatchFunctionsOnMainThread):
- 5:00 AM Changeset in webkit [57967] by
-
- 4 edits in trunk/WebCore
2010-04-21 Marcus Bulach <bulach@chromium.org>
Reviewed by Nate Chapin.
EventSource needs to be marked as an ActiveDomType.
https://bugs.webkit.org/show_bug.cgi?id=37857
Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
- 4:14 AM Changeset in webkit [57966] by
-
- 8 edits in trunk
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r57963.
http://trac.webkit.org/changeset/57963
https://bugs.webkit.org/show_bug.cgi?id=37759
Three tests started crashing on the Qt bot.
- platform/qt/Skipped:
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r57963.
http://trac.webkit.org/changeset/57963
https://bugs.webkit.org/show_bug.cgi?id=37759
Three tests started crashing on the Qt bot.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isCommandEnabled):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r57963.
http://trac.webkit.org/changeset/57963
https://bugs.webkit.org/show_bug.cgi?id=37759
Three tests started crashing on the Qt bot.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 4:02 AM Changeset in webkit [57965] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
Make new-run-webkit-tests work for the Qt port
https://bugs.webkit.org/show_bug.cgi?id=37588
- Scripts/webkitpy/layout_tests/port/qt.py:
- 3:57 AM Changeset in webkit [57964] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Eric Seidel.
new-run-webkit-tests: try to detect alternate apache path
https://bugs.webkit.org/show_bug.cgi?id=37587
_check_port_build() also needs to return true in the
base implementation to not fail the check_build step.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 3:54 AM Changeset in webkit [57963] by
-
- 8 edits in trunk
2010-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Unskip a bunch of now passing tests, which was skipped because of
missing LayoutTestController::computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759
- platform/qt/Skipped:
2010-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-04-21 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::computedStyleIncludingVisitedInfo):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:44 AM Changeset in webkit [57962] by
-
- 2 edits in trunk/WebCore
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Nikolas Zimmermann.
Add missing includes to platform/posix/FileSystemPOSIX.cpp
https://bugs.webkit.org/show_bug.cgi?id=37861
No behavior changes, so no new tests were added.
- platform/posix/FileSystemPOSIX.cpp:
- 3:09 AM Changeset in webkit [57961] by
-
- 9 edits in trunk
2010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Fraser.
[Qt] Fix or remove the runtime flag for accelerated compositing.
This adds a way for a chrome client to disallow layers from becoming composited,
even if the settings enable accelerated compositing. This is necessary for platforms
where different views can be applied with the same settings to the same page.
We enable an API through ChromeClient to ask the chrome-client whether or not
it can render composited layers, which is taken into account when the compositor
decides whether or not to start compositing.
Pages under LayoutTests/compositing now work under QWebView, even when
QWebSettings::AcceleratedCompositingEnabled is on.
- page/ChromeClient.h: (WebCore::ChromeClient::allowsAcceleratedCompositing):
- platform/qt/QWebPageClient.h: (QWebPageClient::allowsAcceleratedCompositing):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::canBeComposited):
2010-04-21 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Fraser.
[Qt] Fix or remove the runtime flag for accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=37313
This lets the QWebPageClient "veto" the settings value for accelerated compositing.
In this case we allow accelerated compositing only on QGraphicsWebView.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::allowsAcceleratedCompositing):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
- WebCoreSupport/ChromeClientQt.h:
- 2:48 AM Changeset in webkit [57960] by
-
- 2 edits in trunk/WebKitTools
2010-04-21 Eric Seidel <eric@webkit.org>
Unreviewed, test fix only.
new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
https://bugs.webkit.org/show_bug.cgi?id=37726
This change seems to have broken a test.
Attempting to handle the case where we don't have any
timing information. Dirk may have to correct this change.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 1:24 AM Changeset in webkit [57959] by
-
- 2 edits in trunk/WebCore
No review. Spurious whitespace was removed from project file.
- WebCore.xcodeproj/project.pbxproj:
- 12:57 AM Changeset in webkit [57958] by
-
- 2 edits in trunk/LayoutTests
2010-04-21 Alejandro G. Castro <alex@igalia.com>
Rubber-stamped by Xan Lopez.
Skipping fast/frames/frame-crash-with-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=37914
- platform/gtk/Skipped:
- 12:46 AM Changeset in webkit [57957] by
-
- 2 edits in trunk/WebCore
[Qt] Build fix: warning on L933 of CompositeEditCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=37912
Reviewed by Eric Seidel.
Replaced the ternary operator by an if statement because GCC was confused by the use of
ternary operator and producing warnings on Qt builds.
- WebCore.xcodeproj/project.pbxproj:
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
Apr 20, 2010:
- 11:55 PM Changeset in webkit [57956] by
-
- 6 edits in trunk/WebKitTools
2010-04-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests has much higher startup latency than run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37643
I got rid of the -expected.checksum reads during startup.
This makes startup noticably better on my laptop.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Use image_hash() instead of .image_hash now that expected.checksum file reads are done lazily.
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Add debug logging for this sleep call. In my testing I never saw this sleep() hit.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Sleep a shorter interval to make websocket server startup more responsive. On my machine startup was taking around 1 second.
- Remove the unconditional .5s delay on startup.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Make image_hash file reads done lazily in a new image_hash() function.
- Add a "Starting testing ..." meter update after DRT threads have been started, but before we get updates from the first one.
- Rename variable "t" to a full english name to match WebKit style.
- 11:41 PM Changeset in webkit [57955] by
-
- 14 edits3 adds in trunk
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[ES5] RegExp literals are constants that should be persistent across multiple function calls.
https://bugs.webkit.org/show_bug.cgi?id=37908
Dump the separate RegExp constant pool, and just use the standard JS constant pool
in codeblock. This allows us to drop op_new_regexp and all associated code as well.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
- jit/JITStubs.cpp:
- jit/JITStubs.h: (JSC::):
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[ES5] RegExp literals are constants that should be persistent across multiple function calls.
https://bugs.webkit.org/show_bug.cgi?id=37908
Add tests to ensure correct persistence of RegExp literals, and correctly avoid
sharing "identical" regexps used in different places.
- fast/js/regexp-literals-are-constants-expected.txt: Added.
- fast/js/regexp-literals-are-constants.html: Added.
- fast/js/script-tests/regexp-literals-are-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
- 10:54 PM Changeset in webkit [57954] by
-
- 5 edits3 adds in trunk
Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
https://bugs.webkit.org/show_bug.cgi?id=19539
Reviewed by Justin Garcia.
WebCore:
Fixes a bug where two consecutive lists are not merged if they have been converted
from ordered/unordered lists inside another list.
The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
list element and its neighbors. This patch adds code to doApply so that after inserting
the list element, it updates previousList and nextList to the outermost list elements around
insertionPos under the same enclosing list. Because the next and the previous list elements
are not necessarily visually next to the newly inserted element before moveParagraph moves
the paragraph into the new list element, doApply merges lists after moveParagraph is called.
Test: editing/execCommand/insert-lists-inside-another-list.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Modified as described above
- editing/htmlediting.cpp:
(WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,
which is a descendent of rootNode.
- editing/htmlediting.h:
LayoutTests:
Test to make sure InsertListCommand merges consecutive lists when converting
ordered/unordered lists to the opposite type of lists inside another list.
- editing/execCommand/insert-lists-inside-another-list-expected.txt: Added.
- editing/execCommand/insert-lists-inside-another-list.html: Added.
- editing/execCommand/script-tests/insert-lists-inside-another-list.js: Added.
(testList):
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt:
- 10:48 PM Changeset in webkit [57953] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 Simon Fraser <Simon Fraser>
Fix test result after r57913.
- compositing/iframes/composited-iframe-expected.txt:
- 10:25 PM Changeset in webkit [57952] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 Yuzo Fujishima <yuzo@google.com>
Unreviewed test skipping for Chromium Win.
Skip editing/pasteboard/copy-backslash-with-euc.html for Chromium Win.
https://bugs.webkit.org/show_bug.cgi?id=36419
- platform/chromium/test_expectations.txt:
- 9:55 PM Changeset in webkit [57951] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37776
<rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes
- platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping for Roman letters and punctuation.
- platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak) also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes to their keycodes.
- 9:11 PM Changeset in webkit [57950] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix a ChangeLog entry.
- 9:09 PM Changeset in webkit [57949] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419
Add editing/pasteboard/copy-backslash-with-euc into Gtk's skipped list.
- platform/gtk/Skipped:
- 8:54 PM Changeset in webkit [57948] by
-
- 6 edits in trunk/WebKitTools
2010-04-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Make Sheriffbot more inspirational.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 8:31 PM Changeset in webkit [57947] by
-
- 3 edits1 add in trunk/WebKitTools
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Import Chromium image_diff as ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=37790
ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/ImageDiff.cpp: Added.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- 6:13 PM Changeset in webkit [57946] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-20 Xan Lopez <xlopez@igalia.com>
Another attempt to fix the build.
- GNUmakefile.am:
- 6:13 PM Changeset in webkit [57945] by
-
- 5 edits in trunk/WebKit2
Don't paint the web page before we've blit the last update chunk to the backing store.
Reviewed by Sam Weinig.
- UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didReceiveMessage):
- UIProcess/win/DrawingAreaProxy.h:
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didUpdate):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:
- 5:54 PM Changeset in webkit [57944] by
-
- 2 edits in trunk
2010-04-20 Xan Lopez <xlopez@igalia.com>
Build fix?
- autotools/webkit.m4:
- 5:50 PM Changeset in webkit [57943] by
-
- 2 edits in trunk/JavaScriptCore
Fix license on create_regex_tables
- 5:47 PM Changeset in webkit [57942] by
-
- 2 edits in trunk
Fix gtk
- 5:09 PM Changeset in webkit [57941] by
-
- 2 edits in trunk/WebKit2
Fix build.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::receivedData):
- 4:51 PM Changeset in webkit [57940] by
-
- 12 edits5 adds in trunk
2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler and Alexey Proskuryakov.
A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419
- editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
- editing/execCommand/transpose-backslash-with-euc.html: Added.
- editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
- editing/pasteboard/copy-backslash-with-euc.html: Added.
- editing/pasteboard/resources/copy-backslash-euc.html: Added.
2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler and Alexey Proskuryakov.
A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419
Tests: editing/execCommand/transpose-backslash-with-euc.html
editing/pasteboard/copy-backslash-with-euc.html
- editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls. (WebCore::Editor::addToKillRing):
- editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::init): (WebCore::TextIterator::emitText): (WebCore::plainTextToMallocAllocatedBuffer):
- editing/TextIterator.h: (WebCore::):
- platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::Pasteboard::writeSelection):
- platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
- rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding (WebCore::RenderText::RenderText): (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::styleDidChange): (WebCore::isInlineFlowOrEmptyText): (WebCore::RenderText::previousCharacter): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::textWithoutTranscoding): (WebCore::RenderText::transformText):
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter):
- rendering/RenderTextFragment.h:
- 4:42 PM Changeset in webkit [57939] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, updating Chromium test_expectations for media/video-zoom.html.
- platform/chromium/test_expectations.txt:
- 4:27 PM Changeset in webkit [57938] by
-
- 2 edits1 move2 deletes in trunk/LayoutTests
2010-04-20 James Robinson <jamesr@chromium.org>
Unreviewed. Update chromium expectations. Also consolidate identical
platform expectations for fast/dom/prototype-inheritance.html.
- platform/chromium-linux/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt.
- platform/chromium/test_expectations.txt:
- 4:22 PM Changeset in webkit [57937] by
-
- 3 edits in trunk/JavaScriptCore
Fix gtk
- 4:18 PM Changeset in webkit [57936] by
-
- 4 edits in trunk/WebCore
2010-04-20 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Fix style violations in code generated by CodeGeneratorV8.pm.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/test/V8TestObj.cpp:
- bindings/v8/test/V8TestObj.h:
- 3:57 PM Changeset in webkit [57935] by
-
- 10 edits in trunk
Unreviewed, rolling out r57924.
http://trac.webkit.org/changeset/57924
https://bugs.webkit.org/show_bug.cgi?id=37898
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-20
It broke 3-4 test on all bot (Requested by Ossy on #webkit).
WebCore:
- page/AbstractView.idl:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::media):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
- fast/media/lifetime.html:
- fast/media/matchmedium-query-api.html:
- fast/media/print-restores-previous-mediatype-expected.txt:
- fast/media/print-restores-previous-mediatype.html:
- 3:43 PM Changeset in webkit [57934] by
-
- 4 edits in trunk/WebKitTools
2010-04-20 Dirk Pranke <dpranke@chromium.org>
This patch to new-run-webkit-tests adds a --log 'trace' option
that prints out detailed info about a given test as it executes
(where the baselines are, what the expectation is, what we got,
how long it took).
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- use the newly exposed TestResult class and implement --log trace
- Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
- rename TestStats to TestResult and make it more public, resulting in cleaner code
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- add expectation_to_string() as a separate callable function
- 3:38 PM Changeset in webkit [57933] by
-
- 6 edits in trunk/WebKit2
2010-04-20 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't paint the web page before we've blit the last update chunk to the backing store
https://bugs.webkit.org/show_bug.cgi?id=37896
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::):
- UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
- UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): (WebKit::DrawingAreaProxyUpdateChunk::update): (WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::scheduleDisplay): (WebKit::DrawingAreaUpdateChunk::setSize): (WebKit::DrawingAreaUpdateChunk::didUpdate): (WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
- WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
- 3:34 PM Changeset in webkit [57932] by
-
- 7 edits1 copy2 adds in trunk
JavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Reviewed by Oliver Hunt.
The implementation of StringImpl & UStringImpl is very similar. Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/RopeImpl.h:
(JSC::RopeImpl::RopeImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):
- wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.
(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):
JavaScriptGlue: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.
Reviewed by Oliver Hunt.
- ForwardingHeaders/wtf/text/StringImplBase.h: Added.
WebCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.
Reviewed by Oliver Hunt.
- ForwardingHeaders/wtf/text/StringImplBase.h: Added.
- 3:26 PM Changeset in webkit [57931] by
-
- 4 edits in trunk
2010-04-20 Adam Barth <abarth@webkit.org>
Unreviewed build fix fro Chromium.
- loader/DocumentWriter.cpp:
2010-04-20 Adam Barth <abarth@webkit.org>
Unreviewed build fix.
- Api/qwebframe.cpp: (QWebFrame::setUrl):
- 3:24 PM Changeset in webkit [57930] by
-
- 3 edits in trunk/WebCore
2010-04-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptLine):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._cancelEditingLine):
- 3:24 PM Changeset in webkit [57929] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 Simon Fraser <Simon Fraser>
Test fix, no review.
Disable compositing/iframes/composited-iframe.html because compositing is
turned off at runtime on Leopard (based on QuickTime version), so we can't
rely on the result.
- platform/mac-leopard/Skipped:
- 3:19 PM Changeset in webkit [57928] by
-
- 35 edits2 adds43 deletes in trunk/LayoutTests
2010-04-20 James Robinson <jamesr@chromium.org>
Reviewed by dglazkov.
Update chromium SVG baselines for r57886
https://bugs.webkit.org/show_bug.cgi?id=37891
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
- platform/chromium-mac/svg/batik/filters/filterRegions-expected.txt: Removed.
- platform/chromium-mac/svg/batik/text/textEffect-expected.txt: Removed.
- platform/chromium-mac/svg/batik/text/textEffect3-expected.txt: Removed.
- platform/chromium-mac/svg/batik/text/textFeatures-expected.txt: Removed.
- platform/chromium-mac/svg/batik/text/textProperties-expected.txt: Removed.
- platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
- platform/chromium-mac/svg/custom/non-opaque-filters-expected.txt: Removed.
- platform/chromium-mac/svg/custom/visibility-override-filter-expected.txt: Removed.
- platform/chromium-mac/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Removed.
- platform/chromium-mac/svg/filters/feMerge-expected.txt: Removed.
- platform/chromium-mac/svg/filters/feOffset-expected.txt: Removed.
- platform/chromium-mac/svg/filters/filter-on-tspan-expected.txt: Removed.
- platform/chromium-mac/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
- platform/chromium-mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
- platform/chromium-mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties-expected.txt:
- platform/chromium-win/svg/custom/empty-merge-expected.txt: Removed.
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.txt: Removed.
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-win/svg/custom/invalid-css-expected.txt:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
- platform/chromium-win/svg/custom/text-filter-expected.txt:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.txt: Removed.
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/chromium-win/svg/filters/big-sized-filter-expected.txt: Removed.
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
- platform/chromium-win/svg/filters/feComposite-expected.txt:
- platform/chromium-win/svg/filters/feDisplacementMap-expected.txt: Removed.
- platform/chromium-win/svg/filters/feGaussianBlur-expected.txt: Removed.
- platform/chromium-win/svg/filters/feMerge-expected.txt: Removed.
- platform/chromium-win/svg/filters/feMerge-wrong-input-expected.txt: Removed.
- platform/chromium-win/svg/filters/feOffset-expected.txt: Removed.
- platform/chromium-win/svg/filters/feTile-expected.txt: Removed.
- platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.txt: Removed.
- platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.txt: Removed.
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 3:12 PM Changeset in webkit [57927] by
-
- 41 edits2 adds in trunk
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.
No tests because there is no behavior change (hopefully!).
- Android.mk:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- dom/Document.cpp: (WebCore::Document::close):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/DocumentWriter.cpp: Added.
- loader/DocumentWriter.h: Added.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
- loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
- src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):
- 3:09 PM Changeset in webkit [57926] by
-
- 3 edits in trunk/WebKit2
Fix build.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::chooseIconForFiles):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 3:05 PM Changeset in webkit [57925] by
-
- 13 edits1 add in trunk/JavaScriptCore
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Autogenerate yarr character tables
https://bugs.webkit.org/show_bug.cgi?id=37877
Use a python script to automatically generate character tables
for the builtin YARR character classes. This allows us to generate
actual tables as well, by using these tables we can both increase
performance of the check (for complex builtins) and reduce the actual
code size.
4-8% win on string-unpack-code, but lots of noise on other tests so
i'm only confident saying its a 1% win overall.
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
- assembler/MacroAssembler.h: (JSC::MacroAssembler::branchTest8):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchTest8):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::branchTest8):
- assembler/X86Assembler.h: (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
- bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump):
- create_regex_tables: Added.
- yarr/RegexCompiler.cpp: (JSC::Yarr::CharacterClassConstructor::charClass):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::matchCharacterClass): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
- yarr/RegexPattern.h: (JSC::Yarr::CharacterClassTable::create): (JSC::Yarr::CharacterClassTable::CharacterClassTable): (JSC::Yarr::CharacterClass::CharacterClass):
- 3:04 PM Changeset in webkit [57924] by
-
- 10 edits in trunk
Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187
Reviewed by Simon Fraser.
WebCore:
It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.
- page/AbstractView.idl:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Update layout tests.
- fast/media/lifetime.html:
- fast/media/matchmedium-query-api.html:
- fast/media/print-restores-previous-mediatype.html:
- 2:50 PM Changeset in webkit [57923] by
-
- 2 edits in trunk/WebCore
Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.
Also fix comparisons to be case insensitive.
https://bugs.webkit.org/show_bug.cgi?id=37889
Reviewed by Dave Hyatt.
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.
- 2:42 PM Changeset in webkit [57922] by
-
- 6 edits4 adds in trunk
2010-04-20 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
https://bugs.webkit.org/show_bug.cgi?id=37331
Added a setting to enable/disable media per-page and have the SVGImage
disable media for its dummy page. Also found and fixed a related bad
cast in the V8 bindings (JSC had a custom wrapper for this already).
Tests: media/svg-as-image-with-media-blocked.html
- 2:32 PM Changeset in webkit [57921] by
-
- 2 edits in trunk/WebCore
Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
https://bugs.webkit.org/show_bug.cgi?id=37802
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.
No behavior change, it is just a safe assignment shortcut.
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfCloser):
- 2:29 PM Changeset in webkit [57920] by
-
- 32 edits in trunk/WebKitTools
2010-04-20 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r57907.
http://trac.webkit.org/changeset/57907
https://bugs.webkit.org/show_bug.cgi?id=37765
Appears to have broken MacEWS and possibly webkit-patch upload
for svn users. Needs further investigation.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/checkout/commitinfo.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/common/prettypatch.py:
- Scripts/webkitpy/common/system/autoinstall.py:
- Scripts/webkitpy/common/system/deprecated_logging.py:
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/postdiff.py:
- Scripts/webkitpy/tool/steps/postdiffforcommit.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 2:24 PM Changeset in webkit [57919] by
-
- 9 edits5 adds in trunk
2010-04-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Hook compositing layers together across iframes
https://bugs.webkit.org/show_bug.cgi?id=37878
First step: if an iframe's document goes into compositing mode, also throw the parent
document into compositing mode (all the way up to the root). This is required both
to preserve layering (since parent document content can obscure iframe content),
and so that we can eventually hook the layer trees together.
Test: compositing/iframes/composited-iframe.html
- rendering/RenderIFrame.h:
- rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have a RenderLayer, so must return |true| from requiresLayer(). (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document is in compositing mode. (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check if a renderer is an iframe. (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when the compositing mode changes, so that the parent document can update its compositing status. (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame(). (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe wants to be composited.
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderIFrame): Base class returns false.
- rendering/RenderView.h:
- rendering/RenderView.cpp: (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify its parent document that a recalcStyle is required, to update compositing state.
- 2:17 PM Changeset in webkit [57918] by
-
- 2 edits in trunk/WebKitTools
2010-04-20 Nate Chapin <Nate Chapin>
Unreviewed.
Update my irc handle in committers.py (natechapin -> japhet).
- Scripts/webkitpy/common/config/committers.py:
- 2:13 PM Changeset in webkit [57917] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/text/AtomicString.h:
Reviewed by NOBODY (speculative windows fix - missed a bit!).
- 2:12 PM Changeset in webkit [57916] by
-
- 2 edits in trunk/LayoutTests
worker-close.html is flaky on slow machines.
https://bugs.webkit.org/show_bug.cgi?id=37887
Reviewed by Adam Barth.
- fast/workers/worker-close.html: Move the start of the timer to terminate the test after an expected message is received.
- 2:03 PM Changeset in webkit [57915] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 James Robinson <jamesr@chromium.org>
Unreviewed. Another round of chromium test expectation SVG updates.
- platform/chromium/test_expectations.txt:
- 1:58 PM Changeset in webkit [57914] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/text/AtomicString.h:
Reviewed by NOBODY (speculative windows fix).
- 1:41 PM Changeset in webkit [57913] by
-
- 4 edits in trunk
2010-04-20 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
backgroundColor is oddly indented in layer tree dump
https://bugs.webkit.org/show_bug.cgi?id=37885
The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
to be written twice.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- 1:33 PM Changeset in webkit [57912] by
-
- 10 edits2 copies1 add in trunk
JavaScriptCore: Add missing .def file entries.
Reviewed by NOBODY (windows build fix).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
WebCore: Speculative tiger build fix.
Reviewed by NOBODY (build fix).
- WebCore.NPAPI.exp:
- WebCore.PluginHostProcess.exp:
- WebCore.base.exp:
- 1:23 PM Changeset in webkit [57911] by
-
- 4 edits in trunk/WebCore
Speculative tiger build fix.
Reviewed by NOBODY (build fix).
- WebCore.NPAPI.exp:
- WebCore.PluginHostProcess.exp:
- WebCore.base.exp:
- 1:22 PM Changeset in webkit [57910] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 James Robinson <jamesr@chromium.org>
Unreviewed. Fix typo in chromium test expectations.
- platform/chromium/test_expectations.txt:
- 1:18 PM Changeset in webkit [57909] by
-
- 13 edits in trunk
2010-04-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add basic script editing capabilities to the front-end.
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._editLine): (WebInspector.ScriptView.prototype._editLineComplete):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.canEditScripts): (WebInspector.ScriptsPanel.prototype.editScriptLine):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.updateContent): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.reset):
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.copyRange):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set editCallback): (WebInspector.TextViewer.prototype._buildChunks): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._commitEditingLine): (WebInspector.TextViewer.prototype._cancelEditingLine):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.isEditingAnyField): (WebInspector.startEditing.cleanUpAfterEditing):
2010-04-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add basic script editing capabilities to the front-end.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.editScriptLine): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
- src/js/DevTools.js:
- src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.editScriptLine):
- 1:06 PM Changeset in webkit [57908] by
-
- 2 edits in trunk/JavaScriptCore
Add missing .def file entries.
Reviewed by NOBODY (windows build fix).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 12:54 PM Changeset in webkit [57907] by
-
- 32 edits in trunk/WebKitTools
2010-04-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765
I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.
This fixes our Executive.run_command code to work around a Popen
bug http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.
Following the advice of:
http://farmdev.com/talks/unicode/
I'm attempting to take the python unicode plunge and use unicode()
objects as strings instead of str() objects everywhere in webkitpy.
We do not have to use u"" instead of "" because u"a" == "a" as expected
in Python. Python will generate a warning to the console in cases where
a unicode() == str() operation cannot be performed.
I also cleaned up the input handling in run_command a little by adding
a new _compute_input() method which can return early instead of having
such a long/cluttered if-block.
Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.
All places which use StringIO need to be sure to pass StringIO a
pre-encoded byte-array (str object) instead of unicode so that
clients which read from the StringIO don't have encoding exceptions.
To make this easier, I removed the patch_file_object support from
add_patch_to_bug, and changed the 4 places which previously used
StringIO to create a fake patch file.
I attempted to document any places where we are not correctly converting
to/from bytes (str() objects) to strings (unicode() objects).
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Read/write utf-8 files instead of ascii.
- Update the tests to use test for proper unicode() handling.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Use unicode() strings instead of str() byte arrays.
- Scripts/webkitpy/common/checkout/scm.py:
- Remove use of str().
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Read/write utf-8 files and use unicode() strings in testing.
- Scripts/webkitpy/common/config/committers.py:
- Use \u instead of \x to make slightly clearer what we're doing.
- Scripts/webkitpy/common/net/bugzilla.py:
- Add a new _string_contents() method and explain why we have to call unicode() on the result of soup.string and why it's safe to do so w/o needing to pass a codec name.
- Remove the (unused) support for passing a file object to add_patch_to_bug().
- Scripts/webkitpy/common/net/buildbot.py:
- Use unicode() instead of str() when needing to coax a NavigableString object into a unicode() object.
- Scripts/webkitpy/common/net/statusserver.py:
- Remove use of str()
- Scripts/webkitpy/common/prettypatch.py:
- Write out the patch file as utf-8.
- Scripts/webkitpy/common/system/autoinstall.py:
- Add a FIXME about encoding.
- Scripts/webkitpy/common/system/deprecated_logging.py:
- Document that tee() works on bytes, not strings.
- Scripts/webkitpy/common/system/executive.py:
- Make run* properly take and return unicode() objects.
- Scripts/webkitpy/common/system/executive_unittest.py:
- Added a unit test to make sure we don't break Tor again!
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Write out the test list as utf-8.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Write out json files as utf-8.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Add FIXME about encoding handling.
- Scripts/webkitpy/tool/commands/upload.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/mocktool.py:
- Rename add_patch_to_bug argument to match bugzilla.py
- Scripts/webkitpy/tool/steps/postdiff.py:
- Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
- Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
- Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Fixed spurious logging seen when running test-webkitpy
- 12:52 PM Changeset in webkit [57906] by
-
- 2 edits in trunk/LayoutTests
2010-04-20 James Robinson <jamesr@chromium.org>
Unreviewed. Update chromium test expectations to reflect changes
in SVG tests from r57886.
- platform/chromium/test_expectations.txt:
- 12:42 PM PythonGuidelines edited by
- Stubbed out section on strings and unicode. (diff)
- 12:34 PM Changeset in webkit [57905] by
-
- 3 edits in trunk/WebKitTools
2010-04-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
For check-webkit-style, implemented eq() and ne() (the
built-in equality and inequality methods) for the
DefaultStyleErrorHandler class.
This will facilitate unit-testing for a subsequent patch,
namely for https://bugs.webkit.org/show_bug.cgi?id=37850
- Scripts/webkitpy/style/error_handlers.py:
- Added eq() and ne() to the DefaultStyleErrorHandler class.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Added unit tests for eq() and ne().
- Also included a minor clean-up refactoring of combining the StyleErrorHandlerTestBase class (which has not needed to be separate due to previous changes) into the DefaultStyleErrorHandlerTest class.
- 12:28 PM Changeset in webkit [57904] by
-
- 26 edits7 copies3 moves7 adds in trunk
Bug 37828 - Move WebCore's String classes to WTF
Reviewed by Geoff Garen.
Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).
As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").
Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- config.h:
- wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
- wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
- wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
- wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
- wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
- wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
- wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
- wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
- wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.
(WebCore::charactersToFloat):
- wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.
WebCore:
Moving the files, but leaving the classes logically in the WebCore namespace –
which is technically a layering violation – I'll come back and fix this up in a
subsequent patch.
- Android.mk:
- ForwardingHeaders/wtf/StaticConstructors.h: Added.
- ForwardingHeaders/wtf/text/AtomicString.h: Added.
- ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
- ForwardingHeaders/wtf/text/StringBuffer.h: Added.
- ForwardingHeaders/wtf/text/StringHash.h: Added.
- ForwardingHeaders/wtf/text/StringImpl.h: Added.
- ForwardingHeaders/wtf/text/WTFString.h: Added.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/MediaFeatureNames.cpp:
- dom/QualifiedName.cpp:
- dom/make_names.pl:
- platform/StaticConstructors.h: Removed.
- platform/text/AtomicString.cpp: Removed.
- platform/text/AtomicString.h:
- platform/text/AtomicStringImpl.h:
- platform/text/PlatformString.h:
- platform/text/String.cpp:
- platform/text/StringHash.h:
- platform/text/StringImpl.cpp: Removed.
- platform/text/StringImpl.h:
- 12:20 PM Changeset in webkit [57903] by
-
- 26 edits in trunk
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
to FileChooser*. Though an implementation of chooseIconForFiles()
might have ownership of the FileChooser instance, we don't need to
use PassRefPtr<> in this case.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::chooseIconForFiles):
- page/Chrome.cpp: (WebCore::Chrome::chooseIconForFiles):
- page/Chrome.h:
- page/ChromeClient.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
- src/ChromeClientImpl.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::chooseIconForFiles):
- WebCoreSupport/ChromeClientGtk.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
- WebCoreSupport/ChromeClientHaiku.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
- WebCoreSupport/ChromeClientQt.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
- WebCoreSupport/WebChromeClient.h:
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
- WebKitSupport/ChromeClientWx.h:
- 12:08 PM Changeset in webkit [57902] by
-
- 2 edits in trunk/WebCore
2010-04-20 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_FORM.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 11:52 AM Changeset in webkit [57901] by
-
- 9 edits1 add in trunk
2010-04-20 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::collapseSelection): Converted this logic to a GClosure callback. (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now.
- WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore. (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list. (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list. (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids. (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard.
- WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality.
2010-04-20 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.
No new tests as functionality has not changed.
- GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
- platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
- platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming. (WebCore::clipboard_get_contents_cb): Ditto. (WebCore::Pasteboard::helper): Added, member is now private. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::documentFragment): Update to reflect method renaming. (WebCore::Pasteboard::plainText): Ditto.
- platform/gtk/PasteboardHelper.cpp: Added. (WebCore::PasteboardHelper::PasteboardHelper): Added. (WebCore::PasteboardHelper::~PasteboardHelper): Added. (WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit. (WebCore::widgetFromFrame): Added helper function. (WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit. (WebCore::PasteboardHelper::getClipboard): Ditto. (WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto. (WebCore::PasteboardHelper::targetList): Ditto. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::targetListForDataObject): Ditto. (WebCore::getClipboardContentsCallback): Ditto. (WebCore::clearClipboardContentsCallback): Ditto. (WebCore::PasteboardHelper::writeClipboardContents): Ditto.
- platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
- 11:22 AM Changeset in webkit [57900] by
-
- 12 edits2 deletes in trunk/WebCore
2010-04-20 Simon Fraser <Simon Fraser>
Reviewed by Dimitri Glazkov.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
RenderPartObject is a useless intermediate class between RenderPart and
RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
applies to objects and embeds when the content is a FrameView, so can move
to RenderEmbeddedObject.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): (WebCore::RenderEmbeddedObject::requiresLayer): (WebCore::RenderEmbeddedObject::paint): (WebCore::RenderEmbeddedObject::viewCleared):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFrameBase.h:
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
- rendering/RenderPart.h:
- rendering/RenderPartObject.cpp: Removed.
- rendering/RenderPartObject.h: Removed.
- 11:15 AM Changeset in webkit [57899] by
-
- 7 edits3 adds in trunk/LayoutTests
2010-04-20 Sergey Ulanov <sergeyu@chromium.org>
Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.
- platform/chromium-linux/media/video-replaces-poster-expected.checksum:
- platform/chromium-linux/media/video-replaces-poster-expected.png:
- platform/chromium-mac/media/video-replaces-poster-expected.checksum:
- platform/chromium-mac/media/video-replaces-poster-expected.png:
- platform/chromium-win/media/video-replaces-poster-expected.checksum:
- platform/chromium-win/media/video-replaces-poster-expected.png:
- platform/chromium-win/media/video-zoom-expected.checksum: Added.
- platform/chromium-win/media/video-zoom-expected.png: Added.
- platform/chromium-win/media/video-zoom-expected.txt: Added.
- 11:00 AM Changeset in webkit [57898] by
-
- 2 edits in trunk/WebKitTools
2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>
Unreviewed.
Add my IRC nick to the committers.py list.
- Scripts/webkitpy/common/config/committers.py:
- 10:41 AM Changeset in webkit [57897] by
-
- 2 edits in trunk/WebKitTools
[Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=37816
Patch by Kim Grönholm <kim.gronholm@nomovok.com> on 2010-04-20
Reviewed by Simon Hausmann.
Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
- QtLauncher/main.cpp:
(LauncherWindow::eventFilter):
(LauncherWindow::initializeView):
- 10:31 AM Changeset in webkit [57896] by
-
- 7 edits in trunk
2010-04-20 Robin Cao <robin.webkit@gmail.com>
Reviewed by Dirk Schulze.
SVG no AnimateColor for stroke or fill if they are set to none on target.
https://bugs.webkit.org/show_bug.cgi?id=36718
SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case
the property type determined by base value may be different from the one determined by 'fromTo' values.
No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue):
2010-04-20 Robin Cao <robin.webkit@gmail.com>
Reviewed by Dirk Schulze.
Update expected results after bug fix: https://bugs.webkit.org/show_bug.cgi?id=36718
now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Updated.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Updated.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Updated.
- svg/custom/animation-currentColor.svg: Updated.
- 9:09 AM Changeset in webkit [57895] by
-
- 11 edits in trunk
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57892.
http://trac.webkit.org/changeset/57892
https://bugs.webkit.org/show_bug.cgi?id=37864
Caused an assertion in Mac builds (Requested by smfr on
#webkit).
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- page/Frame.cpp: (WebCore::Frame::ownerRenderer):
- page/Frame.h:
- page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
- rendering/RenderFrameBase.h:
- rendering/RenderObject.h:
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57892.
http://trac.webkit.org/changeset/57892
https://bugs.webkit.org/show_bug.cgi?id=37864
Caused an assertion in Mac builds (Requested by smfr on
#webkit).
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]):
- WebView/WebFrameView.mm: (-[WebFrameView _install]):
- 8:54 AM Changeset in webkit [57894] by
-
- 2 edits in trunk/WebKitTools
2010-04-20 MORITA Hajime <morrita@google.com>
Unreviewed, add myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 8:12 AM Changeset in webkit [57893] by
-
- 2 edits in trunk/WebCore
2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Darin Adler.
RenderListItem: change enclosingList() to only traverse the render tree.
https://bugs.webkit.org/show_bug.cgi?id=37319
This makes the function safe to use for items with nodes that are detached from
the DOM tree and simplifies the code quite a bit.
Covered by existing tests.
- rendering/RenderListItem.cpp: (WebCore::enclosingList): (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
- 8:06 AM Changeset in webkit [57892] by
-
- 11 edits in trunk
2010-04-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- page/Frame.cpp: (WebCore::Frame::ownerRenderer):
- page/Frame.h:
- page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
- rendering/RenderFrameBase.h: (WebCore::RenderFrameBase::isRenderFrameBase): (WebCore::toRenderFrameBase):
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderFrameBase):
- 7:58 AM Changeset in webkit [57891] by
-
- 4 edits in trunk
2010-04-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Pressing tab now closes the select popup as it should.
https://bugs.webkit.org/show_bug.cgi?id=37721
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent):
2010-04-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Tests that pressing tab now closes the select popup.
https://bugs.webkit.org/show_bug.cgi?id=37721
- tests/PopupMenuTest.cpp: (WebKit::TEST_F):
- 7:50 AM Changeset in webkit [57890] by
-
- 2 edits in trunk/LayoutTests
Unskip xss-DENIED-mime-type-execute-as-html.html on Windows
This is essentially a rollout of r57729. I was hoping that skipping
this test would fix the spurious timeouts described in
<http://webkit.org/b/37714>, but that hasn't happened.
- platform/win/Skipped:
- 7:16 AM Changeset in webkit [57889] by
-
- 7 edits in trunk/WebCore
2010-04-20 Yaar Schnitman <yaar@chromium.org>
Reviewed by Nate Chapin.
Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
https://bugs.webkit.org/show_bug.cgi?id=37810
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
- bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
- bindings/v8/test/V8TestObj.cpp: (WebCore::TestObjInternal::overloadedMethodCallback):
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added null checks. (WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
- html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
- html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".
- 6:44 AM Changeset in webkit [57888] by
-
- 4 edits1 add in trunk
2010-04-20 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715
NULL check the return value of nativeImageForCurrentFrame(),
and NULL check Image just for good measure.
Tested by new DragImageTest unit test.
- platform/chromium/DragImageChromiumSkia.cpp: (WebCore::createDragImageFromImage):
2010-04-20 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715
Added unit tests for DragImageChromiumSkia.
- WebKit.gyp:
- tests/DragImageTest.cpp: Added. (WebCore::TestImage::TestImage): (WebCore::TestImage::~TestImage): (WebCore::TestImage::size): (WebCore::TestImage::nativeImageForCurrentFrame): (WebCore::TestImage::destroyDecodedData): (WebCore::TestImage::decodedSize): (WebCore::TestImage::draw): (WebCore::TEST):
- 6:23 AM Changeset in webkit [57887] by
-
- 3 edits in trunk/WebKit/chromium
2010-04-20 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by David Levin.
Remove a workaround in plugin cursor setting that was obsoleted by
the change in https://bugs.webkit.org/show_bug.cgi?id=35132
https://bugs.webkit.org/show_bug.cgi?id=37811
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin):
- src/ChromeClientImpl.h:
- 6:14 AM PythonGuidelines edited by
- Added single quote/double quote example. (diff)
- 5:57 AM PythonGuidelines edited by
- Added unittest naming convention. (diff)
- 5:52 AM Changeset in webkit [57886] by
-
- 133 edits3 adds2 deletes in trunk
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.
No behavior changes, so no new tests were added.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGResource.h: (WebCore::): (WebCore::RenderSVGResource::postApplyResource):
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
- rendering/RenderSVGText.cpp:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
- svg/SVGFETurbulenceElement.h: (WebCore::):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.cpp:
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
- svg/graphics/SVGResourceFilter.cpp: Removed.
- svg/graphics/SVGResourceFilter.h: Removed.
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::externalRepresentation):
- svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-on-tspan-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
- platform/win/svg/filters/feColorMatrix-values-expected.txt:
- 5:46 AM Changeset in webkit [57885] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Unreviewed speculative buildfix for WinCE after r57882
https://bugs.webkit.org/show_bug.cgi?id=37701
- JavaScriptCore.pri: missing wince* case added.
- 4:33 AM Changeset in webkit [57884] by
-
- 2 edits in trunk/JavaScriptCore
Speculative Chromium/Win build fix, attempt #2.
Reviewed by NOBODY (build fix).
- config.h:
- 4:19 AM Changeset in webkit [57883] by
-
- 2 edits in trunk/JavaScriptCore
Speculative Chromium/Win build fix.
Reviewed by NOBODY (build fix).
- config.h: JS_EXPORTDATA should do nothing on !JSC builds.
- 4:16 AM Changeset in webkit [57882] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37701
Reviewed by Simon Hausmann.
- JavaScriptCore.pri: dependency added.
- 3:37 AM Changeset in webkit [57881] by
-
- 116 edits2 adds2 deletes in trunk
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57880.
http://trac.webkit.org/changeset/57880
https://bugs.webkit.org/show_bug.cgi?id=37846
Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57880.
http://trac.webkit.org/changeset/57880
https://bugs.webkit.org/show_bug.cgi?id=37846
Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGResource.h: (WebCore::):
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: Removed.
- rendering/RenderSVGResourceFilter.h: Removed.
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
- rendering/RenderSVGText.cpp:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
- svg/SVGFETurbulenceElement.h: (WebCore::):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h: (WebCore::SVGFilterElement::rendererIsNeeded):
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.cpp:
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
- svg/graphics/SVGResourceFilter.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::fitsInMaximumImageSize): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation): (WebCore::getFilterById):
- svg/graphics/SVGResourceFilter.h: Added. (WebCore::SVGResourceFilter::create): (WebCore::SVGResourceFilter::resourceType): (WebCore::SVGResourceFilter::setFilterResolution): (WebCore::SVGResourceFilter::setHasFilterResolution): (WebCore::SVGResourceFilter::filterBoundingBoxMode): (WebCore::SVGResourceFilter::setFilterBoundingBoxMode): (WebCore::SVGResourceFilter::effectBoundingBoxMode): (WebCore::SVGResourceFilter::setEffectBoundingBoxMode): (WebCore::SVGResourceFilter::filterRect): (WebCore::SVGResourceFilter::setFilterRect): (WebCore::SVGResourceFilter::scaleX): (WebCore::SVGResourceFilter::scaleY): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::builder):
- svg/graphics/filters/SVGFilterBuilder.h:
- 2:45 AM Changeset in webkit [57880] by
-
- 116 edits2 adds2 deletes in trunk
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.
No behavior changes, so no new tests were added.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
- rendering/RenderSVGResource.h: (WebCore::):
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
- rendering/RenderSVGText.cpp:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
- svg/SVGFETurbulenceElement.h: (WebCore::):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
- svg/graphics/SVGResource.cpp:
- svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
- svg/graphics/SVGResourceFilter.cpp: Removed.
- svg/graphics/SVGResourceFilter.h: Removed.
- svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):
2010-04-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320
All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- 1:30 AM Changeset in webkit [57879] by
-
- 23 edits4 copies in trunk
Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- API/JSContextRef.cpp:
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
- runtime/Identifier.h:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
- wtf/WTFThreadData.cpp: Copied from JavaScriptCore/wtf/WTFThreadData.cpp.
- wtf/WTFThreadData.h: Copied from JavaScriptCore/wtf/WTFThreadData.h.
JavaScriptGlue:
- ForwardingHeaders/wtf/WTFThreadData.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h.
- JSUtils.cpp:
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
WebCore:
- ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::eventNames):
- platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
- 1:28 AM Changeset in webkit [57878] by
-
- 4 edits in trunk
2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Remove LayoutTests/animations/fill-mode-transform.html from the skip list
- platform/qt/Skipped:
2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Antti Koivisto.
[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
- 12:30 AM Changeset in webkit [57877] by
-
- 1 edit in trunk/LayoutTests/fast/forms/interactive-validation-lost-focusable.html
Unreviewed.
Attempt to fix fast/forms/interactive-validation-lost-focusable.html failures on non-Mac.
- 12:15 AM Changeset in webkit [57876] by
-
- 2 edits in trunk/WebKitTools
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[DRT/Chromium] Fix some unexpected results of editing
https://bugs.webkit.org/show_bug.cgi?id=37843
This change fixes about 70 unexpected results.
The original test_webview_delegate.cc doesn't have this bug.
The bug was introduced when I ported it to WebKit tree.
- DumpRenderTree/chromium/WebViewHost.cpp: (printRangeDescription): Replace the latter startContainer() with endContainer().
- 12:03 AM Changeset in webkit [57875] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
More tests for interactive validation
https://bugs.webkit.org/show_bug.cgi?id=37345
Add tests for cases that event handlers modify DOM structures.
These improve test coverage for r57346.
- fast/forms/checkValidity-handler-updates-dom-expected.txt: Added.
- fast/forms/checkValidity-handler-updates-dom.html: Added.
- fast/forms/interactive-validation-lost-focusable-expected.txt: Added.
- fast/forms/interactive-validation-lost-focusable.html: Added.
- fast/forms/script-tests/checkValidity-handler-updates-dom.js: Added.
Apr 19, 2010:
- 11:39 PM Changeset in webkit [57874] by
-
- 2 edits in trunk/WebKit/gtk
2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Expand testatkroles to test ATK form roles.
- tests/testatkroles.c: (test_webkit_atk_get_role_check_box): (test_webkit_atk_get_role_entry): (test_webkit_atk_get_role_label): (test_webkit_atk_get_role_listbox): (test_webkit_atk_get_role_password_text): (test_webkit_atk_get_role_push_button): (test_webkit_atk_get_role_radio_button): (main):
- 11:30 PM Changeset in webkit [57873] by
-
- 3 edits in trunk/WebCore
2010-04-19 Leandro Pereira <leandro@profusion.mobi>
Reviewed by David Hyatt.
Add missing dummy implementations in PluginPackageNone and PluginViewNone.
http://webkit.org/b/37478
- plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::NPVersion): Add dummy implementation.
- plugins/PluginViewNone.cpp: (WebCore::PluginView::handleFocusInEvent): Add dummy implementation. (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
- 11:18 PM Changeset in webkit [57872] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Turn off some unit tests for now - the new-run-webkit-tests dryrun
tests for chromium won't work if you don't have a chromium checkout.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 11:00 PM Changeset in webkit [57871] by
-
- 1 edit1 add in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
(Re-)add dryrun.py; this was renamed from passing.py in the previous
CL but apparently somehow didn't get checked in.
- Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
- 10:41 PM Changeset in webkit [57870] by
-
- 3 edits in trunk/WebKitTools
2010-04-19 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
check-webkit-style: exits when encountering a deleted file
https://bugs.webkit.org/show_bug.cgi?id=37122
This reverts the quick fix done by r57119 and makes check_patch
not call check_file for deleted files.
Also this change fixes the behavior for "-", which should mean
stdin. Before this change, the style checker just ignored "-"
with a warning message.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 10:10 PM Changeset in webkit [57869] by
-
- 6 edits in trunk/WebKitTools
2010-04-19 Daniel Bates <dbates@rim.com>
No review, rolling out 57868.
http://trac.webkit.org/changeset/57868
https://bugs.webkit.org/show_bug.cgi?id=37748
Sheriffbot wasn't very inspirational after this patch.
Instead, he was silent when you said hi :-(. Rolling
out this patch so that I can debug/test this some more.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 9:34 PM Changeset in webkit [57868] by
-
- 6 edits in trunk/WebKitTools
2010-04-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Make Sheriffbot more inspirational.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 9:22 PM Changeset in webkit [57867] by
-
- 5 edits in trunk/WebCore
2010-04-19 Simon Fraser <Simon Fraser>
Reviewed by Geoff Garen.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
since it's only used for <object> fallback.
- rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
- rendering/RenderEmbeddedObject.h: (WebCore::RenderEmbeddedObject::hasFallbackContent):
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
- rendering/RenderPart.h:
- 9:02 PM Changeset in webkit [57866] by
-
- 15 edits4 copies in trunk/WebCore
2010-04-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741
Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
and move code from RenderPart and RenderPartObject into these new classes.
There should be no functionality difference with this change, so no new tests.
Fixing up renderer names in the layout tests will be done in a later pass.
Fix build systems to include the new files.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::createRenderer):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame):
- rendering/RenderFrame.h:
- rendering/RenderFrameBase.cpp: Added. (WebCore::RenderFrameBase::RenderFrameBase): (WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameBase.h: Added.
- rendering/RenderIFrame.cpp: Added. (WebCore::RenderIFrame::RenderIFrame): (WebCore::RenderIFrame::calcHeight): (WebCore::RenderIFrame::calcWidth): (WebCore::RenderIFrame::flattenFrame): (WebCore::RenderIFrame::layout):
- rendering/RenderIFrame.h: Added. (WebCore::RenderIFrame::renderName):
- rendering/RenderPart.cpp:
- rendering/RenderPart.h:
- rendering/RenderPartObject.cpp:
- rendering/RenderPartObject.h:
- 8:59 PM Changeset in webkit [57865] by
-
- 4 edits in trunk/WebCore
Bindings clean-up.
https://bugs.webkit.org/show_bug.cgi?id=37833
Reviewed by Geoffrey Garen.
Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
- 7:59 PM Changeset in webkit [57864] by
-
- 2 edits in trunk/WebCore
Fix the Mac builders for now by restoring the keepAlive function.
- 7:10 PM Changeset in webkit [57863] by
-
- 7 edits in trunk
Build fixes for wx with latest trunk.
- 6:43 PM Changeset in webkit [57862] by
-
- 2 edits in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed. Update chromium test expectations.
- platform/chromium/test_expectations.txt:
- 5:56 PM Changeset in webkit [57861] by
-
- 3 edits2 deletes in trunk/LayoutTests
Remove an extra space in the getComputedStyle-with-psuedo-element test that was causing it to fail on the Chromium bots, and remove the platform-specific results that were landed in the meantime.
Reviewed by Dan Bernstein.
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
- platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
- 5:53 PM Changeset in webkit [57860] by
-
- 5 edits1 delete in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
that can be used to test platforms other than the one you are running
on. This can be useful for checking baselines and testing code
coverage.
Note that running the code on the "wrong" port requires each
port-specific implementation to actually not require any
platform-specific python code (e.g., the chromium-win port must
test for the existence of windows functions before calling them).
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:34 PM Changeset in webkit [57859] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force generated interfaces to be rebuilt. Boo.
- 5:33 PM Changeset in webkit [57858] by
-
- 4 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add --build (default) and --no-build
options to make that step optional. This flag modifies what happens
in port.check_build().
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 5:24 PM Changeset in webkit [57857] by
-
- 2 edits in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed. Update chromium test expectations.
- platform/chromium/test_expectations.txt:
- 5:16 PM Changeset in webkit [57856] by
-
- 38 edits2 deletes in trunk
Roll out r57823.
It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
by shipping clients of WebKit on Windows. Adding methods to a delegate interface in this
manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
methods are used.
- 4:35 PM Changeset in webkit [57855] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
new-run-webkit-tests - fix a typo in r57480 that caused us to stop
logging the actual list of unexpected results.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 4:30 PM Changeset in webkit [57854] by
-
- 3 edits in trunk/WebKit2
Fix build.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 4:26 PM Changeset in webkit [57853] by
-
- 23 edits4 deletes in trunk
This broke windows.
Reviewed by NOBODY (rolling out r57829).
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- API/JSContextRef.cpp:
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
- runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
- wtf/WTFThreadData.cpp: Removed.
- wtf/WTFThreadData.h: Removed.
JavaScriptGlue:
- ForwardingHeaders/wtf/WTFThreadData.h: Removed.
- JSUtils.cpp:
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
WebCore:
- ForwardingHeaders/wtf/WTFThreadData.h: Removed.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::atomicStringTable):
- platform/text/AtomicString.cpp:
(WebCore::stringTable):
- 4:24 PM Changeset in webkit [57852] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/graphics/mac/GraphicsContext3DMac.cpp:
- 4:10 PM Changeset in webkit [57851] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed and landed by Anders Carlsson.
Patch by Douglas Gregor <dgregor@apple.com> on 2010-04-19
- runtime/UStringImpl.h:
Fix class/struct declaration mismatches.
- 4:05 PM Changeset in webkit [57850] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
From a patch by Tor Arne Vestbo <tor.arne.vestbo@nokia.com>
new-run-webkit-tests: make the retry step more explicit
https://bugs.webkit.org/show_bug.cgi?id=37606
It might be confusing to see the test and percent counters
reset without any notice of what's going on, so we make the
message that a retry-run is started explicit.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:59 PM Changeset in webkit [57849] by
-
- 8 edits in trunk/WebKitTools
Add support for opening a new window (File->New Window) to
Windows MiniBrowser. Accelerator doesn't work.
Reviewed by Anders Carlsson.
- MiniBrowser/win/BrowserView.cpp:
(createNewPage): Use BrowserView::create.
- MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
by creating a new window.
- MiniBrowser/win/BrowserWindow.h:
(BrowserWindow::create): Added. Don't allow creating
BrowserWindows on the stack by making constructor
private and exposing the create function.
- MiniBrowser/win/MiniBrowser.cpp:
(MiniBrowser::createNewWindow): Move new window creation
logic here.
- MiniBrowser/win/MiniBrowser.h:
- MiniBrowser/win/MiniBrowser.rc:
- MiniBrowser/win/main.cpp:
(_tWinMain): Use the new MiniBrowser::createNewWindow().
- 3:54 PM QtWebKitGraphics edited by
- (diff)
- 3:27 PM Changeset in webkit [57848] by
-
- 8 edits2 adds in trunk
2010-04-19 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808
Test: platform/mac/accessibility/element-haspopup.html
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaHasPopup):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaHasPopup): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2010-04-19 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808
- platform/mac/accessibility/element-haspopup-expected.txt: Added.
- platform/mac/accessibility/element-haspopup.html: Added.
2010-04-19 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::hasPopup):
- 3:09 PM Changeset in webkit [57847] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Submit a better workaround for r57806 than the one in r57831 - log
an error and exit if you try to run new-run-webkit-tests with --use-drt
on Windows.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:03 PM Changeset in webkit [57846] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Just adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 2:59 PM Changeset in webkit [57845] by
-
- 3 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add slightly better logging to the websocket python wrapper script,
including a --verbose flag for debug output.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/new-run-webkit-websocketserver:
- 2:57 PM Changeset in webkit [57844] by
-
- 2 edits in trunk/WebCore
Fix a crash when rendering <select> elements with WebKit2.
Reviewed by Sam Weinig.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.
- 2:56 PM Changeset in webkit [57843] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add a way (--print-unexpected-results) to
(re-)print out the tests that produced unexpected results in the
last run. Also add a way (--retry-unexpected-results) to
automatically re-test them.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:48 PM Changeset in webkit [57842] by
-
- 1 edit6 adds3 deletes in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed, move chromium baselines for fast/url around.
The desired behavior is that chromium-win use one set of baselines and
chromium-mac/chromium-linux use another, however to do we have to
duplicate the mac+linux results into chromium-mac and chromium-linux.
- platform/chromium-linux/fast/url/file-expected.txt: Added.
- platform/chromium-linux/fast/url/relative-unix-expected.txt: Added.
- platform/chromium-linux/fast/url/relative-win-expected.txt: Added.
- platform/chromium-mac/fast/url/file-expected.txt: Added.
- platform/chromium-mac/fast/url/relative-unix-expected.txt: Added.
- platform/chromium-mac/fast/url/relative-win-expected.txt: Added.
- platform/chromium/fast/url/file-expected.txt: Removed.
- platform/chromium/fast/url/relative-unix-expected.txt: Removed.
- platform/chromium/fast/url/relative-win-expected.txt: Removed.
- 2:41 PM Changeset in webkit [57841] by
-
- 3 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Restructure the logging in new-run-webkit-tests so that many of log
messages that were logged to the MeteredStream also get logged in
--verbose mode.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:39 PM Changeset in webkit [57840] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: add 'summary' and 'unexpected-results' options
to the --log flag. Also add a 'progress' flag to enable the regular
progress bar (as opposed to 'detailed-progress', which enables the
dots). Also add a 'nothing' flag to allow you to be explicit that
you don't want any logging on the command line.
The default is
'--log detailed-progress,summary,unexpected,unexpected-results'
(The default logging is unchanged by this patch, this just makes things
properly configurable).
Note that 'nothing' doesn't work properly yet; I need a couple other
patches to land to avoid rewriting things several different ways.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:15 PM Changeset in webkit [57839] by
-
- 4 edits2 adds in trunk
Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
https://bugs.webkit.org/show_bug.cgi?id=36031
Reviewed by Darin Adler.
WebCore:
Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.
Test: fast/dom/Node/fragment-mutation.html
- dom/ContainerNode.cpp:
(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in
inserting/appending operation.
(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.
- dom/Node.cpp:
(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.
LayoutTests:
These tests study various side-effects of DOM mutation events fired during appending/inserting
document fragments.
- fast/dom/Node/fragment-mutation-expected.txt: Added.
- fast/dom/Node/fragment-mutation.html: Added.
- 2:10 PM Changeset in webkit [57838] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed - yet more rebaselines and expectation updates.
- platform/chromium-win/fast/url/file-expected.txt: Added.
- platform/chromium-win/fast/url/relative-unix-expected.txt: Added.
- platform/chromium-win/fast/url/relative-win-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:07 PM Changeset in webkit [57837] by
-
- 1 edit3 adds in trunk/JavaScriptCore
Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.
Reviewed by Beth Dakin.
- tests/perf: Added.
- tests/perf/bench-allocate-nonretained.js: Added.
- tests/perf/bench-allocate-retained.js: Added.
- 1:56 PM Changeset in webkit [57836] by
-
- 4 edits in trunk/WebKitTools
Make the URL change on committed load.
Reviewed by Simon Hausmann.
- QtLauncher/mainwindow.cpp:
(MainWindow::buildUI):
(MainWindow::setAddressUrl):
- QtLauncher/mainwindow.h:
- 1:51 PM Changeset in webkit [57835] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix).
- 1:50 PM Changeset in webkit [57834] by
-
- 4 edits3 adds2 deletes in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed. More chromium rebaselines+expectation updates.
- platform/chromium-linux/fast/css/getComputedStyle: Added.
- platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
- platform/chromium-mac/media/video-src-change-expected.txt:
- platform/chromium-mac/media/video-src-invalid-remove-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
- platform/chromium-win/media/video-src-change-expected.txt:
- platform/chromium-win/media/video-src-invalid-remove-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 1:35 PM Changeset in webkit [57833] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix a typo in the rebaselining tool that causes us to use "debug"
instead of "Debug" in a directory path, which fails on platforms with
case-sensitive filesystems.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 1:20 PM Changeset in webkit [57832] by
-
- 2 edits in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed build fix.
Update chromium expectations
- platform/chromium/test_expectations.txt:
- 1:17 PM Changeset in webkit [57831] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix breakage of chromium-win canary bots caused by r57806. That patch
introduced the option of using Chrome's new port of DumpRenderTree,
but unfortunately that port relies on the webkit.py class
implementation which uses non-blocking I/O that isn't available on
Windows. This patch turns off that option and doesn't import the
class if we're running on Windows.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 1:12 PM Changeset in webkit [57830] by
-
- 2 edits in trunk/WebCore
2010-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Fix regression introduced in r57820.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of just setting a URL on the one used for the previous <source> element. This restores the behavior prior to the changes for https://bugs.webkit.org/show_bug.cgi?id=37728.
- 1:05 PM Changeset in webkit [57829] by
-
- 22 edits2 copies2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.
Reviewed by Sam Weinig.
Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.
WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.
This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.
- API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- API/JSContextRef.cpp:
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
- runtime/Identifier.h:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
- wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
- wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.
(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):
JavaScriptGlue:
- ForwardingHeaders/wtf/WTFThreadData.h: Added.
- JSUtils.cpp: Update
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
WebCore:
- ForwardingHeaders/wtf/WTFThreadData.h: Added.
- platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h: Remove m_atomicStringTable.
(WebCore::ThreadGlobalData::eventNames):
- platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().
- 1:00 PM CommitterTips edited by
- There is no more "--no-build" option anymore. (diff)
- 12:36 PM Changeset in webkit [57828] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 James Robinson <jamesr@chromium.org>
Reviewed by abarth.
Fix a typo
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 12:29 PM Changeset in webkit [57827] by
-
- 2 edits5 adds in trunk/LayoutTests
2010-04-19 James Robinson <jamesr@chromium.org>
Unreviewed build fix for Chromium
Add baselines for new platform-specific tests.
- platform/chromium/fast/url: Added.
- platform/chromium/fast/url/file-expected.txt: Added.
- platform/chromium/fast/url/relative-expected.txt: Added.
- platform/chromium/fast/url/relative-unix-expected.txt: Added.
- platform/chromium/fast/url/relative-win-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:13 PM Changeset in webkit [57826] by
-
- 3 edits in trunk/WebCore
Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
- 12:13 PM Changeset in webkit [57825] by
-
- 2 edits in trunk/WebKitTools
Fix run-webkit-tests when there are spaces in the path
Fixes <http://webkit.org/b/37809>
Reviewed by Adam Barth.
- Scripts/run-webkit-tests: Use an "indirect object" to specify the
path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.
- 12:01 PM Changeset in webkit [57824] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild of Interfaces.vcproj
- 11:49 AM Changeset in webkit [57823] by
-
- 38 edits2 adds in trunk
WebCore: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
Test: fast/dom/icon-url-property.html
- dom/Document.cpp:
(WebCore::Document::setIconURL):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setIconURL):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::iconURL):
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
WebKit/chromium: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didChangeIcons):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
- src/FrameLoaderClientImpl.h:
WebKit/gtk: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidChangeIcons):
WebKit/qt: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::didChangeTitle):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- Interfaces/IWebFrameLoadDelegatePrivate2.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidChangeIcons):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
(WebFrame::didChangeIcons):
- WebFrame.h:
WebKitTools: Add test support for icon changes.
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpIconChangesCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpIconChanges):
(LayoutTestController::setDumpIconChanges):
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didChangeIcons):
- DumpRenderTree/win/FrameLoadDelegate.h:
- WinLauncher/WinLauncher.h:
(WinLauncherWebHost::didChangeIcons):
LayoutTests: Add test for icon change notifications.
Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=33812
- fast/dom/icon-url-property-expected.txt: Added.
- fast/dom/icon-url-property.html: Added.
- Skipped on all platforms but Win
- 11:37 AM Changeset in webkit [57822] by
-
- 12 edits in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.
Reviewed by Jeremy Orlow.
- WebCore.base.exp: Export Settings::setSessionStorageQuota().
- page/Page.cpp:
(WebCore::Page::sessionStorage):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):
- page/Settings.h:
(WebCore::Settings::sessionStorageQuota):
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageNamespace.h:
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
- storage/StorageNamespaceImpl.h:
WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=37717
Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
StorageNamespace::sessionStorageNamespace() take in a quota parameter.
Reviewed by Jeremy Orlow.
- src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
- src/WebStorageNamespaceImpl.cpp:
(WebKit::WebStorageNamespace::createSessionStorageNamespace):
- 11:34 AM Changeset in webkit [57821] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Build fix for WinCE.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.
Moved the include of the non-existing errno.h header file inside
platform guard macros.
- jit/ExecutableAllocatorFixedVMPool.cpp:
- 11:28 AM Changeset in webkit [57820] by
-
- 9 edits2 deletes in trunk
2010-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Setting media element 'src' attribute should trigger immediate load
https://bugs.webkit.org/show_bug.cgi?id=37728
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute changes unless it is missing. (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal. (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad. (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad so the previously loading file, if any, is cancelled there.
2010-04-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Setting media element 'src' attribute should trigger immediate load
https://bugs.webkit.org/show_bug.cgi?id=37728
- media/event-attributes-expected.txt: Updated results.
- media/event-attributes.html: Do not need to call load().
- media/video-source-add-src-expected.txt: Removed.
- media/video-source-add-src.html: Removed.
- media/video-src-change-expected.txt: Updated results.
- media/video-src-change.html: Update test to match current behavior.
- media/video-src-invalid-remove-expected.txt: Updated results.
- media/video-src-invalid-remove.html: Update test to match current behavior.
- 11:07 AM Changeset in webkit [57819] by
-
- 8 edits in trunk
[Qt] Fix compilation against namespaced Qt.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.
WebCore:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/Tile.h:
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- platform/network/qt/NetworkStateNotifierPrivate.h:
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/QtFallbackWebPopup.h:
- 11:00 AM Changeset in webkit [57818] by
-
- 2 edits in trunk/WebCore
2010-04-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Destroy SharedTimerQt before destruction of QCoreApplication.
To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
into the SharedTimerQt instance.
No functional change so no new tests.
- platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::destroy): (WebCore::SharedTimerQt::inst):
- 10:48 AM Changeset in webkit [57817] by
-
- 2 edits in trunk/WebCore
Make the fix for <rdar://problem/7873647> from r57759 more robust.
Reviewed by Darin Adler.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.
- 10:43 AM Changeset in webkit [57816] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Roben.
WinLauncher.h should use LF line-endings and use native line-endings style.
https://bugs.webkit.org/show_bug.cgi?id=37807
- WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
- 10:38 AM Changeset in webkit [57815] by
-
- 3 edits1 add in trunk
2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Add and enable the build of testatkroles to test ATK non form roles.
- GNUmakefile.am:
2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Add testatkroles to test ATK non form roles.
- tests/testatkroles.c: Added. (finish_loading): (atk_roles_fixture_setup): (atk_roles_fixture_teardown): (get_child_and_test_role): (test_webkit_atk_get_role_document_frame): (test_webkit_atk_get_role_heading): (test_webkit_atk_get_role_image): (test_webkit_atk_get_role_link): (test_webkit_atk_get_role_list_and_item): (test_webkit_atk_get_role_paragraph): (test_webkit_atk_get_role_section): (test_webkit_atk_get_role_table): (main):
- 10:21 AM Changeset in webkit [57814] by
-
- 2 edits in trunk/WebKit/mac
Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.
Reviewed by Sam Weinig.
- WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
- 10:11 AM Changeset in webkit [57813] by
-
- 2 edits in trunk/WebCore
2010-04-19 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix.
- bindings/v8/JavaScriptCallFrame.h:
- 10:01 AM Changeset in webkit [57812] by
-
- 10 edits3 adds in trunk
2010-04-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement JavaScriptCallFrame that works for v8.
Implementing this binding for v8 allows to make evaluations on
call frames and protects access to the debugger context from
inspected context.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
- bindings/v8/JavaScriptCallFrame.cpp: Added. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::scopeType): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
- bindings/v8/JavaScriptCallFrame.h: Added. (WebCore::JavaScriptCallFrame::create):
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added. (WebCore::V8JavaScriptCallFrame::evaluateCallback): (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter): (WebCore::V8JavaScriptCallFrame::scopeTypeCallback): (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter): (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
- inspector/JavaScriptCallFrame.idl:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
- 9:41 AM Changeset in webkit [57811] by
-
- 5 edits39 adds in trunk/LayoutTests
[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.
Rubber-stamped by Simon Hausmann.
Compared to Mac png files and Mac expected files.
- platform/qt/Skipped:
- platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
- platform/qt/fast/frames/frame-navigation-expected.png: Added.
- platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
- platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
- platform/qt/fast/overflow/line-clamp-expected.png: Added.
- platform/qt/fast/overflow/line-clamp-expected.txt: Added.
- platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
- platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
- platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
- platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
- platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
- platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
- platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
- platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
- platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
- platform/qt/http/tests/misc/error404-expected.checksum: Added.
- platform/qt/http/tests/misc/error404-expected.png: Added.
- platform/qt/http/tests/misc/error404-expected.txt: Added.
- platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
- platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
- platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
- platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
- platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
- platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
- platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
- platform/qt/http/tests/misc/iframe404-expected.png: Added.
- platform/qt/http/tests/misc/iframe404-expected.txt: Added.
- platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
- platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
- platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
- platform/qt/http/tests/uri/css-href-expected.checksum: Added.
- platform/qt/http/tests/uri/css-href-expected.png: Added.
- platform/qt/http/tests/uri/css-href-expected.txt: Updated.
- platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
- platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
- platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
- platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
- 8:05 AM Changeset in webkit [57810] by
-
- 2 edits in trunk/WebCore
Rubber Stamped by Adam Roben
Chromium Release Build Fix.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.
- 6:28 AM Changeset in webkit [57809] by
-
- 13 edits2 adds in trunk
First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
https://bugs.webkit.org/show_bug.cgi?id=24021
Reviewed by Dave Hyatt.
WebCore:
Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.
Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
- WebCore.base.exp:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.
- css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Take into consideration the pseudo-element.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.
- css/CSSSelector.h:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.
- dom/Element.cpp:
(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.
- dom/Element.h:
(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.
- dom/Node.h:
(WebCore::Node::computedStyle):
Ditto.
- dom/Node.cpp:
(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
Ditto.
LayoutTests:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.
- 4:54 AM Changeset in webkit [57808] by
-
- 2 edits in trunk/LayoutTests
[Qt] lacks clipToImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=24289
Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.
- platform/qt/Skipped:
- 2:05 AM Changeset in webkit [57807] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
[DRT/Chromium] Fix a test initialization problem
https://bugs.webkit.org/show_bug.cgi?id=37791
- DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Call resetTestController() before runFileTest(). Some controllers initialize their fields in reset() and not in their constructors.
- 1:52 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 1:40 AM Changeset in webkit [57806] by
-
- 2 edits in trunk/WebKitTools
2010-04-19 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
https://bugs.webkit.org/show_bug.cgi?id=37793
We need to use WebKitDriver instead of ChromiumDriver for Chromium
DRT because its interface is different from test_shell.
Chromium DRT has no UI. So we can't use it to show test results.
- Scripts/webkitpy/layout_tests/port/chromium.py:
Apr 18, 2010:
- 11:36 PM Changeset in webkit [57805] by
-
- 3 edits in trunk/WebKitTools
2010-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Roben.
Make failure-reason more forgiving
https://bugs.webkit.org/show_bug.cgi?id=37525
Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/tool/commands/queries.py:
- 10:13 PM Changeset in webkit [57804] by
-
- 2 edits in trunk/JavaScriptCore
2010-04-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
https://bugs.webkit.org/show_bug.cgi?id=37434
Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.
- wtf/Platform.h:
- 9:26 PM Changeset in webkit [57803] by
-
- 3 edits2 adds in trunk/WebKitTools
Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=37754
This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.
- Scripts/webkitpy/common/system/logtesting.py:
- Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
- Scripts/webkitpy/style/checker.py:
- Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
- Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
- Scripts/webkitpy/style/filereader.py: Added.
- Created a TextFileReader class that encapsulates reading and iterating over text files.
- Scripts/webkitpy/style/filereader_unittest.py: Added.
- Added a TextFileReaderTest class to unit-test the new TextFileReader class.
- 9:22 PM Changeset in webkit [57802] by
-
- 4 edits in trunk
2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix JavaScriptCore's include path for WinCE builds
- JavaScriptCore.pri:
2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix JavaScriptCore's include path for WinCE builds
- WebCore.pro:
- 9:08 PM Changeset in webkit [57801] by
-
- 2 edits in trunk
2010-04-18 Michael Forney <michael@mforney.org>
Reviewed by Laszlo Gombos.
Fixes the sandbox option in configure.
- configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
- 8:26 PM Changeset in webkit [57800] by
-
- 5 edits in trunk/WebKitTools
2010-04-15 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
[chromium] new-run-webkit-tests should be able to use chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=37645
Make sure that the lack of a chromium checkout doesn't cause the script to
fail.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
to be relative to an upstream output dir.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
- 2:25 PM Changeset in webkit [57799] by
-
- 2 edits in trunk/WebKitTools
2010-04-18 Eric Seidel <eric@webkit.org>
Unreviewed, fixing the Qt bot.
Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632
- Scripts/run-webkit-tests:
- Exit non-zero of launching the harness fails.
- 1:58 PM Changeset in webkit [57798] by
-
- 2 edits in trunk/WebKitTools
2010-04-18 Eric Seidel <eric@webkit.org>
Unreviewed, fixing the Qt bot.
Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632
- Scripts/run-webkit-tests:
- Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
- 1:56 PM Changeset in webkit [57797] by
-
- 2 edits in trunk/WebKitSite
2010-04-18 Adam Barth <abarth@webkit.org>
Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.
- blog-files/loader-diagram.svg:
- 1:34 PM Changeset in webkit [57796] by
-
- 3 edits1 copy in trunk/WebKitTools
2010-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
https://bugs.webkit.org/show_bug.cgi?id=37632
This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.
Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.
I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.
- Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
- Scripts/run-webkit-tests:
- A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
- 10:43 AM Changeset in webkit [57795] by
-
- 3 edits in trunk/WebKitTools
2010-04-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33295
The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 4:01 AM Changeset in webkit [57794] by
-
- 4 edits1 add in trunk/LayoutTests
[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <robert@webkit.org>
Unreviewed fix to pixel differences in unskipped layout tests.
[Qt] Add support for LayoutTestController commands
Fix up minor pixel differences on unskipped tests from r57793.
- platform/qt/editing/deleting/smart-delete-003-expected.txt:
- platform/qt/editing/deleting/smart-delete-004-expected.txt:
- platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
- platform/qt/editing/selection/5195166-2-expected.txt:
- 3:36 AM Changeset in webkit [57793] by
-
- 17 edits in trunk
[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add support for LayoutTestController commands:
setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
- Api/qwebpage_p.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
- WebCoreSupport/EditorClientQt.h:
2010-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add support for LayoutTestController commands:
setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled
Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html
- platform/qt/Skipped:
- platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
- platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
- platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
- platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
- platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.
2010-04-18 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Add support for LayoutTestController commands:
setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:25 AM Changeset in webkit [57792] by
-
- 2 edits in trunk/LayoutTests
2010-04-18 Antonio Gomes <tonikitoo@webkit.org>
[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)
It was removed by r57511.
- platform/qt/Skipped:
