Context Navigation

Allow MIMETypeRegistry to have more than one MIME type for a
media file extension, and have the QTKit media engine register
all MIME types it can find for each file type QTKit supports.

Test: media/media-can-play-mp3.html

platform/MIMETypeRegistry.cpp: (WebCore::mediaMIMETypeMap): Update for new HashMap format. (WebCore::TypeExtensionPair::): Store String+Vector<String> (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Only consult mediaMIMETypeMap(), it has the canonical answer. (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): New, return a Vector of all MIME types for an extension.
platform/MIMETypeRegistry.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add all MIME types returned in the getMediaMIMETypesForExtension Vector.

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
https://bugs.webkit.org/show_bug.cgi?id=40594

media/media-can-play-mp3-expected.txt: Added.
media/media-can-play-mp3.html: Added.

6:50 PM Changeset in webkit [61171] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/8071866> REGRESSION: Crash on launch on Tiger and Leopard with network home folder

Reviewed by Brady Eidson.

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Don't assume that tail is always non-null, since that may
not be the case with some versions of SQLite. Instead we must null-check before dereferencing.

6:41 PM Changeset in webkit [61170] by andersca@apple.com

2 edits in trunk/WebKit/chromium

Fix Chromium build.

src/WebPluginListBuilderImpl.cpp:

(WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

6:37 PM Changeset in webkit [61169] by andersca@apple.com

2 edits in trunk/WebCore

Fix Tiger build.

plugins/mac/PluginDataMac.mm:

6:30 PM Changeset in webkit [61168] by andersca@apple.com

10 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use an array for extensions in MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40602

Get rid of MimeClassInfo::suffixes and replace it with an array of extensions.

plugins/MimeType.cpp: (WebCore::MimeType::suffixes): Create a string of joined extensions.

plugins/MimeType.h:
plugins/PluginData.h: (WebCore::operator==):
plugins/chromium/PluginDataChromium.cpp: (WebCore::getPluginMimeTypeFromExtension):
plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):

5:52 PM Changeset in webkit [61167] by abarth@webkit.org

2 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Add an include to try to fix Chromium build.

html/HTML5DocumentParser.cpp:

5:35 PM Changeset in webkit [61166] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Reorder build event to fix cygwin path issue.

win/WebKit2Generated.vcproj:

5:25 PM Changeset in webkit [61165] by abarth@webkit.org

5 edits in trunk/WebCore

2010-06-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari beach-balls loading large pages with HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40596

Implement parser yielding, similar to how the old
HTMLDocumentParser yields.

This implementation re-uses the tokenizerTimeDelay and
tokenizerChunkSize settings even though they don't map exactly
to the token loop that the HTML5 parser uses.

dom/DocumentParser.h:
- Add a FIXME for processingData() and clarify how the appendData flag is used by renaming it to isFromNetwork.
html/HTML5DocumentParser.cpp: (WebCore::parserTimeLimit):
- Defaults accessor, probably belongs on Page.

(WebCore::parserChunkSize):

Defaults accessor, probably belongs on Page.

(WebCore::HTML5DocumentParser::HTML5DocumentParser):
(WebCore::HTML5DocumentParser::stopParsing):

Stop the continue-parsing timer if active.

(WebCore::HTML5DocumentParser::processingData):

Implement this poorly understood accessor to match the old parser's behavior. It's unclear what this does and it does not affect any layout tests to my knowledge but likely affects the WebKit API in some way.

(WebCore::HTML5DocumentParser::pumpLexerIfPossible):

Pass SynchronousMode.
Do not ever pump if we've yielded to the timer.

(WebCore::HTML5DocumentParser::PumpSession::PumpSession):

A struct for storing the yield counters.

(WebCore::HTML5DocumentParser::shouldContinueParsing):

Mostly matches HTMLDocumentParser::shouldContinueParsing.

(WebCore::HTML5DocumentParser::pumpLexer):

Respect SynchronousMode.
ASSERT that a timer is not scheduled if we're pumping.

(WebCore::isLayoutTimerActive):

This belongs on Document.

(WebCore::HTML5DocumentParser::continueNextChunkTimerFired):
(WebCore::HTML5DocumentParser::write):
(WebCore::HTML5DocumentParser::end):

We should never end() if a timer is still outstanding.

(WebCore::HTML5DocumentParser::attemptToEnd):
(WebCore::HTML5DocumentParser::endIfDelayed):
(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::):
html/HTMLDocumentParser.cpp:
- Clarify the old TimeDelay and ChunkSize constants.

5:20 PM Changeset in webkit [61164] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

win/WebKit2WebProcess.vcproj:

5:07 PM Changeset in webkit [61163] by abarth@webkit.org

10 edits
2 adds in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preload scanner for the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40557

This patch adds a simple preload scanner for the HTML5 parser. This
preload scanner is not as awesome as the old one because it doesn't
scan CSS, but it's much simpler.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
- Build file torture.
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::write):
- Call into the preload scanner when waiting for a script.
html/HTML5DocumentParser.h:
html/HTML5PreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::scan):
- A simple loop to pump the preload scanner's lexer.

(WebCore::HTML5PreloadScanner::processToken):

Preload interesting resources. Stolen from the old preload scanner.

(WebCore::HTML5PreloadScanner::scanningBody):

html/HTML5PreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.

5:00 PM Changeset in webkit [61162] by tony@chromium.org

4 edits in trunk

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore directories fetched by chromium and chromium mac output dir.

chromium: Added property svn:ignore.

2010-06-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore Chromium Linux build files.

.: Added property svn:ignore. Modified property svn:ignore.

4:58 PM Changeset in webkit [61161] by abarth@webkit.org

5 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Constify some HTML5Token methods
https://bugs.webkit.org/show_bug.cgi?id=40592

I keep wanting these methods to be const. Eric wanted this in a
separate patch.

html/HTML5Lexer.h: (WebCore::HTML5Lexer::state):
html/HTML5Token.h: (WebCore::HTML5Token::attributes): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment): (WebCore::HTML5Token::publicIdentifier): (WebCore::HTML5Token::systemIdentifier):
html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::adjustedLexerState):
- Technically, this might belong in the other patch, but I think it's fine here.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

html/HTML5TreeBuilder.h:

4:47 PM Changeset in webkit [61160] by sfalken@apple.com

2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

win/WebKit2Generated.vcproj:

4:11 PM Changeset in webkit [61159] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, more Chromium expectations updates.

platform/chromium/test_expectations.txt:

3:31 PM Changeset in webkit [61158] by dumi@chromium.org

2 edits in trunk/WebCore

Unreviewed, build fix.

WebCore.xcodeproj/project.pbxproj:

3:27 PM Changeset in webkit [61157] by ap@apple.com

2 edits in trunk/WebKitTools

Chromium build fix.

DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.

3:27 PM Changeset in webkit [61156] by Dimitri Glazkov

2 edits in trunk/WebCore

Unreviewed, build fix.

Remove accidental specifying of the class name twice.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareFormData): Removed my ghastly typo.

3:08 PM Changeset in webkit [61155] by adachan@apple.com

3 edits in trunk/WebKit2

Rubber-stamped by Steve Falkenburg.

Fix the release configuration to use release.vsprops.
Add Debug_Internal and Debug_All configurations to the WebKit2WebProcess project.
Fix launchWebProcess() to get the right path to the WebKit2WebProcess executable.

UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::launchWebProcess):
win/WebKit2WebProcess.vcproj:

3:07 PM Changeset in webkit [61154] by dumi@chromium.org

15 edits in trunk

Get DatabaseTracker ready for sync DBs.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::~AbstractDatabase):

storage/AbstractDatabase.h:
storage/Database.cpp:

(WebCore::Database::closeImmediately):

storage/Database.h:

(WebCore::Database::scriptExecutionContext):

storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

storage/DatabaseTracker.h:
storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

storage/OriginQuotaManager.h:
storage/chromium/DatabaseObserver.h:
storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::TrackerRemoveOpenDatabaseTask::create):
(WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

WebKit/chromium:

public/WebDatabase.h:
src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):
(WebKit::WebDatabase::WebDatabase):
(WebKit::WebDatabase::operator=):
(WebKit::WebDatabase::operator WTF::PassRefPtr<AbstractDatabase>):

2:58 PM Changeset in webkit [61153] by ap@apple.com

11 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms

WebCore:

platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use virtual key code to force correct character code for clarity. Also, reworded comment, since saying that "backspace needs to always be 8" misleadingly implied that it could "sometimes" be such without this code.

WebKitTools:

DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete.

DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those.

LayoutTests:

editing/deleting/forward-delete-key-expected.txt: Added.
editing/deleting/forward-delete-key.html: Added. Added a test for forward delete key working (particularly in DRT, since there was a lot of confusion between platform maintainers about it).

fast/forms/resources/input-live-pseudo-selectors.js:
fast/forms/resources/textarea-live-pseudo-selectors.js: These two tests expected that keyDown("delete") executed backward delete, changed them to send "\x08" for backspace.

2:51 PM Changeset in webkit [61152] by Dimitri Glazkov

3 edits in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Refactor form submission code in HTMLFormElement to add clarity.
https://bugs.webkit.org/show_bug.cgi?id=39430

Covered by existing tests in fast/forms/mailto.

html/HTMLFormElement.cpp: (WebCore::appendMailtoPostFormDataToURL): Renamed from transferMailtoPostFormDataToUrl,

removed clearing out of the FormData and moved it to a new place (next to the call site).

(WebCore::HTMLFormElement::prepareFormData): Renamed from createFormData, moved the logic of

prepareing FormData here, including the use of appendMailtoPostFormDataToURL.

(WebCore::HTMLFormElement::submit): Consolidated multiple invocations of submitForm().

html/HTMLFormElement.h: Renamed createFormData to prepareFormData.

2:48 PM Changeset in webkit [61151] by Chris Fleizach

8 edits in trunk

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Reviewed by Darin Adler.

WebCore:

accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListItem):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKit/chromium:

public/WebAccessibilityRole.h:
src/AssertMatchingEnums.cpp:

2:45 PM Changeset in webkit [61150] by andersca@apple.com

9 edits in trunk

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

plugins/PluginData.h:
plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):

2:41 PM Changeset in webkit [61149] by kinuko@chromium.org

11 edits
2 adds in trunk/WebCore

2010-06-14 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

No new tests; they will be added when we add jsc bindings.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/BlobBuilder.cpp: Added.
html/BlobBuilder.h: Added. (WebCore::BlobBuilder::create):
platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): Added EndingNative support.
platform/BlobItem.h: Added EndingNative line-ending type. (WebCore::):

2:37 PM Changeset in webkit [61148] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, temporary update Chromium expectations after http://trac.webkit.org/changeset/61128

platform/chromium/test_expectations.txt:

2:13 PM Changeset in webkit [61147] by andersca@apple.com

5 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Stop using MimeClassInfo::pluginIndex
https://bugs.webkit.org/show_bug.cgi?id=40582

Add a pluginIndicies vector to PluginData and use it instead of MimeClassInfo::pluginIndex.

plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin): Get the plug-in index from the mimePluginIndices vector.

plugins/Plugin.cpp: (WebCore::Plugin::item): Compare the mime plugin index as well.

plugins/PluginData.cpp: (WebCore::PluginData::PluginData): Populate the m_mimePluginIndices vector.

(WebCore::PluginData::pluginNameForMimeType):
Get the plug-in index from the m_mimePluginIndices vector.

plugins/PluginData.h: (WebCore::operator==): Don't check for pluginIndex.

(WebCore::PluginData::mimePluginIndices):
Add getter for m_mimePluginIndices.

2:08 PM Changeset in webkit [61146] by weinig@apple.com

2 edits in trunk/WebCore

Better build fix.

bindings/js/JSBindingsAllInOne.cpp:

2:06 PM Changeset in webkit [61145] by weinig@apple.com

2 edits in trunk/WebCore

Another windows build fix.

bindings/js/JSBindingsAllInOne.cpp:

2:03 PM Changeset in webkit [61144] by Martin Robinson

2 edits in trunk/WebKitTools

2010-06-14 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Small GtkLauncher build fix for some systems.

GtkLauncher/main.c: Add <limit.h> include.

1:54 PM Changeset in webkit [61143] by weinig@apple.com

2 edits in trunk/WebCore

Another build fix.

bindings/js/JSDOMWindowCustom.cpp:

1:45 PM Changeset in webkit [61142] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

[Qt] Unreviewed fix. Platform specific expected results updated after r61136.

platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

1:09 PM Changeset in webkit [61141] by crogers@google.com

1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

A little cleanup in realtime analyser code

1:09 PM Changeset in webkit [61140] by crogers@google.com

1 edit in branches/audio/WebCore/audio/Reverb.cpp

Handle edge case of reverb 1 -> 4 -> 2 matrixing

1:09 PM Changeset in webkit [61139] by crogers@google.com

2 edits in branches/audio/WebCore/audio

include config.h in MidSide

1:05 PM Changeset in webkit [61138] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/justify-padding-distribution.html fails
https://bugs.webkit.org/show_bug.cgi?id=40584

platform/qt/Skipped: fast/text/justify-padding-distribution.html skipped until fix.

12:51 PM Changeset in webkit [61137] by weinig@apple.com

2 edits in trunk/WebCore

Add missing comma to fix GTK build.

xml/XSLTProcessor.idl:

12:46 PM Changeset in webkit [61136] by weinig@apple.com

47 edits
4 moves
28 deletes in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40581
Auto-generate most of the JS constructors

Reviewed by Alexey Proskuryakov.

WebCore:

Auto-generates all the JS constructors that don't have custom names (eg, Not Image(), Audio() or Option())
Fixes two typos.

(new XSLTConstructor()).toString() [object XSLTProcessorConsructor] -> [object XSLTProcessorConstructor])
(new EventSource()).toString() [object EventSourceContructor] -> [object EventSourceConstructor])

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSArrayBufferConstructor.cpp: Removed.
bindings/js/JSArrayBufferConstructor.h: Removed.
bindings/js/JSArrayBufferCustom.cpp: Copied from WebCore/bindings/js/JSArrayBufferConstructor.cpp.

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferView):

bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSEventSourceConstructor.cpp: Removed.
bindings/js/JSEventSourceConstructor.h: Removed.
bindings/js/JSEventSourceCustom.cpp: Copied from WebCore/bindings/js/JSEventSourceConstructor.cpp.

(WebCore::JSEventSourceConstructor::constructJSEventSource):

bindings/js/JSFloat32ArrayConstructor.cpp: Removed.
bindings/js/JSFloat32ArrayConstructor.h: Removed.
bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

bindings/js/JSInt16ArrayConstructor.cpp: Removed.
bindings/js/JSInt16ArrayConstructor.h: Removed.
bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

bindings/js/JSInt32ArrayConstructor.cpp: Removed.
bindings/js/JSInt32ArrayConstructor.h: Removed.
bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

bindings/js/JSInt8ArrayConstructor.cpp: Removed.
bindings/js/JSInt8ArrayConstructor.h: Removed.
bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

bindings/js/JSMessageChannelConstructor.cpp: Removed.
bindings/js/JSMessageChannelConstructor.h: Removed.
bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannelConstructor::constructJSMessageChannel):

bindings/js/JSSharedWorkerConstructor.cpp: Removed.
bindings/js/JSSharedWorkerConstructor.h: Removed.
bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

bindings/js/JSUint16ArrayConstructor.cpp: Removed.
bindings/js/JSUint16ArrayConstructor.h: Removed.
bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

bindings/js/JSUint32ArrayConstructor.cpp: Removed.
bindings/js/JSUint32ArrayConstructor.h: Removed.
bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

bindings/js/JSUint8ArrayConstructor.cpp: Removed.
bindings/js/JSUint8ArrayConstructor.h: Removed.
bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

bindings/js/JSWebKitCSSMatrixConstructor.cpp: Removed.
bindings/js/JSWebKitCSSMatrixConstructor.h: Removed.
bindings/js/JSWebKitCSSMatrixCustom.cpp: Copied from WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp.

(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):

bindings/js/JSWebKitPointConstructor.cpp: Removed.
bindings/js/JSWebKitPointConstructor.h: Removed.
bindings/js/JSWebKitPointCustom.cpp: Copied from WebCore/bindings/js/JSWebKitPointConstructor.cpp.

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

bindings/js/JSWebSocketConstructor.cpp: Removed.
bindings/js/JSWebSocketConstructor.h: Removed.
bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

bindings/js/JSWorkerConstructor.cpp: Removed.
bindings/js/JSWorkerConstructor.h: Removed.
bindings/js/JSWorkerContextCustom.cpp:
bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

bindings/js/JSXSLTProcessorConstructor.cpp: Removed.
bindings/js/JSXSLTProcessorConstructor.h: Removed.
bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

bindings/scripts/CodeGeneratorJS.pm:
css/WebKitCSSMatrix.idl:
dom/MessageChannel.idl:
html/canvas/ArrayBuffer.idl:
html/canvas/Float32Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
page/EventSource.idl:
page/WebKitPoint.idl:
websockets/WebSocket.idl:
workers/SharedWorker.idl:
workers/Worker.idl:
xml/XSLTProcessor.idl:

LayoutTests:

fast/dom/Window/window-lookup-precedence-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/dom/constructed-objects-prototypes-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/js/global-constructors-expected.txt:

12:11 PM Changeset in webkit [61135] by tonikitoo@webkit.org

2 edits in trunk/WebCore

2010-05-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed naming fixes of local variables used in Spatial Navigation methods.

Summary:

"candidate" renamed to "node";
"currentFocusCandidate" renamed to "candidate"
"closestFocusCandidate" renamed to "closest"

That way naming is more consistent in the various Spatial Navigation methods.

page/FocusController.cpp: (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):

12:10 PM Changeset in webkit [61134] by tonikitoo@webkit.org

5 edits
4 adds in trunk

Spatial Navigation: make it work with focusable elements in overflow content
https://bugs.webkit.org/show_bug.cgi?id=36463

Reviewed by Simon Fraser and Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

This patch addresses the problem with Spatial Navigation. It currently does not
properly traverse scrollable contents, including scrollable div's. For this to work,
a new class member called scrollableEnclosingBox was introduced to FocusCandidate class which
keeps track of the current scrollable box Node wrapping a FocusCandidate.

To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal routine
(FocusController::findNextFocusableInDirection) was changed as follows: when it
encounters a scrollable Node, each focusable node which is 'inner' keeps track of
the container reference. By the time a sibling of the scrollable Node is encountered,
there is no need to track this reference any more and the traversal algorithm continues
normally.

The common case is obviously that there is no scrollable container wrapping it.

updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.

Tests: fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

fast/events/spatial-navigation/snav-clipped-overflow-content.html

page/FocusController.cpp:

(WebCore::updateFocusCandidateInSameContainer):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

page/SpatialNavigation.cpp:

(WebCore::isScrollableContainerNode):

page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::FocusCandidate::inScrollableContainer):

LayoutTests:

fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt: Added.
fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html: Added.
fast/events/spatial-navigation/snav-clipped-overflow-content-expected.txt: Added.
fast/events/spatial-navigation/snav-clipped-overflow-content.html: Added.

11:59 AM Changeset in webkit [61133] by jianli@chromium.org

7 edits in trunk/WebCore

Unreviewed. Fix build break in GTK.

bindings/scripts/CodeGeneratorGObject.pm:
bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:

11:43 AM Changeset in webkit [61132] by Chris Fleizach

3 edits
2 adds in trunk

AX: AXUnknown objects are being returned
https://bugs.webkit.org/show_bug.cgi?id=40574

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html

accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Added.
platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html: Added.

11:34 AM Changeset in webkit [61131] by jianli@chromium.org

29 edits in trunk/WebCore

Fix code generators to better support Conditional attribute and add test
coverage for it.
https://bugs.webkit.org/show_bug.cgi?id=39512

Reviewed by Darin Adler.

bindings/scripts/CodeGeneratorGObject.pm:
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestInterface.mm:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj conditionalAttr1]):
(-[DOMTestObj setConditionalAttr1:]):
(-[DOMTestObj conditionalAttr2]):
(-[DOMTestObj setConditionalAttr2:]):
(-[DOMTestObj conditionalAttr3]):
(-[DOMTestObj setConditionalAttr3:]):

bindings/scripts/test/TestInterface.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestInterface.cpp:
bindings/scripts/test/V8/V8TestInterface.h:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::conditionalAttr1AttrGetter):
(WebCore::TestObjInternal::conditionalAttr1AttrSetter):
(WebCore::TestObjInternal::conditionalAttr2AttrGetter):
(WebCore::TestObjInternal::conditionalAttr2AttrSetter):
(WebCore::TestObjInternal::conditionalAttr3AttrGetter):
(WebCore::TestObjInternal::conditionalAttr3AttrSetter):
(WebCore::):

11:30 AM Changeset in webkit [61130] by Chris Fleizach

3 edits in trunk/LayoutTests

Bug 40576 - AX: need to update iframe-bastardization.html LayoutTest to be more modern
https://bugs.webkit.org/show_bug.cgi?id=40576

10:29 AM Changeset in webkit [61129] by eric@webkit.org

26 edits in trunk

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.x.html
and canvas/philip/tests/2d.shadow.enable.y.html.

https://bugs.webkit.org/show_bug.cgi?id=40434

platform/qt/Skipped:

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowSize from IntSize to FloatSize in GraphicsContext.
Using IntSize loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue.

https://bugs.webkit.org/show_bug.cgi?id=40434

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow):
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextPrivate.h:
platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[win] Make windows compile after API changes.

https://bugs.webkit.org/show_bug.cgi?id=40434

WebKitGraphics.cpp: (WebDrawText):

10:06 AM Changeset in webkit [61128] by mitz@apple.com

58 edits
4 adds in trunk

<rdar://problem/7752961> Unevenly distributed space in justified text
https://bugs.webkit.org/show_bug.cgi?id=36105

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justify-padding-distribution.html

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_padPerSpace to the quotient of the total
padding and the number of spaces rather than truncating it.
(WebCore::WidthIterator::advance): Subtract m_padPerSpace from m_padding and add the difference
between its old and new values, when rounded, to the advance.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

platform/graphics/win/UniscribeController.h:

LayoutTests:

fast/text/justify-padding-distribution-expected.checksum: Added.
fast/text/justify-padding-distribution-expected.png: Added.
fast/text/justify-padding-distribution-expected.txt: Added.
fast/text/justify-padding-distribution.html: Added.
platform/mac/css1/box_properties/clear_float-expected.checksum:
platform/mac/css1/box_properties/clear_float-expected.png:
platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
platform/mac/css1/box_properties/float_elements_in_series-expected.png:
platform/mac/css1/box_properties/float_on_text_elements-expected.checksum:
platform/mac/css1/box_properties/float_on_text_elements-expected.png:
platform/mac/css1/text_properties/text_align-expected.checksum:
platform/mac/css1/text_properties/text_align-expected.png:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
platform/mac/fast/multicol/float-avoidance-expected.checksum:
platform/mac/fast/multicol/float-avoidance-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
platform/mac/fast/text/atsui-spacing-features-expected.checksum:
platform/mac/fast/text/atsui-spacing-features-expected.png:
platform/mac/fast/text/justified-selection-at-edge-expected.checksum:
platform/mac/fast/text/justified-selection-at-edge-expected.png:
platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:

9:38 AM Changeset in webkit [61127] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Stack overflow when converting navigator object to QVariant
https://bugs.webkit.org/show_bug.cgi?id=40572

Protect against infinite recursion in JSValue->QVariant conversion.
This fixes a crash when trying to convert MimeType objects (they
recurse infinitely and on-the-fly via the enabledPlugin property.)

bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

9:27 AM Changeset in webkit [61126] by eric@webkit.org

4 edits
2 adds in trunk/WebCore

2010-06-14 Yong Li <yoli@rim.com>

Test cases created by: Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38910

Suspend Document::m_executeScriptSoonTimer objects when the page is deferred.
There's no reason why we suspend all active DOM timers on the page but not suspend
this one. Document::m_executeScriptSoonTimer can run JS and schedule more DOM Timers.

It can only be tested manually.

manual-tests/load-deferrer-script-element.html: Added.
manual-tests/resources/load-deferrer-script-element.js: Added.

dom/Document.cpp: (WebCore::Document::executeScriptSoon): (WebCore::Document::suspendExecuteScriptSoonTimer): Added. (WebCore::Document::resumeExecuteScriptSoonTimer): Added.
dom/Document.h:
page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

8:23 AM Changeset in webkit [61125] by bulach@chromium.org

2 edits in trunk/LayoutTests

2010-06-14 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt.
https://bugs.webkit.org/show_bug.cgi?id=40568

https://bugs.webkit.org/show_bug.cgi?id=39994 changed the test expectations, and we need to rebaseline.

platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt:

8:13 AM Changeset in webkit [61124] by loislo@chromium.org

2 edits in trunk/WebKit/gtk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):

8:07 AM Changeset in webkit [61123] by Laszlo Gombos

2 edits in trunk/WebKit/qt

2010-06-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

symbian/eabi/QtWebKitu.def:

7:31 AM Changeset in webkit [61122] by mitz@apple.com

2 edits in trunk

Fixed a typo and reviewr information in ChangeLog files

7:09 AM Changeset in webkit [61121] by yael.aharon@nokia.com

13 edits
2 adds in trunk

[Qt] Platform plugin support for Notifications UI
https://bugs.webkit.org/show_bug.cgi?id=40005

Reviewed by Kenneth Rohde Christiansen.

WebCore:

To avoid race condition when GC is run during shutdown,
disconnect the Notification from the NotificationPresenter
when the presenter deletes itself.
This cannot be tested by a layout test, the race condition happens only
when GC is run during shutdown. It can be tested manually by loading
manually any notification test and closing the browser.

notifications/Notification.cpp:

(WebCore::Notification::~Notification):

notifications/Notification.h:

(WebCore::Notification::detachPresenter):

WebKit/qt:

Add an interface to the platform plugin to display notifications.
Implemented the notification in the example platform plugin.
This interface is enabled by default, but could be turned off with
a build flag. The platform plugin should control its own lifecycle,
so now the close timer applies only when using the QSystemTrayIcon.
That's because QSystemTrayIcon does not inform its caller when it
is closed.

Changed the way NotificationPresenterClientQt is deleted because it
is being accessed when GC is deleting the Notification objects.
NotificationPresenterClientQt is now detaching itself from the
Notifications before it is deleted.

Api/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
(WebCore::NotificationIconWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::detachNotification):

WebCoreSupport/NotificationPresenterClientQt.h:
WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createNotificationPresenter):

WebCoreSupport/QtPlatformPlugin.h:
examples/platformplugin/WebNotificationPresenter.cpp: Added.

(WebNotificationWidget::WebNotificationWidget):
(WebNotificationWidget::~WebNotificationWidget):
(WebNotificationWidget::showNotification):
(WebNotificationWidget::event):

examples/platformplugin/WebNotificationPresenter.h: Added.

(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
(WebNotificationPresenter::showNotification):

examples/platformplugin/WebPlugin.cpp:

(WebPlugin::supportsExtension):

examples/platformplugin/WebPlugin.h:

(WebPlugin::createNotificationPresenter):

examples/platformplugin/platformplugin.pro:
examples/platformplugin/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

6:42 AM Changeset in webkit [61120] by bulach@chromium.org

17 edits
3 copies
3 adds in trunk

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

storage/indexeddb/idb-keyrange-expected.txt: Added.
storage/indexeddb/idb-keyrange.html: Added.
storage/indexeddb/script-tests/idb-keyrange.js: Added. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

Test: storage/indexeddb/idb-keyrange.html

Android.derived.jscbindings.mk:
Android.derived.v8bindings.mk:
Android.mk:
CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
storage/IDBKeyRange.cpp: Added. (WebCore::IDBKeyRange::IDBKeyRange):
storage/IDBKeyRange.h: Added. (WebCore::IDBKeyRange::): (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::~IDBKeyRange): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right): (WebCore::IDBKeyRange::flags):
storage/IDBKeyRange.idl: Added.
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
storage/IndexedDatabaseRequest.h:
storage/IndexedDatabaseRequest.idl:

6:28 AM Changeset in webkit [61119] by jorlow@chromium.org

2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

And another.

storage/IndexedDatabaseRequest.h:

6:21 AM Changeset in webkit [61118] by jorlow@chromium.org

4 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

More build fixes.

storage/IndexedDatabaseRequest.h:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Build fix.

src/IDBCallbacksProxy.h:

6:05 AM Changeset in webkit [61117] by Csaba Osztrogonác

17 edits
2 adds in trunk

[Qt] navigator.geolocation support for Qt port
https://bugs.webkit.org/show_bug.cgi?id=39724

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
Reviewed by Laszlo Gombos.

WebCore:

Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.

WebCore.pri:
WebCore.pro:
platform/qt/GeolocationServiceQt.cpp: Added.

(WebCore::GeolocationServiceQt::create):
(WebCore::GeolocationServiceQt::GeolocationServiceQt):
(WebCore::GeolocationServiceQt::~GeolocationServiceQt):
(WebCore::GeolocationServiceQt::positionUpdated):
(WebCore::GeolocationServiceQt::startUpdating):
(WebCore::GeolocationServiceQt::stopUpdating):

platform/qt/GeolocationServiceQt.h: Added.

(WebCore::GeolocationServiceQt::lastPosition):
(WebCore::GeolocationServiceQt::lastError):

WebKit/qt:

Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
Layout and unit test cases for the are also added.

Api/qwebpage.cpp:

(QWebPage::allowGeolocationRequest):

Api/qwebpage.h:
WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):

WebCoreSupport/DumpRenderTreeSupportQt.h:
tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage::allowGeolocationRequest):
(JSTestPage::setGeolocationPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

Implementation for geolocation cases to DumpRenderTreeQt

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::allowGeolocationRequest):

DumpRenderTree/qt/DumpRenderTreeQt.h:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):

DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):

LayoutTests:

Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html

platform/qt/Skipped:

5:57 AM Changeset in webkit [61116] by jorlow@chromium.org

3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

2 more build fixes.

storage/IDBDatabaseImpl.h:
storage/IndexedDatabaseRequest.h:

5:48 AM Changeset in webkit [61115] by jorlow@chromium.org

2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for my last.

workers/WorkerScriptLoaderClient.h:

5:35 AM Changeset in webkit [61114] by jorlow@chromium.org

3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
bindings/v8/SerializedScriptValue.h:

5:32 AM Changeset in webkit [61113] by loislo@chromium.org

37 edits in trunk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134

inspector/InspectorClient.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend):
inspector/InspectorFrontend.h:
inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::frontendLoaded):
inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
inspector/front-end/inspector.js: (WebInspector.dispatchMessageToFrontend):
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::sendMessageToFrontend):

5:09 AM Changeset in webkit [61112] by eric@webkit.org

13 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

Existing test now fixed.

storage/indexeddb/idb-database-request-expected.txt:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

On the 26th, Beth commented out the description attribute in
IDBDatabaseRequest because it was causing problems with the
objective c bindings. Turns out that this is the same bug as
in http://trac.webkit.org/changeset/19486. (Thanks for the
pointer, Mark!)

The solution is to change the objective C bindings generator
to change the name in the generated code. id and hash both
just appended "Name" to them in the past. I couldn't think
of anything else particularly better to append, so I just
went with name as well.

Test: building the world works on the first try. Layout

test verifies description works again.

bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjDescription): (WebCore::jsTestObjId): (WebCore::jsTestObjHash): (WebCore::setJSTestObjId):
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj descriptionName]): (-[DOMTestObj idName]): (-[DOMTestObj setIdName:]): (-[DOMTestObj hashName]):
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::descriptionAttrGetter): (WebCore::TestObjInternal::idAttrGetter): (WebCore::TestObjInternal::idAttrSetter): (WebCore::TestObjInternal::hashAttrGetter): (WebCore::):
storage/IDBDatabaseRequest.idl:

12:55 AM Changeset in webkit [61111] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r61100.

platform/qt/fast/dom/Window/window-properties-expected.txt: updated.

Jun 13, 2010:

11:32 PM Changeset in webkit [61110] by eric@webkit.org

3 edits
3 adds in trunk

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Test case to verify that MIME type in uppercase (TEXT/HTML) is supported.
https://bugs.webkit.org/show_bug.cgi?id=39492

http/tests/mime/resources/uppercase-mime-type.php: Added.
http/tests/mime/uppercase-mime-type-expected.txt: Added.
http/tests/mime/uppercase-mime-type.html: Added.

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix the QtWebKit which doesn't recognize the MIME type of HTML/TEXT in uppercase
https://bugs.webkit.org/show_bug.cgi?id=39492

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType):

11:20 PM Changeset in webkit [61109] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScreenQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39766

platform/qt/ScreenQt.cpp:

10:58 PM Changeset in webkit [61108] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-13 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Darin Adler.

Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
be a way of overwriting the Xcode system path. Making
$WEBKITOUTPUTDIR take precedence over the system default would make
this possible.

Scripts/webkitdirs.pm:

10:19 PM Changeset in webkit [61107] by eric@webkit.org

23 edits
2 moves in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename HTMLParser to LegacyHTMLTreeConstructor
https://bugs.webkit.org/show_bug.cgi?id=40554

This makes our old HTML parsing system closer match the
HTML5 spec, and thus easier to compare to the new HTML5
parsing system.

This rename was entirely automatic. Done by do-webcore-rename.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:
dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.h:
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLInputElement.cpp:
html/HTMLMeterElement.cpp:
html/HTMLProgressElement.cpp:
html/LegacyHTMLTreeConstructor.cpp: Renamed from WebCore/html/HTMLParser.cpp. (WebCore::addTags): (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::LegacyHTMLTreeConstructor::LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::~LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::reset): (WebCore::LegacyHTMLTreeConstructor::setCurrent): (WebCore::tagPriorityOfNode): (WebCore::LegacyHTMLTreeConstructor::limitDepth): (WebCore::LegacyHTMLTreeConstructor::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeConstructor::parseToken): (WebCore::LegacyHTMLTreeConstructor::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::isScopingTag): (WebCore::LegacyHTMLTreeConstructor::insertNode): (WebCore::LegacyHTMLTreeConstructor::handleError): (WebCore::LegacyHTMLTreeConstructor::textCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::headCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::formCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::mapCreateErrorCheck): (WebCore::mapTagToFunc): (WebCore::mapTagsToFunc): (WebCore::LegacyHTMLTreeConstructor::getNode): (WebCore::LegacyHTMLTreeConstructor::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeConstructor::processCloseTag): (WebCore::LegacyHTMLTreeConstructor::isHeadingTag): (WebCore::LegacyHTMLTreeConstructor::isInline): (WebCore::LegacyHTMLTreeConstructor::isResidualStyleTag): (WebCore::LegacyHTMLTreeConstructor::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeConstructor::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeConstructor::pushBlock): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::popOneBlockCommon): (WebCore::LegacyHTMLTreeConstructor::popOneBlock): (WebCore::LegacyHTMLTreeConstructor::moveOneBlockToStack): (WebCore::LegacyHTMLTreeConstructor::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::popInlineBlocks): (WebCore::LegacyHTMLTreeConstructor::freeBlock): (WebCore::LegacyHTMLTreeConstructor::createHead): (WebCore::LegacyHTMLTreeConstructor::handleIsindex): (WebCore::LegacyHTMLTreeConstructor::startBody): (WebCore::LegacyHTMLTreeConstructor::finished): (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole): (WebCore::shouldCreateImplicitHead): (WebCore::serializeForNumberType): (WebCore::parseToDoubleForNumberType):
html/LegacyHTMLTreeConstructor.h: Renamed from WebCore/html/HTMLParser.h. (WebCore::LegacyHTMLTreeConstructor::skipMode): (WebCore::LegacyHTMLTreeConstructor::isHandlingResidualStyleAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::setSkipMode): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::hasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::reportError): (WebCore::LegacyHTMLTreeConstructor::): (WebCore::shouldCreateImplicitHead):
html/StepRange.cpp:
html/ValidityState.cpp:
rendering/RenderSlider.cpp:

9:48 PM Changeset in webkit [61106] by abarth@webkit.org

9 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename m_parser, htmlParser() to m_treeConstructor, htmlTreeConstructor() in preparation for renaming HTMLParser
https://bugs.webkit.org/show_bug.cgi?id=40514

This rename was done by hand. I realize now I should have
renamed HTMLParser to HTMLTreeConstructor before renaming HTMLTokenizer.

No functional changes, thus no tests.

dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::htmlTreeConstructor): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets):
html/HTML5DocumentParser.h:
html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::finished):
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):

9:44 PM Changeset in webkit [61105] by abarth@webkit.org

6 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40513

Last set of Tokenizer related renames, also done via do-webcore-rename:
asHTMLTokenizer => asHTMLDocumentParser
tok => parser

No functional changes, thus no tests.

dom/Document.cpp: (WebCore::Document::write):
dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
html/HTMLDocumentParser.cpp: (WebCore::parseHTMLDocumentFragment):
html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::asHTMLDocumentParser):
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):

9:40 PM Changeset in webkit [61104] by abarth@webkit.org

37 edits in trunk/WebCore

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Fix the rest of the references to the old Tokenizer class (now DocumentParser)
https://bugs.webkit.org/show_bug.cgi?id=40512

No functional changes, thus no new tests.
This was mostly done by do-webcore-rename:
tokenizer => parser
m_tokenizer => m_parser
createTextTokenizer => createTextDocumentParser
createTokenizer => createParser
getTokenizer => getParser

However had to be careful to avoid renaming things related to
css/tokenizer.flex (which we should later rename to CSSTokenizer.flex)

Still a couple references with "tok" and "asHTMLTokenizer" which I'll
get in the next patch.

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isLoaded):
bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::createParser): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::write): (WebCore::Document::finishParsing): (WebCore::Document::removePendingSheet):
dom/Document.h: (WebCore::Document::parser):
dom/DocumentParser.h:
dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::getParser): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::parseXMLDocumentFragment):
dom/XMLDocumentParserQt.cpp: (WebCore::parseXMLDocumentFragment):
html/HTML5EntityParser.cpp:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
html/HTMLDocument.h:
html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLParser.cpp: (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addLine):
html/HTMLViewSourceDocument.h:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData):
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createParser):
loader/FTPDirectoryDocument.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createParser):
loader/ImageDocument.h:
loader/MediaDocument.cpp: (WebCore::MediaDocument::createParser):
loader/MediaDocument.h:
loader/PluginDocument.cpp: (WebCore::PluginDocument::createParser):
loader/PluginDocument.h:
loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
loader/SinkDocument.h:
loader/TextDocument.cpp: (WebCore::TextDocument::createParser): (WebCore::createTextDocumentParser):
loader/TextDocument.h:
svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::registerTemplatesInDocument):

9:00 PM Changeset in webkit [61103] by Chris Fleizach

9 edits
2 adds in trunk

AX: link won't return linked element if URL contains #
https://bugs.webkit.org/show_bug.cgi?id=40192

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/accessibility/internal-link-when-document-has-fragment.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

WebKitTools:

Reviewed by Darin Adler.

DumpRenderTree/AccessibilityUIElement.cpp:

(linkedUIElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::linkedUIElementAtIndex):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

LayoutTests:

Reviewed by Darin Alder.

platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt: Added.
platform/mac/accessibility/internal-link-when-document-has-fragment.html: Added.

8:37 PM Changeset in webkit [61102] by Simon Fraser

3 edits in trunk/LayoutTests

2010-06-13 Simon Fraser <Simon Fraser>

Fix GTK bots; don't include the offsetWidth in the results
since it can differ between platforms.

transitions/font-family-during-transition-expected.txt:
transitions/font-family-during-transition.html:

7:42 PM Changeset in webkit [61101] by weinig@apple.com

3 edits in trunk/WebCore

Try and fix the chrome build.

bindings/scripts/CodeGeneratorV8.pm:
xml/XMLHttpRequest.idl:

7:27 PM Changeset in webkit [61100] by weinig@apple.com

16 edits
3 adds
2 deletes in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

Test: fast/dom/XMLHttpRequest-constants.html

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSWorkerContextCustom.cpp:
bindings/js/JSXMLHttpRequestConstructor.cpp: Removed.
bindings/js/JSXMLHttpRequestConstructor.h: Removed.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):

bindings/scripts/CodeGeneratorJS.pm:
xml/XMLHttpRequest.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

fast/dom/Window/window-properties-expected.txt:
fast/dom/XMLHttpRequest-constants-expected.txt: Added.
fast/dom/XMLHttpRequest-constants.html: Added.
fast/dom/script-tests/XMLHttpRequest-constants.js: Added.

6:47 PM Changeset in webkit [61099] by Simon Fraser

4 edits
2 adds in trunk

2010-06-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

-webkit-transition font-size and font-family
https://bugs.webkit.org/show_bug.cgi?id=33429

When animating font-size, update the font with a saved
version of the font selector to ensure that we don't clobber
the font family.

Test: transitions/font-family-during-transition.html

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setBlendedFontSize):

6:37 PM Changeset in webkit [61098] by eric@webkit.org

6 edits
1 add in trunk/WebKitTools

2010-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
https://bugs.webkit.org/show_bug.cgi?id=39550

This can cause an extra request to bugs.webkit.org durig upload, but it
shouldn't be too bad. Also, this won't work if you remove the
boilerplate created by prepare-ChangeLog.

Scripts/webkitpy/common/checkout/changelog.py:
Scripts/webkitpy/common/checkout/changelog_unittest.py:
Scripts/webkitpy/common/net/bugzilla.py:
Scripts/webkitpy/tool/steps/abstractstep.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.

5:58 PM Changeset in webkit [61097] by tony@chromium.org

5 edits in trunk

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

bindings/v8/custom/V8NamedNodesCollection.cpp: (WebCore::V8NamedNodesCollection::itemWithName):

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

src/ChromeClientImpl.cpp:
src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::nameForAutofill):

12:01 PM Changeset in webkit [61096] by Darin Adler

5 edits in trunk/LayoutTests

Updated Windows-platform results for the fix for bug 40394.
The patch fixed the cross-platform results, GTK results, and Qt results,
but there were Windows results too.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

10:50 AM Changeset in webkit [61095] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Reviewed by Alexey Proskuryakov.

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeList::itemWithName):

dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

rendering/RenderSVGResourceContainer.h:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::handleDeepUseReferencing):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):
Use the new idForStyleResolution function, which is the new name of
the getIDAttribute function. There's a good chance these call sites are
incorrect, which is something we should investigate later, so there's
a FIXME at each call site.

dom/Document.cpp:

(WebCore::Document::Document): Initialize m_idAttributeName to the
standard id attribute from HTML.
(WebCore::Document::getElementById): Use Element::getIdAttribute.

dom/Document.h: Added Document::idAttributeName.

dom/Element.cpp:

(WebCore::Element::setAttribute): Use Document::idAttributeName.
(WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
(WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::formatForDebugger): Use Element::getIdAttribute.

dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,

idForStyleResolution. Removed rareIDAttributeName.

dom/ElementRareData.h: Removed m_idAttributeName.

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.

dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,

setIdForStyleResolution, and m_idForStyleResolution since this is not the
value of the id attribute because it gets lowercased for compatibility-mode
documents.

rendering/RenderIFrame.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderProgress.cpp:

Added include of HTMLNames.h now that Element.h no longer includes it.

editing/SetNodeAttributeCommand.h:
editing/markup.cpp:
html/HTMLParser.cpp:

Removed unneeded includes.

html/HTMLParser.h: Sorted includes.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.

dom/Attr.cpp:

(WebCore::Attr::isId): Use Document::idAttributeName.

dom/StyledElement.cpp:

(WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
and setIdForStyleResolution.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.

editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
(WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.

html/HTMLDataGridColElement.cpp:

(WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
(WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
(WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
Also restructured the function a bit to make its structure clearer and added
a comment pointing out that it can't be quite right.

html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.

html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.

loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Use getIdAttribute.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.

rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGPaintingResource): Use getIdAttribute.
(WebCore::writeSVGResourceContainer): Ditto.

svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
(WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.

wml/WMLElement.cpp:

(WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:29 AM Changeset in webkit [61094] by Darin Adler

45 edits in trunk/WebCore

2010-06-12 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
dom/StaticNodeList.cpp: (WebCore::StaticNodeList::itemWithName):
rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::handleDeepUseReferencing):
svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations): Use the new idForStyleResolution function, which is the new name of the getIDAttribute function. There's a good chance these call sites are incorrect, which is something we should investigate later, so there's a FIXME at each call site.

dom/Document.cpp: (WebCore::Document::Document): Initialize m_idAttributeName to the standard id attribute from HTML. (WebCore::Document::getElementById): Use Element::getIdAttribute.
dom/Document.h: Added Document::idAttributeName.

dom/Element.cpp: (WebCore::Element::setAttribute): Use Document::idAttributeName. (WebCore::Element::setAttributeMap): Use Element::isIdAttributeName. (WebCore::Element::insertedIntoDocument): Use Document::idAttributeName. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute, idForStyleResolution. Removed rareIDAttributeName.

dom/ElementRareData.h: Removed m_idAttributeName.

dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution, setIdForStyleResolution, and m_idForStyleResolution since this is not the value of the id attribute because it gets lowercased for compatibility-mode documents.

rendering/RenderIFrame.cpp:
rendering/RenderLayerCompositor.cpp:
rendering/RenderProgress.cpp: Added include of HTMLNames.h now that Element.h no longer includes it.

editing/SetNodeAttributeCommand.h:
editing/markup.cpp:
html/HTMLParser.cpp: Removed unneeded includes.

html/HTMLParser.h: Sorted includes.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
dom/Attr.cpp: (WebCore::Attr::isId): Use Document::idAttributeName.
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName, and setIdForStyleResolution.
editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): Ditto.
html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute. (WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute. (WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::nextNamedItem): Added missing braces. (WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName. Also restructured the function a bit to make its structure clearer and added a comment pointing out that it can't be quite right.
html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingResource): Use getIdAttribute. (WebCore::writeSVGResourceContainer): Ditto.
svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName. (WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:22 AM Changeset in webkit [61093] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated results after r61092.

fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:

9:40 AM Changeset in webkit [61092] by mitz@apple.com

2 edits in trunk/WebCore

<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast in list boxes and in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=40537

Reviewed by Darin Adler.

platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Only multiply by pixelsPerLineStep() if the
event is not continuous, as was before r56012.

6:54 AM Changeset in webkit [61091] by abecsi@webkit.org

18 edits
1 add
1 delete in trunk

Centralize the gperf code generation commands into make-hash-tools.pl
to avoid redundancy across multiple build systems.
Do this in preparation of refactoring the usage of these generated
sources to fix the debug linking error on Linux with gcc >= 4.4.0.

WebCore:

Reviewed by Darin Adler.

webkit.org/b/29244

No functionality change, so no new tests needed.

DerivedSources.make:
GNUmakefile.am:
WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/rule_gperf.py: Removed.
WebCore.pri:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):

css/makeprop.pl:
css/makevalues.pl:
html/DocTypeStrings.gperf:
html/HTML5EntityParser.cpp:
html/HTMLDocumentParser.cpp:
html/HTMLEntityNames.gperf:
html/PreloadScanner.cpp:
make-hash-tools.pl: Added.
platform/ColorData.gperf:
platform/graphics/Color.cpp:

WebKit/chromium:

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-06-13
Reviewed by Darin Adler.

webkit.org/b/29244

src/WebEntities.cpp:

6:29 AM Changeset in webkit [61090] by robert@webkit.org

8 edits in trunk

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

platform/qt/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shouldClose):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews):

6:05 AM Changeset in webkit [61089] by eric@webkit.org

4 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tests/hybridPixmap fails
https://bugs.webkit.org/show_bug.cgi?id=37316

The problem was that JSC::Instance::createRuntimeObject was never called.
This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
in between, instead of creating the runtime object directly inside the static function
QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.

This fixes an existing test, tests/hybridPixmap

bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::newRuntimeObject): (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
bridge/qt/qt_pixmapruntime.h:
bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):

2:11 AM Changeset in webkit [61088] by adachan@apple.com

3 edits in trunk/WebKit2

Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for Windows release build.

WebProcess/win/WebLocalizableStrings.cpp: (findCachedString):

1:33 AM Changeset in webkit [61087] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

GraphicsContext3D.h in the Qt port includes too many unnecessary files
https://bugs.webkit.org/show_bug.cgi?id=40536

Removed unncessary includes.

No new tests; Compilation improvement.

platform/graphics/GraphicsContext3D.h:
platform/graphics/qt/GraphicsContext3DQt.cpp:

1:20 AM Changeset in webkit [61086] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Eric Seidel.

[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
https://bugs.webkit.org/show_bug.cgi?id=40535

Made sure the painter ends its operation before copying the pixmap.

No new tests: this is an optimization.

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache):

12:54 AM Changeset in webkit [61085] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-13 Clemmitt Sigler <cmsigler@gmail.com>

Reviewed by Eric Seidel.

Patch to fix missing references to RenderMathMLRoot,
RenderMathMLSquareRoot when building GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=40326

No change in functionality so no new tests.

GNUmakefile.am:

Jun 12, 2010:

10:50 PM Changeset in webkit [61084] by dimich@chromium.org

2 edits in trunk/LayoutTests

Not reviewed, update Chromium expected result following r61071.

platform/chromium/fast/dom/prototype-inheritance-expected.txt:

10:49 PM Changeset in webkit [61083] by adachan@apple.com

2 edits
1 add in trunk/WebCore

2010-06-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=40538

Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106: invalid
file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.

WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.

10:39 PM Changeset in webkit [61082] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61031.
http://trac.webkit.org/changeset/61031
https://bugs.webkit.org/show_bug.cgi?id=40539

Crashes Dromaeo jslib test in Release Chromium (Requested by
dimich_ on #webkit).

bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
bindings/v8/V8Binding.h:

10:36 PM Changeset in webkit [61081] by eric@webkit.org

8 edits in trunk/WebCore

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40508

This was a very simple do-webcore-rename-generated patch.

PluginTokenizer => PluginDocumentParser
TextTokenizer => TextDocumentParser
SinkTokenizer => SinkDocumentParser
MediaTokenizer => MediaDocumentParser
FTPDirectoryTokenizer => FTPDirectoryDocumentParser

No functional changes, thus no tests.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
html/HTMLViewSourceDocument.h:
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::write): (WebCore::FTPDirectoryDocumentParser::finish): (WebCore::FTPDirectoryDocument::createTokenizer):
loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::write): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::writeRawData): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::isWaitingForScripts): (WebCore::MediaDocument::createTokenizer):
loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::pluginWidgetFromDocument): (WebCore::PluginDocumentParser::write): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::isWaitingForScripts): (WebCore::PluginDocument::createTokenizer): (WebCore::PluginDocument::pluginWidget):
loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser): (WebCore::SinkDocumentParser::finish): (WebCore::SinkDocument::createTokenizer):
loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::~TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::isWaitingForScripts): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):

10:19 PM Changeset in webkit [61080] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

do-webcore-rename should have a --verbose option
https://bugs.webkit.org/show_bug.cgi?id=40497

Scripts/do-webcore-rename:
- Unified how we handle skipping files/directories this will allow us to "black list" certain files and directories when performing renames.
- Made do-webcore-rename log what it's skipping when passed --verbose.

9:52 PM Changeset in webkit [61079] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/run-bindings-tests: Fixed a typo in a message.

9:46 PM Changeset in webkit [61078] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-12 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventHandlerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40259

Coding style change only.

page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::eventActivatedView):

9:29 PM Changeset in webkit [61077] by eric@webkit.org

8 edits
1 delete in trunk/WebCore

2010-06-12 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Unify fileSystemRepresentation and filenameFromString
https://bugs.webkit.org/show_bug.cgi?id=40201

Remove filenameFromString and use fileSystemRepresentation instead
as they do the same job.

platform/FileSystem.cpp: Removed.
platform/FileSystem.h:
platform/efl/FileSystemEfl.cpp: (WebCore::fileSystemRepresentation):
platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
platform/gtk/FileSystemGtk.cpp: (WebCore::fileSystemRepresentation): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):

9:15 PM Changeset in webkit [61076] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-12 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

[Haiku] Cleanup SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=39003

platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):

9:04 PM Changeset in webkit [61075] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-12 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] WheelEventQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39760

platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

8:41 PM Changeset in webkit [61074] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-12 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't include POSIX headers in WebCorePrefix.h
https://bugs.webkit.org/show_bug.cgi?id=39411

When building for BREW MP, don't include POSIX headers:
<fcntl.h>, <pthread.h> and <sys/types.h>.

WebCorePrefix.h:

7:16 PM Changeset in webkit [61073] by eric@webkit.org

40 edits
10 moves in trunk

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

wtf/Platform.h:
- fixed a comment to match new names.

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

This search/replace was done by do-webcore-rename.
Just looking for a rubber stamp.

XMLTokenizer => XMLDocumentParser
XMLTokenizerLibxml2 => XMLDocumentParserLibxml2
XMLTokenizerQt => XMLDocumentParserQt
XMLTokenizerScope => XMLDocumentParserScope
HTML5Tokenizer => HTML5DocumentParser
HTMLTokenizer => HTMLDocumentParser

No functional change, thus no tests.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
dom/Document.cpp: (WebCore::Document::createTokenizer): (WebCore::Document::write):
dom/Document.h: (WebCore::Document::setXMLEncoding):
dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLTokenizer):
dom/Element.cpp:
dom/ProcessingInstruction.cpp:
dom/XMLDocumentParser.cpp: Added. (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::write): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing):
dom/XMLDocumentParser.h: Added. (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
dom/XMLDocumentParserLibxml2.cpp: Added. (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getTokenizer): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
dom/XMLDocumentParserQt.cpp: Added. (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
dom/XMLDocumentParserScope.cpp: Added. (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
dom/XMLDocumentParserScope.h: Added.
dom/XMLTokenizer.cpp: Removed.
dom/XMLTokenizer.h: Removed.
dom/XMLTokenizerLibxml2.cpp: Removed.
dom/XMLTokenizerQt.cpp: Removed.
dom/XMLTokenizerScope.cpp: Removed.
dom/XMLTokenizerScope.h: Removed.
html/HTML5DocumentParser.cpp: Added. (WebCore::): (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::~HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::write): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed): (WebCore::HTML5DocumentParser::finish): (WebCore::HTML5DocumentParser::executingScript): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber): (WebCore::HTML5DocumentParser::htmlParser): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::stopWatchingForLoad): (WebCore::HTML5DocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTML5DocumentParser::executeScript): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTML5DocumentParser::script):
html/HTML5DocumentParser.h: Added. (WebCore::HTML5DocumentParser::InputStream::InputStream): (WebCore::HTML5DocumentParser::InputStream::appendToEnd): (WebCore::HTML5DocumentParser::InputStream::insertAtCurrentInsertionPoint): (WebCore::HTML5DocumentParser::InputStream::close): (WebCore::HTML5DocumentParser::InputStream::current): (WebCore::HTML5DocumentParser::InputStream::splitInto): (WebCore::HTML5DocumentParser::InputStream::mergeFrom): (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): (WebCore::HTML5DocumentParser::InsertionPointRecord::~InsertionPointRecord): (WebCore::HTML5DocumentParser::inWrite):
html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
html/HTML5Tokenizer.cpp: Removed.
html/HTML5Tokenizer.h: Removed.
html/HTML5TreeBuilder.cpp:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
html/HTMLDocumentParser.cpp: Added. (WebCore::): (WebCore::fixUpChar): (WebCore::tagMatch): (WebCore::Token::addAttribute): (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::reset): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::setForceSynchronous): (WebCore::HTMLDocumentParser::processListing): (WebCore::HTMLDocumentParser::parseNonHTMLText): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::scriptExecution): (WebCore::HTMLDocumentParser::parseComment): (WebCore::HTMLDocumentParser::parseServer): (WebCore::HTMLDocumentParser::parseProcessingInstruction): (WebCore::HTMLDocumentParser::parseText): (WebCore::HTMLDocumentParser::parseEntity): (WebCore::HTMLDocumentParser::parseDoctype): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::continueProcessing): (WebCore::HTMLDocumentParser::advance): (WebCore::HTMLDocumentParser::willWriteHTML): (WebCore::HTMLDocumentParser::didWriteHTML): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::timerFired): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::enlargeBuffer): (WebCore::HTMLDocumentParser::enlargeScriptBuffer): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::HTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::HTMLDocumentParser::continueExecutingExternalScripts): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::setSrc): (WebCore::parseHTMLDocumentFragment): (WebCore::decodeNamedEntity):
html/HTMLDocumentParser.h: Added. (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::isOpenTag): (WebCore::Token::isCloseTag): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar): (WebCore::): (WebCore::DoctypeToken::DoctypeToken): (WebCore::DoctypeToken::reset): (WebCore::DoctypeToken::state): (WebCore::DoctypeToken::setState): (WebCore::HTMLDocumentParser::forceSynchronous): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::processingContentWrittenByScript): (WebCore::HTMLDocumentParser::htmlParser): (WebCore::HTMLDocumentParser::asHTMLTokenizer): (WebCore::HTMLDocumentParser::checkBuffer): (WebCore::HTMLDocumentParser::checkScriptBuffer): (WebCore::HTMLDocumentParser::): (WebCore::HTMLDocumentParser::State::State): (WebCore::HTMLDocumentParser::State::tagState): (WebCore::HTMLDocumentParser::State::setTagState): (WebCore::HTMLDocumentParser::State::entityState): (WebCore::HTMLDocumentParser::State::setEntityState): (WebCore::HTMLDocumentParser::State::inScript): (WebCore::HTMLDocumentParser::State::setInScript): (WebCore::HTMLDocumentParser::State::inStyle): (WebCore::HTMLDocumentParser::State::setInStyle): (WebCore::HTMLDocumentParser::State::inXmp): (WebCore::HTMLDocumentParser::State::setInXmp): (WebCore::HTMLDocumentParser::State::inTitle): (WebCore::HTMLDocumentParser::State::setInTitle): (WebCore::HTMLDocumentParser::State::inIFrame): (WebCore::HTMLDocumentParser::State::setInIFrame): (WebCore::HTMLDocumentParser::State::inPlainText): (WebCore::HTMLDocumentParser::State::setInPlainText): (WebCore::HTMLDocumentParser::State::inProcessingInstruction): (WebCore::HTMLDocumentParser::State::setInProcessingInstruction): (WebCore::HTMLDocumentParser::State::inComment): (WebCore::HTMLDocumentParser::State::setInComment): (WebCore::HTMLDocumentParser::State::inDoctype): (WebCore::HTMLDocumentParser::State::setInDoctype): (WebCore::HTMLDocumentParser::State::inTextArea): (WebCore::HTMLDocumentParser::State::setInTextArea): (WebCore::HTMLDocumentParser::State::escaped): (WebCore::HTMLDocumentParser::State::setEscaped): (WebCore::HTMLDocumentParser::State::inServer): (WebCore::HTMLDocumentParser::State::setInServer): (WebCore::HTMLDocumentParser::State::skipLF): (WebCore::HTMLDocumentParser::State::setSkipLF): (WebCore::HTMLDocumentParser::State::startTag): (WebCore::HTMLDocumentParser::State::setStartTag): (WebCore::HTMLDocumentParser::State::discardLF): (WebCore::HTMLDocumentParser::State::setDiscardLF): (WebCore::HTMLDocumentParser::State::allowYield): (WebCore::HTMLDocumentParser::State::setAllowYield): (WebCore::HTMLDocumentParser::State::loadingExtScript): (WebCore::HTMLDocumentParser::State::setLoadingExtScript): (WebCore::HTMLDocumentParser::State::forceSynchronous): (WebCore::HTMLDocumentParser::State::setForceSynchronous): (WebCore::HTMLDocumentParser::State::inAnyNonHTMLText): (WebCore::HTMLDocumentParser::State::hasTagState): (WebCore::HTMLDocumentParser::State::hasEntityState): (WebCore::HTMLDocumentParser::State::needsSpecialWriteHandling): (WebCore::HTMLDocumentParser::State::): (WebCore::HTMLDocumentParser::State::setBit): (WebCore::HTMLDocumentParser::State::testBit):
html/HTMLElement.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
html/HTMLParser.h:
html/HTMLTokenizer.cpp: Removed.
html/HTMLTokenizer.h: Removed.
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:
loader/DocumentLoader.cpp:
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::finish):
loader/FrameLoader.cpp:
loader/ImageDocument.cpp:
loader/MediaDocument.cpp:
loader/PluginDocument.cpp:
loader/TextDocument.cpp:
page/XSSAuditor.h:
svg/SVGDocumentExtensions.cpp:
wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString):
xml/XSLTProcessor.cpp:
xml/XSLTProcessorLibxslt.cpp:

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

src/WebEntities.cpp:
- Fix a comment to match new class names.

7:09 PM Changeset in webkit [61072] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-12 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Menu key should act on current selection even if it is not editable
https://bugs.webkit.org/show_bug.cgi?id=40348

Allow the menu key to act on non-editable selections.

src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

6:03 PM Changeset in webkit [61071] by eric@webkit.org

23 edits in trunk

2010-06-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
https://bugs.webkit.org/show_bug.cgi?id=40394

Unskipped 2 tests that are now working properly.

canvas/philip/tests/2d.gradient.object.return-expected.txt:
canvas/philip/tests/2d.pattern.basic.type-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/dom/Window/window-property-descriptors-expected.txt:
fast/dom/dom-constructors-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
fast/js/global-constructors-expected.txt:
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:
platform/mac/Skipped:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

2010-06-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
https://bugs.webkit.org/show_bug.cgi?id=40394

This fixes the following tests:

canvas/philip/tests/2d.gradient.object.return.html
canvas/philip/tests/2d.pattern.basic.type.html

html/canvas/CanvasGradient.idl:
html/canvas/CanvasPattern.idl:
page/DOMWindow.idl:

4:35 PM Changeset in webkit [61070] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/8025267> REGRESSION (Safari 4-TOT): Crash when a frame’s resize handler removes the frame
https://bugs.webkit.org/show_bug.cgi?id=40534

Reviewed by Oliver Hunt.

WebCore:

Test: fast/replaced/frame-removed-during-resize.html

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition): Null-check m_widget, since resizing the widget
may trigger an iframe’s resize handler, which may destroy the widget.

LayoutTests:

fast/replaced/frame-removed-during-resize-expected.txt: Added.
fast/replaced/frame-removed-during-resize.html: Added.

3:34 PM Changeset in webkit [61069] by dimich@chromium.org

2 edits in trunk/LayoutTests

Not reviewed, update for Chromium test expectations.

platform/chromium/test_expectations.txt:

3:16 PM Changeset in webkit [61068] by Simon Fraser

5 edits
4 adds in trunk

2010-06-12 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Animation keyframe timing functions are applying incorrectly
https://bugs.webkit.org/show_bug.cgi?id=38963

When copying RenderStyles, we have to clone the AnimationList so that each keyframe
can have its own timing function.

Tests: animations/keyframe-timing-functions-transform.html

animations/keyframe-timing-functions2.html

platform/animation/Animation.h: (WebCore::Animation::create):
platform/animation/AnimationList.cpp: (WebCore::AnimationList::AnimationList):
platform/animation/AnimationList.h: (WebCore::AnimationList::AnimationList):

2:08 PM Changeset in webkit [61067] by bweinstein@apple.com

2 edits
1 delete in branches/safari-533-branch/WebCore

Roll out r61066, it was meant to be made on the trunk, not the branch.

2:00 PM Changeset in webkit [61066] by bweinstein@apple.com

2 edits
1 add in branches/safari-533-branch/WebCore

Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106:
invalid file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.

Rubber-stamped by Darin Adler.

WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.

1:05 PM Changeset in webkit [61065] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/7882140> -webkit-column-break-* properties don’t do anything
https://bugs.webkit.org/show_bug.cgi?id=40531

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/break-properties.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren): Check for -webkit-column-break-{before,after}: always
and -webkit-column-break-inside: avoid when doing column layout.

LayoutTests:

fast/multicol/break-properties-expected.txt: Added.
fast/multicol/break-properties.html: Added.

11:06 AM ApplicationsGtk edited by patternjake@hotmail.com

(diff)

11:05 AM Applications using WebKit edited by patternjake@hotmail.com

(diff)

11:05 AM Changeset in webkit [61064] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-06-12 Dawit Alemayehu <adawit@kde.org>

Reviewed by Kenneth Rohde Christiansen.

Added an attribute to enable/disable site specific quirks mode in WebKit.
The attribute is enabled by default.

https://bugs.webkit.org/show_bug.cgi?id=40073

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

9:45 AM Changeset in webkit [61063] by robert@webkit.org

2 edits in trunk/WebKit/qt

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_qwebframe regression from http://trac.webkit.org/changeset/61062

Only use cacheableBindingRootObject() if the object has QtOwnership.

https://bugs.webkit.org/show_bug.cgi?id=40527

Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):

6:41 AM Changeset in webkit [61062] by robert@webkit.org

7 edits in trunk

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Alexey Proskuryakov.

FrameLoader::clear() clears JS objects that cached pages later rely on

https://bugs.webkit.org/show_bug.cgi?id=37725
https://bugs.webkit.org/show_bug.cgi?id=31626

Fix the following tests for Qt:

fast/events/pageshow-pagehide-on-back-cached.html
fast/events/pageshow-pagehide-on-back-cached-with-frames.html
fast/loader/input-element-page-cache-crash.html
fast/dom/Window/timer-resume-on-navigation-back.html
loader/go-back-to-different-window-size.html
fast/dom/javascript-url-crash-function.html
fast/dom/location-new-window-no-crash.html
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html

which currently fail because the page's Qt-bindings runtime objects are
cleared when navigating away from the page containing them.

Track Qt-bindings objects in a separate ScriptController::cacheableRootBindingObject().
RuntimeObjects tracked by this root object will not get invalidated on page navigations,
so they will still be available when the pages containing them are retrieved from the
b/f cache.

This means the Qt bindings objects will only get cleared on Frame::pageDestroyed().

Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
bindings/js/ScriptController.cpp: (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::cacheableBindingRootObject):
bindings/js/ScriptController.h:
platform/qt/Skipped:

5:44 AM Changeset in webkit [61061] by tkent@chromium.org

4 edits in trunk/WebKitTools

2010-06-12 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
https://bugs.webkit.org/show_bug.cgi?id=40402

_build_path() of each Chromium port check existence of build path
of Chromium checkout first, then check existence of build path of
WebKit-only checkout.

Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:

4:33 AM Changeset in webkit [61060] by tkent@chromium.org

5 edits
2 adds in trunk

REGRESSION: Can't submit a form with <input type=radio required>
https://bugs.webkit.org/show_bug.cgi?id=40429

Reviewed by Darin Adler.

WebCore:

Validity state was not updated correctly for radio buttons, and it
prevents form submission even if a radio button group has a
checked radio button.

Test: fast/forms/interactive-validation-required-radio.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):

Call setNeedsValidityCheck() for all of radio buttons in the same group
to update validity state.

(WebCore::HTMLInputElement::setChecked):

Remove setNeedsValidityCheck() call because it is called in
updateCheckedRadioButtons().

LayoutTests:

fast/forms/ValidityState-valueMissing-radio-expected.txt:
fast/forms/interactive-validation-required-radio-expected.txt: Added.
fast/forms/interactive-validation-required-radio.html: Added.
fast/forms/script-tests/ValidityState-valueMissing-radio.js: We need to test against a radio group with at least three radio buttons because we should test behaviors of
- checked
- unchecked
- neither checked nor unchecked

4:19 AM Changeset in webkit [61059] by tkent@chromium.org

3 edits
4 adds in trunk

Disable interactive form validation in non-strict modes
https://bugs.webkit.org/show_bug.cgi?id=40218

Reviewed by Dimitri Glazkov.

WebCore:

The interactive validation feature of HTML5 is not compatible with
HTML4, and users and page authors don't expect existing sites work
differently in WebKit. For example, maxlength and required attributes
in existing sites unexpectedly prevented form submission.
So, we disable the interactive validation feature in non-strict
modes to improve compatibility.

Test: fast/forms/interactive-validation-compat-mode.html

fast/forms/interactive-validation-html4.html

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Process interactive validation only in the strict mode.

LayoutTests:

fast/forms/interactive-validation-compat-mode-expected.txt: Added.
fast/forms/interactive-validation-compat-mode.html: Added.
fast/forms/interactive-validation-html4-expected.txt: Added.
fast/forms/interactive-validation-html4.html: Added.

1:21 AM Changeset in webkit [61058] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-06-12 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
https://bugs.webkit.org/show_bug.cgi?id=35861

The previous accepted patch was actually a faulty one; It was hard to trace since it's just a documentation
change. The new patch amends that, with the correct snippets and grammar fixes.

docs/qtwebkit-bridge.qdoc:
docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):

1:10 AM Changeset in webkit [61057] by eric@webkit.org

37 edits
1 move in trunk/WebCore

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Rename Tokenizer to DocumentParser to match what it actually does
https://bugs.webkit.org/show_bug.cgi?id=40504

The rename was entirely done by do-webcore-rename.
The only manual changes were removing out-dated comments
and fixing Tokenizer_h to DocumentParser_h in the header guards.

I'll do all the rest of the renames (like the tokenizer subclasses
and the tokenizer() createTokenizer() methods) in separate changes.

No functional change, thus no tests.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/v8/ScriptEventListener.cpp:
dom/Document.cpp: (WebCore::Document::createTokenizer):
dom/Document.h: (WebCore::Document::tokenizer):
dom/DocumentParser.h: Added. (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::executingScript): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlParser): (WebCore::DocumentParser::asHTMLTokenizer): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
dom/Tokenizer.h: Removed.
dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
dom/XMLTokenizer.h:
dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::stopParsing):
dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::stopParsing):
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer):
html/HTML5Tokenizer.h:
html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
html/HTMLDocument.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::stopParsing):
html/HTMLTokenizer.h:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
html/HTMLViewSourceDocument.h:
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createTokenizer):
loader/FTPDirectoryDocument.h:
loader/ImageDocument.cpp: (WebCore::ImageDocument::createTokenizer):
loader/ImageDocument.h:
loader/MediaDocument.cpp: (WebCore::MediaDocument::createTokenizer):
loader/MediaDocument.h:
loader/PluginDocument.cpp: (WebCore::PluginDocument::createTokenizer):
loader/PluginDocument.h:
loader/SinkDocument.cpp: (WebCore::SinkDocument::createTokenizer):
loader/SinkDocument.h:
loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):
loader/TextDocument.h:
wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):

12:36 AM Changeset in webkit [61056] by eric@webkit.org

10 edits in trunk

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

platform/qt/Skipped:

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core):
Api/qwebhistory.h:
Api/qwebhistory_p.h:
WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isTargetItem): (DumpRenderTreeSupportQt::historyItemTarget): (DumpRenderTreeSupportQt::getChildHistoryItems):
WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):

12:23 AM Changeset in webkit [61055] by eric@webkit.org

4 edits in trunk/WebCore

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5Tokenizer needs to tell the InspectorTimelineAgent before and after it writes
https://bugs.webkit.org/show_bug.cgi?id=40417

This "fixes" inspector/timeline-script-tag-1.html. HTML5 results
differ from the old parser for expected reasons.

HTML5Tokenizer calls InspectorTimelineAgent::will/didWriteHTML every
time we pump the lexer instead of every write() call.
We end up pumping the lexer slightly more often than the old code called
write() in order to cleanly handle unclosed-entities, unclosed tags,
buffered characters, etc. at the end of a document.

I discussed this extensively with James Robinson in #webkit and we decided
that it was better for the HTML5Tokenizer to call for every pump and
that the Inspector should later filter out empty pumps.

We can't filter out empty pumps yet, because the number of parsed
characters is passed in willWrite instead of didWrite and thus is
speculative (and wrong). This is a problem independent of this change
as willWrite's "length" argument is wrong in different ways for the old
parser, including always being 0 when the old parser resumes.

Tested by inspector/timeline-script-tag-1.html

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::willPumpLexer):
- Notify the InspectorTimelineAgent we're about to process input.

(WebCore::HTML5Tokenizer::didPumpLexer):

Notify the InspectorTimelineAgent we did process tokens.

(WebCore::HTML5Tokenizer::pumpLexer):

Call willPump and didPump

html/HTML5Tokenizer.h:
inspector/InspectorTimelineAgent.h:
- Add a FIXME about passing length to didWrite instead of willWrite.

12:09 AM Changeset in webkit [61054] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-06-11 Eric Seidel <eric@webkit.org>

Unreviewed. Just updating expectations.

tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
https://bugs.webkit.org/show_bug.cgi?id=40485

The current HTML5 parser is expected to fail the new webkit01 test.
It will be fixed when we fix text-node coalescing as discussed in
the previous commit.

html5lib/runner-expected-html5.txt:
html5lib/webkit-resumer-expected-html5.txt:

Jun 11, 2010:

11:21 PM Changeset in webkit [61053] by eric@webkit.org

3 edits
2 deletes in trunk

2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61052.
http://trac.webkit.org/changeset/61052
https://bugs.webkit.org/show_bug.cgi?id=40517

"Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
eseidel on #webkit).

fast/html/hidden-attr-expected.txt: Removed.
fast/html/hidden-attr.html: Removed.

2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61052.
http://trac.webkit.org/changeset/61052
https://bugs.webkit.org/show_bug.cgi?id=40517

"Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
eseidel on #webkit).

html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): (WebCore::HTMLElement::parseMappedAttribute):

9:54 PM Applications using WebKit edited by yves@mailhot.com

(diff)

6:28 PM Changeset in webkit [61052] by mjs@apple.com

3 edits
2 adds in trunk

2010-06-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ojan Vafai.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

Test: fast/html/hidden-attr.html

Note: I used the mapped attribute mechanism for this instead of a rule in the UA stylesheet
to avoid a performance hit from adding a global attribute rule to the UA stylesheet.

html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute. (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.

2010-06-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ojan Vafai.

Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

fast/html/hidden-attr-expected.txt: Added.
fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

5:54 PM Changeset in webkit [61051] by Simon Fraser

1 edit
1 add in trunk/LayoutTests

2010-06-11 Simon Fraser <Simon Fraser>

Add expected result missing from the previous commit.

svg/text/text-style-invalid-expected.txt: Added.

5:52 PM Changeset in webkit [61050] by Simon Fraser

4 edits
1 add in trunk

2010-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Do not render CSS Styles :first-letter and :first-line in a SVG text element context.
https://bugs.webkit.org/show_bug.cgi?id=40031

Test: svg/text/text-style-invalid.svg

rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::firstLineBlock): (WebCore::RenderSVGText::updateFirstLetter):
rendering/RenderSVGText.h:

5:24 PM Changeset in webkit [61049] by weinig@apple.com

2 edits in trunk/WebKit2

Use -Os for optimized builds instead of -02. -02 wasn't giving the
right trade off at this time.

Reviewed by Mark Rowe.

Configurations/Base.xcconfig:

5:17 PM Changeset in webkit [61048] by weinig@apple.com

13 edits in trunk/WebKit2

Move WKRetain and WKRelease overloaded functions out of WKRetainPtr
and into the files of the type they overload (eg, WKRetain(WKFrameRef
moves to WKFrame.h)).

Reviewed by Anders Carlsson.

UIProcess/API/C/WKBase.h:
UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKFrame.h:
UIProcess/API/C/WKFramePolicyListener.h:
UIProcess/API/C/WKNavigationData.h:
UIProcess/API/C/WKPage.h:
UIProcess/API/C/WKPageNamespace.h:
UIProcess/API/C/WKPreferences.h:
UIProcess/API/C/WKString.h:
UIProcess/API/C/WKURL.h:
UIProcess/API/cpp/WKRetainPtr.h:
UIProcess/API/win/WKView.h:

4:55 PM Changeset in webkit [61047] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-06-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

upload all patches that lack in-rietveld to rietveld
https://bugs.webkit.org/show_bug.cgi?id=40444

If it's a patch, then we'll try to upload it as long as it
doesn't have in-rietveld set. No longer set in-rietveld? since
it's not needed.

Scripts/webkitpy/common/net/bugzilla.py:

4:44 PM Changeset in webkit [61046] by kbr@google.com

5 edits in trunk

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
https://bugs.webkit.org/show_bug.cgi?id=40506

Return the data members of WebGLRenderingContext for these
parameter queries rather than asking OpenGL, which knows nothing
about them.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getParameter):

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
https://bugs.webkit.org/show_bug.cgi?id=40506

Return the data members of WebGLRenderingContext for these
parameter queries rather than asking OpenGL, which knows nothing
about them.

fast/canvas/webgl/gl-get-calls-expected.txt:
fast/canvas/webgl/gl-get-calls.html:

4:38 PM Changeset in webkit [61045] by Simon Fraser

3 edits
2 adds in trunk

2010-06-11 Simon Fraser <Simon Fraser>

Reviewed by Dr Dan Bernstein.

REGRESSION: crash when unloading an iFrame with Flash from the DOM
https://bugs.webkit.org/show_bug.cgi?id=40161
<rdar://problem/7994710>

Null-check the ownerElement of the RenderView's document when unhooking the compositing
root of an iframe whose layers are parented via the enclosing document. Fixes a crash when
dynamically removing such an iframe.

Test: compositing/iframes/remove-iframe-crash.html

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::detachRootPlatformLayer):

4:33 PM Changeset in webkit [61044] by jhawkins@chromium.org

3 edits
2 adds in trunk

2010-06-11 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Don't process floats if parent node is not a RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=40033

Test: svg/text/clear-floats-crash.svg

rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):

2010-06-11 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that we do not crash when clearing floats during SVG load.
https://bugs.webkit.org/show_bug.cgi?id=40033

svg/text/clear-floats-crash-expected.txt: Added.
svg/text/clear-floats-crash.svg: Added.

3:50 PM Changeset in webkit [61043] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, fixing Chromium test bots.

platform/chromium/test_expectations.txt:

Adding MISSING expectation for the fast/css/nested-rounded-corners.html

3:41 PM Changeset in webkit [61042] by kbr@google.com

3 edits in trunk/LayoutTests

2010-06-11 Kenneth Russell <kbr@google.com>

Unreviewed, test fix.

gl-get-calls failing apparently due to UNPACK_ALIGNMENT test
https://bugs.webkit.org/show_bug.cgi?id=40502

Disabled new test of UNPACK_ALIGNMENT which appears to be failing
on some of the bots.

fast/canvas/webgl/gl-get-calls-expected.txt:
fast/canvas/webgl/gl-get-calls.html:

3:10 PM Changeset in webkit [61041] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61036.
http://trac.webkit.org/changeset/61036
https://bugs.webkit.org/show_bug.cgi?id=40499

broke chromium compile (Requested by jamesr on #webkit).

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):

3:08 PM Changeset in webkit [61040] by jamesr@google.com

1 edit
2 adds in trunk/LayoutTests

2010-06-11 James Robinson <jamesr@chromium.org>

Unreviewed baselines for new test on Qt/Gtk.

https://bugs.webkit.org/show_bug.cgi?id=40456

Qt and Gtk appear to produce layers of slightly different sizes
for blocks with rounded corners, probably due to roundoff difference
in the graphics layers. Since the diffs are +/- 1 pixel, just
rebaselining.

platform/gtk/fast/css/nested-rounded-corners-expected.txt: Added.
platform/qt/fast/css/nested-rounded-corners-expected.txt: Added.

3:03 PM Changeset in webkit [61039] by kbr@google.com

20 edits in trunk

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add texImage2D and texSubImage2D signatures with internal format, etc.
https://bugs.webkit.org/show_bug.cgi?id=40318

Added new texImage2D and texSubImage2D entry points following
WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
them for the new entry points taking HTML elements, and added
support to getParameter. Added warnings to the console for calls
to the obsolete entry points, which will be removed in a few
weeks. Updated all layout tests to use the new entry points and
pixelStorei parameters, and associated expectations. No other new
tests.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::printWarningToConsole):
html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContext.idl:
platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Add texImage2D and texSubImage2D signatures with internal format, etc.
https://bugs.webkit.org/show_bug.cgi?id=40318

Added new texImage2D and texSubImage2D entry points following
WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
them for the new entry points taking HTML elements, and added
support to getParameter. Added warnings to the console for calls
to the obsolete entry points, which will be removed in a few
weeks. Updated all layout tests to use the new entry points and
pixelStorei parameters, and associated expectations. No other new
tests.

fast/canvas/webgl/bug-32364-expected.txt:
fast/canvas/webgl/bug-32364.html:
fast/canvas/webgl/bug-32888.html:
fast/canvas/webgl/gl-get-calls-expected.txt:
fast/canvas/webgl/gl-get-calls.html:
fast/canvas/webgl/resources/utils3d.js: (doLoadImageTexture):
fast/canvas/webgl/script-tests/texImageTest.js:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
fast/canvas/webgl/texImage2DImageDataTest.html:
fast/canvas/webgl/texImageTest-expected.txt:
fast/canvas/webgl/texture-npot.html:

2:43 PM Fixing page breaking edited by jamesr@google.com

(diff)

2:42 PM WikiStart edited by jamesr@google.com

(diff)

2:42 PM Fixing page breaking created by jamesr@google.com

2:33 PM Changeset in webkit [61038] by zmo@google.com

3 edits in trunk/LayoutTests

Roll out the failing part of fast/canvas/webgl/get-active-test.html (failed in Chrome in Mac)

2:24 PM QtWebKitContrib edited by adawit@kde.org

Added more details on how to track QtWebKit release staging branches (diff)

2:08 PM Changeset in webkit [61037] by jamesr@google.com

4 edits
4 adds in trunk

2010-06-11 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Skia mispaints pages with border-radius
https://bugs.webkit.org/show_bug.cgi?id=40456

Skia mispaints pages that have border radius set in some cases. The bug is in the anti aliased
clip path logic used to implement anti aliased curves in Skia. Since Skia internally only supports
1-bit clips, anti aliased clipping is emulated by creating a new alpha layer, storing a set of
clip paths on the side, and then 'erasing' the regions outside the clip. See r49641.
PlatformContextSkia maintains a stack of PlatformContextSkia::State objects that preserve information
like fill color, drawing mode, etc that is manipulated by GraphicsContext::save() /
GraphicsContext::restore() calls as well some internal functions. Whenever a new State object is pushed
a new copy of the current State object is pushed onto the top of this stack using the copy c'tor. The
set of anti alias clip paths is also stored on the State object, but not copied when new entries are
added as the paths only apply to that entry on the stack.

The bug is that the state stack is stored in a WTF::Vector. When this vector exceeds its capacity
(by default at 16 elements) all of the existing State entries are copied into the new buffer using
State's copy constructor. This does not preserve the anti alias clip paths, so when the State entries
are popped the anti aliasing info is lost. This corrupts all further paint operations since it results
in inbalanced save/restore calls to the underlying SkCanvas.

The fix is to make the PlatformContextSkia::State copy constructor copy all fields and to add a new
function PlatformContextSkia::State::cloneInheritedProperties to use when pushing new State entries
that copies everything except for the anti aliased clip paths.

Test: fast/css/nested-rounded-corners.html

platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::State::cloneInheritedProperties): (PlatformContextSkia::save):

2010-06-11 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Skia mispaints pages with border-radius
https://bugs.webkit.org/show_bug.cgi?id=40456

Tests deeply nested divs with border-radius.

fast/css/nested-rounded-corners-expected.txt: Added.
fast/css/nested-rounded-corners.html: Added.
platform/chromium/test_expectations.txt
platform/chromium-linux/fast/css/nested-rounded-corners-expected.checksum: Added.
platform/chromium-linux/fast/css/nested-rounded-corners-expected.png: Added.

1:41 PM Changeset in webkit [61036] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
bindings/v8/SerializedScriptValue.h:

1:20 PM Changeset in webkit [61035] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-11 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Notify the WebView when the AutoFill popup hides.

https://bugs.webkit.org/show_bug.cgi?id=40459

src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::selectionCleared):

12:57 PM Changeset in webkit [61034] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-11 Jesus Sanchez-Palencia <jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Typo error in QWebPluginFactory Documentation
https://bugs.webkit.org/show_bug.cgi?id=40490

Api/qwebpluginfactory.cpp:

12:37 PM Changeset in webkit [61033] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
https://bugs.webkit.org/show_bug.cgi?id=40485

The old HTMLTokenizer handled invalid close tags like "< /A>" as part
of the lexing step. The HTML5 parser specification dictates that
the tokenization/lexing step is to output each character token in sequence
and that the parser is to insert emitted character tokens into the last
parser-created text node. In our current HTML5Lexer-with-old-HTMLParser
setup, we gather up character tokens and output them all in one bunch
(to match the expectations of the old parser).

In the case of "foo< /A>" the HTML5Lexer sees the '<', switched out of the
"data" state and emits all pending characters assuming the start of a close tag.
When it sees the ' ' it switches back to the "data" state. The HTML5Lexer
expects that the parser will coalesce the separate characters it emitted
into one text node. Since we haven't implemented the parser side of the
HTML5 spec, for now we don't. This is a known issue we will address after
enabling the HTML5Lexer, as we start to write an HTML5-compliant parser.

This text-node-coalescing behavior is already tested by numerous html5lib
tests, however this was the only layout test which hit this quirk. I've
added yet another html5lib test of this exact case just for good measure.

html5lib/resources/webkit01.dat:
- Add a test of this exact case to make sure we don't miss it when implementing an HTML5-compliant parser.
tables/mozilla/bugs/bug1188.html:
- Replace "< /A>" with "&lt /A>" to avoid hitting this lexing quirk.

12:23 PM Changeset in webkit [61032] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Roll chromium DEPS 49376:49521
https://bugs.webkit.org/show_bug.cgi?id=40488

DEPS:

12:11 PM Changeset in webkit [61031] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-11 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Introduce single element caches for WebCore::String to v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435
Measurements show that for some web apps (GMail, Wave) and some scenarios
(intensive reading and/or keeping a tab open for a long time),
hit rate lies in 30--50% interval.
Inlining fast case gives another minor performance win.

bindings/v8/V8Binding.cpp: (WebCore::getStringCache): (WebCore::v8ExternalStringSlow):
bindings/v8/V8Binding.h: (WebCore::v8ExternalString):

12:00 PM Changeset in webkit [61030] by eric@webkit.org

3 edits in trunk/WebCore

2010-06-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[EFL] Build fix: remove unneeded file (npapi.cpp) and add
other files that got added to the tree.
http://webkit.org/b/40331

CMakeLists.txt:
CMakeListsEfl.txt:

11:48 AM Changeset in webkit [61029] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update Chromium test expectations.

platform/chromium/test_expectations.txt:

http://trac.webkit.org/changeset/60999 regressed acid3.html image match on Chromium Mac.
http://trac.webkit.org/changeset/61020 modified get-active-test.html that now fails on Chromium Mac.

11:46 AM Changeset in webkit [61028] by eric@webkit.org

7 edits in trunk/WebCore

2010-06-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
https://bugs.webkit.org/show_bug.cgi?id=40454

This required exposing the HTMLParser which we definitely don't want to
do, but the good news is that it can go away when the HTMLParser goes
away.

No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.

dom/Tokenizer.h: (WebCore::Tokenizer::htmlParser):
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::htmlParser):
html/HTML5Tokenizer.h:
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::htmlParser):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::htmlParser):

11:22 AM Changeset in webkit [61027] by kbr@google.com

10 edits in trunk

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443

Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.

bindings/js/JSWebGLRenderingContextCustom.cpp:
- Deleted custom bindings.
bindings/scripts/CodeGeneratorJS.pm:
- Made overload helper functions static to fix compiler warnings.
- Added needed isObject check for overloads between object and non-object arguments.
- Added JSValue::encode to exception return path, needed on Leopard in particular.
html/HTMLCanvasElement.idl:
html/HTMLImageElement.idl:
html/HTMLVideoElement.idl:
- Added GenerateNativeConverter extended attribute.
html/canvas/WebGLRenderingContext.idl:
- Deleted #ifdefs for custom JSC bindings.

2010-06-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443

Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.

fast/canvas/webgl/script-tests/texImageTest.js:
fast/canvas/webgl/texImageTest-expected.txt:

10:54 AM Changeset in webkit [61026] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Written by Dave Moore <davemoore@google.com>.

https://bugs.webkit.org/show_bug.cgi?id=22741
innerHTML, forms and images don't play well together

This was fixed already (in bug 34076), just landing an additional test.

fast/forms/form-image-access-by-name-expected.txt: Added.
fast/forms/form-image-access-by-name.html: Added.

10:42 AM Changeset in webkit [61025] by kevino@webkit.org

2 edits in trunk/WebCore

[wx] Build fix, add KillRingNone.cpp until we can implement it.

9:49 AM Changeset in webkit [61024] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-06-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Fisher.

Fix rietveld upload when message length > 100 characters
https://bugs.webkit.org/show_bug.cgi?id=40457

Scripts/webkitpy/common/net/rietveld.py:

9:17 AM Changeset in webkit [61023] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2010-06-11 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

DOM storage should only create databases when needed
https://bugs.webkit.org/show_bug.cgi?id=40301

As soon as a page attempts to use localstorage, StorageAreaSync will
create an empty database if one doesn't already exist. This can lead to
lots of unnecessary database files. In particular, they are created
even when the privacy settings or private browsing mode disallow
localstorage data, which may seem odd to the user.

Database creation should be put off in StorageAreaSync until it is time
to actually write something to the database.

Tests:

manual-tests/localstorage-empty-database.html

manual-tests/localstorage-empty-database.html: Added.
storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::openDatabase): (WebCore::StorageAreaSync::performImport): (WebCore::StorageAreaSync::sync):
storage/StorageAreaSync.h: (WebCore::StorageAreaSync::):

9:04 AM Changeset in webkit [61022] by eric@webkit.org

4 edits in trunk/WebCore

2010-06-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Eric Seidel.

Perl scripts for bindings don't use strict keyword.
As result some problems in the script code were not detected at compile stage.
https://bugs.webkit.org/show_bug.cgi?id=40468

bindings/scripts/CodeGenerator.pm:
bindings/scripts/IDLParser.pm:
bindings/scripts/IDLStructure.pm:

8:28 AM Changeset in webkit [61021] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5Tokenizer should not delete itself while running scripts
https://bugs.webkit.org/show_bug.cgi?id=40458

Tested by fast/dom/document-clear.html

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::attemptToEnd):
- Don't ever end() while running scripts. This matches the old HTMLTokenizer.cpp

8:16 AM Changeset in webkit [61020] by eric@webkit.org

3 edits
1 move
3 adds
2 deletes in trunk

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

getActiveUniform must ensure names of arrays end in "[0]"
https://bugs.webkit.org/show_bug.cgi?id=38709

fast/canvas/webgl/get-active-test-expected.txt: Copied from LayoutTests/fast/canvas/webgl/getActiveTest-expected.txt, modified to test array names.
fast/canvas/webgl/get-active-test.html: Copied from LayoutTests/fast/canvas/webgl/getActiveTest.html.
fast/canvas/webgl/getActiveTest-expected.txt: Removed.
fast/canvas/webgl/getActiveTest.html: Removed.
fast/canvas/webgl/resources/intArrayUniformShader.vert: Added, with array uniform.
fast/canvas/webgl/script-tests/get-active-test.js: Copied from LayoutTests/fast/canvas/webgl/script-tests/getActiveTest.js, modified to test array names.
fast/canvas/webgl/script-tests/getActiveTest.js: Removed.

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

getActiveUniform must ensure names of arrays end in "[0]"
https://bugs.webkit.org/show_bug.cgi?id=38709

Test: fast/canvas/webgl/get-active-test.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getActiveAttrib): Append "[0]" to the name if needed.

8:03 AM Changeset in webkit [61019] by eric@webkit.org

7 edits in trunk

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels with negative width/height should generate INVALID_VALUE and return
https://bugs.webkit.org/show_bug.cgi?id=39704

fast/canvas/webgl/read-pixels-expected.txt: Add test cases for non-positive width/height.
fast/canvas/webgl/read-pixels.html: Ditto.

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels with negative width/height should generate INVALID_VALUE and return
https://bugs.webkit.org/show_bug.cgi?id=39704

html/canvas/WebGLRenderingContext.cpp: Deal with negative width/height. (WebCore::WebGLRenderingContext::readPixels):
html/canvas/WebGLRenderingContext.h: Change width/height type from unsigned long to long.
html/canvas/WebGLRenderingContext.idl: Ditto.

7:50 AM Changeset in webkit [61018] by eric@webkit.org

7 edits in trunk

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
https://bugs.webkit.org/show_bug.cgi?id=38707

fast/canvas/webgl/null-uniform-location-expected.txt: No error is generated if a null WebGLUniformLocation is passed to uniform*().
fast/canvas/webgl/script-tests/null-uniform-location.js: Ditto.
fast/canvas/webgl/script-tests/uniform-location.js: Ditto.
fast/canvas/webgl/uniform-location-expected.txt: Ditto.

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
https://bugs.webkit.org/show_bug.cgi?id=38707

html/canvas/WebGLRenderingContext.cpp: uniform* entry points ignore the call if a null WebGLUniformLocation is passed. (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):

7:38 AM Changeset in webkit [61017] by eric@webkit.org

6 edits
4 adds
4 deletes in trunk

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

drawElements/drawArrays should validate input parameters according to GLES2 spec
https://bugs.webkit.org/show_bug.cgi?id=38700

fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds-expected.txt, and fix a few test cases.
fast/canvas/webgl/draw-arrays-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds.html, and fix a few test cases.
fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds-expected.txt, and fix a few test cases.
fast/canvas/webgl/draw-elements-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds.html, and fix a few test cases.
fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Removed.
fast/canvas/webgl/drawArraysOutOfBounds.html: Removed.
fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Removed.
fast/canvas/webgl/drawElementssOutOfBounds.html: Removed.
fast/canvas/webgl/resources/webgl-test.js: Add helper functions for easy test of gl function errors. (getGLErrorAsString): (shouldGenerateGLError):

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

drawElements/drawArrays should validate input parameters according to GLES2 spec
https://bugs.webkit.org/show_bug.cgi?id=38700

Tests: fast/canvas/webgl/draw-arrays-out-of-bounds.html

fast/canvas/webgl/draw-elements-out-of-bounds.html

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawArrays): Validate input parameters. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::validateDrawMode): Validate mode for draw{Arrays/Elements}.
html/canvas/WebGLRenderingContext.h: Add validateDrawMode, fix incorrect parameter types.
html/canvas/WebGLRenderingContext.idl: Fix incorrect parameter types.

7:25 AM Changeset in webkit [61016] by eric@webkit.org

10 edits
2 adds in trunk

2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

CSS3 Media Queries are not serialized according to CSSOM
https://bugs.webkit.org/show_bug.cgi?id=39220

Added test for testing the serialization, plus updated current
tests to take serialization into account.

fast/css/insertRule-media-expected.txt:
fast/css/insertRule-media.html:
fast/css/resources/insertRule-media.js:
fast/media/media-query-serialization-expected.txt: Added.
fast/media/media-query-serialization.html: Added.

2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

CSS3 Media Queries are not serialized according to CSSOM
https://bugs.webkit.org/show_bug.cgi?id=39220

MediaQuery serialization according to specification
http://dev.w3.org/csswg/cssom/#serializing-media-queries.

MediaQuery objects now ignore duplicated expressions. MediaQueryEvaluator::eval()
now does not proccess MediaQuery objects that are known to be invalid.

Test: fast/media/media-query-serialization.html

css/MediaQuery.cpp: (WebCore::stringCompare): (WebCore::MediaQuery::serialize): (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery): (WebCore::MediaQuery::operator==): (WebCore::MediaQuery::cssText): (WebCore::MediaQuery::append):
css/MediaQuery.h: (WebCore::MediaQuery::ignored): (WebCore::MediaQuery::begin): (WebCore::MediaQuery::end):
css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::serialize):
css/MediaQueryExp.h:
css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):

7:02 AM Changeset in webkit [61015] by jorlow@chromium.org

23 edits in trunk

2010-06-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Implement more of IndexedDB's Indexes and ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=40424

Clean up both of these classes a bit and add create/open/remove
methods as needed.

Tests in a future patch (promise).

storage/IDBDatabase.h:
storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStores): (WebCore::IDBDatabaseImpl::createObjectStore): (WebCore::IDBDatabaseImpl::objectStore): (WebCore::IDBDatabaseImpl::removeObjectStore):
storage/IDBDatabaseImpl.h: (WebCore::IDBDatabaseImpl::name): (WebCore::IDBDatabaseImpl::description): (WebCore::IDBDatabaseImpl::version):
storage/IDBDatabaseRequest.cpp: (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::createObjectStore): (WebCore::IDBDatabaseRequest::objectStore): (WebCore::IDBDatabaseRequest::removeObjectStore):
storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::create): (WebCore::IDBDatabaseRequest::name): (WebCore::IDBDatabaseRequest::description): (WebCore::IDBDatabaseRequest::version): (WebCore::IDBDatabaseRequest::objectStores):
storage/IDBDatabaseRequest.idl:
storage/IDBObjectStore.h:
storage/IDBObjectStoreImpl.h:
storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::get): (WebCore::IDBObjectStoreRequest::add): (WebCore::IDBObjectStoreRequest::modify): (WebCore::IDBObjectStoreRequest::addOrModify): (WebCore::IDBObjectStoreRequest::remove): (WebCore::IDBObjectStoreRequest::createIndex): (WebCore::IDBObjectStoreRequest::index): (WebCore::IDBObjectStoreRequest::removeIndex):
storage/IDBObjectStoreRequest.h:
storage/IDBObjectStoreRequest.idl:

2010-06-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Implement more of IndexedDB's Indexes and ObjectStores
https://bugs.webkit.org/show_bug.cgi?id=40424

Add plumbing for both of these classes.

public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores): (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::removeObjectStore):
public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::indexNames): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex):
src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::name): (WebCore::IDBDatabaseProxy::description): (WebCore::IDBDatabaseProxy::version): (WebCore::IDBDatabaseProxy::objectStores): (WebCore::IDBDatabaseProxy::objectStore): (WebCore::IDBDatabaseProxy::removeObjectStore):
src/IDBDatabaseProxy.h:
src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex):
src/IDBObjectStoreProxy.h:
src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::name): (WebKit::WebIDBDatabaseImpl::description): (WebKit::WebIDBDatabaseImpl::version): (WebKit::WebIDBDatabaseImpl::objectStores): (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::objectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore):
src/WebIDBDatabaseImpl.h:
src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl): (WebKit::WebIDBObjectStoreImpl::name): (WebKit::WebIDBObjectStoreImpl::keyPath): (WebKit::WebIDBObjectStoreImpl::indexNames): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex):
src/WebIDBObjectStoreImpl.h:

6:47 AM Changeset in webkit [61014] by apavlov@chromium.org

20 edits in trunk

2010-06-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable serialization/deserialization of the frontend state
https://bugs.webkit.org/show_bug.cgi?id=40228

WebCore:

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::saveApplicationSettings): (WebCore::InspectorBackend::saveSessionSettings):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::populateApplicationSettings): (WebCore::InspectorFrontend::populateSessionSettings):
inspector/InspectorFrontend.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded): (WebInspector.EventListenersSidebarPane.prototype): ():
inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.saveApplicationSettings): (.WebInspector.InspectorBackendStub.prototype.saveSessionSettings):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
inspector/front-end/Settings.js: (WebInspector.populateApplicationSettings): (WebInspector.populateSessionSettings): (WebInspector.Settings): (WebInspector.Settings.prototype.reset): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype._set):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._settingsLoaded): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._changeSetting): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.ComputedStyleSidebarPane.settingsLoaded): (WebInspector.ComputedStyleSidebarPane.showInheritedToggleFunction): (WebInspector.ComputedStyleSidebarPane):
inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded): (WebInspector.WatchExpressionsSection): (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.reset):

Webkit/chromium:

src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

6:37 AM Changeset in webkit [61013] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2010-06-10 S√∏ren Gjesse <sgjesse@chromium.org>

Reviewed by Pavel Feldman.

V8: Chromium test expectations not matching improved V8 JavaScript stepping
https://bugs.webkit.org/show_bug.cgi?id=40419

Update test expetations to match chaged V8 break locations.

src/js/Tests.js:

6:31 AM Changeset in webkit [61012] by pfeldman@chromium.org

20 edits in trunk

2010-06-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

https://bugs.webkit.org/show_bug.cgi?id=40422

inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::addNodesToSearchResult):
inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::performSearch): (WebCore::InspectorBackend::searchCanceled):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorDOMAgent.cpp: (WebCore::): (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::searchCanceled): (WebCore::InspectorDOMAgent::onMatchJobsTimer): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
inspector/InspectorDOMAgent.h: (WebCore::MatchJob::~MatchJob): (WebCore::MatchJob::MatchJob): (WebCore::MatchJob::addNodesToResults):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addNodesToSearchResult):
inspector/InspectorFrontend.h:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
inspector/front-end/InjectedScriptAccess.js:

2010-06-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

https://bugs.webkit.org/show_bug.cgi?id=40422

src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

2010-06-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

https://bugs.webkit.org/show_bug.cgi?id=40422

inspector/elements-panel-search.html:

6:17 AM Changeset in webkit [61011] by mnaganov@chromium.org

4 edits in trunk/WebCore

2010-06-11 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Restore 'console.profiles' access.

https://bugs.webkit.org/show_bug.cgi?id=39840

bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::stop):
bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
inspector/InspectorController.cpp: (WebCore::InspectorController::stopUserInitiatedProfiling):

5:53 AM Changeset in webkit [61010] by pfeldman@chromium.org

4 edits
2 adds in trunk/LayoutTests

2010-06-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add a test for dumping global object in the console.

https://bugs.webkit.org/show_bug.cgi?id=40241

http/tests/inspector/inspector-test.js: (frontend_dumpTreeOutline): (frontend_dumpTreeItem):
inspector/console-dir-global-expected.txt: Added.
inspector/console-dir-global.html: Added.
inspector/elements-tests.js: (frontend_dumpStyleTreeItem):

5:48 AM Changeset in webkit [61009] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-06-10 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Make a close brace in Styles pane selectable.
https://bugs.webkit.org/show_bug.cgi?id=40157

inspector/front-end/inspector.css: (.styles-selector): (.styles-section .properties li): (.styles-section):

5:39 AM Changeset in webkit [61008] by yurys@chromium.org

3 edits in trunk/WebCore

2010-06-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: localize missing script source message
https://bugs.webkit.org/show_bug.cgi?id=40467

English.lproj/localizedStrings.js:
inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): fixed typo in comment.

5:28 AM Changeset in webkit [61007] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-11 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by David Levin.

[chromium] Adding a build dependency to the gles2 C library to the webkit_unit_tests
project to allow it to link when WebCore is compiled with the ACCELERATED_COMPOSITING
flag.
https://bugs.webkit.org/show_bug.cgi?id=40341

WebKit.gyp:

5:16 AM Changeset in webkit [61006] by eric@webkit.org

6 edits in trunk

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=40315

fast/canvas/webgl/index-validation-expected.txt: Generate INVALID_ERROR when an enabled vertex attrib is not bound to any buffer in drawElements().
fast/canvas/webgl/script-tests/index-validation.js: Ditto.

2010-06-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=40315

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Check if an enabled vertext attribs is bound to a buffer. (WebCore::WebGLRenderingContext::vertexAttribPointer): Set bound buffer in vertex attrib state.
html/canvas/WebGLRenderingContext.h: Add a member in vertex attrib state to track bound buffer.

5:01 AM QtWebKitJournal edited by Simon Hausmann

(diff)

5:00 AM QtWebKitJournal edited by Simon Hausmann

(diff)

4:47 AM Changeset in webkit [61005] by jocelyn.turcotte@nokia.com

2 edits in trunk/WebKit/qt

[Qt] Second fix attempt for the build break introduced by r61002.

Reviewed by nobody, build fix.

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

3:42 AM Changeset in webkit [61004] by jocelyn.turcotte@nokia.com

2 edits in trunk/WebKit/qt

[Qt] Fix build break introduced by r61002.

Reviewed by nobody, build fix.

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

3:36 AM Changeset in webkit [61003] by Simon Hausmann

6 edits in trunk/JavaScriptCore

[Qt] Explicit conversions from QtScript types to JSC opaque types were removed.
https://bugs.webkit.org/show_bug.cgi?id=40412

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-11
Reviewed by Simon Hausmann.

Conversion between a JSC C types and a QtScript private types, takes
main part of the source code. In most cases a mapping between the types
is one to one. New cast operators were added to simplify the code.

The QScriptValuePrivate could be casted to the JSValueRef and the JSObjectRef.
The QScriptEnginePrivate could be casted to the JSGlobalContext.
The QScriptProgramPrivate could be casted to the JSStringRef.

qt/api/qscriptengine_p.cpp:

(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::newObject):
(QScriptEnginePrivate::globalObject):

qt/api/qscriptengine_p.h:

(QScriptEnginePrivate::operator JSGlobalContextRef):

qt/api/qscriptprogram_p.h:

(QScriptProgramPrivate::operator JSStringRef):

qt/api/qscriptsyntaxcheckresult.cpp:

(QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate):
(QScriptSyntaxCheckResultPrivate::errorMessage):
(QScriptSyntaxCheckResultPrivate::errorLineNumber):

qt/api/qscriptvalue_p.h:

(QScriptValuePrivate::~QScriptValuePrivate):
(QScriptValuePrivate::QScriptValuePrivate):
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::isFunction):
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toBool):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::strictlyEquals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::operator JSValueRef):
(QScriptValuePrivate::operator JSObjectRef):
(QScriptValuePrivate::setValue):
(QScriptValuePrivate::inherits):
(QScriptValuePrivate::refinedJSValue):

2:59 AM Changeset in webkit [61002] by jocelyn.turcotte@nokia.com

8 edits in trunk

[Qt] Implement the simple text code path.
https://bugs.webkit.org/show_bug.cgi?id=40077

Reviewed by Simon Hausmann.

Remove the FONT_FAST_PATH macro and use the Qt's
fast text implementation instead of the one of WebKit.

The Qt::TextBypassShaping flag is used to tell Qt to
only use the glyph advances.

Qt 4.7 is needed to get this flag thus the complex path is always
used if QtWebKit is compiled against an earlier version.

Contrary to the WebKit's implementation, the complex code path
is taken if the text is RightToLeft, justified or is formatted
with non-zero letter or word spacing.

JavaScriptCore:

wtf/Platform.h:

WebCore:

platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::floatWidth):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):

platform/graphics/Font.h:

(WebCore::Font::isRoundingHackCharacter):

platform/graphics/qt/FontQt.cpp:

(WebCore::fromRawDataWithoutRef):
(WebCore::needComplexCodePath):
(WebCore::setupPlatformContext):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::selectionRectForSimpleText):

WebKit\qt:

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

2:58 AM Changeset in webkit [61001] by jocelyn.turcotte@nokia.com

4 edits in trunk/WebCore

Move the text code path detection code from FontFastPath.cpp to Font.cpp.
https://bugs.webkit.org/show_bug.cgi?id=40077

Reviewed by Simon Hausmann.

This is a patch preliminary to the implementation of the
simple font code path for the Qt port.

platform/graphics/Font.cpp:

(WebCore::Font::setCodePath):
(WebCore::Font::codePath):

platform/graphics/Font.h:
platform/graphics/FontFastPath.cpp:

2:36 AM Changeset in webkit [61000] by eric@webkit.org

8 edits
4 adds in trunk/WebCore

2010-06-11 Sterling Swigart <sswigart@google.com>

Reviewed by Dmitry Titov.

Added AsyncImageResizer and ImageResizerThread classes, which after further
patches will be capable of resizing images.
https://bugs.webkit.org/show_bug.cgi?id=40018

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/AsyncImageResizer.cpp: Added. (WebCore::AsyncImageResizer::create): (WebCore::AsyncImageResizer::AsyncImageResizer): (WebCore::AsyncImageResizer::~AsyncImageResizer): (WebCore::AsyncImageResizer::notifyFinished):
html/AsyncImageResizer.h: Added. (WebCore::AsyncImageResizer::CallbackInfo::CallbackInfo): (WebCore::AsyncImageResizer::): (WebCore::AsyncImageResizer::resizeComplete): (WebCore::AsyncImageResizer::resizeError):
html/ImageResizerThread.cpp: Added. (WebCore::returnBlobOrError): (WebCore::ImageResizerThread::start): (WebCore::ImageResizerThread::ImageResizerThread): (WebCore::ImageResizerThread::~ImageResizerThread): (WebCore::ImageResizerThread::imageResizerThreadStart): (WebCore::ImageResizerThread::imageResizerThread):
html/ImageResizerThread.h: Added.

2:10 AM Changeset in webkit [60999] by eric@webkit.org

5 edits in trunk/LayoutTests

2010-06-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Update acid3 test with latest from acid3.acidtests.org
https://bugs.webkit.org/show_bug.cgi?id=40428

This is a straight copy from "curl http://acid3.acidtests.org/" with
LayoutTest specific bits reapplied:

Rename resources to resources/acid3/...
Add window.layoutTestController bits to start and end.

We still fail the same link test. The difference is that its error
changed from "LINKTEST FAILED" to "YOU SHOULD NOT SEE THIS AT ALL".

http/tests/misc/acid3-expected.checksum:
http/tests/misc/acid3-expected.png:
http/tests/misc/acid3-expected.txt:
http/tests/misc/acid3.html:

1:50 AM Changeset in webkit [60998] by steveblock@google.com

6 edits
3 adds in trunk

2010-06-11 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Client-based Geolocation does not handle multiple simultaneous requests
https://bugs.webkit.org/show_bug.cgi?id=40148

Test: fast/dom/Geolocation/multiple-requests.html

The Geolocation must handle multiple calls to addObserver() from the same Geolocation object.

page/GeolocationController.cpp: (WebCore::GeolocationController::addObserver):

2010-06-11 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Client-based Geolocation does not handle multiple simultaneous requests
https://bugs.webkit.org/show_bug.cgi?id=40148

The change to the GeolocationController is explicitly tested with multiple-requests.html.

This change also fixes reentrant-error.html and reentrant-success.html which were previously
on the mac skipped list. reentrant-error.html required a minor tweak as the mac
GeolocationController can only provide an error code of 2 (POSITION_UNAVAILABLE).

Added to GTK skipped list.

fast/dom/Geolocation/multiple-requests-expected.txt: Added.
fast/dom/Geolocation/multiple-requests.html: Added.
fast/dom/Geolocation/script-tests/multiple-requests.js: Added.
fast/dom/Geolocation/script-tests/reentrant-error.js:
platform/mac/Skipped:
platform/gtk/Skipped:

1:41 AM Changeset in webkit [60997] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-11 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] There should be a way to enable popups in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=40427

QtTestBrowser/main.cpp: (LauncherWindow::toggleJavascriptCanOpenWindows): (LauncherWindow::createChrome):

1:27 AM Changeset in webkit [60996] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

add codePointCompare to JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=40426

JavaScriptCore.exp:

1:12 AM Changeset in webkit [60995] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-11 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: When completing using a tab key, select very first value, not a second.
https://bugs.webkit.org/show_bug.cgi?id=40409

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):

12:47 AM Changeset in webkit [60994] by hamaji@chromium.org

2 edits in trunk/LayoutTests

2010-06-11 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed.

Skip re-enabled SVG test (svg/W3C-SVG-1.1/fonts-glyph-02-t)

platform/chromium/test_expectations.txt:

Jun 10, 2010:

11:56 PM Changeset in webkit [60993] by abarth@webkit.org

5 edits
1 add in trunk/WebKitTools

2010-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Make SheriffBot more chatty
https://bugs.webkit.org/show_bug.cgi?id=40463

People seem to like to talk to SheriffBot, so let's make him chat back.

Scripts/webkitpy/thirdparty/init.py:
Scripts/webkitpy/tool/bot/irc_command.py:
Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
Scripts/webkitpy/tool/bot/sheriffircbot.py:
Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

10:51 PM Changeset in webkit [60992] by yuzo@google.com

4 edits
4 adds in trunk

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452

platform/chromium/test_expectations.txt:
platform/mac/printing/page-rule-in-media-query-expected.checksum: Added.
platform/mac/printing/page-rule-in-media-query-expected.png: Added.
platform/mac/printing/page-rule-in-media-query-expected.txt: Added.
printing/page-rule-in-media-query.html: Added.

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452

Test: printing/page-rule-in-media-query.html

css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSRuleSet::addStyleRule):

10:47 PM Changeset in webkit [60991] by eric@webkit.org

7 edits in trunk/WebCore

2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60989.
http://trac.webkit.org/changeset/60989
https://bugs.webkit.org/show_bug.cgi?id=40462

It makes things crash (Requested by abarth on #webkit).

dom/Tokenizer.h: (WebCore::Tokenizer::isHTMLTokenizer):
html/HTML5Tokenizer.cpp:
html/HTML5Tokenizer.h:
html/HTML5TreeBuilder.h:
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::isHTMLTokenizer): (WebCore::HTMLTokenizer::htmlParser):

10:36 PM Changeset in webkit [60990] by oliver@apple.com

3 edits
3 adds in trunk

2010-06-10 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
https://bugs.webkit.org/show_bug.cgi?id=40367

If we're in the slow case of right shift we must write the type tag as
the only reason we hit this code path is because we know we're working
with a double. eg. we are guaranteed that the tag cannot be reused.

jit/JITArithmetic32_64.cpp: (JSC::JIT::emitRightShiftSlowCase):

2010-06-10 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Math Javascript Bug on Safari 5 (webkit 533.16) under "32bit" mode
https://bugs.webkit.org/show_bug.cgi?id=40367

Add some tests to ensure correct behaviour of right shift.

fast/js/bitops-type-tag.html: Added.
fast/js/script-tests/bitops-type-tag.js: Added.

10:28 PM Changeset in webkit [60989] by abarth@webkit.org

7 edits in trunk/WebCore

2010-06-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
https://bugs.webkit.org/show_bug.cgi?id=40454

This required exposing the HTMLParser which we definitely don't want to
do, but the good news is that it can go away when the HTMLParser goes
away.

No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.

dom/Tokenizer.h: (WebCore::Tokenizer::htmlParser):
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::htmlParser):
html/HTML5Tokenizer.h:
html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::htmlParser):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::htmlParser):

9:58 PM Changeset in webkit [60988] by bweinstein@apple.com

2 edits in trunk/WebKitTools

Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.

Reviewed by Darin Adler.

Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
WEXITSTATUS on $result instead of just comparing $result to 0.

Scripts/update-webkit-auxiliary-libs:

9:05 PM Changeset in webkit [60987] by tkent@chromium.org

3 edits in trunk/WebKit/chromium

[DRT/Chromium] Support plugin tests
https://bugs.webkit.org/show_bug.cgi?id=40413

Reviewed by Dimitri Glazkov.

DEPS: Bump the Chromium revision to r49376 to have a npapi_layout_test_plugin change and Linux <progress> resources. Add third_party/mesa because app/ depends on them since r49332.
WebKit.gyp: Copy a plugin binary for DRT to recognize it.

6:40 PM Changeset in webkit [60986] by jhawkins@chromium.org

2 edits in trunk/WebKit/chromium

2010-06-10 James Hawkins <jhawkins@chromium.org>

Not reviwed.

Build fix for Chromium Mac Release.

src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::itemIsSeparator):

5:51 PM Changeset in webkit [60985] by jhawkins@chromium.org

6 edits in trunk/WebKit/chromium

2010-06-09 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add the ability to specify a separator in
AutoFillPopupMenuClient.

https://bugs.webkit.org/show_bug.cgi?id=40397

public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestionsCount): (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::itemIsSeparator): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::setSuggestions):
src/AutoFillPopupMenuClient.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
src/WebViewImpl.h:

5:49 PM Changeset in webkit [60984] by tony@chromium.org

3 edits
2 adds in trunk

2010-06-10 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407

fast/events/focus-change-crash-expected.txt: Added.
fast/events/focus-change-crash.html: Added.

2010-06-10 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

crash when focus is changed while trying to focus next element
https://bugs.webkit.org/show_bug.cgi?id=40407

Test: fast/events/focus-change-crash.html

dom/Element.cpp: (WebCore::Element::focus):

5:45 PM Changeset in webkit [60983] by ap@apple.com

3 edits
1 move in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=18830
Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

This doesn't happen any more, the code has changed a lot since 2008. Re-enabling the test.

platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled.
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Removed.

5:27 PM Changeset in webkit [60982] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-06-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Alexey Proskuryakov.

don't use Exception.message as it's deprecated in python 2.6+
https://bugs.webkit.org/show_bug.cgi?id=40449

Scripts/webkitpy/tool/commands/queues.py:

4:05 PM Changeset in webkit [60981] by yael.aharon@nokia.com

2 edits in trunk/WebKit/qt

[Qt] Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40004

Reviewed by Kenneth Rohde Christiansen.

Take into use the icon that was loaded for the notification.

WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::show):

4:05 PM Changeset in webkit [60980] by kbr@google.com

10 edits in trunk

2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60979.
http://trac.webkit.org/changeset/60979
https://bugs.webkit.org/show_bug.cgi?id=40450

Broke build on Leopard (Requested by kbr_google on #webkit).

bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D):
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLCanvasElement.idl:
html/HTMLImageElement.idl:
html/HTMLVideoElement.idl:
html/canvas/WebGLRenderingContext.idl:

2010-06-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60979.
http://trac.webkit.org/changeset/60979
https://bugs.webkit.org/show_bug.cgi?id=40450

Broke build on Leopard (Requested by kbr_google on #webkit).

fast/canvas/webgl/script-tests/texImageTest.js:
fast/canvas/webgl/texImageTest-expected.txt:

3:44 PM Changeset in webkit [60979] by kbr@google.com

10 edits in trunk

2010-06-10 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443

Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.

bindings/js/JSWebGLRenderingContextCustom.cpp:
- Deleted custom bindings.
bindings/scripts/CodeGeneratorJS.pm:
- Made overload helper functions static to fix compiler warnings.
- Added needed isObject check for overloads between object and non-object arguments.
html/HTMLCanvasElement.idl:
html/HTMLImageElement.idl:
html/HTMLVideoElement.idl:
- Added GenerateNativeConverter extended attribute.
html/canvas/WebGLRenderingContext.idl:
- Deleted #ifdefs for custom JSC bindings.

2010-06-10 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=40443

Deleted custom JSC bindings for bufferData, texImage2D and
texSubImage2D and fixed minor associated issues in code generator
and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
which now runs as intended. Ran all layout tests, including WebGL
tests, in Safari.

fast/canvas/webgl/script-tests/texImageTest.js:
fast/canvas/webgl/texImageTest-expected.txt:

3:03 PM Changeset in webkit [60978] by hyatt@apple.com

4 edits in trunk/WebKitLibraries

Update WebKitSystemInterface to fix build.

2:56 PM Changeset in webkit [60977] by dimich@chromium.org

2 edits in trunk/WebKit/chromium

Not reviewed, Chromium build fix from Abhishek Arya.

src/WebImageCG.cpp:

(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):

2:55 PM Changeset in webkit [60976] by ojan@chromium.org

7 edits in trunk/WebKitTools

2010-06-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix handle_script_error in rietveld upload queue and add testing for handle_script_error
https://bugs.webkit.org/show_bug.cgi?id=40436

Scripts/webkitpy/common/system/outputcapture.py:
Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/mocktool.py:

2:40 PM Changeset in webkit [60975] by hyatt@apple.com

1 edit in trunk/LayoutTests/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt

Reset layout test results for continuous wheeling.

2:31 PM Changeset in webkit [60974] by hyatt@apple.com

6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
wheel delta values.

Reviewed by John Sullivan.

WebCore:

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/mac:

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

2:29 PM Changeset in webkit [60973] by hamaji@chromium.org

6 edits in trunk

2010-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Add null pointer checks for nativeImageForCurrentFrame
function calls.
https://bugs.webkit.org/show_bug.cgi?id=39797

platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):

2010-06-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Add null pointer checks for nativeImageForCurrentFrame
function calls.
https://bugs.webkit.org/show_bug.cgi?id=39797

src/WebImageCG.cpp: (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):

2:01 PM Changeset in webkit [60972] by sullivan@apple.com

2 edits in trunk/WebKit2

mac/WebKit2.exp:

Added another symbol needed by Mac clients.

Reviewed by Dan Bernstein.

1:41 PM Changeset in webkit [60971] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-06-10 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] *All* WebGL layout tests fail!
https://bugs.webkit.org/show_bug.cgi?id=40296

Added test for WebKitWebGLEnabled to
LayoutTestController::overridePreference().

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):

12:34 PM Changeset in webkit [60970] by eric@webkit.org

3 edits
2 adds in trunk/LayoutTests

2010-06-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix Qt-specific event-sender-keydown-frame.html test

It looks like this test was added without elements required for it work.

http://bugs.webkit.org/show_bug.cgi?id=20303

platform/qt/Skipped:
platform/qt/fast/events/event-sender-keydown-frame.html:
platform/qt/fast/events/resources/divs.html: Added.

12:13 PM Changeset in webkit [60969] by andersca@apple.com

3 edits in trunk/WebKitExamplePlugins

Fix build.

NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
NetscapeCocoaPlugin/main.m:

(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

11:57 AM Changeset in webkit [60968] by dimich@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update Chromium test expectations.

platform/chromium/test_expectations.txt:

Disable fast/text/international/khmer-selection.html on Windows regressed by http://trac.webkit.org/changeset/60953
Skip fast/dom/Window/window-properties-geolocation.html unnecessarily enabled by http://trac.webkit.org/changeset/60956

11:53 AM Changeset in webkit [60967] by kbr@google.com

24 edits in trunk

2010-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement TypedArray BYTES_PER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=39100

Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
Required bug fixes to JSC bindings' custom constructors. Updated
fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
layout tests in Safari and Chromium.

bindings/js/JSFloat32ArrayConstructor.cpp: (WebCore::JSFloat32ArrayConstructor::JSFloat32ArrayConstructor): (WebCore::JSFloat32ArrayConstructor::getOwnPropertySlot): (WebCore::JSFloat32ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSFloat32ArrayConstructor.h: (WebCore::JSFloat32ArrayConstructor::createStructure):
bindings/js/JSInt16ArrayConstructor.cpp: (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::JSInt16ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt16ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSInt16ArrayConstructor.h: (WebCore::JSInt16ArrayConstructor::createStructure):
bindings/js/JSInt32ArrayConstructor.cpp: (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::JSInt32ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt32ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSInt32ArrayConstructor.h: (WebCore::JSInt32ArrayConstructor::createStructure):
bindings/js/JSInt8ArrayConstructor.cpp: (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::JSInt8ArrayConstructor::getOwnPropertySlot): (WebCore::JSInt8ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSInt8ArrayConstructor.h: (WebCore::JSInt8ArrayConstructor::createStructure):
bindings/js/JSUint16ArrayConstructor.cpp: (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::JSUint16ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint16ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSUint16ArrayConstructor.h: (WebCore::JSUint16ArrayConstructor::createStructure):
bindings/js/JSUint32ArrayConstructor.cpp: (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::JSUint32ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint32ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSUint32ArrayConstructor.h: (WebCore::JSUint32ArrayConstructor::createStructure):
bindings/js/JSUint8ArrayConstructor.cpp: (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::JSUint8ArrayConstructor::getOwnPropertySlot): (WebCore::JSUint8ArrayConstructor::getOwnPropertyDescriptor):
bindings/js/JSUint8ArrayConstructor.h: (WebCore::JSUint8ArrayConstructor::createStructure):
html/canvas/Float32Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:

2010-06-09 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement TypedArray BYTES_PER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=39100

Implemented BYTES_PER_ELEMENT on all ArrayBufferView subclasses.
Required bug fixes to JSC bindings' custom constructors. Updated
fast/canvas/webgl/array-unit-tests.html to verify. Ran all WebGL
layout tests in Safari and Chromium.

fast/canvas/webgl/array-unit-tests.html:

11:17 AM Changeset in webkit [60966] by abarth@webkit.org

4 edits
2 adds in trunk

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 Parser should continue parsing after script execution
https://bugs.webkit.org/show_bug.cgi?id=40416

The previous code was just wrong. We were always blocking
the parser after any script execution. Now we correctly continue
parsing after a successful script execution and only block the
parser when we weren't able to execute the script immediately.

Added a new haveParsingBlockingScript() function to HTML5ScriptRunner
to make some of the code more self-documenting.

Test: fast/tokenizer/write-multiple-scripts.html

fast/js/implicit-call-with-global-reentry.html

html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::execute):
- Remove some old (now bogus) FIXMEs and notImplemented() calls.
- Fix the logic to match the HTML5 spec by continuing parsing after script execution and only blocking the parser when the script wasn't able to immediately run.

(WebCore::HTML5ScriptRunner::haveParsingBlockingScript):

New function to make some of the code read better.

(WebCore::HTML5ScriptRunner::executeParsingBlockingScripts):

Use haveParsingBlockingScript().

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

Use haveParsingBlockingScript().

(WebCore::HTML5ScriptRunner::runScript):

Use haveParsingBlockingScript().

html/HTML5ScriptRunner.h:

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 Parser should continue parsing after script execution
https://bugs.webkit.org/show_bug.cgi?id=40416

Test the ordering of script execution with multiple calls to
document.write().

fast/tokenizer/write-multiple-scripts-expected.txt: Added.
fast/tokenizer/write-multiple-scripts.html: Added.

10:59 AM Changeset in webkit [60965] by yurys@chromium.org

13 edits in trunk

2010-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: to reduce the front end start up time don't push script
sources to frontend if debugger is always enabled, instead request
script content lazily at the moment it should be displyed. It is critical for
always enabled debugger because in that case lots of script may have
already been parsed when the front end is opening and pushing all
of them at once may slow things down(even though the script sources will never
be used if scripts panel isn't open).
https://bugs.webkit.org/show_bug.cgi?id=40364

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getScriptSource):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::didParseSource):
inspector/InspectorController.h:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetScriptSource):
inspector/InspectorFrontend.h:
inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.editScriptSource): (.WebInspector.InspectorBackendStub.prototype.getScriptSource):
inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): (WebInspector.ScriptView.prototype._didGetScriptSource): (WebInspector.ScriptView.prototype._sourceFrameSetupFinished):

2010-06-10 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: to reduce the front end start up time don't push script
sources to frontend if debugger is always enabled, instead request
script content lazily at the moment it should be displyed. It is critical for
always enabled debugger because in that case lots of script may have
already been parsed when the front end is opening and pushing all
of them at once may slow things down(even though the script sources will never
be used if scripts panel isn't open).
https://bugs.webkit.org/show_bug.cgi?id=40364

src/js/DevTools.js:
src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): (.devtools.InspectorBackendImpl.prototype.getScriptSource):

10:39 AM Changeset in webkit [60964] by abarth@webkit.org

5 edits in trunk/WebCore

2010-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use allowRequestIfNoIllegalURICharacters instead of context for XSSAuditor::canLoadExternalScriptFromSrc
https://bugs.webkit.org/show_bug.cgi?id=40404

We originally added the context parameter to
canLoadExternalScriptFromSrc to work around some false positives caused
by folks checking external script URLs on the server. Our thought was
that we could tell these were not real XSS attacks because the
surrounding context wouldn't match in the URL and the document.

Implementing this feature in the HTML5 parser is hard because it
pierces a layer of abstraction (the token abstraction of the input
stream). We could hack this into the new parser, but instead I think
it's better to switch to using the allowRequestIfNoIllegalURICharacters
heuristic.

We designed the allowRequestIfNoIllegalURICharacters after the context
heuristic to deal with other cases where the server was validating
input before echoing it. However, we never tried applying it to
canLoadExternalScriptFromSrc.

It's possible that this will cause false positives and will need to be
reverted, which is why I've left in some of the infrustructure for
computing context. We don't have a good way to know if that will
happen except to try. We do know, however, that this heuristic will
work for the original false positives we saw.

html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::shouldLoadExternalScriptFromSrc):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
page/XSSAuditor.h:

10:24 AM Changeset in webkit [60963] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Memory leak in qwebpage unit test cases
https://bugs.webkit.org/show_bug.cgi?id=40405

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::infiniteLoopJS):

10:10 AM Changeset in webkit [60962] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(DATABASE) guard for DatabaseAuthorizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=40399

Build fix for ENABLE(DATABASE)=0.

storage/DatabaseAuthorizer.cpp:

9:49 AM Changeset in webkit [60961] by eric@webkit.org

23 edits in trunk

2010-06-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.blur.html.

platform/qt/Skipped:

2010-06-10 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowBlur from int to float in GraphicsContext.
Using int for ShadowBlur loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue. Function CGContextSetShadowWithColor() does not take
a blur value less than 0.5.

https://bugs.webkit.org/show_bug.cgi?id=40370

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextPrivate.h:
platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

9:32 AM Changeset in webkit [60960] by eric@webkit.org

8 edits
14 adds in trunk

2010-06-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40396

http/tests/notifications: Added.
http/tests/notifications/icon-does-not-exist-expected.txt: Added.
http/tests/notifications/icon-does-not-exist.html: Added.
http/tests/notifications/icon-exists-cancel-expected.txt: Added.
http/tests/notifications/icon-exists-cancel.html: Added.
http/tests/notifications/icon-exists-expected.txt: Added.
http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Added.
http/tests/notifications/icon-exists-show-alert-during-load.html: Added.
http/tests/notifications/icon-exists.html: Added.
http/tests/notifications/icon-requires-auth-expected.txt: Added.
http/tests/notifications/icon-requires-auth.html: Added.
http/tests/notifications/resources: Added.
http/tests/notifications/resources/icon-exists.png: Added.
http/tests/notifications/resources/icon-requires-auth.php: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

2010-06-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40396

Make notification objects download the icon needed for displaying the
notification before calling the NotificationPresenter to display the
notification.

An error during the download would cause the notification to be displayed
without an icon.

If a notification is in the process of download, and a new notification
is created with the same ReplaceId, the download is not cancelled
immediately and the notification is removed only after the download is
complete.

Tests: http/tests/notifications/icon-does-not-exist.html

http/tests/notifications/icon-exists-cancel.html
http/tests/notifications/icon-exists-show-alert-during-load.html
http/tests/notifications/icon-exists.html
http/tests/notifications/icon-requires-auth.html

notifications/Notification.cpp: (WebCore::Notification::Notification): (WebCore::Notification::~Notification): (WebCore::Notification::show): (WebCore::Notification::cancel): (WebCore::Notification::startLoading): (WebCore::Notification::stopLoading): (WebCore::Notification::didReceiveResponse): (WebCore::Notification::didReceiveData): (WebCore::Notification::didFinishLoading): (WebCore::Notification::didFail): (WebCore::Notification::didFailRedirectCheck): (WebCore::Notification::didReceiveAuthenticationCancellation): (WebCore::Notification::finishLoading):
notifications/Notification.h: (WebCore::Notification::iconData): (WebCore::Notification::releaseIconData): (WebCore::Notification::):

8:45 AM Changeset in webkit [60959] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-06-10 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT EventSender support to graphics mouse events activation
https://bugs.webkit.org/show_bug.cgi?id=40017

DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::keyDown): (EventSender::contextClick): (EventSender::sendTouchEvent): (EventSender::sendOrQueueEvent): (EventSender::eventFilter): (EventSender::createGraphicsSceneMouseEvent): (EventSender::sendEvent):
DumpRenderTree/qt/EventSenderQt.h: (EventSender::isGraphicsBased):

8:34 AM Changeset in webkit [60958] by eric@webkit.org

7 edits
4 adds in trunk

2010-06-10 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Impossible to set input method hints based HTML5 input types
https://bugs.webkit.org/show_bug.cgi?id=40107

Helper methods for checking "tel", "number", "email",
and "url" input element types.

html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTelephoneField): (WebCore::HTMLInputElement::isNumberField): (WebCore::HTMLInputElement::isEmailField): (WebCore::HTMLInputElement::isUrlField):

2010-06-10 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Impossible to set input method hints based HTML5 input types
https://bugs.webkit.org/show_bug.cgi?id=40107

EditorClientQt to set input method hints for "number", "tel",
"email", and "url" HTML input elements.

Tests for HTML input elements and input method hints added for
QGraphicsWebView and QWebView.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
tests/qgraphicswebview/resources/input_types.html: Added.
tests/qgraphicswebview/tst_qgraphicswebview.cpp: (GraphicsWebView::GraphicsWebView): (GraphicsWebView::fireMouseClick): (tst_QGraphicsWebView::focusInputTypes):
tests/qgraphicswebview/tst_qgraphicswebview.qrc: Added.
tests/qwebview/resources/input_types.html: Added.
tests/qwebview/tst_qwebview.cpp: (WebView::fireMouseClick): (tst_QWebView::focusInputTypes):
tests/qwebview/tst_qwebview.qrc:

7:31 AM Changeset in webkit [60957] by eric@webkit.org

21 edits
3 adds in trunk

2010-06-10 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826

For security reasons, we don't want to expose file system paths to web
content, so we filter them out of edit drags.

editing/pasteboard/file-drag-to-editable-expected.txt: Added.
editing/pasteboard/file-drag-to-editable.html: Added.
editing/pasteboard/script-tests/file-drag-to-editable.js: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2010-06-10 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826

For security reasons, we don't want to expose file system paths to web
content, so we filter them out of edit drags.

Test: editing/pasteboard/file-drag-to-editable.html

page/DragController.cpp: (WebCore::documentFragmentFromDragData):
platform/DragData.h: (WebCore::DragData::):
platform/android/DragDataAndroid.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/chromium/DragDataChromium.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/efl/DragDataEfl.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/haiku/DragDataHaiku.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/qt/DragDataQt.cpp: (WebCore::DragData::asPlainText): (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getURL): (WebCore::getPlainText):
platform/win/ClipboardUtilitiesWin.h:
platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::getData):
platform/win/DragDataWin.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/wince/DragDataWince.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
platform/wx/DragDataWx.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):

7:16 AM Changeset in webkit [60956] by eric@webkit.org

2 edits
2 adds in trunk/LayoutTests

2010-06-10 Marcus Bulach <bulach@google.com>

Reviewed by Jeremy Orlow.

[chromium] Upstream layout tests expectations for Geolocation.
Rebaseline fast/dom/Geolocation/callback-exception-expected.html due to JSC x V8 messages.
https://bugs.webkit.org/show_bug.cgi?id=39721

platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt: Added.
platform/chromium/test_expectations.txt:

6:56 AM Changeset in webkit [60955] by eric@webkit.org

5 edits in trunk

2010-06-10 Mike Belshe <mbelshe@chromium.org>

Reviewed by David Levin

Track whether a resource is loaded via a proxy.

https://bugs.webkit.org/show_bug.cgi?id=40312

platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaProxy): (WebCore::ResourceResponse::setWasFetchedViaProxy):

2010-06-10 Mike Belshe <mbelshe@google.com>

Reviewed by David Levin

Track whether a resource is loaded via a proxy.

https://bugs.webkit.org/show_bug.cgi?id=40312

public/WebURLResponse.h:
src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaProxy): (WebKit::WebURLResponse::setWasFetchedViaProxy):

6:44 AM Changeset in webkit [60954] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-06-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding the ANGLE project to the DEPS file as it's required
by the gpu-accelerated compositor.
https://bugs.webkit.org/show_bug.cgi?id=40379

DEPS:

6:31 AM Changeset in webkit [60953] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-10 Jungshik Shin <jshin@chromium.org>

Reviewed by Kent Tamura

Bug 38224 - [chromium] Enable rendering of Ethiopic, Lao, Tibetan

and a few other scripts on Win XP

https://bugs.webkit.org/show_bug.cgi?id=38224

Make it possible to specify a list of fonts for per-script
fallback instead of a single font per script. This is
necessary for Malayalam (for which Windows font doesn't
support Unicode 5.x fully on Vista or earlier), Ethiopic
(we want to support on XP with a 3rd party font because XP
doesn't have any Ethiopic font out of the box) and some other
scripts. This is a short-term 'fix' until we have per-script
font preferences.

No layout test is added because the test results would be
dependent on which fonts are present.

platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::): (WebCore::FontMap::ScriptToFontFamilies::):

4:23 AM Changeset in webkit [60952] by andreip@google.com

6 edits
3 adds in trunk

2010-06-09 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=40372

Use two variables to keep track of the number of arguments passed from JavaScript vs the number
of arguments passed to the corresponding C++ method. These numbers can be different since
the parameter declared via [CallWith] is generated in the bindings instead of being passed
from JavaScript.

The layout tests added here test both that the parameters are read correctly as well as
tests some basic indexed database functionality. There are also bindings specific
tests added in TestObj.idl.

storage/indexeddb/idb-objectstore-request-expected.txt: Added.
storage/indexeddb/idb-objectstore-request.html: Added.
storage/indexeddb/script-tests/idb-objectstore-request.js: Added. (openSuccess): (createSuccess): (createObjectStore): (doCreateOrOpen): (test):

2010-06-09 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

CodeGeneratorJS.pm incorrectly increments $paramIndex when a method is declared with [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=40372

Use two variables to keep track of the number of arguments passed from JavaScript vs the number
of arguments passed to the corresponding C++ method. These numbers can be different since
the parameter declared via [CallWith] is generated in the bindings instead of being passed
from JavaScript.

Test: storage/indexeddb/idb-objectstore-request.html

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::withScriptExecutionContext):
bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):

3:34 AM Changeset in webkit [60951] by morrita@google.com

11 edits
2 adds in trunk/WebCore

2010-06-09 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Simple shadow elements should be factored out .
https://bugs.webkit.org/show_bug.cgi?id=40400

Pulled ShadowElement class up from SliderThumbElement,
ProgressValueElement, ShadowInputElement.
And renamed ProgressValueElement to ShadowBlockElement.

No new tests. Because there is no functional change.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
rendering/RenderFileUploadControl.cpp:
rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState):
rendering/RenderProgress.h:
rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::SliderThumbElement::detach):
rendering/ShadowElement.cpp: Added. (WebCore::ShadowBlockElement::create): (WebCore::ShadowBlockElement::ShadowBlockElement): (WebCore::ShadowInputElement::create): (WebCore::ShadowInputElement::ShadowInputElement):
rendering/ShadowElement.h: Added. (WebCore::ShadowElement::ShadowElement): (WebCore::ShadowElement::isShadowNode): (WebCore::ShadowElement::shadowParentNode):

2:31 AM Changeset in webkit [60950] by eric@webkit.org

3 edits in trunk/WebKit

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

Another fix for Windows.

WebView.cpp:

2:21 AM Changeset in webkit [60949] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

Api/qwebframe.cpp:
- Include RenderLayer.h since it's used in this file.

2:14 AM Changeset in webkit [60948] by eric@webkit.org

2 edits in trunk/WebCore

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

Another fix for Qt.

page/Frame.h:
- Include CSSMutableStyleDeclaration.h since it's used by m_typingStyle = 0;

2:06 AM Changeset in webkit [60947] by eric@webkit.org

5 edits in trunk

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

More attempted build fixes for Tiger and Qt.

page/Frame.cpp:
page/Frame.h:

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

webkit/webkitwebinspector.cpp:
- Include RenderLayer.h

1:58 AM Changeset in webkit [60946] by eric@webkit.org

4 edits in trunk/WebCore

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

Add a few more RenderLayer.h includes to fix non-mac builds.

page/FrameView.cpp:
rendering/RenderObject.cpp:
rendering/RenderTreeAsText.cpp:

1:49 AM Changeset in webkit [60945] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2010-06-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Remove weakRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=40291

weakRandomNumber is used nowhere. Currently, WeakRandom is used instead.

wtf/RandomNumber.cpp:
wtf/RandomNumber.h:

1:35 AM Changeset in webkit [60944] by abarth@webkit.org

7 edits in trunk/LayoutTests

2010-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

fast/repaint/opacity-change-on-overflow-float.html depends on invalid HTML parsing
https://bugs.webkit.org/show_bug.cgi?id=40262

See comment in opacity-change-on-overflow-float.html to understand why
we made this goofy change.

fast/repaint/opacity-change-on-overflow-float.html:
html5lib/resources/webkit01.dat:
html5lib/runner-expected.txt:
html5lib/webkit-resumer-expected.txt:
platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt:

1:33 AM Changeset in webkit [60943] by eric@webkit.org

25 edits in trunk/WebCore

2010-06-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408

Cleaned up FrameView.h includes and then propagated the
cascade of includes to the necessary .cpp files.
This should reduce the set of files rebuilt every
time FrameView.h changes, and should also reduce the size
of some .o files.

No functional changes, thus no tests.

accessibility/AccessibilityRenderObject.cpp:
dom/ContainerNode.cpp:
dom/Document.cpp:
dom/Element.cpp:
dom/EventTarget.h:
dom/Node.cpp:
editing/EditorCommand.cpp:
editing/SelectionController.cpp:
html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::script):
- No need for this to be inline. Being inline required Frame.h in the header, which causes huge include cascade.
html/HTML5Tokenizer.h:
page/DragController.cpp:
page/EventHandler.cpp:
page/Frame.h:
page/FrameView.h:
page/PrintContext.cpp:
page/SpatialNavigation.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBlockLineLayout.cpp:
rendering/RenderImage.cpp:
rendering/RenderInline.cpp:
rendering/RenderObject.h:
rendering/RenderTextControlSingleLine.cpp:
rendering/RenderWidget.cpp:
rendering/SVGRenderSupport.cpp:

1:15 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

12:59 AM Changeset in webkit [60942] by Simon Hausmann

2 edits in trunk/WebKit/qt

REGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default
https://bugs.webkit.org/show_bug.cgi?id=40401

Patch by Andy Shaw <andy.shaw@nokia.com> on 2010-06-10
Reviewed by Simon Hausmann.

The correct pattern in Qt for Dnd events is to use acceptProposedAction() instead
of accept().

Api/qwebpage.cpp:

(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):

12:48 AM Changeset in webkit [60941] by abarth@webkit.org

10 edits
2 copies in trunk/WebCore

2010-06-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTML5 entity parser to its own file
https://bugs.webkit.org/show_bug.cgi?id=40406

Moving this algorithm to its own file better encapsulates its
dependencies and makes it callable from other parts of WebCore.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/HTML5EntityParser.cpp: Copied from WebCore/html/HTML5Lexer.cpp. (WebCore::): (WebCore::consumeHTML5Entity):
html/HTML5EntityParser.h: Copied from WebCore/html/HTML5Lexer.h.
html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::processEntity): (WebCore::HTML5Lexer::nextToken):
html/HTML5Lexer.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed