Timeline



Aug 9, 2010:

11:59 PM Changeset in webkit [65053] by yurys@chromium.org
  • 13 edits
    2 deletes in trunk

2010-08-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
​https://bugs.webkit.org/show_bug.cgi?id=43726

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: Removed.
  • inspector/InspectorFrontend.h: Removed.

2010-08-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
​https://bugs.webkit.org/show_bug.cgi?id=43726

  • http/tests/inspector/inspector-test.js: (notifyDone):
10:50 PM Changeset in webkit [65052] by loislo@chromium.org
  • 15 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove obsolete JS wrappers for did* methods.
​https://bugs.webkit.org/show_bug.cgi?id=43738

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/Callback.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptView.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
10:13 PM Changeset in webkit [65051] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix Qt/ARM again, this time including the other changed file.

9:00 PM Changeset in webkit [65050] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

eviewed by Ariya Hidayat.

[Qt] QtTestBrowser: proper set scene rect

When resizesToContents is ON scene's rect is set to the boundary of
the mainFrame. However, navigating to other web page should keep resizing
scene's rect according to the new document loaded. Patch addresses this issue.

Now resizesToContents and scrolling properly work on QtTestBrowser.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::contentsSizeChanged): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent):
  • QtTestBrowser/webview.h:
8:59 PM Changeset in webkit [65049] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: Clean up LauncherWindow code.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init(). (LauncherWindow::init): Fixed comments. (LauncherWindow::applyPrefs): Move the method around. (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
8:58 PM Changeset in webkit [65048] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.

It gets control+0 the same visual effect as control++ or control-.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::toggleZoomTextOnly):
8:57 PM Changeset in webkit [65047] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QtTestBrowser
make m_zoomLevels a static member.

Not all instances of LauncherWindow need its own m_zoomLevel.

  • QtTestBrowser/launcherwindow.cpp:
  • QtTestBrowser/launcherwindow.h:
8:43 PM Changeset in webkit [65046] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VIII.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:34 PM Changeset in webkit [65045] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VII.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:29 PM Changeset in webkit [65044] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Qt/ARM

C++ overload resolution I stab at thee

  • jit/JITInlineMethods.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):

8:27 PM Changeset in webkit [65043] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Qt build fix attempt VI.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:19 PM Changeset in webkit [65042] by oliver@apple.com
  • 19 edits
    1 add in trunk/JavaScriptCore

2010-08-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow an assembler/macroassembler to compact branches to more concise forms when linking
​https://bugs.webkit.org/show_bug.cgi?id=43745

This patch makes it possible for an assembler to convert jumps into a different
(presumably more efficient) form at link time. Currently implemented in the
ARMv7 JIT as that already had logic to delay linking of jumps until the end of
compilation already. The ARMv7 JIT chooses between either a 4 byte short jump
or a full 32-bit offset (and rewrites ITTT instructions as appropriate), so does
not yet produce the most compact form possible. The general design of the linker
should make it relatively simple to introduce new branch types with little effort,
as the linker has no knowledge of the exact form of any of the branches.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.cpp: Added. (JSC::): Record jump sizes
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::LinkRecord::LinkRecord): (JSC::ARMv7Assembler::LinkRecord::from): (JSC::ARMv7Assembler::LinkRecord::setFrom): (JSC::ARMv7Assembler::LinkRecord::to): (JSC::ARMv7Assembler::LinkRecord::type): (JSC::ARMv7Assembler::LinkRecord::linkType): (JSC::ARMv7Assembler::LinkRecord::setLinkType): Encapsulate LinkRecord fields so we can compress the values somewhat

(JSC::ARMv7Assembler::JmpSrc::JmpSrc):

Need to record the jump type now

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):

Need to pass the jump types

(JSC::ARMv7Assembler::executableOffsetFor):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::linkRecordSourceComparator):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::convertJumpTo):
(JSC::ARMv7Assembler::recordLinkOffsets):
(JSC::ARMv7Assembler::jumpsToLink):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::unlinkedCode):

Helper functions for the linker

(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::canBeShortJump):
(JSC::ARMv7Assembler::linkLongJump):
(JSC::ARMv7Assembler::linkShortJump):
(JSC::ARMv7Assembler::linkJumpAbsolute):

Moving code around for the various jump linking functions

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::beginUninterruptedSequence): (JSC::AbstractMacroAssembler::endUninterruptedSequence): We have to track uninterrupted sequences in any assembler that compacts branches as that's not something we're allowed to do in such sequences. AbstractMacroAssembler has a nop version of these functions as it makes the code elsewhere nicer.
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::trampolineAt): Updated these functions to adjust for any changed offsets in the linked code

(JSC::LinkBuffer::applyOffset):

A helper function to deal with the now potentially moved labels

(JSC::LinkBuffer::linkCode):

The new and mighty linker function

  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::beginUninterruptedSequence): (JSC::MacroAssemblerARMv7::endUninterruptedSequence): (JSC::MacroAssemblerARMv7::jumpsToLink): (JSC::MacroAssemblerARMv7::unlinkedCode): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::convertJumpTo): (JSC::MacroAssemblerARMv7::recordLinkOffsets): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::link): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::breakpoint): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::executableOffsetFor): (JSC::MacroAssemblerARMv7::inUninterruptedSequence): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):

All branches need to pass on their type now

  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::returnLastBytes):

We can't know ahead of time how much space will be necessary to
hold the linked code if we're compacting branches, this new
function allows us to return the unused bytes at the end of linking

  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
  • jit/JIT.h: (JSC::JIT::compile):

The JIT class now needs to take a linker offset so that recompilation
can generate the same jumps when using branch compaction.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emitSlow_op_mod):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): Update for new trampolineAt changes
  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::):
  • wtf/Platform.h:
8:18 PM Changeset in webkit [65041] by barraclough@apple.com
  • 3 edits in trunk/WebCore

Qt build fix attempt V.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

8:10 PM Changeset in webkit [65040] by barraclough@apple.com
  • 4 edits in trunk/WebCore

Qt build fix attempt IV.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

  • dom/XMLDocumentParserQt.cpp:

(WebCore::handleElementNamespaces):

7:58 PM Changeset in webkit [65039] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative chromium build fix.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::charactersAreAllASCII):

7:41 PM Changeset in webkit [65038] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

7:40 PM Changeset in webkit [65037] by mrowe@apple.com
  • 1 copy in tags/Safari-533.18.1

New tag.

7:35 PM Changeset in webkit [65036] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

7:24 PM Changeset in webkit [65035] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.18-branch

Merge r63772.

7:13 PM Changeset in webkit [65034] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix V.

  • tests/KURLTest.cpp:

(ComponentCase::TEST):

7:06 PM Changeset in webkit [65033] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix IV.

  • src/WebPageSerializerImpl.h:
6:59 PM Changeset in webkit [65032] by barraclough@apple.com
  • 4 edits in trunk

Qt build fix III.

JavaScriptCore:

  • wtf/text/WTFString.h:

WebCore:

  • css/CSSSelector.cpp:
6:47 PM Changeset in webkit [65031] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove error-prone external SegementedSubstring contructor
​https://bugs.webkit.org/show_bug.cgi?id=43752

There's a lot of code that assumes that SegmentedString takes ownership
of its substrings. For example, when the HTML parser pauses and
resumes asynchronously, it could explode if SegmentedString didn't own
its substrings.

Prior to this patch, there was a constructor that let
SegmentedSubstring use an external string buffer. It turns out it was
only used in a handful of places, but I'd rather pay the memcpy of
these small strings than risk having them used after free.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::parseComment):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString):
6:43 PM Changeset in webkit [65030] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative Qt build fix.

  • css/CSSSelector.cpp:
6:43 PM Changeset in webkit [65029] by weinig@apple.com
  • 13 edits in trunk

Add zoom support for injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=43759

Reviewed by Geoffrey Garen.

WebKit2:

Add SPI to change the zoom factor for a page.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(toZoomMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetZoomFactor):
(WKBundlePageSetZoomFactor):
(WKBundlePageSetZoomMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::zoomFactor):
(WebKit::WebPage::setZoomFactor):
(WebKit::WebPage::setZoomMode):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Use zoom factor SPI to implement zoom related eventSender functions.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.

LayoutTests:

  • platform/mac-wk2/Skipped: Remove now passing tests.
6:42 PM Changeset in webkit [65028] by barraclough@apple.com
  • 4 edits in trunk/WebKitTools

Speculative chromium build fix III.

  • DumpRenderTree/chromium/MockSpellCheck.h:
  • DumpRenderTree/chromium/NotificationPresenter.h:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost::addClearHeader):
(WebViewHost::clearHeaders):

6:37 PM Changeset in webkit [65027] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix II.

  • src/AssertMatchingEnums.cpp:
6:32 PM Changeset in webkit [65026] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

increase the number of test results that we save
​https://bugs.webkit.org/show_bug.cgi?id=43763

Now that we do incremental uploads, we can increase the number of
results that we save for ​http://test-results.appspot.com/dashboards/flakiness_dashboard.html.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
6:28 PM Changeset in webkit [65025] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Speculative gtk build fix.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handlePostReadFile):

6:24 PM Changeset in webkit [65024] by mrowe@apple.com
  • 1 edit in branches/safari-533.18-branch/WebCore/rendering/RenderLayerBacking.cpp

Build fix. Remove a static function that is no longer called.

6:22 PM Changeset in webkit [65023] by barraclough@apple.com
  • 2 edits in trunk/WebKit/chromium

Speculative chromium build fix.

  • public/WebCString.h:
5:55 PM Changeset in webkit [65022] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Qt build fix.

  • wtf/qt/StringQt.cpp:
5:38 PM Changeset in webkit [65021] by barraclough@apple.com
  • 504 edits in trunk

Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

Rubber stamped by Sam Weinig

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.h:
  • bindings/cpp/WebDOMCString.h:
  • bindings/cpp/WebDOMString.h:
  • bindings/gobject/ConvertToUTF8String.h:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JavaScriptCallFrame.h:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptSourceProvider.h:
  • bindings/js/ScriptString.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/v8/ScheduledAction.h:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bridge/c/c_utility.h:
  • css/CSSFontSelector.h:
  • css/CSSHelper.h:
  • css/CSSOMUtils.h:
  • css/CSSPrimitiveValue.h:
  • css/MediaList.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • css/WebKitCSSKeyframesRule.h:
  • dom/CheckedRadioButtons.h:
  • dom/DOMImplementation.h:
  • dom/DocumentMarker.h:
  • dom/DynamicNodeList.h:
  • dom/EventTarget.h:
  • dom/MessagePort.h:
  • dom/MessagePortChannel.h:
  • dom/NameNodeList.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/OptionGroupElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/SelectElement.h:
  • dom/ViewportArguments.h:
  • dom/make_names.pl:
  • editing/HTMLInterchange.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CollectionCache.h:
  • html/DOMFormData.h:
  • html/DataGridColumnList.h:
  • html/DateComponents.h:
  • html/FileStream.h:
  • html/FileStreamProxy.h:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):

  • html/HTMLCollection.h:
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.h:
  • html/HTMLParserQuirks.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptRunnerHost.h:
  • html/StepRange.h:
  • html/canvas/CanvasGradient.h:
  • html/canvas/CanvasNumberArray.h:
  • html/canvas/CanvasPattern.h:
  • inspector/InjectedScript.h:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorValues.h:
  • inspector/ScriptDebugListener.h:
  • loader/CachedResourceClient.h:
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/RedirectScheduler.h:
  • loader/SubframeLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveFactory.h:
  • loader/icon/IconDatabaseClient.h:
  • notifications/NotificationPresenter.h:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Console.h:
  • page/ContextMenuClient.h:
  • page/DOMSelection.h:
  • page/EditorClient.h:
  • page/EventHandler.h:
  • page/FrameView.h:
  • page/GeolocationPositionCache.h:
  • page/History.h:
  • page/Location.h:
  • page/Navigator.h:
  • page/NavigatorBase.h:
  • page/PluginHalterClient.h:
  • page/PrintContext.h:
  • page/SpeechInput.h:
  • page/SpeechInputListener.h:
  • page/animation/AnimationController.h:
  • platform/CookieJar.h:
  • platform/CrossThreadCopier.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/Language.h:
  • platform/Length.h:
  • platform/LinkHash.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.h:
  • platform/Logging.h:
  • platform/Pasteboard.h:
  • platform/PopupMenuClient.h:
  • platform/SearchPopupMenu.h:
  • platform/Widget.h:
  • platform/cf/BinaryPropertyList.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/cocoa/KeyEventCocoa.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontData.h:
  • platform/graphics/FontSelector.h:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Icon.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/Path.h:
  • platform/graphics/StringTruncator.h:
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cairo/FontPlatformData.h:
  • platform/graphics/cg/FontPlatformData.h:
  • platform/graphics/cg/ImageSourceCG.h:
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wince/MediaPlayerPrivateWince.h:
  • platform/graphics/wince/MediaPlayerProxy.h:
  • platform/graphics/wx/FontCustomPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/mac/PasteboardHelper.h:
  • platform/network/DNS.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.h:
  • platform/text/Hyphenation.h:
  • platform/text/LineEnding.h:
  • platform/text/TextCodec.h:
  • platform/text/TextEncoding.h:
  • platform/text/TextStream.h:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/WCDataObject.h:
  • platform/win/WebCoreTextRenderer.h:
  • plugins/DOMMimeType.h:
  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.h:
  • plugins/DOMPluginArray.h:
  • rendering/CounterNode.h:
  • rendering/HitTestResult.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.h:
  • rendering/TextControlInnerElements.h:
  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • storage/Storage.h:
  • storage/chromium/DatabaseObserver.h:
  • svg/SVGAnimatedTemplate.h:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGStylable.h:
  • svg/SVGTests.h:
  • svg/SVGTransformList.h:
  • svg/SVGTransformable.h:
  • svg/SVGVKernElement.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketHandshakeResponse.h:
  • wml/WMLErrorHandling.h:
  • wml/WMLPageState.h:
  • wml/WMLVariables.h:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:
  • workers/Worker.h:
  • workers/WorkerContextProxy.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerLocation.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerThread.h:
  • xml/DOMParser.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:
  • xml/XPathUtil.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/chromium:

  • public/WebCString.h:
  • public/WebString.h:
  • src/DOMUtilitiesPrivate.h:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.h:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebPageSerializerImpl.h:

WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.h:

WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.h:
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/WebBaseNetscapePluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebView/WebViewInternal.h:

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

  • COMVariantSetter.h:
  • MarshallingHelpers.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebHistory.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.h:
  • WebKitSupport/InspectorClientWx.h:

WebKit2:

  • UIProcess/PageClient.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:
5:25 PM Changeset in webkit [65020] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Nat Duca <​nduca@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Blue line visible at the right hand side of the window with accelerated compositor
​https://bugs.webkit.org/show_bug.cgi?id=43748

Correct the ortho projection matrix for the root layer, which was
too large by 0.5px in both width and height. For even view sizes,
this would cause the viewport to appear 1 pixel too small.

Fixing this requires removal of several 0.5 correction factors
that were previously added to compensate for the too-large viewport.

Finally, compute the translation for the root layer quad using
floating point rather than integer arithmetic. This avoids us losing
a key half-pixel of translation when the width of the window is odd.

To test, size window to even/odd dimensions. No blue line should be visible.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
5:24 PM Changeset in webkit [65019] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43465

Removed fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle
because StyleChange's applyFontColor, applyFontFace, and applyFontSize all return false
if there was no difference between the new font color, font size, font face and that of the computed style.

Also added a work-around for the bug 28282 in getPropertiesNotInComputedStyle with a test so that
the above change will not add a redundant font or span element.

Test: editing/style/fore-color-by-name.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getRGBAFontColor): Added. (WebCore::StyleChange::extractTextStyles): Calls getRGBAFontColor. (WebCore::getPropertiesNotInComputedStyle): Removes color property manually by checking the RGBA values. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): See above.

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43465

Added a test for applying execCommand('foreColor') by color name. Because of the bug 28282, we have to manually
process color property in getPropertiesNotInComputedStyle to avoid adding a redundant font or span element.

  • editing/style/fore-color-by-name-expected.txt: Added.
  • editing/style/fore-color-by-name.html: Added.
5:06 PM Changeset in webkit [65018] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-09 Kenneth Russell <​kbr@google.com>

Reviewed by David Levin.

Fix compilation of VideoLayerChromium on Mac OS X with compositor
​https://bugs.webkit.org/show_bug.cgi?id=43757

No new tests; build fix only (associated functionality not implemented yet).

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
  • platform/graphics/chromium/VideoLayerChromium.h:
5:00 PM Changeset in webkit [65017] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need to implement GraphicsContextQt::clipConvexPolygon()
​https://bugs.webkit.org/show_bug.cgi?id=41310

Based on the prototype code by Simon Hausmann.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
  • rendering/RenderObject.h:
4:45 PM Changeset in webkit [65016] by Chris Fleizach
  • 8 edits in trunk

AX: Placeholder value for text fields not exposed like it should be
​https://bugs.webkit.org/show_bug.cgi?id=43598

Reviewed by David Kilzer.

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::placeholderValue):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:
4:29 PM Changeset in webkit [65015] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] DRT error print statement incorrectly tries to print a FILE*
​https://bugs.webkit.org/show_bug.cgi?id=43747

  • DumpRenderTree/chromium/ImageDiff.cpp: (writeFile): pass the correct pointer.
4:25 PM Changeset in webkit [65014] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
​https://bugs.webkit.org/show_bug.cgi?id=43639

The bug was caused when RemoveCSSPropertyCommand is called with CSSMutableStyleDeclaration of some styled element,
and the style attribute of the element is removed subsequently. When the attribute removal is undone, new instance of
CSSMutableStyleDeclaration is created and RemoveCSSPropertyCommand's m_style became detached from the element.

Modified RemoveCSSPropertyCommand to store the styled element directly instead of its CSSMutableStyleDeclaration.

Test: editing/undo/remove-css-property-and-remove-style.html

  • WebCore.order:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): Calls removeCSSProperty. (WebCore::ApplyStyleCommand::extractTextDecorationStyle): Calls removeCSSProperty.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeCSSProperty): Takes StyledElement instead of CSSMutableStyleDeclaration.
  • editing/CompositeEditCommand.h:
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Takes StyledElement instead of CSSMutableStyleDeclaration. (WebCore::RemoveCSSPropertyCommand::doApply): See above. (WebCore::RemoveCSSPropertyCommand::doUnapply): See above.
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create): See above.

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
​https://bugs.webkit.org/show_bug.cgi?id=43639

Added a test to remove style attribute after removing a CSS property from the style.
Undo should restore both style attribute and the removed CSS property.

  • editing/undo/remove-css-property-and-remove-style-expected.txt: Added.
  • editing/undo/remove-css-property-and-remove-style.html: Added.
4:18 PM Changeset in webkit [65013] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-08-09 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Use getIdentifierValue to obtain direction and unicode-bidi properties in ApplyStyleCommand
​https://bugs.webkit.org/show_bug.cgi?id=43699

Deployed getIdentifierValue in various parts of ApplyStyleCommand where
direction and unicode-bidi properties were obtained manually.

No new tests since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: (WebCore::getIdentifierValue): Takes CSSStyleDeclaration instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls getIdentifierValue.
  • editing/ApplyStyleCommand.h:
4:06 PM Changeset in webkit [65012] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove trailing whitespace in HTMLViewSourceDocument.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43741

No behavior change. The whitespace was distracting me while porting
this class to the new parser.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
3:11 PM Changeset in webkit [65011] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-09 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

Upload incremental test results json to server by default.

​https://bugs.webkit.org/show_bug.cgi?id=43743

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:06 PM Changeset in webkit [65010] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-533.18-branch

Merge r64706.

2:59 PM Changeset in webkit [65009] by mrowe@apple.com
  • 7 edits in branches/safari-533.18-branch

Merge r64110.

2:59 PM Changeset in webkit [65008] by mrowe@apple.com
  • 4 edits in branches/safari-533.18-branch/WebKit/mac

Merge r62872.

2:59 PM Changeset in webkit [65007] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.18-branch

Merge r64095.

2:52 PM Changeset in webkit [65006] by eric@webkit.org
  • 18 edits in trunk

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
​https://bugs.webkit.org/show_bug.cgi?id=43586

  • html5lib/runner-expected.txt:
    • We pass 2 more tests now that the tokenizer is set to the right state before fragment parsing.
  • html5lib/runner-expected-html5.txt:
    • We pass 4 more tests now that HTML5 fragment parsing is (partially) implemented behind the --html5-treebuilder flag.

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Use the HTML5 TreeBuilder for Fragment Parsing
​https://bugs.webkit.org/show_bug.cgi?id=43586

The bulk of this change is just a transcription of the HTML5 spec:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#fragment-case

DocumentParser() now sets the right tokenizer state before handling
fragments. Since default code path uses the HTML5 tokenizer with the
legacy tree builder, this fixes 2 tokenizer-state tests for the html5lib.
This fixes 2 more tree-builder tests when the html5 treebuilder is enabled too.

  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
    • HTML5 implementation of fragment parsing requires the context element (parent) pointer. The legacy implementation handles all parsing branches which require the context element outside of the parser itself, which likely produces "wrong" results. We'll remove those branches when we turn on the HMTL5 fragment parser.

(WebCore::DocumentFragment::parseXML):

  • Rename "parent" to "contextElement" to match the HTML path (and the HTML5 spec).
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
    • Pass the contextElement (this).
  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::setForm):
    • Needed by for the fragment case.

(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

  • I'm not sure this method should exist, it only has one caller. but for now, I've moved the fragment case FIXME out to the one caller and implemented it.
  • html/HTMLConstructionSite.h:
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLNames::tokenizerStateForContextElement):
    • Part of the fragment case handling for the HTML5 parser.

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • Set the Tokenizer state based on the contextElement.

(WebCore::HTMLDocumentParser::parseDocumentFragment):

  • Take a contextElement argument.
  • html/HTMLDocumentParser.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML):
    • Added a FIXME before the branches the old parser used to avoid ever needing to pass a context element when parsing HTML fragments.

(WebCore::HTMLElement::insertAdjacentHTML):

  • Pass the context element.
  • html/HTMLTokenizer.h:
  • html/HTMLTreeBuilder.cpp:
    • I added a new helper class FragmentParsingContext to simplify the two HTMLTreeBuilder constructors and hide the existence of m_dummyDocumentForFragmentParse.
    • I also removed m_isParsingFragment and replaced it with an isParsingFragment() function.

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::~FragmentParsingContext):
(WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):

  • I had to implement two notImplemented() states in order to get most of the layout tests to pass when using the HTML5 parser fragment case.

(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):

  • The HTML5 parsing algorithm fragment case uses a dummy document to handle all the parsing and then moves all the children from the dummy document over into a DocumentFragment when the parse is done. We could avoid this adopt step by making the TreeBuilder a bit more complicated, but I'm not sure that's necessary (yet).
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::isParsingFragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): (WebCore::HTMLTreeBuilder::FragmentParsingContext::scriptingPermission):
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
2:36 PM Changeset in webkit [65005] by dumi@chromium.org
  • 34 edits
    4 deletes in trunk

WebCore: Auto-generate most HTML5 DB bindings.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp

and the custom implementations of openDatabase{Sync}().

  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDatabaseCustom.cpp: Removed.
  • bindings/js/JSDatabaseSyncCustom.cpp: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/scripts/CodeGeneratorGObject.pm: Change the code generators

to check that each value can be converted to the respective
argument type.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/custom/V8BindingMacros.h:
  • bindings/v8/V8Binding.h: Minor changes required to support the

auto-generated bindings.
(WebCore::V8Parameter::V8Parameter):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):

  • storage/Database.h:
  • storage/Database.idl:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl:
  • workers/WorkerContext.idl:

LayoutTests: Changing the expected error message for a test.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • fast/workers/storage/open-database-inputs-sync-expected.txt:
2:32 PM Changeset in webkit [65004] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild
​https://bugs.webkit.org/show_bug.cgi?id=43740

This removes the DTD checks, which aren't needed for view source
documents.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
2:29 PM Changeset in webkit [65003] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fixed an uninitialized member variable in the Color(CGColorRef) constructor.

Reviewed by Simon Fraser.

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::Color): Initialize m_valid to true if the color is not 0.

2:12 PM Changeset in webkit [65002] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Chromium compile fix, unreviewed.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
1:54 PM Changeset in webkit [65001] by jamesr@google.com
  • 4 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
​https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
1:44 PM Changeset in webkit [65000] by mrowe@apple.com
  • 5 edits in branches/safari-533.18-branch

Versioning.

1:41 PM Changeset in webkit [64999] by mrowe@apple.com
  • 1 copy in branches/safari-533.18-branch

New branch.

1:36 PM Changeset in webkit [64998] by zmo@google.com
  • 8 edits in trunk

2010-08-09 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43693

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): Don't generate GL errors. Generate them in the callers instead. (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate GL error if sizeInBytes fails.
  • html/canvas/WebGLRenderingContext.h: Make sizeInBytes private helper.
  • html/canvas/WebGLRenderingContext.idl: Remove sizeInBytes.

2010-08-09 Zhenyao Mo <​zmo@google.com>

Reviewed by David Levin.

sizeInBytes should be removed
​https://bugs.webkit.org/show_bug.cgi?id=43693

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Define sizeInBytes and don't use the WebGL one (it's been removed).
  • fast/canvas/webgl/gl-object-get-calls.html: Ditto.
  • fast/canvas/webgl/index-validation.html: Ditto.
1:29 PM Changeset in webkit [64997] by eric.carlson@apple.com
  • 10 edits in trunk

2010-08-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): RenderVideo::videoSizeChanged is gone, just use updateFromElement instead. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Clear the image loader and cached image when the 'poster' attribute is changed and we aren't displaying a poster.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::intrinsicSizeChanged): videoSizeChanged -> updateIntrinsicSize. (WebCore::RenderVideo::updateIntrinsicSize): Renamed from videoSizeChanged, calculate initial intrinsic size with calculateIntrinsicSize (WebCore::RenderVideo::calculateIntrinsicSize): New, calculate size according to current spec. (WebCore::RenderVideo::imageChanged): Reset intrinsic size to default when poster fails to load. (WebCore::RenderVideo::updatePlayer): Call updateIntrinsicSize.
  • rendering/RenderVideo.h: Renamed videoSizeChanged to updateIntrinsicSize and make private.

2010-08-09 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly

  • media/video-poster-expected.txt:
  • media/video-poster.html:
  • media/video-size-expected.txt:
  • media/video-size.html:
11:44 AM Changeset in webkit [64996] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Fixes custom JS bindings for IDBCursor after r64828.
​https://bugs.webkit.org/show_bug.cgi?id=43729

Build fix, no tests.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • storage/IDBObjectStore.h:
11:33 AM Changeset in webkit [64995] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

EWS bots wait 2 minutes between patches
​https://bugs.webkit.org/show_bug.cgi?id=43731

  • Scripts/webkitpy/tool/bot/queueengine.py:
    • Don't sleep after failures. This was a hold-over from an earlier design.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
    • EWS bots were not properly reporting true/false from process_work_item. They were always returning None, thus false, thus always logging as a failure and sleeping 2 minutes after each patch.
11:22 AM Changeset in webkit [64994] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-08-09 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64993.
​http://trac.webkit.org/changeset/64993
​https://bugs.webkit.org/show_bug.cgi?id=43734

broke chromium compile (Requested by jamesr on #webkit).

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
11:05 AM Changeset in webkit [64993] by jamesr@google.com
  • 4 edits in trunk/WebCore

2010-08-09 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
​https://bugs.webkit.org/show_bug.cgi?id=43656

When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.

To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.

  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
  • platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
11:01 AM Changeset in webkit [64992] by eric@webkit.org
  • 3 edits in trunk/WebKit2

2010-08-09 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] No need for PageClientImpl

​https://bugs.webkit.org/show_bug.cgi?id=43728

Remove PageClientImpl, take the implementation of WebKit::PageClient into QWKPagePrivate.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::toolTipChanged):
  • UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::pageDidEnterAcceleratedCompositing): (QWKPagePrivate::pageDidLeaveAcceleratedCompositing): (QWKPagePrivate::processDidExit): (QWKPagePrivate::processDidRevive): (QWKPagePrivate::setCursor): (QWKPagePrivate::takeFocus):
10:50 AM Changeset in webkit [64991] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-08-09 Dominic Cooney <​dominicc@google.com>

Reviewed by Adam Barth.

Moves window.open logic into the generic bindings.

This patch moves window.open logic from V8 into the generic
bindings so it could be shared with JSC. JSC sharing is not in
this patch. This patch is of the same flavor/intent as 33201.

​https://bugs.webkit.org/show_bug.cgi?id=41392

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open): (WebCore::::completeURL):
  • bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp): (WebCore::::shouldAllowNavigation):
  • bindings/v8/V8Binding.h: (WebCore::V8Binding::emptyScriptValue):
  • bindings/v8/V8Utilities.cpp: (WebCore::transferHiddenDependency): (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture):
  • bindings/v8/specialization/V8BindingState.h: (WebCore::):
10:39 AM Changeset in webkit [64990] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Skip the slow software rendering path of GraphicsContext3D if accelerated
compositing is active. This fixes an issue with WebGL and the compositor
in which the software rendering of WebGL would cause the current GL context
to change while the compositor was processing layers. Tested by running
several WebGL samples both with the compositor enabled and disabled.
​https://bugs.webkit.org/show_bug.cgi?id=43644

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::beginPaint):
10:36 AM Changeset in webkit [64989] by jianli@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Update chromium test results.

  • platform/chromium-mac/editing/selection/5076323-1-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/5076323-1-expected.png: Added.
  • platform/chromium/test_expectations.txt:
10:05 AM Changeset in webkit [64988] by jhawkins@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-06 James Hawkins <​jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=43648

  • public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
9:39 AM Changeset in webkit [64987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Darin Adler.

Fixes xcode project issues after r64828:
​https://bugs.webkit.org/show_bug.cgi?id=43638

Build fix, no tests (sort-Xcode-project-file should not throw any warnings).

  • WebCore.xcodeproj/project.pbxproj: fixed IDBCursor and related IndexedDB files, and re-ran sort-Xcode-project-file.
9:11 AM Changeset in webkit [64986] by loislo@chromium.org
  • 12 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove callId argument from all backend agents' methods.
​https://bugs.webkit.org/show_bug.cgi?id=43723

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::getDatabaseTableNames):
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource):
  • inspector/InspectorDebuggerAgent.h:
8:55 AM Changeset in webkit [64985] by weinig@apple.com
  • 11 edits
    3 adds in trunk

Stub out EventSender for WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=43703

WebKitTools:

Reviewed by Anders Carlsson.

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Add ability to pass javascript arguments to the wrapped object.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.

(WTR::EventSendingController::create):
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::~EventSendingController):
(WTR::EventSendingController::wrapperClass):
(WTR::setExceptionForString):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::contextClick):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
(WTR::EventSendingController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::eventSendingController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):
Add stubbed out EventSenderController.

  • WebKitTestRunner/InjectedBundle/GCController.h:

Remove incorrect comment.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

Add new files.

LayoutTests:

Reviewed by Anders Carlsson

  • platform/mac-wk2/Skipped: Update.
8:52 AM Changeset in webkit [64984] by eric@webkit.org
  • 7 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for mroot color handling.
​https://bugs.webkit.org/show_bug.cgi?id=43628

  • mathml/presentation/roots.xhtml:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Take into account style color to draw MathML mroot radical.
​https://bugs.webkit.org/show_bug.cgi?id=43628

Test: mathml/presentation/roots.xhtml

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
8:50 AM Changeset in webkit [64983] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-08-09 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus
​https://bugs.webkit.org/show_bug.cgi?id=43602

Only call gtk_im_context_focus_in() when we focus a frame which is currently in
an editable node.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in().
8:40 AM Changeset in webkit [64982] by eric@webkit.org
  • 8 edits in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add test for some deprecated MathML style attributes
​https://bugs.webkit.org/show_bug.cgi?id=43503

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement MathML deprecated style attributes
​https://bugs.webkit.org/show_bug.cgi?id=43503

Test: mathml/presentation/attributes.xhtml

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
  • mathml/mathattrs.in:
7:59 AM Changeset in webkit [64981] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove unnecessary did* methods from RemoteInspectorFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=43721

  • inspector/CodeGeneratorInspector.pm:
6:56 AM Changeset in webkit [64980] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-08-09 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

Canvas: Fast-path for setting the already set color with setStrokeColor() and setFillColor()
​https://bugs.webkit.org/show_bug.cgi?id=43718

Avoid creating CanvasStyle objects when setting the same fill or stroke color using
the WebKit-specific setters of CanvasRenderingContext2D.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
  • html/canvas/CanvasStyle.h: Added CanvasStyle::isEquivalentColor() overloads for RGBA and CMYKA channel values.
6:34 AM Changeset in webkit [64979] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

  • platform/chromium/test_expectations.txt:
6:00 AM Changeset in webkit [64978] by pfeldman@chromium.org
  • 4 edits in trunk

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore original last panel restore logic.

​https://bugs.webkit.org/show_bug.cgi?id=43719

  • inspector/front-end/inspector.js: (WebInspector.showPanel):
5:23 AM Changeset in webkit [64977] by pfeldman@chromium.org
  • 5 edits in trunk

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

  • src/js/Tests.js: (.TestSuite.prototype.testShowStoragePanel.this): (.TestSuite.prototype.testShowStoragePanel):

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

Chromium: provisional interactive ui tests fix.

  • http/tests/inspector/inspector-test.js: (frontend_setupTestEnvironment):
  • inspector/elements-panel-limited-children.html:
4:57 AM Changeset in webkit [64976] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Unreviewed, fixing the builds after r64967.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
4:48 AM Changeset in webkit [64975] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium tests fix.

Disable runtime switch for device motion in chromium.
​https://bugs.webkit.org/show_bug.cgi?id=43717

  • src/WebViewImpl.cpp: (WebKit::WebView::create):
4:40 AM Changeset in webkit [64974] by morrita@google.com
  • 7 edits
    3 adds in trunk

2010-05-20 MORITA Hajime <​morrita@google.com>

Reviewed by Ojan Vafai.

<​http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.
<​http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.

  • editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt: Added.
  • editing/selection/doubleclick-inline-first-last-contenteditable.html: Added.
  • editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js: Added.

2010-05-27 MORITA Hajime <​morrita@google.com>

Reviewed by Ojan Vafai.

<​http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.
<​http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.

nextBoundary() and previousBoundary() assumed that editable
boundaries are on block-level elements, But it can appear on
inline-level elements. So we start boundary look-up from the given
node, instead of the containingBlock of the given node.
Also, added TextIteratorEndsAtEditingBoundary to
BackwardsCharacterIterator, otherwise, the VisiblePosition
returned by BackwardsCharacterIterator might cross an editing
boundary.

Test: editing/selection/doubleclick-inline-first-last-contenteditable.html

  • dom/Position.cpp: (WebCore::Position::parentEditingBoundary): Added.
  • dom/Position.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::crossesEditingBoundary): Added. (WebCore::SimplifiedBackwardsTextIterator::setCurrentNode): Added. (WebCore::SimplifiedBackwardsTextIterator::clearCurrentNode): Added. (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
  • editing/TextIterator.h: (WebCore::):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):
4:26 AM Changeset in webkit [64973] by loislo@chromium.org
  • 19 edits in trunk

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
​https://bugs.webkit.org/show_bug.cgi?id=43711

  • WebCore.exp.in:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.toggleSearchingForNode): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.showProfileForURL):

2010-08-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
​https://bugs.webkit.org/show_bug.cgi?id=43711

  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-proto-property.html:
  • inspector/elements-panel-limited-children.html:
3:50 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:24 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:17 AM MathML 3 testsuite results edited by François Sausset
(diff)
2:48 AM Changeset in webkit [64972] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-09 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: Remove temporary device motion fix.

​https://bugs.webkit.org/show_bug.cgi?id=43713

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
2:36 AM Changeset in webkit [64971] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2010-08-09 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::clipOut(IntRect) ignores the transformation matrix.
​https://bugs.webkit.org/show_bug.cgi?id=43705

Just like clipOut(Path), which is taken care in r60796 already,
clipOut(IntRect) must transform the window bounding box properly.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut):
2:18 AM Changeset in webkit [64970] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Drop SLOW as SLOW and TIMEOUT isn't allowed.
2:14 AM Changeset in webkit [64969] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Mark http/tests/misc/bad-charset-alias as a slow test.
1:49 AM Changeset in webkit [64968] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-09 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's expectation.

  • platform/chromium/test_expectations.txt: Mark fast/parser/residual-style-hang as a slow test.
1:33 AM QtWebKitMediaElementSupport edited by Henry Haverinen
(diff)
12:53 AM Changeset in webkit [64967] by eric@webkit.org
  • 20 edits
    6 adds in trunk

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add a test for the mfenced MathML element and update tests with stretched parenthesis/brackets/operators
​https://bugs.webkit.org/show_bug.cgi?id=42472

  • mathml/presentation/fenced.xhtml: Added.
  • mathml/presentation/row.xhtml:
  • platform/mac/mathml/presentation/fenced-expected.checksum: Added.
  • platform/mac/mathml/presentation/fenced-expected.png: Added.
  • platform/mac/mathml/presentation/fenced-expected.txt: Added.
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:

2010-08-09 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement mfenced MathML element
Update stretchy operator code to take into account new brackets and to tune layout parameters
​https://bugs.webkit.org/show_bug.cgi?id=42472

Test: mathml/presentation/fenced.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement): (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLFenced.cpp: Added. (WebCore::RenderMathMLFenced::RenderMathMLFenced): (WebCore::RenderMathMLFenced::updateFromElement): (WebCore::RenderMathMLFenced::makeOperatorStyle): (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::addChild): (WebCore::RenderMathMLFenced::layout):
  • mathml/RenderMathMLFenced.h: Added.
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::RenderMathMLOperator): (WebCore::RenderMathMLOperator::stretchToHeight): (WebCore::): (WebCore::RenderMathMLOperator::updateFromElement): (WebCore::RenderMathMLOperator::createStackableStyle): (WebCore::RenderMathMLOperator::createGlyph):

Aug 8, 2010:

11:56 PM Changeset in webkit [64966] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Darin Adler.

REGRESSION(64898,64949) build break because of wrong filename
​https://bugs.webkit.org/show_bug.cgi?id=43701

add SVGPathStringSource.cpp and modify SVGPathSourceString.cpp to
SVGPathStringSource.cpp

simple fixing build break, so No new tests.

  • CMakeLists.txt:
10:47 PM Changeset in webkit [64965] by ariya@webkit.org
  • 15 edits in trunk

2010-08-08 Ariya Hidayat <​ariya@sencha.com>

Reviewed by Antonio Gomes.

Inconsistent Qt version checks
​https://bugs.webkit.org/show_bug.cgi?id=43695

Use QT_VERSION_CHECK macro instead of encoded hex.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebViewPrivate::detachCurrentPage):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery): (QWebPage::view):
  • Api/qwebview.cpp: (QWebViewPrivate::detachCurrentPage):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/PageClientQt.h:
10:43 PM Changeset in webkit [64964] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43698

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): Add suggested parentheses.
10:26 PM Changeset in webkit [64963] by morrita@google.com
  • 10 edits
    3 adds in trunk

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • editing/pasteboard/paste-text-events-expected.txt: Added.
  • editing/pasteboard/paste-text-events.html: Added.
  • editing/pasteboard/script-tests/paste-text-events.js: Added.

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

  • Extended TextEvents to hold paste-specific parameters
  • Did fire TextEvents at where we originally did immediate pastes.
  • Factored out TextEvent handling from EventHandler::defaultTextInputEventHandler() to Editor::handleTextEvent() because it's solely done by the editor.
  • move actual pasting logic to Editor::handleTextEvent()

Test: editing/pasteboard/paste-text-events.html

  • WebCore.exp.in:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isPaste): (WebCore::TextEvent::shouldSmartReplace): (WebCore::TextEvent::shouldMatchStyle): (WebCore::TextEvent::pastingFragment):
  • editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::findEventTargetFromSelection):
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):

2010-08-04 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Pasting should fire textInput event.
​https://bugs.webkit.org/show_bug.cgi?id=42958

On paste, invoke Editor instead of direct command invocation,
which allows dispatching events before actual paste.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
9:29 PM Changeset in webkit [64962] by morrita@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-05 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Should have test: textInput should not fired when preceding key events are cancelled.
​https://bugs.webkit.org/show_bug.cgi?id=43601

  • fast/events/inputText-never-fired-on-keydown-cancel-expected.txt: Added.
  • fast/events/inputText-never-fired-on-keydown-cancel.html: Added.
  • fast/events/script-tests/inputText-never-fired-on-keydown-cancel.js: Added. (handleTextInput): (mayCancel): (setup): (test):
9:05 PM Changeset in webkit [64961] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, trivial fix.

Fix "WindowsError: [Error 32] The process cannot access the file
because it is being used by another process" introduced by r64959.

  • BuildSlaveSupport/test-result-archive:
7:16 PM Changeset in webkit [64960] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
6:26 PM Changeset in webkit [64959] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium buildbot: Avoid "zip" command dependency
​https://bugs.webkit.org/show_bug.cgi?id=43470

Reviewed by Tony Chang.

  • BuildSlaveSupport/test-result-archive: For Chromium port, creates a zip archive with zipfile package of Python instead of external "zip" command. We'd like to avoid additional command installation.
6:12 PM Changeset in webkit [64958] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, add member needed to compile Mac-specific font code.

3:27 PM Changeset in webkit [64957] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

[Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h
​https://bugs.webkit.org/show_bug.cgi?id=43360

  • platform/WindowsKeyboardCodes.h: Undef macros which are also defined in MinGW/include/winuser.h to aviod gcc redefinition warning
1:30 PM Changeset in webkit [64956] by jamesr@google.com
  • 9 edits in trunk/LayoutTests

2010-08-08 James Robinson <​jamesr@chromium.org>

Unreviewed. Rebaseline chromium results for r64954.

  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/invalid/003-expected.txt:
  • platform/chromium-win/fast/invalid/019-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium/test_expectations.txt:
1:24 PM Changeset in webkit [64955] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Add more items to WebKit2 skipped list.

Rubber stamped by Sam Weinig.

  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [64954] by jamesr@google.com
  • 11 edits in trunk

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
builder's adoption agency flag. This is a speedup assuming that nodes subjected
to the adoption agency are likely to be frequently reparented, and thus it is better
to delay creating the render tree until later (when hopefully the DOM is finalized).

On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

New baselines for tests where the render tree depends on 0x0 render objects being
created/destroyed during adoption agency fixups.

  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/invalid/003-expected.txt:
  • platform/mac/fast/invalid/019-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug647-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
10:56 AM Changeset in webkit [64953] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

fast/events/onunload-back-to-page-cache.html does not pass with GTK DRT
​https://bugs.webkit.org/show_bug.cgi?id=43692

Update onunload-back-to-page-cache.html to set the frame name later,
so that the onunload handler console message doesn't have it. Also
include a message about what exactly we're testing.

  • fast/events/onunload-back-to-page-cache-expected.txt:
  • fast/events/script-tests/onunload-back-to-page-cache.js: (onpageshow):
10:45 AM Changeset in webkit [64952] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: speed-up Element.prototype.removeChildren
​https://bugs.webkit.org/show_bug.cgi?id=43687

  • inspector/front-end/utilities.js: (Element.prototype.removeChildren):
9:47 AM Changeset in webkit [64951] by loislo@chromium.org
  • 11 edits in trunk/WebCore

2010-08-08 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: remove hand written InspectorFrontend from almost all places.
​https://bugs.webkit.org/show_bug.cgi?id=43630

  • inspector/ConsoleMessage.cpp:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
  • inspector/InjectedScriptHost.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::evaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/TimelineRecordFactory.cpp:
9:41 AM Changeset in webkit [64950] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Chromium Mac build after r64915.

  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm:

(WebCore::FontPlatformData::ctFont): Copied from mac/FontPlatformDataMac.mm.

9:10 AM Changeset in webkit [64949] by krit@webkit.org
  • 18 edits
    2 adds in trunk/WebCore

2010-08-08 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add missing String builder for SVGPathParser
​https://bugs.webkit.org/show_bug.cgi?id=43682

Introduces SVGPathStringBuilder. SVGPathParser clients, like normalized and unaltered
SVGPathSegLists or SVGPathByteStreams, can be parsed and transformed to a string.
StringBuilder can create a string of individual strings, seperated by spaces now.
Share more code in SVGPathParserFactory and use a common general concept to manage SVG path
data parsing.

Doesn't affect any tests.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString): Added possibility to use a space between individual strings.
  • platform/text/StringBuilder.h: Cleanup according to WebKit style. (WebCore::): (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::setNonNull): (WebCore::StringBuilder::isNull):
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::cleanup): Clear all references.
  • svg/SVGPathByteStreamBuilder.h: (WebCore::SVGPathByteStreamBuilder::cleanup): dito.
  • svg/SVGPathConsumer.h:
  • svg/SVGPathParser.cpp: (WebCore::SVGPathParser::cleanup): dito.
  • svg/SVGPathParser.h:
  • svg/SVGPathParserFactory.cpp: Cleanup of factory. More code get shared. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathByteStreamBuilder): (WebCore::globalSVGPathStringBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathStringBuilder.cpp: Added. Build string from parsed SVG data. (WebCore::SVGPathStringBuilder::SVGPathStringBuilder): (WebCore::SVGPathStringBuilder::moveTo): (WebCore::SVGPathStringBuilder::lineTo): (WebCore::SVGPathStringBuilder::lineToHorizontal): (WebCore::SVGPathStringBuilder::lineToVertical): (WebCore::SVGPathStringBuilder::curveToCubic): (WebCore::SVGPathStringBuilder::curveToCubicSmooth): (WebCore::SVGPathStringBuilder::curveToQuadratic): (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth): (WebCore::SVGPathStringBuilder::arcTo): (WebCore::SVGPathStringBuilder::closePath):
  • svg/SVGPathStringBuilder.h: Added. (WebCore::SVGPathStringBuilder::cleanup): (WebCore::SVGPathStringBuilder::result):
1:32 AM Changeset in webkit [64948] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKitTools

WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
​https://bugs.webkit.org/show_bug.cgi?id=43686

Reviewed by Dan Bernstein.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().

  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Link to shlwapi.lib for SHGetValue.

1:07 AM Changeset in webkit [64947] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069)
​https://bugs.webkit.org/show_bug.cgi?id=43040

The pointer from Document to Frame can be null. See ​http://webkit.org/coding/major-objects.html.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:55 AM Changeset in webkit [64946] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

frame()->selection() can't be null
​https://bugs.webkit.org/show_bug.cgi?id=43681

SelectionController is a component of Frame. If frame is non-null, it
can't possibly be null.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive):
12:45 AM Changeset in webkit [64945] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

Send invalid input to trigger old ASSERTs.

  • svg/dom/svg-length-units-expected.txt: Added.
  • svg/dom/svg-length-units.html: Added.

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

SVGLength uses ASSERTs to validate user input
​https://bugs.webkit.org/show_bug.cgi?id=43680

ASSERTs aren't in release builds, so we can't use them to validate user
input! We've seen a bunch of examples of this in SVG code. It might
be worth auditing all the code to remove this misguided pattern.

Test: svg/dom/svg-length-units.html

  • svg/SVGLength.cpp: (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits):
12:33 AM Changeset in webkit [64944] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-08 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Chromium: isindex tests timeout after r64712
​https://bugs.webkit.org/show_bug.cgi?id=43543

Update isindex tests/expectactions after r64712 so that even though they
stil fail, they fail immediately instead of timing out.

  • http/tests/misc/isindex-formdata-expected.txt:
  • http/tests/misc/isindex-formdata.html:
  • http/tests/misc/isindex-with-no-form-base-href-expected.txt:
  • http/tests/misc/resources/isindex-with-no-form-base-href.html:
12:22 AM Changeset in webkit [64943] by eric@webkit.org
  • 21 edits
    1 delete in trunk/JavaScriptCore

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64938.
​http://trac.webkit.org/changeset/64938
​https://bugs.webkit.org/show_bug.cgi?id=43685

Did not compile on several ports (Requested by abarth on
#webkit).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
  • jit/JIT.h:
  • jit/JITMarkObjects.cpp: Removed.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
  • wtf/Platform.h:

Aug 7, 2010:

11:58 PM Changeset in webkit [64942] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Empty strings can have more than one ref
​https://bugs.webkit.org/show_bug.cgi?id=43666

These asserts are trying to say that we have a thread-safe copy of the
string, but they're not accurate for empty strings because we use a
special static empty string that magically has infinite refs.

  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::addDatabase): (WebCore::OriginUsageRecord::markDatabase):
11:45 PM Changeset in webkit [64941] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Add KURL parameter to WMLDocument::create()
​https://bugs.webkit.org/show_bug.cgi?id=43173

To fix build break in WML, url parameter is added. Because,
Document class has url parameter.

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
  • wml/WMLDocument.h: (WebCore::WMLDocument::create): Add an url parameter to create() method
11:32 PM Changeset in webkit [64940] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Change getIDAttribute() with getIdAttribute()
​https://bugs.webkit.org/show_bug.cgi?id=43175

Change getIDAttribute() with getIdAttribute() because function
name was changed.

  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::findNamedCardInDocument): Change getIDAttribute() with getIdAttribute().
11:19 PM Changeset in webkit [64939] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-08-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

WebTiming does not take page cache into account
​https://bugs.webkit.org/show_bug.cgi?id=42772

Adds tests that simulates flow from a page that's in the page cache to
one that's not, and then back to the page cached page (where the
DocumentLoader is reused, but we should have a new DocumentLoadTiming
struct).

  • fast/events/onunload-back-to-page-cache-expected.txt: Added.
  • fast/events/onunload-back-to-page-cache.html: Added.

2010-08-07 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

WebTiming does not take page cache into account
​https://bugs.webkit.org/show_bug.cgi?id=42772

When restoring a page from the page cache, reset its DocumentLoadTiming
struct and record navigationStart.

Test: fast/events/onunload-back-to-page-cache.html

  • loader/DocumentLoadTiming.h: removed Noncopyable, since it's just a simple struct.
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::resetTiming): Added method.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Uncommented assert. (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): Added resetTiming() call.
11:04 PM Changeset in webkit [64938] by eric@webkit.org
  • 21 edits
    1 add in trunk/JavaScriptCore

2010-08-07 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

The JIT code contains a number of direct references to GC'd objects.
When we have movable objects, these references will need to be
updated.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::int32AtLocation): (JSC::AbstractMacroAssembler::pointerAtLocation): (JSC::AbstractMacroAssembler::jumpTarget):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithPatch):

Normally, loadPtr will optimize when the register is eax. Since
the slightly smaller instruction changes the offsets, it messes up
our ability to repatch the code. We added this new instruction
that garuntees a constant size.

  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32WithPatch):

Changed load32 in the same way described above.

(JSC::MacroAssemblerX86::load32):

Moved the logic to optimize laod32 from movl_mr to load32

(JSC::MacroAssemblerX86::store32):

Moved the logic to optimize store32 from movl_rm to store32

  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::int32AtLocation): (JSC::X86Assembler::pointerAtLocation): (JSC::X86Assembler::jumpTarget):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/Instruction.h:

As described in StructureStubInfo.h, we needed to add additional
fields to both StructureStubInfo and
PolymorphicAccessStructureList so that we can determine the
structure of the JITed code at patch time.

(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::markAggregate):

Added this function to mark the JITed code that correosponds to
this structure stub info.

  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
  • jit/JIT.h:
  • jit/JITMarkObjects.cpp: Added. (JSC::JIT::patchPrototypeStructureAddress): (JSC::JIT::patchGetDirectOffset): (JSC::JIT::markGetByIdProto): (JSC::JIT::markGetByIdChain): (JSC::JIT::markGetByIdProtoList): (JSC::JIT::markPutByIdTransition): (JSC::JIT::markGlobalObjectReference):
  • jit/JITPropertyAccess.cpp:

Added asserts for the patch offsets.

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
  • wtf/Platform.h:

Added ENABLE_MOVABLE_GC_OBJECTS flag

10:29 PM Changeset in webkit [64937] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-08-07 Michael Saboff <​msaboff@apple.com>

Reviewed by Geoffrey Garen.

Revert JSArray to point to the beginning of the contained ArrayStorage
struct. This is described in
​https://bugs.webkit.org/show_bug.cgi?id=43526.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::~JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::getOwnPropertyNames): (JSC::JSArray::getNewVectorLength): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::increaseVectorPrefixLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::shiftCount): (JSC::JSArray::unshiftCount): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting): (JSC::JSArray::subclassData): (JSC::JSArray::setSubclassData): (JSC::JSArray::checkConsistency):
  • runtime/JSArray.h: (JSC::JSArray::length): (JSC::JSArray::canGetIndex): (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
10:01 PM Changeset in webkit [64936] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for EventHandlingState struct
​https://bugs.webkit.org/show_bug.cgi?id=43548

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

struct name - instantiated at: WebCore/
EventHandlingState - html/HTMLInputElement.cpp:2051

  • html/HTMLInputElement.cpp:
9:47 PM Changeset in webkit [64935] by eric@webkit.org
  • 5 edits in trunk

2010-08-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Remove unecessary focus code.
​https://bugs.webkit.org/show_bug.cgi?id=43542

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):

2010-08-07 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Eric Seidel.

Removed unecessary focus code.
​https://bugs.webkit.org/show_bug.cgi?id=43542

  • src/ChromiumBridge.cpp:
8:55 PM Changeset in webkit [64934] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-07 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

Add ENABLE(YARR) guard around JSGlobalData::m_regexAllocator
​https://bugs.webkit.org/show_bug.cgi?id=43399

m_regexAllocator is used only by RegExp::compile which is guarded with ENABLE(YARR).

  • runtime/JSGlobalData.h:
8:25 PM Changeset in webkit [64933] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-07 Patrick Roland Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

[Qt] Enable JIT on WinCE
​https://bugs.webkit.org/show_bug.cgi?id=43303

Add ExtraCompiler for generating GeneratedJITStubs_MSVC.asm.

  • DerivedSources.pro:
8:13 PM Changeset in webkit [64932] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Include FormDataBuilder.h in WMLGoElement.h
​https://bugs.webkit.org/show_bug.cgi?id=43177

To fix build breaks in WMLGoElement.cpp, FormDataBuilder.h needs to be included.

  • wml/WMLGoElement.cpp: Include FormDataBuilder.h
8:00 PM Changeset in webkit [64931] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=43176

  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::defaultEventHandler): Sets NULL parameter to SelectElement::defaultEventHandler.
7:38 PM Changeset in webkit [64930] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[WML] Change DocumentParser with ScriptableDocumentParser in WMLDocument
​https://bugs.webkit.org/show_bug.cgi?id=43174

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing): Change DocumentParser with ScriptableDocumentParser.
7:22 PM Changeset in webkit [64929] by weinig@apple.com
  • 7 edits in trunk

WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
​https://bugs.webkit.org/show_bug.cgi?id=42683

Reviewed by Maciej Stachowiak.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):

LayoutTests:

  • platform/mac-wk2/Skipped:
6:59 PM Changeset in webkit [64928] by weinig@apple.com
  • 9 edits in trunk

WebKitTestRunner needs to print onunload handler information
<rdar://problem/8213831>
​https://bugs.webkit.org/show_bug.cgi?id=42703

Reviewed by Anders Carlsson.

WebKit2:

Add SPI to get the number of pending unload events.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetPendingUnloadCount):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::pendingUnloadCount):

  • WebProcess/WebPage/WebFrame.h:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::operator<<):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

LayoutTests:

  • platform/mac-wk2/Skipped:
4:26 PM Changeset in webkit [64927] by weinig@apple.com
  • 9 edits in trunk

Add additional loader client functions need to complete WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=43684

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):

WebKitTools:

Remove unnecessary and jarring underscores as well.

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didClearWindowObjectForFrame):
(didCreatePage):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3:47 PM Changeset in webkit [64926] by mitz@apple.com
  • 2 edits in trunk/WebCore

Use ctFont() to get the CTFont.

Reviewed by Sam Weinig.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

3:40 PM Changeset in webkit [64925] by abarth@webkit.org
  • 2 edits
    2 adds in trunk

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

document->documentElement can always be null
​https://bugs.webkit.org/show_bug.cgi?id=43677

This ASSERT is bogus.

  • css/StyleMedia.cpp: (WebCore::StyleMedia::matchMedium):
3:32 PM Changeset in webkit [64924] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another fix for the windows build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):

3:26 PM Changeset in webkit [64923] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references

to JSGCController.{cpp,h} relative to the build root.

3:25 PM Changeset in webkit [64922] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix windows build.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::platformLayer):

  • WebProcess/Plugins/PluginView.h:
2:42 PM Changeset in webkit [64921] by weinig@apple.com
  • 17 edits
    3 adds in trunk

WebKitTestRunner needs GCController
<rdar://problem/8213834>
​https://bugs.webkit.org/show_bug.cgi?id=42701

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleGarbageCollectJavaScriptObjects):
(WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WKBundleGetJavaScriptObjectsCount):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::garbageCollectJavaScriptObjects):
(WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WebKit::InjectedBundle::javaScriptObjectsCount):

  • WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

  • WebKitTestRunner/DerivedSources.make:
  • WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:

(WTR::setProperty):

  • WebKitTestRunner/InjectedBundle/GCController.cpp: Added.

(WTR::GCController::create):
(WTR::GCController::GCController):
(WTR::GCController::~GCController):
(WTR::GCController::wrapperClass):
(WTR::GCController::collect):
(WTR::GCController::collectOnAlternateThread):
(WTR::GCController::getJSObjectCount):
(WTR::GCController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/GCController.h: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::bundle):
(WTR::InjectedBundle::gcController):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::keepWebHistory):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:

LayoutTests:

  • platform/mac-wk2/Skipped: Remove now passing tests and add some failing tests.
2:41 PM Changeset in webkit [64920] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/8285090> First word on a line doesn’t hyphenate properly
​https://bugs.webkit.org/show_bug.cgi?id=43679

Reviewed by Anders Carlsson.

WebCore:

Test: fast/text/hyphenate-first-word.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): The character at lastSpace is not necessarily a whitespace character
before the current word. It can also be part of the word, such as when the word is the first
one on the line. Include the charcater at lastSpace in the string passed to lastHyphenLocation().

LayoutTests:

  • fast/text/hyphenate-first-word.html: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/mac/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/mac/fast/text/hyphenate-locale-expected.checksum:
  • platform/mac/fast/text/hyphenate-locale-expected.png:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
1:54 PM Changeset in webkit [64919] by andersca@apple.com
  • 9 edits in trunk/WebKit2

CA drawing model support for Mac Plugins
​https://bugs.webkit.org/show_bug.cgi?id=43678
<rdar://problem/7929701>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle WKNVSupportsCompositingCoreAnimationPluginsBool and
NPNVsupportsCoreAnimationBool and return true if accelerated compositing is enabled.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
Call PluginController::isAcceleratedCompositingEnabled.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
If the plug-in uses the Core Animation drawing model, ask it for its layer.

(WebKit::NetscapePlugin::platformPaint):
Don't send draw events if the Core Animation drawing model is used.

(WebKit::NetscapePlugin::pluginLayer):
Return the plug-in layer.

  • WebProcess/Plugins/Plugin.h:

Add a pluginLayer pure virtual member function.

  • WebProcess/Plugins/PluginController.h:

Add an isAcceleratedCompositingEnabled pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
If the plug-in has a layer, enter compositing mode.

(WebKit::PluginView::platformLayer):
Ask the plug-in for its layer.

(WebKit::PluginView::isAcceleratedCompositingEnabled):
Call Settings::acceleratedCompositingEnabled.

  • WebProcess/Plugins/PluginView.h:
1:45 PM Changeset in webkit [64918] by weinig@apple.com
  • 10 edits in trunk/WebKit2

Delete key doesn't go Back in WebKit2
<rdar://problem/8272978>
​https://bugs.webkit.org/show_bug.cgi?id=43665

Reviewed by Anders Carlsson.

  • Adds support for delete key going back (mac only for now)
  • Adds support for command-left/command right going back/forward
  • Flesh out scrolling due to arrow keys on the mac to match old webkit.
  • Made performDefaultBehaviorForKeyEvent platform specific and added a boolean return value which will be used later to inform the UI process about what events have been processed.
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _wantsKeyDownForEvent:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::forwardItem):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

1:07 PM Changeset in webkit [64917] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKitTools/QtTestBrowser/launcherwindow.cpp

2010-08-07 Antonio Gomes <​tonikitoo@webkit.org>

Another unreviewed missing bit of r64673

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
12:18 PM Changeset in webkit [64916] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • platform/graphics/SimpleFontData.h:
11:59 AM Changeset in webkit [64915] by mitz@apple.com
  • 12 edits in trunk

Created a separate SimpleFontData constructor exclusively for SVG fonts and moved the CTFontRef
from SimpleFontData to FontPlatformData.
​https://bugs.webkit.org/show_bug.cgi?id=43674

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/Platform.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI here from WebCore/config.h.

WebCore:

  • config.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI from here to wtf/Platform.h.
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Use new SimpleFontData constructor for SVG fonts.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Separated into two constructors, one for
PlatformFontData-based fonts and one for SVG fonts.

  • platform/graphics/SimpleFontData.h: Moved the m_CTFont member variable and the getCTFont()

accessor from here…

  • platform/graphics/mac/FontPlatformData.h: …to here, renaming the latter ctFont().
  • platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Copy m_CTFont.
(WebCore::FontPlatformData::operator=): Copy m_CTFont.
(WebCore::FontPlatformData::setFont): Clear m_CTFont.
(WebCore::FontPlatformData::ctFont): Moved here from SimpleFontDataCoreText.cpp and renamed.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes): Updated to use FontPlatformData::ctFont().

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::SVGFontData): Added an assertion.

11:00 AM Changeset in webkit [64914] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos in the change log

10:52 AM Changeset in webkit [64913] by abarth@webkit.org
  • 6 edits in trunk

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Regression: Memory corruption in tree builder
​https://bugs.webkit.org/show_bug.cgi?id=43672

Turns out this ASSERT was wrong and we need the branch. Yay for
test-driven development.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-07 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Regression: Memory corruption in tree builder
​https://bugs.webkit.org/show_bug.cgi?id=43672

  • html5lib/resources/adoption02.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
10:34 AM Changeset in webkit [64912] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Bitmap.h has no default constructor
​https://bugs.webkit.org/show_bug.cgi?id=43619

Reviewed by Eric Seidel.

Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.

Csaba Osztrogonác helped to find this bug.

  • wtf/Bitmap.h:

(WTF::::Bitmap):

8:57 AM Changeset in webkit [64911] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Unreviewed build-fix.

Come up with a more efficient way to represent Path segments
​https://bugs.webkit.org/show_bug.cgi?id=41159

Landed wrong version of the patch.

  • svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData):
  • svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
  • svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::createSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
8:33 AM Changeset in webkit [64910] by Dimitri Glazkov
  • 1 edit
    7 adds in trunk/LayoutTests

2010-08-07 Dimitri Glazkov <Dimitri Glazkov>

[Chromium]: Added port-specific expectations after ​http://trac.webkit.org/changeset/64901.
​https://bugs.webkit.org/show_bug.cgi?id=41596

  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
8:17 AM Changeset in webkit [64909] by krit@webkit.org
  • 11 edits
    5 adds in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Come up with a more efficient way to represent Path segments
​https://bugs.webkit.org/show_bug.cgi?id=41159

Introduce SVGPathByteStream as a fast and efficient way to organize the synchronization
of Path, SVG path data string and SVGPathSegList in normalized and unaltered modes.
Extended SVGPathParserFactory to accept SVGPathByteStreams as input source and to create
a SVGPathByteStream from a SVG path data string.

Doesn't affect any tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGPathByteStream.h: Added. (WebCore::): (WebCore::SVGPathByteStream::create): (WebCore::SVGPathByteStream::data): (WebCore::SVGPathByteStream::begin): (WebCore::SVGPathByteStream::end): (WebCore::SVGPathByteStream::append): (WebCore::SVGPathByteStream::clear): (WebCore::SVGPathByteStream::isEmpty): (WebCore::SVGPathByteStream::SVGPathByteStream):
  • svg/SVGPathByteStreamBuilder.cpp: Added. (WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder): (WebCore::SVGPathByteStreamBuilder::moveTo): (WebCore::SVGPathByteStreamBuilder::lineTo): (WebCore::SVGPathByteStreamBuilder::lineToHorizontal): (WebCore::SVGPathByteStreamBuilder::lineToVertical): (WebCore::SVGPathByteStreamBuilder::curveToCubic): (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth): (WebCore::SVGPathByteStreamBuilder::curveToQuadratic): (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth): (WebCore::SVGPathByteStreamBuilder::arcTo): (WebCore::SVGPathByteStreamBuilder::closePath):
  • svg/SVGPathByteStreamBuilder.h: Added. (WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): (WebCore::SVGPathByteStreamBuilder::writeType): (WebCore::SVGPathByteStreamBuilder::writeFlag): (WebCore::SVGPathByteStreamBuilder::writeFloat): (WebCore::SVGPathByteStreamBuilder::writeFloatPoint): (WebCore::SVGPathByteStreamBuilder::writeSegmentType):
  • svg/SVGPathByteStreamSource.cpp: Added. (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::~SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData): (WebCore::SVGPathByteStreamSource::parseFloat): (WebCore::SVGPathByteStreamSource::parseFlag): (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand):
  • svg/SVGPathByteStreamSource.h: Added. (WebCore::SVGPathByteStreamSource::create): (WebCore::SVGPathByteStreamSource::readType): (WebCore::SVGPathByteStreamSource::readFlag): (WebCore::SVGPathByteStreamSource::readFloat): (WebCore::SVGPathByteStreamSource::readSVGSegmentType): (WebCore::SVGPathByteStreamSource::readFloatPoint):
  • svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathByteStreamBuilder): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
  • svg/SVGPathParserFactory.h:
6:03 AM Changeset in webkit [64908] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-07 Dirk Schulze <​krit@webkit.org>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
5:42 AM Changeset in webkit [64907] by victorw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-06 Victor Wang <​victorw@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add dllimport/dllexport to WebSpeechInputControllerMock::create
so it works for windows dll build.

​https://bugs.webkit.org/show_bug.cgi?id=43627

  • public/WebSpeechInputControllerMock.h:
5:22 AM Changeset in webkit [64906] by abecsi@webkit.org
  • 7 edits
    3 deletes in trunk

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebCore.pri:
  • WebCore.pro:
  • features.pri: Removed.

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebKit.pro:

2010-08-07 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64904.
​http://trac.webkit.org/changeset/64904
​https://bugs.webkit.org/show_bug.cgi?id=43671

Broke the Qt Windows builders. (Requested by bbandix on
#webkit).

  • WebKit2.pri: Removed.
  • WebKit2.pro:
  • WebProcess.pro: Removed.
4:47 AM Changeset in webkit [64905] by abecsi@webkit.org
  • 5 edits in trunk/WebKit2

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

NPAPI headers should be included through npruntime_internal.h

​https://bugs.webkit.org/show_bug.cgi?id=43620

  • DerivedSources.pro:
  • WebProcess/Plugins/NPJSObject.h:
  • WebProcess/Plugins/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
4:44 AM Changeset in webkit [64904] by abecsi@webkit.org
  • 7 edits
    3 adds in trunk

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

Just build changes so no new tests.

  • WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
  • WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
  • features.pri: Added.

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.

2010-08-07 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[Qt] Build WebKit2 into a static lib

​https://bugs.webkit.org/show_bug.cgi?id=43621

  • WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
  • WebKit2.pro: Build specification for the WebKit2 framework.
  • WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.
2:32 AM Changeset in webkit [64903] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update DRT expectation.
2:28 AM Changeset in webkit [64902] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Remove workarounds in two dynamic-updates scripts, that now work without it.

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js:
  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js:
2:25 AM Changeset in webkit [64901] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)

Test: http/tests/misc/slow-loading-image-in-pattern.html

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Added test verifying that resources are properly updated, if an image child element has changed.

  • http/tests/misc/slow-loading-image-in-pattern.html: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
2:17 AM Changeset in webkit [64900] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-07 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt: Rebaseline for r64890.
12:13 AM Changeset in webkit [64899] by Nikolas Zimmermann
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-08-07 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove obsolete baselines for win-xp and win-vista, all windows platforms are the same for this test
​https://bugs.webkit.org/show_bug.cgi?id=43669

  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.

Aug 6, 2010:

11:27 PM Changeset in webkit [64898] by krit@webkit.org
  • 22 edits
    5 adds in trunk/WebCore

2010-08-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Generalize SVGPathParser to allow more than just strings as input source
​https://bugs.webkit.org/show_bug.cgi?id=43618

Generalize SVGPathParser, by allowing different parsing sources than just strings.
For now only a SVGPathStringSource is available, parsing from bytestreams follows soon.
Each client that wants to parse strings, like Path or SVGPathSegList objects, only
needs to use the new central SVGPathParserFactory, which glues consumer and sources together.
Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for
easier access throughout the SVG code.

Doesn't affect any tests.

  • Android.mk:
  • CMakeLists.txt
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • svg/SVGGlyphElement.cpp: (WebCore::parsePathData):
  • svg/SVGPathBuilder.cpp: (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
  • svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::setCurrentPath): (WebCore::SVGPathBuilder::arcTo):
  • svg/SVGPathConsumer.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute):
  • svg/SVGPathParser.cpp: (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataFromSource): (WebCore::SVGPathParser::decomposeArcToCubic):
  • svg/SVGPathParser.h: (WebCore::SVGPathParser::setCurrentConsumer):
  • svg/SVGPathParserFactory.cpp: Added. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::self): (WebCore::SVGPathParserFactory::SVGPathParserFactory): (WebCore::SVGPathParserFactory::~SVGPathParserFactory): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
  • svg/SVGPathParserFactory.h: Added.
  • svg/SVGPathSeg.h: (WebCore::): (WebCore::SVGPathSeg::~SVGPathSeg): (WebCore::SVGPathSeg::): (WebCore::SVGPathSeg::pathSegType): (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString): (WebCore::SVGPathSeg::associatedAttributeName): (WebCore::SVGPathSeg::SVGPathSeg): (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord): (WebCore::SVGPathSegSingleCoord::setX): (WebCore::SVGPathSegSingleCoord::x): (WebCore::SVGPathSegSingleCoord::setY): (WebCore::SVGPathSegSingleCoord::y): (WebCore::SVGPathSegSingleCoord::toString):
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): (WebCore::SVGPathSegList::toPathData): (WebCore::SVGPathSegList::createAnimated):
  • svg/SVGPathSegListBuilder.cpp: (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo):
  • svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
  • svg/SVGPathSource.h: Added. (WebCore::SVGPathSource::~SVGPathSource): (WebCore::SVGPathSource::SVGPathSource):
  • svg/SVGPathStringSource.cpp: Added. (WebCore::SVGPathStringSource::SVGPathStringSource): (WebCore::SVGPathStringSource::~SVGPathStringSource): (WebCore::SVGPathStringSource::endOfStream): (WebCore::SVGPathStringSource::parseFloat): (WebCore::SVGPathStringSource::parseFlag): (WebCore::SVGPathStringSource::skipSpaces): (WebCore::SVGPathStringSource::parseSVGSegmentType): (WebCore::SVGPathStringSource::hasRemainingCoordinatesInCurrentCommand):
  • svg/SVGPathStringSource.h: Added. (WebCore::SVGPathStringSource::create):
11:20 PM Changeset in webkit [64897] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing files from last commit - per Alex request.

  • platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
10:03 PM Changeset in webkit [64896] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-06 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Darin Adler.

recent colorspace changes have fixed svg/custom/grayscale-gradient-mask.svg
​https://bugs.webkit.org/show_bug.cgi?id=43104

New baselines for windows and linux for two tests affected by the bug fix
for ​https://bugs.webkit.org/show_bug.cgi?id=42228 where I failed to rebaseline
them properly at that time.

  • platform/chromium-linux/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:27 PM Changeset in webkit [64895] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

2010-08-06 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Dirk Schulze.

can't see anything wrong with the output for circle-in-mask-with-shadow.svg
​https://bugs.webkit.org/show_bug.cgi?id=43106

This test has been affected by recent colorspace changes but the diffs are
so slight as to be very difficult to detect. I'm reasonably confident
these new baselines are OK.

  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium/test_expectations.txt:
9:11 PM Changeset in webkit [64894] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

2010-08-06 Alex Nicolaou <​anicolao@chromium.org>

Reviewed by Darin Adler.

rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
​https://bugs.webkit.org/show_bug.cgi?id=43107

After some investigation, the antialiasing diffs were
definitely verified to be due to the colorspace change
made for ​https://bugs.webkit.org/show_bug.cgi?id=42228
and I'm reasonably confident that these rebaselined
outputs are good.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium/test_expectations.txt:
8:37 PM Changeset in webkit [64893] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-06 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

Define setPrivateBrowsingEnabled()
​https://bugs.webkit.org/show_bug.cgi?id=42283

Define the scope of 'private browsing' in WebKit
See also ​https://bugs.webkit.org/show_bug.cgi?id=41801

  • page/Settings.h:
8:30 PM Changeset in webkit [64892] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Ojan Vafai.

dump-as-markup should work in Firefox
​https://bugs.webkit.org/show_bug.cgi?id=43606

Apparently Firefox lacks this API.

  • resources/dump-as-markup.js: (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
8:09 PM Changeset in webkit [64891] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-06 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] One more tweak to the expectation overrides to pacify the bot.

  • platform/chromium/drt_expectations.txt: Removed duplicate expectations.
6:56 PM Changeset in webkit [64890] by abarth@webkit.org
  • 5 edits in trunk

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
​https://bugs.webkit.org/show_bug.cgi?id=43605

Show test progression. We missed this regression when analyzing the
expectation diffs because the DOM was correct and was a progression.

  • fast/dom/no-elements-expected.txt:
  • platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
​https://bugs.webkit.org/show_bug.cgi?id=43605

The old parser used to drop <noembed> on the floor. We're supposed to
add it to the DOM, but we don't want to create a renderer for it.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
6:30 PM Changeset in webkit [64889] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-08-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Fix style violations in Document
​https://bugs.webkit.org/show_bug.cgi?id=43657

No new tests because no new functionality.

  • dom/Document.cpp: (WebCore::acceptsEditingFocus): (WebCore::Document::Document): (WebCore::Document::importNode): (WebCore::Document::adoptNode): (WebCore::Document::getElementById): (WebCore::Document::readyState): (WebCore::Document::createTreeWalker): (WebCore::Document::shouldScheduleLayout): (WebCore::Document::nextFocusableNode): (WebCore::Document::previousFocusableNode): (WebCore::Document::nodeAbsIndex): (WebCore::Document::nodeWithAbsIndex): (WebCore::Document::childTypeAllowed): (WebCore::Document::canReplaceChild): (WebCore::Document::recalcStyleSelector): (WebCore::Document::setFocusedNode): (WebCore::Document::attachNodeIterator): (WebCore::Document::detachNodeIterator): (WebCore::Document::parseQualifiedName): (WebCore::Document::getImageMap): (WebCore::Document::setInPageCache): (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::shiftMarkers): (WebCore::Document::setMarkersActive): (WebCore::Document::parentDocument): (WebCore::Document::topDocument): (WebCore::FormElementKeyHash::hash): (WebCore::Document::initSecurityContext):
  • dom/Document.h: (WebCore::Document::incDOMTreeVersion): (WebCore::Document::domTreeVersion):
5:34 PM Changeset in webkit [64888] by jhoneycutt@apple.com
  • 15 edits
    3 adds in trunk

WebKitTestRunner needs to be able to set the font smoothing type
​https://bugs.webkit.org/show_bug.cgi?id=43406

Reviewed by Adam Roben.

WebKit2:

  • Shared/FontSmoothingLevel.h: Added.

(WebKit::):

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
Initialize fontSmoothingLevel.
(WebKit::WebPreferencesStore::swap):
Copy fontSmoothingLevel.

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
Encode fontSmoothingLevel.
(WebKit::WebPreferencesStore::decode):
Decode it.

  • UIProcess/API/C/WKPreferencesPrivate.cpp: Added.

(WKPreferencesSetFontSmoothingLevel):
Get the font smoothing level from the WKFontSmoothingLevel, and call
WebPreferences::setFontSmoothingLevel().
(WKPreferencesGetFontSmoothingLevel):
Get the font smoothing level from WebPreferences, and translate it to a
WKFontSmoothingLevel.

  • UIProcess/API/C/WKPreferencesPrivate.h: Added.

Declare the font smoothing levels, and declare functions to get and set
the level.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setFontSmoothingLevel):
Set fontSmoothingLevel and call update().
(WebKit::WebPreferences::fontSmoothingLevel):
Return the level.

  • UIProcess/WebPreferences.h:

Declare getter and setter for fontSmoothingLevel.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files to project.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::preferencesDidChange):
Call platformPreferencesDidChange().

  • WebProcess/WebPage/WebPage.h:

Declare platformPreferencesDidChange().

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformPreferencesDidChange):
On CG platforms, call wkSetFontSmoothingLevel(). This matches the code
in old WebKit's WebPreferences. Set the font rendering mode to either
normal (CG) or alternative (GDI) based on the font smoothing level. This
matches what was done in old WebKit's WebView.

  • win/WebKit2.vcproj:

Add FontSmoothingLevel.h and WKPreferencesPrivate.{h,cpp} to project.

  • win/WebKit2Generated.make:

Copy WKPreferencesPrivate.h.

WebKitTools:

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set the font smoothing level to
kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.

5:07 PM Changeset in webkit [64887] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-06 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] Adjust expectations after my unexpectedly awful search-and-replace performance.

  • platform/chromium/drt_expectations.txt: Un-bungled test names.
4:47 PM Changeset in webkit [64886] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-08-06 Eric Carlson <​eric.carlson@apple.com>

Unreviewed, release Qt build fix.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent): Guard call to toRenderVideo() with #if ENABLE(VIDEO).
4:43 PM Changeset in webkit [64885] by mrowe@apple.com
  • 1 edit in tags/Safari-534.5/WebCore/WebCore.vcproj/WebCore.vcproj

Windows build fix. Temporarily turn off link-time code generation.

4:35 PM Changeset in webkit [64884] by eric.carlson@apple.com
  • 15 edits
    2 adds in trunk

2010-08-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTML5 "video" tag with poster frame defined "flashes" right before movie displays
​https://bugs.webkit.org/show_bug.cgi?id=37591
<rdar://problem/5650561>

If a video element has a poster frame, display it until the playback is requested or the movie's
time is changed.

Test: compositing/video/video-poster.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_displayMode. (WebCore::HTMLMediaElement::prepareForLoad): Set m_displayMode to Unknown. (WebCore::HTMLMediaElement::loadResource): Call updateDisplayState to let it set configure the poster, if necessary. (WebCore::HTMLMediaElement::noneSupported): updatePosterImage -> updateDisplayState. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::finishSeek): Set display mode to Video so a video frame will be displayed if a poster is currently visible. (WebCore::HTMLMediaElement::mediaPlayerRepaint): updatePosterImage -> updateDisplayState. (WebCore::HTMLMediaElement::updatePlayState): Set display mode to Video.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::displayMode): New. (WebCore::HTMLMediaElement::setDisplayMode): Ditto. (WebCore::HTMLMediaElement::updateDisplayState): Ditto.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Remove m_shouldDisplayPosterImage. (WebCore::HTMLVideoElement::attach): Call shouldDisplayPosterImage instead of checking m_shouldDisplayPosterImage directly. (WebCore::HTMLVideoElement::detach): Ditto. (WebCore::HTMLVideoElement::parseMappedAttribute): Set m_displayMode to Unknown before calling updateDisplayState so shouldDisplayPosterImage() will return the correct result. Remove the PLUGIN_PROXY_FOR_VIDEO code, it is now in updateDisplayState. (WebCore::HTMLVideoElement::setDisplayMode): Renamed from updatePosterImage and rework logic so we tell the media engine it is OK to display video frames when there is no poster, or once the media engine has something to display and the movie has started or seeked. (WebCore::HTMLVideoElement::updateDisplayState): New, manage display mode based on poster attribute.
  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::shouldDisplayPosterImage):
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::prepareForRendering): New, call media engine's prepareForRendering.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::prepareForRendering):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_isAllowedToRender. (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::isReadyForVideoSetup): Renamed from isReadyForRendering. (WebCore::MediaPlayerPrivate::prepareForRendering): New, set m_isAllowedToRender and inform the client that render tree should be updated so we correctly switch from showing the poster, which often doens't use a layer, to showing video frames, which do. (WebCore::MediaPlayerPrivate::updateStates): Don't call setUpVideoRendering until isReadyForVideoSetup() returns true. (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): isReadyForRendering -> isReadyForVideoSetup
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent): Only consider video when displaying video frames so a poster won't force compositing mode.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::shouldDisplayVideo): New, return true when not displaying a poster.
  • rendering/RenderVideo.h:

2010-08-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

HTML5 "video" tag with poster frame defined "flashes" right before movie displays
​https://bugs.webkit.org/show_bug.cgi?id=37591
<rdar://problem/5650561>

If a video element has a poster frame, display it until the playback is requested or the movie's
time is changed. Test this by ensuring that an element with a poster doesn't have layers while
and element with one does.

  • compositing/video/video-poster-expected.txt: Added.
  • compositing/video/video-poster.html: Added.
4:35 PM Changeset in webkit [64883] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:30 PM Changeset in webkit [64882] by mrowe@apple.com
  • 1 copy in tags/Safari-534.5

New tag.

4:29 PM Changeset in webkit [64881] by jamesr@google.com
  • 9 edits in trunk/WebCore

2010-08-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Accelerated 2d canvases should get compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=43362

Allows for 2d canvas rendering contexts to use a GraphicsContext3D for
accelerated rendering. The rendering context holds the GraphicsContext3D
alive and exposes it to the compositor. The 3d context itself is passed
down through the GraphicsContext to use for actual rendering:
​https://bug-43362-attachments.webkit.org/attachment.cgi?id=63557

This approach will let us simultaneously prototype accelerated techniques
for canvas 2d and revise the design of canvas elements without destabilizing
all ports.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::willDraw): (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::isAccelerated): (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
  • html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::graphicsContext3D):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::syncSoftwareCanvas):
4:23 PM Changeset in webkit [64880] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-06 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] Update expectation overrides for Windows.

  • platform/chromium/drt_expectations.txt: Added a bunch of failing tests.
4:15 PM Changeset in webkit [64879] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Build fixes.

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):

  • Shared/qt/UpdateChunk.cpp:

(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/qt/UpdateChunk.h:
  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/win/UpdateChunk.h:
4:07 PM Changeset in webkit [64878] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

Fix a missed variable rename.

Unreviewed.

  • Scripts/old-run-webkit-tests:
4:04 PM Changeset in webkit [64877] by andersca@apple.com
  • 36 edits in trunk/WebKit2

Change all ArgumentEncoder and ArgumentDecoder references to pointers
​https://bugs.webkit.org/show_bug.cgi?id=43651

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoder.h:
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/mac/MachPort.h:
  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp:
  • Shared/DrawingAreaBase.cpp:
  • Shared/DrawingAreaBase.h:
  • Shared/WebEvent.h:
  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/mac/UpdateChunk.cpp:
  • Shared/mac/UpdateChunk.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:
3:59 PM Changeset in webkit [64876] by jhoneycutt@apple.com
  • 4 edits in trunk

mac-wk2/Skipped should be used on Windows when running regression tests
​https://bugs.webkit.org/show_bug.cgi?id=43494

Reviewed by Adam Roben.

WebKitTools:

  • Scripts/old-run-webkit-tests:

If the platform is win-wk2, also read the mac-wk2 skipped list.

LayoutTests:

  • platform/win-wk2/Skipped:

Remove the tests copied from the mac-wk2 skipped list.

3:39 PM Changeset in webkit [64875] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Don't try to allocate a vector unless we know the buffer can contain it
​https://bugs.webkit.org/show_bug.cgi?id=43647

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):
Check that the argument decoder buffer actually can hold all the vector elements.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Align the current position to the given alignment, add the size and check if the position is
past the end of the buffer.

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Get the size and alignment and call the other bufferIsLargeEnoughtToContain overload.

3:20 PM Changeset in webkit [64874] by eric@webkit.org
  • 12 edits in trunk/WebCore

2010-08-06 Eric Seidel <​eric@webkit.org>

Reviewed by Chris Fleizach.

Make AX Code use more specific RenderObject subclass types
​https://bugs.webkit.org/show_bug.cgi?id=43632

No functional change, thus no tests.

  • accessibility/AXObjectCache.cpp: (WebCore::nodeHasRole):
    • Make this take a String instead of AtomicString, to avoid thrashing the atomic string hash. It would be better to take a const char* here, except one caller passes nullAtom.

(WebCore::createFromRenderer):

  • Split this out from getOrCreate to make it simpler.
  • No longer needs to deal with setting a "result" pointer and can instead just return.
  • I've also made this function use RenderBoxModelObject* where appropriate.

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
    • Fix style.
  • accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::AccessibilityMenuList):
    • Use a more specific type.

(WebCore::AccessibilityMenuList::renderer):

  • accessibility/AccessibilityMenuList.h: (WebCore::AccessibilityMenuList::create):
  • accessibility/AccessibilityMenuListPopup.cpp:
    • Need RenderMenuList.h since renderer() is a RenderMenuList*
  • accessibility/AccessibilityObject.cpp: (WebCore::renderListItemContainerForNode):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderBoxModelObject):
    • New helper function, similar to Node::renderBoxModelObject()

(WebCore::isInlineWithContinuation):
(WebCore::AccessibilityRenderObject::isNativeImage):
(WebCore::AccessibilityRenderObject::isAttachment):
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::isFieldset):
(WebCore::AccessibilityRenderObject::actionElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::widget):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addChildren):
(WebCore::msaaRoleForRenderer):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
  • accessibility/AccessibilityTable.h:
    • Remove unneeded "using namespace std".
3:07 PM Changeset in webkit [64873] by tonyg@chromium.org
  • 12 edits
    2 adds in trunk/WebCore

2010-08-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Factor an AsyncScriptRunner out of Document
​https://bugs.webkit.org/show_bug.cgi?id=43633

This copies the existing implementation exactly. In the future
this will use PendingScript which handles ref counting without
the need for those manual ref()/deref()s. This is also currently
a trivial class, but a little more logic will be added to it to
support <script async>.

No new tests because no new functionality.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AsyncScriptRunner.cpp: Added. (WebCore::AsyncScriptRunner::AsyncScriptRunner): (WebCore::AsyncScriptRunner::~AsyncScriptRunner): (WebCore::AsyncScriptRunner::executeScriptSoon): (WebCore::AsyncScriptRunner::suspend): (WebCore::AsyncScriptRunner::resume): (WebCore::AsyncScriptRunner::timerFired):
  • dom/AsyncScriptRunner.h: Added. (WebCore::AsyncScriptRunner::create): (WebCore::AsyncScriptRunner::hasPendingScripts):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::asyncScriptRunner):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2:58 PM Changeset in webkit [64872] by jamesr@google.com
  • 9 edits in trunk/WebCore

2010-08-06 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Implement GLES2Canvas/Texture in terms of GraphicsContext3D instead of direct OpenGL calls
​https://bugs.webkit.org/show_bug.cgi?id=43608

This converts all OpenGL calls in GLES2(Canvas|Texture) to calls on the corresponding GraphicsContext3D
API, due to feedback on ​https://bugs.webkit.org/show_bug.cgi?id=43362. Nearly all the changes are
applying the regex s/gl([A-Z])/m_context->%1</ and removing unnecessary makeCurrent() calls.
Other changes hilighted below.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::affineTo3x3): (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::applyCompositeOperator): (WebCore::GLES2Canvas::getQuadVertices): (WebCore::GLES2Canvas::getQuadIndices):
    • use new typed XXArray classes for buffer uploads

(WebCore::loadShader):
(WebCore::GLES2Canvas::getSimpleProgram):
(WebCore::GLES2Canvas::getTexProgram):
(WebCore::GLES2Canvas::createTexture):
(WebCore::GLES2Canvas::checkGLError):

  • platform/graphics/chromium/GLES2Canvas.h: (WebCore::GLES2Canvas::context):
  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::convertFormat): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bind):
  • platform/graphics/chromium/GLES2Texture.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect):
    • add a missing restore() call to the H/W path
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
    • avoid applying CTM to uploads

(WebCore::PlatformContextSkia::readbackHardwareToSoftware):

  • platform/graphics/skia/PlatformContextSkia.h:
2:52 PM Changeset in webkit [64871] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Detect invalid CoreIPC messages and call didReceiveInvalidMessage
​https://bugs.webkit.org/show_bug.cgi?id=43643
<rdar://problem/7891069>

Reviewed by Adam Roben.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::alignBufferPosition):
If we can't correctly align the buffer position, mark the decoder as invalid.

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::isInvalid):
Check if the argument decoder is valid.

(CoreIPC::ArgumentDecoder::markInvalid):
Mark the argument decoder as invalid, by setting its buffer position past its end position.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchMessages):
Check if m_client is null before dispatching messages. If an argument decoder was marked invalid, call
Connection::Client::didReceiveInvalidMessage.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::Message::releaseArguments):
Rename destroy to releaseArguments and make it return a PassOwnPtr.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Call releaseArguments instead of destroy.

(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Kill the web process and invalidate its connection.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveInvalidMessage):
Don't do anything, if the UI process is sending invalid messages there's not much we can do.

  • WebProcess/WebProcess.h:
2:49 PM Changeset in webkit [64870] by jamesr@google.com
  • 12 edits
    2 moves in trunk

2010-08-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Composited canvas should be treated the same by the compositor and not be WebGL specific
​https://bugs.webkit.org/show_bug.cgi?id=43589

Initializes the platformLayer as a CanvasLayerChromium, not a WebGLLayerChromium.
The layer itself isn't WebGL-specific.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformLayer): (WebCore::GraphicsContext3D::platformLayer):

2010-08-06 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Composited canvas should be treated the same by the compositor and not be WebGL specific
​https://bugs.webkit.org/show_bug.cgi?id=43589

This treats all GraphicsContext3D-backed layers the same instead of special casing WebGL.
The cross-platform change is to rename GraphicsLayer::setContentsToWebGL() to
GraphicsLayer::setContentsToCanvas() and to rename all implementations.

This patch also renames the chromium class used for accelerating these layers.

Cross platform changes:

  • WebCore.gypi:
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToCanvas):

Rename the function on the base class. GraphicsLayerCA and GraphicsLayerChromium implement this.

  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas):

Helper function to see if a renderer is associated with an accelerated compositing layer.

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::rendererContentChanged):

Chromium specific changes:

  • platform/graphics/chromium/CanvasLayerChromium.cpp: Added. (WebCore::CanvasLayerChromium::create): (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::textureId): (WebCore::CanvasLayerChromium::updateTextureContents): (WebCore::CanvasLayerChromium::setContext):
  • platform/graphics/chromium/CanvasLayerChromium.h: Added. (WebCore::CanvasLayerChromium::drawsContent): (WebCore::CanvasLayerChromium::ownsTexture): (WebCore::CanvasLayerChromium::shaderProgramId): (WebCore::CanvasLayerChromium::setShaderProgramId):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsNeedsDisplay): (WebCore::GraphicsLayerChromium::setContentsToCanvas):
  • platform/graphics/chromium/GraphicsLayerChromium.h: (WebCore::GraphicsLayerChromium::):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedGLObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
  • platform/graphics/chromium/WebGLLayerChromium.h: Removed. Mac specific changes:
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateContentsCanvasLayer): (WebCore::GraphicsLayerCA::setContentsToCanvas):
2:45 PM Changeset in webkit [64869] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-06 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Eric Seidel.

Add PluginView::bindingInstance() to PluginViewNone
​https://bugs.webkit.org/show_bug.cgi?id=42936

  • bindings/js/ScriptControllerEfl.cpp: (WebCore::ScriptController::createScriptInstanceForWidget): Removed workaround.
  • plugins/PluginViewNone.cpp: Added property svn:eol-style. (WebCore::PluginView::bindingInstance): Added missing method and use it on WinCE.
2:22 PM Changeset in webkit [64868] by Joseph Pecoraro
  • 2 edits in trunk/WebKit/mac

2010-08-06 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Eric Seidel.

add "const" to WebChromeClient::webView().
​https://bugs.webkit.org/show_bug.cgi?id=43631

Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
is const method now, and calling webView() inside port-specific didReceiveViewportArguments
implementation fails compiling if webView() is not const.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
1:40 PM Changeset in webkit [64867] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Add CoreIPC::MessageReceiver class
​https://bugs.webkit.org/show_bug.cgi?id=43637

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::MessageReceiver::~MessageReceiver):
Add MessageReceiver class and make Client inherit from it.

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:

Remove ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage.

  • Shared/DrawingAreaBase.h:

Include "Connection.h" instead.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:

Remove didReceiveSyncMessage.

1:20 PM Changeset in webkit [64866] by leandro@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-06 Rafael Antognolli <​antognolli@profusion.mobi>

[EFL] Build fix.

  • CMakeLists.txt: add runtime/CGHandle.cpp.
12:59 PM Changeset in webkit [64865] by kov@webkit.org
  • 4 edits in trunk

2010-08-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Use new "package" name also for the directory where the inspector
support files are installed.

  • GNUmakefile.am:

WebKit/gtk

2010-08-06 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Use the new paths, and also fix the path for localizedStrings.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::localizedStringsURL):
12:27 PM Changeset in webkit [64864] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix chromium build break.

  • inspector/InspectorDebuggerAgent.h:
12:21 PM Changeset in webkit [64863] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-06 Dirk Schulze <​krit@webkit.org>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
11:54 AM Changeset in webkit [64862] by weinig@apple.com
  • 8 edits
    2 adds in trunk/WebKit2

Roll out ​http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.

Patch by Jessie Berlin <​jberlin@apple.com> on 2010-08-06

  • UIProcess/PageClient.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:
11:49 AM Changeset in webkit [64861] by jberlin@webkit.org
  • 285 edits in trunk

2010-08-06 Jessie Berlin <​jberlin@apple.com>

Roll out ​http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.

11:21 AM Changeset in webkit [64860] by jianli@chromium.org
  • 9 edits
    4 adds in trunk/LayoutTests

Update chromium test results.

  • platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png: Added.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/custom/path-zero-strokewidth-expected.checksum: Added.
  • platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [64859] by zmo@google.com
  • 6 edits in trunk

2010-08-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
​https://bugs.webkit.org/show_bug.cgi?id=42124

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Helper function that's called by all associateBufferData(). (WebCore::WebGLBuffer::associateBufferData): Call associateBufferDataImpl(). (WebCore::WebGLBuffer::associateBufferSubDataImpl): Helper function that's called by all associateBufferSubData(). (WebCore::WebGLBuffer::associateBufferSubData): Call associateBufferSubDataImpl().
  • html/canvas/WebGLBuffer.h: Declare helper functions.

2010-08-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
​https://bugs.webkit.org/show_bug.cgi?id=42124

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Adding test case for bufferData and bufferSubData with ArrayBufferView input.
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
10:58 AM Changeset in webkit [64858] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

noembed should respect whether plugins are enabled
​https://bugs.webkit.org/show_bug.cgi?id=43611

This instruction isn't in the HTML5 spec, but it seems like the right
thing to do. I suspect this is because the spec doesn't understand
that plugins can be disabled.

I'm not sure how we can test this in DumpRenderTree, but I'm open to
suggestions.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::adjustedLexerState): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::scriptEnabled): (WebCore::HTMLTreeBuilder::pluginsEnabled):
  • html/HTMLTreeBuilder.h:
10:35 AM Changeset in webkit [64857] by tonyg@chromium.org
  • 10 edits
    2 adds in trunk/WebCore

2010-08-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Factor out PendingScript and protect its members
​https://bugs.webkit.org/show_bug.cgi?id=43391

This will be shared by AsyncScriptRunner.

No new tests because no new functionality.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/PendingScript.cpp: Added. (WebCore::PendingScript::~PendingScript): (WebCore::PendingScript::element): (WebCore::PendingScript::releaseElementAndClear): (WebCore::PendingScript::setCachedScript): (WebCore::PendingScript::cachedScript):
  • dom/PendingScript.h: Added. (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::startingLineNumber): (WebCore::PendingScript::watchingForLoad): (WebCore::PendingScript::setWatchingForLoad): (WebCore::PendingScript::hasElement): (WebCore::PendingScript::adoptElement): (WebCore::PendingScript::notifyFinished):
  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::haveParsingBlockingScript): (WebCore::HTMLScriptRunner::requestScript):
  • html/HTMLScriptRunner.h:
9:51 AM Changeset in webkit [64856] by jberlin@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-06 Jessie Berlin <​jberlin@apple.com>

Windows Build Fix (continued). Unreviewed.

9:43 AM Changeset in webkit [64855] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-06 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Darin Adler.

Change permission to access methods in XMLDocumentParser.h
​https://bugs.webkit.org/show_bug.cgi?id=43180

Change permission to access wellFormed(), lineNumber() and columnNumber()
in XMLDocumentParser.h. Because, the methods are used by WML.

  • dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::wellFormed): Change accebility permission.
9:09 AM Changeset in webkit [64854] by jberlin@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-06 Jessie Berlin <​jberlin@apple.com>

Windows Build Fix. Unreviewed.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add GCHandle.h and GCHandle.cpp.
9:02 AM Changeset in webkit [64853] by commit-queue@webkit.org
  • 2 edits in trunk

2010-08-06 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Regression (64763) build fix for efl.
​https://bugs.webkit.org/show_bug.cgi?id=43597

change ENABLE_BLOB_SLICE to ENABLE_BLOB for fixing build break

  • cmake/OptionsEfl.cmake:
8:59 AM Changeset in webkit [64852] by Martin Robinson
  • 5 edits
    4 adds in trunk

2010-08-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Support for image drags
​https://bugs.webkit.org/show_bug.cgi?id=40788

Unskip and add baselines for tests that are now passing with image drag support.

  • platform/gtk/Skipped:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt: Added.

2010-08-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Support for image drags
​https://bugs.webkit.org/show_bug.cgi?id=40788

Add image drag-and-drop support for WebKit GTK+.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::setDragImage): Filled this stub. (WebCore::ClipboardGtk::setDragImageElement): Filled this stub. (WebCore::ClipboardGtk::createDragImage): Filled this stub. (WebCore::ClipboardGtk::declareAndWriteDragImage): Write the image URL, markup, and image itself to the data object member.
  • platform/gtk/ClipboardGtk.h: Brought method declarations into line with the parent class.
8:30 AM Changeset in webkit [64851] by pfeldman@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-08-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: disable device motion by default.

​https://bugs.webkit.org/show_bug.cgi?id=43623

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceMotion): (WebKit::WebRuntimeFeatures::isDeviceMotionEnabled): (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
7:59 AM Changeset in webkit [64850] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline win specific getComputedStyle* results, after r64832.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
7:55 AM Changeset in webkit [64849] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk/JavaScriptCore

2010-08-06 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=43207

WeakGCPtr's should instead of directly pointing to the GC'd object
should be directed to an array of pointers that can be updated for
movable objects.

  • Android.mk:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/Collector.cpp: (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlock): (JSC::Heap::updateWeakGCHandles): (JSC::WeakGCHandlePool::update): (JSC::Heap::addWeakGCHandle): (JSC::Heap::markRoots):
  • runtime/Collector.h: (JSC::Heap::weakGCHandlePool):
  • runtime/GCHandle.cpp: Added. (JSC::WeakGCHandle::pool): (JSC::WeakGCHandlePool::WeakGCHandlePool): (JSC::WeakGCHandlePool::allocate): (JSC::WeakGCHandlePool::free): (JSC::WeakGCHandlePool::operator new):
  • runtime/GCHandle.h: Added. (JSC::WeakGCHandle::isValidPtr): (JSC::WeakGCHandle::isPtr): (JSC::WeakGCHandle::isNext): (JSC::WeakGCHandle::invalidate): (JSC::WeakGCHandle::get): (JSC::WeakGCHandle::set): (JSC::WeakGCHandle::getNextInFreeList): (JSC::WeakGCHandle::setNextInFreeList): (JSC::WeakGCHandlePool::isFull):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::~WeakGCPtr): (JSC::WeakGCPtr::get): (JSC::WeakGCPtr::clear): (JSC::WeakGCPtr::assign): (JSC::get):
7:44 AM Changeset in webkit [64848] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline gtk specific getComputedStyle-basic.html result, after r64832.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
7:16 AM Changeset in webkit [64847] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.3.3

Way late tagging of 1.3.3.

7:00 AM Changeset in webkit [64846] by yurys@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-08-06 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract debugger implementation into InspectorDebuggerAgent
​https://bugs.webkit.org/show_bug.cgi?id=42340

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h: (WebCore::InspectorController::debuggerAgent):
  • inspector/InspectorDebuggerAgent.cpp: Added. (WebCore::md5Base16): (WebCore::formatBreakpointId): (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled): (WebCore::InspectorDebuggerAgent::activateBreakpoints): (WebCore::InspectorDebuggerAgent::deactivateBreakpoints): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::resume): (WebCore::InspectorDebuggerAgent::stepOverStatement): (WebCore::InspectorDebuggerAgent::stepIntoStatement): (WebCore::InspectorDebuggerAgent::stepOutOfFunction): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::clearForPageNavigation): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::loadBreakpoints): (WebCore::InspectorDebuggerAgent::saveBreakpoints): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue): (WebCore::InspectorDebuggerAgent::remoteFrontend):
  • inspector/InspectorDebuggerAgent.h: Added.
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
6:38 AM Changeset in webkit [64845] by dino@apple.com
  • 35 edits
    22 adds in trunk

2010-08-06 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser and Steve Block.

​https://bugs.webkit.org/show_bug.cgi?id=42865
Implement DeviceMotionEvent

Implement the DeviceMotionEvent interface as defined
in ​http://dev.w3.org/geo/api/spec-source-orientation.html
This is currently an empty implementation, in that there is
no motion client connected - the platform implementations
will need to do that.

Tests: fast/dom/DeviceMotion/create-event.html

fast/dom/DeviceMotion/optional-event-properties.html
fast/dom/DeviceMotion/window-property.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • Android.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
    • Add new files for DeviceMotionEvent build support
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
    • new runtime flags for device motion
  • bindings/js/JSDeviceMotionEventCustom.cpp: Added.
  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp: Added.
    • Custom JS binding to translate property access through to the DeviceMotionData object that the Event holds
  • bindings/js/JSEventCustom.cpp:
    • Include the custom code for DeviceMotionEvent
  • dom/DeviceMotionClient.h: Added.
    • Pure virtual client for DeviceMotion access
  • dom/DeviceMotionController.cpp: Added.
  • dom/DeviceMotionController.h: Added.
    • Controller class that manages event dispatch
  • dom/DeviceMotionData.cpp: Added.
  • dom/DeviceMotionData.h: Added.
    • Representation of the data that comes from a device motion client that is then used within the event.
  • dom/DeviceMotionEvent.cpp: Added.
  • dom/DeviceMotionEvent.h: Added.
  • dom/DeviceMotionEvent.idl: Added.
    • The actual event implementation
  • dom/Document.cpp: (WebCore::Document::createEvent):
    • Update createEvent to allow "devicemotion" events
  • dom/Event.cpp:
  • dom/Event.h:
    • isDeviceMotionEvent virtual method
  • dom/EventNames.h:
    • new "devicemotion" event type
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
    • allow creation of "devicemotion" events and pass registration through to the Page's deviceMotionController object
  • page/Page.cpp:
  • page/Page.h:
    • new PageClient for deviceMotionController

Layout Tests:

  • fast/dom/Window/window-properties-device-orientation-expected.txt:
  • fast/dom/Window/window-properties-device-orientation.html:
  • fast/dom/Window/window-properties.html:

Add some tests for the DeviceMotionEvent interface.

  • fast/dom/DeviceMotion/create-event-expected.txt: Added.
  • fast/dom/DeviceMotion/create-event.html: Added.
  • fast/dom/DeviceMotion/optional-event-properties-expected.txt: Added.
  • fast/dom/DeviceMotion/optional-event-properties.html: Added.
  • fast/dom/DeviceMotion/script-tests/TEMPLATE.html: Added.
  • fast/dom/DeviceMotion/script-tests/create-event.js: Added.
  • fast/dom/DeviceMotion/script-tests/optional-event-properties.js: Added.
  • fast/dom/DeviceMotion/script-tests/window-property.js: Added.
  • fast/dom/DeviceMotion/window-property-expected.txt: Added.
  • fast/dom/DeviceMotion/window-property.html: Added.

Make sure these are skipped on Mac, Win, GTK and QT.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
6:29 AM Changeset in webkit [64844] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-06 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
​https://bugs.webkit.org/show_bug.cgi?id=43450

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState):
  • inspector/front-end/Settings.js:

2010-08-06 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
​https://bugs.webkit.org/show_bug.cgi?id=43450

6:22 AM Changeset in webkit [64843] by tkent@chromium.org
  • 8 edits in trunk/WebKitTools

2010-08-06 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Should revoke scheduled tasks
​https://bugs.webkit.org/show_bug.cgi?id=43560

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Calls RevokeAll().
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
6:07 AM Changeset in webkit [64842] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix warnings about difference in symbol visiblity on Mac OS X

Reviewed by Antonio Gomes.

  • jsc.pro:
6:07 AM Changeset in webkit [64841] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Fix the DRT build on Mac OS X

Reviewed by Antonio Gomes.

  • DumpRenderTree/qt/DumpRenderTree.pro:
5:59 AM Changeset in webkit [64840] by pfeldman@chromium.org
  • 34 edits
    4 adds in trunk

2010-08-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out 64835, 64836 and 64839.

5:25 AM Changeset in webkit [64839] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fix the "GTK Linux 64-bit Debug" bot.

CodeGeneratorGObject.pm doesn't know yet how to auto-generate
callbacks, so we should not auto-generate functions that take
callbacks as parameters. This shouldn't break anything, because
all these functions were marked as Custom until now, and this
code generator skipped those functions anyway.

  • bindings/scripts/CodeGeneratorGObject.pm:
5:13 AM Changeset in webkit [64838] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

<noscript> is not allowed inside <p>
​https://bugs.webkit.org/show_bug.cgi?id=43440

Add a test that we now we parse this example correctly.

  • html5lib/resources/webkit02.dat:
5:04 AM Changeset in webkit [64837] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed, forgot to land these new results in my last commit.

SVG - stroke-width:0 bug with stroke other than "none"
​https://bugs.webkit.org/show_bug.cgi?id=42387

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
5:00 AM Changeset in webkit [64836] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, "Qt Linux Realese minimal" build fix.

  • bindings/scripts/CodeGeneratorJS.pm:
4:47 AM Changeset in webkit [64835] by dumi@chromium.org
  • 33 edits
    4 deletes in trunk

WebCore: Auto-generate all HTML5 DB bindings.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp

and the custom implementations of openDatabas{Sync}().

  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDatabaseCustom.cpp: Removed.
  • bindings/js/JSDatabaseSyncCustom.cpp: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm: Change the code generators

to check that a value was passed for each non-optional argument,
and that the value can be converted to the argument type.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::serializedValueCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/V8Binding.h:

(WebCore::String):
(WebCore::AtomicString):

  • page/DOMWindow.idl: Minor changes required by the auto-generated

bindings.

  • storage/Database.cpp:

(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):

  • storage/Database.h:
  • storage/Database.idl:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl:
  • workers/WorkerContext.idl:

LayoutTests: Cosmetic changes to two tests.
​https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

  • fast/workers/storage/open-database-inputs-sync-expected.txt:
  • fast/workers/storage/resources/open-database-inputs-sync.js:
  • storage/null-callbacks.html:
4:43 AM Changeset in webkit [64834] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Sort XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
4:41 AM Changeset in webkit [64833] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skip another hyphens* test to turn Leopard green again.

fast/text/hyphen* tests have different results on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=43296

  • platform/mac-leopard/Skipped:
4:30 AM Changeset in webkit [64832] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix warning, breaking win build.

  • svg/SVGLength.cpp: (WebCore::SVGLength::toCSSPrimitiveValue):
4:23 AM Changeset in webkit [64831] by ap@apple.com
  • 2 edits in trunk/WebCore

Fix crashing Leopard and Gtk bots.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Don't register ISO8859-16, because older versions of ICU don't support ISO-8859-16, causing crashes when we try to register an alias. Also, we don't need it, because Firefox doesn't support this particular alias (it supports ISO8859-1 to ISO8859-15, but only supports the main name for ISO-8859-16).
4:21 AM Changeset in webkit [64830] by Nikolas Zimmermann
  • 25 edits
    4 adds in trunk

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG - stroke-width:0 bug with stroke other than "none"
​https://bugs.webkit.org/show_bug.cgi?id=42387

Stop storing refcounted CSSValue/CSSValueList objects in SVGRenderStyle, replacing them with SVGLength types.
Allows us to directly specify default values for stroke-dashoffset/width in the SVGRenderStyle, fixing a problem
with stroke-width animations when resetting to the original stored baseVal, exposed in svg/W3C-1.1/animate-elem-40-t.svg
Originally discovered by Fady Samuel.

Test: svg/custom/path-zero-strokewidth.svg

  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::strokeDashArrayToCSSValueList): New helper function converting from Vector<SVGLength> to CSSValueList. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Convert SVGLength values to CSSPrimitiveValues.
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Convert CSSPrimitiveValues to SVGLength objects, for SVGRenderStyle storage.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Just grab strokeWidth SVGLength value from SVGRenderSTyle, no need to call cssPrimitiveToLength anymore.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Ditto.
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::calculateBaselineShift): Ditto (for baseline-shift).
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::buildLayoutInformation): Ditto (for kerning).
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Ditto (for stroke-width/stroke-dashoffset/stroke-dasharray).
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): Ditto.
  • rendering/SVGTextLayoutUtilities.cpp: (WebCore::calculateCSSKerning): Ditto.
  • rendering/SVGTextLayoutUtilities.h:
  • rendering/style/SVGRenderStyle.cpp: Remove no longer needed cssPrimitiveToLength function.
  • rendering/style/SVGRenderStyle.h: Stop storing RefPtr<CSSValue> / RefPtr<CSSValueList> but use SVGLength/Vector<SVGLength>. (WebCore::SVGRenderStyle::initialStrokeDashArray): Allows us to specify correct default values, instead of null pointers. (WebCore::SVGRenderStyle::initialBaselineShiftValue): Specify 0px default value. (WebCore::SVGRenderStyle::initialKerning): Ditto. (WebCore::SVGRenderStyle::initialStrokeDashOffset): Ditto. (WebCore::SVGRenderStyle::initialStrokeWidth): Specify 1px default value. (WebCore::SVGRenderStyle::setStrokeDashArray): Takes a Vector<SVGLength> now, not a PassRefPtr<CSSValueList>. (WebCore::SVGRenderStyle::setStrokeWidth): Takes a SVGLength now, not a PassRefPtr<CSSValue>. (WebCore::SVGRenderStyle::setStrokeDashOffset): Ditto. (WebCore::SVGRenderStyle::setKerning): Ditto. (WebCore::SVGRenderStyle::setStopColor): Pass Color as const-reference. (WebCore::SVGRenderStyle::setFloodColor): Ditto. (WebCore::SVGRenderStyle::setLightingColor): Ditto. (WebCore::SVGRenderStyle::setBaselineShiftValue): Takes a SVGLength now, not a PassRefPtr<CSSValue>. (WebCore::SVGRenderStyle::setShadow): Reformat, had wrong style. (WebCore::SVGRenderStyle::setClipperResource): Pass String as const-reference. (WebCore::SVGRenderStyle::setFilterResource): Ditto. (WebCore::SVGRenderStyle::setMaskerResource): Ditto. (WebCore::SVGRenderStyle::setMarkerStartResource): Ditto. (WebCore::SVGRenderStyle::setMarkerMidResource): Ditto. (WebCore::SVGRenderStyle::setMarkerEndResource): Ditto. (WebCore::SVGRenderStyle::strokeDashArray): Return Vector<SVGLength>. (WebCore::SVGRenderStyle::strokeWidth): Return SVGLength. (WebCore::SVGRenderStyle::strokeDashOffset): Ditto. (WebCore::SVGRenderStyle::kerning): Ditto. (WebCore::SVGRenderStyle::baselineShiftValue): Ditto.
  • rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleStrokeData::StyleStrokeData): Changed initialization order, to group stroke properties.
  • rendering/style/SVGRenderStyleDefs.h: Store SVGLength values instead of reference counted CSS objects.
  • svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): Add copy constructor. (WebCore::SVGLength::operator==): Add comparision operator. (WebCore::SVGLength::operator!=): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): New static helper function to convert from a CSSPrimitiveValue. (WebCore::SVGLength::toCSSPrimitiveValue): New static helper function to convert to a CSSPrimitiveValue.
  • svg/SVGLength.h: Reindent.

2010-08-06 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG - stroke-width:0 bug with stroke other than "none"
​https://bugs.webkit.org/show_bug.cgi?id=42387

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Updated result, as fill="freeze" and stroke-width now works as expected.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Ditto.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: kerning reports 0, stroke-dashoffset 0, stroke-width 1 instead of empty values.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Updated result, as fill="freeze" and stroke-width now works as expected.
  • platform/mac/svg/custom/path-zero-strokewidth-expected.checksum: Added.
  • platform/mac/svg/custom/path-zero-strokewidth-expected.png: Added.
  • platform/mac/svg/custom/path-zero-strokewidth-expected.txt: Added.
  • svg/css/getComputedStyle-basic-expected.txt: An empty stroke-dasharray reports "none", as defined in the spec now.
  • svg/custom/path-zero-strokewidth.svg: Added.
4:15 AM Changeset in webkit [64829] by commit-queue@webkit.org
  • 11 edits
    3 moves
    1 add
    3 deletes in trunk

2010-08-06 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
​https://bugs.webkit.org/show_bug.cgi?id=43427

After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.

PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
to WebKit/qt/WebCoreSupport as well.

All classes that previously inherited from QtAbstractWebPopup now inherit from
QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
instance of class QWebSelectMethod instead of QtAbstractWebPopup.

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: Removed.
  • platform/qt/PopupMenuQt.h: Removed.
  • platform/qt/QtAbstractWebPopup.cpp: Removed.
  • platform/qt/QtAbstractWebPopup.h: Removed.
  • platform/qt/SearchPopupMenuQt.cpp: Removed.
  • platform/qt/SearchPopupMenuQt.h: Removed.

2010-08-06 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
​https://bugs.webkit.org/show_bug.cgi?id=43427

After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.

PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
to WebKit/qt/WebCoreSupport as well.

All classes that previously inherited from QtAbstractWebPopup now inherit from
QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
instance of class QWebSelectMethod instead of QtAbstractWebPopup.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup): (WebCore::ChromeClientQt::createPopupMenu): (WebCore::ChromeClientQt::createSearchPopupMenu):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/PopupMenuQt.cpp: Added. (SelectData::SelectData): (SelectData::itemText): (SelectData::itemToolTip): (SelectData::itemIsEnabled): (SelectData::itemCount): (SelectData::itemIsSelected): (SelectData::multiple): (SelectData::itemType): (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::disconnectClient): (WebCore::PopupMenuQt::show): (WebCore::PopupMenuQt::didHide): (WebCore::PopupMenuQt::hide): (WebCore::PopupMenuQt::updateFromElement): (WebCore::PopupMenuQt::selectItem):
  • WebCoreSupport/PopupMenuQt.h: Added.
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::pageClient):
  • WebCoreSupport/QtFallbackWebPopup.h: (WebCore::QtFallbackWebPopup::setGeometry): (WebCore::QtFallbackWebPopup::geometry): (WebCore::QtFallbackWebPopup::setFont): (WebCore::QtFallbackWebPopup::font):
  • WebCoreSupport/QtMaemoWebPopup.cpp: (WebCore::Maemo5Popup::populateList): (WebCore::QtMaemoWebPopup::QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::QtMaemoWebPopup::createPopup): (WebCore::QtMaemoWebPopup::show): (WebCore::QtMaemoWebPopup::popupClosed): (WebCore::QtMaemoWebPopup::itemClicked): (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup): (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
  • WebCoreSupport/QtMaemoWebPopup.h: (WebCore::Maemo5Popup::Maemo5Popup):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createSelectInputMethod):
  • WebCoreSupport/QtPlatformPlugin.h:
  • WebCoreSupport/SearchPopupMenuQt.cpp: Added. (WebCore::SearchPopupMenuQt::SearchPopupMenuQt): (WebCore::SearchPopupMenuQt::popupMenu): (WebCore::SearchPopupMenuQt::saveRecentSearches): (WebCore::SearchPopupMenuQt::loadRecentSearches): (WebCore::SearchPopupMenuQt::enabled):
  • WebCoreSupport/SearchPopupMenuQt.h: Added.
3:37 AM Changeset in webkit [64828] by bulach@chromium.org
  • 38 edits
    13 copies
    3 adds in trunk

2010-08-05 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Initial bindings and plumbing for IDBCursor.
​https://bugs.webkit.org/show_bug.cgi?id=41888

Test: storage/indexeddb/idb-opencursor.html

  • storage/indexeddb/open-cursor-expected.txt: Added.
  • storage/indexeddb/open-cursor.html: Added.
  • storage/indexeddb/script-tests/open-cursor.js: Added. (cursorSuccess): (openCursor): (populateObjectStore): (createObjectStoreSuccess): (openSuccess): (test):

2010-08-05 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Initial bindings and plumbing for IDBCursor.
​https://bugs.webkit.org/show_bug.cgi?id=41888

Test: storage/indexeddb/idb-opencursor.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbCursor): (WebCore::IDBAny::set):
  • storage/IDBAny.h: (WebCore::IDBAny::):
  • storage/IDBCallbacks.h:
  • storage/IDBCursor.cpp: Added. (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::~IDBCursor): (WebCore::IDBCursor::direction): (WebCore::IDBCursor::key): (WebCore::IDBCursor::value): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: Added. (WebCore::IDBCursor::): (WebCore::IDBCursor::create):
  • storage/IDBCursor.idl: Added.
  • storage/IDBCursorBackendImpl.cpp: Added. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::direction): (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
  • storage/IDBCursorBackendImpl.h: Added. (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBCursorBackendInterface.h: Added. (WebCore::IDBCursorBackendInterface::~IDBCursorBackendInterface):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
  • storage/IDBRequest.h:

2010-08-05 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Initial bindings and plumbing for IDBCursor.
​https://bugs.webkit.org/show_bug.cgi?id=41888

Test: storage/indexeddb/idb-opencursor.html

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • public/WebIDBCursor.h: Added. (WebKit::WebIDBCursor::~WebIDBCursor): (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBKeyRange.h: Added. (WebKit::WebIDBKeyRange::~WebIDBKeyRange): (WebKit::WebIDBKeyRange::WebIDBKeyRange):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::openCursor):
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBCursorBackendProxy.cpp: Added. (WebCore::IDBCursorBackendProxy::create): (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy): (WebCore::IDBCursorBackendProxy::~IDBCursorBackendProxy): (WebCore::IDBCursorBackendProxy::direction): (WebCore::IDBCursorBackendProxy::key): (WebCore::IDBCursorBackendProxy::value): (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
  • src/IDBCursorBackendProxy.h: Added.
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBCursorImpl.cpp: Added. (WebKit::WebIDBCursorImpl::WebIDBCursorImpl): (WebKit::WebIDBCursorImpl::~WebIDBCursorImpl): (WebKit::WebIDBCursorImpl::direction): (WebKit::WebIDBCursorImpl::key): (WebKit::WebIDBCursorImpl::value): (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
  • src/WebIDBCursorImpl.h: Added.
  • src/WebIDBKeyRange.cpp: Added. (WebKit::WebIDBKeyRange::WebIDBKeyRange): (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::reset): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::flags):
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
3:33 AM Changeset in webkit [64827] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Refactor identifier parsing in lexer
​https://bugs.webkit.org/show_bug.cgi?id=41845

Reviewed by Darin Adler.

The code is refactored to avoid gotos. The new code
has the same performance as the old one.

SunSpider --parse-only: no change (from 34.0ms to 33.6ms)
SunSpider: no change (from 523.2ms to 523.5ms)

  • parser/Lexer.cpp:

(JSC::Lexer::parseIdent):
(JSC::Lexer::lex):

  • parser/Lexer.h:
3:16 AM Changeset in webkit [64826] by andreip@google.com
  • 2 edits in trunk/WebCore

2010-08-06 Andrei Popescu <​andreip@google.com>

Unreviewed, release build fix.

Leopard relase build is broken due to absolute path to JSIDBTransaction.cpp file present in XCode project file.
​https://bugs.webkit.org/show_bug.cgi?id=43616

  • WebCore.xcodeproj/project.pbxproj:
3:00 AM Changeset in webkit [64825] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-08-06 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Add support for the Android viewport meta tag extensions.
​http://webkit.org/b/43567

  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::didReceiveViewportArguments):
2:42 AM Changeset in webkit [64824] by andreip@google.com
  • 26 edits
    2 copies
    2 adds in trunk

2010-08-05 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IndexedDB is missing the Transaction interface.
​https://bugs.webkit.org/show_bug.cgi?id=42970

Add IDBTransaction boilerplate.

No new tests, not functional yet.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::canSuspend): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
  • storage/IDBTransaction.cpp: Added. (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::~IDBTransaction): (WebCore::IDBTransaction::mode): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
  • storage/IDBTransaction.h: Added. (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::): (WebCore::IDBTransaction::toIDBTransaction): (WebCore::IDBTransaction::refEventTarget): (WebCore::IDBTransaction::derefEventTarget):
  • storage/IDBTransaction.idl: Added.
  • storage/IDBTransactionBackendInterface.h: Added. (WebCore::IDBTransactionBackendInterface::~IDBTransactionBackendInterface):

2010-08-05 Andrei Popescu <​andreip@dhcp-172-16-14-12.lon.corp.google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] IndexedDB is missing the Transaction interface.
​https://bugs.webkit.org/show_bug.cgi?id=42970

Add IDBTransaction boilerplate.

  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
1:45 AM Changeset in webkit [64823] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-06 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Regression (64735) build fix for efl.
​https://bugs.webkit.org/show_bug.cgi?id=43564

Removing bindings/js/ScriptArray.cpp from the WebCore_SOURCES.
No new features, so no new tests.

  • CMakeLists.txt:
1:42 AM Changeset in webkit [64822] by jochen@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-06 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Pavel Feldman.

Rietvield's upload.py moved to a different location.
​https://bugs.webkit.org/show_bug.cgi?id=43613

  • Scripts/webkitpy/thirdparty/init.py:
1:15 AM Changeset in webkit [64821] by pfeldman@chromium.org
  • 10 edits
    1 copy
    1 add in trunk/LayoutTests

2010-08-06 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium test expectations rebaseline.

  • platform/chromium-linux/fast/text/stripNullFromText-expected.checksum:
  • platform/chromium-linux/fast/text/stripNullFromText-expected.png: Added.
  • platform/chromium-linux/fast/text/stripNullFromText-expected.txt:
  • platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
  • platform/chromium-mac/fast/text/stripNullFromText-expected.checksum:
  • platform/chromium-mac/fast/text/stripNullFromText-expected.png:
  • platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/fast/text/stripNullFromText-expected.checksum:
  • platform/chromium-win/fast/text/stripNullFromText-expected.png:
  • platform/chromium-win/fast/text/stripNullFromText-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
12:47 AM MathML 3 testsuite results edited by François Sausset
(diff)

Aug 5, 2010:

11:50 PM Changeset in webkit [64820] by ap@apple.com
  • 5 edits in trunk

Fix http/tests/webarchive/test-css-url-encoding-shift-jis.html

For some reason, I didn't see the failure locally, but bots complain.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register "shift-jis" (with dash instead of underscore). At least Firefox supports it.
10:57 PM Changeset in webkit [64819] by benm@google.com
  • 3 edits
    2 adds in trunk

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

  • fast/css/visibility-collapse-form-buttons-expected.txt: Added.
  • fast/css/visibility-collapse-form-buttons.html: Added.

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from
visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

A relayout is required after toggling visibility from collapse to another value.

Test: fast/css/visibility-collapse-form-buttons.html

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another

visibility value (or vice versa) then we need to trigger a relayout.

10:50 PM Changeset in webkit [64818] by loki@webkit.org
  • 4 edits in trunk/JavaScriptCore

The ARM JIT does not support JSValue32_64 with RVCT
​https://bugs.webkit.org/show_bug.cgi?id=43411

Reviewed by Gavin Barraclough.

JSValue32_64 is enabled for RVCT by default.

  • create_jit_stubs:
  • jit/JITStubs.cpp:

(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):

  • wtf/Platform.h:
10:36 PM Changeset in webkit [64817] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43554
Way too many encoding aliases are treated as valid

<rdar://problem/7863399> Garbage characters displayed in some yesky.com pages.

<rdar://problem/7859068> Garbage characters displayed for most text at ceping.zhaopin.com

Test: http/tests/misc/bad-charset-alias.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Fix encoding name length computation. Previously, a trailing quote was ignored by TextEncodingRegistry.


  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added dashes to alias names that didn't have them. Added aliases prompted by regression tests.
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::registerEncodingNames): Don't register 8859-1, other browsers do not support this encoding name.
  • platform/text/TextEncoding.cpp: (WebCore::Latin1Encoding): "Latin-1" is not a real encoding name, it's not known to Firefox or IE.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): Changed to no longer ignore non-alphanumeric characters. There is a good chance that we'll be missing support for some necessary alias names, but other browsers don't ignore any characters when matching names. (WebCore::TextEncodingNameHash::hash): Ditto. (WebCore::checkExistingName): Re-formatted a line. (WebCore::isUndesiredAlias): Added a filter to reject "8859_1" and any names containing commas. (WebCore::addToTextEncodingNameMap): Used it. (WebCore::atomicCanonicalTextEncodingName): Changed to no longer ignore non-alphanumeric characters.
10:08 PM Changeset in webkit [64816] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Temporary files should not be created in the current directory
​https://bugs.webkit.org/show_bug.cgi?id=43562

Don't create temporary files in the current directory, use QDir::tempPath()
instead, as suggested by the QTemporaryFile documentation.

  • platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
9:50 PM Changeset in webkit [64815] by commit-queue@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

2010-08-05 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by Nikolas Zimmermann.

SVG - numeric overflow for very large elements
​https://bugs.webkit.org/show_bug.cgi?id=25645

Rebaselining results for gtk/win platforms.
Skip pattern-excessive-malloc.svg on GTK for now.

  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
  • platform/gtk/Skipped: Modified.
  • platform/win/svg/custom/massive-coordinates-expected.txt: Added.
9:11 PM Changeset in webkit [64814] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Make STIX font the default one to render MathML
​https://bugs.webkit.org/show_bug.cgi?id=41961

  • css/mathml.css: (math):
8:47 PM Changeset in webkit [64813] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Apply a stylistic fix to the patch 62640.
​https://bug-41175-attachments.webkit.org/attachment.cgi?id=62640
​https://bugs.webkit.org/show_bug.cgi?id=41175

  • WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (getImageData):
7:57 PM WebKit Team edited by Girish Ramakrishnan
(diff)
7:51 PM Changeset in webkit [64812] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Make SearchPopupMenuWin more portable
​https://bugs.webkit.org/show_bug.cgi?id=43527

Add #if PLATFORM(CF) around CoreFoundation code.

  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
7:17 PM Changeset in webkit [64811] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

2010-08-05 Jessie Berlin <​jberlin@apple.com>

Reviewed by Jon Honeycutt.

Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
​https://bugs.webkit.org/show_bug.cgi?id=43593

  • WebView.cpp: (WebView::backingStore): If m_backingStoreBitmap is NULL, return E_FAIL.
6:54 PM Changeset in webkit [64810] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/WebCore

2010-08-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r63653.
​http://trac.webkit.org/changeset/63653
​https://bugs.webkit.org/show_bug.cgi?id=43592

regressed multiple background-images (Requested by smfr on
#webkit).

  • manual-tests/css3-background-layer-count.html: Removed.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): (WebCore::InheritedFlags::adjustMaskLayers):
6:38 PM Changeset in webkit [64809] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix some leaks seen on the buildbot.

Reviewed by Jon Honeycutt.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::paintToCanvas): Adopt the newly-created CoreGraphics objects rather than sharing ownership
and over-incrementing their reference count. Also cleaned up the bizarre wrapping used for function arguments while I was
touching this code.

6:23 PM Changeset in webkit [64808] by rniwa@webkit.org
  • 4 edits
    3 adds
    29 deletes in trunk/LayoutTests

2010-08-05 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
​https://bugs.webkit.org/show_bug.cgi?id=43580

Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.

  • editing/deleting/delete-4038408-fix-expected.txt: Added.
  • editing/deleting/delete-4038408-fix.html: Converted.
  • editing/deleting/delete-br-011-expected.txt: Added.
  • editing/deleting/delete-br-011.html: Converted.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Converted.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
  • platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
6:09 PM Changeset in webkit [64807] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-08-05 James Robinson <​jamesr@chromium.org>

Rubber stamped by Eric Seidel.

[SVG] SVGPathSeg.cpp needs an #if ENABLE(SVG) guard
​https://bugs.webkit.org/show_bug.cgi?id=43599

Matches the rest of the .cpp files in this directory.

  • svg/SVGPathSeg.cpp:
5:56 PM Changeset in webkit [64806] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Update Qt result showing that we strip nulls in this case.

  • platform/qt/fast/text/stripNullFromText-expected.txt:
5:46 PM Changeset in webkit [64805] by arv@chromium.org
  • 4 edits
    2 adds in trunk

2010-08-05 Erik Arvidsson <​arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
​https://bugs.webkit.org/show_bug.cgi?id=43582

  • fast/forms/setCustomValidity-expected.txt: Added.
  • fast/forms/setCustomValidity.html: Added.

2010-08-05 Erik Arvidsson <​arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
​https://bugs.webkit.org/show_bug.cgi?id=43582

Test: fast/forms/setCustomValidity.html

  • html/ValidityState.cpp: (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
  • html/ValidityState.h:
5:41 PM Changeset in webkit [64804] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Chao-ying Fu <​fu@mips.com>

Reviewed by Darin Adler.

Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS
​https://bugs.webkit.org/show_bug.cgi?id=43514

MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that
RenderArena::allocate() can return 8-byte aligned memory to avoid
exceptions on sdc1/ldc1.

  • wtf/Platform.h:
5:31 PM Changeset in webkit [64803] by weinig@apple.com
  • 12 edits in trunk

Add ability to get a JSValueRef for a node handle and a world
​https://bugs.webkit.org/show_bug.cgi?id=43591

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Add exports.

WebKit2:

  • Add API to get a JSValueRef for a world, node and frame (the frame is currently necessary to pick the right globalObject for the node wrapper).
  • Add API to a JSGlobalContextRef for a world and a frame.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetJavaScriptContextForWorld):
(WKBundleFrameGetJavaScriptWrapperForNodeForWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::coreNode):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::coreWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsContext):
(WebKit::WebFrame::jsContextForWorld):
(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebFrame.h:
5:24 PM Changeset in webkit [64802] by Joseph Pecoraro
  • 2 edits in trunk/WebKit/mac

2010-08-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Remove Invalid Asserts for Application Cache Quotas
​https://bugs.webkit.org/show_bug.cgi?id=43585

Removed Invalid ASSERTs that would always happen for quotas
that were not noQuota().

  • WebView/WebPreferences.mm: (-[WebPreferences applicationCacheTotalQuota]): (-[WebPreferences applicationCacheDefaultOriginQuota]):
5:20 PM Changeset in webkit [64801] by barraclough@apple.com
  • 286 edits in trunk

Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).

Rubber stamped by Sam Weinig

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.h:
  • bindings/cpp/WebDOMCString.h:
  • bindings/cpp/WebDOMString.h:
  • bindings/gobject/ConvertToUTF8String.h:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JavaScriptCallFrame.h:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptSourceProvider.h:
  • bindings/js/ScriptString.h:
  • bindings/js/WorkerScriptController.h:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/v8/ScheduledAction.h:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.h:
  • bridge/c/c_utility.h:
  • css/CSSFontSelector.h:
  • css/CSSHelper.h:
  • css/CSSOMUtils.h:
  • css/CSSPrimitiveValue.h:
  • css/MediaList.h:
  • css/StyleBase.h:
  • css/StyleSheetList.h:
  • css/WebKitCSSKeyframesRule.h:
  • dom/CheckedRadioButtons.h:
  • dom/DOMImplementation.h:
  • dom/DocumentMarker.h:
  • dom/DynamicNodeList.h:
  • dom/EventTarget.h:
  • dom/MessagePort.h:
  • dom/MessagePortChannel.h:
  • dom/NameNodeList.h:
  • dom/Node.h:
  • dom/NodeList.h:
  • dom/OptionGroupElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/SelectElement.h:
  • dom/ViewportArguments.h:
  • dom/make_names.pl:
  • editing/HTMLInterchange.h:
  • editing/htmlediting.h:
  • editing/markup.h:
  • html/CollectionCache.h:
  • html/DOMFormData.h:
  • html/DataGridColumnList.h:
  • html/DateComponents.h:
  • html/FileStream.h:
  • html/FileStreamProxy.h:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):

  • html/HTMLCollection.h:
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.h:
  • html/HTMLParserQuirks.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptRunnerHost.h:
  • html/StepRange.h:
  • html/canvas/CanvasGradient.h:
  • html/canvas/CanvasNumberArray.h:
  • html/canvas/CanvasPattern.h:
  • inspector/InjectedScript.h:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorClient.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorValues.h:
  • inspector/ScriptDebugListener.h:
  • loader/CachedResourceClient.h:
  • loader/CrossOriginAccessControl.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/RedirectScheduler.h:
  • loader/SubframeLoader.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/ArchiveFactory.h:
  • loader/icon/IconDatabaseClient.h:
  • notifications/NotificationPresenter.h:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Console.h:
  • page/ContextMenuClient.h:
  • page/DOMSelection.h:
  • page/EditorClient.h:
  • page/EventHandler.h:
  • page/FrameView.h:
  • page/GeolocationPositionCache.h:
  • page/History.h:
  • page/Location.h:
  • page/Navigator.h:
  • page/NavigatorBase.h:
  • page/PluginHalterClient.h:
  • page/PrintContext.h:
  • page/SpeechInput.h:
  • page/SpeechInputListener.h:
  • page/animation/AnimationController.h:
  • platform/CookieJar.h:
  • platform/CrossThreadCopier.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/Language.h:
  • platform/Length.h:
  • platform/LinkHash.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.h:
  • platform/Logging.h:
  • platform/Pasteboard.h:
  • platform/PopupMenuClient.h:
  • platform/SearchPopupMenu.h:
  • platform/Widget.h:
  • platform/cf/BinaryPropertyList.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/cocoa/KeyEventCocoa.h:
  • platform/graphics/Color.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontData.h:
  • platform/graphics/FontSelector.h:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Icon.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/Path.h:
  • platform/graphics/StringTruncator.h:
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/cairo/FontPlatformData.h:
  • platform/graphics/cg/FontPlatformData.h:
  • platform/graphics/cg/ImageSourceCG.h:
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wince/MediaPlayerPrivateWince.h:
  • platform/graphics/wince/MediaPlayerProxy.h:
  • platform/graphics/wx/FontCustomPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/mac/PasteboardHelper.h:
  • platform/network/DNS.h:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.h:
  • platform/text/Hyphenation.h:
  • platform/text/LineEnding.h:
  • platform/text/TextCodec.h:
  • platform/text/TextEncoding.h:
  • platform/text/TextStream.h:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/WCDataObject.h:
  • platform/win/WebCoreTextRenderer.h:
  • plugins/DOMMimeType.h:
  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.h:
  • plugins/DOMPluginArray.h:
  • rendering/CounterNode.h:
  • rendering/HitTestResult.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.h:
  • rendering/TextControlInnerElements.h:
  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.h:
  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseTrackerClient.h:
  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.h:
  • storage/Storage.h:
  • storage/chromium/DatabaseObserver.h:
  • svg/SVGAnimatedTemplate.h:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGNumberList.h:
  • svg/SVGPointList.h:
  • svg/SVGPreserveAspectRatio.h:
  • svg/SVGStylable.h:
  • svg/SVGTests.h:
  • svg/SVGTransformList.h:
  • svg/SVGTransformable.h:
  • svg/SVGVKernElement.h:
  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketHandshakeResponse.h:
  • wml/WMLErrorHandling.h:
  • wml/WMLPageState.h:
  • wml/WMLVariables.h:
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorkerRepository.h:
  • workers/Worker.h:
  • workers/WorkerContextProxy.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerLocation.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerThread.h:
  • xml/DOMParser.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.h:
  • xml/XPathNSResolver.h:
  • xml/XPathResult.h:
  • xml/XPathUtil.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/chromium:

  • public/WebCString.h:
  • public/WebString.h:
  • src/DOMUtilitiesPrivate.h:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.h:
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.h:
  • src/WebPageSerializerImpl.h:

WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.h:

WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.h:
  • WebCoreSupport/InspectorClientHaiku.h:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/WebBaseNetscapePluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebView/WebViewInternal.h:

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

  • COMVariantSetter.h:
  • MarshallingHelpers.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebPluginHalterClient.h:
  • WebHistory.h:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.h:
  • WebKitSupport/InspectorClientWx.h:

WebKit2:

  • UIProcess/PageClient.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • UIProcess/win/WebView.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:
5:13 PM Changeset in webkit [64800] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed leak seen on buildbot.

Reviewed by Mark Rowe.

  • runtime/GCActivityCallbackCF.cpp:

(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()): Make out timer a RetainPtr,
since anything less would be uncivilized.

5:12 PM Changeset in webkit [64799] by abarth@webkit.org
  • 9 edits
    4 adds in trunk

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

U+0000 is turned to U+FFFD (replacement character)
​https://bugs.webkit.org/show_bug.cgi?id=42112

Update test results to show null stripping. These changes are mostly
going back to the old results we had before we added the FFFD
replacement.

  • fast/dom/stripNullFromTextNodes-expected.txt:
  • fast/tokenizer/null-in-text-expected.txt: Added.
  • fast/tokenizer/null-in-text.html: Added.
  • fast/tokenizer/null-xss-expected.txt: Added.
  • fast/tokenizer/null-xss.html: Added.
    • The main risk with stripping null characters is that they'll be used in XSS attacks. This test shows that we don't strip null characters from tag names.
  • platform/mac/fast/text/stripNullFromText-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/rgb-color-parser-expected.txt:

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

U+0000 is turned to U+FFFD (replacement character)
​https://bugs.webkit.org/show_bug.cgi?id=42112

This patch introduces an intentional parsing difference from the HTML5
parsing specificiation. The spec requires us to convert NULL
characters to U+FFFD, but doing so causes compatibility issues with a
number of sites, including US Bank.

In this patch, we strip the null characters instead in certain cases.
Firefox has made a corresponding change. After gathering compatability
data, we hope to convince the HTML WG to adopt this change.

Tests: fast/tokenizer/null-in-text.html

fast/tokenizer/null-xss.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::setSkipLeadingNewLineForListing): (WebCore::HTMLTokenizer::forceNullCharacterReplacement): (WebCore::HTMLTokenizer::setForceNullCharacterReplacement): (WebCore::HTMLTokenizer::shouldSkipNullCharacters): (WebCore::HTMLTokenizer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTagForInBody):
5:08 PM Changeset in webkit [64798] by aestes@apple.com
  • 11 edits in trunk

JavaScriptCore: Rename iOS-related OS and PLATFORM macros.
​https://bugs.webkit.org/show_bug.cgi?id=43493

Reviewed by David Kilzer.

Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.

  • jit/ExecutableAllocator.h:
  • jit/JITStubs.cpp:
  • profiler/ProfilerServer.mm:

(-[ProfilerServer init]):

  • wtf/FastMalloc.cpp:

(WTF::TCMallocStats::):

  • wtf/Platform.h:
  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

WebCore: Rename iOS-related OS and PLATFORM macros.
​https://bugs.webkit.org/show_bug.cgi?id=43493

Reviewed by David Kilzer.

Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.

  • platform/cocoa/KeyEventCocoa.mm:
  • platform/iphone/KeyEventIPhone.mm:
  • platform/network/Credential.h:
5:00 PM Changeset in webkit [64797] by andersca@apple.com
  • 13 edits in trunk

Use the visited link provider for visited links
​https://bugs.webkit.org/show_bug.cgi?id=43583

Reviewed by Sam Weinig.

WebCore:

Export Page::visitedStateChanged and Page::allvisitedStateChanged.

  • WebCore.exp.in:

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Remove AddVisitedLink.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

(WebProcessProxyMessage::):
Remove PopulateVisitedLinks and add AddVisitedLink.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
Initialize the main run loop before creating the context.

(WebKit::WebContext::sharedThreadContext):
Ditto.

(WebKit::WebContext::create):
Ditto.

(WebKit::WebContext::WebContext):
Initialize the visited link provider.

(WebKit::WebContext::processDidFinishLaunching):
Ask the visited link provider to populate visited links.

(WebKit::WebContext::addVisitedLink):
Ask the visited link provider to add the visited link.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addVisitedLink):
Call WebContext::addVisitedLink.

(WebKit::WebProcessProxy::didReceiveMessage):
Handle AddVisitedLink.

(WebKit::WebProcessProxy::didFinishLaunching):
Call WebContext::processdidFinishLaunching.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::populateVisitedLinks):
Don't send the WebProcessProxyMessage::PopulateVisitedLinks message.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::isLinkVisited):
Call WebProcess::isLinkVisited.

(WebKit::WebPlatformStrategies::addVisitedLink):
Call WebProcess::addVisitedLink.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setVisitedLinkTable):
Create a shared memory object and tell the visited link table about it.

(WebKit::WebProcess::visitedLinkStateChanged):
Go through the link hashes and call Page::visitedStateChanged.

(WebKit::WebProcess::allVisitedLinkStateChanged):
Call Page::allVisitedStateChanged.

(WebKit::WebProcess::isLinkVisited):
Call VisitedLinkTable::isLinkVisited.

(WebKit::WebProcess::addVisitedLink):
Inform the UI process about the added link.

(WebKit::WebProcess::didReceiveMessage):
Handle new messages.

4:52 PM Changeset in webkit [64796] by abarth@webkit.org
  • 7 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

js-test-pre.js's escapeHTML should escape null characters so we can see them
​https://bugs.webkit.org/show_bug.cgi?id=43579

  • fast/canvas/canvas-getContext-invalid-expected.txt:
  • fast/js/null-char-in-string-expected.txt:
  • fast/js/resources/js-test-pre.js: (escapeHTML):
  • fast/js/switch-behaviour-expected.txt:
  • storage/domstorage/complex-values-expected.txt:
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt:
4:22 PM Changeset in webkit [64795] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add missing include path.

  • win/WebKit2Common.vsprops:
4:11 PM Changeset in webkit [64794] by brettw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Brett Wilson <​brettw@chromium.org>

Reviewed by Nate Chapin.

Make the webkit unit tests depend on test_support_base
​https://bugs.webkit.org/show_bug.cgi?id=43584

  • WebKit.gyp:
3:55 PM CommitterTips edited by ojan@chromium.org
(diff)
3:55 PM Changeset in webkit [64793] by eric@webkit.org
  • 22 edits
    1 add in trunk/WebCore

2010-08-05 Eric Seidel <​eric@webkit.org>

Reviewed by Nikolas Zimmermann.

Touching SVGNames should only rebuild hundreds of files, not thousands
​https://bugs.webkit.org/show_bug.cgi?id=43308

Remove SVGNames.h include from several core SVG header files
which do not need to include it.

One of them, SVGPathSeg.h, required creation of an SVGPathSeg.cpp.
A bunch of SVGPathSeg* could remove PlatformString.h includes if
we moved their toString() methods into the .cpp files.

I re-indented on header to stop check-webkit-style from complaining.
I removed a couple mode lines I saw, since my understanding from
previous webkit-dev threads is that we plan to remove those all.

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAngle.h:
  • svg/SVGPathSeg.cpp: Added. (WebCore::SVGPathSeg::~SVGPathSeg): (WebCore::SVGPathSeg::pathSegType): (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString): (WebCore::SVGPathSeg::associatedAttributeName): (WebCore::SVGPathSegSingleCoord::toString):
  • svg/SVGPathSeg.h: (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
  • svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArc::toString):
  • svg/SVGPathSegArc.h: (WebCore::SVGPathSegArc::SVGPathSegArc):
  • svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create): (WebCore::SVGPathSegClosePath::pathSegType): (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter): (WebCore::SVGPathSegClosePath::toString):
  • svg/SVGPathSegCurvetoCubic.h:
  • svg/SVGPathSegCurvetoCubicSmooth.h:
  • svg/SVGPathSegCurvetoQuadratic.h:
  • svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • svg/SVGPathSegLineto.h:
  • svg/SVGPathSegLinetoHorizontal.h:
  • svg/SVGPathSegLinetoVertical.h:
  • svg/SVGPathSegMoveto.h:
  • svg/SVGTransform.h:
3:38 PM Changeset in webkit [64792] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Export WKError.h

Rubberstamped by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
3:29 PM Changeset in webkit [64791] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Correct vcproj nesting.

  • win/WebKit2.vcproj:
3:22 PM Changeset in webkit [64790] by commit-queue@webkit.org
  • 11 edits in trunk/JavaScriptCore

2010-08-05 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=43464

Currently, the global object is being embedded in the JavaScriptCore
bytecode, however since the global object is the same for all opcodes
in a code block, we can have the global object just be a member of the
associated code block.

Additionally, I added an assert inside of emitOpcode that verifies
that the last generated opcode was of the correct length.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock):
  • bytecode/Opcode.h: (JSC::opcodeLength):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitOpcode):

Added an assert to check that the last generated opcode is the
correct length.

(JSC::BytecodeGenerator::rewindBinaryOp):

Changed the last opcode to op_end since the length will no longer
be correct.

(JSC::BytecodeGenerator::rewindUnaryOp):

Changed the last opcode to op_end since the length will no longer
be correct.

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitPutScopedVar):
(JSC::BytecodeGenerator::emitResolveWithBase):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global):
  • jit/JITStubs.cpp: (JSC::cti_op_resolve_global):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo):
2:49 PM Changeset in webkit [64789] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
2:32 PM Changeset in webkit [64788] by weinig@apple.com
  • 8 edits
    4 adds in trunk/WebKit2

Add script world API for injected bundles
​https://bugs.webkit.org/show_bug.cgi?id=43577

Reviewed by Gavin Barraclough.

  • Shared/APIObject.h:

(WebKit::APIObject::):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp: Added.

(WKBundleScriptWorldGetTypeID):
(WKBundleScriptWorldCreateWorld):
(WKBundleScriptWorldNormalWorld):
(WKBundleScriptWorldRetain):
(WKBundleScriptWorldRelease):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: Added.

(WebKit::allWorlds):
(WebKit::InjectedBundleScriptWorld::create):
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::InjectedBundleScriptWorld):
(WebKit::InjectedBundleScriptWorld::~InjectedBundleScriptWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Added.

(WebKit::InjectedBundleScriptWorld::type):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
2:28 PM Changeset in webkit [64787] by eric@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-05-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

QueueStatusServer needs better queue-status pages
​https://bugs.webkit.org/show_bug.cgi?id=39562

The primary goal of this patch is to display queue
positions somewhere on the site so that it's easier
for commit-queue users to know when their pach will
be landed. I also tried to improve the root page
to be more useful than the previous wall of status text.

  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/recentstatus.html:
2:24 PM Changeset in webkit [64786] by victorw@chromium.org
  • 5 edits in trunk/WebKitTools

2010-08-05 Victor Wang <​victorw@chromium.org>

Reviewed by Ojan Vafai.

Add option to generate/upload incremental json results to test result server.
Also refactor the json results generator unittest code to test
incremental and aggregated json results.

​https://bugs.webkit.org/show_bug.cgi?id=43519

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:10 PM Changeset in webkit [64785] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Adam Barth <​abarth@webkit.org>

Actually make HTMLEntityNames.json valid JSON.

  • html/HTMLEntityNames.json:
2:10 PM Changeset in webkit [64784] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=43574

  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [64783] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=43516 REGRESSION:
Huge number of memory leaks after enabling MathML
-and corresponding-
<rdar://problem/8274123>

Reviewed by Kenneth Rohde Christiansen.

Destroy the old children in
RenderMathMLOperator::updateFromElement() instead of just removing
them since just removing them will cause them to leak.

  • mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):

1:57 PM Changeset in webkit [64782] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Bug 43185 - Switch RegisterFile over to use PageAllocation

Reviewed by Sam Weinig.

Remove platform-specific memory allocation code.

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::~RegisterFile):
(JSC::RegisterFile::releaseExcessCapacity):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
(JSC::RegisterFile::checkAllocatedOkay):

  • wtf/PageAllocation.cpp:

(WTF::PageAllocation::lastError):

  • wtf/PageAllocation.h:

(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::isPageAligned):
(WTF::PageAllocation::isPowerOfTwo):

  • wtf/PageReservation.h:

(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):

1:40 PM Changeset in webkit [64781] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

  • platform/gtk/Skipped: Skip some more failing Sputnik tests.
1:32 PM Changeset in webkit [64780] by tony@chromium.org
  • 6 edits
    3 adds in trunk

2010-08-05 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
​https://bugs.webkit.org/show_bug.cgi?id=42724

  • scrollbars/hidden-iframe-scrollbar-crash2.html: Added.
  • scrollbars/resources/hidden-iframe-scrollbar-crash2.html: Added.

2010-08-05 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
​https://bugs.webkit.org/show_bug.cgi?id=42724

Test: scrollbars/hidden-iframe-scrollbar-crash2.html

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): Pass in Frame (WebCore::RenderScrollbar::RenderScrollbar): Pass in Frame (WebCore::RenderScrollbar::owningRenderer): Use the frame to get the RenderBox (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): null check (WebCore::RenderScrollbarPart::computeScrollbarHeight): null check
1:27 PM Changeset in webkit [64779] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Chromium.

WebInspector: inspector/debugger-breakpoints-not-activated-on-reload.html
was regressed. I'll fix it tomorrow.
​https://bugs.webkit.org/show_bug.cgi?id=43574

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [64778] by weinig@apple.com
  • 8 edits
    5 adds in trunk/WebKit2

Reviewed Anders Carlsson.

Add DOM Node wrapper class for injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=43524

  • This class should not expose any DOM APIs, but just be a handle that can be used to get a JS wrapper for the node in a specific world.
  • Shared/APIObject.h:

(WebKit::APIObject::):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: Added.

(WKBundleNodeHandleGetTypeID):
(WKBundleNodeHandleRetain):
(WKBundleNodeHandleRelease):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h: Added.
  • WebProcess/InjectedBundle/DOM: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::getDOMHandle):
(WebKit::setDOMHandle):
(WebKit::removeDOMHandle):
(WebKit::InjectedBundleNodeHandle::getOrCreate):
(WebKit::InjectedBundleNodeHandle::create):
(WebKit::InjectedBundleNodeHandle::InjectedBundleNodeHandle):
(WebKit::InjectedBundleNodeHandle::~InjectedBundleNodeHandle):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Added.

(WebKit::InjectedBundleNodeHandle::type):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
1:01 PM Changeset in webkit [64777] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Yong Li <​yoli@rim.com>

Reviewed by Adam Treat.

Fix the problem that down-sampling code doesn't work
for some GIF's. GIF reader can call setSize() multiple times.
We should clear the scaling maps before adding new entries.
Also add a fast path to check if the size has changed since last time.

​https://bugs.webkit.org/show_bug.cgi?id=43501

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::prepareScaleDataIfNecessary):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
12:58 PM Changeset in webkit [64776] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • Platform/mac/SharedMemoryMac.cpp:
12:54 PM Changeset in webkit [64775] by andersca@apple.com
  • 5 edits
    1 copy
    1 add in trunk/WebKit2

Add VisitedLinkProvider class
​https://bugs.webkit.org/show_bug.cgi?id=43570

Reviewed by Sam Weinig.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add SetVisitedLinkTable, VisitedLinkStateChanged and AllVisitedLinkStateChanged.

  • UIProcess/VisitedLinkProvider.cpp: Added.

(WebKit::VisitedLinkProvider::VisitedLinkProvider):
Initialize table.

(WebKit::VisitedLinkProvider::populateVisitedLinksIfNeeded):
Ask the context to populate visited links.

(WebKit::VisitedLinkProvider::addVisitedLink):
Add the link hash to the set of pending visited links and start the timer.

(WebKit::nextPowerOf2):
Add helper function.

(WebKit::tableSizeForKeyCount):
Given a key count, returns a table size. The table size is always a power of two, and
is chosen so that the table is always at least half empty.

(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
First, check if we need to resize the hash table and allocate new shared memory for it if that is the case.
Then, go through the pending link hash vector and insert all the elements in the table. Finally, notify the web
process about visited links whose state have changed.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
Add case statements.

  • win/WebKit2.vcproj:
  • WebKit2.xcodeproj/project.pbxproj:

Add VisitedLinkProvider.cpp and VisitedLinkProvider.h.

12:44 PM Changeset in webkit [64774] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

  • platform/gtk/Skipped: Adding some more sputnik failures from the debug bot.
12:33 PM Changeset in webkit [64773] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-08-05 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=43401 where array
content aren't properly initialized as part of unshift.

  • runtime/JSArray.cpp: (JSC::JSArray::unshiftCount):

2010-08-05 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

New regression tests added as part of unshift fix for bug described
inhttps://bugs.webkit.org/show_bug.cgi?id=43401.

  • fast/js/script-tests/unshift-multi.js: Added.
  • fast/js/unshift-multi-expected.txt: Added.
  • fast/js/unshift-multi.html: Added.
12:24 PM Changeset in webkit [64772] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/JavaScriptAudioNode.cpp

fixes for buffer size in JavaScriptAudioNode

  • keep buffer size within reasonable min/max range
  • fix initialization error
12:24 PM Changeset in webkit [64771] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioContext.cpp

Fix AudioContext initialization to avoid unpredictable pauses

12:17 PM Changeset in webkit [64770] by loislo@chromium.org
  • 18 edits in trunk/WebCore

2010-08-05 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: In the current implementation of inspector agents we're calling
did methods manually. That is error prone and is bad from protocol point of view.
It would be better to call did methods automatically from the corresponding methods
of InspectorBackendDispatcher and report the results. As far as our protocol is
statefull this trick will keep it in the consistent state.
​https://bugs.webkit.org/show_bug.cgi?id=43489

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::releaseWrapperObjectGroup): (WebCore::InspectorBackend::getDatabaseTableNames):
  • inspector/InspectorBackend.h:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::inspectorStyleSheet):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::editScriptSource): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::asNumber): (WebCore::InspectorBasicValue::asNumber):
  • inspector/InspectorValues.h:
  • inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processCallback): (WebInspector.Callback.prototype.removeCallbackEntry):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
12:11 PM Changeset in webkit [64769] by Martin Robinson
  • 2 edits
    6 adds in trunk/LayoutTests

2010-08-05 Martin Robinson <​mrobinson@igalia.com>

[GTK] Some sputnik tests fail
​https://bugs.webkit.org/show_bug.cgi?id=43568

Unskip the majority of the Sputnik tests. Most of them are passing
and a few just needed GTK+ baselines showing that they pass.

  • platform/gtk/Skipped: Skip remaining failures.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
11:58 AM Changeset in webkit [64768] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add VisitedLinkTable class
​https://bugs.webkit.org/show_bug.cgi?id=43566

Reviewed by Sam Weinig.

  • Shared/VisitedLinkTable.cpp: Added.

(WebKit::VisitedLinkTable::VisitedLinkTable):
(WebKit::VisitedLinkTable::~VisitedLinkTable):
Add out of line constructors so we won't have to include SharedMemory.h in the
VisitedLinkTable.h header.

(WebKit::isPowerOf2):
Add helper function.

(WebKit::VisitedLinkTable::setSharedMemory):
Set the new shared memory and update the table size and hash.

(WebKit::doubleHash):
Add helper function from the WTF HashTable.

(WebKit::VisitedLinkTable::addLinkHash):
Add a link hash to the table.

(WebKit::VisitedLinkTable::isLinkVisited):
See if there is an entry for the given link hash.

  • Shared/VisitedLinkTable.h: Added.

(WebKit::VisitedLinkTable::sharedMemory):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add VisitedLinkTable.cpp and VisitedLinkTable.h

11:33 AM Changeset in webkit [64767] by kbr@google.com
  • 28 edits in trunk

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Style cleanups in WebGL
​https://bugs.webkit.org/show_bug.cgi?id=38761

Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/WebGraphicsContext3DDefaultImpl.cpp:
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-08-04 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Style cleanups in WebGL
​https://bugs.webkit.org/show_bug.cgi?id=38761

Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.

  • html/canvas/ArrayBuffer.cpp: (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
  • html/canvas/ArrayBufferView.cpp: (WebCore::ArrayBufferView::setImpl):
  • html/canvas/ArrayBufferView.h:
  • html/canvas/TypedArrayBase.h:
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): (WebCore::WebGLBuffer::associateBufferData):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::~WebGLBuffer): (WebCore::WebGLBuffer::elementArrayBuffer): (WebCore::WebGLBuffer::getTarget): (WebCore::WebGLBuffer::isBuffer):
  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::deleteObjectImpl):
  • html/canvas/WebGLFramebuffer.h: (WebCore::WebGLFramebuffer::~WebGLFramebuffer): (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached): (WebCore::WebGLFramebuffer::isFramebuffer):
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject):
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::object): (WebCore::WebGLObject::detachContext): (WebCore::WebGLObject::context): (WebCore::WebGLObject::isBuffer): (WebCore::WebGLObject::isFramebuffer): (WebCore::WebGLObject::isProgram): (WebCore::WebGLObject::isRenderbuffer): (WebCore::WebGLObject::isShader): (WebCore::WebGLObject::isTexture):
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl):
  • html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::~WebGLProgram): (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag): (WebCore::WebGLProgram::isProgram):
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl):
  • html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::~WebGLRenderbuffer): (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat): (WebCore::WebGLRenderbuffer::isInitialized): (WebCore::WebGLRenderbuffer::setInitialized): (WebCore::WebGLRenderbuffer::isRenderbuffer):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::beginPaint): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::vertexAttribPointer):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::is3d): (WebCore::WebGLRenderingContext::isAccelerated): (WebCore::WebGLRenderingContext::graphicsContext3D): (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall): (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): (WebCore::WebGLRenderingContext::VertexAttribState::initValue):
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl):
  • html/canvas/WebGLShader.h: (WebCore::WebGLShader::~WebGLShader): (WebCore::WebGLShader::getType): (WebCore::WebGLShader::isShader):
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::~WebGLTexture): (WebCore::WebGLTexture::isCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::setCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::isTexture): (WebCore::WebGLTexture::LevelInfo::LevelInfo): (WebCore::WebGLTexture::LevelInfo::setInfo):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): (WebCore::GraphicsContext3D::Attributes::Attributes): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::platformLayer):
11:19 AM Changeset in webkit [64766] by jianli@chromium.org
  • 19 edits in trunk/LayoutTests

Update test results caused by r64763.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
11:12 AM WebKitGTK edited by Martin Robinson
Small language cleanup (diff)
11:03 AM Changeset in webkit [64765] by andersca@apple.com
  • 3 edits
    3 adds in trunk/WebKit2

Add shared memory abstraction
​https://bugs.webkit.org/show_bug.cgi?id=43535
<rdar://problem/8275295>

Reviewed by Adam Roben.

  • Platform/SharedMemory.h: Added.

(WebKit::SharedMemory::):
(WebKit::SharedMemory::size):
Return the size, in bytes, of the shared memory object.

(WebKit::SharedMemory::data):
Return a pointer to the shared memory object.

  • Platform/mac/SharedMemoryMac.cpp: Added.

(WebKit::SharedMemory::Handle):
A shared memory handle, which can be passed in a CoreIPC Connection.

(WebKit::SharedMemory::create):
Allocate the shared memory.

(WebKit::SharedMemory::~SharedMemory):
Deallocate the shared memory.

(WebKit::SharedMemory::createHandle):
Create a mach port and pass it to the handle.

(WebKit::SharedMemory::systemPageSize):
Return the system page size, in bytes.

  • Platform/win/SharedMemoryWin.cpp: Added.

Add stubbed out version.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add files.

10:50 AM Changeset in webkit [64764] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make the viewport meta tag parser support the Android
target-densitydpi extension.
​http://webkit.org/b/43492

​http://developer.android.com/reference/android/webkit/WebView.html
Section 'Building web pages to support different screen densities'

  • dom/ViewportArguments.cpp: (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate):
  • dom/ViewportArguments.h: (WebCore::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
10:42 AM Changeset in webkit [64763] by jianli@chromium.org
  • 49 edits in trunk

Unify blob related feature defines to ENABLE(BLOB).
​https://bugs.webkit.org/show_bug.cgi?id=43081

Reviewed by David Levin.

.:

  • cmakeconfig.h.cmake:
  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExceptionCode.h:

(WebCore::):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • html/Blob.cpp:
  • html/Blob.h:
  • html/Blob.idl:
  • html/FileError.h:
  • html/FileError.idl:
  • html/FileReader.cpp:
  • html/FileReader.h:
  • html/FileReader.idl:
  • html/FileStream.cpp:

(WebCore::FileStream::openForRead):

  • html/FileStream.h:
  • html/FileStreamClient.h:
  • html/FileStreamProxy.cpp:
  • html/FileStreamProxy.h:
  • html/FileThread.cpp:
  • html/FileThread.h:
  • page/DOMWindow.idl:
  • platform/BlobItem.cpp:

(WebCore::getFileSnapshotModificationTime):
(WebCore::DataBlobItem::slice):
(WebCore::FileBlobItem::slice):

  • platform/BlobItem.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendItem):
(WebCore::FormData::appendKeyValuePairItems):

  • platform/network/FormData.h:

(WebCore::operator==):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):

WebKit/chromium:

  • features.gypi:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
10:25 AM Changeset in webkit [64762] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
10:14 AM Changeset in webkit [64761] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Remove GHashTable left-overs. GHashTable is ref-counted, and is
correctly supported by GRefPtr.

  • wtf/gobject/GOwnPtr.h:
10:06 AM Changeset in webkit [64760] by kov@webkit.org
  • 2 edits in trunk

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Move files that are generated by the configure script to
DISTCLEANFILES, where they should be. This fixes building after a
make clean.

  • GNUmakefile.am:
10:06 AM Changeset in webkit [64759] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-05 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed.

Typo fix that makes distcheck happy.

  • GNUmakefile.am:
9:57 AM Changeset in webkit [64758] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

When trying to wrap a Node we know is an Element fallback to a
simple Element wrapper in the worst case, not to Node.

  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper):
9:52 AM Changeset in webkit [64757] by jorlow@chromium.org
  • 17 edits
    13 adds in trunk/LayoutTests

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Updated test expectations for speech input in the chromium port
​https://bugs.webkit.org/show_bug.cgi?id=43563

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:30 AM Changeset in webkit [64756] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Nico Weber <​thakis@chromium.org>

Reviewed by Jeremy Orlow.

Remove useless const on return-by-value (fixes a clang warning)
​https://bugs.webkit.org/show_bug.cgi?id=43491

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformKeyboardEventType):
9:23 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:10 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:07 AM Debugging With Visual Studio edited by Adam Roben
(diff)
9:00 AM Debugging With Visual Studio created by Adam Roben
8:58 AM Changeset in webkit [64755] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-08-05 Balazs Kelemen <​kb@inf.u-szeged.hu>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Remove redundant include paths from WebKit2.pro.

  • WebKit2.pro:
8:55 AM Changeset in webkit [64754] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Jeremy Orlow <​jorlow@chromium.org>

Don't skip speech tests.

  • platform/chromium/test_expectations.txt:
8:43 AM WikiStart edited by Adam Roben
(diff)
8:33 AM Changeset in webkit [64753] by commit-queue@webkit.org
  • 8 edits in trunk

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Add test for basic values of the MathML mathvariant attribute
​https://bugs.webkit.org/show_bug.cgi?id=43481

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-08-05 François Sausset <François Sausset>

Reviewed by Kenneth Rohde Christiansen.

Implement basic values of MathML mathvariant attribute
​https://bugs.webkit.org/show_bug.cgi?id=43481

Test: mathml/presentation/attributes.xhtml

  • css/mathml.css: (math[mathvariant="normal"], mstyle[mathvariant="normal"], mo[mathvariant="normal"], mn[mathvariant="normal"], mi[mathvariant="normal"], mtext[mathvariant="normal"], mspace[mathvariant="normal"], ms[mathvariant="normal"]): (math[mathvariant="bold"], mstyle[mathvariant="bold"], mo[mathvariant="bold"], mn[mathvariant="bold"], mi[mathvariant="bold"], mtext[mathvariant="bold"], mspace[mathvariant="bold"], ms[mathvariant="bold"]): (math[mathvariant="italic"], mstyle[mathvariant="italic"], mo[mathvariant="italic"], mn[mathvariant="italic"], mi[mathvariant="italic"], mtext[mathvariant="italic"], mspace[mathvariant="italic"], ms[mathvariant="italic"]): (math[mathvariant="bold-italic"], mstyle[mathvariant="bold-italic"], mo[mathvariant="bold-italic"], mn[mathvariant="bold-italic"], mi[mathvariant="bold-italic"], mtext[mathvariant="bold-italic"], mspace[mathvariant="bold-italic"], ms[mathvariant="bold-italic"]):
  • mathml/mathattrs.in:
8:29 AM Changeset in webkit [64752] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-08-05 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Use correct path for Inspector data files in GTK+3.x builds
​https://bugs.webkit.org/show_bug.cgi?id=43445

Use the right data path for inspector files when building with
GTK+ 3.x.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
8:16 AM Changeset in webkit [64751] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium test expectations update.

  • platform/chromium/test_expectations.txt:
7:48 AM Changeset in webkit [64750] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-05 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing pixel test results for svg/in-html test.

  • platform/mac/svg/in-html/circle-expected.checksum: Added.
  • platform/mac/svg/in-html/circle-expected.png: Added.
7:40 AM Changeset in webkit [64749] by jorlow@chromium.org
  • 17 edits
    7 adds in trunk

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

  • fast/speech/input-text-speechbutton-expected.txt: Added.
  • fast/speech/input-text-speechbutton.html: Added.
  • fast/speech/script-tests/input-text-speechbutton.js: Added. (onChange): (run):

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

  • WebKit.gyp:
  • public/WebSpeechInputControllerMock.h: Added WebKit speech input controller mock interface.
  • src/WebSpeechInputControllerMockImpl.cpp: Added implementation of the above mock. (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording): (WebKit::WebSpeechInputControllerMock::create):

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add speech input controller mock in WebKit and a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=43477

Added LayoutTestController::setMockSpeechInputResultCallback method.

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback): Wrapper invoking the member function. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockSpeechInputResult): Sets the mock result. (LayoutTestController::speechInputController): Creates the mock controller.
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): Creates the mock controller.
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
7:39 AM Changeset in webkit [64748] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Skip new debugger test on Qt.

  • platform/qt/Skipped:
7:32 AM Changeset in webkit [64747] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
​https://bugs.webkit.org/show_bug.cgi?id=43558

Test: inspector/debugger-cyclic-ref.html

  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
​https://bugs.webkit.org/show_bug.cgi?id=43558

  • inspector/debugger-cyclic-ref-expected.txt: Added.
  • inspector/debugger-cyclic-ref.html: Added.
7:28 AM Changeset in webkit [64746] by jorlow@chromium.org
  • 10 edits
    3 moves
    14 adds
    4 deletes in trunk

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Fix rendering of speech button and enable layout tests
​https://bugs.webkit.org/show_bug.cgi?id=43425

Added layout and pixel test expecations for speech button on chromium-linux and chromium-mac.
Also enabled the relevant layout tests on these platforms.
Non chromium ports don't have the feature flag enabled and the code does not get compiled in yet,
so there are no test expectations for those ports.

  • fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton-expected.txt: Removed.
  • fast/speech/input-appearance-speechbutton.html:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Removed.
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Removed.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Removed.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Removed.

2010-08-05 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Fix rendering of speech button and enable layout tests
​https://bugs.webkit.org/show_bug.cgi?id=43425

Rewrote the speech button rendering code to match how the spin buttons (for input type=number)
are implemented as the previous implementation did not work well on many platforms.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create):
  • rendering/TextControlInnerElements.h:
7:23 AM Changeset in webkit [64745] by commit-queue@webkit.org
  • 7 edits in trunk

2010-08-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Re-enabling inspector/extension* tests following a fix in InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=43344

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-08-05 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Separated WebInspector extension API injection logic from other scripts that inspector injects.
Enabled injection of the API scripts even if inspector is disabled for inspector front-end page.
​https://bugs.webkit.org/show_bug.cgi?id=43344

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setInspectorExtensionAPI):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
7:16 AM QtScript edited by kent.hansen@nokia.com
(diff)
7:02 AM Changeset in webkit [64744] by Adam Roben
  • 11 edits in trunk

Get WebKitTestRunner loading TestNetscapePlugin on Windows

Fixes <​http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
load TestNetscapePlugin

Reviewed by Jon Honeycutt.

WebKit2:

Teach WebKit2 how to load the TestNetscapePlugin

  • Platform/Module.cpp:

(WebKit::Module::Module): Initialize m_module on Windows.

  • Platform/Module.h: Added m_module on Windows.
  • Platform/win/ModuleWin.cpp:

(WebKit::Module::load): Implemented using ::LoadLibraryExW.
(WebKit::Module::unload): Implemented using ::FreeLibrary.
(WebKit::Module::platformFunctionPointer): Implemented using
::GetProcAddress.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Kill the native timer before calling
the fired callback. This makes all our timers non-repeating, but
that's all we need currently.
(RunLoop::TimerBase::start): Added an assertion to help us figure out
when we need to implement repeating timers. Also fixed a typo.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::pluginsDirectories): Added a FIXME.

(WebKit::PathWalker::PathWalker):
(WebKit::PathWalker::~PathWalker):
(WebKit::PathWalker::isValid):
(WebKit::PathWalker::data):
(WebKit::PathWalker::step):
Added. This class wraps the ::FindFirstFile/::FindNextFile APIs.

(WebKit::PluginInfoStore::pluginPathsInDirectory): Implemented by
porting logic from
WebCore::PluginDatabase::getPluginPathsInDirectories.
(WebKit::getVersionInfo): Copied from PluginDatabaseWin.cpp.
(WebKit::PluginInfoStore::getPluginInfo): Implemented by porting logic
from WebCore::PluginPackage::fetchInfo.
(WebKit::PluginInfoStore::shouldUsePlugin): Changed to always return
true for now. Added a FIXME about implementing this for real.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Removed PLATFORM(MAC) guards around plugin code.

  • win/WebKit2.vcproj: Let VS sort the file.

WebKitTools:

Fix the path to TestNetscapePlugin's directory on Windows

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeTestPluginDirectory):
TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
next to WebKitTestRunner.exe. Previously we were passing the directory
that contains WebKitTestRunner.exe. Also fixed some leaks.

6:41 AM Changeset in webkit [64743] by commit-queue@webkit.org
  • 6 edits in trunk/WebKitTools

2010-08-05 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

check-webkit-style returns non-zero when patch is entirely minus lines.
​https://bugs.webkit.org/show_bug.cgi?id=38169

  • Scripts/check-webkit-style: Check whether a patch contains modified files that are entirely minus lines.
  • Scripts/webkitpy/style/filereader.py: Add a variable that holds number of files that contain only deleted lines.
  • Scripts/webkitpy/style/patchreader.py: Count up modified files that contain only deleted lines.
6:30 AM Changeset in webkit [64742] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: [REGRESSION] Frame navigation is not handled in devtools.

​https://bugs.webkit.org/show_bug.cgi?id=43556

  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
6:27 AM Changeset in webkit [64741] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. More chromium test rebaselines.

  • platform/chromium/test_expectations.txt:
6:19 AM Changeset in webkit [64740] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=43469
<noscript> is working wrong in some cases when xhtmlmp is enabled.

  • fast/xhtmlmp/noscript-basic-expected.txt: Added.
  • fast/xhtmlmp/noscript-basic.xhtml: Added.

2010-08-05 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

<noscript> is working the other way around in some cases with xhtmlmp enabled
​https://bugs.webkit.org/show_bug.cgi?id=43469

Test: fast/xhtmlmp/noscript-basic.xhtml

  • dom/Document.cpp: (WebCore::Document::Document):
6:05 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
5:58 AM Changeset in webkit [64739] by antti.j.koivisto@nokia.com
  • 3 edits in trunk/WebKit2

Use toCopiedRef for making WK objects
​https://bugs.webkit.org/show_bug.cgi?id=43552

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/cpp/qt/WKStringQt.cpp:

(WKStringCreateWithQString):

  • UIProcess/API/cpp/qt/WKURLQt.cpp:

(WKURLCreateWithQUrl):

5:50 AM Changeset in webkit [64738] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Fix Win compilation.

  • bindings/js/JSBindingsAllInOne.cpp:
5:44 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:40 AM Changeset in webkit [64737] by Simon Hausmann
  • 6 edits in trunk

[Qt] Clean up the input method handling
​https://bugs.webkit.org/show_bug.cgi?id=43545

Reviewed by Tor Arne Vestbø.

WebCore:

Changed input method hint interface to be more efficient by setting
all hints in one shot, like in QWidget.

  • platform/qt/QWebPageClient.h:

WebKit/qt:

Replace the way of individually setting input method hints by
many calls to QWidget::setInputMethodHints with one single call.

This is more efficient by requiring less updates in the input
method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setInputMethodHints):
(WebCore::PageClientQGraphicsWidget::setInputMethodHints):

  • WebCoreSupport/PageClientQt.h:
5:37 AM Changeset in webkit [64736] by pfeldman@chromium.org
  • 2 edits
    10 adds
    1 delete in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. More chromium test rebaselines.

  • platform/chromium-linux/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-linux/svg/in-html/circle-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-mac/svg/in-html/circle-expected.png: Added.
  • platform/chromium-win/svg/in-html/circle-expected.checksum: Added.
  • platform/chromium-win/svg/in-html/circle-expected.png: Added.
  • platform/chromium-win/svg/in-html/circle-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:36 AM Changeset in webkit [64735] by yurys@chromium.org
  • 17 edits
    4 deletes in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove mutator methods from ScriptObject and remove ScriptArray.
We shouldn't modify JS objects from InspectorController, InspectorValues
should be used instead.
​https://bugs.webkit.org/show_bug.cgi?id=43546

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptArray.cpp: Removed.
  • bindings/js/ScriptArray.h: Removed.
  • bindings/js/ScriptCallStack.h:
  • bindings/js/ScriptObject.cpp:
  • bindings/js/ScriptObject.h:
  • bindings/v8/ScriptArray.cpp: Removed.
  • bindings/v8/ScriptArray.h: Removed.
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/ScriptObject.h:
4:54 AM Changeset in webkit [64734] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-05 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Darin Adler.

~5% complex layout performance improvement.
​https://bugs.webkit.org/show_bug.cgi?id=43436

  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use Vector rather than CFMutableData. (WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText): Ditto. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Avoid typesetter allocation unless using typesetter options.
4:34 AM Changeset in webkit [64733] by johnnyg@google.com
  • 2 edits in trunk/WebKit/chromium

2010-08-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] WebFileChooserParams should have default constructor
​https://bugs.webkit.org/show_bug.cgi?id=43435

  • public/WebFileChooserParams.h: (WebKit::WebFileChooserParams::WebFileChooserParams):
4:24 AM MathML 3 testsuite results edited by François Sausset
(diff)
4:19 AM Changeset in webkit [64732] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-08-05 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

targetReferenceFromResource() in SVGResources.cpp is missing an ENABLE(FILTERS) guard
​https://bugs.webkit.org/show_bug.cgi?id=43550

Also updates an existing ENABLE(FILTERS) guard to avoid a compiler
warning 'case FilterResourceType not handled in switch' when FILTERS
is not enabled.

No new tests, build fix only.

  • rendering/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::SVGResources::resourceDestroyed):
4:15 AM Changeset in webkit [64731] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-05 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Added logic to use glMapTexSubImage2D to write video layer to GPU
texture. Also fixes CPU usage problem from previous patch.
​https://bugs.webkit.org/show_bug.cgi?id=43101

No change in user-visible functionality (since it isn't turned on),
so no new tests.

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect): (WebCore::VideoLayerChromium::updateCompleted):
  • platform/graphics/chromium/VideoLayerChromium.h:

2010-08-05 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Added a repaint request so that VideoLayerChromium does not have
a flickering problem when playing video.
​https://bugs.webkit.org/show_bug.cgi?id=43101

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
3:55 AM Changeset in webkit [64730] by pfeldman@chromium.org
  • 26 edits
    3 adds in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Chromium expectations update.

3:00 AM Changeset in webkit [64729] by pfeldman@chromium.org
  • 14 edits in trunk

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

DevTools: get rid of delayed command dispatching on front-end side.

​https://bugs.webkit.org/show_bug.cgi?id=43479

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::frontendLoaded):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DevTools.js: (WebInspector.doLoadedDone):
  • src/js/Tests.js: (.uiTests.runTest):

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

DevTools: get rid of delayed command dispatching on front-end side.

​https://bugs.webkit.org/show_bug.cgi?id=43479

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::detach): (DRTDevToolsAgent::frontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::sendFrontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
2:56 AM Changeset in webkit [64728] by pfeldman@chromium.org
  • 141 edits
    39 adds in trunk/LayoutTests

2010-08-05 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rebaselined a bunch of chromium layout tests after the parser switch.

​https://bugs.webkit.org/show_bug.cgi?id=43547

2:25 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
2:25 AM Changeset in webkit [64727] by Simon Hausmann
  • 1 edit in trunk/WebKit/qt/tests/qwebview/tst_qwebview.cpp

Remove stray debug output

2:25 AM Changeset in webkit [64726] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for ClipperData struct
​https://bugs.webkit.org/show_bug.cgi?id=43337

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderSVGResourceClipper.cpp:165

  • rendering/RenderSVGResourceClipper.h:
2:19 AM Changeset in webkit [64725] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

[Qt] Input mode states are not reset after entering a password field
​https://bugs.webkit.org/show_bug.cgi?id=43530

Patch by David Leong <​david.leong@nokia.com> on 2010-08-05
Reviewed by Simon Hausmann.

Input mode hints are not reset if clicking on password <input> elements then
clicking on <textarea> elements

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • tests/qwebview/resources/input_types.html:
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes):

2:06 AM Changeset in webkit [64724] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for DoctypeData class
​https://bugs.webkit.org/show_bug.cgi?id=43343

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
DoctypeData - html/HTMLToken.h:113

  • html/HTMLToken.h:
1:45 AM Changeset in webkit [64723] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 François Sausset <François Sausset>

Reviewed by Darin Adler.

Small style adjustments for MathML merror element.
​https://bugs.webkit.org/show_bug.cgi?id=43432

  • css/mathml.css: (merror):
1:31 AM Changeset in webkit [64722] by yurys@chromium.org
  • 12 edits in trunk/WebCore

2010-08-05 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: forbid InspectorController to create script objects directly in the frontend
​https://bugs.webkit.org/show_bug.cgi?id=43541

Cookie and AppCache data are now serialized into InspectorValues instead of
ScriptObjects. These were last usages of InspectorFrontend::newScript{Object,Array}
so we can remove them now and use only InspectorValues to pass data to the inspector
frontend.

  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::setRecordingProfile):
  • inspector/InspectorFrontend.h:
12:55 AM Changeset in webkit [64721] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
​https://bugs.webkit.org/show_bug.cgi?id=43418

Ensure the renderer is a RenderText before calling toRenderText()

Also, simplified code a bit to avoid so many nested if's in that
part of the code, while keeping the same logic.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange):
12:36 AM Changeset in webkit [64720] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-05 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Define htonl, htons, ntohl and ntohs
​https://bugs.webkit.org/show_bug.cgi?id=43397

In BREWMP, AEEStdLib.h provides macros for byte order conversion: HTONL, HTONS, NTOHL and NTOHS.
Use these macros to define htonl, htons, ntohl and ntohs used by WOFFFileFormat.cpp.

  • platform/graphics/WOFFFileFormat.cpp:
12:11 AM Changeset in webkit [64719] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

residual-style-hang times out on Gtk
​https://bugs.webkit.org/show_bug.cgi?id=43540

Skip fast/parser/residual-style-hang.html on Gtk. Hopefully someone
with access to a Gtk machine can help us understand why this is
hanging. There's (a little) more information in the bug page.

  • platform/gtk/Skipped:
12:11 AM Changeset in webkit [64718] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-04 Kenichi Ishibashi <​bashi@google.com>

Reviewed by Shinichiro Hamaji.

Fixes check-webkit-style false positive on "new uint32_t."
​https://bugs.webkit.org/show_bug.cgi?id=43077

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:01 AM Changeset in webkit [64717] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-08-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a test for SVG-in-HTML
​https://bugs.webkit.org/show_bug.cgi?id=43539

Just a basic test that we can render SVG in HTML.

  • platform/mac/svg/in-html/circle-expected.txt: Added.
  • svg/in-html/circle.html: Added.
Note: See TracTimeline for information about the timeline view.