Timeline
Sep 15, 2010:
- 10:47 PM Changeset in webkit [67598] by
-
- 3 edits in trunk/WebKit/chromium
Overload WebHTTPBody::appendFileRange() to take a double modification time argument.
https://bugs.webkit.org/show_bug.cgi?id=45829
Reviewed by Darin Fisher.
The plan is to change all callers of
WebHTTPBody::appendFileRange(..., const WebFileInfo&) to use the
new method, and then remove it.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
- 7:45 PM Changeset in webkit [67597] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2 should be able to encode and decode objects of type APIObject::TypeURL.
https://bugs.webkit.org/show_bug.cgi?id=45819
- Shared/UserMessageCoders.h: Add the ability to encode and decode the URL type. (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
- 7:18 PM Changeset in webkit [67596] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
[GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
https://bugs.webkit.org/show_bug.cgi?id=45865
When initializing the backForwardList private member of the WebView, do
so with adoptPlatformRef to prevent a memory leak.
- webkit/webkitwebview.cpp: (webkit_web_view_init): Initialize member with adoptPlatformRef.
- 7:15 PM Changeset in webkit [67595] by
-
- 2 edits in trunk/WebKit2
Add user message coding for WebUInt64 type.
Reviewed by Jon Honeycutt.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- 6:52 PM Changeset in webkit [67594] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Unreviewed.
Only show the review-in-context link if there are contextual comments.
- code-review.js:
- 6:50 PM Changeset in webkit [67593] by
-
- 3 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
We should save messages that can't be sent when postMessageToInjectedBundle is called and
send them in ensureWebProcess.
https://bugs.webkit.org/show_bug.cgi?id=45822
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Post any messages to the Injected Bundle that couldn't be sent earlier because the WebProcess hadn't been initialized yet. (WebKit::WebContext::postMessageToInjectedBundle):
- UIProcess/WebContext.h:
- 6:48 PM Changeset in webkit [67592] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Show the status bubbles on the toolbar
https://bugs.webkit.org/show_bug.cgi?id=45861
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 6:34 PM Changeset in webkit [67591] by
-
- 7 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Use GOwnPtr for code that needs it
https://bugs.webkit.org/show_bug.cgi?id=21594
Convert as reference counted private members of WebKitWebView to
smart pointers as possible. This removes a lot of unecessary manual
memory management. Also convert some pointer members away from pointer
types, now that we are sure their destructors are called.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Ditto.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::handleInputMethodKeydown): Ditto. (WebKit::EditorClient::handleInputMethodMousePress): Ditto. (WebKit::EditorClient::EditorClient): Ditto. (WebKit::EditorClient::~EditorClient): Ditto.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Ditto.
- webkit/webkitprivate.h: Ditto.
- webkit/webkitwebview.cpp: Ditto. (destroy_menu_cb): Ditto. (webkit_web_view_forward_context_menu_event): Ditto. (webkit_web_view_key_release_event): Ditto. (webkit_web_view_button_press_event): Ditto. (webkit_web_view_button_release_event): Ditto. (webkit_web_view_focus_in_event): Ditto. (webkit_web_view_focus_out_event): Ditto. (webkit_web_view_realize): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Changed all g_object_unref calls to PlatformRefPtr.clear(). Although this will also be done by the manual call to the WebKitWebViewPrivate destructor, the order that these fields are zero'd in is still very sensitive. (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes. (webViewGetDPI): Ditto. (webkit_web_view_screen_changed): Ditto. (webkit_web_view_drag_end): Ditto. (webkit_web_view_drag_data_get): Ditto. (doDragLeaveLater): Ditto. (webkit_web_view_drag_leave): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto. (webkit_web_view_get_im_context): Ditto. (webkit_web_view_update_settings): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_set_settings): Ditto. (webkit_web_view_get_settings): Ditto. (webkit_web_view_get_inspector): Ditto. (webkit_web_view_set_window_features): Ditto. (webkit_web_view_get_window_features): Ditto. (webkit_web_view_get_back_forward_list): Ditto. (webkit_web_view_zoom_in): Ditto. (webkit_web_view_zoom_out): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_get_main_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_get_subresources): Ditto.
- 6:19 PM Changeset in webkit [67590] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Allow setting review and commit-queue flags from main review screen
https://bugs.webkit.org/show_bug.cgi?id=45860
This patch adds drop down menus for adjusting the review and
commit-queue flags from the main review screen. These controls don't
appear immediately because we need to read the state of the flags off
the details page.
It's a slight sadness that bugzilla doesn't have a clean way of
identifying which select control is associated with a given flag. The
flags seem to have some sort of id, but it's unclear to me how to map
that id back to a notion of "review" or "commit-queue". Instead, we
look for some magic strings in the title. I'm sure this will come back
to bit us at some point, but I'm not sure what to do that's better.
(The webkitpy solution to this problem is to assume that the flags are
in a given order, but this seems better.)
- PrettyPatch/PrettyPatch.rb:
- Bump version number to bust throuh caches.
- code-review.js:
- 6:13 PM Changeset in webkit [67589] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
<rdar://problem/8214099> Mousewheel scrolling in WebKit2 is wonky
Use floats so that fractional scrollwheel deltas don't get lost.
- Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
- 5:40 PM Changeset in webkit [67588] by
-
- 3 edits in trunk/WebKitTools
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- 5:30 PM Changeset in webkit [67587] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-09-15 John Gregg <johnnyg@google.com>
Unreviewed, build fix after incomplete revert.
Remove layout test added in 67570 that wasn't reverted in 67574.
https://bugs.webkit.org/show_bug.cgi?id=45854
- fast/css/test-setting-canvas-color-expected.txt: Removed.
- fast/css/test-setting-canvas-color.html: Removed.
- 5:29 PM Changeset in webkit [67586] by
-
- 1 edit in trunk/ChangeLog
2010-09-15 Eric Seidel <eric@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 5:09 PM Changeset in webkit [67585] by
-
- 4 edits in trunk/WebKitTools
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] sort testing methods in DRT
https://bugs.webkit.org/show_bug.cgi?id=45850
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController):
- 5:05 PM Changeset in webkit [67584] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
CQ status shows items out of order
https://bugs.webkit.org/show_bug.cgi?id=45846
Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.
Also don't indent status items that only have a single item in their
group.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
- QueueStatusServer/templates/queuestatus.html:
- 5:05 PM Changeset in webkit [67583] by
-
- 10 edits in trunk/JavaScriptCore
2010-09-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Use free variable analysis to improve activation performance
https://bugs.webkit.org/show_bug.cgi?id=45837
Adds free and captured variable tracking to the JS parser. This
allows us to avoid construction of an activation object in some
cases. Future patches will make more use of this information to
improve those cases where activations are still needed.
- parser/ASTBuilder.h:
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::useVariable): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::capturedVariables): (JSC::JSParser::ScopeRef::ScopeRef): (JSC::JSParser::ScopeRef::operator->): (JSC::JSParser::ScopeRef::index): (JSC::JSParser::currentScope): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::parseProgram): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parsePrimaryExpression):
- parser/Nodes.cpp: (JSC::ScopeNodeData::ScopeNodeData): (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
- parser/Nodes.h: (JSC::ScopeNode::needsActivation): (JSC::ScopeNode::hasCapturedVariables):
- parser/Parser.cpp: (JSC::Parser::didFinishParsing):
- parser/Parser.h: (JSC::Parser::parse):
- parser/SyntaxChecker.h:
- runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h: (JSC::ScriptExecutable::needsActivation): (JSC::ScriptExecutable::recordParse):
- 5:04 PM Changeset in webkit [67582] by
-
- 8 edits in trunk/WebKitTools
2010-09-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.
There are also a few PEP8 changes needed to pass check-webkit-style.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 4:56 PM Changeset in webkit [67581] by
-
- 7 edits in trunk/WebKit2
Add WKUInt64Ref wrapper for sending uint64_ts.
Reviewed by Jon Honeycutt.
- Shared/APIObject.h:
- Shared/WebNumber.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetTypeID):
(WKUInt64Create):
(WKUInt64GetValue):
(WKUInt64SetValue):
- UIProcess/API/C/WKNumber.h:
- 4:51 PM Changeset in webkit [67580] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Simon Fraser <Simon Fraser>
https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url
Fix MiniBrowser crash when the url is not parseable.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]):
- 4:43 PM Changeset in webkit [67579] by
-
- 2 edits in trunk/WebCore
2010-09-15 Simon Fraser <Simon Fraser>
Fix chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- 4:30 PM Changeset in webkit [67578] by
-
- 28 edits1 add in branches/audio/WebCore
audio branch: lots of changes in preparation for moving to trunk
- more HRTF cleanup (added HRTFUtilities.cpp file)
- general cleanup AudioDestinationMac, AudioFileReaderMac, AudioResourcesMac
- added locking mechanism to AudioContext which is used by AudioNode
- removed some unnecessary method argument names in header files
- 4:29 PM Changeset in webkit [67577] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 4:27 PM Changeset in webkit [67576] by
-
- 18 edits in trunk
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44715
maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
be taken care of in platform code without the need to complicate the GraphicsLayer API.
RenderLayerCompositor no longer sets the geometry orientation for the root
platform layer; platform-specific code does this instead.
This fixes flipped layers in WebKit2, since WebKit2 was already flipping
geometry, and then RenderLayerCompositor was doing an additional flip.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::defaultContentsOrientation):
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
- platform/graphics/qt/GraphicsLayerQt.h:
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
- platform/graphics/win/GraphicsLayerCACF.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::setRootChildLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 4:25 PM Changeset in webkit [67575] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Comments should quote previous comments on the same line
https://bugs.webkit.org/show_bug.cgi?id=45847
Now when you reply to a previous comment, the tool will quote the
previous comment in the bugs.webkit.org post. This makes it eaiser for
folks following along in email to understand the discussion.
While I was editing this code, I also cleaned up some of the whitespace
handling in comments.
- code-review.js:
- 4:01 PM WebKit Team edited by
- (diff)
- 3:57 PM Changeset in webkit [67574] by
-
- 9 edits in trunk
Unreviewed.
Reverting my changes as it is breaking several tests on Gtk and Qt.
- 3:55 PM Changeset in webkit [67573] by
-
- 2 edits in trunk
[wx] Build fixes for wxMSW.
- 3:43 PM Changeset in webkit [67572] by
-
- 7 edits1 copy in trunk/WebKitTools
2010-09-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786
Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.
This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).
The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(
- QueueStatusServer/handlers/nextpatch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 3:43 PM Changeset in webkit [67571] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fix regression from bug 32230. The test needed to be updated to reflect the zoom adjusted font-size.
https://bugs.webkit.org/show_bug.cgi?id=45841
- editing/pasteboard/page-zoom.html:
- 3:31 PM Changeset in webkit [67570] by
-
- 9 edits2 adds in trunk
WebCore: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
Test: fast/css/test-setting-canvas-color.html
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
- css/CSSParser.h: Added the new parseSystemColor method.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.
- html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
LayoutTests: Test for: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
This tests that svg color, deprecated system color and different
type of colors and invalid inputs are still parsed as such.
- fast/css/test-setting-canvas-color-expected.txt: Added.
- fast/css/test-setting-canvas-color.html: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
- 3:10 PM Changeset in webkit [67569] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Minor UI tweak to the review tool. We want to display newlines in
previous and frozen comments instead of collapsing them.
- PrettyPatch/PrettyPatch.rb:
- 2:23 PM Changeset in webkit [67568] by
-
- 7 edits3 adds in trunk
2010-09-14 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230
Test: fast/css/getComputedStyle/computed-style-with-zoom.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::zoomAdjustedPixelValue): (WebCore::zoomAdjustedNumberValue): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::getBorderRadiusCornerValue): (WebCore::computedTransform): (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): (WebCore::CSSComputedStyleDeclaration::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- rendering/RenderObject.h: (WebCore::adjustForAbsoluteZoom):
- rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom):
- 12:52 PM Changeset in webkit [67567] by
-
- 4 edits2 moves4 adds in trunk/WebCore
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fully separate Pango and FreeType font backends
https://bugs.webkit.org/show_bug.cgi?id=27442
Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
Include the correct file via #ifdef'd includes, like the Chromium port. Also split
FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
compilation unit is used only by the FreeType backend. This change is important to
prevent upcoming fixes to the FreeType backend from affecting other backends.
No new tests as functionality has not changed.
- CMakeListsEfl.txt: Update source lists.
- GNUmakefile.am: Update source lists.
- platform/graphics/cairo/FontCacheCairo.cpp: Removed.
- platform/graphics/cairo/FontCacheFreeType.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::isWellKnownFontName): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/cairo/FontPlatformData.h:
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::description):
- platform/graphics/cairo/FontPlatformDataFreeType.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/gtk/FontCachePango.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/gtk/FontPlatformDataPango.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/win/FontPlatformDataCairoWin.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::useGDI): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
- 12:19 PM Changeset in webkit [67566] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=45775
Handle the toggle-overwrite signal on the GtkTextView used for generating editing
commands. Ignore this signals, as the default handler assumes that the GtkTextView
has a layout and this one does not.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): Added. Cancels the default handler. (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
- 12:16 PM Changeset in webkit [67565] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Allow for narrow columns in waterfall.
- 12:10 PM Changeset in webkit [67564] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Darken and improve contrast for success and failure boxes.
- 10:51 AM Changeset in webkit [67563] by
-
- 2 edits in trunk/LayoutTests
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Adding ellipsis-text.html to the skip list for GTK until the reason for its failure
is determined.
- platform/gtk/Skipped:
- 10:34 AM Changeset in webkit [67562] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Tony Chang <tony@chromium.org>
Unreviewed, remove test that is now passing in test_shell and DRT.
- platform/chromium/test_expectations.txt:
- 10:07 AM Changeset in webkit [67561] by
-
- 5 edits2 adds in trunk
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Reviewed by Simon Fraser.
WebCore:
Allow accessibility to retrieve the absoluteQuads of a text node that
clips to the ellipsis.
Test: accessibility/ellipsis-text.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
- rendering/RenderText.cpp:
(WebCore::ellipsisRectForBox):
Make a common method to retrieve the ellipsis rect.
(WebCore::RenderText::absoluteQuads):
Default into the absoluteQuads method that allows for ellipsis clipping.
(WebCore::RenderText::selectionRectForRepaint):
Use the common method for retrieving the ellipsis.
- rendering/RenderText.h:
LayoutTests:
- accessibility/ellipsis-text-expected.txt: Added.
- accessibility/ellipsis-text.html: Added.
- 10:05 AM Changeset in webkit [67560] by
-
- 3 edits in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=45791
Force filenames to be raw bytes before running difflib.unified_diff.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 9:44 AM Changeset in webkit [67559] by
-
- 5 edits in trunk
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Update pixel test result.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Rewrite the shadow blur function with loop unrolls and sliding step
unification for both horizontal and vertical directions.
This gives significant performance improvement on most cases.
- platform/graphics/qt/ContextShadow.cpp: (WebCore::shadowBlur):
- 9:06 AM Changeset in webkit [67558] by
-
- 3 adds1 delete in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
2010-09-15 William Siegrist <wsiegrist@apple.com>
Sync buildbot files after upgrade to v0.8.1
- 8:52 AM Changeset in webkit [67557] by
-
- 3 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
fast/dom/DeviceOrientation/add-listener-from-callback flaky
https://bugs.webkit.org/show_bug.cgi?id=45814
When we call addEventListener(), an event is sent to all registered
event listeners on that page. So in the existing test, both the calls
to setMockDeviceOrientation() and addEventListener() will trigger events
to fire asynchronously on both listeners (both will be registered by the
time the event fires), giving a total of five events. A race condition
exists as to whether the test finishes after the third event, before
the fourth event fires.
This patch fixes the problem by expecting the correct number of events
to fire. We also remove the call to setMockDeviceOrientation() as this
adds extra complication and is tested in update.html.
- fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt:
- fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: (checkOrientation): (firstListener):
- 8:35 AM Changeset in webkit [67556] by
-
- 2 edits in trunk/PlanetWebKit
Use Qt Labs' WebKit category feed instead of filtering on "webkit"
Looks like the URL of the WebKit category feed changed since this blog
was first added to Planet WebKit.
Rubber-stamped by David Kilzer.
- config.ini:
- 8:20 AM Changeset in webkit [67555] by
-
- 2 edits in trunk/PlanetWebKit
Only include Qt Labs posts that mention WebKit
All other feeds are either WebKit-specific or are filtered on
"webkit". This makes Qt Labs match all the others. This should help
keep off-topic posts off of Planet WebKit.
Fixes <http://webkit.org/b/45818> Planet WebKit contains many
off-topic posts from Qt Labs
Reviewed by David Kilzer.
- config.ini: Filter the Qt Labs feed on "webkit" like we do for all
other non-WebKit-specific feeds.
- 6:32 AM Changeset in webkit [67554] by
-
- 3 edits in trunk/WebKitTools
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247
Reviewed by Tor Arne Vestbø.
The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
- QtTestBrowser/mainwindow.h:
- 6:25 AM Changeset in webkit [67553] by
-
- 38 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:56 AM Changeset in webkit [67552] by
-
- 37 edits in trunk
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didFinishLoading):
- loader/MainResourceLoader.h:
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::finishedCallback): (WebCore::parseDataUrl):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:04 AM Changeset in webkit [67551] by
-
- 37 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 4:45 AM Changeset in webkit [67550] by
-
- 1 edit40 adds in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] rebaseline 10 new svg tests added in 67544
https://bugs.webkit.org/show_bug.cgi?id=45813
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- 4:34 AM Changeset in webkit [67549] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the Symbian def files
Re-freeze with the viewport meta tag updates.
- symbian/eabi/QtWebKitu.def:
- 4:34 AM Changeset in webkit [67548] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] mark new viewport tests as failing rather then skip them
https://bugs.webkit.org/show_bug.cgi?id=45652
- platform/chromium/test_expectations.txt:
- 4:17 AM Changeset in webkit [67547] by
-
- 10 edits in trunk
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
- 3:05 AM Changeset in webkit [67546] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Kent Tamura.
LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=45783
This test synchronously navigates the page to a new URL from its main script file.
This navigation causes WebView.onPageFinished() to be called for the test page.
The problem is that this may occur before js-test-post.js, which is included by the
test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a
result, the test is incorrectly deemed to have finished as soon as the navigation
is started and the output will therefore be incorrect.
This patch fixes the problem by initiating the page navigation from
the onload handler, which is not fired until all resources have been
loaded and parsed. This guarantees that WebView.onPageFinished() is
not called until after layoutTestController.waitUntilDone() has been
called.
- fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
- 2:44 AM Changeset in webkit [67545] by
-
- 2 edits in trunk/WebCore
2010-09-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Multiline console does not work on Windows / Linux.
https://bugs.webkit.org/show_bug.cgi?id=45807
- inspector/front-end/ConsoleView.js:
- 2:13 AM Changeset in webkit [67544] by
-
- 4 edits50 adds in trunk
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=45809
Adding layout tests for feTurbulence dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-baseFrequency-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-numOctaves-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-seed-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-stitchTiles-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-type-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-numOctaves-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-seed-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-stitchTiles-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-type-prop.js: Added. (executeTest):
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
A typo (noStich instead of nostitch) is also fixed in this patch.
https://bugs.webkit.org/show_bug.cgi?id=45809
Tests: svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
- svg/SVGFETurbulenceElement.h:
- 1:58 AM Changeset in webkit [67543] by
-
- 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp
Merge 67185 - 2010-09-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Joseph Pecoraro.
WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.
- Open any page
- Right-click on any element, select "Inspect Element"
- Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
- Inspect the Web Inspector. An error message is logged in the console.
The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/3385005
- 1:55 AM Changeset in webkit [67542] by
-
- 1 edit2 copies in branches/chromium/517
Merge 66813 - 2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
Test: inspector/debugger-suspend-active-dom-objects.html
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
- inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
- inspector/debugger-suspend-active-dom-objects.html: Added.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/3446004
- 1:46 AM Changeset in webkit [67541] by
-
- 2 edits in trunk/WebCore
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Avoid memcpy in TextCodecWinCE::encode
https://bugs.webkit.org/show_bug.cgi?id=45468
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::TextCodecWinCE::encode):
- 1:29 AM Changeset in webkit [67540] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Web Inspector] mark two debugger tests as slow on win debug chromium
https://bugs.webkit.org/show_bug.cgi?id=45742
- platform/chromium/test_expectations.txt:
- 12:20 AM Changeset in webkit [67539] by
-
- 2 edits in trunk/WebKit/mac
Roll out r67533 to fix the build.
Sep 14, 2010:
- 11:41 PM Changeset in webkit [67538] by
-
- 8 edits2 adds in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
https://bugs.webkit.org/show_bug.cgi?id=45724
No new tests; tests will be added later.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDirectoryEntryCustom.cpp: Added. (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
- bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
- fileapi/DirectoryEntry.h:
- fileapi/DirectoryEntry.idl:
- 10:59 PM Changeset in webkit [67537] by
-
- 5 edits3 adds1 delete in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline to fix build.
[chromium] rebaselines for bug16012.html after font-size changes
https://bugs.webkit.org/show_bug.cgi?id=45805
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.png: Added.
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug16012-expected.txt:
- 10:26 PM Changeset in webkit [67536] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-09-14 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline.
Rebaseline xss-DENIED-frame-name-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=45795
- platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- 10:03 PM Changeset in webkit [67535] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Attempt to fix test failure on Qt and Gtk. It's tricky to write a test
for an API that supposed to report the current date and time without a
timezone. This patch increases the allowably time window to a day +
one hour, which should be enough to account for any timezone issues.
- http/tests/misc/no-last-modified.html:
- 9:38 PM Changeset in webkit [67534] by
-
- 12 edits in trunk
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp: (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp: (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() when autocorrection panel is shown. (WebCore::createCommandMap): Replaced isSupported function pointer for executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, for invalid correction panel tag. Replaced -1 with this constant. (WebEditorClient::dismissCorrectionPanel): Ditto (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 9:09 PM Changeset in webkit [67533] by
-
- 2 edits in trunk/WebKit/mac
2010-09-14 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
- WebView/WebView.mm: (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
when the application level preferences are not set.
- 8:47 PM Changeset in webkit [67532] by
-
- 12 edits in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- fileapi/ThreadableBlobRegistry.cpp: (WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802
This patch broke GTK builds (Requested by jianli_ on #webkit).
- src/ResourceHandle.cpp:
- 8:37 PM Changeset in webkit [67531] by
-
- 2 edits in trunk/WebCore
2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Zoom factor for checkboxes and radios.
https://bugs.webkit.org/show_bug.cgi?id=45776
RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.
Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
- 8:19 PM Changeset in webkit [67530] by
-
- 1 edit3 adds in trunk/WebCore
2010-09-14 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add AudioFileReader files (Mac implementation)
https://bugs.webkit.org/show_bug.cgi?id=36475
No new tests since audio API is not yet implemented.
- platform/audio/AudioFileReader.h: Added.
- platform/audio/mac/AudioFileReaderMac.cpp: Added. (WebCore::createAudioBufferList): (WebCore::destroyAudioBufferList): (WebCore::AudioFileReader::AudioFileReader): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::readProc): (WebCore::AudioFileReader::getSizeProc): (WebCore::AudioFileReader::createBus): (WebCore::createBusFromAudioFile): (WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h: Added. (WebCore::AudioFileReader::data): (WebCore::AudioFileReader::dataSize):
- 7:31 PM Changeset in webkit [67529] by
-
- 3 edits in trunk/JavaScriptCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
https://bugs.webkit.org/show_bug.cgi?id=44764
- wtf/OwnPtrCommon.h:
- wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
- 7:04 PM Changeset in webkit [67528] by
-
- 2 edits1 add in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugs.webkit.org should autocomplete WebKit Committers and Reviewers
https://bugs.webkit.org/show_bug.cgi?id=45799
This patch implements an autocomplete dropdown that helps users type
the names of WebKit committers and reviewers. The script grabs the
data from SVN now that wms set up CORS for http://svn.webkit.org.
Security technology for the win.
This script is based on (well, essentially copied from) the popular
autocomplete extension:
https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb
I asked Ojan, and said he was fine licensing the code under the BSD
license. I'm not sure how the patch interacts with the extension, but
we can retire the extension if they interact poorly.
- committers-autocomplete.js: Added.
- template/en/default/global/footer.html.tmpl:
- Add the script to every page on bugs.webkit.org
- 6:59 PM Changeset in webkit [67527] by
-
- 2 edits in trunk/WebKitTools
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156
Move printf inside shouldDumpAccessibilityNotifications check.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- 6:55 PM Changeset in webkit [67526] by
-
- 2 edits in trunk/WebCore
2010-09-14 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
Drawing an image outside the bounds of a canvas still causes repaints
https://bugs.webkit.org/show_bug.cgi?id=45792
Some canvas examples, such as http://www.phoboslab.org/biolab/, draw
images outide the bounds of the canvas. If the canvas already had a
non-empty m_dirtyRect, such draws would cause us to do a repaint of
m_dirtyRect again (which goes through the platform-specific invalidation
machinery, which can be slow).
Optimize this by avoiding extra invalidation when the dirty rect
does not intersect the canvas bounds.
Not testable because this avoids additional repaints of m_dirtyRect, but
m_dirtyRect has to be non-empty for this to benefit.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
- 6:42 PM Changeset in webkit [67525] by
-
- 5 edits in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link
- inspector/front-end/inspector.js: code cleanup: removed no-op method (WebInspector.addMainEventListeners):
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756
- src/js/DevTools.js: remove obsolete code
- 6:26 PM BuildingGtk edited by
- (diff)
- 6:25 PM Changeset in webkit [67524] by
-
- 6 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DEPS: Include webkit_support::LocalFileToDataURL
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
- 6:23 PM Changeset in webkit [67523] by
-
- 3 edits in trunk/WebCore
2010-09-14 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Use codePage instead of TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=45466
Use codePage as member variable to avoid repeated lookup.
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode):
- platform/text/wince/TextCodecWinCE.h:
- 5:48 PM Changeset in webkit [67522] by
-
- 2 edits in trunk/BugsSite
2010-09-14 Adam Barth <abarth@webkit.org>
Add a license block to the reviewtool. I should have added this from
the start. According to the SVN log, I'm the only one to have ever
touched this file.
- code-review.js:
- 5:45 PM Changeset in webkit [67521] by
-
- 5 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- public/WebKit.h:
- src/WebKit.cpp:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
- 5:36 PM Changeset in webkit [67520] by
-
- 2 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Attempted Chromium build fix. The compiler can't tell that
ASSERT_NOT_REACHED is not reached and so it demands an initialization
of this variable.
- html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
- 5:34 PM Changeset in webkit [67519] by
-
- 3 edits in trunk/WebKit/efl
2010-09-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] ewk_frame_view_create_for_view set null as theme.
https://bugs.webkit.org/show_bug.cgi?id=45741
Add theme in ewk_view to use instead of frame's theme which is null in
ewk_frame_view_create_for_view.
- ewk/ewk_frame.cpp: (ewk_frame_view_create_for_view):
- ewk/ewk_view.cpp: (ewk_view_theme_set): (ewk_view_theme_get):
- 5:19 PM Changeset in webkit [67518] by
-
- 5 edits in trunk/WebKit/mac
Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
Reviewed by John Sullivan.
- Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
- Misc/WebKitVersionChecks.m:
(WebKitLinkedOnOrAfter):
(setWebKitLinkTimeVersion): Set the overridden version.
(WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
- WebView/WebPreferences.mm:
(+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
- WebView/WebPreferencesPrivate.h:
- 5:19 PM Changeset in webkit [67517] by
-
- 4 edits in trunk
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Remove blob-related tests that now pass.
- platform/chromium/drt_expectations.txt:
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772
Roll Chromium forward to r59406, which registers the blob
URL scheme for the Chromium DRT too.
- DEPS:
- 4:53 PM Changeset in webkit [67516] by
-
- 2 edits in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Wheeling over windowed plugins sometimes cause them to disappear
- plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::x11Event): Pass on captured mouse wheel events to the effective native window rather than the grandparent widget. We were calling QWidget::winId() which caused a new X11 window to be created for the grandparent widget and generally mess things up.
- 4:46 PM Changeset in webkit [67515] by
-
- 8 edits1 add in trunk
[wx] Build fixes after recent changes.
- 4:32 PM Changeset in webkit [67514] by
-
- 7 edits in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update font size parser to match HTML5 spec. The main difference here
is the handling of 0, which now maps to 1 instead of 3.
- html/HTMLFontElement.cpp: (WebCore::parseFontSize): (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148
Update tests and results to match new behavior.
- editing/execCommand/query-font-size-expected.txt:
- fast/dom/HTMLFontElement/script-tests/size-attribute.js:
- fast/dom/HTMLFontElement/size-attribute-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
- 4:29 PM Changeset in webkit [67513] by
-
- 3 edits5 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
Implement document.lastModified as per HTML5.
Tests: http/tests/misc/last-modified-parsing.html
http/tests/misc/no-last-modified.html
- dom/Document.cpp: (WebCore::Document::lastModified):
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475
- http/tests/misc/last-modified-parsing-expected.txt: Added.
- http/tests/misc/last-modified-parsing.html: Added.
- Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
- http/tests/misc/no-last-modified-expected.txt: Added.
- http/tests/misc/no-last-modified.html: Added.
- Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
- http/tests/resources/last-modified.php: Added.
- PHP helper script.
- 4:27 PM Changeset in webkit [67512] by
-
- 7 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Moving the compatMode IDL attribute from HTMLDocument.idl to
Document.idl fixes this bug and improve compliance with HTML5.
Test: fast/parser/compatMode-in-xhtml.xhtml
- dom/Document.cpp: (WebCore::Document::compatMode):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLDocument.cpp:
- html/HTMLDocument.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.compatModeisundefinedwhen usingapplication/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422
Test the value of compatMode in XHTML. I'm terrible at XML, but this
test seems to work.
- fast/parser/compatMode-in-xhtml-expected.txt: Added.
- fast/parser/compatMode-in-xhtml.xhtml: Added.
- 4:15 PM Changeset in webkit [67511] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-09-14 James Kozianski <soulplant@gmail.com>
Reviewed by Ojan Vafai.
Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window
https://bugs.webkit.org/show_bug.cgi?id=18447
Add a test for CSSStyleDeclaration.prototype.foo leaking into inner
windows.
- fast/frames/css-style-declaration-isolation-expected.txt: Added.
- fast/frames/css-style-declaration-isolation.html: Added.
- 4:13 PM Changeset in webkit [67510] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- win/WebKit2Generated.make:
- 4:12 PM Changeset in webkit [67509] by
-
- 3 edits3 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test: http/tests/security/xss-DENIED-frame-name.html
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheck):
- If the property name exists on the object, it will shadow the named property lookup on the window object. That means we need to block access if there's shadowing going on.
(WebCore::V8DOMWindow::indexedSecurityCheck):
- I made the corresponding change to this function too, but I don't think this one can actually be triggered because JavaScript variable names need to start with a non-digit.
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700
Test whether cross-origin observers can see global variables shadowing
named frames.
- http/tests/security/resources/frame-for-parent-name.html: Added.
- http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
- http/tests/security/xss-DENIED-frame-name.html: Added.
- 4:12 PM Changeset in webkit [67508] by
-
- 4 edits in branches/chromium/517/WebKit/chromium
Merge 67418 - 2010-09-13 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572
- public/WebAccessibilityObject.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/3398006
- 3:53 PM Changeset in webkit [67507] by
-
- 12 edits2 deletes in trunk
Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785
Reviewed by Anders Carlsson.
WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Remove files.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleNode.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp:
(WKBundleRangeCopyStartContainer):
(WKBundleRangeCopyEndContainer):
- WebProcess/InjectedBundle/API/c/WKBundleRange.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
Change to be in terms of WKBundleNodeHandleRef.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 3:53 PM Changeset in webkit [67506] by
-
- 9 edits2 adds in trunk
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Updated our integer parsing for tabindex to use the algorithm from the
HTML5 spec.
Test: fast/parser/tabindex-parsing-2.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTMLInteger):
- html/parser/HTMLParserIdioms.h:
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
- fast/parser/tabindex-parsing-2-expected.txt: Added.
- fast/parser/tabindex-parsing-2.html: Added.
- Test a bunch of corner cases in tabindex parsing.
- fast/parser/tabindex-parsing-expected.txt:
- fast/parser/tabindex-parsing.html:
- Update expected result. This case is actually the one that the original reporter was complaining about.
- 3:48 PM Changeset in webkit [67505] by
-
- 2 edits in trunk/WebCore
Build correction, no review.
- WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from
non-Cairo based builds.
- 3:38 PM Changeset in webkit [67504] by
-
- 3 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 3:26 PM Changeset in webkit [67503] by
-
- 12 edits in trunk
fast/files/apply-blob-url-to-img.html timeout on Leopard
https://bugs.webkit.org/show_bug.cgi?id=45576
Reviewed by David Levin.
WebCore:
The failure on Leopard is caused by the static method
ResourceHandle::supportsBufferedData that returns true to indicate that
the buffered data support is enabled for blob resource. However,
BlobResourceHandle does not support this and we need to override this.
The fix is to change supportsBufferedData method from static to virtual
so that we can override the default behavior in BlobResourceHandle.
- fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread.
(WebCore::BlobRegistryContext::BlobRegistryContext):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::supportsBufferedData): Override the default
behavior.
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h: Made supportsBufferedData virtual.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::bufferedData):
WebKit/chromium:
- src/ResourceHandle.cpp: Remove the no longer applicable static comment.
LayoutTests:
Update the test to compute the right coordinates to drag the file to.
This fixes the problem that onInputFileChange() is not called on
Leopard.
- fast/files/apply-blob-url-to-img.html:
- platform/mac/Skipped: Remove the passing test from Skipped list.
- 3:19 PM Changeset in webkit [67502] by
-
- 1 edit24 deletes in trunk/LayoutTests
2010-09-14 Victor Wang <victorw@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Remove the wrong chromium-win-vista expectations.
Layout test results generated from Chromium vista bots match
the expectations in chromium-win. These baselines are either
wrong or out of date. Need to be cleaned up so chromium
vista bots can pass on these tests.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Removed.
- platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Removed.
- platform/chromium-win-vista/svg/custom/text-linking-expected.png: Removed.
- 3:00 PM Changeset in webkit [67501] by
-
- 4 edits in trunk
2010-09-14 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Exceptions are getting ignored on 64-bit Windows in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=45779
WebKit2:
- WebProcess/WebKitMain.cpp: (disableProcessCallbackFilterForExceptions): Clear the PROCESS_CALLBACK_FILTER_ENABLED flag so that exceptions thrown in callback routines are not ignored, as described in http://support.microsoft.com/kb/976038 and http://blog.paulbetts.org/index.php/2010/07/20/the-case-of-the-disappearing-onload-exception-user-mode-callback-exceptions-in-x64/. (WebKitMain):
WebKitSite:
- building/tools.html: Add instructions about how to optionally get hotfix 976038.
- 2:55 PM Changeset in webkit [67500] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Fixed layout test failure seen on buildbot by correcting expected results.
It looks like Darin accidentally checked in the wrong expected results.
- fast/css/visited-link-hang-expected.txt:
- 2:43 PM Changeset in webkit [67499] by
-
- 5 edits in trunk
Build correction, no review.
WebCore:
- WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp implementation file.
- platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include for <cairo.h>
WebKit2:
- win/WebKit2.vcproj: Disable build for Cairo targets of
the WebURLRequestWin.cpp and WebURLResponseWin.cpp files.
- 2:29 PM Changeset in webkit [67498] by
-
- 14 edits32 adds2 deletes in trunk
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
- WebKit.gyp:
- public/WebAccessibilityNotification.h: Added.
- public/WebViewClient.h: (WebKit::WebViewClient::postAccessibilityNotification):
- src/AssertMatchingEnums.h: Added.
- src/ChromeClientImpl.cpp: (WebKit::toWebAccessibilityNotification): (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren): (WebKit::ChromeClientImpl::postAccessibilityNotification):
- src/ChromeClientImpl.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
Use postAccessibilityNotification to pass accessibility notifications
to chromium.
Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html
platform/chromium/accessibility/post-notification-CheckedStateChanged.html
platform/chromium/accessibility/post-notification-ChildrenChanged.html
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html
platform/chromium/accessibility/post-notification-LayoutComplete.html
platform/chromium/accessibility/post-notification-LiveRegionChanged.html
platform/chromium/accessibility/post-notification-LoadComplete.html
platform/chromium/accessibility/post-notification-MenuListValueChanged.html
platform/chromium/accessibility/post-notification-RowCollapsed.html
platform/chromium/accessibility/post-notification-RowCountChanged.html
platform/chromium/accessibility/post-notification-RowExpanded.html
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html
platform/chromium/accessibility/post-notification-SelectedTextChanged.html
platform/chromium/accessibility/post-notification-ValueChanged.html
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- platform/chromium/accessibility/children-changed-notification-expected.txt: Removed.
- platform/chromium/accessibility/children-changed-notification.html: Removed.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LayoutComplete.html: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Added.
- platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Added.
- platform/chromium/accessibility/post-notification-LoadComplete.html: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCollapsed.html: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowCountChanged.html: Added.
- platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Added.
- platform/chromium/accessibility/post-notification-RowExpanded.html: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Added.
- platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Added.
- platform/chromium/accessibility/post-notification-ValueChanged.html: Added.
- platform/chromium/accessibility/post-notification.js: Added. (enumAccessibilityObjects): (testDone): (test):
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-09-14 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
- DumpRenderTree/chromium/WebViewHost.h:
- 2:22 PM Changeset in webkit [67497] by
-
- 5 edits in trunk/WebKit/win
Reviewed by Adam Roben.
Add an IWebFramePrivate API to load string as plain text into the WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=45782
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl: Touch the file.
- WebFrame.cpp: (WebFrame::loadPlainTextString):
- WebFrame.h:
- 2:10 PM Changeset in webkit [67496] by
-
- 3 edits2 adds in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
Test: fast/css/visited-link-hang.html
- platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): Added a start position argument and changed types to use size_t consistently instead of a mix. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::squeezeOutNullCharacters): Added. (WebCore::cleanSlashDotDotSlashes): Added. Factored out part of cleanPath (see below). (WebCore::mergeDoubleSlashes): Ditto. (WebCore::cleanSlashDotSlashes): Ditto. (WebCore::cleanPath): Changed algorithm to not remove as we go to avoid N2 behavior; instead replace with null characters and then do a squeeze operation after the fact. Also moved the body of the function out of line since we normally don't have to do any cleaning. This whole thing should go at some point -- it's not the right algorithm -- but this should eliminate the performance problems without changing behavior.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767
- fast/css/visited-link-hang-expected.txt: Added.
- fast/css/visited-link-hang.html: Added.
- 2:07 PM Changeset in webkit [67495] by
-
- 4 edits in trunk/WebKitTools
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
commit-queue is slow during the day
https://bugs.webkit.org/show_bug.cgi?id=45780
Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.
This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 2:06 PM Changeset in webkit [67494] by
-
- 5 edits in trunk
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- runtime/JSArray.cpp: (JSC::JSArray::sort): Replaced early exit for an array of length zero to instead exit for any array without values, even if it has a non-0 length.
2010-09-14 Darin Adler <Darin Adler>
Reviewed by Geoffrey Garen.
Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781
- fast/js/script-tests/sort-large-array.js: Added test cases.
- fast/js/sort-large-array-expected.txt: Updated.
- 2:02 PM Changeset in webkit [67493] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: On Mac, let image layer data row order match skia.
https://bugs.webkit.org/show_bug.cgi?id=45400
Make CoreGraphics texture row order match skia's row order, remove all
code that worked around this difference. This also fixes a problem where
image layers would be drawn upside down.
Covered by existing layout tests, but we don't run these with
compositing yet.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::drawLayers):
- 1:45 PM Changeset in webkit [67492] by
-
- 2 edits in tags/Safari-534.7.2/JavaScriptCore
Merge r67482.
- 1:41 PM Changeset in webkit [67491] by
-
- 5 edits in tags/Safari-534.7.2
Versioning.
- 1:29 PM Changeset in webkit [67490] by
-
- 10 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
- fast/events/event-input-contentEditable-expected.txt: Merged two anchor elements.
- fast/events/event-input-contentEditable.html: Ditto.
- 1:27 PM Changeset in webkit [67489] by
-
- 1 copy in tags/Safari-534.7.2
New tag.
- 1:08 PM Changeset in webkit [67488] by
-
- 4 edits in trunk
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::ensureDebuggerScriptLoaded): Added, loads DebuggerScript.js into ScriptDebugServer. (WebCore::InspectorClientQt::openInspectorFrontend): Ensure that DebuggerScript.js is loaded before opening an inspector.
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771
- inspector/front-end/WebKit.qrc: Add DebuggerScript.js
- 12:56 PM Changeset in webkit [67487] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium win compile.
- public/WebView.h:
- 12:48 PM Changeset in webkit [67486] by
-
- 2 edits in trunk/WebCore
PPC Build fix.
- 12:44 PM Changeset in webkit [67485] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[chromium] Remove unused ICU headers
https://bugs.webkit.org/show_bug.cgi?id=45698
Remove unused headers.
- platform/graphics/chromium/FontCacheLinux.cpp:
- 12:23 PM Changeset in webkit [67484] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode
https://bugs.webkit.org/show_bug.cgi?id=17722
I believe our behavior matches the HTML5 spec. When we see a </x>, we
correctly kick out of standards mode. In the </> case, however, the
tokenizer just eats the bytes, without emitting a token, which means we
don't get kicked out of standards mode. Our behavior matches Minefield.
- fast/parser/strange-doctype-compatmode-1-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-1.html: Added.
- fast/parser/strange-doctype-compatmode-2-expected.txt: Added.
- fast/parser/strange-doctype-compatmode-2.html: Added.
- 12:02 PM Changeset in webkit [67483] by
-
- 2 edits1 add in trunk/WebCore
2010-09-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Numpad Enter key returns keyCode 0 instead of 13
https://bugs.webkit.org/show_bug.cgi?id=45014
Original patch by Jarred Nicholls <jarred.nicholls@gmail.com>
There is a missing case statement in the PlatformKeyboardEventQt.cpp
file to handle the Enter button on the number pad. Because it is not
handled, the keyCode returned in a JavaScript event is 0 rather than 13.
Test: manual-tests/qt/numpad-enter-key.html
- manual-tests/qt/numpad-enter-key.html: Added.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 11:49 AM Changeset in webkit [67482] by
-
- 2 edits in trunk/JavaScriptCore
Windows production build fix.
Roll out r65143.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- 11:15 AM Changeset in webkit [67481] by
-
- 2 edits in trunk/WebCore
2010-09-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Fisher.
[chromium] building without debug syms broke after recent refactoring
https://bugs.webkit.org/show_bug.cgi?id=45720
Now that we build WebCore as multiple libraries, we need to adjust the
flags to turn off debug symbols for all of these libraries.
No new tests; should only affect an uncommon build flag.
- WebCore.gyp/WebCore.gyp:
- 10:59 AM Changeset in webkit [67480] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, remove tests that are now passing after Noel Gordon's
fix to test_shell delete key handling.
- platform/chromium/test_expectations.txt:
- 10:38 AM Changeset in webkit [67479] by
-
- 9 edits in trunk
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- platform/chromium/test_expectations.txt:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- public/WebView.h: add WebView::setDomainRelaxationForbidden
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDomainRelaxationForbidden):
- src/WebViewImpl.h:
2010-09-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
- DumpRenderTree/chromium/LayoutTestController.h:
- 10:27 AM Changeset in webkit [67478] by
-
- 2 edits in trunk/WebCore
2010-09-14 Tony Chang <tony@chromium.org>
Unreviewed, fix chromium compile.
- platform/graphics/chromium/ImageLayerChromium.h:
- 10:16 AM Changeset in webkit [67477] by
-
- 3 edits in trunk/WebCore
2010-09-14 Nico Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
[chromium]: crash less in compositor mode on mac
https://bugs.webkit.org/show_bug.cgi?id=45714
The contents image can go away when the dom is updated. Since the
layer tree is updated asynchronously, it needs to ref the native image,
else it will hold on to a stale object.
This still needs to be done for skia, too.
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
- 10:04 AM Changeset in webkit [67476] by
-
- 2 edits in trunk/WebKit/efl
2010-09-14 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix: remove "virtual" keyword from
implementation file.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
- 9:49 AM Changeset in webkit [67475] by
-
- 3 edits1 move in trunk/JavaScriptCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Share UnicodeMacrosFromICU.h
https://bugs.webkit.org/show_bug.cgi?id=45710
glib, qt4 and wince use the same macros from ICU.
Remove the code duplication and use the same header file.
- wtf/unicode/UnicodeMacrosFromICU.h: Copied from JavaScriptCore/wtf/unicode/glib/UnicodeMacrosFromICU.h.
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Removed.
- wtf/unicode/qt4/UnicodeQt4.h:
- wtf/unicode/wince/UnicodeWince.h:
- 9:30 AM Changeset in webkit [67474] by
-
- 7 edits in trunk
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support for resource timings to HAREntry.
https://bugs.webkit.org/show_bug.cgi?id=45663
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildTimings): (WebInspector.HAREntry.prototype._toMilliseconds): (WebInspector.HAREntry.prototype._interval):
2010-09-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
https://bugs.webkit.org/show_bug.cgi?id=45663
- http/tests/inspector/resource-har-conversion-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- http/tests/inspector/resource-test2.js: Added entire timings object to list of non-deterministic fields.
- http/tests/inspector/resource-tests.js: Ditto.
- 9:19 AM Changeset in webkit [67473] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Always set LeftButton in PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=45705
AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
which button is pressed or released. The current code erroneously sets NoButton.
Set LeftButton unconditionally because Brew MP usually runs on touch device.
- platform/brew/PlatformMouseEventBrew.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 8:40 AM Changeset in webkit [67472] by
-
- 4 edits1 move1 delete in trunk
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- bindings/v8/DebuggerScript.js: Added.
2010-09-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Andreas Kling.
Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739
- WebKit.grd:
- WebKit.gypi:
- src/js/DebuggerScript.js: Removed.
- src/js/DevToolsHostStub.js: Removed.
- 8:31 AM Changeset in webkit [67471] by
-
- 4 edits9 adds2 deletes in trunk/LayoutTests
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Rebaseline DeviceOrientation related layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45542
Some DeviceOrientation layout tests need Chromium-specific
baselines because of differences between JSC and V8.
Also enable prototype-inheritance.html again and unfork its
expectations.
- fast/dom/script-tests/prototype-inheritance.js:
- platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
- platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:18 AM Changeset in webkit [67470] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] add new tests from r67463 to expectations
https://bugs.webkit.org/show_bug.cgi?id=45753
- platform/chromium/test_expectations.txt:
- 7:59 AM Changeset in webkit [67469] by
-
- 7 edits in trunk
2010-09-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore
https://bugs.webkit.org/show_bug.cgi?id=45530
WebCore:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
- css/CSSStyleSelector.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
LayoutTests:
- inspector/elements-panel-styles-expected.txt:
- inspector/resources/elements-panel-styles.css: (.foo): (.foo::before):
- 7:42 AM Changeset in webkit [67468] by
-
- 2 edits in trunk/WebCore
2010-09-14 Hyung Song <beergun@company100.net>
Reviewed by Darin Adler.
[BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
https://bugs.webkit.org/show_bug.cgi?id=45701
SharedBuffer::createWithContentsOfFile() reads file content and saves to
result.m_buffer directly, leaving result.m_size unchanged.
- platform/brew/SharedBufferBrew.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 7:25 AM Changeset in webkit [67467] by
-
- 7 edits in trunk/WebCore
2010-09-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move adjustLexerState to the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=45649
This function used let us share code between the tree builder and the
two other users of the HTMLTokenizer. However, now that the tree
builder is all grown up, it can't use this code anymore. The other
users would much rather this code lived on HTMLTokenizer and understood
<script>. This patch attempts to make them happy.
- html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTokenizer.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::scriptEnabled):
- html/parser/HTMLTreeBuilder.h:
- html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
- 7:06 AM Changeset in webkit [67466] by
-
- 4 edits4 adds16 deletes in trunk/LayoutTests
2010-09-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610
post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.
- http/tests/navigation/post-basic-expected.txt: Added.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames-expected.txt: Added.
- http/tests/navigation/post-frames.html:
- http/tests/navigation/resources/form-target.pl: Added
- http/tests/navigation/resources/page-that-posts.html: Added.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
- 7:04 AM Changeset in webkit [67465] by
-
- 2 edits in trunk
2010-09-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] qmake doesn't generate correct dependencies for rcc resource files
https://bugs.webkit.org/show_bug.cgi?id=45747
- WebKit.pri: add OUT_PWD to DEPENDPATH
- 6:33 AM Changeset in webkit [67464] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Anton Muhin <antonm@chromium.org>
Unreviewed cleanup of test expectations for Chromium.
ietestcenter/Javascript/15.4.4.15-3-14.html, ietestcenter/Javascript/15.4.4.15-3-29.html and
ietestcenter/Javascript/15.4.4.15-3-8.html are passing now.
- platform/chromium/test_expectations.txt:
- 6:25 AM Changeset in webkit [67463] by
-
- 3 edits8 adds in trunk
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.
- fast/repaint/block-layout-inline-children-float-positioned.html: Added.
- fast/repaint/block-layout-inline-children-replaced.html: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>
Reviewed by Darin Adler.
REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142
http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.
Patch by: Dave Hyatt
Tests: fast/repaint/block-layout-inline-children-float-positioned.html
fast/repaint/block-layout-inline-children-replaced.html
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 6:20 AM Changeset in webkit [67462] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-14 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Make WebDeviceOrientationClientMock constructor private.
https://bugs.webkit.org/show_bug.cgi?id=45743
Clients should use the create member function instead. DumpRenderTree
and the Chromium test_shell have previously been updated to call create.
- public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
- 6:16 AM Changeset in webkit [67461] by
-
- 2 edits in trunk/WebCore
2010-09-14 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Andreas Kling.
[Qt] Cookie operations should use NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45745
No new functionality so no new tests.
- platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager instead of directly accessing the FrameLoaderClient.
- 5:38 AM Changeset in webkit [67460] by
-
- 2 edits in trunk/LayoutTests
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] mark fast/frames/frame-limit.html as DEBUG SLOW CRASH
https://bugs.webkit.org/show_bug.cgi?id=45738
- platform/chromium/test_expectations.txt:
- 5:26 AM Changeset in webkit [67459] by
-
- 8 edits3 deletes in trunk
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/execCommand/script-tests/toggle-style-3.js:
- editing/execCommand/toggle-style-3-expected.txt:
- editing/execCommand/unlink-expected.txt:
- editing/style/inline-style-extend-run-expected.txt: Removed.
- editing/style/inline-style-extend-run.html: Removed.
- editing/style/script-tests/inline-style-extend-run.js: Removed.
- editing/style/script-tests/make-text-writing-direction-inline.js:
2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746
This change makes tree red. (Requested by pfeldman on
#webkit).
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown):
- editing/ApplyStyleCommand.h:
- 4:07 AM Changeset in webkit [67458] by
-
- 12 edits in trunk
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::createCommandMap):
- loader/EmptyClients.h:
- page/EditorClient.h:
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::dismissCorrectionPanel):
2010-09-14 Eric Seidel <eric@webkit.org>
Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::dismissCorrectionPanel):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 2:52 AM Changeset in webkit [67457] by
-
- 2 edits in trunk/WebKitTools
Adding myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 2:46 AM Changeset in webkit [67456] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
https://bugs.webkit.org/show_bug.cgi?id=45736
Reviewed by Kenneth Rohde Christiansen.
Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.
- Scripts/build-webkit:
- 2:23 AM Changeset in webkit [67455] by
-
- 2 edits in trunk/WebCore
2010-09-14 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; an attempt to fix Chromium Windows build.
- fileapi/FileEntry.cpp:
- 2:10 AM Changeset in webkit [67454] by
-
- 3 edits in trunk/WebCore
2010-09-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: provide support for opening external navigation for links within certain elements
Use default handling for clicks on links that have target="_blank"
Add option for external navigation to URL audit formatter.
https://bugs.webkit.org/show_bug.cgi?id=45671
- inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.url):
- inspector/front-end/inspector.js:
- 1:26 AM Changeset in webkit [67453] by
-
- 2 edits in trunk/WebKit/qt
2010-09-14 Enrico Ros <eros@codeaurora.org>
Reviewed by Andreas Kling.
[Qt] Respect title attribute on option elements
https://bugs.webkit.org/show_bug.cgi?id=45084
Set the tooltip in the combo box model, so it's reflected in the view.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
- 1:03 AM Changeset in webkit [67452] by
-
- 2 edits in trunk/WebCore
Build fix.
- editing/EditorCommand.cpp:
- 12:50 AM Changeset in webkit [67451] by
-
- 12 edits in trunk
Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071
Patch by Jia Pu <jpu@apple.com> on 2010-09-14
Reviewed by Dan Bernstein.
WebCore:
Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.
- editing/Editor.cpp:
(WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection
panel is shown.
- editing/Editor.h: Added declaration of isShowingCorrectionPanel().
- editing/EditorCommand.cpp:
(WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation()
when autocorrection panel is shown.
(WebCore::createCommandMap): Replaced isSupported function pointer for
executeCancelOperation() command with supportedDismissCorrectionPanel().
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of
new member method declared in base class.
- page/EditorClient.h: Declared new member method isShowingCorrectionPanel().
WebKit/mac:
- WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
for invalid correction panel tag. Replaced -1 with this constant.
(WebEditorClient::dismissCorrectionPanel): Ditto
(WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
- WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
- 12:40 AM Changeset in webkit [67450] by
-
- 1 edit1 delete in trunk/WebCore
2010-09-14 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45691
Brew MP no longer depends on ICU for internationalization.
Remove TextBreakIteratorInternalICUBrew.cpp.
- platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed.
- 12:12 AM Changeset in webkit [67449] by
-
- 8 edits3 adds in trunk
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.
Test: editing/style/inline-style-extend-run.html
- editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
- editing/ApplyStyleCommand.h:
2010-09-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616
Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.
- editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
- editing/execCommand/toggle-style-3-expected.txt: Ditto.
- editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
- editing/style/inline-style-extend-run-expected.txt: Added.
- editing/style/inline-style-extend-run.html: Added.
- editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
- editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
Sep 13, 2010:
- 11:51 PM Changeset in webkit [67448] by
-
- 2 edits in trunk/WebCore
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Kent Tamura.
Add one #if guard block to fix Qt builds.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/InspectorResource.cpp:
- 11:27 PM Changeset in webkit [67447] by
-
- 13 edits in trunk
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/extensions-api-expected.txt: Added a new resource type.
2010-09-13 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Add WebSocket resource type to Web Inspector.
When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.
Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
- inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
- inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
- inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
- inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
- websockets/WebSocketChannel.h:
- 11:17 PM WebKit Team edited by
- (diff)
- 11:06 PM Changeset in webkit [67446] by
-
- 3 edits4 adds in trunk/WebKit/chromium
2010-09-13 Eric Uhrhane <ericu@chromium.org>
Reviewed by Darin Fisher.
Add Chromium API for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44360
Build file changes.
- WebKit.gyp:
Added a way to get a WebFileWriter.
- public/WebFileSystem.h: (WebKit::WebFileSystem::createFileWriter):
WebFileWriter writes and truncates files.
- public/WebFileWriter.h: Added.
WebFileWriterClient reports success/failure and progress events.
- public/WebFileWriterClient.h: Added.
AsyncFileWriterChromium is a connector that links FileWriter and WebFileWriter, FileWriterClient and WebFileWriterClient.
- src/AsyncFileWriterChromium.cpp: Added.
- src/AsyncFileWriterChromium.h: Added.
- 10:26 PM Changeset in webkit [67445] by
-
- 6 edits in trunk
2010-09-13 W. James MacLean <wjmaclean@google.com>
Reviewed by Darin Fisher.
[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127
Replicates existing functionality, use existing tests.
Adds pixel-readback for GPU composited pages to allow for thumbnailing,
printing and other services to work with GPU rendered pages.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerTextureSize):
2010-09-13 W. James MacLean <wjmaclean@google.com>
Reviewed by Darin Fisher.
[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127
Modified WebViewImpl::paint() to detect non-null canvas pointers when
accelerated compositing is active, and instead fills the pixel buffer
from the GPU framebuffer. Includes re-scaling support when provided
canvas does not match size of current render layer. Limits pixel
readback to rect passed to paint(), clipped by size of rootLayerTexture.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint):
- src/WebViewImpl.h:
- 10:05 PM Changeset in webkit [67444] by
-
- 2 edits in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, build fix for Gtk.
- bindings/js/JSEntryCustom.cpp:
- 9:59 PM Changeset in webkit [67443] by
-
- 13 edits2 adds in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Adam Barth.
Make FileEntry and DirectoryEntry methods accessible via Entry instance
https://bugs.webkit.org/show_bug.cgi?id=45553
FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type.
Added custom toJS/toV8 implementation to Entry interface.
No new tests; test will be added later when we have complete implementation for the API.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEntryCustom.cpp: Added. (WebCore::toJS):
- bindings/v8/custom/V8EntryCustom.cpp: Added. (WebCore::toV8):
- fileapi/DirectoryEntry.h: Nits fix.
- fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter.
- fileapi/Entry.idl: Added CustomToJS attribute.
- fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter): (WebCore::FileEntry::file):
- fileapi/FileEntry.h:
- fileapi/FileEntry.idl:
- 9:29 PM Changeset in webkit [67442] by
-
- 2 edits in trunk/WebKit/qt
2010-09-13 Daniel Bates <dbates@rim.com>
Fix the Qt build. I missed this when reviewing the patch
for Bug #45732.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Change enum value ActiveDOMObject::JavaScriptPaused to ActiveDOMObject::JavaScriptDebuggerPaused
- 9:18 PM Changeset in webkit [67441] by
-
- 3 edits2 adds in trunk
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632
Test: editing/execCommand/query-font-size-with-typing-style.html
The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before
retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function.
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632
Added a test to ensure WebKit does not crash when querying font size even if there is a typing style.
- editing/execCommand/query-font-size-with-typing-style-expected.txt: Added.
- editing/execCommand/query-font-size-with-typing-style.html: Added.
- 9:17 PM Changeset in webkit [67440] by
-
- 2 edits in trunk/WebKit/qt
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Daniel Bates.
[Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter
https://bugs.webkit.org/show_bug.cgi?id=45732
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Pass ActiveDOMObject::JavaScriptPaused to suspendActiveDOMObjects.
- 9:08 PM Changeset in webkit [67439] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-13 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Return NULL from getSharedGraphicsContext3D if we couldn't initialize
https://bugs.webkit.org/show_bug.cgi?id=45731
If we can't create a GraphicsContext3D, return NULL from getSharedGraphicsContext3D rather
than an object with NULL internal pointers. Callers know how to handle a null return value
but not one that has inconsistent internal state.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
- 9:00 PM Changeset in webkit [67438] by
-
- 2 edits in trunk/WebCore
2010-09-13 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
[BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45690
WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already
in namespace WebCore block.
- platform/brew/SSLKeyGeneratorBrew.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
- 8:40 PM Changeset in webkit [67437] by
-
- 6 edits in trunk/WebKit2
URL in address bar doesn't update when navigating to http://webkit.org/new-bug when using WebKit2
<rdar://problem/8272775>
https://bugs.webkit.org/show_bug.cgi?id=45729
Reviewed by Jon Honeycutt.
Pass an updated provisional url while notifying the UIProcess of
didReceiveServerRedirectForProvisionalLoadForFrame.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
- 8:23 PM Changeset in webkit [67436] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- 8:15 PM Changeset in webkit [67435] by
-
- 2 edits in trunk/WebCore
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Code simplification needed in Atk Wrapper
https://bugs.webkit.org/show_bug.cgi?id=45687
Use TextIterator::rangeLength() to calculate endOffset
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Don't manually iterate over a artificial new range but just call TextIterator::rangeLength on the range created between the start and end positions.
- 7:54 PM Changeset in webkit [67434] by
-
- 2 edits in trunk/WebCore
Clean up xcode project.
Reviewed by Alice Liu.
- WebCore.xcodeproj/project.pbxproj:
- 7:48 PM Changeset in webkit [67433] by
-
- 11 edits5 adds in trunk/WebKit2
Threaded mode should work in WebKit2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45727
Reviewed by Jon Honeycutt.
- Make starting the web thread more like starting a new process (encapsulate it in a thread launcher class).
- Make the call to didFinishLaunching asynchronous so that WebProcess is fully constructed before it is called.
- Platform/WorkItem.h:
(MemberFunctionWorkItem1::MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::~MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::execute):
(WorkItem::create):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/ThreadLauncher.cpp: Added.
(WebKit::ThreadLauncher::ThreadLauncher):
(WebKit::ThreadLauncher::launchThread):
(WebKit::ThreadLauncher::didFinishLaunchingThread):
(WebKit::ThreadLauncher::invalidate):
- UIProcess/Launcher/ThreadLauncher.h: Added.
(WebKit::ThreadLauncher::Client::~Client):
(WebKit::ThreadLauncher::create):
(WebKit::ThreadLauncher::isLaunching):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::terminateProcess):
- UIProcess/Launcher/mac/ThreadLauncherMac.mm: Added.
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Added.
(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):
- UIProcess/Launcher/win/ProcessLauncherWin.cpp:
- UIProcess/Launcher/win/ThreadLauncherWin.cpp: Added.
(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
(WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/WebProcessProxy.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- 7:41 PM Changeset in webkit [67432] by
-
- 20 edits2 adds in trunk
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Geoff Garen.
JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688
Test: http/tests/media/reload-after-dialog.html
- bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter.
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects.
- dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter.
- dom/ActiveDOMObject.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto.
- dom/ScriptExecutionContext.h:
- history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects.
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter.
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): Deal with element being suspended. (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document becoming inactive.
- html/HTMLMediaElement.h:
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects.
- page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter.
- page/SuspendableTimer.h:
- websockets/WebSocket.cpp: (WebCore::WebSocket::suspend): Ditto.
- websockets/WebSocket.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::suspend): Ditto.
- xml/XMLHttpRequest.h:
2010-09-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Geoff Garen.
JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688
- http/tests/media/reload-after-dialog-expected.txt: Added.
- http/tests/media/reload-after-dialog.html: Added.
- 7:15 PM Changeset in webkit [67431] by
-
- 2 edits in trunk/WebCore
Fix the mac build.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMousePressEventToSubframe):
- 7:03 PM Changeset in webkit [67430] by
-
- 2 edits in trunk/WebCore
Can't scroll on Bugzilla patch review pages on Mac with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43555
Reviewed by Anders Carlsson.
<rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks
<rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555)
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Add WebKit2 mode for these functions based on the presence of a platform widget for a
FrameView.
- 6:38 PM Changeset in webkit [67429] by
-
- 4 edits in trunk/WebKitTools
2010-09-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should log when it's retrying due to checkout out of date error
https://bugs.webkit.org/show_bug.cgi?id=45725
This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.
In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 6:37 PM Changeset in webkit [67428] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Upload results when cq patch landing fails
https://bugs.webkit.org/show_bug.cgi?id=45683
Include script errors when CommitQueue._land fails.
- Scripts/webkitpy/tool/commands/queues.py:
- 6:10 PM Changeset in webkit [67427] by
-
- 2 edits in trunk/WebCore
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Buildfix for ViewportArguments.cpp
https://bugs.webkit.org/show_bug.cgi?id=45678
Use fabs() instead of abs().
This patch also fixes the return value, when
the value is between -1 and 1.
- dom/ViewportArguments.cpp: (WebCore::findUserScalableValue):
- 6:02 PM Changeset in webkit [67426] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix duplicate entries in expectations file; we really need to fix
the checkin trigger to catch these.
- platform/chromium/test_expectations.txt:
- 5:56 PM Changeset in webkit [67425] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Add some suppressions back in - it looks like we are probably tripping
over some debug asserts that I need to triage downstream.
- platform/chromium/test_expectations.txt:
- 5:29 PM Changeset in webkit [67424] by
-
- 2 edits in trunk/WebKit/efl
2010-09-13 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[EFL] Fix build break when enabling HTML5 video support
https://bugs.webkit.org/show_bug.cgi?id=45674
The correct include variable for LibXml2 in cmake is
LIBXML2_INCLUDE_DIR instead of LIBXML2_INCLUDE_DIRS.
- CMakeListsEfl.txt:
- 4:42 PM Changeset in webkit [67423] by
-
- 22 edits2 adds in trunk
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
- wtf/text/WTFString.h: Added isAllSpecialCharacters, moved here from the HTML tree builder.
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
- DOM/WebDOMOperations.mm: (-[DOMDocument webFrame]): Get rid of unneeded local variable. (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
2010-09-13 Darin Adler <Darin Adler>
Reviewed by Adam Barth.
Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695
Added new HTMLParserIdioms source file, with a name inspired by the HTML
specification, which has a section defining things like "space character"
that talks about common parser idioms. These are idioms for the main HTML
parser and for parsers for various microlanguages as well.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Added HTMLParserIdioms.
- css/CSSHelper.h: Fixed indentation and comments here. Point to the new stripLeadingAndTrailingHTMLSpaces function.
- html/parser/HTMLParserIdioms.cpp: Added.
- html/parser/HTMLParserIdioms.h: Added.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Updated for name changes.
- html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h.
- html/HTMLInputElement.cpp:
- html/HTMLMeterElement.cpp:
- html/HTMLProgressElement.cpp:
- html/StepRange.cpp:
- rendering/RenderSlider.cpp: Updated includes.
- svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. This is for use on the attribute value before building the URL, not on the URL after building it. I did not add a test case; this is an obscure corner and soon we will be moving to stripLeadingAndTrailingHTMLSpaces anyway.
- wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Ditto.
- 4:27 PM Changeset in webkit [67422] by
-
- 3 edits2 adds in trunk
AX: REGRESSION: WebKit does not report label of web popup buttons
https://bugs.webkit.org/show_bug.cgi?id=45715
Reviewed by Darin Adler.
WebCore:
Test: platform/mac/accessibility/popup-button-title.html
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
LayoutTests:
- platform/mac/accessibility/popup-button-title-expected.txt: Added.
- platform/mac/accessibility/popup-button-title.html: Added.
- 4:14 PM Changeset in webkit [67421] by
-
- 15 edits in trunk/WebCore
2010-09-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
Expose Flags constructor if FileSystem API is Enabled
https://bugs.webkit.org/show_bug.cgi?id=45165
This change also includes:
- Changed Flags' attribute names from UPPERCASE to camelCase to reflect the recent spec change. http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
- Enhanced EnabledAtRuntime attribute to take parameter that is used to generate a RuntimeEnabledFeatures method name.
No new tests; tests will be added when we fully expose the interface.
- bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor.
- fileapi/Flags.idl: Changed attribute names to camelCase.
- page/DOMWindow.idl: Exposed Flags constructor.
- bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object).
- bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::create): (WebDOMTestObj::setCreate):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::createAttrGetter): (WebCore::TestObjInternal::createAttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): (WebCore::ConfigureV8TestObjTemplate):
- 4:10 PM Changeset in webkit [67420] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
"Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=45647
Implements the notImplemented by doing nothing, which is the proper
behavior according to the spec.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 4:08 PM Changeset in webkit [67419] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
More trivial EOF handling in tree builder
https://bugs.webkit.org/show_bug.cgi?id=45648
The spec says to treat these modes like the InBodyMode, which is what
this patch does. Doing so is indistinguishable from our current
behavior, which is why we didn't catch this based on tests.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 3:59 PM Changeset in webkit [67418] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-13 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572
- public/WebAccessibilityObject.h:
- src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
- 3:58 PM Changeset in webkit [67417] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Remove a bunch of tests that are now passing.
- platform/chromium/test_expectations.txt:
- 3:27 PM Changeset in webkit [67416] by
-
- 4 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] rebaseline two svg tests after r67200
https://bugs.webkit.org/show_bug.cgi?id=45665
- platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
- platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:26 PM Changeset in webkit [67415] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] mark fast/files/read-blob-async.html as CRASH PASS on linux
https://bugs.webkit.org/show_bug.cgi?id=45672
- platform/chromium/test_expectations.txt:
- 3:10 PM Changeset in webkit [67414] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] fix broken dependency in ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=45684
- WebKit.gyp:
- 3:05 PM Changeset in webkit [67413] by
-
- 3 edits in trunk/WebKit/efl
2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add setting API for enabling page cache
https://bugs.webkit.org/show_bug.cgi?id=44931
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_page_cache_get): Added. (ewk_view_setting_page_cache_set): Added.
- ewk/ewk_view.h:
- 2:39 PM Changeset in webkit [67412] by
-
- 5 edits in trunk/WebCore
2010-09-13 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
SharedGraphicsContext3D's texture cache holds on to images after free
https://bugs.webkit.org/show_bug.cgi?id=45706
Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs.
Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know
so that the cache entry and associated texture can also be removed.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::removeTextureFor): (WebCore::SharedGraphicsContext3D::removeTexturesFor): (WebCore::SharedGraphicsContext3D::allContexts):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
- platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::~NativeImageSkia):
- platform/graphics/skia/NativeImageSkia.h:
- 2:23 PM Changeset in webkit [67411] by
-
- 2 edits in trunk/WebKit2
didFinishDocumentLoadForFrame() is not being sent by WebKit2
<rdar://problem/8424171>
Reviewed by Anders Carlsson.
Finish wiring up didFinishDocumentLoad to the UIProcess.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
- 2:08 PM Changeset in webkit [67410] by
-
- 6 edits in branches/chromium/517
Merge 67401 - 210-09-13 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689
The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimatorWin.cpp:
- platform/ScrollAnimatorWin.h:
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/3290027
- 2:08 PM Changeset in webkit [67409] by
-
- 1 edit in trunk/WebKit/win/WebFrame.cpp
One more attempt at fixing the Windows build.
Not reviewed.
- 2:06 PM Changeset in webkit [67408] by
-
- 9 edits2 adds in trunk
AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
https://bugs.webkit.org/show_bug.cgi?id=45548
Reviewed by David Kilzer.
WebCore:
Test: platform/mac/accessibility/element-is-ignored.html
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isIgnored):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isIgnored):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isIgnored):
LayoutTests:
- platform/mac/accessibility/element-is-ignored-expected.txt: Added.
- platform/mac/accessibility/element-is-ignored.html: Added.
- 1:55 PM Changeset in webkit [67407] by
-
- 3 edits2 adds in trunk
CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663
https://bugs.webkit.org/show_bug.cgi?id=45697
Reviewed by Darin Adler.
WebCore:
Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may
be in a bad state and accessing internal variables can lead to a crash.
Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::parentTable):
LayoutTests:
- platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt: Added.
- platform/mac/accessibility/updating-attribute-in-table-row-crash.html: Added.
- 1:49 PM Changeset in webkit [67406] by
-
- 3 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement EOF handling in TextMode
https://bugs.webkit.org/show_bug.cgi?id=45644
This patch is actually covered by a bunch of tests. We were just
magically passing the tests before because of some nutty code in
Document.cpp.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- This code was masking the notImplemented in the tree builder. I also removed the use of the setting because it wasn't working properly anyway. I'll implement a working version shortly.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndOfFile):
- Implement per the spec.
- 1:43 PM Changeset in webkit [67405] by
-
- 1 edit in trunk/WebKit/win/WebFrame.h
Fixing Windows build.
Not reviewed.
- 12:40 PM Changeset in webkit [67404] by
-
- 1 edit173 deletes in trunk/LayoutTests
2010-09-13 Tony Chang <tony@chromium.org>
Unreviewed, removing chromium-linux results that deduplicate-tests says are
unnecessary (mostly due to the checksum computation change last week).
- platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-image-004-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-002-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-003-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Removed.
- platform/chromium-linux/editing/undo/5378473-expected.checksum: Removed.
- platform/chromium-linux/editing/undo/5378473-expected.png: Removed.
- platform/chromium-linux/editing/undo/undo-misspellings-expected.checksum: Removed.
- platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.checksum: Removed.
- platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
- platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
- platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Removed.
- platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Removed.
- platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-linux/fast/dom/attr_dead_doc-expected.checksum: Removed.
- platform/chromium-linux/fast/dom/attr_dead_doc-expected.png: Removed.
- platform/chromium-linux/fast/frames/content-opacity-1-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/content-opacity-1-expected.png: Removed.
- platform/chromium-linux/fast/frames/content-opacity-2-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/content-opacity-2-expected.png: Removed.
- platform/chromium-linux/fast/frames/iframe-text-contents-expected.checksum: Removed.
- platform/chromium-linux/fast/frames/iframe-text-contents-expected.png: Removed.
- platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.checksum: Removed.
- platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-linux/fast/layers/self-painting-outline-expected.checksum: Removed.
- platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Removed.
- platform/chromium-linux/fast/repaint/background-generated-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/background-generated-expected.png: Removed.
- platform/chromium-linux/fast/repaint/background-misaligned-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
- platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Removed.
- platform/chromium-linux/fast/repaint/content-into-overflow-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Removed.
- platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
- platform/chromium-linux/fast/repaint/float-new-in-block-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Removed.
- platform/chromium-linux/fast/repaint/focus-ring-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/focus-ring-expected.png: Removed.
- platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Removed.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/outline-inset-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/outline-inset-expected.png: Removed.
- platform/chromium-linux/fast/repaint/overflow-into-content-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Removed.
- platform/chromium-linux/fast/repaint/selection-clear-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/selection-clear-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-outer-border-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-section-repaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Removed.
- platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Removed.
- platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.checksum: Removed.
- platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Removed.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Removed.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Removed.
- platform/chromium-linux/fast/table/giantRowspan-expected.checksum: Removed.
- platform/chromium-linux/fast/table/giantRowspan-expected.png: Removed.
- platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.checksum: Removed.
- platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Removed.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Removed.
- platform/chromium-linux/svg/custom/dynamic-empty-path-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Removed.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
- platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
- platform/chromium-linux/svg/custom/group-opacity-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-container-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-container-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-container2-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-container2-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-style-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-style-expected.png: Removed.
- platform/chromium-linux/svg/custom/js-update-transform-addition-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Removed.
- platform/chromium-linux/svg/custom/marker-referencePoint-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Removed.
- platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/mask-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/pattern-y-offset-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Removed.
- platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/text-dom-removal-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Removed.
- platform/chromium-linux/svg/custom/use-forward-refs-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Removed.
- platform/chromium-linux/svg/hixie/data-types/001-expected.checksum: Removed.
- platform/chromium-linux/svg/hixie/data-types/001-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.checksum: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
- 12:16 PM Changeset in webkit [67403] by
-
- 39 edits in trunk
Paste should be implemented in WebCore like Copy and Cut for Mac also.
https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>
WebCore:
Reviewed by Sam Weining.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- editing/Editor.cpp:
(WebCore::Editor::shouldInsertFragment):
- editing/mac/EditorMac.mm: extended to support Mail specific scenarios.
(WebCore::Editor::pasteWithPasteboard):
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added.
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added.
(WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail.
- loader/FrameLoaderClient.h:
- page/EditorClient.h:
- platform/Pasteboard.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that
doesn't calll back into WebKit.
(WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the
WebCore level.
(WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the
WebCore level.
(WebCore::uniqueURLWithRelativePart): Added.
(WebCore::Pasteboard::documentFragment): Extended to include all the functionality
provided in documentFragmentFromPasteboard in WebHTMLView.mm.
WebKit/chromium:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::canShowMIMETypeAsHTML): Added stub.
- src/FrameLoaderClientImpl.h:
WebKit/efl:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientEfl.h:
WebKit/gtk:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/haiku:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientHaiku.h:
WebKit/mac:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(excludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Added.
(WebEditorClient::setInsertionPasteboard):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
of the editor client.
- WebView/WebHTMLView.mm: Removed paste method.
WebKit/qt:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMETypeAsHTML): Added stub.
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebFrame.cpp:
(WebFrame::canShowMIMETypeASHTML): Added.
WebKit/wx:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::canShowMIMETypeAsHTML): Added stub.
- WebKitSupport/FrameLoaderClientWx.h:
WebKit2:
Reviewed by Sam Weinig.
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added.
(WebKit::WebEditorClient::setInsertionPasteboard): Added.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 12:05 PM Changeset in webkit [67402] by
-
- 2 edits in trunk/WebCore
2010-09-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Kenneth Rohde Christiansen.
[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
https://bugs.webkit.org/show_bug.cgi?id=44699
Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- 11:56 AM Changeset in webkit [67401] by
-
- 6 edits in trunk
210-09-13 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689
The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimatorWin.cpp:
- platform/ScrollAnimatorWin.h:
- 11:45 AM Changeset in webkit [67400] by
-
- 5 edits in trunk/LayoutTests
2010-09-13 Adam Langley <agl@chromium.org>
Unreviewed. Layout test re-baseline.
After r66882, complex text word spacing changed due to a bug fix. This
rebaselines the layout test for that case.
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
- platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:41 AM Changeset in webkit [67399] by
-
- 2 edits in trunk/WebCore
2010-09-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Move functions of StyledMarkupAccumulator below that of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=45624
Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions
to below the definitions of MarkupAccumulator's member functions.
No new tests are added since this is a cleanup.
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): (WebCore::StyledMarkupAccumulator::appendElement): (WebCore::StyledMarkupAccumulator::shouldAnnotate): (WebCore::StyledMarkupAccumulator::wrapWithNode): (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): (WebCore::StyledMarkupAccumulator::takeResults): (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::renderedText): (WebCore::StyledMarkupAccumulator::stringValueForRange): (WebCore::styleFromMatchedRulesForElement): (WebCore::StyledMarkupAccumulator::removeExteriorStyles): (WebCore::needInterchangeNewlineAfter): (WebCore::styleFromMatchedRulesAndInlineDecl): (WebCore::removeEnclosingMailBlockquoteStyle): (WebCore::removeDefaultStyles):
- 11:34 AM Changeset in webkit [67398] by
-
- 4 edits in trunk/WebCore
2010-09-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Leak in the GraphicsContextCairo drawPathShadow
https://bugs.webkit.org/show_bug.cgi?id=44959
Fix a leak of the cairo_path.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- platform/graphics/cairo/OwnPtrCairo.cpp: (WTF::cairo_path_t):
- platform/graphics/cairo/OwnPtrCairo.h:
- 11:28 AM WinCE edited by
- (diff)
- 11:25 AM Changeset in webkit [67397] by
-
- 18 edits in trunk
Build fix. Clear the executable bit on files that should not be executable.
- 11:15 AM WinCE edited by
- (diff)
- 10:40 AM Changeset in webkit [67396] by
-
- 4 edits in trunk
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645
Test that </sarcasm> works properly.
- html5lib/resources/webkit02.dat:
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645
Umm... Yeah.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
- 10:21 AM Changeset in webkit [67395] by
-
- 3 edits in trunk/WebCore
2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Darin Adler.
[WML] Fix build breaks when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=45628
There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter.
So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent()
was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp
- wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
- 10:00 AM Changeset in webkit [67394] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline inspector/extensions-events.html
- inspector/extensions-events-expected.txt:
- 9:32 AM Changeset in webkit [67393] by
-
- 2 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=45677
[WebView canMarkAllTextMatches] can crash if called after [WebView close]
Reviewed by Adam Roben.
<rdar://problem/8404890>
- WebView/WebView.mm:
(-[WebView canMarkAllTextMatches]):
Return NO immediately if the webview has already been closed. This was an overlooked
case from the fix for 45175.
- 9:26 AM Changeset in webkit [67392] by
-
- 2 edits in trunk/WebCore
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
https://bugs.webkit.org/show_bug.cgi?id=45230
No new tests as this is just a build change.
- GNUmakefile.am: Move as many sources as possible to the SOURCES primary. Others should be moved over time as we solve issues with them.
- 9:17 AM Changeset in webkit [67391] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Andreas Kling.
jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651
- Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
- 9:03 AM Changeset in webkit [67390] by
-
- 7 edits2 adds in trunk
REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43807
Reviewed by Darin Adler.
WebCore:
Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types.
Test: platform/mac/accessibility/visible-position-crash-for-text-node.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::textMarkerForPoint):
LayoutTests:
- platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt: Added.
- platform/mac/accessibility/visible-position-crash-for-text-node.html: Added.
- 8:25 AM Changeset in webkit [67389] by
-
- 4 edits in trunk
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
- platform/qt/Skipped: Unskip tests that are now passing.
2010-09-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365
Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
- 8:13 AM Changeset in webkit [67388] by
-
- 2 edits in trunk/JavaScriptCore
Copy JavaScriptCore's generated sources to the right directory
- JavaScriptCore.vcproj/JavaScriptCore.make: Fixed typo.
- 7:20 AM Changeset in webkit [67387] by
-
- 12 edits in trunk
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Remove exceptions for tests that now pass (in DRT and downstream test_shell)
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Add missing virtual destructor to the abstract base class.
- platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
- platform/chromium/GeolocationServiceChromium.h:
2010-09-13 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313
Ports over fixes from test shell:
Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html
Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112
Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably
Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService
- public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService):
- public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed):
- public/WebGeolocationServiceMock.h:
- src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached):
- src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions):
- 7:17 AM Changeset in webkit [67386] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Skip new debugger test on Qt.
- platform/qt/Skipped:
- 6:39 AM Changeset in webkit [67385] by
-
- 6 edits3 adds in trunk
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
Test that scope sections in Scripts panel are expandable and
contain correct data.
- inspector/debugger-expand-scope-expected.txt: Added.
- inspector/debugger-expand-scope.html: Added.
- platform/chromium/inspector/debugger-expand-scope-expected.txt: Added.
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
Test: inspector/debugger-expand-scope.html
- inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. (injectedScriptConstructor.):
2010-09-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260
- src/js/DebuggerScript.js: copy scope variables into a new object, but for global scope object, with statement parameter and catch block exception variable pass the object itself to the injected script.
- src/js/Tests.js: moved testExpandScope to LayoutTests
- 6:03 AM Changeset in webkit [67384] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] add viewport meta tag tests to expectations
https://bugs.webkit.org/show_bug.cgi?id=45655
- platform/chromium/test_expectations.txt:
- 5:29 AM Changeset in webkit [67383] by
-
- 8 edits in trunk
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673
Implement AtkText's setSelection and removeSelection functions
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange): Moved some GTK specific code from a ifdef-endif region to AccessibilityObjectAtk.cpp
- accessibility/AccessibilityObject.h:
- accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::getLengthForTextRange): New.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_remove_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_caret_offset): Changed to directly use visiblePositionRangeForRange now that there's no longer a problem with that, as it was in the past (only worked for text controls).
2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Provide unit tests for AtkText's text selection functions
https://bugs.webkit.org/show_bug.cgi?id=43919
New tests to check getting, setting and removing text selections
- tests/testatk.c: (testWekitAtkTextSelections): New unit tests to check all the text selection related functions altogether through a single test function. (main):
Make sure that code dependant on getting information from the
clipboard gets executed only when there's a GDK window associated
to the webview widget, as that's not the case when executing the
unit tests (the wedbview is not inside of any toplevel window) and
will make the tests crash if not taken into account.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):
- 5:09 AM Changeset in webkit [67382] by
-
- 2 edits10 adds in trunk/LayoutTests
2010-09-13 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium][Test] custom-scrollbar-with-incomplete-style.html need expectation files.
https://bugs.webkit.org/show_bug.cgi?id=45646
Added missing expectations.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:06 AM Changeset in webkit [67381] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 MORITA Hajime <morrita@google.com>
Reviewed by Dirk Schulze.
[chromium] svg/filters/filter-empty-g.svg crashes in linux/mac debug after r63530
https://bugs.webkit.org/show_bug.cgi?id=42486
Removed skip line.
This looks fixed with a fix for http://webkit.org/b/41175.
- platform/chromium/test_expectations.txt:
- 4:35 AM Changeset in webkit [67380] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Unreviewed.
[Qt] Skip three viewport meta tag tests that fail on the bot.
- platform/qt/Skipped:
- 4:19 AM Changeset in webkit [67379] by
-
- 2 edits in trunk/WebKitTools
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] build-webkit: Add --v8 option to build against V8
Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.
- Scripts/build-webkit:
- 4:05 AM Changeset in webkit [67378] by
-
- 5 edits in trunk
2010-09-13 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650
Since the virtual member functions of WebDeviceOrientationClientMock
are not exported from the DLL, construction of the object must be done inside
the DLL, or else the linker will complain (because the vtable cannot
be set up). Clients should use the create() member function, and the constructor
will be made private in a subsequent patch.
- public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
- src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::create):
2010-09-13 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650
Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.
This should fix the linker errors for the multi-DLL Chromium DRT build.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
- 3:58 AM Changeset in webkit [67377] by
-
- 2 edits in trunk/LayoutTests
2010-09-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] update test expectations for tests that pass after rolling out r67328
https://bugs.webkit.org/show_bug.cgi?id=45642
- platform/chromium/test_expectations.txt:
- 3:37 AM Changeset in webkit [67376] by
-
- 20 edits229 adds in trunk
WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
Tests: fast/viewport/viewport-1.html
fast/viewport/viewport-10.html
fast/viewport/viewport-100.html
fast/viewport/viewport-101.html
fast/viewport/viewport-102.html
fast/viewport/viewport-103.html
fast/viewport/viewport-104.html
fast/viewport/viewport-105.html
fast/viewport/viewport-106.html
fast/viewport/viewport-107.html
fast/viewport/viewport-108.html
fast/viewport/viewport-109.html
fast/viewport/viewport-11.html
fast/viewport/viewport-110.html
fast/viewport/viewport-111.html
fast/viewport/viewport-112.html
fast/viewport/viewport-113.html
fast/viewport/viewport-114.html
fast/viewport/viewport-115.html
fast/viewport/viewport-116.html
fast/viewport/viewport-117.html
fast/viewport/viewport-118.html
fast/viewport/viewport-119.html
fast/viewport/viewport-12.html
fast/viewport/viewport-120.html
fast/viewport/viewport-121.html
fast/viewport/viewport-122.html
fast/viewport/viewport-123.html
fast/viewport/viewport-124.html
fast/viewport/viewport-125.html
fast/viewport/viewport-126.html
fast/viewport/viewport-127.html
fast/viewport/viewport-13.html
fast/viewport/viewport-14.html
fast/viewport/viewport-15.html
fast/viewport/viewport-16.html
fast/viewport/viewport-17.html
fast/viewport/viewport-18.html
fast/viewport/viewport-19.html
fast/viewport/viewport-2.html
fast/viewport/viewport-20.html
fast/viewport/viewport-21.html
fast/viewport/viewport-22.html
fast/viewport/viewport-23.html
fast/viewport/viewport-24.html
fast/viewport/viewport-25.html
fast/viewport/viewport-26.html
fast/viewport/viewport-27.html
fast/viewport/viewport-28.html
fast/viewport/viewport-29.html
fast/viewport/viewport-3.html
fast/viewport/viewport-30.html
fast/viewport/viewport-31.html
fast/viewport/viewport-32.html
fast/viewport/viewport-33.html
fast/viewport/viewport-34.html
fast/viewport/viewport-35.html
fast/viewport/viewport-36.html
fast/viewport/viewport-37.html
fast/viewport/viewport-38.html
fast/viewport/viewport-39.html
fast/viewport/viewport-4.html
fast/viewport/viewport-40.html
fast/viewport/viewport-41.html
fast/viewport/viewport-42.html
fast/viewport/viewport-43.html
fast/viewport/viewport-44.html
fast/viewport/viewport-45.html
fast/viewport/viewport-46.html
fast/viewport/viewport-47.html
fast/viewport/viewport-48.html
fast/viewport/viewport-49.html
fast/viewport/viewport-5.html
fast/viewport/viewport-50.html
fast/viewport/viewport-51.html
fast/viewport/viewport-52.html
fast/viewport/viewport-53.html
fast/viewport/viewport-54.html
fast/viewport/viewport-55.html
fast/viewport/viewport-56.html
fast/viewport/viewport-57.html
fast/viewport/viewport-58.html
fast/viewport/viewport-59.html
fast/viewport/viewport-6.html
fast/viewport/viewport-60.html
fast/viewport/viewport-61.html
fast/viewport/viewport-62.html
fast/viewport/viewport-63.html
fast/viewport/viewport-64.html
fast/viewport/viewport-65.html
fast/viewport/viewport-66.html
fast/viewport/viewport-67.html
fast/viewport/viewport-68.html
fast/viewport/viewport-69.html
fast/viewport/viewport-7.html
fast/viewport/viewport-70.html
fast/viewport/viewport-71.html
fast/viewport/viewport-72.html
fast/viewport/viewport-73.html
fast/viewport/viewport-74.html
fast/viewport/viewport-75.html
fast/viewport/viewport-76.html
fast/viewport/viewport-77.html
fast/viewport/viewport-78.html
fast/viewport/viewport-79.html
fast/viewport/viewport-8.html
fast/viewport/viewport-80.html
fast/viewport/viewport-81.html
fast/viewport/viewport-82.html
fast/viewport/viewport-83.html
fast/viewport/viewport-84.html
fast/viewport/viewport-85.html
fast/viewport/viewport-86.html
fast/viewport/viewport-87.html
fast/viewport/viewport-88.html
fast/viewport/viewport-9.html
fast/viewport/viewport-90.html
- dom/ViewportArguments.cpp:
(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):
WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
- Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
- Api/qwebpage.cpp:
(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::didReceiveViewportArguments):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:
Reviewed by Antti Koivisto.
http://people.opera.com/rune/TR/ED-css-viewport-20100806/
Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.
- fast/viewport/viewport-1-expected.txt: Added.
- fast/viewport/viewport-1.html: Added.
- fast/viewport/viewport-10-expected.txt: Added.
- fast/viewport/viewport-10.html: Added.
- fast/viewport/viewport-100-expected.txt: Added.
- fast/viewport/viewport-100.html: Added.
- fast/viewport/viewport-101-expected.txt: Added.
- fast/viewport/viewport-101.html: Added.
- fast/viewport/viewport-102-expected.txt: Added.
- fast/viewport/viewport-102.html: Added.
- fast/viewport/viewport-103-expected.txt: Added.
- fast/viewport/viewport-103.html: Added.
- fast/viewport/viewport-104-expected.txt: Added.
- fast/viewport/viewport-104.html: Added.
- fast/viewport/viewport-105-expected.txt: Added.
- fast/viewport/viewport-105.html: Added.
- fast/viewport/viewport-106-expected.txt: Added.
- fast/viewport/viewport-106.html: Added.
- fast/viewport/viewport-107-expected.txt: Added.
- fast/viewport/viewport-107.html: Added.
- fast/viewport/viewport-108-expected.txt: Added.
- fast/viewport/viewport-108.html: Added.
- fast/viewport/viewport-109-expected.txt: Added.
- fast/viewport/viewport-109.html: Added.
- fast/viewport/viewport-11-expected.txt: Added.
- fast/viewport/viewport-11.html: Added.
- fast/viewport/viewport-110-expected.txt: Added.
- fast/viewport/viewport-110.html: Added.
- fast/viewport/viewport-111-expected.txt: Added.
- fast/viewport/viewport-111.html: Added.
- fast/viewport/viewport-112-expected.txt: Added.
- fast/viewport/viewport-112.html: Added.
- fast/viewport/viewport-113-expected.txt: Added.
- fast/viewport/viewport-113.html: Added.
- fast/viewport/viewport-114-expected.txt: Added.
- fast/viewport/viewport-114.html: Added.
- fast/viewport/viewport-115-expected.txt: Added.
- fast/viewport/viewport-115.html: Added.
- fast/viewport/viewport-116-expected.txt: Added.
- fast/viewport/viewport-116.html: Added.
- fast/viewport/viewport-117-expected.txt: Added.
- fast/viewport/viewport-117.html: Added.
- fast/viewport/viewport-118-expected.txt: Added.
- fast/viewport/viewport-118.html: Added.
- fast/viewport/viewport-119-expected.txt: Added.
- fast/viewport/viewport-119.html: Added.
- fast/viewport/viewport-12-expected.txt: Added.
- fast/viewport/viewport-12.html: Added.
- fast/viewport/viewport-120-expected.txt: Added.
- fast/viewport/viewport-120.html: Added.
- fast/viewport/viewport-121-expected.txt: Added.
- fast/viewport/viewport-121.html: Added.
- fast/viewport/viewport-122-expected.txt: Added.
- fast/viewport/viewport-122.html: Added.
- fast/viewport/viewport-123-expected.txt: Added.
- fast/viewport/viewport-123.html: Added.
- fast/viewport/viewport-124-expected.txt: Added.
- fast/viewport/viewport-124.html: Added.
- fast/viewport/viewport-125-expected.txt: Added.
- fast/viewport/viewport-125.html: Added.
- fast/viewport/viewport-126.html: Added.
- fast/viewport/viewport-127.html: Added.
- fast/viewport/viewport-13-expected.txt: Added.
- fast/viewport/viewport-13.html: Added.
- fast/viewport/viewport-14-expected.txt: Added.
- fast/viewport/viewport-14.html: Added.
- fast/viewport/viewport-15-expected.txt: Added.
- fast/viewport/viewport-15.html: Added.
- fast/viewport/viewport-16-expected.txt: Added.
- fast/viewport/viewport-16.html: Added.
- fast/viewport/viewport-17-expected.txt: Added.
- fast/viewport/viewport-17.html: Added.
- fast/viewport/viewport-18-expected.txt: Added.
- fast/viewport/viewport-18.html: Added.
- fast/viewport/viewport-19-expected.txt: Added.
- fast/viewport/viewport-19.html: Added.
- fast/viewport/viewport-2-expected.txt: Added.
- fast/viewport/viewport-2.html: Added.
- fast/viewport/viewport-20-expected.txt: Added.
- fast/viewport/viewport-20.html: Added.
- fast/viewport/viewport-21-expected.txt: Added.
- fast/viewport/viewport-21.html: Added.
- fast/viewport/viewport-22-expected.txt: Added.
- fast/viewport/viewport-22.html: Added.
- fast/viewport/viewport-23-expected.txt: Added.
- fast/viewport/viewport-23.html: Added.
- fast/viewport/viewport-24-expected.txt: Added.
- fast/viewport/viewport-24.html: Added.
- fast/viewport/viewport-25-expected.txt: Added.
- fast/viewport/viewport-25.html: Added.
- fast/viewport/viewport-26-expected.txt: Added.
- fast/viewport/viewport-26.html: Added.
- fast/viewport/viewport-27-expected.txt: Added.
- fast/viewport/viewport-27.html: Added.
- fast/viewport/viewport-28-expected.txt: Added.
- fast/viewport/viewport-28.html: Added.
- fast/viewport/viewport-29-expected.txt: Added.
- fast/viewport/viewport-29.html: Added.
- fast/viewport/viewport-3-expected.txt: Added.
- fast/viewport/viewport-3.html: Added.
- fast/viewport/viewport-30-expected.txt: Added.
- fast/viewport/viewport-30.html: Added.
- fast/viewport/viewport-31-expected.txt: Added.
- fast/viewport/viewport-31.html: Added.
- fast/viewport/viewport-32-expected.txt: Added.
- fast/viewport/viewport-32.html: Added.
- fast/viewport/viewport-33-expected.txt: Added.
- fast/viewport/viewport-33.html: Added.
- fast/viewport/viewport-34-expected.txt: Added.
- fast/viewport/viewport-34.html: Added.
- fast/viewport/viewport-35-expected.txt: Added.
- fast/viewport/viewport-35.html: Added.
- fast/viewport/viewport-36-expected.txt: Added.
- fast/viewport/viewport-36.html: Added.
- fast/viewport/viewport-37-expected.txt: Added.
- fast/viewport/viewport-37.html: Added.
- fast/viewport/viewport-38-expected.txt: Added.
- fast/viewport/viewport-38.html: Added.
- fast/viewport/viewport-39-expected.txt: Added.
- fast/viewport/viewport-39.html: Added.
- fast/viewport/viewport-4-expected.txt: Added.
- fast/viewport/viewport-4.html: Added.
- fast/viewport/viewport-40-expected.txt: Added.
- fast/viewport/viewport-40.html: Added.
- fast/viewport/viewport-41-expected.txt: Added.
- fast/viewport/viewport-41.html: Added.
- fast/viewport/viewport-42-expected.txt: Added.
- fast/viewport/viewport-42.html: Added.
- fast/viewport/viewport-43-expected.txt: Added.
- fast/viewport/viewport-43.html: Added.
- fast/viewport/viewport-44-expected.txt: Added.
- fast/viewport/viewport-44.html: Added.
- fast/viewport/viewport-45-expected.txt: Added.
- fast/viewport/viewport-45.html: Added.
- fast/viewport/viewport-46-expected.txt: Added.
- fast/viewport/viewport-46.html: Added.
- fast/viewport/viewport-47-expected.txt: Added.
- fast/viewport/viewport-47.html: Added.
- fast/viewport/viewport-48-expected.txt: Added.
- fast/viewport/viewport-48.html: Added.
- fast/viewport/viewport-49-expected.txt: Added.
- fast/viewport/viewport-49.html: Added.
- fast/viewport/viewport-5-expected.txt: Added.
- fast/viewport/viewport-5.html: Added.
- fast/viewport/viewport-50-expected.txt: Added.
- fast/viewport/viewport-50.html: Added.
- fast/viewport/viewport-51-expected.txt: Added.
- fast/viewport/viewport-51.html: Added.
- fast/viewport/viewport-52-expected.txt: Added.
- fast/viewport/viewport-52.html: Added.
- fast/viewport/viewport-53-expected.txt: Added.
- fast/viewport/viewport-53.html: Added.
- fast/viewport/viewport-54-expected.txt: Added.
- fast/viewport/viewport-54.html: Added.
- fast/viewport/viewport-55-expected.txt: Added.
- fast/viewport/viewport-55.html: Added.
- fast/viewport/viewport-56-expected.txt: Added.
- fast/viewport/viewport-56.html: Added.
- fast/viewport/viewport-57-expected.txt: Added.
- fast/viewport/viewport-57.html: Added.
- fast/viewport/viewport-58-expected.txt: Added.
- fast/viewport/viewport-58.html: Added.
- fast/viewport/viewport-59-expected.txt: Added.
- fast/viewport/viewport-59.html: Added.
- fast/viewport/viewport-6-expected.txt: Added.
- fast/viewport/viewport-6.html: Added.
- fast/viewport/viewport-60-expected.txt: Added.
- fast/viewport/viewport-60.html: Added.
- fast/viewport/viewport-61-expected.txt: Added.
- fast/viewport/viewport-61.html: Added.
- fast/viewport/viewport-62-expected.txt: Added.
- fast/viewport/viewport-62.html: Added.
- fast/viewport/viewport-63-expected.txt: Added.
- fast/viewport/viewport-63.html: Added.
- fast/viewport/viewport-64-expected.txt: Added.
- fast/viewport/viewport-64.html: Added.
- fast/viewport/viewport-65.html: Added.
- fast/viewport/viewport-66-expected.txt: Added.
- fast/viewport/viewport-66.html: Added.
- fast/viewport/viewport-67-expected.txt: Added.
- fast/viewport/viewport-67.html: Added.
- fast/viewport/viewport-68-expected.txt: Added.
- fast/viewport/viewport-68.html: Added.
- fast/viewport/viewport-69-expected.txt: Added.
- fast/viewport/viewport-69.html: Added.
- fast/viewport/viewport-7-expected.txt: Added.
- fast/viewport/viewport-7.html: Added.
- fast/viewport/viewport-70-expected.txt: Added.
- fast/viewport/viewport-70.html: Added.
- fast/viewport/viewport-71-expected.txt: Added.
- fast/viewport/viewport-71.html: Added.
- fast/viewport/viewport-72-expected.txt: Added.
- fast/viewport/viewport-72.html: Added.
- fast/viewport/viewport-73-expected.txt: Added.
- fast/viewport/viewport-73.html: Added.
- fast/viewport/viewport-74-expected.txt: Added.
- fast/viewport/viewport-74.html: Added.
- fast/viewport/viewport-75-expected.txt: Added.
- fast/viewport/viewport-75.html: Added.
- fast/viewport/viewport-76-expected.txt: Added.
- fast/viewport/viewport-76.html: Added.
- fast/viewport/viewport-77-expected.txt: Added.
- fast/viewport/viewport-77.html: Added.
- fast/viewport/viewport-78-expected.txt: Added.
- fast/viewport/viewport-78.html: Added.
- fast/viewport/viewport-79-expected.txt: Added.
- fast/viewport/viewport-79.html: Added.
- fast/viewport/viewport-8-expected.txt: Added.
- fast/viewport/viewport-8.html: Added.
- fast/viewport/viewport-80-expected.txt: Added.
- fast/viewport/viewport-80.html: Added.
- fast/viewport/viewport-81-expected.txt: Added.
- fast/viewport/viewport-81.html: Added.
- fast/viewport/viewport-82.html: Added.
- fast/viewport/viewport-83-expected.txt: Added.
- fast/viewport/viewport-83.html: Added.
- fast/viewport/viewport-84.html: Added.
- fast/viewport/viewport-85-expected.txt: Added.
- fast/viewport/viewport-85.html: Added.
- fast/viewport/viewport-86-expected.txt: Added.
- fast/viewport/viewport-86.html: Added.
- fast/viewport/viewport-87.html: Added.
- fast/viewport/viewport-88-expected.txt: Added.
- fast/viewport/viewport-88.html: Added.
- fast/viewport/viewport-9-expected.txt: Added.
- fast/viewport/viewport-9.html: Added.
- fast/viewport/viewport-90-expected.txt: Added.
- fast/viewport/viewport-90.html: Added.
- platform/gtk/Skipped: Skip tests due to missing DRT support.
- platform/mac/Skipped: Skip tests due to missing DRT support.
- platform/win/Skipped: Skip tests due to missing DRT support.
- platform/qt/Skipped: Skip failing tests.
- 3:15 AM Changeset in webkit [67375] by
-
- 2 edits in trunk/WebCore
2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Don't add empty strings to list of supported image MIME types
https://bugs.webkit.org/show_bug.cgi?id=45643
After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
returns an empty string instead of "application/octet-stream" for unsupported
extensions. Don't add these to the list of supported types, and clean out
the logic that removed "application/octet-stream" from supported types.
Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
a HashSet<String>.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- 3:12 AM Changeset in webkit [67374] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Re-skip some layout tests that fail on the bots but not on my system
https://bugs.webkit.org/show_bug.cgi?id=45626
- platform/mac-wk2/Skipped:
- 2:50 AM Changeset in webkit [67373] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Attempted Qt build fix.
- html/parser/HTMLElementStack.cpp:
- 2:19 AM Changeset in webkit [67372] by
-
- 6 edits in trunk
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636
Add some tests of breaking out of foreign content.
- html5lib/resources/webkit01.dat:
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636
Now breaking out of foreign content doesn't always bring you back to
HTML. If you have a foreign content element that can contain HTML, you
just get brought back to that element.
- html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
- html/parser/HTMLElementStack.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndOfFile):
- 1:58 AM Changeset in webkit [67371] by
-
- 2 edits in trunk/JavaScriptCore
2010-09-13 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Don't call _msize
https://bugs.webkit.org/show_bug.cgi?id=45556
Because Brew MP uses its own memory allocator, it is not correct to use
_msize in fastMallocSize. Add !PLATFORM(BREWMP) guard.
- wtf/FastMalloc.cpp: (WTF::fastMallocSize):
- 1:39 AM Changeset in webkit [67370] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert notImplemented() to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=45639
The reason we never implemented this state is because it's not actually
reachable.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
- 1:20 AM Changeset in webkit [67369] by
-
- 2 edits in trunk/WebCore
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Buildfix for ScrollAnimatorWin
https://bugs.webkit.org/show_bug.cgi?id=45595
Use fabs() instead of abs().
- platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::animateScroll):
- 1:03 AM Changeset in webkit [67368] by
-
- 1 edit2 adds in trunk/WebKit/wince
2010-09-13 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
Add FrameNetworkingContextWinCE
https://bugs.webkit.org/show_bug.cgi?id=45474
- WebCoreSupport/FrameNetworkingContextWinCE.cpp: Added. (WebKit::FrameNetworkingContextWinCE::FrameNetworkingContextWinCE): (WebKit::FrameNetworkingContextWinCE::userAgent): (WebKit::FrameNetworkingContextWinCE::referrer):
- WebCoreSupport/FrameNetworkingContextWinCE.h: Added. (WebKit::FrameNetworkingContextWinCE::create):
- 12:22 AM Changeset in webkit [67367] by
-
- 2 edits in trunk/WebCore
2010-09-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove fixed FIXME
https://bugs.webkit.org/show_bug.cgi?id=45637
The spec made assertions that were false. Hixie fixed the spec by
removing the assertions. There's no need to keep these FIXMEs in the
code.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
Sep 12, 2010:
- 11:43 PM Changeset in webkit [67366] by
-
- 3 edits8 adds in trunk
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634
Add tests recommended by Hixie.
- fast/parser/form-pointer-1-expected.txt: Added.
- fast/parser/form-pointer-1.html: Added.
- fast/parser/form-pointer-2-expected.txt: Added.
- fast/parser/form-pointer-2.html: Added.
- fast/parser/form-pointer-3-expected.txt: Added.
- fast/parser/form-pointer-3.html: Added.
- fast/parser/form-pointer-4-expected.txt: Added.
- fast/parser/form-pointer-4.html: Added.
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634
The spec changed to say what we do here so this FIXME isn't needed
anymore.
Tests: fast/parser/form-pointer-1.html
fast/parser/form-pointer-2.html
fast/parser/form-pointer-3.html
fast/parser/form-pointer-4.html
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
- 11:24 PM Changeset in webkit [67365] by
-
- 6 edits5 adds in trunk
2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();
- scrollbars/resources/scrollable-iframe.html: Added.
- scrollbars/scrollevent-iframe-no-scrolling-expected.txt: Added.
- scrollbars/scrollevent-iframe-no-scrolling-wheel-expected.txt: Added.
- scrollbars/scrollevent-iframe-no-scrolling-wheel.html: Added.
- scrollbars/scrollevent-iframe-no-scrolling.html: Added.
2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();
Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html
scrollbars/scrollevent-iframe-no-scrolling.html
- page/FrameView.cpp: (WebCore::FrameView::valueChanged): Added.
- page/FrameView.h: Added a new method.
- platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged): Added. (WebCore::ScrollView::updateScrollbars):
- platform/ScrollView.h: Added a new method.
- 10:45 PM Changeset in webkit [67364] by
-
- 5 edits in trunk/LayoutTests
2010-09-12 Adam Barth <abarth@webkit.org>
Revert mistaken changes to test baselines.
- platform/mac/http/tests/navigation/post-goback1-expected.txt:
- platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
- platform/mac/http/tests/navigation/postredirect-frames-expected.txt:
- platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
- 9:21 PM Changeset in webkit [67363] by
-
- 6 edits in trunk
2010-09-12 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517
- DEPS: Roll Chromium revision to r59033 to have webkit_support_gfx.h.
- WebKit.gyp:
2010-09-12 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517
Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
- DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): (Image::createFromFilename): (diffImages):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
- 9:21 PM Changeset in webkit [67362] by
-
- 15 edits in trunk
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Add an note for API readiness.
- platform/chromium/test_expectations.txt:
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Added an API for testing marker state.
We locate this here instead of DRT for sharing the logic between
multiple ports.
- WebCore.exp.in:
- editing/Editor.cpp: (WebCore::Editor::selectionStartHasSpellingMarkerFor):
- editing/Editor.h:
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Exported Frame::selectionStartHasSpellingMarkerFor() for DRT use.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
- src/WebFrameImpl.h:
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Moved the actual logic of hasSpellingMarker into WebCore to share
it with other ports.
- WebView/WebFrame.mm: (-[WebFrame hasSpellingMarker:length:]):
2010-09-10 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441
Added TextInputController::hasSpellingMarker().
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::hasSpellingMarker):
- DumpRenderTree/chromium/TextInputController.h:
- 8:30 PM Changeset in webkit [67361] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Think this is the last set.
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [67360] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Suppress some more failures so I can triage the WebKit roll
without the tree being red.
- platform/chromium/test_expectations.txt:
- 7:39 PM Changeset in webkit [67359] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Suppress some failures so I can
triage the WebKit roll without the tree being red.
- platform/chromium/test_expectations.txt:
- 6:09 PM Changeset in webkit [67358] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change. Fix a duplicate expectation and
remove some passing tests.
- platform/chromium/test_expectations.txt:
- 6:04 PM Changeset in webkit [67357] by
-
- 10 edits in trunk
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570
Before this patch, we were using an unsafe pattern of walking the
sibling list without grabbing references. Instead, we should use the
shiny new takeAllChildrenFrom method that shoves the children into a
vector first. Also, update takeAllChildrenFrom to handle the case
where the old parent is attached.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- html/parser/HTMLTreeBuilder.h:
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570
More test cases.
- html5lib/resources/webkit01.dat:
- 5:42 PM Changeset in webkit [67356] by
-
- 5 edits in trunk
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621
Add new tests and (minor) test progression.
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected.txt:
2010-09-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621
Update our list of special tags to match the spec.
- html/parser/HTMLTreeBuilder.cpp:
- 5:19 PM Changeset in webkit [67355] by
-
- 5 edits in trunk
2010-09-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix http/tests/navigation/reload-subframe-object.html
Unskip http/tests/navigation/reload-subframe-object.html
- platform/qt/Skipped:
2010-09-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix http/tests/navigation/reload-subframe-object.html
We need to bring our use of getMimeTypeForPath() and
getMimeTypeForExtension() into line with WebCore expectations.
We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
where an empty mimetype should be returned if no match is found, and
MIMETypeRegistry::getMIMETypeForPath() for cases where
'application/octet-stream' should be returned if no match is found.
Fixes http/tests/navigation/reload-subframe-object.html
Based on findings in webkit.org/b/31398 and webkit.org/b/15554.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 5:02 PM Changeset in webkit [67354] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by James Robinson.
Remove some tests from the WebKit2 skipped list that are now passing
https://bugs.webkit.org/show_bug.cgi?id=45625
- platform/mac-wk2/Skipped:
- 4:40 PM Changeset in webkit [67353] by
-
- 2 edits in trunk/LayoutTests
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 4:37 PM Changeset in webkit [67352] by
-
- 2 edits in trunk/WebKitTools
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
My last change accidentally contained a local change to the
rebaselinig script; webkit-patch land picked it up without telling
me and committed it :(
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 4:34 PM Changeset in webkit [67351] by
-
- 3 edits in trunk
2010-09-12 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 4:04 PM Changeset in webkit [67350] by
-
- 2 edits in trunk/WebCore
Neglect unlikely hyphenation opportunities
https://bugs.webkit.org/show_bug.cgi?id=45606
Reviewed by Adele Peterson.
Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about
3% of the hyphenation opportunities.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more
than 5/4 the font size.
- 3:58 PM Changeset in webkit [67349] by
-
- 5 edits16 adds3 deletes in trunk/LayoutTests
2010-09-12 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r67328.
http://trac.webkit.org/changeset/67328
https://bugs.webkit.org/show_bug.cgi?id=45610
Broke layout tests on mac and chromium.
- http/tests/navigation/post-basic-expected.txt: Removed.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames-expected.txt: Removed.
- http/tests/navigation/post-frames.html:
- http/tests/navigation/resources/page-that-posts.html: Removed.
- http/tests/navigation/resources/postresult.pl:
- platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Added.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Added.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Added.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Added.
- platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Added.
- platform/chromium-win/http/tests/navigation/post-basic-expected.png: Added.
- platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Added.
- platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Added.
- platform/chromium-win/http/tests/navigation/post-frames-expected.png: Added.
- platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-basic-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.checksum.
- platform/mac/http/tests/navigation/post-basic-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.png.
- platform/mac/http/tests/navigation/post-basic-expected.txt: Added.
- platform/mac/http/tests/navigation/post-frames-expected.checksum: Added.
- platform/mac/http/tests/navigation/post-frames-expected.png: Added.
- platform/mac/http/tests/navigation/post-frames-expected.txt: Added.
- 2:19 PM Changeset in webkit [67348] by
-
- 2 edits in trunk/WebKit/qt
doc: Changed the title so lists of contents sort better.
Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
- docs/qtwebkit.qdoc:
- 2:08 PM Changeset in webkit [67347] by
-
- 2 edits in trunk/WebKit/qt
Doc: More work on the QML documentation.
Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
- declarative/qdeclarativewebview.cpp:
- 1:58 PM Changeset in webkit [67346] by
-
- 2 edits in trunk/WebKit/qt
[Qml] Ensure WebView gets focus when an editable node is clicked on.
Patch by Martin Jones <martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
Task-number: QTBUG-13342
- declarative/qdeclarativewebview.cpp:
(GraphicsWebView::mousePressEvent):
- 1:56 PM Changeset in webkit [67345] by
-
- 2 edits in trunk/WebKit/qt
Doc: qdoc fixes.
Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
- declarative/qdeclarativewebview.cpp:
- 1:53 PM Changeset in webkit [67344] by
-
- 2 edits in trunk/WebCore
[Qt] fix qt_webkit_version.pri install for in-Qt builds
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.
Task-number: QTBUG-13306
- WebCore.pro:
- 1:50 PM Changeset in webkit [67343] by
-
- 4 edits in trunk
WebCore: [Qt] Let QtWebKit inject itself into the qt configuration
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.
Task-number: QTBUG-12379
- WebCore.pro:
WebKit/qt: [Qt] let WebKit inject itself into the qt configuration
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
Task-number: QTBUG-12379
- qt_webkit_version.pri: Use the faster + instead of *
operator to add webkit to the config.
- 1:44 PM Changeset in webkit [67342] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix group of declarative web view in QML docs.
Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.
- declarative/qdeclarativewebview.cpp:
- 12:08 PM Changeset in webkit [67341] by
-
- 5 edits in trunk/LayoutTests
[Qt] Rebase a bunch of tests after r67200.
Reviewed by Antonio Gomes.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
- 11:40 AM Changeset in webkit [67340] by
-
- 2 edits in trunk/WebCore
[Qt] Build fix.
- WebCore.pro: Re-add erroneously removed sources.
- 11:35 AM Changeset in webkit [67339] by
-
- 6 edits in trunk
2010-09-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618
Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG
paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
- platform/graphics/Path.h:
- platform/graphics/qt/PathQt.cpp:
2010-09-12 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618
Skip fast/canvas/canvas-closePath-single-point.html - it can be unskipped again
once the bot is upgraded to Qt 4.7.1.
- platform/qt/Skipped:
- 11:32 AM Changeset in webkit [67338] by
-
- 2 edits in trunk/WebCore
Fix the Gtk and minimal builds.
- plugins/PluginView.cpp:
(WebCore::PluginView::npObject): Correct the #ifdefs.
(WebCore::PluginView::bindingInstance): Moved npErr variable
into npObject() function where it is used.
- 11:28 AM Changeset in webkit [67337] by
-
- 3 edits in trunk/WebCore
[Qt] Prospective build fix for minimal build.
- plugins/PluginView.cpp: Guard newly added function
by ENABLE_NETSCAPE_PLUGIN feature.
(WebCore::PluginView::npObject):
- plugins/PluginView.h:
- 11:21 AM Changeset in webkit [67336] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Partial implementation of Qt bridge using V8 and QtScript.
Reviewed by Andreas Kling.
- Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript): Stub it out for now,
to compile, until we have a conversion path between v8::Object
and QScriptValue.
- Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject): Implemented using
few lines of QtScript code.
(QWebFrame::evaluateJavaScript): Ditto.
- 11:19 AM Changeset in webkit [67335] by
-
- 4 edits1 add in trunk/WebCore
[Qt] Add support for binding QtWebKit to a QScriptEngine.
Reviewed by Andreas Kling.
The ScriptController owns the V8 context, and this patch
for the Qt build also gives it a QScriptEngine, that has
been instructed to adopt the V8 context.
This is the enabler for the QObject bindings, used in
the API and DRT.
- WebCore.pro:
- bindings/v8/ScriptController.cpp: Include QScriptEngine
for the Qt build, to let the ~ScriptController destructor
find the QScriptEngine destructor (via OwnPtr).
- bindings/v8/ScriptController.h: Declare getters.
- bindings/v8/ScriptControllerQt.cpp: Added.
(WebCore::ScriptController::qtScriptEngine): Implement
engine adoption.
- 11:15 AM Changeset in webkit [67334] by
-
- 2 edits in trunk/WebCore
[Qt] Last bits and pieces for a V8 build.
Reviewed by Andreas Kling.
When building with V8, get it from QtScript.
- WebCore.pro: Use QtScript, removed non-existant
bridge files from the build.
- 11:12 AM Changeset in webkit [67333] by
-
- 4 edits2 adds in trunk/WebCore
[Qt] Add PlatformBridge for V8 build.
Reviewed by Andreas Kling.
Add the minimalisting platform bridge with the two
methods needed by NPV8Object.cpp.
- WebCore.pro:
- platform/qt/PlatformBridge.h: Added.
- platform/qt/PlatformBridgeQt.cpp: Added.
(WebCore::PlatformBridge::popupsAllowed):
(WebCore::PlatformBridge::pluginScriptableObject):
- plugins/PluginView.cpp: Refactor the plugin object
retrieval code into a separate function, called by
bindingInstance() and PlatformBridge.
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):
- plugins/PluginView.h:
- 11:08 AM Changeset in webkit [67332] by
-
- 2 edits in trunk/WebKit/qt
Fix the build with V8.
Reviewed by Andreas Kling.
This is a temporary kludge until the scriptworld stuff is properly
ported, as part of the upcoming DRT work.
- Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):
- 11:08 AM Changeset in webkit [67331] by
-
- 2 edits in trunk/WebCore
Fix compilation of the V8 bindings on X11 with Qt.
Reviewed by Andreas Kling.
This changes brings the file in sync with its copy in bridge/,
adding additional conflicting X11 keywords to undef. This is
a temporary fix until the file is removed altogether, which is
tracked in https://bugs.webkit.org/show_bug.cgi?id=45617
- bindings/v8/npruntime_internal.h:
- 10:38 AM Changeset in webkit [67330] by
-
- 4 edits in trunk/WebCore
2010-09-11 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
http/tests/media/text-served-as-text.html failing on Windows (Debug+Release)
https://bugs.webkit.org/show_bug.cgi?id=45603
Disable the eat/text components under Windows the same way as we do on the Mac.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
- platform/graphics/win/QTMovie.cpp:
- platform/graphics/win/QTMovie.h:
- 9:57 AM Changeset in webkit [67329] by
-
- 4 edits in trunk/WebCore
Fix compilation of the V8 bindings on X11 with Qt.
Reviewed by Andreas Kling.
These headers include npruntime, which drag on X11Resources.h, which
among other things #define's None and Boolean. Later on v8.h is included,
which declares these in enums and therefore conflicts. npruntime_internal.h
was introduced exactly to address this problem by including npruntime.h
and undeff'ing the offending constants.
- bindings/v8/V8Helpers.h:
- bindings/v8/V8NPObject.h:
- bindings/v8/V8NPUtils.h:
- 8:11 AM Changeset in webkit [67328] by
-
- 5 edits3 adds16 deletes in trunk/LayoutTests
2010-09-12 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610
post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.
- http/tests/navigation/post-basic-expected.txt: Added.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames-expected.txt: Added.
- http/tests/navigation/post-frames.html:
- http/tests/navigation/resources/page-that-posts.html: Added.
- http/tests/navigation/resources/postresult.pl:
- platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
- platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
- platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
- 7:47 AM Changeset in webkit [67327] by
-
- 2 edits in trunk/WebCore
Gtk build fix.
Use false instead of False after
http://trac.webkit.org/changeset/67323
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
- 7:28 AM Changeset in webkit [67326] by
-
- 2 edits in trunk/WebCore
[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.
Reviewed by Andreas Kling.
- bindings/v8/V8Binding.cpp:
(WebCore::WebCoreStringResource::WebCoreStringResource): In this
line an AtomicString should be converted to a WTF::String. The former
has a conversion operator to the latter, to be able to call the
WTF::String copy constructor. When compiling with Qt, then AtomicString
also has a conversion operator to QString _and_ WTF::String has an
implicit constructor that takes a QString. Therefore the compiler is
confused and not sure which conversion to prefer, the one that isn't
actually a conversion - going to WTF::String - or the conversion from
AtomicString to QString and then constructing the WTF::String from
a QString. To resolve this ambiguity we explicitly call the string()
helper function on the AtomicString, which is equivalent to the
operator WTF::String().
- 6:57 AM Changeset in webkit [67325] by
-
- 3 edits in trunk/WebCore
Fix the build without JSC.
Reviewed by Andreas Kling.
Complement http://trac.webkit.org/changeset/59826 and
add missing JSC guards.
- plugins/PluginView.cpp:
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):
- 6:57 AM Changeset in webkit [67324] by
-
- 3 edits in trunk/WebCore
Fix compilation with V8 and XPath enabled.
Reviewed by Andreas Kling.
V8XPathNSResolver.cpp includes V8XPathNSResolver.h,
which includes V8DOMWrapper.h as its first header.
V8DOMWrapper.h then uses V8XPathNSResolver in an inline
function, and gcc doesn't seem to like this, because
at this point the type isn't known ("V8XPathNSResolver
has not been declared"). Forward declaring the type
doesn't help unfortunately: "incomplete type
'WebCore::V8XPathNSResolver' used in nested name
specifier".
To resolve this circular dependency, this patch moves
the inline function into the .cpp file.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getXPathNSResolver):
- bindings/v8/V8DOMWrapper.h:
- 6:33 AM Changeset in webkit [67323] by
-
- 4 edits in trunk/WebCore
[Qt][X11] Fix build with V8 against X11 headers.
Reviewed by Andreas Kling.
Added "True" and "False" to the list of words
we free from the X11 macro jail.
- bridge/npruntime_internal.h:
- config.h: The V8 bindings end up indirectly pulling
in X11 headers and they use True/False. There's no
central header apart from this one, so include the
x11 fixing header here for Qt/X11/V8.
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paint): Use false instead of False
since False isn't available anymore.
- 6:28 AM Changeset in webkit [67322] by
-
- 2 edits in trunk/WebCore
[Qt] Fix compilation with V8 and Qt.
Reviewed by Andreas Kling.
Use WebKit's page cache for ScriptCachedFrameData.
- bindings/v8/ScriptCachedFrameData.h:
- 6:25 AM Changeset in webkit [67321] by
-
- 2 edits in trunk/WebCore
Fix compiler warning.
Reviewed by Andreas Kling.
NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't
initialized explicitly.
- bindings/v8/NPV8Object.cpp:
- 4:16 AM Changeset in webkit [67320] by
-
- 2 edits in trunk/WebCore
2010-09-12 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] get_n_selections and get_selection fail when selecting text across object boundaries
https://bugs.webkit.org/show_bug.cgi?id=26991
Fix AtkText getNSelections() and getSelection() to work properly
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): Check that both the selection intersects the node AND that the selection is not just "touching" one of the boundaries for the selected node. We want to check whether the node is actually inside the region, at least partially (getSelectionOffsetsForObject): New function to get the start and end offsets of a selection for a given accessible object. (webkit_accessible_text_get_selection): Return zero when both start and end offsets are equal, following the lead of GAIL.
- 12:37 AM Changeset in webkit [67319] by
-
- 2 edits in trunk/LayoutTests
2010-09-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Animations don't seem to run in multiple WebKit2 animation tests
https://bugs.webkit.org/show_bug.cgi?id=42137
- platform/mac-wk2/Skipped: These tests no longer fail, so simply unskip them.
Sep 11, 2010:
- 11:37 PM Changeset in webkit [67318] by
-
- 2 edits in trunk/WebKit2
2010-09-11 Daniel Bates <dbates@rim.com>
Attempt to fix the Qt Linux Release build after changeset 67312 <http://trac.webkit.org/changeset/67312>.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add missing ',' in WKPageUIClient initialization list.
- 9:58 PM Changeset in webkit [67317] by
-
- 2 edits in trunk/WebKitTools
2010-09-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Attempt to fix Windows MiniBrowser build (untested)
https://bugs.webkit.org/show_bug.cgi?id=45609
- MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt):
- 7:28 PM Changeset in webkit [67316] by
-
- 21 edits in trunk
2010-09-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219
This function was secretly an instance function because callers needed
to pass in a document (which owns a SecurityOrigin). Only the
FrameLoader actually needs the method to be static.
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/Cache.cpp:
(WebCore::Cache::requestResource):
- Notice that DocLoader::doc() can never be 0.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
- loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
- page/SecurityOrigin.h:
- plugins/PluginView.cpp: (WebCore::PluginView::load):
2010-09-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
- WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):
2010-09-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219
- WebFrame.cpp: (WebFrame::allowsFollowingLink):
2010-09-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
- 7:17 PM Changeset in webkit [67315] by
-
- 2 edits in trunk/LayoutTests
2010-09-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Remove nonexistent test from skipped list
https://bugs.webkit.org/show_bug.cgi?id=45608
- platform/mac-wk2/Skipped:
- 7:15 PM Changeset in webkit [67314] by
-
- 2 edits in trunk/WebKitTools
Fix zoom related tests when testing WebKit2.
Reviewed by Maciej Stachowiak.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
- 7:08 PM Changeset in webkit [67313] by
-
- 2 edits in trunk/LayoutTests
2010-09-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Skip some new tests that depend on APIs missing from WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=45607
- platform/mac-wk2/Skipped:
- 6:50 PM Changeset in webkit [67312] by
-
- 13 edits in trunk
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
https://bugs.webkit.org/show_bug.cgi?id=45605
Reviewed by Dan Bernstein.
WebKit2:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::setStatusText):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setStatusbarText):
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 6:17 PM Changeset in webkit [67311] by
-
- 15 edits in trunk
Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
https://bugs.webkit.org/show_bug.cgi?id=45604
Reviewed by Dan Bernstein.
WebKit2:
- Shared/CoreIPCSupport/WebPageMessageKinds.h:
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::source):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
WebKitTools:
Add ability to dump the main frame's source to the console.
- MiniBrowser/mac/BrowserWindowController.h:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController dumpSourceToConsole:]):
- MiniBrowser/mac/MainMenu.xib:
- 4:25 PM Changeset in webkit [67310] by
-
- 2 edits in trunk/WebKitTools
2010-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Remove unneeded Empty Queue messages
https://bugs.webkit.org/show_bug.cgi?id=45602
We already have a /gc job to delete these.
recentstatus.py is already smart enough to use the
most recent of the workitems last update or the most recent status,
so removing these should not change the _last_status_date() return
value more than a few milliseconds.
These messages just spam the recent status log.
- Scripts/webkitpy/tool/commands/queues.py:
- 12:15 PM Changeset in webkit [67309] by
-
- 2 edits in trunk/WebCore
Unreviewed.
[Qt] Trivial V8 build fix.
- WebCore.pri: Add storage, workers and css to the include paths for the
JS code generator.
- 11:28 AM Changeset in webkit [67308] by
-
- 5 edits in trunk/WebCore
2010-09-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=45157
Include CString.h where necessary. Chromium builds would get it from
KURLGooglePrivate.h so this is only an issue for Qt + V8.
- bindings/v8/V8Proxy.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorProfilerAgent.cpp:
- plugins/PluginDatabase.cpp:
- 11:22 AM Changeset in webkit [67307] by
-
- 4 edits in trunk
[Qt] V8 port: webkit project files changes
https://bugs.webkit.org/show_bug.cgi?id=45140
Reviewed by Andreas Kling.
.:
- WebKit.pro: Don't compile JavaScriptCore and jsc when
building with v8.
WebCore:
- WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.
- 11:11 AM Changeset in webkit [67306] by
-
- 6 edits1 add in trunk
JavaScriptCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141
Reviewed by Andreas Kling.
- JavaScriptCore.pro: Moved wtf specific files to wtf.pri,
so that they can also be used from WebCore.pro for v8 builds.
- wtf/wtf.pri: Added.
WebCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141
Reviewed by Andreas Kling.
Modify webcore project files to include V8 javascript engine. By default disabled.
- WebCore.pri:
- WebCore.pro:
- features.pri:
- 11:09 AM Changeset in webkit [67305] by
-
- 2 edits in trunk/WebCore
2010-09-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
Web Inspector: Include CString.h in generated files
This is necessary for generated code that uses the CString
returned by String::utf8() (from generateBackendDispatcher)
Chromium builds already get CString.h from KURLGooglePrivate.h
so this issue only occurs when building Qt against V8.
- inspector/CodeGeneratorInspector.pm:
- 10:44 AM Changeset in webkit [67304] by
-
- 4 edits in trunk/WebKit/qt
2010-09-11 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] V8 port for Qt platform: Qt WebCoreSupport changes
https://bugs.webkit.org/show_bug.cgi?id=45149
Original patch by Vlad Burlik <volodimir.burlik@nokia.com>
Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
FrameLoaderClientQt.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame): (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame): (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext): (WebCore::FrameLoaderClientQt::createDocumentLoader):
- WebCoreSupport/FrameLoaderClientQt.h:
- 10:42 AM Changeset in webkit [67303] by
-
- 1 edit1 add in trunk/LayoutTests
2010-09-11 Martin Robinson <mrobinson@igalia.com>
Add a platform-specific result after r67281.
- platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.
- 10:09 AM Changeset in webkit [67302] by
-
- 2 edits in trunk/WebKitTools
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Fix Python exception when generating synthetic patch IDs
https://bugs.webkit.org/show_bug.cgi?id=45592
Can't concatenate strings and numbers directly.
- QueueStatusServer/handlers/queuestatus.py:
- 10:06 AM Changeset in webkit [67301] by
-
- 5 edits in trunk/WebKit/qt
2010-09-11 Vlad Burlik <volodimir.burlik@nokia.com>
Reviewed by Andreas Kling.
[Qt] V8 port for QT platform: QT API implementation changes
https://bugs.webkit.org/show_bug.cgi?id=45148
V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
and QWebFrame::evaluateJavaScript()
- Api/qwebelement.cpp: (setupScriptContext): JSC and V8 variations (QWebElement::evaluateJavaScript):
- Api/qwebelement.h:
- Api/qwebframe.cpp: QObject injection to V8 world (QWebFrame::addToJavaScriptWindowObject): (QWebFrame::evaluateJavaScript):
- Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8 (QWebPagePrivate::QWebPagePrivate):
- 9:25 AM Changeset in webkit [67300] by
-
- 4 edits in trunk
2010-09-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make introspection work with g-o-i 0.9.5
https://bugs.webkit.org/show_bug.cgi?id=45590
Bump required gobject-introspection version to 0.9.5.
- configure.ac:
WebKit/gtk:
2010-09-11 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make introspection work with g-o-i 0.9.5
https://bugs.webkit.org/show_bug.cgi?id=45590
Use new type syntax and bump version number of the gir file.
- JSCore.gir.in:
- 9:19 AM Changeset in webkit [67299] by
-
- 3 edits in trunk/LayoutTests
2010-09-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
chromium fast/dom/replaceChild.html regression by r67182
https://bugs.webkit.org/show_bug.cgi?id=45527
Turns out this is a progression! Our new images
match minefield (and sanity). The old image had a
border drawn which should have been removed when the
iframe was replaced.
Other platforms may need to update their results as well.
- platform/mac/fast/dom/replaceChild-expected.checksum:
- platform/mac/fast/dom/replaceChild-expected.png:
- 9:09 AM Changeset in webkit [67298] by
-
- 2 edits in trunk/LayoutTests
2010-09-11 Robert Hogan <robert@webkit.org>
Unreviewed, unskip passing test.
Test fixed by http://trac.webkit.org/changeset/56511
- platform/qt/Skipped:
- 8:04 AM Changeset in webkit [67297] by
-
- 2 edits in trunk/WebKit/efl
2010-09-11 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Fix EFL build after r67274
https://bugs.webkit.org/show_bug.cgi?id=45584
Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
to proper apis chaged by r67264.
- ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
- 6:20 AM Changeset in webkit [67296] by
-
- 3 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.
Reviewed by Sam Weinig.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):
- rendering/RenderFlexibleBox.h:
- 3:06 AM Changeset in webkit [67295] by
-
- 5 edits in trunk/WebKitTools
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Group statuses in queue status by patch ID
https://bugs.webkit.org/show_bug.cgi?id=45588
Group statuses by patch ID so that the status page is easier
to scan.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/stylesheets/dashboard.css: (.status-group): (.status-bug): (.status-group ul): (.status-group ul li): (.status-group ul li:hover): (.status-cell): (.status-cell:hover): (.status-cell.pass): (.status-cell.fail): (.status-cell.pending): (.status-cell.error):
- QueueStatusServer/templates/dashboard.html:
- QueueStatusServer/templates/queuestatus.html:
- 2:48 AM Changeset in webkit [67294] by
-
- 7 edits2 adds2 deletes in trunk
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479
Remove tests from Chromium expectations that now pass. Add
Chromium/Linux expectations for the script test, since it reports a
different MIME type (application/javascript vs.
application/x-javascript).
- platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
- platform/chromium-linux/fast/preloader/script-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479
Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes):
- DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse):
- 2:32 AM Changeset in webkit [67293] by
-
- 2 edits in trunk/LayoutTests
2010-09-11 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
https://bugs.webkit.org/show_bug.cgi?id=45579
- platform/chromium/test_expectations.txt:
- 1:59 AM Changeset in webkit [67292] by
-
- 8 edits2 adds in trunk
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565
Add test to read back the background image URL from an element that was
created via innerHTML (reduction of http://crbug.com/55023).
- fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
- fast/innerHTML/innerHTML-uri-resolution.html: Added.
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565
The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.
Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.
Test: fast/innerHTML/innerHTML-uri-resolution.html
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h: (WebCore::HTMLDocument::create):
- html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
- 12:54 AM Changeset in webkit [67291] by
-
- 30 edits in trunk
Add NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug.cgi?id=42292
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.
WebCore:
Activate NetworkingContext:
Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
- loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
- loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::loadEntry):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
- platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::start):
WebKit/chromium:
- src/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
WebKit/gtk:
- webkit/webkitdownload.cpp:
(webkit_download_start):
- webkit/webkitprivate.cpp:
(currentToplevelCallback):
WebKit/win:
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::blockedError):
- WebCoreSupport/WebFrameNetworkingContext.h:
WebKit2:
- WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
- WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::create):
- 12:23 AM Changeset in webkit [67290] by
-
- 2 edits in trunk/WebKitTools
2010-09-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org should expose /remote_api for data upload/download
https://bugs.webkit.org/show_bug.cgi?id=45559
- QueueStatusServer/app.yaml:
- /remote_api is a standard app-engine service which allows use of the bulk uploader for data upload/download. Exposing this (for admin access only) allows us to use
- 12:07 AM Changeset in webkit [67289] by
-
- 3 edits in trunk/WebKit/qt
2010-09-10 yi shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] selected text gets deleted when qgraphicswebview losts focus
https://bugs.webkit.org/show_bug.cgi?id=45539
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
