Timeline



Sep 17, 2010:

11:16 PM Changeset in webkit [67776] by weinig@apple.com
  • 10 edits in trunk

Need a way to load data (as plain text) in a WKPage
<rdar://problem/8424239>

Reviewed by Jon Honeycutt.

WebCore:

  • WebCore.exp.in:

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadHTMLString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadHTMLString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
10:34 PM Changeset in webkit [67775] by weinig@apple.com
  • 60 edits in trunk/WebKit2

Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.

Rubber-stamped by Anders Carlsson.

  • Platform/Module.h:
  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/WebString.h:

(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):

  • Shared/WebURL.h:

(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):

  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):

  • UIProcess/PageClient.h:
  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::injectedBundlePath):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveTitle):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginHostConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::start):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::showCorrectionPanel):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):

  • WebProcess/WebProcess.h:
9:09 PM Changeset in webkit [67774] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.

Reviewed by Sam Weinig.

Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate. An image on a line did this, but a block-level image did not.

Added fast/multicol/image-inside-nested-blocks-with-border.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):

LayoutTests:

  • fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/image-inside-nested-blocks-with-border.html: Added.
8:38 PM Changeset in webkit [67773] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests from expectations.

  • platform/chromium/drt_expectations.txt: Removed tests that are now

consistently passing on Chromium Windows DRT.

7:59 PM Changeset in webkit [67772] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Removed a helper function,

added direct calls to frame->pageZoomFactor().

7:13 PM Changeset in webkit [67771] by hyatt@apple.com
  • 17 edits
    2 deletes in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.

Reviewed by Simon Fraser.

WebCore:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):

  • page/FrameView.h:
  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcHeight):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):

  • rendering/RenderView.h:

(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):

WebKit/mac:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):

LayoutTests:

Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.

  • printing/page-break-always-for-overflow-expected.txt: Removed.
  • printing/page-break-always-for-overflow.html: Removed.
7:09 PM Changeset in webkit [67770] by mitz@apple.com
  • 11 edits in trunk

Canvas sizing ignores intrinsic size
​https://bugs.webkit.org/show_bug.cgi?id=46024

Reviewed by Simon Fraser.

WebCore:

Updated fast/replaced/table-percent-height.html

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.

  • rendering/RenderReplaced.h:

(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.

  • rendering/RenderVideo.h:

LayoutTests:

  • fast/replaced/table-percent-height-expected.txt: Updated.
  • fast/replaced/table-percent-height.html: Changed to expect canvas to maintain

its intrinsic ratio.

6:06 PM Changeset in webkit [67769] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-09-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Imprecise tracking of variable capture leads to overly pessimistic creation of activations
​https://bugs.webkit.org/show_bug.cgi?id=46020

The old logic for track free and captured variables would cause us
to decide we needed an activation in every function along the scope
chain between a variable capture and its declaration. We now track
captured variables precisely which requires a bit of additional work

The most substantial change is that the parsing routine needs to
be passed the list of function parameters when reparsing a function
as when reparsing we don't parse the function declaration itself only
its body.

  • JavaScriptCore.exp:
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::needsFullActivation):

We need to distinguish between use of a feature that requires
an activation and eval so we now get this additional flag.

(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::getCapturedVariables):

We can't simply return the list of "capturedVariables" now as
is insufficiently precise, so we compute them instead.

(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):

  • parser/JSParser.h:
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode):

Pass function parameters (if available) to the parser.

6:01 PM Changeset in webkit [67768] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):

6:00 PM Changeset in webkit [67767] by Darin Adler
  • 2 edits in trunk/WebCore

Build fix for platforms that compile Touch.

  • dom/Touch.cpp:

(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.

5:57 PM Changeset in webkit [67766] by abarth@webkit.org
  • 1 edit
    5 deletes in trunk/LayoutTests

2010-09-17 Adam Barth <​abarth@webkit.org>

Remove Leopard specific expected results because these now match Snow
Leopard.

​https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
5:40 PM Changeset in webkit [67765] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

Add IsFloatingPoint and IsArithmetic type traits
​https://bugs.webkit.org/show_bug.cgi?id=46018

Reviewed by Sam Weinig.

  • wtf/TypeTraits.h:
  • wtf/TypeTraits.cpp:
5:38 PM Changeset in webkit [67764] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67692.
​http://trac.webkit.org/changeset/67692
​https://bugs.webkit.org/show_bug.cgi?id=46011

broke layout test dashboard (Requested by johnny_g on
#webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:34 PM Changeset in webkit [67763] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix Windows and Qt builds.

  • Shared/qt/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

5:32 PM Changeset in webkit [67762] by Darin Adler
  • 34 edits
    4 adds in trunk

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • webkit/webkitwebview.cpp: (webkit_web_view_get_zoom_level): (webkit_web_view_apply_zoom_level): (webkit_web_view_set_full_content_zoom): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView.cpp: (WebView::setZoomMultiplier): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_set): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

Moved zoom level back from FrameView to Frame.
I had forgotten that FrameView's lifetime is much shorter than
Frame's, and until that is fixed it's best to leave this on Frame.

  • WebCore.exp.in: Updated.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • dom/Document.cpp: (WebCore::Document::nodesFromRect): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY): (WebCore::pageZoomFactor):
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent):
  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
  • html/ImageDocument.cpp: (WebCore::pageZoomFactor): (WebCore::ImageDocument::scale): (WebCore::ImageDocument::imageFitsInWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/DragController.cpp: (WebCore::elementUnderMouse):
  • rendering/RenderView.cpp: (WebCore::RenderView::zoomFactor):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): Get zoom factor from Frame rather than FrameView.
  • page/Frame.cpp: (WebCore::parentPageZoomFactor): Moved back here from FrameView. (WebCore::parentTextZoomFactor): Ditto. (WebCore::Frame::Frame): Ditto. (WebCore::Frame::setPageZoomFactor): Ditto. (WebCore::Frame::setTextZoomFactor): Ditto. (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
  • page/Frame.h: Moved functions and data for zooming back here from FrameView.
  • page/FrameView.cpp: (WebCore::FrameView::FrameView):
  • page/FrameView.h: Removed code from here.

2010-09-17 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.

2010-09-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
​https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::textZoomFactor): (WebKit::WebPage::setTextZoomFactor): (WebKit::WebPage::pageZoomFactor): (WebKit::WebPage::setPageZoomFactor): (WebKit::WebPage::setPageAndTextZoomFactors): Call functions on Frame instead of FrameView.
5:23 PM Changeset in webkit [67761] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/7897425>
​https://bugs.webkit.org/show_bug.cgi?id=45601

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowResizerRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowResizerRect):

  • WebProcess/WebPage/WebPage.h:

Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.

5:20 PM Changeset in webkit [67760] by weinig@apple.com
  • 16 edits
    9 adds in trunk/WebKit2

Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/8350189>
​https://bugs.webkit.org/show_bug.cgi?id=45998

Reviewed by Anders Carlsson.

  • Shared/APIObject.h:

Add new type.

  • Shared/WebCertificateInfo.h: Added.

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.

  • Shared/mac/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::peerCertificates):

  • Shared/mac/PlatformCertificateInfo.mm: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):

  • Shared/qt/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKCertificateInfo.cpp: Added.

(WKCertificateInfoGetTypeID):

  • UIProcess/API/C/WKCertificateInfo.h: Added.

Add wrapper for WebCertificateInfo.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetCertificateInfo):

  • UIProcess/API/C/WKFrame.h:

Add getter for a WKCertificateInfo.

  • UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
  • UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.

(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::setCertificateInfo):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::certificateInfo):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Pipe the certificate info through to the WebFrameProxy on
commit.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:09 PM Changeset in webkit [67759] by tony@chromium.org
  • 34 edits in trunk/LayoutTests

2010-09-17 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] 16 more chromium linux baselines (scrollbars change)
​https://bugs.webkit.org/show_bug.cgi?id=46009

  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [67758] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.

No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.

  • WebCore.exp.in:
  • page/DOMTimer.cpp: Removed old comments.
  • page/DOMTimer.h: Removed old comments.
  • page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
  • page/Settings.h:

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
​https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
4:12 PM Changeset in webkit [67757] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
​https://bugs.webkit.org/show_bug.cgi?id=46006

  • DEPS:
3:50 PM Changeset in webkit [67756] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

3:49 PM Changeset in webkit [67755] by mrowe@apple.com
  • 1 copy in tags/Safari-534.8

New tag.

3:48 PM Changeset in webkit [67754] by andersca@apple.com
  • 3 edits in trunk/WebKit2

CoreIPC argument coder improvements
​https://bugs.webkit.org/show_bug.cgi?id=45999

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Add explicit specialization for a vector of bytes.

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.

(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.

3:43 PM Changeset in webkit [67753] by tony@chromium.org
  • 24 edits in trunk/LayoutTests

2010-09-17 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] rebaseline tests that are only scrollbar differences on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46000

  • platform/chromium-linux/css1/basic/containment-expected.checksum:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
  • platform/chromium/test_expectations.txt:
3:36 PM Changeset in webkit [67752] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add mesa as DumpRenderTree dependency
​https://bugs.webkit.org/show_bug.cgi?id=46001

  • WebKit.gyp:
3:23 PM Changeset in webkit [67751] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Split webcore_platform off webcore_remaining

Further reduce webcore_remaining size by moving platform/ code in its
own static libary.
​https://bugs.webkit.org/show_bug.cgi?id=45915

  • WebCore.gyp/WebCore.gyp:
2:59 PM Changeset in webkit [67750] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
​https://bugs.webkit.org/show_bug.cgi?id=37540

2:57 PM Changeset in webkit [67749] by mpcomplete@chromium.org
  • 12 edits in trunk

2010-09-13 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
​https://bugs.webkit.org/show_bug.cgi?id=45721

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
  • loader/FrameLoaderClient.h:
2:50 PM Changeset in webkit [67748] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-17 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8440903> WK2: REGRESSION (r66156): Web sites using
AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
​https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
2:47 PM Changeset in webkit [67747] by commit-queue@webkit.org
  • 6 edits
    2 adds
    7 deletes in trunk/LayoutTests

2010-09-17 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

http/tests/navigation/post-goback1.html should not be a pixel test
​https://bugs.webkit.org/show_bug.cgi?id=45834

Convert post-goback1.html to be a simpler dumpAsText test. It can use
the form-target.pl that was added r67466 with some small modifications.

To be extra safe, clear the back forward list for all the tests that
were converted to use dumpAsText.

  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/post-goback1-expected.txt: Added.
  • http/tests/navigation/post-goback1.html:
  • http/tests/navigation/resources/form-target.pl:
  • http/tests/navigation/resources/go-back.html: Added.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.
2:29 PM Changeset in webkit [67746] by andersca@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r66711): Plug-in replacement text is never shown
​https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/8446766>

Reviewed by Sam Weinig.

Don't return when the plug-in has replacement text.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):

2:27 PM Changeset in webkit [67745] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Eric Carlson <​eric.carlson@apple.com>

Rubber-stamped by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=45983

  • platform/win/Skipped: Skip media-can-play-mpeg4-video.html.
1:42 PM Changeset in webkit [67744] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Unskip the canvas philip suite
​https://bugs.webkit.org/show_bug.cgi?id=45991

  • platform/chromium/test_expectations.txt:
1:27 PM Changeset in webkit [67743] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed, tweaked, and landed by Anders Carlsson.

Patch by Sam Weinig <​sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
1:17 PM Changeset in webkit [67742] by jianli@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67734 - createBlobURL with no argument causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.

BUG=45880
TEST=create-blob-url-crash.html
TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3444009

1:11 PM Changeset in webkit [67741] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Make WebNumbers immutable matching CF.

Reviewed by Anders Carlsson.

  • Shared/WebNumber.h:

(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):

  • UIProcess/API/C/WKNumber.cpp:

(WKUInt64GetValue):

  • UIProcess/API/C/WKNumber.h:
1:04 PM Changeset in webkit [67740] by levin@chromium.org
  • 2 edits in trunk/WebKit/chromium

Remove unimplemented destructor declaration to fix Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=45987

Patch by Eric Uhrhane <​ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.

  • src/AsyncFileWriterChromium.h:
1:01 PM Changeset in webkit [67739] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit

<​http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project

Reviewed by Joseph Pecoraro.

  • WebKit.xcodeproj/project.pbxproj: Added missing

WebArchiveInternal.h header file to the project. It has been
missing since r31281!

12:35 PM Changeset in webkit [67738] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Add bool wrapper for WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=45985

Reviewed by John Sullivan.

  • Shared/APIObject.h:
  • Shared/WebNumber.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNumber.cpp:

(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):

  • UIProcess/API/C/WKNumber.h:
12:25 PM Changeset in webkit [67737] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.

  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:07 PM Changeset in webkit [67736] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed, build fix. Add files missed in r67704.

  • CMakeLists.txt:
12:00 PM Changeset in webkit [67735] by Simon Fraser
  • 11 edits in trunk

2010-09-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
​https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame(). (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
  • platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::setRootChildLayer): (WebCore::WKCACFLayerRenderer::destroyRenderer): (WebCore::WKCACFLayerRenderer::resize):
  • platform/graphics/win/WKCACFLayerRenderer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer. (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows, always say yes.

2010-09-17 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
​https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • WebView.cpp: (WebView::sizeChanged): Moved code that handles the WM_SIZE message into this method. Use it to resize the layer renderer. (WebView::WebViewWndProc): Call sizeChanged(). (WebView::updateRootLayerContents): No need to call setScrollFrame() any more. (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
  • WebView.h:
11:59 AM Changeset in webkit [67734] by jianli@chromium.org
  • 4 edits
    2 adds in trunk

createBlobURL with no argument causes crash.
​https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.
11:48 AM Changeset in webkit [67733] by tonyg@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 67627 - 2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.

BUG=55598
TBR=​tonyg@chromium.org
Review URL: ​http://codereview.chromium.org/3394006

11:39 AM Changeset in webkit [67732] by tonyg@chromium.org
  • 8 edits
    2 copies in branches/chromium/517

Merge 67292 - 2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of ​http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
​https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):

BUG=56034
TBR=​mihaip@chromium.org
Review URL: ​http://codereview.chromium.org/3400014

11:35 AM Changeset in webkit [67731] by cmarrin@apple.com
  • 7 edits in trunk

2010-09-17 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
​https://bugs.webkit.org/show_bug.cgi?id=45911

11:34 AM Changeset in webkit [67730] by bweinstein@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the bug number in the ChangeLog.

11:32 AM Changeset in webkit [67729] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <​http://webkit.org/b/44199>.

Rubber-stamped by Adam Roben.

  • platform/win/Skipped:
11:04 AM Changeset in webkit [67728] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERTION FAILED: m_loadEventDelayCount
​https://bugs.webkit.org/show_bug.cgi?id=45790

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
11:01 AM Changeset in webkit [67727] by senorblanco@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] GPU-accelerated canvas should work in test_shell.
​https://bugs.webkit.org/show_bug.cgi?id=45968

In order for the shaders in GPU-accelerated canvas to work in both the
GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
passes them to the Mesa backend unmodified), the precision specifiers
in the fragment shader have to be wrapped in #if GL_ES.

Soon to be covered by many layout tests.

  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
11:00 AM Changeset in webkit [67726] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-09-17 William Siegrist <​wsiegrist@apple.com>

Replaces branches option with ChangeFilter since branches is now deprecated.

10:47 AM Changeset in webkit [67725] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] Listbox rendering is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=45941

Only apply the shadow tiling optimization to a layer if the GraphicsContext
has a shadow.

This is covered by manual-tests/select-element-type-select.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization first check to see if the context has a shadow at all.
10:42 AM Changeset in webkit [67724] by Martin Robinson
  • 13 edits in trunk

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
​https://bugs.webkit.org/show_bug.cgi?id=45917

Added support to PlatformRefPtr for handling HashTableDeletedValue.

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue. (WTF::PlatformRefPtr::isHashTableDeletedValue): Added.

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
​https://bugs.webkit.org/show_bug.cgi?id=45917

Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
as this type is reference-counted.

No new tests as this should not introduce any functionality changes.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes. (WebCore::FontCache::createFontPlatformData): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::operator=): Ditto. (WebCore::FontPlatformData::~FontPlatformData): Ditto. (WebCore::FontPlatformData::isFixedPitch): Ditto. (WebCore::FontPlatformData::operator==): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::scaledFont): Ditto. (WebCore::FontPlatformData::hash): Ditto. (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill): Ditto.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
  • platform/graphics/cairo/OwnPtrCairo.h: Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations. (WTF::refPlatformPtr): Ditto. (WTF::derefPlatformPtr): Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): Ditto.
10:40 AM Changeset in webkit [67723] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land new Windows results for fast/forms/file-input-disabled.html

This corresponds to the changes made in r64712.

Rubber-stamped by John Sullivan.

  • platform/win/fast/forms/file-input-disabled-expected.txt:
10:20 AM Changeset in webkit [67722] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-09-17 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

Style bot complains about cairo forward declaration naming
​https://bugs.webkit.org/show_bug.cgi?id=45867

Exclude Cairo forward declarations from indentifiers with underscores checks.

  • Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
10:16 AM Changeset in webkit [67721] by pfeldman@chromium.org
  • 14 edits in trunk

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=45114

  • English.lproj/localizedStrings.js:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeById):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.css: (.pane > .body .placard + .info):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.formatLocalized):

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=45114

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
10:02 AM Changeset in webkit [67720] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/WebKitSite

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Adding a timeline screenshot for blocking and defer scripts
​https://bugs.webkit.org/show_bug.cgi?id=45933

  • blog-files/timeline-blocking-script.png: Added.
  • blog-files/timeline-defer-script.png: Added.
9:56 AM Changeset in webkit [67719] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/517

Merge 67281
Review URL: ​http://codereview.chromium.org/3419009

9:47 AM Changeset in webkit [67718] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/517

Merge 67509
Review URL: ​http://codereview.chromium.org/3452011

9:38 AM Changeset in webkit [67717] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67240
Review URL: ​http://codereview.chromium.org/3464001

9:36 AM Changeset in webkit [67716] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-17 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
Now history reload can only navigate the page in self frame, no matter
what target frame is defined in <base> and no new window can be created.
​https://bugs.webkit.org/show_bug.cgi?id=45369

Test: fast/events/popup-blocked-from-history-reload.html

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::wasUserGesture): Move the m_wasUserGesture to base class ScheduledNavigation. Then all asynchronous navigation situations can restore the correct gesture state during the real navigation process. (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleHistoryNavigation):

2010-09-17 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
​https://bugs.webkit.org/show_bug.cgi?id=45369

  • fast/events/popup-blocked-from-history-reload-expected.txt: Added.
  • fast/events/popup-blocked-from-history-reload.html: Added.
9:30 AM Changeset in webkit [67715] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Zhenyao Mo <​zmo@google.com>

Unreviewed.

Add failing WebGL tests in drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
9:27 AM Changeset in webkit [67714] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Clip the update region of an ImageLayerChromium to actual size
of the image bitmap to prevent uninitialized memory access when uploading
the dirty region to the texture.
​https://bugs.webkit.org/show_bug.cgi?id=45937

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
9:25 AM Changeset in webkit [67713] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67236

TBR=​jschuh@chromium.org
Review URL: ​http://codereview.chromium.org/3419008

9:20 AM Changeset in webkit [67712] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67356

TBR=​abarth@webkit.org
Review URL: ​http://codereview.chromium.org/3402012

9:15 AM Changeset in webkit [67711] by inferno@chromium.org
  • 8 edits in branches/chromium/517

Merge 67357

Review URL: ​http://codereview.chromium.org/3403012

9:13 AM Changeset in webkit [67710] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Hyatt.

Remove extraneous RenderObject traversal.
​https://bugs.webkit.org/show_bug.cgi?id=45821

This code always exits in the first iteration of the loop,
because in the context of this call, node->renderer()->node() != 0
is always true.

No behavior change, covered by existing tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop. (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
9:02 AM Changeset in webkit [67709] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-09-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
8:52 AM Changeset in webkit [67708] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land new Windows results for html5lib/runner.html

This corresponds to the changes made in r67233 and r67356.

Rubber-stamped by Anders Carlsson.

  • platform/win/html5lib/runner-expected.txt:
8:38 AM Changeset in webkit [67707] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file

  • platform/win/Skipped: Added two tests which fail due to

already-known limitations of Windows DRT.

8:11 AM Changeset in webkit [67706] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-17 William Siegrist <​wsiegrist@apple.com>

Remove centering on results directory listing.

8:00 AM Changeset in webkit [67705] by apavlov@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2010-09-17 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, build fix. Add files missed in the previous commit.

  • GNUmakefile.am:
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
7:37 AM Changeset in webkit [67704] by apavlov@chromium.org
  • 20 edits in trunk

2010-09-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Provide source-based properties for style declarations to CSSParser clients

This change:

  • Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets, even with the resource tracking turned off.
  • Adds to CSSParser a capability of source-related style declaration data extraction:
    • Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
    • Start/end source offsets for CSS properties, relative to the declaration start.
    • CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
  • Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData(). ​https://bugs.webkit.org/show_bug.cgi?id=44949

WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::node):
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
  • css/CSSParser.h: (WebCore::CSSParser::resetPropertyMarks):
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
  • inspector/Inspector.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::reset): (WebCore::InspectorCSSStore::styleSheetText): (WebCore::InspectorCSSStore::resourceStyleSheetText): (WebCore::InspectorCSSStore::inlineStyleSheetText): (WebCore::InspectorCSSStore::getStyleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges): (WebCore::InspectorCSSStore::getParentStyleSheet): (WebCore::InspectorCSSStore::inlineStyleElement):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::resourceContentForURL):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData): (WebCore::InspectorDOMAgent::buildObjectForStyle):
  • inspector/InspectorDOMAgent.h:

LayoutTests:

  • inspector/resources/styles-source-offsets.css: (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles-source-offsets-expected.txt:
  • inspector/styles-source-offsets.html:
6:36 AM Changeset in webkit [67703] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show node description in inspector highlight
​https://bugs.webkit.org/show_bug.cgi?id=20930

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
  • inspector/InspectorController.h:
6:06 AM Changeset in webkit [67702] by alex
  • 3 edits in trunk/LayoutTests

2010-09-17 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, GTK+ rebaselines.

  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
4:09 AM Changeset in webkit [67701] by satish@chromium.org
  • 7 edits
    3 copies in trunk/LayoutTests/platform

2010-09-17 Satish Sampath <​satish@chromium.org>

Unreviewed, updated chromium baselines and disabled a failing test.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium/test_expectations.txt
1:15 AM Changeset in webkit [67700] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp

Merge 67651 - 2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
​https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/3380012

1:13 AM Changeset in webkit [67699] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/front-end/ResourcesPanel.js

Merge 67629 - 2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
​https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/3442005

1:10 AM Changeset in webkit [67698] by pfeldman@chromium.org
  • 4 edits in branches/chromium/517

Merge 67623 - 2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.

TBR=​yurys@chromium.org
Review URL: ​http://codereview.chromium.org/3389017

1:07 AM Changeset in webkit [67697] by pfeldman@chromium.org
  • 2 edits in branches/chromium/517/WebCore/inspector/front-end

Merge 67601 - 2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):

TBR=​pfeldman@chromium.org
Review URL: ​http://codereview.chromium.org/3429016

12:20 AM Changeset in webkit [67696] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

WebKit should use system wide spell checking preference when application specific one isn't set.
​https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/8416041>

Patch by Jia Pu <​jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(+[WebView initialize]): Use system wide autocorrection and text substitution preferences

when the application level preferences are not set.

Sep 16, 2010:

11:20 PM Changeset in webkit [67695] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 takano takumi <​takano1@asia.apple.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Fixed a regression in SVG test introduced by my previous change.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EWritingMode):
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
10:26 PM Changeset in webkit [67694] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67693.
​http://trac.webkit.org/changeset/67693
​https://bugs.webkit.org/show_bug.cgi?id=45946

"Need to pick up a chromium change first" (Requested by dumi
on #webkit).

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp: (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendFileRange):
9:56 PM Changeset in webkit [67693] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

9:30 PM Changeset in webkit [67692] by kinuko@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
​https://bugs.webkit.org/show_bug.cgi?id=45408

This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:05 PM Changeset in webkit [67691] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/8395558>
​https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.

6:53 PM Changeset in webkit [67690] by kbr@google.com
  • 8 edits in trunk

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
​https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
​https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM): (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
6:34 PM Changeset in webkit [67689] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage):
  • QtTestBrowser/mainwindow.h:
6:33 PM Changeset in webkit [67688] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.

This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode):
6:32 PM Changeset in webkit [67687] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

We usually separate methods whose body are larger the a few lines from the class definition.

  • QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):
6:32 PM Changeset in webkit [67686] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make initializeView method of LauncherWindow private.

No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.

  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/launcherwindow.h:
6:31 PM Changeset in webkit [67685] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make the getter 'page' method of MainWindow const.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::page):
  • QtTestBrowser/mainwindow.h:
6:31 PM Changeset in webkit [67684] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Remove useless parameter from MainWindow class' constructor.

The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
  • QtTestBrowser/mainwindow.h:
6:18 PM Changeset in webkit [67683] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-09-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash due to timer triggered GC on one heap while another heap is active
​https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/8318446>

The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.

  • runtime/Collector.cpp: (JSC::Heap::allocate): (JSC::Heap::reset): (JSC::Heap::collectAllGarbage):

Add assertions to ensure we have the correct identifierTable active
while collecting.

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger):

Temporarily make the expected IdentifierTable active

  • wtf/WTFThreadData.h: (JSC::IdentifierTable::remove):

Make it possible to see when IdentifierTable::remove has succeeded

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::~StringImpl):

CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.

6:04 PM Changeset in webkit [67682] by Simon Fraser
  • 35 edits in trunk

2010-09-16 Simon Fraser <Simon Fraser>

Reviewed by James Robinson.

In layerTreeAsText output, avoid printing properties which have their default values
​https://bugs.webkit.org/show_bug.cgi?id=45931

Don't dump properties that have their default values to simplify output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
5:55 PM Changeset in webkit [67681] by johnnyg@google.com
  • 96 edits
    98 adds
    4 deletes in trunk/LayoutTests

2010-09-16 John Gregg <​johnnyg@google.com>

Unreviewed, chromium rebaselines.

[chromium] Rebaseline multicol tests
​https://bugs.webkit.org/show_bug.cgi?id=45936

  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/single-line-expected.checksum:
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
  • platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-win/fast/multicol/client-rects-expected.png:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.checksum:
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
5:35 PM Changeset in webkit [67680] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update Windows-specific results to getComputedStyle tests after r67667.

Rubber-stamped by Jon Honeycutt.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
4:34 PM Changeset in webkit [67679] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Remove unused variable

GraphicsContextPlatformPrivate::redirect wasn't used for anything.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
4:15 PM Changeset in webkit [67678] by tony@chromium.org
  • 3 edits
    1 add
    8 deletes in trunk/LayoutTests

2010-09-16 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

convert fast/events/5056619.html to a dump-as-markup test
​https://bugs.webkit.org/show_bug.cgi?id=45907

  • fast/events/5056619.html:
  • platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-linux/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-win/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/events/5056619-expected.checksum: Removed.
  • platform/mac/fast/events/5056619-expected.png: Removed.
  • platform/mac/fast/events/5056619-expected.txt: Removed.
4:03 PM Changeset in webkit [67677] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Add needed entry points to WebGraphicsContext3D for compositor
​https://bugs.webkit.org/show_bug.cgi?id=45921

  • public/WebGraphicsContext3D.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
  • src/WebGraphicsContext3DDefaultImpl.h:
3:45 PM Changeset in webkit [67676] by tony@chromium.org
  • 10 edits in trunk

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • platform/chromium/test_expectations.txt:

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • public/WebDataSource.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost): (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
  • src/WebDataSourceImpl.h:

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
​https://bugs.webkit.org/show_bug.cgi?id=42151

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource):
3:35 PM Changeset in webkit [67675] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
​https://bugs.webkit.org/show_bug.cgi?id=45923

QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
3:30 PM Changeset in webkit [67674] by barraclough@apple.com
  • 3 edits in trunk/SunSpider

​https://bugs.webkit.org/show_bug.cgi?id=45924

Reviewed by Mark Rowe.

Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.

Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').

  • resources/sunspider-standalone-driver.js:
  • sunspider:
3:18 PM Changeset in webkit [67673] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for regression from my previous check-in. Make sure not to move the LayoutRepainter line
below the setHeight(0) call. This meant it snagged the wrong rectangle and we ended up repainting
the world.

Reviewed by Eric Seidel.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

2:58 PM Changeset in webkit [67672] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed.

Remove passing WebGL tests from platform/chromium/test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=45905

Remove passing tests; also, put webgl tests in one place.

  • platform/chromium/test_expectations.txt:
2:53 PM Changeset in webkit [67671] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/ColumnInfo.h

Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.

2:51 PM Changeset in webkit [67670] by eric@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Eric Seidel <​eric@webkit.org>

Unreviewed. Just changing the path to the PNG file.

fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
​https://bugs.webkit.org/show_bug.cgi?id=45919

Fixing the underlying issue in a separate bug. For now
give this test its own png so to unblock the commit-queue.

  • fast/css/font-face-svg-decoding-error.html:
  • fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.
2:44 PM Changeset in webkit [67669] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-09-16 Adrienne Walker <​enne@google.com>

Reviewed by Kenneth Russell.

Add script to synchronize WebKit and Khronos WebGL tests
​https://bugs.webkit.org/show_bug.cgi?id=42336

  • Scripts/update-webgl-conformance-tests: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2:39 PM Changeset in webkit [67668] by Martin Robinson
  • 11 edits
    38 adds in trunk/LayoutTests

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Update baselines for GTK+ and unskip a test which is passing.

  • platform/gtk/Skipped: Update baselines for GTK+.
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/gtk/fast/multicol/client-rects-expected.txt: Added.
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/gtk/svg/css/shadow-changes-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
  • platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.
2:37 PM Changeset in webkit [67667] by hyatt@apple.com
  • 17 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Patch by takano takumi <​takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.

Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.

WebCore:

Test: fast/text/international/block-flow-parser-test.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/text/international/block-flow-parser-test-expected.txt: Added.
  • fast/text/international/block-flow-parser-test.html: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
2:04 PM Changeset in webkit [67666] by weinig@apple.com
  • 15 edits in trunk

Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
​https://bugs.webkit.org/show_bug.cgi?id=44785

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

  • MiniBrowser/mac/AppDelegate.m:

(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didCreatePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

1:55 PM Changeset in webkit [67665] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Roll forward Chromium DEPS to r59706
​https://bugs.webkit.org/show_bug.cgi?id=45916

  • DEPS:
1:51 PM Changeset in webkit [67664] by Martin Robinson
  • 10 edits in trunk

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

  • wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
might this allow code to be shared between Cairo ports it prevents a
full data copy when the image is not resized and makes the implementation
of dissolveDragImageToFraction more straight-forward.

This feature is covered by manual-tests/drag-image.html.

  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag image a little smaller.
  • platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
  • platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): Reimplemented to reflect new drag image type. (WebCore::deleteDragImage): Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Filled the stub of this function. (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
  • platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
​https://bugs.webkit.org/show_bug.cgi?id=45826

To support full alpha in the drag icon, changed the drag icon to be a
GtkWindow with an RGBA colormap. Added logic to support painting the drag
image to this window during the expose event.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowExposeEventCallback): Added. (WebKit::DragClient::DragClient): Initialize the new drag icon window. (WebKit::DragClient::~DragClient): Disconnect the expose event signal. (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and if necessary, set its colormap. (WebKit::DragClient::dragIconWindowExposeEvent): Added.
  • WebCoreSupport/DragClientGtk.h: Added new member and method declarations.
1:42 PM Changeset in webkit [67663] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
​https://bugs.webkit.org/show_bug.cgi?id=45412

BUG=45412
TEST=none

Reviewed by Darin Adler.

WebCore:

This is caused by not including the final null character into the count
that is provided to fgets.

This is covered by the existing test: send-form-data-with-sliced-file.html.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

LayoutTests:

Remove the test that is now passing on Linux for chromium.

  • platform/chromium/test_expectations.txt:

TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3389014

1:31 PM Changeset in webkit [67662] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Leonid Ebril <​leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
​https://bugs.webkit.org/show_bug.cgi?id=45885

Avoid creation of an additional window for screenshot to prevent overlapping with original window.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot):
1:26 PM Changeset in webkit [67661] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67646 - BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
​https://bugs.webkit.org/show_bug.cgi?id=45909

BUG=55910
TEST=none

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:

TBR=​jianli@chromium.org
Review URL: ​http://codereview.chromium.org/3449009

1:20 PM Changeset in webkit [67660] by hyatt@apple.com
  • 74 edits
    42 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.

Reviewed by Darin Adler.

WebCore:

This patch adds support for column breaking at layout time rather than at paint time. New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.

The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns. Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.

Many new tests added in fast/multicol and new results added for existing fast/multicol tests.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):

  • rendering/RenderView.h:

(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):

LayoutTests:

Add many new multicol layout tests that demonstrate new pagination features.

  • fast/multicol/border-padding-pagination.html: Added.
  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/column-break-with-balancing.html: Added.
  • fast/multicol/float-paginate-complex.html: Added.
  • fast/multicol/float-paginate.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/margin-collapse.html: Added.
  • fast/multicol/max-height-columns-block.html: Added.
  • fast/multicol/positioned-split.html: Added.
  • fast/multicol/shadow-breaking.html: Added.
  • fast/multicol/single-line-expected.checksum:
  • fast/multicol/single-line-expected.png:
  • fast/multicol/table-margin-collapse.html: Added.
  • fast/multicol/table-vertical-align.html: Added.
  • fast/multicol/unsplittable-inline-block.html: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.checksum:
  • platform/mac/fast/multicol/column-rules-expected.png:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.checksum:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/float-paginate-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum:
  • platform/mac/fast/multicol/nested-columns-expected.png:
  • platform/mac/fast/multicol/nested-columns-expected.txt:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/mac/fast/multicol/positioned-split-expected.png: Added.
  • platform/mac/fast/multicol/positioned-split-expected.txt: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.
1:18 PM Changeset in webkit [67659] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
​https://bugs.webkit.org/show_bug.cgi?id=45737

Test: fast/frames/frame-limit.html

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
1:15 PM Changeset in webkit [67658] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix clang++ build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.

1:05 PM Changeset in webkit [67657] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Thomas Zander <​t.zander@nokia.com>

Reviewed by Andreas Kling.

​https://bugs.webkit.org/show_bug.cgi?id=45878

[Qt] Fixed incorrect Symbian scoping.

The missing install functionality is only true for mmp based systems.

  • WebCore.pro: limit functionality to mmp systems.
1:00 PM Changeset in webkit [67656] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang build.

  • page/animation/AnimationBase.h:

Fix struct/class mismatch.

12:48 PM Changeset in webkit [67655] by Darin Adler
  • 4 edits in trunk/WebKit

Fix build.

WebKit/efl:

  • ewk/ewk_view.cpp:

(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.

WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.

12:44 PM Changeset in webkit [67654] by levin@chromium.org
  • 1 edit in branches/chromium/517/WebCore/page/chromium/FrameChromium.cpp

Merge 67645 - 2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
​https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):

TBR=​dcheng@chromium.org
Review URL: ​http://codereview.chromium.org/3422008

12:40 PM Changeset in webkit [67653] by Darin Adler
  • 21 edits in trunk

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute): Use isImageButton.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Use isPasswordField.
  • src/WebSearchableFormData.cpp: (WebCore::IsInDefaultState): Use isCheckbox and isRadioButton. (WebCore::HasSuitableTextElement): Use isFileUpload and isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Use isPasswordField. (WebFrame::elementIsPassword): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField. (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.

2010-09-16 Darin Adler <Darin Adler>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
​https://bugs.webkit.org/show_bug.cgi?id=45903

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload. (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton. (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use isCheckbox and isRadioButton.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Use isTextField.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
  • editing/SelectionController.cpp: (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
  • html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
  • page/DragController.cpp: (WebCore::asFileInput): Use isFileUpload.
  • page/EventHandler.cpp: (WebCore::isSubmitImage): Use isImageButton.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
12:33 PM Changeset in webkit [67652] by Darin Adler
  • 1 edit
    3 adds in trunk/LayoutTests

Mac results for recently-added test.

  • platform/mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.txt: Added.
12:31 PM Changeset in webkit [67651] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
​https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):
12:31 PM Changeset in webkit [67650] by kbr@google.com
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Expose separate GraphicsContext3DInternal.h
​https://bugs.webkit.org/show_bug.cgi?id=45914

  • WebKit.gyp:
  • src/GraphicsContext3D.cpp:
  • src/GraphicsContext3DInternal.h: Added.
12:26 PM Changeset in webkit [67649] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

[chromium] Add WebGraphicsContext3D accessor to WebView
​https://bugs.webkit.org/show_bug.cgi?id=45913

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
12:17 PM Changeset in webkit [67648] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
​https://bugs.webkit.org/show_bug.cgi?id=45892

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
12:13 PM Changeset in webkit [67647] by loislo@chromium.org
  • 16 edits in trunk

2010-09-16 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move resourceTracking flag under control of BackendSettings.

Four Inspector API methods about resourceTracking flag were removed.
Actual state of the flag is transfered as the response of setResourceTracking request.
Initial state of the flag on the frontend side is obtained from settings.backend.

​https://bugs.webkit.org/show_bug.cgi?id=45887

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getBackendSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::setResourceTracking):
  • inspector/InspectorController.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize.populateBackendSettings): (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js:

WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

LayoutTests:

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/styles-source-offsets.html:
12:09 PM Changeset in webkit [67646] by jianli@chromium.org
  • 4 edits in trunk

BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
​https://bugs.webkit.org/show_bug.cgi?id=45909

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:
12:05 PM Changeset in webkit [67645] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
​https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
11:55 AM Changeset in webkit [67644] by levin@chromium.org
  • 1 edit
    1 copy in branches/chromium/517/WebCore

Merge 67641 - 2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
​https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):

TBR=​tony@chromium.org
Review URL: ​http://codereview.chromium.org/3452007

11:36 AM Changeset in webkit [67643] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed, TAG fix for two webgl tests in Linux/Win.

  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [67642] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
​https://bugs.webkit.org/show_bug.cgi?id=41510

  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
  • platform/mac/fast/loader/user-stylesheet-fast-path.html:

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
​https://bugs.webkit.org/show_bug.cgi?id=41510

This prevents usage of nil value, which would cause an uncaught exception.

  • WebView/WebPreferences.mm: (-[WebPreferences setUserStyleSheetLocation:]):
11:06 AM Changeset in webkit [67641] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-09-16 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
​https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):
10:59 AM Changeset in webkit [67640] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Unreviewed, test TAG fix.

  • platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.
10:52 AM Changeset in webkit [67639] by mitz@apple.com
  • 5 edits in trunk/WebKit

Reverted the previous change because r67628 has been reverted.

WebKit:

  • English.lproj/Localizable.strings:

WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
10:39 AM Changeset in webkit [67638] by mitz@apple.com
  • 5 edits in trunk/WebKit

WebKit: Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):

10:37 AM Changeset in webkit [67637] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-16 Balazs Kelemen <​kbalazs@webkit.org>

Unreviewed trivial typo fix.

Remove old debug helper code inside |#if 0| from ConnectionQt.cpp

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
10:33 AM Changeset in webkit [67636] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Martin Robinson <​mrobinson@igalia.com>

Unskip some tests that are now passing after libxml fixes in r66336.

  • platform/gtk/Skipped: Unskip passing tests.
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
10:32 AM Changeset in webkit [67635] by commit-queue@webkit.org
  • 22 edits
    2 deletes in trunk

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • media/context-menu-actions-expected.txt: Removed.
  • media/context-menu-actions.html: Removed.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:
  • platform/brew/LocalizedStringsBrew.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/haiku/LocalizedStringsHaiku.cpp:
  • platform/wx/LocalizedStringsWx.cpp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
  • rendering/HitTestResult.h:

2010-09-16 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
​http://trac.webkit.org/changeset/67628
​https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):
10:21 AM Changeset in webkit [67634] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Fraser.

CSS: Fix crash in getTimingFunctionValue()
​https://bugs.webkit.org/show_bug.cgi?id=45896

Use a RefPtr to avoid deleting the TimingFunction prematurely.

This is covered by existing tests, e.g transitions/inherit-other-props.html
but will only actually crash on picky platforms (or in valgrind.)

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getTimingFunctionValue):
10:15 AM Changeset in webkit [67633] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Turn on WebGL layout tests for Chromium win/linux
​https://bugs.webkit.org/show_bug.cgi?id=45859

  • platform/chromium/test_expectations.txt: Re-enabling WebGL tests.
10:04 AM Changeset in webkit [67632] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 John Gregg <​johnnyg@google.com>

Unreviewed; chromium test expectations.

editing/selection/context-menu-on-text.html fails on chromium
​https://bugs.webkit.org/show_bug.cgi?id=45898

  • platform/chromium/test_expectations.txt:
9:28 AM Changeset in webkit [67631] by enrica@apple.com
  • 8 edits in trunk/WebKit2

Pasteboard doesn't work in WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the

new editing commands.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.

  • UIProcess/WebPageProxy.cpp: Added all the proxy methods.

(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.

  • WebProcess/WebPage/WebPage.cpp: Added all the stub methods.

(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.

  • WebProcess/WebPage/WebPage.h:
9:27 AM Changeset in webkit [67630] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Balazs Kelemen <​kbalazs@webkit.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
9:24 AM Changeset in webkit [67629] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
​https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
9:21 AM Changeset in webkit [67628] by Philippe Normand
  • 22 edits
    2 adds in trunk

2010-09-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
​https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:12 AM Changeset in webkit [67627] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
​https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
9:06 AM Changeset in webkit [67626] by Philippe Normand
  • 8 edits
    2 adds in trunk

2010-09-14 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):

WebKit/gtk:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

New private WebView API to retrieve the context-menu widget. This
is used by DRT only.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_context_menu):

LayoutTests:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
​https://bugs.webkit.org/show_bug.cgi?id=39102

New test checking the return value of eventSender.contextClick()
on a non-editable element. Skipped on qt and win.

  • editing/selection/context-menu-on-text-expected.txt: Added.
  • editing/selection/context-menu-on-text.html: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
8:58 AM Changeset in webkit [67625] by vangelis@chromium.org
  • 4 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] ImageLayerChromium needs to keep a ref to the Image it uses
so that it never tries to access an already destroyed Image.
​https://bugs.webkit.org/show_bug.cgi?id=45869

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/ImageLayerChromium.h:
8:57 AM Changeset in webkit [67624] by Patrick Gansterer
  • 1 edit
    1 add in trunk/WebCore

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add platform-specific Image methods
​https://bugs.webkit.org/show_bug.cgi?id=28272

  • platform/graphics/wince/ImageWinCE.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::FrameData::clear): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::drawPattern): (WebCore::BitmapImage::checkForSolidColor):
8:37 AM Changeset in webkit [67623] by yurys@chromium.org
  • 6 edits in trunk

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
​https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.
8:33 AM Changeset in webkit [67622] by satish@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Satish Sampath <​satish@chromium.org>

Unreviewed, fixing a build break with VS 2008.

Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
​https://bugs.webkit.org/show_bug.cgi?id=45893

  • fileapi/FileWriter.h:
8:30 AM Changeset in webkit [67621] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] XOverlay API changes break the build
​https://bugs.webkit.org/show_bug.cgi?id=45810

Cope with the GStreamer XOverlay API change for the upcoming
0.10.31 version.
No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
8:24 AM Changeset in webkit [67620] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/wince

2010-09-16 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add missing FrameNetworkingContextWinCE::blockedError
​https://bugs.webkit.org/show_bug.cgi?id=45680

  • WebCoreSupport/FrameNetworkingContextWinCE.cpp: (WebKit::FrameNetworkingContextWinCE::blockedError):
  • WebCoreSupport/FrameNetworkingContextWinCE.h:
8:17 AM Changeset in webkit [67619] by andreas.kling@nokia.com
  • 11 edits in trunk/WebCore

2010-09-16 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Fix debug build

Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.

  • history/PageCache.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/DocumentLoader.cpp:
  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconLoader.cpp:
  • storage/AbstractDatabase.cpp:
  • storage/Database.cpp:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseTracker.cpp:
8:05 AM Changeset in webkit [67618] by ap@apple.com
  • 4 edits
    2 adds in trunk

2010-09-16 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

  • fast/dom/Range/select-node-different-document-expected.txt: Added.
  • fast/dom/Range/select-node-different-document.html: Added.

2010-09-16 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

Test: fast/dom/Range/select-node-different-document.html

There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
Firefox.

  • dom/Range.cpp: (WebCore::Range::setDocument): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents):
  • dom/Range.h:
7:44 AM Changeset in webkit [67617] by satish@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2010-09-16 Satish Sampath <​satish@chromium.org>

Unreviewed, build fix after checking in the wrong location.

Moving a test expectation which should have been under the chromium platform.

  • platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/fast/images/gif-large-checkerboard-expected.txt.
7:08 AM Changeset in webkit [67616] by satish@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-09-16 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add chromium baselines for a recently added layout test.
​https://bugs.webkit.org/show_bug.cgi?id=45886

  • fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.png: Added.
6:56 AM Changeset in webkit [67615] by caseq@chromium.org
  • 6 edits in trunk/WebCore

2010-09-16 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support to export HAR to file from Resources panel (conditional on Preferences)
Added support for HARLog (a higher-level aggregate than HAREntry)
​https://bugs.webkit.org/show_bug.cgi?id=45663

6:45 AM Changeset in webkit [67614] by commit-queue@webkit.org
  • 49 edits in trunk

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • configure.ac:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExceptionCode.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
  • dom/ScriptExecutionContext.h:
  • fileapi/AsyncFileWriter.h:
  • fileapi/FileEntry.cpp:
  • fileapi/FileEntry.h:
  • fileapi/FileEntry.idl:
  • fileapi/FileError.h:
  • fileapi/FileError.idl:
  • fileapi/FileException.h:
  • fileapi/FileException.idl:
  • fileapi/FileStreamProxy.cpp:
  • fileapi/FileStreamProxy.h:
  • fileapi/FileThread.cpp:
  • fileapi/FileThread.h:
  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h:
  • fileapi/FileWriter.idl:
  • fileapi/FileWriterCallback.h:
  • fileapi/FileWriterCallback.idl:
  • fileapi/FileWriterClient.h:
  • page/DOMWindow.idl:
  • platform/AsyncFileStream.h:
  • platform/FileStream.cpp:
  • platform/FileStream.h:
  • platform/FileStreamClient.h:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • src/AsyncFileWriterChromium.h:
  • src/AsyncFileWriterChromium.cpp:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-09-16 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
​https://bugs.webkit.org/show_bug.cgi?id=45798

  • Scripts/build-webkit:
6:19 AM Changeset in webkit [67613] by satish@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Rename an image file to all lower case matching how it is used in the layout test. The original patch and layout test is at ​https://bugs.webkit.org/show_bug.cgi?id=45322

6:15 AM Changeset in webkit [67612] by robert@webkit.org
  • 13 edits in trunk

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • platform/qt/Skipped:

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::populateVisitedLinks):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpHistoryCallbacks): (DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-16 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
​https://bugs.webkit.org/show_bug.cgi?id=45774

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isGlobalHistoryTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpHistoryCallbacks): (LayoutTestController::removeAllVisitedLinks):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:03 AM Changeset in webkit [67611] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-16 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.

This is necessary because sources! is processed before sources/. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.

Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp

​https://bugs.webkit.org/show_bug.cgi?id=45823

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
5:51 AM Changeset in webkit [67610] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
​https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::finish):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-09-16 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
​https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
5:47 AM Changeset in webkit [67609] by alex
  • 5 edits in trunk

2010-09-16 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
  • platform/gtk/gtk2drawing.c: (moz_gtk_scrollbar_thumb_paint): (moz_gtk_combo_box_paint):

2010-09-16 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
5:38 AM Changeset in webkit [67608] by diegohcg@webkit.org
  • 8 edits in trunk

2010-09-16 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
​https://bugs.webkit.org/show_bug.cgi?id=42293

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::commitLoad):

2010-09-16 Diego Gonzalez <​diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
​https://bugs.webkit.org/show_bug.cgi?id=42293

  • Api/qwebframe.cpp: (QWebFrame::childFrames): (QWebFramePrivate::kit):
  • Api/qwebpage.cpp: (QWebPage::currentFrame):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::contentsSizeChanged):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::chooseFile):
  • WebCoreSupport/FrameLoaderClientQt.h:
5:07 AM Changeset in webkit [67607] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Ryuan Choi <​ryuan.choi@samsung.com>

Unreviewed build fix for EFL

[EFL] REGRESSION(67567) FontCacheCairo was removed
​https://bugs.webkit.org/show_bug.cgi?id=45858

  • CMakeListsEfl.txt:
4:47 AM Changeset in webkit [67606] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=37117

Add platform-independent JPEG/PNG image encoders that
work with big endian RGBA source data.

There's no layout test because this patch does't make
any port start using the encoders.

  • platform/image-encoders/JPEGImageEncoder.cpp: Added.
  • platform/image-encoders/JPEGImageEncoder.h: Added.
  • platform/image-encoders/PNGImageEncoder.cpp: Added.
  • platform/image-encoders/PNGImageEncoder.h: Added.
4:27 AM Changeset in webkit [67605] by jorlow@chromium.org
  • 11 edits in trunk

2010-09-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
​https://bugs.webkit.org/show_bug.cgi?id=45815

Existing tests provide coverage. Use the indexedDBPath parameter that's
already on the group settings object. Pass this parameter into the backend
which will use it rather than a hard coded tmp directory location. If
nothing is specified, assume it should be an in-memory temporary database.
(This is useful for bringup and Chromium's incognito mode.)

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2010-09-15 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
​https://bugs.webkit.org/show_bug.cgi?id=45815

Need to add the extra .open() parameter to make this all work.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
4:16 AM Changeset in webkit [67604] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

Add a test for GIF down sampling.

GIF image down sampling can miss some lines
​https://bugs.webkit.org/show_bug.cgi?id=45322

  • fast/images/gif-large-checkerboard.html: Added.
  • fast/images/resources/large-gif-checkerboard.GIF: Added.

2010-09-16 Yong Li <​yoli@rim.com>

Reviewed by George Staikos.

Fix the bug that GIF image down sampling can miss some lines.
​https://bugs.webkit.org/show_bug.cgi?id=45322

Test: fast/images/gif-large-checkerboard.html

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
4:13 AM Changeset in webkit [67603] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Jeremy Orlow <​jorlow@chromium.org>

Speculative build fix.

  • src/IDBIndexBackendProxy.cpp:
3:50 AM Changeset in webkit [67602] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-16 Philippe Normand <​pnormand@igalia.com>

Reviewed by Andreas Kling.

[GStreamer] un-needed header includes in MediaPlayerPrivate
​https://bugs.webkit.org/show_bug.cgi?id=45877

Include only the headers we need.
No new tests, #includes cleanup only.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3:41 AM Changeset in webkit [67601] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
​https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):
3:23 AM Changeset in webkit [67600] by jorlow@chromium.org
  • 34 edits
    4 adds in trunk

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

  • storage/indexeddb/index-basics-expected.txt: Added.
  • storage/indexeddb/index-basics.html: Added.
  • storage/indexeddb/index-cursor-expected.txt: Added.
  • storage/indexeddb/index-cursor.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/script-tests/objectstore-basics.js: Removed.

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

Add the rest of the index related API for IndexedDB. This
includes cursor suport. A bunch of code was also refactored
since it is shared between indexes and objectStores.

Tests: storage/indexeddb/index-basics.html

storage/indexeddb/index-cursor.html
+ additions to others.

  • storage/IDBAny.cpp: (WebCore::IDBAny::set):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::value):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::loadCurrentRow): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
  • storage/IDBIndex.h: (WebCore::IDBIndex::storeName):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::storeName): (WebCore::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::objectStore):
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::leftCursorWhereFragment): (WebCore::IDBKey::rightCursorWhereFragment):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator): (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::timerFired):

2010-09-08 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=45386

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::storeName): (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBKey.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::value):
  • src/IDBCursorBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::storeName): (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
  • src/IDBIndexBackendProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::value):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::storeName): (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
2:07 AM Changeset in webkit [67599] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-09-15 Commit Queue <​commit-queue@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

Sep 15, 2010:

10:47 PM Changeset in webkit [67598] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Overload WebHTTPBody::appendFileRange() to take a double modification time argument.
​https://bugs.webkit.org/show_bug.cgi?id=45829

Reviewed by Darin Fisher.

The plan is to change all callers of
WebHTTPBody::appendFileRange(..., const WebFileInfo&) to use the
new method, and then remove it.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):

7:45 PM Changeset in webkit [67597] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-15 Jessie Berlin <​jberlin@apple.com>

Reviewed by Sam Weinig.

WebKit2 should be able to encode and decode objects of type APIObject::TypeURL.
​https://bugs.webkit.org/show_bug.cgi?id=45819

  • Shared/UserMessageCoders.h: Add the ability to encode and decode the URL type. (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
7:18 PM Changeset in webkit [67596] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-09-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by David Levin.

[GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
​https://bugs.webkit.org/show_bug.cgi?id=45865

When initializing the backForwardList private member of the WebView, do
so with adoptPlatformRef to prevent a memory leak.

  • webkit/webkitwebview.cpp: (webkit_web_view_init): Initialize member with adoptPlatformRef.
7:15 PM Changeset in webkit [67595] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add user message coding for WebUInt64 type.

Reviewed by Jon Honeycutt.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

6:52 PM Changeset in webkit [67594] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-15 Adam Barth <​abarth@webkit.org>

Unreviewed.

Only show the review-in-context link if there are contextual comments.

  • code-review.js:
6:50 PM Changeset in webkit [67593] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

2010-09-15 Jessie Berlin <​jberlin@apple.com>

Reviewed by Jon Honeycutt.

We should save messages that can't be sent when postMessageToInjectedBundle is called and
send them in ensureWebProcess.
​https://bugs.webkit.org/show_bug.cgi?id=45822

  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Post any messages to the Injected Bundle that couldn't be sent earlier because the WebProcess hadn't been initialized yet. (WebKit::WebContext::postMessageToInjectedBundle):
  • UIProcess/WebContext.h:
6:48 PM Changeset in webkit [67592] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Show the status bubbles on the toolbar
​https://bugs.webkit.org/show_bug.cgi?id=45861

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:34 PM Changeset in webkit [67591] by Martin Robinson
  • 7 edits in trunk/WebKit/gtk

2010-09-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[Gtk] Use GOwnPtr for code that needs it
​https://bugs.webkit.org/show_bug.cgi?id=21594

Convert as reference counted private members of WebKitWebView to
smart pointers as possible. This removes a lot of unecessary manual
memory management. Also convert some pointer members away from pointer
types, now that we are sure their destructors are called.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Ditto.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::handleInputMethodKeydown): Ditto. (WebKit::EditorClient::handleInputMethodMousePress): Ditto. (WebKit::EditorClient::EditorClient): Ditto. (WebKit::EditorClient::~EditorClient): Ditto.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Ditto.
  • webkit/webkitprivate.h: Ditto.
  • webkit/webkitwebview.cpp: Ditto. (destroy_menu_cb): Ditto. (webkit_web_view_forward_context_menu_event): Ditto. (webkit_web_view_key_release_event): Ditto. (webkit_web_view_button_press_event): Ditto. (webkit_web_view_button_release_event): Ditto. (webkit_web_view_focus_in_event): Ditto. (webkit_web_view_focus_out_event): Ditto. (webkit_web_view_realize): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Changed all g_object_unref calls to PlatformRefPtr.clear(). Although this will also be done by the manual call to the WebKitWebViewPrivate destructor, the order that these fields are zero'd in is still very sensitive. (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes. (webViewGetDPI): Ditto. (webkit_web_view_screen_changed): Ditto. (webkit_web_view_drag_end): Ditto. (webkit_web_view_drag_data_get): Ditto. (doDragLeaveLater): Ditto. (webkit_web_view_drag_leave): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto. (webkit_web_view_get_im_context): Ditto. (webkit_web_view_update_settings): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_set_settings): Ditto. (webkit_web_view_get_settings): Ditto. (webkit_web_view_get_inspector): Ditto. (webkit_web_view_set_window_features): Ditto. (webkit_web_view_get_window_features): Ditto. (webkit_web_view_get_back_forward_list): Ditto. (webkit_web_view_zoom_in): Ditto. (webkit_web_view_zoom_out): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_get_main_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_get_subresources): Ditto.
6:19 PM Changeset in webkit [67590] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Allow setting review and commit-queue flags from main review screen
​https://bugs.webkit.org/show_bug.cgi?id=45860

This patch adds drop down menus for adjusting the review and
commit-queue flags from the main review screen. These controls don't
appear immediately because we need to read the state of the flags off
the details page.

It's a slight sadness that bugzilla doesn't have a clean way of
identifying which select control is associated with a given flag. The
flags seem to have some sort of id, but it's unclear to me how to map
that id back to a notion of "review" or "commit-queue". Instead, we
look for some magic strings in the title. I'm sure this will come back
to bit us at some point, but I'm not sure what to do that's better.
(The webkitpy solution to this problem is to assume that the flags are
in a given order, but this seems better.)

  • PrettyPatch/PrettyPatch.rb:
    • Bump version number to bust throuh caches.
  • code-review.js:
6:13 PM Changeset in webkit [67589] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-09-15 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/8214099> Mousewheel scrolling in WebKit2 is wonky

Use floats so that fractional scrollwheel deltas don't get lost.

  • Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
5:40 PM Changeset in webkit [67588] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-10 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

deduplicate-tests should be runnable from any WebKit directory
​https://bugs.webkit.org/show_bug.cgi?id=44709

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
5:30 PM Changeset in webkit [67587] by johnnyg@google.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-09-15 John Gregg <​johnnyg@google.com>

Unreviewed, build fix after incomplete revert.

Remove layout test added in 67570 that wasn't reverted in 67574.
​https://bugs.webkit.org/show_bug.cgi?id=45854

  • fast/css/test-setting-canvas-color-expected.txt: Removed.
  • fast/css/test-setting-canvas-color.html: Removed.
5:29 PM Changeset in webkit [67586] by eric@webkit.org
  • 1 edit in trunk/ChangeLog

2010-09-15 Eric Seidel <​eric@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

5:09 PM Changeset in webkit [67585] by tony@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] sort testing methods in DRT
​https://bugs.webkit.org/show_bug.cgi?id=45850

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController):
5:05 PM Changeset in webkit [67584] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-09-15 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

CQ status shows items out of order
​https://bugs.webkit.org/show_bug.cgi?id=45846

Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.

Also don't indent status items that only have a single item in their
group.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
  • QueueStatusServer/templates/queuestatus.html:
5:05 PM Changeset in webkit [67583] by oliver@apple.com
  • 10 edits in trunk/JavaScriptCore

2010-09-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Use free variable analysis to improve activation performance
​https://bugs.webkit.org/show_bug.cgi?id=45837

Adds free and captured variable tracking to the JS parser. This
allows us to avoid construction of an activation object in some
cases. Future patches will make more use of this information to
improve those cases where activations are still needed.

  • parser/ASTBuilder.h:
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::useVariable): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::capturedVariables): (JSC::JSParser::ScopeRef::ScopeRef): (JSC::JSParser::ScopeRef::operator->): (JSC::JSParser::ScopeRef::index): (JSC::JSParser::currentScope): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::parseProgram): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parsePrimaryExpression):
  • parser/Nodes.cpp: (JSC::ScopeNodeData::ScopeNodeData): (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • parser/Nodes.h: (JSC::ScopeNode::needsActivation): (JSC::ScopeNode::hasCapturedVariables):
  • parser/Parser.cpp: (JSC::Parser::didFinishParsing):
  • parser/Parser.h: (JSC::Parser::parse):
  • parser/SyntaxChecker.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
  • runtime/Executable.h: (JSC::ScriptExecutable::needsActivation): (JSC::ScriptExecutable::recordParse):
5:04 PM Changeset in webkit [67582] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-09-15 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add queue start/stop messages
​https://bugs.webkit.org/show_bug.cgi?id=45853

I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.

There are also a few PEP8 changes needed to pass check-webkit-style.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4:56 PM Changeset in webkit [67581] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Add WKUInt64Ref wrapper for sending uint64_ts.

Reviewed by Jon Honeycutt.

  • Shared/APIObject.h:
  • Shared/WebNumber.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNumber.cpp:

(WKUInt64GetTypeID):
(WKUInt64Create):
(WKUInt64GetValue):
(WKUInt64SetValue):

  • UIProcess/API/C/WKNumber.h:
4:51 PM Changeset in webkit [67580] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-15 Simon Fraser <Simon Fraser>

​https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url

Fix MiniBrowser crash when the url is not parseable.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]):
4:43 PM Changeset in webkit [67579] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-09-15 Simon Fraser <Simon Fraser>

Fix chromium build.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
4:30 PM Changeset in webkit [67578] by crogers@google.com
  • 28 edits
    1 add in branches/audio/WebCore

audio branch: lots of changes in preparation for moving to trunk

  • more HRTF cleanup (added HRTFUtilities.cpp file)
  • general cleanup AudioDestinationMac, AudioFileReaderMac, AudioResourcesMac
  • added locking mechanism to AudioContext which is used by AudioNode
  • removed some unnecessary method argument names in header files
4:29 PM Changeset in webkit [67577] by Patrick Gansterer
  • 2 edits in trunk/WebKitTools

2010-09-15 Patrick Gansterer <​paroga@paroga.com>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
4:27 PM Changeset in webkit [67576] by Simon Fraser
  • 18 edits in trunk

2010-09-15 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=44715
maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac

Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
be taken care of in platform code without the need to complicate the GraphicsLayer API.

RenderLayerCompositor no longer sets the geometry orientation for the root
platform layer; platform-specific code does this instead.

This fixes flipped layers in WebKit2, since WebKit2 was already flipping
geometry, and then RenderLayerCompositor was doing an additional flip.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::defaultContentsOrientation):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
  • platform/graphics/win/GraphicsLayerCACF.h:
  • platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::setRootChildLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
4:25 PM Changeset in webkit [67575] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Comments should quote previous comments on the same line
​https://bugs.webkit.org/show_bug.cgi?id=45847

Now when you reply to a previous comment, the tool will quote the
previous comment in the bugs.webkit.org post. This makes it eaiser for
folks following along in email to understand the discussion.

While I was editing this code, I also cleaned up some of the whitespace
handling in comments.

  • code-review.js:
4:01 PM WebKit Team edited by paroga@paroga.com
(diff)
3:57 PM Changeset in webkit [67574] by jchaffraix@webkit.org
  • 9 edits in trunk

Unreviewed.

Reverting my changes as it is breaking several tests on Gtk and Qt.

3:55 PM Changeset in webkit [67573] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fixes for wxMSW.

3:43 PM Changeset in webkit [67572] by eric@webkit.org
  • 7 edits
    1 copy in trunk/WebKitTools

2010-09-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to run more than one commit-queue instance
​https://bugs.webkit.org/show_bug.cgi?id=45786

Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.

This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).

The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(

  • QueueStatusServer/handlers/nextpatch.py: Added.
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • Scripts/webkitpy/tool/commands/queues.py:
3:43 PM Changeset in webkit [67571] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-15 Erik Arvidsson <​arv@chromium.org>

Reviewed by Adam Barth.

Fix regression from bug 32230. The test needed to be updated to reflect the zoom adjusted font-size.
​https://bugs.webkit.org/show_bug.cgi?id=45841

  • editing/pasteboard/page-zoom.html:
3:31 PM Changeset in webkit [67570] by jchaffraix@webkit.org
  • 9 edits
    2 adds in trunk

WebCore: Parse system colors in the HTML5 canvas context.
​https://bugs.webkit.org/show_bug.cgi?id=39168

Reviewed by Andreas Kling.

Test: fast/css/test-setting-canvas-color.html

Based on previous work by Jan Erik Hanssen <​jhanssen@codeaurora.org>

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.

(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.

  • css/CSSParser.h: Added the new parseSystemColor method.
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.

  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.

  • html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.

LayoutTests: Test for: Parse system colors in the HTML5 canvas context.
​https://bugs.webkit.org/show_bug.cgi?id=39168

Reviewed by Andreas Kling.

This tests that svg color, deprecated system color and different
type of colors and invalid inputs are still parsed as such.

  • fast/css/test-setting-canvas-color-expected.txt: Added.
  • fast/css/test-setting-canvas-color.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
3:10 PM Changeset in webkit [67569] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-15 Adam Barth <​abarth@webkit.org>

Minor UI tweak to the review tool. We want to display newlines in
previous and frozen comments instead of collapsing them.

  • PrettyPatch/PrettyPatch.rb:
2:23 PM Changeset in webkit [67568] by arv@chromium.org
  • 7 edits
    3 adds in trunk

2010-09-14 Erik Arvidsson <​arv@chromium.org>

Reviewed by Darin Adler.

getComputedStyle() returns different values for different zoom levels
​https://bugs.webkit.org/show_bug.cgi?id=32230

Test: fast/css/getComputedStyle/computed-style-with-zoom.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::zoomAdjustedPixelValue): (WebCore::zoomAdjustedNumberValue): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::getBorderRadiusCornerValue): (WebCore::computedTransform): (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): (WebCore::CSSComputedStyleDeclaration::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSComputedStyleDeclaration.h:
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • rendering/RenderObject.h: (WebCore::adjustForAbsoluteZoom):
  • rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom):
12:52 PM Changeset in webkit [67567] by Martin Robinson
  • 4 edits
    2 moves
    4 adds in trunk/WebCore

2010-09-14 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fully separate Pango and FreeType font backends
​https://bugs.webkit.org/show_bug.cgi?id=27442

Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
Include the correct file via #ifdef'd includes, like the Chromium port. Also split
FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
compilation unit is used only by the FreeType backend. This change is important to
prevent upcoming fixes to the FreeType backend from affecting other backends.

No new tests as functionality has not changed.

  • CMakeListsEfl.txt: Update source lists.
  • GNUmakefile.am: Update source lists.
  • platform/graphics/cairo/FontCacheCairo.cpp: Removed.
  • platform/graphics/cairo/FontCacheFreeType.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::isWellKnownFontName): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/cairo/FontPlatformData.h:
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::description):
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/gtk/FontCachePango.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/gtk/FontPlatformDataPango.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/win/FontPlatformDataCairoWin.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::useGDI): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
12:19 PM Changeset in webkit [67566] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-09-14 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
​https://bugs.webkit.org/show_bug.cgi?id=45775

Handle the toggle-overwrite signal on the GtkTextView used for generating editing
commands. Ignore this signals, as the default handler assumes that the GtkTextView
has a layout and this one does not.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): Added. Cancels the default handler. (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
12:16 PM Changeset in webkit [67565] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-15 William Siegrist <​wsiegrist@apple.com>

Allow for narrow columns in waterfall.

12:10 PM Changeset in webkit [67564] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-15 William Siegrist <​wsiegrist@apple.com>

Darken and improve contrast for success and failure boxes.

10:51 AM Changeset in webkit [67563] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

AX: when text is auto-truncated, accessibility bounds are wrong
​https://bugs.webkit.org/show_bug.cgi?id=45793

Adding ellipsis-text.html to the skip list for GTK until the reason for its failure
is determined.

  • platform/gtk/Skipped:
10:34 AM Changeset in webkit [67562] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-15 Tony Chang <​tony@chromium.org>

Unreviewed, remove test that is now passing in test_shell and DRT.

  • platform/chromium/test_expectations.txt:
10:07 AM Changeset in webkit [67561] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: when text is auto-truncated, accessibility bounds are wrong
​https://bugs.webkit.org/show_bug.cgi?id=45793

Reviewed by Simon Fraser.

WebCore:

Allow accessibility to retrieve the absoluteQuads of a text node that
clips to the ellipsis.

Test: accessibility/ellipsis-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

  • rendering/RenderText.cpp:

(WebCore::ellipsisRectForBox):

Make a common method to retrieve the ellipsis rect.

(WebCore::RenderText::absoluteQuads):

Default into the absoluteQuads method that allows for ellipsis clipping.

(WebCore::RenderText::selectionRectForRepaint):

Use the common method for retrieving the ellipsis.

  • rendering/RenderText.h:

LayoutTests:

  • accessibility/ellipsis-text-expected.txt: Added.
  • accessibility/ellipsis-text.html: Added.
10:05 AM Changeset in webkit [67560] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-15 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
​https://bugs.webkit.org/show_bug.cgi?id=45791

Force filenames to be raw bytes before running difflib.unified_diff.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
9:44 AM Changeset in webkit [67559] by ariya@webkit.org
  • 5 edits in trunk

2010-09-15 Ariya Hidayat <​ariya@sencha.com>

[Qt] Improve the speed of blur shadow
​https://bugs.webkit.org/show_bug.cgi?id=44222

Update pixel test result.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:

2010-09-15 Ariya Hidayat <​ariya@sencha.com>

[Qt] Improve the speed of blur shadow
​https://bugs.webkit.org/show_bug.cgi?id=44222

Rewrite the shadow blur function with loop unrolls and sliding step
unification for both horizontal and vertical directions.
This gives significant performance improvement on most cases.

  • platform/graphics/qt/ContextShadow.cpp: (WebCore::shadowBlur):
9:06 AM Changeset in webkit [67558] by wsiegrist@apple.com
  • 3 adds
    1 delete in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-09-15 William Siegrist <​wsiegrist@apple.com>

Sync buildbot files after upgrade to v0.8.1

8:52 AM Changeset in webkit [67557] by steveblock@google.com
  • 3 edits in trunk/LayoutTests

2010-09-15 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

fast/dom/DeviceOrientation/add-listener-from-callback flaky
​https://bugs.webkit.org/show_bug.cgi?id=45814

When we call addEventListener(), an event is sent to all registered
event listeners on that page. So in the existing test, both the calls
to setMockDeviceOrientation() and addEventListener() will trigger events
to fire asynchronously on both listeners (both will be registered by the
time the event fires), giving a total of five events. A race condition
exists as to whether the test finishes after the third event, before
the fourth event fires.

This patch fixes the problem by expecting the correct number of events
to fire. We also remove the call to setMockDeviceOrientation() as this
adds extra complication and is tested in update.html.

  • fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt:
  • fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: (checkOrientation): (firstListener):
8:35 AM Changeset in webkit [67556] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Use Qt Labs' WebKit category feed instead of filtering on "webkit"

Looks like the URL of the WebKit category feed changed since this blog
was first added to Planet WebKit.

Rubber-stamped by David Kilzer.

  • config.ini:
8:20 AM Changeset in webkit [67555] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Only include Qt Labs posts that mention WebKit

All other feeds are either WebKit-specific or are filtered on
"webkit". This makes Qt Labs match all the others. This should help
keep off-topic posts off of Planet WebKit.

Fixes <​http://webkit.org/b/45818> Planet WebKit contains many
off-topic posts from Qt Labs

Reviewed by David Kilzer.

  • config.ini: Filter the Qt Labs feed on "webkit" like we do for all

other non-WebKit-specific feeds.

6:32 AM Changeset in webkit [67554] by Simon Hausmann
  • 3 edits in trunk/WebKitTools

[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
​https://bugs.webkit.org/show_bug.cgi?id=35247

Reviewed by Tor Arne Vestbø.

The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):

  • QtTestBrowser/mainwindow.h:
6:25 AM Changeset in webkit [67553] by pfeldman@chromium.org
  • 38 edits in trunk

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
  • inspector/InspectorResource.h:
  • loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
  • loader/icon/IconFetcher.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
  • platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • public/WebURLLoadTiming.h:
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
  • src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
5:56 AM Changeset in webkit [67552] by yurys@chromium.org
  • 37 edits in trunk

2010-09-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67551.
​http://trac.webkit.org/changeset/67551
​https://bugs.webkit.org/show_bug.cgi?id=45816

"Plugin tests fail" (Requested by yurys on #webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
  • inspector/InspectorResource.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didFinishLoading):
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
  • loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
  • loader/SubresourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
  • loader/icon/IconFetcher.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::finishedCallback): (WebCore::parseDataUrl):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):

2010-09-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67551.
​http://trac.webkit.org/changeset/67551
​https://bugs.webkit.org/show_bug.cgi?id=45816

"Plugin tests fail" (Requested by yurys on #webkit).

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):

2010-09-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67551.
​http://trac.webkit.org/changeset/67551
​https://bugs.webkit.org/show_bug.cgi?id=45816

"Plugin tests fail" (Requested by yurys on #webkit).

  • webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
5:04 AM Changeset in webkit [67551] by pfeldman@chromium.org
  • 37 edits in trunk

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
  • inspector/InspectorResource.h:
  • loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
  • loader/icon/IconFetcher.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
  • platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • public/WebURLLoadTiming.h:
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
  • src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):

2010-09-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
​https://bugs.webkit.org/show_bug.cgi?id=45664

  • webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
4:45 AM Changeset in webkit [67550] by pfeldman@chromium.org
  • 1 edit
    40 adds in trunk/LayoutTests

2010-09-15 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] rebaseline 10 new svg tests added in 67544
​https://bugs.webkit.org/show_bug.cgi?id=45813

  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
4:34 AM Changeset in webkit [67549] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Update the Symbian def files

Re-freeze with the viewport meta tag updates.

  • symbian/eabi/QtWebKitu.def:
4:34 AM Changeset in webkit [67548] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-15 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] mark new viewport tests as failing rather then skip them
​https://bugs.webkit.org/show_bug.cgi?id=45652

  • platform/chromium/test_expectations.txt:
4:17 AM Changeset in webkit [67547] by loislo@chromium.org
  • 10 edits in trunk

2010-09-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: small refactoring for monitorXHR backend property.

Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.

​https://bugs.webkit.org/show_bug.cgi?id=45759

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/inspector.js:

2010-09-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: small refactoring for monitorXHR backend property.

Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.

​https://bugs.webkit.org/show_bug.cgi?id=45759

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/inspector.js:
3:05 AM Changeset in webkit [67546] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

2010-09-15 Steve Block <​steveblock@google.com>

Reviewed by Kent Tamura.

LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=45783

This test synchronously navigates the page to a new URL from its main script file.
This navigation causes WebView.onPageFinished() to be called for the test page.
The problem is that this may occur before js-test-post.js, which is included by the
test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a
result, the test is incorrectly deemed to have finished as soon as the navigation
is started and the output will therefore be incorrect.

This patch fixes the problem by initiating the page navigation from
the onload handler, which is not fired until all resources have been
loaded and parsed. This guarantees that WebView.onPageFinished() is
not called until after layoutTestController.waitUntilDone() has been
called.

  • fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
2:44 AM Changeset in webkit [67545] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Multiline console does not work on Windows / Linux.
​https://bugs.webkit.org/show_bug.cgi?id=45807

  • inspector/front-end/ConsoleView.js:
2:13 AM Changeset in webkit [67544] by commit-queue@webkit.org
  • 4 edits
    50 adds in trunk

2010-09-15 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=45809

Adding layout tests for feTurbulence dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-baseFrequency-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-numOctaves-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-seed-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-stitchTiles-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-type-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-numOctaves-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-seed-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-stitchTiles-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-type-prop.js: Added. (executeTest):

2010-09-15 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
A typo (noStich instead of nostitch) is also fixed in this patch.
​https://bugs.webkit.org/show_bug.cgi?id=45809

Tests: svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html

svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html

  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
  • svg/SVGFETurbulenceElement.h:
1:58 AM Changeset in webkit [67543] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp

Merge 67185 - 2010-09-09 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Joseph Pecoraro.

WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.

  1. Open any page
  2. Right-click on any element, select "Inspect Element"
  3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
  4. Inspect the Web Inspector. An error message is logged in the console.

The regression was introduced in ​http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).

​https://bugs.webkit.org/show_bug.cgi?id=45374

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):

TBR=​loislo@chromium.org
Review URL: ​http://codereview.chromium.org/3385005

1:55 AM Changeset in webkit [67542] by pfeldman@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 66813 - 2010-08-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=44943

Test: inspector/debugger-suspend-active-dom-objects.html

  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

2010-08-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=44943

  • inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
  • inspector/debugger-suspend-active-dom-objects.html: Added.

TBR=​yurys@chromium.org
Review URL: ​http://codereview.chromium.org/3446004

1:46 AM Changeset in webkit [67541] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-15 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Avoid memcpy in TextCodecWinCE::encode
​https://bugs.webkit.org/show_bug.cgi?id=45468

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::TextCodecWinCE::encode):
1:29 AM Changeset in webkit [67540] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-15 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Web Inspector] mark two debugger tests as slow on win debug chromium
​https://bugs.webkit.org/show_bug.cgi?id=45742

  • platform/chromium/test_expectations.txt:
12:20 AM Changeset in webkit [67539] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Roll out r67533 to fix the build.

Sep 14, 2010:

11:41 PM Changeset in webkit [67538] by kinuko@chromium.org
  • 8 edits
    2 adds in trunk/WebCore

2010-09-14 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
​https://bugs.webkit.org/show_bug.cgi?id=45724

No new tests; tests will be added later.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDirectoryEntryCustom.cpp: Added. (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • fileapi/DirectoryEntry.h:
  • fileapi/DirectoryEntry.idl:
10:59 PM Changeset in webkit [67537] by johnnyg@google.com
  • 5 edits
    3 adds
    1 delete in trunk/LayoutTests

2010-09-14 John Gregg <​johnnyg@google.com>

Unreviewed, chromium rebaseline to fix build.

[chromium] rebaselines for bug16012.html after font-size changes
​https://bugs.webkit.org/show_bug.cgi?id=45805

  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.txt:
10:26 PM Changeset in webkit [67536] by johnnyg@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-14 John Gregg <​johnnyg@google.com>

Unreviewed, chromium rebaseline.

Rebaseline xss-DENIED-frame-name-expected.txt
​https://bugs.webkit.org/show_bug.cgi?id=45795

  • platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
10:03 PM Changeset in webkit [67535] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-14 Adam Barth <​abarth@webkit.org>

Attempt to fix test failure on Qt and Gtk. It's tricky to write a test
for an API that supposed to report the current date and time without a
timezone. This patch increases the allowably time window to a day +
one hour, which should be enough to account for any timezone issues.

  • http/tests/misc/no-last-modified.html:
9:38 PM Changeset in webkit [67534] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-14 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.

  • editing/Editor.cpp: (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection panel is shown.
  • editing/Editor.h: Added declaration of isShowingCorrectionPanel().
  • editing/EditorCommand.cpp: (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() when autocorrection panel is shown. (WebCore::createCommandMap): Replaced isSupported function pointer for executeCancelOperation() command with supportedDismissCorrectionPanel().
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of new member method declared in base class.
  • page/EditorClient.h: Declared new member method isShowingCorrectionPanel().

2010-09-14 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, for invalid correction panel tag. Replaced -1 with this constant. (WebEditorClient::dismissCorrectionPanel): Ditto (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.

2010-09-14 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
9:09 PM Changeset in webkit [67533] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-09-14 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

WebKit should use system wide spell checking preference when application specific one isn't set.
​https://bugs.webkit.org/show_bug.cgi?id=45789

  • WebView/WebView.mm: (+[WebView initialize]): Use system wide autocorrection and text substitution preferences

when the application level preferences are not set.

8:47 PM Changeset in webkit [67532] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
​http://trac.webkit.org/changeset/67503
​https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • fast/files/apply-blob-url-to-img.html:
  • platform/mac/Skipped:

2010-09-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
​http://trac.webkit.org/changeset/67503
​https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::BlobRegistryContext::BlobRegistryContext):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::addData):
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):

2010-09-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
​http://trac.webkit.org/changeset/67503
​https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • src/ResourceHandle.cpp:
8:37 PM Changeset in webkit [67531] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Zoom factor for checkboxes and radios.
​https://bugs.webkit.org/show_bug.cgi?id=45776

RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.

Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
8:19 PM Changeset in webkit [67530] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-14 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add AudioFileReader files (Mac implementation)
​https://bugs.webkit.org/show_bug.cgi?id=36475

No new tests since audio API is not yet implemented.

  • platform/audio/AudioFileReader.h: Added.
  • platform/audio/mac/AudioFileReaderMac.cpp: Added. (WebCore::createAudioBufferList): (WebCore::destroyAudioBufferList): (WebCore::AudioFileReader::AudioFileReader): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::readProc): (WebCore::AudioFileReader::getSizeProc): (WebCore::AudioFileReader::createBus): (WebCore::createBusFromAudioFile): (WebCore::createBusFromInMemoryAudioFile):
  • platform/audio/mac/AudioFileReaderMac.h: Added. (WebCore::AudioFileReader::data): (WebCore::AudioFileReader::dataSize):
7:31 PM Changeset in webkit [67529] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-09-14 Hyung Song <​beergun@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
​https://bugs.webkit.org/show_bug.cgi?id=44764

  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
7:04 PM Changeset in webkit [67528] by abarth@webkit.org
  • 2 edits
    1 add in trunk/BugsSite

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

bugs.webkit.org should autocomplete WebKit Committers and Reviewers
​https://bugs.webkit.org/show_bug.cgi?id=45799

This patch implements an autocomplete dropdown that helps users type
the names of WebKit committers and reviewers. The script grabs the
data from SVN now that wms set up CORS for ​http://svn.webkit.org.
Security technology for the win.

This script is based on (well, essentially copied from) the popular
autocomplete extension:

​https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb

I asked Ojan, and said he was fine licensing the code under the BSD
license. I'm not sure how the patch interacts with the extension, but
we can retire the extension if they interact poorly.

  • committers-autocomplete.js: Added.
  • template/en/default/global/footer.html.tmpl:
    • Add the script to every page on bugs.webkit.org
6:59 PM Changeset in webkit [67527] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-14 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Send webkit accessibility notifications to Chromium
​https://bugs.webkit.org/show_bug.cgi?id=45156

Move printf inside shouldDumpAccessibilityNotifications check.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
6:55 PM Changeset in webkit [67526] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-09-14 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

Drawing an image outside the bounds of a canvas still causes repaints
​https://bugs.webkit.org/show_bug.cgi?id=45792

Some canvas examples, such as ​http://www.phoboslab.org/biolab/, draw
images outide the bounds of the canvas. If the canvas already had a
non-empty m_dirtyRect, such draws would cause us to do a repaint of
m_dirtyRect again (which goes through the platform-specific invalidation
machinery, which can be slow).

Optimize this by avoiding extra invalidation when the dirty rect
does not intersect the canvas bounds.

Not testable because this avoids additional repaints of m_dirtyRect, but
m_dirtyRect has to be non-empty for this to benefit.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
6:42 PM Changeset in webkit [67525] by yurys@chromium.org
  • 5 edits in trunk

2010-09-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Links from "Profiles" don't lead to "Scripts"
​https://bugs.webkit.org/show_bug.cgi?id=45756

  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link
  • inspector/front-end/inspector.js: code cleanup: removed no-op method (WebInspector.addMainEventListeners):

2010-09-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Links from "Profiles" don't lead to "Scripts"
​https://bugs.webkit.org/show_bug.cgi?id=45756

  • src/js/DevTools.js: remove obsolete code
6:26 PM BuildingGtk edited by tonyg@chromium.org
(diff)
6:25 PM Changeset in webkit [67524] by tony@chromium.org
  • 6 edits in trunk

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
​https://bugs.webkit.org/show_bug.cgi?id=45788

  • platform/chromium/test_expectations.txt:

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
​https://bugs.webkit.org/show_bug.cgi?id=45788

  • DEPS: Include webkit_support::LocalFileToDataURL

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
​https://bugs.webkit.org/show_bug.cgi?id=45788

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
6:23 PM Changeset in webkit [67523] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-14 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Use codePage instead of TextEncoding
​https://bugs.webkit.org/show_bug.cgi?id=45466

Use codePage as member variable to avoid repeated lookup.

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode):
  • platform/text/wince/TextCodecWinCE.h:
5:48 PM Changeset in webkit [67522] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-14 Adam Barth <​abarth@webkit.org>

Add a license block to the reviewtool. I should have added this from
the start. According to the SVN log, I'm the only one to have ever
touched this file.

  • code-review.js:
5:45 PM Changeset in webkit [67521] by tony@chromium.org
  • 5 edits in trunk

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=45768

  • public/WebKit.h:
  • src/WebKit.cpp:

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=45768

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
5:36 PM Changeset in webkit [67520] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Adam Barth <​abarth@webkit.org>

Attempted Chromium build fix. The compiler can't tell that
ASSERT_NOT_REACHED is not reached and so it demands an initialization
of this variable.

  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
5:34 PM Changeset in webkit [67519] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-09-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] ewk_frame_view_create_for_view set null as theme.
​https://bugs.webkit.org/show_bug.cgi?id=45741

Add theme in ewk_view to use instead of frame's theme which is null in
ewk_frame_view_create_for_view.

  • ewk/ewk_frame.cpp: (ewk_frame_view_create_for_view):
  • ewk/ewk_view.cpp: (ewk_view_theme_set): (ewk_view_theme_get):
5:19 PM Changeset in webkit [67518] by mrowe@apple.com
  • 5 edits in trunk/WebKit/mac

Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.

Reviewed by John Sullivan.

  • Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
  • Misc/WebKitVersionChecks.m:

(WebKitLinkedOnOrAfter):
(setWebKitLinkTimeVersion): Set the overridden version.
(WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.

  • WebView/WebPreferences.mm:

(+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.

  • WebView/WebPreferencesPrivate.h:
5:19 PM Changeset in webkit [67517] by tony@chromium.org
  • 4 edits in trunk

2010-09-14 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

blob: URL scheme does not work with Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45772

Remove blob-related tests that now pass.

  • platform/chromium/drt_expectations.txt:

2010-09-14 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

blob: URL scheme does not work with Chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=45772

Roll Chromium forward to r59406, which registers the blob
URL scheme for the Chromium DRT too.

  • DEPS:
4:53 PM Changeset in webkit [67516] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Wheeling over windowed plugins sometimes cause them to disappear

  • plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::x11Event): Pass on captured mouse wheel events to the effective native window rather than the grandparent widget. We were calling QWidget::winId() which caused a new X11 window to be created for the grandparent widget and generally mess things up.
4:46 PM Changeset in webkit [67515] by kevino@webkit.org
  • 8 edits
    1 add in trunk

[wx] Build fixes after recent changes.

4:32 PM Changeset in webkit [67514] by abarth@webkit.org
  • 7 edits in trunk

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Handle <font size=0> as <font size=1> like any other browser
​https://bugs.webkit.org/show_bug.cgi?id=39148

Update font size parser to match HTML5 spec. The main difference here
is the handling of 0, which now maps to 1 instead of 3.

  • html/HTMLFontElement.cpp: (WebCore::parseFontSize): (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Handle <font size=0> as <font size=1> like any other browser
​https://bugs.webkit.org/show_bug.cgi?id=39148

Update tests and results to match new behavior.

  • editing/execCommand/query-font-size-expected.txt:
  • fast/dom/HTMLFontElement/script-tests/size-attribute.js:
  • fast/dom/HTMLFontElement/size-attribute-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
4:29 PM Changeset in webkit [67513] by abarth@webkit.org
  • 3 edits
    5 adds in trunk

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
​https://bugs.webkit.org/show_bug.cgi?id=8475

Implement document.lastModified as per HTML5.

Tests: http/tests/misc/last-modified-parsing.html

http/tests/misc/no-last-modified.html

  • dom/Document.cpp: (WebCore::Document::lastModified):

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
​https://bugs.webkit.org/show_bug.cgi?id=8475

  • http/tests/misc/last-modified-parsing-expected.txt: Added.
  • http/tests/misc/last-modified-parsing.html: Added.
    • Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
  • http/tests/misc/no-last-modified-expected.txt: Added.
  • http/tests/misc/no-last-modified.html: Added.
    • Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
  • http/tests/resources/last-modified.php: Added.
    • PHP helper script.
4:27 PM Changeset in webkit [67512] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.compatMode is undefined when using application/xhtml+xml
​https://bugs.webkit.org/show_bug.cgi?id=44422

Moving the compatMode IDL attribute from HTMLDocument.idl to
Document.idl fixes this bug and improve compliance with HTML5.

Test: fast/parser/compatMode-in-xhtml.xhtml

  • dom/Document.cpp: (WebCore::Document::compatMode):
  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.compatMode is undefined when using application/xhtml+xml
​https://bugs.webkit.org/show_bug.cgi?id=44422

Test the value of compatMode in XHTML. I'm terrible at XML, but this
test seems to work.

  • fast/parser/compatMode-in-xhtml-expected.txt: Added.
  • fast/parser/compatMode-in-xhtml.xhtml: Added.
4:15 PM Changeset in webkit [67511] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-14 James Kozianski <​soulplant@gmail.com>

Reviewed by Ojan Vafai.

Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window
​https://bugs.webkit.org/show_bug.cgi?id=18447

Add a test for CSSStyleDeclaration.prototype.foo leaking into inner
windows.

  • fast/frames/css-style-declaration-isolation-expected.txt: Added.
  • fast/frames/css-style-declaration-isolation.html: Added.
4:13 PM Changeset in webkit [67510] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • win/WebKit2Generated.make:
4:12 PM Changeset in webkit [67509] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Nate Chapin.

V8 security checks don't account for shadowing named frames
​https://bugs.webkit.org/show_bug.cgi?id=45700

Test: http/tests/security/xss-DENIED-frame-name.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::namedSecurityCheck):
    • If the property name exists on the object, it will shadow the named property lookup on the window object. That means we need to block access if there's shadowing going on.

(WebCore::V8DOMWindow::indexedSecurityCheck):

  • I made the corresponding change to this function too, but I don't think this one can actually be triggered because JavaScript variable names need to start with a non-digit.

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Nate Chapin.

V8 security checks don't account for shadowing named frames
​https://bugs.webkit.org/show_bug.cgi?id=45700

Test whether cross-origin observers can see global variables shadowing
named frames.

  • http/tests/security/resources/frame-for-parent-name.html: Added.
  • http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • http/tests/security/xss-DENIED-frame-name.html: Added.
4:12 PM Changeset in webkit [67508] by Dimitri Glazkov
  • 4 edits in branches/chromium/517/WebKit/chromium

Merge 67418 - 2010-09-13 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
​https://bugs.webkit.org/show_bug.cgi?id=45572

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):

TBR=​ctguil@chromium.org
Review URL: ​http://codereview.chromium.org/3398006

3:53 PM Changeset in webkit [67507] by weinig@apple.com
  • 12 edits
    2 deletes in trunk

Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
​https://bugs.webkit.org/show_bug.cgi?id=45785

Reviewed by Anders Carlsson.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Remove files.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleNode.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp:

(WKBundleRangeCopyStartContainer):
(WKBundleRangeCopyEndContainer):

  • WebProcess/InjectedBundle/API/c/WKBundleRange.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
Change to be in terms of WKBundleNodeHandleRef.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3:53 PM Changeset in webkit [67506] by abarth@webkit.org
  • 9 edits
    2 adds in trunk

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

incorrect tabindex parsing
​https://bugs.webkit.org/show_bug.cgi?id=21076

Updated our integer parsing for tabindex to use the algorithm from the
HTML5 spec.

Test: fast/parser/tabindex-parsing-2.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTMLInteger):
  • html/parser/HTMLParserIdioms.h:

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

incorrect tabindex parsing
​https://bugs.webkit.org/show_bug.cgi?id=21076

  • fast/parser/tabindex-parsing-2-expected.txt: Added.
  • fast/parser/tabindex-parsing-2.html: Added.
    • Test a bunch of corner cases in tabindex parsing.
  • fast/parser/tabindex-parsing-expected.txt:
  • fast/parser/tabindex-parsing.html:
    • Update expected result. This case is actually the one that the original reporter was complaining about.
3:48 PM Changeset in webkit [67505] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Build correction, no review.

  • WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from

non-Cairo based builds.

3:38 PM Changeset in webkit [67504] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-14 Adam Barth <​abarth@webkit.org>

Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
3:26 PM Changeset in webkit [67503] by jianli@chromium.org
  • 12 edits in trunk

fast/files/apply-blob-url-to-img.html timeout on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=45576

Reviewed by David Levin.

WebCore:

The failure on Leopard is caused by the static method
ResourceHandle::supportsBufferedData that returns true to indicate that
the buffered data support is enabled for blob resource. However,
BlobResourceHandle does not support this and we need to override this.

The fix is to change supportsBufferedData method from static to virtual
so that we can override the default behavior in BlobResourceHandle.

  • fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread.

(WebCore::BlobRegistryContext::BlobRegistryContext):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::supportsBufferedData): Override the default
behavior.

  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h: Made supportsBufferedData virtual.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::bufferedData):

WebKit/chromium:

  • src/ResourceHandle.cpp: Remove the no longer applicable static comment.

LayoutTests:

Update the test to compute the right coordinates to drag the file to.
This fixes the problem that onInputFileChange() is not called on
Leopard.

  • fast/files/apply-blob-url-to-img.html:
  • platform/mac/Skipped: Remove the passing test from Skipped list.
3:19 PM Changeset in webkit [67502] by victorw@chromium.org
  • 1 edit
    24 deletes in trunk/LayoutTests

2010-09-14 Victor Wang <​victorw@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove the wrong chromium-win-vista expectations.

Layout test results generated from Chromium vista bots match
the expectations in chromium-win. These baselines are either
wrong or out of date. Need to be cleaned up so chromium
vista bots can pass on these tests.

​https://bugs.webkit.org/show_bug.cgi?id=45766

  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.png: Removed.
3:00 PM Changeset in webkit [67501] by jberlin@webkit.org
  • 4 edits in trunk

2010-09-14 Jessie Berlin <​jberlin@apple.com>

Reviewed by Adam Roben.

Exceptions are getting ignored on 64-bit Windows in the Web Process
​https://bugs.webkit.org/show_bug.cgi?id=45779

WebKit2:

WebKitSite:

  • building/tools.html: Add instructions about how to optionally get hotfix 976038.
2:55 PM Changeset in webkit [67500] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

Fixed layout test failure seen on buildbot by correcting expected results.

It looks like Darin accidentally checked in the wrong expected results.

  • fast/css/visited-link-hang-expected.txt:
2:43 PM Changeset in webkit [67499] by bfulgham@webkit.org
  • 5 edits in trunk

Build correction, no review.

WebCore:

  • WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp implementation file.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include for <cairo.h>

WebKit2:

  • win/WebKit2.vcproj: Disable build for Cairo targets of

the WebURLRequestWin.cpp and WebURLResponseWin.cpp files.

2:29 PM Changeset in webkit [67498] by abarth@webkit.org
  • 14 edits
    32 adds
    2 deletes in trunk

2010-09-14 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156


Use postAccessibilityNotification to pass accessibility notifications
to chromium.

  • WebKit.gyp:
  • public/WebAccessibilityNotification.h: Added.
  • public/WebViewClient.h: (WebKit::WebViewClient::postAccessibilityNotification):
  • src/AssertMatchingEnums.h: Added.
  • src/ChromeClientImpl.cpp: (WebKit::toWebAccessibilityNotification): (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren): (WebKit::ChromeClientImpl::postAccessibilityNotification):
  • src/ChromeClientImpl.h:

2010-09-14 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156


Use postAccessibilityNotification to pass accessibility notifications
to chromium.

Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html

platform/chromium/accessibility/post-notification-CheckedStateChanged.html
platform/chromium/accessibility/post-notification-ChildrenChanged.html
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html
platform/chromium/accessibility/post-notification-LayoutComplete.html
platform/chromium/accessibility/post-notification-LiveRegionChanged.html
platform/chromium/accessibility/post-notification-LoadComplete.html
platform/chromium/accessibility/post-notification-MenuListValueChanged.html
platform/chromium/accessibility/post-notification-RowCollapsed.html
platform/chromium/accessibility/post-notification-RowCountChanged.html
platform/chromium/accessibility/post-notification-RowExpanded.html
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html
platform/chromium/accessibility/post-notification-SelectedTextChanged.html
platform/chromium/accessibility/post-notification-ValueChanged.html

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:

2010-09-14 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156

  • platform/chromium/accessibility/children-changed-notification-expected.txt: Removed.
  • platform/chromium/accessibility/children-changed-notification.html: Removed.
  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Added.
  • platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Added.
  • platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ChildrenChanged.html: Added.
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Added.
  • platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LayoutComplete.html: Added.
  • platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Added.
  • platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LoadComplete.html: Added.
  • platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Added.
  • platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowCollapsed.html: Added.
  • platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowCountChanged.html: Added.
  • platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowExpanded.html: Added.
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Added.
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Added.
  • platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Added.
  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ValueChanged.html: Added.
  • platform/chromium/accessibility/post-notification.js: Added. (enumAccessibilityObjects): (testDone): (test):
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-09-14 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45156

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
  • DumpRenderTree/chromium/WebViewHost.h:
2:22 PM Changeset in webkit [67497] by adachan@apple.com
  • 5 edits in trunk/WebKit/win

Reviewed by Adam Roben.

Add an IWebFramePrivate API to load string as plain text into the WebFrame.
​https://bugs.webkit.org/show_bug.cgi?id=45782

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl: Touch the file.
  • WebFrame.cpp: (WebFrame::loadPlainTextString):
  • WebFrame.h:
2:10 PM Changeset in webkit [67496] by Darin Adler
  • 3 edits
    2 adds in trunk

2010-09-14 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Hang processing href attribute containing a million slashes
​https://bugs.webkit.org/show_bug.cgi?id=45767

Test: fast/css/visited-link-hang.html

  • platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): Added a start position argument and changed types to use size_t consistently instead of a mix. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::squeezeOutNullCharacters): Added. (WebCore::cleanSlashDotDotSlashes): Added. Factored out part of cleanPath (see below). (WebCore::mergeDoubleSlashes): Ditto. (WebCore::cleanSlashDotSlashes): Ditto. (WebCore::cleanPath): Changed algorithm to not remove as we go to avoid N2 behavior; instead replace with null characters and then do a squeeze operation after the fact. Also moved the body of the function out of line since we normally don't have to do any cleaning. This whole thing should go at some point -- it's not the right algorithm -- but this should eliminate the performance problems without changing behavior.

2010-09-14 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Hang processing href attribute containing a million slashes
​https://bugs.webkit.org/show_bug.cgi?id=45767

  • fast/css/visited-link-hang-expected.txt: Added.
  • fast/css/visited-link-hang.html: Added.
2:07 PM Changeset in webkit [67495] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue is slow during the day
​https://bugs.webkit.org/show_bug.cgi?id=45780

Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.

This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
2:06 PM Changeset in webkit [67494] by Darin Adler
  • 5 edits in trunk

2010-09-14 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Sort with non-numeric custom sort function fails on array with length but no values
​https://bugs.webkit.org/show_bug.cgi?id=45781

  • runtime/JSArray.cpp: (JSC::JSArray::sort): Replaced early exit for an array of length zero to instead exit for any array without values, even if it has a non-0 length.

2010-09-14 Darin Adler <Darin Adler>

Reviewed by Geoffrey Garen.

Sort with non-numeric custom sort function fails on array with length but no values
​https://bugs.webkit.org/show_bug.cgi?id=45781

  • fast/js/script-tests/sort-large-array.js: Added test cases.
  • fast/js/sort-large-array-expected.txt: Updated.
2:02 PM Changeset in webkit [67493] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-14 Nico Weber <​thakis@chromium.org>

Reviewed by Kenneth Russell.

[chromium]: On Mac, let image layer data row order match skia.
​https://bugs.webkit.org/show_bug.cgi?id=45400

Make CoreGraphics texture row order match skia's row order, remove all
code that worked around this difference. This also fixes a problem where
image layers would be drawn upside down.

Covered by existing layout tests, but we don't run these with
compositing yet.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::drawLayers):
1:45 PM Changeset in webkit [67492] by sfalken@apple.com
  • 2 edits in tags/Safari-534.7.2/JavaScriptCore

Merge r67482.

1:41 PM Changeset in webkit [67491] by sfalken@apple.com
  • 5 edits in tags/Safari-534.7.2

Versioning.

1:29 PM Changeset in webkit [67490] by rniwa@webkit.org
  • 10 edits
    3 adds in trunk

2010-09-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend run properly
​https://bugs.webkit.org/show_bug.cgi?id=45616

The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.

Test: editing/style/inline-style-extend-run.html

  • editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
  • editing/ApplyStyleCommand.h:

2010-09-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend a run properly
​https://bugs.webkit.org/show_bug.cgi?id=45616

Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.

  • editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
  • editing/execCommand/toggle-style-3-expected.txt: Ditto.
  • editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
  • editing/style/inline-style-extend-run-expected.txt: Added.
  • editing/style/inline-style-extend-run.html: Added.
  • editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
  • editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
  • fast/events/event-input-contentEditable-expected.txt: Merged two anchor elements.
  • fast/events/event-input-contentEditable.html: Ditto.
1:27 PM Changeset in webkit [67489] by sfalken@apple.com
  • 1 copy in tags/Safari-534.7.2

New tag.

1:08 PM Changeset in webkit [67488] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-09-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] V8 port: Get inspector up and running
​https://bugs.webkit.org/show_bug.cgi?id=45771

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::ensureDebuggerScriptLoaded): Added, loads DebuggerScript.js into ScriptDebugServer. (WebCore::InspectorClientQt::openInspectorFrontend): Ensure that DebuggerScript.js is loaded before opening an inspector.

2010-09-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] V8 port: Get inspector up and running
​https://bugs.webkit.org/show_bug.cgi?id=45771

  • inspector/front-end/WebKit.qrc: Add DebuggerScript.js
12:56 PM Changeset in webkit [67487] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-14 Tony Chang <​tony@chromium.org>

Unreviewed, fix chromium win compile.

  • public/WebView.h:
12:48 PM Changeset in webkit [67486] by oliver@apple.com
  • 2 edits in trunk/WebCore

PPC Build fix.

12:44 PM Changeset in webkit [67485] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Andreas Kling.

[chromium] Remove unused ICU headers
​https://bugs.webkit.org/show_bug.cgi?id=45698

Remove unused headers.

  • platform/graphics/chromium/FontCacheLinux.cpp:
12:23 PM Changeset in webkit [67484] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode
​https://bugs.webkit.org/show_bug.cgi?id=17722

I believe our behavior matches the HTML5 spec. When we see a </x>, we
correctly kick out of standards mode. In the </> case, however, the
tokenizer just eats the bytes, without emitting a token, which means we
don't get kicked out of standards mode. Our behavior matches Minefield.

  • fast/parser/strange-doctype-compatmode-1-expected.txt: Added.
  • fast/parser/strange-doctype-compatmode-1.html: Added.
  • fast/parser/strange-doctype-compatmode-2-expected.txt: Added.
  • fast/parser/strange-doctype-compatmode-2.html: Added.
12:02 PM Changeset in webkit [67483] by andreas.kling@nokia.com
  • 2 edits
    1 add in trunk/WebCore

2010-09-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Numpad Enter key returns keyCode 0 instead of 13
​https://bugs.webkit.org/show_bug.cgi?id=45014

Original patch by Jarred Nicholls <​jarred.nicholls@gmail.com>

There is a missing case statement in the PlatformKeyboardEventQt.cpp
file to handle the Enter button on the number pad. Because it is not
handled, the keyCode returned in a JavaScript event is 0 rather than 13.

Test: manual-tests/qt/numpad-enter-key.html

  • manual-tests/qt/numpad-enter-key.html: Added.
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
11:49 AM Changeset in webkit [67482] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows production build fix.
Roll out r65143.

11:15 AM Changeset in webkit [67481] by evan@chromium.org
  • 2 edits in trunk/WebCore

2010-09-14 Evan Martin <​evan@chromium.org>

Reviewed by Darin Fisher.

[chromium] building without debug syms broke after recent refactoring
​https://bugs.webkit.org/show_bug.cgi?id=45720

Now that we build WebCore as multiple libraries, we need to adjust the
flags to turn off debug symbols for all of these libraries.

No new tests; should only affect an uncommon build flag.

  • WebCore.gyp/WebCore.gyp:
10:59 AM Changeset in webkit [67480] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-14 Tony Chang <​tony@chromium.org>

Unreviewed, remove tests that are now passing after Noel Gordon's
fix to test_shell delete key handling.

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [67479] by tony@chromium.org
  • 9 edits in trunk

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
​https://bugs.webkit.org/show_bug.cgi?id=45762

  • platform/chromium/test_expectations.txt:

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
​https://bugs.webkit.org/show_bug.cgi?id=45762

  • public/WebView.h: add WebView::setDomainRelaxationForbidden
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDomainRelaxationForbidden):
  • src/WebViewImpl.h:

2010-09-14 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
​https://bugs.webkit.org/show_bug.cgi?id=45762

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  • DumpRenderTree/chromium/LayoutTestController.h:
10:27 AM Changeset in webkit [67478] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-09-14 Tony Chang <​tony@chromium.org>

Unreviewed, fix chromium compile.

  • platform/graphics/chromium/ImageLayerChromium.h:
10:16 AM Changeset in webkit [67477] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-14 Nico Weber <​thakis@chromium.org>

Reviewed by Darin Fisher.

[chromium]: crash less in compositor mode on mac
​https://bugs.webkit.org/show_bug.cgi?id=45714

The contents image can go away when the dom is updated. Since the
layer tree is updated asynchronously, it needs to ref the native image,
else it will hold on to a stale object.

This still needs to be done for skia, too.

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
10:04 AM Changeset in webkit [67476] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-14 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed build fix: remove "virtual" keyword from
implementation file.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
9:49 AM Changeset in webkit [67475] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/JavaScriptCore

2010-09-14 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Share UnicodeMacrosFromICU.h
​https://bugs.webkit.org/show_bug.cgi?id=45710

glib, qt4 and wince use the same macros from ICU.
Remove the code duplication and use the same header file.

  • wtf/unicode/UnicodeMacrosFromICU.h: Copied from JavaScriptCore/wtf/unicode/glib/UnicodeMacrosFromICU.h.
  • wtf/unicode/glib/UnicodeMacrosFromICU.h: Removed.
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWince.h:
9:30 AM Changeset in webkit [67474] by caseq@chromium.org
  • 7 edits in trunk

2010-09-14 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support for resource timings to HAREntry.
​https://bugs.webkit.org/show_bug.cgi?id=45663

2010-09-14 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
​https://bugs.webkit.org/show_bug.cgi?id=45663

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-test2.js: Added entire timings object to list of non-deterministic fields.
  • http/tests/inspector/resource-tests.js: Ditto.
9:19 AM Changeset in webkit [67473] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Always set LeftButton in PlatformMouseEvent
​https://bugs.webkit.org/show_bug.cgi?id=45705

AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
which button is pressed or released. The current code erroneously sets NoButton.
Set LeftButton unconditionally because Brew MP usually runs on touch device.

  • platform/brew/PlatformMouseEventBrew.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
8:40 AM Changeset in webkit [67472] by yurys@chromium.org
  • 4 edits
    1 move
    1 delete in trunk

2010-09-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Andreas Kling.

Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
​https://bugs.webkit.org/show_bug.cgi?id=45739

  • bindings/v8/DebuggerScript.js: Added.

2010-09-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Andreas Kling.

Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
​https://bugs.webkit.org/show_bug.cgi?id=45739

  • WebKit.grd:
  • WebKit.gypi:
  • src/js/DebuggerScript.js: Removed.
  • src/js/DevToolsHostStub.js: Removed.
8:31 AM Changeset in webkit [67471] by hans@chromium.org
  • 4 edits
    9 adds
    2 deletes in trunk/LayoutTests

2010-09-14 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline DeviceOrientation related layout tests for Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=45542

Some DeviceOrientation layout tests need Chromium-specific
baselines because of differences between JSC and V8.

Also enable prototype-inheritance.html again and unfork its
expectations.

  • fast/dom/script-tests/prototype-inheritance.js:
  • platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
8:18 AM Changeset in webkit [67470] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] add new tests from r67463 to expectations
​https://bugs.webkit.org/show_bug.cgi?id=45753

  • platform/chromium/test_expectations.txt:
7:59 AM Changeset in webkit [67469] by apavlov@chromium.org
  • 7 edits in trunk

2010-09-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore
​https://bugs.webkit.org/show_bug.cgi?id=45530

WebCore:

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
  • css/CSSStyleSelector.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):

LayoutTests:

  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/elements-panel-styles.css: (.foo): (.foo::before):
7:42 AM Changeset in webkit [67468] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Hyung Song <​beergun@company100.net>

Reviewed by Darin Adler.

[BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
​https://bugs.webkit.org/show_bug.cgi?id=45701

SharedBuffer::createWithContentsOfFile() reads file content and saves to
result.m_buffer directly, leaving result.m_size unchanged.

  • platform/brew/SharedBufferBrew.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
7:25 AM Changeset in webkit [67467] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-09-14 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Move adjustLexerState to the HTMLTokenizer
​https://bugs.webkit.org/show_bug.cgi?id=45649

This function used let us share code between the tree builder and the
two other users of the HTMLTokenizer. However, now that the tree
builder is all grown up, it can't use this code anymore. The other
users would much rather this code lived on HTMLTokenizer and understood
<script>. This patch attempts to make them happy.

  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::processToken):
  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::updateStateFor):
  • html/parser/HTMLTokenizer.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::scriptEnabled):
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
7:06 AM Changeset in webkit [67466] by commit-queue@webkit.org
  • 4 edits
    4 adds
    16 deletes in trunk/LayoutTests

2010-09-14 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
​https://bugs.webkit.org/show_bug.cgi?id=45610

post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.

  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/form-target.pl: Added
  • http/tests/navigation/resources/page-that-posts.html: Added.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
7:04 AM Changeset in webkit [67465] by abecsi@webkit.org
  • 2 edits in trunk

2010-09-14 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] qmake doesn't generate correct dependencies for rcc resource files
​https://bugs.webkit.org/show_bug.cgi?id=45747

  • WebKit.pri: add OUT_PWD to DEPENDPATH
6:33 AM Changeset in webkit [67464] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-14 Anton Muhin <​antonm@chromium.org>

Unreviewed cleanup of test expectations for Chromium.

ietestcenter/Javascript/15.4.4.15-3-14.html, ietestcenter/Javascript/15.4.4.15-3-29.html and
ietestcenter/Javascript/15.4.4.15-3-8.html are passing now.

  • platform/chromium/test_expectations.txt:
6:25 AM Changeset in webkit [67463] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

2010-09-14 Pierre-Antoine LaFayette <​plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
​https://bugs.webkit.org/show_bug.cgi?id=40142

Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.

  • fast/repaint/block-layout-inline-children-float-positioned.html: Added.
  • fast/repaint/block-layout-inline-children-replaced.html: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.

2010-09-14 Pierre-Antoine LaFayette <​plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
​https://bugs.webkit.org/show_bug.cgi?id=40142

​http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.

Patch by: Dave Hyatt

Tests: fast/repaint/block-layout-inline-children-float-positioned.html

fast/repaint/block-layout-inline-children-replaced.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
6:20 AM Changeset in webkit [67462] by hans@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-14 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Make WebDeviceOrientationClientMock constructor private.
​https://bugs.webkit.org/show_bug.cgi?id=45743

Clients should use the create member function instead. DumpRenderTree
and the Chromium test_shell have previously been updated to call create.

  • public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
6:16 AM Changeset in webkit [67461] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-14 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] Cookie operations should use NetworkingContext
​https://bugs.webkit.org/show_bug.cgi?id=45745
No new functionality so no new tests.

  • platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager instead of directly accessing the FrameLoaderClient.
5:38 AM Changeset in webkit [67460] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] mark fast/frames/frame-limit.html as DEBUG SLOW CRASH
​https://bugs.webkit.org/show_bug.cgi?id=45738

  • platform/chromium/test_expectations.txt:
5:26 AM Changeset in webkit [67459] by commit-queue@webkit.org
  • 8 edits
    3 deletes in trunk

2010-09-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67449.
​http://trac.webkit.org/changeset/67449
​https://bugs.webkit.org/show_bug.cgi?id=45746

This change makes tree red. (Requested by pfeldman on
#webkit).

  • editing/execCommand/script-tests/toggle-style-3.js:
  • editing/execCommand/toggle-style-3-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt: Removed.
  • editing/style/inline-style-extend-run.html: Removed.
  • editing/style/script-tests/inline-style-extend-run.js: Removed.
  • editing/style/script-tests/make-text-writing-direction-inline.js:

2010-09-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r67449.
​http://trac.webkit.org/changeset/67449
​https://bugs.webkit.org/show_bug.cgi?id=45746

This change makes tree red. (Requested by pfeldman on
#webkit).

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown):
  • editing/ApplyStyleCommand.h:
4:07 AM Changeset in webkit [67458] by eric@webkit.org
  • 12 edits in trunk

2010-09-14 Eric Seidel <​eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • loader/EmptyClients.h:
  • page/EditorClient.h:

2010-09-14 Eric Seidel <​eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::dismissCorrectionPanel):

2010-09-14 Eric Seidel <​eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::dismissCorrectionPanel):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
2:52 AM Changeset in webkit [67457] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
2:46 AM Changeset in webkit [67456] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
​https://bugs.webkit.org/show_bug.cgi?id=45736

Reviewed by Kenneth Rohde Christiansen.

Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.

  • Scripts/build-webkit:
2:23 AM Changeset in webkit [67455] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-09-14 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed; an attempt to fix Chromium Windows build.

  • fileapi/FileEntry.cpp:
2:10 AM Changeset in webkit [67454] by caseq@chromium.org
  • 3 edits in trunk/WebCore

2010-09-13 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide support for opening external navigation for links within certain elements
Use default handling for clicks on links that have target="_blank"
Add option for external navigation to URL audit formatter.
​https://bugs.webkit.org/show_bug.cgi?id=45671

  • inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.url):
  • inspector/front-end/inspector.js:
1:26 AM Changeset in webkit [67453] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-14 Enrico Ros <​eros@codeaurora.org>

Reviewed by Andreas Kling.

[Qt] Respect title attribute on option elements
​https://bugs.webkit.org/show_bug.cgi?id=45084

Set the tooltip in the combo box model, so it's reflected in the view.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
1:03 AM Changeset in webkit [67452] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • editing/EditorCommand.cpp:
12:50 AM Changeset in webkit [67451] by mitz@apple.com
  • 12 edits in trunk

Only intercept ESC key press when autocorrection UI is visible.
​https://bugs.webkit.org/show_bug.cgi?id=45071

Patch by Jia Pu <​jpu@apple.com> on 2010-09-14
Reviewed by Dan Bernstein.

WebCore:

Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.

  • editing/Editor.cpp:

(WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection

panel is shown.

  • editing/Editor.h: Added declaration of isShowingCorrectionPanel().
  • editing/EditorCommand.cpp:

(WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation()

when autocorrection panel is shown.

(WebCore::createCommandMap): Replaced isSupported function pointer for

executeCancelOperation() command with supportedDismissCorrectionPanel().

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of

new member method declared in base class.

  • page/EditorClient.h: Declared new member method isShowingCorrectionPanel().

WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,

for invalid correction panel tag. Replaced -1 with this constant.

(WebEditorClient::dismissCorrectionPanel): Ditto
(WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.

WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
12:40 AM Changeset in webkit [67450] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2010-09-14 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp
​https://bugs.webkit.org/show_bug.cgi?id=45691

Brew MP no longer depends on ICU for internationalization.
Remove TextBreakIteratorInternalICUBrew.cpp.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed.
12:12 AM Changeset in webkit [67449] by rniwa@webkit.org
  • 8 edits
    3 adds in trunk

2010-09-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend run properly
​https://bugs.webkit.org/show_bug.cgi?id=45616

The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.

Test: editing/style/inline-style-extend-run.html

  • editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
  • editing/ApplyStyleCommand.h:

2010-09-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend a run properly
​https://bugs.webkit.org/show_bug.cgi?id=45616

Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.

  • editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
  • editing/execCommand/toggle-style-3-expected.txt: Ditto.
  • editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
  • editing/style/inline-style-extend-run-expected.txt: Added.
  • editing/style/inline-style-extend-run.html: Added.
  • editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
  • editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.

Sep 13, 2010:

11:51 PM Changeset in webkit [67448] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-13 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

Add one #if guard block to fix Qt builds.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorResource.cpp:
11:27 PM Changeset in webkit [67447] by commit-queue@webkit.org
  • 13 edits in trunk

2010-09-13 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/extensions-api-expected.txt: Added a new resource type.

2010-09-13 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
11:17 PM WebKit Team edited by kinuko@chromium.org
(diff)
11:06 PM Changeset in webkit [67446] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/WebKit/chromium

2010-09-13 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Darin Fisher.

Add Chromium API for FileWriter
​https://bugs.webkit.org/show_bug.cgi?id=44360

Build file changes.

  • WebKit.gyp:

Added a way to get a WebFileWriter.

  • public/WebFileSystem.h: (WebKit::WebFileSystem::createFileWriter):

WebFileWriter writes and truncates files.

  • public/WebFileWriter.h: Added.

WebFileWriterClient reports success/failure and progress events.

  • public/WebFileWriterClient.h: Added.

AsyncFileWriterChromium is a connector that links FileWriter and WebFileWriter, FileWriterClient and WebFileWriterClient.

  • src/AsyncFileWriterChromium.cpp: Added.
  • src/AsyncFileWriterChromium.h: Added.
10:26 PM Changeset in webkit [67445] by commit-queue@webkit.org
  • 6 edits in trunk

2010-09-13 W. James MacLean <​wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
​https://bugs.webkit.org/show_bug.cgi?id=44127

Replicates existing functionality, use existing tests.
Adds pixel-readback for GPU composited pages to allow for thumbnailing,
printing and other services to work with GPU rendered pages.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerTextureSize):

2010-09-13 W. James MacLean <​wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
​https://bugs.webkit.org/show_bug.cgi?id=44127

Modified WebViewImpl::paint() to detect non-null canvas pointers when
accelerated compositing is active, and instead fills the pixel buffer
from the GPU framebuffer. Includes re-scaling support when provided
canvas does not match size of current render layer. Limits pixel
readback to rect passed to paint(), clipped by size of rootLayerTexture.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint):
  • src/WebViewImpl.h:
10:05 PM Changeset in webkit [67444] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-09-13 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, build fix for Gtk.

  • bindings/js/JSEntryCustom.cpp:
9:59 PM Changeset in webkit [67443] by kinuko@chromium.org
  • 13 edits
    2 adds in trunk/WebCore

2010-09-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Make FileEntry and DirectoryEntry methods accessible via Entry instance
​https://bugs.webkit.org/show_bug.cgi?id=45553

FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type.

Added custom toJS/toV8 implementation to Entry interface.

No new tests; test will be added later when we have complete implementation for the API.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEntryCustom.cpp: Added. (WebCore::toJS):
  • bindings/v8/custom/V8EntryCustom.cpp: Added. (WebCore::toV8):
  • fileapi/DirectoryEntry.h: Nits fix.
  • fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter.
  • fileapi/Entry.idl: Added CustomToJS attribute.
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter): (WebCore::FileEntry::file):
  • fileapi/FileEntry.h:
  • fileapi/FileEntry.idl:
9:29 PM Changeset in webkit [67442] by dbates@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-09-13 Daniel Bates <​dbates@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=45732

Fix the Qt build. I missed this when reviewing the patch
for Bug #45732.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Change enum value ActiveDOMObject::JavaScriptPaused to ActiveDOMObject::JavaScriptDebuggerPaused
9:18 PM Changeset in webkit [67441] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
​https://bugs.webkit.org/show_bug.cgi?id=45632

Test: editing/execCommand/query-font-size-with-typing-style.html

The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before
retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function.

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):

2010-09-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
​https://bugs.webkit.org/show_bug.cgi?id=45632

Added a test to ensure WebKit does not crash when querying font size even if there is a typing style.

  • editing/execCommand/query-font-size-with-typing-style-expected.txt: Added.
  • editing/execCommand/query-font-size-with-typing-style.html: Added.
9:17 PM Changeset in webkit [67440] by eric.carlson@apple.com
  • 2 edits in trunk/WebKit/qt

2010-09-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Daniel Bates.

[Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter
​https://bugs.webkit.org/show_bug.cgi?id=45732

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Pass ActiveDOMObject::JavaScriptPaused to suspendActiveDOMObjects.
9:08 PM Changeset in webkit [67439] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-13 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Return NULL from getSharedGraphicsContext3D if we couldn't initialize
​https://bugs.webkit.org/show_bug.cgi?id=45731

If we can't create a GraphicsContext3D, return NULL from getSharedGraphicsContext3D rather
than an object with NULL internal pointers. Callers know how to handle a null return value
but not one that has inconsistent internal state.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
9:00 PM Changeset in webkit [67438] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

[BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp
​https://bugs.webkit.org/show_bug.cgi?id=45690

WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already
in namespace WebCore block.

  • platform/brew/SSLKeyGeneratorBrew.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
8:40 PM Changeset in webkit [67437] by weinig@apple.com
  • 6 edits in trunk/WebKit2

URL in address bar doesn't update when navigating to ​http://webkit.org/new-bug when using WebKit2
<rdar://problem/8272775>
​https://bugs.webkit.org/show_bug.cgi?id=45729

Reviewed by Jon Honeycutt.

Pass an updated provisional url while notifying the UIProcess of
didReceiveServerRedirectForProvisionalLoadForFrame.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

8:23 PM Changeset in webkit [67436] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
8:15 PM Changeset in webkit [67435] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Code simplification needed in Atk Wrapper
​https://bugs.webkit.org/show_bug.cgi?id=45687

Use TextIterator::rangeLength() to calculate endOffset

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Don't manually iterate over a artificial new range but just call TextIterator::rangeLength on the range created between the start and end positions.
7:54 PM Changeset in webkit [67434] by weinig@apple.com
  • 2 edits in trunk/WebCore

Clean up xcode project.

Reviewed by Alice Liu.

  • WebCore.xcodeproj/project.pbxproj:
7:48 PM Changeset in webkit [67433] by weinig@apple.com
  • 11 edits
    5 adds in trunk/WebKit2

Threaded mode should work in WebKit2 MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=45727

Reviewed by Jon Honeycutt.

  • Make starting the web thread more like starting a new process (encapsulate it in a thread launcher class).
  • Make the call to didFinishLaunching asynchronous so that WebProcess is fully constructed before it is called.
  • Platform/WorkItem.h:

(MemberFunctionWorkItem1::MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::~MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::execute):
(WorkItem::create):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/ThreadLauncher.cpp: Added.

(WebKit::ThreadLauncher::ThreadLauncher):
(WebKit::ThreadLauncher::launchThread):
(WebKit::ThreadLauncher::didFinishLaunchingThread):
(WebKit::ThreadLauncher::invalidate):

  • UIProcess/Launcher/ThreadLauncher.h: Added.

(WebKit::ThreadLauncher::Client::~Client):
(WebKit::ThreadLauncher::create):
(WebKit::ThreadLauncher::isLaunching):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):

  • UIProcess/Launcher/mac/ThreadLauncherMac.mm: Added.

(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
7:41 PM Changeset in webkit [67432] by eric.carlson@apple.com
  • 20 edits
    2 adds in trunk

2010-09-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
​https://bugs.webkit.org/show_bug.cgi?id=45688

Test: http/tests/media/reload-after-dialog.html

  • bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter.
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter.
  • dom/ActiveDOMObject.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto.
  • dom/ScriptExecutionContext.h:
  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects.
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter.
  • html/HTMLMarqueeElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): Deal with element being suspended. (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document becoming inactive.
  • html/HTMLMediaElement.h:
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects.
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter.
  • page/SuspendableTimer.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::suspend): Ditto.
  • websockets/WebSocket.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::suspend): Ditto.
  • xml/XMLHttpRequest.h:

2010-09-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
​https://bugs.webkit.org/show_bug.cgi?id=45688

  • http/tests/media/reload-after-dialog-expected.txt: Added.
  • http/tests/media/reload-after-dialog.html: Added.
7:15 PM Changeset in webkit [67431] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the mac build.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMousePressEventToSubframe):

7:03 PM Changeset in webkit [67430] by weinig@apple.com
  • 2 edits in trunk/WebCore

Can't scroll on Bugzilla patch review pages on Mac with WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=43555

Reviewed by Anders Carlsson.

<rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks
<rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555)

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Add WebKit2 mode for these functions based on the presence of a platform widget for a
FrameView.

6:38 PM Changeset in webkit [67429] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should log when it's retrying due to checkout out of date error
​https://bugs.webkit.org/show_bug.cgi?id=45725

This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.

In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
6:37 PM Changeset in webkit [67428] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Upload results when cq patch landing fails
​https://bugs.webkit.org/show_bug.cgi?id=45683

Include script errors when CommitQueue._land fails.

  • Scripts/webkitpy/tool/commands/queues.py:
6:10 PM Changeset in webkit [67427] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ViewportArguments.cpp
​https://bugs.webkit.org/show_bug.cgi?id=45678

Use fabs() instead of abs().
This patch also fixes the return value, when
the value is between -1 and 1.

  • dom/ViewportArguments.cpp: (WebCore::findUserScalableValue):
6:02 PM Changeset in webkit [67426] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.

Fix duplicate entries in expectations file; we really need to fix
the checkin trigger to catch these.

  • platform/chromium/test_expectations.txt:
5:56 PM Changeset in webkit [67425] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Add some suppressions back in - it looks like we are probably tripping
over some debug asserts that I need to triage downstream.

  • platform/chromium/test_expectations.txt:
5:29 PM Changeset in webkit [67424] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-13 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Fix build break when enabling HTML5 video support
​https://bugs.webkit.org/show_bug.cgi?id=45674

The correct include variable for LibXml2 in cmake is
LIBXML2_INCLUDE_DIR instead of LIBXML2_INCLUDE_DIRS.

  • CMakeListsEfl.txt:
4:42 PM Changeset in webkit [67423] by Darin Adler
  • 22 edits
    2 adds in trunk

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=45695

  • wtf/text/WTFString.h: Added isAllSpecialCharacters, moved here from the HTML tree builder.

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=45695

  • DOM/WebDOMOperations.mm: (-[DOMDocument webFrame]): Get rid of unneeded local variable. (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.

2010-09-13 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=45695

Added new HTMLParserIdioms source file, with a name inspired by the HTML
specification, which has a section defining things like "space character"
that talks about common parser idioms. These are idioms for the main HTML
parser and for parsers for various microlanguages as well.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added HTMLParserIdioms.
  • css/CSSHelper.h: Fixed indentation and comments here. Point to the new stripLeadingAndTrailingHTMLSpaces function.
  • html/parser/HTMLParserIdioms.cpp: Added.
  • html/parser/HTMLParserIdioms.h: Added.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Updated for name changes.
  • html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h.
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/StepRange.cpp:
  • rendering/RenderSlider.cpp: Updated includes.
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. This is for use on the attribute value before building the URL, not on the URL after building it. I did not add a test case; this is an obscure corner and soon we will be moving to stripLeadingAndTrailingHTMLSpaces anyway.
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Ditto.
4:27 PM Changeset in webkit [67422] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: REGRESSION: WebKit does not report label of web popup buttons
​https://bugs.webkit.org/show_bug.cgi?id=45715

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/popup-button-title.html

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

  • platform/mac/accessibility/popup-button-title-expected.txt: Added.
  • platform/mac/accessibility/popup-button-title.html: Added.
4:14 PM Changeset in webkit [67421] by kinuko@chromium.org
  • 15 edits in trunk/WebCore

2010-09-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Expose Flags constructor if FileSystem API is Enabled
​https://bugs.webkit.org/show_bug.cgi?id=45165

This change also includes:

No new tests; tests will be added when we fully expose the interface.

  • bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor.
  • fileapi/Flags.idl: Changed attribute names to camelCase.
  • page/DOMWindow.idl: Exposed Flags constructor.
  • bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object).
  • bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::create): (WebDOMTestObj::setCreate):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::createAttrGetter): (WebCore::TestObjInternal::createAttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): (WebCore::ConfigureV8TestObjTemplate):
4:10 PM Changeset in webkit [67420] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

"Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode
​https://bugs.webkit.org/show_bug.cgi?id=45647

Implements the notImplemented by doing nothing, which is the proper
behavior according to the spec.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
4:08 PM Changeset in webkit [67419] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

More trivial EOF handling in tree builder
​https://bugs.webkit.org/show_bug.cgi?id=45648

The spec says to treat these modes like the InBodyMode, which is what
this patch does. Doing so is indistinguishable from our current
behavior, which is why we didn't catch this based on tests.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
3:59 PM Changeset in webkit [67418] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-09-13 Chris Guillory <​chris.guillory@google.com>

Reviewed by Chris Fleizach.

WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
​https://bugs.webkit.org/show_bug.cgi?id=45572

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
3:58 PM Changeset in webkit [67417] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of tests that are now passing.

  • platform/chromium/test_expectations.txt:
3:27 PM Changeset in webkit [67416] by dpranke@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] rebaseline two svg tests after r67200
​https://bugs.webkit.org/show_bug.cgi?id=45665

  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium/test_expectations.txt:
3:26 PM Changeset in webkit [67415] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] mark fast/files/read-blob-async.html as CRASH PASS on linux
​https://bugs.webkit.org/show_bug.cgi?id=45672

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [67414] by dpranke@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] fix broken dependency in ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=45684

  • WebKit.gyp:
3:05 PM Changeset in webkit [67413] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-09-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add setting API for enabling page cache
​https://bugs.webkit.org/show_bug.cgi?id=44931

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_page_cache_get): Added. (ewk_view_setting_page_cache_set): Added.
  • ewk/ewk_view.h:
2:39 PM Changeset in webkit [67412] by jamesr@google.com
  • 5 edits in trunk/WebCore

2010-09-13 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

SharedGraphicsContext3D's texture cache holds on to images after free
​https://bugs.webkit.org/show_bug.cgi?id=45706

Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs.
Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know
so that the cache entry and associated texture can also be removed.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::removeTextureFor): (WebCore::SharedGraphicsContext3D::removeTexturesFor): (WebCore::SharedGraphicsContext3D::allContexts):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::~NativeImageSkia):
  • platform/graphics/skia/NativeImageSkia.h:
2:23 PM Changeset in webkit [67411] by weinig@apple.com
  • 2 edits in trunk/WebKit2

didFinishDocumentLoadForFrame() is not being sent by WebKit2
<rdar://problem/8424171>

Reviewed by Anders Carlsson.

Finish wiring up didFinishDocumentLoad to the UIProcess.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

2:08 PM Changeset in webkit [67410] by darin@chromium.org
  • 6 edits in branches/chromium/517

Merge 67401 - 210-09-13 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
​https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimatorWin.cpp:
  • platform/ScrollAnimatorWin.h:

TBR=​darin@chromium.org
Review URL: ​http://codereview.chromium.org/3290027

2:08 PM Changeset in webkit [67409] by enrica@apple.com
  • 1 edit in trunk/WebKit/win/WebFrame.cpp

One more attempt at fixing the Windows build.
Not reviewed.

2:06 PM Changeset in webkit [67408] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
​https://bugs.webkit.org/show_bug.cgi?id=45548

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/element-is-ignored.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityIsIgnored]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isIgnored):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isIgnored):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isIgnored):

LayoutTests:

  • platform/mac/accessibility/element-is-ignored-expected.txt: Added.
  • platform/mac/accessibility/element-is-ignored.html: Added.
1:55 PM Changeset in webkit [67407] by Chris Fleizach
  • 3 edits
    2 adds in trunk

CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663
​https://bugs.webkit.org/show_bug.cgi?id=45697

Reviewed by Darin Adler.

WebCore:

Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may
be in a bad state and accessing internal variables can lead to a crash.

Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

  • platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt: Added.
  • platform/mac/accessibility/updating-attribute-in-table-row-crash.html: Added.
1:49 PM Changeset in webkit [67406] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement EOF handling in TextMode
​https://bugs.webkit.org/show_bug.cgi?id=45644

This patch is actually covered by a bunch of tests. We were just
magically passing the tests before because of some nutty code in
Document.cpp.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
    • This code was masking the notImplemented in the tree builder. I also removed the use of the setting because it wasn't working properly anyway. I'll implement a working version shortly.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
    • Implement per the spec.
1:43 PM Changeset in webkit [67405] by enrica@apple.com
  • 1 edit in trunk/WebKit/win/WebFrame.h

Fixing Windows build.
Not reviewed.

12:40 PM Changeset in webkit [67404] by tony@chromium.org
  • 1 edit
    173 deletes in trunk/LayoutTests

2010-09-13 Tony Chang <​tony@chromium.org>

Unreviewed, removing chromium-linux results that deduplicate-tests says are
unnecessary (mostly due to the checksum computation change last week).

  • platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-image-004-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-003-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Removed.
  • platform/chromium-linux/editing/undo/5378473-expected.checksum: Removed.
  • platform/chromium-linux/editing/undo/5378473-expected.png: Removed.
  • platform/chromium-linux/editing/undo/undo-misspellings-expected.checksum: Removed.
  • platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/attr_dead_doc-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/attr_dead_doc-expected.png: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-1-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-1-expected.png: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-2-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-2-expected.png: Removed.
  • platform/chromium-linux/fast/frames/iframe-text-contents-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/iframe-text-contents-expected.png: Removed.
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.checksum: Removed.
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.checksum: Removed.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/background-generated-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/background-generated-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/content-into-overflow-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/float-new-in-block-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/focus-ring-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/focus-ring-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/outline-inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/outline-inset-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/overflow-into-content-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/selection-clear-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/selection-clear-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-outer-border-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-section-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Removed.
  • platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Removed.
  • platform/chromium-linux/fast/table/giantRowspan-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/giantRowspan-expected.png: Removed.
  • platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Removed.
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Removed.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Removed.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
  • platform/chromium-linux/svg/custom/group-opacity-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/group-opacity-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-container-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-container-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-container2-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-container2-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-style-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-style-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Removed.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Removed.
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/mask-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/pattern-y-offset-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Removed.
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/text-dom-removal-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Removed.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/data-types/001-expected.checksum: Removed.
  • platform/chromium-linux/svg/hixie/data-types/001-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
12:16 PM Changeset in webkit [67403] by enrica@apple.com
  • 39 edits in trunk

Paste should be implemented in WebCore like Copy and Cut for Mac also.
​https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>

WebCore:

Reviewed by Sam Weining.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • editing/Editor.cpp:

(WebCore::Editor::shouldInsertFragment):

  • editing/mac/EditorMac.mm: extended to support Mail specific scenarios.

(WebCore::Editor::pasteWithPasteboard):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added.
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added.
(WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail.

  • loader/FrameLoaderClient.h:
  • page/EditorClient.h:
  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that
doesn't calll back into WebKit.
(WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the
WebCore level.
(WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the
WebCore level.
(WebCore::uniqueURLWithRelativePart): Added.
(WebCore::Pasteboard::documentFragment): Extended to include all the functionality
provided in documentFragmentFromPasteboard in WebHTMLView.mm.

WebKit/chromium:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMETypeAsHTML): Added stub.

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(excludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Added.
(WebEditorClient::setInsertionPasteboard):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
of the editor client.

  • WebView/WebHTMLView.mm: Removed paste method.

WebKit/qt:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebFrame.cpp:

(WebFrame::canShowMIMETypeASHTML): Added.

WebKit/wx:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::canShowMIMETypeAsHTML): Added stub.

  • WebKitSupport/FrameLoaderClientWx.h:

WebKit2:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added.
(WebKit::WebEditorClient::setInsertionPasteboard): Added.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML): Added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:05 PM Changeset in webkit [67402] by alex
  • 2 edits in trunk/WebCore

2010-09-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
​https://bugs.webkit.org/show_bug.cgi?id=44699

Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
11:56 AM Changeset in webkit [67401] by darin@chromium.org
  • 6 edits in trunk

210-09-13 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
​https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimatorWin.cpp:
  • platform/ScrollAnimatorWin.h:
11:45 AM Changeset in webkit [67400] by agl@chromium.org
  • 5 edits in trunk/LayoutTests

2010-09-13 Adam Langley <​agl@chromium.org>

Unreviewed. Layout test re-baseline.

After r66882, complex text word spacing changed due to a bug fix. This
rebaselines the layout test for that case.

​https://bugs.webkit.org/show_bug.cgi?id=45191

  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
  • platform/chromium/test_expectations.txt:
11:41 AM Changeset in webkit [67399] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Kent Tamura.

Move functions of StyledMarkupAccumulator below that of MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=45624

Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions
to below the definitions of MarkupAccumulator's member functions.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): (WebCore::StyledMarkupAccumulator::appendElement): (WebCore::StyledMarkupAccumulator::shouldAnnotate): (WebCore::StyledMarkupAccumulator::wrapWithNode): (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): (WebCore::StyledMarkupAccumulator::takeResults): (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::renderedText): (WebCore::StyledMarkupAccumulator::stringValueForRange): (WebCore::styleFromMatchedRulesForElement): (WebCore::StyledMarkupAccumulator::removeExteriorStyles): (WebCore::needInterchangeNewlineAfter): (WebCore::styleFromMatchedRulesAndInlineDecl): (WebCore::removeEnclosingMailBlockquoteStyle): (WebCore::removeDefaultStyles):
11:34 AM Changeset in webkit [67398] by alex
  • 4 edits in trunk/WebCore

2010-09-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leak in the GraphicsContextCairo drawPathShadow
​https://bugs.webkit.org/show_bug.cgi?id=44959

Fix a leak of the cairo_path.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
  • platform/graphics/cairo/OwnPtrCairo.cpp: (WTF::cairo_path_t):
  • platform/graphics/cairo/OwnPtrCairo.h:
11:28 AM WinCE edited by paroga@paroga.com
(diff)
11:25 AM Changeset in webkit [67397] by mrowe@apple.com
  • 18 edits in trunk

Build fix. Clear the executable bit on files that should not be executable.

11:15 AM WinCE edited by paroga@paroga.com
(diff)
10:40 AM Changeset in webkit [67396] by abarth@webkit.org
  • 4 edits in trunk

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
​https://bugs.webkit.org/show_bug.cgi?id=45645

Test that </sarcasm> works properly.

  • html5lib/resources/webkit02.dat:

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
​https://bugs.webkit.org/show_bug.cgi?id=45645

Umm... Yeah.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
10:21 AM Changeset in webkit [67395] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Darin Adler.

[WML] Fix build breaks when WML is enabled
​https://bugs.webkit.org/show_bug.cgi?id=45628

There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter.
So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent()
was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp

  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
10:00 AM Changeset in webkit [67394] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Rebaseline inspector/extensions-events.html

  • inspector/extensions-events-expected.txt:
9:32 AM Changeset in webkit [67393] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

​https://bugs.webkit.org/show_bug.cgi?id=45677
[WebView canMarkAllTextMatches] can crash if called after [WebView close]

Reviewed by Adam Roben.

<rdar://problem/8404890>

  • WebView/WebView.mm:

(-[WebView canMarkAllTextMatches]):
Return NO immediately if the webview has already been closed. This was an overlooked
case from the fix for 45175.

9:26 AM Changeset in webkit [67392] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
​https://bugs.webkit.org/show_bug.cgi?id=45230

No new tests as this is just a build change.

  • GNUmakefile.am: Move as many sources as possible to the SOURCES primary. Others should be moved over time as we solve issues with them.
9:17 AM Changeset in webkit [67391] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-09-13 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

jscPath() is incorrect in Windows' cmd.exe shell
​https://bugs.webkit.org/show_bug.cgi?id=45651

  • Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
9:03 AM Changeset in webkit [67390] by Chris Fleizach
  • 7 edits
    2 adds in trunk

REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
​https://bugs.webkit.org/show_bug.cgi?id=43807

Reviewed by Darin Adler.

WebCore:

Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types.

Test: platform/mac/accessibility/visible-position-crash-for-text-node.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::textMarkerForPoint):

LayoutTests:

  • platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt: Added.
  • platform/mac/accessibility/visible-position-crash-for-text-node.html: Added.
8:25 AM Changeset in webkit [67389] by Martin Robinson
  • 4 edits in trunk

2010-09-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=43365

  • platform/qt/Skipped: Unskip tests that are now passing.

2010-09-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
​https://bugs.webkit.org/show_bug.cgi?id=43365

Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
8:13 AM Changeset in webkit [67388] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Copy JavaScriptCore's generated sources to the right directory

7:20 AM Changeset in webkit [67387] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-13 Jonathan Dixon <​joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
​https://bugs.webkit.org/show_bug.cgi?id=45313

Remove exceptions for tests that now pass (in DRT and downstream test_shell)

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-09-13 Jonathan Dixon <​joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
​https://bugs.webkit.org/show_bug.cgi?id=45313

Also re-apply rolled out patch ​http://trac.webkit.org/changeset/66886 :-
Add missing virtual destructor to the abstract base class.

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-13 Jonathan Dixon <​joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
​https://bugs.webkit.org/show_bug.cgi?id=45313

Ports over fixes from test shell:

Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html

Also re-apply rolled out patch ​http://trac.webkit.org/changeset/66886 :-
Access to out-of-scope WebGeolocationServiceBridgeImpl
​https://bugs.webkit.org/show_bug.cgi?id=45112

Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably

Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService

  • public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService):
  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed):
  • public/WebGeolocationServiceMock.h:
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached):
  • src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions):
7:17 AM Changeset in webkit [67386] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Skip new debugger test on Qt.

  • platform/qt/Skipped:
6:39 AM Changeset in webkit [67385] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

2010-09-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
​https://bugs.webkit.org/show_bug.cgi?id=45260

Test that scope sections in Scripts panel are expandable and
contain correct data.

  • inspector/debugger-expand-scope-expected.txt: Added.
  • inspector/debugger-expand-scope.html: Added.
  • platform/chromium/inspector/debugger-expand-scope-expected.txt: Added.

2010-09-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
​https://bugs.webkit.org/show_bug.cgi?id=45260

Test: inspector/debugger-expand-scope.html

  • inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. (injectedScriptConstructor.):

2010-09-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
​https://bugs.webkit.org/show_bug.cgi?id=45260

  • src/js/DebuggerScript.js: copy scope variables into a new object, but for global scope object, with statement parameter and catch block exception variable pass the object itself to the injected script.
  • src/js/Tests.js: moved testExpandScope to LayoutTests
6:03 AM Changeset in webkit [67384] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] add viewport meta tag tests to expectations
​https://bugs.webkit.org/show_bug.cgi?id=45655

  • platform/chromium/test_expectations.txt:
5:29 AM Changeset in webkit [67383] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] ATs should be able to select/unselect text
​https://bugs.webkit.org/show_bug.cgi?id=25673

Implement AtkText's setSelection and removeSelection functions

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange): Moved some GTK specific code from a ifdef-endif region to AccessibilityObjectAtk.cpp
  • accessibility/AccessibilityObject.h:
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::getLengthForTextRange): New.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_remove_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_caret_offset): Changed to directly use visiblePositionRangeForRange now that there's no longer a problem with that, as it was in the past (only worked for text controls).

2010-09-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide unit tests for AtkText's text selection functions
​https://bugs.webkit.org/show_bug.cgi?id=43919

New tests to check getting, setting and removing text selections

  • tests/testatk.c: (testWekitAtkTextSelections): New unit tests to check all the text selection related functions altogether through a single test function. (main):

Make sure that code dependant on getting information from the
clipboard gets executed only when there's a GDK window associated
to the webview widget, as that's not the case when executing the
unit tests (the wedbview is not inside of any toplevel window) and
will make the tests crash if not taken into account.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):
5:09 AM Changeset in webkit [67382] by morrita@google.com
  • 2 edits
    10 adds in trunk/LayoutTests

2010-09-13 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][Test] custom-scrollbar-with-incomplete-style.html need expectation files.
​https://bugs.webkit.org/show_bug.cgi?id=45646

Added missing expectations.

  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:06 AM Changeset in webkit [67381] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-13 MORITA Hajime <​morrita@google.com>

Reviewed by Dirk Schulze.

[chromium] svg/filters/filter-empty-g.svg crashes in linux/mac debug after r63530
​https://bugs.webkit.org/show_bug.cgi?id=42486

Removed skip line.
This looks fixed with a fix for ​http://webkit.org/b/41175.

  • platform/chromium/test_expectations.txt:
4:35 AM Changeset in webkit [67380] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2010-09-13 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed.

[Qt] Skip three viewport meta tag tests that fail on the bot.

  • platform/qt/Skipped:
4:19 AM Changeset in webkit [67379] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-09-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] build-webkit: Add --v8 option to build against V8

Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.

  • Scripts/build-webkit:
4:05 AM Changeset in webkit [67378] by hans@chromium.org
  • 5 edits in trunk

2010-09-13 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
​https://bugs.webkit.org/show_bug.cgi?id=45650

Since the virtual member functions of WebDeviceOrientationClientMock
are not exported from the DLL, construction of the object must be done inside
the DLL, or else the linker will complain (because the vtable cannot
be set up). Clients should use the create() member function, and the constructor
will be made private in a subsequent patch.

  • public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
  • src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::create):

2010-09-13 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
​https://bugs.webkit.org/show_bug.cgi?id=45650

Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.

This should fix the linker errors for the multi-DLL Chromium DRT build.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
3:58 AM Changeset in webkit [67377] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] update test expectations for tests that pass after rolling out r67328
​https://bugs.webkit.org/show_bug.cgi?id=45642

  • platform/chromium/test_expectations.txt:
3:37 AM Changeset in webkit [67376] by kenneth@webkit.org
  • 20 edits
    229 adds in trunk

WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

​http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
​https://bugs.webkit.org/show_bug.cgi?id=44201

Tests: fast/viewport/viewport-1.html

fast/viewport/viewport-10.html
fast/viewport/viewport-100.html
fast/viewport/viewport-101.html
fast/viewport/viewport-102.html
fast/viewport/viewport-103.html
fast/viewport/viewport-104.html
fast/viewport/viewport-105.html
fast/viewport/viewport-106.html
fast/viewport/viewport-107.html
fast/viewport/viewport-108.html
fast/viewport/viewport-109.html
fast/viewport/viewport-11.html
fast/viewport/viewport-110.html
fast/viewport/viewport-111.html
fast/viewport/viewport-112.html
fast/viewport/viewport-113.html
fast/viewport/viewport-114.html
fast/viewport/viewport-115.html
fast/viewport/viewport-116.html
fast/viewport/viewport-117.html
fast/viewport/viewport-118.html
fast/viewport/viewport-119.html
fast/viewport/viewport-12.html
fast/viewport/viewport-120.html
fast/viewport/viewport-121.html
fast/viewport/viewport-122.html
fast/viewport/viewport-123.html
fast/viewport/viewport-124.html
fast/viewport/viewport-125.html
fast/viewport/viewport-126.html
fast/viewport/viewport-127.html
fast/viewport/viewport-13.html
fast/viewport/viewport-14.html
fast/viewport/viewport-15.html
fast/viewport/viewport-16.html
fast/viewport/viewport-17.html
fast/viewport/viewport-18.html
fast/viewport/viewport-19.html
fast/viewport/viewport-2.html
fast/viewport/viewport-20.html
fast/viewport/viewport-21.html
fast/viewport/viewport-22.html
fast/viewport/viewport-23.html
fast/viewport/viewport-24.html
fast/viewport/viewport-25.html
fast/viewport/viewport-26.html
fast/viewport/viewport-27.html
fast/viewport/viewport-28.html
fast/viewport/viewport-29.html
fast/viewport/viewport-3.html
fast/viewport/viewport-30.html
fast/viewport/viewport-31.html
fast/viewport/viewport-32.html
fast/viewport/viewport-33.html
fast/viewport/viewport-34.html
fast/viewport/viewport-35.html
fast/viewport/viewport-36.html
fast/viewport/viewport-37.html
fast/viewport/viewport-38.html
fast/viewport/viewport-39.html
fast/viewport/viewport-4.html
fast/viewport/viewport-40.html
fast/viewport/viewport-41.html
fast/viewport/viewport-42.html
fast/viewport/viewport-43.html
fast/viewport/viewport-44.html
fast/viewport/viewport-45.html
fast/viewport/viewport-46.html
fast/viewport/viewport-47.html
fast/viewport/viewport-48.html
fast/viewport/viewport-49.html
fast/viewport/viewport-5.html
fast/viewport/viewport-50.html
fast/viewport/viewport-51.html
fast/viewport/viewport-52.html
fast/viewport/viewport-53.html
fast/viewport/viewport-54.html
fast/viewport/viewport-55.html
fast/viewport/viewport-56.html
fast/viewport/viewport-57.html
fast/viewport/viewport-58.html
fast/viewport/viewport-59.html
fast/viewport/viewport-6.html
fast/viewport/viewport-60.html
fast/viewport/viewport-61.html
fast/viewport/viewport-62.html
fast/viewport/viewport-63.html
fast/viewport/viewport-64.html
fast/viewport/viewport-65.html
fast/viewport/viewport-66.html
fast/viewport/viewport-67.html
fast/viewport/viewport-68.html
fast/viewport/viewport-69.html
fast/viewport/viewport-7.html
fast/viewport/viewport-70.html
fast/viewport/viewport-71.html
fast/viewport/viewport-72.html
fast/viewport/viewport-73.html
fast/viewport/viewport-74.html
fast/viewport/viewport-75.html
fast/viewport/viewport-76.html
fast/viewport/viewport-77.html
fast/viewport/viewport-78.html
fast/viewport/viewport-79.html
fast/viewport/viewport-8.html
fast/viewport/viewport-80.html
fast/viewport/viewport-81.html
fast/viewport/viewport-82.html
fast/viewport/viewport-83.html
fast/viewport/viewport-84.html
fast/viewport/viewport-85.html
fast/viewport/viewport-86.html
fast/viewport/viewport-87.html
fast/viewport/viewport-88.html
fast/viewport/viewport-9.html
fast/viewport/viewport-90.html

  • dom/ViewportArguments.cpp:

(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):

WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:

Reviewed by Antti Koivisto.

​http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
​https://bugs.webkit.org/show_bug.cgi?id=44201

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):

  • Api/qwebpage.cpp:

(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:

(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::didReceiveViewportArguments):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):

WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:

Reviewed by Antti Koivisto.

​http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
​https://bugs.webkit.org/show_bug.cgi?id=44201

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::dumpConfigurationForViewport):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

  • fast/viewport/viewport-1-expected.txt: Added.
  • fast/viewport/viewport-1.html: Added.
  • fast/viewport/viewport-10-expected.txt: Added.
  • fast/viewport/viewport-10.html: Added.
  • fast/viewport/viewport-100-expected.txt: Added.
  • fast/viewport/viewport-100.html: Added.
  • fast/viewport/viewport-101-expected.txt: Added.
  • fast/viewport/viewport-101.html: Added.
  • fast/viewport/viewport-102-expected.txt: Added.
  • fast/viewport/viewport-102.html: Added.
  • fast/viewport/viewport-103-expected.txt: Added.
  • fast/viewport/viewport-103.html: Added.
  • fast/viewport/viewport-104-expected.txt: Added.
  • fast/viewport/viewport-104.html: Added.
  • fast/viewport/viewport-105-expected.txt: Added.
  • fast/viewport/viewport-105.html: Added.
  • fast/viewport/viewport-106-expected.txt: Added.
  • fast/viewport/viewport-106.html: Added.
  • fast/viewport/viewport-107-expected.txt: Added.
  • fast/viewport/viewport-107.html: Added.
  • fast/viewport/viewport-108-expected.txt: Added.
  • fast/viewport/viewport-108.html: Added.
  • fast/viewport/viewport-109-expected.txt: Added.
  • fast/viewport/viewport-109.html: Added.
  • fast/viewport/viewport-11-expected.txt: Added.
  • fast/viewport/viewport-11.html: Added.
  • fast/viewport/viewport-110-expected.txt: Added.
  • fast/viewport/viewport-110.html: Added.
  • fast/viewport/viewport-111-expected.txt: Added.
  • fast/viewport/viewport-111.html: Added.
  • fast/viewport/viewport-112-expected.txt: Added.
  • fast/viewport/viewport-112.html: Added.
  • fast/viewport/viewport-113-expected.txt: Added.
  • fast/viewport/viewport-113.html: Added.
  • fast/viewport/viewport-114-expected.txt: Added.
  • fast/viewport/viewport-114.html: Added.
  • fast/viewport/viewport-115-expected.txt: Added.
  • fast/viewport/viewport-115.html: Added.
  • fast/viewport/viewport-116-expected.txt: Added.
  • fast/viewport/viewport-116.html: Added.
  • fast/viewport/viewport-117-expected.txt: Added.
  • fast/viewport/viewport-117.html: Added.
  • fast/viewport/viewport-118-expected.txt: Added.
  • fast/viewport/viewport-118.html: Added.
  • fast/viewport/viewport-119-expected.txt: Added.
  • fast/viewport/viewport-119.html: Added.
  • fast/viewport/viewport-12-expected.txt: Added.
  • fast/viewport/viewport-12.html: Added.
  • fast/viewport/viewport-120-expected.txt: Added.
  • fast/viewport/viewport-120.html: Added.
  • fast/viewport/viewport-121-expected.txt: Added.
  • fast/viewport/viewport-121.html: Added.
  • fast/viewport/viewport-122-expected.txt: Added.
  • fast/viewport/viewport-122.html: Added.
  • fast/viewport/viewport-123-expected.txt: Added.
  • fast/viewport/viewport-123.html: Added.
  • fast/viewport/viewport-124-expected.txt: Added.
  • fast/viewport/viewport-124.html: Added.
  • fast/viewport/viewport-125-expected.txt: Added.
  • fast/viewport/viewport-125.html: Added.
  • fast/viewport/viewport-126.html: Added.
  • fast/viewport/viewport-127.html: Added.
  • fast/viewport/viewport-13-expected.txt: Added.
  • fast/viewport/viewport-13.html: Added.
  • fast/viewport/viewport-14-expected.txt: Added.
  • fast/viewport/viewport-14.html: Added.
  • fast/viewport/viewport-15-expected.txt: Added.
  • fast/viewport/viewport-15.html: Added.
  • fast/viewport/viewport-16-expected.txt: Added.
  • fast/viewport/viewport-16.html: Added.
  • fast/viewport/viewport-17-expected.txt: Added.
  • fast/viewport/viewport-17.html: Added.
  • fast/viewport/viewport-18-expected.txt: Added.
  • fast/viewport/viewport-18.html: Added.
  • fast/viewport/viewport-19-expected.txt: Added.
  • fast/viewport/viewport-19.html: Added.
  • fast/viewport/viewport-2-expected.txt: Added.
  • fast/viewport/viewport-2.html: Added.
  • fast/viewport/viewport-20-expected.txt: Added.
  • fast/viewport/viewport-20.html: Added.
  • fast/viewport/viewport-21-expected.txt: Added.
  • fast/viewport/viewport-21.html: Added.
  • fast/viewport/viewport-22-expected.txt: Added.
  • fast/viewport/viewport-22.html: Added.
  • fast/viewport/viewport-23-expected.txt: Added.
  • fast/viewport/viewport-23.html: Added.
  • fast/viewport/viewport-24-expected.txt: Added.
  • fast/viewport/viewport-24.html: Added.
  • fast/viewport/viewport-25-expected.txt: Added.
  • fast/viewport/viewport-25.html: Added.
  • fast/viewport/viewport-26-expected.txt: Added.
  • fast/viewport/viewport-26.html: Added.
  • fast/viewport/viewport-27-expected.txt: Added.
  • fast/viewport/viewport-27.html: Added.
  • fast/viewport/viewport-28-expected.txt: Added.
  • fast/viewport/viewport-28.html: Added.
  • fast/viewport/viewport-29-expected.txt: Added.
  • fast/viewport/viewport-29.html: Added.
  • fast/viewport/viewport-3-expected.txt: Added.
  • fast/viewport/viewport-3.html: Added.
  • fast/viewport/viewport-30-expected.txt: Added.
  • fast/viewport/viewport-30.html: Added.
  • fast/viewport/viewport-31-expected.txt: Added.
  • fast/viewport/viewport-31.html: Added.
  • fast/viewport/viewport-32-expected.txt: Added.
  • fast/viewport/viewport-32.html: Added.
  • fast/viewport/viewport-33-expected.txt: Added.
  • fast/viewport/viewport-33.html: Added.
  • fast/viewport/viewport-34-expected.txt: Added.
  • fast/viewport/viewport-34.html: Added.
  • fast/viewport/viewport-35-expected.txt: Added.
  • fast/viewport/viewport-35.html: Added.
  • fast/viewport/viewport-36-expected.txt: Added.
  • fast/viewport/viewport-36.html: Added.
  • fast/viewport/viewport-37-expected.txt: Added.
  • fast/viewport/viewport-37.html: Added.
  • fast/viewport/viewport-38-expected.txt: Added.
  • fast/viewport/viewport-38.html: Added.
  • fast/viewport/viewport-39-expected.txt: Added.
  • fast/viewport/viewport-39.html: Added.
  • fast/viewport/viewport-4-expected.txt: Added.
  • fast/viewport/viewport-4.html: Added.
  • fast/viewport/viewport-40-expected.txt: Added.
  • fast/viewport/viewport-40.html: Added.
  • fast/viewport/viewport-41-expected.txt: Added.
  • fast/viewport/viewport-41.html: Added.
  • fast/viewport/viewport-42-expected.txt: Added.
  • fast/viewport/viewport-42.html: Added.
  • fast/viewport/viewport-43-expected.txt: Added.
  • fast/viewport/viewport-43.html: Added.
  • fast/viewport/viewport-44-expected.txt: Added.
  • fast/viewport/viewport-44.html: Added.
  • fast/viewport/viewport-45-expected.txt: Added.
  • fast/viewport/viewport-45.html: Added.
  • fast/viewport/viewport-46-expected.txt: Added.
  • fast/viewport/viewport-46.html: Added.
  • fast/viewport/viewport-47-expected.txt: Added.
  • fast/viewport/viewport-47.html: Added.
  • fast/viewport/viewport-48-expected.txt: Added.
  • fast/viewport/viewport-48.html: Added.
  • fast/viewport/viewport-49-expected.txt: Added.
  • fast/viewport/viewport-49.html: Added.
  • fast/viewport/viewport-5-expected.txt: Added.
  • fast/viewport/viewport-5.html: Added.
  • fast/viewport/viewport-50-expected.txt: Added.
  • fast/viewport/viewport-50.html: Added.
  • fast/viewport/viewport-51-expected.txt: Added.
  • fast/viewport/viewport-51.html: Added.
  • fast/viewport/viewport-52-expected.txt: Added.
  • fast/viewport/viewport-52.html: Added.
  • fast/viewport/viewport-53-expected.txt: Added.
  • fast/viewport/viewport-53.html: Added.
  • fast/viewport/viewport-54-expected.txt: Added.
  • fast/viewport/viewport-54.html: Added.
  • fast/viewport/viewport-55-expected.txt: Added.
  • fast/viewport/viewport-55.html: Added.
  • fast/viewport/viewport-56-expected.txt: Added.
  • fast/viewport/viewport-56.html: Added.
  • fast/viewport/viewport-57-expected.txt: Added.
  • fast/viewport/viewport-57.html: Added.
  • fast/viewport/viewport-58-expected.txt: Added.
  • fast/viewport/viewport-58.html: Added.
  • fast/viewport/viewport-59-expected.txt: Added.
  • fast/viewport/viewport-59.html: Added.
  • fast/viewport/viewport-6-expected.txt: Added.
  • fast/viewport/viewport-6.html: Added.
  • fast/viewport/viewport-60-expected.txt: Added.
  • fast/viewport/viewport-60.html: Added.
  • fast/viewport/viewport-61-expected.txt: Added.
  • fast/viewport/viewport-61.html: Added.
  • fast/viewport/viewport-62-expected.txt: Added.
  • fast/viewport/viewport-62.html: Added.
  • fast/viewport/viewport-63-expected.txt: Added.
  • fast/viewport/viewport-63.html: Added.
  • fast/viewport/viewport-64-expected.txt: Added.
  • fast/viewport/viewport-64.html: Added.
  • fast/viewport/viewport-65.html: Added.
  • fast/viewport/viewport-66-expected.txt: Added.
  • fast/viewport/viewport-66.html: Added.
  • fast/viewport/viewport-67-expected.txt: Added.
  • fast/viewport/viewport-67.html: Added.
  • fast/viewport/viewport-68-expected.txt: Added.
  • fast/viewport/viewport-68.html: Added.
  • fast/viewport/viewport-69-expected.txt: Added.
  • fast/viewport/viewport-69.html: Added.
  • fast/viewport/viewport-7-expected.txt: Added.
  • fast/viewport/viewport-7.html: Added.
  • fast/viewport/viewport-70-expected.txt: Added.
  • fast/viewport/viewport-70.html: Added.
  • fast/viewport/viewport-71-expected.txt: Added.
  • fast/viewport/viewport-71.html: Added.
  • fast/viewport/viewport-72-expected.txt: Added.
  • fast/viewport/viewport-72.html: Added.
  • fast/viewport/viewport-73-expected.txt: Added.
  • fast/viewport/viewport-73.html: Added.
  • fast/viewport/viewport-74-expected.txt: Added.
  • fast/viewport/viewport-74.html: Added.
  • fast/viewport/viewport-75-expected.txt: Added.
  • fast/viewport/viewport-75.html: Added.
  • fast/viewport/viewport-76-expected.txt: Added.
  • fast/viewport/viewport-76.html: Added.
  • fast/viewport/viewport-77-expected.txt: Added.
  • fast/viewport/viewport-77.html: Added.
  • fast/viewport/viewport-78-expected.txt: Added.
  • fast/viewport/viewport-78.html: Added.
  • fast/viewport/viewport-79-expected.txt: Added.
  • fast/viewport/viewport-79.html: Added.
  • fast/viewport/viewport-8-expected.txt: Added.
  • fast/viewport/viewport-8.html: Added.
  • fast/viewport/viewport-80-expected.txt: Added.
  • fast/viewport/viewport-80.html: Added.
  • fast/viewport/viewport-81-expected.txt: Added.
  • fast/viewport/viewport-81.html: Added.
  • fast/viewport/viewport-82.html: Added.
  • fast/viewport/viewport-83-expected.txt: Added.
  • fast/viewport/viewport-83.html: Added.
  • fast/viewport/viewport-84.html: Added.
  • fast/viewport/viewport-85-expected.txt: Added.
  • fast/viewport/viewport-85.html: Added.
  • fast/viewport/viewport-86-expected.txt: Added.
  • fast/viewport/viewport-86.html: Added.
  • fast/viewport/viewport-87.html: Added.
  • fast/viewport/viewport-88-expected.txt: Added.
  • fast/viewport/viewport-88.html: Added.
  • fast/viewport/viewport-9-expected.txt: Added.
  • fast/viewport/viewport-9.html: Added.
  • fast/viewport/viewport-90-expected.txt: Added.
  • fast/viewport/viewport-90.html: Added.
  • platform/gtk/Skipped: Skip tests due to missing DRT support.
  • platform/mac/Skipped: Skip tests due to missing DRT support.
  • platform/win/Skipped: Skip tests due to missing DRT support.
  • platform/qt/Skipped: Skip failing tests.
3:15 AM Changeset in webkit [67375] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-13 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't add empty strings to list of supported image MIME types
​https://bugs.webkit.org/show_bug.cgi?id=45643

After <​http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
returns an empty string instead of "application/octet-stream" for unsupported
extensions. Don't add these to the list of supported types, and clean out
the logic that removed "application/octet-stream" from supported types.

Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
a HashSet<String>.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
3:12 AM Changeset in webkit [67374] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Re-skip some layout tests that fail on the bots but not on my system
​https://bugs.webkit.org/show_bug.cgi?id=45626

  • platform/mac-wk2/Skipped:
2:50 AM Changeset in webkit [67373] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Attempted Qt build fix.

  • html/parser/HTMLElementStack.cpp:
2:19 AM Changeset in webkit [67372] by abarth@webkit.org
  • 6 edits in trunk

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
​https://bugs.webkit.org/show_bug.cgi?id=45636

Add some tests of breaking out of foreign content.

  • html5lib/resources/webkit01.dat:

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
​https://bugs.webkit.org/show_bug.cgi?id=45636

Now breaking out of foreign content doesn't always bring you back to
HTML. If you have a foreign content element that can contain HTML, you
just get brought back to that element.

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
  • html/parser/HTMLElementStack.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndOfFile):
1:58 AM Changeset in webkit [67371] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-13 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't call _msize
​https://bugs.webkit.org/show_bug.cgi?id=45556

Because Brew MP uses its own memory allocator, it is not correct to use
_msize in fastMallocSize. Add !PLATFORM(BREWMP) guard.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSize):
1:39 AM Changeset in webkit [67370] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Convert notImplemented() to ASSERT_NOT_REACHED
​https://bugs.webkit.org/show_bug.cgi?id=45639

The reason we never implemented this state is because it's not actually
reachable.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
1:20 AM Changeset in webkit [67369] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ScrollAnimatorWin
​https://bugs.webkit.org/show_bug.cgi?id=45595

Use fabs() instead of abs().

  • platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::animateScroll):
1:03 AM Changeset in webkit [67368] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-13 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

Add FrameNetworkingContextWinCE
​https://bugs.webkit.org/show_bug.cgi?id=45474

  • WebCoreSupport/FrameNetworkingContextWinCE.cpp: Added. (WebKit::FrameNetworkingContextWinCE::FrameNetworkingContextWinCE): (WebKit::FrameNetworkingContextWinCE::userAgent): (WebKit::FrameNetworkingContextWinCE::referrer):
  • WebCoreSupport/FrameNetworkingContextWinCE.h: Added. (WebKit::FrameNetworkingContextWinCE::create):
12:22 AM Changeset in webkit [67367] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove fixed FIXME
​https://bugs.webkit.org/show_bug.cgi?id=45637

The spec made assertions that were false. Hixie fixed the spec by
removing the assertions. There's no need to keep these FIXMEs in the
code.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
Note: See TracTimeline for information about the timeline view.