Timeline
Nov 1, 2010:
- 11:34 PM Changeset in webkit [71102] by
-
- 4 edits in trunk/LayoutTests
2010-11-01 MORITA Hajime <morrita@google.com>
Unreviewed, added skip entries for platforms where spellchecking
is not supported.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:30 PM Changeset in webkit [71101] by
-
- 8 edits3 adds in trunk
2010-11-01 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418
- editing/spelling/script-tests/spelling-attribute-at-child.js: Added.
- editing/spelling/spelling-attribute-at-child-expected.txt: Added.
- editing/spelling/spelling-attribute-at-child.html: Added.
2010-11-01 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418
Changed to check spellcheck availability against a node under the
selection (caret) instead of the focus. For shadow elements, the
check now refers its host node. Note that the original code didn't
care shadows because focus is never set on them.
Test: editing/spelling/spelling-attribute-at-child.html
- dom/Element.h:
- editing/Editor.cpp: (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::isSpellCheckingEnabledFor): (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Now just calling isSpellCheckingEnabledFor() (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/Editor.h:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::isSpellCheckingEnabled): Added.
- rendering/TextControlInnerElements.h:
- 10:09 PM Changeset in webkit [71100] by
-
- 50 edits11 deletes in trunk/LayoutTests
2010-11-01 Adam Barth <abarth@webkit.org>
Update expected results for PNG ICC profile.
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum:
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum:
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Removed.
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum:
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Removed.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Removed.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
- platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Removed.
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
- platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
- platform/chromium-mac/svg/custom/createImageElement-expected.png:
- platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
- platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
- platform/chromium-mac/svg/custom/group-opacity-expected.checksum:
- platform/chromium-mac/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
- platform/chromium-mac/svg/custom/js-update-image-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium/test_expectations.txt:
- 9:34 PM Changeset in webkit [71099] by
-
- 2 edits in trunk/WebCore
2010-11-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] PopupMenuGtk has a very confusing if-else block
https://bugs.webkit.org/show_bug.cgi?id=48816
Small code cleanup for PopupMenuGtk.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
- 9:15 PM Changeset in webkit [71098] by
-
- 7 edits in trunk/WebCore
2010-11-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170
This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.
This is covered by about infinite tests.
- platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- 7:42 PM Changeset in webkit [71097] by
-
- 7 edits1 add in trunk
2010-11-01 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Roben.
Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364
- Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added Added removeIdentifierForRequest.
- Interfaces/WebKit.idl: Added IWebResourceLoadDelegatePrivate2.idl.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transferLoadingResourceFromPage):
2010-11-01 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Roben.
Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364
- DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main): Give each WebView its own ResourceLoadDelegate instance in order to make assertions about resource ids on a particular WebView.
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::identifierForInitialRequest): Always add id to the map. (ResourceLoadDelegate::removeIdentifierForRequest): Added. (ResourceLoadDelegate::willSendRequest): (ResourceLoadDelegate::didReceiveAuthenticationChallenge): (ResourceLoadDelegate::didReceiveResponse): (ResourceLoadDelegate::didFinishLoadingFromDataSource): (ResourceLoadDelegate::didFailLoadingWithError): (ResourceLoadDelegate::descriptionSuitableForTestResult): Replace static descriptionSuitableForTestResult with static member function to access identifier map.
- DumpRenderTree/win/ResourceLoadDelegate.h: (ResourceLoadDelegate::urlMap): Moved within class so that each WebView has its own id map.
- 7:20 PM Changeset in webkit [71096] by
-
- 2 edits in trunk
2010-11-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt][Symbian] QtTestBrowser runs out of memory with most of javascript benchmarks.
https://bugs.webkit.org/show_bug.cgi?id=48730
Increase the maximum heap size on Symbian to 256 MB.
- WebKit.pri:
- 7:10 PM Changeset in webkit [71095] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
Snap chromium checksum for the newly added baseline (added in http://trac.webkit.org/changeset/71088)
- platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
- 6:56 PM Changeset in webkit [71094] by
-
- 5 edits in trunk
2010-11-01 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145
- fast/events/spatial-navigation/snav-multiple-select-expected.txt:
- fast/events/spatial-navigation/snav-multiple-select.html:
2010-11-01 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145
- dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
- 6:54 PM Changeset in webkit [71093] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
Did I run --lint-test-files last time? Probably not.
- platform/chromium/test_expectations.txt:
- 6:44 PM Changeset in webkit [71092] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
- platform/chromium/test_expectations.txt:
- 6:40 PM Changeset in webkit [71091] by
-
- 3 edits in trunk/WebCore
2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71080.
http://trac.webkit.org/changeset/71080
https://bugs.webkit.org/show_bug.cgi?id=48815
This change caused many crashes on the debug bot. (Requested
by mrobinson on #webkit).
- platform/network/soup/SocketStreamHandle.h:
- platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::isActiveHandle): (WebCore::deactivateHandle): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::readBytes): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::connectedCallback): (WebCore::readReadyCallback): (WebCore::writeReadyCallback):
- 6:36 PM Changeset in webkit [71090] by
-
- 4 edits in trunk/WebKit/gtk
2010-11-01 Jennifer Braithwaite <jennb@google.com>
Reviewed by Martin Robinson.
GTK: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48362
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): Assign resource id to current web view and remove from former web view.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_remove_resource): Added.
- 6:15 PM Changeset in webkit [71089] by
-
- 5 edits in trunk/WebKit2
2010-11-01 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
Initial implementation of QWKHistoryItem.
https://bugs.webkit.org/show_bug.cgi?id=48620
The QWkHistoryItem represents one item in the history of QWKPage.
- UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::~QWKHistoryItem): (QWKHistoryItem::title): The page title (QWKHistoryItem::url): The URL of the page. (QWKHistoryItem::originalUrl): The URL used to access the page.
- UIProcess/API/qt/qwkhistory.h:
- UIProcess/API/qt/qwkhistory_p.h:
- WebKit2.pro: Added WKBackForwardListItem.h and WKBackForwardListItem.cpp
- 5:55 PM Changeset in webkit [71088] by
-
- 311 edits310 copies3 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for css/ for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 5:47 PM Changeset in webkit [71087] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
- platform/chromium/test_expectations.txt:
- 5:39 PM Changeset in webkit [71086] by
-
- 1 add in trunk/LayoutTests/platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt
Fix layout tests.
- 5:38 PM Changeset in webkit [71085] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt
Fix layout tests.
- 5:31 PM Changeset in webkit [71084] by
-
- 263 edits262 copies2 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for editing/ for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
Some tests had differences due to spell correction underlining, those
were skipped since it's not clear what the correct dictionary state is.
- 5:17 PM Changeset in webkit [71083] by
-
- 2 edits in trunk/WebKitTools
2010-11-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
remove debug code from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=48800
Remove temporary debug code and make --master-name required
if --test-results-server is set now that all clients set
--master-name.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:17 PM Changeset in webkit [71082] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
Temporarily disable new test added by http://trac.webkit.org/changeset/71066
Need to convert it to dumpAsText().
- platform/chromium/test_expectations.txt:
- 5:12 PM Changeset in webkit [71081] by
-
- 9 edits in trunk/WebKit2
Make NPRemoteObjectMap a ref counted object
https://bugs.webkit.org/show_bug.cgi?id=48808
Reviewed by Oliver Hunt.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::WebProcessConnection):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
(WebKit::WebProcessConnection::npRemoteObjectMap):
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::create):
(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
- Shared/Plugins/NPRemoteObjectMap.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::npRemoteObjectMap):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getWindowScriptNPObject):
- 5:09 PM Changeset in webkit [71080] by
-
- 3 edits in trunk/WebCore
2010-11-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=48805
Track active WebSocket handles via a sequential id. This ensures
that when a handle is reallocated into a recently used segment of
memory, it doesn't trigger a false positive in the code which ensures
the original handle is active.
No new tests. This test should stop crashing on the bots, proving the fix.
- platform/network/soup/SocketStreamHandle.h: (WebCore::SocketStreamHandle::id): Added an m_id member and accessor to SocketStreamHandle.
- platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to SocketStreamHandle*. (WebCore::deactivateHandle): Ditto. (WebCore::activateHandle): Ditto. (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Ditto. (WebCore::SocketStreamHandle::readBytes): Ditto. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto. (WebCore::connectedCallback): Ditto. (WebCore::readReadyCallback): Ditto. (WebCore::writeReadyCallback): Ditto.
- 5:05 PM Changeset in webkit [71079] by
-
- 2 edits in trunk/WebCore
2010-11-01 Kent Tamura <tkent@chromium.org>
Unreviewed. Run sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 5:05 PM Changeset in webkit [71078] by
-
- 2 edits in trunk/WebKitTools
2010-11-01 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
add plugin event logging for linux
https://bugs.webkit.org/show_bug.cgi?id=48779
This is taken from Chromium's fork of the layout test plugin:
http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11): (NPP_HandleEvent):
- 5:00 PM Changeset in webkit [71077] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-01 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Compile TestNetscapePlugin on chromium win
https://bugs.webkit.org/show_bug.cgi?id=48802
It creates npTestNetscapePlugin.dll in the build directory, so
it's not yet loaded by DRT or test_shell.
- WebKit.gyp:
- 5:00 PM Changeset in webkit [71076] by
-
- 1 edit in trunk/WebKit2/ChangeLog
Remove duplicate ChangeLog entry.
- 4:58 PM Changeset in webkit [71075] by
-
- 12 edits4 copies in trunk/WebKit2
Respond to NP_GetProperty by sending a GetProperty message
https://bugs.webkit.org/show_bug.cgi?id=48797
Reviewed by John Sullivan.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new sync message overload.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPIdentifierData.h:
Add NPIdentifierData, a CoreIPC representation of an NPIdentifier.
- Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::getProperty):
Add stub.
- Shared/Plugins/NPObjectMessageReceiver.messages.in:
Add GetProperty.
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::create):
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::initialize):
NPObjectProxy now takes an NPRemoteObjectMap in its create function.
(WebKit::NPObjectProxy::getProperty):
Send a GetProperty message.
(WebKit::NPObjectProxy::NP_GetProperty):
Call getProperty.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Pass the NPRemoteObjectMap.
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
Find the right message receiver and dispatch the message to it.
- Shared/Plugins/NPVariantData.cpp:
- Shared/Plugins/NPVariantData.h:
Add NPVariantData, which will be a CoreIPC representation of an NPVariant.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.
- 4:41 PM Changeset in webkit [71074] by
-
- 3 edits3 adds in trunk
2010-11-01 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Assertion failure in FrameView::layout when clicking on a YouTube video on youtube.com front page
https://bugs.webkit.org/show_bug.cgi?id=44287
When removing subframes, it's possible for layout() to get called on a FrameView
for a Frame that has been removed from the frame tree. This can happen if the parent
document happens to do a layout() while RenderView still has a reference to the widget
for the removed frame; updateWidgetPosition() will try to force a layout() on the
subframe.
Fix by checking that the FrameView's Frame still has a reference to the page before
calling layout() on the subframe.
Test: fast/frames/layout-after-destruction.html
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
- 4:36 PM Changeset in webkit [71073] by
-
- 201 edits200 copies18 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 4:30 PM Changeset in webkit [71072] by
-
- 2 edits in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 4:25 PM Changeset in webkit [71071] by
-
- 7 edits in trunk/WebCore
2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71065.
http://trac.webkit.org/changeset/71065
https://bugs.webkit.org/show_bug.cgi?id=48801
Seem to breake a lot of tests on Chromium bots (Requested by
dimich on #webkit).
- platform/image-decoders/ImageDecoder.cpp:
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/qt/RGBA32BufferQt.cpp:
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
- 4:23 PM Changeset in webkit [71070] by
-
- 4 edits9 adds2 deletes in trunk/LayoutTests
2010-11-01 James Robinson <jamesr@chromium.org>
Update chromium baselines for a few tests.
- platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Added.
- platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
- platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
- platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
- platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png: Added.
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/chromium/test_expectations.txt:
- 4:12 PM Changeset in webkit [71069] by
-
- 2 edits in trunk/WebKit2
Add ArgumentCoder specialization for WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=48796
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentCoders.h:
- 4:01 PM Changeset in webkit [71068] by
-
- 3 edits in trunk/WebKitTools
2010-11-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by James Robinson.
new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
https://bugs.webkit.org/show_bug.cgi?id=48790
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 3:43 PM Changeset in webkit [71067] by
-
- 1 edit in trunk/WebCore/rendering/svg/SVGInlineTextBox.cpp
Fix SVG bustage.
- 3:40 PM Changeset in webkit [71066] by
-
- 3 edits3 adds in trunk
2010-11-01 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785
Test: svg/animations/repeatDur-zero.xhtml
- svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.
2010-11-01 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785
- svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
- 3:33 PM Changeset in webkit [71065] by
-
- 7 edits in trunk/WebCore
2010-10-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170
This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.
This is covered by about infinite tests.
- platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
- 3:27 PM Changeset in webkit [71064] by
-
- 5 edits in trunk/WebKitTools
2010-11-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach check-webkit-style how to accept a list of files to diff on the
command line
https://bugs.webkit.org/show_bug.cgi?id=48784
In a future patch, webkit-patch will use this option to improve
performance. I'm landing this in two pieces to avoid causing a version
skew problem for the style-bot.
- Scripts/check-webkit-style:
- Scripts/webkitpy/style/optparser.py:
- Scripts/webkitpy/style/optparser_unittest.py:
- Scripts/webkitpy/style_references.py:
- 3:20 PM Changeset in webkit [71063] by
-
- 3 edits4 adds2 deletes in trunk/LayoutTests
[Chromium] Unreviewed test rebaseline.
- platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Removed.
- platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:16 PM Changeset in webkit [71062] by
-
- 204 edits202 copies8 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/body-propagation, fast/borders, fast/box-shadow, fast/box-sizing, fast/clip, and fast/compact for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
platform/mac/test_expectations.txt was also modified to remove two
now-passing tests.
- 3:10 PM Changeset in webkit [71061] by
-
- 2 edits in trunk/LayoutTests
2010-11-01 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
Update chromium-gpu test expectations to reflect test_shell
timeouts on ~35 tests.
- platform/chromium-gpu/test_expectations.txt:
- 2:53 PM Changeset in webkit [71060] by
-
- 2 edits in trunk/WebKit2
Fix build.
- WebKit2.xcodeproj/project.pbxproj:
- 2:51 PM Changeset in webkit [71059] by
-
- 11 edits in branches/audio/WebCore
audio branch: bracket some JS and V8 wrappper and Event code with #if ENABLE(WEB_AUDIO)
- 2:30 PM Changeset in webkit [71058] by
-
- 3 edits in trunk/LayoutTests
2010-11-01 Simon Fraser <Simon Fraser>
Fix test failures on Qt by avoiding references to external image files.
- fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
- fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
- 2:29 PM Changeset in webkit [71057] by
-
- 6 edits1 add in trunk/WebKit2
Add NPObjectMessageReceiver.messages.in
https://bugs.webkit.org/show_bug.cgi?id=48782
Reviewed by Adam Roben.
- DerivedSources.make:
Add NPObjectMessageReceiver.
- Platform/CoreIPC/MessageID.h:
Add MessageClassNPObjectMessageReceiver message class.
- Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::deallocate):
Add stubbed out deallocate member function.
- Shared/Plugins/NPObjectMessageReceiver.messages.in: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add NPObjectMessageReceiver.messages.in.
- 2:25 PM Changeset in webkit [71056] by
-
- 203 edits202 copies1 add in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/selectors for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 2:13 PM Changeset in webkit [71055] by
-
- 14 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=48776
Reviewed by Dan Bernstein.
Change isVertical() on InlineBox to isHorizontal() instead. This makes the horizontal code path come
first if you branch on isHorizontal() and makes the code read better (since that's the more common code
path).
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isHorizontal):
(WebCore::InlineBox::setIsHorizontal):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
- rendering/InlineTextBox.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::blockDirectionOverflow):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::hitTest):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):
- 2:10 PM Changeset in webkit [71054] by
-
- 7 edits in trunk/WebKit2
Start stubbing out NPClass functions in NPObjectProxy
https://bugs.webkit.org/show_bug.cgi?id=48778
Reviewed by Adam Roben.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
getOrCreateNPObjectProxy is now createNPObjectProxy.
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::create):
Allocate and initialize an NPObjectProxy object.
(WebKit::NPObjectProxy::NPObjectProxy):
Initialize m_npObjectID to 0.
(WebKit::NPObjectProxy::isNPObjectProxy):
Check the class.
(WebKit::NPObjectProxy::initialize):
Set m_npObjectID.
(WebKit::NPObjectProxy::npClass):
Return the NPClass with all functions filled in.
(WebKit::NPObjectProxy::NP_Allocate):
Create a new NPObjectProxy object.
(WebKit::NPObjectProxy::NP_Deallocate):
Deallocate the NPObjectProxy object.
(WebKit::NPObjectProxy::NP_HasMethod):
(WebKit::NPObjectProxy::NP_Invoke):
(WebKit::NPObjectProxy::NP_InvokeDefault):
(WebKit::NPObjectProxy::NP_HasProperty):
(WebKit::NPObjectProxy::NP_GetProperty):
(WebKit::NPObjectProxy::NP_SetProperty):
(WebKit::NPObjectProxy::NP_RemoveProperty):
(WebKit::NPObjectProxy::NP_Enumerate):
(WebKit::NPObjectProxy::NP_Construct):
Add stubs.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::createNPObjectProxy):
- Shared/Plugins/NPRemoteObjectMap.h:
Rename getOrCreateNPObjectProxy to createNPObjectProxy.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::NP_Allocate):
Remove unused parameter.
- 2:01 PM Changeset in webkit [71053] by
-
- 1 edit4 adds in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
Add baseline for a new test added in http://trac.webkit.org/changeset/71043
- platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
- platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
- 2:00 PM Changeset in webkit [71052] by
-
- 2 edits in trunk/WebKit/gtk
2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Cleanup needed in testatk.c file
https://bugs.webkit.org/show_bug.cgi?id=48759
Cleanup done in testatk.c, mainly addressing the following issues:
- Removed any trace of extra main loops in tests, so now we just spin the original main loop in all of them to get the a11y objects.
- As we no longer use the extra main loops, removed the bail_out function, used along with g_idle_add() to stop those extra loops.
- As we now spin the loop in every test, created a new function waitForAccessibilityObjects() to write the loop just once.
- Fixed name in incorrectly named test testWekitAtkTextSelections.
- Alphabetically sorted the list of includes.
- Renamed all identifiers to camel Case notation.
- Declare variables when needed only (instead of declaring all of them at the beginning of the function).
- Don't declare two variables of the same type in the same line.
- No more short names like 'obj', 'textObj' or 'alloc'. Use names like 'object', 'textObject' and 'allocation' instead.
- Fixed indentation.
- Make sure all comments finish with '.'
- Replace NULL's with 0's.
- tests/testatk.c: (waitForAccessibleObjects): New, manually spins the main context to make sure accessible objects are created before continuing. (testGetTextFunction): Fixed this function to be compliant with the WebKit's coding style. (runGetTextTests): Ditto. (testWebkitAtkGetTextAtOffsetForms): Ditto. (testWebkitAtkGetTextAtOffset): Ditto. (testWebkitAtkGetTextAtOffsetNewlines): Ditto. (testWebkitAtkGetTextAtOffsetTextarea): Ditto. (testWebkitAtkGetTextAtOffsetTextInput): Ditto. (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto. (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto. (testWebkitAtkGetTextInTable): Ditto. (testWebkitAtkGetHeadersInTable): Ditto. (compAtkAttribute): Ditto. (atkAttributeSetAttributeNameHasValue): Ditto. (testWebkitAtkTextAttributes): Ditto. (testWebkitAtkTextSelections): Ditto. (testWebkitAtkGetExtents): Ditto. (testWebkitAtkLayoutAndDataTables): Ditto. (testWebkitAtkLinksWithInlineImages): Ditto. (testWebkitAtkHypertextAndHyperlinks): Ditto. (testWebkitAtkListsOfItems): Ditto. (testWebkitAtkTextChangedNotifications): Ditto. (main): Ditto.
- 1:53 PM UpdatingBugzilla edited by
- (diff)
- 1:47 PM Changeset in webkit [71051] by
-
- 12 edits in trunk/WebKit2
Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps
https://bugs.webkit.org/show_bug.cgi?id=48775
Reviewed by Adam Roben.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
Ask for an NPObjectProxy for the window script NPObject.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::WebProcessConnection):
Initialize m_npRemoteObjectMap.
- Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::create):
Add a create member function that takes an NPObject.
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
Retain the NPObject.
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Release the NPObject.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::generateNPObjectID):
Generate a unique 64-bit NPObject ID.
(WebKit::NPRemoteObjectMap::getOrCreateNPObjectProxy):
Add stub.
(WebKit::NPRemoteObjectMap::registerNPObject):
Create a NPObjectMessageReceiver and add it to the map.
- WebKit2.xcodeproj/project.pbxproj:
Set the correct target for NPRuntime related files.
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
Initialize m_npRemoteObjectMap
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getWindowScriptNPObject):
Ask the real plug-in controller for the window script NPObject and register it.
- 1:44 PM Changeset in webkit [71050] by
-
- 11 edits in trunk/LayoutTests
[Chromium] Unreviewed, update test expectations.
Updated render tree dumps after http://trac.webkit.org/changeset/71043.
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt:
- platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt:
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/chromium-win/fast/blockflow/english-lr-text-expected.txt:
- platform/chromium-win/fast/blockflow/english-rl-text-expected.txt:
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt:
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt:
- 1:39 PM Changeset in webkit [71049] by
-
- 3 edits5 adds in trunk
2010-11-01 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Multiple background properties are not retrievable via DOM method getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23203
Return lists of values from getComputedStyle() for multiple backgrounds,
and multiple masks.
Test: fast/backgrounds/multiple-backgrounds-computed-style.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::fillSizeToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- 1:37 PM Changeset in webkit [71048] by
-
- 5 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48774
minimFontSize preference needs to be exposed in WebKit2
Reviewed by Anders Carlsson.
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setMinimumFontSize):
New function, parallel to existing functions for other preferences.
(WebKit::WebPreferences::minimumFontSize):
Ditto.
- UIProcess/WebPreferences.h:
Declared new function.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMinimumFontSize):
New UI process wrapper for new function.
(WKPreferencesGetMinimumFontSize):
Ditto.
- UIProcess/API/C/WKPreferences.h:
Declared new functions.
- 1:24 PM Changeset in webkit [71047] by
-
- 101 edits100 copies2 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/block/positioning for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 1:20 PM Changeset in webkit [71046] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed update of test expectations.
svg-as-background.html now fails on debug mac 10.5 bots.
- platform/chromium/test_expectations.txt:
- 12:30 PM Changeset in webkit [71045] by
-
- 13 edits1 move1 add1 delete in branches/audio/WebCore
audio branch: changes in preparation for landing in trunk
- change name from Accelerate to VectorMath
- AudioResamplerKernel cleanup
- JSDOMWindowCustom.cpp: guard include and audioContext() method with ENABLE_WEB_AUDIO
- V8Binding.cpp: remove AdjustAmountOfExternalAllocatedMemory() hack
- 12:16 PM Changeset in webkit [71044] by
-
- 7 edits in trunk
Tear down the related WebProcessProxy when a WebContext is deallocated
https://bugs.webkit.org/show_bug.cgi?id=48769
Reviewed by John Sullivan.
WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
Call WebProcessManager::contextWasDestroyed.
(WebKit::WebContext::didNavigateWithNavigationData):
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
It is valid for a frame to have a null page here, if the frame has outlived
its page.
- UIProcess/WebProcessManager.cpp:
(WebKit::WebProcessManager::contextWasDestroyed):
Remove the context from the map.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
It's OK for the connection to be non-null here if the process goes away because
the context has been deallocated.
WebKitTools:
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
We don't support empty URLs anymore, update test to expect a null URL instead.
- 12:07 PM Changeset in webkit [71043] by
-
- 26 edits3 copies8 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48663
Reviewed by Dan Bernstein.
Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.
Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
Patch hit testing to also account for "rt" and "bt" blocks.
WebCore:
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
LayoutTests:
- fast/repaint/inline-horizontal-bt-overflow.html: Added.
- fast/repaint/inline-vertical-lr-overflow.html: Added.
- fast/repaint/inline-vertical-rl-overflow.html: Copied from fast/repaint/inline-vertical-rl-overflow.html.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png.
- 11:53 AM Changeset in webkit [71042] by
-
- 2 edits in trunk/WebKit2
Windows build fix.
- UIProcess/win/WebView.cpp:
- 11:34 AM Changeset in webkit [71041] by
-
- 50 edits8 adds in trunk
<rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
Context menu support for WebKit 2.
Reviewed by Anders Carlsson.
WebCore:
Add a "showContextMenu" call to Chrome/ChromeClient:
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::showContextMenu):
- page/Chrome.cpp:
(WebCore::Chrome::showContextMenu):
- page/Chrome.h:
- page/ChromeClient.h:
Add a "platform description to ContextMenuItem" creator, will be needed by WebKit2
- platform/ContextMenu.h:
- platform/mac/ContextMenuMac.mm:
(WebCore::contextMenuItemVector):
- platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::checked): WebKit2 ports now need this implemented.
Stub these out to keep their WK2 ports building:
- platform/qt/ContextMenuItemQt.cpp:
(WebCore::ContextMenuItem::checked):
- platform/qt/ContextMenuQt.cpp:
(WebCore::contextMenuItemVector):
- platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::checked):
- platform/win/ContextMenuWin.cpp:
(WebCore::contextMenuItemVector):
WebKit/chromium:
- src/ChromeClientImpl.h:
(WebKit::ChromeClientImpl::showContextMenu):
WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::showContextMenu):
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::showContextMenu):
WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.h:
(WebCore::ChromeClientHaiku::showContextMenu):
WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::showContextMenu):
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::showContextMenu):
WebKit/win:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::showContextMenu):
WebKit/wx:
- WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::showContextMenu):
WebKit2:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- Shared/WebContextMenuItem.cpp: Added.
(WebKit::WebContextMenuItem::WebContextMenuItem):
(WebKit::WebContextMenuItem::encode):
(WebKit::WebContextMenuItem::decode):
(WebKit::kitItems):
- Shared/WebContextMenuItem.h: Added.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createContextMenuProxy): Stub to keep the build working.
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebContextMenuProxy.cpp: Added.
(WebKit::WebContextMenuProxy::~WebContextMenuProxy):
(WebKit::WebContextMenuProxy::WebContextMenuProxy):
- UIProcess/WebContextMenuProxy.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu): Shows the menu after receiving the message from the WebProcess.
(WebKit::WebPageProxy::contextMenuItemSelected): Sends info about the selected menu item to the WebProcess
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebContextMenuProxyMac.h: Added.
(WebKit::WebContextMenuProxyMac::create):
- UIProcess/mac/WebContextMenuProxyMac.mm: Added.
(+[WebMenuTarget sharedMenuTarget]):
(-[WebMenuTarget WebKit::]):
(-[WebMenuTarget setMenuProxy:WebKit::]):
(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::createContextMenuProxy): Stub for now.
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::showContextMenu):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Return the WebCore-provided default
menu for now. Embedding app customization will come later (see bug 48720)
- WebProcess/WebPage/WebContextMenu.cpp: Added.
(WebKit::WebContextMenu::WebContextMenu):
(WebKit::WebContextMenu::~WebContextMenu):
(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::itemSelected):
- WebProcess/WebPage/WebContextMenu.h: Added.
(WebKit::WebContextMenu::create):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextMenu):
(WebKit::handleMouseEvent): Pass right mouse presses along to WebCore as both a mouse event and context menu event,
the same way WebKit1 does.
(WebKit::WebPage::didSelectItemFromActiveContextMenu):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 11:30 AM Changeset in webkit [71040] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium build fix.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
- 11:18 AM Changeset in webkit [71039] by
-
- 13 edits2 adds in trunk
2010-11-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
Test: media/video-seek-by-small-increment.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
- platform/graphics/win/QTMovie.h:
2010-11-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
- media/video-seek-by-small-increment-expected.txt: Added.
- media/video-seek-by-small-increment.html: Added.
- platform/qt/Skipped: Skip new test as it fails.
- 11:14 AM Changeset in webkit [71038] by
-
- 2 edits in trunk/WebCore
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium build fix. Adding missing transitive dependency.
- inspector/InspectorResourceAgent.cpp:
- 11:09 AM Changeset in webkit [71037] by
-
- 139 edits138 copies2 adds in trunk/LayoutTests
2010-11-01 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/block/margin-collapse for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
- 11:02 AM Changeset in webkit [71036] by
-
- 4 edits in trunk/WebCore
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Removing references to removed file from project files.
- WebCore.gypi:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- 10:56 AM Changeset in webkit [71035] by
-
- 38 edits4 deletes in trunk
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657
- CMakeLists.txt:
- English.lproj/localizedStrings.js:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- inspector/InjectedScriptHost.cpp:
- inspector/Inspector.idl:
- inspector/InspectorCSSStore.cpp:
- inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorResource.cpp: Removed.
- inspector/InspectorResource.h: Removed.
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setOverrideContent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
- inspector/front-end/Images/resourcesSilhouette.png: Removed.
- inspector/front-end/Resource.js:
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.getContent):
- inspector/front-end/ResourcesPanel.js: Removed.
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.get toolbarItemLabel):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.get networkResources): (WebInspector.forAllResources): (WebInspector.resourceForURL): (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.openResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.reset): (WebInspector._choosePanelToShowSourceLine):
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
- src/WebDevToolsAgentImpl.h:
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657
- http/tests/inspector/inspector-test2.js:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters.html:
- inspector/audits-panel-functional.html:
- inspector/extensions-test.js:
- inspector/report-protocol-errors-expected.txt:
- inspector/report-protocol-errors.html:
- inspector/styles-source-offsets.html:
- 10:35 AM Changeset in webkit [71034] by
-
- 5 edits in trunk/WebCore
2010-10-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Fix enum naming style violation in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=48441
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- 9:51 AM Changeset in webkit [71033] by
-
- 6 edits in trunk/WebKit2
Cancel main resource loads after we hand them off to the media engine
This is the WebKit2 equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.
Fixes <http://webkit.org/b/48561> <rdar://problem/8606679> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit2
Reviewed by Eric Carlson.
- WebProcess/WebCoreSupport/WebErrors.h: Added pluginWillHandleLoadError.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].
(WebKit::WebFrameLoaderClient::pluginWillHandleLoadError): Call through to WebErrors.
(WebKit::WebFrameLoaderClient::shouldFallBack): Implemented. We fall
back for all errors except when the load was cancelled or we handed it
off to the media engine or a plugin.
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(WebKit::pluginWillHandleLoadError): Implemented.
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
(WebKit::pluginWillHandleLoadError): Stubbed out.
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::pluginWillHandleLoadError): Implemented.
- 9:50 AM Changeset in webkit [71032] by
-
- 3 edits in trunk/WebKit/win
Cancel main resource loads after we hand them off to the media engine
This is the Windows equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.
Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit1 on Windows
Reviewed by Dan Bernstein.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].
- WebFrame.cpp:
(WebFrame::shouldFallBack): Don't fall back when handing the resource
load off to the media engine or a plugin. Added error domain checking
so that we don't rely on error codes being unique.
- 9:00 AM Changeset in webkit [71031] by
-
- 4 edits in trunk
2010-11-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737
Include a content-type meta tag prefix on all clipboard markup. Programs like
Thunderbird expect this meta tag and will not paste anything unless it is there.
This is covered by changes to WebKit/gtk/tests/testcopyandpaste.c. This patch was
written in such a way as to not affect layout test results, otherwise there
would be many new GTK+-specific results that say "FAIL").
- platform/gtk/PasteboardHelper.cpp: (WebCore::removeMarkupPrefix): Added this helper which removes the prefix when found on incoming clipboard and drag-and-drop text. (WebCore::PasteboardHelper::getClipboardContents): Remove the meta tag prefix. (WebCore::PasteboardHelper::fillSelectionData): Add the meta tag prefix. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Remove the meta tag prefix
2010-11-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737
Added a test verifying that the meta tag prefix on markup data exists.
- tests/testcopyandpaste.c: (load_status_cb): Add a check for the meta tag prefix.
- 8:50 AM Changeset in webkit [71030] by
-
- 2 edits in trunk/WebKitTools
2010-11-01 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Andreas Kling.
Fix warning when compiling the chromium port of DumpRenderShell
with clang.
https://bugs.webkit.org/show_bug.cgi?id=48414
- DumpRenderTree/chromium/TestShell.h: (TestShell::javaScriptFlagsForLoad):
- 8:33 AM Changeset in webkit [71029] by
-
- 3 edits in trunk/WebKit2
2010-11-01 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Cleanup viewportAttributesForSize API
Change QSize argument to a const QSize&.
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
- UIProcess/API/qt/qwkpage.h:
- 8:27 AM Changeset in webkit [71028] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r71004
https://bugs.webkit.org/show_bug.cgi?id=48758
- platform/qt/Skipped: fast/dom/nodesFromRect-basic.html added until fix.
- 8:23 AM Changeset in webkit [71027] by
-
- 3 edits2 adds in trunk
2010-11-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741
- svg/custom/use-on-use-with-child-and-empty-target-expected.txt: Added.
- svg/custom/use-on-use-with-child-and-empty-target.svg: Added.
2010-11-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741
Test: svg/custom/use-on-use-with-child-and-empty-target.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
- 8:11 AM BuildingOnWindows edited by
- Added some more DLLs that need to be rebased (diff)
- 8:08 AM BuildingOnWindows edited by
- Update instructions for rebasing libphp4.dll (diff)
- 8:05 AM Changeset in webkit [71026] by
-
- 5 edits2 adds in trunk
2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785
Implemented the AtkHyperlink/AtkHypertext stuff in the GTK port.
Even thought these kind of tasks are usually about implementing an
interface, in this case it was needed to implement some more
things due to the fact that AtkHyperlink is neither an interface
nor an AtkObject, but just an abstract class child of GObject that
needs to be redefined in a specific subclass of that one. On top
of that, it was needed to implement the AtkAction interface as
well for that new class, so exposed hyperlinks can work as
expected with Assistive Technologies based on ATK.
Furthermore, as there's no mechanism to get an instance of that
AtkHyperlink other than doing it through an AtkObject implementing
the AtkHypertext interface, it was needed to also add the code to
implement that one, so it makes possible to ask for the
'hyperlinks' under an 'hypertext' accessible object.
Finally, to complete the implementation of all this stuff and make
it all consistent, it was needed as well to implement the
AtkHyperlinkImpl interface (providing just one method only) so
that allows retrieving the AtkHyperlink object associated to an
AtkObject implementing such an interface.
- GNUmakefile.am: Add the new WebKitAccessibleHyperlink.[h|cpp] files to the sources list for the GTK port.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (core): New function to return the core accessibility object related to an AtkObject implementing the AtkHypertext interface. (webkitAccessibleHypertextGetLink): New, part of the implementation of the AtkHypertext interface. (webkitAccessibleHypertextGetNLinks): New, likewise. (webkitAccessibleHypertextGetLinkIndex): New, likewise. (atkHypertextInterfaceInit): New, initialize the AtkHypertext interface. (webkitAccessibleHyperlinkImplGetHyperlink): New, part of the implementation of the AtkHyperlinkImpl interface. (atkHyperlinkImplInterfaceInit): New, initialize the AtkHyperlinkImpl interface. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_HYPERTEXT and ATK_TYPE_HYPERLINK_IMPL to the list of recognized types. (getInterfaceMaskFromObject): Decide when it's needed to add WAI_HYPERTEXT and WAI_HYPERLINK to the interface mask.
- accessibility/gtk/WebKitAccessibleHyperlink.h: Added.
- accessibility/gtk/WebKitAccessibleHyperlink.cpp: Added. (returnString): Return (const char*) from String variables. (core): Return the associated AccessibilityObject. (webkitAccessibleHyperlinkActionDoAction): Part of the implementation of the AtkAction interface. (webkitAccessibleHyperlinkActionGetNActions): Likewise. (webkitAccessibleHyperlinkActionGetDescription): Likewise. (webkitAccessibleHyperlinkActionGetKeybinding): Likewise. (webkitAccessibleHyperlinkActionGetName): Likewise. (atkActionInterfaceInit): Initialize the AtkAction interface. (getRangeLengthForObject): Returns the length for a given Range, considering special cases (e.g. List item markers). (webkitAccessibleHyperlinkGetURI): Implementation of one of the methods in the AtkHyperlink abstract class. (webkitAccessibleHyperlinkGetObject): Likewise. (webkitAccessibleHyperlinkGetStartIndex): Likewise. (webkitAccessibleHyperlinkGetEndIndex): Likewise. (webkitAccessibleHyperlinkIsValid): Likewise. (webkitAccessibleHyperlinkGetNAnchors): Likewise. (webkitAccessibleHyperlinkIsSelectedLink): Likewise. (webkitAccessibleHyperlinkGetProperty): Getter method. (webkitAccessibleHyperlinkSetProperty): Setter method. (webkitAccessibleHyperlinkFinalize): Finalize method. (webkitAccessibleHyperlinkClassInit): Initialize the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkInit): Initialize the WebKitAccessibleHyperlink instance. (webkitAccessibleHyperlinkGetType): Implementation of the get_type() function for the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkNew): Returns an instance of the class associated to a given AtkHyperlinkImpl object. (webkitAccessibleHyperlinkGetAccessibilityObject): Public function returning the AccessibilityObject associated to the instance of the WebKitAccessibleHyperlink class.
2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785
New test to ensure the AtkHypertext/AtkHyperlink stuff works.
- tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): New test, checking both the implementation of the AtkHypertext interface, the subclass of the AtkHyperlink abstract class, and the implementation of the AtkAction interface in that subclass. (main): Added the new unit test.
- 7:55 AM Changeset in webkit [71025] by
-
- 2 edits in trunk/LayoutTests
Add two more failing tests to the WebKit2 Skipped file
- platform/mac-wk2/Skipped:
- 7:38 AM Changeset in webkit [71024] by
-
- 2 edits in trunk/LayoutTests
Add some failing/timing out tests to the Windows Skipped file
- platform/win/Skipped:
- 7:32 AM Changeset in webkit [71023] by
-
- 2 edits in trunk/WebKitTools
Fix typo from r71022
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:29 AM Changeset in webkit [71022] by
-
- 2 edits in trunk/WebKitTools
Trigger the Windows Release WebKit2 tests when a Release build finishes, not when a Debug build finishes
Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
triggered at the wrong time
Reviewed by Sam Weinig.
- BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
triggerable name and trigger.
- 7:28 AM Changeset in webkit [71021] by
-
- 2 edits in trunk/LayoutTests
2010-11-01 Jeremy Orlow <jorlow@chromium.org>
Remove test previous patch fixed.
- platform/chromium/test_expectations.txt:
- 7:26 AM Changeset in webkit [71020] by
-
- 3 edits in trunk/LayoutTests
2010-11-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Fix IndexedDB layout test
https://bugs.webkit.org/show_bug.cgi?id=48644
This test needs to be async. Also clean up a few other things like
using a logger div rather than document.write.
- storage/indexeddb/tutorial-expected.txt:
- storage/indexeddb/tutorial.html:
- 5:56 AM Changeset in webkit [71019] by
-
- 6 edits in trunk
2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420
- platform/chromium/test_expectations.txt:
2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420
- public/WebSpeechInputControllerMock.h:
- src/WebSpeechInputControllerMockImpl.cpp:
- src/WebSpeechInputControllerMockImpl.h:
- 5:21 AM WinCE edited by
- (diff)
- 4:28 AM Changeset in webkit [71018] by
-
- 2 edits in trunk/WebKitTools
2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Adding my IRC nickname to the list of committers.
- Scripts/webkitpy/common/config/committers.py:
- 4:09 AM Changeset in webkit [71017] by
-
- 6 edits in trunk
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: simplify inspector styles test to make all bots happy.
(drive-by fix for overriden inspector styles in network panel).
- inspector/InspectorController.h:
- inspector/front-end/networkPanel.css:
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: simplify styles test to make all bots happy.
- inspector/styles-source-lines-inline-expected.txt:
- inspector/styles-source-lines-inline.html:
- 3:25 AM Changeset in webkit [71016] by
-
- 3 edits in trunk
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Updating inspector test expectation as a follow up to r71010.
- inspector/styles-source-lines-inline-expected.txt:
- 2:12 AM Changeset in webkit [71015] by
-
- 12 edits in trunk/LayoutTests
2010-11-01 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715
Forgot to land some changes in my previous commit.
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js:
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js:
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js:
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js:
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js:
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js:
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js:
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js:
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js:
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js:
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js:
- 1:57 AM Changeset in webkit [71014] by
-
- 18 edits3 moves27 adds2 deletes in trunk
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715
Enable StrictTypeChecking for all readwrite attributes and function calls of all types using the new SVG(Animated)PropertyTearOff concept.
Also enable RequiresAllArguments=Raise for all function calls of these new types. Cover this functionality by tests for each of them.
When testing SVGLength it became obvious that quite a lot of functionality was missing.
Conversion from relative arguments (percentage, ems, exs) to user specified units was missing, added that functionality and tested it.
User units to pt conversion was wrong, fixed that.
Tests: svg/dom/SVGAnimatedAngle.html
svg/dom/SVGAnimatedBoolean.html
svg/dom/SVGAnimatedEnumeration.html
svg/dom/SVGAnimatedInteger.html
svg/dom/SVGAnimatedLength.html
svg/dom/SVGAnimatedLengthList.html
svg/dom/SVGAnimatedRect.html
svg/dom/SVGLength-px-with-context.html
svg/dom/SVGLength-px.html
svg/dom/SVGLength.html
- bindings/js/JSSVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/scripts/CodeGeneratorObjC.pm: Remove FIXMEs, pass real context instead off null pointer. DOMSVGLength::value is functional now.
- bindings/v8/custom/V8SVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
- rendering/style/SVGRenderStyle.h: Adapt to SVGLength API changes. (WebCore::SVGRenderStyle::initialBaselineShiftValue): (WebCore::SVGRenderStyle::initialKerning): (WebCore::SVGRenderStyle::initialStrokeDashOffset): (WebCore::SVGRenderStyle::initialStrokeWidth):
- svg/SVGAngle.idl: Add StrictTypeChecking, RequiresAllArguments=Raise to all methods.
- svg/SVGAnimatedBoolean.idl: Remove StrictTypeChecking from animVal, it's readonly so this is useless.
- svg/SVGAnimatedEnumeration.idl: Add StrictTypeChecking to all attributes.
- svg/SVGAnimatedInteger.idl: Ditto.
- svg/SVGLength.cpp: Implement all missing features of SVGLength. Conform to our style guide (s/.0f etc) (WebCore::lengthTypeToString): (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): Throw NOT_SUPPORTED_ERR when trying to obtain to relative units, when no context is given (SVGLength created by createSVGLength()). (WebCore::SVGLength::setValue): Ditto, for the setter. (WebCore::SVGLength::valueAsPercentage): Use m_valueInSpecifiedUnits instead of valueInSpecifiedUnits(). (WebCore::SVGLength::setValueAsString): Throw SYNTAX_ERR if parsing failed. (WebCore::SVGLength::valueAsString): Use makeString() instead of String and operator+. (WebCore::SVGLength::newValueSpecifiedUnits): Add ExceptionCode parameter, throw NOT_SUPPORTED_ERR, if the given unit type is invalid. (WebCore::SVGLength::convertToSpecifiedUnits): Ditto. (WebCore::SVGLength::determineViewport): Added helper function used by convertValue*Percentage*. (WebCore::SVGLength::convertValueFromUserUnitsToPercentage): Add new helper functions, used by value/setValue. (WebCore::SVGLength::convertValueFromPercentageToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEMS): Ditto. (WebCore::SVGLength::convertValueFromEMSToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): Ditto. (WebCore::SVGLength::convertValueFromEXSToUserUnits): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): Adapt to newValueSpecifiedUnits API change. (WebCore::SVGLength::toCSSPrimitiveValue): Remove default switch case.
- svg/SVGLength.h: (WebCore::SVGLength::valueInSpecifiedUnits): Inlined. (WebCore::SVGLength::setValueInSpecifiedUnits): Ditto. (WebCore::SVGLength::isRelative):
- svg/SVGLength.idl: Add StrictTypeChecking for all attributes/functions and RequiresAllArguments=Raise for all functions.
- svg/SVGLengthList.cpp: Adapt to SVGLength API changes. (WebCore::SVGLengthList::parse):
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715
- svg/dom/SVGAngle-expected.txt:
- svg/dom/SVGAnimatedAngle-expected.txt: Added.
- svg/dom/SVGAnimatedAngle.html: Added.
- svg/dom/SVGAnimatedBoolean-expected.txt: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired-expected.txt.
- svg/dom/SVGAnimatedBoolean.html: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired.html.
- svg/dom/SVGAnimatedEnumeration-expected.txt: Added.
- svg/dom/SVGAnimatedEnumeration.html: Added.
- svg/dom/SVGAnimatedInteger-expected.txt: Added.
- svg/dom/SVGAnimatedInteger.html: Added.
- svg/dom/SVGAnimatedLength-expected.txt: Added.
- svg/dom/SVGAnimatedLength.html: Added.
- svg/dom/SVGAnimatedLengthList-expected.txt: Added.
- svg/dom/SVGAnimatedLengthList.html: Added.
- svg/dom/SVGAnimatedRect-expected.txt: Added.
- svg/dom/SVGAnimatedRect.html: Added.
- svg/dom/SVGExternalResourcesRequired-expected.txt: Removed.
- svg/dom/SVGExternalResourcesRequired.html: Removed.
- svg/dom/SVGLength-expected.txt: Added.
- svg/dom/SVGLength-px-expected.txt: Added.
- svg/dom/SVGLength-px-with-context-expected.txt: Added.
- svg/dom/SVGLength-px-with-context.html: Added.
- svg/dom/SVGLength-px.html: Added.
- svg/dom/SVGLength.html: Added.
- svg/dom/script-tests/SVGAngle.js:
- svg/dom/script-tests/SVGAnimatedAngle.js: Added.
- svg/dom/script-tests/SVGAnimatedBoolean.js: Copied from LayoutTests/svg/dom/script-tests/SVGExternalResourcesRequired.js.
- svg/dom/script-tests/SVGAnimatedEnumeration.js: Added.
- svg/dom/script-tests/SVGAnimatedInteger.js: Added.
- svg/dom/script-tests/SVGAnimatedLength.js: Added.
- svg/dom/script-tests/SVGAnimatedLengthList.js: Added.
- svg/dom/script-tests/SVGAnimatedRect.js: Added.
- svg/dom/script-tests/SVGExternalResourcesRequired.js: Removed.
- svg/dom/script-tests/SVGLength-px-with-context.js: Added. Tests various operations on a SVGLength object obtained via rectElement.x.baseVal.
- svg/dom/script-tests/SVGLength-px.js: Added. Tests various operations on a SVGLength object created via svgElement.createSVGLength().
- svg/dom/script-tests/SVGLength.js: Added.
- svg/dom/svg-length-units-expected.txt: Removed.
- svg/dom/svg-length-units.html: Removed. Test is obsolete now, as SVGLength* covers this in detail.
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js: (executeTest): Fixed StrictTypeChecking correctness, don't assign strings as SVGLength value.
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js: (executeTest): Ditto.
- svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js: (executeTest): Ditto.
- 12:57 AM Changeset in webkit [71013] by
-
- 2 edits in trunk/LayoutTests
2010-10-31 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: add failing SVG tests to Chromium test_expectations.txt.
WebKit roll 70949:71000 caused failures within 4 SVG tests on all platforms.
Bot and server outages make analysis difficult, thus adding to
Chromium test_expectations.txt for the time being.
- platform/chromium/test_expectations.txt:
- 12:30 AM Changeset in webkit [71012] by
-
- 2 edits in trunk/LayoutTests
2010-11-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Fixing test expectation for r71010.
- inspector/console-log-syntax-error-expected.txt:
- 12:19 AM Changeset in webkit [71011] by
-
- 5 edits in trunk/LayoutTests
2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71002.
http://trac.webkit.org/changeset/71002
https://bugs.webkit.org/show_bug.cgi?id=48743
Makes Leopard and GTK bots red. (Requested by pfeldman on
#webkit).
- platform/chromium-gpu/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
- 12:07 AM Changeset in webkit [71010] by
-
- 16 edits in trunk
2010-10-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725
- English.lproj/localizedStrings.js:
- inspector/InspectorController.h:
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.addDocumentURL): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.get itemURL): (WebInspector.FileSystemTreeElement.prototype.onselect):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- inspector/front-end/networkPanel.css: (#network-close-button): (.network.panel.viewing-resource #network-close-button):
2010-10-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725
- http/tests/inspector/console-xhr-logging-expected.txt:
- http/tests/inspector/resource-parameters-expected.txt:
- inspector/console-log-syntax-error-expected.txt:
- inspector/elements-panel-styles-expected.txt:
2010-10-31 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
Oct 31, 2010:
- 11:35 PM Changeset in webkit [71009] by
-
- 10 edits2 adds in trunk/WebCore
2010-10-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287
Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/EditingAllInOne.cpp
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
- editing/TextCheckingHelper.h: Added.
- 9:21 PM Changeset in webkit [71008] by
-
- 2 edits in trunk/WebCore
2010-10-31 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
Do not use broken/deprecated functions that won't be available
with G_DISABLE_DEPRECATED (used in debug builds).
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 7:54 PM Changeset in webkit [71007] by
-
- 2 edits in trunk/WebCore
2010-10-31 Kenichi Ishibashi <bashi@google.com>
Reviewed by Adam Barth.
V8 binding for DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47812
Tests for this change will be included in the change for supporting
the <output> element.
See https://bugs.webkit.org/show_bug.cgi?id=29363.
- bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
- 7:48 PM Changeset in webkit [71006] by
-
- 5 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::setMIMEDescription):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
Change the test netscape plugin to declare its mimetype in sentence
case so that the correct behaviour is enforced.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
- 7:37 PM Changeset in webkit [71005] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Ojan Vafai.
Add layout test to make sure we don't regress truncation of an rtl block.
- fast/block/basic/truncation-rtl.html: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.txt: Added.
- 7:30 PM Changeset in webkit [71004] by
-
- 10 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Unskip fast/dom/nodesFromRect-basic.html
- platform/qt/Skipped:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Pass a Document object as a QWebElement.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 7:20 PM Changeset in webkit [71003] by
-
- 2 edits in trunk/LayoutTests
2010-10-31 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
[GTK] Add bug ID for skipped <meter> tests
https://bugs.webkit.org/show_bug.cgi?id=48714
- platform/gtk/Skipped:
- 7:17 PM Changeset in webkit [71002] by
-
- 5 edits in trunk/LayoutTests
2010-10-31 Mike Lawther <mikelawther@chromium.org>
Reviewed by Andreas Kling.
unskip canvas/philip/tests/2d.imageData.get.source.negative on all ports
https://bugs.webkit.org/show_bug.cgi?id=48702
- platform/chromium-gpu/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
- 7:04 PM Changeset in webkit [71001] by
-
- 3 edits6 adds in trunk
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
- fast/images/gif-loop-count-expected.checksum: Added.
- fast/images/gif-loop-count-expected.png: Added.
- fast/images/gif-loop-count-expected.txt: Added.
- fast/images/gif-loop-count.html: Added.
- fast/images/resources/gif-loop-count.gif: Added.
- fast/images/resources/gif-loop-count.png: Added.
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
Test: fast/images/gif-loop-count.html
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
- 6:39 PM Changeset in webkit [71000] by
-
- 2 edits in trunk/WebCore
2010-10-31 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix for X11.
No new tests; build fix.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart):
- 1:42 PM Changeset in webkit [70999] by
-
- 2 edits in trunk/WebKit/qt
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Short-circuit QWebPage::selectedText() if frame has no selection
https://bugs.webkit.org/show_bug.cgi?id=48736
Do an early return if the selection is empty.
No new tests, this is covered by tst_QWebPage::findText().
- Api/qwebpage.cpp: (QWebPage::selectedText):
- 1:33 PM Changeset in webkit [70998] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-31 James Simonsen <simonjam@chromium.org>
Reviewed by Andreas Kling.
Rebaseline a fast/dynamic LayoutTest for Chromium Linux
fast/dynamic/positioned-movement-with-positioned-children.html exposes
a change to the defult button style on Linux.
Prior to bug 26030, buttons were always drawn as #dddddd, regardless of
what the style said. The default style had been #c0c0c0. With the fix,
buttons now honor the style sheet, but in order to maintain
consistency, the default style for Linux was changed to #dddddd.
This patch updates the test to reflect the newer Linux button style.
- platform/chromium-linux/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
- platform/chromium/test_expectations.txt: Removed rebaselined test.
- 1:20 PM Changeset in webkit [70997] by
-
- 4 edits in trunk/WebKit2
2010-10-31 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Visited links not populated correctly in new web processes after the first
https://bugs.webkit.org/show_bug.cgi?id=48735
rdar://problem/8442177
- UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): Initialize m_webProcessHasVisitedLinkState. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Renamed from populateVisitedLinksIfNeeded. Set m_webProcessHasVisitedLinkState to false, since this is a new process, and also start the timer so the visited links messages will be sent. (WebKit::VisitedLinkProvider::processDidClose): Renamed from stopVisitedLinksTimer. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added logic so we send SetVisitedLinkTable and AllVisitedLinkStateChanged once to each new process and to set m_webProcessHasVisitedLinkState to true once that is done.
- UIProcess/VisitedLinkProvider.h: Updated for above changes.
- UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Called VisitedLinkProvider function under its new name. Also used ASSERT_UNUSED rather than ASSERT since the argument is used only for the assertion. (WebKit::WebContext::processDidClose): Ditto.
- 12:32 PM Changeset in webkit [70996] by
-
- 10 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
https://bugs.webkit.org/show_bug.cgi?id=48727
This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
All use of the function was removed in <http://trac.webkit.org/changeset/21601>
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- platform/graphics/wx/GraphicsContextWx.cpp:
- 12:30 PM Changeset in webkit [70995] by
-
- 2 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Respect the "antialiased" argument in clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=48734
Set (or unset) the QPainter::Antialiased render hint for antialiased
clipping based on the "antialiased" argument.
No test since Qt doesn't have pixel tests yet.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
- 12:02 PM Changeset in webkit [70994] by
-
- 3 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::strokeRect(FloatRect)
https://bugs.webkit.org/show_bug.cgi?id=48726
This function was only implemented by GraphicsContextOpenVG and not
called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- 11:59 AM Changeset in webkit [70993] by
-
- 7 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::origin()
https://bugs.webkit.org/show_bug.cgi?id=48732
This method was not called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- 11:57 AM Changeset in webkit [70992] by
-
- 4 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Remove GraphicsContext::pen()
https://bugs.webkit.org/show_bug.cgi?id=48733
Have PathQt obtain the pen() through the platformContext() instead.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
- 10:33 AM Changeset in webkit [70991] by
-
- 25 edits4 deletes in trunk
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- rendering/InlineBox.cpp: (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::linesVisibleOverflowBoundingBox): (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- fast/repaint/inline-vertical-rl-overflow.html: Removed.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- 9:04 AM Changeset in webkit [70990] by
-
- 1 edit1 add in trunk/LayoutTests
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Forgot to land SVGAnimatedNumber.js, fails on all bots. Thanks Darin for noticing.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
Oct 30, 2010:
- 11:43 PM Changeset in webkit [70989] by
-
- 6 edits in trunk/WebCore
2010-10-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680
By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.
Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
- 4:08 PM Changeset in webkit [70988] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
2010-10-30 Antonio Gomes <agomes@rim.com>
Unreviewed Windows bots build fix (take I).
Touching WebKit.idl to try forcing a clean build.
- Interfaces/WebKit.idl:
- 2:00 PM Changeset in webkit [70987] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
William Siegrist <wsiegrist@apple.com>
Change trigger name to match builder name change in r70871.
- 12:31 PM Changeset in webkit [70986] by
-
- 4 edits in trunk
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70846.
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70574.
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
- 11:48 AM Changeset in webkit [70985] by
-
- 19 edits4 deletes in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- fast/events/shadow-boundary-crossing.html:
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
- dom/EventContext.cpp: Removed.
- dom/EventContext.h: Removed.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
- dom/Node.h:
- dom/Text.cpp: (WebCore::Text::createRenderer):
- dom/WindowEventContext.cpp: Removed.
- dom/WindowEventContext.h: Removed.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
- inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
- svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
- svg/SVGElement.h:
- 10:32 AM Changeset in webkit [70984] by
-
- 19 edits4 adds in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.
- fast/events/shadow-boundary-crossing.html: Modified the test.
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
- Android.mk: Added EventContext, WindowEventContext files.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
- dom/EventContext.cpp: Added.
- dom/EventContext.h: Added.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
- dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
and changed signature of eventAncestors to use EventContexts.
- dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
- svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
- svg/SVGElement.h: Ditto.
- dom/WindowEventContext.cpp: Added.
- dom/WindowEventContext.h: Added.
- 8:17 AM Changeset in webkit [70983] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709
Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.
For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.
- webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.
- 7:51 AM Changeset in webkit [70982] by
-
- 2 edits in trunk/WebKit/qt
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700
Go directly through the Frame's SelectionController instead.
No new tests, this is covered by tst_QWebPage::inputMethods.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
- 7:49 AM Changeset in webkit [70981] by
-
- 2 edits in trunk/WebKit2
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707
UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().
- Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
- 7:48 AM Changeset in webkit [70980] by
-
- 3 edits in trunk/WebKitTools
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705
Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
- QtTestBrowser/webinspector.h: (WebInspector::WebInspector):
- 6:23 AM Changeset in webkit [70979] by
-
- 50 edits10 adds in trunk
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.
Tests: svg/dom/SVGAnimatedNumber.html
svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html
- GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
- bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
- bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
- bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAnimatedNumber.h: Added.
- svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
- svg/SVGAnimatedNumberList.h: Added.
- svg/SVGAnimatedNumberList.idl: Ditto.
- svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFECompositeElement.h: Ditto.
- svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
- svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDisplacementMapElement.h: Ditto.
- svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
- svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFELightElement.h: Ditto.
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
- svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEOffsetElement.h: Ditto.
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
- svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
- svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
- svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
- svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
- svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
- svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGStopElement.h: Ditto.
- svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
- svg/SVGTextPositioningElement.h: Ditto.
- svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.
Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- svg/dom/SVGAnimatedNumber-expected.txt: Added.
- svg/dom/SVGAnimatedNumber.html: Added.
- svg/dom/SVGAnimatedNumberList-expected.txt: Added.
- svg/dom/SVGAnimatedNumberList.html: Added.
- svg/dom/SVGNumber-expected.txt: Added.
- svg/dom/SVGNumber.html: Added.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
- svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
- svg/dom/script-tests/SVGNumber.js: Added.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
- 1:59 AM Changeset in webkit [70978] by
-
- 5 edits in trunk/LayoutTests
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Update SVGFEFloodElement mac-leopard baseline, which was forgotten.
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
Oct 29, 2010:
- 11:15 PM Changeset in webkit [70977] by
-
- 1 edit2 copies in branches/chromium/552
Merge 70718 - 2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
Test some appendChild cases that didn't have coverage before.
- fast/dom/allowed-children-expected.txt: Added.
- fast/dom/allowed-children.html: Added.
2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.
Test: fast/dom/allowed-children.html
- dom/Node.cpp: (WebCore::isChildTypeAllowed):
- 11:13 PM Changeset in webkit [70976] by
-
- 28 edits2 copies in trunk
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- Api/qwebframe.cpp: (QWebFrame::frameName):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebFrame.cpp: (WebFrame::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebView/WebFrame.mm: (-[WebFrame name]):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- ewk/ewk_frame.cpp: (ewk_frame_name_get):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
Test: fast/frames/iframe-set-inner-html.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setName):
- html/HTMLFrameElementBase.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::commitProvisionalLoad):
- loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem):
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- page/FrameTree.cpp: (WebCore::FrameTree::setName): (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): (WebCore::FrameTree::child): (WebCore::FrameTree::find):
- page/FrameTree.h: (WebCore::FrameTree::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- fast/frames/frame-element-name-expected.txt:
- fast/frames/iframe-set-inner-html-expected.txt: Copied from LayoutTests/fast/frames/iframe-set-inner-html-expected.txt.
- fast/frames/iframe-set-inner-html.html: Copied from LayoutTests/fast/frames/iframe-set-inner-html.html.
- fast/frames/resources/frame-element-name-left.html:
- fast/frames/resources/frame-element-name-right.html:
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
- 10:38 PM Changeset in webkit [70975] by
-
- 21 edits in trunk
Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627
Reviewed by Ojan Vafai.
Patch by Antonio Gomes <agomes@rim.com>
WebCore:
Added EditingUnixBehavior editing type aim to cover the cases when
neither Mac or Windows behaviors are appropriated.
It was decided to name it Unix not Linux.
No new tests. The current editing tests that involve platform specific
bahaviors are coded so that they go through all editing behavior
types possible. There will be a follow up bug where all of them will
be updated to include the new editing behavior ("unix").
- editing/EditingBehaviorTypes.h:
- page/Settings.cpp:
(WebCore::editingBehaviorTypeForPlatform):
(WebCore::Settings::Settings):
WebKit/chromium:
Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.
- public/WebSettings.h:
- src/AssertMatchingEnums.cpp:
WebKit/gtk:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
- webkit/webkitwebsettings.h:
WebKit/mac:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
- WebView/WebFrame.mm:
(core):
- WebView/WebPreferencesPrivate.h:
WebKit/qt:
Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setEditingBehavior):
WebKit/win:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
- Interfaces/IWebPreferences.idl:
WebKitTools:
Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setEditingBehavior):
- 9:07 PM Changeset in webkit [70974] by
-
- 9 edits2 deletes in tags/Safari-534.11.1/WebCore
Merge r70970.
- 9:07 PM Changeset in webkit [70973] by
-
- 5 edits in tags/Safari-534.11.1
Versioning.
- 8:57 PM Changeset in webkit [70972] by
-
- 1 copy in tags/Safari-534.11.1
New tag.
- 8:49 PM Changeset in webkit [70971] by
-
- 28 edits2 deletes in trunk
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Chromium-port to use FrameTree::uniqueName().
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Qt-port to use FrameTree::uniqueName().
- Api/qwebframe.cpp: (QWebFrame::frameName):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified GTK-port to use FrameTree::uniqueName().
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Apple Windows-port to use FrameTree::uniqueName().
- WebFrame.cpp: (WebFrame::name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Mac-port to use FrameTree::uniqueName().
- WebView/WebFrame.mm: (-[WebFrame name]):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified EFL-port to use FrameTree::uniqueName().
- ewk/ewk_frame.cpp: (ewk_frame_name_get):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Fixes an issue where the window.name of an unnamed frame returns
a unique generated name that is used internally to identify the
frame. Instead, we should return an empty string as implied by
section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
This section describes that a browsing context can have no name or be
the empty string.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty frame name since this is valid as per the HTML5 spec. (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName() since the loader code no longer depends on the frame name being unique.
- html/HTMLFrameElementBase.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
- loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): Ditto. (WebCore::HistoryController::restoreDocumentState): Ditto. (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem): Ditto.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): Ditto. (WebCore::ProgressTracker::progressCompleted): Ditto.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.
- page/FrameTree.cpp: (WebCore::FrameTree::setName): Modified to store the DOM-specified name of the frame. (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName(). (WebCore::FrameTree::child): Ditto. (WebCore::FrameTree::find): Ditto.
- page/FrameTree.h: (WebCore::FrameTree::uniqueName): Added.
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Updated test case fast/frames/frame-element-name.html to check
the value of window.name.
- fast/frames/frame-element-name-expected.txt: Updated result.
- fast/frames/iframe-set-inner-html-expected.txt: Removed; This test ensured that the generated name for an unnamed frames was unique by looking at the value of window.name. However, the generated name should not be exposed to web developers. Instead, window.name should return the empty string for an unnamed frame as implied by section 5.1.6 of the HTML5 spec. We should consider exposing a DRT method for obtaining the internal frame name (which may be generated) and re-implementing this test to use it.
- fast/frames/iframe-set-inner-html.html: Removed.
- fast/frames/resources/frame-element-name-left.html: Added test for window.name.
- fast/frames/resources/frame-element-name-right.html: Ditto.
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified WebKit2 to use FrameTree::uniqueName().
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
- 8:42 PM Changeset in webkit [70970] by
-
- 9 edits2 deletes in trunk/WebCore
Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.
- 8:37 PM Changeset in webkit [70969] by
-
- 2 edits in trunk/WebKitLibraries
Snow Leopard PowerPC build fix.
- libWebKitSystemInterfaceSnowLeopard.a:
- 8:34 PM Changeset in webkit [70968] by
-
- 2 edits in trunk/WebKitLibraries
Leopard PowerPC build fix.
- libWebKitSystemInterfaceLeopard.a:
- 6:40 PM Changeset in webkit [70967] by
-
- 495 edits494 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla/bugs.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.
- 6:28 PM Changeset in webkit [70966] by
-
- 2 edits in trunk/WebKit2
Implement WebProcess::platformSetCacheModel for windows
<rdar://problem/8605796>
https://bugs.webkit.org/show_bug.cgi?id=48703
Reviewed by Simon Fraser.
- WebProcess/win/WebProcessWin.cpp:
(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
Add implemenation based on the version in WebKit/win/WebView.cpp.
- 6:23 PM Changeset in webkit [70965] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Enable a few tests that were fixed in revs 70891:70949.
- platform/chromium/test_expectations.txt:
- 6:09 PM Changeset in webkit [70964] by
-
- 2 edits in trunk/WebKit2
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
WK2: Unbreak compilation of WebPlatformTouchPoint::decode()
- Shared/WebPlatformTouchPoint.cpp: (WebKit::WebPlatformTouchPoint::decode):
- 6:07 PM Changeset in webkit [70963] by
-
- 5 edits in trunk/WebCore
Try to fix build.
- page/ContextMenuController.cpp: Added include of BackForwardController.h.
- page/DOMWindow.cpp: Ditto.
- page/History.cpp: Ditto.
- platform/ContextMenu.cpp: Ditto.
- 5:58 PM Changeset in webkit [70962] by
-
- 5 edits in trunk
Versioning.
- 5:55 PM Changeset in webkit [70961] by
-
- 1 copy in tags/Safari-534.11
New tag.
- 5:44 PM Changeset in webkit [70960] by
-
- 33 edits3 deletes in trunk
More back/forward refactoring
Reviewed by Sam Weinig.
WebCore:
- WebCore.exp.in: Updated.
- GNUmakefile.am: Removed BackForwardControllerClient.h.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- history/BackForwardControllerClient.h: Removed.
- history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
Set up just m_client.
(WebCore::BackForwardController::~BackForwardController):
Removed call to backForwardControllerDestroyed.
(WebCore::BackForwardController::canGoBackOrForward): Added.
(WebCore::BackForwardController::goBackOrForward): Added.
(WebCore::BackForwardController::goBack): Added.
(WebCore::BackForwardController::goForward): Added.
(WebCore::BackForwardController::addItem): Added.
(WebCore::BackForwardController::setCurrentItem): Added.
(WebCore::BackForwardController::count): Added.
(WebCore::BackForwardController::backCount): Added.
(WebCore::BackForwardController::forwardCount): Added.
(WebCore::BackForwardController::itemAtIndex): Added.
(WebCore::BackForwardController::isActive): Added.
(WebCore::BackForwardController::close): Added.
- history/BackForwardController.h: Added functions from Page
and BackForwardList that should be called here instead.
Note that BackForwardList is to be renamed BackForwardClient soon.
- history/BackForwardList.h: Removed many now-unneeded
virtual functions.
- history/BackForwardListImpl.h: Moved BackForwardListClient
in here.
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision): Use backForward().
(WebCore::PageCache::canCache): Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Removed unneeded
null check of backFowardList, which is never null.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
(WebCore::FrameLoader::didFirstLayout): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
(WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.
- loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem): Ditto.
(WebCore::HistoryController::updateForStandardLoad): Ditto.
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
(WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
(WebCore::HistoryController::pushState): Ditto.
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigation::fire): Ditto.
(WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::close): Ditto.
- page/History.cpp:
(WebCore::History::length): Ditto.
- page/Page.cpp:
(WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
backForwardControllerClient.
(WebCore::Page::~Page): Use backForward.
(WebCore::Page::backForwardList): Ditto.
(WebCore::Page::goBack): Ditto.
(WebCore::Page::goForward): Ditto.
(WebCore::Page::canGoBackOrForward): Ditto.
(WebCore::Page::goBackOrForward): Ditto.
(WebCore::Page::getHistoryLength): Ditto.
(WebCore::Page::PageClients::PageClients): Made non-inline.
(WebCore::Page::PageClients::~PageClients): Ditto.
- page/Page.h: Made PageClients constructor and destructor non-inline.
Added backForward function. Marked old functions as deprecated.
- page/Settings.cpp:
(WebCore::Settings::setUsesPageCache): Use backForward.
- platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate): Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.
- wml/WMLDoElement.cpp:
(WebCore::WMLDoElement::defaultEventHandler): Ditto.
- wml/WMLDocument.cpp:
(WebCore::WMLDocument::finishedParsing): Ditto.
- wml/WMLPageState.cpp:
(WebCore::WMLPageState::reset): Ditto.
(WebCore::tryAccessHistoryURLs): Ditto.
- wml/WMLPrevElement.cpp:
(WebCore::WMLPrevElement::executeTask): Ditto.
WebKit2:
- WebKit2.pro: Removed WebBackForwardControllerClient.cpp and .h.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
- WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Removed.
- WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Removed.
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
(WebKit::InjectedBundleBackForwardList::itemAtIndex): Use backForward.
(WebKit::InjectedBundleBackForwardList::backListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::forwardListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::clear): Ditto.
- WebProcess/WebPage/WebBackForwardListProxy.h: Added newly-needed include.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Set up backForwardClient.
- 5:38 PM Changeset in webkit [70959] by
-
- 25 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48663
Reviewed by Sam Weinig.
Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.
Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
Added fast/repaint/inline-vertical-lr-overflow.html
WebCore:
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
LayoutTests:
- fast/repaint/inline-vertical-rl-overflow.html: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- 5:37 PM Changeset in webkit [70958] by
-
- 321 edits320 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla/marvin.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.
- 5:13 PM Changeset in webkit [70957] by
-
- 5 edits1 delete in trunk
2010-10-29 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277
Remove canvas/philip/tests/2d.imageData.get.source.negative from chromium skipped.
Also remove spurious trailing newlines from 2d.imageData.get.source.negative-expected.txt
- canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
- platform/chromium/test_expectations.txt:
2010-10-29 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277
Handle negative width/height.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
- 4:57 PM Changeset in webkit [70956] by
-
- 25 edits3 adds in trunk
2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982
Adding filesystem support for Inspector under storage tab. This fetches root paths for
temporary and persistent filesystems and allows "reveal folder in OS" option that
launches native file browser. Currently this feature is disabled for non-chromium platforms.
- CMakeLists.txt:
- English.lproj/localizedStrings.js:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
- inspector/InspectorController.h: (WebCore::InspectorController::fileSystemAgent):
- inspector/InspectorFileSystemAgent.cpp: Added.
- inspector/InspectorFileSystemAgent.h: Added.
- inspector/front-end/FileSystemView.js: Added.
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addFileSystem): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.StoragePanel.prototype.updateFileSystemPath): (WebInspector.StoragePanel.prototype.updateFileSystemError): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.onselect):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.file-system-storage-tree-item .icon):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addFileSystemOrigin): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.reset):
- platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::root):
- platform/FileSystem.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/FileSystemChromium.cpp: (WebCore::revealFolderInOS):
2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982
- public/WebFileUtilities.h: (WebKit::WebFileUtilities::revealFolderInOS):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::revealFolderInOS):
- 4:53 PM Changeset in webkit [70955] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-29 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+ after BackForwardListImpl introduction.
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_new_with_web_view):
- 4:45 PM Changeset in webkit [70954] by
-
- 8 edits in trunk/WebKit2
Stop using encode/decodeBytes for WebEvent subclasses
The use of encode/decodeBytes was making these classes sensitive to
differences in padding on different architectures (e.g., 32-bit vs.
64-bit). By encoding each data member explicitly we remove this
sensitivity, allowing these classes to be passed between processes
with different padding.
Fixes <http://webkit.org/b/48552> <rdar://problem/8606571> Mouse
events never reach Flash in WebKit2 on Mac (asserts in Debug builds)
Reviewed by Anders Carlsson.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments8::Arguments8):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments8::decode):
(CoreIPC::In):
(CoreIPC::Out):
Added Arguments8, the biggest Arguments yet.
- Shared/WebEvent.cpp:
(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):
- Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Changed all encode/decode function to use CoreIPC::In/Out to
encode/decode data members individually.
- 4:44 PM Changeset in webkit [70953] by
-
- 2 edits in trunk/WebKit2
Use only CoreIPC-sanctioned types in WebEvent subclasses
Fixes <http://webkit.org//48694> WebEvent subclasses should not use
architecture-dependent types
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
(WebKit::WebEvent::type):
(WebKit::WebMouseEvent::button):
(WebKit::WebMouseEvent::clickCount):
(WebKit::WebWheelEvent::granularity):
(WebKit::WebPlatformTouchPoint::id):
(WebKit::WebPlatformTouchPoint::state):
Replaced enums, ints, and unsigneds with uint32_ts, int32_ts, and
uint32_ts, respectively.
- 4:44 PM Changeset in webkit [70952] by
-
- 3 edits in trunk/LayoutTests
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by David Levin.
Disable media/video-canvas-alpha.html for Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=48688
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:37 PM Changeset in webkit [70951] by
-
- 3 edits in trunk/WebKit2
Generate a DelayedReply struct for sync messages marked delayed
https://bugs.webkit.org/show_bug.cgi?id=48696
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
If we encounter a sync message marked delayed, generate a DelayedReply struct with a send member funciton
that can be used for sending the reply.
- Scripts/webkit2/messages_unittest.py:
Update expected results.
- 4:34 PM Changeset in webkit [70950] by
-
- 89 edits88 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update Snow Leopard pixel baselines for tests in tables/mozilla pt 1
This updates the pixel baselines in platform/mac to be valid for Snow Leopard for tests
in tables/mozilla/collapsing_borders, /core, /dom, and /other. Old baselines moved to
platform/mac-leopard.
- 4:31 PM Changeset in webkit [70949] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
- platform/chromium-win/editing/deleting/5390681-2-expected.checksum:
- platform/chromium-win/editing/deleting/5390681-2-expected.png:
- 4:24 PM Changeset in webkit [70948] by
-
- 2 edits in trunk/WebKit/qt
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
https://bugs.webkit.org/show_bug.cgi?id=48692
- Api/qwebpage.cpp: (QWebPage::event): Add missing break statement.
- 4:22 PM Changeset in webkit [70947] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
https://bugs.webkit.org/show_bug.cgi?id=48695
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 4:19 PM Changeset in webkit [70946] by
-
- 3 edits in trunk/WebKitTools
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
https://bugs.webkit.org/show_bug.cgi?id=48675
FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
on startup with in -graphicsbased mode.
- QtTestBrowser/fpstimer.cpp: (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::stop): (FpsTimer::timerEvent):
- QtTestBrowser/fpstimer.h:
- 4:15 PM Changeset in webkit [70945] by
-
- 8 edits in trunk
2010-10-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870
Converted RenderTextControll::setSelectionRange to a global function.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls setSelectionRange.
2010-10-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870
Made RenderTextControl::setSelectionRange a global function.
Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.
No new tests are added since there is no behavioral change.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
- dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange): Ditto.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. (WebCore::HTMLTextFormControlElement::select): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasVisibleTextArea): Added. (WebCore::setSelectionRange): See above.
- rendering/RenderTextControl.h:
- 3:48 PM Changeset in webkit [70944] by
-
- 191 edits190 copies1 add in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla_expected_failures.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for 96 tests that need them. List of files omitted due to length.
- 3:46 PM Changeset in webkit [70943] by
-
- 7 edits1 copy1 add in trunk/WebKitTools
2010-10-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: change TestResults to be serializable
In preparation for changing new-run-webkit-tests from
multithreaded to multiprocess, we need to make sure the data
going between the threads is easily serialized over a socket.
This change adds serialization/pickling for the TestResults and
TestFailure objects (using cPickle).
The TestFailure objects included a "has_wdiff" flag for Text
results, but the flag wasn't being used, so I've removed it,
simplifying the state to basically a set of enum objects with
associated methods.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 3:44 PM Changeset in webkit [70942] by
-
- 3 edits in trunk/WebKitTools
2010-10-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: need to provide separate dashboard results for GPU tests
https://bugs.webkit.org/show_bug.cgi?id=48687
Modify the steps to upload the JSON files to the dashboards so
that the GPU tests don't conflict with the regular tests on a
port. We do this by modifying the --builder-name parameter to
append " - GPU", which should cause the app to treat the results
as a completely new builder. This is a little non-obvious, but
keeps us from having to restructure the app.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:39 PM Changeset in webkit [70941] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [70940] by
-
- 3 edits in trunk/LayoutTests
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662
- media/controls-drag-timebar-expected.txt:
- media/controls-drag-timebar.html: Remove some of the logging to avoid timing differences on slower machines.
- 3:32 PM Changeset in webkit [70939] by
-
- 4 edits in branches/chromium/552
Merge 70923 - 2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.
Tests: the existing layout test applies
- loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
- loader/appcache/ApplicationCacheHost.h:
TBR=Michael Nordman
- 3:23 PM Changeset in webkit [70938] by
-
- 5 edits in trunk/LayoutTests
Update test results for the presence of HTMLMeterElement
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 3:23 PM Changeset in webkit [70937] by
-
- 2 edits22 adds in trunk/LayoutTests
Stop skipping HTMLMeterElement tests on Windows and check in results for them
Fixes <http://webkit.org/b/48681>
fast/dom/HTMLMeterElement/meter-boundary-values.html fails on Windows
- platform/win/Skipped: Removed HTMLMeterElement tests.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
- 3:16 PM Changeset in webkit [70936] by
-
- 8 edits in trunk/WebKit2
Use WebPage::send in a couple of more places.
Reviewed by Adam Roben.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::takeFocus):
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::setResizable):
(WebKit::WebChromeClient::setStatusbarText):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::setToolTip):
(WebKit::WebChromeClient::setCursor):
(WebKit::WebChromeClient::dispatchViewportDataDidChange):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::dispatchDidBecomeFrameset):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
(WebKit::FindController::hideFindIndicator):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::clear):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendClose):
(WebKit::WebPage::pageDidScroll):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::validateMenuItem):
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::show):
(WebKit::WebPage::runJavaScriptInMainFrame):
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::getSourceForFrame):
- 3:15 PM Changeset in webkit [70935] by
-
- 2 edits in trunk/WebCore
2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Andreas Kling.
[GTK] Crash in TextEncoding.cpp when using glib unicode
https://bugs.webkit.org/show_bug.cgi?id=48521
When the conversion to UTF-8 fails, try to encode the original string
without normalizing. Fixes tests cases:
fast/url/anchor.html
fast/url/query.html
fast/url/standard-url.html
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- 3:02 PM Changeset in webkit [70934] by
-
- 8 edits1 add in trunk/WebKit2
Add a MessageSender class template
https://bugs.webkit.org/show_bug.cgi?id=48683
Reviewed by Adam Roben.
- Platform/CoreIPC/MessageSender.h: Added.
(CoreIPC::MessageSender::send):
Add send overloads for simple message sending.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add MessageSender.h
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
Call send on the web page.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::connection):
Add connection(), used by the MessageSender.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::destinationID):
Add destinationID(), used by the MessageSender.
- win/WebKit2.vcproj:
Add MessageSender.h
- 3:01 PM Changeset in webkit [70933] by
-
- 2 edits in trunk/WebCore
2010-10-29 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antonio Gomes.
TextureMapperGL get the driver info log but do not use it
https://bugs.webkit.org/show_bug.cgi?id=48247
Remove the call to glGetProgramInfoLog().
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TexmapShaderInfo::createShaderProgram):
- 2:47 PM Changeset in webkit [70932] by
-
- 10 edits in trunk
2010-10-29 Benjamin Kalman <kalman@google.com>
Reviewed by Tony Chang.
Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658
- editing/deleting/5390681-expected.txt: Update test for changed behaviour.
- editing/deleting/5390681.html: Ditto (update comment).
- editing/deleting/delete-mixed-editable-content-001-expected.txt: Ditto.
- editing/pasteboard/copy-backslash-with-euc-expected.txt: Ditto.
2010-10-29 Benjamin Kalman <kalman@google.com>
Reviewed by Tony Chang.
Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658
- WebCore.exp.in: Update is{Start,End}OfParagraph symbols.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder.
- editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
- editing/visible_units.h: Ditto.
- 2:38 PM Changeset in webkit [70931] by
-
- 23 edits in trunk/WebKit
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- src/BackForwardListClientImpl.h: Use BackForwardListImpl.h.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Cast to BackForwardList* before calling setClient.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- Api/qwebhistory.cpp: (QWebHistory::clear):
- Api/qwebhistory_p.h:
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- webkit/webkitprivate.h:
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_new_with_web_view): (webkit_web_back_forward_list_go_forward): (webkit_web_back_forward_list_go_back): (webkit_web_back_forward_list_contains_item): (webkit_web_back_forward_list_go_to_item): (webkit_web_back_forward_list_get_forward_list_with_limit): (webkit_web_back_forward_list_get_back_list_with_limit): (webkit_web_back_forward_list_get_back_item): (webkit_web_back_forward_list_get_current_item): (webkit_web_back_forward_list_get_forward_item): (webkit_web_back_forward_list_get_nth_item): (webkit_web_back_forward_list_get_back_length): (webkit_web_back_forward_list_get_forward_length): (webkit_web_back_forward_list_get_limit): (webkit_web_back_forward_list_set_limit): (webkit_web_back_forward_list_add_item): (webkit_web_back_forward_list_clear): (WebKit::core):
- webkit/webkitwebview.cpp: (webkit_web_view_set_maintains_back_forward_list): (webkit_web_view_get_back_forward_list): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::createInstance):
- WebBackForwardList.h:
- WebView.cpp: (WebView::backForwardList): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- WebFrame.cpp: (wxWebFrame::CanGoBack): Use canGoBackOrForward. (wxWebFrame::CanGoForward): Ditto.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- History/WebBackForwardList.mm: Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- ewk/ewk_history.cpp: (ewk_history_new):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_history_enable_get): (ewk_view_history_enable_set): (ewk_view_history_get): Use BackForwardListImpl.
- 2:31 PM Changeset in webkit [70930] by
-
- 2 edits in trunk/WebKit2
Add the plug-in proxy to the map before sending the CreatePlugin message
https://bugs.webkit.org/show_bug.cgi?id=48678
Reviewed by Adam Roben.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
- 2:28 PM Changeset in webkit [70929] by
-
- 7 edits in trunk/WebCore
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: last active panel is not restored upon opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=48668
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/front-end/Settings.js: (WebInspector.Settings):
- inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.doLoadedDone.onPopulateScriptObjects): (WebInspector.doLoadedDone): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
- 2:26 PM Changeset in webkit [70928] by
-
- 3 edits in trunk/WebKit2
Remove redundant data members from WebTouchEvent
WebEvent already stores the Type and timestamp.
Fixes <http://webkit.org/b/48671> WebTouchEvent duplicates data from
WebEvent
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::WebTouchEvent):
Removed m_type and m_timestamp (which was never even getting
initialized!).
- 2:24 PM Changeset in webkit [70927] by
-
- 5 edits in trunk/WebKit2
Add GetWindowScriptNPObject message
https://bugs.webkit.org/show_bug.cgi?id=48670
Reviewed by Adam Roben.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
Send the GetWindowScriptNPObject message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getWindowScriptNPObject):
Add stub.
- WebProcess/Plugins/PluginProxy.messages.in:
Add GetWindowScriptNPObject message.
- 2:18 PM Changeset in webkit [70926] by
-
- 3 edits1 add7 deletes in trunk/LayoutTests
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662
- media/controls-drag-timebar-expected.txt: Added.
- media/controls-drag-timebar.html: Remove all platform specific logging.
- platform/chromium-mac/media/controls-drag-timebar-expected.txt: Removed.
- platform/chromium-win/media/controls-drag-timebar-expected.txt: Removed.
- platform/gtk/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac-leopard/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac-snowleopard/Skipped: Unskip test.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac/media/controls-drag-timebar-expected.txt: Removed.
- platform/win/media/controls-drag-timebar-expected.txt: Removed.
- 2:07 PM Changeset in webkit [70925] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 2:06 PM Changeset in webkit [70924] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add debug logging to help diagnose flakiness dashboard issues
https://bugs.webkit.org/show_bug.cgi?id=48657
The appengine app thinks it's getting empty files uploaded. Add some logging
to see if new-run-webkit-tests agrees.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:06 PM Changeset in webkit [70923] by
-
- 6 edits in trunk
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.
Tests: the existing layout test applies
- loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
- loader/appcache/ApplicationCacheHost.h:
- 2:00 PM Changeset in webkit [70922] by
-
- 3 edits2 adds in trunk
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>
Test: media/media-can-play-wav-audio.html
- platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav".
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>
- media/media-can-play-wav-audio-expected.txt: Added.
- media/media-can-play-wav-audio.html: Added.
- 1:52 PM Changeset in webkit [70921] by
-
- 96 edits94 copies in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/block/float for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
platform/mac/test_expectations.txt was also modified to remove a
now-passing test.
- 1:51 PM Changeset in webkit [70920] by
-
- 12 edits in trunk/WebKit2
Change the Connection::sendSync timeout parameter to have the NoTimeout argument as a default
argument and update all the call sites.
Reviewed by Dan Bernstein.
- Platform/CoreIPC/Connection.h:
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::proxiesForURL):
(WebKit::PluginControllerProxy::cookiesForURL):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::destroy):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::changeAcceleratedCompositingMode):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
(WebKit::LayerBackedDrawingArea::attachCompositingContext):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::interceptEditingKeyboardEvent):
- 1:49 PM Changeset in webkit [70919] by
-
- 7 edits6 adds in trunk
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Added a layout test for verifying that globalAlpha is properly handled
when copying a video frame to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094
- media/video-canvas-alpha-expected.txt: Added.
- media/video-canvas-alpha.html: Added.
- platform/chromium-mac/media/video-canvas-alpha-expected.checksum: Added.
- platform/chromium-mac/media/video-canvas-alpha-expected.png: Added.
- platform/chromium-win/media/video-canvas-alpha-expected.checksum: Added.
- platform/chromium-win/media/video-canvas-alpha-expected.png: Added.
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha()
to centralize alpha rounding & clipping logic.
https://bugs.webkit.org/show_bug.cgi?id=48094
Test: media/video-canvas-alpha.html
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::getNormalizedAlpha):
- platform/graphics/skia/PlatformContextSkia.h:
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Fix globalAlpha support when using drawImage() to copy a video frame
to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094
This fix applies the globalAlpha value to the canvas before passing it
down to the lower layers that don't have access to the graphics
context. This makes sure that any drawing on the canvas will have the
proper global alpha value applied.
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint):
- 1:33 PM Changeset in webkit [70918] by
-
- 8 edits2 adds in trunk
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555
Test: svg/custom/insertItemBefore-from-non-list-origin.svg
- bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true. (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function.
- svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false.
- svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty.
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555
- svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
- svg/custom/insertItemBefore-from-non-list-origin.svg: Added.
- 1:25 PM Changeset in webkit [70917] by
-
- 9 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=48444
Reviewed by Adam Roben.
Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox. They were still assuming horizontal-tb writing-mode.
This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code.
No tests yet, since the invalidation code for inlines still assumes horizontal-tb. That will be fixed in a follow-up bug,
and then repaint tests will be easy to write.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::convertFromFlippedWritingMode):
- rendering/RenderBox.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsDirtyRect):
(WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- 1:06 PM Changeset in webkit [70916] by
-
- 5 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48666
WebKit2 should provide counterpart getter to WKBundleNodeHandleSetHTMLInputElementAutofilled
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetHTMLInputElementAutofilled):
New function, calls through to InjectedBundleNodeHandle.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
Declared new function.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
New function, calls through to HTMLInputElement.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
Declared new function.
- 12:30 PM Changeset in webkit [70915] by
-
- 2 edits in trunk/WebKit2
ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send
the DidCreateMainFrame messsage to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=48654
Reviewed by Anders Carlsson.
WebProcessProxy::frameDestroyed was asserting that the frameID it was called with was
registered in WebProcessProxy::frameCreated (which is called when the WebPageProxy is
created). However, in the case where we close the page before it's had the chance to send
the DidCreateMainFrame message back to the UI process, the UI Process will get the
DidDestroyFrame message because it's sent directly to the WebProcessProxy and doesn't go
through WebPageProxy.
Remove the assert because it is invalid in this case.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::frameDestroyed):
- 12:13 PM Changeset in webkit [70914] by
-
- 2 edits in trunk/WebCore
2010-10-29 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189
- platform/win/ClipboardWin.cpp: (WebCore::createGlobalURLContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::ClipboardWin::writeURL):
- 12:00 PM Changeset in webkit [70913] by
-
- 4 edits in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
[Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=48647
Chromium throws an exception if calling push/replaceState on a detached
frame, while the mac port fails silently (presumably a JSC vs. V8
difference). Either behavior is correct (as long as we don't crash),
make the test handle both.
- fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt:
- fast/loader/stateobjects/state-api-on-detached-frame-crash.html:
- platform/chromium/test_expectations.txt:
- 12:00 PM Changeset in webkit [70912] by
-
- 2 edits in trunk/WebCore
[Chromium clang] Unreviewed fix removing compiler warning.
If GIFImageReader is a struct, don't call it a class.
- platform/image-decoders/gif/GIFImageDecoder.h:
- 11:56 AM Changeset in webkit [70911] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Sam Weinig.
Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
create views for subframes.
- WebView/WebViewData.h: Double negation is better than a lie.
- 11:55 AM Changeset in webkit [70910] by
-
- 4 edits3 adds in trunk
2010-10-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573
I think the interpreter portion of this was introduced by
an incorrect but silent merge when I updated prior to committing.
The JIT change is basically just a correctness fix, but it is
needed to prevent the testcase from asserting in debug builds.
The basic problem is incorrectly setting the activation object
on an arguments object. The crash was due to us setting a null
activation in the interpreter, in the jit we were setting the
activation of a strict mode arguments object.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- wtf/Platform.h:
2010-10-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573
Add a test to ensure that we don't incorrectly set a null activation
as an argument object's activation.
- fast/js/interpreter-no-activation-expected.txt: Added.
- fast/js/interpreter-no-activation.html: Added.
- fast/js/script-tests/interpreter-no-activation.js: Added.
- 11:48 AM Changeset in webkit [70909] by
-
- 5 edits2 copies in branches/chromium/517
Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.
Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
- html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
- fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
- fast/dom/object-plugin-hides-properties.html: Ditto.
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
TBR=cpu@google.com
BUG=57986
Review URL: http://codereview.chromium.org/4214004
- 11:43 AM Changeset in webkit [70908] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed cleanp of platform/chromium/test_expectations.txt
Group http/tests/navigation failures together, and differentiate between
flaky/failing tests and those that need updated baselines (though really
they shouldn't be pixel tests in the first place).
Also enable http/tests/navigation/post-goback-repost-policy.html, it
seems to be passing now (we've enabled sessionStorage for a while).
- platform/chromium/test_expectations.txt:
- 11:40 AM Changeset in webkit [70907] by
-
- 2 edits in trunk/WebCore
Fix the world (d'oh!)
https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::insertedIntoDocument): (WebCore::HTMLFrameSetElement::removedFromDocument): Call base class version.
- 11:36 AM Changeset in webkit [70906] by
-
- 2 edits in trunk/WebCore
Unreviewed. Fix chromium build break.
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
- 11:28 AM Changeset in webkit [70905] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
[Chromium/DRT] Add master-name flag to new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=48649
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
- 11:23 AM Changeset in webkit [70904] by
-
- 26 edits2 copies2 adds in trunk
Support readAsArrayBuffer in FileReader and FileReaderSync
https://bugs.webkit.org/show_bug.cgi?id=47691
Reviewed by David Levin.
WebCore:
Merge the similar code in FileReader and FileReaderSync into
FileReaderLoader.
Test cases have been added to read-file-test-cases.js.
- Android.jscbindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/custom/V8FileReaderCustom.cpp: Added.
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::fireEvent):
(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):
- fileapi/FileReader.h:
(WebCore::FileReader::readType):
- fileapi/FileReader.idl:
- fileapi/FileReaderLoader.cpp: Added.
- fileapi/FileReaderLoader.h: Added.
- fileapi/FileReaderLoaderClient.h: Added.
- fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSync::FileReaderSync):
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::startLoading):
- fileapi/FileReaderSync.h:
- fileapi/FileReaderSync.idl:
- html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
- html/canvas/ArrayBuffer.h:
- loader/ThreadableLoaderClient.h:
LayoutTests:
- fast/files/read-file-async-expected.txt:
- fast/files/resources/read-common.js:
(readBlobAsArrayBuffer):
(_readBlobAsArrayBufferAsync):
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
(logResult):
(loaded):
(_toString):
(_isASCIIString):
(_toHexadecimal):
(_getElementAt):
- fast/files/resources/read-file-test-cases.js:
(testReadingNonExistentFileAsArrayBuffer):
(testReadingEmptyFileAsArrayBuffer):
(testReadingUTF8EncodedFileAsArrayBuffer):
(testReadingBinaryFileAsArrayBuffer):
(testMultipleReads):
- fast/files/workers/resources/worker-read-file-sync.js:
(testMultipleReadsSync):
- fast/files/workers/worker-read-blob-sync-expected.txt:
- fast/files/workers/worker-read-file-async-expected.txt:
- fast/files/workers/worker-read-file-sync-expected.txt:
- 11:00 AM Changeset in webkit [70903] by
-
- 2 edits in trunk/WebKit2
Build fix when Carbon plugins are disabled
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
- 10:57 AM Changeset in webkit [70902] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebKitPrefix.h: Touched to force a rebuild.
- 10:53 AM Changeset in webkit [70901] by
-
- 3 edits in trunk/WebKit/mac
2010-10-27 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Full screen video in Safari (still) exits full-screen if you switch to another
app on a multi-display system.
https://bugs.webkit.org/show_bug.cgi?id=47364
<rdar://problem/8382299>
The FullScreen window does not technically close when it deactivates, but the
two NSWindows that make up the FullScreen feature should not hide when deactivated.
- WebView/WebVideoFullscreenController.mm: (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate. (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
- 10:50 AM Changeset in webkit [70900] by
-
- 1 edit in branches/chromium/552/WebCore/html/HTMLMediaElement.cpp
Merge 70065 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>
Not reviewed. Build fix.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.
BUG=59593
TBR=jschuh@chromium.org
- 10:47 AM Changeset in webkit [70899] by
-
- 5 edits4 copies in branches/chromium/552
Merge 70063 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Fix crashes caused by moving and deleting <source> element(s) of active media element.
Tests: media/video-source-moved.html
media/video-source-removed.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
- html/HTMLSourceElement.h:
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Test moving and deleting <source> element(s) of active <video>.
- media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
- media/video-source-moved-expected.txt: Added.
- media/video-source-moved.html: Added.
- media/video-source-removed-expected.txt: Added.
- media/video-source-removed.html: Added.
BUG=59593
TBR=jschuh@chromium.org
- 10:45 AM Changeset in webkit [70898] by
-
- 4 edits10 moves in trunk/WebKit2
Move NPRuntime-related files into WebProcess/Plugins/Netscape
Fixes <http://webkit.org/b/48645>.
Reviewed by Anders Carlsson.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Updated the files' paths.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.cpp.
- WebProcess/Plugins/Netscape/JSNPMethod.h: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.h.
- WebProcess/Plugins/Netscape/JSNPObject.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.cpp.
- WebProcess/Plugins/Netscape/JSNPObject.h: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.h.
- WebProcess/Plugins/Netscape/NPJSObject.cpp: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.cpp.
- WebProcess/Plugins/Netscape/NPJSObject.h: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.h.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.cpp.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.h.
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.cpp.
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.h.
- 10:44 AM Changeset in webkit [70897] by
-
- 1 edit in branches/chromium/552/WebCore/html/HTMLMediaElement.cpp
Merge 69514 - 2010-10-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Eric Carlson.
CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777
Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
BUG=59593
TBR=jschuh@chromium.org
- 10:32 AM Changeset in webkit [70896] by
-
- 7 edits in trunk/WebCore
2010-10-29 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r70850.
http://trac.webkit.org/changeset/70850
https://bugs.webkit.org/show_bug.cgi?id=45640
chromium and qt pixel test regressions
- dom/Document.cpp:
- dom/Document.h:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::doDeferredRepaints):
- page/FrameView.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 10:28 AM Changeset in webkit [70895] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Zhenyao Mo <zmo@google.com>
Unreviewed, webgl test expectations update.
- platform/chromium/test_expectations.txt:
- 10:23 AM Changeset in webkit [70894] by
-
- 43 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset
This can change in two cases, when document changes, and when frame is navigated to another
document.
- 10:22 AM Changeset in webkit [70893] by
-
- 3 edits in trunk/WebKit2
Connection::sendSyncMessage needs to dispatch incoming sync messages
https://bugs.webkit.org/show_bug.cgi?id=48606
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Protect the connection when waiting for a reply. Schedule for any remaining incoming sync messages
to be sent once the bottom-most waitForSyncReply calls returns.
(CoreIPC::Connection::waitForSyncReply):
Make sure to dispatch any incoming sync messages.
(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync message and we're waiting for a sync reply, add the message to the
queue of "sync messages received while waiting for sync reply" and wake up the client thread.
- Platform/CoreIPC/Connection.h:
- 10:06 AM Changeset in webkit [70892] by
-
- 11 edits in trunk/WebKit2
Use IntPoint/FloatSize in WebEvent subclasses
This is nicer than passing around pairs of ints/floats.
Fixes <http://webkit.org/b/48611>.
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
- Shared/WebMouseEvent.cpp:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebWheelEvent.cpp:
Changed all x/y pairs to either use IntPoint or FloatSize, as
appropriate.
- Shared/WebEventConversion.cpp:
- Shared/mac/WebEventFactory.mm:
- Shared/qt/WebEventFactoryQt.cpp:
- Shared/win/WebEventFactory.cpp:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
Updated for WebEvent changes.
- 10:05 AM Changeset in webkit [70891] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test_expectations update.
Fix a duplicate for Mac, address r70887 tests miss.y
- platform/chromium/test_expectations.txt:
- 10:01 AM Changeset in webkit [70890] by
-
- 2 edits in trunk/WebKit2
Touch WebKit2Prefix.h to fix incremental builds on Windows
- WebKit2Prefix.h:
- 9:59 AM Changeset in webkit [70889] by
-
- 2 edits in trunk/WebKitSite
Instruct developers to install the Feburary 2010 DirectX SDK, not just any version
The February 2010 SDK is the last one with support for Visual Studio
2005.
I also removed some unnecessary instructions regarding the DirectX
SDK.
Fixes <http://webkit.org/b/48642> webkit.org should recommend a
specific version of the DirectX SDK
Reviewed by Steve Falkenburg.
- building/tools.html:
- 9:57 AM Changeset in webkit [70888] by
-
- 2 edits in trunk/WebKit/qt
2010-10-29 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebFrame on XVFB.
https://bugs.webkit.org/show_bug.cgi?id=48637
These tests relied on a window manager to activate the window.
Fixes:
- tst_QWebFrame::popupFocus()
- tst_QwebFrame::inputFieldFocus()
- tests/qwebframe/tst_qwebframe.cpp:
- 9:37 AM Changeset in webkit [70887] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-10-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add IndexedDB test/tutorial
https://bugs.webkit.org/show_bug.cgi?id=48067
This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.
- storage/indexeddb/tutorial-expected.txt: Added.
- storage/indexeddb/tutorial.html: Added.
- 9:31 AM Changeset in webkit [70886] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
Enable popup window in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=48335
The GtkLauncher application does not support opening new window when
a link with "target=_blank" is clicked or similar call to
window.open(). Instead, GtkLauncher does nothing which breaks
navigation of some websites.
- GtkLauncher/main.c: (activate_uri_entry_cb): (update_title): (link_hover_cb): (notify_title_cb): (notify_load_status_cb): (notify_progress_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_web_view_cb): (web_view_ready_cb): (close_web_view_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
- 9:27 AM Changeset in webkit [70885] by
-
- 21 edits in trunk/WebKit2
Remove unnecessary #includes from WebEvent.h
Fixes <http://webkit.org/b/48609> WebEvent.h #includes things it
doesn't need
Reviewed by Sam Weinig.
- Scripts/webkit2/messages.py:
(MessageReceiver.iterparameters): Merged iterreplyparameters into this
function. All callers to iterparameters are really interested in the
reply parameters, too. This will cause us to, e.g., add
forward-declarations for types used in sync replies.
(headers_for_type): Added a special case for WebCore::KeypressCommand.
- Scripts/webkit2/messages_unittest.py: Added a test to cover the
failing case that inspired the above changes.
- Shared/WebEvent.h: Replaced #includes with forward-declarations.
- Shared/API/c/WKSharedAPICast.h:
- Shared/NativeWebKeyboardEvent.h:
- Shared/WebEvent.cpp:
- Shared/WebKeyboardEvent.cpp:
- Shared/WebMouseEvent.cpp:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebTouchEvent.cpp:
- Shared/WebWheelEvent.cpp:
- UIProcess/LayerBackedDrawingAreaProxy.cpp:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
Added now-needed #includes and declarations.
- 8:45 AM Changeset in webkit [70884] by
-
- 2 edits in trunk/WebCore
Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878.
- WebCorePrefix.h:
- 8:45 AM Changeset in webkit [70883] by
-
- 2 edits in trunk/WebKitTools
Teach check-webkit-style about WebKit2's idiosyncracies
Fixes <http://webkit.org/b/48638> Style bot complains about a number
of WebKit2 conventions
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checker.py: Excluded some rules for various
WebKit2-related files. Also updated the excluded rules for
WebKitAPITest to match the current code.
- 8:41 AM Changeset in webkit [70882] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test_expectations fix.
Remove duplicate for body-propagation\overflow\004-xhtml.xhtml.
- platform/chromium/test_expectations.txt:
- 8:39 AM Changeset in webkit [70881] by
-
- 2 edits in trunk/WebCore
2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/show_bug.cgi?id=48227
TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we
need to return indices for the given input string that are in UTF-16.
The number of characters is the same for both UTF-16 and UTF-8 except when
the input string contains surrogate pairs. We need to keep both, the
index for the UTF-8 string to be used internally, and the index for the
UTF-16 string to be used as return value of the iterator interface. It
fixes test fast/forms/textarea-maxlength.html
- platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::CharacterIterator::getText): (WebCore::CharacterIterator::getLength): (WebCore::CharacterIterator::getSize): (WebCore::CharacterIterator::getIndex): (WebCore::CharacterIterator::getUTF16Index): (WebCore::CharacterIterator::getUTF16Length): (WebCore::CharacterIterator::characterSize): (WebCore::CharacterIterator::setText): (WebCore::CharacterIterator::setIndex): (WebCore::CharacterIterator::setUTF16Index): (WebCore::CharacterIterator::first): (WebCore::CharacterIterator::last): (WebCore::CharacterIterator::next): (WebCore::CharacterIterator::previous): (WebCore::setUpIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
- 8:34 AM Changeset in webkit [70880] by
-
- 3 edits2 adds in trunk
2010-10-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work
https://bugs.webkit.org/show_bug.cgi?id=48631
Test: inspector/styles-add-blank-property.html
WebCore:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
LayoutTests:
- inspector/styles-add-blank-property-expected.txt: Added.
- inspector/styles-add-blank-property.html: Added.
- 8:25 AM Changeset in webkit [70879] by
-
- 11 edits in trunk
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass for
resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addResourceToFrame):
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- inspector/front-end/networkPanel.css: (.network-close-button):
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- src/js/Tests.js:
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- inspector/audits-panel-functional.html:
- 8:23 AM Changeset in webkit [70878] by
-
- 17 edits in trunk
Fix and cleanup of build systems
https://bugs.webkit.org/show_bug.cgi?id=48342
Reviewed by Adam Roben and David Kilzer.
.:
- cmake/OptionsEfl.cmake: Remove unnecessary ENABLE_SANDBOX.
- cmakeconfig.h.cmake:
- configure.ac:
- Configurations/FeatureDefines.xcconfig: Add missing ENABLE_FULLSCREEN_API
WebKit/chromium:
- features.gypi: Remove unnecessary ENABLE_SANDBOX.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
WebKit2:
- Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX and add missing features.
WebKitLibraries:
Remove unnecessary ENABLE_SANDBOX.
Add missing features to converge to FeatureDefines.xcconfig.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
WebKitTools:
- Scripts/build-webkit:
- Remove unnecessary ENABLE_SANDBOX option.
- Add ENABLE_FULLSCREEN_API option.
- 8:19 AM Changeset in webkit [70877] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Add 4 more suspicious tests to bug 48634.
https://bugs.webkit.org/show_bug.cgi?id=48634
- platform/chromium/test_expectations.txt:
- 7:43 AM Changeset in webkit [70876] by
-
- 5 edits in trunk/LayoutTests
Update Windows test results after r70854
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 7:33 AM Changeset in webkit [70875] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed, disable tests after r70867.
- platform/chromium/test_expectations.txt:
- 7:19 AM Changeset in webkit [70874] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed, disable tests.
- platform/chromium/test_expectations.txt:
- 6:52 AM Changeset in webkit [70873] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed rebaselines, probably leftover from r70858.
- platform/chromium-mac/fast/images/icon-decoding-expected.checksum: Added.
- platform/chromium-mac/fast/images/icon-decoding-expected.txt: Added.
- platform/chromium-mac/fast/images/pdf-as-background-expected.checksum: Added.
- platform/chromium-mac/fast/images/pdf-as-background-expected.png: Added.
- platform/chromium-mac/svg/custom/createImageElement-expected.checksum: Added.
- platform/chromium-mac/svg/custom/createImageElement-expected.png: Added.
- 6:50 AM Changeset in webkit [70872] by
-
- 37 edits2 adds in trunk/WebCore
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48623
Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support
for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests.
Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings.
- GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept.
- bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAnimatedEnumeration.h: Added.
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.h: Added.
- svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types.
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Ditto. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
- svg/SVGFilterElement.h:
- svg/SVGGradientElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPatternElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextPathElement.h:
- svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties.
- 6:45 AM Changeset in webkit [70871] by
-
- 2 edits in trunk/WebKitTools
Switch the Windows WebKit2 bot to the Release configuration
We only have one machine testing WebKit2 on Windows right now, and
Debug is just too slow for it to keep up.
Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
always way behind
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:44 AM Changeset in webkit [70870] by
-
- 2 edits in trunk/WebCore
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make GraphicsContext cheaper to construct
https://bugs.webkit.org/show_bug.cgi?id=48626
Do less unnecessary things when creating the Qt GraphicsContext:
- Don't create a black QBrush that's immediately discarded.
- Don't call setPlatform*(), set the painter brush and pen directly.
- Call setRenderHints() once instead of multiple setRenderHint().
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext):
- 6:41 AM Changeset in webkit [70869] by
-
- 2 edits in branches/chromium/517/WebCore
Merge 70644 - 2010-10-27 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/4111010
- 6:39 AM Changeset in webkit [70868] by
-
- 2 edits in trunk/WebCore
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary
https://bugs.webkit.org/show_bug.cgi?id=48624
Don't queue multiple meta method invocations for notifySyncRequired()
4% speedup on <http://ariya.github.com/clock.htm>
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange):
- 6:35 AM Changeset in webkit [70867] by
-
- 7 edits in trunk
2010-10-29 Zhenyao Mo <zmo@google.com>
Reviewed by Chris Marrin.
drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601
- fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-arrays-out-of-bounds.html:
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
2010-10-29 Zhenyao Mo <zmo@google.com>
Reviewed by Chris Marrin.
drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements):
- 6:26 AM Changeset in webkit [70866] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed tests checksums update. Also, fix duplicates introduced in r70865.
- platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- 6:06 AM Changeset in webkit [70865] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 5:08 AM Changeset in webkit [70864] by
-
- 15 edits12 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed tests rebaselines after r70843, r70847, r70856
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- 5:00 AM Changeset in webkit [70863] by
-
- 30 edits2 adds in trunk
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
https://bugs.webkit.org/show_bug.cgi?id=47089
- fast/speech/input-text-language-tag-expected.txt: Added.
- fast/speech/input-text-language-tag.html: Added.
- fast/speech/input-text-speechbutton.html:
- fast/speech/speech-button-ignore-generated-events.html:
- platform/chromium/test_expectations.txt:
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.
Test: fast/speech/input-text-language-tag.html
- page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
- page/SpeechInput.h:
- page/SpeechInputClient.h:
- platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- public/WebSpeechInputControllerMock.h:
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
- src/SpeechInputClientImpl.h:
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
- src/WebSpeechInputControllerMockImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089
- DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
- 4:50 AM Changeset in webkit [70862] by
-
- 3 edits3 adds in trunk
2010-10-29 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621
Check that the Date property is an object before attempting to get
hidden properties from it.
Test: fast/dom/Window/slow-unload-handler-overwritten-date.html
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
2010-10-29 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621
- fast/dom/Window/resources/slow-unload-handler-overwritten-date1.html: Added.
- fast/dom/Window/slow-unload-handler-overwritten-date-expected.txt: Added.
- fast/dom/Window/slow-unload-handler-overwritten-date.html: Added.
- 4:25 AM Changeset in webkit [70861] by
-
- 3 edits in trunk/WebKit/gtk
2010-10-29 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add the GtkScrollablePolicy property to the webview
https://bugs.webkit.org/show_bug.cgi?id=48357
Added the GtkScrollablePolicy properties to the webview widget, it
is now required for GtkScrollable widgets in GTK+ 3.x.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (setHorizontalScrollPolicy): Added. (setVerticalScrollPolicy): Added. (getHorizontalScrollPolicy): Added. (getVerticalScrollPolicy): Added. (webkit_web_view_get_property): (webkit_web_view_set_property): (webkit_web_view_class_init):
- 3:32 AM Changeset in webkit [70860] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Oh my, remove a left-over alert(), that I accidently landed.
- svg/dom/SVGScriptElement/resources/script-load4.js:
- 3:31 AM Changeset in webkit [70859] by
-
- 8 edits in trunk/LayoutTests
2010-10-29 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update Qt and GTK expectations for r70854.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 3:11 AM Changeset in webkit [70858] by
-
- 66 edits192 adds16 deletes in trunk/LayoutTests
2010-10-29 Adam Barth <abarth@webkit.org>
Unreviewed.
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
Update chromium-mac expectations for new image decoders. There are a
lot of changed images here, but I think they're correct.
- platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
- platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/zero-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/zero-expected.png: Added.
- platform/chromium-mac/fast/block/float/014-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac/fast/borders/border-fit-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-fit-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
- platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Added.
- platform/chromium-mac/fast/css/contentDiv-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentDiv-expected.png: Added.
- platform/chromium-mac/fast/css/contentDivWithChildren-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentDivWithChildren-expected.png: Added.
- platform/chromium-mac/fast/css/contentImage-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentImage-expected.png: Added.
- platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-align-image-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-type-change-expected.checksum: Added.
- platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-onload-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-sizing-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-tag-expected.checksum: Added.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
- platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
- platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
- platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
- platform/chromium-mac/svg/custom/convolution-crash-expected.checksum: Added.
- platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
- platform/chromium-mac/svg/custom/focus-ring-expected.png:
- platform/chromium-mac/svg/custom/group-opacity-expected.checksum: Added.
- platform/chromium-mac/svg/custom/group-opacity-expected.png: Added.
- platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum: Added.
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Added.
- platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-expected.png: Added.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum: Added.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum: Added.
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum: Added.
- platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
- platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12910-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4523-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png: Added.
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- Now that we now fail a handful of tests more consistently across platforms.
- 2:54 AM Changeset in webkit [70857] by
-
- 52 edits5 adds in trunk
2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469
Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean.
Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details.
Add support for StrictTypeChecking for boolean types.
Test: svg/dom/SVGExternalResourcesRequired.html
- GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list.
- bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling.
- svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed.
- svg/SVGAnimatedBoolean.h: Added.
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h: (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGradientElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPathElement.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGUseElement.h:
- svg/SVGViewElement.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
- svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal. (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes.
- svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types.
- svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
- svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added. (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created. (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto. (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes. (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented. (WebCore::SVGAnimatedStaticPropertyTearOff::create): (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
- svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange.
- svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::commitChange): Ditto.
2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469
Add simple test that SVGAnimatedBooleans aren't creating tear off when accessing baseVal/animVal.
For example with SVGLength you can do:
var foo = rect.x.baseVal; SVGRectElement -> SVGAnimatedLength -> SVGLength
foo.value = 50; affects the SVGRectElement
For SVGExternalResourcesRequired (one of the two SVGAnimatedBoolean types), this is not possible, as baseVal returns a POD type (boolean).
var bar = rect.externalResourcesRequired.baseVal; bar is a boolean
bar = false; does NOT effect the rect.externalResourcesRequired object
- svg/dom/SVGExternalResourcesRequired-expected.txt: Added.
- svg/dom/SVGExternalResourcesRequired.html: Added.
- svg/dom/script-tests/SVGExternalResourcesRequired.js: Added.
- 2:47 AM Changeset in webkit [70856] by
-
- 7 edits4 adds in trunk
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613
- fast/dom/HTMLMeterElement/meter-boundary-values.html: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613
Changed to make the condition inclusive for better case consistently.
- Values on the border between optimum and subsequntial go optimum.
- Values on the border between suboptimal and even-less-than-good go suboptimal.
Test: fast/dom/HTMLMeterElement/meter-boundary-values.html
- html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):
- 2:43 AM Changeset in webkit [70855] by
-
- 19 edits17 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update after r70843.
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/english-rl-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
- platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
- platform/chromium-win/fast/blockflow/english-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png:
- 2:32 AM Changeset in webkit [70854] by
-
- 32 edits4 copies2 adds in trunk
2010-10-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810
- fast/dom/Window/window-properties-expected.txt: Updated expectations.
- fast/dom/Window/window-property-descriptors-expected.txt: Updated expectations.
- fast/dom/prototype-inheritance-2-expected.txt: Updated expectations.
- fast/dom/prototype-inheritance-expected.txt: Updated expectations.
- fast/js/global-constructors-expected.txt: Updated expectations.
2010-10-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810
Adds DOMSettableTokenList interface to support <output> element.
The DOMTokenList interface was refactored since its was tightly coupled
with HTMLElement.classList property.
- Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file.
- Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file.
- Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file.
- Android.mk: Added ClassList.cpp file.
- CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files.
- DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file.
- DerivedSources.make: Added DOMSettableTokenList entry.
- GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files.
- WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files.
- WebCore.pri: Added DOMSettableTokenList.idl file.
- WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
- WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
- WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp}
- bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files.
- bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList.
- bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter):
- dom/Element.cpp: Replaced DOMTokenList to ClassList. (WebCore::Element::classList):
- dom/ElementRareData.h: ditto.
- dom/SpaceSplitString.cpp: Added add() and remove() functions. (WebCore::SpaceSplitStringData::add): (WebCore::SpaceSplitStringData::remove): (WebCore::SpaceSplitString::add): (WebCore::SpaceSplitString::remove):
- dom/SpaceSplitString.h: Added add() and remove() functions.
- dom/StyledElement.cpp: Replaced DOMTokenList to ClassList. (WebCore::StyledElement::classAttributeChanged):
- dom/StyledElement.h: ditto.
- html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp. (WebCore::ClassList::ClassList): (WebCore::ClassList::ref): (WebCore::ClassList::deref): (WebCore::ClassList::length): (WebCore::ClassList::item): (WebCore::ClassList::contains): (WebCore::ClassList::containsInternal): (WebCore::ClassList::add): (WebCore::ClassList::addInternal): (WebCore::ClassList::remove): (WebCore::ClassList::removeInternal): (WebCore::ClassList::toggle): (WebCore::ClassList::toString): (WebCore::ClassList::reset): (WebCore::ClassList::classNames):
- html/ClassList.h: Added, mostly from original DOMTokenList.h. (WebCore::ClassList::create): (WebCore::ClassList::element):
- html/DOMSettableTokenList.cpp: Added. (WebCore::DOMSettableTokenList::DOMSettableTokenList): (WebCore::DOMSettableTokenList::~DOMSettableTokenList): (WebCore::DOMSettableTokenList::item): (WebCore::DOMSettableTokenList::contains): (WebCore::DOMSettableTokenList::add): (WebCore::DOMSettableTokenList::addInternal): (WebCore::DOMSettableTokenList::remove): (WebCore::DOMSettableTokenList::removeInternal): (WebCore::DOMSettableTokenList::toggle): (WebCore::DOMSettableTokenList::setValue):
- html/DOMSettableTokenList.h: Added. (WebCore::DOMSettableTokenList::create): (WebCore::DOMSettableTokenList::ref): (WebCore::DOMSettableTokenList::deref): (WebCore::DOMSettableTokenList::length): (WebCore::DOMSettableTokenList::toString): (WebCore::DOMSettableTokenList::value):
- html/DOMSettableTokenList.idl: Added.
- html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList. (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal(). (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal().
- html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::~DOMTokenList): (WebCore::DOMTokenList::element):
- page/DOMWindow.cpp: Added an entry for DOMSettableTokenList.
- page/DOMWindow.idl: ditto.
- 2:00 AM Changeset in webkit [70853] by
-
- 11 edits in trunk/WebCore
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48532
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
- inspector/InspectorResource.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): (WebInspector.Resource.prototype._checkWarning):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
- inspector/front-end/inspector.js:
- 1:23 AM Changeset in webkit [70852] by
-
- 2 edits in trunk/WebCore
2010-10-29 MORITA Hajime <morrita@google.com>
Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847
- editing/EditingAllInOne.cpp:
- 1:08 AM Changeset in webkit [70851] by
-
- 4 edits in trunk
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809
fast/loader/stateobjects/pushstate-object-types.html now passes.
- platform/chromium/test_expectations.txt:
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809
Add RegExp serialization/deserialization now that V8 provides API access
to the RegExp type.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Writer::writeRegExp): (WebCore::ZigZag::Serializer::writeRegExp): (WebCore::ZigZag::Serializer::doSerialize): (WebCore::ZigZag::Reader::read): (WebCore::ZigZag::Reader::readRegExp):
- 12:49 AM Changeset in webkit [70850] by
-
- 7 edits in trunk/WebCore
2010-10-13 MORITA Hajime <morrita@google.com>
Reviewed by David Hyatt.
Navigating dark background websites results in blinding white flashes between pages.
https://bugs.webkit.org/show_bug.cgi?id=45640
This FOUC is caused by an early layout request before the <body> is ready,
and the page's background style given for <body>, instead of <html>.
So many sites have such stylesheets that we should care them.
- Some DOM operation such as 'element.offsetLeft' causes page layout.
- The page layout results page repaint
- The page page repaint makes a white screen. because there is nothing to paint before <body> is available.
This change:
- extracted existing FOUC check on RenderBlock and RenderLayer to Document::mayCauseFlashOfUnstyledContent(),
- checked <body> availability on mayCauseFlashOfUnstyledContent(), and
- added FOUC guards before requesting reapint on FrameView.
No new tests. The data loading speed matters and it cannot be
captured by DRT.
- dom/Document.cpp: (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
- dom/Document.h:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): Added a guard. (WebCore::FrameView::repaintContentRectangle): Added a guard. (WebCore::FrameView::doDeferredRepaints): Added a guard. (WebCore::FrameView::shouldUpdate): Added.
- page/FrameView.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
- 12:16 AM Changeset in webkit [70849] by
-
- 2 edits in branches/chromium/552/WebCore/inspector
Merge 70799 - 2010-10-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix pausing on next JavaScript statement
https://bugs.webkit.org/show_bug.cgi?id=48534
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
- inspector/InspectorDebuggerAgent.h:
TBR=podivilov@chromium.org
BUG=61195
- 12:07 AM Changeset in webkit [70848] by
-
- 8 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48618
Reviewed by Dan Bernstein.
WebCore:
Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.
Added fast/blockflow/border-radius-clipping-vertical-lr.html.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.
Added fast/blockflow/border-radius-clipping-vertical-lr.html.
- fast/blockflow/border-radius-clipping-vertical-lr.html: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
Oct 28, 2010:
- 11:58 PM Changeset in webkit [70847] by
-
- 9 edits2 adds in trunk/WebCore
2010-10-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287
Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
- editing/TextCheckingHelper.h: Added.
- 11:55 PM Changeset in webkit [70846] by
-
- 13 edits1 add in trunk
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
Enable WebKit's image decoders.
- features.gypi:
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
This patch teaches WebKit's image decoders how to talk to CoreGraphics.
This patch doesn't handle color profiles, but that will come in a
subsequent patch.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
- platform/graphics/ImageSource.h:
- platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize):
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cg: Added.
- platform/image-decoders/cg/ImageDecoderCG.cpp: Added. (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage):
- 11:45 PM Changeset in webkit [70845] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 11:32 PM Changeset in webkit [70844] by
-
- 2 edits in trunk/WebCore
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] GObject bindings generator issues
https://bugs.webkit.org/show_bug.cgi?id=48135
GObject code generator must not generate conditional API's. This
patch also adds an alternative return value for non-void
conditional methods. With this change the conditionalMethods hack
is no longer needed.
- bindings/scripts/CodeGeneratorGObject.pm:
- 11:30 PM Changeset in webkit [70843] by
-
- 17 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48569
Reviewed by Dan Bernstein.
Box shadows on vertical inlines don't paint properly. Fix the paintBoxShadow method to treat the edges to include as
logical (so that top/bottom are used instead of left/right for vertical lines). In order to make my box-shadow tests
work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to
be wrong.
Added fast/blockflow/box-shadow-* tests
WebCore:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderBoxModelObject.h:
LayoutTests:
- fast/blockflow/box-shadow-horizontal-bt.html: Added.
- fast/blockflow/box-shadow-vertical-lr.html: Added.
- fast/blockflow/box-shadow-vertical-rl.html: Added.
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
- platform/mac/fast/blockflow/english-lr-text-expected.checksum:
- platform/mac/fast/blockflow/english-lr-text-expected.png:
- platform/mac/fast/blockflow/english-rl-text-expected.checksum:
- platform/mac/fast/blockflow/english-rl-text-expected.png:
- platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/mac/fast/blockflow/japanese-lr-text-expected.png:
- platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/mac/fast/blockflow/japanese-rl-text-expected.png:
- 10:22 PM Changeset in webkit [70842] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
Disable new test added in http://trac.webkit.org/changeset/70840.
- platform/chromium/test_expectations.txt:
- 9:54 PM Changeset in webkit [70841] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Not reviewed, fix test expectations.
- platform/chromium-win/fast/table/simple_paint-expected.checksum: Added.
- platform/chromium-win/fast/table/simple_paint-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:48 PM Changeset in webkit [70840] by
-
- 3 edits5 adds in trunk
2010-10-28 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570
Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.
- fast/repaint/iframe-scroll-repaint.html: Added.
- fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
2010-10-28 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570
Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.
Test: fast/repaint/iframe-scroll-repaint.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 9:31 PM Changeset in webkit [70839] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Not reviewed, test_expectations fix.
- platform/chromium/test_expectations.txt:
- 9:19 PM Changeset in webkit [70838] by
-
- 4 edits in trunk
LLVM compiler build fix
WebKit/mac:
Reviewed by Mark Rowe.
- Misc/WebDownload.mm:
(-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
WebKit2:
- WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didReceiveResponse:]): Removed a stray semicolon.
- 8:50 PM Changeset in webkit [70837] by
-
- 12 edits2 deletes in trunk
2010-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70814.
http://trac.webkit.org/changeset/70814
https://bugs.webkit.org/show_bug.cgi?id=48612
Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).
- media/video-seek-by-small-increment-expected.txt: Removed.
- media/video-seek-by-small-increment.html: Removed.
2010-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70814.
http://trac.webkit.org/changeset/70814
https://bugs.webkit.org/show_bug.cgi?id=48612
Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek):
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/QTMovie.cpp:
- platform/graphics/win/QTMovie.h:
- 8:20 PM Changeset in webkit [70836] by
-
- 5 edits6 adds in trunk/WebKit2
Move some function definitions from WebEvent.h into new .cpp files
Someday maybe we'll split the classes into their own header files,
too.
Fixes <http://webkit.org/b/48604>.
Reviewed by Anders Carlsson.
- Shared/WebEvent.h: Moved code from here...
- Shared/WebEvent.cpp: Added.
- Shared/WebKeyboardEvent.cpp: Added.
- Shared/WebMouseEvent.cpp: Added.
- Shared/WebPlatformTouchPoint.cpp: Added.
- Shared/WebTouchEvent.cpp: Added.
- Shared/WebWheelEvent.cpp: Added.
...to here. Also changed WebTouchEvent::touchPoints not to copy the
Vector.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Added the new files.
- 7:56 PM Changeset in webkit [70835] by
-
- 197 edits196 copies3 adds in trunk/LayoutTests
2010-10-28 James Robinson <jamesr@chromium.org>
Update the pixel expectations for fast/tables for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests --tolerance 0,
this moves the current pixel results to mac-leopard and adds new Snow Leopard-specific
results to platform/mac.
List of files omitted due to length but composed entirely of moves from platform/mac to
platform/mac-leopard and newly added files in platform/mac.
- 7:35 PM Changeset in webkit [70834] by
-
- 3 edits2 adds in trunk
<rdar://problem/8597430> Crash triggered by incremental layout of block truncated by line-clamp
https://bugs.webkit.org/show_bug.cgi?id=48602
Reviewed by Simon Fraser.
WebCore:
Test: fast/flexbox/line-clamp-crash.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(),
since layout itself may be partial and not touch the truncated line (but touch its markup box).
LayoutTests:
- fast/flexbox/line-clamp-crash-expected.txt: Added.
- fast/flexbox/line-clamp-crash.html: Added.
- 6:29 PM Changeset in webkit [70833] by
-
- 3 edits in trunk/WebKit2
Move code to dispatch a sync message out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=48605
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
Factor code out from dispatchMessage. Handle receiving a message with an invalid reply ID.
(CoreIPC::Connection::dispatchMessages):
Call dispatchSyncMessage.
- Platform/CoreIPC/Connection.h:
- 6:28 PM Changeset in webkit [70832] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Uneviewed, test_expectations fix.
Re-suppress few test from a bunch re-enabled by http://trac.webkit.org/changeset/70823.
They have some old issues still.
- platform/chromium/test_expectations.txt:
- 6:28 PM Changeset in webkit [70831] by
-
- 1 edit in branches/chromium/552/WebCore/platform/UUID.cpp
Merge 70830 - [chromium] UUID generation does not work in Linux that has sandbox
turned on
https://bugs.webkit.org/show_bug.cgi?id=48571
BUG=59680
TEST=none
Reviewed by Dmitry Titov.
This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- 6:12 PM Changeset in webkit [70830] by
-
- 2 edits in trunk/WebCore
[chromium] UUID generation does not work in Linux that has sandbox
turned on
https://bugs.webkit.org/show_bug.cgi?id=48571
Reviewed by Dmitry Titov.
This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- 5:43 PM Changeset in webkit [70829] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Include stddef.h unconditionally in Assertions.h
https://bugs.webkit.org/show_bug.cgi?id=48573
There is no reason to have stddef.h include be MSVC-only.
- wtf/Assertions.h:
- 5:23 PM WebKit Team edited by
- (diff)
- 5:21 PM Changeset in webkit [70828] by
-
- 2 edits2 adds in trunk/WebKit2
Add NPObjectMessageReceiver class.
https://bugs.webkit.org/show_bug.cgi?id=48599
Reviewed by Darin Adler.
- Shared/Plugins/NPObjectMessageReceiver.cpp: Added.
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
- Shared/Plugins/NPObjectMessageReceiver.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 5:16 PM WebKit Team edited by
- Add new committer(Gyuyoung Kim) to list (diff)
- 5:15 PM Changeset in webkit [70827] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed fix for test_expectations.
Temporarily suppress new tests that fail in Chromium port.
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [70826] by
-
- 14 edits6 adds in trunk
2010-10-28 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>
- platform/mac-leopard/Skipped: New tests don't apply to this platform.
- platform/mac-snowleopard/Skipped: Ditto.
- platform/mac-tiger/Skipped: Ditto.
- platform/mac-wk2/Skipped: Ditto.
- platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
- platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
- platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
- platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
- platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
- platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
- platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
- platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.
2010-10-28 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>
Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
platform/mac/editing/spelling/editing-word-with-marker-2.html
This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
spelling checking finds spelling error in newlly formed words, it will add the markers back in.
- dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
- dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove markers with specific type from a node. (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type. (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring. (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
- dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
- editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word. (WebCore::Editor::cut): Remove markers on words that will be modified by this editing. (WebCore::Editor::paste): Ditto. (WebCore::Editor::pasteAsPlainText): Ditto. (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing markers on words affected by editing.
- editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited(). Added REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing. (WebCore::TypingCommand::deleteKeyPressed): Ditto. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- 4:43 PM Changeset in webkit [70825] by
-
- 4 edits in trunk
Part of <https://bugs.webkit.org/show_bug.cgi?id=45980>
userscripts/user-script-*-document.html tests are flaky on Windows
Reviewed by Brady Eidson.
WebCore:
In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.
We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.
This is tested by re-enabling user-script-plugin-document.html on Windows.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):
LayoutTests:
Unskip the user-script-plugin-document test because its issue is fixed.
- platform/win/Skipped:
- 4:41 PM Changeset in webkit [70824] by
-
- 2 edits1 move2 adds2 deletes in trunk/WebKitSite
2010-10-28 Lucas Forschler <Lucas Forschler>
Reviewed by Geoffrey Garen.
Bug 46927 - Sunspider 0.9 web site should prominently link to Sunspider 0.9.1
Notes:
-Created a new sunspider "landing" page which lists current and previous versions of SunSpider.
-Edited the .htaccess file to redirect the old pages to the new landing page.
-This should keep our search engine page rankings effective.
Potentially breaking:
-This COULD potentially break the SunSpider benchmark.
-Local testing with relative links seems to function as expected.
-The .htaccess 301 redirects are UNTESTED.
- .htaccess:
- perf/sunspider: Added.
- perf/sunspider-0.9.1/sunspider.html: Removed.
- perf/sunspider-0.9.1/versions.html: Removed.
- perf/sunspider-0.9/sunspider.html: Removed.
- perf/sunspider/sunspider.css: Added.
- perf/sunspider/sunspider.html: Added.
- 4:20 PM Changeset in webkit [70823] by
-
- 8 edits in trunk
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Remove test_expectations.txt lines for tests that now pass.
- platform/chromium/test_expectations.txt:
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Remove backItem(), forwardItem() and currentItem() from the Chromium
BackForwardList implementation, since they can use the base class
behavior now (which call itemAtIndex with -1, 1, and 0 respectively).
- history/BackForwardList.h:
- history/BackForwardListChromium.cpp:
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Since r70723 made BackForwardList::currentItem no longer be virtual,
we were not reaching the implementation in Chromium's
BackForwardListClientImpl, and for Chromium currentItem is not the same
as itemAtIndex(0).
The fix is to make itemAtIndex(0) have the currentItem() behavior, which
lets us keep currentItem as non-virtual (and remove its implementation
from the Chromium side).
This also switches Chromium to use the default implementation of
backItem() and forwardItem() (vs. the old stubs that just had
ASSERT_NOT_REACHED) since they're actually reacheable with Chromium
code thanks to the calls in FrameLoader::checkDidPerformFirstNavigation.
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- src/BackForwardListClientImpl.h:
- 4:19 PM Changeset in webkit [70822] by
-
- 5 edits in trunk/WebKitTools
2010-10-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add a result-small.json file for the test dashboard
https://bugs.webkit.org/show_bug.cgi?id=48547
Output both a results.json file and a results-small.json file.
The dashboard will load results-small.json by default so it loads faster.
- TestResultServer/model/jsonresults.py:
- TestResultServer/model/jsonresults_unittest.py: Added a bunch of sys.path hackery. Unforunately, this uses hardcoded paths. That obviously needs to be fixed, but at least this way it clearly documents what paths are necessary.
- 4:07 PM Changeset in webkit [70821] by
-
- 3 edits2 adds in trunk
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
https://bugs.webkit.org/show_bug.cgi?id=47888
The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle
not considering the case where startNode is the root editable element.
Fixed the bug by not entering the loop when startNode is the editable root.
Test: editing/style/fix-range-from-root-editable-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
https://bugs.webkit.org/show_bug.cgi?id=47888
Added a test to ensure ApplyStyleCommand::fixRangeAndApplyInlineStyle doesn't crash
when startNode is body and it is, therefore, the editable root.
Note that the test does not reproduce the crash when DOCTYPE is added.
- editing/style/fix-range-from-root-editable-crash-expected.txt: Added.
- editing/style/fix-range-from-root-editable-crash.html: Added.
- 4:01 PM Changeset in webkit [70820] by
-
- 7 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload calls changed_files more often than it should
https://bugs.webkit.org/show_bug.cgi?id=48567
Passing changed_files around everywhere isn't a very elegant solution
but it's the one we have for the moment. I think keeping an explicit
cache on Checkout (or making StepState() a real class) is a better
long-term option.
Previously bug_id_for_this_commit was calling changed_files and the
result was never getting cached on the state. Now we're explicitly
caching the result on the state and passing that to the bug_id_for_this_commit call.
I looked into building unit tests for this. Doing so would require
using a real Checkout object with a MockSCM and overriding the appropriate
calls on SCM to count how often we're stating the file system.
That's a useful set of tests to build for a separate change.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/mocktool.py:
- 3:57 PM Changeset in webkit [70819] by
-
- 8 edits in trunk
2010-10-28 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix, some wrong changes slipped into the previous patch.
No new tests: build fix.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::setContentsToImage):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::TextureMapperNode::uploadTextureFromContent): (WebCore::TextureMapperNode::paintRecursive):
- platform/qt/QWebPageClient.h: (QWebPageClient::setRootGraphicsLayer):
2010-10-28 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix,
- WebCoreSupport/PageClientQt.cpp: (WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
- 3:27 PM Changeset in webkit [70818] by
-
- 4 edits in trunk/LayoutTests
2010-10-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Missing expectation file changes from bug 47853.
https://bugs.webkit.org/show_bug.cgi?id=48564
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- 3:17 PM Changeset in webkit [70817] by
-
- 5 edits2 copies in branches/chromium/552
Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.
Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
- html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
- fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
- fast/dom/object-plugin-hides-properties.html: Ditto.
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
TBR=cpu@google.com
BUG=57986
- 3:12 PM Changeset in webkit [70816] by
-
- 3 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48568
Reviewed by James Robinson.
WebCore:
Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.
Added fast/blockflow/background-* tests
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
LayoutTests:
Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.
- fast/blockflow/background-horizontal-bt.html: Added.
- fast/blockflow/background-vertical-lr.html: Added.
- fast/blockflow/background-vertical-rl.html: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.txt: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt: Added.
- 2:56 PM Changeset in webkit [70815] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make suggest-reviewers slightly faster
https://bugs.webkit.org/show_bug.cgi?id=48562
Add @memoized to one more common call.
- Scripts/webkitpy/common/checkout/api.py:
- 2:46 PM Changeset in webkit [70814] by
-
- 12 edits2 adds in trunk
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
Test: media/video-seek-by-small-increment.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
- platform/graphics/win/QTMovie.h:
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
- media/video-seek-by-small-increment-expected.txt: Added.
- media/video-seek-by-small-increment.html: Added.
- 2:44 PM Changeset in webkit [70813] by
-
- 3 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48443
Reviewed by Beth Dakin.
Border images don't work right with vertical RenderInlines. Make border/mask/background painting
do the right thing for vertical strips.
WebCore:
Added fast/blockflow/border-image-* tests.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
LayoutTests:
- fast/blockflow/border-image-horizontal-bt.html: Added.
- fast/blockflow/border-image-vertical-lr.html: Added.
- fast/blockflow/border-image-vertical-rl.html: Added.
- 2:41 PM Changeset in webkit [70812] by
-
- 2 edits in trunk/WebCore
2010-10-28 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407
- platform/win/ContextMenuItemWin.cpp:
- 2:38 PM Changeset in webkit [70811] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
https://bugs.webkit.org/show_bug.cgi?id=48536
This patch makes it about 40 seconds faster, but it still
takes 1:40. This will require more refinement.
The suggested reviewers list appears to be the same.
I think the next step may be to have it stop the search after
5 reviewers are found. We never want to suggest 30 people.
- Scripts/webkitpy/common/checkout/scm.py:
- Using --remove-empty to theoretically stop lookups past when a file is removed. I'm not entirely clear that the option does what it says it does. Example: git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h returns only one commit vs. git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h which returns 5. I was not aware that wx files were ever removed from the repository?
- 2:38 PM Changeset in webkit [70810] by
-
- 5 edits in trunk
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue should fall back to queryCommandState
https://bugs.webkit.org/show_bug.cgi?id=48479
Added a fallback to Command::value so that commands with a state function without a value function
returns the value returned by the state function as a string.
- editing/EditorCommand.cpp: (WebCore::Editor::Command::value):
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue should fall back to queryCommandState
https://bugs.webkit.org/show_bug.cgi?id=48479
Modified the existing tests to ensure queryCommandValue returns 'true' or 'false'
for commands that supports queryCommandState.
- editing/execCommand/script-tests/query-command-state.js: (testQueryCommandState):
- editing/execCommand/script-tests/query-text-alignment.js: (isEquivalentBoolean): (queryTextAlignment):
- 2:35 PM Changeset in webkit [70809] by
-
- 2 edits2 adds in trunk/WebKit2
Add NPObjectProxy class
https://bugs.webkit.org/show_bug.cgi?id=48558
Reviewed by Sam Weinig.
- Shared/Plugins/NPObjectProxy.cpp: Added.
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::~NPObjectProxy):
- Shared/Plugins/NPObjectProxy.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [70808] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Martin Robinson <mrobinson@igalia.com>
Unskip some passing canvas tests on GTK+. These were
likely fixed by the recent shadow changes.
- platform/gtk/Skipped: Unskip passing tests.
- 2:16 PM Changeset in webkit [70807] by
-
- 3 edits6 deletes in trunk/LayoutTests
Remove test expectations obsoleted by r70619.
- platform/chromium-linux/fast/block/float/tableshifting-expected.checksum: Removed.
- platform/chromium-linux/fast/block/float/tableshifting-expected.png: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.checksum: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.png: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.txt: Removed.
- platform/gtk/Skipped: Unskip fast/block/float/tableshifting.html
- platform/qt/Skipped: Ditto.
- platform/qt/fast/block/float/tableshifting-expected.txt: Removed.
- 2:15 PM UsingGitWithWebKit edited by
- (diff)
- 2:09 PM Changeset in webkit [70806] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, updating drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 2:09 PM Changeset in webkit [70805] by
-
- 12 edits in trunk/WebCore
2010-10-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r70800.
- 1:35 PM Changeset in webkit [70804] by
-
- 3 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=48551
HTMLDocument::isFrameSet() should not depend on renderer
No change in functionality, so no new tests.
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer.
- rendering/RenderLayer.h: Removed unneeded includes and forward declarations.
- 1:30 PM Changeset in webkit [70803] by
-
- 3 edits52 adds in trunk/LayoutTests
2010-10-28 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Unskip remaining canvas layout tests so that they can track progressions/regressions
https://bugs.webkit.org/show_bug.cgi?id=46439
- platform/mac-leopard/Skipped: Moving overall mac skipped tests down to specifically leopard skipped.
- platform/mac-snowleopard/canvas/philip/tests: Added snowleopard specific expectation files for now unskipped tests.
- platform/mac/Skipped: Unskipped all canvas tests that we want to track. Commented why the test that remain on the list are there.
- 1:23 PM Changeset in webkit [70802] by
-
- 2 edits3 adds in trunk/WebKit2
Add NPRemoteObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=48553
Reviewed by Sam Weinig.
- Shared/Plugins/NPRemoteObjectMap.cpp: Added.
(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
- Shared/Plugins/NPRemoteObjectMap.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [70801] by
-
- 6 edits4 copies in branches/chromium/552
Merge 70797
BUG=55215
- 1:22 PM Changeset in webkit [70800] by
-
- 12 edits in trunk/WebCore
2010-10-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48532
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
- inspector/InspectorResource.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 1:13 PM Changeset in webkit [70799] by
-
- 3 edits in trunk/WebCore
2010-10-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix pausing on next JavaScript statement
https://bugs.webkit.org/show_bug.cgi?id=48534
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
- inspector/InspectorDebuggerAgent.h:
- 1:01 PM QtWebKitTableOfFeatures46 edited by
- (diff)
- 12:48 PM QtWebKitPerformanceWork edited by
- (diff)
- 12:46 PM Changeset in webkit [70798] by
-
- 24 edits3 copies in branches/chromium/552
Merge 70741 - 2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
DOMFileSystem's reference should be kept while there're any active Entries/callbacks
https://bugs.webkit.org/show_bug.cgi?id=47535
Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.
BUG=61040
TEST=fast/filesystem/filesystem-reference.html
- 12:43 PM QtWebKitMirrorGuide edited by
- (diff)
- 12:30 PM Changeset in webkit [70797] by
-
- 8 edits4 adds in trunk
2010-10-28 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix for Bug 14550 - Non-layout style change does not update nested first-letter
https://bugs.webkit.org/show_bug.cgi?id=14550
If a render text fragment is accompanied by a first letter, update the
first letter's style when the fragment's style is changed.
Test: fast/css/first-letter-nested.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter from here.
- rendering/RenderBlock.h: Make updateFirstLetter accessbile from RenderTextFragment.
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::styleDidChange): If appropriate, update first letter after removing stale cached pseudo style. (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper to get the block for the first letter.
- rendering/RenderTextFragment.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified pseudo style from cache.
- rendering/style/RenderStyle.h:
2010-10-28 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix for Bug 14550 - Non-layout style change does not update nested first-letter
https://bugs.webkit.org/show_bug.cgi?id=14550
- fast/css/first-letter-nested-expected.txt: Added.
- fast/css/first-letter-nested.html: Added.
- fast/css/first-letter-removed-added-expected.txt: Added.
- fast/css/first-letter-removed-added.html: Added.
- 12:30 PM QtWebKitFeatures46 edited by
- (diff)
- 12:29 PM QtWebKitFeatures20 edited by
- (diff)
- 12:27 PM QtWebKitContrib edited by
- (diff)
- 12:21 PM QtWebKit edited by
- (diff)
- 12:17 PM Changeset in webkit [70796] by
-
- 7 edits in trunk
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
[Chromium] Support FileSystem in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=47643
Update the chromium DEPS to pick up corresponding webkit_support change.
Also add a temporary glue implementation with FIXME comment to
WebFrameClient::openFileSystem.
- DEPS:
- public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
[Chromium] Support FileSystem in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=47643
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::openFileSystem): Added.
- DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::openFileSystem): Added.
- 12:09 PM Changeset in webkit [70795] by
-
- 5 edits in trunk
WKURLRefs should be allowed to be null
<rdar://problem/8575621>
https://bugs.webkit.org/show_bug.cgi?id=48535
Reviewed by Anders Carlsson.
WebKit2:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toURLRef):
(WebKit::toCopiedURLAPI):
Turn a null WTF::String into a null WKURLRef.
WebKitTools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
Test that URLs are null pointers when unset.
- 12:05 PM Changeset in webkit [70794] by
-
- 5 edits in trunk/LayoutTests
2010-10-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add shouldBeDefined function to js-test-pre.js and update
context-attributes-etc test to use it.
https://bugs.webkit.org/show_bug.cgi?id=47853
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/js/resources/js-test-pre.js: (shouldBeDefined):
- 12:04 PM Changeset in webkit [70793] by
-
- 2 edits in trunk/WebCore
2010-10-28 Benoit Jacob <bjacob@mozilla.com>
Reviewed by Kenneth Russell.
Ensure that WebGL stencil buffers are correctly initialized
https://bugs.webkit.org/show_bug.cgi?id=48351
- html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::initializeRenderbuffers):
- 11:54 AM Changeset in webkit [70792] by
-
- 7 edits2 adds in trunk
AX: multi select group option does not handle setting of AXSelectedChildren correctly
https://bugs.webkit.org/show_bug.cgi?id=48464
Reviewed by Adele Peterson.
WebCore:
Ensure that when selecting an item from a <select> element, it accounts for <optgroups>.
Test: platform/mac/accessibility/select-element-selection-with-optgroups.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::setSelected):
WebKitTools:
Add support for querying information about selected children to DRT, including:
selectedChildAtIndex
selectedChildrenCount
setSelectedChild
- DumpRenderTree/AccessibilityUIElement.cpp:
(selectedChildAtIndexCallback):
(setSelectedChildCallback):
(selectedChildrenCountCallback):
(AccessibilityUIElement::setSelectedChild):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::setSelectedChild):
LayoutTests:
- platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt: Added.
- platform/mac/accessibility/select-element-selection-with-optgroups.html: Added.
- 11:28 AM Changeset in webkit [70791] by
-
- 4 edits in trunk/WebKitLibraries
Added UniCharProvider-based ways to create a CTTypeSetter and a CTLine, to be used in an
upcoming ComplexTextController patch.
Reviewed by John Sullivan.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 11:21 AM Changeset in webkit [70790] by
-
- 13 edits in trunk
Add WebKit2 API for window feature getter/setters
<rdar://problem/8590373>
https://bugs.webkit.org/show_bug.cgi?id=48496
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setToolbarsAreVisible):
(WebKit::WebPageProxy::getToolbarsAreVisible):
(WebKit::WebPageProxy::setMenuBarIsVisible):
(WebKit::WebPageProxy::getMenuBarIsVisible):
(WebKit::WebPageProxy::setStatusBarIsVisible):
(WebKit::WebPageProxy::getStatusBarIsVisible):
(WebKit::WebPageProxy::setIsResizable):
(WebKit::WebPageProxy::getIsResizable):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::setResizable):
Plumb through the calls.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 11:08 AM Changeset in webkit [70789] by
-
- 3 edits in trunk/WebKitTools
2010-10-28 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Tony Chang.
Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
https://bugs.webkit.org/show_bug.cgi?id=48236
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 10:37 AM Changeset in webkit [70788] by
-
- 6 edits in trunk
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
- platform/gtk/Skipped: unskipped a couple of tests
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
"frame-created" signal must be issued before loading any data,
that way clients can correctly capture all the loading related
signals for that frame.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
DRT now listens to WebKitWebFrame load-status signals for each
created frame instead of the load-status signal of the
WebKitWebView that only notifies about changes in the main frame.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webFrameLoadStatusNotified): (frameCreatedCallback): (createWebView): (main):
- 10:19 AM Changeset in webkit [70787] by
-
- 2 edits in trunk/WebKit2
Build fix.
- win/WebKit2Common.vsprops:
- 10:10 AM Changeset in webkit [70786] by
-
- 4 edits in trunk
2010-10-28 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix textInputController.{selectedRange,markedRange}
https://bugs.webkit.org/show_bug.cgi?id=48487
- platform/chromium/test_expectations.txt: correct some comments about
firstRectForCharacterRange.
2010-10-28 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix textInputController.{selectedRange,markedRange}
https://bugs.webkit.org/show_bug.cgi?id=48487
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): Return arrays of ints, rather than a string (TextInputController::selectedRange): Ditto.
- 9:53 AM Changeset in webkit [70785] by
-
- 6 edits in trunk
No longer soft-link zlib
https://bugs.webkit.org/show_bug.cgi?id=48004
Reviewed by Adam Roben.
WebCore:
- platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfnt): Removed Windows-speciific code to soft-link
zlib.
WebKit2:
- win/WebKit2Common.vsprops: Added zlib.lib to AdditionalDependencies.
LayoutTests:
- platform/win/Skipped: Enabled fast/css/font-face-woff.html.
- 9:51 AM Changeset in webkit [70784] by
-
- 6 edits in trunk
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Work around a Mac driver bug in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=48489
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to NEAREST_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value.
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getMinFilter): Return the cached minFilter value.
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Work around a Mac driver bug in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=48489
- fast/canvas/webgl/texture-npot-expected.txt: Add back the failing part due to the generateMipmap Mac driver bug.
- fast/canvas/webgl/texture-npot.html: Ditto.
- 9:38 AM Changeset in webkit [70783] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed fix for test_expectations.
- platform/chromium/test_expectations.txt:
- 9:27 AM Changeset in webkit [70782] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add a master-name flag to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48488
The test results server now allows adding a master name to
the uploaded files. This lets us distinguish bots that have
the same name, but are on different masters.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 9:14 AM Changeset in webkit [70781] by
-
- 5 edits in trunk
Make PluginView retain its HTMLPlugInElement
This matches WebKit/mac's WebBaseNetscapePluginView. WebCore didn't do
this, but had a very different mechanism for implementing NPRuntime
that didn't require it.
Fixes <http://webkit.org/b/46672> <rdar://problem/8484208> Crash
(preceded by assertion) in Node::document when running
plugins/document-open.html in WebKit2 on Windows
Reviewed by Anders Carlsson.
LayoutTests:
Remove plugins/document-open.html from the win-wk2 Skipped file
It passes now that <http://webkit.org/b/46672> is fixed.
- platform/win-wk2/Skipped:
WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::create): Moved here from the header file so that
clients of the header file won't have to pull in HTMLPlugInElement.h.
Changed to take a PassRefPtr<HTMLPlugInElement>.
(WebKit::PluginView::PluginView): Changed to take a
PassRefPtr<HTMLPlugInElement> and to use m_pluginElement later (because
the parameter to the function will be nulled-out after assigning into
m_pluginElement).
(WebKit::PluginView::pluginElementNPObject): Updated for change to m_pluginElement.
- WebProcess/Plugins/PluginView.h: Made m_pluginElement a RefPtr.
- 9:13 AM Changeset in webkit [70780] by
-
- 2 edits in trunk/WebKitTools
Don't append a newline to the test output if the frame has no document element in WebKitTestRunner
Fixes <http://webkit.org/b/48526> Extra trailing newline when running
plugins/document-open.html in WebKitTestRunner
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
(WTR::hasDocumentElement): Added. Uses the JSC API to figure out
whether the frame has a document element.
(WTR::dumpFrameText): Match DRT by bailing (rather than appending an
empty string and a newline) if the frame has no document element.
- 9:13 AM Changeset in webkit [70779] by
-
- 3 edits in trunk/LayoutTests
Recategorize the failure of plugins/mouse-events.html for WebKit2
This should have been done in r70685.
- platform/mac-wk2/Skipped: Moved plugins/mouse-events.html into the
"Need eventSender" category...
- platform/win-wk2/Skipped: ...from here.
- 9:05 AM Changeset in webkit [70778] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QWebElement: Don't retrieve CSS rules through DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=48519
Reviewed by Andreas Kling.
JavaScript is prevented from retrieving cross-domain CSS rules since r70335.
This patch allow QWebElement to retrive style without this limitation
by asking the Document directly instead of going through DOMWindow.
Fixes:
- tst_QWebFrame::setHtmlWithResource()
- tst_QWebElement::style()
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 8:49 AM Changeset in webkit [70777] by
-
- 4 edits in trunk
2010-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make Qt viewportAttributesForSize not assert on (0, 0) size
https://bugs.webkit.org/show_bug.cgi?id=48524
We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).
- Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):
2010-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make Qt viewportAttributesForSize not assert on (0, 0) size
https://bugs.webkit.org/show_bug.cgi?id=48524
We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
- 7:52 AM Changeset in webkit [70776] by
-
- 2 edits in trunk/WebKit2
2010-10-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] SharedMemory should be released by the receiving process
https://bugs.webkit.org/show_bug.cgi?id=48520
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
- 7:23 AM Changeset in webkit [70775] by
-
- 3 edits in trunk/WebCore
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium clang] Unreviewed. Fix forward declaration of 'struct FileMetadata'.
- fileapi/FileSystemCallbacks.h:
- platform/AsyncFileSystemCallbacks.h:
- 7:03 AM Changeset in webkit [70774] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Remove rule for non-existent long-css-selector-matches test.
- platform/chromium/test_expectations.txt:
- 6:50 AM Changeset in webkit [70773] by
-
- 2 edits in trunk/WebKitTools
Skip npn-invalidate-rect-invalidates-window.html on headless XP machines
TestNetscapePlugIn never receives a WM_PAINT message on headless XP
machines, so this test times out. Fixing the test is covered by
<http://webkit.org/b/48333>.
- Scripts/old-run-webkit-tests: Skip
npn-invalidate-rect-invalidates-window.html on Windows if accelerated
compositing support is disabled, which likely means we're on a headless
XP machine.
- 6:27 AM Changeset in webkit [70772] by
-
- 11 edits in trunk
2010-10-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Bring backend-frontend message format to follow the protocol specification
https://bugs.webkit.org/show_bug.cgi?id=48406
WebCore:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.parseRuleArrayPayload): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setCSSText):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parsePayload): (WebInspector.CSSStyleDeclaration.prototype.get allProperties): (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSRule): (WebInspector.CSSRule.parsePayload): (WebInspector.CSSRule.prototype.get isUserAgent): (WebInspector.CSSRule.prototype.get isUser): (WebInspector.CSSRule.prototype.get isViaInspector): (WebInspector.CSSRule.prototype.get isRegular): (WebInspector.CSSProperty): (WebInspector.CSSProperty.parsePayload): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.get isLive): (WebInspector.CSSProperty.prototype.get active): (WebInspector.CSSProperty.prototype.get styleBased): (WebInspector.CSSProperty.prototype.get inactive): (WebInspector.CSSProperty.prototype.get disabled): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update.callback): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback): (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.callback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): (WebInspector.StylePropertyTreeElement): (WebInspector.StylePropertyTreeElement.prototype.get disabled): (WebInspector.StylePropertyTreeElement.prototype.get name): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype.get parsedOk): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
LayoutTests:
- http/tests/inspector/inspect-iframe-from-different-domain.html:
- inspector/styles-source-offsets.html:
- 6:04 AM Changeset in webkit [70771] by
-
- 6 edits in branches/chromium/552
Merge 70682 - 2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
- http/tests/inspector/resource-parameters.html:
- inspector/audits-panel-functional.html:
- inspector/styles-source-offsets.html:
2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
TBR=apavlov@chromium.org
BUG=60929
- 6:01 AM Changeset in webkit [70770] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Update expectation for linux javascriptlink-frames.html
- platform/chromium/test_expectations.txt:
- 5:56 AM Changeset in webkit [70769] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-28 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=48504
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- 5:37 AM Changeset in webkit [70768] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Rebaseline test results.
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 5:19 AM Changeset in webkit [70767] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Mark regressed after r70723 history-related tests.
- platform/chromium/test_expectations.txt:
- 5:16 AM Changeset in webkit [70766] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix interpreter build.
Rubber stamped by Csaba Osztrogonác.
Needed parentheses around assignment to avoid GCC warning after
http://trac.webkit.org/changeset/70703
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 5:03 AM Changeset in webkit [70765] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Kimmo Kinnunen <Kimmo Kinnunen>
Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 4:17 AM Changeset in webkit [70764] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
resetAssertionMatches() is an unused function in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=48503
The resetAssertionMatches() function is removed from YARR Interpreter
because it's never called.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::resetMatches):
- 3:41 AM Changeset in webkit [70763] by
-
- 8 edits6 adds in trunk
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebKit needs to expose an Element::spellcheck attribute to javascript.
https://bugs.webkit.org/show_bug.cgi?id=25536
- editing/spelling/script-tests/spelling-attribute-change.js: Added.
- editing/spelling/spelling-attribute-change-expected.txt: Added.
- editing/spelling/spelling-attribute-change.html: Added.
- fast/dom/HTMLElement/script-tests/spellcheck.js: Added.
- fast/dom/HTMLElement/spellcheck-expected.txt: Added.
- fast/dom/HTMLElement/spellcheck.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-10-27 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebKit needs to expose an Element::spellcheck attribute to javascript.
https://bugs.webkit.org/show_bug.cgi?id=25536
Published Element.spellcheck property on IDL, implemented it.
Tests: editing/spelling/spelling-attribute-change.html
fast/dom/HTMLElement/spellcheck.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::spellcheck): (WebCore::HTMLElement::setSpellcheck):
- html/HTMLElement.h:
- html/HTMLElement.idl:
- 3:22 AM Changeset in webkit [70762] by
-
- 15 edits in trunk
2010-10-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make debugger work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48376
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set content):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype._createResource): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype._updateResourceWithRequest): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceManager.prototype.resourceForURL): (WebInspector.ResourceManager.prototype.addConsoleMessage): (WebInspector.ResourceManager.prototype.clearConsoleMessages): (WebInspector.ResourceManager.prototype.forAllResources): (WebInspector.ResourceManager.prototype._bindResourceURL): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.getContent): (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
- inspector/front-end/networkPanel.css: (.network.panel .resources-dividers):
2010-10-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make debugger work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48376
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded):
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters.html:
- inspector/extensions-resources.html:
- 2:25 AM Changeset in webkit [70761] by
-
- 1 edit in branches/chromium/552/WebCore/inspector/front-end/inspector.css
Merge 69494 - 2010-10-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix event listener breakpoints sidebar pane style
https://bugs.webkit.org/show_bug.cgi?id=47487
- inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):
TBR=podivilov@chromium.org
BUG=61066
- 2:02 AM Changeset in webkit [70760] by
-
- 2 edits in trunk/WebKit2
2010-10-28 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web process cannot be debugged if it crashes in initialization
https://bugs.webkit.org/show_bug.cgi?id=47399
Wait 3 seconds for the debugger on debug mode if
WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable is set.
The debugging can be initiated for example in following way:
export WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH=1
./MiniBrowser & while [ -zpidof QtWebProcess]; do sleep 1; done; \
gdb --pid=
pidof QtWebProcess
- WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
- 1:33 AM Changeset in webkit [70759] by
-
- 2 edits in trunk/WebCore
One more Qt fix due to r70754.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
- 1:21 AM Changeset in webkit [70758] by
-
- 2 edits in trunk/WebCore
2010-10-28 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
fix setSize() call flow: it was only called the first
time (when onlySize is true)
Bug URL: https://bugs.webkit.org/show_bug.cgi?id=48494
Testing: difficult to exercise the bug, as it requires
some manual flow (change tab, scroll,...)
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
fix: call setSize() even when onlySize is false
- 1:16 AM Changeset in webkit [70757] by
-
- 3 edits in trunk/WebCore
Fix the Qt build after r70754.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::updateWidget):
- html/HTMLObjectElement.h:
- 1:08 AM Changeset in webkit [70756] by
-
- 2 edits in trunk/WebKit2
32-bit build fix.
Qualify references to Rect to avoid ambiguity between WebCore::Rect and Carbon's Rect.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::windowFrameChanged):
- 1:02 AM Changeset in webkit [70755] by
-
- 3 edits in trunk/LayoutTests
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix test description
https://bugs.webkit.org/show_bug.cgi?id=48501
I mistakenly copy/pasted this text from another test.
- fast/dom/allowed-children-expected.txt:
- fast/dom/allowed-children.html:
- 12:47 AM Changeset in webkit [70754] by
-
- 2 edits in trunk/WebCore
2010-10-28 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Fix a test failure introduced in r70748 by supporting Qt's non-standard
use of classid.
https://bugs.webkit.org/show_bug.cgi?id=45679
- html/HTMLObjectElement.cpp: (WebCore::objectHasSupportedClassId): Return true if the object's serviceType is 'application/x-qt-plugin'. (WebCore::HTMLObjectElement::updateWidget): Do not render fallback content if a non-empty classid is specified for a Qt plugin object.
- 12:47 AM Changeset in webkit [70753] by
-
- 2 edits in trunk/WebKit
Stop allowing deprecated methods to be used in NetscapePluginHostProxy.mm now
that deprecated methods are no longer used.
- WebKit.xcodeproj/project.pbxproj:
- 12:22 AM Changeset in webkit [70752] by
-
- 2 edits in trunk/JavaScriptCore
Wrong instruction form for BKPT
https://bugs.webkit.org/show_bug.cgi?id=48427
Reviewed by Andreas Kling.
One '0' is missing from BKPT instruction.
Thanks for Jacob Bramley for reporting this error.
- assembler/ARMAssembler.h:
- 12:14 AM Changeset in webkit [70751] by
-
- 18 edits in trunk
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebKitSystemInterface.h:
- 12:11 AM Changeset in webkit [70750] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Xan Lopez <xlopez@igalia.com>
Try to fix Snow Leopard build.
- jit/JITPropertyAccess.cpp: (JSC::JIT::testPrototype):
- 12:00 AM Changeset in webkit [70749] by
-
- 13 edits in trunk/JavaScriptCore
2010-10-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Oliver Hunt.
Do not have two different asCell APIs in JSValue
https://bugs.webkit.org/show_bug.cgi?id=47979
Remove JSCell* asCell(JSValue) in favor of only using
JSValue::asCell().
- API/APICast.h: (toRef):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::testPrototype):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- runtime/GetterSetter.h: (JSC::asGetterSetter):
- runtime/JSByteArray.h: (JSC::asByteArray):
- runtime/JSCell.h: (JSC::JSCell::getCallData): (JSC::JSCell::getConstructData):
- runtime/JSString.h: (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): (JSC::asString):
- runtime/JSValue.h:
- runtime/Operations.cpp: (JSC::jsIsObjectType):
- runtime/Operations.h: (JSC::normalizePrototypeChain):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
