Timeline



Nov 24, 2010:

11:08 PM Changeset in webkit [72721] by morrita@google.com
  • 2 edits in trunk/WebKit/chromium

2010-11-24 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][Windows] TestShell flakily crashes with EventSender.contextClick()
​https://bugs.webkit.org/show_bug.cgi?id=50052

makeStringArrayImpl() assumed wtf::StringImpl data is
null-terminated. But it is not.
Changed the code to pass the string length explicitly instead of
making it computed by v8::String::New().

  • src/WebBindings.cpp: (WebKit::makeStringArrayImpl):
9:55 PM Changeset in webkit [72720] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Mark http/tests/websocket/tests/frame-lengths.html as SLOW
​https://bugs.webkit.org/show_bug.cgi?id=50051

Chromium test expectation update: mark http/tests/websocket/tests/frame-lengths.html as SLOW.

This test takes a longer time to finish because it sends a lot of WebSocket messages.

  • platform/chromium/test_expectations.txt:
8:35 PM Changeset in webkit [72719] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

[Qt] plugins/keyboard-events.html fails after r72717
​https://bugs.webkit.org/show_bug.cgi?id=50050

  • platform/qt/Skipped: Skip failing tests until a fix is made.
7:34 PM Changeset in webkit [72718] by jianli@chromium.org
  • 27 edits
    7 adds in trunk

Implement DataView interface from Typed Array specification
​https://bugs.webkit.org/show_bug.cgi?id=46541

Reviewed by Kenneth Russell.

WebCore:

Test: fast/canvas/webgl/data-view-test.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::dataViewEnabled):

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::dataView):

  • bindings/js/JSDataViewCustom.cpp: Added.
  • bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

  • bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

  • bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

  • bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

  • bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

  • bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

  • bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8DataViewCustom.cpp: Added.
  • html/canvas/ArrayBufferView.h:

(WebCore::ArrayBufferView::isDataView):

  • html/canvas/DataView.cpp: Added.
  • html/canvas/DataView.h: Added.
  • html/canvas/DataView.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Add a new test for testing DataView interface. Also update some tests
to exclude DataView property from being tested because it is not
exposed to all platforms.

  • fast/canvas/webgl/data-view-test-expected.txt: Added.
  • fast/canvas/webgl/data-view-test.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:

(constructorNamesForWindow):

  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/js/script-tests/global-constructors.js:
7:18 PM Changeset in webkit [72717] by commit-queue@webkit.org
  • 4 edits in trunk

2010-11-24 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Windowless plugins gets broken key input
​https://bugs.webkit.org/show_bug.cgi?id=49927

When converting the GdkEvent to XEvent we need to send the
hardware_keycode as XEvent::keycode. Instead we where sending
the GdkEvent::keyval. This is already tested by
plugins/keyboard-events.html, but a bug in the test plugin was
resulting in false positive.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent):

2010-11-24 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Windowless plugins gets broken key input
​https://bugs.webkit.org/show_bug.cgi?id=49927

Convert the XEvent::keycode to ASCII before printing it. Not
doing this was causing false positive in
plugins/keyboard-events.html.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (keycode_to_char): (webkit_test_plugin_handle_event):
7:02 PM Changeset in webkit [72716] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Tony Chang.

Fix file-writer-truncate-extend test.
​https://bugs.webkit.org/show_bug.cgi?id=50047

  • fast/filesystem/resources/file-writer-truncate-extend.js:
6:44 PM Changeset in webkit [72715] by commit-queue@webkit.org
  • 23 edits
    3 copies in trunk/WebCore

2010-11-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

Implement FileWriterSync
​https://bugs.webkit.org/show_bug.cgi?id=49939

Tests to follow in a separate CL, once the test framework in 47680 goes in.

Build file changes to add FileWriterBase and FileWriterBaseCallback.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

FileWriterSync doesn't turn out to need to be an ActiveDOMObject.

  • bindings/scripts/CodeGeneratorV8.pm:

Added new AsyncFileWriter::waitForOperationToComplete to enable
synchronous calls.

  • fileapi/AsyncFileWriter.h:

Added a way to get a FileSystemSync.

  • fileapi/DOMFileSystemSync.cpp:
  • fileapi/FileEntrySync.cpp:
  • fileapi/FileEntrySync.h:
  • fileapi/FileEntrySync.idl:

Added an error code for OK, rather than just having 0 everywhere.

  • fileapi/FileError.h:

Turned FileWriterCallback into FileWriterBaseCallback.

  • fileapi/FileSystemCallbacks.cpp:
  • fileapi/FileSystemCallbacks.h:

Refactored out a common base class, FileWriterBase, for FileWriter and
FileWriterSync.

  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h:
  • fileapi/FileWriterBase.cpp: Added.
  • fileapi/FileWriterBase.h: Added.
  • fileapi/FileWriterBaseCallback.h: Added.
  • fileapi/FileWriterSync.cpp:
  • fileapi/FileWriterSync.h:

Small tweaks to deal with the base class refactoring.

  • fileapi/DOMFileSystem.cpp:
  • fileapi/DOMFileSystemSync.h:

Removed "CallWith=ScriptExecutionContext", as FileWriterSync doesn't actually need it.

  • fileapi/FileWriterSync.idl:
6:38 PM Changeset in webkit [72714] by crogers@google.com
  • 1891 edits
    137 copies
    176 adds
    126 deletes in branches/audio

audio branch: merge from trunk 71224:72704

6:26 PM Changeset in webkit [72713] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Build fix for GTK+. There were some typos in my last build fix
and the empty command (semicolon) seems to be necessary for wildcard
rule chains.

  • GNUmakefile.am: Small build fixes.
6:11 PM Changeset in webkit [72712] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-24 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Antonio Gomes.

[Qt] Html autofocus not working with QGraphicsWebView
​https://bugs.webkit.org/show_bug.cgi?id=43169

Tell the scene to set the webview item as the currently
focused item. This makes the input field with autofocus get
focus as it should.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
5:55 PM Changeset in webkit [72711] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-11-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

[Chromium] Implement FileWriterSync
​https://bugs.webkit.org/show_bug.cgi?id=49940

Added waitForOperationToComplete, delegating to the bridge.

  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.h:

Added waitForOperationToComplete and some debug-only code to make sure it's working properly.

  • src/WorkerFileWriterCallbacksBridge.cpp: (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread): (WebKit::WorkerFileWriterCallbacksBridge::WorkerFileWriterCallbacksBridge): (WebKit::WorkerFileWriterCallbacksBridge::didWriteOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::didFailOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::didTruncateOnWorkerThread): (WebKit::WorkerFileWriterCallbacksBridge::waitForOperationToComplete):
  • src/WorkerFileWriterCallbacksBridge.h:
5:46 PM Changeset in webkit [72710] by thakis@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-24 Nico Weber <​thakis@chromium.org>

Unreviewed.

Another new baseline after ​http://trac.webkit.org/changeset/72689
​https://bugs.webkit.org/show_bug.cgi?id=50040

  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
5:09 PM Changeset in webkit [72709] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Reviewed implicitly by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=50042

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WebUserDataWrapper initWithUserData:WebKit::]): Do the proper self = [super init] dance here.

4:56 PM Changeset in webkit [72708] by dpranke@chromium.org
  • 14 edits in trunk/WebKitTools

2010-11-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt - clean up create_driver interface and print out the
command line used for DumpRenderTree/TestShell.

This patch adds a driver_cmd_line() call to the Port class in
order to retrive the command line to print it out (as part of
--print config).

In addition, this patch cleans up the Port.create_driver()
signature and the Driver constructor interface to take a worker
number and no longer require the image_path argument (Chromium's
drivers now synthesize the image_path from the worker number
internally).

​https://bugs.webkit.org/show_bug.cgi?id=49934

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:53 PM Changeset in webkit [72707] by beidson@apple.com
  • 12 edits in trunk/WebKit2

More of <rdar://problem/8613727> and ​https://bugs.webkit.org/show_bug.cgi?id=50042
WK2 Context Menu Items need a user data object and a client callback for selection.

Reviewed by Dan Bernstein.

  • Shared/API/c/WKContextMenuItem.cpp:

(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):

  • Shared/API/c/WKContextMenuItem.h:
  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::userData):
(WebKit::WebContextMenuItem::setUserData):

  • Shared/WebContextMenuItem.h:
  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::userData):
(WebKit::WebContextMenuItemData::setUserData):

  • Shared/WebContextMenuItemData.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::customContextMenuItemSelected): Added for WK2 apps to get a callback.

  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WebUserDataWrapper initWithUserData:WebKit::]): Add an "APIObject" user data wrapper class to associate with the NSMenuItem.
(-[WebUserDataWrapper WebKit::]):
(-[WebMenuTarget forwardContextMenuAction:]): Include the user data object in the created ContextMenuItemData.
(WebKit::nsMenuItemVector):

4:39 PM Changeset in webkit [72706] by thakis@chromium.org
  • 43 edits
    2 copies
    2 adds
    2 deletes in trunk/LayoutTests

2010-11-24 Nico Weber <​thakis@chromium.org>

Unreviewed.

More new baselines after ​http://trac.webkit.org/changeset/72689
​https://bugs.webkit.org/show_bug.cgi?id=50040

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Removed.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum:
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/custom/convolution-crash-expected.checksum:
  • platform/chromium-mac/svg/custom/convolution-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/createImageElement-expected.png.
  • platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum:
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/js-update-image-expected.png.
4:13 PM Changeset in webkit [72705] by crogers@google.com
  • 10 edits
    1 copy
    2 adds in branches/audio

audio branch: changes for landing in trunk

  • AudioNode custom bindings last tweaks
  • chromium WebKit API work: WebAudioBus...
  • FFMPEG file reading compile fixes for chromium
  • switch to 'webkit' prefix on AudioContext constructor
3:59 PM Changeset in webkit [72704] by commit-queue@webkit.org
  • 18 edits
    7 adds
    2 deletes in trunk/LayoutTests

2010-11-24 Eric Uhrhane <​ericu@chromium.org>

Reviewed by David Levin.

Add FileWriter test utilities.
​https://bugs.webkit.org/show_bug.cgi?id=47680

Cleaning up shared test utility files caused the includes and output of
a bunch of existing tests change slightly, so I've rebuilt the
expectation files.

This is the first test [in DOM and worker versions] to use the new utilities.

  • fast/filesystem/file-writer-truncate-extend-expected.txt: Added.
  • fast/filesystem/file-writer-truncate-extend.html: Added.
  • fast/filesystem/resources/file-writer-truncate-extend.js: Added.
  • fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Added.
  • fast/filesystem/workers/file-writer-truncate-extend.html: Added.

This is a new utility file for FileWriter tests.

  • fast/filesystem/resources/file-writer-utils.js: Added.

Touched up a bit

  • fast/filesystem/resources/fs-worker-common.js:

Removed

  • fast/filesystem/resources/fs-worker-test-post.js:
  • fast/filesystem/resources/fs-worker-test-pre.js: renamed to
  • fast/filesystem/resources/fs-worker-test-util.js:

These tests and their expectations were tweaked slightly to use the new code more cleanly.

  • fast/filesystem/workers/async-operations-expected.txt:
  • fast/filesystem/workers/async-operations.html:
  • fast/filesystem/workers/file-from-file-entry-expected.txt:
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt:
  • fast/filesystem/workers/file-from-file-entry-sync.html:
  • fast/filesystem/workers/file-from-file-entry.html:
  • fast/filesystem/workers/simple-persistent-expected.txt:
  • fast/filesystem/workers/simple-persistent-sync-expected.txt:
  • fast/filesystem/workers/simple-persistent-sync.html:
  • fast/filesystem/workers/simple-persistent.html:
  • fast/filesystem/workers/simple-temporary-expected.txt:
  • fast/filesystem/workers/simple-temporary-sync-expected.txt:
  • fast/filesystem/workers/simple-temporary-sync.html:
  • fast/filesystem/workers/simple-temporary.html:
  • fast/filesystem/workers/sync-operations-expected.txt:
  • fast/filesystem/workers/sync-operations.html:

Removed suppression of FileWriter tests, as we now have support in TestShell.

  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [72703] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-11-24 Kenneth Russell <​kbr@google.com>

Reviewed by Darin Fisher.

[chromium] Disable antialiasing for compositor
​https://bugs.webkit.org/show_bug.cgi?id=50039

  • src/WebViewImpl.cpp: (WebCore::getCompositorContextAttributes): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::graphicsContext3D):
3:11 PM Changeset in webkit [72702] by thakis@chromium.org
  • 100 edits
    13 deletes in trunk/LayoutTests

2010-11-24 Nico Weber <​thakis@chromium.org>

Unreviewed.

New baselines after ​http://trac.webkit.org/changeset/72689
​https://bugs.webkit.org/show_bug.cgi?id=50040

  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
  • platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png:
  • platform/chromium-mac/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
3:00 PM Changeset in webkit [72701] by vangelis@chromium.org
  • 21 edits
    18 adds in trunk

2010-11-24 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
​https://bugs.webkit.org/show_bug.cgi?id=49629

This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.

The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.

A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.

Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().

Tests: compositing/lots-of-img-layers-with-opacity.html

compositing/lots-of-img-layers.html

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::updateContentsIfDirty): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::renderSurfaceSharedValues): (WebCore::LayerRendererChromium::textureManager):
  • platform/graphics/chromium/LayerTexture.cpp: Added. (WebCore::LayerTexture::LayerTexture): (WebCore::LayerTexture::~LayerTexture): (WebCore::LayerTexture::isValid): (WebCore::LayerTexture::reserve): (WebCore::LayerTexture::unreserve): (WebCore::LayerTexture::bindTexture): (WebCore::LayerTexture::framebufferTexture2D):
  • platform/graphics/chromium/LayerTexture.h: Added. (WebCore::LayerTexture::create):
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::shaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation): (WebCore::RenderSurfaceChromium::SharedValues::initialized):
  • platform/graphics/chromium/TextureManager.cpp: Added. (WebCore::memoryUseBytes): (WebCore::TextureManager::TextureManager): (WebCore::TextureManager::getToken): (WebCore::TextureManager::releaseToken): (WebCore::TextureManager::hasTexture): (WebCore::TextureManager::protectTexture): (WebCore::TextureManager::unprotectTexture): (WebCore::TextureManager::reduceMemoryToLimit): (WebCore::TextureManager::addTexture): (WebCore::TextureManager::removeTexture): (WebCore::TextureManager::requestTexture):
  • platform/graphics/chromium/TextureManager.h: Added. (WebCore::TextureManager::create):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/WebGLLayerChromium.h:

2010-11-24 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Compositor needs to manage its VRAM use
​https://bugs.webkit.org/show_bug.cgi?id=49629

Adds a few tests involving lots of visible image layers. The tests are designed
to require slightly more than 64MB of VRAM.

  • compositing/lots-of-img-layers-with-opacity.html: Added.
  • compositing/lots-of-img-layers.html: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/mac/compositing/lots-of-img-layers-expected.checksum: Added.
  • platform/mac/compositing/lots-of-img-layers-expected.png: Added.
  • platform/mac/compositing/lots-of-img-layers-expected.txt: Added.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.checksum: Added.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png: Added.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt: Added.
2:30 PM Changeset in webkit [72700] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Tony Chang <​tony@chromium.org>

Unreviewed, updating plugin test expectations now that we've switched
to the upstream plugin!

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [72699] by ojan@chromium.org
  • 5 edits in trunk/WebKitTools

2010-11-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

[chromium] improve memory usage for test results server and store fewer runs
​https://bugs.webkit.org/show_bug.cgi?id=50035

Store fewer runs and don't pass full files around when we only need bools.
Greatly improves error rates on test-results.appspot.com.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/model/dashboardfile.py:
  • TestResultServer/model/jsonresults.py:
1:57 PM Changeset in webkit [72698] by dpranke@chromium.org
  • 6 edits in trunk/WebKitTools

2010-11-24 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

This patch implements the first part of the manager side of the
Broker objects - it handles creating threads, waiting for them
to complete, and running a single-threaded loop as well.

​https://bugs.webkit.org/show_bug.cgi?id=49779

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1:29 PM Changeset in webkit [72697] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-24 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Fixed handling of QInputMethodEvents with nonzero replacementLength.

These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.

​https://bugs.webkit.org/show_bug.cgi?id=49787

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
12:20 PM Changeset in webkit [72696] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Just assign a bug for compositing/plugin tests.

  • platform/chromium-gpu/test_expectations.txt:
12:02 PM Changeset in webkit [72695] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-11-24 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] response.isNull() assert when using directory file URI
​https://bugs.webkit.org/show_bug.cgi?id=49018

When using ​file:/// (or any directory), WebKitGTK use to abort on
assertion. This test ensure that loading a directory is possible.

  • platform/gtk/fast/loader/crash-display-local-directory-expected.txt: Added.
  • platform/gtk/fast/loader/crash-display-local-directory.html: Added.
  • platform/gtk/fast/loader/resources/directory/keep-empty: Added.

2010-11-24 Nicolas Dufresne <​nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] response.isNull() assert when using directory file URI
​https://bugs.webkit.org/show_bug.cgi?id=49018

Do ensure that didReceiveResponse happens before any call to
didReceiveData. That was not true for ​file:// URIs pointing to
directories and thus was triggering an assertion.

Test: platform/gtk/fast/loader/crash-display-local-directory.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::contentSniffedCallback): (WebCore::parseDataUrl): (WebCore::sendRequestCallback): (WebCore::readCallback):
11:45 AM Changeset in webkit [72694] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-24 Mihai Parparita <​mihaip@chromium.org>

Reviewed by David Levin.

DRT should not generate pixel output for text/plain tests
​https://bugs.webkit.org/show_bug.cgi?id=50002

Modify Mac, Windows and GTK DRT implementations to disable pixel output
when encountering a text/plain response (the Chromium one already does
this, and none of the other ports special-case text/plain output in
the first place).

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump):
11:23 AM Changeset in webkit [72693] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed, update platform expectations following expectations change in r72683.

  • platform/mac-leopard/inspector/extensions-resources-expected.txt:
11:23 AM Changeset in webkit [72692] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • bindings/gobject/WebKitDOMBinding.h: fix stlye nit.
11:15 AM Changeset in webkit [72691] by xan@webkit.org
  • 8 edits in trunk

WebCore:

2010-11-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make kit() methods return the proper type instead of gpointer
​https://bugs.webkit.org/show_bug.cgi?id=50034

Change kit() methods to return proper type pointer.

  • bindings/gobject/WebKitDOMBinding.cpp: change implementions of kit methods.
  • bindings/gobject/WebKitDOMBinding.h: change their declarations.
  • bindings/scripts/CodeGeneratorGObject.pm: change the generated kit() methods.

WebKit/gtk:

2010-11-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make kit() methods return the proper type instead of gpointer
​https://bugs.webkit.org/show_bug.cgi?id=50034

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): get rid of unneeded cast. (WebKit::EditorClient::shouldShowDeleteInterface): ditto. (WebKit::EditorClient::shouldBeginEditing): ditto. (WebKit::EditorClient::shouldEndEditing): ditto. (WebKit::EditorClient::shouldInsertText): ditto. (WebKit::EditorClient::shouldChangeSelectedRange): ditto. (WebKit::EditorClient::shouldApplyStyle): ditto. (WebKit::EditorClient::shouldInsertNode): ditto.
  • webkit/webkitprivate.cpp: (WebKit::kit): ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_get_dom_document): ditto.
11:08 AM Changeset in webkit [72690] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DerivedSources/WebCore/DocTypeStrings.cpp is generated for every build
​https://bugs.webkit.org/show_bug.cgi?id=50032

Instead of listing two targets for rules that have two outputs, make
a dependency chain. This fixes the issue where some files are generated
unconditionally. Also remove all unnecessary semicolons from the file.

No new tests as this is just a build fix.

  • GNUmakefile.am: Fix GNUmake dependency issue.
11:01 AM Changeset in webkit [72689] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-24 Nico Weber <​nicolasweber@gmx.de>

Reviewed by Adam Barth.

Chromium/Mac: Make scaled images un-ugly when using the webkit image decoders
​https://bugs.webkit.org/show_bug.cgi?id=49965

Probably covered by existing tests whose expectations were overwritten
in ​http://trac.webkit.org/changeset/70858

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
10:54 AM Changeset in webkit [72688] by hayato@chromium.org
  • 2 edits in trunk

2010-11-24 Hayato Ito <​hayato@chromium.org>

Reviewed by David Levin.

Add files which Chromium port generates to .gitignore.

​https://bugs.webkit.org/show_bug.cgi?id=49943

  • .gitignore:
10:45 AM Changeset in webkit [72687] by apavlov@chromium.org
  • 5 edits in trunk

2010-11-24 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Crash when inspecting ​http://alphaarnhem.nl/beta/
​https://bugs.webkit.org/show_bug.cgi?id=50025

@font-face rules were improperly handled by source data extractor.

WebCore:

  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
  • css/CSSParser.h:

LayoutTests:

  • inspector/resources/styles-new-API-1.css: (@font-face):
10:31 AM Changeset in webkit [72686] by xan@webkit.org
  • 3 edits in trunk/LayoutTests/platform/gtk

2010-11-24 Xan Lopez <​xlopez@igalia.com>

Update results for some leftover tests now that we have editing
delegates.

  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/fast/forms/caret-rtl-expected.txt:
10:13 AM Changeset in webkit [72685] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Added check when parsing local fonts to ensure that a value's unit type is either string or ident.
​https://bugs.webkit.org/show_bug.cgi?id=49883

Test: fast/css/local_font_invalid.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceSrc):

2010-11-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Test for crash with invalid local fonts.
​https://bugs.webkit.org/show_bug.cgi?id=49883

  • fast/css/local_font_invalid-expected.txt: Added.
  • fast/css/local_font_invalid.html: Added.
10:06 AM Changeset in webkit [72684] by pfeldman@chromium.org
  • 14 edits in trunk/WebCore

2010-11-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: place local modifications to under original
resource nodes in the resource panel.
​https://bugs.webkit.org/show_bug.cgi?id=50029

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setInitialContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set content): (WebInspector.Resource.prototype.get contentTimestamp): (WebInspector.Resource.prototype.setInitialContent):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.setInitialContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged.else.finished): (WebInspector.FrameResourceTreeElement.prototype._contentChanged): (WebInspector.ResourceRevisionTreeElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.get scrollTop): (WebInspector.SourceView.prototype.set scrollTop): (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
10:03 AM Changeset in webkit [72683] by caseq@chromium.org
  • 24 edits in trunk

2010-11-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extension API cleanup
​https://bugs.webkit.org/show_bug.cgi?id=50019

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
  • inspector/front-end/ExtensionAPI.js: See bug for summary of extension API changes. (WebInspector.injectedExtensionAPI.Resources.resourceDispatch): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR): (WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent): (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.PanelImpl): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createWatchExpressionSidebarPane): (WebInspector.injectedExtensionAPI.ElementsPanel): (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight): (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory): (WebInspector.injectedExtensionAPI.AuditCategoryImpl.auditResultDispatch): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity): (WebInspector.injectedExtensionAPI.InspectedWindow): (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
  • inspector/front-end/ExtensionCommon.js: (WebInspector.commonExtensionSymbols):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyObjectSelected): (WebInspector.ExtensionServer.prototype.notifyResourceFinished): (WebInspector.ExtensionServer.prototype.notifyPageLoaded): (WebInspector.ExtensionServer.prototype.notifyPageDOMContentLoaded): (WebInspector.ExtensionServer.prototype._onCreatePanel): (WebInspector.ExtensionServer.prototype._onReload): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
  • inspector/front-end/HAREntry.js: (WebInspector.HARLog): (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.didCommitLoad):

2010-11-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extension API cleanup
Improve synchronization between different parts of the test to reduce flakiness.
​https://bugs.webkit.org/show_bug.cgi?id=50019

  • http/tests/inspector/inspector-test2.js: Clean inspected page test output before pushing output from front-end. (initialize_InspectorTest.InspectorTest.completeTest): Delay test completion until page's onload is completed after reload. (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (output):
  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt:
  • inspector/extensions-audits-expected.txt:
  • inspector/extensions-audits-tests.js: (extension_runAudits): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone): (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest): (test):
  • inspector/extensions-eval-expected.txt:
  • inspector/extensions-eval.html:
  • inspector/extensions-events-expected.txt:
  • inspector/extensions-events.html:
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
  • inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest.extensionOutput): (initialize_ExtensionsTest.dumpSidebarContent): (initialize_ExtensionsTest.reloadPage):
  • inspector/extensions.html:
  • inspector/resources/extension-main.html:
  • inspector/resources/extension-main.js: (fetchTests.callback): (fetchTests): (onTestsDone): (dispatchOnFrontend):
9:57 AM Changeset in webkit [72682] by jorlow@chromium.org
  • 8 edits
    2 adds in trunk

2010-11-23 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Fix minor errors in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=49970

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/createAndRemoveObjectStore-expected.txt: Added.
  • storage/indexeddb/createAndRemoveObjectStore.html: Added.

2010-11-23 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Fix minor errors in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=49970

  • Remove SNAPSHOT_READ per spec.
  • Assert that the transaction that changes the db is a setVersion transaction.
  • When an objectStore already exists, throw a CONSTRAINT_ERR.
  • When not in a setVersion transaction, throw a NOT_ALLOWED_ERR.

Test: storage/indexeddb/createAndRemoveObjectStore.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore):
  • storage/IDBTransaction.h:
  • storage/IDBTransaction.idl:
9:51 AM Changeset in webkit [72681] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix crashes in GTK+ bots. Use kit() instead of wrapFoo, otherwise
the DOM objects won't be in the cache and we'll ASSERT when
unreffing them.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): use kit to get the GObject wrapper for the DOM object. (WebKit::EditorClient::shouldShowDeleteInterface): ditto. (WebKit::EditorClient::shouldBeginEditing): ditto. (WebKit::EditorClient::shouldEndEditing): ditto. (WebKit::EditorClient::shouldInsertText): ditto. (WebKit::EditorClient::shouldChangeSelectedRange): ditto. (WebKit::EditorClient::shouldApplyStyle): ditto. (WebKit::EditorClient::shouldInsertNode): ditto.
9:49 AM Changeset in webkit [72680] by Philippe Normand
  • 3 edits in trunk/WebCore

2010-11-24 Philippe Normand <​pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] pause webkitvideosink during fullscreen video playback
​https://bugs.webkit.org/show_bug.cgi?id=48824

Added an identity element before the webkitvideosink so that when
fullscreen video is active the element can drop the incoming
buffers so that webkitvideosink appears paused.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen): (WebCore::GStreamerGWorld::exitFullscreen):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
9:45 AM Changeset in webkit [72679] by alex
  • 2 edits in trunk/LayoutTests

2010-11-24 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skip mathml/presentation again, apparently the issue
is still happening in the bots.

  • platform/gtk/Skipped:
9:31 AM QtWebKitTesting edited by Ademar Reis
(diff)
9:20 AM Changeset in webkit [72678] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-11-24 Avi Drissman <​avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

  • editing/selection/context-menu-text-selection-expected.txt: Added.
  • editing/selection/context-menu-text-selection.html: Added.

2010-11-24 Avi Drissman <​avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

Test: editing/selection/context-menu-text-selection.html

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
9:18 AM Changeset in webkit [72677] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Unreviewed.

Add my other email address to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
9:07 AM Changeset in webkit [72676] by commit-queue@webkit.org
  • 4 edits in trunk

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

Make build-webkit --minimal build with ENABLE_INSPECTOR=0.
​https://bugs.webkit.org/show_bug.cgi?id=49975

No new tests needed.

  • features.pri: Make the Qt buildsystem aware that the inspector is enabled by default.

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

Make build-webkit --minimal build with ENABLE_INSPECTOR=0
​https://bugs.webkit.org/show_bug.cgi?id=49975

  • Scripts/build-webkit: Add ENABLE_INSPECTOR define to features, to enable the script to define it 0 in case of a minimal build.
8:43 AM Changeset in webkit [72675] by Martin Robinson
  • 149 edits
    34 adds
    1 delete in trunk

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
​https://bugs.webkit.org/show_bug.cgi?id=49143

Unskip passing editing tests.

  • platform/gtk/Skipped:
  • platform/gtk/Skipped.rej: Added.
  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-001-expected.txt:
  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-003-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-image-004-expected.txt:
  • platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-002-expected.txt:
  • platform/gtk/editing/deleting/delete-line-005-expected.txt:
  • platform/gtk/editing/deleting/delete-line-006-expected.txt:
  • platform/gtk/editing/deleting/delete-line-007-expected.txt:
  • platform/gtk/editing/deleting/delete-line-008-expected.txt:
  • platform/gtk/editing/deleting/delete-line-009-expected.txt:
  • platform/gtk/editing/deleting/delete-line-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-011-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-line-013-expected.txt:
  • platform/gtk/editing/deleting/delete-line-014-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
  • platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt:
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/execCommand/4641880-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/4641880-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/create-list-with-hr-expected.txt: Added.
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt: Added.
  • platform/gtk/editing/execCommand/findString-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Added.
  • platform/gtk/editing/execCommand/findString-expected.txt: Added.
  • platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
  • platform/gtk/editing/execCommand/indent-empty-root-expected.txt: Added.
  • platform/gtk/editing/execCommand/indent-list-item-expected.txt: Added.
  • platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Removed.
  • platform/gtk/editing/execCommand/indent-selection-expected.txt: Added.
  • platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
  • platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt: Added.
  • platform/gtk/editing/execCommand/insertImage-expected.txt: Added.
  • platform/gtk/editing/execCommand/nsresponder-indent-expected.txt: Added.
  • platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
  • platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
  • platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
  • platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
  • platform/gtk/editing/execCommand/outdent-selection-expected.txt: Added.
  • platform/gtk/editing/execCommand/paste-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/paste-2-expected.txt: Added.
  • platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
  • platform/gtk/editing/execCommand/remove-list-item-1-expected.txt: Added.
  • platform/gtk/editing/execCommand/selectAll-expected.txt: Added.
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/gtk/editing/inserting/insert-br-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-001-expected.txt:
  • platform/gtk/editing/inserting/insert-div-002-expected.txt:
  • platform/gtk/editing/inserting/insert-div-003-expected.txt:
  • platform/gtk/editing/inserting/insert-div-004-expected.txt:
  • platform/gtk/editing/inserting/insert-div-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-009-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/redo-expected.txt:
  • platform/gtk/editing/inserting/typing-001-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/inserting/typing-003-expected.txt:
  • platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
  • platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/5368833-expected.txt: Added.
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/4947387-expected.txt: Added.
  • platform/gtk/editing/selection/5195166-2-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt:
  • platform/gtk/editing/selection/extend-selection-bidi-expected.txt: Added.
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-002-expected.txt:
  • platform/gtk/editing/selection/move-by-character-003-expected.txt:
  • platform/gtk/editing/selection/move-by-character-004-expected.txt:
  • platform/gtk/editing/selection/move-by-character-005-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/selection-actions-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/style/unbold-in-bold-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/redo-typing-001-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/editing/undo/undo-misspellings-expected.txt:

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
​https://bugs.webkit.org/show_bug.cgi?id=49143

  • platform/gtk/GtkVersioning.c: (g_signal_accumulator_first_wins): Add g_signal_accumulator_first_wins for versions of GLib before 2.28.
  • platform/gtk/GtkVersioning.h:

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
​https://bugs.webkit.org/show_bug.cgi?id=49143

Add signals that encapsulate the functionality of the Mac EditingDelegate. These signals
are private for now, but DRT consumes them to produce proper output for editing tests.
After some time, these may be part of the public API.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::shouldDeleteRange): Fire the appropriate editing signal. (WebKit::EditorClient::shouldShowDeleteInterface): Ditto. (WebKit::EditorClient::shouldBeginEditing): Ditto. (WebKit::EditorClient::shouldEndEditing): Ditto. (WebKit::kit): Added helper function. (WebKit::EditorClient::shouldInsertText): Fire the appropriate editing signal. (WebKit::EditorClient::shouldChangeSelectedRange): Ditto. (WebKit::EditorClient::shouldApplyStyle): Ditto. (WebKit::EditorClient::didBeginEditing): Ditto. (WebKit::EditorClient::respondToChangedContents): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::didEndEditing): Ditto. (WebKit::EditorClient::shouldInsertNode): Ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_real_should_allow_editing_action): Added this default signal callback which explicitly allows cancellable editing actions. (webkit_web_view_class_init): Add new editing signal declarations to the view.
  • webkit/webkitwebview.h:
  • webkitmarshal.list: Added some new marshaling definitions.

2010-11-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
​https://bugs.webkit.org/show_bug.cgi?id=49143

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView): Call the new connectEditingCallbacks function.
  • DumpRenderTree/gtk/EditingCallbacks.cpp: Added. (dumpNodePath): (dumpRange): (insertActionString): (selectionAffinityString): (shouldBeginEditing): (shouldEndEditing): (shouldInsertNode): (shouldInsertText): (shouldDeleteRange): (shouldShowDeleteInterfaceForElement): (shouldChangeSelectedRange): (shouldApplyStyle): (editingBegan): (userChangedContents): (editingEnded): (selectionChanged): (connectEditingCallbacks):
  • DumpRenderTree/gtk/EditingCallbacks.h: Added.
  • GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
8:21 AM Changeset in webkit [72674] by alex
  • 19 edits in trunk/LayoutTests

2010-11-24 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, rebaselined mathml/presentation using bots results.

  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.txt:
7:56 AM Changeset in webkit [72673] by commit-queue@webkit.org
  • 8 edits in trunk

2010-11-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72499.
​http://trac.webkit.org/changeset/72499
​https://bugs.webkit.org/show_bug.cgi?id=50022

This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).

  • accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA):
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): (optionFromList): (optionFromSelection): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_text_get_text): (getInterfaceMaskFromObject):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):

2010-11-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72499.
​http://trac.webkit.org/changeset/72499
​https://bugs.webkit.org/show_bug.cgi?id=50022

This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).

  • tests/testatk.c: (main):
7:51 AM Changeset in webkit [72672] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-11-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Simplify makeprop.pl
​https://bugs.webkit.org/show_bug.cgi?id=49925

Don't generate CSSPropertyNamesHash.h.
Instead generate CSSPropertyNames directly.

  • GNUmakefile.am: Removed rule for CSSPropertyNamesHash.h.
  • css/makeprop.pl:
7:49 AM Changeset in webkit [72671] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-24 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Make QtTestBrowser remember the selected user agent
​https://bugs.webkit.org/show_bug.cgi?id=50021

Set user agent for a new page by using the old page's

  • QtTestBrowser/mainwindow.cpp: (MainWindow::setPage):
7:42 AM WikiStart edited by Patrick Gansterer
r72669 removed remaining Bakefile build system files (diff)
7:38 AM Changeset in webkit [72670] by alex
  • 56 edits in trunk/LayoutTests

2010-11-24 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, unskipped and rebaselined mathml/presentation tests
after r72413

  • platform/gtk/Skipped:
  • platform/gtk/mathml/presentation/attributes-expected.checksum:
  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.checksum:
  • platform/gtk/mathml/presentation/fenced-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.checksum:
  • platform/gtk/mathml/presentation/fenced-mi-expected.png:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.checksum:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.checksum:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.checksum:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.checksum:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.checksum:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.checksum:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.checksum:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.checksum:
  • platform/gtk/mathml/presentation/sub-expected.png:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.checksum:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.checksum:
  • platform/gtk/mathml/presentation/sup-expected.png:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.checksum:
  • platform/gtk/mathml/presentation/tables-expected.png:
  • platform/gtk/mathml/presentation/tables-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.checksum:
  • platform/gtk/mathml/presentation/tokenElements-expected.png:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.checksum:
  • platform/gtk/mathml/presentation/under-expected.png:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.checksum:
  • platform/gtk/mathml/presentation/underover-expected.png:
  • platform/gtk/mathml/presentation/underover-expected.txt:
7:35 AM Changeset in webkit [72669] by Patrick Gansterer
  • 4 edits
    14 deletes in trunk

2010-11-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Remove Bakefile build system files
​https://bugs.webkit.org/show_bug.cgi?id=49983

r53757 only removed the content, but not the files.
This patch removes that empty files.

7:21 AM Changeset in webkit [72668] by reni@webkit.org
  • 2 edits in trunk/WebCore

[Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
​https://bugs.webkit.org/show_bug.cgi?id=49919

Reviewed by Andreas Kling.

Add ASSERT_NOT_REACHED() if the given WebCore type doesn't have an equivalent type in Qt.
Also change the return value of toQtLineJoin() from Qt::MiterJoin to the default Qt::SvgMiterJoin,
because the previous one doesn't work currently.

No new test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::toQtCompositionMode):
(WebCore::toQtLineCap):
(WebCore::toQtLineJoin):
(WebCore::toQPenStyle):
(WebCore::toQtFillRule):

6:55 AM QtWebKitContrib edited by Ademar Reis
Adding reference to QtWebKitTesting and the testing VM (diff)
6:54 AM QtWebKitTesting created by Ademar Reis
6:51 AM Changeset in webkit [72667] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-11-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Simplify makevalues.pl
​https://bugs.webkit.org/show_bug.cgi?id=49926

Don't generate CSSValueKeywordsHash.h.
Instead generate CSSValueKeywords.cpp directly.

  • GNUmakefile.am: Removed rule for CSSValueKeywordsHash.h.
  • css/makevalues.pl:
6:38 AM Changeset in webkit [72666] by abecsi@webkit.org
  • 37 edits in trunk

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Make WebKit2 compile with !ENABLE(INSPECTOR).
​https://bugs.webkit.org/show_bug.cgi?id=49973

No new tests needed.

  • bindings/js/ScriptHeapSnapshot.h:
  • bindings/js/ScriptProfile.cpp:
  • bindings/js/ScriptProfile.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/ScriptBreakpoint.h:

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Make WebKit2 compile with !ENABLE(INSPECTOR).
​https://bugs.webkit.org/show_bug.cgi?id=49973

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled):

2010-11-24 Andras Becsi <​abecsi@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Make WebKit2 compile with !ENABLE(INSPECTOR).
​https://bugs.webkit.org/show_bug.cgi?id=49973

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKInspector.cpp:
  • UIProcess/API/C/WKInspector.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::processDidCrash):
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/WebInspectorProxyWin.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspector.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::close): (WebKit::WebPage::windowIsFocused): (WebKit::WebPage::didReceiveMessage):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebPage/win/WebInspectorWin.cpp:
5:47 AM Changeset in webkit [72665] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-24 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Make deep copies of tile images

We need the tile images we get from UpdateChunk::createImage() to persist,
so we should take a copy() of them.

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::updateFromChunk):
5:26 AM Changeset in webkit [72664] by Patrick Gansterer
  • 4 edits
    1 add in trunk/WebCore

2010-11-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Simplify make-hash-tools.pl
​https://bugs.webkit.org/show_bug.cgi?id=49922

HashTools.h does not need to be generated, because it only contains static code.

  • html/DocTypeStrings.gperf: Include findDoctypeEntry function.
  • make-hash-tools.pl: Do not generate HashTools.h.
  • platform/ColorData.gperf: Include findColor function.
  • platform/HashTools.h: Added.
5:04 AM Changeset in webkit [72663] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-24 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Merge the usage of jumps and calls at ARM-JIT
​https://bugs.webkit.org/show_bug.cgi?id=50008

Those JmpSrc objects which represent jumps (not calls) should point to
after the jump instruction.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::blx): (JSC::ARMAssembler::loadBranchTarget): (JSC::ARMAssembler::getAbsoluteJumpAddress): (JSC::ARMAssembler::linkJump): (JSC::ARMAssembler::relinkJump): (JSC::ARMAssembler::linkCall): (JSC::ARMAssembler::relinkCall): (JSC::ARMAssembler::getRelocatedAddress): (JSC::ARMAssembler::getDifferenceBetweenLabels): (JSC::ARMAssembler::getCallReturnOffset):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::call):
4:51 AM Changeset in webkit [72662] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-24 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Optimize foldCase, toLower and toUpper methods in glib unicode backend
​https://bugs.webkit.org/show_bug.cgi?id=48625

GLib methods use UTF-8 strings, so we have to convert from UTF-16 to
UTF-8 to perform the case operations and then convert back the result to
UTF-16. GLib conversion methods return a new allocated string, so we
have to memcpy the result into the destination buffer too. Using our
own methods to convert between UTF-8 and UTF-16 from wtf/unicode/UTF8.h
we don't need such memcpy, since they take an already allocated buffer
rather than returning a new one. There's another optimization for the
case when the destination buffer is not large enough. In that case,
methods should return the expected destination buffer size and are
called again with a new buffer. We can avoid the conversion to UTF-16 by
pre-calculating the required size for the destination buffer.

  • wtf/unicode/glib/UnicodeGLib.cpp: (WTF::Unicode::getUTF16LengthFromUTF8): (WTF::Unicode::convertCase): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper):
4:29 AM Changeset in webkit [72661] by satish@chromium.org
  • 4 edits in trunk

2010-11-24 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Re-enabled layout tests which were disabled during an API migration.
​https://bugs.webkit.org/show_bug.cgi?id=50013

  • platform/chromium/test_expectations.txt:

2010-11-24 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Remove API migration code which is no longer used.
​https://bugs.webkit.org/show_bug.cgi?id=50013

  • public/WebSpeechInputControllerMock.h:
4:04 AM Changeset in webkit [72660] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-24 Andreas Kling <​kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Pass Qt::TextBypassShaping flag when calculating shadow layer rects

Without this, we could end up with a slightly too small shadow layer
for some string/font combinations.

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
4:00 AM Changeset in webkit [72659] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-24 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. chromium expectation fix.

BUG49967 MAC : font-size-zero.html = TEXT
was restored.

  • platform/chromium/test_expectations.txt:
3:42 AM Changeset in webkit [72658] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

2010-11-24 Steve block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

LayoutTest fast/dom/DeviceOrientation/event-after-navigation.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=49384

This is an asynchronous script test which navigates the main page but
relies on js-test-post.js calling LayoutTestController.waitUntilDone().
It's possible for the main page to be navigated and hence the load of
js-test-post.js to be cancelled before
LayoutTestController.waitUntilDone() is called, which causes the test to
fail.

  • fast/dom/DeviceOrientation/script-tests/event-after-navigation.js:
3:04 AM Changeset in webkit [72657] by pfeldman@chromium.org
  • 12 edits
    1 add in trunk

2010-11-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add timing tab to the network item view.
​https://bugs.webkit.org/show_bug.cgi?id=49920

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showPopover):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set timing):
  • inspector/front-end/ResourceTimingView.js: Added. (WebInspector.ResourceTimingView): (WebInspector.ResourceTimingView.prototype.show): (WebInspector.ResourceTimingView.prototype._refresh): (WebInspector.ResourceTimingView.createTimingTable):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/networkPanel.css: (#network-views .network-item-view .tabbed-pane-header): (.resource-timing-view): (.resource-timing-view table): (.resource-timing-view .network-timing-bar): (.resource-timing-view .network-timing-bar.proxy): (.resource-timing-view .network-timing-bar.dns): (.resource-timing-view .network-timing-bar.connecting): (.resource-timing-view .network-timing-bar.ssl): (.resource-timing-view .network-timing-bar.sending): (.resource-timing-view .network-timing-bar.waiting): (.resource-timing-view .network-timing-bar.receiving): (.resource-timing-view.visible):
2:59 AM Changeset in webkit [72656] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Follow up to r72652 (style id change in inspector).

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
2:36 AM Changeset in webkit [72655] by pfeldman@chromium.org
  • 18 edits
    4 adds in trunk/WebCore

2010-11-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor ResourceView hierarchy.
​https://bugs.webkit.org/show_bug.cgi?id=49864

This refactoring splits ResourceView.js into:

NetworkItemView.js (tabbed pane)
ResourceHeadersView.js (header tab)
ResourceCookiesView.js (cookies tab)
ResourceView.js (base class for content tab).

CookiesTable was extracted from CookieItemsView and
brushed up. headersVisible flag has been removed.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.resize): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._deleteCookie): (WebInspector.CookieItemsView.prototype._deleteButtonClicked): (WebInspector.CookieItemsView.prototype._refreshButtonClicked): (WebInspector.SimpleCookiesTable): (WebInspector.SimpleCookiesTable.prototype.setCookies): (WebInspector.SimpleCookiesTable.prototype.resize):
  • inspector/front-end/CookiesTable.js: Added. (WebInspector.CookiesTable): (WebInspector.CookiesTable.prototype.updateWidths): (WebInspector.CookiesTable.prototype.setCookies): (WebInspector.CookiesTable.prototype.addCookiesFolder): (WebInspector.CookiesTable.prototype.get selectedCookie): (WebInspector.CookiesTable.prototype._rebuildTable): (WebInspector.CookiesTable.prototype.reset): (WebInspector.CookiesTable.prototype._populateNode): (WebInspector.CookiesTable.prototype._totalSize): (WebInspector.CookiesTable.prototype._sortCookies.localeCompare): (WebInspector.CookiesTable.prototype._sortCookies.numberCompare): (WebInspector.CookiesTable.prototype._sortCookies.expiresCompare): (WebInspector.CookiesTable.prototype._sortCookies): (WebInspector.CookiesTable.prototype._createGridNode): (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystemView.prototype._selectFileSystemTab): (WebInspector.FileSystemView.prototype.selectTemporaryFileSystemTab):
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContent): (WebInspector.FontView.prototype._createContentIfNeeded): (WebInspector.FontView.prototype.show): (WebInspector.FontView.prototype.updateFontPreviewSize):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContent): (WebInspector.ImageView.prototype.show):
  • inspector/front-end/NetworkItemView.js: Added. (WebInspector.NetworkItemView): (WebInspector.NetworkItemView.prototype.show): (WebInspector.NetworkItemView.prototype._selectTab): (WebInspector.NetworkItemView.prototype._tabSelected): (WebInspector.NetworkItemView.prototype.resize): (WebInspector.NetworkItemView.prototype.selectContentTab):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refreshResource): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource):
  • inspector/front-end/ResourceCookiesView.js: Added. (WebInspector.ResourceCookiesView): (WebInspector.ResourceCookiesView.prototype.show):
  • inspector/front-end/ResourceHeadersView.js: Added. (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshURL): (WebInspector.ResourceHeadersView.prototype._refreshQueryString): (WebInspector.ResourceHeadersView.prototype._refreshFormData): (WebInspector.ResourceHeadersView.prototype._refreshRequestPayload): (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._toggleURLdecoding): (WebInspector.ResourceHeadersView.prototype._getHeaderValue): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation): (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.hasContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._showResourceView):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype.hasContent): (WebInspector.SourceView.prototype.updateLocalContent): (WebInspector.SourceView.prototype.selectLocalContentTab):
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.selectTab): (WebInspector.TabbedPane.prototype._showTab): (WebInspector.TabbedPane.prototype._hideTab):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.webkit-line-gutter-backdrop): (.resource-view): (.resource-view.visible): (.resource-view.font): (.resource-view.image > .image): (.resource-view.image > .info): (.storage-view): (.storage-view .data-grid): (.storage-empty-view, .storage-view .storage-table-error): (.storage-view .storage-table-error):
  • inspector/front-end/inspector.html:
  • inspector/front-end/networkPanel.css: (.network-cell-subtitle): (.network-header-subtitle): (#network-views .network-item-view .tabbed-pane-header): (#network-views.small .network-item-view .tabbed-pane-header): (.network-item-view): (.network-item-view.visible): (.network-item-view .tabbed-pane-header): (.network-item-view .scope-bar li): (.resource-headers-view): (.resource-headers-view.visible): (.resource-headers-view .outline-disclosure .parent): (.resource-headers-view .outline-disclosure .children li): (.resource-headers-view .outline-disclosure li.expanded .header-count): (.resource-headers-view .outline-disclosure .header-name): (.resource-headers-view .outline-disclosure .header-value): (.resource-headers-view .outline-disclosure .raw-form-data): (.resource-cookies-view): (.resource-cookies-view.visible): (.resource-cookies-view .data-grid): (.resource-cookies-view .data-grid .row-group):
2:28 AM Changeset in webkit [72654] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add "Locally modified" group into the resource panel.
​https://bugs.webkit.org/show_bug.cgi?id=50005

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.addLocallyModifiedRevision): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.BaseStorageTreeElement.prototype.set titleText): (WebInspector.LocallyModifiedResourceTreeElement): (WebInspector.LocallyModifiedResourceTreeElement.prototype.onselect): (WebInspector.LocallyModifiedResourceTreeElement.prototype.gcRevisions): (WebInspector.LocallyModifiedRevisionTreeElement): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onattach): (WebInspector.LocallyModifiedRevisionTreeElement.prototype.onselect): (WebInspector.LocallyModifiedRevisionTreeElement.prototype._ondragstart):
2:24 AM Changeset in webkit [72653] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-11-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72650.
​http://trac.webkit.org/changeset/72650
​https://bugs.webkit.org/show_bug.cgi?id=50010

breaks focus in scenes focus item other than graphicswebiview
(Requested by tronical_ on #webkit).

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::itemChange):
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2:11 AM Changeset in webkit [72652] by pfeldman@chromium.org
  • 9 edits in trunk

2010-11-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: pass style id to front-end as Object, not string.
​https://bugs.webkit.org/show_bug.cgi?id=49971

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getStyleSheetText2): (WebCore::InspectorCSSAgent::setPropertyText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyleSheet::finalURL): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::text):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorCSSId::InspectorCSSId): (WebCore::InspectorCSSId::isEmpty): (WebCore::InspectorCSSId::styleSheetId): (WebCore::InspectorCSSId::ordinal): (WebCore::InspectorCSSId::asInspectorValue): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):

2010-11-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: pass style id to front-end as Object, not string.
​https://bugs.webkit.org/show_bug.cgi?id=49971

  • inspector/styles-new-API.html:
1:47 AM Changeset in webkit [72651] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-24 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix uninitialized variable in QGraphicsWKViewPrivate

Always initialize QGWKVP::m_isChangingScale in the constructor.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
1:34 AM Changeset in webkit [72650] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-11-24 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Html autofocus not working with QGraphicsWebView
​https://bugs.webkit.org/show_bug.cgi?id=43169

QGraphicsScene does not propagate Qt::ActivateWindowFocusReason focus
events when there are no active items.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::eventFilter): (QGraphicsWebView::itemChange):
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (FocusPage::FocusPage): (FocusPage::event): (FocusPage::gotFocus): (tst_QGraphicsWebView::receivesFocusInOnShow):
1:25 AM Changeset in webkit [72649] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72647.
​http://trac.webkit.org/changeset/72647
​https://bugs.webkit.org/show_bug.cgi?id=50009

breaks the http layout tests (Requested by philn-tp on
#webkit).

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): (WebCore::startHttp): (WebCore::ResourceHandle::platformSetDefersLoading):
1:01 AM BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
Fix the MSVC instructions. (diff)
12:32 AM Changeset in webkit [72648] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Fix for chromium expectations.

composited-plugin.html is crashing on MAC.
small-to-large-composited-plugin.html is crashing on MAC.
font-size-zero.html is passing.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:24 AM Changeset in webkit [72647] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-11-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[soup] implement ResourceHandle::platformSetDefersLoading
​https://bugs.webkit.org/show_bug.cgi?id=44158

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Implemented using the soup_session_{,un}pause_message APIs.

Nov 23, 2010:

10:35 PM Changeset in webkit [72646] by Patrick Gansterer
  • 2 edits in trunk

2010-11-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Levin.

Add WebKit2 VisualStudio files to .gitattributes
​https://bugs.webkit.org/show_bug.cgi?id=49969

  • .gitattributes:
8:44 PM Changeset in webkit [72645] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Drag and drop not working properly. Skipping just like other similar drag
and drop tests. E.g. similar test drag-image-in-about-blank-frame.html.

  • platform/qt/Skipped:
8:14 PM Changeset in webkit [72644] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

2010-11-22 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

r71925 broke the chrome new tab page. r71925 blocked drag and drop
of same security origin objects onto themselves if their origin is
marked unique. We need to allow drag and drop in that scenario.
​https://bugs.webkit.org/show_bug.cgi?id=49098

Test: http/tests/security/drag-drop-same-unique-origin.html

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canReceiveDragData):

2010-11-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that drag and drop is allowed across the same security origin object,
even if they are marked unique.

  • http/tests/security/drag-drop-same-unique-origin-expected.txt: Added.
  • http/tests/security/drag-drop-same-unique-origin.html: Added.
  • http/tests/security/resources/drag-drop-allowed.html: Added.
4:22 PM Changeset in webkit [72643] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed update of GTK's skipped list.

Disabled editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html
because they require editing delegates dump which haven't been implemented in GTK.

  • platform/gtk/Skipped:
4:19 PM Changeset in webkit [72642] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-23 Tony Chang <​tony@chromium.org>

Unreviewed, [chromium] merge the plugin failures in test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=49993

  • platform/chromium/drt_expectations.txt: Remove plugin failures
  • platform/chromium/test_expectations.txt: Move them into this file

with expectations that are valid for either plugin.

4:15 PM Changeset in webkit [72641] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-23 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

This patch cleans up the logic used to shard tests into groups a
bit and adds the --worker-model flag to NRWT. The flag is only
used at the moment to control whether to run single-threaded or
not, but eventually will also allow toggling between threads and
processes.

Also add a minor cleanup with _test_is_slow(), which just
eliminates some repetition and gives slightly better encapsulation.

​https://bugs.webkit.org/show_bug.cgi?id=49773

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:12 PM Changeset in webkit [72640] by mihaip@chromium.org
  • 8 edits
    1 add in trunk/WebKitTools

2010-11-23 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: list current baselines and platforms
​https://bugs.webkit.org/show_bug.cgi?id=49991

List existing baselines (with Trac links) for tests.

Add dropdowns for choosing with platform baselines to target (and what
to do with existing ones).

Also fix MockFileSystem.join to behave more like os.path.join (unit
test was ending up with two consecutive slashes in a layout test
path).

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
4:12 PM Changeset in webkit [72639] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Removed unneeded conversions to RenderBlock.
​https://bugs.webkit.org/show_bug.cgi?id=49896

Test: fast/css/input-search-table-column-crash.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):

2010-11-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Test for crash with input type search and table column style.
​https://bugs.webkit.org/show_bug.cgi?id=49896

  • fast/css/input-search-table-column-crash-expected.txt: Added.
  • fast/css/input-search-table-column-crash.html: Added.
3:59 PM Changeset in webkit [72638] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
​https://bugs.webkit.org/show_bug.cgi?id=49701

Fixed the bug by calling ScriptElement's executeScript, which sets isEvaluated flag to true.

Test: fast/dom/script-clone-rerun-src.xhtml

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished):

2010-11-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
​https://bugs.webkit.org/show_bug.cgi?id=49701

Added a test to ensure WebKit doesn't run the script twice when a script element with an external script file
is cloned in a XML document.

  • fast/dom/resources/script-clone-rerun-src.js: Added.
  • fast/dom/script-clone-rerun-src.xhtml: Added.
3:39 PM Changeset in webkit [72637] by rniwa@webkit.org
  • 3 edits
    2 adds
    23 deletes in trunk/LayoutTests

2010-11-23 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsText conversion: editing/deleting/delete-by-word-001.html and delete-by-word-002.html
​https://bugs.webkit.org/show_bug.cgi?id=48130

Converted editing/deleting/delete-by-word-001.html and delete-by-word-002.html to dumpAsText tests
by replacing calls to runEditingTest by runDumpAsTextEditingTest.

  • editing/deleting/delete-by-word-001-expected.txt: Added.
  • editing/deleting/delete-by-word-001.html:
  • editing/deleting/delete-by-word-002-expected.txt: Added.
  • editing/deleting/delete-by-word-002.html:
  • platform/chromium-linux/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.txt: Removed.
3:39 PM Changeset in webkit [72636] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-23 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

remove timeout argument to urlopen
​https://bugs.webkit.org/show_bug.cgi?id=49995

Apparently the version of python we have on the bots doesn't accept a timeout argument.

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3:36 PM Changeset in webkit [72635] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
​http://trac.webkit.org/changeset/72628
​https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • accessibility/iframe-has-document-expected.txt: Removed.
  • accessibility/iframe-has-document.html: Removed.
  • platform/win/Skipped:

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
​http://trac.webkit.org/changeset/72628
​https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
​http://trac.webkit.org/changeset/72628
​https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::parentObject):

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
​http://trac.webkit.org/changeset/72628
​https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/CppBoundClass.h:
3:15 PM Changeset in webkit [72634] by xan@webkit.org
  • 4 edits in trunk

WebCore:

2010-11-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix IFrame DOM bindings API
​https://bugs.webkit.org/show_bug.cgi?id=49980

Fix IFrame API naming. It needs special casing because of the two
consecutive capital letters.

  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-11-23 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix IFrame DOM bindings API
​https://bugs.webkit.org/show_bug.cgi?id=49980

  • tests/testdomdocument.c: (test_dom_document_garbage_collection): change to use the fixed IFrame APIs.
2:59 PM Changeset in webkit [72633] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=49944

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2:55 PM Changeset in webkit [72632] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing chromium gpu_test expectations.

Remove entries for tests that no longer exist, removed in r71822.
Remove duplicates introduced in r72613.

  • platform/chromium-gpu/test_expectations.txt:
2:54 PM Changeset in webkit [72631] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-23 Shimeng (Simon) Wang <​swang@google.com>

Reviewed by Steve Block.

Use platform bridge to set scroll position.
​https://bugs.webkit.org/show_bug.cgi?id=49550

Refactoring only. Existing tests shall suffice.

  • platform/android/PlatformBridge.h:
  • platform/android/ScrollViewAndroid.cpp: (WebCore::ScrollView::platformSetScrollPosition):
2:51 PM Changeset in webkit [72630] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-23 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Selecting shadowed text causes rendering artifacts
​https://bugs.webkit.org/show_bug.cgi?id=49990

When selecting text starting from the end of a word, we need to use
the X coordinate of the start of the substring when calculating the
bounding rect for a ContextShadow.

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
2:43 PM Changeset in webkit [72629] by crogers@google.com
  • 3 edits in trunk/LayoutTests

2010-11-23 Chris Rogers <​crogers@google.com>

Unreviewed.

Disable new XMLHttpRequest layout tests for Qt and gtk since they require ArrayBuffer support
​https://bugs.webkit.org/show_bug.cgi?id=49992

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:33 PM Changeset in webkit [72628] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

2010-11-23 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • accessibility/iframe-has-document-expected.txt: Added.
  • accessibility/iframe-has-document.html: Added.
  • platform/win/Skipped:

2010-11-23 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

Include render widget children in the accessibility tree for not mac webkit ports.

Test: accessibility/iframe-has-document.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren): (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-11-23 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::equals): (WebKit::WebAccessibilityObject::parentObject):

2010-11-23 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
​https://bugs.webkit.org/show_bug.cgi?id=49106

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback): (AccessibilityUIElement::isEqualCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getFromCppVariant):
  • DumpRenderTree/chromium/CppBoundClass.h:
2:00 PM Changeset in webkit [72627] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-23 Tony Chang <​tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] update plugin expectations
​https://bugs.webkit.org/show_bug.cgi?id=49988

  • platform/chromium/drt_expectations.txt: These tests are passing on the bot
  • platform/chromium/test_expectations.txt: Group and sort alphabetically
1:51 PM Changeset in webkit [72626] by crogers@google.com
  • 7 edits
    9 adds in trunk

2010-11-23 Chris Rogers <​crogers@google.com>

Reviewed by Alexey Proskuryakov.

Add .responseType and .response to XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=49633

Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html

fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
fast/xmlhttprequest/xmlhttprequest-responsetype-document.html
fast/xmlhttprequest/xmlhttprequest-responsetype-text.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::responseBlob): (WebCore::XMLHttpRequest::responseArrayBuffer): (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::responseType): (WebCore::XMLHttpRequest::setAsBlob): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob): (WebCore::XMLHttpRequest::optionalResponseXML): (WebCore::XMLHttpRequest::optionalResponseBlob): (WebCore::XMLHttpRequest::responseTypeCode): (WebCore::XMLHttpRequest::optionalResponseArrayBuffer):
  • xml/XMLHttpRequest.idl:

2010-11-23 Chris Rogers <​crogers@google.com>

Reviewed by Alexey Proskuryakov.

Add .responseType and .response to XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=49633

  • fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-document.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-text.html: Added.
  • http/tests/resources/balls-of-the-orient.aif: Added.
1:34 PM Changeset in webkit [72625] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

2010-11-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

dispatchEvent call in EventSource endRequest can lead to calling endRequest
again which frees up the pending activity. Make sure we have request in flight
to prevent that from happening.
​https://bugs.webkit.org/show_bug.cgi?id=49448

Test: http/tests/eventsource/eventsource-status-error-iframe-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::endRequest): (WebCore::EventSource::close):

2010-11-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Tests that we do not crash on EventSource status errors inside an iframe.
​https://bugs.webkit.org/show_bug.cgi?id=49448

  • http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt: Added.
  • http/tests/eventsource/eventsource-status-error-iframe-crash.html: Added.
  • http/tests/eventsource/resources/request-status-error.htm: Added.
1:30 PM Changeset in webkit [72624] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/WebKit/chromium

2010-11-23 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Introduce wrapper types for WebCore::GeolocationError, WebCore::GeolocationPosition.
​https://bugs.webkit.org/show_bug.cgi?id=49735

Introduce WebKit API types so that the browser implementation can feed
position and error updates to the WebCore::GeolocationController.

  • WebKit.gyp:
  • public/WebGeolocationError.h: Added. (WebKit::WebGeolocationError::WebGeolocationError): (WebKit::WebGeolocationError::~WebGeolocationError):
  • public/WebGeolocationPosition.h: Added. (WebKit::WebGeolocationPosition::WebGeolocationPosition): (WebKit::WebGeolocationPosition::~WebGeolocationPosition):
  • src/WebGeolocationError.cpp: Added. (WebKit::WebGeolocationError::assign): (WebKit::WebGeolocationError::reset): (WebKit::WebGeolocationError::WebGeolocationError): (WebKit::WebGeolocationError::operator=): (WebKit::WebGeolocationError::operator WTF::PassRefPtr<WebCore::GeolocationError>):
  • src/WebGeolocationPosition.cpp: Added. (WebKit::WebGeolocationPosition::assign): (WebKit::WebGeolocationPosition::reset): (WebKit::WebGeolocationPosition::operator=): (WebKit::WebGeolocationPosition::operator PassRefPtr<WebCore::GeolocationPosition>):
1:07 PM Changeset in webkit [72623] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-23 Jonathan Backer <​backer@chromium.org>

Reviewed by Kenneth Russell.

Renderer is resizing IOSurfaces when accelerated compositing is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=49827

  • IOSurfaces are only presented when accelerated compositing is enabled.
  • Slight performance increase (and clean-up for using this path for Linux and Windows).
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
12:50 PM Changeset in webkit [72622] by jparent@chromium.org
  • 4 edits
    2 deletes in trunk

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72618.
​http://trac.webkit.org/changeset/72618
​https://bugs.webkit.org/show_bug.cgi?id=49987

"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).

  • editing/EditingBehavior.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):

2010-11-23 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72618.
​http://trac.webkit.org/changeset/72618
​https://bugs.webkit.org/show_bug.cgi?id=49987

"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).

  • editing/selection/context-menu-text-selection-expected.txt: Removed.
  • editing/selection/context-menu-text-selection.html: Removed.
12:40 PM Changeset in webkit [72621] by Martin Robinson
  • 4 edits in trunk/WebKit/gtk

2010-11-23 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

focus issue with links that have tooltips
​https://bugs.webkit.org/show_bug.cgi?id=49498

Set the area of the widget where the tooltip should be shown when
a new tooltip is set. Since the widget is the same (the view), if
the tooltip area is not set and a new tooltip is triggered while
the previous one is still visible, the text of the tooltip is
updated but its position doesn't change.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_query_tooltip):
12:33 PM Changeset in webkit [72620] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-23 Grace Kloba <​klobag@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Accumulated scroll damage rect should be in the content space
​https://bugs.webkit.org/show_bug.cgi?id=49842

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): Adjust the previous scroll damage with the scroll delta before union it with the new damage rect.
12:14 PM Changeset in webkit [72619] by jparent@chromium.org
  • 1 edit
    2 copies in trunk/LayoutTests

Unreviewed, fixing chromium baselines.
Adding back baselines that were removed in r72542 due to r72527, because
r72527 was rolled ou in r72582.

  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
11:33 AM Changeset in webkit [72618] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-11-23 Avi Drissman <​avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

  • editing/selection/context-menu-text-selection-expected.txt: Added.
  • editing/selection/context-menu-text-selection.html: Added.

2010-11-23 Avi Drissman <​avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
​https://bugs.webkit.org/show_bug.cgi?id=23351

Test: editing/selection/context-menu-text-selection.html

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
11:02 AM Changeset in webkit [72617] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-23 Alex Grilo <​abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add tiled backing store to EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=45777

Allow EWebLauncher to choose between single and tiled backing store

  • EWebLauncher/main.c: (on_key_down): (browserCreate): (main):
10:35 AM Changeset in webkit [72616] by darin@chromium.org
  • 5 edits
    2 adds in trunk/WebKit/chromium

2010-11-18 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add a mechanism for creating a WebURLLoader that is associated with a
particular WebFrame.
​https://bugs.webkit.org/show_bug.cgi?id=49764

This will be used by code that calls webKitClient()->createURLLoader()
from within the Chromium source tree.

An associated WebURLLoader should be treated like a subresource of the
WebFrame's document.

  • WebKit.gyp:
  • public/WebFrame.h:
  • src/AssociatedURLLoader.cpp: Added. (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::PrepareRequest):
  • src/AssociatedURLLoader.h: Added.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createAssociatedURLLoader):
  • src/WebFrameImpl.h:
10:31 AM Changeset in webkit [72615] by apavlov@chromium.org
  • 7 edits in trunk

2010-11-23 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] invalid color values are not marked as such.
​https://bugs.webkit.org/show_bug.cgi?id=49960

Properties having a valid structure but invalid values will also
be marked as non-parsedOk in the Styles pane.

WebCore:

  • css/CSSGrammar.y:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):

LayoutTests:

  • inspector/resources/styles-new-API.css: (body):
  • inspector/styles-new-API-expected.txt:
  • inspector/styles-source-offsets-expected.txt:
10:09 AM WebDevelopers edited by dkeith@apple.com
updated instructions on how to turn on Safari's Develop menu (diff)
9:29 AM Changeset in webkit [72614] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-23 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Building with Blob support fails
​https://bugs.webkit.org/show_bug.cgi?id=49724

Build fix.

  • GNUmakefile.am:
  • platform/gtk/FileSystemGtk.cpp: (WebCore::seekFile): Not implemented.
9:18 AM Changeset in webkit [72613] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Updated chromium expectations.

Plugin tests were disabled.

MAC : compositing/plugins/1x1-composited-plugin.html = CRASH
MAC : compositing/plugins/composited-plugin.html = CRASH
MAC : compositing/plugins/large-to-small-composited-plugin.html = CRASH
MAC : compositing/plugins/small-to-large-composited-plugin.html = CRASH

  • platform/chromium-gpu/test_expectations.txt:
8:58 AM Changeset in webkit [72612] by andreas.kling@nokia.com
  • 13 edits in trunk

2010-11-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Make setShouldDelegateScrolling not a real setting, so that it works
similar to the related setUseFixedLayout and setPaintEntireContents
options which are all in ScrollView.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setDelegatesScrolling):
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling):

2010-11-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page, etc.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
8:54 AM Changeset in webkit [72611] by Adam Roben
  • 3 edits in trunk/WebCore

Don't rely on DocumentLoader outliving the load/unload events

DocumentLoader::m_documentLoadTiming is used to record how long firing
the load event took. But the DocumentLoader was being destroyed while
the event was being dispatched (due to a call to document.open), which
meant that when we tried to record the time when the load event
finished, we were writing into freed memory. We now protect the
DocumentLoader using a RefPtr. (I initially made a change where we
would only access the DocumentLoader after the event has finished
firing, but it seemed possible that a different DocumentLoader could
have come into existence by then, which would cause us to record the
times on the wrong DocumentLoadTiming struct.)

I only saw a crash when firing the load event, but the code for timing
the unload event seemed like it was vulnerable to the same issue, so I
made the same fix for it.

Fixes <​http://webkit.org/b/49972> REGRESSION (r72415?): Crash in
DOMWindow::dispatchTimedEvent when running fast/dom/onload-open.html

Reviewed by Darin Fisher.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):
Protect the DocumentLoader (and thus its DocumentLoadTiming) with a
RefPtr.

8:51 AM Changeset in webkit [72610] by zmo@google.com
  • 3 edits
    2 adds in trunk

2010-11-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
​https://bugs.webkit.org/show_bug.cgi?id=49673

Test: fast/canvas/webgl/read-pixels-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels):

2010-11-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
​https://bugs.webkit.org/show_bug.cgi?id=49673

  • fast/canvas/webgl/read-pixels-test-expected.txt: Added.
  • fast/canvas/webgl/read-pixels-test.html: Added.
8:19 AM Changeset in webkit [72609] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Expectations for chromium were fixed.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
7:47 AM Changeset in webkit [72608] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Just fixing tipo in test_expectations.txt

  • platform/chromium/test_expectations.txt:
7:34 AM Changeset in webkit [72607] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Updating test expectations for chromium.

  • platform/chromium/test_expectations.txt:
7:33 AM Changeset in webkit [72606] by Laszlo Gombos
  • 3 edits in trunk/WebKit/qt

2010-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with !ENABLE(INSPECTOR)
​https://bugs.webkit.org/show_bug.cgi?id=49942

Add ENABLE(INSPECTOR) to the Qt specific files following r71981.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::sendMessageToFrontend):
  • WebCoreSupport/InspectorServerQt.cpp: (WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
7:02 AM BuildingQtOnLinux edited by benjamin.poulain@nokia.com
SQLite takes only one 'L' (diff)
7:01 AM Changeset in webkit [72605] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Adjusting expectations for chromium.

  • platform/chromium/test_expectations.txt:
6:52 AM Changeset in webkit [72604] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Restore binary compatibility with the QtWebKit 2.1 branch

Reviewed by Andreas Kling.

Re-order the enums by adding new enum entries to the end.

  • Api/qwebsettings.h:
6:24 AM Changeset in webkit [72603] by Simon Hausmann
  • 8 edits in trunk

[Qt] Review the setUserPermission & friends API
​https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Renamed requestPermissionFromUser to featurePermissionRequested
and cancelRequestsForPermission to featurePermissionRequestCanceled.

WebKit/qt:

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):
(WebPage::featurePermissionRequestCanceled):

  • QtTestBrowser/webpage.h:
6:23 AM Changeset in webkit [72602] by Simon Hausmann
  • 8 edits in trunk

[Qt] Review the setUserPermission & friends API
​https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename setUserPermission to setFeaturePermission

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setFeaturePermission):

  • Api/qwebpage.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::requestPermission):

6:23 AM Changeset in webkit [72601] by Simon Hausmann
  • 12 edits in trunk

[Qt] Review the setUserPermission & friends API
​https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
and GeolocationPermissionDomain to Geolocation.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission):

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::geolocationPermissionSet):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::cancelRequestsForPermission):

  • QtTestBrowser/webpage.h:
6:22 AM Changeset in webkit [72600] by Simon Hausmann
  • 9 edits in trunk

[Qt] Review the setUserPermission & friends API
​https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Add a ByUser suffix to PermissionGranted/Denied. In the future
we can add PermissionGrantedByDefault.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission):

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::setPermission):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::requestPermission):

5:25 AM Changeset in webkit [72599] by loislo@chromium.org
  • 52 edits
    5 copies
    3 adds
    4 deletes in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed rollout r72534 and r72533 because r72544, r72530 and r72527 were reverted.

  • platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-linux/fast/doctypes/002-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/001-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/002-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/002-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/003-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/003-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/007-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/007-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/008-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/008-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Removed.
  • platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/padding_right-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/chromium-win/fast/doctypes/002-expected.checksum:
  • platform/chromium-win/fast/doctypes/002-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/002-expected.checksum:
  • platform/chromium-win/fast/lists/002-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.checksum:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/007-vertical-expected.txt:
  • platform/chromium-win/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/008-vertical-expected.txt:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
5:19 AM Changeset in webkit [72598] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-23 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Use strike through as an 'overridden' marker.
​https://bugs.webkit.org/show_bug.cgi?id=49961

"line-through" is used for inactive properties overridden within the same style.

  • inspector/front-end/inspector.css: (.styles-section .properties .overloaded, .styles-section .properties .inactive, .styles-section .properties .disabled):
5:04 AM Changeset in webkit [72597] by satish@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-23 Satish Sampath <​satish@chromium.org>

Unreviewed, chromium build fix.

  • public/WebSpeechInputControllerMock.h: (WebKit::WebSpeechInputControllerMock::setMockRecognitionResult):
4:57 AM Changeset in webkit [72596] by yael.aharon@nokia.com
  • 5 edits in trunk/WebCore

2010-11-23 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=49442

Remove code that is not used anymore after ​http://trac.webkit.org/changeset/72522.
Added const to canBeScrolledIntoView.
No new tests because this is only code cleanup.

  • page/FocusController.cpp:
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::canBeScrolledIntoView):
  • page/SpatialNavigation.h:
4:48 AM Changeset in webkit [72595] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed.

fast/text/font-size-zero.html was disabled.
It is failing on Mac platform.

​https://bugs.webkit.org/show_bug.cgi?id=49967

  • platform/chromium/test_expectations.txt:
3:54 AM Changeset in webkit [72594] by alex
  • 3 edits in trunk/LayoutTests

2010-11-23 Alejandro G. Castro <​alex@igalia.com>

Unreviewed. Rebaselined
svg-curve-with-relative-cordinates-expected.txt test.

Skipped fast/profiler/throw-exception-from-eval.html, checked in
bug ​https://bugs.webkit.org/show_bug.cgi?id=49801

Skipped fast/canvas/canvas-fillPath-shadow.html and
fast/canvas/canvas-strokePath-shadow.html until we check if there
is an issue in the gtk shadows or DRT.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
3:14 AM Changeset in webkit [72593] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-11-23 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Remove unimplemented (and untested) methods from IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=49911

  • storage/IDBCursor.idl:
  • storage/IDBDatabase.idl:
2:07 AM Changeset in webkit [72592] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-11-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Sam Weinig.

Use WTF::StringHasher directly in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=49893

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
2:01 AM Changeset in webkit [72591] by satish@chromium.org
  • 40 edits
    8 copies
    1 add in trunk

2010-11-18 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
​https://bugs.webkit.org/show_bug.cgi?id=49736

  • fast/speech/input-onspeechchange-event-expected.txt: Added.
  • fast/speech/input-onspeechchange-event.html: New test to check multiple results.
  • fast/speech/input-text-language-tag.html: Updated with new method signature.
  • fast/speech/input-text-speechbutton.html: Ditto.
  • fast/speech/speech-button-ignore-generated-events.html: Ditto.

2010-11-18 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
​https://bugs.webkit.org/show_bug.cgi?id=49736

Currently the speech input event 'onwebkitspeechchange' receives no parameters. WebCore already
has the full list of recognition results and populates only the top result into the input field
automatically. In this patch we pass a SpeechInputEvent object to the event handler, and the JS
code can access the full list of results via "event.results.length", "results[i].utterance" and
"results[i].confidence". Also updated mock object with appropriate methods to test multiple results.

Test: fast/speech/input-onspeechchange-event.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): Added new event
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): Added new event
  • dom/Event.cpp: (WebCore::Event::isSpeechInputEvent):
  • dom/Event.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • page/SpeechInputEvent.h: New file implementing SpeechInputEvent.idl (WebCore::SpeechInputEvent::~SpeechInputEvent): (WebCore::SpeechInputEvent::create): (WebCore::SpeechInputEvent::isSpeechInputEvent): (WebCore::SpeechInputEvent::results): (WebCore::SpeechInputEvent::SpeechInputEvent):
  • page/SpeechInputEvent.idl: New file defining SpeechInputEvent object
  • page/SpeechInputListener.h:
  • page/SpeechInputResult.cpp: (WebCore::SpeechInputResult::create):
  • page/SpeechInputResult.h:
  • page/SpeechInputResult.idl: New file defining a single SpeechInputResult object
  • page/SpeechInputResultList.h: New file implementing SpeechInputResultList.idl (WebCore::SpeechInputResultList::create): (WebCore::SpeechInputResultList::length): (WebCore::SpeechInputResultList::item): (WebCore::SpeechInputResultList::SpeechInputResultList):
  • page/SpeechInputResultList.idl: New file defining a list of SpeechInputResult objects
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::addRecognitionResult): Renamed method and added one parameter. (WebCore::SpeechInputClientMock::clearResults): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Pass new event object to handler.

2010-11-18 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
​https://bugs.webkit.org/show_bug.cgi?id=49736

Updated mock object's method to new signature.

  • public/WebSpeechInputControllerMock.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
  • src/WebSpeechInputControllerMockImpl.h:

2010-11-18 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
​https://bugs.webkit.org/show_bug.cgi?id=49736

Updated DRT by renaming the mock result method on all platforms to the new signature.

  • DumpRenderTree/LayoutTestController.cpp: (addMockSpeechInputResultCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::addMockSpeechInputResult):
12:55 AM Changeset in webkit [72590] by ap@apple.com
  • 17 edits
    9 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=49860
CSS style rules don't GC protect objects reachable as their properties

Test: fast/dom/StyleSheet/gc-rule-children-wrappers.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added new files, sorted appropriate sections for easier adding.
  • bindings/js/JSCSSFontFaceRuleCustom.cpp: Added. (WebCore::JSCSSFontFaceRule::markChildren):
  • bindings/js/JSCSSImportRuleCustom.cpp: Added. (WebCore::JSCSSImportRule::markChildren):
  • bindings/js/JSCSSMediaRuleCustom.cpp: Added. (WebCore::JSCSSMediaRule::markChildren):
  • bindings/js/JSCSSPageRuleCustom.cpp: Added. (WebCore::JSCSSPageRule::markChildren):
  • bindings/js/JSCSSStyleRuleCustom.cpp: Added. (WebCore::JSCSSStyleRule::markChildren):
  • bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Added. (WebCore::JSWebKitCSSKeyframeRule::markChildren):
  • bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Added. (WebCore::JSWebKitCSSKeyframesRule::markChildren): Mark objects reachable through these ones.
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSStyleRule.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl: Added CustomMarkFunction IDL attribute.
12:43 AM Changeset in webkit [72589] by Csaba Osztrogonác
  • 27 edits
    12 deletes in trunk/LayoutTests

Unreviewed revert r72544 and r72530, because r72527 was reverted.

Outside list bullets ignore text-align style.
​https://bugs.webkit.org/show_bug.cgi?id=15713

  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/002-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/lists/007-vertical-expected.txt:
  • platform/gtk/fast/lists/008-vertical-expected.txt:
  • platform/gtk/fast/lists/outSideListMarkers-expected.txt: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.checksum: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.png: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.checksum: Removed.
  • platform/qt/css1/box_properties/padding_right-expected.png: Removed.
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/fast/doctypes/002-expected.checksum: Removed.
  • platform/qt/fast/doctypes/002-expected.png: Removed.
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/lists/007-vertical-expected.checksum:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.txt:
  • platform/qt/fast/lists/008-vertical-expected.checksum:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.txt:
  • platform/qt/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/qt/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/qt/fast/lists/outSideListMarkers-expected.txt: Removed.
12:00 AM Changeset in webkit [72588] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2010-11-23 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
​https://bugs.webkit.org/show_bug.cgi?id=49878

New test checking solid and blurry shadow on images drawn on canvas.

  • fast/canvas/canvas-drawImage-shadow-expected.txt: Added.
  • fast/canvas/canvas-drawImage-shadow.html: Added.
  • fast/canvas/script-tests/canvas-drawImage-shadow.js: Added.

2010-11-23 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
​https://bugs.webkit.org/show_bug.cgi?id=49878

Add support for blurry shadows when drawing images on canvas.

Test: fast/canvas/canvas-drawImage-shadow.html

  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::endShadowLayer): Make composition work for solid shadow too.
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw): Remove old shadow code and introduce ContextShadow.

Nov 22, 2010:

11:44 PM Changeset in webkit [72587] by commit-queue@webkit.org
  • 8 edits in trunk/WebKit/chromium

2010-11-22 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
​https://bugs.webkit.org/show_bug.cgi?id=49946

  • public/WebGraphicsContext3D.h: added isContextLost()
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isContextLost):
  • src/GraphicsContext3DInternal.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining
10:46 PM Changeset in webkit [72586] by jcivelli@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-22 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Don't create an external popup menu when there are no items to show.
​https://bugs.webkit.org/show_bug.cgi?id=49937

  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::show):
10:26 PM Changeset in webkit [72585] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Port ContextMenuWin.cpp to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=48408

  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::insertMenuItem): (WebCore::ContextMenu::insertItem): (WebCore::contextMenuItemByIdOrPosition): (WebCore::ContextMenu::setPlatformDescription): (WebCore::contextMenuItemVector): (WebCore::platformMenuDescription):
10:05 PM Changeset in webkit [72584] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-22 Nat Duca <​nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Send didActivateAcceleratedCompositing when compositor
initializes but does not create the shared context3d.
​https://bugs.webkit.org/show_bug.cgi?id=49930

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
9:44 PM Changeset in webkit [72583] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests

Back out rebaselines from r72527.

  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
9:41 PM Changeset in webkit [72582] by hyatt@apple.com
  • 67 edits
    4 deletes in trunk

Back out r72527 since it caused multiple rendering regressions. Details in bug.

WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

  • fast/lists/outSideListMarkers-expected.txt: Removed.
  • fast/lists/outSideListMarkers.html: Removed.
  • platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/margin_right-expected.png:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.png:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/doctypes/002-expected.checksum:
  • platform/mac-leopard/fast/doctypes/002-expected.png:
  • platform/mac-leopard/fast/lists/001-expected.checksum:
  • platform/mac-leopard/fast/lists/001-expected.png:
  • platform/mac-leopard/fast/lists/002-expected.checksum:
  • platform/mac-leopard/fast/lists/002-expected.png:
  • platform/mac-leopard/fast/lists/003-expected.checksum:
  • platform/mac-leopard/fast/lists/003-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/doctypes/002-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.checksum:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/002-expected.txt:
  • platform/mac/fast/lists/002-vertical-expected.checksum:
  • platform/mac/fast/lists/002-vertical-expected.png:
  • platform/mac/fast/lists/002-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.checksum:
  • platform/mac/fast/lists/003-vertical-expected.png:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/007-vertical-expected.checksum:
  • platform/mac/fast/lists/007-vertical-expected.png:
  • platform/mac/fast/lists/007-vertical-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.
8:43 PM Changeset in webkit [72581] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2010-11-22 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Implement mocks for client-based Geolocation.
​https://bugs.webkit.org/show_bug.cgi?id=49258

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mock/GeolocationClientMock.cpp: Added. (WebCore::GeolocationClientMock::GeolocationClientMock): (WebCore::GeolocationClientMock::~GeolocationClientMock): (WebCore::GeolocationClientMock::setController): (WebCore::GeolocationClientMock::setPosition): (WebCore::GeolocationClientMock::setError): (WebCore::GeolocationClientMock::geolocationDestroyed): (WebCore::GeolocationClientMock::startUpdating): (WebCore::GeolocationClientMock::stopUpdating): (WebCore::GeolocationClientMock::setEnableHighAccuracy): (WebCore::GeolocationClientMock::lastPosition): (WebCore::GeolocationClientMock::timerFired): (WebCore::GeolocationClientMock::makeGeolocationCallback):
  • platform/mock/GeolocationClientMock.h: Added.
8:10 PM Changeset in webkit [72580] by commit-queue@webkit.org
  • 2 edits in trunk/PlanetWebKit

2010-11-22 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Andreas Kling.

Add Leandro Pereira's blog to Planet WebKit
​https://bugs.webkit.org/show_bug.cgi?id=49910

  • config.ini:
6:35 PM Changeset in webkit [72579] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk/WebKit/efl

2010-11-22 Alex Grilo <​abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Tiled Backing Store for Webkit-Efl
​https://bugs.webkit.org/show_bug.cgi?id=45397

This tile based backing store is a grid of tiles where each tile is
an Evas_Object showing a piece of the page content. The
new ewk_view_tiled.c is an implementation of some of the functions of
the original ewk_view, that makes calls to the Tiled Backing Store
specific functions.

The rendering occurs in the pixels stored in each tile (Evas_Object),
in the same way as the previous single backing store. Tiles not being
shown in the viewport are stored in a cache, and can be reused later
to avoid having to be rendered again.

Scrolling occurs as just moving the tiles, using Evas move operations,
and when more than one tile size is scrolled, a shift of rows or
columns needs to be done.

  • CMakeListsEfl.txt:
  • ewk/ewk_tiled_backing_store.c: Added. (_ewk_tiled_backing_store_updates_process): (_ewk_tiled_backing_store_flush): (_ewk_tiled_backing_store_tile_new): (_ewk_tiled_backing_store_item_move): (_ewk_tiled_backing_store_item_resize): (_ewk_tiled_backing_store_tile_associate): (_ewk_tiled_backing_store_tile_dissociate): (_ewk_tiled_backing_store_tile_dissociate_all): (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_del): (_ewk_tiled_backing_store_pre_render_request_first): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_remove_unassociated): (_ewk_tiled_backing_store_pre_render_request_remove_associated): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_process_idler_stop): (_ewk_tiled_backing_store_item_process_idler_start): (_ewk_tiled_backing_store_item_request_del): (_ewk_tiled_backing_store_item_request_add): (_ewk_tiled_backing_store_disable_render): (_ewk_tiled_backing_store_enable_render): (_ewk_tiled_backing_store_visible_tiles_rect): (_ewk_tiled_backing_store_tile_is_inside_viewport): (_ewk_tiled_backing_store_tile_is_adjacent_to_viewport): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_item_smooth_scale_set): (_ewk_tiled_backing_store_changed): (_ewk_tiled_backing_store_view_cols_end_del): (_ewk_tiled_backing_store_view_cols_end_add): (_ewk_tiled_backing_store_view_row_del): (_ewk_tiled_backing_store_view_rows_range_del): (_ewk_tiled_backing_store_view_rows_all_del): (_ewk_tiled_backing_store_render): (_ewk_tiled_backing_store_model_matrix_create): (_ewk_tiled_backing_store_smart_member_del): (_ewk_tiled_backing_store_smart_member_add): (_ewk_tiled_backing_store_mem_dbg): (_ewk_tiled_backing_store_sig_usr): (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_smart_del): (_ewk_tiled_backing_store_smart_move): (_ewk_tiled_backing_store_smart_resize): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_smart_calculate_size): (_ewk_tiled_backing_store_view_dbg): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_view_refill): (_ewk_tiled_backing_store_view_pos_apply): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate_pos): (_ewk_tiled_backing_store_fill_renderers): (_ewk_tiled_backing_store_smart_calculate): (ewk_tiled_backing_store_add): (ewk_tiled_backing_store_render_cb_set): (ewk_tiled_backing_store_tile_unused_cache_get): (ewk_tiled_backing_store_tile_unused_cache_set): (_ewk_tiled_backing_store_scroll_full_offset_set_internal): (ewk_tiled_backing_store_scroll_full_offset_set): (ewk_tiled_backing_store_scroll_full_offset_add): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_set): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_zoom_weak_smooth_scale_set): (ewk_tiled_backing_store_update): (ewk_tiled_backing_store_updates_process_pre_set): (ewk_tiled_backing_store_updates_process_post_set): (ewk_tiled_backing_store_updates_process): (ewk_tiled_backing_store_updates_clear): (ewk_tiled_backing_store_contents_resize): (ewk_tiled_backing_store_disabled_update_set): (ewk_tiled_backing_store_flush): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel): (ewk_tiled_backing_store_disable_render): (ewk_tiled_backing_store_enable_render): (ewk_tiled_backing_store_process_entire_queue_set):
  • ewk/ewk_tiled_backing_store.h: Added.
  • ewk/ewk_tiled_matrix.c: Added. (_ewk_tile_matrix_cell_free): (_ewk_tile_matrix_tile_free): (ewk_tile_matrix_new): (ewk_tile_matrix_free): (ewk_tile_matrix_resize): (ewk_tile_matrix_unused_cache_get): (ewk_tile_matrix_tile_exact_get): (ewk_tile_matrix_tile_exact_exists): (ewk_tile_matrix_tile_nearest_get): (ewk_tile_matrix_tile_new): (ewk_tile_matrix_tile_put): (ewk_tile_matrix_tile_update): (ewk_tile_matrix_tile_update_full): (ewk_tile_matrix_tile_updates_clear): (_ewk_tile_matrix_slicer_setup): (ewk_tile_matrix_update): (ewk_tile_matrix_updates_process): (ewk_tile_matrix_updates_clear): (ewk_tile_matrix_dbg): (ewk_tile_matrix_freeze): (ewk_tile_matrix_thaw):
  • ewk/ewk_tiled_matrix.h: Added.
  • ewk/ewk_tiled_model.c: Added. (_ewk_tile_account_get): (_ewk_tile_account_allocated): (_ewk_tile_account_freed): (ewk_tile_accounting_dbg): (_ewk_tile_paint_rgb888): (_ewk_tile_paint_rgb565): (_ewk_tile_paint): (ewk_tile_new): (ewk_tile_free): (ewk_tile_show): (ewk_tile_hide): (ewk_tile_visible_get): (ewk_tile_update_full): (ewk_tile_update_area): (ewk_tile_updates_process): (ewk_tile_updates_clear): (ewk_tile_unused_cache_new): (ewk_tile_unused_cache_lock_area): (ewk_tile_unused_cache_unlock_area): (ewk_tile_unused_cache_free): (ewk_tile_unused_cache_clear): (ewk_tile_unused_cache_ref): (ewk_tile_unused_cache_unref): (ewk_tile_unused_cache_max_set): (ewk_tile_unused_cache_max_get): (ewk_tile_unused_cache_used_get): (ewk_tile_unused_cache_flush): (ewk_tile_unused_cache_auto_flush): (ewk_tile_unused_cache_dirty): (ewk_tile_unused_cache_freeze): (ewk_tile_unused_cache_thaw): (ewk_tile_unused_cache_tile_get): (ewk_tile_unused_cache_tile_put): (ewk_tile_unused_cache_dbg):
  • ewk/ewk_tiled_model.h: Added.
  • ewk/ewk_tiled_private.h: Added.
  • ewk/ewk_view.cpp: (_ewk_view_smart_add): (_ewk_view_smart_calculate): (_ewk_view_smart_show): (_ewk_view_smart_hide): (_ewk_view_smart_pre_render_relative_radius): (_ewk_view_zoom_animator_cb): (_ewk_view_smart_disable_render): (_ewk_view_smart_enable_render): (ewk_view_base_smart_set): (ewk_view_pre_render_region): (ewk_view_pre_render_relative_radius): (ewk_view_enable_render): (ewk_view_disable_render): (ewk_view_scroll): (ewk_view_did_first_visually_nonempty_layout): (ewk_view_dispatch_did_finish_loading): (ewk_view_transition_to_commited_for_newpage):
  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.c: Added. (_ewk_view_tiled_render_cb): (_ewk_view_tiled_updates_process_pre): (_ewk_view_tiled_smart_backing_store_add): (_ewk_view_tiled_contents_size_changed_cb): (_ewk_view_tiled_smart_add): (_ewk_view_tiled_smart_scrolls_process): (_ewk_view_tiled_smart_repaints_process): (_ewk_view_tiled_smart_contents_resize): (_ewk_view_tiled_smart_zoom_set): (_ewk_view_tiled_smart_zoom_weak_set): (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set): (_ewk_view_tiled_smart_flush): (_ewk_view_tiled_smart_pre_render_region): (_ewk_view_tiled_smart_pre_render_relative_radius): (_ewk_view_tiled_smart_pre_render_cancel): (_ewk_view_tiled_smart_disable_render): (_ewk_view_tiled_smart_enable_render): (ewk_view_tiled_smart_set): (_ewk_view_tiled_smart_class_new): (ewk_view_tiled_add): (ewk_view_tiled_unused_cache_get): (ewk_view_tiled_unused_cache_set): (ewk_view_tiled_process_entire_queue_set):
5:50 PM Changeset in webkit [72578] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-11-22 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Fix bogus include guard.

  • loader/NavigationScheduler.h:
5:47 PM Changeset in webkit [72577] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
​https://bugs.webkit.org/show_bug.cgi?id=48845

Test: fast/canvas/canvas-strokeText-strokes-shadow.html

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Stroke the shadow rather than filling it in the cTextStroke case.

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
​https://bugs.webkit.org/show_bug.cgi?id=48845

Add test to verify that strokeText() doesn't produce a fillText() shadow.

  • fast/canvas/canvas-strokeText-strokes-shadow.html: Added.
  • fast/canvas/canvas-strokeText-strokes-shadow-expected.txt: Added.
  • fast/canvas/script-tests/canvas-strokeText-strokes-shadow.js: Added.
4:56 PM Changeset in webkit [72576] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-22 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Fix some spacing issues with log messages with
new-run-webkit-tests --verbose.

​https://bugs.webkit.org/show_bug.cgi?id=49936

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
4:56 PM Changeset in webkit [72575] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-22 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

update scm to work with different remote branches
​https://bugs.webkit.org/show_bug.cgi?id=49949

This works if there are multiple svn tracking branches
and/or if the tracking branch is refs/remots/origin/master
instead of refs/remotes/trunk which is the direction we're trying
to head since that makes fetches faster.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
4:55 PM Changeset in webkit [72574] by Patrick Gansterer
  • 4 edits in trunk

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Sam Weinig.

Add WTF::FixedArray::size()
​https://bugs.webkit.org/show_bug.cgi?id=49891

Add a method to get the size of a FixedArray.

  • wtf/FixedArray.h: (WTF::FixedArray::size):

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Sam Weinig.

Use WTF::FixedArray::size()
​https://bugs.webkit.org/show_bug.cgi?id=49891

  • dom/Document.cpp: (WebCore::Document::~Document):
4:25 PM Changeset in webkit [72573] by rniwa@webkit.org
  • 10 edits in trunk

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
​https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return value of SelectionController::typingStyle() to EditingStyle*.
Also added SelectionController::copyTypingStyle() to copy the typing style
as an instance of CSSMutableStyleDeclaration.

No tests are added since this is no behavioral change.

  • WebView/WebFrame.mm: (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
​https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return type of SelectionController::typingStyle to EditingStyle*.

Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
CSSMutableStyleDeclaration.

Also extracted the code to preserve unicode-bidi and direction CSS properties in
InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
these two properties are preserved.

Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
CSSMutableStyleDeclaration.

No new tests are added since this is a refactoring.

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check. (WebCore::EditingStyle::prepareToApplyAt): See above. (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
  • editing/EditingStyle.h: Moved WritingDirection from Editor.h
  • editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection. (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle. (WebCore::Editor::selectionComputedStyle): Ditto. (WebCore::Editor::styleForSelectionStart): Ditto.
  • editing/Editor.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
  • editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*. (WebCore::SelectionController::copyTypingStyle): Added.
4:18 PM Changeset in webkit [72572] by Patrick Gansterer
  • 4 edits in trunk

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
​https://bugs.webkit.org/show_bug.cgi?id=49887

  • wtf/Platform.h:

2010-11-22 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
​https://bugs.webkit.org/show_bug.cgi?id=49887

  • config.h:
3:57 PM Changeset in webkit [72571] by Adam Roben
  • 5 edits
    2 adds in trunk/LayoutTests

Update Windows 7 results for two tests

Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).

  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/win/fast/text/international/bold-bengali-expected.png: Added.
  • platform/win/fast/text/international/bold-bengali-expected.txt:
3:38 PM Changeset in webkit [72570] by Adam Roben
  • 2 edits
    2 adds in trunk/LayoutTests

Update Windows 7 results for fast/text/international/complex-character-based-fallback.html

  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
3:27 PM Changeset in webkit [72569] by Adam Roben
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173

The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.

  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.
3:21 PM Changeset in webkit [72568] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update Windows results after r72552

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:04 PM Changeset in webkit [72567] by jamesr@google.com
  • 7 edits in trunk

2010-11-22 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
​https://bugs.webkit.org/show_bug.cgi?id=49871

Expands test to check width in addition to height.

  • fast/text/font-size-zero-expected.txt:
  • fast/text/font-size-zero.html:
  • fast/text/script-tests/font-size-zero.js:

2010-11-22 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
​https://bugs.webkit.org/show_bug.cgi?id=49871

Returns 0 from platformWidthForGlyph if the specified font size is 0.

Test: fast/text/font-size-zero.html

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
3:01 PM Changeset in webkit [72566] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2010-11-22 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
​https://bugs.webkit.org/show_bug.cgi?id=48809

Test that we update content state when leaving a form in a subframe.

  • fast/history/saves-state-after-frame-nav.html:
  • fast/history/saves-state-after-frame-nav-expected.txt:
  • fast/history/resources/subframe-with-form.html:

2010-11-22 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
​https://bugs.webkit.org/show_bug.cgi?id=48809

Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.

Test: fast/history/saves-state-after-frame-nav.html

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
2:59 PM Changeset in webkit [72565] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.

  • platform/chromium/test_expectations.txt:
2:52 PM Changeset in webkit [72564] by hayato@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-22 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Ignore reference files which will be used by reftests when collecting
test cases.
​https://bugs.webkit.org/show_bug.cgi?id=49835

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2:45 PM Changeset in webkit [72563] by Adam Roben
  • 5 edits
    2 adds in trunk/LayoutTests

Update Windows results for transforms/2d/hindi-rotated.html after r72173

The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.

  • platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.checksum:
  • platform/win/transforms/2d/hindi-rotated-expected.png:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
2:40 PM Changeset in webkit [72562] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaseline for Chromium.

Removed the erroneous expected result for editing/deleting/5168598.html on chromium linux.

  • platform/chromium-linux/editing/deleting/5168598-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed editing/deleting/5168598.html.
2:33 PM QtWebKitFeatures21 edited by Ademar Reis
adding (partial) list of fixes (diff)
2:24 PM Changeset in webkit [72561] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed. Update GTK and Mac specific expected results after r72552.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
2:15 PM Changeset in webkit [72560] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-22 Tony Chang <​tony@chromium.org>

Unreviewed, roll Chromium DEPS to r67004.

  • DEPS:
2:05 PM Changeset in webkit [72559] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
2:01 PM Changeset in webkit [72558] by jamesr@google.com
  • 3 edits in branches/chromium/552/WebCore

Revert code changes of WebKit r67261 on the 552 branch BUG=56150 TBR=pkasting

2:01 PM Changeset in webkit [72557] by luiz@webkit.org
  • 2 edits in trunk/WebCore

2010-11-22 Luiz Agostini <​luiz.agostini@openbossa.org>

Unreviewed, Windows build fix.

Adding JSMediaQueryList to DerivedSources.cpp.

  • DerivedSources.cpp:
1:53 PM Changeset in webkit [72556] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72552.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
1:38 PM QtWebKitContrib edited by Ademar Reis
(diff)
1:21 PM Changeset in webkit [72555] by Adam Roben
  • 36 edits in trunk

Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.

This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.

To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.

For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:

$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

which resolves to:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)

Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.

Fixes <​http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated

Reviewed by Dave Hyatt.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the

.vsprops files. It isn't needed anymore.

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebCore:

  • WebCore.vcproj/WebCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit/win:

  • WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit2:

  • win/WebKit2.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKitLibraries:

  • win/tools/WinTools.make: Copy the shared .vsprops files into a directory tree beneath

AppleInternal\tools\vsprops that matches the source directory tree. This allows production
builds to redirect the relative paths used to find the shared .vsprops files into
AppleInternal by setting $WebKitVSPropsRedirectionDir to the appropriate value.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

1:17 PM Changeset in webkit [72554] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make it possible to run tests on Windows without Visual Studio or VC++ Express installed

webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
are not installed. But this function doesn't need to be called when we
already have a build available and are just trying to run the tests.

Fixes <​http://webkit.org/b/49932> New Windows 7 bot can't run tests
because Visual Studio/VC++ Express aren't installed

Reviewed by Dave Hyatt.

  • Scripts/webkitdirs.pm:

(determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
it is not needed by this function. Also added a FIXME.

(usingVisualStudioExpress): Call setupCygwinEnv directly rather than
relying on determineConfigurationForVisualStudio doing it.

1:16 PM Changeset in webkit [72553] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed update of Windows's skipped list and Chromium's test expectation.

fast/text/international/thai-cursor-position.html erroneously had an expected result
on Windows even though textInputController hasn't been implemented on Windows (the bug 32021).

Removed the expected result and added the tests to Windows platform's skipped list.

  • platform/chromium/test_expectations.txt: Removed fast/text/international/thai-cursor-position.html.
  • platform/win/Skipped: Added fast/text/international/thai-cursor-position.html.
  • platform/win/fast/text/international/thai-cursor-position-expected.txt: Removed.
1:02 PM Changeset in webkit [72552] by luiz@webkit.org
  • 31 edits
    22 adds in trunk

2010-10-21 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
​https://bugs.webkit.org/show_bug.cgi?id=37205

New property matchMedia was added to window.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:

window.matchMedia and MediaQueryList tests.

  • fast/media/media-query-list-01-expected.txt: Added.
  • fast/media/media-query-list-01.html: Added.

The following tests depend on LayoutTestController::setViewModeMediaFeature() to work.
As it is only implemented by Qt and Gtk the tests needed to be skipped in all other platforms.

  • fast/media/media-query-list-02-expected.txt: Added.
  • fast/media/media-query-list-02.html: Added.
  • fast/media/media-query-list-03-expected.txt: Added.
  • fast/media/media-query-list-03.html: Added.
  • fast/media/media-query-list-04-expected.txt: Added.
  • fast/media/media-query-list-04.html: Added.
  • fast/media/media-query-list-05-expected.txt: Added.
  • fast/media/media-query-list-05.html: Added.
  • fast/media/media-query-list-06-expected.txt: Added.
  • fast/media/media-query-list-06.html: Added.
  • fast/media/media-query-list-07-expected.txt: Added.
  • fast/media/media-query-list-07.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-10-21 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
​https://bugs.webkit.org/show_bug.cgi?id=37205

New interfaces may be used to evaluate media queries and to associate listeners
to media queries. Those listeners are called whenever the associated query changes.
Specification may be found at ​http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface

operator== added to JS version of ScriptValue.
Method isFunction added to JS and V8 versions of ScriptValue.

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::operator==):
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isFunction):

Some changes were needed to the code generators to handle type MediaQueryListListener.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:

Some changes to the bindings test results that were previously added.

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::TestMediaQueryListListenerInternal::methodCallback): (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

New interfaces:

  • css/MediaQueryList.cpp: Added.
  • css/MediaQueryList.h: Added.
  • css/MediaQueryList.idl: Added.
  • css/MediaQueryListListener.cpp: Added.
  • css/MediaQueryListListener.h: Added.
  • css/MediaQueryListListener.idl: Added.

To avoid adding code to classes DOMWindow and Document a new class MediaQueryMatcher was created.

  • css/MediaQueryMatcher.cpp: Added.
  • css/MediaQueryMatcher.h: Added.

Document and DOMWindow have changed to support new features. DOMWindow is the class that
publishes methods matchMedia but for page cache to work properly the reference to the
MediaQueryMatcher must be in Document.

  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::mediaQueryMatcher): (WebCore::Document::styleSelectorChanged):
  • dom/Document.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::matchMedia):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Build systems

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:

Tests: fast/media/media-query-list-01.html

fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html

1:00 PM Changeset in webkit [72551] by hayato@chromium.org
  • 10 edits
    1 delete in trunk/WebKitTools

2010-11-19 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Simplify Driver.run_test() so that it takes only one parameter, TestInput.

​https://bugs.webkit.org/show_bug.cgi?id=49812

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:13 PM Changeset in webkit [72550] by rniwa@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-11-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed update of Windows Skipped list.

editing/selection/5825350-1.html and 5825350-2.html erroneously
had expectations with console error message even though textInputController
hasn't been implemented on Windows (the bug 32021),

Removed these expectations and added the tests to the skipped list.

  • platform/win/Skipped:
  • platform/win/editing/selection/5825350-1-expected.txt: Removed.
  • platform/win/editing/selection/5825350-2-expected.txt: Removed.
12:08 PM Changeset in webkit [72549] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for fast/ruby/nested-ruby.html

  • platform/win/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/win/fast/ruby/nested-ruby-expected.png: Added.
  • platform/win/fast/ruby/nested-ruby-expected.txt: Added.
12:07 PM Changeset in webkit [72548] by Adam Roben
  • 3 edits
    1 delete in trunk/LayoutTests

Update Windows XP results for fast/text/international/bidi-control-chars-treated-as-ZWS.html

The render tree dump on XP now matches Mac. I updated the pixel results
to match the current rendering (the two test lines have moved down
slightly).

  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
11:58 AM Changeset in webkit [72547] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-22 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Retry a few times in reading a png image to avoid a race condition.

​https://bugs.webkit.org/show_bug.cgi?id=49924

  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:09 AM Changeset in webkit [72546] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove obsolete Windows-specific results for svg/dom/path-parser.html

r72381 made these unnecessary.

  • platform/win/svg/dom/path-parser-expected.txt: Removed.
11:08 AM Changeset in webkit [72545] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results for fast/dom/prototype-inheritance-2.html

This is the Windows equivalent of r72353.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
10:55 AM Changeset in webkit [72544] by andreas.kling@nokia.com
  • 8 edits
    1 add in trunk/LayoutTests

2010-11-22 Andreas Kling <​kling@webkit.org>

Unreviewed, rebaseline GTK+ after r72527.

  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/002-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/lists/007-vertical-expected.txt:
  • platform/gtk/fast/lists/008-vertical-expected.txt:
  • platform/gtk/fast/lists/outSideListMarkers-expected.txt: Added.
10:50 AM Changeset in webkit [72543] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific results for editing/selection/extend-selection-home-end.html

These results are identical to the cross-platform results, but are
needed to override the Mac-specific results in platform/mac.

Fixes <​http://webkit.org/b/49874>.

  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
10:44 AM Changeset in webkit [72542] by antonm@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Not reviewed. Test expectations arrangements and rebaselinings.

  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
10:30 AM Changeset in webkit [72541] by antonm@chromium.org
  • 4 edits
    23 adds in trunk/LayoutTests

Not reviewed. Fallback font rebaselines.

  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/001-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:26 AM Changeset in webkit [72540] by apavlov@chromium.org
  • 8 edits
    1 add in trunk

2010-11-22 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Contents of rules inside @media not displayed/editable
​https://bugs.webkit.org/show_bug.cgi?id=49804

WebCore:

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
  • inspector/InspectorStyleSheet.cpp: (WebCore::asCSSRuleList): (WebCore::InspectorStyleSheet::reparseStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::ensureFlatRules): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): (WebCore::InspectorStyleSheet::collectFlatRules):
  • inspector/InspectorStyleSheet.h:


LayoutTests:

  • inspector/resources/styles-new-API-1.css: Added. (@page): (@page :first): (#absent-id): (body):
  • inspector/resources/styles-new-API.css:
  • inspector/styles-new-API-expected.txt:
9:53 AM Changeset in webkit [72539] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Amending expectations for Chromium.

  • platform/chromium/test_expectations.txt:
9:50 AM Changeset in webkit [72538] by antonm@chromium.org
  • 4 edits
    30 adds in trunk/LayoutTests

Not reviewed. Another portion of Chromium rebaselines for SVG.

  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [72537] by antonm@chromium.org
  • 17 edits in trunk/LayoutTests

Not reviewed. Another portion of Chromium rebaselines.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium/test_expectations.txt:
9:36 AM Changeset in webkit [72536] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-22 Tony Chang <​tony@chromium.org>

Unreviewed, update Chromium Win plugin test expectations.

  • platform/chromium/drt_expectations.txt:
9:33 AM Changeset in webkit [72535] by antonm@chromium.org
  • 6 edits
    26 adds in trunk/LayoutTests

Not reviewed. Chromium rebaselines after ​http://trac.webkit.org/changeset/72518

  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:23 AM Changeset in webkit [72534] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Reorganizing suppressions.

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [72533] by antonm@chromium.org
  • 86 edits
    7 adds
    10 deletes in trunk/LayoutTests

Unreviewed. Tons of Chromium rebaselines after ​http://trac.webkit.org/changeset/72527

  • platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-linux/fast/doctypes/002-expected.checksum:
  • platform/chromium-linux/fast/doctypes/002-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/002-expected.checksum:
  • platform/chromium-linux/fast/lists/002-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-expected.checksum:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.png:
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/007-vertical-expected.png:
  • platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/008-vertical-expected.png:
  • platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Removed.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/008-vertical-expected.png:
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Added.
  • platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/chromium-win/fast/doctypes/002-expected.checksum:
  • platform/chromium-win/fast/doctypes/002-expected.png:
  • platform/chromium-win/fast/doctypes/002-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/002-expected.checksum:
  • platform/chromium-win/fast/lists/002-expected.png:
  • platform/chromium-win/fast/lists/002-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.checksum:
  • platform/chromium-win/fast/lists/003-expected.png:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.txt:
  • platform/chromium-win/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.txt:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:57 AM Changeset in webkit [72532] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

Make WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

  • WebProcess/WebPage/WebInspector.cpp: Add missing ENABLE(JAVASCRIPT_DEBUGGER) guards.

(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):

8:46 AM Changeset in webkit [72531] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-11-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: dump inspector protocol messages into console.
Sometimes I need to dump inspector messages into console.
It'd be much simple to have this code in repository and
enable protocol dumping just by a flag.

​https://bugs.webkit.org/show_bug.cgi?id=49905

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector_syncDispatch):
8:43 AM Changeset in webkit [72530] by Csaba Osztrogonác
  • 20 edits
    11 adds in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72527.

  • platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/padding_right-expected.png: Added.
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Added.
  • platform/qt/editing/pasteboard/merge-end-list-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/fast/doctypes/002-expected.checksum: Added.
  • platform/qt/fast/doctypes/002-expected.png: Added.
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/lists/007-vertical-expected.checksum:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.txt:
  • platform/qt/fast/lists/008-vertical-expected.checksum:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.txt:
  • platform/qt/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/qt/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/qt/fast/lists/outSideListMarkers-expected.txt: Added.
8:18 AM Changeset in webkit [72529] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-11-22 Andreas Kling <​kling@webkit.org>

Unreviewed, 2 missing rebaselines after r72527.

  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
7:52 AM Changeset in webkit [72528] by andreas.kling@nokia.com
  • 12 edits in trunk/WebCore

2010-11-22 Andreas Kling <​kling@webkit.org>

Reviewed by Nikolas Zimmermann.

GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>
​https://bugs.webkit.org/show_bug.cgi?id=49840

This avoid copying a Path object when drawing focus rings.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • rendering/RenderImage.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): (WebCore::RenderImage::paintFocusRing): Renamed from paintFocusRings since it only paints one ring.
7:13 AM Changeset in webkit [72527] by reni@webkit.org
  • 67 edits
    4 adds in trunk

Outside list bullets ignore text-align style.
​https://bugs.webkit.org/show-bug.cgi?id=15713

Patch by Renata Hodovan <​reni@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

WebCore:

Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
position. As for the others, this sum should be decremented with the previous marker's width.
In case of vertical markers the padding is unneeded.

Test: fast/lists/outSideListMarkers.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

Add new test for checking outside marker's position and update the related expecteds of tests.

  • fast/lists/outSideListMarkers-expected.txt: Added.
  • fast/lists/outSideListMarkers.html: Added.
  • platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/margin_right-expected.png:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.png:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/doctypes/002-expected.checksum:
  • platform/mac-leopard/fast/doctypes/002-expected.png:
  • platform/mac-leopard/fast/lists/001-expected.checksum:
  • platform/mac-leopard/fast/lists/001-expected.png:
  • platform/mac-leopard/fast/lists/002-expected.checksum:
  • platform/mac-leopard/fast/lists/002-expected.png:
  • platform/mac-leopard/fast/lists/003-expected.checksum:
  • platform/mac-leopard/fast/lists/003-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/doctypes/002-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.checksum:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/002-expected.txt:
  • platform/mac/fast/lists/002-vertical-expected.checksum:
  • platform/mac/fast/lists/002-vertical-expected.png:
  • platform/mac/fast/lists/002-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.checksum:
  • platform/mac/fast/lists/003-vertical-expected.png:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/007-vertical-expected.checksum:
  • platform/mac/fast/lists/007-vertical-expected.png:
  • platform/mac/fast/lists/007-vertical-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/mac/fast/lists/outSideListMarkers-expected.png: Added.
6:57 AM Changeset in webkit [72526] by yael.aharon@nokia.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-11-22 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Additional tests.
​https://bugs.webkit.org/show_bug.cgi?id=49604

  • fast/events/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Added.
  • fast/events/spatial-navigation/snav-div-overflow-scrol-hidden.html: Added.
  • fast/events/spatial-navigation/snav-z-index-expected.txt: Added.
  • fast/events/spatial-navigation/snav-z-index.html: Added.
6:40 AM Changeset in webkit [72525] by antonm@chromium.org
  • 7 edits
    22 adds
    1 delete in trunk/LayoutTests

Not reviewed. Rebaselining various Win/Linux only deviations.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-linux/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/chromium-linux/svg/custom/baseval-animval-equality-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/chromium-linux/svg/dom/path-parser-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.png:
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/chromium-win/svg/dom/path-parser-expected.txt: Added.
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:37 AM Changeset in webkit [72524] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/workers/storage/interrupt-database-sync.html fails intermittently
​https://bugs.webkit.org/show_bug.cgi?id=49906

  • platform/qt/Skipped: fast/workers/storage/interrupt-database-sync.html added until fix.
6:12 AM Changeset in webkit [72523] by Csaba Osztrogonác
  • 1 edit
    27 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/css/negative-leading-expected.checksum: Added.
  • platform/qt/fast/css/negative-leading-expected.png: Added.
  • platform/qt/fast/css/negative-leading-expected.txt: Added. (introduced in r72141)
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt: Added. (introduced in r72402)
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added. (introduced in r72518)
  • platform/qt/svg/custom/image-rescale-expected.checksum: Added.
  • platform/qt/svg/custom/image-rescale-expected.png: Added.
  • platform/qt/svg/custom/image-rescale-expected.txt: Added. (introduced in r72470)
  • platform/qt/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/qt/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/qt/svg/custom/image-rescale-scroll-expected.txt: Added. (introduced in r72470)
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added. (introduced in r72381)
5:49 AM Changeset in webkit [72522] by yael.aharon@nokia.com
  • 17 edits in trunk

Spatial Navigation: issues with the node selection algorithm.
​https://bugs.webkit.org/show_bug.cgi?id=49382

Patch by Yael Aharon <​yael.aharon@nokia.com>, Chang Shu <​chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.

WebCore:

Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.

With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.

With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.

hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.

calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/FocusController.h:
  • page/FrameView.h:
  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):

  • page/SpatialNavigation.h:

LayoutTests:

Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.

  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
5:29 AM Changeset in webkit [72521] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Amending suppressions from previous commit.

  • platform/chromium/test_expectations.txt:
5:25 AM Changeset in webkit [72520] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Adding new suppressions after ​http://trac.webkit.org/changeset/72518

  • platform/chromium/test_expectations.txt:
4:53 AM Changeset in webkit [72519] by antonm@chromium.org
  • 3 edits
    10 adds in trunk/LayoutTests

Not reviewed. Next batch of SVG rebaselines.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:32 AM Changeset in webkit [72518] by commit-queue@webkit.org
  • 56 edits
    20 adds in trunk

2010-11-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
​https://bugs.webkit.org/show_bug.cgi?id=49880

Add tests for all SVG*List types, that were missing.
Add SVG 1.1 2nd edition testcase, types-dom-07-f.svg, testing that all animVal values are readonly.

  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png:
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-07-f.svg: Added.
  • svg/custom/baseval-animval-equality.svg: Fix wrong test.
  • svg/custom/polyline-points-crash-expected.txt:
  • svg/dom/SVGLengthList-basics-expected.txt:
  • svg/dom/SVGLengthList-basics.xhtml: Extended test, synchronized with the other SVG*List tests.
  • svg/dom/SVGNumberList-basics-expected.txt: Added.
  • svg/dom/SVGNumberList-basics.xhtml: Added.
  • svg/dom/SVGPointList-basics-expected.txt: Added.
  • svg/dom/SVGPointList-basics.xhtml: Added.
  • svg/dom/SVGStringList-basics-expected.txt: Added.
  • svg/dom/SVGStringList-basics.xhtml: Added.
  • svg/dom/SVGTransformList-basics-expected.txt: Added.
  • svg/dom/SVGTransformList-basics.xhtml: Added.
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:

2010-11-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
​https://bugs.webkit.org/show_bug.cgi?id=49880

Write tests for SVGNumberList/SVGPointList/SVGStringList/SVGTransformList and extend SVGLengthList tests.
SVG DOM <-> XML DOM synchronization is now tested for all these types, and works great. Unify the string format produced
by the various valueAsString() functions for maximum compatibility with Firefox / Opera.

  • Build a real transform string for SVGTransformList, instead of dumping the elements of the concatted matrix.
  • Add SVGStringList XML dom synchronization, only affects SVGTests requiredFeatures/requiredExtensions/systemLanguage.
  • Make all animVal properties readonly, tested by types-dom-07-f.svg (from SVG 1.1 2nd edition).
  • Enable StrictTypeChecking/RequiresAllArguments=Raise for all SVGList types.

Tests: svg/W3C-SVG-1.1-SE/types-dom-07-f.svg

svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGStringList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::setValue): Throw NO_MODIFICATION_ALLOWED_ERR when the SVGPropertyTearOffs role is AnimValRole. (WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorSetter): Ditto. (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): Ditto.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::synchronizeProperty): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::synchronizeProperty): Ditto.
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::synchronizeProperty): Ditto.
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::synchronizeProperty): Ditto.
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::synchronizeProperty): Ditto.
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::synchronizeProperty): Ditto.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::synchronizeProperty): Ditto.
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::synchronizeProperty): Ditto.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::synchronizeProperty): Ditto.
  • svg/SVGLengthList.cpp: (WebCore::SVGLengthList::valueAsString): Use ' ' instead of ',' as seperator.
  • svg/SVGLengthList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::synchronizeProperty): Ditto.
  • svg/SVGNumberList.cpp: (WebCore::SVGNumberList::valueAsString): Use ' ' instead of ',' as seperator.
  • svg/SVGNumberList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::synchronizeProperty): Ditto.
  • svg/SVGPointList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::synchronizeProperty): Ditto.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::synchronizeProperty): Ditto.
  • svg/SVGStringList.cpp: (WebCore::SVGStringList::valueAsString): Add valueAsString() implementation, necessary for SVG DOM <-> XML DOM synchronization.
  • svg/SVGStringList.h:
  • svg/SVGStringList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGTests.cpp: Rewrite, similar to SVGPolyElement, to synchronize the requiredFeatures/requiredExtension/systemLanguage SVGStringLists with their XML DOM attributes. (WebCore::SVGTests::SVGTests): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): (WebCore::SVGTests::isKnownAttribute): (WebCore::SVGTests::handleAttributeChange): (WebCore::SVGTests::synchronizeProperties): To be called by all classes inheriting from SVGTests, in their synchronizeProperty() methods. (WebCore::SVGTests::synchronizeRequiredFeatures): (WebCore::SVGTests::synchronizeRequiredExtensions): (WebCore::SVGTests::synchronizeSystemLanguage): (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): Added a proper way to serialize a SVGTransform into a String.
  • svg/SVGTransform.h:
  • svg/SVGTransformList.cpp: (WebCore::SVGTransformList::valueAsString): Rewrite, to build a real transform list string, instead of dumping the concatted matrix.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/properties/SVGListProperty.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGListProperty::initializeValuesAndWrappers): (WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers): (WebCore::SVGListProperty::replaceItemValues): (WebCore::SVGListProperty::replaceItemValuesAndWrappers): (WebCore::SVGListProperty::removeItemValuesAndWrappers): Handle corner case, the item passed to removeItem() was the only on in the list, list is empty now, nothing to replace. (WebCore::SVGListProperty::appendItemValuesAndWrappers): (WebCore::SVGListProperty::role): Expose the role of this list property.
  • svg/properties/SVGPathSegListPropertyTearOff.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem):
  • svg/properties/SVGProperty.h: Add new virtual SVGPropertyRole role() accessor.
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::create): Store the passed in SVGProperyRole, instead of ignoring it. (WebCore::SVGPropertyTearOff::role): (WebCore::SVGPropertyTearOff::SVGPropertyTearOff):
  • svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Pass UndefinedRole as default role to SVGPropertyTearOff.
  • svg/properties/SVGStaticPropertyWithParentTearOff.h: Ditto. (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):
4:11 AM Changeset in webkit [72517] by antonm@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

Not reviewed. Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium on Win and Linux.

  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:02 AM Changeset in webkit [72516] by antonm@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Not reviewed. Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.

  • platform/chromium-mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:57 AM Changeset in webkit [72515] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, removing suppression for now passing editing/selection/5354455-1.html (on Win)

  • platform/chromium/test_expectations.txt:
2:53 AM Changeset in webkit [72514] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, proper platform for international test.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [72513] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, Chromium suppressions for a bunch of SVG tests and one international.

  • platform/chromium/test_expectations.txt:
2:26 AM Changeset in webkit [72512] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, temporary suppressing fast/css/font-face-data-uri.html for Chromium.

  • platform/chromium/test_expectations.txt:
2:22 AM Changeset in webkit [72511] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-22 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Partially roll out r72282.
It should not have modified devtools files.

  • src/js/devTools.css:
1:59 AM Changeset in webkit [72510] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-22 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElement::appendInside() doesn't work on head elements
​https://bugs.webkit.org/show_bug.cgi?id=49166

Make QWebElement::appendInside() call
Element::deprecatedCreateContextualFragment(), bypassing the check for
the HEAD tag in the HTMLElement implementation of this function.

  • Api/qwebelement.cpp: (QWebElement::appendInside):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::addElementToHead):
1:58 AM Changeset in webkit [72509] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium-gpu.

  • platform/chromium-gpu/test_expectations.txt:
1:53 AM Changeset in webkit [72508] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, remove duplicate suppression.

  • platform/chromium/test_expectations.txt:
1:30 AM Changeset in webkit [72507] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium.

  • platform/chromium/test_expectations.txt:
1:27 AM Changeset in webkit [72506] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-22 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix EWebLauncher zoom discretization
​https://bugs.webkit.org/show_bug.cgi?id=49810

  • EWebLauncher/main.c: (nearest_zoom_level_get): (zoom_level_set): (on_load_finished): (on_key_down):
1:26 AM Changeset in webkit [72505] by antonm@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Not reviewed. Rebaselining fast/js/regexp-overflow.html expectations
for Chromium after ​http://trac.webkit.org/changeset/72489

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Added.
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt: Added.
12:41 AM Changeset in webkit [72504] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2010-11-22 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=49374

  • fast/css/font-face-data-uri-expected.txt: Added.
  • fast/css/font-face-data-uri.html: Added.

2010-11-22 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
​https://bugs.webkit.org/show_bug.cgi?id=49374

Test: fast/css/font-face-data-uri.html

  • css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::isSupportedFormat): Do not check "file extension" for data URI. For other URI, check against ".eot" rather than "eot".

Nov 21, 2010:

7:03 PM Changeset in webkit [72503] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
6:16 PM Changeset in webkit [72502] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix ~300 WebKit2 tests by enabling developer extras preference.

Rubber-stamped by Dan Bernstein.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

6:08 PM Changeset in webkit [72501] by weinig@apple.com
  • 12 edits
    1 add in trunk

Textareas should be resizable by default
​https://bugs.webkit.org/show_bug.cgi?id=49892

Reviewed by Dan Bernstein.

WebKit2:

Test: WebKit2/WKPreferences

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add textAreasAreResizable bit.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
Fix typo, WKPRe... -> WKPre...

(WKPreferencesSetMinimumFontSize):
(WKPreferencesGetMinimumFontSize):
Fix comment to correctly reflect that the default minimumFontSize is 0, not 1.

(WKPreferencesSetTextAreasAreResizable):
(WKPreferencesGetTextAreasAreResizable):

  • UIProcess/API/C/WKPreferences.h:

Add API.

  • UIProcess/API/C/WKPreferencesPrivate.h:

Don't use PLATFORM in API headers.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setTextAreasAreResizable):
(WebKit::WebPreferences::textAreasAreResizable):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe bit through to the WebProcess and onto WebCore::Settings.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add preferences test.

4:10 PM Changeset in webkit [72500] by Patrick Gansterer
  • 25 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore directory
​https://bugs.webkit.org/show_bug.cgi?id=49882

  • accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::ConfigureV8TestObjTemplate):
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::triStateOfStyle):
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • editing/MarkupAccumulator.cpp: (WebCore::appendCharactersReplacingEntities):
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex):
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasValidAvgCharWidth):
  • rendering/break_lines.cpp:
  • svg/SVGTransformable.cpp: (WebCore::parseAndSkipType):
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::parseZoomAndPan):
  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap):
3:03 PM Changeset in webkit [72499] by mario@webkit.org
  • 8 edits in trunk

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

Implement the remaining bits for combo boxes.

This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.

Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to stringValue(), which holds from now on that used to be here. (WebCore::AccessibilityMenuListOption::stringValue): New, override of AccessibilityObject::stringValue() to return a proper string.

Emit the missing signals when a selection is made.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the usual 'focus' signals when a selection is made over the combo box.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED Atk states are added to the state set when needed. (listObjectForSelection): New, returns the proper list object (the one holding the list of available options as its children) for an specific AtkObject implementing AtkSelection. This is needed because sometimes the selectable options are not directly children of the AtkSelection object (i.e. a combo box has a 'menu' object as its only child of it, holding the list of options as children). (optionFromList): Use listObjectForSelection() to get the actual object holding the list of children as the available options. (optionFromSelection): Add support for combo boxes. (webkit_accessible_selection_add_selection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_is_child_selected): Ditto. (webkit_accessible_selection_remove_selection): Ditto. (webkit_accessible_text_get_text): Makes sure stringValue() is considered to get the result substring when it was already considered when checking the maximum text length for the object. (getInterfaceMaskFromObject): Make sure the AtkSelection interface is implemented for the combo boxes, that the AtkText is implemented for the menu items and that the AtkAction interface is now implemented for every object (WebCore will decide what to do).

Avoid a segfault crash when using this from unit tests.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow before calling gdk_window_get_origin() over it.

2010-11-21 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=25678

New test to check the implementation of the combo boxes.

  • tests/testatk.c: (testWebkitAtkComboBox): New test, checking that the roles and the implemented interfaces for a combo box and its descendants work. (main): Added the new unit test.
9:09 AM Changeset in webkit [72498] by Patrick Gansterer
  • 19 edits in trunk/WebCore

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore/platform directory
​https://bugs.webkit.org/show_bug.cgi?id=49881

  • platform/KURL.cpp: (WebCore::portAllowed):
  • platform/KURLGoogle.cpp: (WebCore::portAllowed):
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedJavaScriptMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCodepage::if):
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::disableComponentsOnce):
  • platform/graphics/mac/SimpleFontDataATSUI.mm: (WebCore::SimpleFontData::checkShapesArabic):
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawLineForTextChecking):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::disableComponentsOnce):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::load):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::pruneBlacklistedCodecs):
  • platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::FontTranscoder):
5:11 AM Changeset in webkit [72497] by Patrick Gansterer
  • 3 edits in trunk/LayoutTests

2010-11-21 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add test for unicode plane 1 characters
​https://bugs.webkit.org/show_bug.cgi?id=49581

  • fast/encoding/xml-utf-8-default-expected.txt:
  • fast/encoding/xml-utf-8-default.xml:

Nov 20, 2010:

11:20 PM Changeset in webkit [72496] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Rubber-stamped by Antonio Gomes.

[Qt] Fix spelling error (isEmtpyValue -> isEmptyValue)

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::isEmptyValue): (WebCore::FontPlatformData::FontPlatformData):
10:44 PM Changeset in webkit [72495] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Limit the size of image preview "cursor" when dragging
​https://bugs.webkit.org/show_bug.cgi?id=49872

Respect DragController::maxDragImageSize() (currently 400x400.)

  • platform/qt/DragImageQt.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage):
10:36 PM Changeset in webkit [72494] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
​https://bugs.webkit.org/show_bug.cgi?id=49870

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag): Pass the DragImage to QDrag::setPixmap()

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
​https://bugs.webkit.org/show_bug.cgi?id=49870

Implement Frame::dragImageForSelection() and the necessary DragImage helpers for Qt.

  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/qt/DragImageQt.cpp: (WebCore::deleteDragImage): (WebCore::createDragImageFromImage):
10:22 PM Changeset in webkit [72493] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove leftover code in unit test.

  • GNUmakefile.am: remove unneeded utils file in dependency list.
  • tests/testdomdocument.c: (main): do not change to the directory of a non existing resource list.
10:11 PM Changeset in webkit [72492] by xan@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

WebCore:

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
​https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am:
  • bindings/gobject/DOMObjectCache.cpp: Added.
  • bindings/gobject/DOMObjectCache.h: Copied from WebCore/bindings/gobject/WebKitDOMBinding.h.
  • bindings/gobject/WebKitDOMBinding.cpp: Remove the old cache code.
  • bindings/gobject/WebKitDOMBinding.h: ditto.
  • bindings/scripts/CodeGeneratorGObject.pm: include the new DOMObjectCache header.

WebKit/gtk:

2010-11-20 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
​https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am: add testutils file to testdomdocument.c
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::setMainFrameDocumentReady): collect DOM objects on document transition.
  • tests/testdomdocument.c: (dom_document_fixture_teardown): only destroy the view if it's not already destroyed, since the new test detroys it on its own. (test_dom_document_get_elements_by_tag_name): manually unref node list. (test_dom_document_get_elements_by_class_name): ditto. (test_dom_document_get_links): ditto. (test_dom_document_garbage_collection): test all possible scenarios for DOM object "garbage collection". (main): add new test.
  • tests/testdomnode.c: (test_dom_node_hierarchy_navigation): manually unref node list. (test_dom_node_insertion): ditto.
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_dispose): unref the inner node on dispose now that the memory management model is clarified. (webkit_hit_test_result_class_init): hook dispose.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_core_frame_gone): clear DOM objects attached to this frame. (webkit_web_frame_finalize): ditto.
10:03 PM Changeset in webkit [72491] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-11-20 Sam Magnuson <​smagnuso@gmail.com>

Reviewed by Andreas Kling.

[Qt] crash when attempting to add a JS object
​https://bugs.webkit.org/show_bug.cgi?id=49287

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):

Test: LayoutTests/fast/frames/sandboxed-iframe-plugins.html

8:19 PM Changeset in webkit [72490] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49490

Add new test for checking path stroke blur shadow.

  • fast/canvas/canvas-strokePath-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokePath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokePath-shadow.js: Added.

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49490

Add blur shadow support to strokePath().

Test: fast/canvas/canvas-strokePath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):
6:48 PM Changeset in webkit [72489] by barraclough@apple.com
  • 22 edits in trunk

YARR JIT should fallback to YARR Interpreter instead of PCRE.
​https://bugs.webkit.org/show_bug.cgi?id=46719

Patch by Peter Varga <​pvarga@inf.u-szeged.hu> on 2010-11-19
Reviewed by Gavin Barraclough.

Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.

JavaScriptCore:

  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::match):

  • tests/mozilla/expected.html:
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::byteCompileRegex):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexJIT.h:

(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):

  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

LayoutTests:

  • fast/js/regexp-look-ahead-empty-expected.txt:
  • fast/js/regexp-overflow-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
5:05 PM Changeset in webkit [72488] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-11-20 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed rebaseline for r72482.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
4:27 PM Changeset in webkit [72487] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace HTONL, HTONS, NTOHL and NTOHS with byte order conversion functions from AEEstd.h
​https://bugs.webkit.org/show_bug.cgi?id=49518

HTONL, HTONS, NTOHL and NTOHS macros are prohibited in Mod1. Use byte order conversion functions provided by AEEstd.h.

  • platform/graphics/WOFFFileFormat.cpp:
4:16 PM Changeset in webkit [72486] by rniwa@webkit.org
  • 5 edits
    2 adds
    3 deletes in trunk/LayoutTests

2010-11-20 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaselines for r72482.

Since Home/End behavior is different on Mac and GTK, move the expected result added by r72482
to platform/mac and platform/gtk, and add new expected result for other platforms.

See also: ​http://trac.webkit.org/changeset/54980 and ​https://webkit.org/b/35066.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed extend-selection.html.
  • platform/gtk/Skipped: Ditto.
  • platform/gtk/editing/selection/extend-selection-expected.txt: Removed.
  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/qt/Skipped: Removed extend-selection.html.
  • platform/win/editing/selection/extend-selection-expected.txt: Removed.
3:34 PM Changeset in webkit [72485] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Use std_wstrlen instead of WSTRLEN
​https://bugs.webkit.org/show_bug.cgi?id=49516

WSTRLEN is prohibited in Mod1. Use std_wstrlen from AEEstd.h instead.

  • platform/text/brew/StringBrew.cpp: (WTF::String::String):
3:32 PM Changeset in webkit [72484] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-20 Kwang Yul Seo <​skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace DBGPRINTF and DBGPRINTF_FATAL with dbg_Message
​https://bugs.webkit.org/show_bug.cgi?id=49520

DBGPRINTF and DBGPRINTF_FATAL macros are prohibited in Mod1. Use dbg_Message instead.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
3:18 PM Changeset in webkit [72483] by Patrick Gansterer
  • 2 edits
    1 delete in trunk/WebCore

2010-11-20 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

[WINCE] Implement textBreakLast and textBreakPrevious
​https://bugs.webkit.org/show_bug.cgi?id=49552

This allows us to use TextBoundaries.cpp and remove TextBoundariesWinCE.cpp.
Also unify the different TextBreakIterator::first() implementations.

  • platform/text/wince/TextBoundariesWinCE.cpp: Removed.
  • platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::TextBreakIterator::first): (WebCore::TextBreakIterator::last): (WebCore::textBreakLast): (WebCore::textBreakPrevious):
2:51 PM Changeset in webkit [72482] by rniwa@webkit.org
  • 1 edit
    10 adds
    2 deletes in trunk/LayoutTests

2010-11-19 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Antonio Gomes.

/editing/selection/extend-selection.html should be split into smaller tests
​https://bugs.webkit.org/show_bug.cgi?id=49849

Divided the test into 4 pieces.

  • editing/selection/extend-selection-character-expected.txt: Added.
  • editing/selection/extend-selection-character.html: Added.
  • editing/selection/extend-selection-enclosing-block-expected.txt: Added.
  • editing/selection/extend-selection-enclosing-block.html: Added.
  • editing/selection/extend-selection-expected.txt: Removed.
  • editing/selection/extend-selection-home-end-expected.txt: Added.
  • editing/selection/extend-selection-home-end.html: Added.
  • editing/selection/extend-selection-word-expected.txt: Added.
  • editing/selection/extend-selection-word.html: Added.
  • editing/selection/extend-selection.html: Removed.
  • editing/selection/resources/extend-selection.css: Added. (div.test): (div.test:before): (div.test span): (div.test img): (div.test img + img): (div.test div):
  • editing/selection/resources/extend-selection.js: Added. (log): (positionsExtendingInDirectionForEnclosingBlock): (positionsExtendingInDirection): (fold): (logPositions): (checkReverseOrder): (checkSameOrder): (extendingSelection): (testExtendingSelection): (createTestNodes.window.onload): (createTestNodes):
2:02 PM Changeset in webkit [72481] by loki@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-11-20 Gabor Loki <​loki@webkit.org>

Reviewed by Gavin Barraclough.

Support JIT_OPTIMIZE_MOD on Thumb-2
​https://bugs.webkit.org/show_bug.cgi?id=49432

Rewrite the soft modulo operation into macroassembler form, and move it
to JSValue32_64 section.
Add support for soft modulo on Thumb-2 JIT also.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::clz):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::countLeadingZeros32): (JSC::MacroAssemblerARM::relativeTableJump):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::countLeadingZeros32): (JSC::MacroAssemblerARMv7::relativeTableJump):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::softModulo):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • wtf/Platform.h:
1:25 PM Changeset in webkit [72480] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Adding failing expectation for Win + Linux for new
fast/canvas/canvas-fillPath-shadow test.

  • platform/chromium/test_expectations.txt:
12:54 PM Changeset in webkit [72479] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-20 Andreas Kling <​kling@webkit.org>

Reviewed by David Kilzer.

Path: Remove unused method swap()
​https://bugs.webkit.org/show_bug.cgi?id=49853

  • platform/graphics/Path.h:
12:12 PM Changeset in webkit [72478] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary

Reviewed by Dan Bernstein.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
RetainPtr<NSDictionary> for movieAttributes.

10:54 AM Changeset in webkit [72477] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

<​http://webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured

Reviewed by Darin Adler.

(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not. Implemented behavior.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.

9:40 AM Changeset in webkit [72476] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-20 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=45488

  • dom/XMLDocumentParser.cpp: (WebCore::toString):
9:33 AM Changeset in webkit [72475] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-20 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r72471.
​http://trac.webkit.org/changeset/72471
​https://bugs.webkit.org/show_bug.cgi?id=49865

broke two IME tests on Qt (Requested by kling on #webkit).

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
6:21 AM Changeset in webkit [72474] by reni@webkit.org
  • 79 edits in trunk/WebCore

FilterPrimitives should have a pointer to its Filter object.
​https://bugs.webkit.org/show_bug.cgi?id=49863

Reviewed by Dirk Schulze.

FilterPrimitives should have a renderer, and they need a member pointer to their Filter objects for Layout() calls.
This patch adds this member to FilterEffect.

No new test is needed because these modifications are covered by all of SVG Filter tests.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::create):
(WebCore::FEBlend::apply):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::FEColorMatrix):
(WebCore::FEColorMatrix::create):
(WebCore::FEColorMatrix::apply):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::FEComponentTransfer):
(WebCore::FEComponentTransfer::create):
(WebCore::FEComponentTransfer::apply):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::FEComposite):
(WebCore::FEComposite::create):
(WebCore::FEComposite::determineAbsolutePaintRect):
(WebCore::FEComposite::apply):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::apply):

  • platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::determineAbsolutePaintRect):

  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::FEDisplacementMap):
(WebCore::FEDisplacementMap::create):
(WebCore::FEDisplacementMap::apply):

  • platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::determineAbsolutePaintRect):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::FEFlood):
(WebCore::FEFlood::create):
(WebCore::FEFlood::apply):

  • platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::determineAbsolutePaintRect):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::FEGaussianBlur):
(WebCore::FEGaussianBlur::create):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::apply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::FELighting):
(WebCore::FELighting::apply):

  • platform/graphics/filters/FELighting.h:

(WebCore::FELighting::determineAbsolutePaintRect):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::FEMerge):
(WebCore::FEMerge::create):
(WebCore::FEMerge::apply):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::FEMorphology):
(WebCore::FEMorphology::create):
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::apply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::FEOffset):
(WebCore::FEOffset::create):
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::apply):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::FETile):
(WebCore::FETile::create):
(WebCore::FETile::apply):

  • platform/graphics/filters/FETile.h:

(WebCore::FETile::determineAbsolutePaintRect):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::create):
(WebCore::FETurbulence::apply):

  • platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::determineAbsolutePaintRect):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::effectContext):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::create):
(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::apply):

  • platform/graphics/filters/SourceAlpha.h:

(WebCore::SourceAlpha::SourceAlpha):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::create):
(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::apply):

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/RenderSVGResourceFilter.h:
  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::build):

  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::build):

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::build):

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp:

(WebCore::SVGFEFloodElement::build):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build):

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp:

(WebCore::SVGFEMergeElement::build):

  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::build):

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::build):

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build):

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::build):

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::build):

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::FEImage):
(WebCore::FEImage::create):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::apply):

  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::create):

2:25 AM Changeset in webkit [72473] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokeArc() is not necessary any more
​https://bugs.webkit.org/show_bug.cgi?id=49859

Remove strokeArc() from the Qt port.

No test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:
2:09 AM Changeset in webkit [72472] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49491

Add new test for checking path fill blur shadow.

  • fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-shadow.js: Added.

2010-11-20 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
​https://bugs.webkit.org/show_bug.cgi?id=49491

Add blur shadow support to fillPath().

Test: fast/canvas/canvas-fillPath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
12:15 AM Changeset in webkit [72471] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-11-19 Kristian Amlie <​kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Fixed handling of QInputMethodEvents with nonzero replacementLength.

These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.

Also made sure that the preeditString is always respected, even if
there is committed text. This is how QLineEdit does it.

​https://bugs.webkit.org/show_bug.cgi?id=49787

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
Note: See TracTimeline for information about the timeline view.