Timeline
Feb 12, 2011:
- 8:01 PM Changeset in webkit [78426] by
-
- 11 edits in trunk/Source/WebKit2
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=54335
<rdar://problem/8895141> Make window.print() work with WebKit2
- Platform/CoreIPC/Connection.h: Corrected a typo in FIXME comment.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::takeSnapshot): (WebKit::TiledDrawingAreaProxy::removeTile):
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::postMessageToInjectedBundle): Updated for send() -> deprecatedSend() rename.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added a flag that's true while serving window.print(). (WebKit::WebPageProxy::printFrame): Set and unset m_isPerformingDOMPrintOperation. (WebKit::WebPageProxy::beginPrinting): Force message processing in web process when serving window.print(). (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ditto. (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Ditto.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::sendMessage): (WebKit::WebProcessProxy::didFinishLaunching): When waiting for a web process to launch, store message flags, too. This is not practically important for DispatchMessageEvenWhenWaitingForSyncReply, but it's easier to store flags than to remember about this pitfall.
- UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::send): Added a flags argument, matching Connection::send(). (WebKit::WebProcessProxy::deprecatedSend): Renamed one of send() overloads, because it was conflicting with the other one after adding a flags argument. This matches a change previously made to CoreIPC::Connection.
- 4:18 PM Changeset in webkit [78425] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
Crash in RenderLayerCompositor::updateCompositingLayers when loading some sites
https://bugs.webkit.org/show_bug.cgi?id=54345
Some sites flip between composited and non-comosited state while loading. When the timing is
right, when we flip out of compositing we will need to do a display while tossing all the
compositing layers. This causes us to reenter RenderLayerCompositor::computeCompositingRequirements()
while we are in the middle of tossing layers, which leads to a crash.
The solution is to defer the logic of exiting compositing mode until the DrawingArea is finished
doing its display, using a timer.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
- WebProcess/WebPage/DrawingAreaImpl.h:
- 3:31 PM Changeset in webkit [78424] by
-
- 7 edits in trunk/Source/WebCore
WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>
Reviewed by Dan Bernstein.
When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.
In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):
- rendering/RenderListBox.h:
Add implementations for visibleHeight/visibleWidth.
- 2:42 PM Changeset in webkit [78423] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein.
Follow up fix to:
https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Fixed the order of the scale and translate.
- 2:13 PM Changeset in webkit [78422] by
-
- 3 edits2 adds in trunk
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342
Test which types of arrays work with crypto.getRandomValues.
- security/crypto-random-values-types-expected.txt: Added.
- security/crypto-random-values-types.html: Added.
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342
As discussed on whatwg, we should support all the integer array types.
Test: security/crypto-random-values-types.html
- page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
- 1:35 PM Changeset in webkit [78421] by
-
- 5 edits in trunk/Source
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279
I'm not sure it makes much of a difference whether we use arc4random or
/dev/urandom on Mac. However, there's some aesthetic benefit to using
the same underlying API on as many platforms as reasonable.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279
Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.
- config.h:
- 1:10 PM Changeset in webkit [78420] by
-
- 2 edits in trunk/Tools
2011-02-12 Chang Shu <cshu@webkit.org>
Unreviewed.
Update my own email addresses and IRC nickname.
- Scripts/webkitpy/common/config/committers.py:
- 12:46 PM Changeset in webkit [78419] by
-
- 8 edits in trunk/Source
2011-02-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321
- public/WebSettings.h: Add a flag for multisampling setting.
- src/WebSettingsImpl.cpp: Ditto. (WebKit::WebSettingsImpl::setOpenGLMultisamplingEnabled):
- src/WebSettingsImpl.h: Ditto.
2011-02-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
- page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled):
- page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled):
- 12:32 PM Changeset in webkit [78418] by
-
- 5 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54341 - optionally scale snapshots in document view coordinates
<rdar://problem/8990069>
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCreateScaledSnapshotInDocumentCoordinates): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added above new function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Added. (WebKit::WebPage::snapshotInDocumentCoordinates): Call scaledSnapshotInDocumentCoordinates with a scale of 1.
- WebProcess/WebPage/WebPage.h: Added scaledSnapshotInDocumentCoordinates().
- 4:37 AM Changeset in webkit [78417] by
-
- 5 edits in trunk/Source/WebCore
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Deploy EditingStyle in applyBlockStyle and applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=53911
Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.
No new tests are added since this is a refactoring.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
- editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
- editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
- editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude.
- 3:56 AM Changeset in webkit [78416] by
-
- 13 edits2 adds in trunk
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
- storage/indexeddb/objectstore-clear-expected.txt: Added.
- storage/indexeddb/objectstore-clear.html: Added.
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
Test: storage/indexeddb/objectstore-clear.html
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear):
- storage/IDBObjectStore.h:
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::clear):
- src/IDBObjectStoreProxy.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::clear):
- src/WebIDBObjectStoreImpl.h:
- 2:13 AM Changeset in webkit [78415] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Adam Barth <abarth@webkit.org>
Another attempt to fix the EFL build. Looks like we're missing one
more file.
- CMakeLists.txt:
- 2:01 AM Changeset in webkit [78414] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.
- CMakeLists.txt:
- 1:39 AM Changeset in webkit [78413] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix.
- dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets):
- 1:36 AM Changeset in webkit [78412] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Adam Barth <abarth@webkit.org>
CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.
- WebCore.pro:
- 1:29 AM Changeset in webkit [78411] by
-
- 5 edits in trunk/LayoutTests
2011-02-12 Adam Barth <abarth@webkit.org>
Update test expectations on Windows to account for ArrayBuffers being
on by default.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
- platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
- 1:18 AM Changeset in webkit [78410] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Adam Barth <abarth@webkit.org>
Apparently lines in .pro files need to be \-terminated.
- WebCore.pro:
- 1:10 AM Changeset in webkit [78409] by
-
- 3 edits in trunk/Source/WebCore
2011-02-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Extract a function to process contents for one node from Range::processContents
https://bugs.webkit.org/show_bug.cgi?id=54282
Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.
When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).
When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).
No new tests are added since this is a refactoring.
- dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added.
- dom/Range.h:
- 1:07 AM Changeset in webkit [78408] by
-
- 2 edits in trunk/Source/WebCore
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt Windows build.
- WebCore.pro:
- 12:24 AM Changeset in webkit [78407] by
-
- 54 edits3 deletes in trunk
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
Export the required functions.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.
- DerivedSources.cpp:
- WebCore.vcproj/WebCore.vcproj:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
- bindings/js/JSArrayBufferCustom.cpp:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDataViewCustom.cpp:
- bindings/js/JSFloat32ArrayCustom.cpp:
- bindings/js/JSInt16ArrayCustom.cpp:
- bindings/js/JSInt32ArrayCustom.cpp:
- bindings/js/JSInt8ArrayCustom.cpp:
- bindings/js/JSUint16ArrayCustom.cpp:
- bindings/js/JSUint32ArrayCustom.cpp:
- bindings/js/JSUint8ArrayCustom.cpp:
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
- bindings/v8/custom/V8DataViewCustom.cpp:
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
- html/canvas/ArrayBuffer.cpp:
- html/canvas/ArrayBuffer.idl:
- html/canvas/ArrayBufferView.cpp:
- html/canvas/ArrayBufferView.idl:
- html/canvas/DataView.cpp:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.cpp:
- html/canvas/Float32Array.idl:
- html/canvas/Int16Array.cpp:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.cpp:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.cpp:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.cpp:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.cpp:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.cpp:
- html/canvas/Uint8Array.idl:
- page/Crypto.cpp: (WebCore::Crypto::getRandomValues):
- page/Crypto.h:
- page/Crypto.idl:
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
Revert incorrect expectations from
http://trac.webkit.org/changeset/78337. These results were cased by
ArrayBuffers not beign enabled on Windows previous to this patch.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-function-resolve-expected.txt: Removed.
- platform/win/fast/js/var-declarations-shadowing-expected.txt: Removed.
- platform/win/security: Removed.
- platform/win/security/crypto-random-values-expected.txt: Removed.
Feb 11, 2011:
- 8:57 PM Changeset in webkit [78406] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-11 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
indexeddb: add onBlocked to WebKit::WebIDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=54329
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onBlocked):
- 7:16 PM Changeset in webkit [78405] by
-
- 9 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Can’t open local files on reload or navigation from the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=54332
<rdar://problem/8903076>
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::isInspectorPage):
- UIProcess/WebInspectorProxy.h: Check whether the given page is a web inspector page.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeSandboxExtensionHandle): If this is a web inspector page, we don't want to make a sandbox extension.
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
Pass a sandbox extension along when sending the message.
- UIProcess/WebPageProxy.h: Make initializeSandboxExtensionHandle a member function.
- UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData): Pass a sandbox extension along.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goForward): (WebKit::WebPage::goBack): (WebKit::WebPage::goToBackForwardItem): Hand the sandbox extension to the sandbox extension tracker.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
Pass the sandbox extension to goToBackForwardItem.
(WebKit::shouldReuseCommittedSandboxExtension):
New function that checks whether a committed sandbox extension should be re-used. We
do this for page reloads, as well as regular page navigations when both the committed
and provisional documents have file URLs.
(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Reuse the committed sandbox extension if necessary.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 7:09 PM Changeset in webkit [78404] by
-
- 3 edits in trunk/Source/WebKit2
Fix Snow Leopard build.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didFailToSendSyncMessage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didFailToSendSyncMessage):
- 6:50 PM Changeset in webkit [78403] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Qt webkit2 build fix after r78392.
- WebProcess/WebProcess.h:
- 6:42 PM Changeset in webkit [78402] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-11 Daniel Bates <dbates@rim.com>
Reviewed by Geoffrey Garen.
Remove explicit disable ENABLE_ASSEMBLER_WX_EXCLUSIVE on non-iOS ports
https://bugs.webkit.org/show_bug.cgi?id=54107
It is unnecessary to explicitly disable ENABLE_ASSEMBLER_WX_EXCLUSIVE
by the definition of ENABLE().
- wtf/Platform.h:
- 6:05 PM Changeset in webkit [78401] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
Unreviewed, Chromium test expectations update.
Unify identical expectation files in chromium/ and update for r78383.
- platform/chromium-mac/fast/url/port-expected.txt: Removed.
- platform/chromium-win/fast/url/port-expected.txt: Removed.
- platform/chromium/fast/url/port-expected.txt: Copied from platform/chromium-win/fast/url/port-expected.txt.
- 5:49 PM Changeset in webkit [78400] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebProcess hung communicating with the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=54328
<rdar://problem/8854075>
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection): Add the DispatchMessageEvenWhenWaitingForSyncReply message send flag when sending the PluginProcess::CreateWebProcessConnection message, since the plug-in process can be busy waiting for a sync reply from the web process.
- 5:45 PM Changeset in webkit [78399] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Incoming synchronous messages should always be processed regardless of connection waiting for a reply
https://bugs.webkit.org/show_bug.cgi?id=54326
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::getOrCreate): Assert that the map has a non-null SyncMessageState object.
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_waitForSyncReplyCount.
(CoreIPC::Connection::SyncMessageState::beginWaitForSyncReply):
Increment m_waitForSyncReplyCount.
(CoreIPC::Connection::SyncMessageState::endWaitForSyncReply):
Decrement m_waitForSyncReplyCount. If it's 0, enqueue any incoming sync messages.
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
If this is a message that needs to be dispatched, add it to the queue and wake up the client run loop.
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
Go through the queue of incoming messages and dispatch them.
(CoreIPC::Connection::sendSyncMessage):
call beginWaitForSyncReply/endWaitForSyncReply.
(CoreIPC::Connection::waitForSyncReply):
Dispatch messages.
(CoreIPC::Connection::processIncomingMessage):
Call SyncMessageState::processIncomingMessage.
(CoreIPC::Connection::enqueueIncomingMessage):
Add helper function for enqueuing an incoming message.
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::destinationID):
- 5:42 PM Changeset in webkit [78398] by
-
- 7 edits in trunk/Tools
2011-02-11 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch adds to NRWT most of the support needed to run the new
message-based workers in separate threads or processes. The code
isn't fully complete yet because we don't support cancel() or
is_alive().
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 5:36 PM Changeset in webkit [78397] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2: Going to Ars Technica crashes WebProcess in WebCore::ResourceRequestBase::url() const + 9
<rdar://problem/8978832>
Reviewed by Maciej Stachowiak.
Speculative fix for crash accessing a bad ResourceRequest in policy
client code. Remove early returns from dispatchDecidePolicyForMIMEType
and dispatchDecidePolicyForNavigationAction that are not present in the WebKit1
equivalent code. This should be safe, now that the IPC calls are synchronous.
Also removes some invalid assertions in WebFrameProxy that were getting hit. It is okay
for the url to empty.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didFailLoad):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- 5:34 PM Changeset in webkit [78396] by
-
- 3 edits19 adds in trunk
2011-02-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862
- fast/inline/inline-box-background-long-image.html: Added.
- fast/inline/inline-box-background-repeat-x.html: Added.
- fast/inline/inline-box-background-repeat-y.html: Added.
- fast/inline/inline-box-background.html: Added.
- fast/inline/resources: Added.
- fast/inline/resources/checker.png: Added.
- fast/inline/resources/gradient.png: Added.
- platform/mac/fast/inline/inline-box-background-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-long-image-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
2011-02-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862
When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order.
Tests: fast/inline/inline-box-background-long-image.html
fast/inline/inline-box-background-repeat-x.html
fast/inline/inline-box-background-repeat-y.html
fast/inline/inline-box-background.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer):
- 5:17 PM Changeset in webkit [78395] by
-
- 9 edits in trunk
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318
Broke Safari extensions (Requested by eseidel on #webkit).
- fast/url/host-expected.txt:
- fast/url/ipv4-expected.txt:
- fast/url/ipv6-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318
Broke Safari extensions (Requested by eseidel on #webkit).
- platform/KURL.cpp: (WebCore::KURL::parse):
- 5:07 PM Changeset in webkit [78394] by
-
- 2 edits in trunk/Source/WebCore
Fix for <rdar://problem/8976456> Scrollbars for overflow
areas never appear for WKScrollbarPainter scrollers
Reviewed by Sam Weinig.
Call ScrollableArea::didAddVerticalScrollbar() and
ScrollableArea::willRemoveVerticalScrollbar() when
appropriate for RenderLayers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
- 4:57 PM Changeset in webkit [78393] by
-
- 3 edits2 moves in trunk/LayoutTests
Unreviewed, Chromium test expectations update.
Also moved a test that's not Linux-specific and other platforms seem to
pass from chromium-linux/ to chromium/.
- platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Removed.
- platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Removed.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/text/international/complex-text-rectangle-expected.txt: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt.
- platform/chromium/fast/text/international/complex-text-rectangle.html: Copied from platform/chromium-linux/fast/text/international/complex-text-rectangle.html.
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [78392] by
-
- 7 edits in trunk/Source/WebKit2
Reviewed by Darin Adler and Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=53593
<rdar://problem/8948380> Crash beneath HistoryController::recursiveSetProvisionalItem in web
process (preceded by assertion failure) if UI process exits while
Messages::WebPage::RestoreSessionAndNavigateToCurrentItem is being handled
Can't test exiting the UI process.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Client::didFailToSendSyncMessage): Notify connection client when the connection fails to send a sync message.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::didFailToSendSyncMessage):
- WebProcess/WebProcess.h: Quit the web process immediately if it tried to send a sync message to a dead UI process. It never needs to continue and handle an unexpected null "reply".
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::didFailToSendSyncMessage):
- PluginProcess/PluginProcess.h: Ditto. There is no need for a plug-in to keep running even briefly if it couldn't get a reply to a sync message.
- 4:17 PM Changeset in webkit [78391] by
-
- 2 edits in trunk/LayoutTests
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unrevied chromium-gpu expectations update. Update expectations for
chromium-gpu-mac (it often has image diffs only, since it can use the
text results from the mac port).
- platform/chromium/test_expectations.txt:
- 4:16 PM Changeset in webkit [78390] by
-
- 4 edits in trunk/Source/JavaScriptCore
Not reviewed.
Randomly touch some build files in the hopes of fixing the Qt build.
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- 4:13 PM Changeset in webkit [78389] by
-
- 2 edits in trunk/Source/JavaScriptCore
Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320
Reviewed by Sam Weinig.
(Rolling back in r78386 with the build fixed.)
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make
our timer inert after forcing a GC, to avoid GC'ing repeatedly.
- 4:10 PM Changeset in webkit [78388] by
-
- 2 edits in trunk/LayoutTests
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Mark tests that fail only on
Snow Leopard, so that we can begin to have green Snow Leopard bots.
- platform/chromium/test_expectations.txt:
- 4:06 PM Changeset in webkit [78387] by
-
- 2 edits in trunk/Source/JavaScriptCore
Not reviewed.
Used svn merge -r78386:78385 to roll out r78386 because it broke the build.
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::trigger):
- 3:58 PM Changeset in webkit [78386] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Garbage collection timer cycles forever, even when nothing is happening
https://bugs.webkit.org/show_bug.cgi?id=54320
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger): Be sure to make our timer inert after forcing a GC, to avoid GC'ing repeatedly.
- 3:49 PM Changeset in webkit [78385] by
-
- 4 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a way to send async messages that can't get out of order with sync ones
https://bugs.webkit.org/show_bug.cgi?id=54319
<rdar://problem/8894844>
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage): sendMessage now takes a messageSendFlags. Update the messageID if the messageSendFlags contain DispatchMessageEvenWhenWaitingForSyncReply.
(CoreIPC::Connection::waitForSyncReply):
Process asynchronous messages as well.
(CoreIPC::Connection::processIncomingMessage):
Check if a message should be dispatched even when we're waiting for a
synchronous reply.
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): Send now takes a messageSendFlags parameter.
- Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::messageIDWithAddedFlags): Return a new MessageID object with the given flags added.
(CoreIPC::MessageID::shouldDispatchMessageWhenWaitingForSyncReply):
Add getter.
- 3:48 PM Changeset in webkit [78384] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build: added an exported symbol.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:47 PM Changeset in webkit [78383] by
-
- 12 edits in trunk
2011-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090
Added a new test to show that we are intentionally removing
a colon after a host name. http://foo.com:/ -> http://foo.com/
- fast/url/port-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090
- platform/KURL.cpp: (WebCore::isDefaultPortForScheme): (WebCore::KURL::parse):
- 3:31 PM Changeset in webkit [78382] by
-
- 18 edits1 delete in trunk/Source
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
CollectorHeapIterator is a God object that knows the internals of each
of the pieces of the heap. This undermines the encapsulation I'm trying
to achieve by splitting concepts into different classes.
As an alternative, I've given each class a forEach iteration function,
which takes a functor as an argument. Now, each class just needs to
know how to iterate the things it knows about.
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed CollectorHeapIterator.
- debugger/Debugger.cpp: (JSC::Recompiler::Recompiler): (JSC::Recompiler::~Recompiler): (JSC::Recompiler::operator()): (JSC::Debugger::recompileAllJSFunctions): Updated to use forEach interface instead of an iterator.
- runtime/CollectorHeapIterator.h: Removed.
- runtime/Heap.cpp: (JSC::TypeCounter::TypeCounter): (JSC::TypeCounter::typeName): (JSC::TypeCounter::operator()): (JSC::TypeCounter::take): (JSC::Heap::protectedObjectTypeCounts): (JSC::Heap::objectTypeCounts): Added forEach and removed iterator.
- runtime/Heap.h: (JSC::Heap::forEach):
- runtime/JSGlobalData.cpp: (JSC::Recompiler::operator()): (JSC::JSGlobalData::recompileAllJSFunctions):
- runtime/MarkedBlock.h: (JSC::MarkedBlock::forEach): Added forEach. Removed friend declaration for CollectorHeapIterator. Now, we can make all our data private and change it without breaking any other classes.
- runtime/MarkedSpace.cpp:
- runtime/MarkedSpace.h: (JSC::MarkedSpace::forEach): Added forEach and removed iterator.
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
- WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
- 3:16 PM Changeset in webkit [78381] by
-
- 5 edits in trunk/Source/WebKit2
Crash with dynamic popup menu use
<rdar://problem/8716952>
Reviewed by Anders Carlsson.
Invalidate popup menus when forcing them closed, since they might still be
in their tracking loop.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
- UIProcess/WebPopupMenuProxy.h:
(WebKit::WebPopupMenuProxy::invalidate):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::setFocusedIndex):
- 3:13 PM Changeset in webkit [78380] by
-
- 2 deletes in branches/chromium/597/LayoutTests/fast/canvas/webgl
remove accidently added .orig files
- 3:12 PM Changeset in webkit [78379] by
-
- 5 edits2 adds in branches/chromium/597
Merge 77956, crbug 71717
- 3:09 PM Changeset in webkit [78378] by
-
- 6 edits in branches/chromium/597/WebCore
Revert 78366 - Revert 78101 - Merge r76728, crbug 68263
Review URL: http://codereview.chromium.org/6508005
- 3:05 PM Changeset in webkit [78377] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend
is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp
No new tests. All existing canvas layouttests exercise this code path
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
- 2:56 PM Changeset in webkit [78376] by
-
- 4 edits in branches/chromium/597/WebCore
Revert 78354 - Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005
Review URL: http://codereview.chromium.org/6510003
- 2:56 PM Changeset in webkit [78375] by
-
- 2 edits in trunk/Source/WebKit2
Actually initialize m_syncMessageState.
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
- 2:46 PM Changeset in webkit [78374] by
-
- 3 edits in trunk/LayoutTests
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
compositing/reflections/reflection-opacity.html has a JS exception
https://bugs.webkit.org/show_bug.cgi?id=54314
The JS code that the test was running was producing an error, and in
any case it didn't seem to be doing anything, since we don't define a
"moved" class (copy-and-paste error?).
- compositing/reflections/reflection-opacity.html:
- platform/mac/compositing/reflections/reflection-opacity-expected.txt:
- 2:45 PM Changeset in webkit [78373] by
-
- 2 edits in trunk/LayoutTests
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unrevied chromium-gpu expectations update. Remove failing expectations
for tests that now pass on the chromium-gpu-win bot.
- platform/chromium/test_expectations.txt:
- 2:38 PM Changeset in webkit [78372] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move the binary semaphore into SyncMessageState
https://bugs.webkit.org/show_bug.cgi?id=54311
With this change, all connections that belong to the same run loop will use same binary semaphore.
This is in preparation for making any connection be able to wakeup the client run loop.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::wakeUpClientRunLoop): (CoreIPC::Connection::SyncMessageState::wait): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::processIncomingMessage): (CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
- 2:26 PM Changeset in webkit [78371] by
-
- 4 edits2 deletes in branches/chromium/597
Revert 78166 - Merge r77114
Review URL: http://codereview.chromium.org/6508002
- 2:21 PM Changeset in webkit [78370] by
-
- 2 edits5 deletes in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Explicitly skip webarchive tests on GTK+, because we do not
support them. Remove all GTK+-specific webarchive expected results.
- platform/gtk/Skipped: Explicitly skip all webarchive tests.
- platform/gtk/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt: Removed.
- platform/gtk/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
- 2:14 PM Changeset in webkit [78369] by
-
- 2 edits150 adds in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 2:03 PM Changeset in webkit [78368] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-11 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add a SyncMessageState class to CoreIPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=54309
SyncMessageState objects are shared between all connections scheduled on
a given run loop. It will be used to keep track of state when waiting
for replies for a synchronous message.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::SyncMessageState::syncMessageStateMap): (CoreIPC::Connection::SyncMessageState::syncMessageStateMapMutex): Add a global RunLoop -> SyncMessageState map and a mutex for locking.
(CoreIPC::Connection::SyncMessageState::getOrCreate):
Look in the map for an existing SyncMessageState object and create a new
one if none is found.
(CoreIPC::Connection::SyncMessageState::SyncMessageState):
Initialize m_runLoop.
(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
Remove the object from the map.
- 2:03 PM Changeset in webkit [78367] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Adler.
Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=54304
This avoids potential crashes in HashMap, as WTF's StringHash doesn't
accept empty Strings.
- platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
- 1:56 PM Changeset in webkit [78366] by
-
- 6 edits2 deletes in branches/chromium/597
Revert 78101 - Merge r76728, crbug 68263
Review URL: http://codereview.chromium.org/6474050
- 1:51 PM Changeset in webkit [78365] by
-
- 4 edits3 adds in trunk/LayoutTests
2011-02-11 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu expectations update. Add more fine-grained
expectations for compositing on Windows (instead of the whole directory
being marked PASS FAIL). Also replace all FAIL GPU expectations with
more specific ones (e.g. TEXT or IMAGE+TEXT).
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png:
- platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.checksum: Added.
- platform/chromium-gpu/compositing/iframes/nested-iframe-scrolling-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:41 PM Changeset in webkit [78364] by
-
- 1 edit1 delete in trunk/LayoutTests
plugins/invalidate_rect.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=54122
This test was fixed on Windows in http://trac.webkit.org/changeset/78359. Remove the failing
expected results. Unreviewed.
- platform/win/plugins/invalidate_rect-expected.txt: Removed.
- 1:39 PM Changeset in webkit [78363] by
-
- 2 edits in trunk/Source/WebKit2
crashes in WebProcess at WebCore::Range::startPosition const + 16
https://bugs.webkit.org/show_bug.cgi?id=54294
<rdar://problem/8982710>
Reviewed by Darin Adler.
I don't have a repro case for this bugs, but the side-by-side
comparison of the IME support implementation in WebKit and WebKi2
shows a missing null check on a Range that could very well explain
this crash.
I tried running platform/mac/editing/input tests with a version of WebKit
without the null check and I can reproduce a crash with the same signature.
These tests are not yet enabled for WebKit2.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::firstRectForCharacterRange):
- 1:39 PM Changeset in webkit [78362] by
-
- 22 edits11 adds in trunk
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
Tests for filesystem: URIs, testing both their security origin
properties and the existence of the Entry.toURI method.
- fast/filesystem/directory-entry-to-uri-expected.txt: Added.
- fast/filesystem/directory-entry-to-uri.html: Added.
- fast/filesystem/file-entry-to-uri-expected.txt: Added.
- fast/filesystem/file-entry-to-uri.html: Added.
- fast/filesystem/filesystem-uri-origin-expected.txt: Added.
- fast/filesystem/filesystem-uri-origin.html: Added.
- fast/filesystem/resources/directory-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestDirectory): ():
- fast/filesystem/resources/file-entry-to-uri.js: Added. (errorCallback): (entryToURI): (createTestFile): ():
- http/tests/security/filesystem-iframe-from-remote-expected.txt: Added.
- http/tests/security/filesystem-iframe-from-remote.html: Added.
- http/tests/security/resources/create-filesystem-file.html: Added.
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
There are two major parts to this patch: one is to add an
implementation of Entry.toURI to the FileSystem API.
The other is to implement security origin checking for this
new scheme.
All changes are guarded by the FILE_SYSTEM feature. An accompanying
Chromium change, to support loading of filesystem: URIs, has recently
been submitted as Chromium r74082.
Spec:
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2
Proposed URI format, and discussion of security origin issues:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html
Tests: fast/filesystem/directory-entry-to-uri.html
fast/filesystem/file-entry-to-uri.html
fast/filesystem/filesystem-uri-origin.html
http/tests/security/filesystem-iframe-from-remote.html
- fileapi/Entry.cpp: (WebCore::Entry::toURI):
- fileapi/Entry.h:
- fileapi/Entry.idl:
- Added toURI method to the IDL, omitting the MIME type argument specified in the spec as it will soon be removed.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
- crack the filesystem: URI to get at the origin of the site (WebCore::SecurityOrigin::canDisplay):
- canDisplay for filesystem: URIs is equivalent to canRequest
- platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::create): (WebCore::AsyncFileSystem::openFileSystem):
- platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::type):
- Exposed filesystem type to allow toURI to use it as part of the path. (WebCore::AsyncFileSystem::AsyncFileSystem):
- platform/SchemeRegistry.cpp: (WebCore::canDisplayOnlyIfCanRequestSchemes): (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest): (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
- Generalized canDisplayOnlyIfCanRequest as it applies to both filesystem: and blob: URIs.
- platform/SchemeRegistry.h:
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
Changes to Chromium WebKit API required to expose
the FileSystem type to WebCore's fileapi code, since the
type is part of the filesystem URI.
- src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
- src/AsyncFileSystemChromium.h: (WebCore::AsyncFileSystemChromium::create):
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
- src/WebFileSystemCallbacksImpl.h:
- src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
- src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create):
- 1:21 PM Changeset in webkit [78361] by
-
- 2 edits in trunk/Source/WebCore
Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62
Reviewed by Darin Adler.
Must check for null _animator.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 12:52 PM Changeset in webkit [78360] by
-
- 5 edits in trunk/Source/WebCore
2011-02-11 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
https://bugs.webkit.org/show_bug.cgi?id=54158
No new tests since audio API is not yet implemented.
- bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer):
- bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::createBufferCallback):
- platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
- webaudio/AudioContext.idl:
- 12:41 PM Changeset in webkit [78359] by
-
- 6 edits in trunk
2011-02-11 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
invalidate_rect.html should now pass on Windows. Removing skip.
- platform/chromium/test_expectations.txt:
2011-02-11 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
This change fixes the invalidate_rect.html test failure on Windows.
There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.
The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.
This change also updates the build path in chromium_win.py to use the new Source directory.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect):
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventWin): (NPP_HandleEvent):
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- 12:24 PM Changeset in webkit [78358] by
-
- 2 edits150 adds in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add another batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 12:19 PM Changeset in webkit [78357] by
-
- 2 edits148 adds in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 12:10 PM Changeset in webkit [78356] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
https://bugs.webkit.org/show_bug.cgi?id=54224
No new tests. Existing canvas tests exercise this...
fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
- 11:53 AM Changeset in webkit [78355] by
-
- 4 edits in trunk/Source/WebCore
2011-02-11 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by David Levin.
Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390
No new tests.
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl: Wrap methods and declarations that use HTMLVideoElement with #if ENABLE(VIDEO).
- 11:44 AM Changeset in webkit [78354] by
-
- 5 edits in branches/chromium/597/WebCore
Revert 78236 - Merge r76205, crbug 54262
Review URL: http://codereview.chromium.org/6500005
- 11:41 AM Changeset in webkit [78353] by
-
- 2 edits142 adds in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Add the next batch of GTK+ SVG test results.
- platform/gtk/Skipped: Unskip tests which now have results.
- 11:37 AM Changeset in webkit [78352] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] wmode gets overridden even if already windowless in QGraphicsWebView
Do not override wmode if it is not set to "window".
https://bugs.webkit.org/show_bug.cgi?id=50495
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- 11:23 AM Changeset in webkit [78351] by
-
- 2 edits in trunk/Source/WebKit2
Eliminate /DELAYLOAD:msimg32.dll ignored warning when building WebKit project
https://bugs.webkit.org/show_bug.cgi?id=54296
Reviewed by Steve Falkenburg.
- win/WebKit2Common.vsprops: Remove msimg32.dll from the list of DelayLoadDLLs.
- 11:16 AM Changeset in webkit [78350] by
-
- 5 edits4 adds in trunk/Source/WebKit2
2011-02-11 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy
classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54080
- GNUmakefile.am:
- Shared/gtk/UpdateChunk.cpp: Added. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
- Shared/gtk/UpdateChunk.h: Added. (WebKit::UpdateChunk::rect): (WebKit::UpdateChunk::isEmpty): (WebKit::UpdateChunk::size):
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): Initialize the surface.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h: Added cairo variables.
- UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingAreaProxy::page): (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
- 11:03 AM Changeset in webkit [78349] by
-
- 5 edits2 deletes in trunk
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
- platform/gtk/accessibility/document-reload-events.html: Removed.
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach):
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus):
- 10:42 AM Changeset in webkit [78348] by
-
- 2 edits461 adds in trunk/LayoutTests
2011-02-11 Martin Robinson <mrobinson@igalia.com>
Generate more GTK+ results for many SVG tests missing them.
- platform/gtk/Skipped: Unskip tests which now have results.
- 10:21 AM Changeset in webkit [78347] by
-
- 2 edits in trunk/LayoutTests
[Windows XP Debug Tests] media/audio-mpeg4-supported.html timing out since introduction in
r76621.
https://bugs.webkit.org/show_bug.cgi?id=54291
Unreviewed, adding this test to the Windows XP skip list in order to get the bots green.
- platform/win-xp/Skipped:
- 10:11 AM Changeset in webkit [78346] by
-
- 3 edits in trunk/Source/WebCore
2011-02-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GDOM] Video element needs proper wrapping
https://bugs.webkit.org/show_bug.cgi?id=54231
Use the same strategy as the one used for the audio tag to wrap
video as well. No layout tests because this only adds API.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createVideoWrapper): (WebKit::createHTMLElementWrapper):
- 10:00 AM Changeset in webkit [78345] by
-
- 59 edits in trunk/Source/WebCore
2011-02-11 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
https://bugs.webkit.org/show_bug.cgi?id=54259
Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
avoid overloading a virtual function.
No change of functionality. Just fixing a build warning, so no new tests.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
- 9:54 AM Changeset in webkit [78344] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776
- platform/win-xp/fast/dom: Added.
- platform/win-xp/fast/dom/52776-expected.txt: Added.
- 9:43 AM Changeset in webkit [78343] by
-
- 3 edits in trunk/Source/WebCore
2011-02-11 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
https://bugs.webkit.org/show_bug.cgi?id=54089
- inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): (WebInspector.Drawer.prototype.immediatelyFinishAnimation): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging):
- inspector/front-end/inspector.js: (WebInspector.animateStyle): (WebInspector.animateStyle.forceComplete): (WebInspector.animateStyle.cancel): (WebInspector.showSourceLine):
- 9:28 AM Changeset in webkit [78342] by
-
- 32 edits in trunk/Source
2011-02-10 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489
Refactor, no new tests.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::explicitClose): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState):
- dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader):
- html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::writer):
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
- loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 9:16 AM Changeset in webkit [78341] by
-
- 2 edits in trunk/LayoutTests
2011-02-11 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added two tests to the skipped file that started to fail only in
64-bit debug bot. Rounding issues are most likely the source of
differences between 32 and 64bit bots.
- platform/gtk/Skipped: added svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
- 8:48 AM ApplicationsGtk edited by
- (diff)
- 8:47 AM ApplicationsGtk edited by
- (diff)
- 8:36 AM Changeset in webkit [78340] by
-
- 1 edit3 deletes in trunk/LayoutTests
2011-02-11 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unnecessary chromium layout test rebaselines
https://bugs.webkit.org/show_bug.cgi?id=54278
- platform/chromium/fast/js/ToNumber-expected.txt: Removed.
- platform/chromium/fast/js/parseFloat-expected.txt: Removed.
- platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.
- 8:24 AM Changeset in webkit [78339] by
-
- 3 edits in trunk/LayoutTests
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: unflake inspector test (2).
- inspector/command-line-api.html:
- inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.selectElementAndRun):
- 7:47 AM Changeset in webkit [78338] by
-
- 3 edits in trunk/LayoutTests
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: unflake inspector test.
- inspector/command-line-api-expected.txt:
- inspector/command-line-api.html:
- 7:42 AM Changeset in webkit [78337] by
-
- 2 edits4 adds in trunk/LayoutTests
[Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html,
fast/js/global-function-resolve.html,
fast/js/var-declarations-shadowing.html,
and security/crypto-random-values.html failing since r78321.
https://bugs.webkit.org/show_bug.cgi?id=54285
Unreviewed, landing expected failing results to get the bots green.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-function-resolve-expected.txt: Added.
- platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
- platform/win/security: Added.
- platform/win/security/crypto-random-values-expected.txt: Added.
- 7:23 AM Changeset in webkit [78336] by
-
- 21 edits in trunk/Source/WebCore
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
https://bugs.webkit.org/show_bug.cgi?id=54227
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler):
- inspector/InspectorAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::mainDOMContentLoaded): (WebCore::InspectorDOMAgent::loadEventFired):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
- inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
- inspector/InspectorDOMStorageResource.h:
- inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
- inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::FrontendProvider::create): (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider): (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::create):
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired):
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::mute): (WebCore::InspectorState::updateCookie):
- inspector/InspectorState.h: (WebCore::InspectorState::~InspectorState):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- 6:54 AM Changeset in webkit [78335] by
-
- 5 edits in trunk
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283
- inspector/command-line-api-expected.txt:
- inspector/command-line-api.html:
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283
- inspector/InjectedScriptSource.js:
- 6:21 AM Changeset in webkit [78334] by
-
- 2 edits in trunk/Tools
[Qt] Increase the timeout of Qt API tests to 120 seconds.
Reviewed by Andreas Kling.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 5:25 AM Changeset in webkit [78333] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-11 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
CryptographicRandomNumber has its threading ifdefs backwards
https://bugs.webkit.org/show_bug.cgi?id=54280
Turns out we want the mutex when thread is enabled. :)
- wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber): (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
- 5:19 AM Changeset in webkit [78332] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Andreas Kling.
[Qt][S60] Vertical borders of buttons and frames are misaligned
https://bugs.webkit.org/show_bug.cgi?id=51169
Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
without anti-aliasing. Patch idea by Laszlo Agocs.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- 4:53 AM Changeset in webkit [78331] by
-
- 5 edits2 adds in trunk
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Added new layout test to check the right signals are emitted.
- platform/gtk/accessibility/document-reload-events-expected.txt: Added.
- platform/gtk/accessibility/document-reload-events.html: Added.
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.
Test: platform/gtk/accessibility/document-reload-events.html
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Emit the right signals when reloading a document.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.
- 3:19 AM Changeset in webkit [78330] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-02-11 Adam Barth <abarth@webkit.org>
Turns out that expectation isn't Qt specific.
- http/tests/security/cross-frame-access-put-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.
- 2:53 AM Changeset in webkit [78329] by
-
- 3 edits1 add in trunk/LayoutTests
2011-02-11 Adam Barth <abarth@webkit.org>
Update Qt expected results for window.crypto.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
- 2:50 AM Changeset in webkit [78328] by
-
- 4 edits2 adds in trunk
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
- inspector/command-line-api-expected.txt: Added.
- inspector/command-line-api.html: Added.
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275
Test: inspector/command-line-api.html
- inspector/InjectedScriptSource.js:
- 2:31 AM Changeset in webkit [78327] by
-
- 7 edits in trunk
2011-02-11 Adam Barth <abarth@webkit.org>
Turns out window.crypto is supposed to be readonly.
- page/DOMWindow.idl:
2011-02-11 Adam Barth <abarth@webkit.org>
Update test expectations to show window.crypto.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- http/tests/security/cross-frame-access-put-expected.txt:
- 2:10 AM Changeset in webkit [78326] by
-
- 1 edit15 adds in trunk/LayoutTests
2011-02-11 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new test expectations for the GTK port.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- 1:34 AM Changeset in webkit [78325] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Adam Barth <abarth@webkit.org>
Actually add Crypto.cpp to the Windows build. I'm terrible.
- WebCore.vcproj/WebCore.vcproj:
- 1:21 AM Changeset in webkit [78324] by
-
- 1 edit in trunk/Source/WebCore/page/Crypto.h
Fix typo
- 1:12 AM Changeset in webkit [78323] by
-
- 5 edits in trunk/Source/WebCore
2011-02-11 Adam Barth <abarth@webkit.org>
Attempt to fix the Windows build. Apparently we don't support
conditional attributes on functions. This patch makes the whole Crypto
interface conditional on ArrayBuffer support.
- page/DOMWindow.idl:
- page/Crypto.cpp:
- page/Crypto.h:
- page/Crypto.idl:
- 12:57 AM Changeset in webkit [78322] by
-
- 6 edits in trunk/Source/WebCore
Enable ancestor identifier filtering for tree building
https://bugs.webkit.org/show_bug.cgi?id=54241
Reviewed by Dave Hyatt.
Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.
This roughly halves the remaining time in style matching over a typical page load.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
- dom/Document.h:
(WebCore::Document::styleSelectorIfExists):
- dom/Element.cpp:
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/Element.h:
- 12:37 AM Changeset in webkit [78321] by
-
- 21 edits6 adds in trunk
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Test crypto.getRandomValues API. It's pretty hard to write a
deterministic API for a randomized API, but this test should catch some
regressions.
- security/crypto-random-values-expected.txt: Added.
- security/crypto-random-values.html: Added.
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Teach JavaScriptCore how to export this function.
- JavaScriptCore.exp:
- JavaScriptCore.xcodeproj/project.pbxproj:
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Add crypto.getRandomValues. Yes, all these diffs are required to
expose a single function to the DOM.
Test: security/crypto-random-values.html
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- config.h:
- page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues):
- page/Crypto.h: Added. (WebCore::Crypto::create):
- page/Crypto.idl: Added.
- page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto):
- page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto):
- page/DOMWindow.idl:
- 12:26 AM Changeset in webkit [78320] by
-
- 2 edits in trunk/Source/WebCore
2011-02-11 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[GTK] Build break with 2.18.3
https://bugs.webkit.org/show_bug.cgi?id=54057
- platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
- 12:14 AM Changeset in webkit [78319] by
-
- 3 edits in trunk/Source/WebCore
2011-02-11 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749
No new tests. Refactoring.
- platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init):
- platform/KURLGooglePrivate.h:
Feb 10, 2011:
- 11:36 PM Changeset in webkit [78318] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Temporarily skip a test that fails in WebKit2 due to a recent regression
https://bugs.webkit.org/show_bug.cgi?id=54276
- platform/mac-wk2/Skipped:
- 11:21 PM Changeset in webkit [78317] by
-
- 6 edits in trunk/Source/WebCore
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
Convert ContainerNode::firstElementChild() to a free function.
https://bugs.webkit.org/show_bug.cgi?id=54269
No new tests. No change in behavior.
It seemed incorrect to have a method on ContainerNode that had the
concept of an Element but couldn't return an Element*, but a method on
Element could not be called by holders of ContainerNodes or other
non-Element ContainerNode subclasses. A free function can both return
an Element* and be called by anyone with a ContainerNode*.
- dom/ContainerNode.h: (WebCore::ContainerNode::lastChild): (WebCore::Node::lastChild):
- dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
- dom/Element.cpp: (WebCore::Element::firstElementChild):
- dom/Element.h: (WebCore::firstElementChild):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
- 10:50 PM Changeset in webkit [78316] by
-
- 3 edits3 adds in trunk
2011-02-10 Mads Ager <ager@chromium.org>
Reviewed by Nate Chapin.
[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216
Check for exceptions when attempting to get the handleEvent property
of an event-handler object.
Test: fast/dom/exception-getting-event-handler.html
- bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::getListenerFunction):
2011-02-10 Mads Ager <ager@chromium.org>
Reviewed by Nate Chapin.
[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216
Add crash regression test with custom chromium expectations.
- fast/dom/exception-getting-event-handler-expected.txt: Added.
- fast/dom/exception-getting-event-handler.html: Added.
- platform/chromium/fast/dom/exception-getting-event-handler-expected.txt: Added.
- 10:38 PM Changeset in webkit [78315] by
-
- 3 edits2 adds in trunk
2011-02-10 Naoki Takano <takano.naoki@gmail.com>
Reviewed by James Robinson.
[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857
This fix is for 2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. Add 2d.composite.globalAlpha.fillPath.html as a new test for the combination with globalAlpha and fillPath().
- fast/canvas/2d.composite.globalAlpha.fillPath-expected.txt: Added.
- fast/canvas/2d.composite.globalAlpha.fillPath.html: Added.
2011-02-10 Naoki Takano <takano.naoki@gmail.com>
Reviewed by James Robinson.
[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857
globalAlpha is not applied to fillPath() and fillRect().
Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called. (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor. (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor.
- 10:35 PM Changeset in webkit [78314] by
-
- 5 edits in trunk/Source/WebCore
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Remove an unneeded argument from HTMLDocument::create().
https://bugs.webkit.org/show_bug.cgi?id=54268
Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for
fragment parsing, there isn't a need to explicitly specify a baseURL
when constructing an HTMLDocument. We can remove the unneeded argument.
Also fix some style issues in Document.h and HTMLDocument.h caught by
check-webkit-style.
No new tests. No change in behavior.
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h: (WebCore::HTMLDocument::create):
- 10:17 PM Changeset in webkit [78313] by
-
- 4 edits in trunk/LayoutTests
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list and skip some tests that show differences
between the bots. Rebaseline Acid2 tests results.
- platform/gtk/Skipped: Clean up the skipped list. Skip failing test.
- platform/gtk/http/tests/misc/acid2-expected.txt:
- platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
- 9:34 PM Changeset in webkit [78312] by
-
- 11 edits in trunk/Source/JavaScriptCore
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more encapsulation for MarkedBlock: Made all constants private
so clients don't know whether allocations are fixed-sized or not
https://bugs.webkit.org/show_bug.cgi?id=54270
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::advance): Updated for removal of HeapConstants.
- runtime/Error.cpp: Switched to using ASSERT_CLASS_FITS_IN_CELL, like all other classes.
- runtime/Heap.cpp: (JSC::Heap::allocate): Updated for removal of HeapConstants. (JSC::Heap::reset): Updated to use size(), instead of calculating size on our own.
- runtime/Heap.h: Moved the ASSERT here to MarkedBlock, since it enforces on special knowledge of fixed-sizery, which only MarkedBlock is supposed to know about.
- runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for removal of HeapConstants. Also changed to reset nextCell to 0 at the end of a block, since that seems more consistent.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Changed to use a fixed array of char. This hard-coded size is a little wonky, but the compiler will tell us if it's ever wrong, so I think it's OK.
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep): Updated for removal of HeapConstants.
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::size): (JSC::MarkedBlock::capacity): Made constants private to this class. Removed HeapConstants. Added size() and capacity() functions.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::size): (JSC::MarkedSpace::capacity):
- runtime/MarkedSpace.h: Use MarkedBlock helper functions instead of direct knowledge of MarkedBlock internals.
- 9:14 PM Changeset in webkit [78311] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
remove extra space from expansion lines
https://bugs.webkit.org/show_bug.cgi?id=54266
- code-review.js:
- 9:12 PM Changeset in webkit [78310] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
only erase draft comments after publish is successful
https://bugs.webkit.org/show_bug.cgi?id=54163
If there is a conflict or 500, then draft comments will survive.
One drawback here is that the form post is now to the iframe,
so to break out of the iframe we redirect to the bug page, which
loses the information of who the email was sent to.
Once WebKit supports seamless iframes we should be able to avoid
the redirect.
- code-review.js:
- 9:07 PM Changeset in webkit [78309] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, fix a typo.
- platform/chromium/test_expectations.txt:
- 8:41 PM Changeset in webkit [78308] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 8:24 PM Changeset in webkit [78307] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectation update.
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [78306] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 7:55 PM Changeset in webkit [78305] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 7:32 PM Changeset in webkit [78304] by
-
- 2 edits in trunk/Tools
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 7:23 PM Changeset in webkit [78303] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more encapsulation for MarkedBlock: Made mark bits private
https://bugs.webkit.org/show_bug.cgi?id=54264
SunSpider reports no change.
- runtime/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients don't need to know that marks are represented as bits. Renamed markedCells => markCount, since clients don't need to know that blocks are split into cells.
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::markCount): New helper functions for encapsulating the information clients actually need.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::clearMarks): (JSC::MarkedSpace::markCount): (JSC::MarkedSpace::objectCount):
- runtime/MarkedSpace.h: Use new helper functions instead of accessing MarkedBlock data directly.
- 7:18 PM Changeset in webkit [78302] by
-
- 5 edits1 add in trunk/Tools
2011-02-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch adds the bulk of the remaining functionality for
the NRWT message-passing implementation. The patch adds a new
Worker class that will eventually replace the TestShellThread
class in dump_render_tree_thread.py, and implements enough of
TestRunner2 and the inline version of the manager_worker_broker
to actually be able to send a full set of messages back and
forth. The Worker stubs do not actually run tests, and there's
lots of error handling and stats needed, but this is the core
logic.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 7:04 PM Changeset in webkit [78301] by
-
- 5 edits in trunk/Source
Versioning.
- 7:03 PM Changeset in webkit [78300] by
-
- 1 copy in tags/Safari-534.19
New tag.
- 6:57 PM Changeset in webkit [78299] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Re-landing this fix, bug without the test case, since it causes hangs on the bots.
https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test.
Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.
(WebKit::PluginView::evaluate):
Add a plug-in protector.
- 6:24 PM Changeset in webkit [78298] by
-
- 2 edits in trunk/Tools
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 6:10 PM Changeset in webkit [78297] by
-
- 9 edits in trunk/Source
2011-02-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245
Added clear method which removes SourceProviderCache items.
Cleaned up extraneous whitespace.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- parser/SourceProviderCache.cpp: (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::clear): (JSC::SourceProviderCache::byteSize): (JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
2011-02-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245
Added logic in CachedScript to clear SourceProviderCache data in
destroyDecodedData(). Added and changed CachedScript timeout to
act similar to CachedImage. Changed didAddClient to call super
class method instead of duplicating the logic in the derived
classes.
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
- loader/cache/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
- loader/cache/CachedScript.h:
- 6:06 PM Changeset in webkit [78296] by
-
- 2 edits in trunk/Tools
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 5:45 PM Changeset in webkit [78295] by
-
- 2 edits in trunk/Tools
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, attempt to fix crashing plugin tests.
- DumpRenderTree/DumpRenderTree.gypi:
- 5:26 PM Changeset in webkit [78294] by
-
- 2 edits in trunk/Tools
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 5:23 PM Changeset in webkit [78293] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228
Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10
Reviewed by David Levin.
Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.
No new tests. This is a style fix.
- platform/KURLGoogle.cpp:
- platform/KURLGooglePrivate.h:
- 5:16 PM Changeset in webkit [78292] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-10 Joseph Pecoraro <Joseph Pecoraro>
Follow-up fix to r78291. I should pass (int) 0, not '0' to memset.
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change.
- 5:09 PM Changeset in webkit [78291] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-10 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Geoffrey Garen.
Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
https://bugs.webkit.org/show_bug.cgi?id=54257
A subclass may want to specify the CFRunLoop that the Garbage Collection
will happen on. It was difficult to manipulate this in a subclass because
the current DefaultGCActivityCallback class does this in its constructor.
This patch generalizes things a bit more so that a specific run loop can
be passed in to the constructor. This makes it so all run loop management
can stay in DefaultGCActivityCallback and a subclass can specify any runloop.
- runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can specify the runloop GC can be scheduled on.
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors, one that specifies the run loop and passes that on to commonConstructor and the old constructor defaults to the current run loop. (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction, adding the timer to the given runloop.
- 5:03 PM Changeset in webkit [78290] by
-
- 2 edits442 adds in trunk/LayoutTests
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Generate GTK+ results for many SVG tests missing them.
- platform/gtk/Skipped: Unskip tests which now have results.
- 5:01 PM Changeset in webkit [78289] by
-
- 3 edits in trunk/Source/WebCore
2011-02-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by David Levin.
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228
Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.
No new tests. This is a style fix.
- platform/KURLGoogle.cpp:
- platform/KURLGooglePrivate.h:
- 4:56 PM Changeset in webkit [78288] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=54254
Reviewed by Enrica Casucci and Adele Peterson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _handleStyleKeyEquivalent:]):
Return early if we're not in an editable region.
- 4:50 PM Changeset in webkit [78287] by
-
- 2 edits in trunk/Tools
Try and fix some crashing tests on the chromium build bot.
- DumpRenderTree/DumpRenderTree.gypi:
- 4:45 PM Changeset in webkit [78286] by
-
- 8 edits2 adds in trunk
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
The HTML5 fragment parsing algorithm specifies that a new Document
should be created to serve as the temporary parent of fragment nodes
during parsing. Document creation is expensive and accounts for ~38% of
the Peacekeeper DOM performance regression. Avoid the cost of creating
a dummy document by using the already-created DocumentFragment as the
root node during fragment parsing.
With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~24%.
Test: fast/parser/fragment-parser-doctype.html
- dom/ContainerNode.h: (WebCore::ContainerNode::firstElementChild): Add a method that returns the first element-typed child from a ContainerNode.
- dom/Document.cpp: (WebCore::Document::cacheDocumentElement): Call ContainerNode::firstElementChild() to retrieve and cache the document element.
- html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the root ContainerNode. (WebCore::HTMLConstructionSite::detach): Clear the reference to the root ContainerNode. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Attach the new element to the root ContainerNode. (WebCore::HTMLConstructionSite::insertDoctype): Ditto. (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
- html/parser/HTMLConstructionSite.h: Store a pointer to a ContainerNode that will be used as the root node for document parsing. This node might or might not be the same as m_document.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the HTMLConstructionSite with the correct root ContainerNode based on whether or not we're parsing a fragment. (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Remove m_dummyDocumentForFragmentParsing. (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the fragment has a context element, store only the children of the root element (HTML5 Section 10.4, Step 7).
- html/parser/HTMLTreeBuilder.h:
2011-02-09 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
- fast/parser/fragment-parser-doctype-expected.txt: Added.
- fast/parser/fragment-parser-doctype.html: Added.
- 4:32 PM Changeset in webkit [78285] by
-
- 2 edits in trunk/Source/WebCore
Speculative fix for <rdar://problem/8985232> Overlay
scrollers can appear on the sliding page during
back/forward fluid gesture
Reviewed by Oliver Hunt.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
- 4:20 PM Changeset in webkit [78284] by
-
- 8 edits in trunk/Source/JavaScriptCore
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for MarkedBlock: Moved allocate() and sweep() into MarkedBlock
https://bugs.webkit.org/show_bug.cgi?id=54253
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: Removed DeadObjectIterator, since it is now unused.
- runtime/Heap.cpp: (JSC::Heap::reset): Moved the call to shrink() here, since it seems a little more clear for MarkedSpace's client to tell it explicitly when to shrink.
- runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Split out from MarkedSpace::allocate.
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::sweep): Split out from MarkedSpace::sweep, and converted to more directly iterate a MarkedBlock based on knowing its internal structure.
- runtime/MarkedBlock.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Split out the code mentioned above.
- 4:14 PM Changeset in webkit [78283] by
-
- 4 edits in trunk/Websites/bugs.webkit.org
2011-02-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
save overall comments when saving drafts in the review tool
https://bugs.webkit.org/show_bug.cgi?id=54165
-save overall comments in localstorage as well
-save all draft comments as you type
-give a *subtle* indicator of saved state
The latter should also make it super easy if someone wanted to do
the work to store draft comments in appengine/s3/bugzilla/etc.
- PrettyPatch/PrettyPatch.rb:
- code-review-test.html:
- code-review.js:
- 3:58 PM Changeset in webkit [78282] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 3:51 PM Changeset in webkit [78281] by
-
- 3 edits in trunk/Tools
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Log an error if a plug-in test can't be found
https://bugs.webkit.org/show_bug.cgi?id=54252
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::create): Return null if the test wasn't found.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Report an error if PluginTest::create returns null.
- 3:49 PM Changeset in webkit [78280] by
-
- 8 edits in trunk/Source/WebCore
2011-02-09 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB event targets need to ensure their wrappers aren't garbage collected
https://bugs.webkit.org/show_bug.cgi?id=54144
hasActivityPending should return true as long as it's possible that we'll
fire more event listeners on our event targets. It is still possible for
user generated events to run into problems, but I'm not sure how to address
that yet (or how big of a deal it is).
There's really no way to test this deterministically. Testing by hand makes
it seem like this patch works as expected though.
- storage/IDBCursorBackendImpl.cpp:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::hasPendingActivity): (WebCore::IDBDatabase::stop):
- storage/IDBDatabase.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::hasPendingActivity): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::finished): (WebCore::IDBTransaction::hasPendingActivity): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h:
- 3:29 PM Changeset in webkit [78279] by
-
- 2 edits61 adds in trunk/LayoutTests
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Add results for HTTP tests missing GTK+ results.
- platform/gtk/Skipped: Unskip HTTP tests that now have results.
- 3:26 PM Changeset in webkit [78278] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
Fix compilation error on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=53766
Add a HAVE_STRNSTR in Platform.h and define it only on Darwin and FreeBSD.
- wtf/Platform.h:
- wtf/StringExtras.h: Use HAVE(STRNSTR) now.
- 3:23 PM Changeset in webkit [78277] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, tiny test fix from cira.
Excluding v8Locale from property-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=54250
- fast/dom/script-tests/prototype-inheritance.js:
- 3:03 PM Changeset in webkit [78276] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Unskip some GTK+ HTTP tests that are passing locally. All the bots
should have the same libsoup version now.
- platform/gtk/Skipped: Unskip some passing tests.
- 2:58 PM Changeset in webkit [78275] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [78274] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-10 Andreas Kling <kling@webkit.org>
Unreviewed Qt build fix.
waitFor() -> deprecatedWaitFor()
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
- 2:54 PM Changeset in webkit [78273] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] create pkg-config files for mingw
https://bugs.webkit.org/show_bug.cgi?id=54238
(mingw is mostly the same as unix)
This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.
Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
45fe2dddc3a0677b9ec9fce09f07cd4129e37afa
- WebCore.pro:
- 2:52 PM Changeset in webkit [78272] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
https://bugs.webkit.org/show_bug.cgi?id=54246
- rendering/style/RenderStyle.h:
- 2:45 PM Changeset in webkit [78271] by
-
- 3 edits in trunk/Source/WebCore
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG animation avoid unnecessary adjust for currentColor
https://bugs.webkit.org/show_bug.cgi?id=54243
At the moment we try to adjust every animation value for currentColor - independent of the animation type.
Since the value is a string and the target element may needs to get called by getElementById, this could
be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
as a string and parse it to Color afterwards again.
With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
parsed as a string again.
No change of functionality, no new tests.
- svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
- 2:32 PM Changeset in webkit [78270] by
-
- 3 edits in trunk/Source/WebKit/qt
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Ensure WebView press delay timer is cancelled when grab is taken
https://bugs.webkit.org/show_bug.cgi?id=54242
As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-15529
Flickable steals the grab, but the timer was not stopped and the
keepGrab flag is set and the mouse grabbed. This means that the WebView
now has the grab and subsequent clicks on another element are ignored.
Original patch from Martin Jones <martin.jones@nokia.com>
reviewed (there) by Joona Petrell
52068f57f9c32098a90cc217730a530f85590f65
- declarative/qdeclarativewebview.cpp: (GraphicsWebView::sceneEvent):
- declarative/qdeclarativewebview_p.h:
- 2:17 PM Changeset in webkit [78269] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Fix assert in QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=54240
As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-14278
Instantiating a QDeclarativeWebView twice will trigger an assertion
when in debug mode.
Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
reviewed (there) by Aaron Kennedy
f532679ca11914b453e22342f2ae5e9f790ce47a
- declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
- 2:15 PM Changeset in webkit [78268] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qFindChildren()
https://bugs.webkit.org/show_bug.cgi?id=54232
This was applied on the Qt repository and affects QtWebKit there.
(13833beb641289c45faed337848d37280195aadc)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if that's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(this,* */f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(&\([\(),]*\),* */
2.f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*()\),* */
2->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*\):\([\(),]*\),* */(
2:
3)->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*\),* */
2->f
1(/'" qFindChild
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):
- 2:03 PM Changeset in webkit [78267] by
-
- 3 edits in branches/chromium/648
Merge 77956
BUG=71717
Review URL: http://codereview.chromium.org/6486014
- 1:59 PM Changeset in webkit [78266] by
-
- 4 edits in trunk/Source/WebKit/qt
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Misc documentation fixes/updates
https://bugs.webkit.org/show_bug.cgi?id=54236
There are a few commits in the Qt repository (master and 4.7 branches)
with QtWebKit documentation fixes:
84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
Clarified documentation of loadFinished() signal
eebe205b306daaa3674d9746de11a73bef4bd0de
Doc: Fixed QML, unindented snippet
b0d64717d2c541976dc5524e4100c62f060e206f
doc: Changed a table into 3 tables to eliminate a \raw.
As these are all minor doc changes, I decided to group them
into one single patch.
- Api/qwebpage.cpp:
- declarative/qdeclarativewebview.cpp:
- docs/qtwebkit.qdoc:
- 1:58 PM Changeset in webkit [78265] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Rename build target from "embedded" to "qpa"
https://bugs.webkit.org/show_bug.cgi?id=54233
This flag is used by Qt's configure script to enable a QPA build
("QPA is a window system agnostic implementation of Qt" --
previously known as lighthouse).
On the Qt repository, this was changed by two commits:
13a0b4935900093607f2b3b7688e1452d22770fd
(from embedded to embedded_lite)
9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
(from embedded_lite to qpa)
- WebCore.pro:
- 1:49 PM Changeset in webkit [78264] by
-
- 1 edit2 adds in trunk/Source/WebCore
2011-02-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Incorporate algorithm for processing paths into GPU-renderable triangle meshes
https://bugs.webkit.org/show_bug.cgi?id=45521
Adding an implementation of Loop and Blinn's GPU accelerated path
rendering algorithm from GPU Gems 3. This implementation pays
particular attention to the efficiency of the curve subdivision
phase needed for correct rendering. It utilizes the OpenGL utility
library tessellator for triangulation of the interior of the
shape. The regions handled by Loop and Blinn's algorithm are
handled by the local triangulator previously incorporated.
No tests yet; pixel tests will eventually be used to verify this
algorithm and prevent regressions.
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added. (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup): (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint): (WebCore::LoopBlinnPathProcessorImplementation::Segment::next): (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour): (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex): (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString): (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour): (WebCore::LoopBlinnPathProcessorImplementation::Contour::add): (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin): (WebCore::LoopBlinnPathProcessorImplementation::Contour::end): (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate): (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::process): (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY): (WebCore::LoopBlinnPathProcessor::determineSidesToFill): (WebCore::LoopBlinnPathProcessor::determineOrientation): (WebCore::SweepData::SweepEvent::SweepEvent): (WebCore::SweepData::SweepEvent::setup): (WebCore::SweepData::SweepEvent::x): (WebCore::SweepData::SweepEvent::entry): (WebCore::SweepData::SweepEvent::interval): (WebCore::SweepData::SweepEvent::operator<): (WebCore::SweepData::trianglesOverlap): (WebCore::LoopBlinnPathProcessor::subdivideCurves): (WebCore::LoopBlinnPathProcessor::conditionallySubdivide): (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow): (WebCore::TessellationState::vertexCallback): (WebCore::TessellationState::combineCallback): (WebCore::TessellationState::edgeFlagCallback): (WebCore::LoopBlinnPathProcessor::tessellateInterior):
- platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.
- 1:18 PM Changeset in webkit [78263] by
-
- 6 edits in trunk/Source
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229
This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-10 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229
This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
- tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myInvokableWithQObjectListArg): (MyQObject::myInvokableWithListOfIntArg): (MyQObject::myInvokableWithQObjectStarArg): (MyQObject::myInvokableWithQBrushArg): (MyQObject::myInvokableWithBrushStyleArg): (MyQObject::myInvokableWithVoidStarArg): (MyQObject::myInvokableWithAmbiguousArg): (MyQObject::myInvokableWithDefaultArgs): (MyQObject::myInvokableWithPointArg): (MyQObject::myOverloadedSlot):
- 1:10 PM Changeset in webkit [78262] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Removed.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
- platform/mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
- 1:04 PM Changeset in webkit [78261] by
-
- 6 edits in trunk/Source/WebCore
2011-02-10 Nico Weber <thakis@chromium.org>
Reviewed by Darin Adler.
Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=54221
The method name conflicts with ContainerNode::getRect() so rename it to
computeRect(). Rename getPath() to computePath() for consistency as
well.
No intended functionality change, covered by existing tests.
- accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::elementRect):
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::computePath): (WebCore::HTMLAreaElement::computeRect):
- html/HTMLAreaElement.h:
- page/SpatialNavigation.cpp: (WebCore::virtualRectForAreaElementAndDirection):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing):
- 1:04 PM Changeset in webkit [78260] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move code to dispatch an incoming message out into a new function
https://bugs.webkit.org/show_bug.cgi?id=54239
This also fixes a leak where we wouldn't free ArgumentDecoder objects
after a connection has been invalidated.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchMessage): (CoreIPC::Connection::dispatchMessages):
- Platform/CoreIPC/Connection.h:
- 12:44 PM Changeset in webkit [78259] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
We now respect the outline property and html.css defines the outline of the focus
ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses
it as the pen size. We should ignore the size and keep a default one. I also
reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia,
CG Win, Haiku, WinCE ports also ignore the width.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath): (WebCore::GraphicsContext::drawFocusRing):
- 12:36 PM Changeset in webkit [78258] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Skip newly added tests that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=54235
- platform/mac-wk2/Skipped:
- 12:26 PM Changeset in webkit [78257] by
-
- 5 edits in trunk
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090
- platform/gtk/Skipped: Unskip tests which should now be passing.
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090
Call didSendData as body data is uploaded to the server. This is necessary
for XHR upload events to function properly.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members. One to track the total amount of body data and one to track the total amount of body data sent so far.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::wroteBodyDataCallback): Added. (WebCore::addFormElementsToSoupMessage): Split this out into a helper function. Will now now sum the total amount of body data. (WebCore::startHttp): Attach a wrote-body-data signal handler.
- 12:18 PM Changeset in webkit [78256] by
-
- 8 edits in trunk
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- platform/qt/Skipped: unskip editing/selection/context-menu-on-text.html
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (iterateContextMenu): (DumpRenderTreeSupportQt::contextMenu):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:12 PM Changeset in webkit [78255] by
-
- 2 edits in trunk/Source/WebKit2
Try again to fix the Qt build.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
- 11:58 AM Changeset in webkit [78254] by
-
- 10 edits in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- 11:50 AM Changeset in webkit [78253] by
-
- 5 edits in trunk/Source/WebCore
2011-02-10 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=53925
- platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::downloadToFile): (WebCore::ResourceRequest::setDownloadToFile):
- platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
- 11:37 AM Changeset in webkit [78252] by
-
- 3 edits in trunk/Source/WebKit2
Attempt to fix the Qt build.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
- WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):
- 11:28 AM UsingGitWithWebKit edited by
- (diff)
- 11:27 AM UsingGitWithWebKit edited by
- (diff)
- 11:26 AM Changeset in webkit [78251] by
-
- 8 edits1 add in trunk
Handle a null FindIndicator correctly
We are passed a null FindIndicator when the find indicator becomes hidden.
Fixes <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
FindIndicator::contentImage when scrolling page
Reviewed by Steve Falkenburg.
Source/WebKit2:
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::isNull): Implemented.
(WebKit::SharedMemory::create): Bail out if the handle is null, just like Mac does.
Otherwise assert that ::MapViewOfFile succeeded. This doesn't fix the bug, but should help
catch other errors.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator): Null-check the FindIndicator before dereferencing it.
Also changed the function to store the FindIndicator in a RefPtr.
Tools:
Test showing and hiding the find indicator on Windows
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
bitmap.
(TestWebKitAPI::initialize): Hook up our callbacks.
(TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::page):
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::page):
Made page a const member function.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
- 11:25 AM Changeset in webkit [78250] by
-
- 2 edits in trunk/Source/JavaScriptCore
Print locations of assertions and logs in a way that Visual Studio understands
With this change, double-clicking one of these locations in Visual Studio's Output Window
will focus that line of code in the editor.
Fixes <http://webkit.org/b/54208> Double-clicking locations of assertions/logs in Visual
Studio's Output Window does nothing
Reviewed by Alexey Proskuryakov.
- wtf/Assertions.cpp:
(printCallSite): Use OS(WINDOWS) instead of the meaningless OS(WIN). When we aren't using
the debug CRT (and thus can't call _CrtDbgReport), print the file and line number using the
same format that cl.exe uses when it prints compiler errors.
- 11:16 AM Changeset in webkit [78249] by
-
- 122 edits in trunk/Source/WebCore
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimateElement needs information about the animated attribute type
https://bugs.webkit.org/show_bug.cgi?id=53442
For animations, we need to know the SVG property type for a XML attribute. A global static mapping between
attribute name and a type is not possible, since one attribute name can be bound to different property types:
x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports
the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between
the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static
HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function
that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons.
No change of functionality, so no new test cases.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::attributeToPropertyTypeMap): (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
- svg/SVGAElement.h:
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::attributeToPropertyTypeMap): (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::attributeToPropertyTypeMap): (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap): (WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::attributeToPropertyTypeMap): (WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap):
- svg/SVGCursorElement.h:
- svg/SVGElement.cpp: (WebCore::SVGElement::attributeToPropertyTypeMap): (WebCore::SVGElement::animatedPropertyTypeForAttribute):
- svg/SVGElement.h: (WebCore::SVGElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::attributeToPropertyTypeMap): (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::attributeToPropertyTypeMap): (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap): (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::attributeToPropertyTypeMap): (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap): (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::attributeToPropertyTypeMap): (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap): (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::attributeToPropertyTypeMap): (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::attributeToPropertyTypeMap): (WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap): (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap): (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::attributeToPropertyTypeMap): (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap): (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::attributeToPropertyTypeMap): (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::attributeToPropertyTypeMap): (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
- svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap): (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
- svg/SVGForeignObjectElement.h:
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGGlyphElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attributeToPropertyTypeMap): (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGImageElement.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::attributeToPropertyTypeMap): (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap): (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::attributeToPropertyTypeMap): (WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::attributeToPropertyTypeMap): (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeToPropertyTypeMap): (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
- svg/SVGMaskElement.h:
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::attributeToPropertyTypeMap): (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGPathElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::attributeToPropertyTypeMap): (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::attributeToPropertyTypeMap): (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap): (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::attributeToPropertyTypeMap): (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::attributeToPropertyTypeMap): (WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap):
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::attributeToPropertyTypeMap): (WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::attributeToPropertyTypeMap): (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty): (WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::attributeToPropertyTypeMap): (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::attributeToPropertyTypeMap): (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::attributeToPropertyTypeMap): (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::attributeToPropertyTypeMap): (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
- svg/SVGTSpanElement.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::attributeToPropertyTypeMap): (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::attributeToPropertyTypeMap): (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::attributeToPropertyTypeMap): (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
- svg/SVGTitleElement.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::attributeToPropertyTypeMap): (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::attributeToPropertyTypeMap): (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
- svg/SVGViewElement.h:
- 11:05 AM Changeset in webkit [78248] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
Fix a Warning after removing FileSystem support for the inspector.
- WebCore.pro:
- 10:55 AM Changeset in webkit [78247] by
-
- 9 edits in trunk/Source/WebKit2
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add 'deprecated' to the deprecated CoreIPC functions
https://bugs.webkit.org/show_bug.cgi?id=54223
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): (CoreIPC::Connection::deprecatedSendSync): (CoreIPC::Connection::deprecatedSend): (CoreIPC::Connection::deprecatedWaitFor):
- Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::open):
- PluginProcess/PluginProcess.cpp:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection):
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::postMessage): (WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::setSize):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
- 10:50 AM Changeset in webkit [78246] by
-
- 10 edits in trunk/Source/WebKit2
2011-02-10 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Window resizer does not have a border when there are scrollbars in WebKit2 windows
<rdar://problem/8488476>
https://bugs.webkit.org/show_bug.cgi?id=54222
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
- UIProcess/API/mac/WKView.mm: (-[WKView _updateGrowBoxForWindowFrameChange]): (-[WKView _didChangeScrollbarsForMainFrame]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::didChangeScrollbarsForMainFrame):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- UIProcess/win/WebView.cpp: (WebKit::WebView::didChangeScrollbarsForMainFrame):
- UIProcess/win/WebView.h:
- 10:44 AM Changeset in webkit [78245] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-10 Ivan Krstić <ike@apple.com>
Reviewed by Adam Roben.
Rename remaining instances of _HOME sandbox parameter.
<rdar://problem/8983428>
- WebProcess/com.apple.WebProcess.sb:
- 10:42 AM Changeset in webkit [78244] by
-
- 3 edits2 adds in trunk/Tools
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Log signals from AtkDocument interface also in AccessibilityController
https://bugs.webkit.org/show_bug.cgi?id=54198
Trace AtkDocument's signals emission through AccessibilityController.
Also, taken the code related to adding and removing global
listeners for ATK signals out to a separate file, for the sake of
clarity and to ease future additions.
- DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
- DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added (printAccessibilityEvent): Print information about an event. (axObjectEventListener): Global listener for AtkObject's signals. (axDocumentEventListener): Global listener for AtkDocument's signals. (connectAccessibilityCallbacks): Connect all global listeners. (disconnectAccessibilityCallbacks): Disconnect all global listeners.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::setLogAccessibilityEvents): Call to connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
- GNUmakefile.am: Added new files.
- 10:40 AM Changeset in webkit [78243] by
-
- 33 edits16 adds in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
- platform/mac-leopard/svg/batik/filters/feTile-expected.png:
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png:
- 10:38 AM Changeset in webkit [78242] by
-
- 1 edit in branches/chromium/648/Source/WebCore/platform/ScrollView.cpp
Merge 77549 - Scroll thumb jumps to top when resizing horizontally.
Reviewed by Beth Dakin.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.
TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/6490004
- 10:25 AM Changeset in webkit [78241] by
-
- 13 edits in trunk/Source
AX: AX needs to stop using WebCoreViewFactory
https://bugs.webkit.org/show_bug.cgi?id=54153
Reviewed by Anders Carlsson.
../WebCore:
WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
to get off of it and use WebCoreSystemInterface, like other clients.
- WebCore.exp.in:
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
- accessibility/mac/AccessibilityObjectWrapper.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetElement):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
../WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
../WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 10:15 AM Changeset in webkit [78240] by
-
- 5 edits2 adds in trunk/Source
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201
Add files for the fullscreen video playback handling. It also fix
a missing header.
- WebCore.pro:
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201
Add a default fullscreen handler when there is no plaftform plugin
installed. This handler creates a fullscreen QVideoWidget and plays
the video. Space pause/resume the video playback and esc quit the
fullscreen mode.
- WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback): (WebCore::DefaultFullScreenVideoHandler::enterFullScreen): (WebCore::DefaultFullScreenVideoHandler::exitFullScreen): (WebCore::FullScreenVideoQt::FullScreenVideoQt):
- WebCoreSupport/FullScreenVideoQt.h:
- WebCoreSupport/FullScreenVideoWidget.cpp: Added. (WebCore::FullScreenVideoWidget::FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::~FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::show): (WebCore::FullScreenVideoWidget::closeEvent): (WebCore::FullScreenVideoWidget::event): (WebCore::FullScreenVideoWidget::keyPressEvent): (WebCore::FullScreenVideoWidget::hideCursor): (WebCore::FullScreenVideoWidget::showCursor):
- WebCoreSupport/FullScreenVideoWidget.h: Added.
- 10:11 AM Changeset in webkit [78239] by
-
- 2 edits in trunk/Source/WebKit2
Sandbox violations trying to read crypto preferences.
<rdar://problem/8981151>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 10:07 AM Changeset in webkit [78238] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Clump the tests failing only on the GTK+ 32-bit bot together with the
other tests that have this kind of failure.
- platform/gtk/Skipped: Clean up the skipped list slightly.
- 9:49 AM Changeset in webkit [78237] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM Compiler build fix.
- runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
- 9:47 AM Changeset in webkit [78236] by
-
- 5 edits in branches/chromium/597/WebCore
Merge r76205, crbug 54262
- 9:47 AM Changeset in webkit [78235] by
-
- 67 edits34 adds15 deletes in trunk/LayoutTests
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
- 9:43 AM Changeset in webkit [78234] by
-
- 17 edits3 deletes in trunk/Source/WebCore
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove FileSystem support from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=50695
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorFileSystemAgent.cpp: Removed.
- inspector/InspectorFileSystemAgent.h: Removed.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
- inspector/front-end/FileSystemView.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 9:29 AM Changeset in webkit [78233] by
-
- 2 edits2 copies in branches/chromium/648
Merge 77891
BUG=72217
Review URL: http://codereview.chromium.org/6488001
- 9:13 AM Changeset in webkit [78232] by
-
- 24 edits in trunk/Source/WebCore
2011-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78219.
http://trac.webkit.org/changeset/78219
https://bugs.webkit.org/show_bug.cgi?id=54215
breaks editing/style/iframe-onload-crash.html on GTK 64-bit
Debug (Requested by philn-tp on #webkit).
- dom/Document.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/Node.h:
- dom/Text.h:
- editing/htmlediting.cpp: (WebCore::editingIgnoresContent): (WebCore::canHaveChildrenForEditing):
- editing/htmlediting.h:
- html/HTMLBRElement.h:
- html/HTMLButtonElement.h:
- html/HTMLDataGridElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLHRElement.h:
- html/HTMLImageElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOutputElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLProgressElement.h:
- wml/WMLBRElement.h:
- wml/WMLDoElement.h:
- wml/WMLImageElement.h:
- wml/WMLInputElement.h:
- wml/WMLSelectElement.h:
- 9:07 AM Changeset in webkit [78231] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77049
BUG=70885
Review URL: http://codereview.chromium.org/6482031
- 9:04 AM Changeset in webkit [78230] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77329
BUG=71167
Review URL: http://codereview.chromium.org/6478032
- 8:58 AM Changeset in webkit [78229] by
-
- 1 edit in branches/chromium/648/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp
Merge 78143
BUG=72387
Review URL: http://codereview.chromium.org/6478030
- 8:46 AM Changeset in webkit [78228] by
-
- 5 edits1 delete in trunk
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Unskip passing tests and remove some bogus expected results.
- platform/gtk/Skipped: Unskip some tests which are now passing.
- platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Disable the default error page during DRT runs. This prevents unexpected loads
from interfering with tests that have planned failed loads.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadError): Added, disable default handler. (createWebView): Connect the new load-error handler.
- 8:21 AM Changeset in webkit [78227] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
French translation for Webkit/GTK
https://bugs.webkit.org/show_bug.cgi?id=26108
- fr.po: Added.
- 8:16 AM Changeset in webkit [78226] by
-
- 3 edits in trunk/Source/WebCore
2011-02-10 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt][V8] Fix the build.
No new tests needed.
- bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header.
- loader/cache/CachedScript.h: do not use extra qualification for base class enum.
- 8:03 AM Changeset in webkit [78225] by
-
- 5 edits in trunk/Source/WebCore
2011-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input
https://bugs.webkit.org/show_bug.cgi?id=54205
- inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
- inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty):
- inspector/front-end/StylesSidebarPane.js: ():
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete):
- 8:01 AM Changeset in webkit [78224] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skip failing fast/text/international/hindi-whitespace.html test on GTK
https://bugs.webkit.org/show_bug.cgi?id=54212
- platform/gtk/Skipped:
- 7:50 AM Changeset in webkit [78223] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skip failing fast/text/atsui* tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=54210
- platform/gtk/Skipped:
- 7:47 AM Changeset in webkit [78222] by
-
- 4 edits40 adds in trunk
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186
Adding layout tests for feSpecularLighting dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularConstant-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularExponent-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-surfaceScale-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularConstant-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularExponent-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-surfaceScale-prop.js: Added. (executeTest):
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186
The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
- svg/SVGFESpecularLightingElement.h:
- 6:59 AM Changeset in webkit [78221] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skipping websocket tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=53683
- platform/gtk/Skipped:
- 6:54 AM Changeset in webkit [78220] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Error messages are not displayed for the last line in a script
https://bugs.webkit.org/show_bug.cgi?id=54204
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._createConditionElement):
- 6:47 AM Changeset in webkit [78219] by
-
- 24 edits in trunk/Source/WebCore
2011-02-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564
Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.
As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:
HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input,
meter, object, output, progress, and select.
WML: br, do, img, input, and select.
No new tests are added since this change cannot be tested directly.
- dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
- dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
- dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
- dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
- dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
- editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
- editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
- html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
- html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto.
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
- html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
- html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto.
- html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
- html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
- html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
- html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
- html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
- wml/WMLBRElement.h: (WebCore::WMLBRElement::canContainRangeEndPoint): Ditto.
- wml/WMLDoElement.h: (WebCore::WMLDoElement::canContainRangeEndPoint): Ditto.
- wml/WMLImageElement.h: (WebCore::WMLImageElement::canContainRangeEndPoint): Ditto.
- wml/WMLInputElement.h: (WebCore::WMLInputElement::canContainRangeEndPoint): Ditto.
- wml/WMLSelectElement.h: (WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto.
- 6:32 AM Changeset in webkit [78218] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Update GTK results after r78204
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- 6:20 AM Changeset in webkit [78217] by
-
- 5 edits4 copies2 adds in trunk/Tools
[Qt] Add UrlLoader and command line argument handling to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54192
Reviewed by Andreas Kling.
Copy and modify files from QtTestBrowser's implementation.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):
- MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
(WindowOptions::WindowOptions):
(MiniBrowserApplication::urls):
(MiniBrowserApplication::isRobotized):
(MiniBrowserApplication::robotTimeout):
(MiniBrowserApplication::robotExtraTime):
- MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
(UrlLoader::loadUrlList):
(UrlLoader::getUrl):
- MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h
- MiniBrowser/qt/main.cpp:
(main):
- MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
(urlFromUserInput):
- MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
- 6:18 AM Changeset in webkit [78216] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
- 6:14 AM Changeset in webkit [78215] by
-
- 3 edits in trunk/Tools
check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=54200
Reviewed by Andreas Kling.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 6:05 AM Changeset in webkit [78214] by
-
- 4 edits in trunk/LayoutTests
Update Windows results after r78204
- platform/win/fast/text/international/text-combine-image-test-expected.checksum:
- platform/win/fast/text/international/text-combine-image-test-expected.png:
- platform/win/fast/text/international/text-combine-image-test-expected.txt:
- 6:04 AM Changeset in webkit [78213] by
-
- 1 edit3 adds in trunk/LayoutTests
Update Windows results after r78182
Nikolas Zimmermann says he thinks we're not matching the Mac results anymore due to rounding
differences.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- 6:03 AM Changeset in webkit [78212] by
-
- 3 edits in trunk/Source/WebCore
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: define interface per domain in Inspector.idl.
https://bugs.webkit.org/show_bug.cgi?id=54135
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- 5:39 AM Changeset in webkit [78211] by
-
- 24 edits2 deletes in trunk
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- Source/cmake/WebKitFS.cmake:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- Android.mk:
- Android.v8.wtf.mk:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pro:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.order:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- pcre/AUTHORS: Removed.
- pcre/COPYING: Removed.
- pcre/dftables: Removed.
- pcre/pcre.h: Removed.
- pcre/pcre.pri: Removed.
- pcre/pcre_compile.cpp: Removed.
- pcre/pcre_exec.cpp: Removed.
- pcre/pcre_internal.h: Removed.
- pcre/pcre_tables.cpp: Removed.
- pcre/pcre_ucp_searchfuncs.cpp: Removed.
- pcre/pcre_xclass.cpp: Removed.
- pcre/ucpinternal.h: Removed.
- pcre/ucptable.cpp: Removed.
- wscript:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- ForwardingHeaders/pcre/pcre.h: Removed.
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- WebKit2.pro:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- wx/build/settings.py:
- 5:37 AM Changeset in webkit [78210] by
-
- 3 edits in trunk/Source/WebCore
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
https://bugs.webkit.org/show_bug.cgi?id=54098
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel.prototype._totalHeight): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.get height):
- inspector/front-end/textViewer.css: (.webkit-line-content):
- 5:24 AM Changeset in webkit [78209] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/text/midword-break-after-breakable-char.html on
GTK
- platform/gtk/Skipped:
- 5:15 AM Changeset in webkit [78208] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Add randomValuesFromOS for OS(WINDOWS)
https://bugs.webkit.org/show_bug.cgi?id=54155
Use CryptGenRandom for generating cryptographically secure random numbers.
This will work on WinCE and MinGW too.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 5:06 AM Changeset in webkit [78207] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-10 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] add WebIDBObjectStore::clear method
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::deleteFunction): (WebKit::WebIDBObjectStore::clear):
- 4:59 AM Changeset in webkit [78206] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/text/capitalize-boundaries.html on
GTK
- platform/gtk/Skipped:
- 4:52 AM Changeset in webkit [78205] by
-
- 3 edits in trunk/Tools
2011-02-10 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style should be able to figure out function modifiers and return type.
https://bugs.webkit.org/show_bug.cgi?id=54124
- Scripts/webkitpy/style/checkers/cpp.py: (_rfind_in_lines): A way to search backwards in lines. (_FunctionState.modifiers_and_return_type):
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
- 4:48 AM Changeset in webkit [78204] by
-
- 7 edits in trunk
2011-02-10 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169
Added a test for this bug to existing text-combine test.
- fast/text/international/text-combine-image-test.html:
- platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
- platform/mac/fast/text/international/text-combine-image-test-expected.png:
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
2011-02-10 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169
- rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
- Fixed by resetting font's orientation to horizontal when we decided to make combined text. Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.
- 4:46 AM Changeset in webkit [78203] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-10 Jarred Nicholls <jarred@sencha.com>
Reviewed by Adam Barth.
REGRESSION(r78149): Return value of read() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=54167
stdio read should have its return value handled. Build error in gcc 4.4.5.
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 4:42 AM Changeset in webkit [78202] by
-
- 2 edits in trunk/Source/WebCore
2011-02-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=50306
<rdar://problem/8976152> REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload()
uses an initialized result value (breaks form submission with clang-built WebKit)
No new test, because I can't reproduce the observable effect with my gcc build.
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an empty path check - an empty path was causing an exception in Foundation.
- 4:41 AM Changeset in webkit [78201] by
-
- 2 edits in trunk/Source/WebKit2
Turn on the new drawing area on Windows
Fixes <http://webkit.org/b/53805> <rdar://problem/8960666> WebKit2 on Windows should use
DrawingAreaProxyImpl
Reviewed by Darin Adler.
- UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Return true!
- 4:40 AM Changeset in webkit [78200] by
-
- 4 edits1 add in trunk
Hook up WM_PRINT to the new drawing area
Fixes <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)
Reviewed by Darin Adler.
Source/WebKit2:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::paint): Added. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent):
(WebKit::WebView::onPrintClientEvent):
Changed to call paint.
- UIProcess/win/WebView.h: Added paint. Also separated message handler functions into their
own paragraph.
Tools:
Test that WM_PRINT doesn't trigger an assertion
- TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
(TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.
- 4:40 AM Changeset in webkit [78199] by
-
- 4 edits in trunk
Notice when the backing store goes away after DidSetSize
Fixes <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden
Reviewed by Darin Adler.
Source/WebKit2:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): Null-check m_backingStore after waiting for
DidSetSize, as m_backingStore can go away when we receive that message. This is the bug fix.
Also moved the accelerated compositing check inside the block where we wait for DidSetSize.
If we didn't wait for DidSetSize, we already know that we're not in accelerated compositing
mode (and asserted so earlier in this function).
Tools:
Test that having a WKView paint after being resized while hidden doesn't cause a crash
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
(TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.
- 4:39 AM Changeset in webkit [78198] by
-
- 5 edits1 add in trunk
Decode a null SharedMemory::Handle correctly on Windows
Fixes <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
performs badly if is resized while hidden (assertion fails in
BackingStore::incorporateUpdate in Debug builds)
Reviewed by Darin Adler.
Source/WebKit2:
- Platform/win/SharedMemoryWin.cpp:
(WebKit::getDuplicatedHandle): Added. Code came from decode. The only changes were to
null-check sourceHandle (this is the bug fix) and to assert when ::DuplicateHandle fails
(which would have caught the bug earlier).
(WebKit::SharedMemory::Handle::decode): Changed to use getDuplicatedHandle.
Tools:
Add a test that resizes a WKView while it's hidden
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
(TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
that all pending messages have been handled by the UI and web process.
(TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
(TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
(TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
chance to display, then flush all pending messages.
(TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
the backing store to update. This triggers the assertion from bug 54141.
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::resizeTo): Implemented.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
- 4:38 AM Changeset in webkit [78197] by
-
- 2 edits in trunk/Source/WebKit2
Don't invalidate outside of the WebPage's bounds
Fixes <http://webkit.org/b/54123> <rdar://problem/8978383> Assertion failure in
BackingStore::BackingStore if a new WebPage becomes active before receiving a size
Reviewed by Darin Adler.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay): Intersect the dirty rect with our bounds before
doing anything else.
(WebKit::DrawingAreaImpl::display): Added an assertion to help catch the bad case a little
earlier.
- 4:36 AM Changeset in webkit [78196] by
-
- 6 edits in trunk/Source/WebCore
2011-02-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Network & Resource panels make multiple requests for images with no content
https://bugs.webkit.org/show_bug.cgi?id=54085
- Added success parameter to resourceContent
- NetworkManager.requestContent() now returns empty for zero-length resources, null for errors
- inspector/Inspector.idl:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::resourceContent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._contentURL):
- 4:26 AM Changeset in webkit [78195] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-10 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Rename randomValuesFromOS to cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=54156
randomValuesFromOS generates random numbers of cryptographic quality.
Make this clear by adding "cryptographically" to the function name.
- wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::stir):
- wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
- wtf/OSRandomSource.h:
- 4:23 AM Changeset in webkit [78194] by
-
- 9 edits3 adds in trunk/Source/WebCore
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
Move the light source implementations into their own files.
https://bugs.webkit.org/show_bug.cgi?id=53996
Splitting LightSource.cpp into 3 files.
No new tests are added since this is a refactoring.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/DistantLightSource.cpp: Added. (WebCore::DistantLightSource::initPaintingData): (WebCore::DistantLightSource::updatePaintingData): (WebCore::DistantLightSource::setAzimuth): (WebCore::DistantLightSource::setElevation): (WebCore::DistantLightSource::externalRepresentation):
- platform/graphics/filters/LightSource.cpp:
- platform/graphics/filters/PointLightSource.cpp: Added. (WebCore::PointLightSource::initPaintingData): (WebCore::PointLightSource::updatePaintingData): (WebCore::PointLightSource::setX): (WebCore::PointLightSource::setY): (WebCore::PointLightSource::setZ): (WebCore::operator<<): (WebCore::PointLightSource::externalRepresentation):
- platform/graphics/filters/SpotLightSource.cpp: Added. (WebCore::SpotLightSource::initPaintingData): (WebCore::SpotLightSource::updatePaintingData): (WebCore::SpotLightSource::setX): (WebCore::SpotLightSource::setY): (WebCore::SpotLightSource::setZ): (WebCore::SpotLightSource::setPointsAtX): (WebCore::SpotLightSource::setPointsAtY): (WebCore::SpotLightSource::setPointsAtZ): (WebCore::SpotLightSource::setSpecularExponent): (WebCore::SpotLightSource::setLimitingConeAngle): (WebCore::operator<<): (WebCore::SpotLightSource::externalRepresentation):
- 4:07 AM Changeset in webkit [78193] by
-
- 8 edits in trunk/Source
2011-02-10 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::updateFromElement):
- platform/chromium/PopupMenuChromium.h:
2011-02-10 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.
- public/WebMenuItemInfo.h:
- public/WebPopupMenuInfo.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
- src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo):
- 3:58 AM Changeset in webkit [78192] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-10 kasthuri <kasthuri.n-s@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QWebFrame::setHtml doesn't emit loadFinished signal
https://bugs.webkit.org/show_bug.cgi?id=38634
QWebView->page()->mainFrame()->setHtml(html) is always emitting
the loadFinished() signal for all types of html files.
But the proposed test content was trying to catch the signal after
calling setHtml() api and becuase of this the emitted signal for a
simple html page is never caught as its emitted before even the connect
call was successful.
updated the tst_QWebFrame::setHtml() in tst_qwebframe.cpp to check for
signal using the QSignalSpy.
- tests/qwebframe/tst_qwebframe.cpp:
- 3:54 AM Changeset in webkit [78191] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/replaced/border-radius-clip.html on GTK
- platform/gtk/Skipped:
- 3:39 AM Changeset in webkit [78190] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Regenerate result with a 64bit SL machine.. a pity that we have diffs there.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- 3:11 AM Changeset in webkit [78189] by
-
- 29 edits in trunk/LayoutTests
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Update mac-leopard/qt baselines after r78182.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- 3:06 AM Changeset in webkit [78188] by
-
- 15 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated svg GTK baselines after r78182.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
- 3:02 AM Changeset in webkit [78187] by
-
- 6 edits in trunk
2011-02-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102
Update test to reflect the new semantics.
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
2011-02-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102
Update the semantics of put: For object stores with auto increment,
it should be allowed to provide an explicit key, or an in-line key,
overriding the key generator mechanism.
This reflects the spec changes suggested here:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11976
Extracting key-selection logic into its own function
to make it a bit easier on the eyes.
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut): (WebCore::IDBObjectStoreBackendImpl::putInternal):
- storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::resetAutoIncrementKeyCache):
- 2:51 AM Changeset in webkit [78186] by
-
- 2 edits in trunk/Tools
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix after roll out of r78157...
- GNUmakefile.am:
- 2:49 AM Changeset in webkit [78185] by
-
- 7 edits3 deletes in trunk
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Removed.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Removed.
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): (WebKit::PluginView::evaluate):
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 2:44 AM Changeset in webkit [78184] by
-
- 2 edits in trunk/Tools
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
https://bugs.webkit.org/show_bug.cgi?id=54185
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 2:43 AM Changeset in webkit [78183] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=54103
Implement fast path for matching simple selectors
Reviewed by Darin Adler.
Implement a fast path for single and descendant selectors consisting
of id, class and tag selectors only.
Selectors like this are marked on style selector initialization. When
encountered during style matching they are resolved using a fast path.
Since selectors like this are very common this speeds up style matching
quite a bit (up to 50% on some sites according to Shark).
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasTopSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::selectorTagMatches):
(WebCore::isFastCheckableSelector):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::RuleData):
- css/CSSStyleSelector.h:
- 2:25 AM Changeset in webkit [78182] by
-
- 90 edits1 delete in trunk/LayoutTests
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Maciej Stachowiak.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Fix wrong xlink:hrefs in dozens of SVG testcases. SVGFreeSans.svg is now used in more places.
Remove unnecessary xml-stylesheet declarations, and unneeded text css attributes in some places.
Updated pixel test results for the affected testcases.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.checksum:
- platform/mac/svg/batik/filters/feTile-expected.png:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/mask-with-shadow-expected.checksum:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/text/text-tref-01-b-expected.checksum:
- platform/mac/svg/text/text-tref-01-b-expected.png:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg:
- svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-01-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-03-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-05-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-07-f.svg:
- svg/W3C-SVG-1.1/filters-light-04-f.svg:
- svg/W3C-SVG-1.1/filters-turb-02-f.svg:
- svg/W3C-SVG-1.1/resources/interact-order-02-b-targ.svg:
- svg/W3C-SVG-1.1/resources/interact-order-03-b-targ.svg:
- svg/W3C-SVG-1.1/resources/linkingToc-t.svg:
- svg/batik/filters/feTile.svg:
- svg/css/circle-in-mask-with-shadow.svg:
- svg/css/mask-with-shadow.svg:
- svg/custom/image-clipped-hit.svg:
- svg/foreignObject/text-tref-02-b.svg:
- svg/hixie/cascade/002.css: Removed.
- svg/text/text-tref-01-b.svg:
- svg/transforms/animated-path-inside-transformed-html.xhtml:
- svg/zoom/page/zoom-mask-with-percentages.svg:
- svg/zoom/page/zoom-zoom-coords.xhtml:
- 2:04 AM Changeset in webkit [78181] by
-
- 4 edits in trunk
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed GTK build fix.
Adding
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
in the build, fixing the
plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
test.
- GNUmakefile.am:
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, typo fix.
- platform/gtk/Skipped:
- 1:29 AM Changeset in webkit [78180] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test.
- platform/gtk/Skipped: Skip fast/events/focusingUnloadedFrame.html
- 1:03 AM Changeset in webkit [78179] by
-
- 6 edits in trunk/Tools
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Add support in DRT to log "accessibility events"
https://bugs.webkit.org/show_bug.cgi?id=54116
Added a way to log accessibility related events, in a
platform-dependant way.
Add new function to AccessibilityController.
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityController.cpp: (logAccessibilityEventsCallback): New callback. (AccessibilityController::getJSClass): Added new function. (AccessibilityController::resetToConsistentState): Initialized calling setLogAccessibilityEvents(false).
Provided implementation for the GTK port.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (accessibility_event_listener): Common listener for logging information about all the signals emitted by any AtkObject. (AccessibilityController::setLogAccessibilityEvents): Add or remove listeners for signals, as specified by the parameter.
Provide dummy implementations for mac and win ports.
- DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::setLogAccessibilityEvents):
- DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::setLogAccessibilityEvents):
- 1:00 AM Changeset in webkit [78178] by
-
- 2 edits in trunk/LayoutTests
2011-02-10 Shinichiro Hamaji <hamaji@chromium.org>
Chromium expectations update.
fast/box-shadow/shadow-buffer-partial.html is failing.
- platform/chromium/test_expectations.txt:
- 12:09 AM Changeset in webkit [78177] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Skip newly added test that depends on unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54172
- platform/mac-wk2/Skipped:
Feb 9, 2011:
- 11:13 PM Changeset in webkit [78176] by
-
- 3 edits in trunk/Source/JavaScriptCore
<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face of errors from the memory reader.
Reviewed by Sam Weinig.
- wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::recordAdministrativeRegions): Use the new helper function to walk the linked list safely.
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMallocStats::PageMapFreeObjectFinder::visit): Bail out if the span could not be read.
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit): Ditto.
- wtf/MallocZoneSupport.h:
(WTF::RemoteMemoryReader::operator()): Remove an assert that is not valid.
(WTF::RemoteMemoryReader::nextEntryInLinkedList): Add a helper function for retrieving the next entry in
a linked list. It maps a failed read of the remote memory in to a null pointer, which all callers can
handle gracefully.
- 9:31 PM Changeset in webkit [78175] by
-
- 3 edits in trunk/Tools
2011-02-09 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Remove encoding parameters where we can assume data can be
written in binary mode.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- 9:21 PM Changeset in webkit [78174] by
-
- 4 edits in trunk/Source/JavaScriptCore
Bug 54164 - Optimize global_var accesses on JSVALUE64
Reviewed by Sam Weinig.
Directly embed the pointer to d->registers, optimize out the load
from the variable object, as we do already in JSVALUE32_64.
This is a ~1.5% win on sunspidey.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
- 9:15 PM Changeset in webkit [78173] by
-
- 3 edits4 adds in trunk
2011-02-09 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
REGRESSION (r77101) box-shadow sometimes renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54160
Fix an issue when ShadowBlur had a cached image buffer
that was larger than that of the current shadow being drawn,
and the current shadow was partially clipped out.
In that situation endShadowLayer() would clip to the image
buffer, using the size of the buffer (as it must), but failed
to take into account the fact that we'd only cleared and painted
into a smaller section of the buffer. So we need to additionally
constrain the clip to cover only the valid part of the buffer.
Test: fast/box-shadow/shadow-buffer-partial.html
- platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::endShadowLayer):
- 7:37 PM Changeset in webkit [78172] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; removed Windows port's expected result for r78104.
- platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- 7:07 PM Changeset in webkit [78171] by
-
- 2 edits in trunk/Source/WebCore
Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364
Reviewed by Maciej Stachowiak.
The ScrollbarPartAnimation must be sent by reference!
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- 6:21 PM Changeset in webkit [78170] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fixed up ChangeLog after my last commit
- 6:20 PM Changeset in webkit [78169] by
-
- 7 edits in trunk/Source/JavaScriptCore
2011-02-09 Adam Barth <abarth@webkit.org>
Another attempt to fix the Qt Windows build.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 6:14 PM Changeset in webkit [78168] by
-
- 5 edits2 adds in trunk
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.
Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.
Test: fast/forms/file-input-hit-test.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.
- fast/forms/file-input-hit-test-expected.txt: Added.
- fast/forms/file-input-hit-test.html: Added.
- 5:55 PM Changeset in webkit [78167] by
-
- 3 edits in trunk/Source/WebCore
Overlay scrollbars crash used with a RenderListBox.
Reviewed by Beth Dakin.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):
- rendering/RenderListBox.h:
Implement enough of the ScrollableArea interface to get things generally
working.
- 5:30 PM Changeset in webkit [78166] by
-
- 4 edits2 adds in branches/chromium/597
Merge r77114
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.
Test: fast/forms/dangling-form-element-crash.html
- html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
- html/HTMLFormControlElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds a test that ensures dangling form associated elements are not
registered on the document.
- fast/forms/dangling-form-element-crash-expected.txt: Added.
- fast/forms/dangling-form-element-crash.html: Added.
BUG=crbug.com/70078
TBR=inferno@chromium.org
- 5:28 PM Changeset in webkit [78165] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in WebSecurityOrigin::protocol.
Rubber-stamped by Sam Weinig.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::protocol): This should return the protocol, not the domain.
- 5:26 PM Changeset in webkit [78164] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 5:17 PM Changeset in webkit [78163] by
-
- 5 edits in trunk/Source/WebKit2
File uploads do not work within the sandbox
<rdar://problem/8950518>
https://bugs.webkit.org/show_bug.cgi?id=54154
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendSandboxForFileFromOpenPanel):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:28 PM Changeset in webkit [78162] by
-
- 8 edits in trunk/Source/WebCore
Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing
Reviewed by Simon Fraser.
New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderListBox.h:
Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate layer]):
- 4:24 PM Changeset in webkit [78161] by
-
- 3 edits in trunk/Source/WebKit2
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=54148
<rdar://problem/8973887> REGRESSION (WebKit2): Opening two print dialogs causes havoc
- UIProcess/API/mac/WKPrintingView.h: Moved _isForcingPreviewUpdate into a static variable, because dispatching a notification affects all WKPrintingViews at once.
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _updatePreview]): Updated for new variable name. (-[WKPrintingView knowsPageRange:]): Don't break if the method is called twice in a row (we already had this logic when printing from separate thread, but not for preview). (-[WKPrintingView drawRect:]): Changed all LOG messages to have view object address for easier matching. (-[WKPrintingView rectForPage:]): Ditto. (-[WKPrintingView beginDocument]): Ditto. (-[WKPrintingView endDocument]): Ditto.
- 4:24 PM Changeset in webkit [78160] by
-
- 5 edits in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few tests which differ on the bots. Skip a test which is
timing out intermittently.
- platform/gtk/Skipped: Skip a test timing out.
- platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
- platform/gtk/fast/dom/52776-expected.txt:
- platform/gtk/fast/text/stroking-decorations-expected.txt:
- 4:09 PM Changeset in webkit [78159] by
-
- 3 edits in trunk/Tools
2011-02-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt multiprocessing: minor cleanup prior to implementing the new worker
This patch renames AbstractManager to ManagerConnection and
changes some argument names to be more consistent between
manager_worker_broker and message_broker. It also fixes a couple
of typos in message_broker. These changes will be tested by code
introduced in the next patch.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
- 3:53 PM Changeset in webkit [78158] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-09 Adam Barth <abarth@webkit.org>
Another attempt to fix the Qt Windows build.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 3:47 PM Changeset in webkit [78157] by
-
- 7 edits3 adds in trunk
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.
(WebKit::PluginView::evaluate):
Add a plug-in protector.
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Add test.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Added.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Added.
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 3:35 PM Changeset in webkit [78156] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-09 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt Windows build.
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 3:33 PM Changeset in webkit [78155] by
-
- 5 edits2 copies in branches/chromium/648
Merge 77114
BUG=70078
Review URL: http://codereview.chromium.org/6476015
- 3:25 PM Changeset in webkit [78154] by
-
- 2 edits2 deletes in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list a bit and unskip a few tests which are passing.
- platform/gtk/Skipped: Clean up the skipped list.
- platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
- 3:23 PM Changeset in webkit [78153] by
-
- 2 edits2 copies in branches/chromium/648
Merge 76732
BUG=70779
Review URL: http://codereview.chromium.org/6471009
- 3:17 PM Changeset in webkit [78152] by
-
- 3 edits2 adds in branches/chromium/597
Merge 77468, crbug 69640
- 3:14 PM Changeset in webkit [78151] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77468
BUG=69640
Review URL: http://codereview.chromium.org/6483007
- 3:13 PM Changeset in webkit [78150] by
-
- 31 edits in trunk/Source/WebCore
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Replace static_cast<HTMLElement*> with toHTMLElement
https://bugs.webkit.org/show_bug.cgi?id=54117
No new tests since no new functionality was introduced.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren):
- accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::addChildren):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::accessibleNameForNode): (WebCore::AccessibilityRenderObject::accessibilityDescription):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::toV8):
- dom/Document.cpp: (WebCore::Document::body):
- dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
- dom/Range.cpp: (WebCore::Range::createContextualFragment):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::shouldSplitTextElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::show):
- editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::mergeWithNeighboringLists):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
- editing/SelectionController.cpp: (WebCore::scanForForm): (WebCore::SelectionController::currentForm):
- editing/htmlediting.cpp: (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::embeddedSublist): (WebCore::appendedSublist):
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
- html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterHTML): (WebCore::HTMLElement::shadowAncestorOwnerForm):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
- rendering/RenderMeter.cpp: (WebCore::RenderMeter::createPart):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- 3:11 PM Changeset in webkit [78149] by
-
- 10 edits4 adds in trunk/Source/JavaScriptCore
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add WTF::cryptographicallyRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=54083
Introduce a cryptographically strong random number generator to WTF.
The random number generator is based on arc4random as found in:
http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.22
I've changed to source to WebKit style and abstracted the operating
system interaction to OSRandomSource. We'll use this functionality to
expose a cryptographically strong random number generator to
JavaScript.
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- config.h:
- wtf/CMakeLists.txt:
- wtf/CryptographicallyRandomNumber.cpp: Added. (WTF::initMutexIfNeeded): (WTF::init): (WTF::addRandomData): (WTF::stir): (WTF::stirIfNeeded): (WTF::getByte): (WTF::getWord): (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomValues):
- wtf/CryptographicallyRandomNumber.h: Added.
- wtf/OSRandomSource.cpp: Added. (WTF::randomValuesFromOS):
- wtf/OSRandomSource.h: Added.
- wtf/wtf.pri:
- 3:10 PM Changeset in webkit [78148] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
handles the case when the device is backed by the GPU.
Patch developed by bsalomon@google.com
No new tests. Existing canvas tests suffice
e.g. LayoutTests/canvas/philip/...
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- 3:07 PM Changeset in webkit [78147] by
-
- 8 edits10 adds in trunk
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689
Tests for various cases involving document.open/write/close. Not all
of them are related to this patch, but they were helpful to me in
working through this patch, so I've added them in case they're useful
in the future.
- fast/frames/document-write-in-iframe-onload-3-expected.txt: Added.
- fast/frames/document-write-in-iframe-onload-3.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-2-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script-2.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-3-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script-3.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script.html: Added.
- fast/parser/setTimeout-open-expected.txt: Added.
- fast/parser/setTimeout-open.html: Added.
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689
Tests: fast/frames/document-write-in-iframe-onload-3.html
fast/parser/iframe-onload-document-close-with-external-script-2.html
fast/parser/iframe-onload-document-close-with-external-script-3.html
fast/parser/iframe-onload-document-close-with-external-script.html
fast/parser/setTimeout-open.html
Move our implementation of document.close closer to the spec by
introducing the notion of a script-created parser. This area of our
code is somewhat hairy. It might take a few more iterations before we
fully come up to spec.
- dom/Document.cpp:
(WebCore::Document::setContent):
(WebCore::Document::open):
(WebCore::Document::cancelParsing):
(WebCore::Document::close):
- Over time, this method should converge to the spec.
(WebCore::Document::explicitClose):
- I'm not in love with this name. Somehow we want to differentiate between Document closing itself and the document.close DOM method.
(WebCore::Document::removePendingSheet):
- dom/Document.h:
- dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
- dom/ScriptableDocumentParser.h:
(WebCore::ScriptableDocumentParser::setWasCreatedByScript):
(WebCore::ScriptableDocumentParser::wasCreatedByScript):
- General nonsense to keep track of whether the parser was created by script.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::hasInsertionPoint):
- I'm not sure whether this part of the change is 100% correct. I think our notion of the EOF character might be subtly different from the notion in the spec.
- html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::hasInsertionPoint):
- Remove FIXME because we're fixing that!
- 3:03 PM Changeset in webkit [78146] by
-
- 2 edits339 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Import the last set of GTK+ baselines in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 3:02 PM Changeset in webkit [78145] by
-
- 3 edits in trunk/Source/WebKit2
Google Maps says it has horizontal scrollbars when it doesn't
<rdar://problem/8978005>
Reviewed by Maciej Stachowiak.
We were updating the main frame's scrollbar state for changes to
frames other than the main frame.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Change to bail out early if we are not looking at the main frame. Also
fix some silly typos and rename the variables to be more specific.
- 2:53 PM Changeset in webkit [78144] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-02-09 David Holloway <dhollowa@chromium.org>
Reviewed by Darin Fisher.
Removes deprecated interface WebAutoFillClient::didAcceptAutocompleteSuggestion(). This interface has been replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion() method.
https://bugs.webkit.org/show_bug.cgi?id=54125
- public/WebAutoFillClient.h:
- src/EditorClientImpl.cpp:
- src/EditorClientImpl.h:
- 2:41 PM Changeset in webkit [78143] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=54132
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::resizeLayer):
- 2:40 PM Changeset in webkit [78142] by
-
- 2 edits996 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 2:39 PM Changeset in webkit [78141] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77914
BUG=70442
Review URL: http://codereview.chromium.org/6480008
- 2:37 PM Changeset in webkit [78140] by
-
- 4 edits2 copies in branches/chromium/648
Merge 76652
BUG=70442
Review URL: http://codereview.chromium.org/6482007
- 2:36 PM Changeset in webkit [78139] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-02-09 Ilya Sherman <isherman@chromium.org>
Reviewed by Darin Fisher.
Export WebInputElement::defaultMaxLength as a function rather than a constant.
Needed because the order of initialization of static constants
is not guaranteed across compilation units.
https://bugs.webkit.org/show_bug.cgi?id=54056
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Now a static function.
- 2:25 PM Changeset in webkit [78138] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed.
Remove unnecessary Qt specific expected results after r78104.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Removed.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Removed.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- 2:23 PM Changeset in webkit [78137] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Use #f7f7f7 for select popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=54115
No new tests since no behavior change.
- css/themeChromiumLinux.css: (select[size="1"] option):
- 2:18 PM Changeset in webkit [78136] by
-
- 3 edits2 adds in branches/chromium/597
Merge r77548, crbug 71296
- 2:16 PM Changeset in webkit [78135] by
-
- 3 edits in trunk/Source/WebKit/qt
2011-02-09 Robert Hogan <robert@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] REGRESSION (r73535): tst_QWebPage fails
https://bugs.webkit.org/show_bug.cgi?id=51331
Since r73535 a ContextMenu is only created when a context menu
event is received, so QWebPage::updatePositionDependentActions()
can't depend on one being there if it is called directly by
the client. QtWebKit itself only ever calls updatePositionDependentActions()
when a context menu event has been received.
Update tst_QWebPage:contextMenuCrash to create a context menu.
Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash.
There doesn't seem to be a good reason for creating a context menu if
clients call QWebPage::updatePositionDependentActions() when no
context menu event has ever been received.
- Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCrash):
- 2:16 PM Changeset in webkit [78134] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77548
BUG=71296
Review URL: http://codereview.chromium.org/6483004
- 2:13 PM Changeset in webkit [78133] by
-
- 3 edits2 adds in branches/chromium/597
- 2:13 PM Changeset in webkit [78132] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:10 PM Changeset in webkit [78131] by
-
- 1 edit in branches/chromium/648/Source/WebCore/rendering/RenderBlock.cpp
Merge 77573
BUG=71855
Review URL: http://codereview.chromium.org/6482006
- 2:09 PM Changeset in webkit [78130] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77565
BUG=71855
Review URL: http://codereview.chromium.org/6480006
- 2:04 PM Changeset in webkit [78129] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:02 PM Changeset in webkit [78128] by
-
- 2 edits876 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 1:53 PM Changeset in webkit [78127] by
-
- 4 edits in trunk/Source/WebCore
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
https://bugs.webkit.org/show_bug.cgi?id=41187
Wire up a basic HTML parse error message. There's a lot of room for
improvement in this area, but this is a start.
No tests! See https://bugs.webkit.org/show_bug.cgi?id=54134
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
- html/parser/HTMLTreeBuilder.h:
- 1:36 PM Changeset in webkit [78126] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-09 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Allow read-only access to mouse preferences from sandboxed WebProcess.
<rdar://problem/8975279>
- WebProcess/com.apple.WebProcess.sb:
- 1:36 PM Changeset in webkit [78125] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77141
BUG=71114
Review URL: http://codereview.chromium.org/6478004
- 1:23 PM Changeset in webkit [78124] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 1:17 PM Changeset in webkit [78123] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77262
BUG=71386
Review URL: http://codereview.chromium.org/6476009
- 1:15 PM Changeset in webkit [78122] by
-
- 2 edits595 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.
- platform/gtk/Skipped: Unskip test with results. Classify failures.
- 1:15 PM Changeset in webkit [78121] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77144
BUG=71388
Review URL: http://codereview.chromium.org/6480004
- 1:09 PM Changeset in webkit [78120] by
-
- 3 edits in branches/chromium/648
Merge 77433
BUG=71734
Review URL: http://codereview.chromium.org/6469012
- 1:06 PM Changeset in webkit [78119] by
-
- 3 edits in tags/Safari-534.18.1/Source/WebKit2
Merge r78116.
- 1:05 PM Changeset in webkit [78118] by
-
- 4 edits2 copies in branches/chromium/648
Merge 77418
BUG=71595
Review URL: http://codereview.chromium.org/6476007
- 1:02 PM Changeset in webkit [78117] by
-
- 4 edits2 copies in branches/chromium/648
Merge 76990
BUG=68120
Review URL: http://codereview.chromium.org/6469011
- 12:59 PM Changeset in webkit [78116] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- win/MainWin.cpp:
(wWinMain):
- 12:59 PM Changeset in webkit [78115] by
-
- 1 edit2 copies in branches/chromium/648
Merge 76708
BUG=67234
Review URL: http://codereview.chromium.org/6483002
- 12:57 PM Changeset in webkit [78114] by
-
- 5 edits in branches/chromium/648
Merge 78077 - 2011-02-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.
2011-02-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
boundary of shadow DOM.
(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.
TBR=Dimitri Glazkov
Review URL: http://codereview.chromium.org/6469009
- 12:56 PM Changeset in webkit [78113] by
-
- 1 edit3 copies in branches/chromium/648
Merge 76915
BUG=71115
Review URL: http://codereview.chromium.org/6471003
- 12:52 PM Changeset in webkit [78112] by
-
- 2 edits2 copies in branches/chromium/648
Merge 76828
BUG=68741
Review URL: http://codereview.chromium.org/6469008
- 12:50 PM Changeset in webkit [78111] by
-
- 2 edits5 adds in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:50 PM Changeset in webkit [78110] by
-
- 6 edits2 copies in branches/chromium/648
Merge 76728
BUG=68263
Review URL: http://codereview.chromium.org/6483001
- 12:46 PM Changeset in webkit [78109] by
-
- 1 edit in branches/chromium/648/Source/WebCore/svg/SVGFont.cpp
Merge 77766
BUG=72134
Review URL: http://codereview.chromium.org/6471002
- 12:22 PM Changeset in webkit [78108] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the build.
- wtf/Bitmap.h: Include string.h for memset. Not sure why this started
failing now.
- 12:15 PM Changeset in webkit [78107] by
-
- 1 edit1 move in trunk
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Steve Block.
Move Android.mk into Source
https://bugs.webkit.org/show_bug.cgi?id=53751
A somewhat blind attempt to move Android.mk into the Source directory.
I'm sure I've goofed this up in some way. The Android folks have
kindly volunteered to fix this up once they merge past this revision.
- Android.mk: Removed.
- Source/Android.mk: Copied from Android.mk.
- 12:15 PM Changeset in webkit [78106] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-02-09 Sailesh Agrawal <sail@chromium.org>
Reviewed by Tony Chang.
Search/replace references to gfx/* with ui/gfx/*
- public/WebPoint.h:
- public/WebRect.h:
- public/WebSize.h:
- 12:09 PM Changeset in webkit [78105] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A tiny bit of encapsulation for MarkedBlock: made its heap data member private
https://bugs.webkit.org/show_bug.cgi?id=54129
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::heap): Made the heap data member private, and provided a constructor and an accessor.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::heap): Use the constructor and accessor.
- 12:08 PM Changeset in webkit [78104] by
-
- 3 edits in trunk/LayoutTests
2011-02-09 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Fixed the new test introduced in the previous patch for the same bug. Previous test isn't platform independent, and fails on all platforms other than Mac OS X with WebKit 1.
- editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt:
- editing/undo/undo-paste-when-caret-is-not-in-range.html:
- 12:06 PM Changeset in webkit [78103] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kenneth Russell.
[Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53757
This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software. (WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
- 12:03 PM Changeset in webkit [78102] by
-
- 6 edits in trunk/Source/WebCore
2011-02-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix scaling and thread safety of FFTFrameFFTW
https://bugs.webkit.org/show_bug.cgi?id=54045
No new tests since audio API is not yet implemented.
- platform/audio/FFTFrame.h:
- platform/audio/fftw/FFTFrameFFTW.cpp: (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
- platform/audio/mac/FFTFrameMac.cpp: (WebCore::FFTFrame::initialize):
- platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::initialize):
- webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
- 11:57 AM Changeset in webkit [78101] by
-
- 8 edits2 adds in branches/chromium/597
Merge r76728, crbug 68263
- 11:54 AM Changeset in webkit [78100] by
-
- 3 edits in trunk/Tools
2011-02-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: The error message about NULL should be more clear for comments.
https://bugs.webkit.org/show_bug.cgi?id=53786
- Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
- 11:52 AM Changeset in webkit [78099] by
-
- 3 edits2 adds in branches/chromium/597
Merge 77141, crbug 71114
- 11:49 AM Changeset in webkit [78098] by
-
- 3 edits in trunk/Source/WebCore
AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
https://bugs.webkit.org/show_bug.cgi?id=54126
Reviewed by Darin Adler.
This is a Mac-only accessibility API concept and doesn't belong in the core AX object.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::node):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
- 11:48 AM Changeset in webkit [78097] by
-
- 2 edits589 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.
- platform/gtk/Skipped: Unskip some tests that now have results.
- 11:46 AM Changeset in webkit [78096] by
-
- 3 edits2 adds in branches/chromium/597
Merge r77262, crbug 71386
- 11:43 AM Changeset in webkit [78095] by
-
- 16 edits3 adds in trunk
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- fast/js/i18n-bindings-locale-expected.txt: Added.
- fast/js/i18n-bindings-locale.html: Added.
- fast/js/script-tests/i18n-bindings-locale.js: Added. (reportResult): (localeTests.this.defaultLocale): (localeTests.this.baseLocale): (localeTests.this.languageScriptLocale): (localeTests.this.languageScriptRegionLocale): (localeTests.this.languageScriptRegionExtensionLocale): (localeTests.this.languageScriptRegionDashUExtensionLocale): (localeTests.this.availableLocales): (localeTests.this.maximizedLocale): (localeTests.this.maximizedLocaleWithExtension): (localeTests.this.minimizedLocale): (localeTests.this.minimizedLocaleWithExtension): (localeTests.this.displayForBaseLocale): (localeTests.this.displayInSameLocale): (localeTests.this.displayInDifferentLocale): (localeTests.this.displayInCyrillicScript): (localeTests.this.displayInHebrewScript): (localeTests):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
Test: fast/js/i18n-bindings-locale.html
- WebCore.gyp/WebCore.gyp:
- bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableExperimentalI18NAPI): (WebKit::WebRuntimeFeatures::isExperimentalI18NAPIEnabled):
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- 11:42 AM Changeset in webkit [78094] by
-
- 3 edits2 adds in branches/chromium/597
Merge r77144, crbug 71388
- 11:38 AM Changeset in webkit [78093] by
-
- 5 edits in branches/chromium/597
Merge r77433, crbug 71734
- 11:35 AM Changeset in webkit [78092] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, fix a bug in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 11:32 AM Changeset in webkit [78091] by
-
- 2 edits in branches/chromium/597/WebCore
Merge r77766, crbug 72134
- 11:27 AM Changeset in webkit [78090] by
-
- 6 edits2 adds in branches/chromium/597
Merge r77418, crbug 71595
- 11:23 AM Changeset in webkit [78089] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-09 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for chromium-mac after r77952.
Added chromium-mac baseline due to fallback sequence.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:19 AM Changeset in webkit [78088] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 11:15 AM Changeset in webkit [78087] by
-
- 3 edits2 adds in branches/chromium/597
Merge r76915, crbug 71115
- 11:09 AM Changeset in webkit [78086] by
-
- 2 adds in branches/chromium/597/LayoutTests/fast/css
Merge r76828, bug 68741, layouttests
- 11:06 AM Changeset in webkit [78085] by
-
- 3 edits1 delete in trunk/LayoutTests
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Martin Robinson.
frames/flattening/iframe-flattening-crash.html fails on GTK.
https://bugs.webkit.org/show_bug.cgi?id=54106
Modify the test to be more consistent with other frame flattening tests.
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/resources/iframe-flattening-crash.html: Removed.
- platform/gtk/Skipped:
- 11:05 AM Changeset in webkit [78084] by
-
- 4 edits in branches/chromium/597
Merge r76828, bug 68741
- 10:54 AM Changeset in webkit [78083] by
-
- 2 edits in tags/Safari-534.18.1/Source/WebCore
Merge r78045.
- 10:50 AM Changeset in webkit [78082] by
-
- 1 edit3 adds in trunk/LayoutTests
Add failing Windows expected results for tests that were added recently and have failed since
they were added.
https://bugs.webkit.org/show_bug.cgi?id=54120 tracks editing/undo/undo-paste-when-caret-is-not-in-range.html
https://bugs.webkit.org/show_bug.cgi?id=54122 tracks plugins/invalidate_rect.html
- platform/win/editing/undo: Added.
- platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- platform/win/plugins/invalidate_rect-expected.txt: Added.
- 10:48 AM Changeset in webkit [78081] by
-
- 5 edits in tags/Safari-534.18.1/Source
Versioning.
- 10:41 AM Changeset in webkit [78080] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations.
- platform/chromium/test_expectations.txt:
- 10:38 AM Changeset in webkit [78079] by
-
- 3 edits445 adds in trunk
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add more results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip more tests.
- 10:04 AM Changeset in webkit [78078] by
-
- 1 copy in tags/Safari-534.18.1
New tag.
- 10:03 AM Changeset in webkit [78077] by
-
- 5 edits in trunk
2011-02-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.
2011-02-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
boundary of shadow DOM.
(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.
- 10:03 AM Changeset in webkit [78076] by
-
- 2 edits448 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add more results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip tests that now have results.
- 10:00 AM Changeset in webkit [78075] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 9:52 AM Changeset in webkit [78074] by
-
- 3 edits1 copy in trunk/Source/WebKit2
2011-02-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Implement Module class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
- GNUmakefile.am:
- Platform/Module.h: Added GModule handle for GTK port.
- Platform/gtk/ModuleGtk.cpp: Initial code using GModule calls. (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):
- 9:46 AM Changeset in webkit [78073] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Add convenience method toHTMLElement(Node*)
https://bugs.webkit.org/show_bug.cgi?id=54105
No new tests since no new functionality introduced.
- html/HTMLElement.h: (WebCore::toHTMLElement):
- 9:45 AM Changeset in webkit [78072] by
-
- 4 edits5 adds in trunk/Source/WebKit2
2011-02-09 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WKBaseGtk API for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54081
- GNUmakefile.am: Added new files to compilation.
- Shared/API/c/WKBase.h: Included WKBaseGtk.h in this file.
- Shared/API/c/gtk: Added.
- Shared/API/c/gtk/WKBaseGtk.h: Added. Declaration of WKViewRef for GTK port.
- UIProcess/API/C/WKAPICast.h: Included WKAPICastGtk.h in this file.
- UIProcess/API/C/gtk: Added.
- UIProcess/API/C/gtk/WKAPICastGtk.h: Added. Type definition template for WKViewRef to WebView and vice-versa.
- UIProcess/API/C/gtk/WKView.cpp: Added. Implementation of WKView API interface. (WKViewCreate): (WKViewGetWindow): (WKViewGetPage): (WKURLCreateWithURL):
- UIProcess/API/C/gtk/WKView.h: Added. Declaration of WKView API interface.
- 9:41 AM Changeset in webkit [78071] by
-
- 2 edits300 adds in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add test results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip tests with results.
- 9:35 AM Changeset in webkit [78070] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
Update Simplified Chinese (zh_CN) translation of WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=42496
- zh_CN.po: Updated.
- 9:33 AM Changeset in webkit [78069] by
-
- 4 edits2 copies1 add in trunk/Source/WebKit2
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WebGraphicsContext stub to the compilation
https://bugs.webkit.org/show_bug.cgi?id=54078
- GNUmakefile.am:
- Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Added stub just for compilation. (WKGraphicsContextGetGtkContext):
- Shared/API/c/gtk/WKGraphicsContextGtk.h: Added stub just for compilation.
- Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
- Shared/WebGraphicsContext.h: (WebKit::WebGraphicsContext::platformContext):
- 9:30 AM Changeset in webkit [78068] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Please add Greek translation of WebkitGTK+
https://bugs.webkit.org/show_bug.cgi?id=34482
- gr.po: Added.
- 9:27 AM Changeset in webkit [78067] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
Arabic translation
https://bugs.webkit.org/show_bug.cgi?id=36340
- ar.po: Added.
- 9:25 AM Changeset in webkit [78066] by
-
- 4 edits in trunk/Source/WebCore
Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding
<rdar://problem/7615997>
https://bugs.webkit.org/show_bug.cgi?id=54054
Reviewed by Dan Bernstein.
Take the overhang into account when calculating position for elements with position: fixed.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollXForFixedPosition):
(WebCore::ScrollView::scrollYForFixedPosition):
(WebCore::ScrollView::scrollOffsetForFixedPosition):
- platform/ScrollView.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::computeRectForRepaint):
- 9:24 AM Changeset in webkit [78065] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add geolocation support to the webkit2 compilation
https://bugs.webkit.org/show_bug.cgi?id=54077
Add Geolocation files to the GTK compilation.
- GNUmakefile.am:
- 9:21 AM Changeset in webkit [78064] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
Attached is the Bulgarian translation of WebKit Gtk
https://bugs.webkit.org/show_bug.cgi?id=44400
- bg.po: Added.
- 9:17 AM Changeset in webkit [78063] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
[l10n] Indonesian translation
https://bugs.webkit.org/show_bug.cgi?id=46455
- id.po: Added.
- 9:13 AM Changeset in webkit [78062] by
-
- 8 edits4 adds in trunk
2011-02-09 Simon Fraser <Simon Fraser>
Reviewed by Dirk Schulze.
Enhance ShadowBlur to tile inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567
Add a tiling code path to ShadowBlur for rendering inset
box-shadows.
Test: fast/box-shadow/inset-box-shadows.html
- platform/graphics/ShadowBlur.cpp: (WebCore::computeSliceSizesFromRadii): Compute the slice sizes for the eight-piece shadow template. (WebCore::ShadowBlur::templateSize): Compute the size of the template, given the slice sizes. (WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty (which probably means we're clipped out). Call templateSize() and use the result to decide whether to tile. (WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code path for inset shadows. (WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template buffer, paint the non-blurred area of the destination, and then call drawLayerPieces() to paint the eight-piece template image. (WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now shares the blurring code via blurAndColorShadowBuffer(), and the tiled template drawing via drawLayerPieces(). (WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the shadow template to the destination. (WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image buffer, and colorize them using the CompositeSourceIn operation.
- platform/graphics/ShadowBlur.h:
- 9:13 AM Changeset in webkit [78061] by
-
- 2 edits in trunk/Tools
2011-02-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove UiTools dependency from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54096
- MiniBrowser/qt/MiniBrowser.pro:
- 9:12 AM Changeset in webkit [78060] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
[l10n] Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=46567
- pl.po: Added.
- 9:06 AM Changeset in webkit [78059] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
[Gtk] Please add Hungarian translation
https://bugs.webkit.org/show_bug.cgi?id=34543
- hu.po: Added.
- 9:03 AM Changeset in webkit [78058] by
-
- 8 edits15 adds in trunk
2011-02-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867
- http/tests/security/contentSecurityPolicy/no-policy-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/no-policy.html: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-iframe.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
- http/tests/security/contentSecurityPolicy/resources/script-src.html: Added.
- http/tests/security/contentSecurityPolicy/resources/script.js: Added.
- http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-in-iframe.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-none.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect.html: Added.
2011-02-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867
Tests: http/tests/security/contentSecurityPolicy/no-policy.html
http/tests/security/contentSecurityPolicy/script-src-in-iframe.html
http/tests/security/contentSecurityPolicy/script-src-none.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
- page/ContentSecurityPolicy.h:
- 8:56 AM Changeset in webkit [78057] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r78047.
ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS),
so they shouldn't cause problems with correct preprocessor defines.
- CMakeLists.txt:
- 8:32 AM Changeset in webkit [78056] by
-
- 5 edits in trunk/Source/WebCore
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorAgent should know nothing about InspectorController instance.
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie):
- 7:48 AM Changeset in webkit [78055] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Don't generate superfluous forwarding header for config.h.
- Scripts/generate-forwarding-headers.pl:
- 7:45 AM Changeset in webkit [78054] by
-
- 2 edits in trunk/Source/WebKit2
Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly
WebView::WebView was initially creating a hidden window, then showing it. It would tell
WebPageProxy about the window while it was still hidden, and then have to inform
WebPageProxy that the window had become shown. This resulted in WebPageProxy sending
unnecessary messages to the web process, and confused code that assumed that the window
would be in the same state after WebView's constructor exited as it was when WebPageProxy
first found out about the window.
We now don't hide the window when creating it, which simplifies the code, and only tell
WebPageProxy about the window after we're done modifying it, which fixes the bug.
Fixes <http://webkit.org/b/53878> <rdar://problem/8977306> Assertion failure in
DrawingAreaImpl::resumePainting after window.open or when opening Web Inspector
Reviewed by Anders Carlsson.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Changed ::CreateWindowEx to ::CreateWindowExW, to match other
Win32 API calls in WebKit2. Pass WS_VISIBLE to ::CreateWindowExW rather than waiting until
later to show the window. Added an assertion that m_isVisible matches the window's visible
state. Don't even create our WebPageProxy, or tell it about our window, until we're done
initializing our window, so that it doesn't get informed about our window's internal state
changes that happen beneath ::CreateWindowExW.
(WebKit::WebView::onSizeEvent): Null-check m_page since we can receive this message beneath
::CreateWindowExW.
(WebKit::WebView::onShowWindowEvent): Ditto. Replaced one FIXME with another. Always set
handled to false so that ::DefWindowProcW can do its thing. (MSDN says this is when it
actually shows/hides the window, though I couldn't find any consequences of not calling
::DefWindowProcW here.)
- 7:28 AM Changeset in webkit [78053] by
-
- 4 edits in trunk/Source/WebCore
2011-02-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: source frame scroll position is not restored.
https://bugs.webkit.org/show_bug.cgi?id=54101
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.get scrollTop): (WebInspector.TextViewer.prototype.set scrollTop): (WebInspector.TextViewer.prototype.get scrollLeft): (WebInspector.TextViewer.prototype.set scrollLeft):
- 6:48 AM Changeset in webkit [78052] by
-
- 13 edits in trunk/Source
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebCore.exp.in:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::showConsole):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::showConsole): (WebCore::InspectorController::enabled): (WebCore::InspectorController::inspectedPage):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp:
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebInspector/WebInspector.mm: (-showConsole:): (-stopProfilingJavaScript:):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebInspector.cpp: (WebInspector::showConsole): (WebInspector::toggleProfilingJavaScript):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::showConsole): (WebKit::WebInspector::stopJavaScriptProfiling):
- 6:09 AM Changeset in webkit [78051] by
-
- 5 edits in trunk/Source/WebCore
2011-02-07 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53513
The PlatformCAAnimation::create() function which took a pointer to another
PlatformCAAnimation was supposed to make a copy of that passed object.
But it was doing completely the wrong thing on Mac and was leaking an object
to boot. And the notion of copying an object using a static creation function
is wrong in the first place. So I changed it to a member copy() function
which would create a new PlatformCAAnimation which was a copy of 'this' and
return it. I changed the implementation on both Mac and Win to match.
This problem was not caught by DRT, even there is a specific test for it.
That test just verifies that the higher level logic is working
properly, which it is. There's no practical way to find out if the
layer is currently animating. There is no logic which probes that
deeply into the layer mechanics.
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
- 6:07 AM Changeset in webkit [78050] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Chromium expectations update.
fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing.
- platform/chromium/test_expectations.txt:
- 5:59 AM Changeset in webkit [78049] by
-
- 1 edit in branches/chromium/648/Source/WebCore/inspector/InspectorController.cpp
DevTools: fix poor merge that resulted in calling into setDocument twice.
I am not doing it using drover since InspectorController has been renamed since the branch point.
BUG=72422
TBR=yurys
- 5:55 AM Changeset in webkit [78048] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Chromium: update expectations
plugins/invalidate_rect is failing on linux and win, too.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
- platform/chromium/test_expectations.txt:
- 5:51 AM Changeset in webkit [78047] by
-
- 2 edits in trunk/Source/WebCore
2011-02-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Remove double definition of ContextMenu.
https://bugs.webkit.org/show_bug.cgi?id=50762
When building with SHARED_CORE enabled, the symbols of ContextMenu
were both in webkit and webcore. This removes them from webcore and
shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
in EFL port.
No new tests because no new functionality.
- CMakeLists.txt:
- 4:40 AM Changeset in webkit [78046] by
-
- 4 edits in trunk/LayoutTests
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: Create expectations for residual-style.html see r77781.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt:
- platform/chromium-win/fast/invalid/residual-style-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:27 AM Changeset in webkit [78045] by
-
- 2 edits in trunk/Source/WebCore
Windows Production build fix
- WebCore.vcproj/QTMovieWinCommon.vsprops: Link against
WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
pick up the _debug variant when appropriate.
- 4:13 AM Changeset in webkit [78044] by
-
- 9 edits in trunk
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084
Pretty obvious change. KURL is the odd man out here.
- fast/url/host-expected.txt:
- fast/url/ipv4-expected.txt:
- fast/url/ipv6-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084
- platform/KURL.cpp: (WebCore::KURL::parse):
- 4:04 AM Changeset in webkit [78043] by
-
- 2 edits7 adds in trunk/LayoutTests
2011-02-09 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new text expectations for GTK port. They should be actually
valid for any port using the libsoup backend. We need different
results because as stated here
https://bugs.webkit.org/show_bug.cgi?id=3812#c6, the original test
results were designed for NSURLConnection which adds the
"Content-Length: 0" header for null message bodies. That does not
happen in libsoup, so instead of artificially add that header we
better generate different results.
Also take into account that for HEAD and GET requests the body is
not included so we should expect always a null for them.
- platform/gtk/Skipped:
- platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
- 4:00 AM Changeset in webkit [78042] by
-
- 24 edits4 adds1 delete in trunk/Source
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
Reviewed by Gavin Barraclough.
Rollback r77626 with windows build fix.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_regex_tables:
- runtime/RegExp.cpp:
- wtf/Platform.h:
- yarr/Yarr.h:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrParser.h:
- yarr/YarrPattern.h:
- yarr/YarrSyntaxChecker.h:
- yarr/yarr.pri: Added.
Source/WebCore:
No new tests needed.
- Android.jscbindings.mk:
- CMakeLists.txt:
- ForwardingHeaders/pcre/pcre.h: Removed.
- ForwardingHeaders/yarr/Yarr.h: Added.
- ForwardingHeaders/yarr/YarrInterpreter.h: Added.
- ForwardingHeaders/yarr/YarrPattern.h: Added.
- WebCore.gyp/WebCore.gyp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):
- 3:54 AM Changeset in webkit [78041] by
-
- 3 edits in trunk/Source/WebCore
2011-02-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add dummy functions for HTML5 Video's control UI
https://bugs.webkit.org/show_bug.cgi?id=53906
In WebKit EFL, there are no implementations for HTML5 control UI.
First, dummy functions are added.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
- platform/efl/RenderThemeEfl.h:
- 3:53 AM Changeset in webkit [78040] by
-
- 10 edits in trunk
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850
- fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Updated to match IE/Chrome
- fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Updated to match IE/Chrome.
- fast/url/anchor-expected.txt:
- "hello world": Our new behavior here matches IE and Chrome, but diverges from FF.
- The last two tests involving #, we were the odd man out. Now match all browsers.
- fast/url/segments-expected.txt:
- Don't percent encode spaces in fragments (to match other browsers)
- WebKit was the only engine encoding # in fragments.
- fast/url/segments-from-data-url-expected.txt:
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850
This doesn't make us match perfectly, but it brings us closer.
- platform/KURL.cpp: (WebCore::appendEscapingBadChars): (WebCore::escapeAndAppendFragment): (WebCore::KURL::parse):
- 3:37 AM Changeset in webkit [78039] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
One more attempt to make Qt buildbot happier and make sheriffbot
not to spam innocent people because of this flakey crash.
- platform/qt/Skipped: Add websocket directory instead of individual tests until fix.
- 3:20 AM Changeset in webkit [78038] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=53921
Patch by Robert Hogan <robert@webkit.org> on 2011-02-09
Reviewed by Antonio Gomes.
QDRTNode needs a copy constructor and an operator= in order to keep
proper refcounts.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(:m_node):
(QDRTNode::operator=):
(DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- 2:58 AM Changeset in webkit [78037] by
-
- 3 edits in trunk/LayoutTests
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: Rebaseline html5lib/runner.html expectations after r77781.
- platform/chromium/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 2:37 AM Changeset in webkit [78036] by
-
- 1 edit1 add in trunk/Websites/webkit.org
2011-02-09 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector stylesheet resource diff screenshot.
- blog-files/inspector/css_rule_diff.png: Added.
- 2:33 AM Changeset in webkit [78035] by
-
- 4 edits2 adds in trunk
2011-02-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690
Cursors should skip over entries that have been deleted
since the cursor was opened.
- storage/indexeddb/cursor-skip-deleted-expected.txt: Added.
- storage/indexeddb/cursor-skip-deleted.html: Added.
2011-02-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690
Add test to check that the cursor skips deleted entries.
Test: storage/indexeddb/cursor-skip-deleted.html
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
- storage/IDBCursorBackendImpl.h:
- 2:12 AM Changeset in webkit [78034] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: script formatter should not create a worker for each script.
https://bugs.webkit.org/show_bug.cgi?id=54010
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype._formatScript): (WebInspector.ScriptFormatter.prototype._handleMessage): (WebInspector.ScriptFormatter.prototype._handleError):
- 2:05 AM Changeset in webkit [78033] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-09 MORITA Hajime <morrita@google.com>
Reviewed by Shinichiro Hamaji.
[Chromium] WebTextCheckingResult should have a default constructor.
https://bugs.webkit.org/show_bug.cgi?id=54075
Gave default parameters to WebTextCheckingResult constructor.
- public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult):
- 2:00 AM Changeset in webkit [78032] by
-
- 3 edits in trunk/Source/WebCore
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: sync uglifyjs parser files.
https://bugs.webkit.org/show_bug.cgi?id=54003
- inspector/front-end/UglifyJS/parse-js.js:
- inspector/front-end/UglifyJS/process.js:
- 1:53 AM Changeset in webkit [78031] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: update expectations for some canvas/philip tests which are failing on MAC.
- platform/chromium/test_expectations.txt:
- 12:23 AM Changeset in webkit [78030] by
-
- 2 edits in trunk/LayoutTests
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Skip some failing tests.
- platform/gtk/Skipped: Skip plugins/invalidate_rect.html and fast/frames/flattening/iframe-flattening-crash.html
- 12:09 AM Changeset in webkit [78029] by
-
- 1 edit1 copy2 adds in trunk/LayoutTests
Unreviewed.
[Qt] Qt platform has a different editing delegates for several tests
https://bugs.webkit.org/show_bug.cgi?id=43082
editing/undo/undo-paste-when-caret-is-not-in-range.html introduced in r77995, but fails on Qt.
Add platform specific expected result until fix.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Added.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Added.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Copied from LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt.
- 12:03 AM Changeset in webkit [78028] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Avoid WebProcessMain compilation, we are used a gtk specific main
https://bugs.webkit.org/show_bug.cgi?id=54015
Avoided the compilation of the general WebProcessMain, and added
soup initialization to WebProcessMainGtk.cpp.
- GNUmakefile.am:
- WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):
Feb 8, 2011:
- 11:59 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:58 PM Changeset in webkit [78027] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Incorrect assertion in WorkQueueGtk, we need to register
more than one handle
https://bugs.webkit.org/show_bug.cgi?id=54014
Fixed assertion condition we need to register more than one
handler for the same file descriptor.
- Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::registerEventSourceHandler):
- 11:58 PM Changeset in webkit [78026] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt]Missing layoutTestController.displayInvalidatedRegion()
plugins/invalidate_rect.html introduced in r78010, but unfortunately
Qt DRT doesn't have layoutTestController.displayInvalidatedRegion().
- platform/qt/Skipped: Add plugins/invalidate_rect.html.
- 11:43 PM Changeset in webkit [78025] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fix typo in the include guards name in ChunkedUpdateDrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54013
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- 11:42 PM Changeset in webkit [78024] by
-
- 2 edits in trunk/Source/WebKit/mac
<rdar://problem/8959420> Find in Mail no longer cycles around
Reviewed by Jon Honeycutt and Maciej Stachowiak.
- WebView/WebHTMLView.mm:
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
the wrap option according to the flag.
- 11:30 PM Changeset in webkit [78023] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Skip a freshly added test that depends on newly added DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54069
- platform/mac-wk2/Skipped:
- 11:25 PM Changeset in webkit [78022] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix after r77874, m_isConnected is initialized before the
socket is opened
https://bugs.webkit.org/show_bug.cgi?id=54011
Fixed connection breakage after r77874, we have to wait until open
the socket to open the connection.
- Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::open):
- 11:21 PM Changeset in webkit [78021] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING
guards but not defined in DrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54009
Removed the guards in the forward declaration, this will fail if
the class is finally used in the function, but it works for the
moment.
- UIProcess/DrawingAreaProxy.h:
- 11:16 PM Changeset in webkit [78020] by
-
- 5 edits in trunk
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
- GNUmakefile.am: Removed the commands to create the directories for the forwarding headers, the script already does it for us.
- config.h: Removed the config.h inclusion and added the autotoolsconfig.h directly, also added a condition to share the defines with QT.
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
Removed the STDC_FORMAT_MACROS definition, it is already defined
in the file where PRIxx64 is used before the inclusion so we are
safe.
- configure.ac:
- 10:42 PM Changeset in webkit [78019] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix toolbar anchoring in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54058
Avoid the anchoring cycle of doom when on the cusp
of whether the toolbar needs to be anchored and
speculatively avoid the Firefox crash when resizing.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 10:09 PM Changeset in webkit [78018] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=54064
- runtime/MarkedSpace.cpp: Removed some now-unused constants and declarations.
(JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
by our caller. Removed redundant typedefs.
- 9:59 PM Changeset in webkit [78017] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
https://bugs.webkit.org/show_bug.cgi?id=54062
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To know if an object is live, you just need to test its mark bit.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from CollectorHeap into MarkedSpace, since they're global state. Removed call to memset since CollectorHeap is a true class with its own constructor now.
(JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapEnd):
- runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): (JSC::MarkedSpace::contains): Same as above.
- 9:46 PM Changeset in webkit [78016] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Skip some tests that fail in WebKit2 for obvious reasons
https://bugs.webkit.org/show_bug.cgi?id=54055
- platform/mac-wk2/Skipped:
- 9:40 PM Changeset in webkit [78015] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Crash when going back/forward when back/forward list is in a bad state.
https://bugs.webkit.org/show_bug.cgi?id=54059
<rdar://problem/8975244>
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goForward): Add a null check. (WebKit::WebPageProxy::goBack): ditto
- 9:33 PM Changeset in webkit [78014] by
-
- 5 edits in trunk/Tools
2011-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Pull up rebaseline code from compare_output() function defined
in text_diff.py and image_diff.py into a SingleTestRunner.
This patch is a first step for eliminating test_type/* classes.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 8:34 PM Changeset in webkit [78013] by
-
- 2 edits in trunk
2011-02-08 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Eric Seidel.
Added include paths for QtScript.
WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- Source/WebKit.pri:
- 8:32 PM Changeset in webkit [78012] by
-
- 6 edits in trunk/Tools
2011-02-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
stop generating results.json files
https://bugs.webkit.org/show_bug.cgi?id=53977
We've only used incremental_results.json for a while now
and there are plans to start generating a results.json file that matches
the format of unexpected_results.json.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:17 PM Changeset in webkit [78011] by
-
- 5 edits2 adds in trunk
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.
Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.
Test: editing/style/query-typing-style.html
- editing/ApplyStyleCommand.cpp: (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that CSS values from xx-small through -webkit-xxx-large are not accounted.
- editing/ApplyStyleCommand.h:
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. No longer calls removeNonEditingProperties on the copied typing style so that background-color property is included when merged into the style.
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
Added a test to ensure calling queryCommandValue returns the correct value for backColor
and fontSize from typing style.
- editing/style/query-typing-style-expected.txt: Added.
- editing/style/query-typing-style.html: Added.
- 7:30 PM Changeset in webkit [78010] by
-
- 11 edits2 adds in trunk
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.
- plugins/invalidate_rect-expected.txt: Added.
- plugins/invalidate_rect.html: Added.
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Invalidate rect for windowless plugins wasn't working if the web page was composited.
The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.
Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.
Tested my fix on Windows and Mac and verified that the movie on http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::invalidateRect):
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added two new utility methods.
- layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
- plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect This is used to test that invalidating a rect correctly causes a repaint of the plugin.
- DumpRenderTree/LayoutTestController.cpp: (displayInvalidatedRegionCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect): (pluginInvoke):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::displayInvalidatedRegion):
- DumpRenderTree/chromium/LayoutTestController.h:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 6:59 PM Changeset in webkit [78009] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>
Reviewed by Maciej Stachowiak.
- page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.
- 6:43 PM Changeset in webkit [78008] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
since we now pass the test.
- platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
- 6:39 PM Changeset in webkit [78007] by
-
- 20 edits1 copy99 adds in trunk/LayoutTests
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu-win rebaseline.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:
- 6:27 PM Changeset in webkit [78006] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 6:14 PM Changeset in webkit [78005] by
-
- 19 edits2 adds in trunk
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-event-propagation.html:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-basics.html:
- storage/indexeddb/transaction-event-propagation-expected.txt: Added.
- storage/indexeddb/transaction-event-propagation.html: Added.
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).
Test: storage/indexeddb/transaction-event-propagation.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/Event.cpp: (WebCore::Event::isIDBAbortEvent): (WebCore::Event::isIDBCompleteEvent):
- dom/Event.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBDatabase):
- dom/EventTarget.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::scriptExecutionContext): (WebCore::IDBDatabase::eventTargetData): (WebCore::IDBDatabase::ensureEventTargetData):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::toIDBDatabase): (WebCore::IDBDatabase::refEventTarget): (WebCore::IDBDatabase::derefEventTarget):
- storage/IDBDatabase.idl:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::backend): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h: (WebCore::IDBTransaction::dispatchEvent):
- 6:10 PM Changeset in webkit [78004] by
-
- 3 edits in branches/chromium/648/Source/WebCore
Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.
[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
- platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6460020
- 6:08 PM Changeset in webkit [78003] by
-
- 3 edits in branches/chromium/648/Source/WebKit/chromium
Merge 77599 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6465012
- 6:02 PM Changeset in webkit [78002] by
-
- 1 edit2 adds in trunk/Source/WebCore
2011-02-08 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add cache for GPU-accelerated path processing results
https://bugs.webkit.org/show_bug.cgi?id=45519
Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.
- platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::addVertex): (WebCore::LoopBlinnPathCache::clear): (WebCore::LoopBlinnPathCache::addInteriorVertex): (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): (WebCore::LoopBlinnPathCache::interiorEdgeVertices): (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
- platform/graphics/gpu/LoopBlinnPathCache.h: Added. (WebCore::LoopBlinnPathCache::numberOfVertices): (WebCore::LoopBlinnPathCache::vertices): (WebCore::LoopBlinnPathCache::texcoords): (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): (WebCore::LoopBlinnPathCache::interiorVertices):
- 5:55 PM Changeset in webkit [78001] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Nevermind
- 5:54 PM Changeset in webkit [78000] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
80,000
- 5:46 PM Changeset in webkit [77999] by
-
- 4 edits in trunk/Source/WebCore
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Rename GraphicsContext3D::WebGLEnumType
https://bugs.webkit.org/show_bug.cgi?id=45708
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::getAttachedShader):
- html/canvas/WebGLProgram.h:
- platform/graphics/GraphicsContext3D.h:
- 5:17 PM Changeset in webkit [77998] by
-
- 3 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move the logic that starts and stops the
servers from dump_render_tree_thread into single_test_runner
so that we can reuse it in the new multiprocessing worker class
as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 5:04 PM Changeset in webkit [77997] by
-
- 26 edits in trunk/Source
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebCore.exp.in:
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::VisiblePosition): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h:
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 5:00 PM Changeset in webkit [77996] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Beth Dakin.
Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
https://bugs.webkit.org/show_bug.cgi?id=54046
<rdar://problem/8973960>
DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
in accelerated compositing mode. Similarly, it can be called with a null layer even when not
in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise just call LayerTreeHost::setRootCompositingLayer.
(WebKit::DrawingAreaImpl::setSize):
Add an assert.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Assert that we don't have a layer tree host.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Assert that we do have a layer tree host.
(WebKit::DrawingAreaImpl::display):
If the call to display caused the page to enter accelerated compositing mode, we don't
want to send back an Update message.
- WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h: Create no longer takes a graphics layer.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create no longer takes a graphics layer.
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
Set the new root compositing layer.
- 4:55 PM Changeset in webkit [77995] by
-
- 3 edits2 adds in trunk
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
- editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):
- 4:48 PM Changeset in webkit [77994] by
-
- 3 edits2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: split out thread stack logging code into a sharable module
This patch splits out the code used to find and log thread
stacks from NRWT-specific packages to something generic and
shareable by other python modules. It will be shared in the near
future by the manager_worker_broker module, for example.
- Scripts/webkitpy/common/system/stack_utils.py: Added.
- Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
- 4:45 PM Changeset in webkit [77993] by
-
- 7 edits2 deletes in trunk/Source/WebCore
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the last remnants of the Mozilla theme drawing code
https://bugs.webkit.org/show_bug.cgi?id=54035
Remove all Mozilla theme drawing code.
No new tests. This change only removes dead code.
- GNUmakefile.am: Remove Mozilla files from the source list.
- platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods and add m_colormap to hold the current colormap of the widgets.
- platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::gtkContainer): Ditto.
- platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- platform/gtk/gtk2drawing.c: Removed.
- platform/gtk/gtkdrawing.h: Removed.
- 4:40 PM Changeset in webkit [77992] by
-
- 4 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move a bunch of testing logic out of
dump_render_tree_thread and into single_test_runner so that we
will be able to reuse it in the new multiprocessing worker class as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 4:37 PM Changeset in webkit [77991] by
-
- 2 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: remove no longer needed WatchableThread
class.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- 4:33 PM Changeset in webkit [77990] by
-
- 1 edit2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add stubs for the Manager objects that
will abstract the concurrency implementation (inline / threads /
processes). These classes do nothing yet and are not wired up to
anything.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
- 4:31 PM Changeset in webkit [77989] by
-
- 1 edit2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add simplified message broker for new-style
messaging. This change adds a very simple message broker that
will be used to shuttle messages between the TestRunner2 manager
thread and the Worker threads. For now the class is not used by
anything, but the eventual usage can be seen in the patches
attached to bug 49566.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
- 4:25 PM Changeset in webkit [77988] by
-
- 3 edits5 adds in trunk
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
- fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-crash.html: Added.
- fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
- fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.
Tests: fast/frames/flattening/iframe-flattening-crash.html
fast/frames/flattening/iframe-flattening-selection-crash.html
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
- 4:25 PM Changeset in webkit [77987] by
-
- 2 edits in trunk/Tools
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
chromium-win builder shouldn't run python or perl tests
https://bugs.webkit.org/show_bug.cgi?id=54032
These tests don't pass on this builder because the builder isn't
running in cygwin. There isn't really any point in running them and
making the bot red forever.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 4:07 PM Changeset in webkit [77986] by
-
- 2 edits in trunk
Add Radar URLs to a recent ChangeLog entry.
- 3:59 PM Changeset in webkit [77985] by
-
- 5 edits in trunk
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Setting the contentEditable attribute to 'plaintext-only' should not throw an exception.
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
- fast/dom/HTMLElement/set-value-caseinsensitive.html:
- 3:51 PM Changeset in webkit [77984] by
-
- 3 edits in trunk/Source/WebCore
RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042
Reviewed by Simon Fraser.
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().
- rendering/RenderRubyRun.h:
- 3:34 PM Changeset in webkit [77983] by
-
- 3 edits in trunk/Source/WebKit2
Implement WorkQueue::scheduleWorkAfterDelay on Windows
Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.
Fixes <http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away
Reviewed by Anders Carlsson.
- Platform/WorkQueue.h: Added timerCallback and m_timerQueue.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.
- 3:15 PM Changeset in webkit [77982] by
-
- 4 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a series of tests that seem to be passing locally. Also unskip
a test that was mistakenly reskipped in r77979 due to what looks like a
merge issue. Rebaseline two of these test which have results originating
from long ago.
- platform/gtk/Skipped: Unskip some tests.
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
- 3:14 PM Changeset in webkit [77981] by
-
- 5 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initializeConnection to PluginProcess::initialize
https://bugs.webkit.org/show_bug.cgi?id=54039
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain):
- WebProcess/WebProcess.h:
- 3:13 PM Changeset in webkit [77980] by
-
- 26 edits in trunk/Source
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
- WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 3:09 PM Changeset in webkit [77979] by
-
- 5 edits in trunk
2011-02-08 Michael Saboff <msaboff@apple.com>
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().
- bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::willDestroyRuntimeObject):
- bridge/runtime_root.cpp: (JSC::Bindings::RootObject::removeRuntimeObject):
2011-02-08 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Re-enabled tests that are fixed with the corresponding change in
WebCore.
- platform/gtk/Skipped:
- 3:07 PM Changeset in webkit [77978] by
-
- 9 edits in trunk
<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed
Reviewed by Darin Adler.
Source/WebKit2:
Update the implementation of this API to include the new item (if any) and removed items (if any):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/WebPageProxy.h:
Have WebBackForwardList pass the new items and/or removed items when calling the notifier:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(didChangeBackForwardList):
- 3:03 PM Changeset in webkit [77977] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Give each MarkedBlock enough mark bits to cover the whole block
https://bugs.webkit.org/show_bug.cgi?id=54029
SunSpider reports no change.
This simplifies access to mark bits, since any cell-aligned pointer
into a block now has a valid mark bit to test.
- runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra mark bits. This happens not to change its actual value. (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to remove a cast from our caller, and to more accurately reflect the fact that MarkedBlock is agnostic about the types pointed to by the pointers you pass to it.
(JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
the null pointer to be a possible cell with a 0 (impossible) block. This
removes a null check from marking.
- runtime/MarkedSpace.cpp:
- runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Simplified the contains check, and inlined the whole thing, now that it's so simple.
- 3:02 PM Changeset in webkit [77976] by
-
- 2 edits in trunk/Source/WebKit2
Sandbox violations visiting MobileMe.
<rdar://problem/8961330>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 2:52 PM Changeset in webkit [77975] by
-
- 5 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
https://bugs.webkit.org/show_bug.cgi?id=54037
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
match the WebProcess initialization code, in preparation of sharing more code.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializePluginProcess):
- PluginProcess/PluginProcess.h:
- PluginProcess/PluginProcess.messages.in:
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
- 2:48 PM Changeset in webkit [77974] by
-
- 26 edits6 adds in trunk
WK2: Add ability to pass context to policy delegate methods
https://bugs.webkit.org/show_bug.cgi?id=54031
Reviewed by Anders Carlsson.
Source/WebKit2:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):
- Scripts/webkit2/messages.py:
Add ability to pass variadic messages to sync messages.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
Add WKBundleNavigation type.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
- UIProcess/WebPolicyClient.h:
Update policy client for new data.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.
(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPolicyClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.
(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.
(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.
- 2:33 PM Changeset in webkit [77973] by
-
- 4 edits1 delete in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for chromium-mac after r77952.
Not sure why the previous rebase did not get the right results.
https://bugs.webkit.org/show_bug.cgi?id=54026
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:31 PM Changeset in webkit [77972] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-08 Daniel Bates <dbates@rim.com>
Rubber-stamped by Martin Robinson.
Rename enum ProtectionSeting [sic] to ProtectionSetting.
- jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
- jit/ExecutableAllocator.h:
- 2:25 PM Changeset in webkit [77971] by
-
- 10 edits in trunk
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
- platform/gtk/Skipped: Unskip a test that is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
This is a likely candidate for a new API point.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- webkit/webkitglobals.cpp: (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead of initializing the database manually. (WebKit::setIconDatabaseEnabled): Added.
- webkit/webkitglobalsprivate.h: Added declarations.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Turn off the icon database.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk method.
- 2:11 PM Changeset in webkit [77970] by
-
- 3 edits in trunk/Source/WebCore
Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258
Reviewed by Darin Adler.
This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.
Remove scrollbarPainterDelegate() since it's not used anymore.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 2:00 PM Changeset in webkit [77969] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, typo fix.
- platform/chromium/test_expectations.txt
- 1:51 PM Changeset in webkit [77968] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash calling -setFrame:andScrollBy: in windowDidResize
https://bugs.webkit.org/show_bug.cgi?id=54030
<rdar://problem/8969760>
- Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Assert that size is not zero here; we never want to try to create shared memory with a zero size.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Always invalidate the entire visible page when resizing.
- 1:09 PM Changeset in webkit [77967] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip some inspector tests that are passing locally. The bugs are
missing test diffs, so we can either reskip them and get more information
or have passing tests. Classify another failure.
- platform/gtk/Skipped: Clean up the skipped list.
- 1:06 PM Changeset in webkit [77966] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 12:54 PM Changeset in webkit [77965] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[Chromium] Remove non-Flaky media tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=54021
- platform/chromium/test_expectations.txt:
- 12:19 PM Changeset in webkit [77964] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. Fix typo in rebaseline in r77961.
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- 12:17 PM Changeset in webkit [77963] by
-
- 29 edits in trunk/Source
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
This code appears to be unused.
- html/HTMLParserErrorCodes.cpp:
- html/HTMLParserErrorCodes.h:
- html/HTMLParserQuirks.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- src/ChromeClientImpl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientEfl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientGtk.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientQt.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebKitSupport/ChromeClientWx.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebProcess/WebCoreSupport/WebChromeClient.cpp
- WebProcess/WebCoreSupport/WebChromeClient.h
- 11:36 AM Changeset in webkit [77962] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>
Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.
The original fix, http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
is in WebInspectorProxy::invalidate.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate):
- 11:25 AM Changeset in webkit [77961] by
-
- 2 edits11 adds in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r77952.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- 11:15 AM Changeset in webkit [77960] by
-
- 7 edits in trunk/Source/WebCore
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836
Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.
No new tests. This should not change the rendering of the default
theme.
- platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
- platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
- platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled window background if we are repainting a button or the thumb. In that case also repaint the track rect.
- platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. (WebCore::getWidgetForScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which also adjusts a widget allocation according to the paint rect. This is necessary to properly draw scrollbar buttons.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- 11:12 AM Changeset in webkit [77959] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo < zmo@google.com>
Unreviewed, test expectations update.
- LauoutTests/platform/chromium/test_expectations.txt
- 10:57 AM Changeset in webkit [77958] by
-
- 3 edits4 adds in trunk
2011-02-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Inset shadow with large offset renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53882
Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.
Test: fast/box-shadow/inset-shadow-large-offset.html
- rendering/RenderBoxModelObject.cpp: (WebCore::areaCastingShadowInHole): Return a rect that covers the area which contributes to the inset shadow.
(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.
- 10:56 AM Changeset in webkit [77957] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-08 Tony Chang <tony@chromium.org>
Unreviewed, build fix for clobber builds of DRT on mac/linux.
This file moved in chromium r73530 and this path wasn't changed.
- WebKit.gyp:
- 10:47 AM Changeset in webkit [77956] by
-
- 5 edits in trunk
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawElements):
- 10:37 AM Changeset in webkit [77955] by
-
- 4 edits in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. after r77952,
skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
set it as expect to fail in chromium.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:35 AM Changeset in webkit [77954] by
-
- 12 edits in trunk/Source/WebCore
2011-01-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190
This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.
Refactoring, covered by existing tests.
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h: Ditto.
- html/shadow/MediaControls.cpp: (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
MediaControlCurrentTimeDisplayElement.
(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
MediaControlTimeRemainingDisplayElement.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
standard style resolution.
(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
that is no longer necessary.
(WebCore::MediaControlElement::styleForElement): Changed to use the standard
style resolution.
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
- rendering/MediaControlElements.h: Added/changed defs accordingly.
- rendering/RenderTheme.h: (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
- rendering/RenderThemeMac.h: Added def.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
- rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
- 10:32 AM Changeset in webkit [77953] by
-
- 3 edits in trunk/Source/WebKit/win
<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
Reviewed by Adam Roben.
Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.
- WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
- WebFrame.h:
- 10:22 AM Changeset in webkit [77952] by
-
- 3 edits4 adds in trunk
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
- fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
Test: fast/text/international/pop-up-button-text-alignment-and-direction.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle):
- 10:01 AM Changeset in webkit [77951] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt-minimal.
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- 9:32 AM Changeset in webkit [77950] by
-
- 25 edits in trunk/Source
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.
- WebCore.exp.in:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::enabled):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::frontend):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::hasInspectorFrontendClient): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::disconnectFrontendImpl): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::enabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::frontendLoaded): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::resume): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::dispatchMessageFromFrontend):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient): (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::hasFrontend):
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
- src/WebViewImpl.h:
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebCoreSupport/InspectorClientGtk.cpp:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_get_property):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector/WebInspector.mm: (-isTimelineProfilingEnabled):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled):
- 9:30 AM Changeset in webkit [77949] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995
Ensure to wait for the body to be loaded before running the test.
- editing/selection/end-of-document.html: Call runEditingTest() on the body.onload event.
- 9:27 AM Changeset in webkit [77948] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-08 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt] Should not always define USE_SYSTEM_MALLOC
https://bugs.webkit.org/show_bug.cgi?id=54007
- wtf/Platform.h:
- 9:21 AM Changeset in webkit [77947] by
-
- 4 edits in trunk/Tools
2011-02-08 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Laszlo Gombos.
Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 9:16 AM Changeset in webkit [77946] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Adam Barth.
Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
- 9:05 AM Changeset in webkit [77945] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Darin Adler.
Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImageBuffer):
- 8:50 AM Changeset in webkit [77944] by
-
- 3 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for DownloadBundle
https://bugs.webkit.org/show_bug.cgi?id=53881
- platform/network/cf/DownloadBundle.h:
- platform/network/win/DownloadBundleWin.cpp: (WebCore::DownloadBundle::appendResumeData):
- 8:47 AM Changeset in webkit [77943] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing include in WKCAImageQueue
https://bugs.webkit.org/show_bug.cgi?id=53890
- platform/graphics/win/WKCAImageQueue.cpp:
- 8:28 AM Changeset in webkit [77942] by
-
- 2 edits in trunk/Source/WebKit2
ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
https://bugs.webkit.org/show_bug.cgi?id=54005
Reviewed by Adam Roben.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.
- 8:17 AM Changeset in webkit [77941] by
-
- 2 edits in trunk/WebKitLibraries
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing forward declarations in WebKitSystemInterface.h
https://bugs.webkit.org/show_bug.cgi?id=53889
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- 8:08 AM Changeset in webkit [77940] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a bunch of tests that are passing locally and move one
timeout with the other timeouts.
- platform/gtk/Skipped: Unskip some passing tests.
- 8:03 AM Changeset in webkit [77939] by
-
- 2 edits in trunk/Source/WebKit2
Handle WM_TIMER messages for stopped timers
Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.
Fixes <http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired
Reviewed by Darin Adler.
- Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.
- 8:01 AM Changeset in webkit [77938] by
-
- 2 edits in trunk/Source/WebKit2
Don't mark a Connection as connected until open() is called on Windows
This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.
Fixes <http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows
Reviewed by Darin Adler.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.
- 7:58 AM Changeset in webkit [77937] by
-
- 7 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/network/cf/LoaderRunLoopCF.h:
- platform/network/cf/ProxyServerCFNet.cpp:
- platform/network/cf/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- 7:57 AM Changeset in webkit [77936] by
-
- 4 edits in trunk
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
Support handling either an array or a string for the modifier argument
to EventSender.keyDown.
- DumpRenderTree/gtk/EventSender.cpp: (gdkModifierFromJSValue): Added this helper which factors out the string comparison bits. (gdkModifersFromJSValue): Test up front whether the value is a string, to handle it specially.
- 7:51 AM Changeset in webkit [77935] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77870.
- platform/DragImage.cpp: Compile createDragImageForLink on WinCE.
- 7:48 AM Changeset in webkit [77934] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Removing inspector tests from Skipped on [win].
Resource tracking has been removed since then, maybe it'll help.
- platform/win/Skipped:
- 7:46 AM Changeset in webkit [77933] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list slightly and unskip a test which should now be passing.
- platform/gtk/Skipped: Clean up.
- 7:40 AM Changeset in webkit [77932] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: open network resource url in new tab upon double click.
https://bugs.webkit.org/show_bug.cgi?id=53930
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- 7:34 AM Changeset in webkit [77931] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: $x: any node should work in optional context parameter.
https://bugs.webkit.org/show_bug.cgi?id=50138
- inspector/InjectedScriptSource.js:
- 7:30 AM Changeset in webkit [77930] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77870.
Remove the global namespace prefix from GlobalLock/GlobalUnlock.
- platform/win/ClipboardUtilitiesWin.cpp:
- 7:27 AM Changeset in webkit [77929] by
-
- 5 edits2 adds in trunk
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: re-apply r77924.
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
- 7:08 AM Changeset in webkit [77928] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
REGRESSION(r77312): Unbreak TiledBackingStore.
Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.
Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().
- platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::updateTileBuffers): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):
- 6:26 AM Changeset in webkit [77927] by
-
- 3 edits2 deletes in trunk
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/console-api-on-call-frame-expected.txt: Removed.
- inspector/console-api-on-call-frame.html: Removed.
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/InjectedScriptSource.js: (.): ():
- 6:04 AM Changeset in webkit [77926] by
-
- 3 edits in trunk/Tools
2011-02-08 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Csaba Osztrogonác.
openDatabaseSync() stop responding after too many call
https://bugs.webkit.org/show_bug.cgi?id=53945
Reset the database quota to a known state between each test.
Define a quota for the known origins at each test run and delete
all the databases.
This way, the database related test do not depend on previous
allocations.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpDatabaseQuota):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- 5:42 AM Changeset in webkit [77925] by
-
- 16 edits in trunk/Source/WebCore
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
https://bugs.webkit.org/show_bug.cgi?id=53789
- perform UserAgent override via InspectorInstrumentation
- move adding extra request headers to InspectorResourceAgent
- simplified things in InspectorState
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::applyUserAgentOverride):
- inspector/InspectorAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::applyUserAgentOverride):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setExtraHeaders): (WebCore::InspectorResourceAgent::willSendRequest):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::getObject):
- inspector/InspectorState.h: (WebCore::InspectorState::setObject):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent):
- 5:29 AM Changeset in webkit [77924] by
-
- 3 edits2 adds in trunk
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
- inspector/console-api-on-call-frame-expected.txt: Added.
- inspector/console-api-on-call-frame.html: Added.
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- 5:03 AM Changeset in webkit [77923] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-02-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Fix when building with curl backend.
- ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
- 4:57 AM Changeset in webkit [77922] by
-
- 11 edits1 delete in trunk
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPage):
- inspector/audits-panel-functional.html:
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::reloadPage):
- inspector/InspectorAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 4:45 AM Changeset in webkit [77921] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test timing out on GTK 32-bit debug bot.
fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53992
- platform/gtk/Skipped: Skipped test.
- 3:26 AM Changeset in webkit [77920] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
fast/frames/sandboxed-iframe-storage.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53991
- platform/gtk/Skipped: Skipped test.
- 2:52 AM Changeset in webkit [77919] by
-
- 3 edits in trunk/Source/WebCore
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987
Reviewed by Cameron Zwarich.
Skip instead of bailing out. This will allow optimizing some sibling selector cases.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
- 2:50 AM Changeset in webkit [77918] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53989
- platform/gtk/Skipped: Skipped test.
- 2:20 AM Changeset in webkit [77917] by
-
- 8 edits2 adds in trunk
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- platform/gtk/Skipped: Unskip several tests that pass now that we have TextInputController.
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): (DumpRenderTreeSupportGtk::confirmComposition): (DumpRenderTreeSupportGtk::firstRectForCharacterRange): (DumpRenderTreeSupportGtk::selectedRange): New methods needed by TextInputController.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
Initial implementation of TextInputController for GTK port.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared):
- DumpRenderTree/gtk/TextInputController.cpp: Added. (setMarkedTextCallback): (insertTextCallback): (unmarkTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (getClass): (makeTextInputController):
- DumpRenderTree/gtk/TextInputController.h: Added.
- GNUmakefile.am:
- 1:18 AM Changeset in webkit [77916] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM Compiler build fix.
Reviewed by Maciej Stachowiak.
- runtime/WriteBarrier.h:
(JSC::WriteBarrier::WriteBarrier):
- 12:49 AM Changeset in webkit [77915] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77866.
http://trac.webkit.org/changeset/77866
https://bugs.webkit.org/show_bug.cgi?id=53981
caused all WebKit2 inspector tests to crash (Requested by
othermaciej on #webkit).
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
