Timeline



Apr 17, 2011:

11:53 PM Changeset in webkit [84123] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-17 Thierry Reding <​thierry.reding@avionic-design.de>

Reviewed by Adam Barth.

Fix build with GCC 4.6.

  • dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.

From the cpp manpage:

-P Inhibit generation of linemarkers in the output from the

preprocessor. This might be useful when running the preprocessor
on something that is not C code, and will be sent to a program
which might be confused by the linemarkers.

The linemarkers are not problematic, however, because the script
properly handles them by ignoring all lines starting with a #.

10:36 PM Changeset in webkit [84122] by Csaba Osztrogonác
  • 46 edits
    90 adds in trunk/LayoutTests

Update Qt specific expected files after r84039.

  • platform/qt/fast/html/details-[...] : Updated.
10:15 PM Changeset in webkit [84121] by cwzwarich@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Reviewed by Dan Bernstein.

JSC no longer builds with Clang due to -Woverloaded-virtual warning
​https://bugs.webkit.org/show_bug.cgi?id=58760

Rename Structure's specificValue overload of put to putSpecificValue to avoid
Clang's warning for overloading a virtual function.

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::putSpecificValue):

  • runtime/Structure.h:
9:06 PM Changeset in webkit [84120] by ddkilzer@apple.com
  • 14 edits in trunk/Source

<​http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
<rdar://problem/9268729>

Reviewed by Dan Bernstein.

This replaces support for the WebKitEnableHTTPPipelining user
default with methods on the WebCore::ResourceRequest class in
WebCore, the WebView class in WebKit1, and the WebContext class
in WebKit2. It also removes support for the
WebKitForceHTTPPipeliningPriorityHigh user default which was not
needed.

Source/WebCore:

Run these commands if you set the user defaults previously,
replacing "BUNDLE.ID" with your application's bundle ID:

defaults delete BUNDLE.ID WebKitEnableHTTPPipelining
defaults delete BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh

  • WebCore.exp.in: Export ResourceRequest::httpPipeliningEnabled()

and ResourceRequest::setHTTPPipeliningEnabled().

  • platform/network/ResourceRequestBase.h:

(WebCore::isHTTPPipeliningEnabled): Removed declaration.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed declaration.

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::httpPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added declaration.
(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added declaration.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::s_httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::httpPipeliningEnabled): Added.
(WebCore::ResourceRequest::setHTTPPipeliningEnabled): Added.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Switched
to use ResourceRequest::httpPipeliningEnabled().
(WebCore::readBooleanPreference): Removed.
(WebCore::isHTTPPipeliningEnabled): Removed.
(WebCore::shouldForceHTTPPipeliningPriorityHigh): Removed.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use ResourceRequest::httpPipeliningEnabled(). Removed check for
shouldForceHTTPPipeliningPriorityHigh().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.

  • WebView/WebViewPrivate.h:

(+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
(+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.

Source/WebKit2:

  • UIProcess/API/C/WKContext.cpp:

(_WKContextSetHTTPPipeliningEnabled): Added.

  • UIProcess/API/C/WKContextPrivate.h:

(_WKContextSetHTTPPipeliningEnabled): Added declaration.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setHTTPPipeliningEnabled): Added.
(WebKit::WebContext::httpPipeliningEnabled): Added.

  • UIProcess/WebContext.h:

(WebKit::WebContext::setHTTPPipeliningEnabled): Added declaration.
(WebKit::WebContext::httpPipeliningEnabled): Added declaration.

7:10 PM Changeset in webkit [84119] by mitz@apple.com
  • 7 edits in trunk

REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html
​https://bugs.webkit.org/show_bug.cgi?id=58736

Reviewed by Maciej Stachowiak.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendFloatingObjectToLastLine): It is enough to extend the float so
that it touches the bottom of the previous line, since RenderBlock::markLinesDirtyInBlockRange()
always dirties the line after the last one in the range.

LayoutTests:

Revert to the correct results.

  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/mac/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/032-expected.txt:
5:10 PM Changeset in webkit [84118] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-04-17 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Make more strings in WebKit2 localizable
​https://bugs.webkit.org/show_bug.cgi?id=58757

  • UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView menuForEvent:]):
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand):
  • UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::nameForEditAction):
  • UIProcess/WebEditCommandProxy.h: Use WebCore's localization macro to make more strings localizable.
4:58 PM Changeset in webkit [84117] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Unreviewed. Add missing include to fix build without precompiled header.

  • rendering/RenderMediaControls.cpp:
4:50 PM Changeset in webkit [84116] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-17 Daniel Bates <​dbates@webkit.org>

Attempt to fix the Chromium build after changeset 84110 <​http://trac.webkit.org/changeset/84110>
(​https://bugs.webkit.org/show_bug.cgi?id=57842).

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::canRequest): Rename CachedResource::LinkPrefetch to CachedResource::LinkResource.
4:33 PM Changeset in webkit [84115] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

2011-04-17 Daniel Bates <​dbates@webkit.org>

Acknowledge Adam Barth for reviewing the patch committed in changeset
84114 <​http://trac.webkit.org/changeset/84114>. And fix my email address.

4:27 PM Changeset in webkit [84114] by dbates@webkit.org
  • 6 edits in trunk/Tools

2011-04-17 Daniel Bates <​dbates@webkit.com>

Reviewed by Eric Seidel.

webkit-patch land hangs if svn prompts for credentials
​https://bugs.webkit.org/show_bug.cgi?id=31500

Prompt for username and password when using git-svn and there aren't cached SVN credentials.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Added mixin class SVNRepository and made both class SVN and Git inherit from it.
    • Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value for argument realm; modified call sites as needed.
    • Modified AuthenticationError constructor to take optional prompt_for_password argument.
    • Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
    • Modified Git._commit_on_branch() to take optional username and password argument.
    • Modified Git.push_local_commits_to_server() to take optional username and password argument and to call has_authorization_for_realm().
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
    • Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to SVN.has_authorization_for_realm().
  • Scripts/webkitpy/common/net/credentials.py:
    • Modified Credentials.read_credentials() to call User.prompt_password() instead of using getpass.getpass() directly.
  • Scripts/webkitpy/common/system/user.py:
    • Added User.prompt_password().
  • Scripts/webkitpy/tool/steps/commit.py:
    • Modified Commit.run() to prompt for a password if needed.
4:08 PM Changeset in webkit [84113] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Remove pthread dependency of GCController
​https://bugs.webkit.org/show_bug.cgi?id=54833

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
2:49 PM Changeset in webkit [84112] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-17 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: save stderr into the layout-test-results dir
​https://bugs.webkit.org/show_bug.cgi?id=58690

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:48 PM Changeset in webkit [84111] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-17 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: read stderr from chromium DRT separately
​https://bugs.webkit.org/show_bug.cgi?id=58708

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
2:30 PM Changeset in webkit [84110] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

2011-04-17 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Add support for link rel type "subresource"
​https://bugs.webkit.org/show_bug.cgi?id=57842

Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.

During testing, I was dissapointed to see the results for the http
test below don't give the subresource priority ordering. This is
another instance of ​https://bugs.webkit.org/show_bug.cgi?id=49238
which I'll be working on next, and thus fix the test.

  • fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
  • fast/dom/HTMLLinkElement/subresource.html: Added.
  • http/tests/misc/link-rel-prefetch-and-subresource-expected.txt: Added.
  • http/tests/misc/link-rel-prefetch-and-subresource.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-04-17 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

Add support for link rel type "subresource"
​https://bugs.webkit.org/show_bug.cgi?id=57842

Link rel=prefetch is great for cache warming for resources on
subsequent pages, but it launches requests at too low a priority
to use for subresources of the current page.

Particularly after ​https://bugs.webkit.org/show_bug.cgi?id=51940
is implemented, a rel type that launches requests at an higher
priority is going to be very useful. This rel type is in the
HTML5 spec at ​http://wiki.whatwg.org/wiki/RelExtensions . An
expected use case will be for servers to provide subresource hints
in link headers, which will allow servers to help make the web
faster.

This feature continues my implementation of the Link header, which
we've talked about in WebKit-dev in
​https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html.

Tests: fast/dom/HTMLLinkElement/subresource.html

http/tests/misc/link-rel-prefetch-and-subresource.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::onloadTimerFired): (WebCore::HTMLLinkElement::notifyFinished):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
  • loader/cache/CachedResource.cpp: (WebCore::defaultPriorityForResourceType):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::isLinkResource):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestLinkResource): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::incrementRequestCount): (WebCore::CachedResourceLoader::decrementRequestCount):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedResourceRequest.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::CachedResourceRequest::load):
2:09 PM Changeset in webkit [84109] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit/mac

2011-04-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Dan Bernstein.

Assign to self in WebInspectorWindowController constructors
​https://bugs.webkit.org/show_bug.cgi?id=58749

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): (-[WebInspectorWindowController initWithInspectedWebView:]):
1:41 PM Changeset in webkit [84108] by Joseph Pecoraro
  • 4 edits
    2 adds in trunk/Source/WebKit

2011-04-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Move WebNodeHighlighter into its own file
​https://bugs.webkit.org/show_bug.cgi?id=58746

  • WebKit.xcodeproj/project.pbxproj: Add WebNodeHighlighter.{h,mm}.

2011-04-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Move WebNodeHighlighter into its own file
​https://bugs.webkit.org/show_bug.cgi?id=58746

Extract this class into its own file alongside the
other WebNodeHighlight files. In doing so do some
cleanup on WebInspectorClient removing some methods
that were never called.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): style fix.
  • WebInspector/WebNodeHighlighter.h: Added.
  • WebInspector/WebNodeHighlighter.mm: Added. (-[WebNodeHighlighter initWithInspectedWebView:]): call super init. (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
1:23 PM Changeset in webkit [84107] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
​https://bugs.webkit.org/show_bug.cgi?id=58745

Reviewed by Joseph Pecoraro.

This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
which was fixed in r83514.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
variable so named, not the top layout overflow.

12:42 PM April 2011 Meeting edited by rniwa@webkit.org
Adding myself to shadow DOM talk (diff)
12:06 PM Changeset in webkit [84106] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove WTF_PLATFORM_SGL
​https://bugs.webkit.org/show_bug.cgi?id=58743

WTF_PLATFORM_SGL and PLATFORM(SGL) are not used in the code anywhere.

  • wtf/Platform.h:
12:03 PM Changeset in webkit [84105] by ggaren@apple.com
  • 19 edits in trunk/Source/WebCore

2011-04-17 Geoffrey Garen <​ggaren@apple.com>

Strongly suggested, but not necessarily reviewed, by
Sam Weinig and Maciej Stachowiak.

Renamed DOMObject* => JSDOMWrapper*.

  • bindings/js/DOMWrapperWorld.cpp: (WebCore::isObservable): (WebCore::DOMObjectHandleOwner::finalize):
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMBinding.h: (WebCore::JSDOMWrapperWithGlobalPointer::globalObject): (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper):
  • bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMWrapper::~JSDOMWrapper):
  • bindings/js/JSDOMWrapper.h: (WebCore::JSDOMWrapper::JSDOMWrapper):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
11:59 AM Changeset in webkit [84104] by Patrick Gansterer
  • 15 edits in trunk

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CA) to USE(CA)
​https://bugs.webkit.org/show_bug.cgi?id=58742

  • wtf/Platform.h:

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CA) to USE(CA)
​https://bugs.webkit.org/show_bug.cgi?id=58742

  • config.h:
  • platform/graphics/ca/TransformationMatrixCA.cpp:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/mac/WebCoreSystemInterface.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CA) to USE(CA)
​https://bugs.webkit.org/show_bug.cgi?id=58742

  • WebProcess/WebPage/LayerTreeHost.cpp:
  • WebProcess/WebPage/win/LayerTreeHostWin.cpp: (WebKit::LayerTreeHost::supportsAcceleratedCompositing):

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CA) to USE(CA)
​https://bugs.webkit.org/show_bug.cgi?id=58742

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
7:29 AM Changeset in webkit [84103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-17 Young Han Lee <​joybro@company100.net>

Reviewed by Benjamin Poulain.

[Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
​https://bugs.webkit.org/show_bug.cgi?id=58739

gInVertexAttributeIndex is a constant variable to point the location of
"InVertex" attribute of the vertex shaders.

  • platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::drawTexture): (WebCore::TextureMapperGL::paintToTarget):
4:04 AM Changeset in webkit [84102] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-17 Kinuko Yasuda <​kinuko@chromium.org>

Not reviewed: Fix copyright (I had submitted the file with wrong
copyright line).

  • storage/StorageInfo.idl:
3:04 AM Changeset in webkit [84101] by Patrick Gansterer
  • 102 edits in trunk

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • wtf/Platform.h:

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • config.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL):
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • platform/FloatConversion.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.h:
  • platform/graphics/DashArray.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance):
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/ColorCG.cpp:
  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/TransformationMatrixCG.cpp:
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::Painter::Painter):
  • platform/graphics/chromium/PlatformCanvas.h:
  • platform/graphics/chromium/PlatformImage.cpp: (WebCore::PlatformImage::updateFromImage):
  • platform/graphics/opentype/OpenTypeUtilities.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/win/DIBPixelData.h:
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::platformInit): (WebCore::createGDIFont): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/win/GraphicsContextWin.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • rendering/RenderObject.h:
  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::reshape):
  • src/GraphicsContext3DInternal.h:
  • src/PlatformBridge.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebFrame.h:
  • WebPreferences.cpp: (WebPreferences::setFontSmoothing): (WebPreferences::setFontSmoothingContrast):
  • WebView.cpp: (systemParameterChanged):

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • Shared/ShareableBitmap.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
  • Shared/WebGraphicsContext.h:
  • Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::setFindIndicator):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): (WebKit::WebPage::drawPagesToPDF):
  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::platformPreferencesDidChange):
  • config.h:

2011-04-17 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Rename PLATFORM(CG) to USE(CG)
​https://bugs.webkit.org/show_bug.cgi?id=58729

  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect):
  • DumpRenderTree/config.h:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
  • TestWebKitAPI/PlatformWebView.h:
  • WebKitTestRunner/config.h:
  • WebKitTestRunner/win/TestInvocationWin.cpp:

Apr 16, 2011:

11:29 PM Changeset in webkit [84100] by commit-queue@webkit.org
  • 3 edits
    14 adds in trunk/Source/WebKit/qt

2011-04-16 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Autotest got missed in the handover of the QML WebView element
​https://bugs.webkit.org/show_bug.cgi?id=41449

Importing WebView QML element test cases from Qt repository. I did some
style modifications and simplifications in the original code but hopefully
without changing the behavior.

Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
issues currently are:

  • pixelCache() test checked the usage of pixel cache by using a subclass of QDeclarativeWebView. We can't do that right now because this class is not exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want this kind of test.
  • elementAtArea() test uses a function that is not exported. But in this case I think we should test it's user, the public method "heuristicZoom".
  • tests/qdeclarativewebview/resources/basic.html: Added.
  • tests/qdeclarativewebview/resources/basic.png: Added.
  • tests/qdeclarativewebview/resources/basic.qml: Added.
  • tests/qdeclarativewebview/resources/elements.html: Added.
  • tests/qdeclarativewebview/resources/elements.qml: Added.
  • tests/qdeclarativewebview/resources/forward.html: Added.
  • tests/qdeclarativewebview/resources/forward.png: Added.
  • tests/qdeclarativewebview/resources/javaScript.html: Added.
  • tests/qdeclarativewebview/resources/javaScript.qml: Added.
  • tests/qdeclarativewebview/resources/loadError.qml: Added.
  • tests/qdeclarativewebview/resources/newwindows.html: Added.
  • tests/qdeclarativewebview/resources/newwindows.qml: Added.
  • tests/qdeclarativewebview/resources/propertychanges.qml: Added.
  • tests/qdeclarativewebview/resources/sethtml.qml: Added.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: (tst_QDeclarativeWebView::tmpDir): (strippedHtml): (fileContents): (removeRecursive): (tst_QDeclarativeWebView::cleanupTestCase): (tst_QDeclarativeWebView::basicProperties): (tst_QDeclarativeWebView::elementAreaAt): (tst_QDeclarativeWebView::historyNav): (callEvaluateJavaScript): (tst_QDeclarativeWebView::javaScript): (tst_QDeclarativeWebView::loadError): (tst_QDeclarativeWebView::multipleWindows): (tst_QDeclarativeWebView::newWindowComponent): (tst_QDeclarativeWebView::newWindowParent): (tst_QDeclarativeWebView::pressGrabTime): (tst_QDeclarativeWebView::renderingEnabled): (tst_QDeclarativeWebView::setHtml): (tst_QDeclarativeWebView::settings): (tst_QDeclarativeWebView::checkNoErrors):
  • tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
7:25 PM Changeset in webkit [84099] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-04-16 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

about:blank documents in new tabs can XHR anywhere
​https://bugs.webkit.org/show_bug.cgi?id=58712

Empty security origins have supposed to be low-privilege, we should
mark them as having a unique origin.

  • manual-tests/about-blank-xhr.html: Added.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • page/SecurityOrigin.h:
5:20 PM Changeset in webkit [84098] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Updated results for fast/block/float/032.html after r84096. Filed ​http://webkit.org/b/58736 to
track this change.

  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/mac/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/032-expected.txt:
3:51 PM Changeset in webkit [84097] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt][WK2] Unskip fast/loader/null-request-after-willSendRequest.html since
it is passing for a long time.

  • platform/qt-wk2/Skipped:
2:59 PM Changeset in webkit [84096] by mitz@apple.com
  • 6 edits
    4 adds in trunk

<rdar://problem/9190108> Crash when hiding a float

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/float/overhanging-tall-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverhangingFloats): Moved the call to childLogicalTop() out of the loop.
Capped the logical bottom so that we get the correct maximum.

  • rendering/RenderBlock.h: Decleared appendFloatingObjectToLastLine().
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendFloatingObjectToLastLine): Added. Ensures correct bookkeeping by
extending the float if needed so that it touches the line.
(WebCore::RenderBlock::layoutInlineChildren): Changed to call appendFloatingObjectToLastLine().
(WebCore::RenderBlock::checkFloatsInCleanLine): Capped the float height so the we mark the right
range of lines as dirty.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::appendFloat): Replaced the floats() accessor with this function, which
allows the creation of the vector to be combined with appending the first float.

LayoutTests:

  • fast/block/float/overhanging-tall-block.html: Added.
  • platform/mac/fast/block/float/overhanging-tall-block-expected.checksum: Added.
  • platform/mac/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt: Added.
2:22 PM Changeset in webkit [84095] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Crash when NPP_Write returns -1 when writing the manual stream
​https://bugs.webkit.org/show_bug.cgi?id=58735
<rdar://problem/9124993>

If NPP_Write returns -1 we must cancel the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::deliverDataToPlugin):
2:19 PM Changeset in webkit [84094] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit/win

2011-04-16 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Windows should use WebCore localized strings
<rdar://problem/9119405>
​https://bugs.webkit.org/show_bug.cgi?id=58733

  • WebCoreSupport/WebEditorClient.cpp: (undoNameForEditAction): (WebEditorClient::registerCommandForUndo):
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
  • WebURLResponse.cpp: (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): (WebURLResponse::localizedStringForStatusCode): Change to use WEB_UI_STRING.
  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebPlatformStrategies.h: Remove the localization strategy in favor of using the default one.
2:15 PM Changeset in webkit [84093] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

2011-04-16 Simon Fraser <Simon Fraser>

Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
​https://bugs.webkit.org/show_bug.cgi?id=58734

Add result for new test.

  • platform/mac/fast/borders/webkit-border-radius-expected.checksum: Added.
  • platform/mac/fast/borders/webkit-border-radius-expected.png: Added.
  • platform/mac/fast/borders/webkit-border-radius-expected.txt: Added.
2:13 PM Changeset in webkit [84092] by Simon Fraser
  • 34 edits
    1 add in trunk/LayoutTests

2011-04-16 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
​https://bugs.webkit.org/show_bug.cgi?id=58734

Drop the -webkit prefix on border-radius in the tests, and remove -moz-border-radius,
since Firefox supports the unprefixed property now. This avoids the problem where
-moz-border-radius and -webkit-border-radius had different behaviors when given two values.

Also unprefix box-sizing for WebKit, and add a -moz prefixed version for Firefox.

Add a test that compares the behavior of -webkit-border-radius and border-radius with
two values.

  • fast/borders/border-radius-circle.html:
  • fast/borders/border-radius-constraints.html:
  • fast/borders/border-radius-groove-01.html:
  • fast/borders/border-radius-groove-02.html:
  • fast/borders/border-radius-groove-03.html:
  • fast/borders/border-radius-wide-border-01.html:
  • fast/borders/border-radius-wide-border-02.html:
  • fast/borders/border-radius-wide-border-03.html:
  • fast/borders/border-radius-wide-border-04.html:
  • fast/borders/borderRadiusAllStylesAllCorners.html:
  • fast/borders/borderRadiusArcs01.html:
  • fast/borders/borderRadiusDashed01.html:
  • fast/borders/borderRadiusDashed02.html:
  • fast/borders/borderRadiusDashed03.html:
  • fast/borders/borderRadiusDashed04.html:
  • fast/borders/borderRadiusDashed05.html:
  • fast/borders/borderRadiusDashed06.html:
  • fast/borders/borderRadiusDotted01.html:
  • fast/borders/borderRadiusDotted02.html:
  • fast/borders/borderRadiusDotted03.html:
  • fast/borders/borderRadiusDotted04.html:
  • fast/borders/borderRadiusDotted05.html:
  • fast/borders/borderRadiusDotted06.html:
  • fast/borders/borderRadiusDouble02.html:
  • fast/borders/borderRadiusDouble03.html:
  • fast/borders/borderRadiusDouble04.html:
  • fast/borders/borderRadiusDouble05.html:
  • fast/borders/borderRadiusDouble06.html:
  • fast/borders/borderRadiusDouble07.html:
  • fast/borders/borderRadiusDouble08.html:
  • fast/borders/borderRadiusDouble09.html:
  • fast/borders/borderRadiusGroove01.html:
  • fast/borders/borderRadiusGroove02.html:
  • fast/borders/webkit-border-radius.html: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
  • platform/mac/fast/borders/border-radius-groove-01-expected.png:
  • platform/mac/fast/borders/border-radius-groove-02-expected.png:
  • platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
  • platform/mac/fast/borders/border-radius-groove-03-expected.png:
  • platform/mac/fast/borders/border-radius-inline-flow-expected.png:
  • platform/mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed04-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed05-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed06-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed06-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted01-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted04-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted05-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble02-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble04-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble05-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble07-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble07-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble08-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble09-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble09-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove01-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/mac/fast/borders/borderRadiusOutset01-expected.png:
  • platform/mac/fast/borders/borderRadiusRidge01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid02-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid03-expected.png:
12:31 PM Changeset in webkit [84091] by weinig@apple.com
  • 9 edits in trunk/Source

2011-04-16 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Pages in the PageCache don't have the correct visited link coloring after being restored
​https://bugs.webkit.org/show_bug.cgi?id=58721

  • WebCore.exp.in: Add export of markPagesForVistedLinkStyleRecalc for use by WebKit2.
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
  • history/CachedPage.h: (WebCore::CachedPage::markForVistedLinkStyleRecalc): Add bit, set by calling markForVistedLinkStyleRecalc, which forces a visited link style recalc when being restored.
  • history/PageCache.h:
  • history/PageCache.cpp: (WebCore::PageCache::markPagesForVistedLinkStyleRecalc): Mark all pages in the page cache as requiring visited link style recalc.
  • page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLink): (WebCore::PageGroup::removeVisitedLinks): (WebCore::PageGroup::removeAllVisitedLinks): Set dirty bit when changing any visited link information.


2011-04-16 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Pages in the PageCache don't have the correct visited link coloring after being restored
​https://bugs.webkit.org/show_bug.cgi?id=58721

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::visitedLinkStateChanged): (WebKit::WebProcess::allVisitedLinkStateChanged): Mark all pages in the page cache as needing visited link style recalc whenever visited link information changes.
11:37 AM Changeset in webkit [84090] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-16 Leo Yang <​leoyang.webkit@gmail.com>

Reviewed by Nikolas Zimmermann.

ASSERT failure when svg <use> element changes href
​https://bugs.webkit.org/show_bug.cgi?id=58726

Test case to verify assertion at line 509 of SVGUseElement.cpp.
Test passes if no crash occurs in debug mode.

  • svg/custom/use-crash-when-href-change-expected.txt: Added.
  • svg/custom/use-crash-when-href-change.svg: Added.

2011-04-16 Leo Yang <​leoyang.webkit@gmail.com>

Reviewed by Nikolas Zimmermann.

ASSERT failure when svg <use> element changes href
​https://bugs.webkit.org/show_bug.cgi?id=58726

m_resourceId was not empty after the pending resource
becomes available. This will trigger the assertion at
line 509 of SVGUseElement.cpp when the <use> element's
href becomes empty or invalid.

This patch makes m_resourceId be empty after the pending
resource becomes available to avoid assertion failure.

Test: svg/custom/use-crash-when-href-change.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource):
3:55 AM Changeset in webkit [84089] by Patrick Gansterer
  • 2 edits in trunk

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(CAIRO) to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=55192

  • Source/cmake/OptionsEfl.cmake:
3:37 AM Changeset in webkit [84088] by Patrick Gansterer
  • 41 edits in trunk

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(CAIRO) to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=55192

  • wtf/Platform.h:
  • wtf/gobject/GTypedefs.h:

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(CAIRO) to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=55192

  • CMakeListsEfl.txt:
  • config.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/DashArray.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::add):
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/DrawErrorUnderline.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageCairo.cpp:
  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/win/GraphicsContextWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintWindowedPluginIntoContext):
  • rendering/RenderObject.h:

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(CAIRO) to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=55192

  • WebFrame.cpp: (WebFrame::spoolPages):
  • WebFrame.h:

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(CAIRO) to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=55192

  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/config.h:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
  • WebKitTestRunner/config.h:
3:12 AM Changeset in webkit [84087] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-04-16 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r84033.

  • platform/win/LocalizedStringsWin.cpp: (WebCore::localizedString):
2:33 AM Changeset in webkit [84086] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-16 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

show diffs+test inline in the results page
​https://bugs.webkit.org/show_bug.cgi?id=58723

Put each row in it's own tbody and sort based on tbodies. That way
we can append the results to the tbody inline as another table row.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
2:02 AM Changeset in webkit [84085] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-04-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Tests that we do not crash when adding a list item block child
as a before child to svg text.
​https://bugs.webkit.org/show_bug.cgi?id=58678

  • svg/text/text-block-child-crash-expected.txt: Added.
  • svg/text/text-block-child-crash.xhtml: Added.

2011-04-16 Abhishek Arya <​inferno@chromium.org>

Reviewed by Nikolas Zimmermann.

Only allow inline child for SVG text since we cannot
handle block childs.
​https://bugs.webkit.org/show_bug.cgi?id=58678

Test: svg/text/text-block-child-crash.xhtml

  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::isChildAllowed):
  • rendering/svg/RenderSVGText.h:
1:47 AM Changeset in webkit [84084] by sergio@webkit.org
  • 46 edits in trunk/LayoutTests

2011-04-16 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, new GTK+ test expectations after r84039.

  • platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-1-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-expected.txt:
  • platform/gtk/fast/html/details-no-summary1-expected.txt:
  • platform/gtk/fast/html/details-no-summary2-expected.txt:
  • platform/gtk/fast/html/details-no-summary3-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open1-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open3-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-open5-expected.txt:
  • platform/gtk/fast/html/details-open6-expected.txt:
  • platform/gtk/fast/html/details-position-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
12:28 AM Changeset in webkit [84083] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-16 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

handle new tests in the new results html file
​https://bugs.webkit.org/show_bug.cgi?id=58715

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:

Apr 15, 2011:

11:22 PM Changeset in webkit [84082] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-15 Daniel Bates <​dbates@webkit.org>

Attempt to fix the Qt Linux Release build after changeset 84064 <​http://trac.webkit.org/changeset/84064>
(​https://bugs.webkit.org/show_bug.cgi?id=58686).

  • UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().
10:41 PM Changeset in webkit [84081] by loislo@chromium.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r84067.
​http://trac.webkit.org/changeset/84067
​https://bugs.webkit.org/show_bug.cgi?id=58724

qt build are failing. (Requested by loislo2 on #webkit).

  • heap/MarkStack.h: (JSC::MarkStack::append):
  • runtime/JSValue.h:
  • runtime/WriteBarrier.h: (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::operator==):
10:32 PM Changeset in webkit [84080] by loislo@chromium.org
  • 7 edits in trunk

2011-04-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=57833

  • http/tests/inspector-enabled/database-open.html:

2011-04-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=57833

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/front-end/inspector.js:
9:40 PM Changeset in webkit [84079] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-15 John Bates <​jbates@google.com>

Reviewed by Kenneth Russell.

Change WebGraphicsContext3D virtuals to pure virtuals as intended
​https://bugs.webkit.org/show_bug.cgi?id=58479

  • public/WebGraphicsContext3D.h:
9:35 PM Changeset in webkit [84078] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

2011-04-15 Jia Pu <​jpu@apple.com>

Reviewed by Dan Bernstein.

[Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
​https://bugs.webkit.org/show_bug.cgi?id=58717

Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.

  • WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::show):
9:23 PM Changeset in webkit [84077] by abarth@webkit.org
  • 5 edits
    6 adds in trunk

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP media-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58642

These tests are adapted from the other media loading tests.

  • http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/media-src-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/media-src-blocked.html: Added.

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP media-src is missing
​https://bugs.webkit.org/show_bug.cgi?id=58642

Yay HTMLMediaElement for having the exact hook we need!

Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html

http/tests/security/contentSecurityPolicy/media-src-blocked.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
    • Although it's tempting to add this branch to the previous if-block, that results in the wrong error message being logged to the console (covered by the "blocked" test).
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
    • These changes are routine.
8:59 PM Changeset in webkit [84076] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

old-run-webkit-tests: save the list of tests actually run to a file
​https://bugs.webkit.org/show_bug.cgi?id=58692

  • Scripts/old-run-webkit-tests:
8:40 PM Changeset in webkit [84075] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

fix MockFileSystem.abspath() on windows
​https://bugs.webkit.org/show_bug.cgi?id=58713

The existing code was borked on Windows if a path was passed
in using a drive letter (e.g., "d:\foo.txt"), and would go
into an infinite recursive loop. While win paths shouldn't
normally be passed into the mock filesystem, this just
bulletproofs things a bit (note that "/foo.txt" is considered
an absolute path on windows python as well.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
8:02 PM Changeset in webkit [84074] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

show stderr files and httpd log files
​https://bugs.webkit.org/show_bug.cgi?id=58714

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
7:33 PM Changeset in webkit [84073] by abarth@webkit.org
  • 9 edits
    8 adds in trunk

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block string arguments to setTimeout and setInterval unless options eval-script
​https://bugs.webkit.org/show_bug.cgi?id=58610

Herein lies a four-way testing matrix.

  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block string arguments to setTimeout and setInterval unless options eval-script
​https://bugs.webkit.org/show_bug.cgi?id=58610

It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.

Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html

http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
  • bindings/js/ScheduledAction.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowEval):
  • page/ContentSecurityPolicy.h:
7:26 PM Changeset in webkit [84072] by commit-queue@webkit.org
  • 16 edits in trunk

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

Initial draft at:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0175.html

  • configure.ac:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • features.gypi:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • Scripts/build-webkit:

2011-04-15 Shishir Agrawal <​shishir@chromium.org>

Reviewed by James Robinson.

Add a flag to guard Page Visibility API changes.
​https://bugs.webkit.org/show_bug.cgi?id=58464

  • win/tools/vsprops/FeatureDefines.vsprops:
7:06 PM Changeset in webkit [84071] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Make plugins compile during WebKit GTK Windows build.
Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=58580

  • plugins/PluginView.cpp: (WebCore::PluginView::stop):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformGetValue): (WebCore::PluginView::platformStart):
6:53 PM Changeset in webkit [84070] by commit-queue@webkit.org
  • 5 edits in trunk

2011-04-15 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

When a message with url embedded is added to console, the "file:" scheme
and path should be stripped.
​https://bugs.webkit.org/show_bug.cgi?id=58665

Unskip passed tests.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-04-15 Chang Shu <​cshu@webkit.org>

Reviewed by Alexey Proskuryakov.

When a message with url embedded is added to console, the "file:" scheme
and path should be stripped.
​https://bugs.webkit.org/show_bug.cgi?id=58665

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent): (WTR::InjectedBundlePage::willAddMessageToConsole):
6:19 PM Changeset in webkit [84069] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Errrk! - build fix from !x86-64.

  • dfg/DFGNode.h:
6:16 PM Changeset in webkit [84068] by levin@chromium.org
  • 2 edits
    2 deletes in trunk/Source/JavaScriptCore

Revert of r83974.

JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=58716

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/tests/RunAllWtfTests.cpp: Removed.
  • wtf/tests/StringTests.cpp: Removed.
6:11 PM Changeset in webkit [84067] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove DeprecatedPtr
​https://bugs.webkit.org/show_bug.cgi?id=58718

As simple as it sounds.

  • heap/MarkStack.h: (JSC::MarkStack::append):
  • runtime/JSValue.h:
  • runtime/WriteBarrier.h:
5:49 PM Changeset in webkit [84066] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

2011-04-15 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
​https://bugs.webkit.org/show_bug.cgi?id=58512

Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
This change keeps an small refactoring on
FrameView::shouldUpdate(), which doesn't affect on the behavior.

  • dom/Document.cpp:
  • dom/Document.h:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::shouldUpdate):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
5:42 PM Changeset in webkit [84065] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-15 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Reduce default kernel size of SincResampler to favor better speed over quality
​https://bugs.webkit.org/show_bug.cgi?id=58710

No new tests since audio API is not yet implemented.

  • platform/audio/SincResampler.h:
5:38 PM Changeset in webkit [84064] by jeffm@apple.com
  • 22 edits in trunk

2011-04-15 Jeff Miller <​jeffm@apple.com>

Reviewed by Sam Weinig.

Add takeFocus callback to WKPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=58686

On Windows, we need to handle moving focus out of the web view in the client, so add a takeFocus callback to WKPageUIClient
and stop handling taking focus in the framework in WKView.mm on the Mac.

  • UIProcess/API/C/WKPage.h: Added WKFocusDirection enum and takeFocus to WKPageUIClient.
  • UIProcess/API/mac/PageClientImpl.h: Removed takeFocus().
  • UIProcess/API/mac/PageClientImpl.mm: Removed takeFocus().
  • UIProcess/API/mac/WKView.mm: Removed _takeFocus().
  • UIProcess/API/mac/WKViewInternal.h: Removed _takeFocus().
  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_takeFocus): Added.
  • UIProcess/API/qt/ClientImpl.h: Added qt_wk_takeFocus.
  • UIProcess/API/qt/qwkpage.cpp: Remove takeFocus(). (QWKPage::QWKPage): Added takeFocus() callback.
  • UIProcess/PageClient.h: Removed takeFocus().
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::takeFocus): Call m_uiClient to take focus.
  • UIProcess/WebPageProxy.h: Pass FocusDirection as a uint32_t to takeFocus().
  • UIProcess/WebPageProxy.messages.in: Pass FocusDirection as a uint32_t in TakeFocus message.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::takeFocus): Added.
  • UIProcess/WebUIClient.h: Added takeFocus().
  • UIProcess/win/WebView.cpp: Removed takeFocus(), which was never implemented on Windows.
  • UIProcess/win/WebView.h: Removed takeFocus().
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::takeFocus): Pass FocusDirection as a uint32_t in TakeFocus message.

2011-04-15 Jeff Miller <​jeffm@apple.com>

Reviewed by Sam Weinig.

Add takeFocus callback to WKPageUIClient
​https://bugs.webkit.org/show_bug.cgi?id=58686

Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Added empty takeFocus entry.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Added empty takeFocus entry. (WTR::TestController::initialize): Added empty takeFocus entry.
5:37 PM Changeset in webkit [84063] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add a simple tool to gather statistics on whether functions
are completed through the new or old JIT.

Reviewed by Oliver Hunt.

  • dfg/DFGNode.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

5:33 PM Changeset in webkit [84062] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Sam Weinig.

WebKit2: Stop using deprecated NSInputManager
​https://bugs.webkit.org/show_bug.cgi?id=58709

Changed all mouse related functions to give NSInputContext a chance to handle the event,
added logging. Removed -rightMouseMoved: method, which was added by accident.

  • UIProcess/API/mac/WKView.mm: (-[WKView mouseMoved:]): (-[WKView mouseDown:]): (-[WKView mouseUp:]): (-[WKView mouseDragged:]):
5:26 PM Changeset in webkit [84061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
These have to be defined for Windows in general, since win32 API
does not provide them.
​https://bugs.webkit.org/show_bug.cgi?id=58582

  • platform/graphics/WOFFFileFormat.cpp:
5:21 PM Changeset in webkit [84060] by commit-queue@webkit.org
  • 6 edits in trunk

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Adam Barth.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

Added console message when X-Frame-Options headers block resource loading

  • http/tests/inspector/network/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Adam Barth.

Show a console message when X-Frame-Options blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=39087

Added console message when X-Frame-Options headers block resource loading

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
5:17 PM Changeset in webkit [84059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
test. This allows Windows build of WebKit GTK to chose the right
path.
​https://bugs.webkit.org/show_bug.cgi?id=58576

  • platform/FileSystem.h:
5:14 PM Changeset in webkit [84058] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Potential crash getting a JS wrapper.

<rdar://problem/8988741>

Reviewed by Brian Weinstein.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsWrapperForWorld):
Ensure that we have a valid m_coreFrame, because it can be cleared by
invalidate().

5:05 PM Changeset in webkit [84057] by luiz@webkit.org
  • 15 edits
    2 copies
    27 adds in trunk

[Qt] QWebPage MIME type handling inconsistency with other web browsers
​https://bugs.webkit.org/show_bug.cgi?id=46968

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
​http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

  • WebCore.pro:
  • platform/network/MIMESniffing.cpp: Added.

(MagicNumbers::dataSizeNeededForImageSniffing):
(MagicNumbers::maskedCompare):
(MagicNumbers::checkSpaceOrBracket):
(MagicNumbers::compare):
(MagicNumbers::findMIMEType):
(MagicNumbers::findSimpleMIMEType):
(MagicNumbers::textOrBinaryTypeSniffingProcedure):
(MagicNumbers::unknownTypeSniffingProcedure):
(MagicNumbers::imageTypeSniffingProcedure):
(MagicNumbers::checkText):
(MagicNumbers::checkRDF):
(MagicNumbers::skipTag):
(MagicNumbers::feedTypeSniffingProcedure):
(MIMESniffer::MIMESniffer):

  • platform/network/MIMESniffing.h: Added.

(MIMESniffer::dataSize):
(MIMESniffer::sniff):
(MIMESniffer::isValid):

  • platform/network/NetworkingContext.h:
  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyWrapper::advertisedMIMEType):
(WebCore::QNetworkReplyWrapper::mimeType):

  • platform/network/qt/QtMIMETypeSniffer.cpp: Added.

(QtMIMETypeSniffer::QtMIMETypeSniffer):
(QtMIMETypeSniffer::sniff):
(QtMIMETypeSniffer::trySniffing):

  • platform/network/qt/QtMIMETypeSniffer.h: Added.

(QtMIMETypeSniffer::mimeType):
(QtMIMETypeSniffer::isFinished):

Source/WebKit/qt:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
​http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createNetworkingContext):

  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):

  • WebCoreSupport/FrameNetworkingContextQt.h:
  • tests/MIMESniffing/MIMESniffing.pro: Added.
  • tests/MIMESniffing/TestData.h: Added.
  • tests/MIMESniffing/resources.qrc: Added.
  • tests/MIMESniffing/resources/application_atom+xml: Added.
  • tests/MIMESniffing/resources/application_ogg: Added.
  • tests/MIMESniffing/resources/application_pdf: Added.
  • tests/MIMESniffing/resources/application_postscript: Added.
  • tests/MIMESniffing/resources/application_rdf+xml: Added.
  • tests/MIMESniffing/resources/application_rss+xml: Added.
  • tests/MIMESniffing/resources/application_x-gzip: Added.
  • tests/MIMESniffing/resources/application_x-rar-compressed: Added.
  • tests/MIMESniffing/resources/application_zip: Added.
  • tests/MIMESniffing/resources/audio_x-wave: Added.
  • tests/MIMESniffing/resources/image_bmp: Added.
  • tests/MIMESniffing/resources/image_gif: Added.
  • tests/MIMESniffing/resources/image_jpeg: Added.
  • tests/MIMESniffing/resources/image_png: Added.
  • tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
  • tests/MIMESniffing/resources/image_webp: Added.
  • tests/MIMESniffing/resources/text_html: Added.
  • tests/MIMESniffing/resources/text_xml: Added.
  • tests/MIMESniffing/resources/video_webm: Added.
  • tests/MIMESniffing/tst_MIMESniffing.cpp: Added.

(tst_MIMESniffing::tst_MIMESniffing):
(errorText):
(tst_MIMESniffing::testCase1):

  • tests/tests.pro:

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
​http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::MIMESniffingEnabled):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

LayoutTests:

Rubberstamped by Andreas Kling.

Unskipping http/tests/loading/text-content-type-with-binary-extension.html.

  • platform/qt/Skipped:
5:03 PM Changeset in webkit [84056] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-15 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

input field with focus makes appendChild operation ~42x slower
​https://bugs.webkit.org/show_bug.cgi?id=57059

Add performance test for cloneNode when an input field has focus.

  • perf/clone-with-focus-expected.txt: Added.
  • perf/clone-with-focus.html: Added.

2011-04-15 Emil A Eklund <​eae@chromium.org>

Reviewed by Dimitri Glazkov.

input field with focus makes appendChild operation ~42x slower
​https://bugs.webkit.org/show_bug.cgi?id=57059

Change ContainerNode::cloneChildNodes to only disable the
deleteButtonController if the container itself (or any of its children)
is being edited. Thus avoiding a reflow in cases where it's not.

Test: perf/clone-with-focus.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
5:01 PM Changeset in webkit [84055] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-15 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=44079

Remove an assert whose invariant doesn't hold.

  • platform/chromium/test_expectations.txt: Re-enable test.

2011-04-15 Charlie Reis <​creis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=44079

Remove an assert whose invariant doesn't hold.

  • src/FrameLoaderClientImpl.cpp:
4:59 PM Changeset in webkit [84054] by ojan@chromium.org
  • 4 edits in trunk/Tools

2011-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

only show pretty-diff/wdiff if they were generated
​https://bugs.webkit.org/show_bug.cgi?id=58682

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
4:58 PM Changeset in webkit [84053] by kinuko@chromium.org
  • 23 edits
    8 adds in trunk

2011-04-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose unified Quota API if QUOTA build flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58648

  • src/AssertMatchingEnums.cpp: Added enum assertions.
  • src/StorageInfoChromium.cpp: Made a build fix.

2011-04-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose unified Quota API if QUOTA build flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58648

Test: storage/storageinfo-query-usage.html

  • CMakeLists.txt: Added new file entries.
  • DerivedSources.cpp: Added new file entries.
  • DerivedSources.make: Added new file entries.
  • GNUmakefile.am: Added new file entries.
  • WebCore.gypi: Added new file entries.
  • WebCore.vcproj/WebCore.vcproj: Added new file entries.
  • WebCore.xcodeproj/project.pbxproj: Added new file entries.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitStorageInfo): Added.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/StorageInfo.h: Added storage type enum.
  • storage/StorageInfo.idl: Added.
  • storage/StorageInfoErrorCallback.idl: Added.
  • storage/StorageInfoUsageCallback.idl: Added.

2011-04-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Expose unified Quota API if QUOTA build flag is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58648

Added a layout test, also added skipped entries on platforms
where the QUOTA flag is not enabled.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/script-tests/TEMPLATE.html: Added.
  • storage/script-tests/storageinfo-query-usage.js: Added.
  • storage/storageinfo-query-usage-expected.txt: Added.
  • storage/storageinfo-query-usage.html: Added.
4:55 PM Changeset in webkit [84052] by oliver@apple.com
  • 191 edits in trunk

2011-04-15 Oliver Hunt <​oliver@apple.com>

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Rolling r83894 r83827 r83810 r83809 r83808 back in with
a workaround for the gcc bug seen by the gtk bots

4:51 PM Changeset in webkit [84051] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
​http://www.webkit.org/demos/calendar.
​https://bugs.webkit.org/show_bug.cgi?id=58698

Reviewed by Brian Weinstein.

  • platform/win/FileSystemWin.cpp:

(WebCore::openFile):
Add breaks to the case statement.
(WebCore::directoryName):
Remove any trailing slash in directoryName. After closer inspection of all callers, it
appears the that callers do not need the trailing slash, and those that use the length do
so only to change the direction of the slashes throughout the length of the path.

4:47 PM Changeset in webkit [84050] by rolandsteiner@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-04-15 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
​https://bugs.webkit.org/show_bug.cgi?id=52963

.) Change base class of ShadowRoot from DocumentFragment to TreeScope.
.) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
.) Merged setTreeScope() with setTreeScopeRecursively()
.) Call setTreeScopeRecursively in DOM manipulation functions where applicable.

No new tests. (refactoring)

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::ContainerNode::removeBetween): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::parserAddChild):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::setDocType):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::treeScope): (WebCore::Node::setTreeScopeRecursively):
  • dom/Node.h: (WebCore::Node::document):
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::ShadowRoot): (WebCore::ShadowRoot::~ShadowRoot): (WebCore::ShadowRoot::nodeType): (WebCore::ShadowRoot::cloneNode): (WebCore::ShadowRoot::childTypeAllowed):
  • dom/ShadowRoot.h: (WebCore::toShadowRoot):
  • dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::setParentTreeScope):
  • dom/TreeScope.h:
  • rendering/RenderSlider.cpp:
4:38 PM Changeset in webkit [84049] by ggaren@apple.com
  • 6 edits in trunk/Source/WebCore

2011-04-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

DOM object handles are never removed from cache
​https://bugs.webkit.org/show_bug.cgi?id=58707

We were trying to remove hash table items by value instead of by key.

  • bindings/js/DOMWrapperWorld.cpp: (WebCore::JSNodeHandleOwner::finalize): Changed to work more like DOMObjectHandleOwner::finalize because I'm going to merge them.

(WebCore::DOMObjectHandleOwner::finalize): Remove hash table items
by key, not value. (Oops!) Use a helper function to make sure we get
this right.

  • bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMObjectWrapper): Store the hash table key as our weak handle context, so we can use it at destruction time.
  • bindings/js/JSDOMBinding.h: Removed unnecessary include.
  • bindings/js/JSNodeCustom.h: (WebCore::cacheDOMNodeWrapper): Store the hash table key as our weak handle context, so we can use it at destruction time.
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::setWrapper): Forward context parameter, to support the above.
4:35 PM Changeset in webkit [84048] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Gavin Barraclough.

Correctly prefix symbols. Since gcc 4.5.0, Windows x64 symbols
are not prefixed by underscore anymore. This is consistent with
what MSVC does.
​https://bugs.webkit.org/show_bug.cgi?id=58573

  • jit/JITStubs.cpp:
4:33 PM WebKit Team edited by dcheng@chromium.org
(diff)
4:10 PM Changeset in webkit [84047] by xan@webkit.org
  • 2 edits in trunk

2011-04-15 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

  • configure.ac: bump to 1.5.0, 1.4.0 will be released from a branch and was already cut off.
4:03 PM Changeset in webkit [84046] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

2011-04-15 Kenneth Russell <​kbr@google.com>

Unreviewed. Chromium Linux Release build fix due to unused variables.

  • platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup):
4:02 PM Changeset in webkit [84045] by barraclough@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Bug 58705 - DFG JIT Add support for flow control (branch, jump).

Reviewed by Geoff Garen.

Add support for control flow by breaking the CodeBlock up into multiple
basic blocks, generating code for each basic block in turn through the
speculative JIT & then the non-speculative JIT.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeOffset):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
(JSC::DFG::JITCodeGenerator::addBranch):
(JSC::DFG::JITCodeGenerator::linkBranches):
(JSC::DFG::JITCodeGenerator::BranchRecord::BranchRecord):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::takenBytecodeOffset):
(JSC::DFG::Node::notTakenBytecodeOffset):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
3:56 PM Changeset in webkit [84044] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build change after r83945.

New 'PlatformPathCairo.cpp' was not added to the WinCairo build.

  • WebCore.vcproj/WebCore.vcproj: Add missing file to WinCairo build. Exclude for standard Apple build.
3:54 PM Changeset in webkit [84043] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add API to get the bundle page overlay fade in fraction.

Reviewed by Sam Weinig.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayFractionFadedIn):

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
3:44 PM April 2011 Meeting edited by morrita@google.com
(diff)
3:31 PM Changeset in webkit [84042] by andersca@apple.com
  • 5 edits in trunk/Source

2011-04-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Fade the find page overlay
​https://bugs.webkit.org/show_bug.cgi?id=58697

Add a symbol that WebKit2 needs.

  • WebCore.exp.in:

2011-04-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Fade the find page overlay
​https://bugs.webkit.org/show_bug.cgi?id=58697

  • WebProcess/WebPage/FindController.cpp: Make the color components floats.

(WebKit::overlayBackgroundColor):
(WebKit::holeShadowColor):
(WebKit::holeFillColor):
Add helper functions for returning the colors given the fraction faded in.

(WebKit::FindController::drawRect):
Use the new helper functions.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Start the fade animation unless we're replacing an already existing page overlay with another.
3:30 PM Changeset in webkit [84041] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 58701 - DFG JIT - add GetLocal/SetLocal nodes

Reviewed by Geoff Garen.

Use these for both access to arguments & local variables, adds ability
to set locals, such that values will persist between basic blocks.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::VariableRecord::VariableRecord):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::derefChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::local):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:17 PM Changeset in webkit [84040] by andreas.kling@nokia.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-04-15 Andreas Kling <​kling@webkit.org>

Unreviewed, remove a Qt-specific expectation that's no longer needed.

  • platform/qt/Skipped:
  • platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Removed.
2:56 PM Changeset in webkit [84039] by morrita@google.com
  • 154 edits
    2 adds
    4 deletes in trunk

2011-04-15 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderDetailsMarker should belong to shadow element.
​https://bugs.webkit.org/show_bug.cgi?id=58591

  • Render tree structure has changed.
  • Changed style rule on details-writing-mode.html to avoid to hit shadow CSS leak bug.
  • fast/html/details-writing-mode.html:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.checksum:
  • platform/mac/fast/html/details-add-summary-1-expected.png:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.checksum:
  • platform/mac/fast/html/details-add-summary-10-expected.png:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.checksum:
  • platform/mac/fast/html/details-add-summary-2-expected.png:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.checksum:
  • platform/mac/fast/html/details-add-summary-3-expected.png:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.checksum:
  • platform/mac/fast/html/details-add-summary-4-expected.png:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.checksum:
  • platform/mac/fast/html/details-add-summary-5-expected.png:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.checksum:
  • platform/mac/fast/html/details-add-summary-6-expected.png:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.checksum:
  • platform/mac/fast/html/details-add-summary-7-expected.png:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.checksum:
  • platform/mac/fast/html/details-add-summary-8-expected.png:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.checksum:
  • platform/mac/fast/html/details-add-summary-9-expected.png:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.checksum:
  • platform/mac/fast/html/details-no-summary1-expected.png:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.checksum:
  • platform/mac/fast/html/details-no-summary2-expected.png:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.checksum:
  • platform/mac/fast/html/details-no-summary3-expected.png:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.checksum:
  • platform/mac/fast/html/details-no-summary4-expected.png:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.checksum:
  • platform/mac/fast/html/details-open-javascript-expected.png:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.checksum:
  • platform/mac/fast/html/details-open1-expected.png:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.checksum:
  • platform/mac/fast/html/details-open2-expected.png:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.checksum:
  • platform/mac/fast/html/details-open3-expected.png:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.checksum:
  • platform/mac/fast/html/details-open4-expected.png:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.checksum:
  • platform/mac/fast/html/details-open5-expected.png:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.checksum:
  • platform/mac/fast/html/details-open6-expected.png:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.checksum:
  • platform/mac/fast/html/details-position-expected.png:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-1-expected.png:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-2-expected.png:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-3-expected.png:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-4-expected.png:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-5-expected.png:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.checksum:
  • platform/mac/fast/html/details-remove-summary-6-expected.png:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.checksum:
  • platform/mac/fast/html/details-writing-mode-expected.png:
  • platform/mac/fast/html/details-writing-mode-expected.txt:

2011-04-15 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

RenderDetailsMarker should belong to shadow element.
​https://bugs.webkit.org/show_bug.cgi?id=58591

  • Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker.
  • Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout. Note that marker size is given via style for -webkit-details-marker pseudo class.
  • Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement. Now RenderDetails knows nothing about default summary.
  • Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of <summary>, and the clickable area is now <summary> itself.
  • Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling.
  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/html.css: (summary::-webkit-details-marker):
  • dom/Element.cpp: (WebCore::Element::attach):
  • dom/Node.cpp: (WebCore::shouldCreateRendererFor):
  • dom/Node.h: (WebCore::Node::canHaveLightChildRendererWithShadow):
  • html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::findSummaryFor): (WebCore::HTMLDetailsElement::findMainSummary): (WebCore::HTMLDetailsElement::refreshMainSummary): (WebCore::HTMLDetailsElement::createShadowSubtree): (WebCore::HTMLDetailsElement::childrenChanged): (WebCore::HTMLDetailsElement::finishParsingChildren): (WebCore::HTMLDetailsElement::toggleOpen):
  • html/HTMLDetailsElement.h: (WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow):
  • html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::create): (WebCore::HTMLSummaryElement::createShadowSubtree): (WebCore::HTMLSummaryElement::detailsElement): (WebCore::HTMLSummaryElement::isMainSummary): (WebCore::HTMLSummaryElement::defaultEventHandler):
  • html/HTMLSummaryElement.h: (WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow):
  • html/shadow/DetailsMarkerControl.cpp: Added. (WebCore::DetailsMarkerControl::DetailsMarkerControl): (WebCore::DetailsMarkerControl::createRenderer): (WebCore::DetailsMarkerControl::rendererIsNeeded): (WebCore::DetailsMarkerControl::shadowPseudoId): (WebCore::DetailsMarkerControl::summaryElement):
  • html/shadow/DetailsMarkerControl.h: Added. (WebCore::DetailsMarkerControl::create):
  • rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::styleDidChange): (WebCore::RenderDetails::moveSummaryToContents): (WebCore::RenderDetails::checkMainSummary): (WebCore::RenderDetails::layout):
  • rendering/RenderDetails.h:
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): (WebCore::RenderDetailsMarker::isOpen): (WebCore::RenderDetailsMarker::getPath): (WebCore::RenderDetailsMarker::paint): (WebCore::RenderDetailsMarker::details):
  • rendering/RenderDetailsMarker.h:
2:52 PM Changeset in webkit [84038] by jianli@chromium.org
  • 1 edit
    2 copies in branches/chromium/696

Merge 83862 - 2011-04-14 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Disable speech input for readonly and disabled input fields.
​https://bugs.webkit.org/show_bug.cgi?id=58540

  • fast/speech/input-readonly-and-disabled-expected.txt: Added.
  • fast/speech/input-readonly-and-disabled.html: Added.

2011-04-14 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Disable speech input for readonly and disabled input fields.
​https://bugs.webkit.org/show_bug.cgi?id=58540

Test: fast/speech/input-readonly-and-disabled.html

  • html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

TBR=​satish@chromium.org

2:45 PM Changeset in webkit [84037] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 58696 - DFG JIT split handling of vars/temporaries

Reviewed by Sam Weinig.

Presently all callee registers are treated as having single block scope,
since the DFG JIT can only compile single block functions. In order to
expand the JIT to support control flow we will need to change to retaining
locals (but not temporaries) across basic block boundaries.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getTemporary):
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::getInt32Constant):
(JSC::DFG::ByteCodeParser::getDoubleConstant):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • dfg/DFGNode.h:
  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):

2:44 PM Changeset in webkit [84036] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::fadeAnimationTimerFired):

2:44 PM Changeset in webkit [84035] by enne@google.com
  • 19 edits
    4 adds in trunk/LayoutTests

2011-04-15 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, update baselines for compositing changes.
​https://bugs.webkit.org/show_bug.cgi?id=57113

  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium/test_expectations.txt:
2:36 PM Changeset in webkit [84034] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-04-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add the ability for PageOverlays to fade in and out
​https://bugs.webkit.org/show_bug.cgi?id=58694

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageUninstallPageOverlay): WebPage::uninstallPageOverlay now takes a boolean. Default to false for now.
  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::findString): Pass false to uninstallPageOverlay.

(WebKit::FindController::hideFindUI):
Pass true to uninstallPageOverlay.


  • WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::PageOverlay): Initialize new member variables.

(WebKit::PageOverlay::bounds):
Get rid of an unnecessary webPage() getter.

(WebKit::PageOverlay::setPage):
Stop the animation timer.

(WebKit::PageOverlay::startFadeInAnimation):
Update m_fractionFadedIn and call startFadeAnimation.

(WebKit::PageOverlay::startFadeOutAnimation):
Ditto.


(WebKit::PageOverlay::startFadeAnimation):
Initialize m_fadeAnimationStartTime and start the fade animation timer.

(WebKit::PageOverlay::fadeAnimationTimerFired):
Update m_fractionFadedIn and call setNeedsDisplay().

  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::uninstallPageOverlay): If fadeOut is true, tell the page overlay to start the fade out animation. When the fade animation is complete, the page overlay will uninstall itself.
2:18 PM Changeset in webkit [84033] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-15 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

Implement localize strings for windows WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=58688

  • platform/win/LocalizedStringsWin.cpp: (WebCore::createWebKitBundle): (WebCore::webKitBundle): (WebCore::localizedString): Add implementation of localizedString for Windows.
2:13 PM Changeset in webkit [84032] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixing build.

Inadvertantly checked in
Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
instead of Source/JavaScriptCore/JavaScriptCore.exp

1:56 PM Changeset in webkit [84031] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-04-15 Andreas Kling <​kling@webkit.org>

Skip failing tests after r84010 and r84012.

  • platform/qt/Skipped:
1:51 PM Changeset in webkit [84030] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-04-15 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
​https://bugs.webkit.org/show_bug.cgi?id=58677

Moved JSObjectWithGlobalObject::globalObject() to
runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
it for a performance benefit. An equivalent instance had been in
a header file before r60057.

  • JavaScriptCore.exp:
  • runtime/JSObjectWithGlobalObject.cpp:
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::globalObject):
1:47 PM Changeset in webkit [84029] by ggaren@apple.com
  • 19 edits in trunk/Source/WebCore

2011-04-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Some mechanical DOM wrapper cleanup
​https://bugs.webkit.org/show_bug.cgi?id=58689

  • WebCore.exp.in: Export!
  • bindings/js/DOMWrapperWorld.cpp: (WebCore::isReachableFromDOM): Inverted the inDocument test to make the relationship of the special cases to the normal case clearer.
  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper): (WebCore::createDOMNodeWrapper): (WebCore::getDOMNodeWrapper): Changed DOM wrapper functions to operate in terms of DOMWrapperWorlds instead of ExecStates. This is clearer, and ever-so-slightly faster.


Removed hasCachedXXX functions, now that they're unused.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
  • bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::toJS):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Updated for changes above.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Removed use of hasCachedDOMObjectWrapper because XHR is almost always created and used by JavaScript, so it's simpler to just always report extra cost.
1:45 PM Changeset in webkit [84028] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r81262): plugins/refcount-leaks.html failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56478

Unskip plugins/refcount-leaks.html on Windows because it is now
passing on release and debug.

  • platform/win/Skipped:
1:33 PM Changeset in webkit [84027] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2011-04-15 James Robinson <​jamesr@chromium.org>

Add chromium linux expectations for direct-image-compositing.html

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium/test_expectations.txt:
1:25 PM Changeset in webkit [84026] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-15 Chris Rogers <​crogers@google.com>

Unreviewed.

Update test_expectations.txt with more failing fast/borders tests
​https://bugs.webkit.org/show_bug.cgi?id=58685

  • platform/chromium/test_expectations.txt:
1:11 PM Changeset in webkit [84025] by andreas.kling@nokia.com
  • 3 edits
    1 delete in trunk

2011-04-15 Andreas Kling <​kling@webkit.org>

Rolling out accidental part of r84010.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle): (WebCore::RenderThemeQt::setButtonPadding):

2011-04-15 Andreas Kling <​kling@webkit.org>

Rolling out accidental part of r84010.

  • fast/forms/button-line-break.html: Removed.
1:07 PM Changeset in webkit [84024] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Forgot windows build fix.

1:01 PM Changeset in webkit [84023] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

2011-04-15 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Yury Semikhatsky.

Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
​https://bugs.webkit.org/show_bug.cgi?id=51364

The front end should not use a transparent background when
loaded as a web page (remote debugging) but should when loaded
regularly in a custom window. This adds a "remote" style class
onto the document body when the page is loaded remotely.

  • inspector/front-end/inspector.css: (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
  • inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.
1:01 PM Changeset in webkit [84022] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-04-15 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

JSLock ASSERT seen often when using the inspector for long
periods of time. We should take the JSLock whenever we
might allocate memory in the JavaScript Heap.

JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
​https://bugs.webkit.org/show_bug.cgi?id=58674

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::nodeAsScriptValue): take the JSLock.
12:55 PM Changeset in webkit [84021] by oliver@apple.com
  • 11 edits in trunk/Source

2011-04-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSNodeFilterCondition handle its lifetime correctly
​https://bugs.webkit.org/show_bug.cgi?id=58622

Add export

2011-04-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSNodeFilterCondition handle its lifetime correctly
​https://bugs.webkit.org/show_bug.cgi?id=58622

Switch over to a WeakHandle and external roots to keep the
condition value live.

  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode): (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
  • bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
  • bindings/scripts/CodeGeneratorJS.pm:
12:48 PM Changeset in webkit [84020] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 83611
BUG=79025

12:46 PM Changeset in webkit [84019] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit2

Views should be made visible before painting in WM_PRINTCLIENT messages
​https://bugs.webkit.org/show_bug.cgi?id=58676
<rdar://problem/9279211>

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPrintClientEvent): If our view isn't currently visible set it to visible

before painting, then reset it back to not visible after painting.

(WebKit::WebView::onShowWindowEvent): Call setIsVisible instead of duplicating logic.
(WebKit::WebView::setIsVisible): Set the m_isVisible flag and call viewStateDidChange.

  • UIProcess/win/WebView.h:
12:42 PM Changeset in webkit [84018] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: some adjustments
​https://bugs.webkit.org/show_bug.cgi?id=57092

Reviewed by Andreas Kling.

  • Removing flag m_redirected from QNetworkReplyHandler and using m_redirectionTargetUrl.isValid() instead.
  • Moving flag m_responseContainsData from QNetworkReplyHandler to the reply wrapper and removing the connection of

signal metaDataChanged for m_responseContainsData to be consistent.

  • Using an OwnPtr to keep the reference to the QNetworkReplyWrapper.
  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveReadyRead):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::release):
(WebCore::shouldIgnoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyWrapper::responseContainsData):
(WebCore::QNetworkReplyWrapper::redirected):

12:37 PM Changeset in webkit [84017] by andersca@apple.com
  • 13 edits
    4 adds in trunk/Source/WebKit2

2011-04-15 Jon Lee <​jonlee@apple.com>

Reviewed by Anders Carlsson.

onClick does not function with <select> elements in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=57904
<rdar://problem/9217757>

Reviewed by Anders Carlsson.

  • Shared/NativeWebMouseEvent.h: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::nativeEvent):
  • Shared/mac/NativeWebMouseEventMac.mm: Added. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • Shared/qt/NativeWebMouseEventQt.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • Shared/win/NativeWebMouseEventWin.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h. (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • UIProcess/API/mac/WKView.mm: (-[WKView mouseMoved:]): (-[WKView _mouseHandler:]): Pre-compiler mouse handler calls need to use the new NativeWebMouseEvent class
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mouseMoveEvent): (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseReleaseEvent): (QWKPagePrivate::mouseDoubleClickEvent):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleMouseEvent): keep track of mouse down event in order to be able to send a fake mouse up event on the select element (WebKit::WebPageProxy::currentMouseDownEvent): for access by the popup menu proxy to dispatch the fake mouse up event (WebKit::WebPageProxy::didReceiveEvent): clear out the cached mouse down event (WebKit::WebPageProxy::processDidCrash): clear out the cached events since we assume that didReceiveEvent did not called prior to the crash
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
  • UIProcess/win/WebPopupMenuProxyWin.cpp: (WebKit::WebPopupMenuProxyWin::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onMouseEvent):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
12:34 PM Changeset in webkit [84016] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Chromium build fix.

  • platform/SecureTextInput.h: CARBON_SECURE_INPUT_MODE no longer exists.
12:31 PM Changeset in webkit [84015] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 83699
BUG=79199

12:30 PM Changeset in webkit [84014] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Qt build fix.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::selectionStateChanged): Wrap the variable in PLATFORM(MAC), too, as it's unused on other platforms.
12:25 PM Changeset in webkit [84013] by andreas.kling@nokia.com
  • 4 edits in trunk

2011-04-15 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Default custom policy delegate decision should be Ignore.

If layoutTestController.setCustomPolicyDelegate() is called with only
one argument, the second ("permissive") should default to false.

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2011-04-15 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Default custom policy delegate decision should be Ignore.

  • platform/qt/Skipped: Unskip now passing tests.
12:25 PM Changeset in webkit [84012] by beidson@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Get the right reviewer up in here.

12:24 PM Changeset in webkit [84011] by beidson@apple.com
  • 8 edits in trunk/Source/WebKit2

<rdar://problem/9287880> and ​https://bugs.webkit.org/show_bug.cgi?id=58596
WK2: Past searches not remembered for <input type=search results="5" autosave="foo">

Reviewed by Sam Weinig.

Add SaveRecentSearches and LoadRecentSearches messages:

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPageProxy.h:

Message up to the UIProcess for the save/load operations:

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::page):

Save the values to disk CFPreference-style:

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

Stubbed out for non-CF platforms:

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

12:22 PM Changeset in webkit [84010] by andreas.kling@nokia.com
  • 5 edits
    1 add in trunk

2011-04-15 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Block access to external URLs.

  • platform/qt/Skipped: Unskip now passing tests.

2011-04-15 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] DRT: Block access to external URLs.

Implement the "Blocked access to external URL" behavior for Qt's DRT,
based on what other ports are doing.

Fixes <​http://webkit.org/b/57306> and <​http://webkit.org/b/58523>.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
12:16 PM Changeset in webkit [84009] by cevans@google.com
  • 3 edits
    8 copies in branches/chromium/696

Merge 83787
BUG=75186

12:16 PM Changeset in webkit [84008] by jianli@chromium.org
  • 36 edits
    3 copies
    3 deletes in branches/chromium/696

Merge 83884 - BlobBuilder should be vendor-prefixed
​https://bugs.webkit.org/show_bug.cgi?id=58518

Reviewed by Darin Fisher.

Source/WebCore:

Renamed BlobBuilder to WebKitBlobBuilder.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.

(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):

  • fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.

(WebCore::WebKitBlobBuilder::create):

  • fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • fast/dom/script-tests/prototype-inheritance-2.js:

(constructorNamesForWindow):

  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/dom/window-domurl-crash.html:
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/filesystem/resources/file-writer-events.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-gc-blob.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-utils.js:
  • fast/js/global-constructors-expected.txt:
  • fast/js/script-tests/global-constructors.js:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/local/blob/resources/hybrid-blob-util.js:

(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):

  • http/tests/security/resources/create-filesystem-file.html:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/window-domurl-crash-expected.txt:

TBR=​jianli@chromium.org

12:13 PM Changeset in webkit [84007] by cevans@google.com
  • 3 edits
    8 deletes in branches/chromium/696

Revert 84004 - Merge 83787
BUG=75186

TBR=​cevans@google.com

12:10 PM Changeset in webkit [84006] by jianli@chromium.org
  • 1 edit in branches/chromium/696/LayoutTests/fast/filesystem/resources/file-writer-utils.js

Merge 83878 - Unreviewed, fixed tests caused by r83873.

  • fast/filesystem/resources/file-writer-utils.js:

(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):

TBR=​jianli@chromium.org

12:07 PM Changeset in webkit [84005] by jianli@chromium.org
  • 13 edits
    2 copies in branches/chromium/696

Merge 83873 - Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
​https://bugs.webkit.org/show_bug.cgi?id=58496

Reviewed by Darin Fisher.

Source/WebCore:

Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.

Test: fast/files/blob-slice-test.html

  • fileapi/Blob.cpp:

(WebCore::Blob::webkitSlice):

  • fileapi/Blob.h:
  • fileapi/Blob.idl:

LayoutTests:

Added a new test to test the new behavior and also update all existing
tests to use the new name.

  • fast/dom/Window/window-properties.html:
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test-expected.txt: Added.
  • fast/files/blob-slice-test.html: Added.
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

  • fast/filesystem/resources/file-writer-utils.js:

(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):

  • http/tests/local/blob/script-tests/send-hybrid-blob.js:

():

  • http/tests/local/blob/script-tests/send-sliced-data-blob.js:

(runSliceTest):

  • http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:

(onStableFileDrop):
(onUnstableFileDrop):

  • http/tests/local/formdata/resources/send-form-data-common.js:

(testSendingFormData):

TBR=​jianli@chromium.org

12:00 PM Changeset in webkit [84004] by cevans@google.com
  • 3 edits
    8 copies in branches/chromium/696

Merge 83787
BUG=75186

11:57 AM Changeset in webkit [84003] by cevans@google.com
  • 3 edits
    8 deletes in branches/chromium/696

Revert 84002 - Merge 83787
BUG=75186

TBR=​rolandsteiner@chromium.org

TBR=​cevans@google.com

11:50 AM Changeset in webkit [84002] by cevans@google.com
  • 3 edits
    8 copies in branches/chromium/696

Merge 83787
BUG=75186

TBR=​rolandsteiner@chromium.org

11:47 AM Changeset in webkit [84001] by cevans@google.com
  • 3 edits
    8 deletes in branches/chromium/696

Revert 83995 - Merge 83787
BUG=75186

TBR=​cevans@google.com

11:45 AM Changeset in webkit [84000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-15 Mike Reed <​reed@google.com>

Reviewed by Darin Fisher.

hide unused static function when SKIA_GPU is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58670

No new tests. Just fixes a warning (treated as an error) when SKIA_GPU is enabled

  • platform/graphics/skia/ImageSkia.cpp:
11:43 AM Changeset in webkit [83999] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-15 James Robinson <​jamesr@chromium.org>

Fix duplicate expectation for compositing/tiling/huge-layer-img.html on chromium mac.

  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [83998] by Simon Fraser
  • 9 edits
    12 adds in trunk

2011-04-15 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Some borders with border-radius do not have rounded inner edges
​https://bugs.webkit.org/show_bug.cgi?id=58457

Improve the logic used to compute the inner radii on curved
borders, to maintain borders of even thickness around the curve.

Tests: fast/borders/mixed-border-styles-radius.html

fast/borders/mixed-border-styles.html

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::computeBorderOuterRect): (WebCore::RenderBoxModelObject::computeBorderInnerRect): Two new utility functions to share some code that was in both paintBorder() and paintBoxShaadow(). getRoundedInnerBorderWithBorderWidths() now takes the outer border box as well as the inner box.

(WebCore::RenderBoxModelObject::paintBorder): Call new methods.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath): getRoundedInnerBorderWithBorderWidths() now takes the outer border box as well as the inner box.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: Compute the inner radii by starting with teh radii used for the outer box, and then shrinking them down based on the border thickness.
11:38 AM Changeset in webkit [83997] by ap@apple.com
  • 13 edits in trunk/Source

Reviewed by Dan Bernstein.

WebKit2: Password field input does not switch to ASCII-compatible source
​https://bugs.webkit.org/show_bug.cgi?id=58583
<rdar://problem/9059651>

The implementation is more modern than what we have in WK1. Instead of returning a null
input context (as in non-editable content), we now set page context's properties.

11:31 AM Changeset in webkit [83996] by xji@chromium.org
  • 5 edits in trunk

2011-04-13 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Continue (3rd) experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=58294

  • editing/selection/move-by-word-visually-expected.txt:
  • editing/selection/move-by-word-visually.html:

2011-04-13 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Continue (3rd) experiment with moving caret by word in visual order.
​https://bugs.webkit.org/show_bug.cgi?id=58294

This patch along with r82588 and r83483 implements moving caret by
word in visual order.


The overall algorithm is:

  1. First get the InlineBox and offset of the pass-in VisiblePosition.
  2. Based on the position (left boundary, middle, right boundary) of the offset and the direction of the movement, look for visually adjacent word breaks. 2.1 If the offset is the minimum offset of the box,

return the rightmost word boundary in previous boxes if moving left.
return the leftmost word boundary in box and next boxes if moving right.

2.2 Similar for the case when offset is at the maximum offset of the box.
2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition

or nextWordPosition based on the directionality of the box. If this word break position
is also inside the same box, return it. Otherwise (the nextWordPosition or
previousWordPosition is not in the same box or is at the box boundary), collect all the
word breaks in the box and search for the one closest to the input "offset" based on
box directionality, block directionality, and movement direction. Continue search in
adjacent boxes if needed.

Notes:

  1. Word boundaries are collected one box at a time. Only when a boundary that is closest to the input position (in the moving direction) is not available in current box, word boundaries in adjacent box will be collected. So, there is no need to save InlineBox in word boundaries. Instead, the word boundaries are saved as a pair (VisiblePosition, offset) to avoid recomputing VisiblePosition.


  1. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block and right boundary of a word in RTL block). And word boundaries are collected using previousWordPosition() and nextWordPosition(). So when box directionality is the same as block directionality, word boundaries are collected from right to left visually in a LTR box, and word boundaries are collected from left to right visually in a RTL box. It is the other way around when box directionality is different from block directionality.
  1. To find the right kinds of word boundaries, we must move back and forth between words in some situations. For example, if we're moving to the right in a LTR box in LTR block, we cannot simply return nextWordPosition() because it would return the right boundary of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().
  1. When collecting word breaks inside a box, it first computes a start position, then collect the right kind of word breaks until it reaches the end of (or beyond) the box. In the meanwhile, it might need special handling on the rightmost or leftmost position based on the directionality of the box and block. These computations do not consider the box's bidi level.
  • editing/visible_units.cpp: (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): (WebCore::collectWordBreaksInBox): (WebCore::previousWordBoundaryInBox): (WebCore::nextWordBoundaryInBox): (WebCore::visuallyLastWordBoundaryInBox): (WebCore::leftWordBoundary): (WebCore::rightWordBoundary): (WebCore::leftWordPosition): (WebCore::rightWordPosition):
11:23 AM Changeset in webkit [83995] by cevans@google.com
  • 3 edits
    8 copies in branches/chromium/696

Merge 83787
BUG=75186

11:07 AM Changeset in webkit [83994] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-04-14 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION: Rendering in <video> element appears to render quickly to catch up if it has been playing in a background tab
​https://bugs.webkit.org/show_bug.cgi?id=58637

Notify AVFoundation that no one will be rendering when the view or window moves off screen.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isViewVisible): Return false if the view's window is not visible.
  • UIProcess/API/mac/WKView.mm: (-[WKView addWindowObserversForWindow:]): Observe orderOut and orderIn events. (-[WKView removeWindowObservers]): Ditto. (-[WKView _windowDidOrderOffScreen:]): Added. (-[WKView _windowDidOrderOnScreen:]): Added.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::suspendPainting): Call LayerTreeHost::pauseRendering. (WebKit::DrawingAreaImpl::resumePainting): Call LayerTreeHost::resumeRendering.
  • WebProcess/WebPage/LayerTreeHost.h: (WebKit::LayerTreeHost::pauseRendering): Added stub. (WebKit::LayerTreeHost::resumeRendering): Added stub.
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: (WebKit::LayerTreeHostCAMac::pauseRendering): Added. Post a notification with our

intention to stop rendering.

(WebKit::LayerTreeHostCAMac::resumeRendering): Added. Post a notification with our

intention to start rendering.

11:05 AM Changeset in webkit [83993] by Simon Fraser
  • 161 edits
    4 adds in trunk/LayoutTests

2011-04-15 Simon Fraser <Simon Fraser>

Rebaseline Mac pixel results in fast/ on SnowLeopard.

  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/block/basic/011-expected.checksum:
  • platform/mac/fast/block/basic/011-expected.png:
  • platform/mac/fast/block/float/float-avoidance-expected.checksum:
  • platform/mac/fast/block/float/float-avoidance-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/positioning/auto/005-expected.checksum:
  • platform/mac/fast/block/positioning/auto/005-expected.png:
  • platform/mac/fast/block/positioning/auto/006-expected.checksum:
  • platform/mac/fast/block/positioning/auto/006-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.checksum:
  • platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/mac/fast/borders/border-radius-circle-expected.checksum:
  • platform/mac/fast/borders/border-radius-circle-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.checksum:
  • platform/mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum:
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/mac/fast/box-shadow/spread-expected.checksum:
  • platform/mac/fast/box-shadow/spread-expected.png:
  • platform/mac/fast/box-shadow/spread-multiple-inset-expected.checksum:
  • platform/mac/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/mac/fast/box-shadow/spread-multiple-normal-expected.checksum:
  • platform/mac/fast/box-shadow/spread-multiple-normal-expected.png:
  • platform/mac/fast/canvas/canvas-incremental-repaint-expected.checksum:
  • platform/mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.checksum:
  • platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png:
  • platform/mac/fast/canvas/drawImage-expected.checksum:
  • platform/mac/fast/canvas/drawImage-expected.png:
  • platform/mac/fast/canvas/webgl/css-webkit-canvas-expected.checksum:
  • platform/mac/fast/canvas/webgl/css-webkit-canvas-expected.png:
  • platform/mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.checksum:
  • platform/mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png:
  • platform/mac/fast/css/font-face-default-font-expected.checksum:
  • platform/mac/fast/css/font-face-default-font-expected.png:
  • platform/mac/fast/css/font_property_normal-expected.checksum:
  • platform/mac/fast/css/font_property_normal-expected.png:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.checksum:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.checksum:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/checkbox-radio-onchange-expected.checksum:
  • platform/mac/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/mac/fast/forms/file-input-disabled-expected.checksum:
  • platform/mac/fast/forms/file-input-disabled-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/formmove-expected.checksum:
  • platform/mac/fast/forms/formmove-expected.png:
  • platform/mac/fast/forms/formmove2-expected.checksum:
  • platform/mac/fast/forms/formmove2-expected.png:
  • platform/mac/fast/forms/indeterminate-expected.checksum:
  • platform/mac/fast/forms/indeterminate-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.checksum:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-value-expected.checksum:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/minWidthPercent-expected.checksum:
  • platform/mac/fast/forms/minWidthPercent-expected.png:
  • platform/mac/fast/forms/radio-attr-order-expected.checksum:
  • platform/mac/fast/forms/radio-attr-order-expected.png:
  • platform/mac/fast/forms/radio-nested-labels-expected.checksum:
  • platform/mac/fast/forms/radio-nested-labels-expected.png:
  • platform/mac/fast/forms/radio_checked-expected.checksum:
  • platform/mac/fast/forms/radio_checked-expected.png:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.checksum:
  • platform/mac/fast/forms/radio_checked_dynamic-expected.png:
  • platform/mac/fast/images/animated-svg-as-image-expected.checksum:
  • platform/mac/fast/images/animated-svg-as-image-expected.png:
  • platform/mac/fast/images/imagemap-case-expected.checksum:
  • platform/mac/fast/images/imagemap-case-expected.png:
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum:
  • platform/mac/fast/images/imagemap-circle-focus-ring-expected.png:
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum:
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum:
  • platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/invalid/019-expected.checksum:
  • platform/mac/fast/invalid/019-expected.png:
  • platform/mac/fast/invalid/missing-address-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-address-end-tag-expected.png:
  • platform/mac/fast/invalid/table-inside-stray-table-content-expected.checksum:
  • platform/mac/fast/invalid/table-inside-stray-table-content-expected.png:
  • platform/mac/fast/lists/003-vertical-expected.checksum:
  • platform/mac/fast/lists/003-vertical-expected.png:
  • platform/mac/fast/media/media-query-invalid-value-expected.checksum:
  • platform/mac/fast/media/media-query-invalid-value-expected.png:
  • platform/mac/fast/overflow/003-expected.checksum:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/parser/bad-xml-slash-expected.checksum:
  • platform/mac/fast/parser/bad-xml-slash-expected.png:
  • platform/mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-h-expected.png:
  • platform/mac/fast/repaint/control-clip-expected.checksum:
  • platform/mac/fast/repaint/control-clip-expected.png:
  • platform/mac/fast/repaint/list-marker-expected.checksum:
  • platform/mac/fast/repaint/list-marker-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.checksum:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/text/emphasis-vertical-expected.checksum:
  • platform/mac/fast/text/emphasis-vertical-expected.png:
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.checksum:
  • platform/mac/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/mac/fast/transforms/shadows-expected.checksum:
  • platform/mac/fast/transforms/shadows-expected.png:
11:01 AM Changeset in webkit [83992] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

2011-04-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash
​https://bugs.webkit.org/show_bug.cgi?id=58501

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Call validateHTMLImageElement(). (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::validateHTMLImageElement): Make sure image is ready.
  • html/canvas/WebGLRenderingContext.h:
10:57 AM Changeset in webkit [83991] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

2011-04-07 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

DocumentMaker::AllMarkers should not be a part of DocumentMarker::MarkerType
​https://bugs.webkit.org/show_bug.cgi?id=58112

  • Converted DocumentMarker::MarkerTypes from unsigned int to a class.
  • Converted DocumentMarker::AllMarkers from an enum entry to a subclass of MarkerTypes.
  • Changed type of some MarkerType argument on DocumentMarkerController API to MarkerTypes which should allow a combination of MarkerType constansts.
  • Removed some MarkerType arguments on DocumentMarkerController API which only received AllMarkers.

No new tests, no behavior change.

  • WebCore.exp.in:
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::MarkerTypes::MarkerTypes): (WebCore::DocumentMarker::MarkerTypes::contains): (WebCore::DocumentMarker::MarkerTypes::intersects): (WebCore::DocumentMarker::MarkerTypes::operator==): (WebCore::DocumentMarker::MarkerTypes::add): (WebCore::DocumentMarker::MarkerTypes::remove): (WebCore::DocumentMarker::AllMarkers::AllMarkers):
  • dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::possiblyHasMarkers): (WebCore::DocumentMarkerController::addMarker): (WebCore::DocumentMarkerController::copyMarkers): (WebCore::DocumentMarkerController::removeMarkers): (WebCore::DocumentMarkerController::markerContainingPoint): (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::renderedRectsForMarkers): (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): (WebCore::DocumentMarkerController::repaintMarkers): (WebCore::DocumentMarkerController::shiftMarkers): (WebCore::DocumentMarkerController::setMarkersActive): (WebCore::DocumentMarkerController::hasMarkers): (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
  • dom/DocumentMarkerController.h:
10:44 AM Changeset in webkit [83990] by ggaren@apple.com
  • 15 edits in trunk/Source/WebCore

2011-04-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Complicated hash table is complicated
​https://bugs.webkit.org/show_bug.cgi?id=58631


Now that we use the opaque roots system to track node wrapper lifetime,
we can remove a lot of complicated hash-tablery that used to do the same.


Now normal world node wrappers are just set as direct properties of
ScriptWrappable, while isolated world node wrappers and other DOM object
wrappers are stored in a shared, per-world hash table.

In addition to reducing complexity, this makes DOM wrapper allocation
1.6X faster (tested with scratch-gc-dom3.html), and it reduces the memory
footprint of normal world wrappers by ~2/3, and isolated world wrappers
by ~1/3.

  • WebCore.exp.in: Paying the patch tithe.
  • bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::~DOMWrapperWorld): (WebCore::DOMWrapperWorld::clearWrappers): No more per-document hash tables.

(WebCore::JSNodeHandleOwner::finalize): Changed to call a helper function,
so the code to destroy a wrapper can live next to the code to create one.

  • bindings/js/DOMWrapperWorld.h: No more per-document hash tables.
  • bindings/js/JSDOMBinding.cpp: (WebCore::uncacheDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMNodeWrapper): (WebCore::getDOMNodeWrapper): No more per-document hash tables. Added uncacheDOMObjectWrapper to be symmetrical with cacheDOMObjectWrapper.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS):
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Ditto.
  • bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::uncacheDOMNodeWrapper): (WebCore::toJS): Implemented the scheme described above.
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper): ScriptWrappable needs a handle owner now, since we don't have an extra handle living in a hash table to maintain ownership for us.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::setDocument): No more per-document hash tables.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Removed call to hasCachedDOMNodeWrapperUnchecked because that was the old way of doing things, and I was in the mood for getting rid of the old way. It's debatable whether the check was ever a good idea. Even when a <canvas> doesn't have a direct JS wrapper, other JS references can still keep the <canvas> alive. So, it's probably best always to report extra cost.
10:42 AM Changeset in webkit [83989] by jberlin@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

DRT on Windows doesn't block access to external URLs (​https://bugs.webkit.org/show_bug.cgi?id=57334),
but WKTR does, so add the expected passing results to the win-wk2 directory to override the expected
failing results in the win directory in order to get the bots green.

  • platform/win-wk2/fast/ruby: Added.
  • platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
10:41 AM Changeset in webkit [83988] by jberlin@webkit.org
  • 5 edits in trunk/Source/WebKit2

WebKit2: Need a way to keep the WebProcess alive for testing purposes.
​https://bugs.webkit.org/show_bug.cgi?id=58592

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.cpp:

(WKContextDisableProcessTermination):
(WKContextEnableProcessTermination):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
Initialize m_processTerminationEnabled to true.
(WebKit::WebContext::enableProcessTermination):
Set m_processTerminationEnabled to true, and try to terminate the web process.
(WebKit::WebContext::shouldTerminate):
If !m_processTerminationEnabled, return false.

  • UIProcess/WebContext.h:

(WebKit::WebContext::disableProcessTermination):
Set m_processTerminationEnabled to false;

10:32 AM Changeset in webkit [83987] by commit-queue@webkit.org
  • 11 edits in trunk/Source

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
​https://bugs.webkit.org/show_bug.cgi?id=58650

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): (WebInspector.Resource.prototype.set requestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.get responseHeadersText): (WebInspector.Resource.prototype.set responseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
  • inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): (WebInspector.ResourceHeadersView.prototype._refreshHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRequestHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleResponseHeadersText): (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
  • inspector/front-end/networkPanel.css: (.resource-headers-view .outline-disclosure li.headers-text):
  • platform/network/ResourceLoadInfo.h:

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
​https://bugs.webkit.org/show_bug.cgi?id=58650

  • public/WebHTTPLoadInfo.h:
  • src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::requestHeadersText): (WebKit::WebHTTPLoadInfo::setRequestHeadersText): (WebKit::WebHTTPLoadInfo::responseHeadersText): (WebKit::WebHTTPLoadInfo::setResponseHeadersText):
10:28 AM Changeset in webkit [83986] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-15 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement css overflow properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=58633

No new tests required as no functionality changes.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Add initializers for CSSPropertyOverflowX, CSSPropertyOverflowY and CSSPropertyOverflow.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Delete existing implementations.
9:57 AM Changeset in webkit [83985] by weinig@apple.com
  • 6 edits in trunk/Source

2011-04-15 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

Make mac WebKit1 use the default localization strategy
​https://bugs.webkit.org/show_bug.cgi?id=58628

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: Remove the localization strategy code. The equivalent is now in WebCore/platform/DefaultLocalizationStrategy.cpp.

2011-04-15 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

Make mac WebKit1 use the default localization strategy
​https://bugs.webkit.org/show_bug.cgi?id=58628

  • English.lproj/Localizable.strings: Update by running update-webkit-localizable-strings.
  • platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary): (WebCore::DefaultLocalizationStrategy::keygenKeychainItemName): (WebCore::DefaultLocalizationStrategy::imageTitle): Match the WebKit1 versions of these functions by special casing CF platforms.
9:42 AM Changeset in webkit [83984] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=58136

Passed response info to inspector when X-Frame-Options header blocks resource loading.

  • http/tests/inspector/network/resources/x-frame-options-deny.cgi: Added.
  • http/tests/inspector/network/x-frame-options-deny-expected.txt: Added.
  • http/tests/inspector/network/x-frame-options-deny.html: Added.

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: No console message and headers in inspector when X-Frame-Options header blocks a load
​https://bugs.webkit.org/show_bug.cgi?id=58136

Passed response info to inspector when X-Frame-Options header blocks resource loading.

Test: http/tests/inspector/network/x-frame-options-deny.html

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDeniedImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
9:29 AM Changeset in webkit [83983] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-15 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
​https://bugs.webkit.org/show_bug.cgi?id=58449

  • inspector/editor/text-editor-model-expected.txt: Added.
  • inspector/editor/text-editor-model.html: Added.

2011-04-15 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: TextViewer and TextEditorModel must support both \n and \r\n as line separators
​https://bugs.webkit.org/show_bug.cgi?id=58449

Test: inspector/editor/text-editor-model.html

9:20 AM Changeset in webkit [83982] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-04-15 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Need to export ViewportAttributes class
​https://bugs.webkit.org/show_bug.cgi?id=58651

On Symbian, if the ViewportAttributes class is not exported we get
linking errors.

Since this is a compilation issue, no new tests added.

  • UIProcess/API/qt/qwkpage.h:
9:11 AM Changeset in webkit [83981] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-15 Eric Seidel <​eric@webkit.org>

Reviewed by Eric Carlson.

Flaky Test: media/invalid-media-url-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=51138

Skipping this test on Snow Leopard since it's hitting
a known MediaToolbox crasher on Snow Leopard.
If Apple happens to software update SL users we can
unskip this, until then no need to run this flaky test.

  • platform/mac-snowleopard/Skipped:
9:00 AM Changeset in webkit [83980] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

fix path to layout test in new results file
​https://bugs.webkit.org/show_bug.cgi?id=58618

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
8:45 AM Changeset in webkit [83979] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-15 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, skipping a test.

[GTK] editing/selection/select-out-of-editable.html failing after r83967
​https://bugs.webkit.org/show_bug.cgi?id=58667

  • platform/gtk/Skipped: skipping editing/selection/select-out-of-editable.html
8:42 AM Changeset in webkit [83978] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

fix sorting in new results file
​https://bugs.webkit.org/show_bug.cgi?id=58616

-Fix the custom sort to return -1, 0, 1 instead of true/false.
-Secondary sort by test name when sort values are equal.
-Sort by test name by default.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
8:39 AM Changeset in webkit [83977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-04-15 Dmitry Lomov <​dslomov@google.com>

Reviewed by David Levin.

check-webkit-style shouldn't complain about not including a primary header file
if none exists
​https://bugs.webkit.org/show_bug.cgi?id=39514

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
8:38 AM Changeset in webkit [83976] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Windows Tests] fast/forms/input-text-drag-down.html and
editing/selection/select-from-textfield-outwards.html failing since r83967.
​https://bugs.webkit.org/show_bug.cgi?id=58664

Adding Windows-specific expected failing results to get the bots green.

  • platform/win/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/win/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/win/fast/forms/input-text-drag-down-expected.checksum: Added.
  • platform/win/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/win/fast/forms/input-text-drag-down-expected.txt: Added.
8:15 AM Changeset in webkit [83975] by yurys@chromium.org
  • 14 edits
    4 adds in trunk/Source/WebCore

2011-04-15 Sergey Vorobyev <​sergeyvorobyev@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Network events don't preserves,
when inspector frontend closed and open again
​https://bugs.webkit.org/show_bug.cgi?id=58064

Added InspectorFrontendProxy and EventsCollector.
They allow captured messages from InspectorResourceAgent
to frontend (or mockFrontend if frontend disabled) and
push collected data when frontend reconnect.
This functionality is disabled by default.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/EventsCollector.cpp: Added. (WebCore::EventsCollector::EventsCollector): (WebCore::EventsCollector::addEvent): (WebCore::EventsCollector::sendCollectedEvents):
  • inspector/EventsCollector.h: Added. (WebCore::EventsCollector::~EventsCollector):
  • inspector/Inspector.json:
  • inspector/InspectorFrontendProxy.cpp: Added. (WebCore::InspectorFrontendProxy::InspectorFrontendProxy): (WebCore::InspectorFrontendProxy::setInspectorFrontendChannel): (WebCore::InspectorFrontendProxy::setEventsCollector): (WebCore::InspectorFrontendProxy::sendMessageToFrontend):
  • inspector/InspectorFrontendProxy.h: Added. (WebCore::InspectorFrontendProxy::~InspectorFrontendProxy):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setFrontend): (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::domContentEventFired): (WebCore::InspectorResourceAgent::loadEventFired): (WebCore::InspectorResourceAgent::enabledBackgoundEventsCoollection): (WebCore::InspectorResourceAgent::enable): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.domContentEventFired): (WebInspector.NetworkDispatcher.prototype.loadEventFired):
  • inspector/front-end/inspector.js: (WebInspector.domContentEventFired): (WebInspector.loadEventFired):
7:55 AM Changeset in webkit [83974] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/Source/JavaScriptCore

2011-04-15 Dmitry Lomov <​dslomov@google.com>

Reviewed by David Levin.

Add a sample test case for GTest framework
​https://bugs.webkit.org/show_bug.cgi?id=58509

Add an example of GTest testcase, complete with a runner, to JavaScriptCore.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/tests/RunAllWtfTests.cpp: Added. (main):
  • wtf/tests/StringTests.cpp: Added.
7:38 AM Changeset in webkit [83973] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-04-15 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r83397) [Qt] When clicking on the media elements they grow 2 pixels.
​https://bugs.webkit.org/show_bug.cgi?id=58477

Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size. Therefore
ports which are not using the borders must explicitly disable them in their custom
stylesheet.

  • css/mediaControlsQt.css: (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (video::-webkit-media-controls-fullscreen-button):
  • css/mediaControlsQuickTime.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
7:35 AM Changeset in webkit [83972] by commit-queue@webkit.org
  • 15 edits in trunk/Source

2011-04-15 Zelidrag Hornung <​zelidrag@chromium.org>

Reviewed by Darin Fisher.

Added enums for external file system type.
​https://bugs.webkit.org/show_bug.cgi?id=58456

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::crackFileSystemURL):
  • fileapi/DOMFileSystemBase.h:
  • fileapi/EntryBase.cpp: (WebCore::EntryBase::toURL):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
  • page/DOMWindow.h:
  • platform/AsyncFileSystem.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): (WebCore::WorkerContext::requestFileSystemSync):
  • workers/WorkerContext.h:

2011-04-15 Zelidrag Hornung <​zelidrag@chromium.org>

Reviewed by Darin Fisher.

Added enums for external file system type and exposed factory function
for creating File- and DirectoryEntry objects from Chromium side.
​https://bugs.webkit.org/show_bug.cgi?id=58456

  • public/WebFileSystem.h:
  • public/WebFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createFileSystem): (WebKit::WebFrameImpl::createFileEntry):
  • src/WebFrameImpl.h:
7:30 AM Changeset in webkit [83971] by sergio@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-04-15 Sergio Villar Senin <​svillar@igalia.com>

Unreviewed, added new GTK+ test expectations.

  • platform/gtk/fast/forms/select-background-none-expected.checksum: Added.
  • platform/gtk/fast/forms/select-background-none-expected.png: Added.
  • platform/gtk/fast/forms/select-background-none-expected.txt: Added.
  • platform/gtk/fast/text/zero-font-size-expected.checksum: Added.
  • platform/gtk/fast/text/zero-font-size-expected.png: Added.
  • platform/gtk/fast/text/zero-font-size-expected.txt: Added.
7:25 AM Changeset in webkit [83970] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add new eventSender-dependent tests from r83967 to the mac-wks Skipped file

  • platform/mac-wk2/Skipped: Added some new editing/selection tests.
7:08 AM Changeset in webkit [83969] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-15 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: make resource revisions use dedicated type (not Resource clone).
​https://bugs.webkit.org/show_bug.cgi?id=58659

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.addRevision): (WebInspector.Resource.prototype._innerRequestContent.onResourceContent): (WebInspector.Resource.prototype._innerRequestContent): (WebInspector.ResourceRevision): (WebInspector.ResourceRevision.prototype.get resource): (WebInspector.ResourceRevision.prototype.get timestamp): (WebInspector.ResourceRevision.prototype.get content): (WebInspector.ResourceRevision.prototype.revertToThis): (WebInspector.ResourceRevision.prototype.requestContent.mycallback): (WebInspector.ResourceRevision.prototype.requestContent):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource): (WebInspector.RevisionSourceFrame): (WebInspector.RevisionSourceFrame.prototype.get resource): (WebInspector.RevisionSourceFrame.prototype.isContentEditable): (WebInspector.RevisionSourceFrame.prototype.requestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._showRevisionView): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step1): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup.step2): (WebInspector.ResourcesPanel.prototype._fetchAndApplyDiffMarkup): (WebInspector.ResourceRevisionTreeElement): (WebInspector.ResourceRevisionTreeElement.prototype.get itemURL): (WebInspector.ResourceRevisionTreeElement.prototype.onselect): (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart): (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._ensureContentLoaded): (WebInspector.SourceFrame.prototype.requestContent): (WebInspector.SourceFrame.prototype.commitEditing.didEditContent): (WebInspector.SourceFrame.prototype.commitEditing):
6:57 AM Changeset in webkit [83968] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-15 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Prevent Backspace keypresses from routing into the inspected page
​https://bugs.webkit.org/show_bug.cgi?id=58653

  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
6:44 AM Changeset in webkit [83967] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk

2011-04-15 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Text selection changes unexpectedly when dragging out of the <input>
​https://bugs.webkit.org/show_bug.cgi?id=55552

Tests that dragging outside of a contenteditable, input or textarea selects to the end of the
element, rather than jumping back to the beginning.

  • editing/selection/resources/select-out-of-floated-editable.js: Added. (log): (else.window.onmouseup): (getSelectionStart): (getSelectionEnd): (checkSelection):
  • editing/selection/select-out-of-editable-expected.txt: Added.
  • editing/selection/select-out-of-editable.html: Added.
  • editing/selection/select-out-of-floated-contenteditable-expected.txt: Added.
  • editing/selection/select-out-of-floated-contenteditable.html: Added.
  • editing/selection/select-out-of-floated-input-expected.txt: Added.
  • editing/selection/select-out-of-floated-input.html: Added.
  • editing/selection/select-out-of-floated-textarea-expected.txt: Added.
  • editing/selection/select-out-of-floated-textarea.html: Added.

2011-04-15 Alice Boxhall <​aboxhall@chromium.org>

Reviewed by Ryosuke Niwa.

Text selection changes unexpectedly when dragging out of the <input>
​https://bugs.webkit.org/show_bug.cgi?id=55552

Tests: editing/selection/select-out-of-editable.html

editing/selection/select-out-of-floated-contenteditable.html
editing/selection/select-out-of-floated-input.html
editing/selection/select-out-of-floated-textarea.html

  • page/EventHandler.cpp: (WebCore::selectionExtentRespectingEditingBoundary): When dragging from an editable element, check that the endpoint is not outside the element. If it is, translate the point into a local point within the editable element. (WebCore::EventHandler::updateSelectionForMouseDrag): Call targetPositionForSelectionEndpoint() to calculate the selection endpoint.
6:41 AM Changeset in webkit [83966] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results after r83939

  • platform/win/media/media-document-audio-repaint-expected.txt:
6:34 AM Changeset in webkit [83965] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a sometimes-failing test on Windows

<​http://webkit.org/b/58441> tracks the failure.

  • platform/win/Skipped: Added fast/events/pageshow-pagehide-on-back-cached-with-frames.html.
6:28 AM Changeset in webkit [83964] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a timing-out test on Windows

<​http://webkit.org/b/58654> tracks the failure.

  • platform/win/Skipped: Added media/video-controls-in-media-document.html.
6:12 AM Changeset in webkit [83963] by Adam Roben
  • 9 edits
    8 deletes in trunk

Roll out r83954

It was causing fast/dom/Window/timer-null-script-execution-context.html to crash on multiple
bots.

See <​http://webkit.org/b/58610>.

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout):
(WebCore::JSDOMWindow::setInterval):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::setInterval):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScheduledAction.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • page/ContentSecurityPolicy.cpp:
  • page/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Removed.
5:39 AM Changeset in webkit [83962] by pfeldman@chromium.org
  • 13 edits in trunk

2011-04-15 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor resource setContent / revisions infrastructure to get
rid of onRevert callback.
​https://bugs.webkit.org/show_bug.cgi?id=58649

Instead, we will have DomainModel/Resource binding responsible for changing
underlying model upon resource changes and vice versa.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::getStyleSheetText): (WebCore::InspectorCSSAgent::setStyleSheetText): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::assertStyleSheetForId):
  • inspector/InspectorCSSAgent.h:
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged): (WebInspector.CSSStyleModel.prototype.setStyleSheetText): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.prototype.setText): (WebInspector.CSSStyleModelResourceBinding): (WebInspector.CSSStyleModelResourceBinding.prototype.setContent): (WebInspector.CSSStyleModelResourceBinding.prototype._frameNavigated): (WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent): (WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders): (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent): (WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didReceiveSource): (WebInspector.DebuggerPresentationModel.prototype.editScriptSource): (WebInspector.DebuggerPresentationModelResourceBinding): (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent): (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
  • inspector/front-end/Object.js: (WebInspector.Object.prototype.hasEventListeners):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.registerDomainModelBinding): (WebInspector.Resource.prototype.isEditable): (WebInspector.Resource.prototype.setContent): (WebInspector.Resource.prototype.addRevision): (WebInspector.Resource.prototype.revertToThis.callback): (WebInspector.Resource.prototype.revertToThis): (WebInspector.ResourceDomainModelBinding): (WebInspector.ResourceDomainModelBinding.prototype.canSetContent): (WebInspector.ResourceDomainModelBinding.prototype.setContent):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceSourceFrame.prototype.isContentEditable): (WebInspector.ResourceSourceFrame.prototype.editContent): (WebInspector.ResourceSourceFrame.prototype.endEditing): (WebInspector.ResourceSourceFrame.prototype._clearIncrementalUpdateTimer): (WebInspector.ResourceSourceFrame.prototype._requestContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._resourceAdded): (WebInspector.FrameResourceTreeElement): (WebInspector.FrameResourceTreeElement.prototype._populateRevisions): (WebInspector.FrameResourceTreeElement.prototype._revisionAdded): (WebInspector.FrameResourceTreeElement.prototype._appendRevision):
  • inspector/front-end/inspector.html:
3:05 AM Changeset in webkit [83961] by Philippe Normand
  • 2 edits
    1 copy in trunk/LayoutTests

2011-04-15 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK platform results for
fast/css/font-face-repeated-url.html

  • fast/css/font-face-repeated-url-expected.txt:
  • platform/gtk/fast/css/font-face-repeated-url-expected.txt: Copied from LayoutTests/fast/css/font-face-repeated-url-expected.txt.
2:28 AM Changeset in webkit [83960] by caseq@chromium.org
  • 8 edits in trunk

2011-04-15 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed, rolling out r83949.
​http://trac.webkit.org/changeset/83949
​https://bugs.webkit.org/show_bug.cgi?id=57960

broke 31 tests in chromium win & linux

  • platform/chromium/test_expectations.txt:

2011-04-15 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed, rolling out r83949.
​http://trac.webkit.org/changeset/83949
​https://bugs.webkit.org/show_bug.cgi?id=57960

broke 31 tests in chromium win & linux

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::updateSubRect):
  • platform/graphics/gpu/Texture.h:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
1:50 AM Changeset in webkit [83959] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-15 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of two tests.

  • fast/css/font-face-repeated-url-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
1:10 AM Changeset in webkit [83958] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-15 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Create tests for network panel timing, size and raw headers text
​https://bugs.webkit.org/show_bug.cgi?id=58566

Added network timing, size and raw headers tests for Inspector
Since chromium used different version of network stack for layout
tests, these are interactive ui tests (DevToolsSanityTest.TestNetwork*)

  • src/js/Tests.js: (.TestSuite.prototype.testNetworkSize.finishResource): (.TestSuite.prototype.testNetworkSyncSize.finishResource): (.TestSuite.prototype.testNetworkRawHeadersText.finishResource): (.TestSuite.prototype.testNetworkTiming.finishResource):
12:55 AM Changeset in webkit [83957] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-15 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

Fix building with Sun Studio 12: function pointers for extern "C" are treated differently
​https://bugs.webkit.org/show_bug.cgi?id=58508

Since extern "C" makes a different type (although most compilers ignore that),
we should be more careful when passing NPAPI callback functions.

  • plugins/npapi.cpp: (NPN_PluginThreadAsyncCall):
12:54 AM Changeset in webkit [83956] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-04-15 Eric Seidel <​eric@webkit.org>

Reviewed by Mihai Parparita.

queues.webkit.org should display when a bot last rebooted
​https://bugs.webkit.org/show_bug.cgi?id=58562

There is more repeated code here than I would like. I fear
my django-fu isn't quite up to snuff.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/templates/queuestatus.html:
12:43 AM Changeset in webkit [83955] by Philippe Normand
  • 191 edits in trunk

2011-04-15 Philippe Normand <​pnormand@igalia.com>

Unreviewed, rollout r83894 r83827 r83810 r83809 r83808.
r83808 and its follow-up commits broke GTK Release builds.
​https://bugs.webkit.org/show_bug.cgi?id=58483

12:39 AM Changeset in webkit [83954] by abarth@webkit.org
  • 9 edits
    8 adds in trunk

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block string arguments to setTimeout and setInterval unless options eval-script
​https://bugs.webkit.org/show_bug.cgi?id=58610

It's somewhat sadness that the JSC and V8 code for setTimeout and
setInterval are so different. I struggled for a while with how to
handle the worker case, but I decided to punt on it for now.

Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html

http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
  • bindings/js/ScheduledAction.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowEval):
  • page/ContentSecurityPolicy.h:

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

CSP should block string arguments to setTimeout and setInterval unless options eval-script
​https://bugs.webkit.org/show_bug.cgi?id=58610

Herein lies a four-way testing matrix.

  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.
12:37 AM Changeset in webkit [83953] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for CSP's 'self' source
​https://bugs.webkit.org/show_bug.cgi?id=58604

  • http/tests/security/contentSecurityPolicy/script-src-self-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-self.html: Added.

2011-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for CSP's 'self' source
​https://bugs.webkit.org/show_bug.cgi?id=58604

This change is now trivially easy.

Test: http/tests/security/contentSecurityPolicy/script-src-self.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPSourceList::addSourceSelf):
12:13 AM Changeset in webkit [83952] by commit-queue@webkit.org
  • 18 edits in trunk

2011-04-15 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Renaming TRACK feature define to VIDEO_TRACK
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • configure.ac:

2011-04-15 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Renaming TRACK feature define to VIDEO_TRACK
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Renaming TRACK feature define to VIDEO_TRACK
​https://bugs.webkit.org/show_bug.cgi?id=53556

No new tests. No new functionality.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLTagNames.in:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/HTMLTrackElement.idl:

2011-04-15 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Renaming TRACK feature define to VIDEO_TRACK
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

2011-04-15 Anna Cavender <​annacc@chromium.org>

Reviewed by Eric Carlson.

Renaming TRACK feature define to VIDEO_TRACK
​https://bugs.webkit.org/show_bug.cgi?id=53556

  • Configurations/FeatureDefines.xcconfig:

Apr 14, 2011:

11:29 PM Changeset in webkit [83951] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Ctrl+Left/Right switch panels during live editing
​https://bugs.webkit.org/show_bug.cgi?id=58521

Disable Ctrl+Left/Right keyboard shortcuts while in live edit.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.readOnlyStateChanged):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set readOnly): (WebInspector.TextViewer.prototype.get readOnly): (WebInspector.TextViewer.prototype._doubleClick): (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing): (WebInspector.TextViewer.prototype._commitEditing): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewerDelegate.prototype.readOnlyStateChanged): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
  • inspector/front-end/inspector.js: (WebInspector.markBeingEdited): (WebInspector.isEditingAnyField): (WebInspector.startEditing.cleanUpAfterEditing):
10:55 PM Changeset in webkit [83950] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable raw HTTP headers support
​https://bugs.webkit.org/show_bug.cgi?id=58259

Added raw headers text support to inspector.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get rawRequestHeadersText): (WebInspector.Resource.prototype.set rawRequestHeadersText): (WebInspector.Resource.prototype.get requestHeadersSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype.get rawResponseHeadersText): (WebInspector.Resource.prototype.set rawResponseHeadersText): (WebInspector.Resource.prototype.get responseHeadersSize): (WebInspector.Resource.prototype._headersSize):
  • inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView): (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders): (WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): (WebInspector.ResourceHeadersView.prototype._refreshHeaders): (WebInspector.ResourceHeadersView.prototype._refreshRawHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRawRequestHeadersText): (WebInspector.ResourceHeadersView.prototype._toggleRawResponseHeadersText): (WebInspector.ResourceHeadersView.prototype._createToggleButton): (WebInspector.ResourceHeadersView.prototype._createHeadersToggleButton):
  • inspector/front-end/networkPanel.css: (.resource-headers-view .outline-disclosure li .header-toggle): (.resource-headers-view .outline-disclosure li.expanded .header-toggle): (.resource-headers-view .outline-disclosure li .header-toggle:hover): (.resource-headers-view .outline-disclosure li.raw-headers-text):
  • platform/network/ResourceLoadInfo.h:

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable raw HTTP headers support
​https://bugs.webkit.org/show_bug.cgi?id=58259

Added raw headers text support to inspector.

  • public/WebHTTPLoadInfo.h:
  • src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::rawRequestHeadersText): (WebKit::WebHTTPLoadInfo::setRawRequestHeadersText): (WebKit::WebHTTPLoadInfo::rawResponseHeadersText): (WebKit::WebHTTPLoadInfo::setRawResponseHeadersText):
10:43 PM Changeset in webkit [83949] by commit-queue@webkit.org
  • 8 edits in trunk

2011-04-14 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Accelerated 2D Canvas is slow to execute putImageData
​https://bugs.webkit.org/show_bug.cgi?id=57960

2011-04-14 Justin Novosad <​junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Accelerated 2D Canvas is slow to execute putImageData
​https://bugs.webkit.org/show_bug.cgi?id=57960

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): Added an option for using the blend ops for alpha multiplication instead of compositing. (WebCore::GLES2Canvas::applyClipping): (WebCore::GLES2Canvas::putImageData): New method for drawing raw pixel data from memory to the canvas (WebCore::GLES2Canvas::putUnmultipliedImageData): Wrapper for putImageData (WebCore::GLES2Canvas::putPremultipliedImageData): Wrapper for putImageData
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::updateSubRect): Added an overload of the updateSubRect method that can receive a pixel of a size that is different from texture size. Improved the performance of updateSubrect by avoiding the allocation of a temporary buffer when not required.
  • platform/graphics/gpu/Texture.h:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): In the unmultiplied path, division by alpha now performs proper rounding in order to avoid generational degradation with putImageData (WebCore::putImageData): Alpha multiplication now performs proper rounding in order to be consistent with the hardware rendering path: OpenGL always rounds when converting to fixed point representation. (WebCore::ImageBuffer::putUnmultipliedImageData): Now supports a hardware rendering path, which eliminates the need for a readback from the GPU (WebCore::ImageBuffer::putPremultipliedImageData): Now supports a hardware rendering path, which eliminates the need for a readback from the GPU
10:24 PM Changeset in webkit [83948] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, test expectations for more bug 57113 fallout.

  • platform/chromium/test_expectations.txt:
10:22 PM Changeset in webkit [83947] by commit-queue@webkit.org
  • 5 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Rewrote video-controls-in-media-document layouttest to use the shadow
DOM (possible as of r83397) and avoid the need for pixel-test status.
​https://bugs.webkit.org/show_bug.cgi?id=54634

  • media/video-controls-in-media-document-expected.txt: Added.
  • media/video-controls-in-media-document.html:
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium-mac-leopard/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/chromium-win-xp/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium-win-xp/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.checksum: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.png: Removed.
  • platform/chromium/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/media/video-controls-in-media-document-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/win/Skipped:
10:19 PM Changeset in webkit [83946] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-04-14 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by Adam Barth.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563


Fixed compile error on Mac when using Core Graphics.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect):
10:18 PM Changeset in webkit [83945] by joone.hur@collabora.co.uk
  • 6 edits
    2 adds
    1 delete in trunk/Source/WebCore

2011-04-14 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

Creating a CairoPath instance is not thread safe
​https://bugs.webkit.org/show_bug.cgi?id=58514

This patch allows a cairo surface to be created just one time in order to
guarantee thread safety.
In addition, CairoPath.{h,cpp} is renamed to PlatformPathCairo.{h,cpp} to
prevent confusing them with PathCairo.cpp

  • CMakeListsEfl.txt: Added PlatformPathCairo.cpp
  • GNUmakefile.list.am: Added PlatformPathCairo.{h,cpp} instead of CairoPath.h.
  • platform/graphics/cairo/CairoPath.h: Removed.
  • platform/graphics/cairo/CairoUtilities.cpp: Include PlatformPathCairo.h instead of CairoPath.h.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
  • platform/graphics/cairo/PathCairo.cpp: Ditto.
  • platform/graphics/cairo/PlatformPathCairo.cpp: Added. (WebCore::getPathSurface): Getting a static cairo surface. (WebCore::CairoPath::CairoPath): Moved the implementation of the constructor into the CPP file.
  • platform/graphics/cairo/PlatformPathCairo.h: Renamed CairoPath.h to this. (WebCore::CairoPath::~CairoPath): (WebCore::CairoPath::context):
10:13 PM Changeset in webkit [83944] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-14 Nat Duca <​nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add lowpass filter and graph to fps indicator
​https://bugs.webkit.org/show_bug.cgi?id=58186

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay): (WebCore::CCHeadsUpDisplay::drawHudContents): (WebCore::CCHeadsUpDisplay::drawFPSCounter): (WebCore::CCHeadsUpDisplay::drawPlatformLayerTree): (WebCore::CCHeadsUpDisplay::onPresent):
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
10:05 PM Changeset in webkit [83943] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=58612
Crash switching overlay/non-overlay scrollbar preference
(WebCore::Page::setNeedsRecalcStyleInAllFrames + 9)
-and corresponding-
<rdar://problem/9241920>

Reviewed by Adele Peterson.

Speculative fix: Page could definitely be null here.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollbarStyleChanged):

9:29 PM Changeset in webkit [83942] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
​https://bugs.webkit.org/show_bug.cgi?id=58447

FrameLoader now takes encoded data length for synchronous requests from the field with the same name.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
  • platform/network/ResourceLoadInfo.h: (WebCore::ResourceLoadInfo::ResourceLoadInfo):

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
​https://bugs.webkit.org/show_bug.cgi?id=58447

FrameLoader now takes encoded data length for synchronous requests from the field with the same name.

  • public/WebHTTPLoadInfo.h:
  • src/WebHTTPLoadInfo.cpp: (WebKit::WebHTTPLoadInfo::encodedDataLength): (WebKit::WebHTTPLoadInfo::setEncodedDataLength):
8:52 PM Changeset in webkit [83941] by commit-queue@webkit.org
  • 23 edits in trunk

2011-04-14 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563

This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas. The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium. We will eventually define an API that every port using skia will define.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/ImageBufferDataSkia.h:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize):
  • platform/graphics/chromium/PlatformCanvas.h:
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::setCanvas): (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::canvas): (WebCore::PlatformContextSkia::printing): (WebCore::PlatformContextSkia::setPrinting):

2011-04-14 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563

  • public/WebCanvas.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage):
  • tests/TransparencyWinTest.cpp: (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::TEST):

2011-04-14 Alok Priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove dependency on chromium skia::PlatformCanvas
​https://bugs.webkit.org/show_bug.cgi?id=57563

  • DumpRenderTree/chromium/TestShell.cpp: (makeCanvasOpaque): (TestShell::dumpImage):
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: (WebThemeControlDRTWin::WebThemeControlDRTWin): (WebThemeControlDRTWin::draw): (WebThemeControlDRTWin::drawTextField): (WebThemeControlDRTWin::drawProgressBar):
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas):
  • DumpRenderTree/chromium/WebViewHost.h:
8:48 PM Changeset in webkit [83940] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

PumpSession should not call currentTime() in the constructor
​https://bugs.webkit.org/show_bug.cgi?id=55211

currentTime() is expensive. So we avoid calling it in the constructor
and instead set startTime on the first check for a yield
(which in the synchronous case never happens, and in the yielding
case will happen immediately after the first token due to
processedTokens being set to INT_MAX).

This ended up being a large win on (my local copy of)
peacekeeper's domDynamicCreationCreateElement:

Before:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377

After:
avg 345.96666666666664
median 346
stdev 1.6829207415152454
min 343
max 349

  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession): (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
8:43 PM Changeset in webkit [83939] by commit-queue@webkit.org
  • 6 edits in trunk

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Update expectation to reflect removal of the -25px bottom margin.
​https://bugs.webkit.org/show_bug.cgi?id=58442

  • media/media-document-audio-repaint-expected.txt:

2011-04-14 Ami Fischman <​fischman@google.com>

Reviewed by Eric Carlson.

Remove unnecessary bottom margin of controls in video elements on media documents.
This makes the cases of media documents and non-media documents consistent,
and makes it possible to reason about the height of a rendered media document
(needed e.g. for sizing iframes).

This change is covered by (the currently Skipped, but soon-to-be-un-Skipped)
media/video-controls-in-media-document.html layouttest (see bug 54634 for
the un-Skipping).

​https://bugs.webkit.org/show_bug.cgi?id=58442

  • css/mediaControls.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
  • css/mediaControlsEfl.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
  • css/mediaControlsQuickTime.css: (video:-webkit-full-page-media::-webkit-media-controls-panel):
8:39 PM Changeset in webkit [83938] by ggaren@apple.com
  • 11 edits in trunk/Source/WebCore

2011-04-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Use opaque roots instead of direct marking for nodes in the DOM
​https://bugs.webkit.org/show_bug.cgi?id=58624

A node treats the root of its tree (usually the document) as its opaque
root during GC.


This is needed for correctness in a generational GC world, but it also
happens to be a 3.5X speedup in a DOM-heavy GC test (scratch-gc-dom2.html).

  • bindings/js/DOMWrapperWorld.cpp: (WebCore::isObservable): (WebCore::isReachableFromDOM): Moved a helper function from JSDOMBinding. We use this function to determine whether a node is observable.

(WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): Start using
our weak handle callback to determine reachability, instead of direct
marking traversal through the DOM.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::markChildren): Updated to use the opaque roots mechanism instead of direct marking.
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h: Moved code mentioned above. Removed markDOMNodeWrapper because it is now unused. This is a good thing because markDOMNodeWrapper used deprecatedAppend, which is not compatible with generational GC.
  • bindings/js/JSDOMImplementationCustom.cpp: (WebCore::JSDOMImplementation::markChildren): Updated to use opaque roots.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::markChildren): No need to mark our child nodes directly, since they will take care of themselves through the opaque roots mechanism.
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::markChildren): Updated to use opaque roots.
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): No need to mark our tree or our document directly, since they will take care of themselves through the opaque roots mechanism.
  • bindings/js/JSNodeCustom.h: (WebCore::root): Helper function for accessing the root of a node tree. This is O(1) while you're in the document, O(log(N)) when you're in a reasonably balanced disconnected tree, and O(N) in the pathological case of a disconnected tree that's shaped like a linked list. If average case O(long(N)) turns out to be too slow, we can optimize through use of rare data or an external hash table, but it is so uncommon that I have ignored it for now.
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::markChildren): Updated to use opaque roots.
8:30 PM Changeset in webkit [83937] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Guess what? ChickenW chromium test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
8:18 PM Changeset in webkit [83936] by commit-queue@webkit.org
  • 3 edits in trunk/Source

2011-04-14 Mike Reed <​reed@google.com>

Reviewed by Kenneth Russell.

fix shadows with gradients
​https://bugs.webkit.org/show_bug.cgi?id=58376

No new tests. Existing tests exercise this
LayoutTests/fast/canvas/canvas-fillPath-gradient-shadow.html

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
8:08 PM Changeset in webkit [83935] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-14 Brian Salomon <​bsalomon@google.com>

Reviewed by Kenneth Russell.

In skia platform call SkBitmap::notifyPixelsChanged on WebGL readback
​https://bugs.webkit.org/show_bug.cgi?id=58543

No new tests. Tested by fast/canvas/webgl/canvas-test.html

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
7:54 PM Changeset in webkit [83934] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test in WK2 that requires
layoutTestController.overridePreference().

  • platform/mac-wk2/Skipped:
7:40 PM Changeset in webkit [83933] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: No headers information in network panel for downloads.
​https://bugs.webkit.org/show_bug.cgi?id=58139

Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.

  • http/tests/inspector/network/download-expected.txt: Added.
  • http/tests/inspector/network/download.html: Added.
  • http/tests/inspector/network/resources/download.zzz: Added.

2011-04-14 Vsevolod Vlasov <​vsevik@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: No headers information in network panel for downloads.
​https://bugs.webkit.org/show_bug.cgi?id=58139

Passed resource response to inspector for PolicyDownload and PolicyIgnore requests.

Test: http/tests/inspector/network/download.html

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl): (WebCore::InspectorInstrumentation::continueWithPolicyDownloadImpl): (WebCore::InspectorInstrumentation::continueWithPolicyIgnoreImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::continueWithPolicyDownload): (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
7:12 PM Changeset in webkit [83932] by joone.hur@collabora.co.uk
  • 3 edits in trunk/Source/WebCore

2011-04-14 Joone Hur <​joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

Convert use of raw pointers to RefPtr in using Cairo
​https://bugs.webkit.org/show_bug.cgi?id=57717

No new tests added becaue of just replacing raw pointers with smart pointers.

  • platform/graphics/cairo/ContextShadowCairo.cpp: Use a RefPtr<cairo_surface_t> instead of raw pointer. (WebCore::purgeScratchBuffer): (WebCore::getScratchBuffer):
  • platform/graphics/cairo/ImageBufferCairo.cpp: Use a RefPtr<cairo_t> instead of raw pointer. (copySurface):
7:12 PM Changeset in webkit [83931] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-04-14 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Antonio Gomes.

Memory cache API
​https://bugs.webkit.org/show_bug.cgi?id=58016

  • ewk/ewk_settings.cpp: (ewk_settings_cache_enable_get): (ewk_settings_cache_enable_set): (ewk_settings_cache_capacity_set):
  • ewk/ewk_settings.h:
7:09 PM Changeset in webkit [83930] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

2011-04-14 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
​https://bugs.webkit.org/show_bug.cgi?id=57818

  • fast/forms/select-background-none.html: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-background-none-expected.txt: Added.
  • platform/mac/fast/forms/select-background-none-expected.txt: Added.

2011-04-14 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium]Change menu list background fallback value to transparent to work background:none for HTML select tag.
​https://bugs.webkit.org/show_bug.cgi?id=57818

Test: fast/forms/select-background-none.html

This fix is only for Chromium on Linux. Chromium on Mac already works fine.
But Windows has the same problem. This change doesn't include Windows part.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::paintMenuList): Change the default color to transparent.
6:54 PM Changeset in webkit [83929] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Hide DFG_JIT_RESTRICTIONS behind ARITHMETIC_OP() macro, and rename
m_regressionGuard to m_parseFailed, such that it can be reused for
other failure cases.

Rubber stamped by Geoffrey Garen.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):

6:44 PM Changeset in webkit [83928] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

2011-04-14 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=58007

Adds flag to start the test browsers maximized.
Symbian started maximized on QtTestBrowser - made MiniBrowser follow
suit.
Also fixes some ToggleFullScreen issues so that prior window state is
restored.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::toggleFullScreenMode):
  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::toggleFullScreenMode):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
6:35 PM Changeset in webkit [83927] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, update test expectations for huge-layer-img.

  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [83926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-14 Luke Macpherson <​macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement border style css properties in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=58506

No new functionality added.

  • css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added new property initializers.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Removed old property handlers.
6:28 PM Changeset in webkit [83925] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-04-14 Leandro Gracia Gil <​leandrogracia@chromium.org>

Reviewed by Steve Block.

[Chromium] Two new tests added by r83287 fail in chromium
​https://bugs.webkit.org/show_bug.cgi?id=58147

Solved by enabling the Media Stream API in the chromium feature override file.

  • platform/chromium/test_expectations.txt:
6:28 PM Changeset in webkit [83924] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Bug 58620 - DFG JIT - loading of arguments should not be lazy

Reviewed by Geoffrey Garen.

This optimization is overly simplistic. It only works because we never
write out definitions to arguments (since we currently only compile
single block functions). Revert this for now, we may want to reintroduce
something like this again in the future, but it will need to be aware
how to schedule definitions to arguments versus lazy loads that have not
yet been performed.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::needsSpill):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::initConstantInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

6:24 PM Changeset in webkit [83923] by enne@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 Adrienne Walker <​enne@google.com>

[chromium] Unreviewed, update test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=58619

  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [83922] by Dimitri Glazkov
  • 3 edits
    3 adds in trunk

2011-04-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Presence of shadow DOM should suppress rendering of ordinary child nodes
​https://bugs.webkit.org/show_bug.cgi?id=58073

  • fast/dom/shadow/no-renderers-for-light-children-expected.txt: Added.
  • fast/dom/shadow/no-renderers-for-light-children.html: Added.

2011-04-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Ojan Vafai.

Presence of shadow DOM should suppress rendering of ordinary child nodes
​https://bugs.webkit.org/show_bug.cgi?id=58073

Test: fast/dom/shadow/no-renderers-for-light-children.html

  • dom/Node.cpp: (WebCore::shadowRoot): Added a helper function. (WebCore::Node::setDocumentRecursively): Changed to use the helper. (WebCore::shouldCreateRendererFor): Expanded a long condition check into a helper function,

added a check for children of an element with a shadow DOM.

(WebCore::Node::createRendererAndStyle): Changed to use the helper.

6:02 PM Changeset in webkit [83921] by jamesr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Add correct chromium expectation for compositing/layer-creation/overflow-scroll-overlap

  • platform/chromium-gpu/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [83920] by jamesr@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Update chromium test expectations.

  • platform/chromium-gpu/compositing/layer-creation: Removed.
  • platform/chromium/test_expectations.txt:
5:51 PM Changeset in webkit [83919] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Select All context menu item doesn't work in Flash
​https://bugs.webkit.org/show_bug.cgi?id=58615
<rdar://problem/9225761>

In some cases, -[NSWindow isKeyWindow] will return false even if
a window is the key window, so we have to compare our window
against -[NSApplication keyWindow].

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isViewWindowActive):
5:47 PM Changeset in webkit [83918] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-14 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add CFPreference based backend for WebKit2 preferences
​https://bugs.webkit.org/show_bug.cgi?id=58605

  • UIProcess/cf/WebPreferencesCF.cpp: (WebKit::cfStringFromWebCoreString): (WebKit::makeKey): (WebKit::setStringValueIfInUserDefaults): (WebKit::setBoolValueIfInUserDefaults): (WebKit::setUInt32ValueIfInUserDefaults): (WebKit::setDoubleValueIfInUserDefaults): (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey): Implement platform functions using CFPreferences API.
5:44 PM Changeset in webkit [83917] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

add checkbox to only show unexpected results to new results file
​https://bugs.webkit.org/show_bug.cgi?id=58606

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
5:25 PM Changeset in webkit [83916] by barraclough@apple.com
  • 21 edits in trunk

Bug 58600 - DFG JIT bugs in ValueToInt, PutByVal

Reviewed by Geoffrey Garen.

The bug in PutByVal is that an operand is in JSValueOperand - when this
locks an integer into a register it will always retag the value without
checking if the register is already locked. This is a problem where the
value being stored by a PutByVal is the same as the subscript.
The subscript is locked into a register first, as a strict integer.
Locking the value results in the subscript being modified.

The bug in ValueToInt related to the function of sillentFillAllRegisters.
The problem is that this method will restore all register values from
prior to the call, overwriting the result of the call out. Allow a
register to be passed to specifically be excluded from being preserved.

Source/JavaScriptCore:

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::debugOffset):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::debugOffset):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::debugOffset):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::debugAddress):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::debugOffset):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::orPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::debugOffset):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGGenerationInfo.h:
  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::fillJSValue):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isConstant):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::isConstant):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:

(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/array-index-immediate-types-expected.txt:
  • fast/js/script-tests/array-index-immediate-types.js:

(putSelf):

5:16 PM Changeset in webkit [83915] by enne@google.com
  • 46 edits in trunk

2011-04-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Tile content and image layers
​https://bugs.webkit.org/show_bug.cgi?id=57113

Rebaseline a number of image tests where slight filtering differences
from using tiles caused test failures with exact pixel matching.
None of these results are perceptually different.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum:
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum:
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum:
  • platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum:
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
  • platform/chromium/test_expectations.txt:

2011-04-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Tile content and image layers
​https://bugs.webkit.org/show_bug.cgi?id=57113

Layers tile by default if any dimension is larger than 512. Smaller
layers are contained within a single texture but still use the tiler
infrastructure so that there's only one code path.

Remove large layer support from content layers. Content layers no
longer own a platform canvas--they own a tiler. Refactor tiler to
allow for better separation of update/upload/paint. Add rect
parameter to update and draw functions on layers for the layer-space
rect of interest. This is necessary to know which tiles need to be
drawn.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerPainter::ContentLayerPainter): (WebCore::ContentLayerPainter::paint): (WebCore::ContentLayerChromium::paintContentsIfDirty): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::tilingTransform): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::layerBounds): (WebCore::ContentLayerChromium::updateLayerSize): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::createTilerIfNeeded): (WebCore::ContentLayerChromium::updateCompositorResources): (WebCore::ContentLayerChromium::setTilingOption): (WebCore::ContentLayerChromium::bindContentsTexture): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::setIsMask): (WebCore::ContentLayerChromium::dumpLayerProperties):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::drawsContent):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): (WebCore::ImageLayerChromium::updateCompositorResources): (WebCore::ImageLayerChromium::layerBounds): (WebCore::ImageLayerChromium::tilingTransform):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::invalidateRect): (WebCore::LayerChromium::paintContentsIfDirty): (WebCore::LayerChromium::setIsMask): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::paintContentsRecursive): (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::getSingleTexture): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::uploadCanvas): (WebCore::LayerTilerChromium::updateFromPixels): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::unreserveTextures):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::setLayerRenderer): (WebCore::LayerTilerChromium::skipsDraw):
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::Painter::Painter):
  • platform/graphics/chromium/PlatformCanvas.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: (WebCore::CCCanvasLayerImpl::draw):
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::draw):
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp: (WebCore::CCPluginLayerImpl::draw):
  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::draw):
  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:
4:54 PM Changeset in webkit [83914] by jamesr@google.com
  • 4 edits in trunk

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
​https://bugs.webkit.org/show_bug.cgi?id=58575

Remove expected failure lines for pixel tests that now should pass.

  • platform/chromium/test_expectations.txt:

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(83820): Composited scrollbar layers sometimes not positioned when initially creating frame
​https://bugs.webkit.org/show_bug.cgi?id=58575

Tell the RenderLayerCompositor to create/destroy composited layers for overflow controls on a FrameView when visibleContentsResized()
is called, not contentsResized() so that we always update layers when adding or removing scrollbars.

Covered by several chromium pixel tests.

  • page/FrameView.cpp: (WebCore::FrameView::contentsResized): (WebCore::FrameView::visibleContentsResized):
4:52 PM Changeset in webkit [83913] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix some threading issues in IconDatabase.
​https://bugs.webkit.org/show_bug.cgi?id=57985

Reviewed by Brady Eidson.

No functionality change so no new tests. It would be very hard to test this, but
I am working on a change for bug 31639 to detect these (which makes layout tests
fail for at least one of these issues).

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::readFromDatabase): Release imageData so that it won't get deref'ed outside of locks.
(WebCore::IconDatabase::writeToDatabase): Acquire m_urlAndIconLock because the SharedBuffer<> data
is used, and this lock seems to be the one which consistently guards it.

4:31 PM Changeset in webkit [83912] by bfulgham@webkit.org
  • 5 edits
    2 adds in trunk/Tools

2011-04-13 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Martin Robinson.

[WinCairo] Implement ImageDiff Logic.
​http://bugs.webkit.org/show_bug.cgi?id=58486

  • DumpRenderTree/win/ImageDiffCairo.cpp: Added. (strtof): (readFromData): (createImageFromStdin): (releaseMallocBuffer): (createDifferenceImage): (imageHasAlpha): (writeToData): (main):
  • DumpRenderTree/win/ImageDiff.vcproj: Updated for new ImageDiffCairo.cpp (excluding from Apple builds).
  • DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use new ImageDiffWinCairoCommon.vsprops file.
  • DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use new ImageDiffWinCairoCommon.vsprops file.
  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
  • Scripts/old-run-webkit-tests: Make sure proper executable is built and executed for WinCairo port.
4:25 PM Changeset in webkit [83911] by crogers@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 Chris Rogers <​crogers@google.com>

Unreviewed.

Update preload-slow-loading.php in test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=58597

  • platform/chromium/test_expectations.txt:
4:20 PM Changeset in webkit [83910] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Drain the mark stack while marking weak handles, not after.
​https://bugs.webkit.org/show_bug.cgi?id=58574

Otherwise, items that would have caused more weak handle marking are
processed after all weak handle marking has finished, and referenced
weak handles get recycled.

  • heap/HandleHeap.cpp: (JSC::HandleHeap::markWeakHandles): Removed looping from here, since we want Heap::markRoots to be responsible for draining the mark stack.
  • heap/Heap.cpp: (JSC::Heap::markRoots): Moved looping to here, as explained above.


For efficiency's sake, drain the mark stack before starting to mark weak
handles. Otherwise, items drained while marking weak handles may force
an extra trip through the weak handle list.

For correctness's sake, drain the mark stack each time through the weak
handle list. Otherwise, opaque roots that would make weak handles reachable
are not discovered until after weak handle marking is over.

4:13 PM Changeset in webkit [83909] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/8665102> and ​https://bugs.webkit.org/show_bug.cgi?id=58595
Menu is not displayed for <input type=search results="5">

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::enabled): Return true, like all good search popup menus should.

  • WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:

(WebKit::WebPopupMenu::setUpPlatformData): Remember the shouldPopOver-ness.

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode): Remember the shouldPopOver-ness.
(WebKit::PlatformPopupMenuData::decode): Remember the shouldPopOver-ness.

  • Shared/PlatformPopupMenuData.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu): Use the shouldPopOver-ness to adjust display position.

4:12 PM Changeset in webkit [83908] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-04-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

only show expected failure type for ports that use an expectations file
​https://bugs.webkit.org/show_bug.cgi?id=58588

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4:08 PM Changeset in webkit [83907] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Add a comment with the bugzilla URL that tracks implementing
layoutTestController.setPluginsEnabled() in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
3:55 PM Changeset in webkit [83906] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue fails to catch IOError when results.html is missing
​https://bugs.webkit.org/show_bug.cgi?id=58589

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
3:48 PM Changeset in webkit [83905] by crogers@google.com
  • 3 edits
    1 delete in trunk/LayoutTests

2011-04-14 Chris Rogers <​crogers@google.com>

Unreviewed.

Rebaseline fast/box-shadow/box-shadow-transformed.html
and other test_expectations.txt fixup
​https://bugs.webkit.org/show_bug.cgi?id=58585

  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Removed.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium/test_expectations.txt:
3:42 PM Changeset in webkit [83904] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-14 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change.

Mark several tests as only failing in Linux debug, add a bug
number.

  • platform/chromium/test_expectations.txt:
3:32 PM Changeset in webkit [83903] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix for Mac installation script.

3:22 PM Changeset in webkit [83902] by ojan@chromium.org
  • 2 edits in trunk/Tools

2011-04-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Tony Chang.

sort columns in the new json_results.html file
​https://bugs.webkit.org/show_bug.cgi?id=58581

Also fix padding on TDs and the path to layout tests.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html:
3:16 PM Changeset in webkit [83901] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Crash in NetscapePluginModule::tryGetSitesWithData when NPP_GetSitesWithData returns null
​https://bugs.webkit.org/show_bug.cgi?id=58578
<rdar://problem/9275201>

It's OK for NPP_GetSitesWithData to return null.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryGetSitesWithData):
3:14 PM Changeset in webkit [83900] by dimich@chromium.org
  • 16 edits in trunk

Simplifying Worker termination sequence (removing unnecessary mutex)
​https://bugs.webkit.org/show_bug.cgi?id=57090

Reviewed by David Levin.

Source/WebCore:

No new tests. Existing Worker tests should pass.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
Check for Terminator-caused exception (or Terminator::shouldTerminate since sometimes
JS might not run significant enough chunk to be terminated by Terminator) and set
the flag to forbid future reentry into JS.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):

  • bindings/js/WorkerScriptController.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):

  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::proxy):
Symmetrical changes to JSC and V8 WorkerScriptControllers:

  • remove Mutex around operations with executionForbidden flag.
  • set/check that flag only on Worker thread.
  • some renaming in attempt to better reflect what the methods do.
  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::invokeEventHandler):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate):
Check for v8::TryCatch::CanContinue() and set forbidExecution flag.
This result indicates that TerminateExecution() was in effect - we should
not reenter V8 anymore after that.

  • dom/Document.h:

(WebCore::Document::isJSExecutionForbidden):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
Stop dispatching messages once the worker context started to close.
Per Workers spec, once WorkerGlobalScope.Close() is called, the next
JS execution does not happen, including onmessage events. Before this
change, Close() was setting the forbidExecution flag, indirectly stopping
events from dispatching.

  • dom/ScriptExecutionContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::close):
(WebCore::WorkerContext::isJSExecutionForbidden):

  • workers/WorkerContext.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

LayoutTests:

  • fast/workers/resources/shared-worker-lifecycle.js:

(createWorkerFrame): Fixing flaky worker test - removing document.write().

When document.write() is called directly from inline script as in this test, it appends to the document.
However, if worker threads from previously run test are still exiting,
the test defers itself using setTimeout() and in this case document.write() overwrites the whole document
and makes the test fail.

3:09 PM Changeset in webkit [83899] by Beth Dakin
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56493
Drag-scrolling overlay scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688>

Reviewed by Simon Fraser.

There was an original change to fix this in the normal hit-testing case, but hit
testing of transformed and/or positioned objects was still broken. The transformed
case is fixed by sending an OverlayScrollbarSizeRelevancy parameter to
calculateRects(). Getting positioned objects right is a little trickier. Those need
to opt into using temporary clip rects during hit testing. To avoid doing that when
it is not necessary, I added a new bit to ScrollView to track whether there are
currently overlay scrollbars painted in the view.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::containsScrollableAreaWithOverlayScrollbars):
(WebCore::ScrollView::setContainsScrollableAreaWithOverlayScrollbars):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::backgroundClipRect):
(WebCore::RenderLayer::calculateRects):

  • rendering/RenderLayer.h:
2:59 PM Changeset in webkit [83898] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:55 PM Changeset in webkit [83897] by Lucas Forschler
  • 1 copy in tags/Safari-534.29

New tag.

2:46 PM Changeset in webkit [83896] by Antti Koivisto
  • 8 edits
    2 adds in trunk

REGRESSION(r74107): Including svg format in @font-face rules makes Web Fonts fail to load
​https://bugs.webkit.org/show_bug.cgi?id=57766
<rdar://problem/9232183>

Reviewed by Oliver Hunt.

Source/WebCore:

Move the knowledge of whether to interpret a font as SVG from CachedFont to CSSFontFaceSource. This way
we can try to interpret the same cached resource in multiple ways.

Test: fast/css/font-face-repeated-url.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:

(WebCore::CSSFontFaceSource::setHasExternalSVGFont):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::ensureSVGFontData):

Use TextResourceDecoder correctly.

(WebCore::CachedFont::getSVGFontById):

  • loader/cache/CachedFont.h:
  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

LayoutTests:

  • fast/css/font-face-repeated-url-expected.txt: Added.
  • fast/css/font-face-repeated-url.html: Added.
2:39 PM Changeset in webkit [83895] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Make creating WebPreferences lazy
​https://bugs.webkit.org/show_bug.cgi?id=58570

Reviewed by Anders Carlsson.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):

  • UIProcess/WebPageGroup.h:

Don't create the WebPreference object until it is requested.

2:36 PM ThreadCommunication edited by levin@chromium.org
(diff)
2:09 PM Changeset in webkit [83894] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Temporarily remove assertion that's firing all the time.

RS=Anders

2:01 PM Changeset in webkit [83893] by kbr@google.com
  • 4 edits in trunk/Source/WebCore

2011-04-14 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Enable building Web Audio with MKL in Chrome-branded builds
​https://bugs.webkit.org/show_bug.cgi?id=58561

Factored out MKL support into a separate GYP file that is
incorporated in Chrome-branded builds. Changed how the FFTFrame
implementations are pulled in and chosen so that all files can be
unconditionally compiled.

Tested with both Chrome-branded build (incorporating MKL) and
Chromium build (building just FFTFrameStub.cpp) on Linux.

  • WebCore.gyp/WebCore.gyp:
  • platform/audio/fftw/FFTFrameFFTW.cpp:
  • platform/audio/mkl/FFTFrameMKL.cpp:
1:53 PM Changeset in webkit [83892] by alexis.menard@openbossa.org
  • 7 edits in trunk/Source

2011-01-26 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] Web Inspector does not highlight elements
​https://bugs.webkit.org/show_bug.cgi?id=35125

Adjust Web inspector to highlight elements on the page when the mouse
hovers the element on DOM inspector.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::highlight): (WebCore::InspectorClientQt::hideHighlight):

2011-04-14 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] Web Inspector does not highlight elements
​https://bugs.webkit.org/show_bug.cgi?id=35125

We should call drawNodeHighlight() just if a highlighted node exists
to avoid do save()/restore() on the Graphics Context unnecessarily.

Added highlightedNode() method to check if we need to call drawNodeHighlight()
and only on this case do save()/restore() on the Graphics Context.

  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::highlightedNode):
1:50 PM Changeset in webkit [83891] by enne@google.com
  • 4 edits in trunk/Source

2011-04-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] TilingData should return 1 tile when tile size is texture size.
​https://bugs.webkit.org/show_bug.cgi?id=58364

  • platform/graphics/gpu/TilingData.cpp: (WebCore::computeNumTiles):

2011-04-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] TilingData should return 1 tile if tile size is texture size.
​https://bugs.webkit.org/show_bug.cgi?id=58364

Update test to properly handle this case.

  • tests/TilingDataTest.cpp: (WebCore::TEST):
1:39 PM Changeset in webkit [83890] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Update chromium expectations for tests that have subtle 32vs64 bit rendering differences on linux in the GPU path.

  • platform/chromium/test_expectations.txt:
1:34 PM Changeset in webkit [83889] by aestes@apple.com
  • 3 edits
    4 adds in trunk

2011-04-14 Andy Estes <​aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r72141): Acid3 rendering is not pixel perfect.
​https://bugs.webkit.org/show_bug.cgi?id=55734

  • fast/text/zero-font-size.html: Added.
  • platform/mac/fast/text/zero-font-size-expected.checksum: Added.
  • platform/mac/fast/text/zero-font-size-expected.png: Added.
  • platform/mac/fast/text/zero-font-size-expected.txt: Added.

2011-04-14 Andy Estes <​aestes@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r72141): Acid3 rendering is not pixel perfect.
​https://bugs.webkit.org/show_bug.cgi?id=55734

WebCore should render text with a 0px font size at 0px regardless of
minimum font size settings. This is compatible with other browsers that
have a minimum font size preference and ensures pixel-perfect rendering
on Acid3.

Test: fast/text/zero-font-size.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If specifiedSize is 0, return specified size regardless of zoom factor or minimum font size.
1:31 PM Changeset in webkit [83888] by mdelaney@apple.com
  • 4 edits
    2 adds in trunk

2011-04-14 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Have canvas drawImageFromRect just redirect to use drawImage
​https://bugs.webkit.org/show_bug.cgi?id=58516

Test: fast/canvas/drawImageFromRect_withToDataURLAsSource.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • html/canvas/CanvasRenderingContext2D.h:

2011-04-14 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

Have canvas drawImageFromRect just redirect to use drawImage
​https://bugs.webkit.org/show_bug.cgi?id=58516

  • fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt: Added.
  • fast/canvas/drawImageFromRect_withToDataURLAsSource.html: Added.
1:26 PM Changeset in webkit [83887] by jamesr@google.com
  • 4 edits
    17 deletes in trunk

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=58535

Remove unnecessary baselines - the behavior on these tests should
match the mac port now.

  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Removed.

2011-04-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=58535

Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::shouldCompositeOverflowControls):
1:24 PM Changeset in webkit [83886] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=52810
​https://bugs.webkit.org/show_bug.cgi?id=52812

  • platform/qt/Skipped: Add svg/text/text-align-05-b.svg
1:17 PM Changeset in webkit [83885] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-14 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make protected object list in caches window reflect reality
​https://bugs.webkit.org/show_bug.cgi?id=58565

Make sure the heap includes objects protected by Strong handles
in its list of protected objects.

  • heap/HandleHeap.h:
  • heap/Heap.cpp: (JSC::HandleHeap::protectedObjectTypeCounts):
1:13 PM Changeset in webkit [83884] by jianli@chromium.org
  • 44 edits
    3 moves in trunk

BlobBuilder should be vendor-prefixed
​https://bugs.webkit.org/show_bug.cgi?id=58518

Reviewed by Darin Fisher.

Source/WebCore:

Renamed BlobBuilder to WebKitBlobBuilder.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.

(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):

  • fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.

(WebCore::WebKitBlobBuilder::create):

  • fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • fast/dom/script-tests/prototype-inheritance-2.js:

(constructorNamesForWindow):

  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/dom/window-domurl-crash.html:
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/filesystem/resources/file-writer-events.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-gc-blob.js:

(tenXBlob):
(startWrite):

  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-utils.js:
  • fast/js/global-constructors-expected.txt:
  • fast/js/script-tests/global-constructors.js:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/local/blob/resources/hybrid-blob-util.js:

(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):

  • http/tests/security/resources/create-filesystem-file.html:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/window-domurl-crash-expected.txt:
12:54 PM Changeset in webkit [83883] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Adam Barth <​abarth@webkit.org>

Remove some trailing whitespace. I'm making this change to initialize
the SVN credentials on a new commit-queue machine. I'm sure there's a
better way to do this, but I don't know it.

  • dom/Document.cpp: (WebCore::Document::Document):
12:50 PM Changeset in webkit [83882] by psolanki@apple.com
  • 13 edits in trunk

Set minimum priority for fast lane connections
​https://bugs.webkit.org/show_bug.cgi?id=58353

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMinimumFastLanePriority to allow javascript resources to use the fast
lane connections.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.

WebKitLibraries:

Add WKSetHTTPPipeliningMinimumFastLanePriority.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:55 AM Changeset in webkit [83881] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Dimitri Glazkov.

queues.webkit.org should display when a bot last passed a patch
​https://bugs.webkit.org/show_bug.cgi?id=58546

I am suspicious that some of our commit-queue instances are never
actually passing anything.

This will let us know if those bots are never passing patches.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/templates/queuestatus.html:
11:53 AM Changeset in webkit [83880] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Adam Roben.

REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
​https://bugs.webkit.org/show_bug.cgi?id=58545

Remove platform-specific overrides; the default behavior should
be working everywhere now, I think.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
11:52 AM Changeset in webkit [83879] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4.0

2011-04-14 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Martin Robinson.

Bump version to 1.4.0.

  • configure.ac:
11:46 AM Changeset in webkit [83878] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixed tests caused by r83873.

  • fast/filesystem/resources/file-writer-utils.js:

(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):

11:33 AM Changeset in webkit [83877] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/transforms/scrollIntoView-transformed.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58559

  • platform/qt/Skipped: Add fast/transforms/scrollIntoView-transformed.html until fix.
11:23 AM Changeset in webkit [83876] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-04-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queues are hitting an exception trying to land when the tree is red
​https://bugs.webkit.org/show_bug.cgi?id=58558

Just an un-tested (and thus broken) code path from yesterday's changes.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
11:19 AM Changeset in webkit [83875] by kbr@google.com
  • 5 edits in trunk/Source/WebCore

2011-04-14 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Fix Web Audio build on Linux Debug and with stub FFTFrame
​https://bugs.webkit.org/show_bug.cgi?id=58555

Built Chromium/Linux in Debug mode to test.

  • platform/audio/FFTFrame.cpp:
  • platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::initialize):
  • webaudio/AudioContext.cpp:
  • webaudio/DefaultAudioDestinationNode.cpp:
11:13 AM Changeset in webkit [83874] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-04-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: add initial implementation of WorkerScriptDebugServer
​https://bugs.webkit.org/show_bug.cgi?id=58552

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): each worker context now have a debug id (similar to frame contexts).
  • bindings/v8/WorkerScriptDebugServer.cpp: (WebCore::retrieveWorkerContext): (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer): (WebCore::WorkerScriptDebugServer::addListener): (WebCore::WorkerScriptDebugServer::removeListener): (WebCore::WorkerScriptDebugServer::getDebugListenerForContext): (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): run message loop until debugger command is received and execution is resumed. (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
  • bindings/v8/WorkerScriptDebugServer.h:
  • inspector/WorkerDebuggerAgent.cpp: (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer): (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
11:10 AM Changeset in webkit [83873] by jianli@chromium.org
  • 13 edits
    2 adds in trunk

Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
​https://bugs.webkit.org/show_bug.cgi?id=58496

Reviewed by Darin Fisher.

Source/WebCore:

Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.

Test: fast/files/blob-slice-test.html

  • fileapi/Blob.cpp:

(WebCore::Blob::webkitSlice):

  • fileapi/Blob.h:
  • fileapi/Blob.idl:

LayoutTests:

Added a new test to test the new behavior and also update all existing
tests to use the new name.

  • fast/dom/Window/window-properties.html:
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test-expected.txt: Added.
  • fast/files/blob-slice-test.html: Added.
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

  • fast/filesystem/resources/file-writer-utils.js:

(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):

  • http/tests/local/blob/script-tests/send-hybrid-blob.js:

():

  • http/tests/local/blob/script-tests/send-sliced-data-blob.js:

(runSliceTest):

  • http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:

(onStableFileDrop):
(onUnstableFileDrop):

  • http/tests/local/formdata/resources/send-form-data-common.js:

(testSendingFormData):

11:10 AM Changeset in webkit [83872] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Clang warning fixes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/mac/TextCheckerMac.mm:
  • WebProcess/Downloads/mac/DownloadMac.mm:
10:53 AM Changeset in webkit [83871] by Csaba Osztrogonác
  • 3168 edits
    2 adds in trunk

[Qt] Height of "Ahem" font differs from all other ports.
​https://bugs.webkit.org/show_bug.cgi?id=57954

Source/WebCore:

Patch by Andreas Kling <​kling@webkit.org> on 2011-04-14
Reviewed by Benjamin Poulain.

QFontMetricsF::descent() returns the actual descent minus 1,
to account for the baseline. Add it back to get correct metrics
for WebKit.

QFontMetricsF::leading() may return negative values on some
platforms (those using FreeType), this breaks WebKit's assumption
that lineSpacing >= (ascent + descent), so we work around this in
the same fashion as SimpleFontDataFreeType and SimpleFontDataPango.

This is covered by thousands of layout tests.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

  • platform/qt/ [...]: Update expected files.
10:47 AM Changeset in webkit [83870] by tony@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-14 Tony Chang <​tony@chromium.org>

Reviewed by Adam Roben.

make PrettyPatch.rb aware of checksums in png files
​https://bugs.webkit.org/show_bug.cgi?id=58387

Patch v2 with nil checks in the case of file adds and deletes.

  • PrettyPatch/PrettyPatch.rb:
10:26 AM Changeset in webkit [83869] by kevino@webkit.org
  • 8 edits in trunk

[wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.

10:21 AM Changeset in webkit [83868] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

RuntimeApplicationChecks.h needs to be a private header so WebKit can find it.

  • WebCore.xcodeproj/project.pbxproj:
10:20 AM ThreadCommunication edited by levin@chromium.org
(diff)
10:10 AM Changeset in webkit [83867] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

WebKit2: Add an option for a PageGroup to be invisible to the History Client.
​https://bugs.webkit.org/show_bug.cgi?id=58547

Reviewed by Timothy Hatcher.

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectorPageGroup):
The Web Inspector should not be visible to the History Client, because its HTML-based nature
should not be exposed through the API.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):

  • UIProcess/WebPageGroup.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
Do not send the message to the WebContent for the history client.
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
Ditto.
(WebKit::WebFrameLoaderClient::setTitle):
Ditto.

  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):

9:57 AM Changeset in webkit [83866] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix for r83864.

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._childNodeRemoved):
9:48 AM April 2011 Meeting edited by levin@chromium.org
(diff)
9:47 AM Changeset in webkit [83865] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Content area highlight does not cover scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=58528

  • inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
9:18 AM Changeset in webkit [83864] by podivilov@chromium.org
  • 16 edits
    1 add
    1 delete in trunk

2011-04-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: re-implement dom breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=57038

  • inspector/debugger/dom-breakpoints.html:

2011-04-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: re-implement dom breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=57038

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js: Removed.
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.NativeBreakpointsSidebarPane.prototype._reset): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMAgent.prototype._childNodeRemoved):
  • inspector/front-end/DOMBreakpointsSidebarPane.js: Added. (WebInspector.DOMBreakpointsSidebarPane): (WebInspector.DOMBreakpointsSidebarPane.prototype.setInspectedURL): (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu.toggleBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu): (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend): (WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.formatters.s): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.append): (WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage): (WebInspector.DOMBreakpointsSidebarPane.prototype.nodeRemoved): (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpointsForNode): (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.DOMBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.DOMBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.DOMBreakpointsSidebarPane.prototype._createBreakpointId): (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.DOMBreakpointsSidebarPane.prototype.restoreBreakpoints):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.coalesceCollapsedCrumbs):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage): (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype._set):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.inspectedURLChanged):
  • inspector/front-end/utilities.js: ():
9:00 AM Changeset in webkit [83863] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.4.0

Merging r83728.

9:00 AM April 2011 Meeting edited by ddkilzer@webkit.org
(diff)
8:51 AM Changeset in webkit [83862] by satish@chromium.org
  • 3 edits
    2 adds in trunk

2011-04-14 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Disable speech input for readonly and disabled input fields.
​https://bugs.webkit.org/show_bug.cgi?id=58540

  • fast/speech/input-readonly-and-disabled-expected.txt: Added.
  • fast/speech/input-readonly-and-disabled.html: Added.

2011-04-14 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Disable speech input for readonly and disabled input fields.
​https://bugs.webkit.org/show_bug.cgi?id=58540

Test: fast/speech/input-readonly-and-disabled.html

  • html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
8:49 AM Changeset in webkit [83861] by loislo@chromium.org
  • 7 edits in trunk

2011-04-14 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Rollout r83849 and r83857.

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/front-end/inspector.js:

2011-04-14 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed. Rollout r83849 and r83857.

  • http/tests/inspector-enabled/database-open.html:
8:47 AM Changeset in webkit [83860] by satish@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-14 Satish Sampath <​satish@chromium.org>

Reviewed by Anders Carlsson.

Don't emit RegExp tables for chromium where they are not used
​https://bugs.webkit.org/show_bug.cgi?id=58544

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • create_regex_tables: Added the "--notables" command line argument.
8:25 AM Changeset in webkit [83859] by Dimitri Glazkov
  • 76 edits
    12 adds
    23 deletes in trunk/LayoutTests

2011-04-14 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r83855.
​http://trac.webkit.org/changeset/83855

After r83847 has been rolled out, these expectations no longer
apply.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Added.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum: Added.
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.checksum: Added.
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.checksum: Added.
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum: Added.
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum: Added.
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.checksum: Added.
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum: Added.
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
8:23 AM Changeset in webkit [83858] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-04-14 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r83847.
​http://trac.webkit.org/changeset/83847
​https://bugs.webkit.org/show_bug.cgi?id=58477

Chromium media controls do use button borders, so this change
is incorrect.

  • css/mediaControls.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
8:15 AM Changeset in webkit [83857] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-14 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed test fix for r83849.

It was flaky.

  • http/tests/inspector-enabled/database-open.html:
7:42 AM Changeset in webkit [83856] by Adam Roben
  • 1 edit
    20 adds in trunk/LayoutTests

Add new Windows expected results after r83820

Windows differs from Mac on these tests due to extra scrollbar layers. Presumably this is
because Mac uses native scrollbars for frames, and thus can't put them into layers.

<​http://webkit.org/b/58535> tracks the difference, but will probably just be closed as
"works correctly".

  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Added.
7:36 AM Changeset in webkit [83855] by caseq@chromium.org
  • 76 edits
    23 adds
    12 deletes in trunk/LayoutTests

2011-04-14 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Updated/added chromium test expectation for media controls tests following CSS change in r83847.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Added.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum: Removed.
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Removed.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum: Removed.
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.checksum: Removed.
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.checksum: Removed.
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum: Removed.
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Removed.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum: Removed.
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.checksum: Removed.
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
7:01 AM Changeset in webkit [83854] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows results for new tests added in r83787

Windows differs from the cross-platfom results due to <​http://webkit.org/b/57334>.

  • platform/win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
6:59 AM Changeset in webkit [83853] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Andrew Wason <​rectalogic@rectalogic.com>

Reviewed by Andreas Kling.

Fix GraphicsContext3DQt.cpp compilation warnings treated as errors
​https://bugs.webkit.org/show_bug.cgi?id=58478

No new tests.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::getProcAddress): Do not use deprecated QString constructor to avoid warning. (WebCore::GraphicsContext3D::reshape): Use parenthesis to avoid warning.
6:59 AM Changeset in webkit [83852] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Replace some known-to-fail assertions with FIXMEs

These assertions get hit during various layout tests. They indicate that we're sometimes
doing some extra work when a page goes into accelerated compositing mode, but otherwise
there's no bad effect.

See <​http://webkit.org/b/58539> for more details.

Rubber-stamped by John Sullivan.

  • WebView.cpp:

(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Replaced assertions with FIXMEs.

6:48 AM Changeset in webkit [83851] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Removed ScrollableArea::paintScrollCorner() added in r83820,
as it breaks chromium clang build (shadowed by RenderLayer::paintScrollCorner()
with a different signature)

  • platform/ScrollableArea.h:
6:42 AM Changeset in webkit [83850] by mnaganov@chromium.org
  • 8 edits in trunk

2011-04-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58534

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived): (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode.prototype.get data):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshot.prototype._numbersComparator): (WebInspector.HeapSnapshot.prototype.baseSnapshotHasNode): (WebInspector.HeapSnapshot.prototype.updateBaseNodeIds): (WebInspector.HeapSnapshotsDiff): (WebInspector.HeapSnapshotsDiff.prototype.set baseIds): (WebInspector.HeapSnapshotsDiff.prototype.set baseSelfSizes): (WebInspector.HeapSnapshotsDiff.prototype.calculate):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy): (WebInspector.HeapSnapshotProxy.prototype.createDiff): (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider): (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider): (WebInspector.HeapSnapshotProxy.prototype.dispose): (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex): (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy): (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds): (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):

2011-04-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58534

  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest.): (initialize_DetailedHeapshotTest):
  • inspector/profiler/heap-snapshot-test.js: (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock): (initialize_HeapSnapshotTest):
6:35 AM Changeset in webkit [83849] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=57833

  • inspector/Inspector.json:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::enable): (WebCore::InspectorDatabaseAgent::disable): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/front-end/inspector.js:
6:31 AM Changeset in webkit [83848] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] "Remove Breakpoint" menu item is absent in the DOM breakpoints sidebar pane
​https://bugs.webkit.org/show_bug.cgi?id=58530

  • inspector/front-end/ElementsPanel.js:
6:22 AM Changeset in webkit [83847] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r83397) [Qt] When clicking on the media elements they
grow 2 pixels.
​https://bugs.webkit.org/show_bug.cgi?id=58477

Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size.

  • css/mediaControls.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
6:17 AM Changeset in webkit [83846] by diegohcg@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Diego Gonzalez <​diegohcg@webkit.org>

[Qt] Improve disable style for input elements in mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=58480

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/QtMobileWebStyle.cpp:

(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawComplexControl):

5:54 AM Changeset in webkit [83845] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-14 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: restore previous selection in Resources panel upon front-end reopen.
​https://bugs.webkit.org/show_bug.cgi?id=58533

  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
  • inspector/front-end/inspector.css: (#close-button-left, #close-button-right):
5:52 AM Changeset in webkit [83844] by caseq@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-04-14 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Added chromium baselines for SVG tests added in r83821.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
5:46 AM Changeset in webkit [83843] by pfeldman@chromium.org
  • 7 edits in trunk

2011-04-14 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: implement incremental CSS free flow editing.
​https://bugs.webkit.org/show_bug.cgi?id=58529

  • inspector/styles/get-set-stylesheet-text.html:

2011-04-14 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: implement incremental CSS free flow editing.
​https://bugs.webkit.org/show_bug.cgi?id=58529

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.isResourceRevision): (WebInspector.Resource.prototype.setContent):
  • inspector/front-end/ResourceView.js: (WebInspector.CSSSourceFrame.prototype.isContentEditable): (WebInspector.CSSSourceFrame.prototype.editContent): (WebInspector.CSSSourceFrame.prototype.endEditing.commitIncrementalEdit): (WebInspector.CSSSourceFrame.prototype.endEditing):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.editContent):
5:38 AM Changeset in webkit [83842] by kbalazs@webkit.org
  • 13 edits in trunk/Source/WebKit2

2011-04-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
​https://bugs.webkit.org/show_bug.cgi?id=55719

Guard functionality related to complex text and implementations
that rely on MachPort with PLATFORM(MAC).
Based on Oleg Romashin's patch.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.messages.in:
  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection):
  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::createPlugin):
  • Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::decode): Fix bad C++ that does not compile with gcc-linux.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch): (WebKit::PluginProcessProxy::didCreateWebProcessConnection):
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • WebKit2.pro: Move implementation that does not need external visibility from WebKit2API.pri. Adding the headers as well.
  • WebKit2API.pri:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
  • WebProcess/WebPage/WebPage.cpp:
5:32 AM Changeset in webkit [83841] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector:Duplicated display of storage db when running Web SQL from an iframe.
​https://bugs.webkit.org/show_bug.cgi?id=57830

There was created a new InspectorDatabaseResource entry for every didOpenDatabase event.
Moreover there is new WebCore::Database for each didOpenDatabase event.
I decided to change the old instance of the Database to a new one if they both use the same file.

  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::findByFileName):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.h: (WebCore::InspectorDatabaseResource::setDatabase):
5:26 AM Changeset in webkit [83840] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
​https://bugs.webkit.org/show_bug.cgi?id=58525

Unskip svgdom-over-01-f.svg, since it is now passing.

  • platform/gtk/Skipped:
5:16 AM Changeset in webkit [83839] by zherczeg@webkit.org
  • 3 edits in trunk/Source/WebCore

svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
​https://bugs.webkit.org/show_bug.cgi?id=58525

Patch by Zoltan Herczeg <​zherczeg@inf.u-szeged.hu> on 2011-04-14
Reviewed by Dirk Schulze.

A renderer is created even for those filter primitives
which parent is not a filter. A rendererIsNeeded() is
added to SVGFilterPrimitiveStandardAttributes.

Test: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):

  • svg/SVGFilterPrimitiveStandardAttributes.h:
5:12 AM Changeset in webkit [83838] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

REGRESSION(r83397) [Qt] When the video is loading and the poster is shown
all the controls are not visible except the play button.
​https://bugs.webkit.org/show_bug.cgi?id=58484

r83397 introduces a new API hasOwnDisabledStateHandlingFor to handle when
the controls should be disabled. Qt port paints its own controls, we don't want
the default implementation to handle the hidden/disable state for us.

Existing tests covers the visibility of the controls.

  • platform/qt/RenderThemeQt.h: (WebCore::RenderThemeQt::hasOwnDisabledStateHandlingFor):
4:59 AM Changeset in webkit [83837] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-04-14 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disabled form controls don't actually look disabled.
​https://bugs.webkit.org/show_bug.cgi?id=58490

Unsetting QStyle::State_Enabled is not enough to get the "disabled" appearance
when painting controls. We must also set the QStyleOption's palette's current
color group.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
4:41 AM Changeset in webkit [83836] by commit-queue@webkit.org
  • 5 edits in trunk

2011-04-14 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Benjamin Poulain.

Added additional test for parsing codecs parameter.
​https://bugs.webkit.org/show_bug.cgi?id=58188

  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:

2011-04-14 Nancy Piedra <​nancy.piedra@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter
​https://bugs.webkit.org/show_bug.cgi?id=58188

The codec parameter in MediaPlayerPrivateQt::supportsType was not parsed into
a QStringList. This change parses and trims the list.

An additional test was added to video-can-play-type.html to test parsing of codec parameter.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::supportsType):
4:20 AM Changeset in webkit [83835] by zherczeg@webkit.org
  • 6 edits
    3 adds in trunk/Source

Optimizing lightning filter to ARM-NEON SIMD instruction set
​https://bugs.webkit.org/show_bug.cgi?id=54456

Reviewed by Nikolas Zimmermann.

NEON is the SIMD instruction set for ARM. This instruction set
allows to speed-up the lighting filter by 4 times on ARM
(on WebCore/manual-tests/svg-filter-animation.svg).

  • WebCore.pri:
  • WebCore.pro:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):
(WebCore::getPowerCoefficients):
(WebCore::FELighting::drawInteriorPixels):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/arm/FELightingNEON.cpp: Added.

(attribute):

  • platform/graphics/filters/arm/FELightingNEON.h: Added.
4:01 AM Changeset in webkit [83834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-14 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Benjamin Poulain.

[Qt] GraphicsContext3D internal buffers are not freed
​https://bugs.webkit.org/show_bug.cgi?id=57530

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
3:53 AM Changeset in webkit [83833] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-14 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip 2 failing tests.

  • platform/gtk/Skipped: Skip http/tests/loading/onload-vs-immediate-refresh.pl and svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
3:46 AM Changeset in webkit [83832] by aestes@apple.com
  • 13 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=52988

Reviewed by Maciej Stachowiak.

Safari RSS relies on synchronous dispatch of ScrollEvent to update the
position of its sidebar during scrolling without producing a jiggling
effect. Due to r75555, this event is no longer dispatched synchronously
which results in stale repaints before the onscroll handler gets a
chance to update the position of the sidebar.

Since it is impractical to resolve this issue in Safari RSS itself, add
a quirk that restores synchronous ScrollEvent dispatch for Safari RSS.

No tests. This is an app-specific change that doesn't affect web
content.

  • Android.mk: Add platform/RuntimeApplicationChecks.[cpp|h]
  • CMakeLists.txt: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventQueue.cpp:

(WebCore::shouldDispatchScrollEventSynchronously): Send ScrollEvent
synchronously if the embedding application is Safari and the document's
URL scheme is "feed" or "feeds".
(WebCore::EventQueue::enqueueOrDispatchScrollEvent): Dispatch
ScrollEvent synchronously if shouldDispatchScrollEventSynchronously()
returns true.

  • dom/EventQueue.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::sendScrollEvent): Call enqueueOrDispatchScrollEvent().

  • platform/RuntimeApplicationChecks.cpp: Added.

(WebCore::mainBundleIsEqualTo): Add a helper routine for CF platforms
that checks if the main bundle's identifier is equal to a given string.
This function returns false for non-CF platforms.
(WebCore::applicationIsSafari): Call mainBundleIsEqualTo().
(WebCore::applicationIsAppleMail): Ditto.
(WebCore::applicationIsMicrosoftMessenger): Ditto.
(WebCore::applicationIsAdobeInstaller): Ditto.
(WebCore::applicationIsAOLInstantMessenger): Ditto.
(WebCore::applicationIsMicrosoftMyDay): Ditto.
(WebCore::applicationIsMicrosoftOutlook): Ditto.

  • platform/mac/RuntimeApplicationChecks.mm: Removed. Functions moved to

RuntimeApplicationChecks.cpp.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo): Call enqueueOrDispatchScrollEvent().

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollTo): Call enqueueOrDispatchScrollEvent().

2:56 AM Changeset in webkit [83831] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/ruby tests fail
​https://bugs.webkit.org/show_bug.cgi?id=58523

  • platform/qt/Skipped: Add failing tests.
2:44 AM Changeset in webkit [83830] by jamesr@google.com
  • 3 edits
    1 move
    1 add
    2 deletes in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Chromium expectation update.

  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt.
  • platform/chromium/test_expectations.txt:
2:39 AM Changeset in webkit [83829] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-04-14 Bill Budge <​bbudge@chromium.org>

Reviewed by Darin Fisher.

Make WebURLLoaderOptions disallow cross origin requests by default.
​https://bugs.webkit.org/show_bug.cgi?id=58475

No new tests. Exposes no new functionality.

  • public/WebURLLoaderOptions.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
2:27 AM Changeset in webkit [83828] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-14 John Bates <​jbates@google.com>

Reviewed by Kenneth Russell.

Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop.
​https://bugs.webkit.org/show_bug.cgi?id=58383

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::addChildContext): (WebCore::LayerRendererChromium::removeChildContext):
  • platform/graphics/chromium/LayerRendererChromium.h:
2:27 AM Changeset in webkit [83827] by Patrick Gansterer
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-14 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r83808.

It seams that the MSVC compiler for WinCE does not handle the friend scope correct.
Add an addtional inline function to StructureTransitionTable to work around this.

  • runtime/Structure.h: (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
2:18 AM Changeset in webkit [83826] by jamesr@google.com
  • 2 edits
    1 move in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Few more updates for r83820.

  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt.
  • platform/chromium-gpu/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Renamed from LayoutTests/platform/chromium-gpu/compositing/layer-creation.
  • platform/chromium/test_expectations.txt:
1:47 AM Changeset in webkit [83825] by Philippe Normand
  • 1 edit
    18 adds in trunk/LayoutTests

2011-04-14 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/borders/bidi-002-expected.checksum: Added.
  • platform/gtk/fast/borders/bidi-002-expected.png: Added.
  • platform/gtk/fast/borders/bidi-002-expected.txt: Added.
  • platform/gtk/fast/borders/bidi-004-expected.checksum: Added.
  • platform/gtk/fast/borders/bidi-004-expected.png: Added.
  • platform/gtk/fast/borders/bidi-004-expected.txt: Added.
  • platform/gtk/fast/borders/bidi-009a-expected.checksum: Added.
  • platform/gtk/fast/borders/bidi-009a-expected.png: Added.
  • platform/gtk/fast/borders/bidi-009a-expected.txt: Added.
  • platform/gtk/fast/frames/iframe-outline-expected.checksum: Added.
  • platform/gtk/fast/frames/iframe-outline-expected.png: Added.
  • platform/gtk/fast/frames/iframe-outline-expected.txt: Added.
  • platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
  • platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
  • platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
1:45 AM Changeset in webkit [83824] by jamesr@google.com
  • 13 edits
    9 deletes in trunk

2011-04-14 Victoria Kirst <​vrk@google.com>

Reviewed by James Robinson.

[chromium] Failing GPU video tests
​https://bugs.webkit.org/show_bug.cgi?id=57926

Rebaseline images.

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Removed.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Removed.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Removed.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium/test_expectations.txt:

2011-04-14 Victoria Kirst <​vrk@google.com>

Reviewed by James Robinson.

[chromium] Failing GPU video tests
​https://bugs.webkit.org/show_bug.cgi?id=57926

Added/updated GPU directory names for rebaseline tool.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1:27 AM Changeset in webkit [83823] by tonyg@chromium.org
  • 4 edits in trunk/LayoutTests

2011-04-14 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Kent Tamura.

[chromium] http/tests/loading/preload-append-scan.php fails
​https://bugs.webkit.org/show_bug.cgi?id=58352

On chromium, onload-vs-immediate-refresh always caused the subsequent test to fail
with an additional didFinishLoadForFrame message. This was because the test
navigates via a refresh, but did not actually wait for the navigation to complete.

This patch fixes that by adding a waitUntilDone() and calling notifyDone() after the
redirect target page loads. Now the log for this test shows both navigations and no
part of the navigation leaks into the next test.

Also, since dumpAsText() shows alerts, there was no reason to write vs. alert the
SUCCESS message.

  • http/tests/loading/onload-vs-immediate-refresh-expected.txt:
  • http/tests/loading/onload-vs-immediate-refresh.pl:
  • platform/chromium/test_expectations.txt:
1:20 AM Changeset in webkit [83822] by jamesr@google.com
  • 20 edits
    2 copies
    11 moves
    1 add
    18 deletes in trunk/LayoutTests

2011-04-14 James Robinson <​jamesr@chromium.org>

Update expectations and baselines for r83820.

  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
  • platform/chromium-gpu-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
  • platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt.
  • platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt.
  • platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt.
  • platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt.
  • platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
  • platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt.
  • platform/chromium-gpu/compositing/layer-creation: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
  • platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt.
  • platform/chromium/test_expectations.txt:
12:40 AM WikiStart edited by rniwa@webkit.org
Added a link to "April 2011 Meeting" (diff)
12:14 AM Changeset in webkit [83821] by reni@webkit.org
  • 13 edits
    20 adds in trunk

2011-04-14 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

CSS related SVG*Element changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=56906

Testing inherited CSS related SVG property changes by FEFlood, FESpecularLighting and FEDiffuseLighing filters.
Adding a missing test to check the dynamic update of lighting-color property of FESpecularLighting.
All the other modifications are covered by the existing dyanmic-update tests.

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Added. (executeTest):

2011-04-14 Renata Hodovan <​reni@webkit.org>

Reviewed by Nikolas Zimmermann.

CSS related SVG*Element changes doesn't require relayout
​https://bugs.webkit.org/show_bug.cgi?id=56906

The changes of some CSS related SVGFilter properties e.g. lighting_color, flood_color, flood_opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.

Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html

svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html

  • platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::setFloodColor): (WebCore::FEFlood::setFloodOpacity):
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setLightingColor):
  • platform/graphics/filters/FESpecularLighting.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::setFilterEffectAttribute):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):

Apr 13, 2011:

11:51 PM Changeset in webkit [83820] by jamesr@google.com
  • 60 edits
    3 copies
    29 adds
    8 deletes in trunk

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Adds some new tests for composited scrollbars, updates test expectations to take into account scrollbar layers.

  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/iframe-size-from-zero-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
  • compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
  • compositing/iframes/repaint-after-losing-scrollbars.html: Added.
  • compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html: Added.
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/overflow/clip-content-under-overflow-controls-expected.checksum: Added.
  • compositing/overflow/clip-content-under-overflow-controls-expected.png: Added.
  • compositing/overflow/clip-content-under-overflow-controls-expected.txt: Added.
  • compositing/overflow/clip-content-under-overflow-controls.html: Added.
  • compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • compositing/overflow/content-gains-scrollbars.html: Added.
  • compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • compositing/overflow/content-loses-scrollbars.html: Added.
  • compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • compositing/overflow/overflow-scrollbar-layers.html: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • compositing/overflow/repaint-after-losing-scrollbars-expected.txt: Added.
  • compositing/overflow/repaint-after-losing-scrollbars.html: Added.
  • compositing/tiling/huge-layer-img-expected.png:
  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png:
  • platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium-gpu/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/chromium-gpu/compositing/iframes/become-composited-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
  • platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt.
  • platform/chromium-gpu/compositing/iframes/overlapped-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
  • platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
  • platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
  • platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.png.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

This teaches ScrollableArea to manage GraphicsLayer backings for the two scrollbars and
scroll corner. ScrollableArea can position the layers and route invalidation and paint calls to
the correct place but depends on subclasses to manage the lifetime of the GraphicsLayers and
place them into the correct place in the hierarchy.

FrameView and RenderLayerCompositor updated to provide layers for frames with overflow controls.
that need them. The overflow control layers are siblings of the frame's clip layer.

RenderLayer and RenderLayerBacking updated to provide overflow control layers for layers that
need them. Currently, layers are only created for overflow controls on layers that are already composited
for other reasons and not necessarily for every RenderLayer with overflow. Overflow control layers are siblings
of the RenderLayerBacking's clipping layer if it exists, otherwise they are siblings of the layer's normal
children.

Tested by a number of compositing/ tests that have scrollbars and by these new tests:

compositing/iframes/repaint-after-losing-scrollbars.html
compositing/overflow/clip-content-under-overflow-controls.html
compositing/overflow/content-gains-scrollbars.html
compositing/overflow/content-loses-scrollbars.html
compositing/overflow/overflow-scrollbar-layers.html
compositing/overflow/repaint-after-losing-scrollbars.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • page/FrameView.cpp: (WebCore::FrameView::layerForHorizontalScrollbar): (WebCore::FrameView::layerForVerticalScrollbar): (WebCore::FrameView::layerForScrollCorner): (WebCore::FrameView::syncCompositingStateForThisFrame): (WebCore::FrameView::contentsResized): (WebCore::FrameView::updateScrollCorner):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: (WebCore::ScrollableArea::invalidateScrollbar): (WebCore::ScrollableArea::invalidateScrollCorner):
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::paintScrollCorner): (WebCore::ScrollableArea::layerForHorizontalScrollbar): (WebCore::ScrollableArea::layerForVerticalScrollbar): (WebCore::ScrollableArea::layerForScrollCorner):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::invalidateRect):
  • platform/Scrollbar.h:
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::paintContentsIfDirty):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::invalidateRootLayerRect): (WebCore::LayerRendererChromium::drawRootLayer): (WebCore::LayerRendererChromium::setViewport): (WebCore::LayerRendererChromium::updateAndDrawLayers): (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPartAnimation setCurrentProgress:]):
  • platform/win/PopupMenuWin.h: (WebCore::PopupMenuWin::invalidateScrollCornerRect): (WebCore::PopupMenuWin::isScrollCornerVisible): (WebCore::PopupMenuWin::scrollCornerRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollCornerRect): (WebCore::RenderLayer::scrollCornerAndResizerRect): (WebCore::RenderLayer::isScrollCornerVisible): (WebCore::RenderLayer::invalidateScrollbarRect): (WebCore::RenderLayer::invalidateScrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::layerForHorizontalScrollbar): (WebCore::RenderLayer::layerForVerticalScrollbar): (WebCore::RenderLayer::layerForScrollCorner):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterWidgetResize): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer): (WebCore::RenderLayerBacking::requiresScrollCornerLayer): (WebCore::RenderLayerBacking::updateOverflowControlsLayers): (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::layerForHorizontalScrollbar): (WebCore::RenderLayerBacking::layerForVerticalScrollbar): (WebCore::RenderLayerBacking::layerForScrollCorner):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::frameViewDidChangeLocation): (WebCore::RenderLayerCompositor::frameViewDidChangeSize): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents): (WebCore::shouldCompositeOverflowControls): (WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer): (WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer): (WebCore::RenderLayerCompositor::requiresScrollCornerLayer): (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::layerForHorizontalScrollbar): (WebCore::RenderLayerCompositor::layerForVerticalScrollbar): (WebCore::RenderLayerCompositor::layerForScrollCorner):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::isScrollCornerVisible): (WebCore::RenderListBox::scrollCornerRect): (WebCore::RenderListBox::invalidateScrollCornerRect):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Remove a lot of scrollbar hacks from the chromium compositor implementation now that
scrollbars go to real layers.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::invalidateScrollCornerRect): (WebKit::WebScrollbarImpl::scrollCornerPresent):
  • src/WebScrollbarImpl.h: (WebKit::WebScrollbarImpl::scrollCornerRect):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::reallocateRenderer):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Update WebScrollBar to reflect ScrollableArea interface changes.

  • WebScrollBar.h: (WebScrollBar::invalidateScrollCornerRect): (WebScrollBar::scrollCornerPresent): (WebScrollBar::scrollCornerRect):

2011-04-13 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

Allow setting composited backing stores for scrollbars and scroll corners
​https://bugs.webkit.org/show_bug.cgi?id=57202

Update WebPopupMenuProxyWin to reflect ScrollableArea interface changes.

  • UIProcess/win/WebPopupMenuProxyWin.h: (WebKit::WebPopupMenuProxyWin::invalidateScrollCornerRect): (WebKit::WebPopupMenuProxyWin::scrollCornerPresent): (WebKit::WebPopupMenuProxyWin::scrollCornerRect):
11:26 PM Changeset in webkit [83819] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Added chromium expectations for test added in r83803.

  • platform/chromium/iframe-outline-expected.png: Added.
11:25 PM Changeset in webkit [83818] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-04-13 Cary Clark <​caryclark@chromium.org>

Reviewed by Eric Seidel.

[Chromium] allow concurrent Skia and CG datatypes
​https://bugs.webkit.org/show_bug.cgi?id=57848

The Chromium port is experimenting with running Skia as the WebKit rendering engine, and CoreGraphics
as the UI rendering engine. This permits Chromium to unify its graphics story while leveraging OS X to
draw elements like scrollbars and buttons.

Restructure the common graphics units, points, and rectangles, to convert to Sk-types and CG-types at
the same time. This requires only adding to the existing preprocessor commands, and will have no effect
on any existing platform.

Eventually, WTF_USE_SKIA_ON_MAC_CHROME will be defined to enable this, but for now, there's no
functional change.

No new tests as this provides no new functionality.

  • platform/graphics/FloatPoint.h: Add USE(SKIA_ON_MAC_CHROME) to make CG type and operators visible to a Skia-based Chrome Mac build.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/FloatSize.h: Ditto.
  • platform/graphics/IntPoint.h: Ditto.
  • platform/graphics/IntRect.h: Ditto.
  • platform/graphics/IntSize.h: Ditto.
  • platform/graphics/cg/FloatPointCG.cpp: Ditto.
  • platform/graphics/cg/FloatRectCG.cpp: Ditto.
  • platform/graphics/cg/FloatSizeCG.cpp: Ditto.
  • platform/graphics/cg/IntPointCG.cpp: Ditto.
  • platform/graphics/cg/IntRectCG.cpp: Ditto.
  • platform/graphics/cg/IntSizeCG.cpp: Ditto.
10:56 PM Changeset in webkit [83817] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-04-13 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

Perl unit test removeEOL.pl should print test case name on failure
​https://bugs.webkit.org/show_bug.cgi?id=58513

  • Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as second argument of Test::Simple::ok().
10:44 PM Changeset in webkit [83816] by rolandsteiner@chromium.org
  • 20 edits in trunk/Source/WebCore

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 58460 - childTypeAllowed() should be const
​https://bugs.webkit.org/show_bug.cgi?id=58460

Made childTypeAllowed const.

No new tests. (minor refactoring).

  • dom/Attr.cpp: (WebCore::Attr::childTypeAllowed):
  • dom/Attr.h:
  • dom/CDATASection.cpp: (WebCore::CDATASection::childTypeAllowed):
  • dom/CDATASection.h:
  • dom/Comment.cpp: (WebCore::Comment::childTypeAllowed):
  • dom/Comment.h:
  • dom/Document.cpp: (WebCore::Document::childTypeAllowed):
  • dom/Document.h:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::childTypeAllowed):
  • dom/DocumentFragment.h:
  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • dom/Element.h:
  • dom/Node.h: (WebCore::Node::childTypeAllowed):
  • dom/Notation.cpp: (WebCore::Notation::childTypeAllowed):
  • dom/Notation.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::childTypeAllowed):
  • dom/ProcessingInstruction.h:
  • dom/Text.cpp: (WebCore::Text::childTypeAllowed):
  • dom/Text.h:
10:41 PM Changeset in webkit [83815] by levin@chromium.org
  • 1 edit
    184 adds in trunk

Add GTest unit-testing framework to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=58507

Patch by Dmitry Lomov <​dslomov@google.com> on 2011-04-13
Reviewed by David Levin.

  • Source/ThirdParty/gtest/CHANGES: Added.
  • Source/ThirdParty/gtest/CMakeLists.txt: Added.
  • Source/ThirdParty/gtest/CONTRIBUTORS: Added.
  • Source/ThirdParty/gtest/COPYING: Added.
  • Source/ThirdParty/gtest/Makefile.am: Added.
  • Source/ThirdParty/gtest/README: Added.
  • Source/ThirdParty/gtest/README.WebKit: Added.
  • Source/ThirdParty/gtest/codegear/gtest.cbproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest.groupproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest_all.cc: Added.
  • Source/ThirdParty/gtest/codegear/gtest_link.cc: Added.
  • Source/ThirdParty/gtest/codegear/gtest_main.cbproj: Added.
  • Source/ThirdParty/gtest/codegear/gtest_unittest.cbproj: Added.
  • Source/ThirdParty/gtest/configure.ac: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-death-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-message.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-param-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-param-test.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-spi.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-test-part.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest-typed-test.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest_pred_impl.h: Added.
  • Source/ThirdParty/gtest/include/gtest/gtest_prod.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-death-test-internal.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-filepath.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-linked_ptr.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-string.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h.pump: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h: Added.
  • Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h.pump: Added.
  • Source/ThirdParty/gtest/m4/acx_pthread.m4: Added.
  • Source/ThirdParty/gtest/m4/gtest.m4: Added.
  • Source/ThirdParty/gtest/make/Makefile: Added.
  • Source/ThirdParty/gtest/msvc/gtest-md.sln: Added.
  • Source/ThirdParty/gtest/msvc/gtest-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest.sln: Added.
  • Source/ThirdParty/gtest/msvc/gtest.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_main-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_main.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_prod_test-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_prod_test.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_unittest-md.vcproj: Added.
  • Source/ThirdParty/gtest/msvc/gtest_unittest.vcproj: Added.
  • Source/ThirdParty/gtest/run_tests.py: Added.
  • Source/ThirdParty/gtest/samples/prime_tables.h: Added.
  • Source/ThirdParty/gtest/samples/sample1.cc: Added.
  • Source/ThirdParty/gtest/samples/sample1.h: Added.
  • Source/ThirdParty/gtest/samples/sample10_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample1_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample2.cc: Added.
  • Source/ThirdParty/gtest/samples/sample2.h: Added.
  • Source/ThirdParty/gtest/samples/sample2_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample3-inl.h: Added.
  • Source/ThirdParty/gtest/samples/sample3_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample4.cc: Added.
  • Source/ThirdParty/gtest/samples/sample4.h: Added.
  • Source/ThirdParty/gtest/samples/sample4_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample5_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample6_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample7_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample8_unittest.cc: Added.
  • Source/ThirdParty/gtest/samples/sample9_unittest.cc: Added.
  • Source/ThirdParty/gtest/scripts/fuse_gtest_files.py: Added.
  • Source/ThirdParty/gtest/scripts/gen_gtest_pred_impl.py: Added.
  • Source/ThirdParty/gtest/scripts/gtest-config.in: Added.
  • Source/ThirdParty/gtest/scripts/pump.py: Added.
  • Source/ThirdParty/gtest/scripts/test/Makefile: Added.
  • Source/ThirdParty/gtest/scripts/upload.py: Added.
  • Source/ThirdParty/gtest/scripts/upload_gtest.py: Added.
  • Source/ThirdParty/gtest/src/gtest-all.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-death-test.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-filepath.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-internal-inl.h: Added.
  • Source/ThirdParty/gtest/src/gtest-port.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-test-part.cc: Added.
  • Source/ThirdParty/gtest/src/gtest-typed-test.cc: Added.
  • Source/ThirdParty/gtest/src/gtest.cc: Added.
  • Source/ThirdParty/gtest/src/gtest_main.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-death-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-filepath_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-linked_ptr_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-listener_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-message_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-options_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test2_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-param-test_test.h: Added.
  • Source/ThirdParty/gtest/test/gtest-port_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-test-part_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-tuple_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test2_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest-typed-test_test.h: Added.
  • Source/ThirdParty/gtest/test/gtest-unittest-api_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_all_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_color_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_color_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_env_var_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_env_var_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_environment_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_filter_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_filter_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_help_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_help_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_list_tests_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_list_tests_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_main_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_nc.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_nc_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_no_test_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_golden_lin.txt: Added.
  • Source/ThirdParty/gtest/test/gtest_output_test_golden_win.txt: Added.
  • Source/ThirdParty/gtest/test/gtest_pred_impl_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_prod_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_repeat_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_shuffle_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_shuffle_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_sole_header_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_stress_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_test_utils.py: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_ex_test.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_throw_on_failure_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_uninitialized_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_uninitialized_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_unittest.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfile1_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfile2_test_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_outfiles_test.py: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_output_unittest.py: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_output_unittest_.cc: Added.
  • Source/ThirdParty/gtest/test/gtest_xml_test_utils.py: Added.
  • Source/ThirdParty/gtest/test/production.cc: Added.
  • Source/ThirdParty/gtest/test/production.h: Added.
  • Source/ThirdParty/gtest/test/run_tests_util.py: Added.
  • Source/ThirdParty/gtest/test/run_tests_util_test.py: Added.
  • Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/General.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/StaticLibraryTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Config/TestTarget.xcconfig: Added.
  • Source/ThirdParty/gtest/xcode/Resources/Info.plist: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/Info.plist: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/runtests.sh: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.cc: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.h: Added.
  • Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget_test.cc: Added.
  • Source/ThirdParty/gtest/xcode/Scripts/runtests.sh: Added.
  • Source/ThirdParty/gtest/xcode/Scripts/versiongenerate.py: Added.
  • Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj: Added.
10:40 PM Changeset in webkit [83814] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-04-13 Jon Lee <​jonlee@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
​https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>

  • WebCore.exp.in: Exporting EditingBehavior.h for use in WebKit2
  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldClearSelectionWhenLosingWebPageFocus): moving the platform-specific code out of an #ifdef and into this class for run-time instead of compile-time checking

2011-04-13 Jon Lee <​jonlee@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
​https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/9246149>

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setFocused): Check for whether we are not supposed to be focused AND whether our platform behavior dictates to clear out the selection
10:35 PM Changeset in webkit [83813] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-04-13 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Eric Seidel.

constructLine should take bidiRuns as a parameter
​https://bugs.webkit.org/show_bug.cgi?id=58458

Pass bidiRuns to constructLine and move reachedEndOfTextRenderer so that it is
declared before constructLine.

No new tests as this is refactoring only.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::reachedEndOfTextRenderer): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::layoutInlineChildren):
10:35 PM Changeset in webkit [83812] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a bug where WKView changed the cursor when the mouse was moving over other views.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView mouseMoved:]): If getting this message because this view is the first responder,
ignore it unless it is inside the visible rect.

10:05 PM Changeset in webkit [83811] by Simon Fraser
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-13 Simon Fraser <Simon Fraser>

Revert ​http://trac.webkit.org/changeset/83750 because it broke PrettyPatch.
​https://bugs.webkit.org/show_bug.cgi?id=58510

  • PrettyPatch/PrettyPatch.rb:
9:01 PM Changeset in webkit [83810] by oliver@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/heap/Heap.cpp

Accidentally made us GC on every allocation.

8:57 PM Changeset in webkit [83809] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 32bit tests.

8:44 PM April 2011 Meeting edited by abarth@webkit.org
(diff)
8:28 PM Changeset in webkit [83808] by oliver@apple.com
  • 192 edits in trunk

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Additional structures are allocated beyond the expected threshold
so we preflight the test to get them allocated.

  • fast/dom/gc-10.html:

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Turn Structure into a GC allocated object. Most of this patch
is the mechanical change of replacing variations on RefPtr<Structure>
with either Structure* (for arguments and locals), WriteBarrier<Structure>
for the few cases where Structures are held by GC allocated objects
and Strong<Structure> for the root structure objects in GlobalData.

  • API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::JSCallbackConstructor):
  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject):
  • API/JSContextRef.cpp:
  • JavaScriptCore.JSVALUE32_64only.exp:
  • JavaScriptCore.JSVALUE64only.exp:
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::markStructures): (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::MethodCallLinkInfo::setSeen): (JSC::GlobalResolveInfo::GlobalResolveInfo):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::markAggregate): (JSC::Instruction::Instruction):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::markAggregate):
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • heap/Handle.h:
  • heap/MarkStack.cpp: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain):
  • heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep):
  • heap/Strong.h: (JSC::Strong::Strong): (JSC::Strong::set):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::uncachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::uncacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchMethodCallProto): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchMethodCallProto): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): (JSC::getPolymorphicAccessStructureListSlot):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::storePtrWithWriteBarrier):
  • jsc.cpp: (cleanupGlobalData):
  • runtime/Arguments.h: (JSC::Arguments::createStructure): (JSC::Arguments::Arguments): (JSC::JSActivation::copyRegisters):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype): (JSC::arrayProtoFuncSplice):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): (JSC::ErrorInstance::create):
  • runtime/ErrorInstance.h: (JSC::ErrorInstance::createStructure):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::TerminatedExecutionError::TerminatedExecutionError):
  • runtime/Executable.cpp:
  • runtime/Executable.h: (JSC::ExecutableBase::ExecutableBase): (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure): (JSC::NativeExecutable::NativeExecutable): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::createStructure):
  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray): (JSC::JSByteArray::createStructure):
  • runtime/JSByteArray.h: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.cpp: (JSC::isZombie):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::JSCell): (JSC::JSCell::JSCell::addressOfStructure): (JSC::JSCell::JSCell::structure): (JSC::JSCell::JSCell::markChildren): (JSC::JSCell::JSValue::isZombie):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::createLeaked):
  • runtime/JSGlobalData.h: (JSC::allocateGlobalHandle):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::markChildren): (JSC::JSGlobalObject::copyGlobalsFrom):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::createStructure): (JSC::Structure::prototypeChain): (JSC::Structure::isValid): (JSC::constructEmptyArray):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::JSNotAnObject): (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.cpp: (JSC::JSONObject::JSONObject):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::seal): (JSC::JSObject::freeze): (JSC::JSObject::preventExtensions): (JSC::JSObject::removeDirect): (JSC::JSObject::createInheritorID):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::JSObject): (JSC::JSNonFinalObject::createStructure): (JSC::JSNonFinalObject::JSNonFinalObject): (JSC::JSFinalObject::create): (JSC::JSFinalObject::createStructure): (JSC::JSFinalObject::JSFinalObject): (JSC::constructEmptyObject): (JSC::createEmptyObjectStructure): (JSC::JSObject::~JSObject): (JSC::JSObject::setPrototype): (JSC::JSObject::setStructure): (JSC::JSObject::inheritorID): (JSC::JSObject::putDirectInternal): (JSC::JSObject::transitionTo): (JSC::JSObject::markChildrenDirect):
  • runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::createStructure): (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::JSPropertyNameIterator::setCachedStructure): (JSC::Structure::setEnumerationCache):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::createStructure):
  • runtime/JSType.h:
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo):
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure): (JSC::JSVariableObject::JSVariableObject): (JSC::JSVariableObject::copyRegisterArray):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
  • runtime/JSZombie.cpp:
  • runtime/JSZombie.h: (JSC::JSZombie::JSZombie): (JSC::JSZombie::createStructure):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::markChildren):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::createStructure):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::createStructure):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
  • runtime/ObjectPrototype.h:
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): (JSC::RegExpMatchesArray::RegExpMatchesArray):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode): (JSC::ScopeChainNode::createStructure):
  • runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined): (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/StringPrototype.h: (JSC::StringPrototype::createStructure):
  • runtime/Structure.cpp: (JSC::StructureTransitionTable::remove): (JSC::StructureTransitionTable::add): (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::toCacheableDictionaryTransition): (JSC::Structure::toUncacheableDictionaryTransition): (JSC::Structure::sealTransition): (JSC::Structure::freezeTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::markChildren):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::setPrototypeWithoutTransition): (JSC::Structure::createStructure): (JSC::JSCell::createDummyStructure): (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): (JSC::StructureChain::markChildren):
  • runtime/StructureChain.h: (JSC::StructureChain::create): (JSC::StructureChain::head): (JSC::StructureChain::createStructure):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::finalizerContextFor): (JSC::StructureTransitionTable::~StructureTransitionTable): (JSC::StructureTransitionTable::slot): (JSC::StructureTransitionTable::setMap): (JSC::StructureTransitionTable::singleTransition): (JSC::StructureTransitionTable::clearSingleTransition): (JSC::StructureTransitionTable::setSingleTransition):
  • runtime/WeakGCMap.h: (JSC::DefaultWeakGCMapFinalizerCallback::finalizerContextFor): (JSC::DefaultWeakGCMapFinalizerCallback::keyForFinalizer): (JSC::WeakGCMap::contains): (JSC::WeakGCMap::find): (JSC::WeakGCMap::remove): (JSC::WeakGCMap::add): (JSC::WeakGCMap::set): (JSC::WeakGCMap::finalize):
  • runtime/WriteBarrier.h: (JSC::writeBarrier): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::setWithoutWriteBarrier):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Fix up JSG to correctly mark Structure, et al.

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSRun.h:
  • JSUtils.cpp: (JSObjectKJSValue):
  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h: (UserObjectImp::createStructure):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WebCore for Structure being a GC allocated object

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.h: (WebCore::JSAudioConstructor::createStructure):
  • bindings/js/JSDOMBinding.cpp: (WebCore::cacheDOMStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer): (WebCore::DOMConstructorObject::createStructure): (WebCore::DOMConstructorObject::DOMConstructorObject): (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::markChildren):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::createStructure):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::createStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSDOMWrapper.h: (WebCore::DOMObject::DOMObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener):
  • bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::createStructure):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSOptionConstructor.h: (WebCore::JSOptionConstructor::createStructure):
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::JSWorkerContextBase):
  • bindings/js/JSWorkerContextBase.h: (WebCore::JSWorkerContextBase::createStructure):
  • bindings/js/ScriptCachedFrameData.h:
  • bindings/js/SerializedScriptValue.h:
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.h: (JSC::Bindings::CRuntimeObject::createStructure):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaRuntimeObject.h: (JSC::Bindings::JavaRuntimeObject::createStructure):
  • bridge/objc/ObjCRuntimeObject.h: (JSC::Bindings::ObjCRuntimeObject::createStructure):
  • bridge/objc/objc_instance.mm: (ObjCRuntimeMethod::createStructure):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::RuntimeObject):
  • bridge/runtime_object.h: (JSC::Bindings::RuntimeObject::createStructure):
  • history/HistoryItem.h:

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WebKit for the world of GC allocated Structure

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure):
  • Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff Garen.

GC allocate Structure
​https://bugs.webkit.org/show_bug.cgi?id=58483

Update WK2 for the world of GC allocated Structure

  • WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::createStructure):
  • WebProcess/Plugins/Netscape/JSNPObject.h: (WebKit::JSNPObject::createStructure):
8:22 PM April 2011 Meeting created by rniwa@webkit.org
Adding a new page for April 2011 meeting
7:38 PM Writing Reftests edited by hayato@chromium.org
(diff)
7:20 PM Changeset in webkit [83807] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

gdb-safari should pass arguments to safari.
​https://bugs.webkit.org/show_bug.cgi?id=58439

We can do:

gdb-safari --debug LayoutTests/.../foo.html

  • Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
7:14 PM Changeset in webkit [83806] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, build fix.
​https://bugs.webkit.org/show_bug.cgi?id=52763

r83799 broke test-webkitpy because it assumed we always have
access to a real filesystem (we don't during the unit tests).
Stubbing out the copy for now but we might need a better
solution at some point.

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
7:13 PM Changeset in webkit [83805] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-04-13 Cary Clark <​caryclark@google.com>

Reviewed by Eric Seidel.

Allow CG Font support in Chrome Darwin build using Skia
​https://bugs.webkit.org/show_bug.cgi?id=58321

This allows Chrome to use Skia to do WebKit rendering, while
using CoreGraphics for glyph creation and computing font metrics.
It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.

No new tests needed, no functionality change.

  • loader/cache/CachedFont.cpp: Make CGFontRef functions and CG-specific font code available to Chrome builds on Darwin using Skia.
  • platform/graphics/FontPlatformData.h: Ditto. (WebCore::FontPlatformData::hash): Ditto.
  • platform/graphics/GlyphBuffer.h: Ditto. (WebCore::GlyphBuffer::advanceAt): Ditto. (WebCore::GlyphBuffer::add): Ditto. (WebCore::GlyphBuffer::expandLastAdvance): Ditto.
  • platform/graphics/SimpleFontData.h: Ditto.
6:47 PM Changeset in webkit [83804] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Dimitri Glazkov.

The timeline of the video controls is unusable if the multimedia backend returns a
infinite duration.
​https://bugs.webkit.org/show_bug.cgi?id=58452

In case the underlaying media element backend returns crazy values, e.g.
an infinite duration for the video we need to bail out and hide the timeline
rather than in a broken state where you can't use it. The previous code was just
checking if the duration was NaN.

We can't control from JS what the backend will return as a duration for the video
so we can't make an test for it.

  • html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset):
6:41 PM Changeset in webkit [83803] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2011-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Tests that iframe outline is drawn.
​https://bugs.webkit.org/show_bug.cgi?id=57439

  • fast/frames/iframe-outline.html: Added.
  • platform/mac/fast/frames/iframe-outline-expected.checksum: Added.
  • platform/mac/fast/frames/iframe-outline-expected.png: Added.
  • platform/mac/fast/frames/iframe-outline-expected.txt: Added.

2011-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by James Robinson.

Draw outline for render widgets.
​https://bugs.webkit.org/show_bug.cgi?id=57439

Test: fast/frames/iframe-outline.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
6:39 PM Changeset in webkit [83802] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change - remove tests that are no longer
failing.

  • platform/mac/test_expectations.txt:
6:37 PM Changeset in webkit [83801] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests --run-singly option is busted
​https://bugs.webkit.org/show_bug.cgi?id=55909

Python's broken lexical scoping strikes again :(.

  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:24 PM Changeset in webkit [83800] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Try to fix ASSERTs seen on Windows bots.

  • wtf/HashTable.h: (WTF::hashTableSwap): Force MSVC to use the right version of swap.
6:13 PM Changeset in webkit [83799] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Tools

2011-04-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

generated unexpected_results.html from unexpected_results.json
​https://bugs.webkit.org/show_bug.cgi?id=52763

Eventually, we'll merge this with results.html and have a single richer results page.
For now, I just want to get something checked in that we can iterate on.

  • Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
6:12 PM Changeset in webkit [83798] by jianli@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Unreviewed, rebaseline 4 tests added as r83787.

  • platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
6:12 PM Changeset in webkit [83797] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Up the failure limit to allow the commit-queue to actually land when the tree is red
​https://bugs.webkit.org/show_bug.cgi?id=58499

This change increases the --exit-after-N-failures limit used by the commit-queue
from 1 to 10. This will cause the code added in bug 58494 to actually get
exercised and the queues should start being able to land when the trees are red.

When testing I found that test_runtests_leopard_commit_queue_hack_command was the
only unit test to actually detect this change! Since we don't actually
run on leopard anymore, I removed the hack code and repurposed the test.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
6:11 PM Changeset in webkit [83796] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-13 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Change the representation of ShadowRoot nodes in render tree dumps
​https://bugs.webkit.org/show_bug.cgi?id=58432

Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
in DRT results.

No new tests. This change doesn't affect existing tests yet.

  • dom/DocumentFragment.h: Make nodeName() protected in order that ShdowRoot can override it.
  • dom/ShadowRoot.cpp: (WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
  • dom/ShadowRoot.h: Declare nodeName().
  • rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary. We don't use isShadowRoot() here because the legacy shadow root nodes return true for isShadowRoot() and we don't want to update existing test results.
6:08 PM Changeset in webkit [83795] by eric@webkit.org
  • 8 edits
    2 adds in trunk/Tools

2011-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should be able to land when tree is red
​https://bugs.webkit.org/show_bug.cgi?id=58494

There is some yak hair on my hands, I will admit.

This change is mostly about adding an ExpectedFailures
class to track when the bots are red and we should be
ignoring failures when landing from the commit-queue.

However, to make intelligent decisions about patches we
need to know whether the run hit the --exit-after-N-failures limit
or not. Right now that information is not saved off in results.html
so we have to pull the information from RunTests.

I've plumbed the --exit-after-N-failures information into
LayoutTestResults for now to make the ExpectedFailures code cleaner.

As a result of adding all these additional calls to delegate.layout_test_results()
I broke some of our flaky test detection tests and had to re-write them
to not depend on the number of layout_test_results code.

At the same time I updated the commit-queue to use the newer filesystem
API (to allow us to use MockFileSystem) which required further changes
to the layout tests. Changes were required in either case, since
we're now calling layout_test_results() in more cases, which previously
would try and hit the disk (until I moved it to use tool.filesystem).

I should note that *all* of this code is disabled for now, since our
--exit-after-N-failures limit is currently 1! (Thus were always in the
case where we can't actually tell if the layout test results are legit.)
I will up that limit in a second patch (which may require a couple more unit test tweaks).

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
5:58 PM Changeset in webkit [83794] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Merge LineOffsets and LineWidth
​https://bugs.webkit.org/show_bug.cgi?id=58411

Merged lineOffsets into LineWidth.

After this patch, available width is updated in positionNewFloatOnLine via updateAvailableWidth and
shrinkAvailableWidthForNewFloatIfNeeded instead of findNextBreak. This is correct because

  • LineOffsets::update and LineOffsets::shrinkWidthForNewFloatIfNeeded were only called in positionNewFloatOnLine besides LineOffsets' constructor
  • positionNewFloatOnLine was only called in skipLeadingWhitespace and findNextLineBreak
  • findNextLineBreak updates the available width whenever it calls skipLeadingWhitespace or positionNewFloatOnLine
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineWidth instead of LineOffset (WebCore::LineWidth::LineWidth): Takes RenderBlock* and boolean isFirstLine; call updateAvailableWidth because the initial available width was used to be computed from lineOffsets.width(). (WebCore::LineWidth::computeAvailableWidthFromLeftAndRight): Added. (WebCore::LineWidth::updateAvailableWidth): Renamed from LineOffsets::update; this function now updates m_availableWidth via computeAvailableWidthFromLeftAndRight as well as m_left and m_right. (WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Renamed from LineOffsets::shrinkWidthForNewFloatIfNeeded. This function also calls computeAvailableWidthFromLeftAndRight. (WebCore::LineWidth::applyOverhang): No longer takes arguments since both arguments were member variables of LineOffsets. (WebCore::LineWidth::fitBelowFloats): No longer takes isFirstLine. (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth. (WebCore::RenderBlock::positionNewFloatOnLine): Takes a reference to LineWidth.
5:45 PM Changeset in webkit [83793] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build correction.

  • TestWebKitAPI/PlatformWebView.h: Limit include of <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
5:44 PM Changeset in webkit [83792] by commit-queue@webkit.org
  • 13 edits in trunk

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

Seperate DerivedSources/ to DerivedSources/WebCore and
DerivedSources/JavaScriptCore.

  • Source/CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitFS.cmake:
  • Source/cmake/WebKitHelpers.cmake:
  • Source/cmake/WebKitMacros.cmake:

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

  • CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_JAVASCRIPTCORE_DIR.

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

No new tests since these are refactoring only.

  • CMakeLists.txt:
  • UseJSC.cmake:

2011-04-13 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[CMAKE] Separate DerivedSources.
​https://bugs.webkit.org/show_bug.cgi?id=58427

  • CMakeLists.txt: Change DERIVED_SOURCES_DIR to DERIVED_SOURCES_WEBCORE_DIR
5:36 PM Changeset in webkit [83791] by mdelaney@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.gypi

Fixing burning chromium mac tree.

5:25 PM Changeset in webkit [83790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Kenneth Russell.

[chromium] Fix canvas.toDataURL mimeType assertion
​https://bugs.webkit.org/show_bug.cgi?id=58425

Following r81213, reassert expected toDataURL() mimeType, remove an unused variable.

No new tests. Covered by existing tests.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL):
4:54 PM Changeset in webkit [83789] by tony@chromium.org
  • 2 edits in trunk

2011-04-13 Tony Chang <​tony@chromium.org>

Ignore files generated from glu.gyp.

  • .gitignore:
4:54 PM Changeset in webkit [83788] by luiz@webkit.org
  • 4 edits in trunk/Source/WebCore

[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
​https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

4:52 PM Changeset in webkit [83787] by rolandsteiner@chromium.org
  • 5 edits
    8 adds in trunk

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by David Hyatt.

Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
​https://bugs.webkit.org/show_bug.cgi?id=55930

Test that 'display: block' and 'display: table' on generated :before/:after content
within <ruby> doesn't crash.

  • fast/ruby/after-block-doesnt-crash-expected.txt: Added.
  • fast/ruby/after-block-doesnt-crash.html: Added.
  • fast/ruby/after-table-doesnt-crash-expected.txt: Added.
  • fast/ruby/after-table-doesnt-crash.html: Added.
  • fast/ruby/before-block-doesnt-crash-expected.txt: Added.
  • fast/ruby/before-block-doesnt-crash.html: Added.
  • fast/ruby/before-table-doesnt-crash-expected.txt: Added.
  • fast/ruby/before-table-doesnt-crash.html: Added.

2011-04-13 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by David Hyatt.

Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
​https://bugs.webkit.org/show_bug.cgi?id=55930

Non-inline :before/:after generated content is now wrapped with an anonymous inline block.

Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
to verify that the created render object is legal under the parent.

Tests: fast/ruby/after-block-doesnt-crash.html

fast/ruby/after-table-doesnt-crash.html
fast/ruby/before-block-doesnt-crash.html
fast/ruby/before-table-doesnt-crash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderRuby.cpp: (WebCore::isAnonymousRubyInlineBlock): (WebCore::rubyBeforeBlock): (WebCore::rubyAfterBlock): (WebCore::createAnonymousRubyInlineBlock): (WebCore::lastRubyRun): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsInline::removeChild): (WebCore::RenderRubyAsBlock::addChild): (WebCore::RenderRubyAsBlock::removeChild):
  • rendering/RenderRuby.h:
4:49 PM Changeset in webkit [83786] by mdelaney@apple.com
  • 6 edits
    9 adds
    7 deletes in trunk/Source/WebCore

2011-04-13 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Simon Fraser.

[CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
​https://bugs.webkit.org/show_bug.cgi?id=58084

No new tests. Does not affect outward behavior.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageBufferData.h: Added.
  • platform/graphics/cairo/ImageBufferData.h: Removed.
  • platform/graphics/cairo/ImageBufferDataCairo.h: Added.
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferDataCG.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::haveVImageRoundingErrorFix): (WebCore::ImageBufferData::getData): (WebCore::ImageBufferData::putData):
  • platform/graphics/cg/ImageBufferData.h: Removed.
  • platform/graphics/cg/ImageBufferDataCG.h: Added.
  • platform/graphics/chromium/ImageBufferData.h: Removed.
  • platform/graphics/chromium/ImageBufferDataSkia.h: Added.
  • platform/graphics/haiku/ImageBufferData.h: Removed.
  • platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
  • platform/graphics/qt/ImageBufferData.h: Removed.
  • platform/graphics/qt/ImageBufferDataQt.h: Added.
  • platform/graphics/wince/ImageBufferData.h: Removed.
  • platform/graphics/wince/ImageBufferDataWince.h: Added.
  • platform/graphics/wx/ImageBufferData.h: Removed.
  • platform/graphics/wx/ImageBufferDataWx.h: Added.
4:36 PM Changeset in webkit [83785] by mdelaney@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

2011-04-13 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Chris Marrin.

Update layout test expected result files' locations
​https://bugs.webkit.org/show_bug.cgi?id=58492

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt.
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt.
  • platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
4:33 PM Changeset in webkit [83784] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-04-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Remove std
prefix on some min/max calls ​https://bugs.webkit.org/show_bug.cgi?id=58493
Remove std
namespacing on min/max in favor of a 'using' clause.
  • platform/graphics/RoundedIntRect.cpp: (WebCore::RoundedIntRect::Radii::expand):
  • rendering/style/RenderStyle.cpp: (WebCore::calcConstraintScaleFor):
4:04 PM Changeset in webkit [83783] by mihaip@chromium.org
  • 5 edits in trunk/Tools

2011-04-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
​https://bugs.webkit.org/show_bug.cgi?id=58489

r83743 added --additional-platform-directory to old-run-webkit-tests,
rename the equivalent flag in new-run-webkit-tests to be consistent.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:03 PM Changeset in webkit [83782] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-13 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Jian Li.

[chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit
​https://bugs.webkit.org/show_bug.cgi?id=58474

  • DEPS:
  • public/WebSpellCheckClient.h:
3:54 PM Changeset in webkit [83781] by mihaip@chromium.org
  • 1 edit
    19 adds in trunk/Tools

2011-04-13 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Eric Seidel.

Rebaseline queue server
​https://bugs.webkit.org/show_bug.cgi?id=57891

Adds a simple rebaseline queue server (meant to run at
​http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
builders and their failing tests, and allows those tests to be added to
a per-builer rebaseline queue.

A subsequent change will add a mode to NRWT (and/or a wrapper script)
for pulling the tests to be rebaselined from the server and running them
with --reset-results (the initial use-case is for the GPU hardware bots,
which do not have checked-in baselines, therefore there is no need for a
check-in step yet).

  • RebaselineQueueServer/app.yaml: Added.
  • RebaselineQueueServer/handlers/init.py: Added.
  • RebaselineQueueServer/handlers/builderqueue.py: Added.
  • RebaselineQueueServer/handlers/pages.py: Added.
  • RebaselineQueueServer/index.yaml: Added.
  • RebaselineQueueServer/main.py: Added.
  • RebaselineQueueServer/model/init.py: Added.
  • RebaselineQueueServer/model/queueentry.py: Added.
  • RebaselineQueueServer/static/builder-frame-empty.html: Added.
  • RebaselineQueueServer/static/styles.css: Added.
  • RebaselineQueueServer/templates/builder-picker.html: Added.
  • RebaselineQueueServer/templates/builder-queue-edit.html: Added.
  • RebaselineQueueServer/templates/builder-queue-list.html: Added.
  • RebaselineQueueServer/templates/home.html: Added.
3:52 PM Changeset in webkit [83780] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, more chromium test expectations update.

  • platform/chromium/test_expectations.txt:
3:45 PM Changeset in webkit [83779] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

Replace our own RenderThemeQt::getMediaElementFromRenderObject by
MediaControlsElement::toParentMediaElement used by every other port.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaFullscreenButton): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack):
  • platform/qt/RenderThemeQt.h:
3:40 PM Changeset in webkit [83778] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Should not rely on WKEditableLinkBehavior being in synch
with WebCore::EditableLinkBehavior.
​https://bugs.webkit.org/show_bug.cgi?id=58473

Reviewed by Dan Bernstein.

Adding conversion routines.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

3:38 PM Changeset in webkit [83777] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

After closing the last window, re-opening my last visited website is over 2X slower
​https://bugs.webkit.org/show_bug.cgi?id=58488
<rdar://problem/9233518>

Give the web process a 60 second termination timeout.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
3:29 PM Changeset in webkit [83776] by jberlin@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

inspector/debugger/script-formatter.html broken on a bunch of platforms since introduction
in r83748
​https://bugs.webkit.org/show_bug.cgi?id=58487

Disable the test until it is fixed to get the bots green.

  • inspector/debugger/script-formatter.html: Removed.
  • inspector/debugger/script-formatter.html-disabled: Copied from inspector/debugger/script-formatter.html.
3:24 PM Changeset in webkit [83775] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Unreviewed, expectations change / build fix. The file had
multiple checksums which confused NRWT.

  • platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum:
3:24 PM Changeset in webkit [83774] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Convert WebProcess over to using disableTermination/enableTermination
​https://bugs.webkit.org/show_bug.cgi?id=58485

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::getSitesWithData): (WebKit::PluginProcess::clearSiteData): Use the LocalTerminationDisabler RAII class.
  • Shared/ChildProcess.h: (WebKit::ChildProcess::LocalTerminationDisabler::LocalTerminationDisabler): (WebKit::ChildProcess::LocalTerminationDisabler::~LocalTerminationDisabler): Add RAII class for calling disableTermination/enableTermination.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries): Use the LocalTerminationDisabler RAII class.
  • WebProcess/Cookies/WebCookieManager.cpp: (WebKit::WebCookieManager::getHostnamesWithCookies): (WebKit::WebCookieManager::deleteCookiesForHostname): (WebKit::WebCookieManager::deleteAllCookies): (WebKit::WebCookieManager::startObservingCookieChanges): (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Use the LocalTerminationDisabler RAII class.
  • WebProcess/Downloads/Download.cpp: (WebKit::Download::Download): Call disableTermination().

(WebKit::Download::~Download):
Call enableTermination().

  • WebProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::downloadFinished): Remove call to terminateIfPossible.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManager::deleteAllEntries): Use the LocalTerminationDisabler RAII class.


  • WebProcess/MediaCache/WebMediaCacheManager.cpp: (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManager::clearCacheForHostname): (WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Use the LocalTerminationDisabler RAII class.


  • WebProcess/ResourceCache/WebResourceCacheManager.cpp: (WebKit::WebResourceCacheManager::getCacheOrigins): (WebKit::WebResourceCacheManager::clearCacheForOrigin): (WebKit::WebResourceCacheManager::clearCacheForAllOrigins): Use the LocalTerminationDisabler RAII class.


  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::getDatabasesByOrigin): (WebKit::WebDatabaseManager::getDatabaseOrigins): (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManager::deleteDatabasesForOrigin): (WebKit::WebDatabaseManager::deleteAllDatabases): (WebKit::WebDatabaseManager::setQuotaForOrigin): Use the LocalTerminationDisabler RAII class.


  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): Call disableTermination().

(WebKit::WebProcess::removeWebPage):
Call enableTermination().

(WebKit::WebProcess::shouldTerminate):
Move logic from terminateIfPossible over here.

(WebKit::WebProcess::terminate):
Move logic from terminateIfPossible over here.

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
Use the LocalTerminationDisabler RAII class.

  • WebProcess/WebProcess.h: Publically inherit from ChildProcess, LocalTerminationDisabler needs to be accessible from the WebProcess class.
3:15 PM Changeset in webkit [83773] by ggaren@apple.com
  • 11 edits in trunk/Source

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
​https://bugs.webkit.org/show_bug.cgi?id=58482


This will allow wrappers to make individual decisions about their lifetimes.

  • heap/HandleHeap.h: (JSC::HandleHeap::copyWeak): New function for copying a weak handle. It's wasn't previously possible to perform this operation using HandleHeap API because the HandleHeap doesn't expose its underlying Node structure.
  • heap/Local.h: (JSC::::set):
  • heap/Strong.h: (JSC::Strong::set): Added ASSERTs to verify that dead objects are not resurrected by placement into handles.

(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient.

  • heap/Weak.h: (JSC::Weak::Weak): Fixed a bug where copying a weak pointer would not copy its weak callback and context.

(JSC::Weak::operator=): Added an assignment operator, since the default
C++ assignment operator did the wrong thing.

(JSC::Weak::set): Added ASSERTs to verify that dead objects are not
resurrected by placement into handles.

(JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
is efficient, and can be done without copying, which is illegal during
the handle finalization phase.

2011-04-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
​https://bugs.webkit.org/show_bug.cgi?id=58482

This will allow wrappers to make individual decisions about their lifetimes.

  • bindings/js/DOMWrapperWorld.cpp: (WebCore::DOMWrapperWorld::DOMWrapperWorld): (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots): (WebCore::JSNodeHandleOwner::finalize): (WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots): (WebCore::DOMObjectHandleOwner::finalize):
  • bindings/js/DOMWrapperWorld.h: (WebCore::JSNodeHandleOwner::JSNodeHandleOwner): (WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner): (WebCore::DOMWrapperWorld::jsNodeHandleOwner): (WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners for JSNode and DOMObject, our two hash table values. For now, the owners just take care to remove their handles from their respective hash tables.


Changed the hash table type to be a standard HashMap of weak pointers,
instead of a WeakGCMap.

  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper): (WebCore::cacheDOMNodeWrapper): (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): (WebCore::takeWrappers): (WebCore::updateDOMNodeDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper): Updated wrapper hash table access to accomodate its new data type.
  • bindings/js/JSNodeCustom.h: (WebCore::getCachedDOMNodeWrapper): Ditto.
  • dom/Document.h: Updated declaration to match the above.
3:11 PM Changeset in webkit [83772] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Follow-up to: WebKit2 will load two copies of the same plugin, but should not
​https://bugs.webkit.org/show_bug.cgi?id=49075


Use pathGetFileName instead of Win32 PathFindFileNameW.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin):
2:50 PM Changeset in webkit [83771] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac builds.

  • WebCore.exp.in:
2:39 PM Changeset in webkit [83770] by weinig@apple.com
  • 10 edits in trunk/Source

WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>

Reviewed by Gavin Barraclough.

Source/WebCore:

Notify the scrollbar painter controller when gesture scrolls begin and end.

  • WebCore.exp.in:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Initialize new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Initialize new WKSI functions.

2:38 PM Changeset in webkit [83769] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver Hunt.

WebKit2 will load two copies of the same plugin, but should not
​https://bugs.webkit.org/show_bug.cgi?id=49075
<rdar://problem/8635947>

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::shouldUsePlugin): Don't use a plug-in if we've already allowed a plug-in with the same filename.
2:31 PM Changeset in webkit [83768] by timothy@apple.com
  • 5 edits in trunk/Source/WebKit2

Hide the dictionary panel when navigating or crashing.

<rdar://problem/9261202>

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added. Call WKHideWordDefinitionWindow.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Call PageClient::dismissDictionaryLookupPanel.
(WebKit::WebPageProxy::processDidCrash): Call dismissCorrectionPanel and PageClient::dismissDictionaryLookupPanel.

2:29 PM Changeset in webkit [83767] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-04-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add support for disabling/enabling termination to ChildProcess
​https://bugs.webkit.org/show_bug.cgi?id=58476

Add ChildProcess::disableTermination and ChildProcess::enableTermination and convert
the PluginProcess class over to using them.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::PluginProcess): The child process now takes a terminationTimeout argument. Get rid of the shutdown timer.

(WebKit::PluginProcess::removeWebProcessConnection):
Call enableTermination().

(WebKit::PluginProcess::shouldTerminate):
Always return true.

(WebKit::PluginProcess::createWebProcessConnection):
Call disableTermination().

(WebKit::PluginProcess::getSitesWithData):
Call disableTermination()/enableTermination().

(WebKit::PluginProcess::clearSiteData):
Ditto.

  • Shared/ChildProcess.cpp: (WebKit::ChildProcess::disableTermination): Increment the counter and stop the timer.

(WebKit::ChildProcess::enableTermination):
Decrement the counter; if it's zero, start the timer.

(WebKit::ChildProcess::terminationTimerFired):
Call shouldTerminate(). If it returns true, call terminate().

(WebKit::ChildProcess::terminate):
Call RunLoop::quit().

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Just initialize the termination timeout to 0 for now.

(WebKit::WebProcess::shouldTerminate):
Always return true; this isn't used yet.

  • WebProcess/WebProcess.h:
2:26 PM Changeset in webkit [83766] by enrica@apple.com
  • 6 edits in trunk/Source/WebKit2

REGRESSION: Links are clickable when a contentEditable is set to true.
​https://bugs.webkit.org/show_bug.cgi?id=58473
<rdar://problem/9256793>

Reviewed by Dan Bernstein.

Added support for editable link behavior property.

  • Shared/WebPreferencesStore.cpp:
  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:24 PM Changeset in webkit [83765] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
​https://bugs.webkit.org/show_bug.cgi?id=58451
<rdar://problem/9278468>

No new tests, supported MIME types haven't changed.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use [AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.
2:22 PM Changeset in webkit [83764] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: enable multiple processes by default on Chromium Win.
​https://bugs.webkit.org/show_bug.cgi?id=55163

Re-land r79268; it should be more stable now and will hopefully
work.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2:11 PM Changeset in webkit [83763] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-04-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Media engine fallback doesn't always work
​https://bugs.webkit.org/show_bug.cgi?id=58462

No new tests, this was verified manually with the url noted in the bug.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::networkStateChanged):
2:08 PM Changeset in webkit [83762] by zmo@google.com
  • 12 edits in trunk/Source

2011-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Extension3D needs to provide a way to check if an extension is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58410

Implement isEnabled() in chromium port.

  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::isEnabled):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isExtensionEnabled):
  • src/GraphicsContext3DInternal.h:

2011-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Extension3D needs to provide a way to check if an extension is enabled
​https://bugs.webkit.org/show_bug.cgi?id=58410

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
  • platform/graphics/Extensions3D.h: Add isEnabled().
  • platform/graphics/chromium/Extensions3DChromium.h: Ditto.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto. (WebCore::Extensions3DOpenGL::isEnabled):
  • platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
  • platform/graphics/qt/Extensions3DQt.cpp: Ditto. (WebCore::Extensions3DQt::isEnabled):
  • platform/graphics/qt/Extensions3DQt.h: Ditto.
2:04 PM Changeset in webkit [83761] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations per change in r83756.

  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [83760] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: configure logging in child processes properly
​https://bugs.webkit.org/show_bug.cgi?id=58296

Logging propagated properly from manager to worker processes on
Unix but not on Windows; this fixes that.

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1:58 PM Changeset in webkit [83759] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: suppress extraneous pretty patch warnings
​https://bugs.webkit.org/show_bug.cgi?id=58295

NRWT wasn't being careful about when it logged messages from
PrettyPatch not being available; it should only log during
check_build(), and be silent otherwise. This was causing us to
get multiple errors at runtime, which was confusing.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
1:37 PM Changeset in webkit [83758] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations to work around a bug
in gpu test expectations handling.

  • platform/chromium/test_expectations.txt:
1:13 PM Changeset in webkit [83757] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

Mark compositing/webgl/webgl-reflection.html as failed for all platforms
in chromium.

  • platform/chromium/test_expectations.txt:
1:11 PM Changeset in webkit [83756] by cmarrin@apple.com
  • 2 edits
    13 adds
    4 deletes in trunk/LayoutTests

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518
​https://bugs.webkit.org/show_bug.cgi?id=58323

Got rid of unnecessary JS from composited-subframe.html. This was mistakenly left in from previous experiments.
Also moved pixel results to be platform specific. These are for Mac WebKit and WebKit2. There are color diffs
between the two platforms, so I will make them all platform specific.

  • compositing/framesets/composited-frame-alignment-expected.checksum: Removed.
  • compositing/framesets/composited-frame-alignment-expected.png: Removed.
  • compositing/objects/composited-object-alignment-expected.checksum: Removed.
  • compositing/objects/composited-object-alignment-expected.png: Removed.
  • compositing/objects/resources/composited-subframe.html:
  • platform/mac-wk2/compositing: Added.
  • platform/mac-wk2/compositing/framesets: Added.
  • platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
  • platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/mac-wk2/compositing/objects: Added.
  • platform/mac-wk2/compositing/objects/composited-object-alignment-expected.checksum: Added.
  • platform/mac-wk2/compositing/objects/composited-object-alignment-expected.png: Added.
  • platform/mac/compositing/framesets: Added.
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
  • platform/mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/mac/compositing/objects: Added.
  • platform/mac/compositing/objects/composited-object-alignment-expected.checksum: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.checksum.
  • platform/mac/compositing/objects/composited-object-alignment-expected.png: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.png.
12:30 PM Changeset in webkit [83755] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<​http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm

Reviewed by Anders Carlsson.

Fixes the following warning with -Wcast-align enabled:

Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]

archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));

~

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isNativeLibraryData:]): Added
COMPILE_ASSERT() to make sure our pointer math is valid.
Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
by sizeof(uint32_t) to fix the pointer math. Replaced C-style
casts with reinterpret_cast.

12:08 PM Changeset in webkit [83754] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Exclude webkitGetUserMedia from the navigator-detached-no-crash test.
​https://bugs.webkit.org/show_bug.cgi?id=58459

Patch by Leandro Gracia Gil <​leandrogracia@chromium.org> on 2011-04-13
Reviewed by Jian Li.

Exclude the MediaStream API methods from the test until the feature
is supported by most platforms.

  • fast/dom/navigator-detached-no-crash.html:
11:58 AM Changeset in webkit [83753] by jianli@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, rebaseline 2 tests for linux64 in chromium.

  • platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
11:52 AM Changeset in webkit [83752] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Jian Li.

add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=58461

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
11:48 AM Changeset in webkit [83751] by oliver@apple.com
  • 26 edits in trunk/Source

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Make PropertyMapEntry use a WriteBarrier for specificValue
​https://bugs.webkit.org/show_bug.cgi?id=58407

Make PropertyMapEntry use a WriteBarrier for specificValue, and then
propagate the required JSGlobalData through all the methods it ends
up being needed.

  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectSetPrototype):
  • JavaScriptCore.exp:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • interpreter/Interpreter.cpp: (JSC::appendSourceToError): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::name): (JSC::InternalFunction::displayName):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSFunction.cpp: (JSC::JSFunction::name): (JSC::JSFunction::displayName): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype):
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::getPropertySpecificValue): (JSC::JSObject::getOwnPropertyNames): (JSC::JSObject::seal): (JSC::JSObject::freeze): (JSC::JSObject::preventExtensions): (JSC::JSObject::removeDirect): (JSC::JSObject::getOwnPropertyDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::isSealed): (JSC::JSObject::isFrozen): (JSC::JSObject::setPrototypeWithCycleCheck): (JSC::JSObject::setPrototype): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/ObjectConstructor.cpp: (JSC::objectConstructorCreate): (JSC::objectConstructorSeal): (JSC::objectConstructorFreeze): (JSC::objectConstructorPreventExtensions): (JSC::objectConstructorIsSealed): (JSC::objectConstructorIsFrozen):
  • runtime/Operations.h: (JSC::normalizePrototypeChain):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry): (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::copy):
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::despecifyDictionaryFunction): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::toCacheableDictionaryTransition): (JSC::Structure::toUncacheableDictionaryTransition): (JSC::Structure::sealTransition): (JSC::Structure::freezeTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::isSealed): (JSC::Structure::isFrozen): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::despecifyAllFunctions): (JSC::Structure::put): (JSC::Structure::getPropertyNames):
  • runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::materializePropertyMapIfNecessary):

2011-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Make PropertyMapEntry use a WriteBarrier for specificValue
​https://bugs.webkit.org/show_bug.cgi?id=58407

Pass JSGlobalData reference on to APIs that now need them

  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::all):
11:05 AM LayoutTestResultFallbackOrder edited by tony@chromium.org
(diff)
11:04 AM Changeset in webkit [83750] by tony@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Adam Roben.

make PrettyPatch.rb aware of checksums in png files
​https://bugs.webkit.org/show_bug.cgi?id=58387

  • PrettyPatch/PrettyPatch.rb:
10:22 AM Changeset in webkit [83749] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-04-13 Tony Chang <​tony@chromium.org>

Unreviewed, fix NRWT. Stack:

return super(ChromiumPort, self).results_directory(self)

TypeError: results_directory() takes exactly 1 argument (2 given)

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:06 AM LayoutTestResultFallbackOrder edited by tony@chromium.org
(diff)
10:05 AM LayoutTestResultFallbackOrder created by tony@chromium.org
from …
10:01 AM WikiStart edited by tony@chromium.org
(diff)
9:45 AM Changeset in webkit [83748] by podivilov@chromium.org
  • 7 edits
    1 add in trunk

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix source mapping for deobfuscated scripts.
​https://bugs.webkit.org/show_bug.cgi?id=58231

  • inspector/debugger/resources/obfuscated.js: Added.
  • inspector/debugger/script-formatter-expected.txt:
  • inspector/debugger/script-formatter.html:

2011-04-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix source mapping for de-obfuscated scripts.
​https://bugs.webkit.org/show_bug.cgi?id=58231

  • inspector/front-end/ScriptFormatterWorker.js: (buildMapping):
  • inspector/front-end/SourceFile.js: (WebInspector.SourceMapping): (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation): (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation): (WebInspector): (WebInspector.FormattedSourceMapping): (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine): (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
9:33 AM Changeset in webkit [83747] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Consider editable and non editable nodes when calculating selection offsets
​https://bugs.webkit.org/show_bug.cgi?id=58431

Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().

This is needed to ensure that getSelectionOffsetsForObject() works
well when non editable nodes are present in the selection, since
firstPositionInNode() and lastPositionInNode() don't work in those
cases (they assume the node is editable).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Updated calls.
9:27 AM Changeset in webkit [83746] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Missing nullchecks in GTK's a11y wrapper
​https://bugs.webkit.org/show_bug.cgi?id=58429

Add missing nullchecks for coreObject->document().

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfRootObject): Add missing nullcheck. (getPangoLayoutForAtk): Ditto. (webkit_accessible_text_get_caret_offset): Ditto. (textExtents): Ditto. (webkit_accessible_editable_text_insert_text): Ditto. (webkit_accessible_editable_text_delete_text): Ditto.
9:17 AM Changeset in webkit [83745] by Martin Robinson
  • 3 edits in trunk/Source/WebCore

2011-04-13 Thierry Reding <​thierry.reding@avionic-design.de>

Gtk+ port fails to build when enabling WebGL
​https://bugs.webkit.org/show_bug.cgi?id=58434

Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
9:15 AM Changeset in webkit [83744] by Philippe Normand
  • 2 edits
    4 adds in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK platform results for full-screen-zIndex.html test.

[GTK] fullscreen/full-screen-zIndex.html fails
​https://bugs.webkit.org/show_bug.cgi?id=58444

  • platform/gtk/Skipped:
  • platform/gtk/fullscreen/full-screen-zIndex-expected.checksum: Added.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Added.
9:12 AM Changeset in webkit [83743] by Adam Roben
  • 2 edits in trunk/Tools

Teach ORWT about extra platform-specific directories to be searched before the default ones

Fixes <​http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
platform-specific results

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(top-level): Added @additionalPlatformDirectories and hooked up
--additional-platform-directories to populate it.
(buildPlatformResultHierarchy): Prepend the additional platform directories to the default
list (after filtering out any of the additional directories that don't exist).

8:55 AM Changeset in webkit [83742] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/inspector/extensions-resources-redirect.html and
inspector/extensions/extensions-resources.html sometimes fail on Windows 7 Release (WebKit2
Tests).
​https://bugs.webkit.org/show_bug.cgi?id=57491

Add the tests to the win-wk2 Skipped list to get the bots green.

  • platform/win-wk2/Skipped:
8:49 AM Changeset in webkit [83741] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-04-12 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
​https://bugs.webkit.org/show_bug.cgi?id=58312

Make sure to link the videoValve in all cases, fpsdisplaysink
being used or not.

No new test, this patch fixes an internal feature of the player,
not publicly exposed. Having two video sinks and pausing one while
the other displays the fullscreen video is an implementation
detail of the GStreamer player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
8:45 AM Changeset in webkit [83740] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing fullscreen test on GTK.

  • platform/gtk/Skipped:
8:44 AM Changeset in webkit [83739] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: there is a problem if an optional param is not at the end of a params list.
​https://bugs.webkit.org/show_bug.cgi?id=58440

In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
for a callback. But in some cases the optional parameter is declared in the middle of the params list.
That gets us into a problem if this param has been skipped in the message. In that case the tail of the
event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.

  • inspector/CodeGeneratorInspector.pm:
8:33 AM Changeset in webkit [83738] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames.html
failing since r83699
​https://bugs.webkit.org/show_bug.cgi?id=58441

Add the Windows-XP specific expected failing results to get the bots green.

  • platform/win-xp/fast/events: Added.
  • platform/win-xp/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.
8:02 AM Changeset in webkit [83737] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-04-13 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK rebaseline of an svg test updated in r83710 and
skip an http test using unimplemented DRT features.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/text-dom-01-f-expected.txt:
7:58 AM Changeset in webkit [83736] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=57337

Work around a bug in ternary opertions in the Solaris Studio
12/12.1/12.2 compilers, using an if clause.

  • dom/NodeRenderStyle.h: (WebCore::Node::renderStyle):
7:57 AM Changeset in webkit [83735] by Lucas Forschler
  • 2 edits in trunk/Tools

Add /T to TaskKill.exe

7:55 AM Changeset in webkit [83734] by Lucas Forschler
  • 2 edits in trunk/Tools

Sort task kill list

7:33 AM Changeset in webkit [83733] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Brian Salomon <​bsalomon@google.com>

Reviewed by Kenneth Russell.

Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
​https://bugs.webkit.org/show_bug.cgi?id=58363

No new tests needed, exercised by all existing canvas2d tests.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
7:28 AM Changeset in webkit [83732] by Lucas Forschler
  • 2 edits in trunk/Tools

2011-04-13 Lucas Forschler <Lucas Forschler>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=58384
Update kill-old-processes to include a few new ones.

  • BuildSlaveSupport/win/kill-old-processes:
7:26 AM Changeset in webkit [83731] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Fix chromium clang build problem:
ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
with a different signature in base class instead of overriding it.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyExpandingSuppressValue::applyValue):
7:25 AM Changeset in webkit [83730] by caseq@chromium.org
  • 5 edits
    16 adds
    4 deletes in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Rebaselined SVG test expectations following mac expectations change in r83710.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:
7:20 AM Changeset in webkit [83729] by kinuko@chromium.org
  • 8 edits
    8 adds in trunk/Source

2011-04-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
​https://bugs.webkit.org/show_bug.cgi?id=57927

Added plumbing code for the quota API, that is based on the
discussion on public-webapps:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

  • WebKit.gyp: Added new file entries.
  • src/StorageInfoChromium.cpp: Added.
  • src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of WebStorageQuotaCallbacks.
  • src/WebStorageQuotaCallbacksImpl.h: Added.

2011-04-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Add mock implementation and plumbing code for unified Quota API
​https://bugs.webkit.org/show_bug.cgi?id=57927

Added mock implementation and some plumbing code for the quota API,
that is based on the discussion on public-webapps:
​http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

No new tests: tests will be added when we expose the API.

  • CMakeLists.txt: Added new file entries.
  • DerivedSources.cpp: Added new file entries.
  • DerivedSources.make: Added new file entries.
  • GNUmakefile.am: Added new file entries.
  • WebCore.gypi: Added new file entries.
  • WebCore.pro: Added new file entries.
  • WebCore.vcproj/WebCore.vcproj: Added new file entries.
  • WebCore.xcodeproj/project.pbxproj: Added new file entries.
  • storage/StorageInfo.cpp: Added.
  • storage/StorageInfo.h: Added.
  • storage/StorageInfoErrorCallback.h: Added.
  • storage/StorageInfoQuotaCallback.h: Added.
  • storage/StorageInfoUsageCallback.h: Added.
7:05 AM Changeset in webkit [83728] by commit-queue@webkit.org
  • 4 edits in trunk

2011-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
​https://bugs.webkit.org/show_bug.cgi?id=58297

Make sure we do not load plugins that use symbols of a different
GTK+ major version to avoid bugs and crashes.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::moduleMixesGtkSymbols): (WebCore::PluginPackage::load):

2011-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Martin Robinson.

[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
​https://bugs.webkit.org/show_bug.cgi?id=58297

Do not disable flash specifically when built with GTK+ 3 -
PluginPackage should do the right thing while loading plugins.

  • GtkLauncher/main.c: (main):
7:04 AM Changeset in webkit [83727] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit/efl

2011-04-13 Grzegorz Czajkowski <​g.czajkowski@samsung.com>

Reviewed by Kent Tamura.

[EFL] Doxygen documentation for ewk_main, ewk_history and tools
​https://bugs.webkit.org/show_bug.cgi?id=58428

  • ewk/EWebKit.h:
  • ewk/ewk_eapi.h:
  • ewk/ewk_history.h:
  • ewk/ewk_logging.h:
  • ewk/ewk_main.cpp:
  • ewk/ewk_main.h:
  • ewk/ewk_private.h:
  • ewk/ewk_util.cpp:
  • ewk/ewk_util.h:
7:01 AM Changeset in webkit [83726] by tonyg@chromium.org
  • 3 edits
    1 move in trunk/LayoutTests

2011-04-13 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by David Levin.

[chromium] Regression(r80861): fast/dom/Window/window-lookup-precedence.html started failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=56608

Previously the test unintentionally navigated the iframe when setting
window.location. Instead, now, we just skip setting window.location.

  • fast/dom/Window/window-lookup-precedence.html:
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt: Moved to chromium.
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt: Moved from chromium-win.
  • platform/chromium/test_expectations.txt:
6:39 AM Changeset in webkit [83725] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Implement undo/redo in text editor
​https://bugs.webkit.org/show_bug.cgi?id=58426

Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.endEditing):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.setText): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._pushUndoableCommand): (WebInspector.TextEditorModel.prototype.undo): (WebInspector.TextEditorModel.prototype.redo): (WebInspector.TextEditorModel.prototype._doUndo):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._registerShortcuts): (WebInspector.TextViewer.prototype._cancelEditing): (WebInspector.TextViewer.prototype._handleUndoRedo): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback): (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
6:24 AM Changeset in webkit [83724] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make optional event parameter last to prevent regressions.
​https://bugs.webkit.org/show_bug.cgi?id=58433

  • inspector/Inspector.json:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
6:12 AM Changeset in webkit [83723] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
​http://webkit.org/b/58334

Make same changes in Qt WK2 Skipped list as r83595 in Mac WK2 Skipped list.

  • platform/qt-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify three other skipped tests with that same bug.
5:24 AM Changeset in webkit [83722] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert Inspector.json change for breaking world.

  • inspector/Inspector.json:
5:14 AM Changeset in webkit [83721] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: swap methods in the Inspector.json.

  • inspector/Inspector.json:
4:41 AM Changeset in webkit [83720] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

2011-04-13 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r83695.
​http://trac.webkit.org/changeset/83695
​https://bugs.webkit.org/show_bug.cgi?id=58375

[Qt][WK2]It broke http tests

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::synchronousLoad):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::resourceResponse): (WebCore::WebCoreSynchronousLoader::resourceError): (WebCore::WebCoreSynchronousLoader::data): (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::waitForCompletion): (WebCore::ResourceHandle::loadResourceSynchronously):
4:37 AM Changeset in webkit [83719] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-04-13 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inactive style sheets should be read only.
​https://bugs.webkit.org/show_bug.cgi?id=58423

  • inspector/front-end/ResourceView.js: (WebInspector.CSSSourceFrame): (WebInspector.CSSSourceFrame.prototype.isContentEditable): (WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId): (WebInspector.CSSSourceFrame.prototype._loadStyleSheet):
4:35 AM Changeset in webkit [83718] by mnaganov@chromium.org
  • 12 edits
    1 add in trunk

2011-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58320

Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

  • inspector/profiler/detailed-heapshots-test.js: (initialize_DetailedHeapshotTest):

2011-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
​https://bugs.webkit.org/show_bug.cgi?id=58320

Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted): (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate): (WebInspector.HeapSnapshotGridNode.prototype._populate): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved): (WebInspector.HeapSnapshotGridNode.prototype.populateChildren): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate): (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort): (WebInspector.HeapSnapshotGridNode.prototype.sort): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent): (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren): (WebInspector.HeapSnapshotObjectNode): (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotObjectNode.prototype._createProvider): (WebInspector.HeapSnapshotInstanceNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode): (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider): (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind): (WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff): (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity): (WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated): (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren): (WebInspector.HeapSnapshotDominatorObjectNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode): (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged): (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting): (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource): (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived): (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren): (WebInspector.HeapSnapshotRetainingPathsList): (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths): (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.DetailedHeapshotView.profileCallback): (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype.get profileWrapper): (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper): (WebInspector.DetailedHeapshotView.prototype.show.profileCallback1): (WebInspector.DetailedHeapshotView.prototype.show.profileCallback2): (WebInspector.DetailedHeapshotView.prototype.show): (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
  • inspector/front-end/HeapSnapshot.js:
  • inspector/front-end/HeapSnapshotProxy.js: Added.
  • inspector/front-end/PleaseWaitMessage.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
3:45 AM Changeset in webkit [83717] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected results after r83710.

  • platform/qt/svg/custom/text-dom-01-f-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
3:20 AM Changeset in webkit [83716] by apavlov@chromium.org
  • 4 edits in trunk

2011-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Web Page Performance auditing fails
​https://bugs.webkit.org/show_bug.cgi?id=58322

  • inspector/audits/audits-panel-functional.html:

2011-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Web Page Performance auditing fails
​https://bugs.webkit.org/show_bug.cgi?id=58322

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
2:51 AM Changeset in webkit [83715] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: enumerate properties in Inspector.json using array, not object keys.
​https://bugs.webkit.org/show_bug.cgi?id=58418

  • inspector/Inspector.json:
2:33 AM Changeset in webkit [83714] by hans@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-04-12 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
​https://bugs.webkit.org/show_bug.cgi?id=58343

Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
Add the necessary dependencies to the DEPS file.

  • DEPS:
  • features.gypi:
2:32 AM Changeset in webkit [83713] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-04-06 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
​https://bugs.webkit.org/show_bug.cgi?id=57942

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._populateLineGutterContextMenu): (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu): (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult): (WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles): (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
2:22 AM Changeset in webkit [83712] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg has different output on Windows
​https://bugs.webkit.org/show_bug.cgi?id=58421

  • platform/win/Skipped: Skip svdgdom-over-01-f.svg test. The test is fine, but its missing a line compared to the mac output.
2:00 AM Changeset in webkit [83711] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-04-13 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed.
Rebaselined expectations following console message format change in V8 bindings.

  • platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/fast/js/recursion-limit-equal-expected.txt:
1:42 AM Changeset in webkit [83710] by Nikolas Zimmermann
  • 19 edits
    24 adds in trunk

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextContentElements textLength returns 0
​https://bugs.webkit.org/show_bug.cgi?id=52543

Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.

If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
will return the same as "textContentElement.getComputedTextLength()". If it's set the values
aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
in the SVG Text DOM API.

Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).

Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
with getComputedTextLength().

Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg

svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::selectionRect): (WebCore::SVGInlineTextBox::paintSelectionBackground): (WebCore::SVGInlineTextBox::paint): (WebCore::SVGInlineTextBox::calculateBoundaries):
  • rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::buildTextChunks): (WebCore::SVGTextChunkBuilder::layoutTextChunks): (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk): (WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection): (WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
  • rendering/svg/SVGTextFragment.h: (WebCore::SVGTextFragment::SVGTextFragment): (WebCore::SVGTextFragment::buildFragmentTransform): (WebCore::SVGTextFragment::transformAroundOrigin): (WebCore::SVGTextFragment::buildTransformForTextOnPath): (WebCore::SVGTextFragment::buildTransformForTextOnLine):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout): (WebCore::dumpTextBoxes): (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices): (WebCore::SVGTextLayoutEngine::finishLayout): (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
  • rendering/svg/SVGTextQuery.cpp: (WebCore::SVGTextQuery::textLengthCallback): (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::SVGTextQuery::rotationOfCharacterCallback): (WebCore::calculateGlyphBoundaries):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeTextLength): (WebCore::SVGTextContentElement::textLengthAnimated): (WebCore::SVGTextContentElement::parseMappedAttribute): (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGTextContentElement.h: (WebCore::SVGTextContentElement::specifiedTextLength):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged):
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):

2011-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextContentElements textLength returns 0
​https://bugs.webkit.org/show_bug.cgi?id=52543

Add new testcases from SVG 1.1 2nd edition. Correct all existing tests using textLength + SVG DOM Text API,
as we're not including textLength/lengthAdjust="spacingAndGlyphs" anymore in the SVGTextQuery results.
This matches Opera and a discussion on www-svg some time ago: ​http://www.w3.org/2010/05/24-svg-minutes.html.

  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/mac/svg/custom/text-dom-01-f-expected.checksum:
  • platform/mac/svg/custom/text-dom-01-f-expected.png:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg: Added.
  • svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-lengthAdjust-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-dom-textLength-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-textLength-prop.js: Added. (executeTest):
  • svg/text/lengthAdjust-text-metrics-expected.txt:
  • svg/text/resources/SelectionTestCase.js: (transformPoint): (transformRect): (toAbsoluteCoordinates): (selectRange):
  • svg/text/script-tests/lengthAdjust-text-metrics.js: (transformPoint): (transformRect): (numberToString): (lengthToString): (pointToString): (rectToString):
1:14 AM Changeset in webkit [83709] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-04-13 Paul Knight <​pknight@apple.com>

Reviewed by Gavin Barraclough.

BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
​https://bugs.webkit.org/show_bug.cgi?id=58405

The BACKTRACE() macro requires JavaScriptCore be built with a Debug
configuration in order for it to be enabled. Move the NDEBUG check to
the header so it will be enabled when the calling framework or
application is built with a Debug configuration, similar to how
ASSERT() and friends work.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
12:52 AM Changeset in webkit [83708] by caseq@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Fixed chromium test expectations.

12:22 AM Changeset in webkit [83707] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-04-13 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: requestDocument can result in race condition in DOMAgent.js
​https://bugs.webkit.org/show_bug.cgi?id=58415

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable): (WebInspector.DOMAgent.prototype.requestDocument):
12:04 AM Changeset in webkit [83706] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-04-12 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: another pass of protocol renames.
​https://bugs.webkit.org/show_bug.cgi?id=58340

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getDocument): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::setSearchingForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._setSearchingForNode): (WebInspector.ElementsPanel.prototype.setSearchingForNode):
Note: See TracTimeline for information about the timeline view.