Timeline
Jun 13, 2011:
- 11:44 PM Changeset in webkit [88781] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/win/media/audio-repaint-expected.txt:
- 11:31 PM Changeset in webkit [88780] by
-
- 2 edits in trunk/Tools
2011-06-13 Hayato Ito <hayato@chromium.org>
Reviewed by Ojan Vafai.
[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188
A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.
No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 11:11 PM Changeset in webkit [88779] by
-
- 4 edits in branches/chromium/782/Source/WebCore
Merge 88139
BUG=84002
Review URL: http://codereview.chromium.org/7145023
- 10:55 PM Changeset in webkit [88778] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
More Leopard and GTK rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/gtk/fast/forms/input-appearance-range-expected.txt: Added.
- platform/mac-leopard/media/audio-repaint-expected.txt: Added.
- platform/mac-leopard/media/media-document-audio-repaint-expected.txt: Added.
- 10:42 PM Changeset in webkit [88777] by
-
- 10 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920
- platform/win/media/audio-controls-rendering-expected.txt:
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-strict-expected.txt:
- platform/win/media/controls-styling-expected.txt:
- platform/win/media/controls-without-preload-expected.txt:
- platform/win/media/media-document-audio-repaint-expected.txt:
- platform/win/media/video-controls-rendering-expected.txt:
- platform/win/media/video-display-toggle-expected.txt:
- platform/win/media/video-no-audio-expected.txt:
- 10:34 PM Changeset in webkit [88776] by
-
- 3 edits2 copies in branches/chromium/742
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145022
- 10:25 PM Changeset in webkit [88775] by
-
- 2 edits in trunk/Tools
2011-06-13 Kent Tamura <tkent@chromium.org>
[Chromium-win] Fix two wrong assertions exposed by r88757.
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: (WebThemeEngineDRTWin::paintTrackbar):
- 10:19 PM Changeset in webkit [88774] by
-
- 3 edits2 copies in branches/chromium/782
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145021
- 10:15 PM Changeset in webkit [88773] by
-
- 22 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[GTK] Rebaseline for r88757.
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
- platform/gtk/fast/forms/slider-padding-expected.txt:
- platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
- platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
- platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/fast/multicol/client-rects-expected.txt:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- 10:07 PM Changeset in webkit [88772] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125
Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871
- platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
- 10:02 PM Changeset in webkit [88771] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224
Fix the expected result and remove the test from the Skipped list.
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/Skipped:
- 10:00 PM Changeset in webkit [88770] by
-
- 8 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Leopard expectation files for r88757.
- platform/mac-leopard/media/controls-after-reload-expected.txt:
- platform/mac-leopard/media/controls-strict-expected.txt:
- platform/mac-leopard/media/controls-styling-expected.txt:
- platform/mac-leopard/media/controls-without-preload-expected.txt:
- platform/mac-leopard/media/video-controls-rendering-expected.txt:
- platform/mac-leopard/media/video-display-toggle-expected.txt:
- platform/mac-leopard/media/video-no-audio-expected.txt:
- 9:53 PM Changeset in webkit [88769] by
-
- 3 edits in trunk/LayoutTests
2011-06-13 Kent Tamura <tkent@chromium.org>
[Mac] Rebaseline for r88757.
- media/audio-repaint-expected.txt:
- media/media-document-audio-repaint-expected.txt:
- 9:45 PM Changeset in webkit [88768] by
-
- 2 edits in trunk/Tools
Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.
- Scripts/webkitpy/common/config/committers.py:
- 9:34 PM Changeset in webkit [88767] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Fix a typo in Mac WebKit2's skipped list.
svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.
- platform/mac-wk2/Skipped:
- 9:29 PM Changeset in webkit [88766] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip editing/pasteboard/smart-paste-004.html per bug 61633.
- platform/win/Skipped:
- 9:23 PM Changeset in webkit [88765] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.
- platform/chromium/test_expectations.txt:
- 9:15 PM Changeset in webkit [88764] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] The second try to fix a build break.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:08 PM Changeset in webkit [88763] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Fix a typo.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:07 PM Changeset in webkit [88762] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Kent Tamura <tkent@chromium.org>
[EFL] Try to fix a build break by r88757.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart):
- 9:05 PM Changeset in webkit [88761] by
-
- 3 edits in branches/chromium/782/Source
Merge 88444
BUG=85559
Review URL: http://codereview.chromium.org/7145019
- 9:02 PM Changeset in webkit [88760] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.
- platform/chromium/test_expectations.txt:
- 8:49 PM Changeset in webkit [88759] by
-
- 1 edit in branches/chromium/782/Source/WebCore/dom/Element.cpp
Merge 87827
BUG=84335
Review URL: http://codereview.chromium.org/7155001
- 8:48 PM Changeset in webkit [88758] by
-
- 1 edit in branches/chromium/742/Source/WebCore/dom/Element.cpp
Merge 87827
BUG=84355
Review URL: http://codereview.chromium.org/7111044
- 8:46 PM Changeset in webkit [88757] by
-
- 46 edits5 adds in trunk
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Add two new tests, and update tests with sliders.
- fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
- fast/forms/input-appearance-range.html: Added.
- fast/forms/slider-thumb-stylability.html: Remove text.
- fast/forms/validation-message-on-range-expected.txt: Added.
- fast/forms/validation-message-on-range.html: Added.
- fast/multicol/client-rects-expected.txt:
- fast/repaint/slider-thumb-float-expected.txt:
- media/audio-repaint-expected.txt:
- media/controls-without-preload-expected.txt:
- media/media-document-audio-repaint-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped: Skip validaiton-message-on-range.html because this platform doesn't support the interactive validation.
- platform/mac-wk2/Skipped: Skip validaiton-message-on-range.html.
- platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png:
- platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.png:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.png:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-range-expected.png: Added.
- platform/mac/fast/forms/input-appearance-range-expected.txt: Added.
- platform/mac/fast/forms/range-thumb-height-percentage-expected.txt:
- platform/mac/fast/forms/slider-padding-expected.png:
- platform/mac/fast/forms/slider-padding-expected.txt:
- platform/mac/fast/forms/slider-thumb-shared-style-expected.png:
- platform/mac/fast/forms/slider-thumb-shared-style-expected.txt:
- platform/mac/fast/forms/slider-thumb-stylability-expected.png:
- platform/mac/fast/forms/slider-thumb-stylability-expected.txt:
- platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
- platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.png:
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.png:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-styling-expected.png:
- platform/mac/media/controls-styling-expected.txt:
- platform/qt/Skipped: Skip validaiton-message-on-range.html.
- platform/win/Skipped: Skip validaiton-message-on-range.html.
2011-06-10 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Use CSS machinery to position slider thumb.
https://bugs.webkit.org/show_bug.cgi?id=52920
Remove RenderSlider::layout().
In order to remove it, we introduce new three shadow nodes:
- A flex box container occupying the whole box
- A flex box item representing a movable area of the thumb
- A flex box item limiting the movable area of the thumb
The thumb position is specified by percentage position in the second element.
This change also fixes Bug 60353.
Tests: fast/forms/input-appearance-range.html
fast/forms/validation-message-on-range.html
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect): Use Node::getRect() for the thumb element.
- css/html.css: Add new style definitions for the new node layout. (input[type="range"]::-webkit-slider-container): (input[type="range"]::-webkit-slider-runnable-track): (input[type="range"]::-webkit-slider-thumb):
- html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Accepts events on shadow nodes, use sliderThumbElementOf(). (WebCore::RangeInputType::createShadowSubtree): Creates new nodes layout. (WebCore::RangeInputType::valueChanged): Use sliderThumbElementOf().
- html/RangeInputType.h: Remove shadowSliderThumb().
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Moved from RenderSlider.cpp.
(WebCore::hasVerticalAppearance): New utility function.
(WebCore::sliderThumbElementOf): New utility function.
(WebCore::RenderSliderThumb::layout):
Sets CSS top/left values.
(WebCore::RenderSliderContainer::RenderSliderContainer):
(WebCore::RenderSliderContainer::layout):
Add some adjustment code.
- Setting box-orient
- Adjust heights of some nodes. It is required to pass existing tests.
(WebCore::SliderThumbElement::setPositionFromValue):
Update comments.
(WebCore::SliderThumbElement::setPositionFromPoint):
Calculate the current position from absolute positions.
(WebCore::SliderThumbElement::hostInput):
Removed unnecessary variable.
(WebCore::TrackLimiterElement::TrackLimiterElement):
(WebCore::TrackLimiterElement::create): Adjust style.
(WebCore::TrackLimiterElement::createRenderer):
This node uses RenderSliderThumb.
(WebCore::TrackLimiterElement::shadowPseudoId):
This node also uses -webkit-slider-thumb.
(WebCore::SliderContainerElement::SliderContainerElement):
(WebCore::SliderContainerElement::create):
(WebCore::SliderContainerElement::createRenderer):
Uses RenderSliderContainer.
(WebCore::SliderContainerElement::shadowPseudoId):
- html/shadow/SliderThumbElement.h: Make hostInput() public, add declarations of TrackLimiterElement and SliderContainerElement.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::RenderSlider): Added an assertion. (WebCore::RenderSlider::inDragMode): Uses sliderThumbElementOf().
- rendering/RenderSlider.h: Remove declarations of removed functions.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbStyle): Calls adjustSliderThumbSize().
- 8:30 PM Changeset in webkit [88756] by
-
- 1 edit in branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
Merge 87911
BUG=84597
Review URL: http://codereview.chromium.org/7154001
- 7:55 PM Changeset in webkit [88755] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-13 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, rolled DEPS.
- DEPS:
- 7:27 PM Changeset in webkit [88754] by
-
- 7 edits in trunk
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.
- configure.ac: Add configure option to enable/disable register protocol handler.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
- GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Add configure option to enable/disable register protocol handler
https://bugs.webkit.org/show_bug.cgi?id=62534
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::registerProtocolHandler): Added.
- WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
- 7:19 PM Changeset in webkit [88753] by
-
- 3 edits in trunk/Source/WebCore
2011-06-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Support for painting thumb of media slider
https://bugs.webkit.org/show_bug.cgi?id=62174
Implement paintMediaSliderThumb() function to show thumb of media slider.
adjustSliderThumbSize() should be implemented in order to call paintMediaSliderThumb().
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::adjustSliderThumbSize): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
- platform/efl/RenderThemeEfl.h:
- 7:15 PM Changeset in webkit [88752] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- 7:09 PM Changeset in webkit [88751] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Keishi Hattori <keishi@webkit.org>
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 7:08 PM Changeset in webkit [88750] by
-
- 1 edit2 copies in branches/chromium/742
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149011
- 7:07 PM Changeset in webkit [88749] by
-
- 1 edit2 copies in branches/chromium/782
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149010
- 6:59 PM Changeset in webkit [88748] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaselines after r88617. The test is now passing on all platforms.
- platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:46 PM Changeset in webkit [88747] by
-
- 2 edits2 adds in trunk/LayoutTests
REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566
Add/update the (failing?) expected results for Windows in order to get the bots green.
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/tiling: Added.
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- 6:15 PM Changeset in webkit [88746] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 David Levin <levin@chromium.org>
Reviewed by Dmitry Titov.
fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609
- fast/workers/worker-close.html: Move a setTimeout to start after the response message is received to make the ordering of messages deterministic.
- 6:13 PM Changeset in webkit [88745] by
-
- 6 edits in trunk/Source
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
- platform/chromium/PlatformBridge.h:
- platform/chromium/SystemTimeChromium.cpp: (WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
2011-06-13 James Simonsen <simonjam@chromium.org>
Reviewed by James Robinson.
[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162
- public/WebKitClient.h: (WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
- src/PlatformBridge.cpp: (WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
- 6:10 PM Changeset in webkit [88744] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.
- platform/chromium/test_expectations.txt:
- 6:00 PM Changeset in webkit [88743] by
-
- 2 edits in branches/chromium/782/Source/WebKit/chromium
Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592
Reviewed by David Levin.
- public/WebNotification.h:
- src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.
TBR=jianli@chromium.org
BUG=84660
Review URL: http://codereview.chromium.org/7148005
- 5:58 PM Changeset in webkit [88742] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Skip test added by r88578 on GTK per bug 62585.
- platform/gtk/Skipped:
- 5:53 PM Changeset in webkit [88741] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602
No new tests, build cleanup only.
- config.h:
- 5:42 PM Changeset in webkit [88740] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612
This parameter defaults to true anyway.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
- 5:39 PM Changeset in webkit [88739] by
-
- 1 edit3 adds in trunk/LayoutTests
Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).
- platform/win/svg/hixie/intrinsic: Added.
- platform/win/svg/hixie/intrinsic/003-expected.png: Added.
- platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
- 5:38 PM Changeset in webkit [88738] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592
Reviewed by David Levin.
- public/WebNotification.h:
- src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.
- 5:22 PM Changeset in webkit [88737] by
-
- 11 edits2 adds in trunk
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256
Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.
- printing/page-count-with-one-word-expected.txt: Added.
- printing/page-count-with-one-word.html: Added.
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebCore.exp.in:
- page/Frame.cpp: (WebCore::Frame::resizePageRectsKeepingRatio):
- page/Frame.h:
- page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::begin):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]): (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): (-[WebHTMLView _endPrintMode]): (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): (-[WebHTMLView _endScreenPaginationMode]): (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]): (-[WebHTMLView layout]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView setPageWidthForPrinting:]):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.
Test: printing/page-count-with-one-word.html
- WebFrame.cpp: (WebFrame::setPrinting): (WebFrame::setInPrintingMode):
- WebFrame.h:
- 5:11 PM Changeset in webkit [88736] by
-
- 7 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r88734
- 5:10 PM Changeset in webkit [88735] by
-
- 5 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611
<rdar://problem/9058370>
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::getPluginInfo): Get the plug-in version string instead of the version number.
(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.
(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.
- Shared/Plugins/PluginQuirks.h: Add the ReturnsNonRetainedScriptableNPObject quirk.
- UIProcess/Plugins/PluginInfoStore.h: Use a version string. Eventually this should hold the PluginVersion class we added.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pluginScriptableNPObject): If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
- 5:09 PM Changeset in webkit [88734] by
-
- 7 edits in trunk/Source/WebKit/gtk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.
- docs/webkitgtk-sections.txt: Add missing sections to the list and remove unneeded sections.
- docs/webkitgtk.types: Update the types list.
- webkit/webkithittestresult.cpp: Fix inline documentation errors. (webkit_hit_test_result_class_init): Ditto.
- webkit/webkiticondatabase.cpp: Ditto.
- webkit/webkitwebsettings.cpp: Ditto. (webkit_web_settings_class_init): Ditto.
- webkit/webkitwebview.cpp: Ditto. (webkit_web_view_class_init): Ditto.
- 4:51 PM Changeset in webkit [88733] by
-
- 4 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Mac, GTK, and Qt rebaselines after r88717.
- platform/gtk/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- 4:49 PM Changeset in webkit [88732] by
-
- 2 edits in trunk/Tools
2011-06-13 Chris Rogers <crogers@google.com>
Unreviewed build fix.
Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- 4:28 PM Changeset in webkit [88731] by
-
- 18 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601
Previously, our user-gesture state was per-frame. Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture. Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.
This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code. Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
- bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp):
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/ScriptController.h: (WebCore::ScriptController::setProcessingTimerCallback):
- bindings/v8/V8Utilities.cpp:
- bindings/v8/V8Utilities.h:
- bindings/v8/specialization/V8BindingState.cpp:
- bindings/v8/specialization/V8BindingState.h:
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitFromJavaScript): (WebCore::HTMLFormElement::submit):
- page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::createWindow): (WebCore::DOMWindow::open):
- 4:20 PM Changeset in webkit [88730] by
-
- 4 edits2 adds in trunk
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Added a test that tries to remove the children of munder, mover and munderover elements.
- mathml/munderover-remove-children-expected.txt: Added.
- mathml/munderover-remove-children.html: Added.
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.
Test: mathml/munderover-remove-children.html
- rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
- rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
- 4:06 PM Changeset in webkit [88729] by
-
- 11 edits in trunk/Source
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromSerializedValueAndKeyPath): (WebCore::injectIDBKeyIntoSerializedValue):
- bindings/v8/V8Binding.cpp: (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData): (WebCore::V8BindingPerIsolateData::create): (WebCore::V8BindingPerIsolateData::ensureInitialized): (WebCore::V8BindingPerIsolateData::dispose): (WebCore::getToStringName): (WebCore::getToStringTemplate):
- bindings/v8/V8Binding.h: (WebCore::V8BindingPerIsolateData::get): (WebCore::V8BindingPerIsolateData::current): (WebCore::V8BindingPerIsolateData::rawTemplateMap): (WebCore::V8BindingPerIsolateData::templateMap): (WebCore::V8BindingPerIsolateData::toStringName): (WebCore::V8BindingPerIsolateData::toStringTemplate):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8Utilities.cpp: (WebCore::V8LocalContext::V8LocalContext): (WebCore::V8LocalContext::~V8LocalContext):
- bindings/v8/V8Utilities.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-13 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.
- tests/IDBBindingUtilitiesTest.cpp: (WebCore::TEST):
- 3:56 PM Changeset in webkit [88728] by
-
- 4 edits in trunk/Source/WebKit/chromium
2011-06-13 Lei Zhang <thestig@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423
- public/WebSettings.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
- src/WebSettingsImpl.h:
- 3:53 PM Changeset in webkit [88727] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Adam Barth.
Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598
Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressCompleted):
- 3:50 PM Changeset in webkit [88726] by
-
- 6 edits in trunk/Tools
2011-06-13 Chris Rogers <crogers@google.com>
Reviewed by Dirk Pranke.
Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::setEncodedAudioData):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::encodedAudioData): (LayoutTestController::shouldDumpAsAudio): (LayoutTestController::setShouldDumpAsAudio):
- DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleAudioHeader): (TestShellPrinter::handleAudioHeader):
- DumpRenderTree/chromium/TestEventPrinter.h:
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::dump):
- 3:47 PM Changeset in webkit [88725] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Michal Pakula vel Rutka <Michał Pakuła vel Rutka>
Reviewed by Eric Seidel.
[EFL] Input method hints not updated while clicking non-input field editable area
https://bugs.webkit.org/show_bug.cgi?id=62539
This fixes a minor bug when input method hints are not updated while focus is
changed from editable area with input tags to other which are does not have input
tag i.e. textarea.
- ewk/ewk_view.cpp: (ewk_view_input_method_state_set):
- 3:46 PM Changeset in webkit [88724] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605
A simple rename
- parser/Lexer.cpp: (JSC::Lexer::parseIdentifier): (JSC::Lexer::parseString): (JSC::Lexer::lex):
- parser/Lexer.h: (JSC::Lexer::lexExpectIdentifier):
- 3:45 PM Changeset in webkit [88723] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536
Implements basic functions for "redo" command.
- WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::registerCommandForUndo): (WebCore::EditorClientEfl::registerCommandForRedo): (WebCore::EditorClientEfl::clearUndoRedoOperations): (WebCore::EditorClientEfl::canRedo): (WebCore::EditorClientEfl::redo):
- WebCoreSupport/EditorClientEfl.h:
- 3:44 PM Changeset in webkit [88722] by
-
- 1 edit13 adds in trunk/Source/WebKit2
2011-06-13 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445
Add Efl related directory and files in WebKit2/WebProcess/.
- WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
- WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
- WebProcess/WebPage/efl/WebPageEfl.cpp: Added. (WebKit::WebPage::platformInitialize): (WebKit::WebPage::platformPreferencesDidChange): (WebKit::scroll): (WebKit::WebPage::performDefaultBehaviorForKeyEvent): (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL):
- WebProcess/efl/WebProcessEfl.cpp: Added. (WebKit::WebProcess::platformSetCacheModel): (WebKit::WebProcess::platformClearResourceCaches): (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformTerminate):
- WebProcess/efl/WebProcessMainEfl.cpp: Added. (WebKit::WebProcessMainEfl):
- WebProcess/efl/WebProcessMainEfl.h: Added.
- efl/MainEfl.cpp: Added. (main):
- 3:39 PM Changeset in webkit [88721] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88704.
http://trac.webkit.org/changeset/88704
https://bugs.webkit.org/show_bug.cgi?id=62466
Caused layout test failures on Chromium Mac.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- 3:39 PM Changeset in webkit [88720] by
-
- 2 edits in trunk
2011-06-13 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Need to report whether touch icon loading is enabled
https://bugs.webkit.org/show_bug.cgi?id=62532
It needs to report whether touch icon loading is enabled.
- configure.ac: Updated option parsing code for loading touch icons.
- 3:38 PM Changeset in webkit [88719] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600
Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases. This comes out as a reasonable parsing speed
boost.
- parser/JSParser.cpp: (JSC::JSParser::nextExpectIdentifier): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
- parser/Lexer.cpp:
- parser/Lexer.h: (JSC::Lexer::makeIdentifier): (JSC::Lexer::lexExpectIdentifier):
- 3:38 PM Changeset in webkit [88718] by
-
- 2 edits in trunk/Source/WebCore
Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562
<rdar://problem/9313885>
Patch by Morgan Winer <mwiner@apple.com> on 2011-06-13
Reviewed by Enrica Casucci.
The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.
There are no layout tests for this, since it can be tested only at API level.
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().
- 3:37 PM Changeset in webkit [88717] by
-
- 6 edits3 deletes in trunk/LayoutTests
2011-06-13 Wyatt Carss <wcarss@google.com>
Reviewed by Ryosuke Niwa.
dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159
Converted to dump the key part of page as text. The platform-dependent files are
copied from the previous setup of this test, as mac appears to do something different
in its delegate info -- 'insertText' instead of 'insertNode', and some differences
in how it counts indices. Note that chromium-mac works the same as chromium-win, but
would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
a bit accordingly.
- editing/pasteboard/paste-xml.xhtml:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/win/editing/pasteboard/paste-xml-expected.txt:
- 3:36 PM Changeset in webkit [88716] by
-
- 4 edits in trunk
2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277
Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.
- Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
2011-06-13 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277
Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.
No change in functionality so no new tests.
- CMakeLists.txt: move .idl files to be conditionally generated.
- 3:32 PM Changeset in webkit [88715] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: Infinity as key
https://bugs.webkit.org/show_bug.cgi?id=62285
- storage/indexeddb/key-type-infinity-expected.txt: Added.
- storage/indexeddb/key-type-infinity.html: Added.
- 3:30 PM Changeset in webkit [88714] by
-
- 2 edits in trunk/Tools
2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add load error handler to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62347
Add a handler function of "load,error" to EWebLauncher.
EWebLauncher now displays a simple error page on load errors.
- EWebLauncher/main.c: (on_load_error): (browserCreate):
- 3:29 PM Changeset in webkit [88713] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: odd database names
https://bugs.webkit.org/show_bug.cgi?id=62322
- storage/indexeddb/database-odd-names-expected.txt: Added.
- storage/indexeddb/database-odd-names.html: Added.
- 3:25 PM Changeset in webkit [88712] by
-
- 6 edits1 delete in trunk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
since the TestPlugin no longer prints this event.
- platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Do not set the plugin as windowless always. Doing this breaks some results on Qt and this seems to be unnecessary for the moment. (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the XP_UNIX block is first by guarding against using a null instance.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add the XP_UNIX define for Linux.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
- GNUmakefile.am: Update source list.
- 3:23 PM Changeset in webkit [88711] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
without plugin support
https://bugs.webkit.org/show_bug.cgi?id=62394
No behaviour changes, so no new tests.
- CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and Plugin{Package,View}None.cpp and move them to CMakeListWinCE and CMakeListsEfl, respectively.
- CMakeListsEfl.txt:
- CMakeListsWinCE.txt:
- 3:22 PM Changeset in webkit [88710] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Eric Seidel.
[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
https://bugs.webkit.org/show_bug.cgi?id=62365
These functions do not exist in any public headers and
they are not used internally.
Moreover ewk_view has the same functionality added
https://bugs.webkit.org/show_bug.cgi?id=60435
- ewk/ewk_frame.cpp:
- 3:22 PM Changeset in webkit [88709] by
-
- 35 edits in trunk/LayoutTests
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Rewrite a bunch of XHR-based tests to use waitUntilDone()/notifyDone().
https://bugs.webkit.org/show_bug.cgi?id=62066
- fast/xmlhttprequest/xmlhttprequest-gc.html:
- fast/xmlhttprequest/xmlhttprequest-get.xhtml:
- fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
- html5lib/runner.html:
- html5lib/webkit-resumer.html:
- http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html:
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html:
- http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html:
- http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html:
- http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html:
- http/tests/xmlhttprequest/cross-origin-preflight-get.html:
- http/tests/xmlhttprequest/event-listener-gc.html:
- http/tests/xmlhttprequest/interactive-state.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html:
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html:
- http/tests/xmlhttprequest/response-encoding.html:
- http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-004.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-005.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-006.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-007.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-008.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-009.html:
- http/tests/xmlhttprequest/uri-resolution-opera-open-010.html:
- http/tests/xmlhttprequest/web-apps/001.html:
- http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html:
- http/tests/xmlhttprequest/xmlhttprequest-crlf-getAllResponseHeader.html:
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
- http/tests/xmlhttprequest/zero-length-response.html:
- 3:17 PM Changeset in webkit [88708] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Eric Seidel.
IndexedDB test: readonly properties
https://bugs.webkit.org/show_bug.cgi?id=62392
- storage/indexeddb/readonly-expected.txt: Added.
- storage/indexeddb/readonly.html: Added.
- 3:16 PM Changeset in webkit [88707] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62524
- UIProcess/efl/WebInspectorEfl.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformDidClose): (WebKit::WebInspectorProxy::platformBringToFront): (WebKit::WebInspectorProxy::platformInspectedURLChanged): (WebKit::WebInspectorProxy::inspectorPageURL): (WebKit::WebInspectorProxy::platformAttach): (WebKit::WebInspectorProxy::platformDetach): (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
- 3:14 PM Changeset in webkit [88706] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62438
- UIProcess/efl/TextCheckerEfl.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkSpellingOfString): (WebKit::TextChecker::checkGrammarOfString): (WebKit::TextChecker::spellingUIIsShowing): (WebKit::TextChecker::toggleSpellingUIIsShowing): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::updateSpellingUIWithGrammarString): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
- 3:09 PM Changeset in webkit [88705] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Eric Seidel.
Web Inspector: [refactoring] remove dead code from NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=62481
- inspector/front-end/NetworkPanel.js:
- 3:06 PM Changeset in webkit [88704] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Daniel Cheng <dcheng@chromium.org>
Reviewed by Eric Seidel.
[chromium] Dragging images to Mail.app results in broken attachments
https://bugs.webkit.org/show_bug.cgi?id=62466
No new tests.
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
- 3:00 PM Changeset in webkit [88703] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-06-13 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Dimitri Glazkov.
Add accessors for selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=62596
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::selectionEnd): (WebKit::WebAccessibilityObject::selectionStart):
- 2:58 PM Changeset in webkit [88702] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Sangyong Park <sy302.park@gmail.com>
Reviewed by Eric Seidel.
implement to handle wheel event of plugin on x11
https://bugs.webkit.org/show_bug.cgi?id=62522
Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
for to handle wheel event on plugins
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: (WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent (WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent (WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin
- 2:51 PM Changeset in webkit [88701] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Eric Seidel.
[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62523
- UIProcess/efl/WebContextEfl.cpp: Added. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformInvalidateContext): (WebKit::WebContext::platformDefaultDatabaseDirectory): (WebKit::WebContext::platformDefaultIconDatabasePath): (WebKit::WebContext::platformDefaultLocalStorageDirectory):
- 2:44 PM Changeset in webkit [88700] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-13 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[efl] Disable tiled backing store debug messages by default.
https://bugs.webkit.org/show_bug.cgi?id=61745
These messages pollute the output and are only useful to people
working on TBS itself. It makes more sense to have them disabled by
default.
- ewk/ewk_tiled_backing_store.h:
- 2:36 PM Changeset in webkit [88699] by
-
- 2 edits1 add11 deletes in trunk/LayoutTests
2011-06-13 Annie Sullivan <sullivan@chromium.org>
Reviewed by Dimitri Glazkov.
Convert editing/execCommand/outdent-selection.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=62582
Convert the test to dump as markup and clean up the HTML.
- editing/execCommand/outdent-selection-expected.txt: Added.
- editing/execCommand/outdent-selection.html:
- platform/chromium-linux/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/gtk/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/mac/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/mac/editing/execCommand/outdent-selection-expected.txt: Removed.
- platform/qt/editing/execCommand/outdent-selection-expected.png: Removed.
- platform/qt/editing/execCommand/outdent-selection-expected.txt: Removed.
- 2:33 PM Changeset in webkit [88698] by
-
- 3 edits3 adds in trunk
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465
- compositing/layer-creation/overlap-child-layer-expected.png: Added.
- compositing/layer-creation/overlap-child-layer-expected.txt: Added.
- compositing/layer-creation/overlap-child-layer.html: Added.
2011-06-13 Adrienne Walker <enne@google.com>
Reviewed by Simon Fraser.
Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465
Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.
Test: compositing/layer-creation/overlap-animated-layer.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
- 2:29 PM Changeset in webkit [88697] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Correctly classify the test as failing.
- platform/chromium/test_expectations.txt: It's failing.
- 2:23 PM Changeset in webkit [88696] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Touch this to try to fix the build...
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget):
- 2:22 PM Changeset in webkit [88695] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Record more flakiness...
- platform/chromium/test_expectations.txt: Added expectation of flakiness.
- 2:20 PM Changeset in webkit [88694] by
-
- 2 edits in trunk/LayoutTests
[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597
Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.
- platform/win/Skipped:
- 2:14 PM Changeset in webkit [88693] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
- GNUmakefile.list.am: remove CredentialStorage.cpp
- 2:10 PM Changeset in webkit [88692] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Improve GPU canvas startup time on the SkiaGPU path.
https://bugs.webkit.org/show_bug.cgi?id=62594
Fixed by skipping creation of shaders used only by the legacy path.
Covered by existing canvas tests.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
- 2:08 PM Changeset in webkit [88691] by
-
- 6 edits in trunk/Source/WebCore
2011-06-13 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498
Added some needed and speculative FontCachePurgePreventer objects.
Built and ran Safari with debug version of webkit that purges all
purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
to find system fallback fonts access via code paths that aren't
protected with FontCachePurgePreventer objects. Also examined
platform specific code that calls either Font::drawText() or
Canvas::drawText(). For those methods that may be called from currently
unprotected paths, added FontCachePurgePreventer objects.
No new functionality so no new tests.
- inspector/DOMNodeHighlighter.cpp:
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: (PlatformCALayerWinInternal::displayCallback):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::drawHudContents):
- platform/mac/DragImageMac.mm: (WebCore::widthWithFont): (WebCore::drawAtPoint):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
- 1:59 PM Changeset in webkit [88690] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Windows rebaseline after r62565. The failure is tracked by the bug 62565.
- platform/win/fast/harness/results-expected.txt:
- 1:58 PM Changeset in webkit [88689] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
Unreviewed fix - removed parts of r88659 that were committed by mistake.
The patch accidentally included parts that weren't supposed to be there, namely the whole
code was duplicated. This patch rectifies that and brings it to the original reviewed code.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- 1:56 PM Changeset in webkit [88688] by
-
- 2 edits in trunk/LayoutTests
Test fix for Windows.
[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595
- platform/win/Skipped: Skipped the test with the problem.
- 1:52 PM Changeset in webkit [88687] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r88683
- 1:49 PM Changeset in webkit [88686] by
-
- 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Merging r87766
- 1:46 PM Changeset in webkit [88685] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544
Fixed the crash by adding null pointer checks.
No new tests since there's no way to open dictionary panel.
- dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
- editing/VisiblePosition.cpp: (WebCore::makeRange):
- page/Frame.cpp: (WebCore::Frame::rangeForPoint):
- 1:41 PM Changeset in webkit [88684] by
-
- 3 edits in trunk/LayoutTests
plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973
Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.
- platform/win/plugins/mouse-events-expected.txt:
- platform/win/plugins/mouse-events-fixedpos-expected.txt:
- 1:39 PM Changeset in webkit [88683] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-06-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Update the list of ignored GTK+ header files for the documentation
generation.
- docs/GNUmakefile.am: Update ignored header list.
- 1:36 PM Changeset in webkit [88682] by
-
- 16 edits2 adds in trunk/Source
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::iconURLs):
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Nate Chapin.
Factor IconController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62509
This new class contains all the icon-related logic from FrameLoader.
The icon-related logic and state has almost zero interaction with the
rest of FrameLoader and is better handled as a separate concern.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setIconURL):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconLoadDecisionAvailable): (WebCore::DocumentLoader::continueIconLoadWithDecision):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stop):
- loader/FrameLoader.h: (WebCore::FrameLoader::icon):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
- loader/icon/IconLoader.h:
- 1:25 PM Changeset in webkit [88681] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Update NEWS for 1.5.1 release.
- NEWS: update.
- 1:20 PM Changeset in webkit [88680] by
-
- 7 edits1 delete in trunk/Tools
2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88671.
http://trac.webkit.org/changeset/88671
https://bugs.webkit.org/show_bug.cgi?id=62591
"didn't work" (Requested by dpranke on #webkit).
- Scripts/new-run-webkit-httpd:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 1:19 PM Changeset in webkit [88679] by
-
- 5 edits2 adds in trunk
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
mostly written by Kelly Norton (knorton@google.com).
- plugins/npruntime/embed-property-equality-expected.txt: Added.
- plugins/npruntime/embed-property-equality.html: Added.
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
[V8] Cache V8NPObjects so that we don't create multiple
NPObjects for the same v8::Object.
https://bugs.webkit.org/show_bug.cgi?id=61482
Test: plugins/npruntime/embed-property-equality.html
- bindings/v8/NPV8Object.cpp: (WebCore::freeV8NPObject): (WebCore::npCreateV8ScriptObject):
2011-06-13 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
- 1:16 PM Changeset in webkit [88678] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-06-13 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Alexey Proskuryakov.
chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
https://bugs.webkit.org/show_bug.cgi?id=49316
The bug got fixed, thus just landing the test case. Including another test case from
http://code.google.com/p/chromium/issues/detail?id=61562
which should have the same root cause.
- fast/html/crash-style-first-letter-expected.txt: Added.
- fast/html/crash-style-first-letter.html: Added.
- svg/custom/svg-use-style-float-crash-expected.txt: Added.
- svg/custom/svg-use-style-float-crash.svg: Added.
- 1:07 PM Changeset in webkit [88677] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
BankID plug-in isn't instantiated correctly
https://bugs.webkit.org/show_bug.cgi?id=62588
<rdar://problem/9586600>
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can use the half-baked QuickDraw support.
- WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout): Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events and we don't want the plug-in to die while it's waiting for a reply.
- 1:03 PM Changeset in webkit [88676] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 James Robinson <jamesr@chromium.org>
[chromium] Fix up a boo-boo in GPU test expectations
- platform/chromium/test_expectations.txt:
- 1:01 PM Changeset in webkit [88675] by
-
- 2 edits in trunk/LayoutTests
Test run fix.
[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585
- platform/gtk/Skipped: Skipping a test which depends on this.
- 12:47 PM Changeset in webkit [88674] by
-
- 8 edits in trunk/Source
Source/WebCore:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit/gtk:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
Source/JavaScriptCore:
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Distcheck fixes.
- GNUmakefile.am:
- GNUmakefile.list.am:
- 12:37 PM Changeset in webkit [88673] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Robert Hogan <robert@webkit.org>
Unreviewed, cleanup r87611.
[Qt]Unskip fast/events/backspace-navigates-back.html
This should have been unskipped by http://trac.webkit.org/changeset/87611
- platform/qt/Skipped:
- 12:33 PM Changeset in webkit [88672] by
-
- 2 edits in trunk/LayoutTests
Remove an extra space in the Windows-specific failing expected results to ge the bots
green.
- platform/win/printing/page-count-relayout-shrink-expected.txt:
- 12:15 PM Changeset in webkit [88671] by
-
- 7 edits1 add in trunk/Tools
2011-06-13 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
https://bugs.webkit.org/show_bug.cgi?id=62251
shut_down_http_server() was a total hack that was only used by
new-run-webkit-httpd, so I've moved the code there and switched
to using executive.kill_process() for the common case. The
method itself will be removed in the patch on bug 59993.
- Scripts/new-run-webkit-httpd:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 12:12 PM Changeset in webkit [88670] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed build fix of mac.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
Forgot to add SVGAnimatedLength.cpp.
- WebCore.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [88669] by
-
- 16 edits in trunk/Source/WebKit2
kAXTextMarkerForPositionParametrizedAttribute does not work correctly in WK2
https://bugs.webkit.org/show_bug.cgi?id=62547
Reviewed by Darin Adler.
Implement the missing screenToWindow method for WK2.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToWindow):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::screenToWindow):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::screenToWindow):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::screenToWindow):
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::screenToWindow):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::screenToWindow):
- WebProcess/WebPage/WebPage.h:
- 12:09 PM Changeset in webkit [88668] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-06-13 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Make it possible to inline Identifier::equal
https://bugs.webkit.org/show_bug.cgi?id=62584
Move Identifier::equal to the Identifier header file.
- runtime/Identifier.cpp:
- runtime/Identifier.h: (JSC::Identifier::equal):
- 11:59 AM Changeset in webkit [88667] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.
- 11:58 AM Changeset in webkit [88666] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 James Robinson <jamesr@chromium.org>
[chromium] Clean up GPU test expectations.
- platform/chromium/test_expectations.txt:
- 11:53 AM Changeset in webkit [88665] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB test: complex keyPaths
https://bugs.webkit.org/show_bug.cgi?id=62468
- storage/indexeddb/keyPath-expected.txt: Added.
- storage/indexeddb/keyPath.html: Added.
- 11:50 AM Changeset in webkit [88664] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Print out bounds origin in layer dump
https://bugs.webkit.org/show_bug.cgi?id=62583
Include m_boundsOrigin in the layer dump, which is used by layerTreeAsText().
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- 11:48 AM Changeset in webkit [88663] by
-
- 17 edits55 adds in trunk
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
Added new tests to check correct behavior of SVGLength animations.
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-1.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-2.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-3.js: Added. (sample1): (sample2): (executeTest):
- svg/animations/script-tests/svglength-animation-number-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-cm.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-ems.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-exs.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-in.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-number.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pc.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pt.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-px-to-px.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/svglength-animation-values.js: Added. (sample1): (sample2): (sample3): (sample4): (sample5): (executeTest):
- svg/animations/svglength-animation-LengthModeHeight-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeHeight.html: Added.
- svg/animations/svglength-animation-LengthModeOther-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeOther.html: Added.
- svg/animations/svglength-animation-LengthModeWidth-expected.txt: Added.
- svg/animations/svglength-animation-LengthModeWidth.html: Added.
- svg/animations/svglength-animation-invalid-value-1-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-1.html: Added.
- svg/animations/svglength-animation-invalid-value-2-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-2.html: Added.
- svg/animations/svglength-animation-invalid-value-3-expected.txt: Added.
- svg/animations/svglength-animation-invalid-value-3.html: Added.
- svg/animations/svglength-animation-number-to-number-expected.txt: Added.
- svg/animations/svglength-animation-number-to-number.html: Added.
- svg/animations/svglength-animation-px-to-cm-expected.txt: Added.
- svg/animations/svglength-animation-px-to-cm.html: Added.
- svg/animations/svglength-animation-px-to-ems-expected.txt: Added.
- svg/animations/svglength-animation-px-to-ems.html: Added.
- svg/animations/svglength-animation-px-to-exs-expected.txt: Added.
- svg/animations/svglength-animation-px-to-exs.html: Added.
- svg/animations/svglength-animation-px-to-in-expected.txt: Added.
- svg/animations/svglength-animation-px-to-in.html: Added.
- svg/animations/svglength-animation-px-to-number-expected.txt: Added.
- svg/animations/svglength-animation-px-to-number.html: Added.
- svg/animations/svglength-animation-px-to-pc-expected.txt: Added.
- svg/animations/svglength-animation-px-to-pc.html: Added.
- svg/animations/svglength-animation-px-to-percentage-expected.txt: Added.
- svg/animations/svglength-animation-px-to-percentage.html: Added.
- svg/animations/svglength-animation-px-to-pt-expected.txt: Added.
- svg/animations/svglength-animation-px-to-pt.html: Added.
- svg/animations/svglength-animation-px-to-px-expected.txt: Added.
- svg/animations/svglength-animation-px-to-px.html: Added.
- svg/animations/svglength-animation-values-expected.txt: Added.
- svg/animations/svglength-animation-values.html: Added.
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimation should use direct unit animation for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=61368
When running SMIL animations within SVG, we unnecessarily transform the underlying SVG primitive datatype to strings, number+units, and back. As first step the target element
gets asked for its current value. This value gets transformed to a string. In SVGAnimateElement we try to parse this string again and
split it into a number and its unit. In the further steps we just animate the number. This number gets transformed back to a string
together with the parsed unit. The string gets passed back to the target element, which is responsible for parsing the passed string back
to a value as a SVG primitive datatype (like SVGLength, SVGNumber, SVGAngle, SVGColor, ...), relayout and rerendering.
In short: SVG primitive datatype -> string -> number + unit animation -> string -> SVG primitive datatype.
This patch does not attempt to change the string transformations, but addresses the parsing of the string back to a number and unit in the
SVG animation code. There's no need to write a new parser in SVGAnimateElement to parse SVG primitive datatypes, we can instead reuse the existing ones.
Also the current parser of SVGAnimateElement does not handle most unit types, nor is it possible to animate lists like SVGLengthList with the
parsed content. An animation of values with different unit types is not possible:
<rect width="20" height="20">
<animate animateAttribute="width" from="20px" to="10%" dur="4s"/>
</rect>
For the example above we would animate the rect width from 20px to 10px in 4 seconds and jump to the 10% of the viewport at the end of the
animation.
With using the parsers of SVG primitive datatypes we will also use the SVG primitive datatypes in the animation code itself. And that makes
it possible to do such animations.
In short: SVG primitive datatype -> string -> SVG primitive datatype animation -> string -> SVG primitive datatype.
It will be easier to avoid the string transformation once all SVG primitive datatypes are supported.
To hide the complexity of the animation code, the actual calculations of SVG animation specific values was moved to the corresponding
SVGAnimated* files (SVGAnimatedLength.cpp for SVGLength). SVGAnimateElement itself just works with the new added generic datatype SVGAnimationType.
SVGAnimatorFactory creates the SVG primitive datatype specific animators. This makes the main animation code a lot more readable and
maintainable.
With this patch I add the SVGAnimatorFactory and convert SVGLength animation to the new concept.
Tests: svg/animations/svglength-animation-LengthModeHeight.html
svg/animations/svglength-animation-LengthModeOther.html
svg/animations/svglength-animation-LengthModeWidth.html
svg/animations/svglength-animation-invalid-value-1.html
svg/animations/svglength-animation-invalid-value-2.html
svg/animations/svglength-animation-invalid-value-3.html
svg/animations/svglength-animation-number-to-number.html
svg/animations/svglength-animation-px-to-cm.html
svg/animations/svglength-animation-px-to-ems.html
svg/animations/svglength-animation-px-to-exs.html
svg/animations/svglength-animation-px-to-in.html
svg/animations/svglength-animation-px-to-number.html
svg/animations/svglength-animation-px-to-pc.html
svg/animations/svglength-animation-px-to-percentage.html
svg/animations/svglength-animation-px-to-pt.html
svg/animations/svglength-animation-px-to-px.html
svg/animations/svglength-animation-values.html
- CMakeLists.txt: Added new files to build system.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Added SVGAnimatedLength.cpp for Win and other build systems.
- svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit): Remove parsing code for SVGLength. Use SVGLength parser directly. (WebCore::SVGAnimateElement::adjustForCurrentColor): Made adjustForCurrentColor public as preperation for SVGAnimatedColor. (WebCore::getPropertyValue): Inline function to get computedStyle of CSS property. (WebCore::SVGAnimateElement::adjustForInheritance): Made adjustForInheritance as preperation for SVGAnimated* files. (WebCore::SVGAnimateElement::determineAnimatedAttributeType): SVGLength need special handling via SVGAnimator now. (WebCore::SVGAnimateElement::calculateAnimatedValue): Cleanup. Make use of SVGAnimator for SVGLength. (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. (WebCore::SVGAnimateElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto. (WebCore::SVGAnimateElement::calculateDistance): Ditto.
- svg/SVGAnimateElement.h:
- svg/SVGAnimatedLength.cpp: Added. (WebCore::SVGAnimatedLengthAnimator::SVGAnimatedLengthAnimator): (WebCore::sharedSVGLength): (WebCore::SVGAnimatedLengthAnimator::constructFromString): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndToValues): (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues): (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
- svg/SVGAnimatedLength.h: Added new class SVGAnimatedLengthAnimator which is responsible for the actual animation. (WebCore::SVGAnimatedLengthAnimator::~SVGAnimatedLengthAnimator):
- svg/SVGAnimatedType.h: Added. Generic SVG unit type for animations in SVGAnimateElement. (WebCore::SVGAnimatedType::createLength): (WebCore::SVGAnimatedType::~SVGAnimatedType): (WebCore::SVGAnimatedType::type): (WebCore::SVGAnimatedType::length): (WebCore::SVGAnimatedType::SVGAnimatedType):
- svg/SVGAnimatedTypeAnimator.h: Added. Base class for SVGAnimatedLengthAnimator and future SVG unit animators. (WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator): (WebCore::SVGAnimatedTypeAnimator::setContextElement): (WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseMappedAttribute): We do not use parseNumberValueAndUnit for SVGLength now. Have to strip white spaces here. Whitespaces shouldn't be stripped on the following attributes: 'from', 'to' and 'by'. This is not the case for SVGLength anymore. Added new tests to check this behavior. (WebCore::SVGAnimationElement::animationMode): Enum is accessible in WebCore namespace now. (WebCore::SVGAnimationElement::calcMode): Ditto.
- svg/SVGAnimationElement.h:
- svg/SVGAnimatorFactory.h: Added. (WebCore::SVGAnimatorFactory::create):
- svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString): New setter with string and SVGLengthMode. (WebCore::SVGLength::lengthModeForAnimatedLengthAttribute): Get LengthMode for SVGLength depending on the attribute name.
- svg/SVGLength.h:
- 11:42 AM WebKit Team edited by
- (diff)
- 11:37 AM Changeset in webkit [88662] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
r87539 broke HTMLMediaElement url logging
https://bugs.webkit.org/show_bug.cgi?id=62551
Returning pointers to temporaries is bad times!
- html/HTMLMediaElement.cpp: (WebCore::urlForLogging): (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::sourceWasAdded): (WebCore::HTMLMediaElement::sourceWillBeRemoved):
- 11:36 AM Changeset in webkit [88661] by
-
- 13 edits in trunk
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- Scripts/build-webkit:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62578
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 11:29 AM Changeset in webkit [88660] by
-
- 4 edits2 adds in trunk
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
- storage/indexeddb/setVersion-undefined-expected.txt: Added.
- storage/indexeddb/setVersion-undefined.html: Added.
2011-06-13 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
Test: storage/indexeddb/setVersion-undefined.html
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
- storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
- 11:22 AM Changeset in webkit [88659] by
-
- 1 edit2 adds in trunk/Source/WebKit2
2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Added WebGraphicsLayer, a subclass of WebCore::GraphicsLayer that serializes the state of the layer
tree to the UI process WebLayerTreeInfo.
For now this patch doesn't serialize the animation information, a feature that will be upstreamed later on.
Together with Viatcheslav Ostapenko.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: Added.
- WebProcess/WebCoreSupport/WebGraphicsLayer.h: Added.
- 11:20 AM Changeset in webkit [88658] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Clean up test expectations, add a flake.
- platform/chromium/test_expectations.txt: Cleaned up.
- 11:18 AM Changeset in webkit [88657] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Add utility method to report whether a RenderLayer has any scrollbars
https://bugs.webkit.org/show_bug.cgi?id=62579
New method that returns true with either scrollbar is present.
- rendering/RenderLayer.h: (WebCore::RenderLayer::hasScrollbars):
- 11:10 AM Changeset in webkit [88656] by
-
- 1 edit2 copies in branches/chromium/742
Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
- fast/files/blob-builder-crash-expected.txt: Added.
- fast/files/blob-builder-crash.html: Added.
TBR=jianli@chromium.org
BUG=85659
Review URL: http://codereview.chromium.org/7134095
- 11:09 AM Changeset in webkit [88655] by
-
- 1 edit2 adds in trunk/Source/WebKit2
2011-06-13 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement accelerated compositing on WK2 Qt port
https://bugs.webkit.org/show_bug.cgi?id=56935
Added WebLayerTreeInfo: a set of structures that can serialize a tree of GraphicsLayers
across to the UI process.
Together with Viatcheslav Ostapenko.
- Scripts/webkit2/messages.py:
- Shared/WebLayerTreeInfo.cpp: Added.
- Shared/WebLayerTreeInfo.h: Added.
- 11:05 AM Changeset in webkit [88654] by
-
- 7 edits in trunk/Source
2011-06-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338
No new tests; covered by the existing full-screen tests.
Now that we are forcing a repaint inside of setRootFullScreenLayer() instead of during
the next run loop, make sure that we have disabled animation before calling
setRootFullScreenLayer() so that the RenderFullScreen renderer and its contents are
painted.
- dom/Document.cpp: (WebCore::Document::webkitDidEnterFullScreenForElement):
2011-06-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Avoid flashing when exiting full-screen mode.
https://bugs.webkit.org/show_bug.cgi?id=62338
Instead of making a round-trip between processes by calling forceRepaint
and waiting for a callback, instead make a WebProcess-side call to
forceRepaintWithoutCallback before sending the ExitAcceleratedCompositingMode
message to the WebFullScreenControllerProxy. This also means we can get rid of
the dragImage creation and display.
Because this redraw will happen during the current run-loop instead of a future
one, make sure the background color has been set before the redraw in
didEnterFullScreen().
Wait to hide the full-screen window until after we have received the
ExitAcceleratedCompositingMode message. By this time, repaint will have already
completed.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Disable
screen updates, to be re-enabled during exitAcceleratedCompositingMode.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Don't hide
the full-screen window here; wait for exitAcceleratedCompositing instead.
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Collapse
the redrawCompleted method into this one.
(-[WKFullScreenWindowController close]): Remove the reference to
exitCompositedModeRepaintCompleted.
- WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::didEnterFullScreen): Set the full screen
background color first.
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Repaint before
sending the ExitAcceleratedCompositingMode message.
- 11:02 AM Changeset in webkit [88653] by
-
- 6 edits in trunk/Source/WebCore
2011-06-10 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Flash of white on left and right edges of screen when showing fullscreen controller when movie doesn't fill the entire screen
https://bugs.webkit.org/show_bug.cgi?id=62491
<rdar://problem/9584427>
No new tests; should be covered by existing fullscreen pixel tests.
On certain displays, when a RenderFullScreen renderer is created, it is large enough to trigger the
creation of a tiled CALayer (instead of a normal CALayer). Painting in these layers necessarily
happens asynchronously, so the flash is occurring because of the async painting of the RenderFullScreen
renderer's background color. Since we know the RenderFullScreen does not otherwise paint its contents,
we can add a special case in the RenderLayerBacking to set the GraphicsLayer contents to be the
renderer's background color. Fill in support for creating a contentLayer to contain the background
color inside GraphicsLayerCA.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToBackgroundColor): Renamed from setContentsBackgroundColor to match
the other setContentsTo... functions.
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsToBackgroundColor): Added. Creates a contentsLayer to host the
background color.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Removed a comment only.
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Special case the RenderFullScreen
renderer to call updateBackgroundColor.
(WebCore::RenderLayerBacking::updateBackgroundColor): Added.
(WebCore::RenderLayerBacking::containsPaintedContent): Tell the backing that the RenderFullScreen
renderer does not paint its contents.
- rendering/RenderLayerBacking.h:
- 10:59 AM Changeset in webkit [88652] by
-
- 2 edits2 adds in trunk
2011-06-13 Tim Horton <timothy_horton@apple.com>
Reviewed by Simon Fraser.
REGRESSION(87152): Crash on page with svg fonts
https://bugs.webkit.org/show_bug.cgi?id=61556
We can't assume that the parent of a SVG-font-styled
text node won't be an anonymous block.
Test: svg/text/text-font-anonymous-parent.xhtml
- rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::firstParentRendererForNonTextNode): (WebCore::SVGTextRunWalker::walk): (WebCore::floatWidthOfSubStringUsingSVGFont): (WebCore::SVGTextRunRenderingContext::drawTextUsingSVGFont):
- 10:49 AM Changeset in webkit [88651] by
-
- 2 edits3 deletes in trunk/LayoutTests
2011-06-13 Dirk Schulze <krit@webkit.org>
Rubber-stamped by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
Removing 'transform' animation test. It was added as an example for animateTransform tests but fails on some platforms.
Also it is not part of the fix for 'patternTransform' animation. The test for 'patternTransform' works.
Adding animateTransform-pattern-transform to the skip list of Mac WebKit2, like all other animation or dynamic-update tests.
- platform/mac-wk2/Skipped:
- svg/animations/animateTransform-transformable-transform-expected.txt: Removed.
- svg/animations/animateTransform-transformable-transform.html: Removed.
- svg/animations/script-tests/animateTransform-transformable-transform.js: Removed.
- 10:47 AM Changeset in webkit [88650] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Add radar number.
- 10:32 AM Changeset in webkit [88649] by
-
- 13 edits in trunk
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Configurations/FeatureDefines.xcconfig:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- Scripts/build-webkit:
2011-06-13 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
https://bugs.webkit.org/show_bug.cgi?id=62545
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 10:25 AM Changeset in webkit [88648] by
-
- 4 edits3 adds in trunk/LayoutTests
2011-06-13 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Updated Leopard pixel baselines.
- platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png: Added.
- platform/chromium-mac-leopard/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/chromium-mac-leopard/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:24 AM Changeset in webkit [88647] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Don't access freed memory in the UI process when a plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=62548
Call pluginProcessCrashedOrFailedToLaunch after sending messages to all processes about the plug-in crash,
otherwise we'll try to dereference m_pluginInfo.path after the PluginProcessProxy object has been deleted.
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose):
- 10:14 AM Changeset in webkit [88646] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix a crash when drawing area has been deleted
https://bugs.webkit.org/show_bug.cgi?id=62541
Check whether WebPageProxy::drawingArea() returns a valid pointer
before using it, it might be null, for example, when the web
process crashes.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (callDrawingAreaPaintMethod): (webkitWebViewBaseSizeAllocate):
- 10:12 AM Changeset in webkit [88645] by
-
- 4 edits in trunk/Source/WebCore
2011-06-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Some distcheck fixes. Still broken, but this is moves us closer to
the target.
- GNUmakefile.am: fix vpath syntax and add missing files to EXTRA_DIST.
- GNUmakefile.list.am: add missing files and remove dead files.
- bindings/gobject/GNUmakefile.am: fix comment.
- 9:54 AM Changeset in webkit [88644] by
-
- 2 edits1 add in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 9:16 AM Changeset in webkit [88643] by
-
- 2 edits in trunk/Source/WebCore
2011-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925
Use the new factory function in TextureMapper.
No new functionality so no new tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayer::create):
- 8:48 AM Changeset in webkit [88642] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 8:36 AM Changeset in webkit [88641] by
-
- 3 edits3 adds in trunk
2011-06-13 Young Han Lee <joybro@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281
syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
- animations/animation-direction-normal-expected.png: Added.
- animations/animation-direction-normal-expected.txt: Added.
- animations/animation-direction-normal.html: Added.
2011-06-13 Young Han Lee <joybro@company100.net>
Reviewed by Kenneth Rohde Christiansen.
[Texmap][Qt] Accelerated animation is repeating as if its direction property is always 'alternate'.
https://bugs.webkit.org/show_bug.cgi?id=62281
syncAnimations() has miscalculated a normalized progress value as if the animation always has alternate direction property.
Test: animations/animation-direction-normal.html
- platform/graphics/texmap/TextureMapperNode.cpp: (WebCore::TextureMapperNode::syncAnimations):
- 8:28 AM Changeset in webkit [88640] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62429
- UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
- UIProcess/API/efl/PageClientImpl.h:
- 8:09 AM Changeset in webkit [88639] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-06-13 KwangHyuk Kim <hyuki.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
https://bugs.webkit.org/show_bug.cgi?id=62448
Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter
- ewk/ewk_tiled_model.c: (ewk_tile_new):
- ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
- 7:58 AM Changeset in webkit [88638] by
-
- 1 edit1 add in trunk/Source/WebKit2
2011-06-13 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62525
- UIProcess/efl/WebPreferencesEfl.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey): (WebKit::WebPreferences::platformUpdateDoubleValueForKey):
- 7:28 AM Changeset in webkit [88637] by
-
- 3 edits6 adds in trunk
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
SVG animation did not take attribute 'patternTransform' into account. Added support for combination of
SVGPatternElement and attribute 'patternTransform' to SVGAnimateTransformElement.
Tests: svg/animations/animateTransform-pattern-transform.html
svg/animations/animateTransform-transformable-transform.html
- svg/SVGAnimateTransformElement.cpp: (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
2011-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG patternTransform not animatable
https://bugs.webkit.org/show_bug.cgi?id=62538
Test SVG animateTransform for attributes 'transform' and 'patternTransform'.
- svg/animations/animateTransform-pattern-transform-expected.txt: Added.
- svg/animations/animateTransform-pattern-transform.html: Added.
- svg/animations/animateTransform-transformable-transform-expected.txt: Added.
- svg/animations/animateTransform-transformable-transform.html: Added.
- svg/animations/script-tests/animateTransform-pattern-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
- svg/animations/script-tests/animateTransform-transformable-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):
- 7:12 AM Changeset in webkit [88636] by
-
- 2 edits in trunk/LayoutTests
2011-06-13 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 6:41 AM Changeset in webkit [88635] by
-
- 3 edits in trunk/Source/WebCore
2011-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] JSC Bridge: convert QtConnectionObject to use JSC API
https://bugs.webkit.org/show_bug.cgi?id=62330
This patch is based on the draft patch by Noam Rosenthal in bug 60842.
Qt API autotests cover the bridge behavior and pass after this patch.
- bridge/qt/qt_runtime.h: Change QtConnectionObject to use JSC API types. In particular, we got rid of Strong<JSObject> members. Renamed some members and arguments to follow existing naming in QObject::connect().
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): Use a new helper function to create a connection, passing the ExecState* that will be used when the connection is activated (signal emitted). Use JSC API types when looking up the matching signal to disconnect.
(JSC::Bindings::QtConnectionObject::QtConnectionObject): Use JSC API to
protect the receiver and receiverFunction from being garbage
collected. Removed the ASSERT() since we don't hold ProtectedPtrs (in current
code were Strong<>) anymore.
(JSC::Bindings::QtConnectionObject::~QtConnectionObject): Explain why is safe
to use m_originalSender here. Unprotect values that we protected in constructor.
(JSC::Bindings::isJavaScriptFunction): Helper function to identify whether a
JSObjectRef is a JS function (in contrast to a native function exposed to JS).
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
Both updated to use JSC API when appliable. Note that convertQVariantToValue
still returns JSC internal types, will be handled in a different patch.
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
Convenince for the existing caller until it is converted to JSC as well.
- 2:35 AM Changeset in webkit [88634] by
-
- 9 edits1 copy1 add in trunk/Source
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827
- platform/ContextMenuItem.h: Add gtkAction().
- platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu): Implement constructor that receives a platform menu. (WebCore::ContextMenu::setPlatformDescription): Make sure we don't destroy the menu if the new context menu is the current one. (WebCore::contextMenuItemVector): Implement this method to return the list of menu items in the given context menu, required by WebKit2. (WebCore::platformMenuDescription): Implement this method to return a platform menu for the given menu items.
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::createPlatformMenuItemDescription): Helper function to create a platform context menu item. (WebCore::ContextMenuItem::ContextMenuItem): Use createPlatformMenuItemDescription(). (WebCore::ContextMenuItem::title): Convert the title from UTF-8. (WebCore::ContextMenuItem::setTitle): Use gtkAction(). (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu() that receives a list of items. (WebCore::ContextMenuItem::setChecked): Use gtkAction(). (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2. (WebCore::ContextMenuItem::enabled): Ditto. (WebCore::ContextMenuItem::setEnabled): Use gtkAction(). (WebCore::ContextMenuItem::gtkAction): Return the GtkAction associated to the context menu item.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add context menu support for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54827
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createContextMenuProxy): Create a context menu proxy.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (globalPointForClientPoint): Function copied from webkit1 to convert a point in widget coordinates to global coordinates. (popupMenuPositionFunction): (webkitWebViewBaseShowContextMenu): Show the given context menu at the given position.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added. (WebKit::contextMenuItemActivatedCallback): (WebKit::WebContextMenuProxyGtk::createGtkMenu): (WebKit::WebContextMenuProxyGtk::showContextMenu): (WebKit::WebContextMenuProxyGtk::hideContextMenu): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
- UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h. (WebKit::WebContextMenuProxyGtk::create):
- 2:03 AM Changeset in webkit [88633] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py
2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>
Fix mistake I made in 88632
- 2:00 AM Changeset in webkit [88632] by
-
- 3 edits in trunk
2011-06-13 Keishi Hattori <keishi@webkit.org>
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 1:56 AM Changeset in webkit [88631] by
-
- 10 edits5 adds in trunk
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
- GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
- webkit/webkitwebview.h: Move declarations common to WebKit2 to webkitwebviewcommon.h.
- webkit/webkitwebviewcommon.h: Added.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
Add first implementation of WebKitWebView, a class with the same
API than webkit1, that wraps the C API to provide a high level
WebKit2 API for GTK port.
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitWebView.cpp: Added. (webkit_web_view_init): (webkit_web_view_class_init): (webkit_web_view_new): (webkit_web_view_load_uri): (webkit_web_view_go_back): (webkit_web_view_go_forward):
- UIProcess/API/gtk/WebKitWebView.h: Added.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseCreate): (webkitWebViewBaseCreateWebPage):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/webkit/webkit.h: Added.
2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Export an API similar to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=57820
Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
code, but linking to libwebkit2gtk.
- GNUmakefile.am:
- GtkLauncher/main.c: (createBrowser): (main):
Jun 12, 2011:
- 11:38 PM Changeset in webkit [88630] by
-
- 10 edits in trunk
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- platform/mac-wk2/Skipped:
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- WebKit.vcproj/WebKit.sln:
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 11:20 PM Changeset in webkit [88629] by
-
- 2 edits in trunk/Source/WebCore
2011-06-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507
No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.
If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
- dom/Document.cpp: (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
- 10:15 PM Changeset in webkit [88628] by
-
- 41 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
- loader/FrameLoaderClient.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptedForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/MainResourceLoader.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
- src/FrameLoaderClientImpl.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientEfl.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientGtk.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientHaiku.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::interruptedForPolicyChangeError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientQt.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebFrame.cpp: (WebFrame::interruptedForPolicyChangeError):
- WebFrame.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
- WebCoreSupport/FrameLoaderClientWinCE.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
- WebKitSupport/FrameLoaderClientWx.h:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
- WebProcess/WebCoreSupport/WebErrors.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: (WebKit::interruptedForPolicyChangeError):
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: (WebKit::interruptedForPolicyChangeError):
- 9:55 PM Changeset in webkit [88627] by
-
- 5 edits2 adds in trunk
2011-06-12 Hironori Bono <hbono@chromium.org>
Reviewed by Hajime Morita.
Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526
This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().
- editing/spelling/spellcheck-api-crash-expected.txt: Added.
- editing/spelling/spellcheck-api-crash.html: Added.
2011-06-12 Hironori Bono <hbono@chromium.org>
Reviewed by Hajime Morita.
Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
https://bugs.webkit.org/show_bug.cgi?id=62526
This change adds null checks to the following function to prevent crashes
when calling removeSpellcheckRange() with null:
HTMLTextAreaElement::removeSpellcheckRange(),
HTMLInputElement::removeSpellcheckRange(), and
HTMLDivElement::removeSpellcheckRange().
Test: editing/spelling/spellcheck-api-crash.html
- html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::removeSpellcheckRange):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::removeSpellcheckRange):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
- 9:13 PM Changeset in webkit [88626] by
-
- 5 edits in trunk
2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Antonio Gomes.
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Implements LayoutController.setTextDirection.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setTextDirection):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Antonio Gomes.
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Unskipping fast/html/set-text-direction.html.
- platform/qt/Skipped:
- 8:05 PM Changeset in webkit [88625] by
-
- 10 edits in trunk
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
- WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
Test: fast/harness/internals-object.html
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 7:17 PM Changeset in webkit [88624] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-12 Adam Barth <abarth@webkit.org>
Attempt to fix Qt build.
- WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
- 7:05 PM Changeset in webkit [88623] by
-
- 8 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
DocumentParser::appendBytes should use size_t for length instead of int
https://bugs.webkit.org/show_bug.cgi?id=62508
size_t is the proper type for distances in memory, especially on 64 bit
machines.
- dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes):
- dom/DecodedDataDocumentParser.h:
- dom/DocumentParser.h:
- html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
- html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
- 7:03 PM Changeset in webkit [88622] by
-
- 14 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
This function is a remnant of the old user gesture design, which
involved per-frame state stored on FrameLoader. Now that we're using
static state, we don't need this function anymore.
This function used to check whether JavaScript was enabled for the
top-level frame, but that check doesn't make any sense (like much of
the old user gesture code).
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
- loader/FrameLoader.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- WebView/WebView.mm: (-[WebView _isProcessingUserGesture]):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
- WebCoreSupport/FrameLoaderClientQt.cpp: (drtPrintFrameUserGestureStatus):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove FrameLoader::isProcessingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62519
Instead of asking the gesture indicator directly, ask the
ScriptController, like everyone else. The gesture indicator is just
one of the piece of information we use to determine whether we're
processing a user gesture.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isProcessingUserGesture):
- 4:34 PM Changeset in webkit [88621] by
-
- 3 edits in trunk/Source/WebKit/gtk
2011-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Remove webkit_web_view_get_selected_text
https://bugs.webkit.org/show_bug.cgi?id=62512
It's no longer used and it's a private method, so it can be
removed.
- webkit/webkitwebview.cpp: kill it.
- webkit/webkitwebviewprivate.h: ditto.
- 2:24 PM Changeset in webkit [88620] by
-
- 5 edits in trunk
2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517
It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).
- platform/qt/Skipped:
2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88616.
http://trac.webkit.org/changeset/88616
https://bugs.webkit.org/show_bug.cgi?id=62517
It broke editing/text-iterator/findString.html (Requested by
tonikitoo on #webkit).
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 1:01 PM Changeset in webkit [88619] by
-
- 2 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Fix fullscreen/full-screen-iframe-legacy.html.
- html/HTMLVideoElement.idl:
- 12:21 PM Changeset in webkit [88618] by
-
- 21 edits in trunk/Source
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
Update to call the FrameLoaderClient directly. Also, remove cargo-cult
code that checks whether FrameLoader is null.
- webkit/webkitwebview.cpp: (webkit_web_view_stop_loading): (webkit_web_view_can_show_mime_type):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebCoreSupport/WebFrameNetworkingContext.cpp: (WebFrameNetworkingContext::blockedError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebCoreSupport/WebFrameNetworkingContext.mm: (WebFrameNetworkingContext::blockedError):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
we lost that battle log ago. Nowadays, it's easier if folks just call
into FrameLoaderClient directly. Many of these functions have direct
callers already anyway.
- WebCore.exp.in:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstLayout):
- loader/FrameLoader.h:
- cancelledError is slightly more delicate, so I'm going to move it in a separate patch.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::interruptForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::loadNow):
- loader/MainResourceLoader.h:
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
- loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader):
- loader/PolicyChecker.cpp: (WebCore::PolicyChecker::continueAfterNavigationPolicy):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::blockedError):
- 11:27 AM Changeset in webkit [88617] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557
Reviewed by Darin Adler.
Replaced the fix for bug 58500 with a refined version.
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.
- 10:23 AM Changeset in webkit [88616] by
-
- 5 edits in trunk
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442
Reviewed by Antonio Gomes.
Tools:
Implements LayoutController.setTextDirection.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setTextDirection):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
Unskipping fast/html/set-text-direction.html.
- platform/qt/Skipped:
- 9:57 AM Changeset in webkit [88615] by
-
- 4 edits in trunk/Source/WebCore
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
Minor user-gesture related cleanup
https://bugs.webkit.org/show_bug.cgi?id=62511
In reading the user gesture code, I noticed that these lines of code
should be deleted because they don't do anything.
- bindings/v8/NPV8Object.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLVideoElement.idl:
- 7:52 AM Changeset in webkit [88614] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-06-12 Patrick Gansterer <Patrick Gansterer>
Unreviewed. Build fix for !ENABLE(JIT) after r88604.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate):
- 5:40 AM Changeset in webkit [88613] by
-
- 11 edits in trunk/Source/WebCore
2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add TextRun charactersLength member
https://bugs.webkit.org/show_bug.cgi?id=62501
Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
and skip the next two characters (this will be done in WidthIterator).
This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.
- platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
- platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch. (WebCore::Font::drawSimpleText): (WebCore::Font::drawEmphasisMarksForSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawEmphasisMarks):
- platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer
that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.
(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength):
(WebCore::TextRun::setCharactersLength):
- platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- platform/graphics/wx/FontWx.cpp: Ditto. (WebCore::Font::drawComplexText): (WebCore::Font::drawEmphasisMarksForComplexText):
- rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun. (WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlockLineLayout.cpp: Ditto. (WebCore::textWidth): (WebCore::tryHyphenating):
- rendering/RenderText.cpp: Ditto. (WebCore::RenderText::widthFromCache): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::RenderText::width):
- rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::constructTextRun):
- 4:51 AM Changeset in webkit [88612] by
-
- 5 edits13 adds in trunk
2011-06-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221
Our expectations for the unskipped tests have the following differences from the mac
platform:
- POST requests with no data get a default Content-Type of 'application/octet-stream' in Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3. This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header in qhttpnetworkrequest.cpp)
- DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.
- platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html
http/tests/xmlhttprequest/methods-lower-case.html
http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
- platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
2011-06-12 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix methods.html and methods-lower-case.html
https://bugs.webkit.org/show_bug.cgi?id=62221
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest
(WebCore::QNetworkReplyHandler::getIODevice): ditto
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
- Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since we do not send data with any of these requests.
- If a custom HTTP operation contains data, send it.
- platform/network/qt/QNetworkReplyHandler.h:
Jun 11, 2011:
- 11:01 PM Changeset in webkit [88611] by
-
- 2 edits in trunk/Source/WebCore
2011-06-11 Michael Saboff <msaboff@apple.com>
Reviewed by James Robinson.
REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349
Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.
Change made to address existing Chromium performance test regression.
- platform/graphics/FontCache.cpp:
- 9:19 PM Changeset in webkit [88610] by
-
- 6 edits in trunk/Source/WebCore
2011-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove unnecessary strlen from DocumentWriter
https://bugs.webkit.org/show_bug.cgi?id=62505
This ugly piece of code appears not to be needed. Rejoice.
- WebCore.exp.in:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
- loader/DocumentLoader.h:
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
- loader/DocumentWriter.h:
- 5:51 PM Changeset in webkit [88609] by
-
- 12 edits in trunk/Source/WebCore
2011-06-11 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
https://bugs.webkit.org/show_bug.cgi?id=62499
This patch removes the "flush" Boolean parameter from
DocumentParser::appendBytes in favor of a new flush method. This makes
some code in DocumentWriter look less ridiculous.
There's still lots of on contorting to do here, but it's a start.
- dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::appendBytes): (WebCore::DecodedDataDocumentParser::flush):
- dom/DecodedDataDocumentParser.h:
- dom/DocumentParser.h:
- dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::flush):
- html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes):
- html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::reportDataReceived): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
- loader/DocumentWriter.h:
- loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::appendBytes):
- 1:34 PM Changeset in webkit [88608] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-06-11 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaseline after r85560.
Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
because it has been passing on Mac.
- platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:28 PM Changeset in webkit [88607] by
-
- 5 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess. Launching it earlier can save time
when loading the first page.
Reviewed by Sam Weinig.
- UIProcess/API/C/WKContext.cpp:
(WKContextWarmInitialProcess):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::warmInitialProcess):
- UIProcess/WebContext.h:
- 1:21 PM Changeset in webkit [88606] by
-
- 3 edits2 deletes in trunk
2011-06-11 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
- storage/indexeddb/database-name-undefined-expected.txt: Removed.
- storage/indexeddb/database-name-undefined.html: Removed.
2011-06-11 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88569.
http://trac.webkit.org/changeset/88569
https://bugs.webkit.org/show_bug.cgi?id=62398
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
- storage/IDBFactory.idl:
- 1:16 PM Changeset in webkit [88605] by
-
- 3 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=16777
Reviewed by Darin Adler.
Remove #define NaN per Darin's comments.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):
- wtf/DateMath.cpp:
(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):
- 1:07 PM Changeset in webkit [88604] by
-
- 14 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches
Rubber stamped by Geoff Garen.
The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):
- jit/JIT.h:
- jit/JITCall.cpp:
- jit/JITCall32_64.cpp:
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):
- jit/JITPropertyAccess.cpp:
- jit/JITPropertyAccess32_64.cpp:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
- wtf/Platform.h:
- 11:09 AM Changeset in webkit [88603] by
-
- 2 edits in trunk/LayoutTests
2011-06-11 Dimitri Glazkov <Dimitri Glazkov>
Remove expectation of failure after clobber.
https://bugs.webkit.org/show_bug.cgi?id=62364
- platform/chromium/test_expectations.txt: Removed.
- 10:12 AM Changeset in webkit [88602] by
-
- 4 edits2 deletes in trunk
2011-06-11 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
- storage/indexeddb/setVersion-undefined-expected.txt: Removed.
- storage/indexeddb/setVersion-undefined.html: Removed.
2011-06-11 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
- storage/IDBDatabase.idl:
- 9:37 AM Changeset in webkit [88601] by
-
- 6 edits4 adds in trunk
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230
When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.
Tests: fast/dom/body-link-decl-parent-crash.html
fast/dom/styled-inline-style-decl-parent-crash.html
- dom/StyledElement.cpp: (WebCore::StyledElement::insertedIntoDocument): (WebCore::StyledElement::removedFromDocument):
- dom/StyledElement.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLBodyElement::removedFromDocument): (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
- html/HTMLBodyElement.h:
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62230
- fast/dom/body-link-decl-parent-crash-expected.txt: Added.
- fast/dom/body-link-decl-parent-crash.html: Added.
- fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
- fast/dom/styled-inline-style-decl-parent-crash.html: Added.
Jun 10, 2011:
- 11:45 PM Changeset in webkit [88600] by
-
- 3 edits in trunk/Source/WebCore
2011-06-10 Adam Barth <abarth@webkit.org>
Remove bogus ASSERTs. These ASSERTs used to be correct before I
changed DocumentWriter to put the onus for ignoring empty writes onto
the parser.
This patch should stop these test from triggering ASSERTs:
plugins/plugin-document-back-forward.html
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
userscripts/user-script-plugin-document.html
- html/MediaDocument.cpp: (WebCore::MediaDocumentParser::appendBytes):
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- 11:23 PM Changeset in webkit [88599] by
-
- 4 edits in trunk/Source
2011-06-09 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
AVPlayerLayer is adding a "fade" animation during Safari full-screen
https://bugs.webkit.org/show_bug.cgi?id=62433
CoreAnimation will add default animations when certain properties are changed, unless
those changes are wrapped in a CATransaction which has had its disableActions property set
to true. Wrap each of these three property changes in a CATransaction and disable its actions,
so that the default "fade" animation is not created in response.
- UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction. (-[WKFullScreenWindowController _swapView:with:]): Ditto:
- WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto.
- 11:04 PM Changeset in webkit [88598] by
-
- 2 edits in trunk/Tools
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: 'images' links on results.html don't work
https://bugs.webkit.org/show_bug.cgi?id=62194
Use relative path when generating images-diffs.html
- Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname.
- 10:52 PM Changeset in webkit [88597] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and
svg/custom/focus-event-handling-keyboard.html on Mac WebKit2
because they use DRT features not supported by WebKitTestRunner.
- platform/mac-wk2/Skipped:
- 9:56 PM Changeset in webkit [88596] by
-
- 3 edits in trunk/LayoutTests
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
GTK and Qt rebaselines after r88555.
- platform/gtk/svg/custom/focus-ring-expected.txt:
- platform/qt/svg/custom/focus-ring-expected.txt:
- 9:53 PM Changeset in webkit [88595] by
-
- 12 edits2 adds10 deletes in trunk/LayoutTests
2011-06-10 James Robinson <jamesr@chromium.org>
[chromium] Update chromium gpu baselines
- platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed.
- platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed.
- platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed.
- platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed.
- platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png:
- platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt:
- platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt:
- platform/chromium/test_expectations.txt:
- 9:35 PM Changeset in webkit [88594] by
-
- 3 edits in trunk/LayoutTests
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows.
- platform/chromium/fast/harness/results-expected.txt:
- platform/win/fast/harness/results-expected.txt:
- 9:14 PM Changeset in webkit [88593] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac
because it has been failing on the bot; the failure is tracked by the bug 62364.
- platform/chromium/test_expectations.txt:
- 9:05 PM Changeset in webkit [88592] by
-
- 4 edits in trunk/LayoutTests
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: results.html don't list the same list of failed tests as bots do
https://bugs.webkit.org/show_bug.cgi?id=62425
Fixed the bug by hiding expected crash, timeout, pass, etc... by default.
- fast/harness/resources/results-test.js:
- fast/harness/results-expected.txt:
- fast/harness/results.html:
- 8:36 PM Changeset in webkit [88591] by
-
- 6 edits3 adds in trunk
2011-06-10 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411
- fullscreen/full-screen-remove-ancestor-after-expected.txt: Added.
- fullscreen/full-screen-remove-ancestor-after.html: Added.
- platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
2011-06-09 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
https://bugs.webkit.org/show_bug.cgi?id=62411
Test: fullscreen/full-screen-remove-ancestor-after.html
The placeholder for RenderFullScreen was being created as a non-anonymous object, which led
to the document's renderer being set to 0 when the placeholder was removed due to its parent
being removed. Setting the placeholder to be anonymous, however, means that it will be
coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the
list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder
being so coalesced. To do so, made the placeholder object a true subclass, and add and
override its destroy() function to notify the RenderFullScreen object that it has been
destroyed.
- rendering/RenderFullScreen.cpp: (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added. (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder
has been destroyed.
(RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it.
(RenderFullScreen::setPlaceholder): Added.
(RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous.
- rendering/RenderFullScreen.h:
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added. (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of
objects which are not anonymous blocks.
- 7:51 PM Changeset in webkit [88590] by
-
- 14 edits13 adds in trunk/LayoutTests
2011-06-10 James Robinson <jamesr@chromium.org>
[chromium] Update chromium compositor baselines for r88580
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png:
- platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Added.
- platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png:
- platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png:
- platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
- platform/chromium-gpu-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/tiling/huge-layer-expected.txt: Added.
- platform/chromium-gpu-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:06 PM Changeset in webkit [88589] by
-
- 1 edit2 adds in trunk/Tools
2011-06-10 Lucas Forschler <Lucas Forschler>
Reviewed by Stephanie Lewis.
Script to kill old processes on Mac.
This matches the windows version.
https://bugs.webkit.org/show_bug.cgi?id=62479
- BuildSlaveSupport/mac: Added.
- BuildSlaveSupport/mac/kill-old-processes: Added.
- 7:04 PM Changeset in webkit [88588] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
REGRESSION (WebKit2): window.showModalDialog() broken
https://bugs.webkit.org/show_bug.cgi?id=62496
<rdar://problem/9581492>
If dispatching a message ends up creating a nested run loop, some incoming messages can end up not being
delivered until we exit from the run loop.
Fix this by using a Deque instead of a Vector for incoming messages, and get one message at a time and then
dispatch it. That prevents us from having any lingering messages lying around in stack allocated space.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage): (CoreIPC::Connection::dispatchMessages):
- Platform/CoreIPC/Connection.h:
- 7:03 PM Changeset in webkit [88587] by
-
- 25 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf
Reviewed by Sam Weinig.
There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.
Remove JSC::Inf, JSC::NaN, switch some cases of (isnan isinf) to !isfinite. Source/JavaScriptCore:
- API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
- API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
- JavaScriptCore.exp:
- runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
- runtime/JSCell.cpp:
- runtime/JSCell.h:
(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):
- runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toNumber):
- runtime/JSValue.cpp:
- runtime/JSValue.h:
- runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
- runtime/NumberConstructor.cpp:
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
- runtime/UString.cpp:
- wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
- wtf/dtoa.cpp:
(WTF::dtoa):
Source/WebCore:
- bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):
- 6:56 PM Changeset in webkit [88586] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 James Simonsen <simonjam@chromium.org>
Unreviewed, missing expectations for non-V8 from change 88584.
https://bugs.webkit.org/show_bug.cgi?id=62412
- html5lib/runner-expected.txt:
- 6:18 PM Changeset in webkit [88585] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-10 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Unresponsive cursor is shown when displaying a modal dialog
Part of <rdar://problem/9581492>
https://bugs.webkit.org/show_bug.cgi?id=62494
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runModal):
- UIProcess/WebPageProxy.h: Stop the responsiveness timer when calling out to show a modal dialog.
- 6:08 PM Changeset in webkit [88584] by
-
- 6 edits10 adds2 deletes in trunk
2011-06-10 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412
- platform/chromium/html5lib/runner-expected.txt: Passes another test.
- svg/dom/range-delete-expected.txt: Removed.
- svg/dom/range-delete.html: Removed.
- svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
- svg/dom/use-style-recalc-script-execute-crash.html:
- svg/in-html/resources/external.js: Added.
- svg/in-html/script-expected.txt: Added.
- svg/in-html/script-external-expected.txt: Added.
- svg/in-html/script-external.html: Added.
- svg/in-html/script-nested-expected.txt: Added.
- svg/in-html/script-nested.html: Added.
- svg/in-html/script-write-expected.txt: Added.
- svg/in-html/script-write.html: Added.
- svg/in-html/script.html: Added.
2011-06-10 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
<script> inside <svg> should be executed
https://bugs.webkit.org/show_bug.cgi?id=62412
Tests: svg/in-html/script-external.html
svg/in-html/script-nested.html
svg/in-html/script-write.html
svg/in-html/script.html
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
- 5:56 PM Changeset in webkit [88583] by
-
- 5 edits2 adds in trunk
2011-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336
Triggering this condition is very hard to do deterministically. This
test attempts to trigger the condition by sending exactly the right
number of bytes for the Chromium network stack. As network stacks vary
and evolve, it's likely we'll lose test coverage for this issue, but
this is the best test I could come up with.
- fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
- fast/parser/document-write-ignores-later-network-bytes.html: Added.
2011-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Script-created parsers should ignore data from the network
https://bugs.webkit.org/show_bug.cgi?id=62336
If the network packet boundaries line up just right, we can end up
feeding network data to a parser created by document.write (or
document.open). That's incorrect.
This patch causes DocumentWriter to grab hold of the original parser
and direct all input to that parser.
Test: fast/parser/document-write-ignores-later-network-bytes.html
- dom/Document.cpp: (WebCore::Document::explicitClose):
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource): (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
- loader/DocumentWriter.h:
- 5:39 PM Changeset in webkit [88582] by
-
- 8 edits2 adds in trunk/Source/WebKit/chromium
2011-06-10 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by James Robinson.
Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=62149
Added page overlay for inspector highlight support.
- WebKit.gyp:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
- src/PageOverlay.cpp: Added. (WebKit::PageOverlay::create): (WebKit::PageOverlay::PageOverlay): (WebKit::OverlayGraphicsLayerClientImpl::create): (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl): (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted): (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired): (WebKit::OverlayGraphicsLayerClientImpl::paintContents): (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders): (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter): (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl): (WebKit::PageOverlay::clear): (WebKit::PageOverlay::update): (WebKit::PageOverlay::paintWebFrame): (WebKit::PageOverlay::invalidateWebFrame):
- src/PageOverlay.h: Added. (WebKit::PageOverlay::~PageOverlay): (WebKit::PageOverlay::setClient):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::paintPageOverlay): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight):
- src/WebDevToolsAgentImpl.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::setPageOverlayClient): (WebKit::WebViewImpl::setOverlayLayer): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setRootPlatformLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
- src/WebViewImpl.h: (WebKit::WebViewImpl::pageOverlay):
- 5:38 PM Changeset in webkit [88581] by
-
- 3 edits in trunk/Tools
2011-06-10 Adam Barth <abarth@webkit.org>
Reviewed by James Robinson.
When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
https://bugs.webkit.org/show_bug.cgi?id=62489
- Scripts/webkitpy/tool/bot/sheriff.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 5:22 PM Changeset in webkit [88580] by
-
- 17 edits4 adds in trunk
2011-06-10 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Keep overlap testing logic until real 3d transforms are being used
https://bugs.webkit.org/show_bug.cgi?id=49857
For pages that use the translateZ(0) hack to force compositing layers, it's
advantageous to keep overlap testing, to avoid putting too many other
elements into layers.
Only turn off overlap testing if non-identity 3D transforms are used.
Tests: compositing/layer-creation/rotate3d-overlap.html
compositing/layer-creation/translatez-overlap.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
- rendering/RenderLayerCompositor.h:
- 5:21 PM Changeset in webkit [88579] by
-
- 3 edits2 adds in trunk
Web Worker fails to fire error event when a resource fetch fails.
https://bugs.webkit.org/show_bug.cgi?id=62475
Reviewed by Dmitry Titov.
Source/WebCore:
Test: http/tests/workers/worker-workerScriptNotThere.html
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.
LayoutTests:
- http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
- http/tests/workers/worker-workerScriptNotThere.html: Added.
- 5:11 PM Changeset in webkit [88578] by
-
- 10 edits2 adds in trunk
Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
https://bugs.webkit.org/show_bug.cgi?id=62469
Reviewed by Dmitry Titov.
Source/WebCore:
Test: fast/workers/worker-crash-with-invalid-location.html
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.
- workers/Worker.cpp:
(WebCore::Worker::create): Ditto.
- workers/Worker.h: Ditto.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts): Ditto.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.
- workers/WorkerScriptLoader.h: Made this RefCounted to allow for
keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):
Source/WebKit/chromium:
Test: fast/workers/worker-crash-with-invalid-location.html
- src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.
LayoutTests:
- fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
- fast/workers/worker-crash-with-invalid-location.html: Added.
- 4:55 PM Changeset in webkit [88577] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
[chromium] Top portion of page is rendered messed up with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=62484
Fixed the math in flipping the texture from bottom-up to top-down.
Test: compositing/repaint/shrink-layer.html (existing)
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw):
- 4:35 PM Changeset in webkit [88576] by
-
- 13 edits in trunk
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- Configurations/FeatureDefines.xcconfig:
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- Configurations/FeatureDefines.xcconfig:
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- Configurations/FeatureDefines.xcconfig:
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- Configurations/FeatureDefines.xcconfig:
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- Scripts/build-webkit:
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
add a compile guard ENABLE(FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62049
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 4:27 PM Changeset in webkit [88575] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-06-10 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
Add tests for Web Workers at invalid urls.
https://bugs.webkit.org/show_bug.cgi?id=62486
- http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
- http/tests/workers/shared-worker-invalid-url.html: Added.
- http/tests/workers/worker-invalid-url-expected.txt: Added.
- http/tests/workers/worker-invalid-url.html: Added.
- 3:55 PM Changeset in webkit [88574] by
-
- 1 edit1 add in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Turns out, linux baseline isn't spurious.
- platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.
- 3:43 PM Changeset in webkit [88573] by
-
- 2 edits in trunk/Source/WebCore
Roll out r88568. It is not the right fix for the problem.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
- 3:21 PM Changeset in webkit [88572] by
-
- 1 edit4 deletes in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
Remove all spurious copies of test expectations that somehow made it into the tree.
- platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
- platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
- platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
- 3:20 PM Changeset in webkit [88571] by
-
- 5 edits in trunk
<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
Reviewed by Dimitri Glazkov.
Source/WebCore:
Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.
Install the library and its associated header file in a more appropriate location
for the production configuration.
- Configurations/WebCoreTestSupport.xcconfig:
Tools:
Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- 2:53 PM Changeset in webkit [88570] by
-
- 10 edits in trunk/Source/WebCore
2011-06-10 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=62471
RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
in a way that was safe to call during existing style recalc or layout.
Move this code to ContainerElement so it can be called elsewhere.
Also add a param to the node callback so we can pass the style change type.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): (WebCore::ContainerNode::dispatchPostAttachCallbacks): (WebCore::needsStyleRecalcCallback): (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
- dom/ContainerNode.h:
- dom/Node.h: (WebCore::Node::scheduleSetNeedsStyleRecalc):
- html/HTMLFormControlElement.cpp: (WebCore::focusPostAttach): (WebCore::updateFromElementCallback):
- html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
- html/HTMLPlugInImageElement.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::attachRootPlatformLayer): (WebCore::RenderLayerCompositor::detachRootPlatformLayer): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
- rendering/RenderLayerCompositor.h:
- svg/SVGUseElement.cpp: (WebCore::updateFromElementCallback):
- 2:42 PM Changeset in webkit [88569] by
-
- 3 edits2 adds in trunk
2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398
- storage/indexeddb/database-name-undefined-expected.txt: Added.
- storage/indexeddb/database-name-undefined.html: Added.
2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: indexedDB.open() name argument is required
https://bugs.webkit.org/show_bug.cgi?id=62398
Test: storage/indexeddb/database-name-undefined.html
- storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments
- 2:34 PM Changeset in webkit [88568] by
-
- 2 edits in trunk/Source/WebCore
Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>
Reviewed by Beth Dakin.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.
- 2:25 PM Changeset in webkit [88567] by
-
- 1 edit1 add in trunk/LayoutTests
2011-06-10 Emil A Eklund <eae@chromium.org>
Land Windows expectations for new test added in r88556.
- platform/win/printing/page-count-relayout-shrink-expected.txt: Added.
- 2:16 PM Changeset in webkit [88566] by
-
- 7 edits in trunk/Source/WebCore
2011-06-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove Document::finishParsing
https://bugs.webkit.org/show_bug.cgi?id=62474
This function appears to exist only to confuse and befuddle us. This
patch prepares for DocumentWriter to grab hold of the parser.
This patch removes one of the print statements from
INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.
- dom/Document.cpp:
- dom/Document.h:
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finish):
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
- loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData): (WebCore::DocumentWriter::endIfNotLoadingMainResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stop):
- 2:14 PM Changeset in webkit [88565] by
-
- 4 edits2 adds in trunk
2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
- storage/indexeddb/setVersion-undefined-expected.txt: Added.
- storage/indexeddb/setVersion-undefined.html: Added.
2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB: setVersion() version argument is required
https://bugs.webkit.org/show_bug.cgi?id=62401
Test: storage/indexeddb/setVersion-undefined.html
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion): check for null version
- storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments
- 2:04 PM Changeset in webkit [88564] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Null-check the layer owner again when painting layers
https://bugs.webkit.org/show_bug.cgi?id=62473
Speculative fix for a crash that occurs when the layer's owner
gets destroyed during painting.
- platform/graphics/mac/WebLayer.mm: (drawLayerContents):
- 1:59 PM Changeset in webkit [88563] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Land expectations for a test, added in r88556.
- platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
- platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.
- 1:54 PM Changeset in webkit [88562] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
[V8] Add failure expectation for a test, added in r88559.
- platform/chromium/test_expectations.txt: Added.
- 1:49 PM Changeset in webkit [88561] by
-
- 2 edits in trunk/Source/WebCore
2011-06-08 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Lighten the --no-svg build a little
https://bugs.webkit.org/show_bug.cgi?id=62314
Only generate source from SVG*.idl if the build is svg-enabled.
- CodeGenerators.pri:
- 1:39 PM Changeset in webkit [88560] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Remove expectation of crash, fixed in r88551.
- platform/chromium/test_expectations.txt: Removed expectation.
- 1:33 PM Changeset in webkit [88559] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype
Reviewed by Sam Weinig.
This arises from chapter 15 of the spec:
"Every other property described in this clause has the attributes
{ Writable: true, Enumerable: false, Configurable: true }
unless otherwise specified."
Standardized properties are not enumerable.
Source/JavaScriptCore:
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
LayoutTests:
- fast/js/exception-properties-expected.txt: Added.
- fast/js/exception-properties.html: Added.
- fast/js/script-tests/exception-properties.js: Added.
(enumerableProperties):
- 1:29 PM Changeset in webkit [88558] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update expectations after r88555.
- platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.
- 1:15 PM Changeset in webkit [88557] by
-
- 7 edits in trunk/Source/WebCore
2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
https://bugs.webkit.org/show_bug.cgi?id=62441
Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.
Doesn't affect any test so far.
- platform/graphics/SVGGlyph.h: (WebCore::SVGGlyph::SVGGlyph): (WebCore::SVGGlyph::operator==):
- rendering/svg/SVGTextRunRenderingContext.cpp: (WebCore::SVGTextRunWalker::walk):
- svg/SVGFontData.cpp: (WebCore::SVGFontData::initializeFontData):
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::registerLigaturesInGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::collectGlyphsForString): (WebCore::SVGFontElement::collectGlyphsForGlyphName): (WebCore::SVGFontElement::svgGlyphForGlyph): (WebCore::SVGFontElement::missingGlyph):
- svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair):
- svg/SVGGlyphMap.h: (WebCore::SVGGlyphMap::addGlyphByUnicodeString): (WebCore::SVGGlyphMap::addGlyphByName): (WebCore::SVGGlyphMap::appendToGlyphTable): (WebCore::SVGGlyphMap::collectGlyphsForString): (WebCore::SVGGlyphMap::clear): (WebCore::SVGGlyphMap::svgGlyphForGlyph): (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):
- 12:44 PM Changeset in webkit [88556] by
-
- 3 edits3 adds in trunk
2011-06-10 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343
Fix regression caused by r85573. Cached document size not updated after layout.
- platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
- platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
- printing/page-count-relayout-shrink.html: Added.
2011-06-10 Emil A Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Regression r85573: Blank pages appear at the end of some wikipedia documents.
https://bugs.webkit.org/show_bug.cgi?id=62343
Fix regression caused by r85573. Cached document size not updated after layout.
Test: printing/page-count-relayout-shrink.html
- page/FrameView.cpp: (WebCore::FrameView::forceLayoutForPagination):
- 12:43 PM Changeset in webkit [88555] by
-
- 19 edits6 adds in trunk
2011-06-10 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
animation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894
focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545
Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.
- platform/mac/svg/custom/focus-ring-expected.txt:
- svg/custom/focus-event-handling-expected.txt: Added.
- svg/custom/focus-event-handling-keyboard-expected.txt: Added.
- svg/custom/focus-event-handling-keyboard.xhtml: Added.
- svg/custom/focus-event-handling.xhtml: Added.
- svg/custom/resources/focus-event-handling-keyboard.js: Added. (focusinHandler): (focusoutHandler):
- svg/custom/resources/focus-event-handling.js: Added. (clearFocusSeen): (): (focusoutHandler): (clickAt):
2011-06-10 Rob Buis <rbuis@rim.com>
Reviewed by Nikolas Zimmermann.
amation event handling broken: focusin
https://bugs.webkit.org/show_bug.cgi?id=12894
focusin, focusout, activate not implemented in SVG
https://bugs.webkit.org/show_bug.cgi?id=40545
Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:
http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute
Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.
Tests: svg/custom/focus-event-handling-keyboard.xhtml
svg/custom/focus-event-handling.xhtml
- rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeRectForRepaint):
- svg/SVGCircleElement.h: (WebCore::SVGCircleElement::supportsFocus):
- svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::supportsFocus):
- svg/SVGGElement.h: (WebCore::SVGGElement::supportsFocus):
- svg/SVGImageElement.h: (WebCore::SVGImageElement::supportsFocus):
- svg/SVGLineElement.h: (WebCore::SVGLineElement::supportsFocus):
- svg/SVGPathElement.h: (WebCore::SVGPathElement::supportsFocus):
- svg/SVGPolyElement.h: (WebCore::SVGPolyElement::supportsFocus):
- svg/SVGRectElement.h: (WebCore::SVGRectElement::supportsFocus):
- svg/SVGSVGElement.h: (WebCore::SVGSVGElement::supportsFocus):
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isMouseFocusable): (WebCore::SVGStyledElement::isKeyboardFocusable):
- svg/SVGStyledElement.h:
- svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::supportsFocus):
- svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::supportsFocus):
- svg/SVGTextElement.h: (WebCore::SVGTextElement::supportsFocus):
- svg/SVGUseElement.h: (WebCore::SVGUseElement::supportsFocus):
- 11:35 AM Changeset in webkit [88554] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
Rolled DEPS.
- DEPS:
- 11:17 AM Changeset in webkit [88553] by
-
- 8 edits in trunk/Source/WebCore
2011-06-10 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Clean up CSSPrimitiveValue::computeLength*
https://bugs.webkit.org/show_bug.cgi?id=61612
No new tests as no functionality changed.
- css/CSSGradientValue.cpp: Use new computeLength functions.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthIntForLength): Reduce to a single function using default parameter values. (WebCore::CSSPrimitiveValue::computeLength): Redefine existing functions with separate names as a single function using templated function specialization.
- css/CSSPrimitiveValue.h: Prototypes for computeLengthIntForLength and computeLength.
- css/CSSStyleApplyProperty.cpp: Use new computeLength functions.
- css/CSSStyleSelector.cpp: Use new computeLength functions.
- css/MediaQueryEvaluator.cpp: Use new computeLength functions.
- css/SVGCSSStyleSelector.cpp: Use new computeLength functions.
- 11:10 AM Changeset in webkit [88552] by
-
- 3 edits in trunk/Source/WebCore
2011-06-10 Simon Fraser <Simon Fraser>
Reviewed by Beth Dakin.
Add utility to RenderLayer to determine if the layer is scrollable
https://bugs.webkit.org/show_bug.cgi?id=62467
New method that returns true if either scrollbar is present and enabled.
Not called anywhere yet.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::allowsScrolling):
- rendering/RenderLayer.h:
- 10:56 AM Changeset in webkit [88551] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Tony Chang.
REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
https://bugs.webkit.org/show_bug.cgi?id=62460
Test: fast/dom/prototype-inheritance-2.html
- dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.
- 10:51 AM Changeset in webkit [88550] by
-
- 4 edits14 deletes in branches/chromium/782
Revert r87319 on 782 branch.
- 10:31 AM Changeset in webkit [88549] by
-
- 3 edits2 adds in trunk
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Tony Gentilcore.
Tests that trying to remove all document children while building a svg <use>
element shadow and instance tree does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62225
- svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
- svg/dom/use-style-recalc-script-execute-crash.html: Added.
2011-06-10 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
Don't execute scripts in shadow SVG.
https://bugs.webkit.org/show_bug.cgi?id=62225
Test: svg/dom/use-style-recalc-script-execute-crash.html
- dom/ScriptElement.cpp: (WebCore::ScriptElement::prepareScript):
- 10:31 AM Changeset in webkit [88548] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-10 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] make features.gypi the same as features_override.gypi
https://bugs.webkit.org/show_bug.cgi?id=62399
Make the file the same as chromium's features_override.gypi so we
can remove features_override.gypi in chromium.
Remove ENABLE_DATAGRID=0 since the define is gone and remove
ENABLE_FULLSCREEN_API=1 since we want to disable it.
- features.gypi:
- 10:29 AM Changeset in webkit [88547] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>
Reviewed by Joseph Pecoraro.
Fixed build with enabled workers and disabled inspector
https://bugs.webkit.org/show_bug.cgi?id=62461
- inspector/InspectorWorkerAgent.cpp: Added inspector guard
- 10:05 AM Changeset in webkit [88546] by
-
- 4 edits in trunk/Source/WebCore
2011-06-10 Darin Adler <Darin Adler>
Reviewed by Eric Carlson.
REGRESSION: Fullscreen video controller can't be dragged
https://bugs.webkit.org/show_bug.cgi?id=62462
No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.
- html/shadow/MediaControlElements.cpp: (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new booleans related to dragging. (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging is allowed and a drag isn't already in progress. (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if dragging is already in progress. (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is done during the dragging process. (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel using explicit top/left. (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning done by setPosition. (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag, continueDrag, and endDrag in response to mouse events. (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
- html/shadow/MediaControlElements.h: Added new function and data members as mentioned above.
- html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true) so you can drag the panel while in fullscreen. (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false) so you can't drag the panel while not in fullscreen. Also call resetPosition so position changes from dragging don't affect the panel in other contexts.
- 10:00 AM Changeset in webkit [88545] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
Remove tests that are now passing.
- platform/chromium/test_expectations.txt: Removed passing tests.
- 9:52 AM Changeset in webkit [88544] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Darin Adler <Darin Adler>
Reviewed by Eric Carlson.
REGRESSION: Full screen video HUD is positioned too low for standalone video documents
https://bugs.webkit.org/show_bug.cgi?id=62463
No test because we don't currently have machinery for testing fullscreen.
- css/fullscreen.css: Removed rule that said bottom: 0px for the control panel for full page media in full screen mode. This is not needed because the control panel for full screen mode already has style rules to set its vertical position. (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said -webkit-tranform. This will fix a potential problem where fullscreen would malfunction on a page that had a media element inside a transform.
- 9:06 AM Changeset in webkit [88543] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Add support for non-ASCII filenames in Content-Disposition header
https://bugs.webkit.org/show_bug.cgi?id=62454
Try latin1 as fallback for header parameter values as some servers
do not follow RFC 2045 for example with filename parameter in
Content-Disposition.
No new tests required as no functionality changed.
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
- 8:55 AM Changeset in webkit [88542] by
-
- 2 edits in trunk/LayoutTests
2011-06-10 Dimitri Glazkov <Dimitri Glazkov>
REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
https://bugs.webkit.org/show_bug.cgi?id=62460
- platform/chromium/test_expectations.txt: Updated test expectations.
- 4:56 AM Changeset in webkit [88541] by
-
- 3 edits in trunk/Source/WebCore
2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add layer factory to GraphicsLayer for creating non-default layer type.
https://bugs.webkit.org/show_bug.cgi?id=61925
Added a static factory protected member to GraphicsLayer, which should be accessed from
a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.
This is needed for accelerated compositing across processes in WebKit2, since WebCore
doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
different implementations of GraphicsLayer coexist impossible without some runtime
factory that can be overridden by the web process.
Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
would have to explicitly call it, in order to be unintrusive with current implementations.
No new functionality, so no new tests.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setGraphicsLayerFactory):
- platform/graphics/GraphicsLayer.h:
- 4:34 AM Changeset in webkit [88540] by
-
- 1 edit6 adds in trunk/Source/WebKit2
2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
https://bugs.webkit.org/show_bug.cgi?id=62346
Add WebProcess/WebCoreSupport/efl directory and files.
- WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added. (WebKit::WebEditorClient::handleKeyboardEvent): (WebKit::WebEditorClient::handleInputMethodKeydown):
- WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added. (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError): (WebKit::pluginWillHandleLoadError):
- WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
- WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
- 4:32 AM Changeset in webkit [88539] by
-
- 6 edits in trunk
2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376
Add files that need to be compiled in every port for supporting WebGL.
Each port still needs to add its specific files to
CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
yet.
- Source/CMakeLists.txt: Add files needed to support WebGL.
- Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
- Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is enabled.
2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[CMAKE] Add generic support for building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=62376
Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.
No change in functionality so no new tests.
- CMakeLists.txt:
- 4:31 AM Changeset in webkit [88538] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-10 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Fix 'headers' autotest when building inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=62449
- Api/qwebkitplatformplugin.h:
- 4:30 AM Changeset in webkit [88537] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL]add image content hint information for tile image object when it is created
https://bugs.webkit.org/show_bug.cgi?id=62436
When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
In order to support this enhanced feature, image content hint information must be
specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC
- ewk/ewk_tiled_model.c: (ewk_tile_new):
- 4:23 AM Changeset in webkit [88536] by
-
- 2 edits in trunk/Source/WebCore
2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Andreas Kling.
[GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
https://bugs.webkit.org/show_bug.cgi?id=62435
No new tests required as just fixed warning.
- platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::PlatformContextCairo):
2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377
- inspector/InspectorValues.cpp:
- 3:15 AM Changeset in webkit [88535] by
-
- 5 edits in trunk
2011-06-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377
- inspector/report-protocol-errors-expected.txt:
- inspector/report-protocol-errors.html:
2011-06-11-06-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377
- inspector/InspectorValues.cpp:
- 3:06 AM Changeset in webkit [88534] by
-
- 3 edits in trunk/Source/WebKit/qt
2011-06-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=62420
ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
but they meant to be independent.
- Api/qwebframe.cpp: (QWebFramePrivate::_q_orientationChanged): (QWebFrame::QWebFrame):
- Api/qwebframe_p.h:
- 2:09 AM Changeset in webkit [88533] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-06-10 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Repaint throttling API.
https://bugs.webkit.org/show_bug.cgi?id=56178
The API allows to set the values for repaint throttling.
It should ensure displaying a content with many css/gif animations.
- ewk/ewk_settings.cpp: (ewk_settings_repaint_throttling_set):
- ewk/ewk_settings.h:
- 1:56 AM Changeset in webkit [88532] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Use makeString() when getting os version
https://bugs.webkit.org/show_bug.cgi?id=62434
When os version string is created, to use makeString() is better than
String operation.
- ewk/ewk_settings.cpp: (_ewk_settings_webkit_os_version_get):
- 1:41 AM Changeset in webkit [88531] by
-
- 5 edits in trunk
2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440
qt build was broken (Requested by loislo on #webkit).
- inspector/report-protocol-errors-expected.txt:
- inspector/report-protocol-errors.html:
2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88530.
http://trac.webkit.org/changeset/88530
https://bugs.webkit.org/show_bug.cgi?id=62440
qt build was broken (Requested by loislo on #webkit).
- inspector/InspectorValues.cpp:
- 1:33 AM Changeset in webkit [88530] by
-
- 5 edits in trunk
2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377
- inspector/report-protocol-errors-expected.txt:
- inspector/report-protocol-errors.html:
2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
https://bugs.webkit.org/show_bug.cgi?id=62377
- inspector/InspectorValues.cpp:
- 12:35 AM Changeset in webkit [88529] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-06-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dmitry Titov.
[Chromium] Worker object may be garbage collected even if it has message handlers
https://bugs.webkit.org/show_bug.cgi?id=62292
I'd like to convert the test case into a layout test but I don't see yet
how to do this so that the test isn't too slow and reliable. The problem
with test is that full-GC needs to be triggered right after
WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
So no test for now.
- src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending activity state every time a message is confirmed since the message may have created a new activity.
- src/WebWorkerClientImpl.h:
- 12:10 AM Changeset in webkit [88528] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=62402
Sites are able to override the "overflow:hidden" rule for root full-screen nodes
simply by adding a "html {}" rule. Make this rule !important, and also make it apply
to root nodes who are merely ancestors of full-screen elements, to cover the case of
a root node containing an <iframe> whose contents have gone full-screen.
- css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
:root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
who are full-screen ancestors, and make them !important.
Jun 9, 2011:
- 11:42 PM Changeset in webkit [88527] by
-
- 3 edits in trunk/LayoutTests
2011-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Antonio Gomes.
[Qt] LayoutTests/fast/history/history_reload.html failing
https://bugs.webkit.org/show_bug.cgi?id=62369
Unskipping. Generating click of button element in generic way.
Remove hardcoding of click co-ordinates to avoid native font differences.
- fast/history/history_reload.html:
- platform/qt/Skipped:
- 11:20 PM Changeset in webkit [88526] by
-
- 13 edits in trunk/Source/WebCore
2011-06-09 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=61495
No new tests required as no functionality changed.
- css/CSSPrimitiveValueMappings.h: Support cast to/from Order
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): Convert from bool to enum type. (WebCore::CSSStyleSelector::applyProperty): Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
- dom/Document.cpp: (WebCore::Document::setVisuallyOrdered): Change call to RenderStyle::setRTLOrdering using enum parameter.
- rendering/style/RenderStyle.h: rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
- rendering/style/RenderStyleConstants.h: Define enum type.
- 11:19 PM Changeset in webkit [88525] by
-
- 7 edits in trunk/Source/WebCore
2011-06-09 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61601
No new tests. No new functionality added / covered by existing tests.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EBorderStyle): Support CSSValueAuto as required by outline-style property. (WebCore::CSSPrimitiveValue::operator OutlineIsAuto): Add cast to new OutlineIsAuto enum.
- css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialize handler for CSSPropertyOutlineStyle.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove old handler for CSSPropertyOutlineStyle.
- rendering/style/OutlineValue.h: Use new OutlineIsAuto enum instead of bool.
- rendering/style/RenderStyle.h: Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties. Use new OutlineIsAuto enum type.
- rendering/style/RenderStyleConstants.h: Define new enum OutlineIsAuto.
- 11:17 PM Changeset in webkit [88524] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
https://bugs.webkit.org/show_bug.cgi?id=62418
No new tests / cleanup only.
- css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyDefaultBase::applyInheritValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::applyInitialValue): Use new wrapper functions. (WebCore::ApplyPropertyDefaultBase::setValue): Wrapper for calling m_setter function pointer. (WebCore::ApplyPropertyDefaultBase::value): Wrapper for calling m_getter function pointer. (WebCore::ApplyPropertyDefaultBase::initial): Wrapper for calling m_initial function pointer. (WebCore::ApplyPropertyDefault::applyValue): Use new setValue function. (WebCore::ApplyPropertyLength::applyValue): Use new setValue function. (WebCore::ApplyPropertyWidth::applyValue): Use new setValue function.
- 11:16 PM Changeset in webkit [88523] by
-
- 4 edits1 delete in trunk/Source/WebKit/chromium
2011-06-09 James Kozianski <koz@chromium.org>
Unreviewed, rolling out r88466.
http://trac.webkit.org/changeset/88466
https://bugs.webkit.org/show_bug.cgi?id=60059
Broke PPAPITest.URLLoader test on the chromium bots
- WebKit.gyp:
- WebKit.gypi:
- src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::loadAsynchronously):
- tests/AssociatedURLLoaderTest.cpp: Removed.
- 10:54 PM Changeset in webkit [88522] by
-
- 1 edit in trunk/Examples/ChangeLog
Rollback 88521
- 10:49 PM Changeset in webkit [88521] by
-
- 1 edit in trunk/Examples/ChangeLog
test
- 9:43 PM Changeset in webkit [88520] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix: Corrected header spelling.
- heap/OldSpace.h:
- 9:38 PM Changeset in webkit [88519] by
-
- 11 edits2 adds in trunk/Source/JavaScriptCore
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added OldSpace to the project
https://bugs.webkit.org/show_bug.cgi?id=62417
Currently unused.
Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
per-block flag for testing whether you're in NewSpace vs OldSpace.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Build!
- heap/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h: (JSC::MarkedBlock::inNewSpace): (JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in write barrier.
- heap/NewSpace.cpp: (JSC::NewSpace::addBlock): (JSC::NewSpace::removeBlock):
- heap/NewSpace.h: (JSC::NewSpace::forEachBlock): Added forEachBlock, to use for NewSpace-specific operations.
- heap/OldSpace.cpp: Added. (JSC::OldSpace::OldSpace): (JSC::OldSpace::addBlock): (JSC::OldSpace::removeBlock):
- heap/OldSpace.h: Added. (JSC::OldSpace::forEachBlock): New class for holding promoted blocks. Not in use yet.
- 8:52 PM Changeset in webkit [88518] by
-
- 8 edits2 adds in trunk/Source
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.
- wtf/Platform.h:
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add a new class, GraphicsLayerEfl - not yet implemented.
Add ACCELERATED_COMPOSITING related files to CMakeLists.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- platform/graphics/efl/GraphicsLayerEfl.cpp: Added. (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerEfl::GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl): (WebCore::GraphicsLayerEfl::setNeedsDisplay): (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
- platform/graphics/efl/GraphicsLayerEfl.h: Added.
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add functions for accelerated compositing to ChromeClientEfl.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::attachRootGraphicsLayer): (WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization): (WebCore::ChromeClientEfl::scheduleCompositingLayerSync): (WebCore::ChromeClientEfl::allowedCompositingTriggers):
- WebCoreSupport/ChromeClientEfl.h:
- 8:45 PM Changeset in webkit [88517] by
-
- 3 edits in trunk
2011-06-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[CMAKE] Never let USER_AGENT defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=62410
This patch is similar to r88342, but sets WEBKIT_USER_AGENT_*
definitions only if that port defined it. A port might prefer to set it
in other place, e.g. a header that is part of the public API (like GTK
does).
By using #cmakedefine instead of #define, if that variable is not set
in CMake it will expand to:
/* #define WEBKIT_USER_AGENT_MAJOR_VERSION */
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
- 7:50 PM Changeset in webkit [88516] by
-
- 2 edits in trunk/LayoutTests
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
Last attempt to make buildbot happy against crazy flakiness near inspector tests. :-/
- platform/qt/Skipped: Disable all inspector tests until fix.
- 7:43 PM Changeset in webkit [88515] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Brent Fulgham.
[efl] Do not enable the encoding detector by default.
https://bugs.webkit.org/show_bug.cgi?id=61744
This should match the behaviour of other ports more closely, and makes
at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.
- ewk/ewk_view.cpp: (_ewk_view_priv_new):
- 7:30 PM Changeset in webkit [88514] by
-
- 2 edits in trunk/LayoutTests
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
One more attempt to make buildbot happy
against crazy flakiness near inspector tests. :-/
- platform/qt/Skipped:
- 6:59 PM Changeset in webkit [88513] by
-
- 6 edits1 add in trunk
Unreviewed rolling out r88471, because it broke plugin tests on Qt.
Tools:
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11):
(NPP_GetValue):
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(executeScript):
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_stream_as_file):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
(webkit_test_plugin_print):
(keyEventToChar):
(webkit_test_plugin_handle_event):
(webkit_test_plugin_url_notify):
(webkit_test_plugin_get_value):
(webkit_test_plugin_set_value):
(NP_GetMIMEDescription):
(NP_Initialize):
(NP_Shutdown):
(NP_GetValue):
- GNUmakefile.am:
LayoutTests:
- platform/chromium-linux/plugins/mouse-events-expected.txt:
- 6:42 PM Changeset in webkit [88512] by
-
- 1 edit2 copies in branches/chromium/782
Merge 88510 - Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
- fast/files/blob-builder-crash-expected.txt: Added.
- fast/files/blob-builder-crash.html: Added.
BUG=85659
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/7003106
- 6:31 PM Changeset in webkit [88511] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unskip fast/forms/input-number-large-padding.html
https://bugs.webkit.org/show_bug.cgi?id=61845
It should work now because we don't use outer-spin-button anymore.
- platform/mac/Skipped:
- 6:09 PM Changeset in webkit [88510] by
-
- 3 edits2 adds in trunk
Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
- fast/files/blob-builder-crash-expected.txt: Added.
- fast/files/blob-builder-crash.html: Added.
- 6:08 PM Changeset in webkit [88509] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Remove expectations for passing tests.
- platform/chromium/test_expectations.txt:
- 5:50 PM Changeset in webkit [88508] by
-
- 12 edits in trunk/LayoutTests
2011-06-09 James Robinson <jamesr@chromium.org>
[chromium] Update some chromium gpu baselines
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium/test_expectations.txt:
- 5:30 PM Changeset in webkit [88507] by
-
- 4 edits in trunk
2011-06-09 James Robinson <jamesr@chromium.org>
[chromium] Mark the fullscreen directory as skipped
https://bugs.webkit.org/show_bug.cgi?id=62397
- platform/chromium/test_expectations.txt:
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=62397
Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
even when the runtime setting was disabled.
- features.gypi:
- 5:30 PM Changeset in webkit [88506] by
-
- 2 edits in trunk/Source/JavaScriptCore
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Geoff Garen.
Fix geoff's review comments re static_cast.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
- 5:03 PM Changeset in webkit [88505] by
-
- 4 edits in trunk/Source/WebCore
2011-06-09 Jer Noble <jer.noble@apple.com>
Reviewed by David Hyatt.
Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
https://bugs.webkit.org/show_bug.cgi?id=62400
No new tests; covered by existing fullscreen/full-screen-video-offset.html test.
- rendering/RenderVideo.cpp: (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists. (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block. (WebCore::RenderVideo::offsetTop): Ditto. (WebCore::RenderVideo::offsetWidth): Ditto. (WebCore::RenderVideo::offsetHeight): Ditto.
- rendering/RenderVideo.h: Added virtual overrides for the offset functions.
- 5:02 PM Changeset in webkit [88504] by
-
- 10 edits2 adds in trunk/Source/JavaScriptCore
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored MarkedBlock set management into a helper class with a fast case Bloom filter
https://bugs.webkit.org/show_bug.cgi?id=62413
SunSpider reports a small speedup.
This is in preparation for having ConservativeSet operate on arbitrary
sets of MarkedBlocks, and in preparation for conservative scanning
becoming proportionally more important than other GC activities.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj: Build-o.
- heap/ConservativeRoots.cpp: (JSC::ConservativeRoots::add):
- heap/ConservativeRoots.h: (JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet directly, instead of a Heap, so we can operate on subsets of the Heap instead.
Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
is particularly important since we expect not to find our subject pointer
in the MarkedBlock hash, and hash misses are more expensive than typical
hash lookups because they have high collision rates.
No need for single-pointer add() to be public anymore, since nobody uses it.
- heap/Heap.cpp: (JSC::Heap::markRoots):
- heap/Heap.h: (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what ConservativeRoots relies on.
Nixed contains(), since nobody uses it anymore.
- heap/MarkedBlock.h: (WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of the VM layout properties of MarkedBlocks.
- heap/MarkedBlockSet.h: Added. (JSC::MarkedBlockSet::add): (JSC::MarkedBlockSet::remove): (JSC::MarkedBlockSet::recomputeFilter): (JSC::MarkedBlockSet::filter): (JSC::MarkedBlockSet::set):
- heap/TinyBloomFilter.h: Added. (JSC::TinyBloomFilter::TinyBloomFilter): (JSC::TinyBloomFilter::add): (JSC::TinyBloomFilter::ruleOut): New helper class, used above.
- interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots): No need to specifically exclude values by tag -- the tiny bloom filter is already a register-register compare, so adding another "rule out" factor just slows things down.
- 4:46 PM Changeset in webkit [88503] by
-
- 7 edits in trunk
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Oliver Hunt.
There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.
Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.
These errors result in three test-262 failures.
Source/JavaScriptCore:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
- runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::push):
LayoutTests:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:
- 4:37 PM Changeset in webkit [88502] by
-
- 1 copy in tags/Safari-534.45
New tag.
- 4:37 PM Changeset in webkit [88501] by
-
- 6 edits3 copies in branches/chromium/782
Merge 88496 - 2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
Tests that a layer that should clip its children actually does clip even when scrolled offscreen.
- platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
- platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
- platform/chromium/compositing/scissor-out-of-viewport.html: Added.
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.
This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.
Test: platform/chromium/compositing/scissor-out-of-viewport.html
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):
BUG=84122
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7046081
- 4:36 PM Changeset in webkit [88500] by
-
- 1 edit in branches/safari-534-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
real fix for 88481. (remove tabs)
- 4:35 PM Changeset in webkit [88499] by
-
- 1 delete in tags/Safari-534.45
Remove Tag.
- 4:33 PM Changeset in webkit [88498] by
-
- 7 edits in trunk
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
- platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and end. This matches other ports. Only use GLib style early returns when checking the validity of GObjects. (DumpRenderTreeSupportGtk::hasComposition): Added. (DumpRenderTreeSupportGtk::compositionRange): Added. (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above. (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above. (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
- WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
Add callbacks to support hasMarkedText and markedRange and also clean up existing
TextInputController support.
- DumpRenderTree/gtk/TextInputController.cpp: (setMarkedTextCallback): Accept parameters in terms of start and length, instead of start and end. This matches the other ports. Do not use GLib style early returns. (hasMarkedTextCallback): Added. (markedRangeCallback): Added. (insertTextCallback): Cleanup as described above. (unmarkTextCallback): Cleanup as described above. (firstRectForCharacterRangeCallback): Cleanup as described above. (selectedRangeCallback): Cleanup as described above.
- 4:04 PM Changeset in webkit [88497] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 Kenneth Russell <kbr@google.com>
Skipped new tests from r88489 on WebKit Win, since WebGL is not yet enabled.
- platform/win/Skipped:
- 3:53 PM Changeset in webkit [88496] by
-
- 6 edits3 adds in trunk
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
Tests that a layer that should clip its children actually does clip even when scrolled offscreen.
- platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
- platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
- platform/chromium/compositing/scissor-out-of-viewport.html: Added.
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.
This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.
Test: platform/chromium/compositing/scissor-out-of-viewport.html
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::setUsesLayerScissor): (WebCore::CCLayerImpl::usesLayerScissor):
- 3:53 PM Changeset in webkit [88495] by
-
- 5 edits in trunk/Source/WebKit/chromium
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88486.
http://trac.webkit.org/changeset/88486
https://bugs.webkit.org/show_bug.cgi?id=62409
Broke chromium-win compile (Requested by jamesr on #webkit).
- public/WebData.h:
- public/WebPageSerializer.h:
- src/WebData.cpp:
- src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
- 3:53 PM Changeset in webkit [88494] by
-
- 5 edits in branches/safari-534-branch/Source
Versioning.
- 3:49 PM Changeset in webkit [88493] by
-
- 1 copy in tags/Safari-534.45
New tag.
- 3:44 PM Changeset in webkit [88492] by
-
- 6 edits2 copies in branches/safari-534-branch
Merge r88468.
- 3:30 PM Changeset in webkit [88491] by
-
- 2 edits in branches/safari-534-branch/Source/WebCore
Merge r88475.
- 3:23 PM Changeset in webkit [88490] by
-
- 6 edits2 deletes in trunk
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408
It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).
- fullscreen/full-screen-video-offset-expected.txt: Removed.
- fullscreen/full-screen-video-offset.html: Removed.
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408
It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).
- dom/Element.cpp: (WebCore::adjustForLocalZoom):
- dom/Element.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- 3:02 PM Changeset in webkit [88489] by
-
- 12 edits6 adds in trunk
2011-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Adam Barth.
Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257
Updated WebGL implementation to track recent spec updates in this area.
Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
- html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): (WebCore::CanvasRenderingContext::checkOrigin):
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::checkOrigin):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
- html/canvas/WebGLRenderingContext.h:
2011-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Adam Barth.
Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257
Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.
Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.
- http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
- http/tests/canvas/webgl/origin-clean-conformance.html:
- http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
- http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
- http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
- http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
- http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
- http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- 2:55 PM Changeset in webkit [88488] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an ASSERT to HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=62403
This ASSERT was useful in investigating a re-entrancy bug. We should
keep it.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 2:48 PM Changeset in webkit [88487] by
-
- 2 edits in trunk/Source/WebCore
Fix a regression from r88478.
Reviewed by Darin Adler.
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
afterwards.
- 2:45 PM Changeset in webkit [88486] by
-
- 5 edits in trunk/Source/WebKit/chromium
2011-06-09 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Page serializer APIs now use WebData instead of fetching the entire
resource contents.
https://bugs.webkit.org/show_bug.cgi?id=61908
- public/WebData.h:
- public/WebPageSerializer.h:
- src/WebData.cpp: (WebKit::WebData::getSomeData):
- src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serialize): (WebKit::WebPageSerializer::serializeToMHTML):
- 2:24 PM Changeset in webkit [88485] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Mark tests failing after http://trac.webkit.org/changeset/88478/ as failing.
- platform/chromium/test_expectations.txt: Added failing tests.
- 2:19 PM Changeset in webkit [88484] by
-
- 2 edits in branches/safari-534-branch/Source/WebKit2
Merge r88401.
- 2:18 PM Changeset in webkit [88483] by
-
- 2 edits in trunk/Tools
2011-06-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: support webaudio in chromium driver
https://bugs.webkit.org/show_bug.cgi?id=62226
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 2:11 PM Changeset in webkit [88482] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-09 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update expectations.
- platform/chromium-linux/plugins/mouse-events-expected.txt: Added.
- platform/chromium-win/fullscreen/full-screen-video-offset-expected.txt: Added.
- 2:06 PM Changeset in webkit [88481] by
-
- 2 edits in branches/safari-534-branch/Source/WebCore
Merge r88279.
- 1:53 PM Changeset in webkit [88480] by
-
- 4 edits in trunk/LayoutTests
2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by James Robinson.
Web Inspector: Inspector layout tests - extract method for sending XHR
https://bugs.webkit.org/show_bug.cgi?id=62391
- http/tests/inspector/console-xhr-logging.html:
- http/tests/inspector/network-test.js: (doXHR.xhr.onreadystatechange): (doXHR):
- http/tests/inspector/network/network-size-sync.html:
- 1:33 PM Changeset in webkit [88479] by
-
- 5 edits2 adds in trunk
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Adding test to cover the regression. The test actually uncovered
a bug in the way we handle alternate stylesheet and thus is
failing some parts.
- fast/css/link-disabled-attr-expected.txt: Added.
- fast/css/link-disabled-attr.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Test: fast/css/link-disabled-attr.html
Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!
The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.
- dom/Document.cpp: (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState, replaced by m_isEnabledViaScript. (WebCore::HTMLLinkElement::setDisabled): Updated the logic after m_disabledState removal. It also matches the spec by forwarding the disabled state to our stylesheet if we have one. (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful handling of the disabledAttr. (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto. (WebCore::HTMLLinkElement::isAlternate): Ditto.
- 1:30 PM Changeset in webkit [88478] by
-
- 2 edits in trunk/Source/WebCore
Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387
Reviewed by Darin Adler.
No new test, since functionality is unchanged.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
then reverse the run vector for RTL.
- 1:29 PM Changeset in webkit [88477] by
-
- 5 edits1 add in trunk
Source/JavaScriptCore: Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393
Reviewed by Anders Carlsson.
- wtf/Vector.h:
(WTF::Vector::reverse): Added
Tools: Added a test for Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
(TestWebKitAPI::TEST):
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 1:24 PM Changeset in webkit [88476] by
-
- 13 edits in trunk/Source/WebCore
2011-06-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Fold isShadowBoundary into isShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=62317
Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
Refactoring, covered by existing tests.
- css/CSSStyleSelector.cpp: (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
- dom/Element.cpp: (WebCore::Element::isSpellCheckingEnabled): Ditto.
- dom/Node.cpp: (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto. (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
- dom/Node.h: (WebCore::Node::isContentElement): Added.
- dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
- dom/Position.cpp: (WebCore::Position::Position): Ditto.
- dom/ShadowContentElement.h: (WebCore::ShadowContentElement::isContentElement): Added.
- dom/ShadowRoot.cpp: (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
- editing/htmlediting.cpp: (WebCore::visiblePositionBeforeNode): Ditto. (WebCore::visiblePositionAfterNode): Ditto.
- page/DragController.cpp: (WebCore::asFileInput): Ditto.
- rendering/RenderTreeAsText.cpp: (WebCore::nodePosition): Ditto.
- 1:05 PM Changeset in webkit [88475] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159
Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
- 12:52 PM Changeset in webkit [88474] by
-
- 3 edits2 adds in trunk
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
- fast/css/webkit-keyframes-crash-expected.txt: Added.
- fast/css/webkit-keyframes-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
- css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed to return a non-null pointer. Thus null-check here like the rest of the code.
- 12:44 PM Changeset in webkit [88473] by
-
- 10 edits in trunk/Source/JavaScriptCore
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored a bunch of Heap functionality into stand-alone functors
https://bugs.webkit.org/show_bug.cgi?id=62337
This is in preparation for making these functors operate on arbitrary
sets of MarkedBlocks.
- JavaScriptCore.exp: This file is a small tragedy.
- debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Updated for type change and rename.
- heap/HandleHeap.h: (JSC::HandleHeap::forEachStrongHandle): New function for iterating all strong handles, so we can play along in the functor game.
- heap/Heap.cpp: (JSC::CountFunctor::CountFunctor::CountFunctor): (JSC::CountFunctor::CountFunctor::count): (JSC::CountFunctor::CountFunctor::returnValue): (JSC::CountFunctor::ClearMarks::operator()): (JSC::CountFunctor::ResetAllocator::operator()): (JSC::CountFunctor::Sweep::operator()): (JSC::CountFunctor::MarkCount::operator()): (JSC::CountFunctor::Size::operator()): (JSC::CountFunctor::Capacity::operator()): (JSC::CountFunctor::Count::operator()): (JSC::CountFunctor::CountIfGlobalObject::operator()): (JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty): (JSC::CountFunctor::TakeIfEmpty::operator()): (JSC::CountFunctor::TakeIfEmpty::returnValue): (JSC::CountFunctor::RecordType::RecordType): (JSC::CountFunctor::RecordType::typeName): (JSC::CountFunctor::RecordType::operator()): (JSC::CountFunctor::RecordType::returnValue): These functors factor out behavior that used to be in the functions below.
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Factored out behavior into the functors above.
- heap/Heap.h: (JSC::Heap::forEachProtectedCell): (JSC::Heap::forEachCell): (JSC::Heap::forEachBlock): Added forEach* iteration templates. I chose functor-based templates instead of plain iterators because they're simpler to implement in this case and they require a lot less code at the call site.
- heap/MarkedBlock.h: (JSC::MarkedBlock::VoidFunctor::returnValue): Default parent class for trivial functors.
(JSC::MarkedBlock::forEachCell): Renamed forEach to forEachCell because
we have a few different kind of "for each" now.
- runtime/JSGlobalData.cpp: (WTF::Recompile::operator()): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::recompileAllJSFunctions): Updated for type change and rename.
- runtime/JSGlobalData.h: Removed globalObjectCount because it was unused.
- 12:41 PM Changeset in webkit [88472] by
-
- 3 edits4 adds in trunk
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by David Hyatt.
Test for chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756
- fast/css/fontMetric-border-radius-null-crash-expected.txt: Added.
- fast/css/fontMetric-border-radius-null-crash.html: Added.
- fast/css/fontMetric-webkit-border-end-width-null-crash-expected.txt: Added.
- fast/css/fontMetric-webkit-border-end-width-null-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by David Hyatt.
chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756
Tests: fast/css/fontMetric-border-radius-null-crash.html
fast/css/fontMetric-webkit-border-end-width-null-crash.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update so that our FontFallbackList is allocated if we ever need it when applying our style rules.
- 12:30 PM Changeset in webkit [88471] by
-
- 5 edits2 deletes in trunk
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove a cr-linux expectation that no longer differs from the default
expectation.
- platform/chromium-linux/plugins/mouse-events-expected.txt: Removed.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (keyEventToChar): Added this helper which converts a X11 keycode into a char. (handleEventX11): Use the handler to properly convert the keycode. Do not print adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus it should not be in the results. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
- GNUmakefile.am: Update source list.
- 12:02 PM Changeset in webkit [88470] by
-
- 2 edits in trunk/Source/WebKit2
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
https://bugs.webkit.org/show_bug.cgi?id=62386
- Platform/CoreIPC/Connection.h:
- 11:51 AM Changeset in webkit [88469] by
-
- 4 edits in trunk/Source/WebCore
2011-06-09 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213
When building Mac Chrome using Skia as the WebKit renderer,
add state to LocalCurrentGraphicsContext to convert the SkCanvas
context passed by WebKit into the CGContext needed by UI
rendering.
No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.
- platform/mac/LocalCurrentGraphicsContext.h: Add SkiaBitLocker to create and release the converted CGContext. Add ContextContainer, a class for Skia to create and release the converted CGContext. If Skia is not used, the class has no effect.
- platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): When building with Skia, create the CGContext before passing it on.
(WebCore::LocalCurrentGraphicsContext::cgContext):
Get the CGContext from the SkiaBitLocker, or the saved context,
as appropriate.
- rendering/RenderThemeMac.mm: Get the CGContext from Skia conversion or native, as appropriate. Use the LocalCurrentGraphicsContext if there is one. Otherwise, add a ContextContainer to house the SkCanvas to CGContext conversion.
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
- 11:47 AM Changeset in webkit [88468] by
-
- 6 edits2 adds in trunk
2011-06-02 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>
- fullscreen/full-screen-video-offset-expected.txt: Added.
- fullscreen/full-screen-video-offset.html: Added.
2011-06-02 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/9523017>
Test: fullscreen/full-screen-video-offset.html
When the video element is taken full-screen in the new element full-screen API, return the
offset width and height of the placeholder renderer which is filling in for the full-screen
element. To do so, override offsetWidth, Height, Left, and Top from Element. These are
non-virtual functions, so make them virtual.
- dom/Element.cpp: (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
- dom/Element.h: Made offset functions virtual.
- html/HTMLMediaElement.cpp: (WebCore::elementPlaceholder): Added; utility function. (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the
Element function. Will be called directly via javascript.
(WebCore::HTMLMediaElement::offsetTop): Ditto.
(WebCore::HTMLMediaElement::offsetWidth): Ditto.
(WebCore::HTMLMediaElement::offsetHeight): Ditto.
- html/HTMLMediaElement.h:
- 11:26 AM Changeset in webkit [88467] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 Chang Shu <cshu@webkit.org>
Unreviewed.
Unskip more passed tests after r88461 (bug 62381).
- platform/qt-wk2/Skipped:
- 11:21 AM Changeset in webkit [88466] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
2011-06-09 Bill Budge <bbudge@chromium.org>
Reviewed by Adam Barth.
The AssociatedURLLoader returns URL access errors synchronously. Use a timer to return such errors asynchronously. Also add unit tests for successful loads, same-origin restriction by default, and successful cross-origin loads.
https://bugs.webkit.org/show_bug.cgi?id=60059
- WebKit.gyp:
- WebKit.gypi:
- src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::ClientAdapter::enableErrorNotifications): (WebKit::AssociatedURLLoader::ClientAdapter::notifyError): (WebKit::AssociatedURLLoader::loadAsynchronously):
- tests/AssociatedURLLoaderTest.cpp: Added. (WebKit::TestWebFrameClient::cancelledError): (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): (WebKit::AssociatedURLLoaderTest::SetUp): (WebKit::AssociatedURLLoaderTest::TearDown): (WebKit::AssociatedURLLoaderTest::serveRequests): (WebKit::AssociatedURLLoaderTest::createAssociatedURLLoader): (WebKit::AssociatedURLLoaderTest::willSendRequest): (WebKit::AssociatedURLLoaderTest::didSendData): (WebKit::AssociatedURLLoaderTest::didReceiveResponse): (WebKit::AssociatedURLLoaderTest::didDownloadData): (WebKit::AssociatedURLLoaderTest::didReceiveData): (WebKit::AssociatedURLLoaderTest::didReceiveCachedMetadata): (WebKit::AssociatedURLLoaderTest::didFinishLoading): (WebKit::AssociatedURLLoaderTest::didFail): (WebKit::TEST_F):
- 11:21 AM Changeset in webkit [88465] by
-
- 2 edits in trunk/Tools
2011-06-09 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Tony Chang.
Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721
The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
calls to mean the plugin handled the event.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Return 0 for each event on windows.
- 11:19 AM Changeset in webkit [88464] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-06-09 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB test: behavior of undefined value in record
https://bugs.webkit.org/show_bug.cgi?id=62371
- storage/indexeddb/value-undefined-expected.txt: Added.
- storage/indexeddb/value-undefined.html: Added.
- 11:16 AM Changeset in webkit [88463] by
-
- 22 edits2 deletes in trunk/Source/WebKit2
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Remove usage of deprecated CoreIPC functions.
https://bugs.webkit.org/show_bug.cgi?id=62290
Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
and guarded by ENABLE(TILED_BACKING_STORE).
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
- GNUmakefile.am:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj: Prune deleted files from build system.
- Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete, this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::invalidate): (WebKit::DrawingAreaProxy::snapshotTaken): (WebKit::DrawingAreaProxy::tileUpdated): (WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by TiledDrawingAreaProxy to DrawingAreaProxy.
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): (WebKit::DrawingArea::cancelTileUpdate): (WebKit::DrawingArea::requestTileUpdate): (WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea to DrawingArea.
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage() and didReceiveSyncMessage().
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
- UIProcess/TiledDrawingAreaProxy.h:
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::sizeDidChange): (WebKit::TiledDrawingAreaProxy::tileUpdated): (WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage() into functions.
(WebKit::TiledDrawingAreaProxy::removeTile):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.
- WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::cancelTileUpdate): (WebKit::TiledDrawingArea::requestTileUpdate): (WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaProxyLegacy.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceiveMessage): Remove handling of CoreIPC::MessageClassDrawingAreaLegacy.
- UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
- WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make CoreIPC message handlers explicitly virtual.
- 11:14 AM Changeset in webkit [88462] by
-
- 3 edits in trunk/Source/WebKit2
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: Generate correct header conditionals in message receivers.
https://bugs.webkit.org/show_bug.cgi?id=62379
Given a *.messages.in file like this:
Foo(AwesomeObject o)
#if ENABLE(ESOTERIC_FEATURE)
Bar(AwesomeObject o)
#endif
messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
This breaks the build on platforms without that defined.
Furthermore, if two messages guarded by different conditionals both pull in the same
header, only the last conditional will be applied, for example:
#if ENABLE(ESOTERIC_FEATURE)
Foo(AwesomeObject o)
#endif
#if ENABLE(MYSTERIOUS_FEATURE)
Bar(AwesomeObject o)
#endif
Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should
check #if ENABLE(ESOTERIC_FEATURE) ENABLE(MYSTERIOUS_FEATURE). Change the generator to consider all conditionals for a given header file.
Also consider conditionals for reply parameters.
- Scripts/webkit2/messages.py:
- Scripts/webkit2/messages_unittest.py:
- 11:09 AM Changeset in webkit [88461] by
-
- 4 edits in trunk
2011-06-09 Chang Shu <cshu@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Unskip passed tests.
- platform/qt-wk2/Skipped:
2011-06-09 Chang Shu <cshu@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
QWKPagePrivate::isViewFocused() will check it later.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
- 11:05 AM Changeset in webkit [88460] by
-
- 7 edits in branches/chromium/782/Source
Merge 88396 - 2011-06-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Mihai Parparita.
Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756
Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X.
- wtf/Platform.h:
2011-06-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Mihai Parparita.
Chromium Mac: Enable overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=59756
Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
No new tests, since this code is only enabled on future versions of Mac OS X.
- platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7134051
- 11:04 AM Changeset in webkit [88459] by
-
- 5 edits2 copies in branches/chromium/782/Source/WebCore
Merge 88286 - 2011-06-07 Sailesh Agrawal <sail@chromium.org>
Reviewed by Mihai Parparita.
Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
https://bugs.webkit.org/show_bug.cgi?id=59753
No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
- WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
- WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
- platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
- platform/chromium/ScrollAnimatorChromiumMac.h: Added. (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer): (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
- platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled. (abs): (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]): (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]): (-[ScrollAnimationHelperDelegate bounds]): (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]): (-[ScrollAnimationHelperDelegate convertSizeToBase:]): (-[ScrollAnimationHelperDelegate convertSizeFromBase:]): (-[ScrollAnimationHelperDelegate convertSizeToBacking:]): (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]): (-[ScrollAnimationHelperDelegate superview]): (-[ScrollAnimationHelperDelegate documentView]): (-[ScrollAnimationHelperDelegate window]): (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]): (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPartAnimation setCurrentProgress:]): (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]): (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate convertRectToBacking:]): (-[ScrollbarPainterDelegate convertRectFromBacking:]): (-[ScrollbarPainterDelegate layer]): (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::scroll): (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): (WebCore::elasticDeltaForTimeDelta): (WebCore::elasticDeltaForReboundDelta): (WebCore::reboundDeltaForElasticDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent): (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent): (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection): (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching): (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching): (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::endScrollGesture): (WebCore::ScrollAnimatorChromiumMac::snapRubberBand): (WebCore::roundTowardZero): (WebCore::roundToDevicePixelTowardZero): (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired): (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired): (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
- platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7044088
- 10:49 AM Changeset in webkit [88458] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Dave Tapuska <dtapuska@rim.com>
Reviewed by Daniel Bates.
PingLoader destructor could dereference 0 if the Resource
Handle creation failed.
- loader/PingLoader.cpp: (WebCore::PingLoader::~PingLoader):
- 9:20 AM Changeset in webkit [88457] by
-
- 5 edits in trunk/Source/WebKit/chromium
2011-06-09 Nico Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make a few destructors private.
https://bugs.webkit.org/show_bug.cgi?id=62341
No intended functionality change.
- src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
- src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
- src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
- src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
- 9:15 AM Changeset in webkit [88456] by
-
- 5 edits2 adds in trunk
2011-06-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Make indexForVisiblePosition and isSelectableElement static.
https://bugs.webkit.org/show_bug.cgi?id=62329
This protects us when converting frame->selection->start() or end()
to VisiblePosition which blows away the RenderTextControl from
underneath (due to layout update).
Test: fast/forms/text-control-selection-crash.html
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::indexForVisiblePosition):
- rendering/RenderTextControl.h:
2011-06-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Tests that setting selection on a text control does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62329
- fast/forms/text-control-selection-crash-expected.txt: Added.
- fast/forms/text-control-selection-crash.html: Added.
- 9:05 AM Changeset in webkit [88455] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-06-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix the in-tree build on Linux
https://bugs.webkit.org/show_bug.cgi?id=62378
In case of an in-tree build qmake generates defect prl dependencies for
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
- QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
- 8:52 AM Changeset in webkit [88454] by
-
- 3 edits in trunk/Source/WebCore
2011-06-09 Ben Murdoch <benm@google.com>
Reviewed by Yury Semikhatsky.
Build break in ScriptProfile.cpp and inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=62373
No new tests - build fix only.
- bindings/v8/ScriptProfile.cpp: Add necessary guards.
- bindings/v8/ScriptProfile.h: ditto.
- 8:19 AM Changeset in webkit [88453] by
-
- 2 edits in trunk/Source/WebCore
2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
https://bugs.webkit.org/show_bug.cgi?id=62298
- inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback): (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
- 7:53 AM Changeset in webkit [88452] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed fix after r88447.
- platform/qt/Skipped:
- 7:44 AM Changeset in webkit [88451] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Mac] Speculative buildfix after r88286.
- platform/graphics/IntPoint.h:
- 7:28 AM Changeset in webkit [88450] by
-
- 2 edits in trunk/LayoutTests
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
- platform/qt/Skipped: Add inspector/profiler/detailed-heapshots-comparison-show-next.html.
- 7:24 AM Changeset in webkit [88449] by
-
- 2 edits in trunk/LayoutTests
[WK2] eventSender.keyDown is unimplemented
- platform/mac-wk2/Skipped: Add fast/dom/shadow/tab-order-iframe-and-shadow.html.
- 7:12 AM Changeset in webkit [88448] by
-
- 3 edits2 adds in trunk
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
- css3/calc/regression-62276-expected.txt: Added.
- css3/calc/regression-62276.html: Added.
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
Test: css3/calc/regression-62276.html
- css/CSSParser.cpp: (WebCore::CSSParser::lex):
- 7:11 AM Changeset in webkit [88447] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r88393): Tests fail on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=62374
- platform/qt/Skipped: Add editing/selection/move-by-word-visually-others.html and
editing/selection/move-by-word-visually-single-space-sigle-line.html until fix.
- 7:06 AM Changeset in webkit [88446] by
-
- 11 edits in trunk
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
Unskip fast/harness/internals-object.html
- platform/qt/Skipped:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
- CodeGenerators.pri:
- WebCore.pri:
- WebCore.pro:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::injectInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::initJSObjects):
- 6:54 AM Changeset in webkit [88445] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427
- platform/qt-wk2/Skipped: Unskip passing tests after r88435.
- 5:42 AM Changeset in webkit [88444] by
-
- 5 edits in trunk/Source
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export 2 functions DecimalNumber::bufferLengthForStringExponential and DecimalNumber::toStringExponential.
- 5:09 AM Changeset in webkit [88443] by
-
- 9 edits6 deletes in trunk
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368
New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).
- http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
- http/tests/canvas/webgl/origin-clean-conformance.html:
- http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Removed.
- http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Removed.
- http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Removed.
- http/tests/security/webgl-remote-read-remote-image-allowed.html: Removed.
- http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Removed.
- http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Removed.
- platform/mac-wk2/Skipped:
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368
New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).
- html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
- html/canvas/CanvasRenderingContext.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
- html/canvas/WebGLRenderingContext.h:
- 4:56 AM Changeset in webkit [88442] by
-
- 2 edits in trunk/LayoutTests
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
- platform/qt/Skipped: Skip 3 inspector tests to make buildbot happy.
- 4:10 AM Changeset in webkit [88441] by
-
- 3 edits in trunk/LayoutTests
2011-06-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: New flakiness in styles tests
https://bugs.webkit.org/show_bug.cgi?id=62309
- inspector/styles/styles-disable-then-change.html:
- inspector/styles/styles-source-lines-inline.html:
- 3:26 AM Changeset in webkit [88440] by
-
- 2 edits5 adds in trunk/Source/WebKit2
2011-06-09 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
https://bugs.webkit.org/show_bug.cgi?id=62363
- UIProcess/API/efl/PageClientImpl.cpp: Added. (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::~PageClientImpl): (WebKit::PageClientImpl::createDrawingAreaProxy): (WebKit::PageClientImpl::setViewNeedsDisplay): (WebKit::PageClientImpl::displayView): (WebKit::PageClientImpl::scrollView): (WebKit::PageClientImpl::viewSize): (WebKit::PageClientImpl::isViewWindowActive): (WebKit::PageClientImpl::isViewFocused): (WebKit::PageClientImpl::isViewVisible): (WebKit::PageClientImpl::isViewInWindow): (WebKit::PageClientImpl::processDidCrash): (WebKit::PageClientImpl::didRelaunchProcess): (WebKit::PageClientImpl::pageClosed): (WebKit::PageClientImpl::toolTipChanged): (WebKit::PageClientImpl::setCursor): (WebKit::PageClientImpl::setViewportArguments): (WebKit::PageClientImpl::registerEditCommand): (WebKit::PageClientImpl::clearAllEditCommands): (WebKit::PageClientImpl::canUndoRedo): (WebKit::PageClientImpl::executeUndoRedo): (WebKit::PageClientImpl::convertToDeviceSpace): (WebKit::PageClientImpl::convertToUserSpace): (WebKit::PageClientImpl::windowToScreen): (WebKit::PageClientImpl::doneWithKeyEvent): (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::setFindIndicator): (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation): (WebKit::PageClientImpl::customRepresentationZoomFactor): (WebKit::PageClientImpl::setCustomRepresentationZoomFactor): (WebKit::PageClientImpl::flashBackingStoreUpdates): (WebKit::PageClientImpl::findStringInCustomRepresentation): (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation): (WebKit::PageClientImpl::userSpaceScaleFactor):
- UIProcess/API/efl/PageClientImpl.h: Added. (WebKit::PageClientImpl::create): (WebKit::PageClientImpl::viewObject): (WebKit::PageClientImpl::page):
- UIProcess/WebPageProxy.h:
- UIProcess/efl/WebPageProxyEfl.cpp: Added. (WebKit::WebPageProxy::viewObject): (WebKit::WebPageProxy::standardUserAgent): (WebKit::WebPageProxy::getEditorCommandsForKeyEvent): (WebKit::WebPageProxy::saveRecentSearches): (WebKit::WebPageProxy::loadRecentSearches):
- 3:06 AM Changeset in webkit [88439] by
-
- 1 edit1 add in trunk/LayoutTests
2011-06-09 Kent Tamura <tkent@chromium.org>
[Chromium] Leopard rebaseline for thumbslider-no-parent-slider.html.
- platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Added.
- 2:39 AM Changeset in webkit [88438] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 Ryosuke Niwa <rniwa@webkit.org>
More Chromium Mac test expectation updates.
- platform/chromium/test_expectations.txt:
- 2:36 AM Changeset in webkit [88437] by
-
- 2 edits in trunk/Tools
2011-06-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
https://bugs.webkit.org/show_bug.cgi?id=62362
The mac bots are failing inspector tests. We don't know why yet.
So for now, turning run-webkit-tests off for the mac-ews.
Also noticed that due to the wrong variable name the cr-linux
bots weren't running tests!
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- 2:21 AM Changeset in webkit [88436] by
-
- 2 edits in trunk/LayoutTests
2011-06-09 Ryosuke Niwa <rniwa@webkit.org>
Chromium Mac test expectation updates.
- platform/chromium/test_expectations.txt:
- 1:47 AM Changeset in webkit [88435] by
-
- 4 edits in trunk
[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-09
Reviewed by Csaba Osztrogonac.
Tools:
Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
Since the Qt port should eventually go to QRawFont, this issue will be resolved
in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
needed for the workaround.
- WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WTR::LayoutTestController::platformInitialize):
LayoutTests:
Unskipping canvas tests for WebKit2-Qt.
- platform/qt-wk2/Skipped:
- 1:41 AM Changeset in webkit [88434] by
-
- 3 edits2 adds in trunk
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
- fast/parser/document-write-onload-clear-expected.txt: Added.
- fast/parser/document-write-onload-clear.html: Added.
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.
Test: fast/parser/document-write-onload-clear.html
- html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
- 12:42 AM Changeset in webkit [88433] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-06-09 James Robinson <jamesr@chromium.org>
Fix chromium build on build.webkit.org builders.
- features.gypi:
- 12:35 AM Changeset in webkit [88432] by
-
- 7 edits4 adds in trunk
2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855
New layout test and expected results to check the new function.
- accessibility/platform-name.html: Added.
- platform/gtk/accessibility/platform-name-expected.txt: Added.
- platform/mac/accessibility/platform-name-expected.txt: Added.
- platform/win/accessibility/platform-name-expected.txt: Added.
2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855
Patch for adding 'platformName' static property to DRT's
LayoutController and provide platform specific implementations.
In principle, this feature will be only of interest for writing
accessibility tests, so that's why it's only implemented in the
Mac, Gtk and Win platforms.
- DumpRenderTree/LayoutTestController.h: New method platformName().
- DumpRenderTree/LayoutTestController.cpp: (getPlatformNameCallback): New callback for 'platformName'. (LayoutTestController::staticValues): New static property.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::platformName): Implemented.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::platformName): Implemented.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::platformName): Implemented.
