Timeline



Jul 18, 2011:

10:33 PM Changeset in webkit [91239] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Solar Walk app-specific hack accidentally strips stylesheets from the document.
​https://bugs.webkit.org/show_bug.cgi?id=64777

Reviewed by Adam Barth.

Solar Walk uses a self-closed title tag in its documents ("<title />").
The HTML5 parser does not recognize this as a valid self-closing tag,
so it treats the remainder of the document as title text.

We work around this in WebKit by injecting a script that calls
document.write() on the contents of document.title, thereby restoring
the contents of the document. Unfortunately this overwrote several
<style> tags that existed before the <title>, thereby causing the
document to not have the intended styling.

Fix this by having the injected script concatenate document.title to
the document instead of overwriting it during document.write(). We can
also take the opportunity to remove document.title since it does not
contain useful information.

  • Misc/SolarWalkQuirksUserScript.js:
10:04 PM Changeset in webkit [91238] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:14 PM Changeset in webkit [91237] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=64767

Add a runtime check for font cascading optimization.

It's a constant value in Mac port so hopefully gcc will constant-propagate the value
and eliminate the function altogether.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::canSetCascadeListForCustomFont): Added.
(WebCore::FontPlatformData::ctFont):

9:03 PM Changeset in webkit [91236] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update after r91229.

  • platform/chromium/test_expectations.txt:
7:55 PM Changeset in webkit [91235] by morrita@google.com
  • 23 edits
    2 adds in trunk

.: [ShadowContentElement] forwarded node should be able to access its hosting content element.
​https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Added GTK symbols for new window.internals methods.

  • Source/autotools/symbols.filter:

Source/WebCore: [ShadowContentElement] forwarded node should be able to access its hosting content element.
​https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Introduced ShadowInclusionSet to manage included nodes to its includer content element. ShadowInclusionSet instance is owned by ShadowRoot.
  • Updated the set on inclusion list changes.
  • Used the set to retrieve the content element of NodeRenderingContext.

There are also related refactoring and cleanup:

  • Renamed NodeRenderingContext::m_contentElement to m_includer
  • ShadowContentSelector::m_activeElement is no longer used, thus removed.

Test: fast/dom/shadow/content-element-includer.html

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::includer):

  • dom/ShadowContentElement.cpp:

(WebCore::removeFromSet):
(WebCore::addToSet):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:

(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):

  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):

  • dom/ShadowRoot.h:

(WebCore::toShadowRoot):

  • testing/Internals.cpp:

(WebCore::Internals::includerFor):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2: [ShadowContentElement] forwarded node should be able to access its hosting content element.
​https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

Exported additional symbols for window.internals object.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: [ShadowContentElement] forwarded node should be able to access its hosting content element.
​https://bugs.webkit.org/show_bug.cgi?id=64251

Reviewed by Dimitri Glazkov.

  • Added a new test.
  • Updated expectations. This change make ShadowContentElement availability on NodeRenderingContext more strict. that makes some redundant node disappeared.
  • fast/dom/shadow/content-element-includer-expected.txt: Added.
  • fast/dom/shadow/content-element-includer.html: Added.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
7:42 PM Changeset in webkit [91234] by barraclough@apple.com
  • 13 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2011-07-18

  • platform/chromium/test_expectations.txt:
7:25 PM Changeset in webkit [91233] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Tab Atkins is not in committers.py (as a non-committer)
​https://bugs.webkit.org/show_bug.cgi?id=64770

Patch by Tab Atkins <​jackalmage@gmail.com> on 2011-07-18
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
7:21 PM Changeset in webkit [91232] by dino@apple.com
  • 20 edits in trunk/Source

2011-07-18 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=64742
Expose WebPreferences for media playback requiring user gestures and inline playback

Reviewed by Simon Fraser.

Media playback already tested if it should require user gestures, but
no setting was ever exposed to clients. Also, some ports only allow media
playback to be fullscreen, so exposing a new setting for them.

Two new WebPreferences: MediaPlaybackRequiresUserGesture and
MediaPlaybackAllowsInline.

WebCore:

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Examine the new Setting for user gestures.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Two new settings. (WebCore::Settings::setMediaPlaybackRequiresUserGesture): (WebCore::Settings::mediaPlaybackRequiresUserGesture): (WebCore::Settings::setMediaPlaybackAllowsInline): (WebCore::Settings::mediaPlaybackAllowsInline):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences mediaPlaybackRequiresUserGesture]): (-[WebPreferences setMediaPlaybackRequiresUserGesture:]): (-[WebPreferences mediaPlaybackAllowsInline]): (-[WebPreferences setMediaPlaybackAllowsInline:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChanged:]):

WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setMediaPlaybackRequiresUserGesture): (WebPreferences::mediaPlaybackRequiresUserGesture): (WebPreferences::setMediaPlaybackAllowsInline): (WebPreferences::mediaPlaybackAllowsInline):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMediaPlaybackRequiresUserGesture): (WKPreferencesGetMediaPlaybackRequiresUserGesture): (WKPreferencesSetMediaPlaybackAllowsInline): (WKPreferencesGetMediaPlaybackAllowsInline):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
6:42 PM Changeset in webkit [91231] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Leopard build fix after r91229.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont):

6:25 PM Changeset in webkit [91230] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a failing test expectation for object-prototype-properties.html after r91225.

  • platform/chromium/test_expectations.txt:
6:21 PM Changeset in webkit [91229] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(91209?): fast/css/custom-font-xheight.html is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=64767

Reviewed by Sam Weinig.

  • platform/graphics/Font.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Undo the cascade list optimization on Leopard for custom
fonts, because adding a cascade list apparently breaks the font.

5:54 PM Changeset in webkit [91228] by mdelaney@apple.com
  • 9 edits in trunk/Source/WebCore

Remove drawsUsingCopy now that all ports handle the copying
​https://bugs.webkit.org/show_bug.cgi?id=64768

Introduced in ​https://bugs.webkit.org/show_bug.cgi?id=43507, ImageBuffer::drawsUsingCopy
was used to know whether or not an ImageBuffer should be explicitly copied before being
painted into a context (as was used in HTMLCanvasElement::paint). All platforms now
handle the logic of copying or not in their ImageBuffer::draw() implementations, so
drawsUsingCopy() is no longer needed. This patch removes it.

Reviewed by Dan Bernstein.

No new tests; does not affect behavior.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::isAccelerated):

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:
5:39 PM Changeset in webkit [91227] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Resource preserving fails when frameNavigated event is dispatched on NetworkPanel.
​https://bugs.webkit.org/show_bug.cgi?id=64748

Reviewed by Pavel Feldman.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

5:36 PM Changeset in webkit [91226] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize strict equality as effectively as the old JIT does.
​https://bugs.webkit.org/show_bug.cgi?id=64759

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

This adds a more complete set of strict equality optimizations. If either
operand is known numeric, then the code reverts to the old style of optimizing
(first try integer comparison). Otherwise it uses the old JIT's trick of
first simultaneously checking if both operands are either numbers or cells;
if not then a fast path is taken.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:26 PM Changeset in webkit [91225] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=64760
DFG JIT - Should be able to compile program code.

Reviewed by Geoff Garen.

Add support for op_end, hooks to compile program code in Executable.cpp.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • Add support for op_end
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

  • Added, separate out steps of compileFunction.

(JSC::DFG::JITCompiler::compile):

  • Added, compile program code.

(JSC::DFG::JITCompiler::compileFunction):

  • Sections separated out to helper functions.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):

  • Added m_exceptionCheckCount.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):

  • Renamed tryDFGCompile to tryDFGCompileFunction, added tryDFGCompile to compile program code.
5:25 PM Changeset in webkit [91224] by barraclough@apple.com
  • 8 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=64678
Fix bugs in Object.prototype this handling.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

undefined/null this values should throw TypeErrors, not convert to the global object,
also, to toLocaleString should be calling the ToObject & invoking the object's toString
function, even for values that are already strings.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

LayoutTests:

  • fast/js/resources/js-test-pre.js:
    • Updated harness to not call Object.prototype.toString on undefined.
  • fast/js/eval-var-decl-expected.txt:
  • fast/js/object-prototype-properties-expected.txt: Added.
  • fast/js/object-prototype-properties.html: Added.
  • fast/js/object-prototype-toLocaleString-expected.txt
  • fast/js/script-tests/eval-var-decl.js:
    • Fix test case, calling hasProperty with undefined as the this value should throw.
  • fast/js/script-tests/object-prototype-properties.js: Added.
    • Place for test cases for Object.prototype properties; to being with, check that calling these methods on undefined throws!
  • fast/js/script-tests/object-prototype-toLocaleString.js:
    • Added test cases for correct behaviour when this is a string primitive.
  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
    • These test cases are all incorrect. (See ​https://bugs.ecmascript.org/show_bug.cgi?id=117). We were incorrectly passing 15.5.4.11_String.prototype.replace, this should fail, as the others do. All the other 15.5.4 tests were failing & are still failing, but now have a better error message. S11.1.1_A2 is also invalid, calling toString() passing undefined as this should throw.
5:20 PM Changeset in webkit [91223] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a typo.

  • platform/chromium/test_expectations.txt:
5:14 PM Changeset in webkit [91222] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebCore

Prep work for: Crash under WebPage::platformDragEnded when dragging on Mac
​https://bugs.webkit.org/show_bug.cgi?id=64766
<rdar://problem/9548174>

Reviewed by Darin Adler.

Add a DragClient function that is called when a drag is ended, and call it from DragController::dragEnded.
This isn't used yet, but will be used by WebKit2 on Mac.

This patch also cleans up style in DragClient.h.

No change in behavior, no tests needed.

  • page/DragClient.h:

(WebCore::DragClient::dragEnded): Stub virtual implementation for now, this will be used by

WebKit2 on Mac.

  • page/DragController.cpp:

(WebCore::DragController::dragEnded): Call DragClient::dragEnded.

4:59 PM Changeset in webkit [91221] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add Chromium failing expectations for some font tests; failures are tracked by the bug 64767.

  • platform/chromium/test_expectations.txt:
4:19 PM Changeset in webkit [91220] by ojan@chromium.org
  • 2 edits in trunk/Tools

Load ToT chromium bots by default in the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=64756

Reviewed by Adam Barth.

For now, these are the most useful bots to look at. Eventually,
we may want to load the build.webkit.org bots by default once
most of the bots there upload results.

  • TestResultServer/static-dashboards/dashboard_base.js:
4:16 PM Changeset in webkit [91219] by jhoneycutt@apple.com
  • 15 edits
    2 adds in trunk

Focus and selection events are not fired when a <select>'s selection
changes
​https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
4:11 PM BuildingGtk edited by levin@chromium.org
Fix formatting of recent change. (diff)
3:55 PM Changeset in webkit [91218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC lazy sweep does not inline the common cases of cell destruction.
​https://bugs.webkit.org/show_bug.cgi?id=64745

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This inlines the case of JSFinalObject destruction.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::lazySweep):

3:49 PM Changeset in webkit [91217] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Add regression tests for legacy color parsing of valid CSS colors
​https://bugs.webkit.org/show_bug.cgi?id=64576

Patch by Tab Atkins <​jackalmage@gmail.com> on 2011-07-18
Reviewed by Simon Fraser.

  • fast/dom/attribute-legacy-colors-expected.txt:
  • fast/dom/script-tests/attribute-legacy-colors.js:
3:42 PM Changeset in webkit [91216] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter build-fix

3:36 PM Changeset in webkit [91215] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
​https://bugs.webkit.org/show_bug.cgi?id=64751

Unreviewed. Just updating unit test results after bug 64751.

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3:27 PM Changeset in webkit [91214] by abarth@webkit.org
  • 5 edits in trunk/Tools

simplejson has trouble on chromium-linux
​https://bugs.webkit.org/show_bug.cgi?id=64757

Reviewed by Eric Seidel.

Use the native JSON, if available.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2:59 PM Changeset in webkit [91213] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-18

  • DEPS:
2:51 PM Changeset in webkit [91212] by ojan@chromium.org
  • 5 edits in trunk/Tools

update the flakiness dashboard to understand the new platforms/formats in test_expectations
​https://bugs.webkit.org/show_bug.cgi?id=64743

Reviewed by Adam Barth.

The test expectations format changed a long time ago and the flakiness dashboard
was never updated to match.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
2:33 PM BuildingQtOnLinux edited by phihag@phihag.de
Outdated Mesa (when compiling on debian stable or other old distros) (diff)
2:27 PM Changeset in webkit [91211] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[SVG] [Chromium]: painting-control-04-f.svg and zero-path-square-cap-rendering.svg are failing
​https://bugs.webkit.org/show_bug.cgi?id=64675

Rebaseline painting-control-04-f.svg since r91191 fixed it.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [91210] by commit-queue@webkit.org
  • 37 edits in trunk/Tools

webkit-patch apply-attachment does not work when not called from the root of the checkout
​https://bugs.webkit.org/show_bug.cgi?id=64751

Reviewed by Adam Barth.

Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
is a step that we run for most commands (as one of the earliest steps).
EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
the CWD to the checkout root. This magically made a bunch of otherwise
wrong code work.

When I realized that apply-attachment no longer worked as expected today,
I went and fixed the bug, then realizing that we were not testing
what the cwd was when running various commands. I fixed our MockExecutive
to always log what the cwd is and fixed a whole bunch of places
where we needed to be setting the cwd.

Hopefully this will solve our cwd problems once and for-all, and webkit-patch
will again correctly work when called from any directory (including outside
of a webkit checkout).

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/update.py:
2:10 PM Changeset in webkit [91209] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Specify a cascade list consisting of the last resort font for Core Text
​https://bugs.webkit.org/show_bug.cgi?id=64747

Reviewed by Sam Weinig.

No new tests, because this does not affect behavior.

This prevents Core Text from taking its default, longer fallback list when the primary font does
not include a character. This is OK to do because WebKit never uses the results of Core Text
fallback anyway.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::cascadeToLastResortFontDescriptor): Added. Returns a CTFontDescriptor with a cascade
list consisting of the last resort font.
(WebCore::FontPlatformData::ctFont): Changed to include the cascadeToLastResortFontDescriptor
in the returned font.

2:04 PM Changeset in webkit [91208] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize equal-null comparisons and branches.
​https://bugs.webkit.org/show_bug.cgi?id=64659

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-18
Reviewed by Gavin Barraclough.

Added a peephole-aware compare-to-null implementation to JITCodeGenerator,
which is used by both the speculative and non-speculative JIT. Through
the use of the new isNullConstant helper, the two JITs invoke the
nonSpecualtiveCompareNull() helper instead of their regular comparison
helpers when compiling CompareEq. Through the use of the new isKnownCell
helper, the compare-null code will skip the is-a-cell check if the
speculative JIT had been speculating cell.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::isNullConstant):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:56 PM Changeset in webkit [91207] by ctguil@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore

Merge 90599 - Work around Skia PDF's lack of inverted path support.
​https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <​vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in ​http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that. So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::clipPathAntiAliased):

TBR=​vandebo@chromium.org
Review URL: ​http://codereview.chromium.org/7398032

1:38 PM Changeset in webkit [91206] by commit-queue@webkit.org
  • 30 edits in trunk/Source

Timer scheduling should be based off the monotonic clock
​https://bugs.webkit.org/show_bug.cgi?id=64544

Patch by James Robinson <​jamesr@chromium.org> on 2011-07-18
Reviewed by Darin Adler.

Source/JavaScriptCore:

Switches ThreadCondition::timedWait and related utility functions from currentTime() to
monotonicallyIncreasingTime().

Add WTF::monotonicallyIncreasingTime() to list of exported functions so it can be accessed from WebCore/WebKit.

(WTF::ThreadCondition::timedWait):

  • wtf/ThreadingWin.cpp:

(WTF::absoluteTimeToWaitTimeoutInterval):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::ThreadCondition::timedWait):

  • wtf/qt/ThreadingQt.cpp:

(WTF::ThreadCondition::timedWait):

Source/WebCore:

Changes the Timer scheduling logic from using absolute values in terms of currentTime() to using relative
intervals in terms of monotonicallyIncreasingTime(). This provides better standards compliance, compatibility,
and predictability when the system clock is adjusted.

No automated tests since there is no way to modify the system clock from DRT.

  • platform/SharedTimer.h:

(WebCore::MainThreadSharedTimer::setFireInterval):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/Timer.cpp:

(WebCore::TimerBase::start):
(WebCore::TimerBase::nextFireInterval):

  • platform/android/SharedTimerAndroid.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/brew/SharedTimerBrew.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/chromium/PlatformBridge.h:
  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/efl/SharedTimerEfl.cpp:

(WebCore::addNewTimer):
(WebCore::setSharedTimerFireInterval):

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/haiku/SharedTimerHaiku.cpp:

(WebCore::SharedTimerHaiku::start):
(WebCore::setSharedTimerFireInterval):

  • platform/mac/SharedTimerMac.mm:

(WebCore::setSharedTimerFireInterval):

  • platform/qt/SharedTimerQt.cpp:

(WebCore::SharedTimerQt::start):
(WebCore::setSharedTimerFireInterval):

  • platform/win/SharedTimerWin.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wince/SharedTimerWinCE.cpp:

(WebCore::setSharedTimerFireInterval):

  • platform/wx/SharedTimerWx.cpp:

(WebCore::setSharedTimerFireInterval):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerSharedTimer::setFireInterval):

Source/WebKit/chromium:

Renames setSharedTimerFireTime to setSharedTimerFireInterval to be consistent with WebCore.

  • public/WebKitClient.h:

(WebKit::WebKitClient::setSharedTimerFireInterval):

  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::setSharedTimerFireInterval):

Source/WebKit2:

Converts the WebKit2 RunLoop and CoreIPC timeouts to use monotonicallyIncreasingTime().

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::waitForSyncReply):

  • Platform/RunLoop.h:
1:36 PM Changeset in webkit [91205] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Patch by Yuzhu Shen <​yzshen@chromium.com> on 2011-07-18
Reviewed by James Robinson.

[chromium] WebFontImpl::drawText needs to handle the canvasIsOpaque input.
​https://bugs.webkit.org/show_bug.cgi?id=64555

This change handles canvasIsOpaque for the WEBKIT_USING_SKIA case.

  • src/WebFontImpl.cpp: handled canvasIsOpaque.
  • src/WebFontImpl.h: added method declaration.
1:20 PM Changeset in webkit [91204] by gavinp@chromium.org
  • 2 edits in branches/chromium/782/Source/WebCore/html

Merge 89719 BUG=80729

1:16 PM Changeset in webkit [91203] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update baseline. rbuis says this is an improvement.

  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
12:31 PM Changeset in webkit [91202] by tony@chromium.org
  • 2 edits
    2 moves
    1 add
    1 delete in trunk/LayoutTests

[chromium] Move a Linux specific test into chromium-linux and rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=64632

Reviewed by Ojan Vafai.

Rebaselining per the comment in test_expectations.txt.

  • platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:20 PM Changeset in webkit [91201] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix Windows build. Move static function defaultSessionCookieStorage() to before
its use in defaultCookieStorage().

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultSessionCookieStorage):

11:59 AM BuildingGtk edited by levin@chromium.org
Add info about fixing libjpeg error using mac ports. (diff)
11:55 AM Changeset in webkit [91200] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get coookie storage code to work with USE(CFNETWORK) enabled on Mac.

No new tests because no change in functionality.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::defaultCookieStorage):
(WebCore::defaultSessionCookieStorage):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createPrivateBrowsingStorageSession):

  • platform/network/mac/CookieStorageMac.mm:
11:55 AM Changeset in webkit [91199] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

JSC JIT does not inline GC allocation fast paths
​https://bugs.webkit.org/show_bug.cgi?id=64582

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-18
Reviewed by Oliver Hunt.

This addresses inlining allocation for the easiest-to-allocate cases:
op_new_object and op_create_this. Inlining GC allocation fast paths
required three changes. First, the JSGlobalData now saves the vtable
pointer of JSFinalObject, since that's what op_new_object and
op_create_this allocate. Second, the Heap exposes a reference to
the appropriate SizeClass, so that the JIT may inline accesses
directly to the SizeClass for JSFinalObject allocations. And third,
the JIT is extended with code to emit inline fast paths for GC
allocation. A stub call is emitted in the case where the inline fast
path fails.

  • heap/Heap.h:

(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFinalObject):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

  • runtime/JSGlobalData.h:
  • runtime/JSObject.h:

(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfInheritorID):

11:43 AM Changeset in webkit [91198] by psolanki@apple.com
  • 6 edits in trunk/Source

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit/mac:

Create an NSURLDownload from the CF objects that we have.

  • Misc/WebDownload.mm:

(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):

  • Misc/WebDownloadInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::download):

11:20 AM Changeset in webkit [91197] by abarth@webkit.org
  • 5 edits in trunk/Tools

Increase information garden-o-matic information density by switching to a table
​https://bugs.webkit.org/show_bug.cgi?id=64642

Reviewed by Dimitri Glazkov.

The old layout couldn't handle the large number of failures we had
today. This patch switches garden-o-matic to a table-based layout,
which can handle many more failures gracefully. (I expect we'll need
more UI iterations.)

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:18 AM Changeset in webkit [91196] by abarth@webkit.org
  • 8 edits in trunk/Tools

garden-o-matic should be able to determine when compile breaks
​https://bugs.webkit.org/show_bug.cgi?id=64190

Reviewed by Dimitri Glazkov.

This patch adds a red-ish box to the top of the page whenever there is
a compile error on the bots. The box automatically opens and closes as
appropriate and links to the waterfall display. In the future, we
might want to compute a regression range.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    • Add the build-only bots to the config. We use these to check whether the build failed, which is faster than waiting for the tester bots to cycle.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add DOM for the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • CSS to support the alert bar.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Wiring up events to poll the buildbot to see whether compile has failed.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Infrastructure for fetching and parsing the buildbot status JSON blob. This code could be better factored for testability. :(
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • UI for displaying compile errors.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
11:11 AM Changeset in webkit [91195] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative fix for Leopard assertions caused by 91095.

Rubber stamped by Sam Weinig.

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

  • ensure we pass the window shell, not the global object.
10:47 AM Changeset in webkit [91194] by oliver@apple.com
  • 100 edits in trunk/Source

2011-07-18 Mark Hahnenberg <​mhahnenberg@apple.com>

Refactor JSC to replace JSCell::operator new with static create method
​https://bugs.webkit.org/show_bug.cgi?id=64466

Reviewed by Oliver Hunt (​oliver@apple.com) and Darin Adler (Darin Adler).

First step in a longer refactoring process to remove the use of
operator new overloading in order to allocate GC objects and to replace
this method with static create methods for each individual type of heap-allocated
JS object. This particular patch only deals with replacing uses of
operator new within JSC proper. Future patches will remove it from the
parts that interface with the DOM. Due to the DOM's continued dependence
on it, operator new has not actually been removed from JSCell.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::create):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::create):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::operator new): (JSC::JSCallbackObject::create):
  • API/JSCallbackObjectFunctions.h: (JSC::::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction):
  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::create): (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::create): (JSC::Arguments::createNoParameters):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayConstructor.h: (JSC::ArrayConstructor::create):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::create):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h: (JSC::BooleanConstructor::create):
  • runtime/BooleanObject.h: (JSC::BooleanObject::create):
  • runtime/BooleanPrototype.h: (JSC::BooleanPrototype::create):
  • runtime/DateConstructor.cpp: (JSC::constructDate):
  • runtime/DateConstructor.h: (JSC::DateConstructor::create):
  • runtime/DateInstance.h: (JSC::DateInstance::create):
  • runtime/DatePrototype.h: (JSC::DatePrototype::create):
  • runtime/Error.cpp: (JSC::createError): (JSC::createEvalError): (JSC::createRangeError): (JSC::createReferenceError): (JSC::createSyntaxError): (JSC::createTypeError): (JSC::createURIError): (JSC::StrictModeTypeErrorFunction::create): (JSC::createTypeErrorFunction):
  • runtime/ErrorConstructor.h: (JSC::ErrorConstructor::create):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): (JSC::ErrorInstance::create):
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h: (JSC::ErrorPrototype::create):
  • runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::InterruptedExecutionError::create): (JSC::createInterruptedExecutionException): (JSC::TerminatedExecutionError::TerminatedExecutionError): (JSC::TerminatedExecutionError::create): (JSC::createTerminatedExecutionException):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::FunctionExecutable): (JSC::FunctionExecutable::fromGlobalCode):
  • runtime/Executable.h: (JSC::ExecutableBase::create): (JSC::NativeExecutable::create): (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::ProgramExecutable::create): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::make):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunctionSkippingEvalEnabledCheck):
  • runtime/FunctionConstructor.h: (JSC::FunctionConstructor::create):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::addFunctionProperties):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::create):
  • runtime/GetterSetter.h: (JSC::GetterSetter::create):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::create): (JSC::jsAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h: (JSC::JSActivation::create):
  • runtime/JSArray.h: (JSC::JSArray::create):
  • runtime/JSCell.h: (JSC::JSCell::allocateCell):
  • runtime/JSFunction.h: (JSC::JSFunction::create):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::constructEmptyArray): (JSC::constructArray):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::create):
  • runtime/JSONObject.h: (JSC::JSONObject::create):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::putDescriptor):
  • runtime/JSObject.h: (JSC::JSFinalObject::create):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope): (JSC::JSString::replaceCharacter): (JSC::StringObject::create):
  • runtime/JSString.h: (JSC::RopeBuilder::JSString): (JSC::RopeBuilder::create): (JSC::RopeBuilder::createHasOtherOwner): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString): (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • runtime/JSValue.cpp: (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/MathObject.h: (JSC::MathObject::create):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::create):
  • runtime/NativeErrorPrototype.h: (JSC::NativeErrorPrototype::create):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::create):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h: (JSC::NumberObject::create):
  • runtime/NumberPrototype.h: (JSC::NumberPrototype::create):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::create):
  • runtime/ObjectPrototype.h: (JSC::ObjectPrototype::create):
  • runtime/Operations.h: (JSC::jsString):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::createWithoutCaching): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::arrayOfMatches): (JSC::constructRegExp):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::create):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::create):
  • runtime/RegExpObject.h: (JSC::RegExpObject::create):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/RegExpPrototype.h: (JSC::RegExpPrototype::create):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::create): (JSC::ScopeChainNode::push):
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • runtime/StringConstructor.cpp: (JSC::constructWithStringConstructor):
  • runtime/StringConstructor.h: (JSC::StringConstructor::create):
  • runtime/StringObject.h: (JSC::StringObject::create):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • runtime/StringPrototype.h: (JSC::StringPrototype::create):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::createStructure):
  • runtime/StructureChain.h: (JSC::StructureChain::create):
10:12 AM Changeset in webkit [91193] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
​https://bugs.webkit.org/show_bug.cgi?id=64560

Patch by Hui Huang <​hui.2.huang@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

10:04 AM Changeset in webkit [91192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] [Qt] [WK2] Unsync in TextureMapperNode between parent and child lists cause crashes on WK2.
​https://bugs.webkit.org/show_bug.cgi?id=62587

Patch by Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com> on 2011-07-18
Reviewed by Noam Rosenthal.

Fix unsync between m_parent and m_children list in child and parent texture mapper nodes
in syncCompositingStateSelf.

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):

10:01 AM Changeset in webkit [91191] by commit-queue@webkit.org
  • 5 edits in trunk

Stroking of zero-length paths in SVG should change according to erratum
​https://bugs.webkit.org/show_bug.cgi?id=18356

Patch by Rob Buis <​rbuis@rim.com> on 2011-07-18
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Do not rely on toolkits to correctly render zero-length path with stroke-linecap=round, render
it ourselves just like for stroke-linecap=square.

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGPath::setupSquareCapPath):

LayoutTests:

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
9:54 AM Changeset in webkit [91190] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[REGRESSION] Value 'none' breaks multiple background-image display
​https://bugs.webkit.org/show_bug.cgi?id=59274

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-07-18
Reviewed by Simon Fraser.

When taking fast path for simple color background, we should draw
the background only if it is the last in the list of backgrounds.
Otherwise, it will obscure the previously drawn backgrounds.

Source/WebCore:

Test: fast/backgrounds/background-fast-path-simple-color.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

  • fast/backgrounds/background-fast-path-simple-color-expected.png: Added.
  • fast/backgrounds/background-fast-path-simple-color-expected.txt: Added.
  • fast/backgrounds/background-fast-path-simple-color.html: Added.
9:48 AM Changeset in webkit [91189] by yi.4.shen@nokia.com
  • 5 edits
    3 adds in trunk

[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
​https://bugs.webkit.org/show_bug.cgi?id=62808

Source/WebCore:

The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously
when its load type is set to SynchronousLoad.

Reviewed by Benjamin Poulain.

Test: loader/load-defer-resume-crash.html

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandler::setLoadingDeferred):

LayoutTests:

Added a test for the crash occurs when load deferring is turned off.

Reviewed by Benjamin Poulain.

  • loader/load-defer-resume-crash-expected.txt: Added.
  • loader/load-defer-resume-crash.html: Added.
  • loader/resources/images.html: Added.
  • platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
9:43 AM Changeset in webkit [91188] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Make using lowercase parameter names for AppleConnect be a plug-in quirk
​https://bugs.webkit.org/show_bug.cgi?id=64638

Reviewed by Sam Weinig.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):
Set the WantsLowercaseParameterNames quirk for the AppleConnect plug-in.

  • Shared/Plugins/PluginQuirks.h:

Add WantsLowercaseParameterNames quirk.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
If the plug-in has the WantsLowercaseParameterNames quirk, convert the parameter
names to lowercase.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
Remove the code that would convert the parameters here. Also remove the FIXME; plug-in quirks
aren't really the same thing as site-specific quirks.

9:16 AM Changeset in webkit [91187] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AnimationBase asserts if a test tries to pause during the delay phase
​https://bugs.webkit.org/show_bug.cgi?id=59475

Patch by Young Han Lee <​joybro@company100.net> on 2011-07-18
Reviewed by Simon Fraser.

There is no more assertion failure after r90765, but the testcase still fails due to
the miscalculation of the pauseTime. This patch pauses the animation at its startTime
if a test tries to pause it during the delay phase.

Source/WebCore:

Test: transitions/transition-in-delay-phase.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

LayoutTests:

  • transitions/transition-in-delay-phase-expected.txt: Added.
  • transitions/transition-in-delay-phase.html: Added.
7:26 AM Changeset in webkit [91186] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; updated chromium test expectations.

Remove a passing test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
7:08 AM Changeset in webkit [91185] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; updated chromium test expectations.

Remove two tests from test_expectations.txt that have been rebaselined.

  • platform/chromium/test_expectations.txt:
7:04 AM Changeset in webkit [91184] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Web Inspector: provide unique identifiers for loaders
​https://bugs.webkit.org/show_bug.cgi?id=64599

Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::loaderDetachedFromFrameImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameDestroyed):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::loaderId):
(WebCore::InspectorPageAgent::loaderDetachedFromFrame):

  • inspector/InspectorPageAgent.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::detachFromFrame):

6:43 AM Changeset in webkit [91183] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Consider QTouchWebPage's transform when scrolling the viewport.
​https://bugs.webkit.org/show_bug.cgi?id=64541

Reviewed by Benjamin Poulain.

Currently the scroll deltas are given to moveBy in page coordinates
which doesn't match when the page view is scalled.
This patch gives the scroll delta to the viewport in it's own coordinates.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::panGestureRequestScroll):

6:43 AM Changeset in webkit [91182] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Push the new viewport rect to the drawing area after committing the scale.
​https://bugs.webkit.org/show_bug.cgi?id=64597

Reviewed by Benjamin Poulain.

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureEnded):

6:43 AM Changeset in webkit [91181] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt] Remove the scale commit timer from QTouchWebPage.
​https://bugs.webkit.org/show_bug.cgi?id=64600

Reviewed by Benjamin Poulain.

Since we don't currently need unprepared page view scale changes,
this timer isn't useful.

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
(QTouchWebPagePrivate::commitScaleChange):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::pinchGestureStarted):

6:43 AM Changeset in webkit [91180] by jocelyn.turcotte@nokia.com
  • 6 edits in trunk/Source/WebKit2

TiledDrawingArea: map the visibleArea rect from page to tiles coordinates.
​https://bugs.webkit.org/show_bug.cgi?id=64538

Reviewed by Benjamin Poulain.

TiledDrawingAreaProxy expects its coordinates to be scaled according to
contentsScale. This patch keep the pushed visibleArea as page coordinates
and convert it each time to scaled coordinates in case the contents scale was
changed afterward.
This is a regression introduced in r90750.
Also:

  • Rename visibleArea to visibleContentRect
  • Remove an unnecessary mapToContents in QTouchWebPageProxy::setVisibleContentRect
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPagePrivate::setViewportRect):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::setVisibleContentRect):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::visibleRect):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRect):

  • UIProcess/qt/qtouchwebpageproxy.h:
6:18 AM Changeset in webkit [91179] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: "Reveal in Elements Panel" is broken.
​https://bugs.webkit.org/show_bug.cgi?id=64688

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):

5:40 AM Changeset in webkit [91178] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove RenderObject::addLayers second argument
​https://bugs.webkit.org/show_bug.cgi?id=64649

Reviewed by Benjamin Poulain.

No change in behavior.

The code was always passing |this| as the second argument. Thus just
removed the argument for clarity.

  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addLayers): Removed the argument, replaced
by |this|.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Removed the second argument at those 2 call sites.

2:20 AM Changeset in webkit [91177] by loki@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Qt rebaselines after r91060 and r91116

  • platform/qt/fast/dom/Window/window-properties-expected.txt: (r91060)
  • platform/qt/fast/dom/error-to-string-stack-overflow-expected.txt: Added (r91116)
2:09 AM Changeset in webkit [91176] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: do not pause on caught exceptions while typing in the console.
​https://bugs.webkit.org/show_bug.cgi?id=64379

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::setScriptDebugServer):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update):

1:11 AM Changeset in webkit [91175] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK and Qt rebaselines after r91158.

  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/qt/editing/inserting/5058163-1-expected.txt:
12:34 AM Changeset in webkit [91174] by commit-queue@webkit.org
  • 14 edits in trunk

Unreviewed, rolling out r91132 and r91135.
​http://trac.webkit.org/changeset/91132
​http://trac.webkit.org/changeset/91135
​https://bugs.webkit.org/show_bug.cgi?id=64681

Broke GTK and Chromium debug bots (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-18

Source/WebCore:

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMenuList.cpp:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::didSetSelectedIndex):

  • rendering/RenderMenuList.h:

Tools:

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(logEventProc):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):

Jul 17, 2011:

11:30 PM Changeset in webkit [91173] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Fix selection of elements in a multi select list and remove an unnecessary include in WorkQueue
​https://bugs.webkit.org/show_bug.cgi?id=64666

Patch by Amruth Raj <​amruthraj@motorola.com> on 2011-07-17
Reviewed by Martin Robinson.

  • Platform/gtk/WorkQueueGtk.cpp: Remove an include which is no longer required
  • Shared/gtk/WebEventFactory.cpp:

(WebKit::modifiersForEvent): Fix an incorrect ASSERT statement
(WebKit::WebEventFactory::createWebMouseEvent): Call the function to determine the modifier keys

11:24 PM Changeset in webkit [91172] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Chromium rebaselines after r91158.

Add failing expectations for tests added in r91125. The failures are tracked by the bug 64675.

Also remove failing expectations for some editing tests tracked by the Chromium issue 89477
because they are now passing.

  • platform/chromium-linux/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.png:
  • platform/chromium-win/editing/inserting/5058163-1-expected.txt:
  • platform/chromium/test_expectations.txt:
7:58 PM Changeset in webkit [91171] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Refactor scheduleDispatchFunctionsOnMainThread to fix crash.
​https://bugs.webkit.org/show_bug.cgi?id=64337

Replace ecore_timer_add to Ecore_Pipe.
This is needed because ecore_timer should not be called in a child thread,
but in the main thread.

Reviewed by Antonio Gomes.

  • wtf/efl/MainThreadEfl.cpp:

(WTF::pipeObject):
(WTF::monitorDispatchFunctions):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

6:59 PM Changeset in webkit [91170] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement CSSPropertyCursor in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=64432

Reviewed by Dimitri Glazkov.

No new tests / refectoring only.

  • css/CSSStyleApplyProperty.cpp:

Add handler for CSSPropertyCursor.

  • css/CSSStyleSelector.cpp:

Remove current handler of CSSPropertyCursor.

  • css/CSSStyleSelector.h:

Make styleImage and cachedOrPendingFromValue public.

6:47 PM Changeset in webkit [91169] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

Patch by Lukasz Slachciak <​l.slachciak@samsung.com> on 2011-07-17
Reviewed by Martin Robinson.

[GTK] [WK2] Fix for getting editor client commands.
​https://bugs.webkit.org/show_bug.cgi?id=63081

Editor client commands intepretation was incorrect. It was based on the NativeWebKeyboardEvent only.
In fact EventHandler is generating interpreted events - keypress and keydown. These event types
are now passed from UIProcess to WebProcess so KeyBindingTranslator can correctly find editor commands.
Also build break for Debug build was fixed.

  • UIProcess/API/gtk/PageClientImpl.cpp: KeyboardEvent type is used for KeyBindingTranslator.

(WebKit::PageClientImpl::getEditorCommandsForKeyEvent): getEditorCommandsForKeyEvent now has additional
parameter describing KeyboardEvent type.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): KeyboardEvent type passed to PageClient.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::getEditorCommandsForKeyEvent): Sync message send with KeyboardEvent type.

2:02 AM Changeset in webkit [91168] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline.
​https://bugs.webkit.org/show_bug.cgi?id=64637

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-17
Reviewed by Gavin Barraclough.

  • dfg/DFGOperations.cpp:
1:57 AM Changeset in webkit [91167] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Tools

test-webkitpy failing with Python 2.5
​https://bugs.webkit.org/show_bug.cgi?id=64594

Patch by Philippe Normand <​pnormand@igalia.com> on 2011-07-17
Reviewed by Eric Seidel.

Updated simplejson to version 2.1.6 that fixes an issue when
dumping slashes. Also use cgi.parse_qs instead of the urlparse
version to be compatible with Python2.5. Verified the fix with
test-webkitpy on python 2.5 and python 2.6.

  • Scripts/webkitpy/thirdparty/simplejson/README.txt:
  • Scripts/webkitpy/thirdparty/simplejson/init.py:
  • Scripts/webkitpy/thirdparty/simplejson/_speedups.c:

(json_PyOS_string_to_double):
(_convertPyInt_AsSsize_t):
(_convertPyInt_FromSsize_t):
(ascii_escape_char):
(ascii_escape_unicode):
(ascii_escape_str):
(raise_errmsg):
(join_list_unicode):
(join_list_string):
(_build_rval_index_tuple):
(scanstring_str):
(scanstring_unicode):
(py_scanstring):
(py_encode_basestring_ascii):
(scanner_dealloc):
(scanner_traverse):
(scanner_clear):
(_parse_object_str):
(_parse_object_unicode):
(_parse_array_str):
(_parse_array_unicode):
(_parse_constant):
(_match_number_str):
(_match_number_unicode):
(scan_once_str):
(scan_once_unicode):
(scanner_call):
(scanner_new):
(scanner_init):
(encoder_new):
(encoder_init):
(encoder_call):
(_encoded_const):
(encoder_encode_float):
(encoder_encode_string):
(_steal_list_append):
(encoder_listencode_obj):
(encoder_listencode_dict):
(encoder_listencode_list):
(encoder_dealloc):
(encoder_traverse):
(encoder_clear):
(init_speedups):

  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/encoder.py:
  • Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
  • Scripts/webkitpy/thirdparty/simplejson/scanner.py:
  • Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
12:38 AM Changeset in webkit [91166] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Rename ModifierMatcher to SpecificityCalculator.
​https://bugs.webkit.org/show_bug.cgi?id=64660

It's a little longer than before, but it is much clearer.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted

all callsites, also rewrote the comments.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites

and renamed tests.

Jul 16, 2011:

10:40 PM Changeset in webkit [91165] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/782

Merge 91152
BUG=89520
Review URL: ​http://codereview.chromium.org/7395022

10:04 PM Changeset in webkit [91164] by barraclough@apple.com
  • 9 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=64657
Converted this value not preserved when accessed via direct eval.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Upon entry into a non-strict function, primitive this values should be boxed as Object types
(or substituted with the global object) - which is done by op_convert_this. However we only
do so where this is used lexically within the function (we omit the conversion op if not).
The problem comes if a direct eval (running within the function's scope) accesses the this
value.

We are safe in the case of a single eval, since the this object will be converted within
callEval, however the converted value is not preserved, and a new wrapper object is allocated
each time eval is invoked. This is inefficient and incorrect, since any changes to the wrapper
object will be lost between eval statements.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • If a function uses eval, we always need to convert this.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • Don't convert primitive values here - this is too late!

(JSC::Interpreter::privateExecute):

  • Changed op_convert_this to call new isPrimitive method.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Changed op_convert_this to call new isPrimitive method.
  • runtime/JSCell.h:

(JSC::JSCell::JSValue::isPrimitive):

  • Added JSValue::isPrimitive.
  • runtime/JSValue.h:
    • Added JSValue::isPrimitive.

LayoutTests:

Added test case.

  • fast/js/read-modify-eval-expected.txt:
  • fast/js/script-tests/read-modify-eval.js:

(primitiveThisTest):

9:56 PM Changeset in webkit [91163] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Fix Win Cairo Debug build after <​http://trac.webkit.org/changeset/91085>.

Add stub implementation of scale factor overloaded ShareableBitmap::paint() for
Cairo WebKit2 port after its usage in changeset <​http://trac.webkit.org/changeset/91085>.

Also add stub implementation for GTK.

We'll need to actually implement this. See <​https://bugs.webkit.org/show_bug.cgi?id=64664>
and <​https://bugs.webkit.org/show_bug.cgi?id=64665> for Cairo and GTK, respectively.

  • Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
  • Shared/gtk/ShareableBitmapGtk.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
9:21 PM Changeset in webkit [91162] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Fix Qt Linux Release build after changeset <​http://trac.webkit.org/changeset/91085>
(​https://bugs.webkit.org/show_bug.cgi?id=64611).

Stub out scale factor-variant implementation of ShareableBitmap::paint().
We'll need to implement this. See <​https://bugs.webkit.org/show_bug.cgi?id=64663>
for more details.

  • Shared/qt/ShareableBitmapQt.cpp: (WebKit::ShareableBitmap::paint): Added scale-factor variant.
7:34 PM Changeset in webkit [91161] by Simon Fraser
  • 16 edits in trunk/Source

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Implemented a new behavior on GraphicsLayerCA which attempts to keep layers pixel
aligned as page scale changes.

This requires denoting which layer has the page scale on it (it is assumed to be
already aligned), via setAppliesPageScale(). We also now pass a scale and offset
down through the GraphicsLayer commits, which are used to map layer bounds to display
coordinates for rounding.

  • platform/graphics/GraphicsLayer.h: New flags and getters/setters for pixel alignment, and the layer that is the applier of the scale. (WebCore::GraphicsLayer::setMaintainsPixelAlignment): (WebCore::GraphicsLayer::maintainsPixelAlignment): (WebCore::GraphicsLayer::setAppliesPageScale): (WebCore::GraphicsLayer::appliesPageScale):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): Initialize the new flags. (WebCore::GraphicsLayer::backingScaleFactor): Utility method that calls the client if there is one. (WebCore::GraphicsLayer::pageScaleFactor): Ditto.
  • platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::backingScaleFactor): Provide default implementation. (WebCore::GraphicsLayerClient::pageScaleFactor): Ditto.
  • platform/graphics/ca/GraphicsLayerCA.h: Pass scale and base-relative offset around to methods that need to update geometry during commit. Some new methods related to pixel alignment.
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::computePositionRelativeToBase): For single-layer commits, we have to compute the base-relative offset, and whether we're under the layer applying the scale by walking up the tree.

(WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly): Call
computePositionRelativeToBase() to get scaling parameters for the target layer.

(WebCore::GraphicsLayerCA::recursiveCommitChanges): Pass flags related to scaling.
positionRelativeToBase is an offset relative to the ancestor layer known to be pixel
aligned. affectedByPageScale is true for layers which are descendants of the layer
which applies the scale.

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Pass scale and offset.
(WebCore::GraphicsLayerCA::updateGeometry): Call computePixelAlignment() to get
pixel-aligned geometry. This only needs to be applied to layers which render content,
so re-organize the code to use the unchanged layer geometry for the structural layer,
but to apply the adjusted geometry to the m_layer.

(WebCore::GraphicsLayerCA::updateStructuralLayer): Pass scale and offset.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Ditto.
(WebCore::GraphicsLayerCA::updateLayerDrawsContent): Ditto.
(WebCore::GraphicsLayerCA::updateContentsScale): Ditto.
(WebCore::GraphicsLayerCA::requiresTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Ditto.
(WebCore::GraphicsLayerCA::setKeepPixelAligned): When set, dirties flags
for properties that need to be recomputed.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
(WebCore::isIntegral):
(WebCore::GraphicsLayerCA::computePixelAlignment): Map our bounds to screen
scale, round out to an integral rect, then map it back, adding a fudge factor
so that CA backing stores don't end up being smaller than we expect because
of integer truncation.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Turn on pixel alignment if the compositor says so. (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): Set the RenderView's layer as the one applying the scale, for the main frame.
  • rendering/RenderLayerCompositor.h: New method.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::keepLayersPixelAligned): Master switch for pixel alignment. Default to on. (WebCore::RenderLayerCompositor::ensureRootLayer): Give the two root-ish layers a client so they can ask for page scale if necessary.

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementation of pageScaleFactor() now that GraphicsLayerClient has
a default implementation.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

  • WebView.h:

2011-07-16 Simon Fraser <Simon Fraser>

Add code to attempt to align compositing layers to pixel boundaries when page scale changes
​https://bugs.webkit.org/show_bug.cgi?id=64658

Reviewed by Dan Bernstein.

Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.

  • src/PageOverlay.cpp:
6:47 PM Changeset in webkit [91160] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT compare/branch code emits is-integer tests even when a value is
definitely not an integer.
​https://bugs.webkit.org/show_bug.cgi?id=64654

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Added the isKnownNotInteger() method, which returns true if a node is
definitely not an integer and will always fail any is-integer test. Then
modified the compare and branch code to use this method; if it returns
true then is-int tests are omitted and the compiler always emits a slow
call.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):

5:46 PM Changeset in webkit [91159] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-07-16 Daniel Bates <​dbates@webkit.org>

Attempt to fix the Qt Linux Release build after changeset <​http://trac.webkit.org/changeset/91097>
(​https://bugs.webkit.org/show_bug.cgi?id=64615).

  • UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::setCursorHiddenUntilMouseMoves): Added stub method.
  • UIProcess/qt/QtWebPageProxy.h:
5:33 PM Changeset in webkit [91158] by enrica@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION: Pressing return in a particular document sends the cursor to the end of the document.
​https://bugs.webkit.org/show_bug.cgi?id=64140
<rdar://problem/9737491>

Source/WebCore:

Inserting a paragraph separator at a break element, inside an inline, generates redundant markup
and moves the selection at the end of the inserted block.
The fix consists in detecting that the insertion point is a break element and simply inserting another
break element. This solves the problem of the wrong final selection and also produces less redundant
markup.

Reviewed by Simon Fraser.

Test: editing/inserting/insert-paragraph-separator-at-break.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Modified logic for insertion at a break
element.

LayoutTests:

Added new test to cover this case and updated results for one test that now
produces simpler markup.

Reviewed by Simon Fraser.

  • editing/inserting/insert-paragraph-separator-at-break-expected.txt: Added.
  • editing/inserting/insert-paragraph-separator-at-break.html: Added.
  • platform/mac/editing/inserting/5058163-1-expected.txt:
4:29 PM Changeset in webkit [91157] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

SubresourceLoader::didReceiveDataArray can crash when calling m_client->didReceiveData()
​https://bugs.webkit.org/show_bug.cgi?id=64656
<rdar://problem/9754425>

Reviewed by Alexey Proskuryakov.

  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray): Check for m_client before calling
m_client->didReceiveData().

4:14 PM Changeset in webkit [91156] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG speculative JIT has dead code for slow calls for branches.
​https://bugs.webkit.org/show_bug.cgi?id=64653

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-16
Reviewed by Gavin Barraclough.

Removed SpeculativeJIT::compilePeepHoleCall.

  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:
4:01 PM Changeset in webkit [91155] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Compilation fails on disabling TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=64408

Fix compilation error due to API name change in GraphicsLayer

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2011-07-16
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQt::setContentsToBackgroundColor):

  • platform/graphics/qt/GraphicsLayerQt.h:
3:59 PM Changeset in webkit [91154] by psolanki@apple.com
  • 13 edits in trunk

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

New WebKitSystemInterface functions for CFNetwork-based loader.

../../git/opensource/WebKit.git/Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

../../git/opensource/WebKit.git/Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

../../git/opensource/WebKit.git/WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:39 PM Changeset in webkit [91153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Work towards determining the cause of frequent crashes due to null frame below
ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
​https://bugs.webkit.org/show_bug.cgi?id=62764

Patch by Jessie Berlin <​jberlin@apple.com> on 2011-07-16
Reviewed by Darin Adler.

No loads should be going on for a DocumentLoader that has been detached from its frame, but
that appears to be what is happening in this bug.

Add assertions with the hope that someone will run into this while debugging and thereby find
a reproducible case.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

1:12 PM Changeset in webkit [91152] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

DOMWindow::open performs a security check on a wrong window
​https://bugs.webkit.org/show_bug.cgi?id=64651

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-07-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-window-open-parent.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

LayoutTests:

  • http/tests/security/resources/xss-DENIED-window-open-parent-attacker.html: Added.
  • http/tests/security/xss-DENIED-window-open-parent-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-parent.html: Added.
12:07 PM Changeset in webkit [91151] by weinig@apple.com
  • 103 edits in trunk

Attribute selectors don't handle glob namespaces (e.g. *|E)
​https://bugs.webkit.org/show_bug.cgi?id=64567

Reviewed by Anders Carlsson.

Source/WebCore:

Change checking of attribute selectors to match CSS 3 Selectors in
the presence of namespaces. This entails changing the algorithm to
check each attribute on an element as a match for the attribute selector
and taking into account a prefix of *.

  • css/CSSStyleSelector.cpp:

(WebCore::attributeQualifiedNameMatches):
Checks if the a particular attributes qualified name matches
the attribute selector, taking into account a prefix of *.

(WebCore::attributeValueMatches):
Checks if a particular attribute on an element, matches
the attribute selector.

(WebCore::anyAttributeMatches):
Top level attribute check. Checks if any of an elements attributes
match the attribute selector.

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Factor out attribute checking code into the above functions.

LayoutTests:

Update results for correct handling of a * prefix in an attribute selector.
Fixes 50 tests.

  • platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-104-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-105-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-106-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-107-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-108-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-109-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-110-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-130b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-131b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-132b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-133b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-134b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-135b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-136b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173a-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-173b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174a-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-174b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-104-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-104-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-105-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-105-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-106-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-106-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-107-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-107-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-108-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-108-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-109-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-109-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-110-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-110-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-130-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-130-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-130b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-131-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-131-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-131b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-132-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-132-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-132b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-133-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-133-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-133b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-134-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-134-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-134b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-135-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-135-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-135b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-136-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-136-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-136b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-173a-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-173b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-174a-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-174b-expected.txt:
12:06 PM Changeset in webkit [91150] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/782

Merge 91005
BUG=88730
Review URL: ​http://codereview.chromium.org/7396010

5:37 AM Changeset in webkit [91149] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebCore

WinCE build fix. Unreviewed.

  • dom/SelectElement.cpp:
12:33 AM Changeset in webkit [91148] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Patch by Kulanthaivel Palanichamy <​kulanthaivel@codeaurora.org> on 2011-07-16
Reviewed by Nikolas Zimmermann.

SVG animation API crashes on SVGAnimateTransform
​https://bugs.webkit.org/show_bug.cgi?id=64104

Source/WebCore:

This patch ensures the update in AnimatedTransform list in
SVGAnimateTransformElement.cpp is in sync with its wrapper list.

Test: svg/animations/svgtransform-animation-discrete.html

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::animatedTransformListFor):
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):

LayoutTests:

Added the test to cover assertion in AnimatedTransform list where its
value and wrapper length mismatch occurs.

  • svg/animations/script-tests/svgtransform-animation-discrete.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/svgtransform-animation-discrete-expected.txt: Added.
  • svg/animations/svgtransform-animation-discrete.html: Added.

Jul 15, 2011:

10:55 PM Changeset in webkit [91147] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix the build.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::updateEnabledState):
10:15 PM Changeset in webkit [91146] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Overlay scrollbars in overflow areas no longer pulse when revealed
​https://bugs.webkit.org/show_bug.cgi?id=64606
<rdar://problem/9390674>

Patch by Tim Horton <​timothy_horton@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

Ensure that the state of the scrollbar implementation is kept in sync
with WebCore's internal representation. Previously, we synchronized them
at paint time, causing pulsing to be skipped due to the scrollbars being
disabled.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

9:41 PM Changeset in webkit [91145] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/win

2011-07-15 Simon Fraser <Simon Fraser>

Fix Windows build.

  • WebView.h: (WebView::backingScaleFactor): (WebView::pageScaleFactor):
9:03 PM Changeset in webkit [91144] by abarth@webkit.org
  • 7 edits in trunk/Tools

gardening server should proxy buildbot status for garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=64588

Reviewed by Eric Seidel.

This information will be used to detect build breaks. I took this
opportunity to make ChromiumBuildBot non-static.

  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
7:11 PM Changeset in webkit [91143] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 90936
BUG=88846
Review URL: ​http://codereview.chromium.org/7390020

7:08 PM Changeset in webkit [91142] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 90914
BUG=86705
Review URL: ​http://codereview.chromium.org/7398018

7:04 PM Changeset in webkit [91141] by cevans@google.com
  • 1 edit
    6 copies in branches/chromium/782

Merge 91044
BUG=88337
Review URL: ​http://codereview.chromium.org/7401011

6:41 PM Changeset in webkit [91140] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Another Windows build fix; make this method non-pure virtual.

  • platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::didCommitChangesForLayer):
6:40 PM Changeset in webkit [91139] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix build error in 32-bit builds.

  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::zeroLengthSubpathRect):
6:33 PM Changeset in webkit [91138] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-07-15 Simon Fraser <Simon Fraser>

Fix Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::backingScaleFactor): (WebCore::MediaPlayerPrivate::pageScaleFactor):
6:30 PM Changeset in webkit [91137] by Simon Fraser
  • 18 edits in trunk/Source

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

RenderLayerBacking would set the contentsScale on GraphicsLayers
on creation, and update it when the pageScaleFactor changed. However,
RenderLayerBacking doesn't really know what contentsScale is best
for a layer, so instead, have GraphicsLayers call back through the
GraphicsLayerClient to get the two relevant scale factors, and do
their own computation of contentsScale.

No testable behavior changes.

  • page/Frame.cpp: (WebCore::Frame::pageScaleFactorChanged): No need to pass the scale.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants): Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on each layer.
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::pageScaleFactorChanged): Remove contentsScale/setContentsScale
  • platform/graphics/GraphicsLayerClient.h: Add methods to fetch the backingScaleFactor() and pageScaleFactor().
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges defaults to ContentsScaleChanged so we update contentsScale on the first flush.

(WebCore::GraphicsLayerCA::setContentsToBackgroundColor):
This was the wrong time to call updateContentsRect() and setupContentsLayer();
those should be done at commit time, so moved to updateLayerBackgroundColor().
(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we
have any changes, and call didCommitChangesForLayer() on the client.
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here.
(WebCore::clampedContentsScaleForScale): No longer has any hysteresis
on the scale, and now just clamps.
(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales
from the client, and multiply them, then clamp.
(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes
contentsScale into account when deciding to use tiled layer,
so that zooming in will cause layers to start tiling.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call
setContentsScale(), but rather updateContentsScale().
(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits
for properties that depend on the scale.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
Note that contentsScale needs to be updated. At some point we might also
need to dirty other properties.

  • platform/graphics/ca/GraphicsLayerCA.h: Moved the m_allowTiledLayer bool for better packing. No need for a m_contentsScale member now.
  • rendering/RenderLayer.cpp: Removed pageScaleFactorChanged().
  • rendering/RenderLayer.h: Ditto.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to push the contents scale. (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto. (WebCore::RenderLayerBacking::updateMaskLayer): Ditto. (WebCore::RenderLayerBacking::pageScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerBacking::didCommitChangesForLayer): Send through to the compositor.
  • rendering/RenderLayerBacking.h: GraphicsLayerClient methods.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::didFlushChangesForLayer): We'll use this later. (WebCore::RenderLayerCompositor::backingScaleFactor): GraphicsLayerClient method. (WebCore::RenderLayerCompositor::pageScaleFactor): Ditto. (WebCore::RenderLayerCompositor::didCommitChangesForLayer): Ditto. (WebCore::RenderLayerCompositor::ensureRootLayer): No need to push the contents scale. (WebCore::RenderLayerCompositor::pageScaleFactorChanged): Just call notePageScaleFactorChangedIncludingDescendants() on the root GraphicsLayer.
  • rendering/RenderLayerCompositor.h: Added GraphicsLayerClient methods.

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale,
and don't push the scale.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize): (WebKit::LayerTreeHostCA::backingScaleFactor): (WebKit::LayerTreeHostCA::pageScaleFactor): (WebKit::LayerTreeHostCA::createPageOverlayLayer):
  • WebProcess/WebPage/ca/LayerTreeHostCA.h: (WebKit::LayerTreeHostCA::didCommitChangesForLayer):

2011-07-15 Simon Fraser <Simon Fraser>

Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
​https://bugs.webkit.org/show_bug.cgi?id=64643

Reviewed by Darin Adler.

Impement new GraphicsLayerClient methods related to contents scale.

  • src/PageOverlay.cpp: (WebKit::OverlayGraphicsLayerClientImpl::backingScaleFactor): (WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):
6:10 PM Changeset in webkit [91136] by jchaffraix@webkit.org
  • 5 edits in trunk/Tools

[NRWT] Add support for --no-http
​https://bugs.webkit.org/show_bug.cgi?id=64564

Reviewed by Dirk Pranke.

Added support for --no-http, which disables both HTTP and websockets tests.
It also matches the old-run-webkit-tests behavior if --force is used.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine
what is worth have an HTTP lock as --no-http to avoid badness.

  • Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that

we do skip properly HTTP / websocket tests inside platform/.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Added tests that we properly skip all the tests.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Added checks for the command line arguments.

5:27 PM Changeset in webkit [91135] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix. Unreviewed.

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Cast size_t to int for comparison.

5:16 PM Changeset in webkit [91134] by aestes@apple.com
  • 6 edits in trunk/Source

Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
​https://bugs.webkit.org/show_bug.cgi?id=64641

Reviewed by Brian Weinstein.

Source/WebCore:

  • WebCore.exp.in: Update to new symbol.
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolarWalkMac): Renamed from applicationIsSolarWalk.

  • platform/RuntimeApplicationChecks.h: Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().

5:03 PM Changeset in webkit [91133] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextStateSaver::context): Remove a bogus type qualifier.

4:55 PM Changeset in webkit [91132] by jhoneycutt@apple.com
  • 15 edits in trunk

Focus and selection events are not fired when a <select>'s selection
changes
​https://bugs.webkit.org/show_bug.cgi?id=64504
<rdar://problem/9319881>

Reviewed by Alice Liu.

Source/WebCore:

Test: platform/win/accessibility/option-element-selection-and-focus-events.html

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Add new notification type to the section of unhandled notifications.

  • accessibility/AXObjectCache.h:

Declare a new notification, AXMenuListItemSelected.

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):
Tell our child popup that the active option changed, and post a
notification that our value changed.

  • accessibility/AccessibilityMenuList.h:

Declare didUpdateActiveOption().

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
Get the child <option> element that is selected, and fire focus and
selection events for it.

  • accessibility/AccessibilityMenuListPopup.h:

Declare didUpdateActiveOption().

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
Pass the newly-selected index.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Update the initialization list for the renamed m_lastActiveIndex.
(WebCore::RenderMenuList::setTextFromOption):
A new selection has been made in the popup; call
didUpdateActiveOption().
(WebCore::RenderMenuList::didSetSelectedIndex):
Call didUpdateActiveOption(), passing the index of the newly-selected
<option>.
(WebCore::RenderMenuList::didUpdateActiveOption):
If accessibility is disabled, or if the active option has not changed,
return early. Check whether the option index is in the range of list
items, and assert that the item at that index is an <option> element.
Tell the AccessibilityMenuList for this element that we updated the
active option.

  • rendering/RenderMenuList.h:

Updated the declaration of didSetSelectedIndex() to take the selected
index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
m_lastActiveIndex.

Tools:

  • DumpRenderTree/AccessibilityController.h:

Added m_notificationsEventHook for addNotificationListener().
m_allEventsHook will now be used for setLogAccessibilityEvents().

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize m_notificationsEventHook.
(AccessibilityController::~AccessibilityController):
Turn off logging of all accessibility events. If
m_notificationsEventHook is non-null, unhook it.
(logEventProc):
Add handling of EVENT_OBJECT_SELECTION.
(AccessibilityController::setLogAccessibilityEvents):
If the state of logging is not changing, return early. If we're turning
off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
hook for all events.
(AccessibilityController::addNotificationListener):
Use m_notificationsEventHook rather than m_allEventsHook.

LayoutTests:

  • platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
4:52 PM Changeset in webkit [91131] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the build.

  • dfg/DFGGraph.h:
4:52 PM Changeset in webkit [91130] by cmarrin@apple.com
  • 4 edits in trunk/Source/WebCore

Fixing style issues pointed out by Simon for
​https://bugs.webkit.org/show_bug.cgi?id=64542

Unreviewed.

4:49 PM Changeset in webkit [91129] by jhoneycutt@apple.com
  • 5 edits
    1 add in trunk/Source/WebCore

ALT + DOWN arrow key does not open select

​https://bugs.webkit.org/show_bug.cgi?id=14407
<rdar://problem/5319507>

Reviewed by Alexey Proskuryakov.

No test, because eventSender sends events to the WebView, rather than
the popup menu, so the popup isn't closed.

  • WebCore.vcproj/WebCore.vcproj:

Add SelectElementWin.cpp to project.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::platformHandleKeydownEvent):
Moved ARROW_KEYS_POP_MENU code here. Updated to return whether the
function has handled the key, or whether the caller needs to process it
further.
(WebCore::SelectElement::menuListDefaultEventHandler):
Allow the platform the first chance at handling the keyboard event.

  • dom/SelectElement.h:

Declare platformHandleKeydownEvent().

  • dom/SelectElementWin.cpp: Added.

(WebCore::SelectElement::platformHandleKeyboardEvent):
Allow (Shift) F4 and (Ctrl/Shift) Alt/AltGr + Up/Down
arrow to show the popup. After the popup is dismissed, call
setSelectedIndex(), and report that we handled the event.

  • platform/win/PopupMenuWin.cpp:

Declare HIGH_BIT_MASK_SHORT.
(WebCore::PopupMenuWin::show):
Forward WM_SYSKEYDOWN to the popup's HWND.
(WebCore::PopupMenuWin::wndProc):
Allow the same shortcuts that show the menu to hide it, matching
Firefox.

4:48 PM Changeset in webkit [91128] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

Ensure that a single select element's child option elements are
reported correctly to accessibility clients if the children are
changed.

​https://bugs.webkit.org/show_bug.cgi?id=64500
<rdar://problem/9773066>

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/win/accessibility/single-select-children-changed.html

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):
Remove a comment about WML, which we no longer support.
(WebCore::AccessibilityMenuListPopup::childrenChanged):
Don't just remove children that were detached - this will miss childen
that were dynamically added. Clear the children and re-add them.

LayoutTests:

  • platform/win/accessibility/single-select-children-changed-expected.txt: Added.
  • platform/win/accessibility/single-select-children-changed.html: Added.
4:39 PM Changeset in webkit [91127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

  • DEPS:
4:17 PM Changeset in webkit [91126] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
4:00 PM Changeset in webkit [91125] by rwlbuis@webkit.org
  • 5 edits
    6 adds in trunk

2011-07-15 Rob Buis <​rbuis@rim.com>

Stroking of zero-length paths in SVG should change according to erratum
​https://bugs.webkit.org/show_bug.cgi?id=18356

Reviewed by Nikolas Zimmermann.

Ensure rendering of zero-length paths with stroke-linecap=square works by
creating the square rectangle manually.

Tests: svg/W3C-SVG-1.1-SE/painting-control-04-f.svg

svg/custom/zero-path-square-cap-rendering.svg

  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextStateSaver::context):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath): (WebCore::RenderSVGPath::zeroLengthSubpathRect): (WebCore::RenderSVGPath::setupSquareCapPath): (WebCore::RenderSVGPath::setupNonScalingStrokePath): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h:
3:49 PM Changeset in webkit [91124] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Refactor TestExpectationModel to use TestExpectationLine as data item.
​https://bugs.webkit.org/show_bug.cgi?id=64635

This is a bit largish in scope. Does the following things:

1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,

and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
needs to have any port knowledge.

2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,

and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
Now all expectations are added to the model in the same way!

3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
3:42 PM Changeset in webkit [91123] by Adam Roben
  • 4 edits in trunk/Tools

Teach TestFailures how to detect interrupted build steps

Fixes <​http://webkit.org/b/64619> TestFailures page thinks all tests passed in
​http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:

(Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
build step was interrupted. Treat it as an error (by returning a failureCount of -1).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:

Added a test for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cache data that was afflicted by the above bug.

3:40 PM Changeset in webkit [91122] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip css3/selectors3 tests so we can rebaseline them.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [91121] by eric@webkit.org
  • 2 edits in trunk/Tools

new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
​https://bugs.webkit.org/show_bug.cgi?id=64533

Reviewed by Adam Roben.

Blind removal of Chromium-specific code (now that Chromium does not use this file).

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3:32 PM Changeset in webkit [91120] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Rebaseline overflow-scroll on Linux after r91114.

Unreviewed.

  • platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
3:30 PM Changeset in webkit [91119] by Adam Roben
  • 2 edits in trunk/Tools

Make TestFailures's list of possibly-flaky tests not so tall

Fixes <​http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
much room

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:

Removed a no-longer-used .flakiness-example-separator selector.

(#failure-history > li):
(#possibly-flaky-tests > li):
(#failure-history > li, #possibly-flaky-tests > li):
Use a lot less padding for the possibly-flaky tests.

3:13 PM Changeset in webkit [91118] by tony@chromium.org
  • 4 edits
    2 moves
    1 add in trunk

[chromium] land linux selection color layout test
​https://bugs.webkit.org/show_bug.cgi?id=64631

Reviewed by Ojan Vafai.

Tools:

I had removed this code in r76620 because I thought it wasn't used.
Turns out there was a layout test in the chromium tree that never
got migrated that used it. Re-add the code and land the layout
test (I will remove it from the chromium tree soon).

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::forceRedSelectionColors):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

  • platform/chromium-linux/editing/selection/linux_selection_color.html: Added.
3:10 PM Changeset in webkit [91117] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [91116] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

NativeError.prototype objects have Class of "Object" but should be "Error"
​https://bugs.webkit.org/show_bug.cgi?id=55346

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • Switch to putDirect since we're not the only ones tranitioning this Structure now.
  • runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):

  • runtime/NativeErrorPrototype.h:
    • Switch base class to ErrorPrototype.

LayoutTests:

Added test case.

  • fast/js/native-error-prototype-expected.txt: Added.
  • fast/js/native-error-prototype.html: Added.
  • fast/js/script-tests/native-error-prototype.js: Added.
2:57 PM Changeset in webkit [91115] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG JIT - Where arguments passed are integers, speculate this.
​https://bugs.webkit.org/show_bug.cgi?id=64630

Reviewed by Sam Weinig.

Presently the DFG JIT is overly aggressively predicting double.
Use a bit of dynamic information, and curtail this a little.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

  • Check for integer arguments.
  • dfg/DFGGraph.h:
    • Function declaration.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):
(JSC::FunctionExecutable::compileForCallInternal):

  • Add call to predictArgumentTypes.
2:54 PM Changeset in webkit [91114] by enne@google.com
  • 6 edits
    2 adds
    2 deletes in trunk

Reviewed by Simon Fraser.

Overlap map for compositing needs to consider clipping
​https://bugs.webkit.org/show_bug.cgi?id=63493

Source/WebCore:

Test: compositing/layer-creation/overlap-clipping.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Added new test. limit-layer-bounds-clipping-ancestor had changed
behavior because some layers no longer needed to become composited.
Adjusted that test to be less platform-specific as well.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • compositing/layer-creation/overlap-clipping.html: Added.
  • platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
2:24 PM Changeset in webkit [91113] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r90592.
​http://trac.webkit.org/changeset/90592
​https://bugs.webkit.org/show_bug.cgi?id=64627

Causes crashes with the web audio async decoding API
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

  • manual-tests/array-buffer-memory.html: Removed.
2:22 PM Changeset in webkit [91112] by kbr@google.com
  • 11 edits in trunk

Don't restore WebGL context if it was guilty of a graphics reset
​https://bugs.webkit.org/show_bug.cgi?id=64497

Reviewed by Stephen White.

Source/WebCore:

Use getGraphicsResetStatusARB already defined in Extensions3D to
determine why the context was lost, and respond to guilty context
notifications by forbidding restoration of the context.

It isn't currently possible to write an automated test for this.
We might consider extending the WEBKIT_lose_context extension to
allow a reason to be provided why the context was lost. It was
tested manually in Chromium on Windows and Linux with some test
cases that provoke actual graphics card resets.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

Source/WebKit/chromium:

Actually implement getGraphicsResetStatusARB rather than inferring
the status based on whether the context has been lost.

  • public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

LayoutTests:

Updated expectations for context-lost test and added comment about
the order of event delivery. Per the specification of the
WEBKIT_lose_context extension, the previous expectations were wrong.

  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
2:17 PM Changeset in webkit [91111] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Update Versioning.

2:17 PM Changeset in webkit [91110] by cmarrin@apple.com
  • 10 edits
    2 copies
    2 moves in trunk/Source/WebCore

Move TransformState to platform/graphics and give it the option to transform just a FloatQuad
​https://bugs.webkit.org/show_bug.cgi?id=64542

Reviewed by Simon Fraser.

This is to make it possible to use TransformState in some GraphicsLayer work. HitTestingTransformState
was split out and left in rendering since it's not needed in the platform code. Also added a FIXME
because HitTestingTransformState should eventually be replaced by TransformState.

2:07 PM Changeset in webkit [91109] by Lucas Forschler
  • 1 copy in branches/safari-534.51-branch

New branch.

2:00 PM Changeset in webkit [91108] by adachan@apple.com
  • 5 edits in trunk/Source/WebKit2

Implement "Jump to Selection" in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=64569

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView centerSelectionInVisibleArea:]): Call WebPageProxy::centerSelectionInVisibleArea().
(-[WKView validateUserInterfaceItem:]): Enable the centerSelectionInVisibleArea: selector if there's a selection
range or if there's an insertion point in an editable area.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::showFindIndicatorInSelection): Call updateFindIndicator() to show the find indicator.

  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::centerSelectionInVisibleArea): Use the selection in the focused or main frame.
After scrolling the selection into view, flash the find indicator.

1:54 PM Changeset in webkit [91107] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit/chromium

Chromium build fix.

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::setCursorHiddenUntilMouseMoves):

  • src/WebPopupMenuImpl.h:
1:49 PM Changeset in webkit [91106] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Revert ​http://trac.webkit.org/changeset/91091, since Python 2.5
does not support enumerate() start argument.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
1:49 PM Changeset in webkit [91105] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Re-mark tests as failing as a result of r91069
​https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

senorblanco checked in baselines, but these tests appear to still be failing.

  • platform/chromium/test_expectations.txt:
1:41 PM Changeset in webkit [91104] by weinig@apple.com
  • 4 edits
    2596 adds in trunk/LayoutTests

Reviewed by Simon Fraser.

We should import the CSS 3 Selectors test suite
​https://bugs.webkit.org/show_bug.cgi?id=64610

Add dump of the CSS 3 Selectors test suite from ​http://www.w3.org/Style/CSS/Test/CSS3/Selectors/current/.
Add standalone versions of the html, xhtml and xml suites.

  • css3/selectors3: Added.
  • css3/selectors3/html: Added.
  • css3/selectors3/xhtml: Added.
  • css3/selectors3/xml: Added.
  • platform/mac/css3/selectors3: Added.
  • platform/mac/css3/selectors3/html: Added.
  • platform/mac/css3/selectors3/xhtml: Added.
  • platform/mac/css3/selectors3/xml: Added.

[Individual tests elided]

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Added css3/selectors3 pending results.

1:41 PM Changeset in webkit [91103] by Dimitri Glazkov
  • 4 edits in trunk/Tools

Clean up test_expectations.py after refactorings.
​https://bugs.webkit.org/show_bug.cgi?id=64620

  • Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with its sub-part, the actual expectation.
  • Renamed all references to options to modifier to eliminate dual terminology.
  • Made a bunch of parser constants and changed all callsites to use them.
  • Various other minor clean-ups.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
1:35 PM Changeset in webkit [91102] by psolanki@apple.com
  • 5 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Minor changes needed to keep the compiler happy.

No new tests because no change in functionality.

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCopy):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::WebCoreSynchronousLoaderClient::willSendRequest):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::toTimeT):

1:22 PM Changeset in webkit [91101] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [91100] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/win/WebView.cpp:
1:14 PM Changeset in webkit [91099] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

DFG JIT is inconsistent about fusing branches and speculating
integer comparisons for branches.
​https://bugs.webkit.org/show_bug.cgi?id=64573

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-15
Reviewed by Gavin Barraclough.

This patch moves some of NonSpeculativeJIT's functionality up into the
JITCodeGenerator superclass so that it can be used from both JITs. Now,
in cases where the speculative JIT doesn't want to speculate but still
wants to emit good code, it can reliably emit the same code sequence as
the non-speculative JIT. This patch also extends the non-speculative
JIT's compare optimizations to include compare/branch fusing, and
extends the speculative JIT's compare optimizations to cover StrictEqual.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::detectPeepHoleBranch):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • wtf/Platform.h:
1:10 PM Changeset in webkit [91098] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • UIProcess/win/WebView.h:
1:03 PM Changeset in webkit [91097] by mitz@apple.com
  • 46 edits in trunk/Source

REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
​https://bugs.webkit.org/show_bug.cgi?id=64615

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
entering full screen.
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
hiding the HUD.

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.

  • page/Chrome.cpp:

(WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • src/ChromeClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
+[NSCursor setHiddenUntilMouseMoves:].

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.

Source/WebKit2:

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.

  • UIProcess/API/efl/PageClientImpl.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
to the page proxy.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:59 PM Changeset in webkit [91096] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
12:51 PM Changeset in webkit [91095] by barraclough@apple.com
  • 48 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=64250
Global strict mode function leaking global object as "this".

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The root problem here is that we pass the wrong values into
calls, and then try to fix them up in the callee. Correct
behaviour per the spec is to pass in the value undefined,
as this unless either (1) the function call is based on an
explicit property access or (2) the base of the call comes
directly from a 'with'.

This change does away with the need for this conversion of
objects (non strict code should only box primitives), and
does away with all this conversion for strict functions.

This patch may have web compatibility ramifications, and may
require some advocacy.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecode/Opcode.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitResolveWithThis):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/BytecodeGenerator.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolveThisAndProperty):

  • Based on resolveBaseAndProperty, but produce correct this value.

(JSC::Interpreter::privateExecute):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_with_this):

  • Removed op_convert_this_strict, added op_resolve_with_this.

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • Change NeedsThisConversion check to test for JSString's vptr (objects no longer need conversion).
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Removed op_convert_this_strict, added op_resolve_with_this.
  • jit/JITStubs.h:
    • Removed op_convert_this_strict, added op_resolve_with_this.
  • runtime/JSActivation.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSStaticScopeObject.h:
    • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

  • removed NeedsThisConversion.
  • runtime/JSTypeInfo.h:

(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):

  • removed NeedsThisConversion flag, added IsEnvironmentRecord.
  • runtime/JSValue.h:
    • removed NeedsThisConversion.
  • runtime/JSVariableObject.h:
    • Corrected StructureFlags inheritance.
  • runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

  • Added IsEnvironmentRecord to StructureFlags, addded createStructure.
  • runtime/Structure.h:
    • removed NeedsThisConversion.
  • tests/mozilla/ecma/String/15.5.4.6-2.js:

(getTestCases):

  • Removed invalid test case.

Source/WebCore:

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

  • Change call to pass DOM Window shell, instead of the global varaible object.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

  • Change call to pass DOM Window shell, instead of the global varaible object.

LayoutTests:

Add test case / update test results.

  • fast/js/call-base-resolution-expected.txt: Added.
  • fast/js/call-base-resolution.html: Added.
    • Add test for ES5 correct this value resolution in calls.
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.4_String.prototype.charAt/S15.5.4.4_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.5_String.prototype.charCodeAt/S15.5.4.5_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
12:46 PM Changeset in webkit [91094] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r91082, r91087, and r91089.
​http://trac.webkit.org/changeset/91082
​http://trac.webkit.org/changeset/91087
​http://trac.webkit.org/changeset/91089
​https://bugs.webkit.org/show_bug.cgi?id=64616

gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-15

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

12:44 PM Changeset in webkit [91093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
​https://bugs.webkit.org/show_bug.cgi?id=64612

Patch by Brian Salomon <​bsalomon@google.com> on 2011-07-15
Reviewed by Stephen White.

Tested by compositing/shadows/shadow-drawing.html

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clearRect):

12:33 PM Changeset in webkit [91092] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Move expectation parsing code to TestExpectationParser.
​https://bugs.webkit.org/show_bug.cgi?id=64605

This is a somewhat mechanical move, with two interesting bits:

1) TestExpectationParser.parse methods renamed to tokenize, to better
reflect what they do

2) TestExpectationLine now carries all of its info, from tokens to parsed data,
and even the list of tests that it matches (a line may refer to more than one test).

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods

to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
to "tokenize", changed callsites to use new code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
12:29 PM Changeset in webkit [91091] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Switch to use Python enumerate function to enumerate line numbers.
​https://bugs.webkit.org/show_bug.cgi?id=64602

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
12:27 PM Changeset in webkit [91090] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Avoid rounded rect corner-drawing overhead if no corners are visible
​https://bugs.webkit.org/show_bug.cgi?id=64584

Patch by Ian Henderson <​ianh@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

No new tests, rendering is visually identical.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::unroundClippedCorners):
(WebCore::RenderBoxModelObject::paintBorder):
Any invisible corner may be replaced with a corner of radius zero, as
long as the stroke style is solid. Change the GraphicsContext
parameter into a PaintInfo parameter so we can get the rect to be
drawn.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
paintBorder.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

12:23 PM Changeset in webkit [91089] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Another attempted build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:16 PM Changeset in webkit [91088] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
​https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

  • WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.
12:15 PM Changeset in webkit [91087] by levin@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Chromium build fix.

  • wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick

up the definition of PTHREAD_KEYS_MAX.

12:14 PM Changeset in webkit [91086] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Yet more chromium test baselines.

Somehow I messed these up in my mass-rebaselining.

  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
12:10 PM Changeset in webkit [91085] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Find indicator should take scale factor into account
​https://bugs.webkit.org/show_bug.cgi?id=64611
<rdar://problem/9761020>

Reviewed by Sam Weinig.

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
Keep track of the scale factor of the find indicator bitmap.

(WebKit::FindIndicator::draw):
Pass the scale factor to ShareableBitmap::draw.

  • UIProcess/FindIndicator.h:

Add scale factor member variable.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
This now takes the content image scale factor.

  • UIProcess/WebPageProxy.messages.in:

Add the scale factor.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
Size the backing store correctly, and apply the scale factor to
the graphics context.

(WebKit::FindController::hideFindIndicator):
Pass the scale factor along.

11:52 AM Changeset in webkit [91084] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/AuthenticationCF.h: Just use AuthenticationMac.h instead of having

Mac-specific declarations here.

  • platform/network/cf/CredentialStorageCFNet.cpp:
  • platform/network/mac/AuthenticationMac.h:
11:51 AM Changeset in webkit [91083] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed; chromium test expectations update.

Remove some now-passing tests from chromium's text_expectations.

  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [91082] by levin@chromium.org
  • 4 edits in trunk/Source/JavaScriptCore

currentThread is too slow!
​https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.

  • wtf/ThreadIdentifierDataPthreads.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Acquire the pthread key here.

11:38 AM Changeset in webkit [91081] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

Part of ​https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get LoaderRunLoop to work on Mac when USE(CFNETWORK) is enabled. Although we could use the
main run loop, it's better to have a separate thread handling the loads so that it can work
in parallel to the main thread. This is similar to what NSURLConnection does for us
internally when we use the NS APIs.

No new tests because no change in functionality and option is not enabled on Mac.

  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread): Create an autorelease pool for objc code that might be called in
the run loop.
(WebCore::loaderRunLoop):

  • platform/network/cf/LoaderRunLoopCF.h:
11:34 AM Changeset in webkit [91080] by senorblanco@chromium.org
  • 207 edits
    55 adds
    7 deletes in trunk/LayoutTests

Unreviewed. New chromium test baselines after r91069.

  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
  • platform/chromium-win-vista/fast/block: Added.
  • platform/chromium-win-vista/fast/block/positioning: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Added.
  • platform/chromium-win-vista/fast/text/stroking-expected.png: Added.
  • platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-I18N: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win-vista/svg/zoom/text: Added.
  • platform/chromium-win-vista/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win-xp/fast/dynamic: Added.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png:
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
  • platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/html/details-writing-mode-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/005-vertical-expected.png:
  • platform/chromium-win/fast/lists/006-vertical-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/009-vertical-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Removed.
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/035-vertical-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/transforms/transform-on-inline-expected.png:
  • platform/chromium-win/fast/transforms/transform-table-row-expected.png:
  • platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.png:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/custom/text-rotation-expected.png:
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
  • platform/chromium-win/svg/hixie/error/017-expected.png:
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-middle-align-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-win/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium/test_expectations.txt:
11:25 AM Changeset in webkit [91079] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect

Reviewed by Antonio Gomes.

Only set setFixedVisibleContentRect when in resizesToContents mode.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

11:11 AM Changeset in webkit [91078] by Martin Robinson
  • 9 edits in trunk

Build fixes for WebKit2. Ensure that all generated sources are
on nodist primaries, that they are on forward declared variables
so that BUILT_SOURCES is calculated properly and that zlib is
included during linking (for WOFF support).

.:

  • GNUmakefile.am:
  • Source/autotools/webkit.m4: Include test for zlib.

Source/WebKit/gtk:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:

Tools:

  • WebKitTestRunner/GNUmakefile.am:
10:23 AM Changeset in webkit [91077] by xji@chromium.org
  • 5 edits
    2 adds in trunk

--webkit-visual-word crash on mixed editability
​https://bugs.webkit.org/show_bug.cgi?id=61978

--webkit-visual-word crashes (VisiblePosition.getInlineBoxAndOffset could return null box)
​https://bugs.webkit.org/show_bug.cgi?id=62814

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace previousWordPosition/nextWordPosition with previousBoundary/nextBoundary which do
not honor editable bounary. Honor editable boundary as the last stage of leftWordPosition
and rightWordPosition.

Check previousBoundary/nextBoundary against NULL. Have a static function to encapsulate the
usage of getInlineBoxAndOffset and check the visible position is not NULL before passing to
getInlineBoxAndOffset. Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Test: editing/selection/move-by-word-visually-null-box.html

  • editing/visible_units.cpp:

(WebCore::positionIsInBox):
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::positionIsInsideBox):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

Add a standalone test for testing getInlineBoxAndOffset returning null box.

  • editing/selection/move-by-word-visually-null-box-expected.txt: Added.
  • editing/selection/move-by-word-visually-null-box.html: Added.
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html:
10:17 AM Changeset in webkit [91076] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mopping up some more expectations after r91069.

  • platform/chromium/test_expectations.txt:
10:12 AM Changeset in webkit [91075] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unncessary creation of connectionProperties dictionary
​https://bugs.webkit.org/show_bug.cgi?id=63958

Reviewed by Alexey Proskuryakov.

No new tests because no change in functionality.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

9:50 AM Changeset in webkit [91074] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more tests failing as a result of r91069
​https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

  • platform/chromium/test_expectations.txt:
8:58 AM Changeset in webkit [91073] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Store error and warning information on TestExpectationLine.
​https://bugs.webkit.org/show_bug.cgi?id=64565

Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,

converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
8:55 AM Changeset in webkit [91072] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Plumb the use of TestExpectationLine deeper, clean up.
​https://bugs.webkit.org/show_bug.cgi?id=64559

Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
also cleaning up names and remove an unused TestExpectations._get_options_list member.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
8:51 AM Changeset in webkit [91071] by Dimitri Glazkov
  • 4 edits in trunk/Tools

Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
​https://bugs.webkit.org/show_bug.cgi?id=64554

This moves us toward the world where errors are collected on the expectations, which allows us to
easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.

Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
parsing.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,

changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
8:34 AM Changeset in webkit [91070] by pfeldman@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: Focusing on another node while editing CSS property does not update styles
​https://bugs.webkit.org/show_bug.cgi?id=64283

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-change-node-while-editing.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype.updateStyles):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.callback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.inlineStyleCallback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
(WebInspector.MetricsSidebarPane.prototype._styleSheetChanged):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylesSidebarPane.prototype._styleSheetChanged):
(WebInspector.StylesSidebarPane.prototype._attributesUpdated):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

  • inspector/styles/styles-change-node-while-editing-expected.txt: Added.
  • inspector/styles/styles-change-node-while-editing.html: Added.
8:27 AM Changeset in webkit [91069] by commit-queue@webkit.org
  • 8 edits in trunk

[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
​https://bugs.webkit.org/show_bug.cgi?id=64368

Patch by Mike Reed <​reed@google.com> on 2011-07-15
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
8:10 AM Changeset in webkit [91068] by Adam Roben
  • 4 edits
    2 moves in trunk/Tools

Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <​http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Updated for renames.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and

reordered <script>s to put files which others depend on for parsing first.

7:38 AM Changeset in webkit [91067] by commit-queue@webkit.org
  • 4 edits in trunk

Pixel difference in FEMorphology effect
​https://bugs.webkit.org/show_bug.cgi?id=63930

Source/WebCore:

Patch by Piroska András <​Piroska.Andras@stud.u-szeged.hu> on 2011-07-15
Reviewed by Zoltan Herczeg.

Using short-circuit evaluation in the setFilterEffectAttribute function
was wrong. We should call both setRadius functions and evaluate the
changes separately.

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):

LayoutTests:

Patch by Gabor Loki <​loki@webkit.org> on 2011-07-15
Reviewed by Zoltan Herczeg.

Layout test is updated to follow the bugfix.

  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
7:02 AM Changeset in webkit [91066] by jeffm@apple.com
  • 6 edits in trunk

Fullscreen content doesn't use fullscreen controller on Windows
​https://bugs.webkit.org/show_bug.cgi?id=64540
<rdar://problem/9510455>

Source/WebCore:

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.

  • rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests:

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

  • fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.
  • fullscreen/video-controls-override.html: Add new test to check the height of the panel, and

log errors if window.internals or window.layoutTestController are undefined.

6:10 AM Changeset in webkit [91065] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-07-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix build failure introduced in r91061.

  • page/Console.cpp: (WebCore::Console::markTimeline): Remove argument name from unused parameter.
5:02 AM Changeset in webkit [91064] by kenneth@webkit.org
  • 15 edits in trunk/Source

Upstream QtWebKit/N9 changes related to visibleContentRect
​https://bugs.webkit.org/show_bug.cgi?id=64589

Reviewed by Simon Hausmann.

Source/WebCore:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

Make visibleContentRect return the fixed value if set, and remove
all calls to actualVisibleContentRect.

Also updated the documentation.

This is similar to what we have on our QtWebKit/N9 branch and is
pretty well tested.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
If a fixed visibleContentRect is set, return that.
Remove the code returning the contents size when in
paintsEntireContents mode as that is wrong and already
ifdeffed out for EFL.
(WebCore::ScrollView::setScrollPosition):
Do not try to be smart and update the fixed visibleContentsRect
automatically, as the embedder might ignore the scroll request
for various reasons.

  • platform/ScrollView.h:

(WebCore::ScrollView::setFixedVisibleContentRect):
(WebCore::ScrollView::fixedVisibleContentRect):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setActualVisibleContentRect):
Change to use setFixedVisibleContentRect.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • symbian/eabi/QtWebKitu.def:

Source/WebKit2:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFixedVisibleContentRect):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleArea):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:09 AM Changeset in webkit [91063] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Build plugin process by default when building WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=64592

Reviewed by Philippe Normand.

  • configure.ac:
3:40 AM Changeset in webkit [91062] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Reviewed by Martin Robinson.

[GTK] Install a custom X error handler in plugin process
​https://bugs.webkit.org/show_bug.cgi?id=63248

Some plugins, specially flash, can cause X errors that when
handled by the default X error handler (or the GDK one) abort the
process. Since we don't want to crash due to buggy plugins, we
install a custom error handler to show a warning when a X error
happens without aborting.

  • PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::webkitgtkXError):
(WebKit::PluginProcessMainGtk):

3:06 AM Changeset in webkit [91061] by commit-queue@webkit.org
  • 23 edits
    2 copies
    1 add in trunk

Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.
​https://bugs.webkit.org/show_bug.cgi?id=63317

Patch by Mike West <​mkwst@chromium.org> on 2011-07-15
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-time-stamp.html

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::consoleTimeStamp):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleTimeStampImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didTimeStamp):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimeStampData):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype.update):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

  • page/Console.cpp:

(WebCore::Console::markTimeline):
(WebCore::Console::timeStamp):

  • page/Console.h:
  • page/Console.idl:

LayoutTests:

  • inspector/timeline/resources/timeline-iframe-data.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch.html:
  • inspector/timeline/timeline-mark-timeline-expected.txt:
  • inspector/timeline/timeline-mark-timeline.html:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.dumpTimelineRecord):

  • inspector/timeline/timeline-time-stamp-expected.txt: Added.
  • inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
  • platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
  • platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.
1:35 AM Changeset in webkit [91060] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

LocalStorage: Changed the value type of ItemTable from TEXT to BLOB
to avoid string truncation.
This patch will also convert the exsisting ItemTable and perform
the DATA MIGRATION job.
​https://bugs.webkit.org/show_bug.cgi?id=58762

Patch by Jonathan Dong <Jonathan Dong> on 2011-07-15
Reviewed by Jeremy Orlow.

Tests: manual-tests/localstorage-value-truncation.html

  • manual-tests/localstorage-value-truncation.html: Added.

Demostrate the testcase shown in bug 58762.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclearedAsBlob):
Test if the pre-defined type of column is BLOB.

  • platform/sql/SQLiteStatement.h:
  • storage/StorageAreaSync.cpp:

Change the localStorage value type from Text to BLOB to avoid the
value string truncation at \x00.
(WebCore::StorageAreaSync::openDatabase):
Change the database structure, use BLOB to replace the TEXT type of
value segment in ItemTable.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
Migrate the ItemTable if the pre-defined type of value is TEXT.
(WebCore::StorageAreaSync::performImport):
Use getColumnBlobAsString() to import the BLOB value.
(WebCore::StorageAreaSync::sync):
Use bindBlob() to bind value string to the SQLiteStatement for the
database execution.

  • storage/StorageAreaSync.h:
1:25 AM WebKitGTK edited by plaes@plaes.org
Looking for 1.4.3 ;) (diff)
1:22 AM Changeset in webkit [91059] by abarth@webkit.org
  • 3 edits in trunk/Tools

NRWT stores the Chromium revision number in full_results.json
​https://bugs.webkit.org/show_bug.cgi?id=64586

I have no earthly idea how to test this change.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
1:10 AM Changeset in webkit [91058] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Clear the content of a search input form when 'Escape' is pressed.
​https://bugs.webkit.org/show_bug.cgi?id=51897

Source/WebCore:

This change added handleKeydownEvent() to a search input form,
which clears the form and triggers a 'search' event when 'Escape' is pressed.

Patch by Kentaro Hara <​haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

Test: fast/forms/input-search-press-escape-key.html

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

  • html/SearchInputType.h:

LayoutTests:

The added test checks if the value in a search input form is cleared
and a 'search' event is triggered, when we press 'Escape' key.

Patch by Kentaro Hara <​haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

  • fast/forms/input-search-press-escape-key-expected.txt: Added.
  • fast/forms/input-search-press-escape-key.html: Added.
12:23 AM Changeset in webkit [91057] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
​https://bugs.webkit.org/show_bug.cgi?id=64360

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-15
Reviewed by Hajime Morita.

No new tests needed because the patch is just a refactor.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

Jul 14, 2011:

11:56 PM Changeset in webkit [91056] by morrita@google.com
  • 9 edits
    1 add in trunk/Source/WebCore

ExceptionCodePlaceholder should have its own ExceptionCodePlaceholder.cpp file
​https://bugs.webkit.org/show_bug.cgi?id=64503

Reviewed by Darin Adler.

No new tests. Just a file reorg.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/ExceptionCodePlaceholder.cpp: Added.

(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):

  • dom/ExceptionCodePlaceholder.h: Removed NoExceptionAssertionChecker::m_function, which is loonger used.
11:49 PM Changeset in webkit [91055] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
11:38 PM Changeset in webkit [91054] by ojan@chromium.org
  • 8 edits in trunk/Tools

fix remaining style issues in the static-dashboards directory
​https://bugs.webkit.org/show_bug.cgi?id=64561

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
11:33 PM Changeset in webkit [91053] by commit-queue@webkit.org
  • 9 edits in trunk

Remove LegacyDefaultOptionalArguments flag from WebGL
​https://bugs.webkit.org/show_bug.cgi?id=64549

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-07-14
Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/bad-arguments-test-expected.txt:
  • fast/canvas/webgl/bad-arguments-test.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
11:26 PM Changeset in webkit [91052] by yutak@chromium.org
  • 12 edits in trunk

WebSocket: Introduce pywebsocket-0.6b2
​https://bugs.webkit.org/show_bug.cgi?id=64534

Reviewed by Kent Tamura.

Source/WebCore:

pywebsocket now accepts "Sec-WebSocket-Version: 8" as required in hybi-10 specification.

No new functionality is added, thus no new tests. Existing WebSocket tests should keep passing.

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

Tools:

  • Scripts/webkitpy/thirdparty/init.py:

LayoutTests:

Module "mod_pywebsocket.handshake.hybi06" has been renamed to "mod_pywebsocket.handshake.hybi".

  • http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py:
11:07 PM Changeset in webkit [91051] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2011-07-14
Reviewed by Adam Barth.

[EFL] Remove IconDatabase initialization in _ewk_init_body()
​https://bugs.webkit.org/show_bug.cgi?id=63491

Make IconDatabase feature optional by removing its initialization from _ewk_init_body().
Now IconDatabase must be fully managed by an application:
if it doesn't want to use it, there's nothing to do. Otherwise, just call
ewk_settings_icon_database_path_set() with the directory path.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_set):

10:58 PM Changeset in webkit [91050] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Introduce TestExpectationsModel, split out of TestExpectations.
​https://bugs.webkit.org/show_bug.cgi?id=64531

This is a simple split-and-make-work refactoring, a first step among many.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members

out of TestExpectations and into TestExpectationsModel.

10:37 PM Changeset in webkit [91049] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Replaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with all the corresponding function calls.
​https://bugs.webkit.org/show_bug.cgi?id=54476

Patch by SravanKumar S <​sravan.ken@gmail.com> on 2011-07-14
Reviewed by Darin Adler.

No new tests, since existing fast/dom/HTMLInputElement/checked-pseudo-selector.html verifies the patch.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isChecked):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/CheckedRadioButtons.cpp:

(WebCore::CheckedRadioButtons::removeButton):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldAppearChecked):

  • html/HTMLInputElement.h: Removed virtual declaration from shouldAppearChecked().
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isChecked):

9:36 PM Changeset in webkit [91048] by bashi@chromium.org
  • 9 edits
    2 adds in trunk

<input form="x"> should not associate the input with any forms when there is no form with id="x"
​https://bugs.webkit.org/show_bug.cgi?id=64509

Source/WebCore:

Don't set form owner when a form associated element has the form attribute but there is no such form element.

Patch by Kenichi Ishibashi <​bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

Test: fast/forms/form-attribute-nonexistence-form-id.html

  • dom/Document.cpp:

(WebCore::Document::resetFormElementsOwner): Removed the argument which is no longer needed.

  • dom/Document.h: Ditto.
  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedIntoTree): Resets m_form whenever the element has the form attribute.
(WebCore::FormAssociatedElement::resetFormOwner): Don't set m_form when there is no form element which has the given id.
(WebCore::FormAssociatedElement::formAttributeChanged): Removed the argument of resetFormOwner().

  • html/FormAssociatedElement.h: Ditto.
  • html/HTMLFormElement.cpp: Ditto.

(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):

LayoutTests:

Adds a test for checking input elements don't associate any form elements when they have the form attribute which points nonexistence form.
Fixes existing tests that contain unintended form attributes.

Patch by Kenichi Ishibashi <​bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

  • fast/forms/form-attribute-nonexistence-form-id-expected.txt: Added.
  • fast/forms/form-attribute-nonexistence-form-id.html: Added.
  • fast/forms/script-tests/form-attribute.js: Fixed unintended form attributes.
  • fast/forms/script-tests/form-collection-elements-order.js: Ditto.
9:31 PM Changeset in webkit [91047] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
​https://bugs.webkit.org/show_bug.cgi?id=64537

Reviewed by Darin Adler.

Source/WebCore:

We stopped to call updateCheckedRadioButtons() for checkboxes
since r90809, but we need to call RenderTheme::stateChanged(),
which was in updateCheckedRadioButtons(), for checkboxes.

Tests: fast/forms/checkbox-appearance-change-by-checked-expected.html

fast/forms/checkbox-appearance-change-by-checked.html

  • html/HTMLInputElement.cpp: Move the RenderTheme::stateChanged() call

from updateCheckedRadioButtons() to setChecked().
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

  • fast/forms/checkbox-appearance-change-by-checked-expected.html: Added.
  • fast/forms/checkbox-appearance-change-by-checked.html: Added.
8:50 PM Changeset in webkit [91046] by tkent@chromium.org
  • 29 edits
    4 adds
    2 deletes in trunk/LayoutTests

[Chromium] Updat test expectations for r90971.

  • platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/pseudo-cache-stale-expected.png:
  • platform/chromium-mac-leopard/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac-leopard/fast/forms/password-placeholder-text-security-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:33 PM Changeset in webkit [91045] by eric@webkit.org
  • 2 edits in trunk/Tools

Move webkitpy off of loose mocks
​https://bugs.webkit.org/show_bug.cgi?id=64508

Unreviewed. Fixing a test which fails under test-webkitpy --all (but not in a normal run).

  • Scripts/webkitpy/common/checkout/scm/git.py:
7:16 PM Changeset in webkit [91044] by abarth@webkit.org
  • 3 edits
    6 adds in trunk

The beforeload event allows tracking URI changes in a frame
​https://bugs.webkit.org/show_bug.cgi?id=64482

Reviewed by Nate Chapin.

Source/WebCore:

Tests: http/tests/security/beforeload-iframe-client-redirect.html

http/tests/security/beforeload-iframe-server-redirect.html

Only dispatch the beforeload event for a frame if we haven't yet
committed our first real load. The URL that we send to our parent will
be the same URL the parent seens in the src attribute.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests:

Test whether the beforeload event is fired for various kinds of redirects.

  • http/tests/security/beforeload-iframe-client-redirect-expected.txt: Added.
  • http/tests/security/beforeload-iframe-client-redirect.html: Added.
  • http/tests/security/beforeload-iframe-server-redirect-expected.txt: Added.
  • http/tests/security/beforeload-iframe-server-redirect.html: Added.
  • http/tests/security/resources/post-done.html: Added.
  • http/tests/security/resources/client-redir.html: Added.
7:10 PM Changeset in webkit [91043] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

LLVM Compiler build fix.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):

7:06 PM Changeset in webkit [91042] by abarth@webkit.org
  • 8 edits in trunk/Tools

garden-o-matic should have a "rebaseline" button
​https://bugs.webkit.org/show_bug.cgi?id=64446

Reviewed by Ojan Vafai.

This patch adds a basic Rebaseline button that copies the baselines
displayed in the results pane into the appropriate directory in your
working copy.

There are two main limitations:

1) There is no UI for actually committing the baselines.

2) The baselines are not optimized for redundancy (meaning you can have

identical baselines in both chromium-mac and chromium-win).

  • Scripts/webkitpy/tool/commands/rebaseline.py:
    • Turns out we need to create the directory for the baseline if it doesn't exist yet.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
    • Add an programatic API to call the server.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    • Add the rebaseline button itself.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    • Change the CSS so that the Rebaseline and Close buttons can appear in the normal order in the DOM.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Bind the event and translate the parameters.
    • Hide/show the rebaseline button, as appropriate.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Add some helpful utility functions for manipulating failure types.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
7:06 PM Changeset in webkit [91041] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT does not optimize Branch as well as it could.
​https://bugs.webkit.org/show_bug.cgi?id=64574

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This creates a common code path for emitting unfused branches, which does
no speculation, and only performs a slow call if absolutely necessary.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::emitBranch):

  • dfg/DFGJITCodeGenerator.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:51 PM Changeset in webkit [91040] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not-allowed
​https://bugs.webkit.org/show_bug.cgi?id=64570

Reviewed by Alexey Proskuryakov.

Mac OS X documentation and usage makes it clear that this cursor is usually used for no-drop,
and that it's also reasonable to use it for not-allowed.

  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor): Use [NSCursor operationNotAllowedCursor] for
Cursor::NoDrop.

6:40 PM Changeset in webkit [91039] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

GC allocation fast path has too many operations.
​https://bugs.webkit.org/show_bug.cgi?id=64493

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Darin Adler.

Changed the timing of the lazy sweep so that it occurs when we land on
a previously-unsweeped block, rather than whenever we land on an unsweeped
cell. After the per-block lazy sweep occurs, the block is turned into a
singly linked list of free cells. The allocation fast path is now just a
load-branch-store to remove a cell from the head of the list.

Additionally, this changes the way new blocks are allocated. Previously,
they would be populated with dummy cells. With this patch, they are
turned into a free list, which means that there will never be destructor
calls for allocations in fresh blocks.

These changes result in a 1.9% speed-up on V8, and a 0.6% speed-up on
SunSpider. There are no observed statistically significant slow-downs
on any individual benchmark.

(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):

  • heap/Heap.h:

(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::allocate):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):

  • heap/MarkedBlock.h:
  • heap/NewSpace.cpp:

(JSC::NewSpace::addBlock):
(JSC::NewSpace::canonicalizeBlocks):

  • heap/NewSpace.h:

(JSC::NewSpace::allocate):
(JSC::NewSpace::SizeClass::SizeClass):
(JSC::NewSpace::SizeClass::canonicalizeBlock):

  • heap/OldSpace.cpp:

(JSC::OldSpace::addBlock):

6:28 PM Changeset in webkit [91038] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Reviewed by Dimitri Glazkov.

Introduce templated compute length class in CSSStyleApplyProperty, and use to handle several CSS properties.
​https://bugs.webkit.org/show_bug.cgi?id=62957

No new tests / refactoring only.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Add computeLength function that returns unsigned short.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyComputeLength::ApplyPropertyComputeLength):
Added class to handle computeLength based properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize ApplyPropertyComputeLength for appropriate properties.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::useSVGZoomRules):
Make this a public member function instead of a private static function.
(WebCore::CSSStyleSelector::applyProperty):
Removed code now implemented in CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::setFontSize):
Use new useSVGZoomRules function.

  • css/CSSStyleSelector.h:

Add interface for useSVGZoomRules.

4:48 PM Changeset in webkit [91037] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
4:40 PM Changeset in webkit [91036] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [91035] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

DFG JIT crashes on host constructor calls in debug mode.
​https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

  • fast/js/array-constructor-host-call-expected.txt: Added.
  • fast/js/array-constructor-host-call.html: Added.
  • fast/js/script-tests/array-constructor-host-call.js: Added.

(constructArray):

4:26 PM Changeset in webkit [91034] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/JavaScriptCore: DFG JIT crashes on host constructor calls in debug mode.
​https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Fixed the relevant ASSERT.

  • dfg/DFGOperations.cpp:

LayoutTests: DFG JIT crashes on host constructor calls in debug mode.
​https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

  • fast/js/array-constructor-host-call-expected.txt: Added.
  • fast/js/array-constructor-host-call.html: Added.
  • fast/js/script-tests/array-constructor-host-call.js: Added.

(constructArray):

4:23 PM Changeset in webkit [91033] by rniwa@webkit.org
  • 3 edits in trunk/Tools

REGRESSION: webkit-patch roll-chromium-deps is broken
​https://bugs.webkit.org/show_bug.cgi?id=64568

Reviewed by Dirk Pranke

Use _filesystem.join.

  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/checkout/checkout_unittests.py:
4:22 PM Changeset in webkit [91032] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
4:00 PM Changeset in webkit [91031] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Rolled Chromium revision to 92606.

  • DEPS:
2:52 PM Changeset in webkit [91030] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Tools

Adding myself to the reviewers list; No review needed.

  • Scripts/webkitpy/common/config/committers.py:
2:49 PM Changeset in webkit [91029] by Adam Roben
  • 4 edits
    1 add in trunk/Tools

Don't use Element.prototype.classList in TestFailures

Safari 5 doesn't support it.

Fixes <​http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:

(Element.prototype.hasStyleClass):
(Element.prototype.addStyleClass):
(Element.prototype.removeStyleClass):
(Element.prototype.toggleStyleClass):
Added these helper functions which simulate classList functionality.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:

Added. Tests for the above.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

(ViewController.prototype._domForPossiblyFlakyTests): Changed to use
toggleStyleClass/hasStyleClass instead of classList.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

Added Utilities_unittests.js, and reordered the tested files to be in
roughly dependency order (i.e., the lowest-level files are imported
and tested first).

2:21 PM Changeset in webkit [91028] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

NRWT doesn't store the svn revision in full_results.json on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=64492

Unreviewed. Just fixing my test-webkitpy regression.

Fix the unit tests. Unfortunately scm does not use a filesystem
object so we can't control the result of detect_scm_system.
When detect_scm_system would fail, we would log, which would
cause all passing_run integration tests to fail.

  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2:16 PM Changeset in webkit [91027] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION: Should not dispatch didFirstVisuallyNonEmptyLayout for the initial empty document
​https://bugs.webkit.org/show_bug.cgi?id=64557

Reviewed by Kenneth Rohde Christiansen.

Avoid sending didFirstVisuallyNonEmptyLayout for the initial empty document of the frame. The
clients may not expect it and it doesn't make much sense in any case.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

1:49 PM Changeset in webkit [91026] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [91025] by jpfau@apple.com
  • 3 edits
    3 adds in trunk/Source/WebCore

Character reference parser for new XML parser
​https://bugs.webkit.org/show_bug.cgi?id=64398

Reviewed by Adam Barth.

Refactored out the HTML entity parser and added a common template for parsing character references.

  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLEntityParser.cpp:

(WebCore::consumeHTMLEntity):

  • xml/parser/CharacterReferenceParserInlineMethods.h: Copied from Source/WebCore/html/parser/HTMLEntityParser.cpp.

(WebCore::isHexDigit):
(WebCore::unconsumeCharacters):
(WebCore::consumeCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.cpp: Added.

(WebCore::consumeXMLCharacterReference):

  • xml/parser/XMLCharacterReferenceParser.h: Added.
12:51 PM Changeset in webkit [91024] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Pavel Feldman.

Web Inspector: panel switching is too slow.
​https://bugs.webkit.org/show_bug.cgi?id=60959

  • inspector/front-end/inspector.css:

(.panel):
(.panel.visible):

12:32 PM Changeset in webkit [91023] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

NRWT doesn't store the svn revision in full_results.json on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=64492

Reviewed by Ojan Vafai.

This should fix the bug. Unfortunately this code is currently
impossible to test since it's impossible to mock detect_scm_system at the
moment. I started re-writing scm.detection.py to be mockable, but decided that
was best left for another day.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
12:31 PM Changeset in webkit [91022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG speculative JIT contains a FIXME for rewinding speculative code generation that
has already been fixed.
​https://bugs.webkit.org/show_bug.cgi?id=64022

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

12:24 PM Changeset in webkit [91021] by ojan@chromium.org
  • 8 edits in trunk/Tools

fix coding style of dashboard_base.js
​https://bugs.webkit.org/show_bug.cgi?id=64545

Reviewed by Adam Roben.

The code changes to the files other than dashboard_base.js
are just fallout from renaming globals in dashboard_base.js.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
11:28 AM Changeset in webkit [91020] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
11:23 AM Changeset in webkit [91019] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] updated test expectations.

  • platform/chromium/test_expectations.txt:
11:02 AM Changeset in webkit [91018] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] Add OwnPtr specialization for Ecore_Pipe.
​https://bugs.webkit.org/show_bug.cgi?id=64515

Add an overload for deleteOwnedPtr(Ecore_Pipe*) on EFL port.

Reviewed by Xan Lopez.

  • wtf/OwnPtrCommon.h:
  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):

10:57 AM Changeset in webkit [91017] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: remove more unused CSS from inspector.css
​https://bugs.webkit.org/show_bug.cgi?id=64529

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:
10:52 AM Changeset in webkit [91016] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

[UNIX] Allow sending null handles in messages
​https://bugs.webkit.org/show_bug.cgi?id=60621

Only valid file descriptors are now sent using sendmsg() control
messages, and instead of sending a list of attachment sizes we now
send a list of AttachmentInfo structs. AttachmentInfo contains
information about the attachments including the size for
MappedMemory attachmens and whether the attachment is null or not.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::AttachmentInfo::AttachmentInfo): New class containing
information about the attachments sent.
(CoreIPC::AttachmentInfo::setType): Set the attachment type.
(CoreIPC::AttachmentInfo::getType): Return the attachment type.
(CoreIPC::AttachmentInfo::setSize): Set the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::getSize): Get the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::setNull): Set attachment as null, it
contains an invalid file descriptor, so the receiver shouldn't
expect a file desriptor for this attachment.
(CoreIPC::AttachmentInfo::isNull): Return whether attachment is
null, it contains an invalid file descriptor.
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

10:49 AM Changeset in webkit [91015] by Carlos Garcia Campos
  • 6 edits
    3 adds in trunk

Reviewed by Martin Robinson.

[GTK] Implement Plugin Process
​https://bugs.webkit.org/show_bug.cgi?id=60546

.:

  • configure.ac: Always check for gtk2 when building the plugin

process.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • PluginProcess/gtk/PluginProcessMainGtk.cpp: Added.

(WebKit::PluginProcessMainGtk):

  • PluginProcess/gtk/PluginProcessMainGtk.h: Added.
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::moduleMixesGtkSymbols):

  • gtk/PluginMainGtk.cpp: Added.

(main):

10:45 AM Changeset in webkit [91014] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebCore

Move subtreeHasChanged from RenderTextControl to HTMLTextFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=64476

Reviewed by Kent Tamura.

Moved subtreeHasChanged from RenderTextControl, RenderTextControlSingleLine, and
RenderTextControlMultiLine to HTMLTextFormControlElement, HTMLInputElement, and
HTMLTextAreaElement. Also moved m_searchEventTimer and related functions from
RenderTextSingleLine to SearchInputType.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): Moved from RenderTextControlSingleLine.
(WebCore::HTMLInputElement::onSearch): Calls stopSearchEventTimer.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::subtreeHasChanged): Moved from RenderTextMultiLine.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::defaultEventHandler): Calls subtreeHasChanged.
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Added; calls respondToChangeByUser.

  • html/HTMLTextFormControlElement.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType): Initializes m_searchEventTimer.
(WebCore::SearchInputType::startSearchEventTimer): Moved from RenderTextControlSingleLine.
(WebCore::SearchInputType::stopSearchEventTimer): Ditto.
(WebCore::SearchInputType::searchEventTimerFired): Ditto.

  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Updated comment.

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:

(WebCore::RenderTextControl::respondToChangeByUser): Renamed from subtreeHasChanged.

  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): No longer initializes
m_searchEventTimer.

  • rendering/RenderTextControlSingleLine.h:
10:44 AM Changeset in webkit [91013] by Carlos Garcia Campos
  • 10 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

Implement plugin process for UNIX platform
​https://bugs.webkit.org/show_bug.cgi?id=60629

  • Platform/CoreIPC/Attachment.h:
  • Platform/CoreIPC/unix/AttachmentUnix.cpp:

(CoreIPC::Attachment::Attachment): Add the ability to pass a
socket via Attachment.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::encode): Remove assertions that
check that the Handle is not null. In
PluginProxy::geometryDidChange we pass a null Handle if we do not
need to allocate a new backing store.
(WebKit::SharedMemory::Handle::releaseToAttachment): Ditto.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection): Use
Attachment. Set up the connection with socketpair.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Use Attachment to pass the connection.

10:42 AM Changeset in webkit [91012] by adachan@apple.com
  • 8 edits in trunk/Source/WebKit2

Implement support to center selection on a page for WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=64481

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp: (WKPageCenterSelectionInVisibleArea): Added. Call WebPageProxy::centerSelectionInVisibleArea().
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::centerSelectionInVisibleArea): Send message to the WebProcess to center selection.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::centerSelectionInVisibleArea): Get the FrameSelection from the main frame and call revealSelection() to center it.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add the CenterSelectionInVisibleArea message.
10:40 AM Changeset in webkit [91011] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-07-14 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r90953.

  • WebKitTestRunner/GNUmakefile.am:
10:32 AM Changeset in webkit [91010] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

DFG JIT unnecessarily boxes and unboxes values during silent spilling.
​https://bugs.webkit.org/show_bug.cgi?id=64068

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Silent spilling and filling of registers is done during slow-path C
function calls. The silent spill/fill logic does not affect register
allocation on paths that don't involve the C function call.

This changes the silent spilling code to spill in unboxed form. The
silent fill will refill in whatever form the register was spilled in.
For example, the silent spill code may choose not to spill the register
because it was already spilled previously, which would imply that it
was spilled in boxed form. The filling code detects this and either
unboxes, or not, depending on what is appropriate.

This change also results in a simplification of the silent spill/fill
API: silent spilling no longer needs to know about the set of registers
that cannot be trampled, since it never does boxing and hence does not
need a temporary register.

  • dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:24 AM Changeset in webkit [91009] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic results pane should be more discoverable
​https://bugs.webkit.org/show_bug.cgi?id=64513

Reviewed by Eric Seidel.

This patch causes us to trigger the results pane on mouse clicks
instead of mousein. Also, handle the case of no results details more
elegantly.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    • Change the binding to "click".
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    • Handle the "no results URLs" case explicitly instead of never calling the callback.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    • Show a message when there are no result details to show.
  • Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
10:15 AM Changeset in webkit [91008] by vsevik@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Move XML errors handling out from XMLDocumentParser (refactoring).
​https://bugs.webkit.org/show_bug.cgi?id=64305

XML errors handling logic is moved out from XMLDocumentParser to allow using it for XSLT error handling as well.

Reviewed by Adam Barth.

No tests needed as there is no new functionality added.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/XMLErrors.cpp: Added.

(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/XMLErrors.h: Added.
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::error):
(WebCore::warningHandler):
(WebCore::fatalErrorHandler):
(WebCore::normalErrorHandler):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseDtd):

10:09 AM Changeset in webkit [91007] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should badge TIMEOUT failures
​https://bugs.webkit.org/show_bug.cgi?id=64435

Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:

(.regression .what a[draggable].TIMEOUT::before):

  • Add TIMEOUT.
9:59 AM Changeset in webkit [91006] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=64356

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):

  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._frameNavigated):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):

  • loader/FrameLoader.h:
9:57 AM Changeset in webkit [91005] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Clear SVGElementInstance's children immediately upon detachment
​https://bugs.webkit.org/show_bug.cgi?id=63739
<rdar://problem/9705708>

Patch by Tim Horton <​timothy_horton@apple.com> on 2011-07-14
Reviewed by Nikolas Zimmermann.

In addition to clearing the instance's children in the destructor,
clear them when the instance is detached from its <use>. This way,
we won't attempt to use them after we're detached but before the
destructor has been called.

Source/WebCore:

Test: svg/custom/use-crash-using-children-before-destroy.svg

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):

  • svg/SVGElementInstance.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::detachInstance):

LayoutTests:

  • svg/custom/use-crash-using-children-before-destroy-expected.txt: Added.
  • svg/custom/use-crash-using-children-before-destroy.svg: Added.
9:42 AM Changeset in webkit [91004] by isherman@chromium.org
  • 8 edits
    3 moves in trunk/Source/WebKit/chromium

Rename AutoFill -> Autofill and autoFill -> autofill
​https://bugs.webkit.org/show_bug.cgi?id=64333
​http://code.google.com/p/chromium/issues/detail?id=72758

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebAutofillClient.h:

(WebKit::WebAutofillClient::didAcceptAutofillSuggestion):
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
(WebKit::WebAutofillClient::didClearAutofillSelection):
(WebKit::WebAutofillClient::removeAutocompleteSuggestion):
(WebKit::WebAutofillClient::textFieldDidBeginEditing):
(WebKit::WebAutofillClient::textFieldDidEndEditing):
(WebKit::WebAutofillClient::textFieldDidChange):
(WebKit::WebAutofillClient::textFieldDidReceiveKeyDown):
(WebKit::WebAutofillClient::~WebAutofillClient):

  • public/WebNode.h:
  • public/WebView.h:
  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::~AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::selectionCleared):
(WebKit::AutofillPopupMenuClient::itemText):
(WebKit::AutofillPopupMenuClient::itemLabel):
(WebKit::AutofillPopupMenuClient::itemIcon):
(WebKit::AutofillPopupMenuClient::itemIsEnabled):
(WebKit::AutofillPopupMenuClient::itemStyle):
(WebKit::AutofillPopupMenuClient::menuStyle):
(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):
(WebKit::AutofillPopupMenuClient::popupDidHide):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::setTextFromItem):
(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::hostWindow):
(WebKit::AutofillPopupMenuClient::createScrollbar):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
(WebKit::AutofillPopupMenuClient::convertListIndexToInternalIndex):
(WebKit::AutofillPopupMenuClient::getWebView):
(WebKit::AutofillPopupMenuClient::textFieldStyle):

  • src/AutofillPopupMenuClient.h:

(WebKit::AutofillPopupMenuClient::itemToolTip):
(WebKit::AutofillPopupMenuClient::itemAccessibilityText):
(WebKit::AutofillPopupMenuClient::clientInsetLeft):
(WebKit::AutofillPopupMenuClient::clientInsetRight):
(WebKit::AutofillPopupMenuClient::listSize):
(WebKit::AutofillPopupMenuClient::selectedIndex):
(WebKit::AutofillPopupMenuClient::itemIsLabel):
(WebKit::AutofillPopupMenuClient::itemIsSelected):
(WebKit::AutofillPopupMenuClient::shouldPopOver):
(WebKit::AutofillPopupMenuClient::valueShouldChangeOnHotTrack):
(WebKit::AutofillPopupMenuClient::getTextField):
(WebKit::AutofillPopupMenuClient::getSelectedIndex):
(WebKit::AutofillPopupMenuClient::setSelectedIndex):

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doAutofill):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setAutofilled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setAutofillClient):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::autocompleteHandleKeyEvent):
(WebKit::WebViewImpl::hideAutofillPopup):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::hidePopups):
(WebKit::WebViewImpl::refreshAutofillPopup):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::autofillClient):
(WebKit::WebViewImpl::autofillPopupDidHide):

9:29 AM Changeset in webkit [91003] by Nate Chapin
  • 3 edits
    1 add in trunk/Source/WebCore

Don't skip custom cursors if an Image* is null,
since this can lead to a non-custom Cursor flickering
back in when the custom cursor hasn't finished loading yet.
​https://bugs.webkit.org/show_bug.cgi?id=64321

Reviewed by Darin Fisher.

Manual test, since we're testing visual flickering.

  • manual-tests/canvas-cursor.html: Added.
  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • platform/Cursor.cpp:

(WebCore::determineHotSpot):

9:20 AM Changeset in webkit [91002] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Patch by Young Han Lee <​joybro@company100.net> on 2011-07-14
Reviewed by Dirk Schulze.

REGRESSION (r89774): svg/W3C-SVG-1.1/animate-elem-82-t.svg hits assertion failure.
​https://bugs.webkit.org/show_bug.cgi?id=63911

Some functions assumed calculateKeyTimesIndex() does not return the last index of
the keyTimes, but it would be right behavior for calculateKeyTimesIndex() when it
accepts 1 as the percent argument.

To avoid the assumption, and for more efficiency, this patch allows the functions
using calculateKeyTimesIndex() to return early when it accepts 1 as the percent argument.
These functions have always returned the last element of the corresponding vector
in that situation.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

9:00 AM Changeset in webkit [91001] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix Python exception blocking the commit-queue.

  • Scripts/webkitpy/common/checkout/scm/git.py:
7:54 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt and Mobility version on 4.8.x trunk bot (diff)
7:47 AM Changeset in webkit [91000] by Csaba Osztrogonác
  • 2 edits
    1184 adds in trunk/LayoutTests

[Qt]Update layout test results for newer Qt 4.8.x
​https://bugs.webkit.org/show_bug.cgi?id=64527

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
​https://bugs.webkit.org/show_bug.cgi?id=60176

  • platform/qt-4.8/[...]: Added.
  • platform/qt-4.8/Skipped: Unskip http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html.
7:39 AM Changeset in webkit [90999] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: URL parameters should consistently use camel case names
​https://bugs.webkit.org/show_bug.cgi?id=64520

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(devtools.domContentLoaded): Now that Chromium side is updated we can remove the old parameter
handling code.

7:04 AM Changeset in webkit [90998] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-14 Xan Lopez <​xlopez@igalia.com>

[GTK] Skip one crashing test in GTK+/debug bots.

  • platform/gtk/Skipped:
6:56 AM Changeset in webkit [90997] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2011-07-14 Xan Lopez <​xlopez@igalia.com>

[GTK] Skip one crashing test in GTK+/debug bots.

  • platform/gtk/Skipped:
6:36 AM Changeset in webkit [90996] by caseq@chromium.org
  • 5 edits
    1 delete in trunk/Source/WebCore

2011-07-14 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: remove more dead code
​https://bugs.webkit.org/show_bug.cgi?id=64524

Reviewed by Yury Semikhatsky.

  • WebCore.gypi:
  • inspector/front-end/SummaryBar.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
6:36 AM Changeset in webkit [90995] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]svg/animations/svgtransform-animation-1.html asserts intermittently
​https://bugs.webkit.org/show_bug.cgi?id=64526

  • platform/qt/test_expectations.txt: Mark the test as flakey crash.
6:30 AM Changeset in webkit [90994] by kov@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.
​https://bugs.webkit.org/show_bug.cgi?id=62935

Patch by Lukasz Slachciak <​l.slachciak@samsung.com> on 2011-07-14
Reviewed by Gustavo Noronha.

WebKit can be build with WEBKITOUTPUTDIR env variable set using build-webkit script.
In this case WEBKITOUTPUDIR may be outside repository structure. This causes testmimehandling and testwebview
to fail because they use external test files in WebKit Source directory.
This bug fixes this issue introducing optional environment variable WEBKITREPODIR
Also coding style in existing functions is fixed.

  • tests/test_utils.c: Coding style fixes.

(testutils_relative_chdir): If WEBKITREPODIR is set, change current directory to it.

  • tests/test_utils.h: Coding style fixes.
6:28 AM Changeset in webkit [90993] by podivilov@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

Web Inspector: add test for css live edit.
​https://bugs.webkit.org/show_bug.cgi?id=64454

Reviewed by Pavel Feldman.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.showResource):

  • http/tests/inspector/live-edit-test.js: Added.

(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):

  • inspector/debugger/live-edit.html:
  • inspector/styles/css-live-edit-expected.txt: Added.
  • inspector/styles/css-live-edit.html: Added.
5:15 AM Changeset in webkit [90992] by yutak@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

WebSocket: Add platform-specific test results for hybi tests
​https://bugs.webkit.org/show_bug.cgi?id=64349

Reviewed by Kent Tamura.

These results are identical to ones in hixie76/ directory.

  • platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt: Added.
  • platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt: Added.
  • platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
4:05 AM Changeset in webkit [90991] by pvarga@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][V8] Build fix after r90830.

Reviewed by Csaba Osztrogonác.

The histogramEnumeration() function isn't available from the Qt port's
PlatformBridge.h because this function is Chromium specific.
Since the ​http://trac.webkit.org/changeset/90830 change we need to
guard the usage of the histogramEnumeration() function.

No new tests needed.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::recordActionTakenCallback):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallback):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallback):

3:06 AM Changeset in webkit [90990] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: URL parameters should consistently use camel case names
​https://bugs.webkit.org/show_bug.cgi?id=64520

Reviewed by Pavel Feldman.

  • src/js/DevTools.js:

(devtools.domContentLoaded):

2:47 AM Changeset in webkit [90989] by Csaba Osztrogonác
  • 15 edits
    6 adds in trunk/LayoutTests

[Qt] Update platform specific expected results after r90971.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.png:
  • platform/qt/fast/forms/input-placeholder-text-indent-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/password-placeholder-expected.png: Added.
  • platform/qt/fast/forms/password-placeholder-expected.txt:
  • platform/qt/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/qt/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/qt/fast/forms/placeholder-set-attribute-expected.png: Added.
  • platform/qt/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/placeholder-stripped-expected.png:
  • platform/qt/fast/forms/placeholder-stripped-expected.txt:
  • platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.png: Added.
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/test_expectations.txt:
2:16 AM Changeset in webkit [90988] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: show only Console and Scripts panels in shared worker inspector front-end
​https://bugs.webkit.org/show_bug.cgi?id=64519

Reviewed by Pavel Feldman.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):
(WebInspector.WorkerManager.isWorkerFrontend):
(WebInspector.WorkerManager.isSharedWorkerFrontend):
(WebInspector.WorkerManager.prototype._openInspectorWindow):
(WebInspector.DedicatedWorkerMessageForwarder):

2:00 AM Changeset in webkit [90987] by morrita@google.com
  • 23 edits
    2 deletes in trunk

Unreviewed, rolling out r90976, r90981, and r90985.
​http://trac.webkit.org/changeset/90976
​http://trac.webkit.org/changeset/90981
​http://trac.webkit.org/changeset/90985
​https://bugs.webkit.org/show_bug.cgi?id=64251

build break

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/NodeRenderingContext.h:
  • dom/ShadowContentElement.cpp:

(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):

  • dom/ShadowContentElement.h:
  • dom/ShadowContentSelector.cpp:

(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):
(WebCore::ShadowContentSelector::willAttachContentFor):
(WebCore::ShadowContentSelector::didAttachContent):
(WebCore::ShadowContentSelector::activeElement):

  • dom/ShadowContentSelector.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::activeContentElement):

  • dom/ShadowRoot.h:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/content-element-includer-expected.txt: Removed.
  • fast/dom/shadow/content-element-includer.html: Removed.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
1:54 AM Changeset in webkit [90986] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/test_expectations.txt: Remove a passing test.
1:08 AM Changeset in webkit [90985] by morrita@google.com
  • 2 edits in trunk

Unreviewed attempt to build fix.

  • Source/autotools/symbols.filter:
12:26 AM Changeset in webkit [90984] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Make an entry for input-appearance-range.html specific.

  • platform/chromium/test_expectations.txt:
12:08 AM Changeset in webkit [90983] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=64475

Reviewed by Kent Tamura.

Moved forwardEvent from RenderTextControl, RenderTextControlSingleLine, and RenderTextControlMultiLine
to HTMLTextFormControlElement, HTMLInputElement, and HTMLTextAreaElement.

This removes the last dependency on Event.h and EventNames.h in the cpp files for the above render
objects classes.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::forwardEvent):

  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTextControlSingleLine.h:
Note: See TracTimeline for information about the timeline view.