Timeline



Jul 26, 2011:

11:02 PM Changeset in webkit [91824] by commit-queue@webkit.org
  • 7 edits in trunk

reduce and reduceRight bind callback's this to null rather than undefined
​https://bugs.webkit.org/show_bug.cgi?id=62264

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed Array.prototype.reduce and Array.prototype.reduceRight so that they behave correctly
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

LayoutTests:

Added additional tests to test Array.prototype.reduce and Array.prototype.reduceRight
when calling the callback function without an argument for this, which means it should
be undefined according to ES 15.4.4.21 and 15.4.4.22.

  • fast/js/array-reduce-expected.txt:
  • fast/js/array-reduceRight-expected.txt:
  • fast/js/script-tests/array-reduce.js:
  • fast/js/script-tests/array-reduceRight.js:
8:48 PM Changeset in webkit [91823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context
​https://bugs.webkit.org/show_bug.cgi?id=65224

Patch by James Robinson <​jamesr@chromium.org> on 2011-07-26
Reviewed by Kenneth Russell.

There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
page and kill the GPU process.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::cleanupResources):

  • platform/graphics/chromium/ContentLayerChromium.h:
8:42 PM Changeset in webkit [91822] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r91805.
​http://trac.webkit.org/changeset/91805
​https://bugs.webkit.org/show_bug.cgi?id=65226

Breaks @ symbols and changes other font rendering on Windows
(Requested by enne on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

  • platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
8:18 PM Changeset in webkit [91821] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r91812.
​http://trac.webkit.org/changeset/91812
​https://bugs.webkit.org/show_bug.cgi?id=65210

Breaks OSX GPU tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

8:05 PM Changeset in webkit [91820] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog.

8:01 PM Changeset in webkit [91819] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

enne tells me that she already rebaselined this test. The 10.5 bot is
just behind because dglazkov broke NRWT on Python 2.5.

  • platform/chromium/test_expectations.txt:
7:59 PM Changeset in webkit [91818] by abarth@webkit.org
  • 2 edits in trunk/Tools

Switch to an older idiom that works on Python 2.5.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:
7:56 PM Changeset in webkit [91817] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC command-line tool does not come with any facility for
measuring time precisely.
​https://bugs.webkit.org/show_bug.cgi?id=65223

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

Exposed WTF::currentTime() as currentTimePrecise().

  • jsc.cpp:

(GlobalObject::GlobalObject):
(functionPreciseTime):

7:48 PM Changeset in webkit [91816] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r91809.
​http://trac.webkit.org/changeset/91809
​https://bugs.webkit.org/show_bug.cgi?id=65225

Does not build on Chromium Windows (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-26

Source/WebCore:

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • platform/PlatformGestureEvent.h:
  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):

  • platform/chromium/GestureRecognizerChromium.h:

(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):

  • platform/chromium/PopupMenuChromium.cpp:
  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:
7:45 PM Changeset in webkit [91815] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Fix pointer operator coding style in ewk_view.
​https://bugs.webkit.org/show_bug.cgi?id=65163

Move '*' operator to variable according to efl coding style. In addition,
add a space between * and variable in type casting.

Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(_ewk_view_smart_changed):
(_ewk_view_repaints_resize):
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scrolls_resize):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_smart_add_console_message):
(_ewk_view_smart_run_javascript_alert):
(_ewk_view_smart_run_javascript_confirm):
(_ewk_view_smart_should_interrupt_javascript):
(_ewk_view_smart_run_javascript_prompt):
(_ewk_view_on_focus_in):
(_ewk_view_on_focus_out):
(_ewk_view_on_mouse_wheel):
(_ewk_view_on_mouse_down):
(_ewk_view_on_mouse_up):
(_ewk_view_on_mouse_move):
(_ewk_view_on_key_down):
(_ewk_view_on_key_up):
(_ewk_view_core_frame_new):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_resize):
(_ewk_view_smart_move):
(_ewk_view_smart_calculate):
(_ewk_view_smart_contents_resize):
(_ewk_view_smart_zoom_set):
(_ewk_view_smart_flush):
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_zoom_animated_mark_stop):
(_ewk_view_zoom_animated_finish):
(_ewk_view_zoom_animated_current):
(_ewk_view_zoom_animator_cb):
(_ewk_view_zoom_animation_start):
(_ewk_view_viewport_attributes_compute):
(ewk_view_base_smart_set):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_frame_main_get):
(ewk_view_frame_focused_get):
(ewk_view_uri_set):
(ewk_view_uri_get):
(ewk_view_title_get):
(ewk_view_editable_get):
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
(ewk_view_text_search):
(ewk_view_text_matches_mark):
(ewk_view_text_matches_unmark_all):
(ewk_view_text_matches_highlight_set):
(ewk_view_text_matches_highlight_get):
(ewk_view_editable_set):
(ewk_view_selection_get):
(_ewk_view_editor_command):
(ewk_view_execute_editor_command):
(ewk_view_context_menu_forward_event):
(ewk_view_load_progress_get):
(ewk_view_stop):
(ewk_view_reload):
(ewk_view_reload_full):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_navigate):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_navigate_possible):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):
(ewk_view_zoom_get):
(ewk_view_zoom_set):
(ewk_view_zoom_weak_smooth_scale_get):
(ewk_view_zoom_weak_smooth_scale_set):
(ewk_view_zoom_weak_set):
(ewk_view_zoom_animated_mark_start):
(ewk_view_zoom_animated_mark_end):
(ewk_view_zoom_animated_mark_current):
(ewk_view_zoom_animated_mark_stop):
(ewk_view_zoom_animated_set):
(ewk_view_zoom_text_only_get):
(ewk_view_zoom_text_only_set):
(ewk_view_pre_render_region):
(ewk_view_pre_render_relative_radius):
(ewk_view_pre_render_cancel):
(ewk_view_setting_user_agent_get):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_get):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_get):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_get):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_auto_resize_window_get):
(ewk_view_setting_enable_auto_resize_window_set):
(ewk_view_setting_enable_scripts_get):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_get):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_get):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_window_open_get):
(ewk_view_setting_scripts_window_open_set):
(ewk_view_setting_resizable_textareas_get):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_get):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_offline_app_cache_get):
(ewk_view_setting_offline_app_cache_set):
(ewk_view_setting_caret_browsing_get):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_setting_encoding_default_get):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_encoding_detector_get):
(ewk_view_setting_enable_developer_extras_get):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_get):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_get):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_get):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_get):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_setting_font_standard_get):
(ewk_view_setting_font_standard_set):
(ewk_view_setting_font_cursive_get):
(ewk_view_setting_font_cursive_set):
(ewk_view_setting_font_fantasy_get):
(ewk_view_setting_font_fantasy_set):
(ewk_view_setting_font_monospace_get):
(ewk_view_setting_font_monospace_set):
(ewk_view_setting_font_serif_get):
(ewk_view_setting_font_serif_set):
(ewk_view_setting_font_sans_serif_get):
(ewk_view_setting_font_sans_serif_set):
(ewk_view_setting_spatial_navigation_get):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_get):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_get):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_get):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_smart_data_get):
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
(ewk_view_repaint_add):
(ewk_view_layout_if_needed_recursive):
(ewk_view_scrolls_process):
(ewk_view_paint_context_new):
(ewk_view_paint_context_free):
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):
(ewk_view_paint_context_scale):
(ewk_view_paint_context_translate):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_ready):
(ewk_view_input_method_state_set):
(ewk_view_title_set):
(ewk_view_uri_changed):
(ewk_view_load_started):
(ewk_view_frame_main_load_started):
(ewk_view_load_provisional):
(ewk_view_load_show):
(ewk_view_frame_main_cleared):
(ewk_view_frame_main_icon_received):
(ewk_view_load_finished):
(ewk_view_load_error):
(ewk_view_load_progress_changed):
(ewk_view_restore_state):
(ewk_view_window_create):
(ewk_view_window_close):
(ewk_view_mouse_link_hover_in):
(ewk_view_mouse_link_hover_out):
(ewk_view_toolbars_visible_set):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_set):
(ewk_view_statusbar_visible_get):
(ewk_view_statusbar_text_set):
(ewk_view_scrollbars_visible_set):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_set):
(ewk_view_menubar_visible_get):
(ewk_view_tooltip_text_set):
(ewk_view_add_console_message):
(ewk_view_run_javascript_alert):
(ewk_view_run_javascript_confirm):
(ewk_view_run_javascript_prompt):
(ewk_view_should_interrupt_javascript):
(ewk_view_exceeded_database_quota):
(ewk_view_run_open_panel):
(ewk_view_repaint):
(ewk_view_scroll):
(ewk_view_core_page_get):
(ewk_view_frame_create):
(ewk_view_plugin_create):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(ewk_view_popup_selected_set):
(ewk_view_download_request):
(ewk_view_viewport_attributes_set):
(ewk_view_viewport_attributes_get):
(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_need_touch_events_set):
(ewk_view_need_touch_events_get):
(ewk_view_mode_set):
(ewk_view_mode_get):
(ewk_view_editor_client_selection_changed):

  • ewk/ewk_view.h:
7:41 PM Changeset in webkit [91814] by dslomov@google.com
  • 11 edits in trunk/Source/WebCore

[V8][Chromium] Run workers in a separate v8::Isolate
​https://bugs.webkit.org/show_bug.cgi?id=65004
This patch allocates a new v8::Isolate for every worker and enters it on worker thread.

Reviewed by David Levin.

Covered by existing chromium tests.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):
(WebCore::StaticDOMDataStore::~StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8Binding.h:

(WebCore::V8BindingPerIsolateData::registerDOMDataStore):
(WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
(WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):

  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):

  • bindings/v8/WorkerScriptController.h:
7:37 PM Changeset in webkit [91813] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test appears to fail on Leopard only.

  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [91812] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Avoid clearing the framebuffer when compositing in release builds
​https://bugs.webkit.org/show_bug.cgi?id=65210

Reviewed by Kenneth Russell.

We clear the default framebuffer to blue when compositing so it's
easier to spot regions we miss. This is useful for debugging, but eats
bandwidth unnecessarily in release builds.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawLayers):

7:25 PM Changeset in webkit [91811] by jpfau@apple.com
  • 9 edits
    2 adds in trunk/Source/WebCore

New XML tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=64566

Reviewed by Adam Barth.

Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/parser/NewXMLDocumentParser.cpp:

(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):

  • xml/parser/NewXMLDocumentParser.h:
  • xml/parser/XMLToken.h:
  • xml/parser/XMLTokenizer.cpp: Added.

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::XMLTokenizer::nextToken):
(WebCore::XMLTokenizer::bufferCharacter):
(WebCore::XMLTokenizer::parseError):

  • xml/parser/XMLTokenizer.h: Added.

(WebCore::XMLTokenizer::create):
(WebCore::XMLTokenizer::gotError):
(WebCore::XMLTokenizer::shouldSkipNullCharacters):

7:02 PM Changeset in webkit [91810] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Add an exception to coding style check for EFL port.
​https://bugs.webkit.org/show_bug.cgi?id=65162

Add an exception of whitespace/declaration for EFL port. Because,
'*' operator is next to variable in EFL coding style.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/style/checker.py:
6:52 PM Changeset in webkit [91809] by commit-queue@webkit.org
  • 21 edits in trunk/Source

[chromium] Layering violations in gesture recognizer
​https://bugs.webkit.org/show_bug.cgi?id=65044

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.

  • platform/PlatformGestureRecognizer.h:
  • platform/chromium/FramelessScrollView.h:

Added support for displatching gesture and touch events.

  • platform/chromium/GestureRecognizerChromium.cpp:

(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):

  • platform/chromium/GestureRecognizerChromium.h:
  • platform/chromium/PopupMenuChromium.cpp:

Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):

  • platform/chromium/PopupMenuChromium.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.

Source/WebKit/chromium:

Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.

  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.

  • src/WebPopupMenuImpl.cpp:

Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):

  • src/WebViewImpl.h:
6:38 PM Changeset in webkit [91808] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Restore Composited Layers Faster from PageCache
​https://bugs.webkit.org/show_bug.cgi?id=65216

Reviewed by Simon Fraser.

Restore the layer tree hierarchy a little sooner, when
restoring from the page cache. This more closely matches
original restore behavior.

Existing test showed no change.

  • page/FrameView.cpp:

(WebCore::FrameView::restoreBackingStores):

6:27 PM Changeset in webkit [91807] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG speculative JIT never emits inline double comparisons, even when it
would be obvious more efficient to do so.
​https://bugs.webkit.org/show_bug.cgi?id=65212

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This handles the obvious case of inlining double comparisons: it only addresses
the speculative JIT, and only for fused compare/branch sequences. But it does
handle the case where both operands are double (and there is no slow path),
or where one operand is double and the other is unknown type (in which case it
attempts to unbox the double, otherwise taking slow path). This is an 0.8%
speed-up on SunSpider.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

6:12 PM Changeset in webkit [91806] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] Add option to turn on disk caching in QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <​keith.kyzivat@nokia.com> on 2011-07-26
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

6:10 PM Changeset in webkit [91805] by commit-queue@webkit.org
  • 8 edits in trunk

[skia] never draw with GDI, so that all text can be gpu-accelerated
​https://bugs.webkit.org/show_bug.cgi?id=65203

Patch by Mike Reed <​reed@google.com> on 2011-07-26
Reviewed by Kenneth Russell.

No new tests. existing tests apply to the new drawing path

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):

5:55 PM Changeset in webkit [91804] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=64969
DFG JIT generates inefficient code for speculation failures.

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-26
Reviewed by Gavin Barraclough.

This implements a speculation failure strategy where (1) values spilled on
non-speculative but not spilled on speculative are spilled, (2) values that
are in registers on both paths are rearranged without ever touching memory,
and (3) values spilled on speculative but not spilled on non-speculative are
filled.

The register shuffling is the most interesting part of this patch. It
constructs a permutation graph for registers. Each node represents a
register, and each directed edge corresponds to the register's value having
to be moved to a different register as part of the shuffling. This is a
directed graph where each node may only have 0 or 1 incoming edges, and
0 or 1 outgoing edges. The algorithm then first finds maximal non-cyclic
subgraphs where all nodes in the subgraph are reachable from a start node.
Such subgraphs always resemble linked lists, and correspond to simply
moving the value in the second-to-last register into the last register, and
then moving the value in the third-to-last register into the second-to-last
register, and so on. Once these subgraphs are taken care of, the remaining
subgraphs are cycles, and are handled using either (a) conversion or no-op
if the cycle involves one node, (b) swap if it involves two nodes, or (c)
a cyclic shuffle involving a scratch register if there are three or more
nodes.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::GeneralizedRegister::GeneralizedRegister):
(JSC::DFG::GeneralizedRegister::createGPR):
(JSC::DFG::GeneralizedRegister::createFPR):
(JSC::DFG::GeneralizedRegister::dump):
(JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
(JSC::DFG::GeneralizedRegister::findInEntryLocation):
(JSC::DFG::GeneralizedRegister::previousDataFormat):
(JSC::DFG::GeneralizedRegister::nextDataFormat):
(JSC::DFG::GeneralizedRegister::convert):
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::ShuffledRegister):
(JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::ShuffledRegister::lookup):
(JSC::DFG::lookupForRegister):
(JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
(JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
(JSC::DFG::NodeToRegisterMap::set):
(JSC::DFG::NodeToRegisterMap::end):
(JSC::DFG::NodeToRegisterMap::find):
(JSC::DFG::NodeToRegisterMap::clear):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::linkSpeculationChecks):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::EntryLocation::EntryLocation):

  • dfg/DFGNonSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculationCheck::SpeculationCheck):

  • dfg/DFGSpeculativeJIT.h:
5:53 PM Changeset in webkit [91803] by kbr@google.com
  • 6 edits in trunk

Float32Array(ArrayBuffer, index, length) constructor working incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=57042

Reviewed by James Robinson.

Source/WebCore:

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferViewWithArrayBufferArgument):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
5:25 PM Changeset in webkit [91802] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
​https://bugs.webkit.org/show_bug.cgi?id=65222

Reviewed by James Robinson.

No new tests - this fixes upcoming audionode.html layout test

  • bindings/v8/custom/V8AudioNodeCustom.cpp:

(WebCore::V8AudioNode::connectCallback):

5:15 PM Changeset in webkit [91801] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

AudioContext is not correctly accounting for hardware resources
​https://bugs.webkit.org/show_bug.cgi?id=65217

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lazyInitialize):

5:14 PM Changeset in webkit [91800] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty
​https://bugs.webkit.org/show_bug.cgi?id=65164

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

Add casts to/from various numeric types.
(WebCore::CSSPrimitiveValue::operator short):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator float):

  • css/CSSStyleApplyProperty.cpp:

Add class to handle properties that set an "auto" boolean on RenderStyle.
(WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

Remove existing implementations.
(WebCore::CSSStyleSelector::applyProperty):

4:43 PM Changeset in webkit [91799] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

Add protection space authentication callback code to CFNetwork loader on Mac
​https://bugs.webkit.org/show_bug.cgi?id=65190
<rdar://problem/9842424>

Reviewed by Oliver Hunt.

Port over protection space authentication callback code from ResourceHandleMac.mm to
ResourceHandleCFNet.cpp.

  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::canRespondToProtectionSpace):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.

4:30 PM Changeset in webkit [91798] by enne@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

[chromium] Check in expectations for font-family-pictograph.
​https://bugs.webkit.org/show_bug.cgi?id=65197

Unreviewed gardening.

  • platform/chromium-linux/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-linux/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.png: Added.
  • platform/chromium-win/fast/css/font-family-pictograph-expected.txt: Added.
4:25 PM Changeset in webkit [91797] by abarth@webkit.org
  • 46 edits
    8 adds in trunk

Add support for download='filename' attribute in anchors.
​https://bugs.webkit.org/show_bug.cgi?id=64580

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

Source/WebCore:

The download attribute allows the author of the hyperlink to cause the
browser to download the linked URL. The author can also supply a
suggested file name in the attribute value. This feature is a recent
addition to HTML to better support offline applications that use blob
URLs. Traditionally, web sites use the HTTP Content-Disposition header
to trigger downloads, but that option isn't available when working
offline.

There is some question about whether we should initiate a download when
we receive a DOM-created click event. This patch does initiate the
download, but we might revise that decision in the future as part of a
larger change in how WebKit treats the interaction between default
event handlers and DOM-created events.

Tests: fast/dom/HTMLAnchorElement/anchor-download.html

fast/dom/HTMLAnchorElement/anchor-nodownload.html
fast/dom/HTMLAnchorElement/anchor-download-unset.html
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAttributeNames.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::startDownload):

  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebFrameClient.h:

(WebKit::WebFrameClient::loadURLExternally):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientImpl::startDownload):

  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::startDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::startDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::startDownload):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::startDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::startDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::startDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::startDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::startDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::loadURLExternally):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.
4:18 PM Changeset in webkit [91796] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark webaudio/test-basic as crashing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=65219.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:47 PM Changeset in webkit [91795] by oliver@apple.com
  • 4 edits in trunk

Buffer overflow creating error messages for JSON.parse
​https://bugs.webkit.org/show_bug.cgi?id=65211

Reviewed by Darin Adler.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Update testcase to reflect actual expected output.

  • fast/js/JSON-parse-expected.txt:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Parse string length to the UString constructor.

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::parse):

3:23 PM Changeset in webkit [91794] by mitz@apple.com
  • 5 edits in trunk/Tools

Rubber-stamped by Anders Carlsson.

Update DumpRenderTree and API tests for the pictograph font family preference.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

3:08 PM Changeset in webkit [91793] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Apply r40940 to WebKit2 to work around a Silverlight crash.
​https://bugs.webkit.org/show_bug.cgi?id=65205
<rdar://problem/9058370>

Patch by Tim Horton <​timothy_horton@apple.com> on 2011-07-26
Reviewed by Anders Carlsson.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

3:07 PM Changeset in webkit [91792] by Dimitri Glazkov
  • 7 edits in trunk/Tools

Replace SpecificityCalculator with TestConfiguration-driven logic.
​https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with

test configuration matching, removed a bunch of code.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance

was created. 'default' is not a valid build type.

  • Scripts/webkitpy/layout_tests/port/test.py: Ditto. is not a valid version.
3:04 PM Changeset in webkit [91791] by abarth@webkit.org
  • 4 edits in trunk/Tools

Increase the information density in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=65141

Reviewed by Dimitri Glazkov.

This patch changes lets us show each revision on a single line,
allowing use to show an entire day's worth of commits at once.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2:56 PM Changeset in webkit [91790] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Refactor automatically generated JS DOM bindings to replace operator new with static create methods
​https://bugs.webkit.org/show_bug.cgi?id=64732

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Replacing the public constructors in the automatically generated JS DOM bindings with static
create methods. JSByteArray is used by several of these bindings in WebCore.

(JSC::JSByteArray::create):

  • runtime/JSByteArray.h:

Source/WebCore:

No new tests.

Replacing the public constructors in the automatically generated JS DOM bindings in CodeGeneratorJS.pm
with static create methods. This is part of a larger refactoring effort to use static create methods
in the headers of the generated files (so as to be inline-able) in favor of public constructors throughout JSC.

  • bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::create):

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::create):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListener::createPrototype):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterface::createPrototype):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):

  • bridge/jni/jsc/JavaArrayJSC.cpp:

(JavaArray::convertJObjectToArray):

  • bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::newRuntimeObject):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create):

  • bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

2:52 PM Changeset in webkit [91789] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Cancel the load when an associated URL loader goes out of scope.
Previously, the load would continue even when the WebURLLoader object
was deleted, and the data would just get queued up.

​https://bugs.webkit.org/show_bug.cgi?id=65204

Reviewed by Darin Fisher.

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::cancel):

2:51 PM Changeset in webkit [91788] by xji@chromium.org
  • 10 edits in trunk

--webkit-visual-word does not work in multi-line
​https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace Position(node, offset, PositionIsOffsetInAnchor) with
createPositionAvoidingIgnoredNode(node, offset) which takes care of creating position
before/after <br/> etc. editingIgnoresContent node.

When iterate InlineBox, replace prevLeafChild and nextLeafChild (which only returns
InlineBox within the same line) with leftInlineBox and rightInlineBox (which returns
InlineBox across multiple lines).

  • editing/htmlediting.cpp:

(WebCore::createPositionAvoidingIgnoredNode):

  • editing/htmlediting.h:
  • editing/visible_units.cpp:

(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality): Replace Position() with
createPositionAvoidingIgnoredNode().
(WebCore::leftmostPositionInRTLBoxInLTRBlock): Ditto.
(WebCore::rightmostPositionInLTRBoxInRTLBlock): Ditto.
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality): Ditto.
(WebCore::blockWithPreviousLineBox): Added.
(WebCore::previousRootInlineBox): Added.
(WebCore::blockWithNextLineBox): Added.
(WebCore::nextRootInlineBox): Added.
(WebCore::leftInlineBox): Added.
(WebCore::rightInlineBox): Added.
(WebCore::leftWordBoundary): Replace prevLeafChild/nextLeafChild with leftInlineBox()
and rightInlineBox().
(WebCore::rightWordBoundary): Ditto.
(WebCore::leftWordPositionAcrossBoundary): Ditto.
(WebCore::rightWordPositionAcrossBoundary): Ditto.

LayoutTests:

Add test for multiple-line.

  • editing/selection/move-by-word-visually-null-box.html:
  • editing/selection/move-by-word-visually-others-expected.txt:
  • editing/selection/move-by-word-visually-others.html: Add tests for multi-line. Shorten

test id.

  • editing/selection/move-by-word-visually-single-space-sigle-line.html: Shorten test id.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordForEveryPosition):
(setWidth):
(runMoveLeftRight):

2:49 PM Changeset in webkit [91787] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Qt/Linux.

On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to ​http://trac.webkit.org/changeset/91752.

  • wtf/wtf.pri:
2:44 PM Changeset in webkit [91786] by Dimitri Glazkov
  • 3 edits in trunk/Tools

TestConfigurationConverter should not barf on invalid specifiers.
​https://bugs.webkit.org/show_bug.cgi?id=65194

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,

made it return empty set whenever an invalid specifier is encountered.

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
2:42 PM Changeset in webkit [91785] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Introduce a way to convert between specifier lists and TestConfiguration sets.
​https://bugs.webkit.org/show_bug.cgi?id=65094

Add TestConfigurationConverter, a facility to convert:
1) a set of specifiers into a set of TestConfiguration instances;
2) a set of TestConfiguration instances into a list of sets of specifiers.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
2:37 PM Changeset in webkit [91784] by kerz@chromium.org
  • 3 edits in branches/chromium/835/Source/WebCore/platform/graphics/chromium

Merge 91720 - [Chromium] Use correct vertex shader when rendering video layer.
​https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <​reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

TBR=​commit-queue@webkit.org
Review URL: ​http://codereview.chromium.org/7477025

2:26 PM Changeset in webkit [91783] by kerz@chromium.org
  • 1 add in branches/chromium/835/codereview.settings

add codereview settings file for chromium 835 branch

2:17 PM Changeset in webkit [91782] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
​https://bugs.webkit.org/show_bug.cgi?id=65171

Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-26
Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
1:39 PM Changeset in webkit [91781] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=60778

Use after free because of line box culling optimization regression.

In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.

The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.

The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.

Reviewed by Dan Bernstein.

Added editing/execCommand/crash-line-break-after-outdent.html

Source/WebCore:

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

  • editing/execCommand/crash-line-break-after-outdent-expected.txt: Added.
  • editing/execCommand/crash-line-break-after-outdent.html: Added.
1:36 PM Changeset in webkit [91780] by crogers@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

Add first basic layout test for the web audio API
​https://bugs.webkit.org/show_bug.cgi?id=57977

Reviewed by Tony Chang.

  • webaudio: Added.
  • webaudio/resources: Added.
  • webaudio/resources/audio-testing.js: Added.

(writeString):
(writeInt16):
(writeInt32):
(writeAudioBuffer):
(createWaveFileData):
(createAudioData):
(finishAudioTest):

  • webaudio/test-basic-expected.wav: Added.
  • webaudio/test-basic.html: Added.
1:28 PM Changeset in webkit [91779] by crogers@google.com
  • 2 edits in trunk/Tools

Avoid outputting #EOF twice for web audio tests in chromium DRT
​https://bugs.webkit.org/show_bug.cgi?id=65201

Reviewed by Dirk Pranke.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

1:27 PM Changeset in webkit [91778] by mitz@apple.com
  • 2 edits in trunk

Fix change log typos

1:23 PM Changeset in webkit [91777] by mitz@apple.com
  • 28 edits
    3 adds in trunk

Source/WebCore: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
​https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

Test: fast/css/font-family-pictograph.html

  • WebCore.exp.in: Export Settings::setPictographFontFamily().
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily): Added -webkit-pictograph.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::fontDataForGenericFamily): Ditto.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Ditto.

  • css/CSSValueKeywords.in:
  • inspector/front-end/CSSKeywordCompletions.js: Ditto.
  • inspector/front-end/SourceCSSTokenizer.js: Ditto.

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
  • page/Settings.cpp:

(WebCore::Settings::pictographFontFamily): Added this getter.
(WebCore::Settings::setPictographFontFamily): Added this setter.

  • page/Settings.h:
  • platform/graphics/FontDescription.h: Added PictographFamily to the GenericFamilyType enum.

Source/WebKit/mac: <rdar://problem/9842889> Add a generic pictograph font family
​https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set the default pictograph font family to
"Apple Color Emoji".
(-[WebPreferences pictographFontFamily]): Added this getter.
(-[WebPreferences setPictographFontFamily:]): Added this setter.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Pass the preference through to WebCore.

Source/WebKit/win: <rdar://problem/9842889> Add a generic pictograph font family
​https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Interfaces/IWebPreferences.idl: Added pictographFontFamily() and

setPictographFontFamily().

  • WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Initialize the pictograph font
preference to "Times New Roman".
(WebPreferences::pictographFontFamily): Added this getter.
(WebPreferences::setPictographFontFamily): Added this setter.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Pass the preference value through to
WebCore.

Source/WebKit2: <rdar://problem/9842889> Add a generic pictograph font family
​https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPictographFontFamily): Added.
(WKPreferencesCopyPictographFontFamily): Added.

  • UIProcess/API/C/WKPreferences.h:

LayoutTests: <rdar://problem/9842889> Add a generic pictograph font family Add a generic pictograph font family
​https://bugs.webkit.org/show_bug.cgi?id=65197

Reviewed by Anders Carlsson.

  • fast/css/font-family-pictograph.html: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.txt: Added.
12:54 PM Changeset in webkit [91776] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91689
BUG=88723
Review URL: ​http://codereview.chromium.org/7470026

12:48 PM Changeset in webkit [91775] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] getClientRects now fails similarly on Mac after r91763.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:37 PM Changeset in webkit [91774] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve (i.e., speed up) .gyp(i) files for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <​viettrungluu@chromium.org> on 2011-07-26
Reviewed by Adam Barth.

This re-applies r91595 with the source exclusion fixed.

Test by building (in all supported configurations).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:26 PM Changeset in webkit [91773] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix accidental duplicate expectation from r91772.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:22 PM Changeset in webkit [91772] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark test as flaky after r91738.
​https://bugs.webkit.org/show_bug.cgi?id=65199

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [91771] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Disable video support on linux if the dependencies are not found.

If we can't find the necessary dependencies to build the GStreamer media player
we disable the video support. This is related to ​http://trac.webkit.org/changeset/91752.

Reviewed by Holger Freyther.

No new tests, it's a build fix.

  • features.pri:
12:13 PM Changeset in webkit [91770] by evan@chromium.org
  • 4 edits in trunk/Source/WebCore

regression: generating CSSValueKeywords should not print by default
​https://bugs.webkit.org/show_bug.cgi?id=65195

Reviewed by Tony Chang.

Some refactoring made some callers no longer pass the final 'beQuiet'
parameter to applyPreprocessor. This flag was only used to print the
input filename anyway, so remove the flag and just make the caller
print the filename if it wants this.

  • bindings/scripts/IDLParser.pm:

(Parse): print before calling applyPreprocessor, if necessary.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): remove the beQuiet flag; just always be quiet.

12:03 PM Changeset in webkit [91769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Do not crash on the isSlider() assert.
​https://bugs.webkit.org/show_bug.cgi?id=65191

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-07-26
Reviewed by Antonio Gomes.

RenderThemeEfl's paintSliderThumb() just forwarded the call to
paintSliderTrack(), which, on its turn, called code that assumed that
object->isSlider() was true. That does not seem to be the case for
slidethumbs, so any page with an <input type="range"> tag would crash
WebKit.

We now do what RenderThemeQt does, and assume everything was properly
done in the call to paintSliderTrack().

No new tests, as this has been uncovered by an existing test.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintSliderThumb):

11:53 AM Changeset in webkit [91768] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SKIA] Make the skia GL context current when drawing text to gpu backed platform context.
​https://bugs.webkit.org/show_bug.cgi?id=65182

Patch by Brian Salomon <​bsalomon@google.com> on 2011-07-26
Reviewed by Stephen White.

No new tests. Not sure how to test wrong-ctx bugs in layout tests.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::paintSkiaText):

11:17 AM Changeset in webkit [91767] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More flaky crashers.
​https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [91766] by abecsi@webkit.org
  • 4 edits in trunk

.: [Qt] [WK2] Disable the build with Qt versions older than 5.0
​https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Source/WebKit.pro: Abort if not using Qt5.

Source/WebKit2: [Qt] [WK2] Disable the build with Qt versions older than 5.0
​https://bugs.webkit.org/show_bug.cgi?id=65189

Reviewed by Csaba Osztrogonác.

  • Platform/qt/ModuleQt.cpp:

(WebKit::Module::platformFunctionPointer): Fix the build for Qt5.

10:53 AM Changeset in webkit [91765] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

JSON errors should be informative
​https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-07-26
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
10:53 AM Changeset in webkit [91764] by kerz@chromium.org
  • 1 copy in branches/chromium/835

Branch webkit for chromium

10:47 AM Changeset in webkit [91763] by eae@chromium.org
  • 6 edits in trunk

RenderText::absoluteRectsForRange() and absoluteQuadsForRange() have nearly duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=62478

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dom/Range/getClientRects.html

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::isZero):
Add izZero method, unlike isEmpty this checks if both the width and the
height are zero.

  • rendering/RenderText.cpp:

(WebCore::absoluteQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
Break duplicate code out of absoluteRectsForRange and
absoluteQuadsForRange into shared static function.

Fix what I presume to be a bug in the absoluteQuadsForRange where the
logicalHeight was always used to set the size in absoluteQuadForTextBox
as oppsued to the absoluteRectsForRange implementation that uses the
logicalWidth or the logicalHeight depending on whether it's horizontal or
vertical.

LayoutTests:

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

Add test for vertical text.

10:37 AM Changeset in webkit [91762] by abarth@webkit.org
  • 2 edits in trunk/Tools

Windows bots on build.chromium.org can't figure out the head_svn_revision
​https://bugs.webkit.org/show_bug.cgi?id=65156

Reviewed by Tony Chang.

This patch is a bit of a guess as to the issue based on the
investigation in ​https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
not sure whether it will fix the issue, but it seems worth a try.

  • Scripts/webkitpy/common/checkout/scm/svn.py:
10:32 AM Changeset in webkit [91761] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark media-controls-clone as flaky crashing on other platforms.
​https://bugs.webkit.org/show_bug.cgi?id=65129

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:11 AM Changeset in webkit [91760] by commit-queue@webkit.org
  • 13 edits
    8 adds in trunk

[CSSRegions] Collect flowed elements in different render element
​https://bugs.webkit.org/show_bug.cgi?id=64516

Source/WebCore:

All the RenderObjects that have a specified "flow" name are moved out of the
normal flow. A RenderFlowThread will collect all such RenderObjects. There is
a RenderFlowThread for each flow name. The new RenderFlowThread is an anonymous
RenderBlock that is positioned absolute and will not render directly. In a
different bug/patch we will add RenderRegion that will take care of rendering the
RenderFlowThread on screen.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-26
Reviewed by Simon Fraser.

Tests: fast/regions/webkit-flow-renderer-layer.html

fast/regions/webkit-flow-renderer-nested.html
fast/regions/webkit-flow-renderer.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::hasFlowThreadParent):
(WebCore::NodeRenderingContext::parentFlowRenderer):

  • rendering/RenderFlowThread.cpp: Added.

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::createFlowThreadStyle):
(WebCore::RenderFlowThread::nextRendererForNode):
(WebCore::RenderFlowThread::previousRendererForNode):
(WebCore::RenderFlowThread::addChild):
(WebCore::RenderFlowThread::removeChild):

  • rendering/RenderFlowThread.h: Added.

(WebCore::toRenderFlowThread):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectLayers):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFlowThread):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::renderFlowThreadWithName):

  • rendering/RenderView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-26
Reviewed by Simon Fraser.

  • fast/regions/webkit-flow-renderer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-layer.html: Added.
  • fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
  • fast/regions/webkit-flow-renderer-nested.html: Added.
  • fast/regions/webkit-flow-renderer.html: Added.
10:08 AM Changeset in webkit [91759] by commit-queue@webkit.org
  • 12 edits in trunk

Source/WebCore: Filename text in file upload controls is not aligned with button text on
chromium-linux, chromium-win, and gtk.

​https://bugs.webkit.org/show_bug.cgi?id=64692

The fix is to not include the margin, border, and padding in the calculation,
because those are already accounted for by RenderBlock::baselinePosition().

Patch by Patrick Dubroy <​dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests: In file upload controls, filename text was misaligned with button text.
Update chromium-linux with the new baseline images, and add temporary
exceptions for chromium-win and gtk until they can be rebaselined.

​https://bugs.webkit.org/show_bug.cgi?id=64692

Patch by Patrick Dubroy <​dubroy@chromium.org> on 2011-07-26
Reviewed by Dimitri Glazkov.

  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
9:56 AM Changeset in webkit [91758] by benjamin.poulain@nokia.com
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Make the WebContextMenuProxyQt handle the full interactions between the views and the WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=64739

Reviewed by Andreas Kling.

Change the WebContextMenuProxyQt to be the intermediary between the WebPageProxy and our views regarding
the context menu.

The actions of the context menu are no longer the responsibility of QtWebPageProxy but are instead
created and handled directly by the WebContextMenuProxyQt.

  • UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::createContextMenuProxy):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):

  • UIProcess/qt/QtWebPageProxy.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt):
(WebKit::WebContextMenuProxyQt::create):
(WebKit::WebContextMenuProxyQt::actionTriggered):
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::hideContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
9:22 AM Changeset in webkit [91757] by pfeldman@chromium.org
  • 3 edits
    1 copy
    1 add in trunk/LayoutTests

2011-07-26 Pavel Feldman <​pfeldman@google.com>

Not reviewed: inspector test rebaselines.

  • inspector/console/console-format-expected.txt:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Copied from LayoutTests/inspector/runtime/runtime-getProperties-expected.txt.
7:58 AM Changeset in webkit [91756] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r91746.
​http://trac.webkit.org/changeset/91746
​https://bugs.webkit.org/show_bug.cgi?id=65180

It broke SL build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-26

Source/JavaScriptCore:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):
(WTF::StringImpl::simplifyWhiteSpace):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

Source/WebCore:

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

LayoutTests:

  • fast/forms/option-strip-unicode-spaces-expected.txt: Removed.
  • fast/forms/option-strip-unicode-spaces.html: Removed.
7:55 AM Changeset in webkit [91755] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/Source

[GTK] Remove header webkitwebviewcommon.h
​https://bugs.webkit.org/show_bug.cgi?id=65177

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2011-07-26
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Move webkitwebviewcommon.h contents back to webkitwebview.h.

  • GNUmakefile.am: Remove webkitwebviewcommon.h
  • webkit/webkitwebview.h:
  • webkit/webkitwebviewcommon.h: Removed.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebView.h: Add function prototypes

instead of including webkitwebviewcommon.h.

7:44 AM Changeset in webkit [91754] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: Better represent custom getters in the properties pane
​https://bugs.webkit.org/show_bug.cgi?id=16734

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-getProperties.html

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

LayoutTests:

  • inspector/runtime/runtime-getProperties-expected.txt: Added.
  • inspector/runtime/runtime-getProperties.html: Added.
7:16 AM Changeset in webkit [91753] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/css/font-face-opentype-expected.png: Added.
  • platform/qt/fast/css/font-face-opentype-expected.txt: Updated after r91738.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png: Updated after r91748.
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt: Updated after r91748.
6:34 AM Changeset in webkit [91752] by abecsi@webkit.org
  • 8 edits in trunk/Source

Patch by Alexis Menard <​alexis.menard@openbossa.org> on 2011-07-26
Reviewed by Andreas Kling.

[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=63472

Source/JavaScriptCore:

Enable the bits needed for GStreamer only when QtMultimedia is not used.

  • wtf/wtf.pri:

Source/WebCore:

Enable the GStreamer backend and the QuickTime backend as default media players
for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.

No new tests. The media layout tests are disabled on the Qt port but hopefully with this
switch we can enable them again.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:

Source/WebKit/qt:

Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
exist anymore, it's the default. Ditto for GStreamer.

5:16 AM Changeset in webkit [91751] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-07-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: (getPreferredSizeMethod):
5:01 AM QtWebKitBuildBots edited by zecke@selfish.org
(diff)
4:44 AM QtWebKitBuildBots edited by zecke@selfish.org
(diff)
4:36 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Add MIPS bot, update obsolete infos of obsolete bots (diff)
4:20 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt and Mobility version on Snow Leopard bots (diff)
4:17 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt and Mobility version on 4.7.x QtWebKit2.2 bot and on 4.8 … (diff)
3:20 AM Changeset in webkit [91750] by pfeldman@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn
​https://bugs.webkit.org/show_bug.cgi?id=65112

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/runtime/runtime-setPropertyValue.html

  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
(WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
(WebInspector.RemoteObject.prototype.setPropertyValue):

LayoutTests:

  • inspector/runtime/runtime-setPropertyValue-expected.txt: Added.
  • inspector/runtime/runtime-setPropertyValue.html: Added.
3:09 AM Changeset in webkit [91749] by pfeldman@chromium.org
  • 23 edits in trunk

2011-07-26 Pavel Feldman <​pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

​https://bugs.webkit.org/show_bug.cgi?id=65103
​https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionOn):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::callFunctionOn):
  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.prototype.get subtype): (WebInspector.RemoteObject.prototype.callFunction): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype.get type): (WebInspector.LocalJSONObject.prototype.get subtype):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.inspect):

2011-07-26 Pavel Feldman <​pfeldman@google.com>

Re-applying r91665 and r91668 with JSC issues fixed.

Web Inspector: use dedicated type for object id in the protocol.
Web Inspector: refactor remote object structure to contain value for primitive values.

​https://bugs.webkit.org/show_bug.cgi?id=65103
​https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests): (initialize_ExtensionsTest):
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
3:05 AM Changeset in webkit [91748] by Nikolas Zimmermann
  • 11 edits in trunk/Source/WebCore

2011-07-26 Nikolas Zimmermann <​nzimmermann@rim.com>

Prepare animVal support - phase 2
​https://bugs.webkit.org/show_bug.cgi?id=65167

Reviewed by Dirk Schulze.

Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.

Doesn't affect any tests, yet.

  • svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added). (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPathSegWithContext.h: Ditto. (WebCore::SVGPathSegWithContext::animatedProperty):
  • svg/SVGPolyElement.cpp: Ditto. (WebCore::SVGPolyElement::parseMappedAttribute):
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type. (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not. (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS. (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper. (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
  • svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff. (WebCore::SVGAnimatedPropertyTearOff::isAnimating): (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue): (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating): (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::updateAnimVal):
2:39 AM Changeset in webkit [91747] by hans@chromium.org
  • 2 edits in trunk/LayoutTests

Update another test that relied on fonts loading synchronously.
​https://bugs.webkit.org/show_bug.cgi?id=65169

Not Reviewed, tests fix.

  • platform/chromium-linux/fast/text/international/arabic-vertical-offset.html:
2:10 AM Changeset in webkit [91746] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
​https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripWhiteSpace):

Added an interface to take IsWhiteSpaceFunctionPtr.

(WTF::StringImpl::simplifyWhiteSpace): ditto.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.

  • wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
​https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

  • dom/OptionElement.cpp:

(WebCore::OptionElement::normalizeText):

Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
​https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-07-26
Reviewed by Kent Tamura.

  • fast/forms/option-strip-unicode-spaces-expected.txt: Added.
  • fast/forms/option-strip-unicode-spaces.html: Added.
12:17 AM Changeset in webkit [91745] by morrita@google.com
  • 2 edits in trunk/Tools

[Chromium][DRT] MockSpellCheck.cpp should be clang clean
​https://bugs.webkit.org/show_bug.cgi?id=65166

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/MockSpellCheck.cpp:

(MockSpellCheck::spellCheckWord): -Wsign-compare warning.

12:05 AM Changeset in webkit [91744] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add regression test for :empty { display: none }
​https://bugs.webkit.org/show_bug.cgi?id=26570

Patch by Noel Gordon <​noel.gordon@gmail.com> on 2011-07-26
Reviewed by Alexey Proskuryakov.

  • fast/css/pseudo-empty-display-none-expected.txt: Added.
  • fast/css/pseudo-empty-display-none.html: Added.

Jul 25, 2011:

10:35 PM Changeset in webkit [91743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT emits inefficient code for arithmetic
involving two registers
​https://bugs.webkit.org/show_bug.cgi?id=65160

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The non-speculative JIT now emits inline code for double arithmetic, but
still attempts integer arithmetic first. This is a speed-up on SunSpider
(albeit a small one), and a large speed-up on Kraken.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::basicArithOp):

10:21 PM Changeset in webkit [91742] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

[CMAKE] Split JSC related files from WebCore/CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=61350

Reviewed by Daniel Bates.

No new tests, just moving jsc related files from CMakeLists.txt to UseJSC.cmake.

  • CMakeLists.txt:
  • UseJSC.cmake:
10:11 PM Changeset in webkit [91741] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove unused code in ewk_tile_model.c
​https://bugs.webkit.org/show_bug.cgi?id=64521

Remove unused code in ewk_tile_model.c. Dirty flag is not referenced anywhere.

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2011-07-25
Reviewed by Daniel Bates.

  • ewk/ewk_tiled_model.c:

(ewk_tile_unused_cache_clear):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):

9:44 PM Changeset in webkit [91740] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated three more tests that relied on fonts loading synchronously.

  • fast/blockflow/japanese-rl-text-with-broken-font.html:
  • platform/mac/fast/text/myanmar-shaping.html:
  • platform/mac/fast/text/thai-combining-mark-positioning.html:
8:37 PM Changeset in webkit [91739] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build by committing a rename in this file that I neglected to include in the previous commit.

  • css/CSSFontFaceSource.h:
8:21 PM Changeset in webkit [91738] by mitz@apple.com
  • 19 edits in trunk

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
​https://bugs.webkit.org/show_bug.cgi?id=65123

Source/WebCore:

Reviewed by Anders Carlsson and Darin Adler.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:

LayoutTests:

Reviewed by Darin Adler.

Updated tests that depended on fonts loading synchronously during layout.
Unfortunately, font loading does not fire any DOM events, so in most cases
a constant timeout had to be introduced.

  • fast/blockflow/broken-ideograph-small-caps.html:
  • fast/css/color-leakage.html:
  • fast/css/custom-font-xheight.html:
  • fast/css/font-face-multiple-faces.html:
  • fast/css/font-face-multiple-remote-sources.html:
  • fast/css/font-face-remote.html:
  • fast/css/font-face-woff.html:
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
  • svg/custom/svg-fonts-fallback.xhtml:
  • svg/custom/svg-fonts-in-html.html:
  • svg/custom/svg-fonts-segmented.xhtml:
  • svg/custom/svg-fonts-with-no-element-reference.html:
  • svg/custom/svg-fonts-without-missing-glyph.xhtml:
  • svg/text/text-overflow-ellipsis-svgfont.html:
6:41 PM Changeset in webkit [91737] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Build break with --debug after r89153.
​https://bugs.webkit.org/show_bug.cgi?id=65150

Unreviewed build fix.

  • wtf/CMakeListsEfl.txt: Add missing libraries.
6:18 PM Changeset in webkit [91736] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <​apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):

  • platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
​https://bugs.webkit.org/show_bug.cgi?id=65043

Patch by Al Patrick <​apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
6:07 PM Changeset in webkit [91735] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor ScrollableArea pinned predicates to be more generally useful
<rdar://problem/9740379>

Reviewed by Dan Bernstein.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::isPinnedInBothDirections):
(WebCore::ScrollableArea::isPinnedHorizontallyInDirection):
(WebCore::ScrollableArea::isPinnedVerticallyInDirection):

  • platform/ScrollableArea.h:
6:04 PM Changeset in webkit [91734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG non-speculative JIT emits obviously inefficient code for arithmetic
where one operand is a constant.
​https://bugs.webkit.org/show_bug.cgi?id=65146

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Changed the code to emit double arithmetic inline.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):

6:03 PM Changeset in webkit [91733] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] components/mac: Make webcore not depend on CoreAnimation
​https://bugs.webkit.org/show_bug.cgi?id=65143

Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:
6:02 PM Changeset in webkit [91732] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/cyclic-prototypes.html as a flaky crasher.
​https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [91731] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] draw-arrays-out-of-bounds.html is a non-GPU flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
5:40 PM Changeset in webkit [91730] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Don't link in both libjpeg and libjpeg_turbo in the components build
​https://bugs.webkit.org/show_bug.cgi?id=65138

Reviewed by James Robinson.

  • WebKit.gyp:
5:31 PM Changeset in webkit [91729] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/selectors/001.html as a flaky crasher.
​https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
5:25 PM Changeset in webkit [91728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

DFG JIT bytecode parser misuses pointers into objects allocated as part of a
WTF::Vector.
​https://bugs.webkit.org/show_bug.cgi?id=65128

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

The bytecode parser code seems to be right to have a DFGNode& phiNode reference
into the graph, since this makes the code greatly more readable. This patch
thus makes the minimal change necessary to make the code right: it uses a
pointer (to disambiguate between reloading the pointer and performing a
copy from one location of the vector to another) and reloads it after the
calls to addToGraph().

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processPhiStack):

5:12 PM Changeset in webkit [91727] by commit-queue@webkit.org
  • 5 edits in trunk/Source

WebFrame should have a method to determine its visual emptiness
​https://bugs.webkit.org/show_bug.cgi?id=64223

Patch by Ian Henderson <​ianh@apple.com> on 2011-07-25
Reviewed by Dan Bernstein.

Source/WebCore:

  • page/FrameView.h:

(WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
so we can tell whether it's visually non-empty.

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
through WebKit.

  • WebView/WebFramePrivate.h:
5:11 PM Changeset in webkit [91726] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/cyclic-proto.html as a flaky crasher.
​https://bugs.webkit.org/show_bug.cgi?id=65152

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
4:57 PM Changeset in webkit [91725] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
​https://bugs.webkit.org/show_bug.cgi?id=61006

Patch by Scott Graham <​scottmg@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Rollback previous patch. Occasional crashes seen caused by
CachedResource being deleted twice.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):

  • loader/cache/CachedResourceLoader.h:
4:56 PM Changeset in webkit [91724] by Patrick Gansterer
  • 3 edits in trunk/Tools

Ignore line endings in ChangeLogTests
​https://bugs.webkit.org/show_bug.cgi?id=64956

Reviewed by Adam Barth.

Split the lines of the ChangeLog text before comparing them.
This fixes 3 tests on windows, since only the content importent.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4:40 PM Changeset in webkit [91723] by crogers@google.com
  • 4 edits in trunk/Source/WebCore

Deprecate AudioBufferSourceNode .looping attribute and implement .loop
​https://bugs.webkit.org/show_bug.cgi?id=65133

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::loop):
(WebCore::AudioBufferSourceNode::setLoop):

  • webaudio/AudioBufferSourceNode.idl:
4:35 PM Changeset in webkit [91722] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] HUD texture must be unreserved after drawing
​https://bugs.webkit.org/show_bug.cgi?id=65122

Unreserve the HUD texture after drawing. To test, start chrome in debug with --show-fps-counter. Since this is
a debugging option, no tests.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

4:28 PM Changeset in webkit [91721] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix leveldb crash when compacting during destruction
​https://bugs.webkit.org/show_bug.cgi?id=64494

Patch by David Grogan <​dgrogan@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.

Only tested manually so far by following the repro instructions at
crbug.com/88944

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::~LevelDBDatabase):

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):

4:27 PM Changeset in webkit [91720] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Use correct vertex shader when rendering video layer.
​https://bugs.webkit.org/show_bug.cgi?id=65131

Patch by David Reveman <​reveman@chromium.org> on 2011-07-25
Reviewed by James Robinson.

Add new VertexShaderQuad program that is used by LayerTilerChromium.
Change VertexShaderPosTexTransform so it works with CCVideoLayerImpl.

  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderPosTexTransform::getShaderString):
(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::texTransformLocation):

4:14 PM Changeset in webkit [91719] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
​https://bugs.webkit.org/show_bug.cgi?id=65148

Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
4:12 PM Changeset in webkit [91718] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

Fix AtomicString vs. String usage in accessibility code
​https://bugs.webkit.org/show_bug.cgi?id=65086

Reviewed by Darin Adler.

Use AtomicString instead of String where appropriate
to avoid implicit type conversations.
Also fix a invalid reference to a temporary String.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::elementsFromAttribute):
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.h:
4:10 PM Changeset in webkit [91717] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark user-script-image-document as a flaky crasher on Linux

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

4:02 PM Changeset in webkit [91716] by ojan@chromium.org
  • 2 edits in trunk/Tools

Tweak whitespace wrapping to improve readability.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:59 PM Changeset in webkit [91715] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r91686.
​http://trac.webkit.org/changeset/91686
​https://bugs.webkit.org/show_bug.cgi?id=65144

1.5% regression in JSC (Requested by jmontemayor on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-25

Source/JavaScriptCore:

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

LayoutTests:

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Removed.
3:54 PM Changeset in webkit [91714] by crogers@google.com
  • 5 edits in trunk/LayoutTests

Disable web audio layout tests on all platforms except chromium - as initial tests are added
​https://bugs.webkit.org/show_bug.cgi?id=65142

Unreviewed.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:41 PM Changeset in webkit [91713] by ojan@chromium.org
  • 3 edits in trunk/Tools

Minor tweak to wrap label elements as atomic units.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:33 PM Changeset in webkit [91712] by ojan@chromium.org
  • 2 edits in trunk/Tools

always show flakiness details on the builder page
​https://bugs.webkit.org/show_bug.cgi?id=65139

Reviewed by Tony Chang.

In order to simplify the UI, we hide the flakiness details by default,
but there's no actual use-case for this page without the flakiness details.
So get rid of that option and always show the flakiness details.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:32 PM Changeset in webkit [91711] by ojan@chromium.org
  • 3 edits in trunk/Tools

simplify the UI of the header above the test list table
​https://bugs.webkit.org/show_bug.cgi?id=65136

Reviewed by Adam Barth.

Use checkboxes instead of links since this is really about which tests to include.
Ends up using less text and put the checkboxes to the right of the header instead of below it.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3:23 PM Changeset in webkit [91710] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Reverted r91699 due to
<​http://webkit.org/b/65134> REGRESSION: r91699 broke some font tests (image+text)

Many tests relied on font loading occurring synchronously in the cached and local cases.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
3:23 PM Changeset in webkit [91709] by crogers@google.com
  • 2 edits in trunk/Tools

Update new-run-webkit-tests to accomodate binary audio data
​https://bugs.webkit.org/show_bug.cgi?id=65135

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:16 PM Changeset in webkit [91708] by crogers@google.com
  • 9 edits
    2 adds in trunk

Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
​https://bugs.webkit.org/show_bug.cgi?id=65039

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebArrayBufferView.h: Added.

(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):

  • public/WebBindings.h:
  • src/WebArrayBufferView.cpp: Added.

(WebKit::WebArrayBufferView::assign):
(WebKit::WebArrayBufferView::reset):
(WebKit::WebArrayBufferView::baseAddress):
(WebKit::WebArrayBufferView::byteOffset):
(WebKit::WebArrayBufferView::byteLength):
(WebKit::WebArrayBufferView::WebArrayBufferView):
(WebKit::WebArrayBufferView::operator=):
(WebKit::WebArrayBufferView::operator PassRefPtr<ArrayBufferView>):

  • src/WebBindings.cpp:

(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getArrayBufferView):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setAudioData):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::audioData):

  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(DRTPrinter::handleAudioHeader):
(TestShellPrinter::handleAudioHeader):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

2:43 PM Changeset in webkit [91707] by Martin Robinson
  • 35 edits
    10 adds in trunk

Reviewed by Gustavo Noronha Silva.

[GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
​https://bugs.webkit.org/show_bug.cgi?id=62252

Source/WebCore:

Properly handle the situation where the GtkWidget wants WebCore to draw its
own main frame scrollbars.

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
(WebCore::ScrollView::createScrollbar): Use the new helper.
(WebCore::ScrollView::visibleContentRect): Use the new helper.

Source/WebKit/gtk:

Added an undocumented self-scrolling property to WebKitWebView which
communicates to WebCore whether or not this widget is expected to draw
its own main frame scrollbars or not.

  • webkit/webkitwebview.cpp: Add the self-scrolling property.
  • webkit/webkitwebviewprivate.h: Add the selfScrolling private member.

Tools:

Add a new subclass of WebKitWebView that overrides the size request to
return 1 pixel by 1 pixel. This ensure that it operates properly when
not packed into a GtkScrolledWindow. Also construct the WebKitWebView
with self-scrolling set to true.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
(createWebView): Ditto.
(main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.

(self_scrolling_webkit_web_view_class_init):
(self_scrolling_webkit_web_view_init):
(self_scrolling_webkit_web_view_new):
(sizeRequestMethod):
(getPreferredSizeMethod):

  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
  • GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.

LayoutTests:

Unskip tests which are now passing and update results for tests which
previously had incorrect results.

  • platform/gtk/Skipped: Unskip now-passing tests.
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.png:
  • platform/gtk/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/flexbox/flex-hang-expected.png:
  • platform/gtk/fast/flexbox/flex-hang-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.png:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.png:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.png: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.png: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
2:33 PM Changeset in webkit [91706] by jonlee@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Assertion called in ExecutableBase::generatedJITCodeForCall() when JIT is not available
​https://bugs.webkit.org/show_bug.cgi?id=65132
<rdar://problem/9836297>

Reviewed by Oliver Hunt.

Make sure the JIT is available to use before running the following calls:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::unlinkCalls): Added check, return early if JIT is not available.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addMethodCallLinkInfos): Added assertion.

2:01 PM Changeset in webkit [91705] by ojan@chromium.org
  • 3 edits in trunk/Tools

by default hide tests that have passes for all recorded runs
​https://bugs.webkit.org/show_bug.cgi?id=65127

Reviewed by Adam Barth.

This is part of simplifying the default views of the dashboard to
make it show less information for the common use cases.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1:45 PM Changeset in webkit [91704] by ojan@chromium.org
  • 7 edits in trunk/Tools

stop generating expectations.json now that it's unused
​https://bugs.webkit.org/show_bug.cgi?id=65130

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • TestResultServer/handlers/menu.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
1:20 PM Changeset in webkit [91703] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] media-controls-clone started flaky crashing on mac.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

1:08 PM Changeset in webkit [91702] by hyatt@apple.com
  • 10 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=65125

(1) Add the new CSS3 positioned value for floats.
(2) Rename FLEFT, FRIGHT and FNONE to our more modern convention: NoFloat, LeftFloat, RightFloat.
(3) Replace uses of == FNONE and != FNONE with isFloating and !isFloating.

Reviewed by Dan Bernstein.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFloat):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • css/CSSValueKeywords.in:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isFloating):
(WebCore::InheritedFlags::initialFloating):

  • rendering/style/RenderStyleConstants.h:
1:08 PM Changeset in webkit [91701] by ojan@chromium.org
  • 2 edits in trunk/Tools

don't show builders in the flakiness dashboard that have stopped running a given test suite
​https://bugs.webkit.org/show_bug.cgi?id=65126

Reviewed by Mihai Parparita.

  • TestResultServer/static-dashboards/dashboard_base.js:
1:05 PM Changeset in webkit [91700] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More WebGL flaky crashers on Linux.

  • platform/chromium/test_expectations.txt:

Unreviewed gardening.

1:00 PM Changeset in webkit [91699] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9835028> Font loading during layout can cause layout code to be re-entered via resource load delegate
​https://bugs.webkit.org/show_bug.cgi?id=65123

Reviewed by Anders Carlsson.

Since CSSFontFaceSource::getFontData() can get called during layout, avoid calling out to loader
code from under it, and instead defer that work using a zero-delay timer.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData): Rather than starting the font load here, schedule
a zero-delay timer to do it.
(WebCore::CSSFontFaceSource::startLoadingTimerFired): Added. Starts loading the font if needed.

  • css/CSSFontFaceSource.h:
12:55 PM Changeset in webkit [91698] by dbates@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2011-07-25 Daniel Bates <​dbates@rim.com>

Rename expected results file after changeset <​http://trac.webkit.org/changeset/91689>.

  • fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt: Copied from LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt.
  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Removed.
12:50 PM Changeset in webkit [91697] by Martin Robinson
  • 51 edits
    2 adds in trunk/LayoutTests

Update baselines for GTK+ after several revisions.

  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt: Added.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt:
  • platform/gtk/fast/forms/input-appearance-range-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.png:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
12:46 PM Changeset in webkit [91696] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:42 PM Changeset in webkit [91695] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.4

New tag.

12:20 PM Changeset in webkit [91694] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] Adopt GraphicsContext3DOpenGL.cpp and ANGLE (part 2)
​https://bugs.webkit.org/show_bug.cgi?id=64878

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Adopt GraphicsContext3DOpenGL.cpp and ANGLE compiler for Qt.

  • WebCore.pro: Build ANGLE compiler and GraphicsContext3DOpenGL.cpp.
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h: Expose exising ANGLEWebKitBridge compiler member for Qt.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLE resources.

12:08 PM Changeset in webkit [91693] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More ICU roll test failures from the slow windows bot
​https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [91692] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91147.

11:58 AM Changeset in webkit [91691] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 91386
BUG=88889
Review URL: ​http://codereview.chromium.org/7506003

11:57 AM Changeset in webkit [91690] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] japanese-rl-selection-repaint also broken by ICU roll
​https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:55 AM Changeset in webkit [91689] by dbates@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r85964): Improper relayout of some nested positioned elements
​https://bugs.webkit.org/show_bug.cgi?id=64286

Reviewed by David Hyatt.

Source/WebCore:

Fixes an issue when traversing up the containing block hierarchy after skipping
relatively positioned inlines.

When processing a positioned element we skip any intermediate inlines to get to
to enclosing block B, but don't use the containing block for B (call this P_B) to
properly continue traversing up the containing block hierarchy. So, B may be
considered again instead of looking at P_B. Hence, we don't set the correct dirty
bits for P_B and may not schedule a relayout with respect to the correct layout node.

Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Add test case to ensure we don't regress relayout of nested positioned elements.

  • fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Added.
  • fast/block/positioning/relayout-nested-positioned-elements-crash.html: Added.
11:55 AM Changeset in webkit [91688] by cevans@google.com
  • 2 edits
    2 deletes in branches/chromium/782

Revert 91684 - Merge 91386
BUG=88889
Review URL: ​http://codereview.chromium.org/7503002

11:43 AM Changeset in webkit [91687] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] japanese-rl-selection-clear broken by ICU roll
​https://bugs.webkit.org/show_bug.cgi?id=65124

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:41 AM Changeset in webkit [91686] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk

JSON errors should be informative
​https://bugs.webkit.org/show_bug.cgi?id=63339

Source/JavaScriptCore:

Added error messages to the JSON Parser.

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):
(JSC::LiteralParser::Lexer::sawError):
(JSC::LiteralParser::Lexer::getErrorMessage):

LayoutTests:

Updated expected test results.

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-07-25
Reviewed by Oliver Hunt.

  • fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt: Added.
11:34 AM Changeset in webkit [91685] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91611
BUG=90222
Review URL: ​http://codereview.chromium.org/7499005

11:32 AM Changeset in webkit [91684] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/782

Merge 91386
BUG=88889
Review URL: ​http://codereview.chromium.org/7502005

11:21 AM Changeset in webkit [91683] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark media/remove-from-document as another flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:11 AM Changeset in webkit [91682] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] More WebGL flaky crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:08 AM Changeset in webkit [91681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

removes last ENABLE(DRAG_SUPPORT) gtk check
​https://bugs.webkit.org/show_bug.cgi?id=64518

Patch by Arno Renevier <​arno@renevier.net> on 2011-07-25
Reviewed by Martin Robinson.

  • platform/gtk/ClipboardGtk.h:
11:03 AM Changeset in webkit [91680] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark some media tests as being crashers on Linux.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:02 AM Changeset in webkit [91679] by commit-queue@webkit.org
  • 5 edits in trunk

[CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape
​https://bugs.webkit.org/show_bug.cgi?id=65096

Source/WebCore:

Also the 'inherit' keyword is now treated correctly. It will
copy the value from the parent style.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-25
Reviewed by Tony Chang.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

Fixed 'inherit' test to copy the value from the parent. Also, added new tests
for 'inerhit' with no value in the parent.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-07-25
Reviewed by Tony Chang.

  • fast/exclusions/parsing-wrap-shape-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape.js:
10:59 AM Changeset in webkit [91678] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

X86-64 assembler emits three instructions instead of two for certain
loads and stores.
​https://bugs.webkit.org/show_bug.cgi?id=65095

Patch by Filip Pizlo <​fpizlo@apple.com> on 2011-07-25
Reviewed by Gavin Barraclough.

Simply made these four methods in the assembler use the scratch register,
which they were previously avoiding. It still optimizes for the case where
an absolute address memory accesses is using EAX. This results in a slight
performance improvement.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::load32):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::storePtr):

10:51 AM Changeset in webkit [91677] by abarth@webkit.org
  • 10 edits
    1 add in trunk/Tools

Overhaul garden-o-matic frontend to integrate revision history and failures
​https://bugs.webkit.org/show_bug.cgi?id=65089

Reviewed by Dimitri Glazkov.

This is a major overhaul of the garden-o-matic frontend. The new UI
integrates the revision history information with failures. Failures
appear in context adjacent to the revisions that caused them (which are
highlighted). Each buildbot receives a collumn to the left, which
indicates which revisions that bot has tested and whether that bot
showed the indicated failures.

Failures are selectable with checkboxes, and can then either be
examined or rebaselined.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
10:47 AM Changeset in webkit [91676] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

disable tests pending rebaseline with rotated text fix
​https://bugs.webkit.org/show_bug.cgi?id=65114

Patch by Mike Reed <​reed@google.com> on 2011-07-25
Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
10:45 AM Changeset in webkit [91675] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark gl-enum-enable-test as a flaky crasher.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:39 AM Changeset in webkit [91674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

glActiveTexture(0) is invalid
​https://bugs.webkit.org/show_bug.cgi?id=65115

Patch by Andrew Wason <​rectalogic@rectalogic.com> on 2011-07-25
Reviewed by Kenneth Russell.

Existing WebGL layout tests.

Fix invalid glActiveTexture(0) call.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::prepareTexture):

10:06 AM Changeset in webkit [91673] by pfeldman@chromium.org
  • 14 edits in trunk

Unreviewed, rolling out r91665.
​http://trac.webkit.org/changeset/91665
​https://bugs.webkit.org/show_bug.cgi?id=65118

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):
():

  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
10:00 AM Changeset in webkit [91672] by pfeldman@chromium.org
  • 9 edits in trunk

Unreviewed, rolling out r91668.
​http://trac.webkit.org/changeset/91668
​https://bugs.webkit.org/show_bug.cgi?id=65117

Breaks inspector tests on JSC (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-25

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
9:40 AM Changeset in webkit [91671] by zecke@webkit.org
  • 2 edits in trunk/Tools

[buildbot] Add Qt Linux MIPSEL Configuration
​https://bugs.webkit.org/show_bug.cgi?id=65116

Reviewed by Adam Roben.

Introduce a Qt Linux MIPS EL build slave. The configuration
is a build only configuration.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
9:21 AM Changeset in webkit [91670] by podivilov@chromium.org
  • 3 edits
    1 copy in trunk/LayoutTests

2011-07-25 Pavel Podivilov <​podivilov@chromium.org>

Web Inspector: unreviewed, fix pause-in-internal-script expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65078

  • inspector/debugger/pause-in-internal-script-expected.txt:
  • platform/chromium/inspector/debugger/pause-in-internal-script-expected.txt: Copied from LayoutTests/inspector/debugger/pause-in-internal-script-expected.txt.
  • platform/qt/Skipped:
8:51 AM Changeset in webkit [91669] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Add more tests to cover the behavior of loadFinished() signal
​https://bugs.webkit.org/show_bug.cgi?id=63490

Reviewed by Benjamin Poulain.

  • tests/qwebframe/tst_qwebframe.cpp:

(FakeReply::FakeReply):
(FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.

(tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
after a 404 error without contents.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
is true when we use error page extension to produce our own error pages.

8:10 AM Changeset in webkit [91668] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: use dedicated type for object id in the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=65110

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::callFunctionOn):

LayoutTests:

  • inspector/runtime/runtime-callFunctionOn-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
7:48 AM Changeset in webkit [91667] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt][WK2] Add multi-point touch mocking to MiniBrowser

​https://bugs.webkit.org/show_bug.cgi?id=64374

Reviewed by Benjamin Poulain.

Each mouse button generate a touch point. The touch point stay
virtually on screen if the mouse release happened while the Ctrl
modifier was pressed.

7:42 AM Changeset in webkit [91666] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: live edit error should be revealed in Console
​https://bugs.webkit.org/show_bug.cgi?id=65109

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
(WebInspector.SourceFrame.prototype.commitEditing):

7:24 AM Changeset in webkit [91665] by pfeldman@chromium.org
  • 14 edits in trunk

Web Inspector: refactor remote object structure to contain value for primitive values.
​https://bugs.webkit.org/show_bug.cgi?id=65103

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._format):
(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._format):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get subtype):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.LocalJSONObject.prototype.get type):
(WebInspector.LocalJSONObject.prototype.get subtype):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
(WebInspector.SourceFrame.prototype._showPopup):

  • inspector/front-end/inspector.js:

(WebInspector.log.logMessage):
(WebInspector.log):
(WebInspector.inspect):

LayoutTests:

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/runtime/runtime-callFunctionOn.html:
7:01 AM Changeset in webkit [91664] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Use NRWT for Qt-WK2
​https://bugs.webkit.org/show_bug.cgi?id=65097

Reviewed by Andreas Kling.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

5:52 AM Changeset in webkit [91663] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Fix mixing of retaining path in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=65028

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotPathFinderState): Added
(WebInspector.HeapSnapshotRetainingPathsList): Extracted State-specific code

5:47 AM Changeset in webkit [91662] by Csaba Osztrogonác
  • 43 edits
    2 adds in trunk/LayoutTests

[Qt] Lot of RenderTree mismatches in fast/multicol
​https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening. Add Qt specific expected results after r91474.

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/float-avoidance-expected.png: Added.
  • platform/qt/fast/multicol/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt/fast/multicol/float-multicol-expected.txt:
  • platform/qt/fast/multicol/scrolling-overflow-expected.png:
  • platform/qt/fast/multicol/scrolling-overflow-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt:
5:17 AM Changeset in webkit [91661] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: worker inspector should show Scripts panel by default
​https://bugs.webkit.org/show_bug.cgi?id=65099

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector._defaultPanelName):
(WebInspector.showPanel):

12:18 AM Changeset in webkit [91660] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
​https://bugs.webkit.org/show_bug.cgi?id=64354

Use ecore_time_unix_get which returns unix time as double type for currentTime
and ecore_time_get which uses monotonic clock for monotonicallyIncreasingTime.

Reviewed by Kent Tamura.

  • wtf/CurrentTime.cpp:

(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

12:10 AM Changeset in webkit [91659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Move macro checking inside ewk_view_context_menu_forward_event
​https://bugs.webkit.org/show_bug.cgi?id=64682

When CONTEXT_MENUS macro is disabled method ewk_view_context_menu_forward_event just
returns EINA_FALSE and it avoid undefined reference during building.

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_view.cpp:

(ewk_view_context_menu_forward_event):

12:09 AM Changeset in webkit [91658] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Method ewk_context_menu_destroy returns EINA_FALSE if CONTEXT_MENUS macro is disabled
​https://bugs.webkit.org/show_bug.cgi?id=64683

Fix returned value and omit NULL checking if CONTEXT_MENUS macro is disabled
in ewk_context_menu_destroy.

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2011-07-25
Reviewed by Kent Tamura.

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_destroy):

Jul 24, 2011:

10:10 PM Changeset in webkit [91657] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Small cleanup of m_fontDirty tracking in CSSStyleSelector
​https://bugs.webkit.org/show_bug.cgi?id=65090

Reviewed by Darin Adler.

1) Use existing setFontDescription helper where appropriate.
2) Move always used m_fontDirty check into updateFont()

No new tests / cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::updateFontIfDirty):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSStyleSelector.h:
9:42 PM Changeset in webkit [91656] by tkent@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

[Chromium] Leftover of r91633 (SVG test move)

  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/borders/svg-as-border-image-expected.txt.
9:38 PM Changeset in webkit [91655] by tkent@chromium.org
  • 6 edits
    6 adds in trunk/LayoutTests

[Chromium] Update expectations for r91637.

  • platform/chromium-linux/svg/custom/text-linking-expected.png:
  • platform/chromium-linux/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-win/svg/custom/text-linking-expected.png:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
8:36 PM Changeset in webkit [91654] by tkent@chromium.org
  • 4 edits in trunk

Validation message bubble position is incorrect if the containing block has paddings.
​https://bugs.webkit.org/show_bug.cgi?id=65091

Reviewed by Hajime Morita.

Source/WebCore:

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
We don't need to subtract paddings because the origin of
position:aboslute is inside borders and outside of the padding.

LayoutTests:

  • fast/forms/validation-message-in-relative-body.html: Update the test to cover a padding case.
7:16 PM Changeset in webkit [91653] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-07-24 Rob Buis <​rbuis@rim.com>

Crash in SVGUseElement::updateContainerOffsets on <use> with no parent
​https://bugs.webkit.org/show_bug.cgi?id=63646

Reviewed by Darin Adler.

Prevent using invalid targetElementInstance->shadowTreeElement after shadow render tree recreation. This situation can
only occur when there was a valid shadowTreeElement before setting xlink:href to empty/invalid.

Test: svg/custom/use-shadow-root-parent-removal.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
6:27 PM Changeset in webkit [91652] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Fix AtomicString vs. String usage in JSC binding
​https://bugs.webkit.org/show_bug.cgi?id=65085

Reviewed by Darin Adler.

Use ustringToAtomicString instead of ustringToString where appropriate.

  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
5:38 PM Changeset in webkit [91651] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyOutlineOffset in CSSStyleApplyProperty.
​https://bugs.webkit.org/show_bug.cgi?id=64773

Reviewed by Dimitri Glazkov.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

1:54 PM Changeset in webkit [91650] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Yet another unreviewed Qt fixery for the weekend.

Don't use test_expectations until all of the Qt platforms switched to NRWT.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
12:49 PM Changeset in webkit [91649] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r91635.
​http://trac.webkit.org/changeset/91635
​https://bugs.webkit.org/show_bug.cgi?id=65083

It broke the minimal build (Requested by Ossy_OFFLINE on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-24

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

11:48 AM Changeset in webkit [91648] by abarth@webkit.org
  • 7 edits in trunk/Tools

Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
9:03 AM Changeset in webkit [91647] by kbalazs@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening for Qt.

  • platform/qt/svg/custom/tref-own-content-removal-expected.txt: Added.
9:01 AM Changeset in webkit [91646] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] inspector/debugger/pause-in-internal-script.html fails
​https://bugs.webkit.org/show_bug.cgi?id=65078

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Mark the test as expected TEXT failure.
8:23 AM Changeset in webkit [91645] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Lot of RenderTree mismatches in fast/multicol
​https://bugs.webkit.org/show_bug.cgi?id=65077

Unreviewed gardening for Qt.

  • platform/qt/test_expectations.txt: Add expected TEXT failures.
6:57 AM Changeset in webkit [91644] by rwlbuis@webkit.org
  • 5 edits
    3 adds in trunk

2011-07-24 Rob Buis <​rbuis@rim.com>

SVG <use> element is not repositioned when moved to x=0 y=0 through script
​https://bugs.webkit.org/show_bug.cgi?id=53767

Reviewed by Nikolas Zimmermann.

Only bail out on zero offset if it is not explicitly set.

Test: svg/custom/use-move-to-offset.svg

  • rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/svg/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement): (WebCore::SVGShadowTreeContainerElement::setContainerOffset):
  • rendering/svg/SVGShadowTreeElements.h: (WebCore::SVGShadowTreeContainerElement::containerOffsetChanged): (WebCore::SVGShadowTreeContainerElement::setContainerOffsetChanged):
3:07 AM Changeset in webkit [91643] by jpfau@apple.com
  • 13 edits
    2 adds in trunk/Source/WebCore

Refactor HTML tokenizer code in preparation for a new XML tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=65000

Reviewed by Adam Barth.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLNames::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLNames::isEndTagBufferingState):
(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::TextDocumentParser):

  • html/parser/TextViewSourceParser.cpp:

(WebCore::TextViewSourceParser::TextViewSourceParser):

  • xml/parser/MarkupTokenBase.h:

(WebCore::MarkupTokenBase::type):

  • xml/parser/MarkupTokenizerBase.h: Added.

(WebCore::MarkupTokenizerBase::~MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::lineNumber):
(WebCore::MarkupTokenizerBase::columnNumber):
(WebCore::MarkupTokenizerBase::state):
(WebCore::MarkupTokenizerBase::setState):
(WebCore::MarkupTokenizerBase::forceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::setForceNullCharacterReplacement):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
(WebCore::MarkupTokenizerBase::MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):
(WebCore::MarkupTokenizerBase::emitAndResumeIn):
(WebCore::MarkupTokenizerBase::emitAndReconsumeIn):
(WebCore::MarkupTokenizerBase::emitEndOfFile):
(WebCore::MarkupTokenizerBase::reset):
(WebCore::MarkupTokenizerBase::haveBufferedCharacterToken):

  • xml/parser/MarkupTokenizerInlineMethods.h: Added.

(WebCore::isTokenizerWhitespace):
(WebCore::advanceStringAndASSERTIgnoringCase):
(WebCore::advanceStringAndASSERT):

Jul 23, 2011:

8:30 PM Changeset in webkit [91642] by Dimitri Glazkov
  • 3 edits in trunk/Tools

TestConfiguration should be hashable and comparable for equality.
​https://bugs.webkit.org/show_bug.cgi?id=65070

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added hash and eq methods.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
4:42 PM Changeset in webkit [91641] by Patrick Gansterer
  • 8 edits in trunk/Source/WebCore

Remove WTF namespace from isMainThread() calls
​https://bugs.webkit.org/show_bug.cgi?id=65068

Reviewed by Sam Weinig.

Because of the using WTF::isMainThread in the header there is no
reason to include the namespace name when calling this function.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • page/DOMWindow.cpp:
  • page/History.cpp:
3:44 PM Changeset in webkit [91640] by tkent@chromium.org
  • 9 edits in trunk/LayoutTests

[Chromium] Update expectations for r91636.

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [91639] by Dimitri Glazkov
  • 2 edits
    2 adds in trunk/Tools

Extract TestConfiguration from base and write a few unit tests to capture current behavior.
​https://bugs.webkit.org/show_bug.cgi?id=65066

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
11:44 AM Changeset in webkit [91638] by alokp@chromium.org
  • 11 edits in trunk

Switching off acceleration for small canvas broke gpu tests
​https://bugs.webkit.org/show_bug.cgi?id=65053

Reviewed by Stephen White.

Source/WebCore:

No new tests. These are supposed to fix existing canvas tests on gpu.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldAccelerateCanvas):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
(WebCore::Settings::setMinimumAccelerated2dCanvasSize):

  • page/Settings.h:

(WebCore::Settings::minimumAccelerated2dCanvasSize):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):

  • src/WebSettingsImpl.h:

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:
11:17 AM Changeset in webkit [91637] by rwlbuis@webkit.org
  • 12 edits
    3 adds in trunk

2011-07-23 Rob Buis <​rbuis@rim.com>

Freed SVGTRefElement used in SVGStyledElement::buildPendingResourcesIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=64758

Reviewed by Nikolas Zimmermann.

Fix the crash by storing referenced content inside a shadow tree. This way removing child nodes of
the <tref> does not remove the referenced content.

  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • dom/Text.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGShadowText::create): (WebCore::SVGShadowText::SVGShadowText): (WebCore::SVGShadowText::createRenderer): (WebCore::SVGShadowText::recalcStyle): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::childShouldCreateRenderer):
9:21 AM Changeset in webkit [91636] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebCore: Display number field without using a thousand separator.
​https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

Separated formatters for parsing and displaying.
Removed a test for thousand separator.

  • manual-tests/input-number-localization.html:

Removed a test for thousand separator.
Made the test description more specific.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::createFormatterForCurrentLocaleToDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):
Added to introduce a formatter for display.
(WebCore::numberFormatterForParsing):
Changed the name to be clear.
(WebCore::numberFormatterForDisplay): Added.
(WebCore::parseLocalizedNumber): Used numberFormatterForParsing.
(WebCore::formatLocalizedNumber): Used numberFormatterForDisplay.

LayoutTests: Marked fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
​https://bugs.webkit.org/show_bug.cgi?id=65064

Patch by Shinya Kawanaka <​shinyak@google.com> on 2011-07-23
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Mark fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.
8:39 AM Changeset in webkit [91635] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] Add option to turn on disk caching in QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=65007

Patch by Keith Kyzivat <​keith.kyzivat@nokia.com> on 2011-07-23
Reviewed by Noam Rosenthal.

Add menu item and command line option to turn on disk caching in
QtTestBrowser. Simple QNetworkDiskCache added to the page's
QNetworkAccssManager.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(LauncherApplication::handleUserOptions):

7:54 AM Changeset in webkit [91634] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Turn on new WebSocket protocol in worker shadow page
​https://bugs.webkit.org/show_bug.cgi?id=64852

Reviewed by Dmitry Titov.

  • src/WebWorkerBase.cpp:

(WebKit::WebWorkerBase::initializeLoader):
Initialize the value of WebCore::Settings::useHixie76WebSocketProtocol()
for a new shadow page. The default value of this flag is overridden through
WebPreferences (located in webkit/glue in Chromium source tree) but a shadow
page does not receive the preference values from it.

4:18 AM Changeset in webkit [91633] by Nikolas Zimmermann
  • 4 edits
    4 copies
    145 moves
    18 adds
    1 delete in trunk/LayoutTests

2011-07-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Move several SVG specific tests out of fast/(backgrounds|borders) into svg/(as-background-image|as-border-image) as
we're only running pixel tests for the svg/ subdirectory on a daily base. Also it's easier to spot errors this way.
Updated all Skipped/test_expectations.txt files as well.

Rubber-stamped by Maciej Stachowiak.

  • fast/backgrounds/animated-svg-as-background.html: Removed.
  • fast/backgrounds/resources/animated-rect-fixed-size.svg: Removed.
  • fast/backgrounds/resources/balloon.svg: Removed.
  • fast/backgrounds/resources/eyes.svg: Removed.
  • fast/backgrounds/resources/hearts.svg: Removed.
  • fast/backgrounds/resources/map.svg: Removed.
  • fast/backgrounds/resources/mouse-repel.svg: Removed.
  • fast/backgrounds/svg-as-background-1.html: Removed.
  • fast/backgrounds/svg-as-background-2.html: Removed.
  • fast/backgrounds/svg-as-background-3.html: Removed.
  • fast/backgrounds/svg-as-background-4.html: Removed.
  • fast/backgrounds/svg-as-background-5.html: Removed.
  • fast/backgrounds/svg-as-background-6.html: Removed.
  • fast/borders/resources/large-tiles.png: Removed.
  • fast/borders/resources/tiles-fixed-size.svg: Removed.
  • fast/borders/resources/tiles-relative-size.svg: Removed.
  • fast/borders/resources/tiles.png: Removed.
  • fast/borders/svg-as-border-image-2.html: Removed.
  • fast/borders/svg-as-border-image.html: Removed.
  • platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image: Added.
  • platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-linux/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-linux/svg/as-border-image: Added.
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-background-image: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac-leopard/svg/as-border-image: Added.
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-mac-leopard/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-mac/svg/as-background-image: Added.
  • platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-win/svg/as-background-image: Added.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/chromium-win/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/chromium-win/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/chromium-win/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/chromium-win/svg/as-border-image: Added.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png.
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image: Added.
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/gtk/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/gtk/svg/as-border-image: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.png.
  • platform/gtk/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/gtk/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/gtk/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac-leopard/svg/as-background-image: Added.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac-leopard/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac-leopard/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac-leopard/svg/as-border-image: Added.
  • platform/mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.png: Removed.
  • platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Removed.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/mac/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/mac/svg/as-background-image: Added.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/mac/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.png: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/mac/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/mac/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.png: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.png.
  • platform/mac/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/mac/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.png.
  • platform/mac/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/mac/svg/as-border-image: Added.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-2-expected.txt.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png: Copied from platform/mac/fast/borders/svg-as-border-image-expected.png.
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.txt: Copied from platform/mac/fast/borders/svg-as-border-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-1-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-2-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-3-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-4-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-5-expected.txt: Removed.
  • platform/qt/fast/backgrounds/svg-as-background-6-expected.txt: Removed.
  • platform/qt/svg/as-background-image: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt: Copied from platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt: Copied from platform/qt/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png.
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Copied from platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt.
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/svg/as-image/svg-as-tiled-background-expected.txt.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.png.
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt.
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt.
  • platform/qt/svg/as-image/svg-as-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Removed.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Removed.
  • platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Removed.
  • svg/as-background-image: Added.
  • svg/as-background-image/animated-svg-as-background.html: Copied from fast/backgrounds/animated-svg-as-background.html.
  • svg/as-background-image/resources: Added.
  • svg/as-background-image/resources/animated-rect-relative-size.svg: Copied from fast/backgrounds/resources/animated-rect-relative-size.svg.
  • svg/as-background-image/resources/balloon.svg: Copied from fast/backgrounds/resources/balloon.svg.
  • svg/as-background-image/resources/butterfly.svg: Copied from svg/as-image/resources/butterfly.svg.
  • svg/as-background-image/resources/circle.svg: Copied from svg/as-image/resources/circle.svg.
  • svg/as-background-image/resources/eyes.svg: Copied from fast/backgrounds/resources/eyes.svg.
  • svg/as-background-image/resources/green-fixed-size-rect.svg: Copied from svg/as-image/resources/green-fixed-size-rect.svg.
  • svg/as-background-image/resources/green-relative-size-rect-with-viewBox.svg: Copied from svg/as-image/resources/green-relative-size-rect-with-viewBox.svg.
  • svg/as-background-image/resources/hearts.svg: Copied from fast/backgrounds/resources/hearts.svg.
  • svg/as-background-image/resources/linguistics.svg: Copied from fast/backgrounds/resources/linguistics.svg.
  • svg/as-background-image/resources/map.svg: Copied from fast/backgrounds/resources/map.svg.
  • svg/as-background-image/resources/mouse-repel.svg: Copied from fast/backgrounds/resources/mouse-repel.svg.
  • svg/as-background-image/resources/svg-as-background-with-relative-size.svg: Copied from svg/as-image/resources/svg-as-background-with-relative-size.svg.
  • svg/as-background-image/resources/width-100-percent.svg: Copied from svg/as-image/resources/width-100-percent.svg.
  • svg/as-background-image/svg-as-background-1.html: Copied from fast/backgrounds/svg-as-background-1.html.
  • svg/as-background-image/svg-as-background-2.html: Copied from fast/backgrounds/svg-as-background-2.html.
  • svg/as-background-image/svg-as-background-3.html: Copied from fast/backgrounds/svg-as-background-3.html.
  • svg/as-background-image/svg-as-background-4.html: Copied from fast/backgrounds/svg-as-background-4.html.
  • svg/as-background-image/svg-as-background-5.html: Copied from fast/backgrounds/svg-as-background-5.html.
  • svg/as-background-image/svg-as-background-6.html: Copied from fast/backgrounds/svg-as-background-6.html.
  • svg/as-background-image/svg-as-background-with-relative-size.html: Copied from svg/as-image/svg-as-background-with-relative-size.html.
  • svg/as-background-image/svg-as-background-with-viewBox.html: Copied from svg/as-image/svg-as-background-with-viewBox.html.
  • svg/as-background-image/svg-as-background.html: Copied from svg/as-image/svg-as-background.html.
  • svg/as-background-image/svg-as-tiled-background.html: Copied from svg/as-image/svg-as-tiled-background.html.
  • svg/as-background-image/svg-background-crash-on-refresh-expected.txt: Copied from svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-background-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html.
  • svg/as-background-image/svg-background-partial-redraw.html: Copied from svg/as-image/svg-background-partial-redraw.html.
  • svg/as-background-image/svg-width-100p-as-background.html: Copied from svg/as-image/svg-width-100p-as-background.html.
  • svg/as-border-image: Added.
  • svg/as-border-image/resources: Added.
  • svg/as-border-image/resources/large-tiles.png: Copied from fast/borders/resources/large-tiles.png.
  • svg/as-border-image/resources/tiles-fixed-size.svg: Copied from fast/borders/resources/tiles-fixed-size.svg.
  • svg/as-border-image/resources/tiles-relative-size.svg: Copied from fast/borders/resources/tiles-relative-size.svg.
  • svg/as-border-image/resources/tiles.png: Copied from fast/borders/resources/tiles.png.
  • svg/as-border-image/svg-as-border-image-2.html: Copied from fast/borders/svg-as-border-image-2.html.
  • svg/as-border-image/svg-as-border-image.html: Copied from fast/borders/svg-as-border-image.html.
  • svg/as-image/resources/butterfly.svg: Removed.
  • svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Removed.
  • svg/as-image/resources/svg-as-background-with-relative-size.svg: Removed.
  • svg/as-image/resources/width-100-percent.svg: Removed.
  • svg/as-image/svg-as-background-with-relative-size.html: Removed.
  • svg/as-image/svg-as-background-with-viewBox.html: Removed.
  • svg/as-image/svg-as-background.html: Removed.
  • svg/as-image/svg-as-tiled-background.html: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh.html: Removed.
  • svg/as-image/svg-background-partial-redraw.html: Removed.
  • svg/as-image/svg-width-100p-as-background.html: Removed.
1:15 AM Changeset in webkit [91632] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Update expectations for r91574.

  • platform/chromium-win/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-range-expected.txt:
  • platform/chromium/test_expectations.txt:

Jul 22, 2011:

9:11 PM Changeset in webkit [91631] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add crashing and failing expectations for canvas and css tests after r91628.
The failures are tracked by the bug 65063.

  • platform/chromium/test_expectations.txt:
8:54 PM Changeset in webkit [91630] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add crash expectation for http/tests/media/video-error-abort.html on Chromium Mac and Chromium Windows,
tracked by the bug 65062.

  • platform/chromium/test_expectations.txt:
6:55 PM Changeset in webkit [91629] by jamesr@google.com
  • 8 edits in trunk/Source/WebCore

[chromium] Seperate texture management for contents textures vs render surface textures
​https://bugs.webkit.org/show_bug.cgi?id=64771

Reviewed by Kenneth Russell.

Splits the chromium texture management across two TextureManagers, one for contents textures and one for render
surfaces. The lifetimes and relative evicition costs for these types of textures are significantly different.
Content textures need to be managed from paint time through draw time and evicting them is generally expensive,
since replacing the texture requires doing a software repaint into a buffer, creating a new texture, and
uploading the contents into the texture. Render surface textures are only used while drawing and never contain
useful contents between frames. The only reason to preserve a render surface texture between frames is to avoid
having to create the texture on the next frame, they never contain useful contents across frames.

The contents texture limits remain the same. Render surfaces are allocated the difference between the high
memory bound and the contents texture memory use during a frame and the difference between the low memory bound
and the contents texture memory use between frames.

Covered by existing compositing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::contentsTextureManager):
(WebCore::LayerRendererChromium::renderSurfaceTextureManager):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::createTile):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::prepareContentsTexture):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::setMemoryLimitBytes):
(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore::TextureManager::create):
(WebCore::TextureManager::currentMemoryUseBytes):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

5:39 PM Changeset in webkit [91628] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

2011-07-22 Simon Fraser <Simon Fraser>

Avoiding painting backgrounds if they are fully obscures by an object's foreground
​https://bugs.webkit.org/show_bug.cgi?id=65030

Reviewed by Dan Bernstein.

Some pages use animated loading GIFs as the background of <img>,
but WebKit keeps animating these after the <img> has loaded.

Thwart this by avoiding the painting of such backgrounds, if we can
determine that they are completely obscured by the border and content
of the element.

  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::currentFrameHasAlpha): Utility method, since currentFrame() is protected.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Call paintBackground(). (WebCore::RenderBox::paintBackground): New wrapper for the paintFillLayers() which paints the background layers, plus some code we call in a couple of places. This checks the new backgroundIsObscured() method before doing any painting.
  • rendering/RenderBox.h: (WebCore::RenderBox::backgroundIsObscured): New virtual method that determines whether any of the background is visible.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::BorderEdge::obscuresBackground): Returns true if this edge will entirely hide the background under it. (WebCore::RenderBoxModelObject::borderObscuresBackground): Determine whether the border hides the background.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::backgroundIsObscured): Override the RenderBox method and return true if the image is a loaded, opaque bitmap image, and the background won't show in the border or padding areas.
  • rendering/RenderImage.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): Use paintBackground().
5:19 PM Changeset in webkit [91627] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Patch by Sommer Panage <​panage@apple.com> on 2011-07-22
Reviewed by Oliver Hunt.

export JSContextCreateBacktrace as SPI in JSContextRefPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=64981

UIAutomation for iOS would like to support a Javascript backtrace in our error logs.
Currently, the C API does not provide the tools to do this. However, the private API
does expose the necessary functionality to get a backtrace
(via Interpreter::retrieveLastCaller). We recognize this information may result in
failure in the cases of programs run by 'eval', stack frames beneath host function
call frames, and in programs run from other programs. Thus, we propose exporting our
JSContextCreateBacktrace in JSContextRefPrivate.h. This will provide us with the tools
we need while not advertising an API that isn't really ready for full use.

5:18 PM Changeset in webkit [91626] by kbr@google.com
  • 4 edits
    2 adds in trunk

HTMLImageElement::crossOrigin is hard to use because of caching
​https://bugs.webkit.org/show_bug.cgi?id=64813

Reviewed by Adam Barth.

Source/WebCore:

Reload the resource if the allowCredentials flag doesn't match that in the request.

Test: http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):

  • loader/cache/CachedResourceLoader.h:

LayoutTests:

  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt: Added.
  • http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed.html: Added.
5:16 PM Changeset in webkit [91625] by rniwa@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Chromium Mac rebaseline after r91605.

  • platform/chromium-mac/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-scale-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
5:10 PM Changeset in webkit [91624] by ojan@chromium.org
  • 3 edits in trunk/Tools

Don't match 'DEBUG' when trying to filter BUG modifiers.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
5:01 PM Changeset in webkit [91623] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-07-22 Simon Fraser <Simon Fraser>

Need to update the acceleratesDrawing status on a layer when switching to/from tiled layers
​https://bugs.webkit.org/show_bug.cgi?id=65057

Reviewed by Joseph Pecoraro.

When switching to or from tiled layers, we need to update the new layer's
acceleratesDrawing status.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
4:58 PM Changeset in webkit [91622] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix issue loading gtests since there's no g_expectations.
Also, make filing a bug file a webkit.org bug, not a crbug since
the link is only shown for layout tests.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
4:37 PM Changeset in webkit [91621] by jamesr@google.com
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Remove code that attempted to explicitly sync compositing state before compositing
​https://bugs.webkit.org/show_bug.cgi?id=65055

Reviewed by Kenneth Russell.

There was some logic in WebViewImpl to try to synchronously calculate compositing requirements and sync
compositing state on all frames before painting in an attempt to flush out all pending updates before entering
the composite routines. The idea behind this code was that it would allow us to not worry about compositing
turning off in the middle of a composite operation due to things like RenderLayer overlap being lazily
calculated. In practice, we still need to be defensive to compositing requirements updating during the
composite anyway and this code is quite expensive on some pages (10ms+ on the HTML specification on my box).

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::layout):

  • src/WebViewImpl.h:
4:33 PM Changeset in webkit [91620] by ojan@chromium.org
  • 4 edits in trunk/Tools

pull test expectations into the dashboard from wvn.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=65054

Reviewed by Adam Barth.

Now that svn.webkit.org supports cors headers, we can just grab the txt
file from there instead of generating a JSON file that we upload
to appengine. We'll stop generating the JSON file in a followup patch.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4:32 PM Changeset in webkit [91619] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix typo so the tool works on a case-sensitive file system.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4:30 PM Changeset in webkit [91618] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic should know what patches are landing
​https://bugs.webkit.org/show_bug.cgi?id=64978

Reviewed by Dimitri Glazkov.

This patch adds a display of the recently committed patches to
garden-o-matic. The UI needs iteration, but this patch establishes the
plumbing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
    • Teach trac how to extract more information from the commit log.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
    • Add a data attribute for storing the revision.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
    • Add a container for the recent commit history.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
    • CSS for displaying non-ugly commit history.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
    • Wire up trac to the UI container.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
    • A basic, compact display for a list of commits.
4:26 PM Changeset in webkit [91617] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

Add [Optional=CallWithDefaultValues] flag and use it in initXXXEvent declarations
​https://bugs.webkit.org/show_bug.cgi?id=64973

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-07-22
Reviewed by Adam Barth.

We are doing away with the interface-level LegacyDefaultOptionalArguments
flag. To handle some cases of the old behavior, we need to define a new
(argument-level) flag so that functions can define optional arguments
but not have to declare every single combination of arguments in C++.
The old code generator handled this by calling a single C++ function
with all arguments, but with default values for the "optional" arguments.
Thus, this patch invents a new argument-level flag called
[Optional=CallWithDefaultValue] that emulates the old behavior.

This patch also fixes all the initXXXEvent declarations to remove the
LegacyDefaultOptionalArguments flag and use the new
[Optional=CallWithDefaultValue] flag only on the specific arguments that
require it for backward compatibility.

No new tests, all existing tests pass.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • dom/BeforeLoadEvent.idl:
  • dom/BeforeProcessEvent.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/StreamEvent.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • dom/WheelEvent.idl:
  • html/canvas/WebGLContextEvent.idl:
  • storage/StorageEvent.idl:
  • websockets/CloseEvent.idl:
4:22 PM Changeset in webkit [91616] by jberlin@webkit.org
  • 12 edits in trunk

Source/WebCore: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work
​https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit2: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work.
​https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

  • WebProcess/Cookies/mac/WebCookieManagerMac.mm:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
Set the policy on the Cookie Storage used by the Private Browsing Storage Session as well.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries: [WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work.
​https://bugs.webkit.org/show_bug.cgi?id=64997

Reviewed by Ada Chan.

Add a wrapper around the setter for the CF HTTP cookie accept policy (since it is not
declared in the public headers on Snow Leopard). This wrapper is not necessary for Windows.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
4:05 PM Changeset in webkit [91615] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix bug when switching from layout-tests to another test-type if
ToT webkit.org is the selected group.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:59 PM Changeset in webkit [91614] by ojan@chromium.org
  • 2 edits in trunk/Tools

Add back in line accidentally deleted in ​http://trac.webkit.org/changeset/91612.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
3:42 PM Changeset in webkit [91613] by cdn@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Hook v8 up to cryptographicallyRandomValues as an entropy source.
​https://bugs.webkit.org/show_bug.cgi?id=64887

Reviewed by Adam Barth.

  • public/WebKitClient.h:
  • src/WebKit.cpp:

(WebKit::generateEntropy):
(WebKit::initialize):

3:31 PM Changeset in webkit [91612] by ojan@chromium.org
  • 4 edits in trunk/Tools

simplify the flakiness dashboard to only show modifiers/expectations for the current builder
​https://bugs.webkit.org/show_bug.cgi?id=65049

Reviewed by Tony Chang.

This communicates less information, but probably makes the dashboard more usable.
Also make it show that bug lines that don't point to bug numbers still
show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
columns in any view. The data is still used, but only in the view that updates
the test_expectations.txt file.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3:23 PM Changeset in webkit [91611] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Perform the JavaScript navigation check on a complete URL
​https://bugs.webkit.org/show_bug.cgi?id=65038

Patch by Sergey Glazunov <​serg.glazunov@gmail.com> on 2011-07-22
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-document-baseURI-javascript.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

LayoutTests:

  • http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt: Added.
  • http/tests/security/xss-DENIED-document-baseURI-javascript.html: Added.
3:22 PM Changeset in webkit [91610] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=65051
DFG JIT - Enable by default for mac platform on x86-64.

Rubber Stamped by Geoff Garen.

This is now a performance progression.

  • wtf/Platform.h:
    • Removed definition of ENABLE_DFG_JIT_RESTRICTIONS.
3:17 PM Changeset in webkit [91609] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

3:12 PM Changeset in webkit [91608] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.3

New tag.

3:08 PM Changeset in webkit [91607] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=65047
DFG JIT - Add support for op_resolve/op_resolve_base

Reviewed by Sam Weinig.

These are necessary for any significant eval code coverage
(and as such increase LayoutTest coverage).

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordResolve):

  • Conservatively blow aliasing optimizations for now.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • Add support for op_resolve/op_resolve_base.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

  • Add call with exec, identifer aguments.
  • dfg/DFGNode.h:
    • Add new node types.

(JSC::DFG::Node::hasIdentifier):

  • Resolve nodes have identifiers, too!
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Add generation for new Nodes.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
    • Added new operations.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • Add generation for new Nodes.
2:31 PM Changeset in webkit [91606] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Revert r91595 for it broke Chromium Windows build.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
2:28 PM Changeset in webkit [91605] by jchaffraix@webkit.org
  • 1 edit
    31 adds in trunk/LayoutTests

RenderLayer fixed position logic needs more basic testing
​https://bugs.webkit.org/show_bug.cgi?id=64650

Reviewed by James Robinson.

Those test checks that basic repainting with position: fixed and
scrolling works correctly. The tests are mostly platform-agnostic as they
don't use any text or native controls.

  • fast/repaint/resources/default.css: Added.

Default style sheet for the following tests. This style sheet sets the default size to
avoid complicated calculation and adds some neat classes.

  • fast/repaint/fixed-scroll-simple.html: Added.

Filed ​https://bugs.webkit.org/show_bug.cgi?id=64639 about this test as we repaint too much.

  • fast/repaint/fixed-after-scroll-expected.txt: Added.
  • fast/repaint/fixed-after-scroll.html: Added.
  • fast/repaint/fixed-scale.html: Added.
  • fast/repaint/fixed-table-cell.html: Added.
  • fast/repaint/fixed-table-overflow-zindex.html: Added.
  • fast/repaint/fixed-table-overflow.html: Added.

Added those new repaint dumpAsText(true) tests.

  • fast/repaint/fixed-scale-expected.txt: Added.
  • fast/repaint/fixed-scroll-simple-expected.txt: Added.
  • fast/repaint/fixed-table-cell-expected.txt: Added.
  • fast/repaint/fixed-table-overflow-expected.txt: Added.
  • fast/repaint/fixed-table-overflow-zindex-expected.txt: Added.
  • platform/chromium/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-scale-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
  • platform/mac/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/mac/fast/repaint/fixed-scale-expected.png: Added.
  • platform/mac/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/mac/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
  • platform/qt/fast/repaint/fixed-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-scale-expected.png: Added.
  • platform/qt/fast/repaint/fixed-scroll-simple-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-cell-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-overflow-expected.png: Added.
  • platform/qt/fast/repaint/fixed-table-overflow-zindex-expected.png: Added.
2:25 PM Changeset in webkit [91604] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Chromium test expectation update; also rebaseline a test after r91574.

  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
2:21 PM WebKit Team edited by rwlbuis@webkit.org
(diff)
1:51 PM Changeset in webkit [91603] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-534.51-branch

Merge r87171.

1:49 PM Changeset in webkit [91602] by Lucas Forschler
  • 4 edits in branches/safari-534.51-branch/Source

Merge r87103.

1:27 PM Changeset in webkit [91601] by commit-queue@webkit.org
  • 7 edits in trunk

BORDER attribute with the IMG tag, using percentage values not working.
​https://bugs.webkit.org/show_bug.cgi?id=20226

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-07-22
Reviewed by Simon Fraser.

When border presentational attribute of image element has % in it, it should be parsed using
HTML parser rules. In this case, the algorithm is the one used described in:
​http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-non-negative-integers

Source/WebCore:

  • html/HTMLImageElement.cpp:

(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLNonNegativeInteger):

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

  • fast/images/border-expected.txt:
  • fast/images/script-tests/border.js:
1:17 PM Changeset in webkit [91600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste
​https://bugs.webkit.org/show_bug.cgi?id=61894

Patch by Scott Graham <​scottmg@chromium.org> on 2011-07-22
Reviewed by James Robinson.

DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs
that have passed through FrameLoader::dispatchWillSendRequest() and is
used by FrameLoader::loadedResourceFromMemoryCached to decide whether
to inform the FrameLoader's m_client about this load. Unfortunately,
this set holds a reference to the URL string for every resource
loaded, so on pages that use data URLs to "load" large amounts of data
this leaks lots of memory. The cache improves performance going through
FrameLoader::loadResourceFromMemoryCache, so rather than removing it,
simply exclude 'data:' urls from the cache to save the majority of
memory that is held for too long.

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::didTellClientAboutLoad):

1:04 PM Changeset in webkit [91599] by alokp@chromium.org
  • 4 edits in trunk/Source/WebCore

Use software rendering for small canvas
​https://bugs.webkit.org/show_bug.cgi?id=64958

Reviewed by Stephen White.

No new tests. Does not affect rendering output, just canvas backing.
If there is a regression, they should be caught by existing canvas tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldAccelerateCanvas):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):
(WebCore::CanvasRenderingContext2D::clearAcceleration):
(WebCore::CanvasRenderingContext2D::resetAcceleration):

  • html/canvas/CanvasRenderingContext2D.h:
12:57 PM Changeset in webkit [91598] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2011-07-22 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.
media/adopt-node-crash.html hasn't been flaky recently.

  • platform/chromium/test_expectations.txt:
12:52 PM Changeset in webkit [91597] by enne@google.com
  • 3 edits
    4 adds in trunk

Fix repainting of composited fixed position elements in iframes
​https://bugs.webkit.org/show_bug.cgi?id=64010

Reviewed by Simon Fraser.

Source/WebCore:

In cases where an iframe's contents have their own graphics layer, the
invalidation during scrolling was being sent to the wrong render
layer. Fixed by checking if such a layer exists and routing scrolling
invalidations there first.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsSlowPath):

LayoutTests:

  • compositing/iframes/fixed-position-iframe-expected.png: Added.
  • compositing/iframes/fixed-position-iframe-expected.txt: Added.
  • compositing/iframes/fixed-position-iframe.html: Added.
  • compositing/iframes/resources/fixed-position-subframe.html: Added.
12:47 PM Changeset in webkit [91596] by Lucas Forschler
  • 12 edits in branches/safari-534.51-branch/Source

Merge 91146.

12:42 PM Changeset in webkit [91595] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve (i.e., speed up) .gyp(i) files for Chromium
​https://bugs.webkit.org/show_bug.cgi?id=65032

Patch by Viet-Trung Luu <​viettrungluu@chromium.org> on 2011-07-22
Reviewed by Adam Barth.

Begin splitting off webcore_(privateheader_)files into separate lists
(dom/html/svg in this patch), to avoid the very slow pattern of
excluding all files and then filtering to include selected files.

Test by building (in all supported configurations).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
12:35 PM Changeset in webkit [91594] by tony@chromium.org
  • 8 edits
    2 adds in trunk/Source/WebCore

add placeholder RenderFlexibleBox.cpp files
​https://bugs.webkit.org/show_bug.cgi?id=64982

Reviewed by Ojan Vafai.

No new tests, just adding new files and making sure it compiles.
Also adding the isFlexibleBox identifier to RenderObject.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFlexibleBox.cpp: Added.

(WebCore::RenderFlexibleBox::RenderFlexibleBox): Inherit from RenderBlock like the old flexbox.
(WebCore::RenderFlexibleBox::~RenderFlexibleBox):
(WebCore::RenderFlexibleBox::renderName):
(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.h: Added.

(WebCore::RenderFlexibleBox::isFlexibleBox):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isFlexibleBox):

12:31 PM Changeset in webkit [91593] by Lucas Forschler
  • 6 edits in branches/safari-534.51-branch

Merge r91066.

12:29 PM Changeset in webkit [91592] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch

Merge r91005.

12:26 PM Changeset in webkit [91591] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Force slow scrolling path for non-composited frames in a composited page
​https://bugs.webkit.org/show_bug.cgi?id=64991

Reviewed by Darin Fisher.

The chromium compositor does not properly handle fast path scrolls for non-composited iframe in a composited
page.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

12:25 PM Changeset in webkit [91590] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-534.51-branch

Merge r90936.

12:23 PM Changeset in webkit [91589] by Lucas Forschler
  • 4 edits
    4 copies in branches/safari-534.51-branch

Merge r90914.

12:21 PM Changeset in webkit [91588] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r90851.

12:20 PM Changeset in webkit [91587] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r90797.

12:16 PM Changeset in webkit [91586] by ojan@chromium.org
  • 4 edits in trunk/Tools

hook in the rest of the bots to the dashboard now they run NRWT
​https://bugs.webkit.org/show_bug.cgi?id=64985

Reviewed by Adam Barth.

  • TestResultServer/static-dashboards/builders.js:
12:15 PM Changeset in webkit [91585] by weinig@apple.com
  • 19 edits in trunk/LayoutTests

Update results after change to make columns and column-span establish
formatting contexts in r91497

  • fast/multicol/single-line-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/scrolling-overflow-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
12:07 PM Changeset in webkit [91584] by scherkus@chromium.org
  • 9 edits in trunk/Source

Remove surfaceType() and texture() methods from Chromium video frame classes.
​https://bugs.webkit.org/show_bug.cgi?id=64818

Reviewed by Kenneth Russell.

Source/WebCore:

No tests as code was never being executed.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp:
  • src/VideoFrameChromiumImpl.h:
12:01 PM Changeset in webkit [91583] by Nate Chapin
  • 5 edits
    2 adds in trunk

Source/WebCore: Don't treat child frame loads as back-forward navigations
after the load event fires. This can lead to loading
the wrong url in the child frame.
​https://bugs.webkit.org/show_bug.cgi?id=64895

Reviewed by Mihai Parparita.

Test: fast/loader/child-frame-add-after-back-forward.html

  • dom/Document.h: Drive-by FIXME.
  • loader/DocumentLoader.h: Drive-by FIXME.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURLIntoChildFrame):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=64895.

Reviewed by Mihai Parparita.

  • fast/loader/child-frame-add-after-back-forward-expected.txt: Added.
  • fast/loader/child-frame-add-after-back-forward.html: Added.
11:42 AM Changeset in webkit [91582] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch

Merge r90573.

11:32 AM Changeset in webkit [91581] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r90486.

11:30 AM Changeset in webkit [91580] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r90282.

11:28 AM Changeset in webkit [91579] by Lucas Forschler
  • 3 edits in branches/safari-534.51-branch/Source/JavaScriptCore

Merge r90273.

11:25 AM Changeset in webkit [91578] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=65036
Messing with the register allocation within flow control = badness.

Reviewed by Sam Weinig.

  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • Fix register allocation.
11:12 AM Changeset in webkit [91577] by ap@apple.com
  • 2 edits in trunk/Tools

Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:00 AM Changeset in webkit [91576] by commit-queue@webkit.org
  • 5 edits in trunk

Date.prototype.toISOString doesn't handle negative years or years > 9999 correctly.
​https://bugs.webkit.org/show_bug.cgi?id=63986

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2011-07-22
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Changed the implementation of Date.prototype.toISOString() to use the extended year
format (+/-yyyyyy) for years outside of [0,9999] to be in compliance with ES 15.9.1.15.1.

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToISOString):

LayoutTests:

Changed the implementation of Date.prototype.toISOString() to use the extended year
format (+/-yyyyyy) for years outside of [0,9999] to be in compliance with ES 15.9.1.15.1.
Altered one test that tested for incorrect behavior on years > 9999, and added another test for
years < 0 (i.e. BCE).

  • fast/js/date-toisostring-expected.txt:
  • fast/js/script-tests/date-toisostring.js:
10:55 AM Changeset in webkit [91575] by inferno@chromium.org
  • 1 edit in branches/chromium/782/Source/WebCore/storage/IDBRequest.cpp

Merge 91571 - Fix crash in IDBRequest::abort

BUG=89511
Review URL: ​http://codereview.chromium.org/7488021

10:54 AM Changeset in webkit [91574] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

REGRESSION(r88757): The thumb of a vertical range slider is offset to the right on non-Mac.
​https://bugs.webkit.org/show_bug.cgi?id=65011

Patch by Kent Tamura <​tkent@google.com> on 2011-07-22
Reviewed by Dimitri Glazkov.

Source/WebCore:

We need to update the apeearance of thumbs before the layout of RenderSlider.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):
Added. This function adjsuts the apparance of a thumb for the appearance of an <input>.
(WebCore::RenderSliderThumb::isSliderThumb):
Added. Returns true.
(WebCore::RenderSliderThumb::layout):
Remove the appearance adjustment code. It is unnecessary because it is
done in RenderSlider::layout().
(WebCore::trackLimiterElementOf): Added.

  • html/shadow/SliderThumbElement.h: Move RenderSliderThumb from SliderThumbElement.cpp.
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSliderThumb): Added. Returns false.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):
If the renderers for the thumb element and the limiter element is
RenderSliderThumb, updates its appearance.

LayoutTests:

  • platform/chromium-linux/fast/forms/input-appearance-range-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-range-expected.txt:
  • platform/chromium/test_expectations.txt:
10:46 AM Changeset in webkit [91573] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

Validation message bubble is incorrectly positioned in a relative body.
​https://bugs.webkit.org/show_bug.cgi?id=65018

Reviewed by Dimitri Glazkov.

Source/WebCore:

We use position:aboslute for validation message bubbles, and the
origin of the absolute position can be not only the page, but also
an ancestor block with non-static position.

Test: fast/forms/validation-message-in-relative-body.html

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):
Subtract the containing block position from the host position.
(WebCore::ValidationMessage::buildBubbleTree):
Change the order of appendChild() and adjustBubblePosition() in
order to use RenderObject::containingBlock() in
adjustbubbleposition().

LayoutTests:

  • fast/forms/validation-message-in-relative-body-expected.txt: Added.
  • fast/forms/validation-message-in-relative-body.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:31 AM Changeset in webkit [91572] by commit-queue@webkit.org
  • 5 edits in trunk

Source/WebKit/efl: [EFL] ewk_frame_hit_test_new enhancement
​https://bugs.webkit.org/show_bug.cgi?id=64260

Replaces structure 'flags' with enum 'context' containing more hit test
result types and adds new char* fields to Ewk_Hit_Test structure:
image_uri and media_uri.

Patch by Michal Pakula vel Rutka <Michał Pakuła vel Rutka> on 2011-07-22
Reviewed by Antonio Gomes.

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):

  • ewk/ewk_frame.h:

Tools: [EFL] ewk_frame_hit_test_new enchancement
​https://bugs.webkit.org/show_bug.cgi?id=64260

Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
Replacing Ewk_Hit_Test_Result_Context structure 'flags'
in hit test output to by enum 'context'.

Patch by Michal Pakula vel Rutka <Michał Pakuła vel Rutka> on 2011-07-22
Reviewed by Antonio Gomes.

  • EWebLauncher/main.c:

(on_key_down):

10:07 AM Changeset in webkit [91571] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash in IDBRequest::abort
​https://bugs.webkit.org/show_bug.cgi?id=64740

Patch by David Grogan <​dgrogan@chromium.org> on 2011-07-22
Reviewed by Nate Chapin.

Tested manually with the testcase in the bug.

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::abort):

8:50 AM Changeset in webkit [91570] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

Replace preprocessor statements in IDL files with Conditional attribute
​https://bugs.webkit.org/show_bug.cgi?id=64961

Reviewed by Darin Adler.

Replaced ENABLE_DATALIST, ENABLE_DIRECTORY_UPLOAD, ENABLE_INPUT_SPEECH, ENABLE_MEDIA_STATISTICS
and ENABLE_ORIENTATION_EVENTS with the corresponding Conditional attribute.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.idl:
8:38 AM Changeset in webkit [91569] by caseq@chromium.org
  • 8 edits in trunk

011-07-22 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: [Extensions API] add webInspector.resources.onContentEdited
​https://bugs.webkit.org/show_bug.cgi?id=65024

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype.notifyResourceContentEdited):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.addRevision):

2011-07-22 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: [Extensions API] add webInspector.resources.onContentEdited
​https://bugs.webkit.org/show_bug.cgi?id=65024

Reviewed Pavel Feldman.

  • inspector/extensions/extensions-api-expected.txt:
  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
8:29 AM Changeset in webkit [91568] by podivilov@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: fix exception when paused in internal script.
​https://bugs.webkit.org/show_bug.cgi?id=64995

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/pause-in-internal-script.html

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.PresenationCallFrame.prototype.sourceLine):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/pause-in-internal-script-expected.txt: Added.
  • inspector/debugger/pause-in-internal-script.html: Added.
8:19 AM Changeset in webkit [91567] by loislo@chromium.org
  • 6 edits
    5 adds in trunk

Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
​https://bugs.webkit.org/show_bug.cgi?id=65016

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-receive-response-event.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::appendRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.dump):

  • inspector/timeline/resources/anImage.png: Added.
  • inspector/timeline/resources/anotherImage.png: Added.
  • inspector/timeline/timeline-receive-response-event-expected.txt: Added.
  • inspector/timeline/timeline-receive-response-event.html: Added.
  • platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
6:40 AM Changeset in webkit [91566] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r89535): Form reset does not repaint a file upload control.
​https://bugs.webkit.org/show_bug.cgi?id=65008

Patch by Kentaro Hara <​haraken@google.com> on 2011-07-22
Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected.

Tests: fast/forms/file-input-reset.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Calls repaint() if no files are selected.

LayoutTests:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected. The added test checks
if the label next to the file chooser button becomes "No file chosen"
when we press the reset button.

  • fast/forms/file-input-reset-expected.html: Added.
  • fast/forms/file-input-reset.html: Added.
6:38 AM Changeset in webkit [91565] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: the max depth of the Timeline events' stack trace should be customizable.
​https://bugs.webkit.org/show_bug.cgi?id=65023

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::startTimelineProfiler):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):

3:53 AM Changeset in webkit [91564] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Adjust test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=65020

Create WebKit bug for slow/timing out layout tests:
editing/execCommand/4786404-1.html and
editing/execCommand/break-out-of-empty-list-item.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
2:59 AM Changeset in webkit [91563] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:48 AM Changeset in webkit [91562] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r91024.
​http://trac.webkit.org/changeset/91024
​https://bugs.webkit.org/show_bug.cgi?id=65017

number of problems happened with invisible elements which grab
pointer events. (Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-22

  • inspector/front-end/inspector.css:

(.panel):
(.panel.visible):

1:34 AM Changeset in webkit [91561] by rniwa@webkit.org
  • 6 edits
    4 adds
    3 deletes in trunk/LayoutTests

Another Chromium rebaselines after r91493.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
12:30 AM Changeset in webkit [91560] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Revert r91510 due to Chromium debug test failures.

  • src/WebKit.cpp:

(WebKit::initialize):

12:16 AM Changeset in webkit [91559] by jpu@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Darin Adler.

[Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode().
​https://bugs.webkit.org/show_bug.cgi?id=64824
<rdar://problem/9624232>

  • editing/Editor.cpp:

(WebCore::Editor::textFieldDidEndEditing): Dismiss autocorrection panel when current node losing focus.

Note: See TracTimeline for information about the timeline view.