Timeline
Aug 2, 2011:
- 10:07 PM Changeset in webkit [92261] by
-
- 2 edits in trunk/Source/WebCore
Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584
Reviewed by David Kilzer.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.
- 9:37 PM Changeset in webkit [92260] by
-
- 3 edits3 adds in trunk
WebSocket: Should be closed by receiving invalid continuation frame.
https://bugs.webkit.org/show_bug.cgi?id=65527
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-02
Reviewed by Kent Tamura.
Source/WebCore:
Test: http/tests/websocket/tests/hybi/invalid-continuation.html
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):
LayoutTests:
- http/tests/websocket/tests/hybi/invalid-continuation-expected.txt: Added.
- http/tests/websocket/tests/hybi/invalid-continuation.html: Added.
- http/tests/websocket/tests/hybi/invalid-continuation_wsh.py: Added.
- 9:26 PM Changeset in webkit [92259] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r92256.
http://trac.webkit.org/changeset/92256
https://bugs.webkit.org/show_bug.cgi?id=65593
Causing tons of crashes on the chromium win bots (Requested by
jamesr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-02
- dom/Event.cpp:
- dom/Event.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventDispatcher.h:
- dom/KeyboardEvent.cpp:
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
- dom/MouseEvent.h:
- dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
- dom/WheelEvent.cpp:
- dom/WheelEvent.h:
- 8:59 PM Changeset in webkit [92258] by
-
- 2 edits in trunk/LayoutTests
More expectation updates for r92255
- platform/chromium/test_expectations.txt:
- 8:26 PM Changeset in webkit [92257] by
-
- 2 edits in trunk/LayoutTests
Expectation follow-up for r92255
- platform/chromium/test_expectations.txt:
- 8:25 PM Changeset in webkit [92256] by
-
- 12 edits in trunk/Source/WebCore
Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529
Reviewed by Dimitri Glazkov.
Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.
No changes to functionality so no new tests.
- dom/Event.cpp:
(WebCore::EventDispatchMediator::create):
- dom/Event.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventDispatcher.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::create):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
- dom/MouseEvent.h:
- dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::create):
- dom/WheelEvent.h:
- 7:52 PM Changeset in webkit [92255] by
-
- 15 edits in trunk
Source/WebCore: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942
Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.
Use an edge distance based method instead of the current linear
filtering method for producing anti-aliased edges on 3D transformed
layers. This removes the outer border handling from TilingData as
it's no longer needed for anti-aliasing.
Tests: platform/chromium/compositing/tiny-layer-rotated.html (existing)
platform/chromium/compositing/huge-layer-rotated.html (existing)
compositing/images/content-image-change.html (existing)
TilingDataTest in webkit_unit_tests
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::screenMatrix):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::windowMatrix):
- platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::prepareToUpdate):
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTiles):
- platform/graphics/chromium/LayerTilerChromium.h:
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderTile::VertexShaderTile):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderTile::getShaderString):
(WebCore::FragmentTexAlphaAABinding::FragmentTexAlphaAABinding):
(WebCore::FragmentTexAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexSwizzleAlphaAA::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderTile::vertexTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::alphaLocation):
(WebCore::FragmentTexAlphaAABinding::samplerLocation):
(WebCore::FragmentTexAlphaAABinding::fragmentTexTransformLocation):
(WebCore::FragmentTexAlphaAABinding::edgeLocation):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::setIsMask):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::intersectDrawQuad):
(WebCore::TilingData::textureOffset):
- platform/graphics/gpu/TilingData.h:
Source/WebKit/chromium: [Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942
Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.
- tests/TilingDataTest.cpp:
(WebCore::TEST):
LayoutTests: [Chromium] Use edge-distance method for layer anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=64942
Patch by David Reveman <reveman@chromium.org> on 2011-08-02
Reviewed by James Robinson.
Update expected results.
- platform/chromium/test_expectations.txt:
- 7:28 PM Changeset in webkit [92254] by
-
- 14 edits3 adds in trunk/Source
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
Reviewed by Dmitry Titov.
Source/JavaScriptCore:
- GNUmakefile.list.am: Added new files to the build.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider): Ditto.
- wtf/CMakeLists.txt: Added new files to the build.
- wtf/ThreadRestrictionVerifier.h: Added.
Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):
- wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
- wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium (bug 58093).
Source/JavaScriptGlue:
- ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
Source/WebCore:
No new functionality exposed so no new tests. (The change is basically adding
more testing.)
- ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.
- 7:11 PM Changeset in webkit [92253] by
-
- 3 edits in trunk/Source/WebCore
Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=65441
Reviewed by Simon Fraser.
No new tests / refactoring only.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getFloatValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getIntValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getValue):
Templated getValue that works for all numeric types.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use getValue<short> instead of rolling-your-own clamp to short.
- 6:58 PM Changeset in webkit [92252] by
-
- 35 edits in trunk/Source/WebCore
RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
https://bugs.webkit.org/show_bug.cgi?id=65494
Reviewed by Darin Adler.
No new tests, const-ness change only.
- rendering/RenderObject.h:
(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
Made those 2 const as they call a const method now.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as
this is const.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::rectWithOutlineForRepaint):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderReplaced.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
- rendering/RenderTableRow.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
- rendering/RenderText.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
- rendering/RenderView.h:
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
- rendering/svg/RenderSVGText.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):
- rendering/svg/SVGRenderSupport.h:
Updated the following method's signature to use a const object.
- 6:48 PM Changeset in webkit [92251] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC GC may not be able to reuse partially-free blocks after a
full collection
https://bugs.webkit.org/show_bug.cgi?id=65585
Reviewed by Darin Adler.
This fixes the linked list management bug. This fix is performance
neutral on SunSpider.
- heap/NewSpace.cpp:
(JSC::NewSpace::removeBlock):
- 5:41 PM Changeset in webkit [92250] by
-
- 6 edits in trunk/Source/JavaScriptCore
Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422
Reviewed by Gavin Barraclough.
Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject. This doesn't impact performance, but
we can use this change to make other improvements later.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):
- 5:04 PM Changeset in webkit [92249] by
-
- 4 edits in trunk/Source/WebCore
Add namespace prefix support in XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65578
Reviewed by Adam Barth.
This also changes markup debug printing to print to stderr instead of stdout
- xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::printString):
- xml/parser/XMLToken.h:
(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):
(WebCore::XMLToken::clear):
(WebCore::XMLToken::appendToName):
(WebCore::XMLToken::name):
(WebCore::XMLToken::target):
(WebCore::XMLToken::data):
(WebCore::XMLToken::prefix):
(WebCore::XMLToken::xmlDeclarationData):
(WebCore::XMLToken::endPrefix):
(WebCore::XMLToken::hasPrefix):
(WebCore::XMLToken::endAttributePrefix):
(WebCore::XMLToken::attributeHasPrefix):
(WebCore::XMLToken::printAttrs):
(WebCore::XMLToken::print):
- xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):
- 5:02 PM Changeset in webkit [92248] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r92238.
http://trac.webkit.org/changeset/92238
https://bugs.webkit.org/show_bug.cgi?id=65555
fail fast/events/scrollbar-double-click.html on Mac
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::paint):
- 4:47 PM Changeset in webkit [92247] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from History.idl
https://bugs.webkit.org/show_bug.cgi?id=65572
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- page/History.idl:
- 4:41 PM Changeset in webkit [92246] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
https://bugs.webkit.org/show_bug.cgi?id=65571
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- page/WebKitAnimationList.idl:
- 4:20 PM Changeset in webkit [92245] by
-
- 25 edits2 copies in trunk/Source
[chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms
https://bugs.webkit.org/show_bug.cgi?id=58840
Patch by James Robinson <jamesr@chromium.org> on 2011-08-02
Reviewed by Kenneth Russell.
This decouples the layer visibility related calculations from the LayerChromium and CCLayerImpl trees. This is
done by making LayerRendererChromium's "calculate the world" function (renamed
calculateDrawTransformsAndVisibility()) a templated, free function that can operate on either LayerChromium +
RenderSurfaceChromium pairs or on CCLayerImpl + CCRenderSurface pairs and invoking it twice, once before
painting and once before drawing. Before painting, these calculations are used to determine which layers are
potentially visible and should be painted, which depends on the calculated opacity, render surface bounds, and
draw transforms. Before drawing, these calculations are used to figure out everything needed to draw.
RenderSurfaceChromium is now used just for visibility calculations when painting. CCRenderSurfaceChromium is
responsible for actually drawing the render surfaces.
This does mean that in the current implementation the second calculations are redundant, but in the future this
won't be the case since the pre-draw time calculations might be influenced by animations or gestures. I've
added some traces to try to monitor if this math is a significant amount of the per-frame computation. Note
that layer sorting only happens on the CCLayerImpl tree and the layer sort algorithm is the most expensive part
of the calculations currently.
This removes all of the weak back/forward pointers between LayerChromium and CCLayerImpls, the trees are now
truly decoupled.
Covered by compositing/ tests.
- WebCore.gypi:
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
(WebCore::LayerChromium::createCCLayerImpl):
(WebCore::LayerChromium::createRenderSurface):
(WebCore::LayerChromium::descendantsDrawsContent):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUsesLayerScissor):
(WebCore::LayerChromium::usesLayerScissor):
(WebCore::LayerChromium::clearRenderSurface):
(WebCore::LayerChromium::renderSurface):
(WebCore::LayerChromium::drawOpacity):
(WebCore::LayerChromium::setDrawOpacity):
(WebCore::LayerChromium::scissorRect):
(WebCore::LayerChromium::setScissorRect):
(WebCore::LayerChromium::targetRenderSurface):
(WebCore::LayerChromium::setTargetRenderSurface):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::drawableContentRect):
(WebCore::LayerChromium::setDrawableContentRect):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::~RenderSurfaceChromium):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::clearLayerList):
(WebCore::RenderSurfaceChromium::layerList):
(WebCore::RenderSurfaceChromium::setMaskLayer):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createCCLayerImpl):
(WebCore::TiledLayerChromium::tilingTransform):
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(WebCore::CCCanvasLayerImpl::create):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::bindContentsTexture):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::renderSurface):
(WebCore::CCLayerImpl::targetRenderSurface):
(WebCore::CCLayerImpl::setTargetRenderSurface):
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphNodes):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::create):
- platform/graphics/chromium/cc/CCRenderSurface.cpp: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp.
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::~CCRenderSurface):
(WebCore::CCRenderSurface::cleanupResources):
(WebCore::CCRenderSurface::layerRenderer):
(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::name):
(WebCore::writeIndent):
(WebCore::CCRenderSurface::dumpSurface):
(WebCore::CCRenderSurface::owningLayerId):
- platform/graphics/chromium/cc/CCRenderSurface.h: Copied from Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h.
(WebCore::CCRenderSurface::contentRectCenter):
(WebCore::CCRenderSurface::drawOpacity):
(WebCore::CCRenderSurface::setDrawOpacity):
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScissorRect):
(WebCore::CCRenderSurface::scissorRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::contentRect):
(WebCore::CCRenderSurface::setSkipsDraw):
(WebCore::CCRenderSurface::skipsDraw):
(WebCore::CCRenderSurface::clearLayerList):
(WebCore::CCRenderSurface::layerList):
(WebCore::CCRenderSurface::setMaskLayer):
(WebCore::CCRenderSurface::contentsTexture):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::create):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):
- 4:18 PM Changeset in webkit [92244] by
-
- 3 edits in trunk/Tools
Add mac-lion platform to old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65577
- Scripts/old-run-webkit-tests:
- Scripts/webkitdirs.pm:
(isLion):
- 4:15 PM Changeset in webkit [92243] by
-
- 3 edits in trunk/Source/WebCore
Implement CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition and CSSPropertyWebkitTextEmphasisStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=65517
Reviewed by Dimitri Glazkov.
No new tests. Just refactoring and moving code around.
- css/CSSStyleApplyProperty.cpp:
Added class ApplyPropertyTextEmphasisStyle to handle the special TextEmphasisStyle logic.
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Added initializations for CSSPropertyWebkitTextCombine, CSSPropertyWebkitTextEmphasisPosition, CSSPropertyWebkitTextEmphasisStyle.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations.
- 3:47 PM Changeset in webkit [92242] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
https://bugs.webkit.org/show_bug.cgi?id=65570
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass
- page/SpeechInputResultList.idl:
- 3:41 PM Changeset in webkit [92241] by
-
- 2 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from EventSource.idl
https://bugs.webkit.org/show_bug.cgi?id=65568
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- page/EventSource.idl:
- 3:19 PM Changeset in webkit [92240] by
-
- 2 edits in trunk
Missing null check in WebViewImpl::selectionRange
https://bugs.webkit.org/show_bug.cgi?id=65561
Patch by Varun Jain <varunjain@google.com> on 2011-08-02
Reviewed by Darin Fisher.
- Source/WebKit/chromium/src/WebViewImpl.cpp:
- 3:17 PM Changeset in webkit [92239] by
-
- 2 edits in trunk/Source/WebCore
fail earlier to track down null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=65563
Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
Reviewed by Alexey Proskuryakov.
No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
- 3:11 PM Changeset in webkit [92238] by
-
- 5 edits in trunk/Source/WebCore
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555
Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-02
Reviewed by James Robinson.
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
- platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):
- 2:36 PM Changeset in webkit [92237] by
-
- 19 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65337
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Nikolas Zimmermann.
No new tests, all existing tests pass.
- svg/ElementTimeControl.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGDocument.idl:
- svg/SVGElementInstance.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGException.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGLocatable.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStylable.idl:
- svg/SVGStyleElement.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- 2:35 PM Changeset in webkit [92236] by
-
- 14 edits in trunk/Source/WebCore
Remove LegacyDefaultOptionalArguments flag from CSS IDL files
https://bugs.webkit.org/show_bug.cgi?id=65341
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
No new tests. All existing tests pass.
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- 2:33 PM Changeset in webkit [92235] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectations update, gardener stuff.
- platform/chromium/test_expectations.txt:
- 2:26 PM Changeset in webkit [92234] by
-
- 21 edits in trunk/Source
[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044
Source/WebCore:
Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02
Reviewed by Adam Barth.
Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
- dom/WheelEvent.h:
Added symbolic contstant for tick multiplier.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.
- page/EventHandler.h:
- page/FrameView.cpp:
(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.
- platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.
- platform/PlatformGestureRecognizer.h:
- platform/chromium/FramelessScrollView.h:
Added support for displatching gesture and touch events.
- platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):
- platform/chromium/GestureRecognizerChromium.h:
- platform/chromium/PopupMenuChromium.cpp:
Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
- platform/chromium/PopupMenuChromium.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.
Source/WebKit/chromium:
Reviewed by Adam Barth.
Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.
Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-08-02
- features.gypi:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.
- src/WebPopupMenuImpl.cpp:
Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):
- src/WebViewImpl.h:
- 2:22 PM Changeset in webkit [92233] by
-
- 9 edits in trunk/Source/JavaScriptCore
JSC GC uses dummy cells to avoid having to remember which cells
it has already destroyed
https://bugs.webkit.org/show_bug.cgi?id=65556
Reviewed by Oliver Hunt.
This gets rid of dummy cells, and ensures that it's not necessary
to invoke a destructor on cells that have already been swept. In
the common case, a block knows that either all of its free cells
still need to have destructors called, or none of them do, which
minimizes the amount of branching that needs to happen per cell
when performing a sweep.
This is performance neutral on SunSpider and V8. It is meant as
a stepping stone to simplify the implementation of more
sophisticated sweeping algorithms.
- heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedReset):
(JSC::MarkedBlock::reset):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::produceFreeList):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::FreeCell::setNoObject):
(JSC::MarkedBlock::setDestructorState):
(JSC::MarkedBlock::destructorState):
(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):
- runtime/JSCell.cpp:
- runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
- runtime/JSGlobalData.h:
- runtime/Structure.h:
- 2:22 PM Changeset in webkit [92232] by
-
- 2 edits in trunk/LayoutTests
Add scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list.
- platform/mac/Skipped:
- 2:19 PM Changeset in webkit [92231] by
-
- 6 edits in trunk/Source
Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
https://bugs.webkit.org/show_bug.cgi?id=65502
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
added an assert to the return code of madvise to catch any regressions.
- wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease):
Source/WebCore:
Change the vm_copy in PurgeableBuffer::create to be a memcpy. The
vm_copy causes the process to have additional references to the same
memory region. These additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.
No tests added this is a resource defect and not a functional issue.
- platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create):
Source/WebKit2:
Changed OOL message to use MACH_MSG_PHYSICAL_COPY flag instead of virtual flag
so that the original memory region isn't referenced by the message and ultimately
the receiving process. The additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
- 2:13 PM Changeset in webkit [92230] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 2:08 PM Changeset in webkit [92229] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectations update, gardener stuff.
- platform/chromium/test_expectations.txt:
- 2:06 PM Changeset in webkit [92228] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Sam Weinig.
- fast/blockflow/japanese-rl-text-with-broken-font.html:
This test would create an empty RenderText after the change to make it asynchronous.
Fix this by putting the script inside the head.
- 2:06 PM Changeset in webkit [92227] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560
Reviewed by James Robinson.
No new tests. (Printing has few tests, sadly.)
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.
- 1:52 PM Changeset in webkit [92226] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a Windows build error.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:47 PM Changeset in webkit [92225] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, mark SelectPopupMenuTest.SelectItemKeyEvent as flaky, gardener stuff.
- tests/PopupMenuTest.cpp:
(WebKit::TEST_F):
- 1:40 PM Changeset in webkit [92224] by
-
- 10 edits in trunk/Source
JSC GC is far too conservative about growing the heap size, particularly
on desktop platforms
https://bugs.webkit.org/show_bug.cgi?id=65438
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The minimum heap size is now 16MB instead of 512KB, provided all of the
following are true:
a) ENABLE(LARGE_HEAP) is set, which currently only happens on
x86 targets, but could reasonably happen on any platform that is
known to have a decent amount of RAM.
b) JSGlobalData is initialized with HeapSize = LargeHeap, which
currently only happens when it's the JSDOMWindowBase in WebCore or
in the jsc command-line tool.
This is a 4.1% speed-up on SunSpider.
- JavaScriptCore.exp:
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
- heap/Heap.h:
- jsc.cpp:
(main):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
- runtime/JSGlobalData.h:
- wtf/Platform.h:
Source/WebCore:
No change in behavior, thus no new tests.
Pass the LargeHeap hint to JSGlobalData when creating the JSC runtime
instance corresponding to non-worker JS code.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
- 1:38 PM Changeset in webkit [92223] by
-
- 11 edits in trunk
--webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
https://bugs.webkit.org/show_bug.cgi?id=61346
Patch by Van Lam <vanlam@google.com> on 2011-08-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
When collecintg word boundaries in a box, explicitly check if the box
is at the end of line (so it should contain the end-of-line position)
and collect the end-of-line position.
- editing/visible_units.cpp:
(WebCore::isBoxVisuallyLastInLine):
(WebCore::appendPositionAtLogicalEndOfLine):
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
LayoutTests:
Updated test cases to check for visual word movement to the end-of-line
position.
- editing/selection/move-by-word-visually-multi-line-expected.txt:
- editing/selection/move-by-word-visually-multi-line.html:
- editing/selection/move-by-word-visually-multi-space-expected.txt:
- editing/selection/move-by-word-visually-multi-space.html:
- editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
- editing/selection/move-by-word-visually-single-space-inline-element.html:
- editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
- editing/selection/move-by-word-visually-single-space-one-element.html:
- 1:31 PM Changeset in webkit [92222] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectations update, gardener stuff.
- platform/chromium/test_expectations.txt:
- 1:24 PM QtWebKitRelease22 edited by
- (diff)
- 1:12 PM Changeset in webkit [92221] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Should save scroll positions for network panel Response and Preview tabs.
https://bugs.webkit.org/show_bug.cgi?id=65557
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkItemView.js:
(WebInspector.ResourceContentView.prototype.get innerView):
(WebInspector.ResourceContentView.prototype.set innerView):
(WebInspector.ResourceContentView.prototype.hide):
- inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype.contentLoaded):
- inspector/front-end/ResourceResponseView.js:
(WebInspector.ResourceResponseView.prototype.contentLoaded):
- 1:06 PM Changeset in webkit [92220] by
-
- 2 edits in trunk/Tools
Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
https://bugs.webkit.org/show_bug.cgi?id=65554
Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-02
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 1:00 PM Changeset in webkit [92219] by
-
- 6 edits2 adds in trunk
Tools: Implement WebPermissionClient::allowPlugins for layout tests
https://bugs.webkit.org/show_bug.cgi?id=33991
Reviewed by Adam Barth.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setPluginsAllowed):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowPlugins):
(WebPermissions::setPluginsAllowed):
(WebPermissions::reset):
- DumpRenderTree/chromium/WebPermissions.h:
LayoutTests: Add a test for FrameLoaderClient::allowPlugins
https://bugs.webkit.org/show_bug.cgi?id=33991
Reviewed by Adam Barth.
- platform/chromium/permissionclient/plugin-permission-expected.txt: Added.
- platform/chromium/permissionclient/plugin-permission.html: Added.
- 12:57 PM Changeset in webkit [92218] by
-
- 2 edits in trunk/Tools
TestFailures unit tests leak a global variable
https://bugs.webkit.org/show_bug.cgi?id=65500
Reviewed by Adam Roben.
qunit detects the leak if you check the "noglobals" box on run-unittests.html.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
- 12:57 PM Changeset in webkit [92217] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445
Reviewed by Oliver Hunt.
If the high watermark is not reached, then we allocate new blocks as
before. If the current watermark does reach (or exceed) the high
watermark, then we check if there is a block on the free block pool.
If there is, we simply allocation from it. If there isn't, we
invoke a collectin as before. This effectively couples the elastic
scavenging to the collector's decision function. That is, if an
application rapidly varies its heap usage (sometimes using more and
sometimes less) then the collector will not thrash as it used to.
But if heap usage drops and stays low then the scavenger thread and
the GC will eventually reach a kind of consensus: the GC will set
the watermark low because of low heap usage, and the scavenger thread
will steadily eliminate pages from the free page pool, until the size
of the free pool is below the high watermark.
On command-line, this is neutral on SunSpider and Kraken and a 3% win
on V8. In browser, this is a 1% win on V8 and neutral on the other
two.
- heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::allocateBlock):
- heap/Heap.h:
- 12:50 PM Changeset in webkit [92216] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Ignore empty requests on policy decisions.
https://bugs.webkit.org/show_bug.cgi?id=64536
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-02
Reviewed by Kenneth Rohde Christiansen.
This is the same fix introduced in the GTK+ port in r41313: empty
request should be ignored, so tests such as
fast/loader/empty-embed-src-attribute.html do not crash.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
- 12:15 PM Changeset in webkit [92215] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rebaseline, gardener stuff.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png:
- platform/chromium/test_expectations.txt:
- 11:45 AM Changeset in webkit [92214] by
-
- 11 edits in branches/safari-534.51-branch
Merge r91616.
- 11:41 AM Changeset in webkit [92213] by
-
- 8 edits1 copy in trunk
Web Inspector: Remove initator column for JSC, fix network resource initiator tests.
https://bugs.webkit.org/show_bug.cgi?id=65534
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
- inspector/front-end/Settings.js:
Source/WebKit/chromium:
- src/js/DevTools.js:
():
LayoutTests:
- http/tests/inspector/network/network-initiator-expected.txt:
- http/tests/inspector/network/network-initiator.html:
- platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-initiator-expected.txt.
- 11:32 AM Changeset in webkit [92212] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: SourceFrame should store saved scroll positions in View.
https://bugs.webkit.org/show_bug.cgi?id=65472
Reviewed by Pavel Feldman.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFileChanged):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.get scrollLeft):
(WebInspector.SourceFrame.prototype.set scrollLeft):
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):
- inspector/front-end/View.js:
(WebInspector.View.prototype._innerShow):
(WebInspector.View.prototype._innerHide):
(WebInspector.View.prototype.detach):
(WebInspector.View.prototype.storeScrollPositions):
(WebInspector.View.prototype.inheritScrollPositionsFromView):
(WebInspector.View.prototype.restoreScrollPositions):
- 11:32 AM Changeset in webkit [92211] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation updates, gardener stuff.
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [92210] by
-
- 4 edits in trunk/Source
Move WTF_USE_AVFOUNDATION from JavaScriptCore/wtf/platform.h to WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=65552
Since this is a WebCore feature, there's no need to define it in JavaScriptCore/wtf/platform.h.
Reviewed by Adam Roben.
Source/JavaScriptCore:
- wtf/Platform.h: Removed WTF_USE_AVFOUNDATION.
Source/WebCore:
No change in functionality, so new tests.
- config.h: Added WTF_USE_AVFOUNDATION.
- 11:29 AM Changeset in webkit [92209] by
-
- 1 edit4 adds in trunk/LayoutTests
Add Snow Leopard specific test results.
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
- platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
- platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
- platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
- 11:26 AM Changeset in webkit [92208] by
-
- 2 edits in trunk/LayoutTests
Remove time out expectation since media/track has been added to the skipped list on GTK.
- platform/gtk/test_expectations.txt:
- 11:07 AM Changeset in webkit [92207] by
-
- 3 edits in trunk/Source/WebCore
Split RenderBlock::layoutRunsAndFloats into multiple methods
https://bugs.webkit.org/show_bug.cgi?id=65376
Extracted layoutRunsAndFloatsInRange, linkToEndLineIfNeeded and repaintDirtyFloats methods and moved
most of the locals to LineLayoutState.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-02
Reviewed by David Hyatt.
No new tests needed because it is just refactoring existing code.
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::repaintDirtyFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
- 10:53 AM Changeset in webkit [92206] by
-
- 5 edits in trunk/Source
[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
https://bugs.webkit.org/show_bug.cgi?id=65519
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setViewport):
- platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 10:37 AM Changeset in webkit [92205] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove expectations for no longer crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=65155
Unreviewed expectation update.
These were fixed after Chromium r94376, r94374, r94373.
- platform/chromium/test_expectations.txt:
- 10:36 AM Changeset in webkit [92204] by
-
- 18 edits2 copies in branches/chromium/835
Merge 92143 - .: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Update exports for test harness.
- Source/autotools/symbols.filter:
Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).
With this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load. Test added for crash discovered in
previous revision, but no tests for memory usage.
Test: http/tests/inspector/network/disabled-cache-crash.html
- WebCore.exp.in:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::hasOneHandle):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
- loader/cache/CachedResourceLoader.h:
- testing/Internals.cpp:
(WebCore::Internals::disableMemoryCache):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Update exports for test harness.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006
Test for CachedResourceLoader. Not caused by cache-disabling but very
difficult to reproduce when cache is active, so use cache disable in
inspector to exercise code.
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
- http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
- http/tests/inspector/network/disabled-cache-crash.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7548016
- 10:33 AM Changeset in webkit [92203] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
https://bugs.webkit.org/show_bug.cgi?id=65498
Reviewed by Dimitri Glazkov.
- WebCore.gyp/mac/adjust_visibility.sh:
- 10:31 AM Changeset in webkit [92202] by
-
- 4 edits in branches/chromium/835/Source/WebCore
Merge 91725 - REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-07-25
Reviewed by Nate Chapin.
Rollback previous patch. Occasional crashes seen caused by
CachedResource being deleted twice.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
- loader/cache/CachedResourceLoader.h:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7542020
- 10:16 AM Changeset in webkit [92201] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Removed a dangling reference to Leopard Intel Release (Build).
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:08 AM Changeset in webkit [92200] by
-
- 3 edits4 adds in trunk
hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by David Hyatt.
Source/WebCore:
When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block. We choose the insertion
point to be the first child only if the anonymous block has children, otherwise the before element ends up
in a wrong block.
Tests: fast/dynamic/hover-before-position-after-style-change.html
fast/dynamic/hover-before-position-after-style-change2.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
- fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
- fast/dynamic/hover-before-position-after-style-change.html: Added.
- fast/dynamic/hover-before-position-after-style-change2-expected.txt: Added.
- fast/dynamic/hover-before-position-after-style-change2.html: Added.
- 10:00 AM Changeset in webkit [92199] by
-
- 6 edits1 copy in trunk/Source/WebKit2
[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
https://bugs.webkit.org/show_bug.cgi?id=65378
Reviewed by Benjamin Poulain.
This prevent the runner of the tests from having to add it to PATH himself.
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::tst_CommonViewTests):
- UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::tst_QDesktopWebView):
- UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::tst_QTouchWebView):
- UIProcess/API/qt/tests/tests.pri:
- UIProcess/API/qt/tests/util.cpp: Copied from Source/WebKit2/UIProcess/API/qt/tests/util.h.
Move definitions to a cpp file to prevent unused static symbol warnings.
(addQtWebProcessToPath):
(waitForSignal):
- UIProcess/API/qt/tests/util.h:
- 10:00 AM Changeset in webkit [92198] by
-
- 3 edits in trunk/Source/WebKit2
TiledDrawingArea: Handle update requests in the order they were received.
https://bugs.webkit.org/show_bug.cgi?id=64365
Reviewed by Andreas Kling.
TiledDrawingAreaProxy::createTiles() uses the distance of tiles to the
center of the viewport to decide which tile should be rendered first.
This logic is useless if the requests are not handled in the same order
as they were received.
Now use a list instead of a map to hold pending tile update requests.
- WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::cancelTileUpdate):
(WebKit::TiledDrawingArea::requestTileUpdate):
- WebProcess/WebPage/TiledDrawingArea.h:
- 9:34 AM Changeset in webkit [92197] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Simplify Path::translate() implementation.
https://bugs.webkit.org/show_bug.cgi?id=65540
Patch by Andreas Kling <kling@webkit.org> on 2011-08-02
Reviewed by Benjamin Poulain.
- platform/graphics/qt/PathQt.cpp:
(WebCore::Path::translate):
- 8:59 AM Changeset in webkit [92196] by
-
- 6 edits in trunk
Web Inspector: merge FormattedSourceFile into SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65411
Reviewed by Pavel Feldman.
Prepare for splitting SourceFile into RawSourceCode and UISourceCode:
- merge FormattedSourceFile into SourceFile
- rename SourceFile to RawSourceCode
- hide formatter worker lazy creation in ScriptFormatter
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.ScriptFormatter.prototype.get _worker):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._invokeRequestContentCallbacks):
LayoutTests:
- inspector/debugger/source-file.html:
- 8:58 AM Changeset in webkit [92195] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions]Fix build after changeset 92106
https://bugs.webkit.org/show_bug.cgi?id=65539
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-02
Reviewed by Adam Roben.
No new tests since it is just a build fix.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- 8:54 AM Changeset in webkit [92194] by
-
- 3 edits2 adds in trunk
Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
https://bugs.webkit.org/show_bug.cgi?id=65466
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/network/network-initiator-from-console.html
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
LayoutTests:
- http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
- http/tests/inspector/network/network-initiator-from-console.html: Added.
- 8:52 AM Changeset in webkit [92193] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: REGRESSION(r92105): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65525
- platform/qt/Skipped: Unskip tests, because r92185 fixed the bug.
- 8:51 AM Changeset in webkit [92192] by
-
- 5 edits in trunk
Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
https://bugs.webkit.org/show_bug.cgi?id=65514
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/StylesSidebarPane.js:
LayoutTests:
- inspector/elements/elements-panel-styles-expected.txt:
- inspector/elements/elements-panel-styles.html:
- 8:25 AM Changeset in webkit [92191] by
-
- 3 edits in trunk/Tools
CSS Regions build bot should archive and upload output files
https://bugs.webkit.org/show_bug.cgi?id=65200
Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
The "features" argument is now taken into account when determining the name of the archive on the server. That
was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-02
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 8:18 AM Changeset in webkit [92190] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Remove overlapping recursive layout function
https://bugs.webkit.org/show_bug.cgi?id=63241
First, _ewk_view_layout_if_needed_recursive is called twice in _ewk_view_smart_calculate
and _ewk_view_tiled_updates_process_pre,so it is no problem removing one of them.
Second, In tiled backingstore configuration, _ewk_view_layout_if_needed_recursive called
in _ewk_view_smart_calculate will result in generating repaints for dirty areas
located outside of viewport since m_paintEntireContents is set.
But, the areas will not be actually painted. Thus, the layout is unnecessary except
when there is something to paint inside of viewport, which will consume CPU unnecessarily.
So,the layout func was removed from _ewk_view_smart_calculate
and added to _ewk_view_single_smart_repaints_process for single backingstore.
Patch by Eunsol Park <eunsol47.park@samsung.com> on 2011-08-02
Reviewed by Antonio Gomes.
- ewk/ewk_view.cpp:
(_ewk_view_smart_calculate):
- ewk/ewk_view_single.c:
(_ewk_view_single_smart_repaints_process):
- 8:08 AM Changeset in webkit [92189] by
-
- 7 edits3 adds in trunk/Source
[EFL] Add fullscreen button to media control UI.
https://bugs.webkit.org/show_bug.cgi?id=64428
Source/WebCore:
Implement paintMediaFullscreenButton and emit fullscreen signal.
Reviewed by Antonio Gomes.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
- platform/efl/RenderThemeEfl.h:
Source/WebKit/efl:
Implement functions for full screen in ChromeClientEfl in order to display a full screen button on media control UI.
When full screen mode is activated by pressing the button, the functions are called by Document. So, if there is no implemented
function, full screen button will not be shown.
In addition, a .edc file and an image file are added for full screen button.
Reviewed by Antonio Gomes.
- DefaultTheme/default.edc:
- DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Added.
- DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Added.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::supportsFullScreenForElement):
(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):
- WebCoreSupport/ChromeClientEfl.h:
- 7:11 AM Changeset in webkit [92188] by
-
- 2 edits in trunk/Tools
Fix _win32_check_running_pid on 64bit windows python
https://bugs.webkit.org/show_bug.cgi?id=64950
Reviewed by Adam Roben.
Use the correct types for the PROCESSENTRY32 struct.
th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
failure, when calling the Process32First function.
This is covered by the executive unittest.
- Scripts/webkitpy/common/system/executive.py:
- 7:01 AM Changeset in webkit [92187] by
-
- 5 edits2 adds in trunk
2011-08-01 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
https://bugs.webkit.org/show_bug.cgi?id=65476
- fixed webInspector.inspectedWindow.reload(), brought tests back.
- removed redundant setting of user agent in FrameLoader::loadResourceSynchronously()
Reviewed by Yury Semikhatsky.
Test: http/tests/inspector/extensions-useragent.html
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
2011-08-01 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
https://bugs.webkit.org/show_bug.cgi?id=65476
Reviewed by Yury Semikhatsky.
- http/tests/inspector/extensions-useragent-expected.txt: Added.
- http/tests/inspector/extensions-useragent.html: Added.
- 6:58 AM Changeset in webkit [92186] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042
Remove mark as expected fail where unexpected pass and mark failing test case as expected fail
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):
- 6:54 AM Changeset in webkit [92185] by
-
- 6 edits1 copy in trunk
2011-08-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing inspector tests.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
2011-08-02 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing inspector tests.
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-sorting-expected.txt.
- 6:43 AM Changeset in webkit [92184] by
-
- 2 edits in trunk/Source/WebCore
2011-08-02 Pavel Feldman <pfeldman@google.com>
Not reviewed: one line inspector style change.
- inspector/front-end/networkLogView.css: (.network-error-row, .network-error-row .network-cell-subtitle):
- 6:39 AM Changeset in webkit [92183] by
-
- 4 edits in trunk/Source
Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-02
Reviewed by Martin Robinson.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.
- 5:38 AM Changeset in webkit [92182] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::viewModes() API test
https://bugs.webkit.org/show_bug.cgi?id=65531
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.
- tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail
(tst_QWebPage::viewModes):
- 5:34 AM Changeset in webkit [92181] by
-
- 2 edits in trunk/LayoutTests
Malformed chromium test expectation fix, again. Sorry for the spam...
- platform/chromium/test_expectations.txt:
- 5:13 AM Changeset in webkit [92180] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
https://bugs.webkit.org/show_bug.cgi?id=65170
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.
- tests/qwebframe/tst_qwebframe.cpp: Mark failing test case as expected fail
(tst_QWebFrame::connectAndDisconnect):
- 5:13 AM Changeset in webkit [92179] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebElement::render() API test
https://bugs.webkit.org/show_bug.cgi?id=65243
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.
- tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail
(tst_QWebElement::render):
- 5:02 AM Changeset in webkit [92178] by
-
- 2 edits in trunk/LayoutTests
Fix malformed chromium test expectation introduced by r92173
- platform/chromium/test_expectations.txt:
- 4:06 AM Changeset in webkit [92177] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed gardening. Paint the Qt Snow Leopard bot green.
- platform/qt-mac/Skipped: Skip a failing test.
- 4:00 AM Changeset in webkit [92176] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Add comment after r92175.
- 3:57 AM Changeset in webkit [92175] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Paint the Qt bot green.
- platform/qt/Skipped: Skip failing tests.
- 3:49 AM Changeset in webkit [92174] by
-
- 2 edits in trunk/LayoutTests
Chromium test_expectations.txt update for r92165
- platform/chromium/test_expectations.txt:
- 2:50 AM Changeset in webkit [92173] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/text/international/bidi-mirror-he-ar.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65524
Just update test_expectations.txt
- platform/chromium/test_expectations.txt:
- 2:47 AM Changeset in webkit [92172] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r92127.
- platform/qt/editing/selection/4397952-expected.png: Updated.
- platform/qt/editing/selection/4397952-expected.txt: Updated.
- 2:25 AM Changeset in webkit [92171] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones.
https://bugs.webkit.org/show_bug.cgi?id=65468
Reviewed by Yury Semikhatsky.
- inspector/InjectedScriptSource.js:
- 2:20 AM Changeset in webkit [92170] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: 404/errors should get a RED visual treatment so easier to identify.
https://bugs.webkit.org/show_bug.cgi?id=65471
Reviewed by Yury Semikhatsky.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
- inspector/front-end/networkLogView.css:
(.network-error-cell):
- 1:46 AM Changeset in webkit [92169] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=65244
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-02
Reviewed by Csaba Osztrogonác.
- tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail
(tst_QWebElement::style):
- 1:05 AM Changeset in webkit [92168] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix.
https://bugs.webkit.org/show_bug.cgi?id=65467
Reviewed by Yury Semikhatsky.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._messagesClicked):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement):
- inspector/front-end/inspector.css:
(.properties-tree li):
(.properties-tree li.parent::before):
- inspector/front-end/treeoutline.js:
(TreeElement.treeElementToggled):
- 1:03 AM Changeset in webkit [92167] by
-
- 3 edits2 adds in trunk
Web Inspector: button + "New style rule"
https://bugs.webkit.org/show_bug.cgi?id=65409
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/styles/styles-add-new-rule.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
LayoutTests:
- inspector/styles/styles-add-new-rule-expected.txt: Added.
- inspector/styles/styles-add-new-rule.html: Added.
Aug 1, 2011:
- 8:47 PM Changeset in webkit [92166] by
-
- 6 edits in trunk/Tools
garden-o-matic should call optimize-baselines when rebaselining tests
https://bugs.webkit.org/show_bug.cgi?id=65499
Reviewed by Dimitri Glazkov.
I took the opportunity to modernize this code to use some of our more
powerful primitives from base.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- 8:09 PM Changeset in webkit [92165] by
-
- 5 edits in trunk/LayoutTests
Update Lion specific test results.
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 6:42 PM Changeset in webkit [92164] by
-
- 5 edits in trunk/Source/WebCore
Don't set m_fontDirty when setting zoom unless zoom has actually changed
https://bugs.webkit.org/show_bug.cgi?id=65092
Reviewed by Darin Adler.
No new tests as no functionality changed - this is an optimization that
should be logically equivalent to the current code.
The intent here is to avoid setting m_fontDirty unless the fornt information is actually dirty.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
Use setZoom and setEffectiveZoom wrapper functions.
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setZoom):
Wrapper for m_style->setZoom() that automatically updates m_fontDirty.
(WebCore::CSSStyleSelector::setEffectiveZoom):
Wrapper for m_style->setEffectiveZoom that automatically updates m_fontDirty.
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::ensurePropertyMap):
Use
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setZoom):
Return true only if underlying values change.
(WebCore::InheritedFlags::setZoomWithoutReturnValue):
Return void to match function pointer type where required.
(WebCore::InheritedFlags::setEffectiveZoom):
Return true only if underlying values change.
- 6:37 PM Changeset in webkit [92163] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, rebaseline test results for recently added test.
- platform/chromium-linux/svg/custom/repaint-shadow-expected.png: Added.
- platform/qt/svg/custom/repaint-shadow-expected.txt: Added.
- 6:23 PM Changeset in webkit [92162] by
-
- 37 edits2 deletes in trunk/LayoutTests
Unreviewed, rebaseline, webkit gardener stuff.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Removed.
- platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Removed.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
- platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
- platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
- platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-win/fast/text/international/khmer-selection-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-win/svg/batik/text/textAnchor-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/batik/text/textLayout-expected.png:
- platform/chromium-win/svg/batik/text/textProperties-expected.png:
- platform/chromium-win/svg/batik/text/textProperties2-expected.png:
- platform/chromium-win/svg/batik/text/textStyles-expected.png:
- platform/chromium-win/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
- 6:20 PM Changeset in webkit [92161] by
-
- 6 edits in trunk/Source
Removing old source files in gyp files that slow build
https://bugs.webkit.org/show_bug.cgi?id=65503
Patch by Jean-luc Brouillet <jeanluc@chromium.org> on 2011-08-01
Reviewed by Adam Barth.
A number of stale files are listed in the gyp files. These slow the
build on Visual Studio 2010. Removing them.
Source/JavaScriptCore:
- JavaScriptCore.gypi:
Source/WebCore:
- WebCore.gypi:
Source/WebKit/chromium:
- WebKit.gyp:
- 6:16 PM Changeset in webkit [92160] by
-
- 4 edits in trunk/Tools
Finish reconfiguration started by Lucas Forschler
Reconfigured slaves:
Removed Leopard Intel Release (Build)
Removed Leopard Intel Release (Tests)
Remove apple-pixel-1
Added Lion slaves from disabled Leopard slaves
Added builders:
Lion Intel Release (Build)
Lion Intel Debug (Build)
Lion Intel Release (Tests)
Lion Intel Release WK2 (Tests)
Lion Intel Debug (Tests)
Lion Intel Debug WK2 (Tests)
Added triggers:
lion-intel-debug-tests
lion-intel-debug-test-wk2
lion-intel-release-tests
lion-intel-release-tests-wk2
Removed trigger:
leopard-intel-release-tests
Added PlatformSpecificScheduler:
mac-lion
Added "mac-lion" to build.py and build_unitttest.py
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- Scripts/webkitpy/common/config/build.py:
- Scripts/webkitpy/common/config/build_unittest.py:
- 5:59 PM Changeset in webkit [92159] by
-
- 2 edits in trunk/Source/WebCore
Shard webcore_remaining for msvs official builds
https://bugs.webkit.org/show_bug.cgi?id=65475
Patch by Bradley Nelson <bradnelson@chromium.org> on 2011-08-01
Reviewed by Darin Fisher.
webcore_remaining has consistently exceeded Visual Studio 2008's
capacity to link when link time code generation is turned on (full
release builds). This has been dealt with the past by carving off
larger and larger pieces of webcore_remaining (ie webcore_html,
webcore_renderer etc).
A new option has been added to gyp to automate this sharding:
'msvs_shard': SHARD_COUNT,
Targets marked in this way will be built in several pieces
(target_0, target_1...).
Since the resulting project is less comprehensible in the IDE (and
since the linking limitation only afflicts official builds), this
option is only needed for those builds.
This patch shards webcore_remaining into 10 parts for official builds.
- WebCore.gyp/WebCore.gyp:
- 5:51 PM Changeset in webkit [92158] by
-
- 6 edits in trunk
WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
https://bugs.webkit.org/show_bug.cgi?id=65451
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-01
Reviewed by Chris Fleizach.
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
LayoutTests:
- accessibility/aria-roles.html:
- platform/mac/accessibility/aria-multiline.html:
- platform/mac/accessibility/aria-roles-expected.txt:
- 5:49 PM Changeset in webkit [92157] by
-
- 2 edits in trunk/Source/WebCore
Use threadsafeCopy() API when using Database Directory path variable
https://bugs.webkit.org/show_bug.cgi?id=65436
Patch by srikumar bonda <srikumar.b@gmail.com> on 2011-08-01
Reviewed by David Levin.
Use threadsafeCopy() API while using m_databaseDirectoryPath string variable
when the databaseGuard lock hasn't been taken in DatabaseTracker class.
This is just a safety fix.
No changes to functionality so no new tests.
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::deleteOrigin):
- 5:44 PM Changeset in webkit [92156] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, rebaseline, webkit gardener stuff.
- platform/chromium-mac/svg/custom/repaint-shadow-expected.png: Added.
- platform/chromium-win/svg/custom/repaint-shadow-expected.png: Added.
- 5:21 PM Changeset in webkit [92155] by
-
- 11 edits in trunk/Source/WebCore
[Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486
The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.
Reviewed by Darin Fisher.
No new tests. Existing layout tests cover the version handling functionality.
- storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):
- storage/AbstractDatabase.h:
(WebCore::AbstractDatabase::expectedVersion):
- storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):
- storage/ChangeVersionWrapper.h:
- storage/Database.cpp:
(WebCore::Database::openDatabase):
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):
- storage/SQLTransaction.h:
- storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
- storage/SQLTransactionSync.h:
- 5:10 PM Changeset in webkit [92154] by
-
- 4 edits in trunk/Source/JavaScriptCore
currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577
Reviewed by Darin Adler and Dmitry Titov.
The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.
- wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.
- wtf/ThreadIdentifierDataPthreads.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Acquire the pthread key here.
- 5:07 PM Changeset in webkit [92153] by
-
- 5 edits2 adds in trunk/Tools
webkit-patch needs to be able to "optimize" the storage of baselines on disk
https://bugs.webkit.org/show_bug.cgi?id=65418
Reviewed by Dimitri Glazkov.
If we're not careful when rebaselining tests, we can end up with lots
of duplicate expected results files in the tree. This patch adds a
webkit-patch command that optimizes the storage of expected results on
disk.
This command is similar to deduplicate-tests, except that it can move
test results around rather than just remove duplicate results.
Unfortunately, this problem is very tricky because the baseline search
structure is a hypergraph. This patch include a huerstic optimizer
that appears to work on a bunch of examples I've tried. We'll likely
need to refine it as gain experience.
- Scripts/webkitpy/common/system/filesystem.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:49 PM Changeset in webkit [92152] by
-
- 5 edits3 adds in trunk
Severe shadow repaint issues with SVGText elements
https://bugs.webkit.org/show_bug.cgi?id=63648
<rdar://problem/7632269>
Reviewed by Darin Adler.
Make SVG elements which inherit from RenderSVGBlock take text-shadow
overflow into account when determining whether or not they should draw
Test: svg/custom/repaint-shadow.svg
- rendering/RenderBox.h:
(WebCore::RenderBox::visualOverflowRect):
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::visualOverflowRect):
- rendering/svg/RenderSVGBlock.h:
- 4:25 PM Changeset in webkit [92151] by
-
- 2 edits in trunk/LayoutTests
One more test_expectations.txt fix for windows web audio
https://bugs.webkit.org/show_bug.cgi?id=65496
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:12 PM Changeset in webkit [92150] by
-
- 9 edits in trunk
Unreviewed, rolling out r92022.
http://trac.webkit.org/changeset/92022
https://bugs.webkit.org/show_bug.cgi?id=65203
try to see if this is causing a bunch of browser tests failues
on win bots - will recommit if not
Source/WebCore:
- platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):
- platform/graphics/skia/SkiaFontWin.h:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 3:45 PM Changeset in webkit [92149] by
-
- 2 edits in trunk/LayoutTests
Remove time out expectation since media/track has been added to the skipped list on Qt.
- platform/qt/test_expectations.txt:
- 3:32 PM Changeset in webkit [92148] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG JIT sometimes creates speculation check data structures that have
invalid information about the format of a register
https://bugs.webkit.org/show_bug.cgi?id=65490
Reviewed by Gavin Barraclough.
The code now makes sure to (1) always have correct and up-to-date
information about register format at the time that a speculation
check is emitted, (2) assert that speculation data is correct
inside the speculation check implementation, and (3) avoid creating
speculation data altogether if compilation has already failed, since
at that point the format data is almost guaranteed to be bogus.
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
- 3:22 PM Changeset in webkit [92147] by
-
- 5 edits in trunk/Tools
Teach TestExpectationSerializer about parsed expectations.
https://bugs.webkit.org/show_bug.cgi?id=65444
This is a bit largish in size, but the essentials are:
- TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
- We now store original content of the expectation line on TestExpectationLine.
- Lots of tests.
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
populate macros correctly, also fixed an issue where we incorrectly returned an empty list
for all configurations.
- Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
- Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
changed to store and use TestExpectationLine.original_string.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
- 3:09 PM Changeset in webkit [92146] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r92092): Build fails on 64 bit
https://bugs.webkit.org/show_bug.cgi?id=65458
Reviewed by Oliver Hunt.
The build was broken because some compilers were smart enough to see
an array index out of bounds due to the decision fuction for when to
go from precise size classes to imprecise size classes being broken:
it would assume that sizes in the range 97..128 belonged to a precise
size class when in fact they belonged to an imprecise one.
In fact, the code would have run correctly, by way of a fluke, because
though the 4th precise size class (for 97..128) didn't exist, the next
array over from m_preciseSizeClasses was m_impreciseSizeClasses, and
its first entry would have been a size class that is appropriate for
allocations in the range 97..128. However, this relies on specific
ordering of fields in NewSpace, so it's still a bug.
This fixes the bug by ensuring that allocations larger than 96 use
the imprecise size classes.
- heap/NewSpace.h:
(JSC::NewSpace::sizeClassFor):
- 2:46 PM Changeset in webkit [92145] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add null check to setSwapbuffersCompletCallbackChromium
https://bugs.webkit.org/show_bug.cgi?id=65485
Reviewed by James Robinson.
- src/GraphicsContext3DChromium.cpp:
(WebCore::SwapBuffersCompleteCallbackAdapter::create):
- 2:41 PM Changeset in webkit [92144] by
-
- 1 edit5 adds in trunk/LayoutTests
Add audionode.html and gain.html web audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65276
Reviewed by Kenneth Russell.
- webaudio/audionode-expected.txt: Added.
- webaudio/audionode.html: Added.
- webaudio/gain-expected.wav: Added.
- webaudio/gain.html: Added.
- webaudio/resources/buffer-loader.js: Added.
(BufferLoader):
(BufferLoader.prototype.loadBuffer.request.onload):
(BufferLoader.prototype.loadBuffer.request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):
- 2:22 PM Changeset in webkit [92143] by
-
- 18 edits2 adds in trunk
.: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Update exports for test harness.
- Source/autotools/symbols.filter:
Source/WebCore: REGRESSION (r39725?): Resources removed from document can not be freed
until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Upon completing a load start a Timer to iterate through
CachedResourceLoader's m_documentResources map to check for any items
that have only one reference (thus being the reference in the map
itself). The map should really be weak, but because the
CachedResourceHandle achieves bookkeeping work in addition to
reference counting, this is a simpler and more localized way to free
the used memory while maintaining the other behaviour (when
CachedResource is used as proxy).
With this patch the testcase at
https://bugs.webkit.org/attachment.cgi?id=93850 should no longer
consume 400MB of ram on load. Test added for crash discovered in
previous revision, but no tests for memory usage.
Test: http/tests/inspector/network/disabled-cache-crash.html
- WebCore.exp.in:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::hasOneHandle):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
- loader/cache/CachedResourceLoader.h:
- testing/Internals.cpp:
(WebCore::Internals::disableMemoryCache):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2: REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
https://bugs.webkit.org/show_bug.cgi?id=61006
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
Update exports for test harness.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=61006
Test for CachedResourceLoader. Not caused by cache-disabling but very
difficult to reproduce when cache is active, so use cache disable in
inspector to exercise code.
Patch by Scott Graham <scottmg@chromium.org> on 2011-08-01
Reviewed by Antti Koivisto.
- http/tests/inspector/network/disabled-cache-crash-expected.txt: Added.
- http/tests/inspector/network/disabled-cache-crash.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:18 PM Changeset in webkit [92142] by
-
- 5 edits7 adds in trunk
Source/WebCore: Never override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809
Reviewed by Adam Barth.
Tests: http/tests/security/cookies/third-party-cookie-blocking-main-frame.html
http/tests/security/cookies/third-party-cookie-blocking-user-action.html
http/tests/security/cookies/third-party-cookie-blocking.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::addExtraFieldsToSubresourceRequest):
(WebCore::FrameLoader::addExtraFieldsToMainResourceRequest):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoader.h:
LayoutTests: Require explicit user action to override the policy URL on form submissions.
https://bugs.webkit.org/show_bug.cgi?id=61809
Reviewed by Adam Barth.
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/security/cookies/resources/set-a-cookie.php: Added.
- http/tests/security/cookies/third-party-cookie-blocking-expected.txt: Added.
- http/tests/security/cookies/third-party-cookie-blocking-main-frame-expected.txt: Added.
- http/tests/security/cookies/third-party-cookie-blocking-main-frame.html: Added.
- http/tests/security/cookies/third-party-cookie-blocking-user-action-expected.txt: Added.
- http/tests/security/cookies/third-party-cookie-blocking-user-action.html: Added.
- http/tests/security/cookies/third-party-cookie-blocking.html: Added.
- 2:16 PM Changeset in webkit [92141] by
-
- 5 edits in trunk/LayoutTests
media/track tests should be skipped on all platforms until feature is fully implemented.
https://bugs.webkit.org/show_bug.cgi?id=65482
Patch by Anna Cavender <annacc@chromium.org> on 2011-08-01
Reviewed by Ryosuke Niwa.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:10 PM Changeset in webkit [92140] by
-
- 2 edits in trunk/Source/WebCore
Update comment added in r92139 per Darin's suggestion.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
- 2:08 PM Changeset in webkit [92139] by
-
- 4 edits2 adds in trunk
Search field in designMode causes a crash
https://bugs.webkit.org/show_bug.cgi?id=65362
Reviewed by Dimitri Glazkov.
Source/WebCore:
The crashed was caused by editing code inadvertently deleting search and cancel buttons in the design mode.
Fixed the bug by avoid inheriting user-modify property from the shadow host.
Test: editing/input/search-field-crash-in-designmode.html
- css/CSSStyleSelector.cpp:
(WebCore::isAtShadowBoundary): Moved.
(WebCore::CSSStyleSelector::styleForElement): Overrides -webkit-user-modify by the initial value after m_style
inherited the values from m_parentStyle but before applying matched rules.
- dom/Node.cpp:
(WebCore::Node::rendererIsEditable): Ignore page's editability inside a shadow DOM.
LayoutTests:
Add a test to ensure WebKit doesn't crash when a user tries to delete inside
an empty search field in the design mode.
- editing/input/search-field-crash-in-designmode-expected.txt: Added.
- editing/input/search-field-crash-in-designmode.html: Added.
- 1:40 PM Changeset in webkit [92138] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Set default max-conns to a more sane default value and fix comment
https://bugs.webkit.org/show_bug.cgi?id=65335
Patch by Marco Peereboom <marco@peereboom.us> on 2011-08-01
Reviewed by Martin Robinson.
Rigged the xxxterm web browser and validated that the default values were set properly.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):
- 1:39 PM Changeset in webkit [92137] by
-
- 3 edits in trunk/Tools
Remove unused functionality from gardeningserver
https://bugs.webkit.org/show_bug.cgi?id=65479
Reviewed by Dimitri Glazkov.
We now handle these operations directly from the front-end. That means
they work even without the gardening server running!
Also, add some missing files to the list of static files.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- 12:55 PM Changeset in webkit [92136] by
-
- 3 edits in trunk/Tools
Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
https://bugs.webkit.org/show_bug.cgi?id=65413
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
existing code to use it.
- Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
- 12:25 PM Changeset in webkit [92135] by
-
- 14 edits in trunk/Tools
Refactor bugzilla.js for use by garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65450
Reviewed by Dimitri Glazkov.
This patch refactors bugzilla.js to use the AsynchronousCache and
updates the style to use a module instead of an object. This patch
then fixes all the existing code that uses this class to use the new
API style.
This main benefit of this patch is we remove the tricky manual caching
and this code is now available to use in garden-o-matic (since the
dependency on Utilities.js is now gone).
I ran all the unit tests and poked around in TestFailures a bit to see
that everything seemed to be working properly.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
(FailingTestsBugForm):
(FailingTestsBugForm.prototype._createBugTitle):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
(FlakyTestBugForm):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
(NewBugForm):
(NewBugForm.prototype.domElement):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
(TestRelatedBugForm):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
(ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
(ViewController.prototype._domForPossiblyFlakyTests):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
- 12:23 PM Changeset in webkit [92134] by
-
- 4 edits1 add in trunk/Tools
garden-o-matic shouldn't require local server to determine if compile failed
https://bugs.webkit.org/show_bug.cgi?id=65446
Reviewed by Dimitri Glazkov.
This patch adds some basic bindings for the buildbot JSON API. I
wanted to use Buildbot.js an Builder.js from the original TestFailures,
but they make a number of WebKit-specific assumptions. We'll
eventually need to reconcile these pieces of code.
I should really add tests for this code, but that will require me to
build a better mock network. I'll be happy to do that in a follow-up
patch.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
- It's very unclear to me whether didFail is correct. Supposedly the first entry here is the exit code of the step, which is 0 on success. I suspect we'll need to improve this function over time.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
- 11:45 AM Changeset in webkit [92133] by
-
- 2 edits in trunk/Tools
garden-o-matic should show all failures, even ones that it can't find a regression range for
https://bugs.webkit.org/show_bug.cgi?id=65447
Reviewed by Dimitri Glazkov.
Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page). This patch just displays them at the end of the list,
which is slightly (but not much) better.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- 11:03 AM Changeset in webkit [92132] by
-
- 3 edits2 adds in trunk
Regression(82144): Crash in TrailingObjects::updateMidpointsForTrailingBoxes
https://bugs.webkit.org/show_bug.cgi?id=65137
Source/WebCore:
Fix the looping condition to prevent trailingSpaceMidpoint from becoming negative.
Reviewed by Dave Hyatt.
Test: fast/block/update-midpoints-for-trailing-boxes-crash.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
LayoutTests:
ASSERTION FAILED: trailingSpaceMidpoint >= 0
Reviewed by Dave Hyatt.
- fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt: Added.
- fast/block/update-midpoints-for-trailing-boxes-crash.html: Added.
- 9:51 AM Changeset in webkit [92131] by
-
- 3 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r92127.
- platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
- platform/qt-4.8/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
- platform/qt-4.8/editing/selection/4397952-expected.png: Added.
- platform/qt-4.8/editing/selection/4397952-expected.txt: Added.
- platform/qt-mac/Skipped: Skip failing tests.
- platform/qt-wk2/Skipped: Skip failing tests.
- 9:10 AM Changeset in webkit [92130] by
-
- 3 edits in trunk/Source/WebCore
[Qt] OpenGLShims does not build on ARM
https://bugs.webkit.org/show_bug.cgi?id=65465
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-01
Reviewed by Noam Rosenthal.
Fix the build with OpenGL ES 2:
-lookupOpenGLFunctionAddress() was defined but not used for OpenGL ES.
-glBlitFramebuffer() and glRenderbufferStorageMultisample() are not part of the specification.
When those are available as platform extension, the extension has been added.
-GLchar is not defined on some platform. The patch adds the same typedef as the official definition
to avoid conflicts.
- platform/graphics/cairo/OpenGLShims.cpp:
(lookupOpenGLFunctionAddress):
(WebCore::initializeOpenGLShims):
- platform/graphics/cairo/OpenGLShims.h:
- 9:09 AM Changeset in webkit [92129] by
-
- 2 edits in trunk/LayoutTests
Add fast/forms/selection-direction.html to the Skipped list.
- platform/wk2/Skipped:
- 9:02 AM Changeset in webkit [92128] by
-
- 3 edits in trunk/Tools
Windows build fix after r92096.
- TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
- 9:01 AM Changeset in webkit [92127] by
-
- 105 edits112 adds in trunk/LayoutTests
[Qt] Update expected results and unskip now passing tests.
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/css2.1/ [...]: Updated.
- platform/qt/editing/ [...]: Updated.
- 6:47 AM Changeset in webkit [92126] by
-
- 4 edits in trunk/LayoutTests
2011-08-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: unflake inspector test that was just added.
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- platform/chromium/test_expectations.txt:
- 5:45 AM Changeset in webkit [92125] by
-
- 2 edits in trunk/Source/WebCore
2011-08-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Trivial fix for inspector/debugger/debugger-completions-on-call-frame.html after r92122.
- inspector/front-end/ConsoleView.js:
- 5:25 AM Changeset in webkit [92124] by
-
- 11 edits4 adds in trunk
Add support for getting an element in shadow root by its id into a window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=64587
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::getElementByIdInShadowRoot):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt: Added.
- fast/dom/shadow/get-element-by-id-in-shadow-root.html: Added.
- fast/dom/shadow/resources/create-dom.js: Added.
(createShadow):
(createDom):
- 4:53 AM Changeset in webkit [92123] by
-
- 7 edits in trunk
build: Fix finding the headers for GStreamer
The cmake files to find the various GStreamer packages were all
checking for the header gst/gst.h. However if gst-plugins-base is
installed into a separate prefix from gstreamer then all of these
tests would only pick up the gstreamer include path so the build
would fail. This patch changes it to try and find a file
appropriate to each package.
https://bugs.webkit.org/show_bug.cgi?id=64933
Patch by Neil Roberts <neil@linux.intel.com> on 2011-08-01
Reviewed by Martin Robinson.
- Source/cmake/FindGStreamer-App.cmake:
- Source/cmake/FindGStreamer-Base.cmake:
- Source/cmake/FindGStreamer-Interfaces.cmake:
- Source/cmake/FindGStreamer-Pbutils.cmake:
- Source/cmake/FindGStreamer-Plugins-Base.cmake:
- Source/cmake/FindGStreamer-Video.cmake:
- 4:42 AM Changeset in webkit [92122] by
-
- 11 edits3 adds in trunk
Web Inspector: typing an expression in an iframe leads to multiple "Unsafe JavaScript attempt to access frame..." errors
https://bugs.webkit.org/show_bug.cgi?id=65457
Source/WebCore:
Console completions are now done using evaluation which returns a JSON object with all property names rather than a remote
object. Also Runtime.evaluate and Runtime.callFunctionOn commands were extended with an optional parameter that allows to
get result as JSON value.
Reviewed by Pavel Feldman.
Test: http/tests/inspector/console-cd-completions.html
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
- inspector/InjectedScript.h:
- inspector/InjectedScriptSource.js:
(.):
():
- inspector/Inspector.json:
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::asBool):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
- inspector/InspectorRuntimeAgent.h:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertySet):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/console-cd-completions-expected.txt: Added.
- http/tests/inspector/console-cd-completions.html: Added.
- http/tests/inspector/resources/console-cd-completions-iframe.html: Added.
- 4:38 AM Changeset in webkit [92121] by
-
- 2 edits in trunk/LayoutTests
[chromium] http/tests/inspector/resource-tree/resource-tree-document-url.html occasionally times out
https://bugs.webkit.org/show_bug.cgi?id=65463
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 4:30 AM Changeset in webkit [92120] by
-
- 2 edits in trunk/LayoutTests
[chromium] http/tests/cache/history-only-cached-subresource-loads-max-age-https.html frequently times out on Vista
https://bugs.webkit.org/show_bug.cgi?id=65462
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 4:22 AM Changeset in webkit [92119] by
-
- 2 edits in trunk/LayoutTests
[chromium] Temporarily expect scripts-sorting.html to fail
https://bugs.webkit.org/show_bug.cgi?id=65461
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:18 AM Changeset in webkit [92118] by
-
- 8 edits2 adds in trunk
BORDER attribute with the object tag, using percentage values not working.
https://bugs.webkit.org/show_bug.cgi?id=65176
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-01
Reviewed by Hajime Morita.
Source/WebCore:
When border presentational attribute for object element has % in it, it should be parsed using HTML parser rules.
Test: fast/borders/border-width-percent.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseBorderWidthAttribute):
- html/HTMLElement.h:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
LayoutTests:
Added the tests with border width with percentages in a new file. Moved them
from images border test file.
- fast/borders/border-width-percent-expected.txt: Added.
- fast/borders/border-width-percent.html: Added.
- fast/images/border-expected.txt:
- fast/images/script-tests/border.js:
- 4:16 AM Changeset in webkit [92117] by
-
- 2 edits1 delete in trunk/LayoutTests
[chromium] Update expectations for fast/text/international/bidi-mirror-he-ar.html
https://bugs.webkit.org/show_bug.cgi?id=65460
Unreviewed expectations update.
- platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
- 4:16 AM Changeset in webkit [92116] by
-
- 8 edits in trunk/Source/WebCore
WebSocket: Receive URL and subprotocol in WebSocketChannel::connect()
https://bugs.webkit.org/show_bug.cgi?id=65367
Reviewed by Kent Tamura.
To implement multiple subprotocols support (bug 65247), WebSocket::connect() will need to validate
the value of subprotocols after constructing WebSocketChannel, because the result depends on which
WebSocket protocol is used, which is obtained from WebSocketChannel::useHixie76Protocol(). This
means the subprotocol value will not be available at the time of WebSocketChannel construction.
This change moves URL and subprotocol arguments in WebSocketChannel constructor to
WebSocketChannel::connect(), which allows WebSocket::connect() function to check the subprotocol
value before the actual connection is established.
Relocating URL argument is technically not necessary, but seemed legitimate in terms of functional
correspondence between WebSocket and WebSocketChannel (constructor versus connect()).
No change in behavior, thus no new tests.
- websockets/ThreadableWebSocketChannel.cpp:
Remove "url" and "protocol" arguments from constructor and add them in connect().
(WebCore::ThreadableWebSocketChannel::create):
- websockets/ThreadableWebSocketChannel.h:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- websockets/WebSocketChannel.cpp: Same as ThreadableWebSocketChannel.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
InspectorInstrumentation::didCreateWebSocket() call was moved to connect() because it needs URL.
This does not change behavior, because connect() is guaranteed to be called immediately after
WebSocketChannel is constructed.
- websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
- websockets/WorkerThreadableWebSocketChannel.cpp: Same as ThreadableWebSocketChannel.
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::connect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadConnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
- websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Peer::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
- 3:19 AM Changeset in webkit [92115] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebPage::loadHtml5Video() API test
https://bugs.webkit.org/show_bug.cgi?id=65452
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-01
Reviewed by Csaba Osztrogonác.
- tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail
(tst_QWebPage::loadHtml5Video):
- 3:18 AM Changeset in webkit [92114] by
-
- 1 edit2 adds in trunk/LayoutTests
Web Inspector: Add network panel sidebar width test.
https://bugs.webkit.org/show_bug.cgi?id=65314
Reviewed by Yury Semikhatsky.
- http/tests/inspector/network/network-sidebar-width-expected.txt: Added.
- http/tests/inspector/network/network-sidebar-width.html: Added.
- 2:53 AM Changeset in webkit [92113] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r92108.
http://trac.webkit.org/changeset/92108
https://bugs.webkit.org/show_bug.cgi?id=65459
breaks SL compile (Requested by tonyg-cr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-01
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- 2:36 AM Changeset in webkit [92112] by
-
- 2 edits in trunk/LayoutTests
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky on chromium win
https://bugs.webkit.org/show_bug.cgi?id=60110
Marking it flaky on Linux as well.
- platform/chromium/test_expectations.txt:
- 2:05 AM Changeset in webkit [92111] by
-
- 2 edits1 copy in trunk/LayoutTests
Fix windows text rendering expectations for fast/text/justify-ideograph-leading-expansion.html
https://bugs.webkit.org/show_bug.cgi?id=65455
Unreviewed expectations update.
- platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png.
- platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
- 2:04 AM Changeset in webkit [92110] by
-
- 5 edits4 copies in trunk/LayoutTests
REGRESSION (r92048): svg/custom/external-paintserver-reference.svg, svg/custom/linking-base-external-reference.xhtml failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65432
Revert accidentally committed changes, and update Qt specific expected results.
- platform/qt/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.png.
- platform/qt/svg/custom/external-paintserver-reference-expected.txt: Copied from LayoutTests/svg/custom/external-paintserver-reference-expected.txt.
- platform/qt/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.png.
- platform/qt/svg/custom/linking-base-external-reference-expected.txt: Copied from LayoutTests/svg/custom/linking-base-external-reference-expected.txt.
- svg/custom/external-paintserver-reference-expected.png: Revert r92048.
- svg/custom/external-paintserver-reference-expected.txt: Revert r92048.
- svg/custom/linking-base-external-reference-expected.png: Revert r92048.
- svg/custom/linking-base-external-reference-expected.txt: Revert r92048.
- 1:57 AM Changeset in webkit [92109] by
-
- 3 edits in trunk/LayoutTests
2011-08-01 Pavel Feldman <pfeldman@google.com>
Not reviewed: unflake inspector test that was just added.
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- 1:49 AM Changeset in webkit [92108] by
-
- 2 edits in trunk/Source/WebKit2
Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-01
Reviewed by Darin Adler.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPC::::decode): Decode the image only if required.
- 1:48 AM Changeset in webkit [92107] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/css/outline-auto-empty-rects.html broken by r92059
https://bugs.webkit.org/show_bug.cgi?id=65453
This patch just expects the test to fail for now.
Unreviewed expectations update.
- platform/chromium/test_expectations.txt:
- 1:31 AM Changeset in webkit [92106] by
-
- 5 edits in trunk/Source/WebCore
Add iterator to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=65297
Reviewed by Darin Adler.
No new tests / refactoring only.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isLength):
Add shorthand to determine if this primitive value is a length.
- css/CSSStyleSelector.cpp:
Use CSSValueListIterator throughout.
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::applyPageSizeProperty):
(WebCore::CSSStyleSelector::createTransformOperations):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::copy):
Use itemWithoutBoundsCheck() instead of item().
- css/CSSValueList.h:
Add CSSValueListIterator and CSSValueListInspector class definitions.
(WebCore::CSSValueList::item)
Provide inline definition of item.
(WebCore::CSSValueListIterator::CSSValueListIterator):
(WebCore::CSSValueListIterator::hasMore):
Return true if there are more values to consume, including the current value.
(WebCore::CSSValueListIterator::value):
Return the value at the current position.
(WebCore::CSSValueListIterator::next):
Move the iterator forward to the next item.
(WebCore::CSSValueListIterator::index):
Return the current position in the list.
(WebCore::CSSValueListInspector::item):
Return the item at a given index.
(WebCore::CSSValueListInspector::first):
Return the first item in the list.
(WebCore::CSSValueListInspector::second):
Return the second item in the list.
(WebCore::CSSValueListInspector::length):
Return the size of the underlying list.
- 1:17 AM Changeset in webkit [92105] by
-
- 4 edits2 adds in trunk
Web Inspector: group scripts by folder in the scripts selector.
https://bugs.webkit.org/show_bug.cgi?id=65321
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/scripts-sorting.html
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/scripts-sorting-expected.txt: Added.
- inspector/debugger/scripts-sorting.html: Added.
- 1:13 AM Changeset in webkit [92104] by
-
- 5 edits in trunk
Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
https://bugs.webkit.org/show_bug.cgi?id=65331
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/CodeGeneratorInspector.pm:
(generateBackendFunction):
(generateArgumentGetters):
LayoutTests:
- inspector/report-protocol-errors-expected.txt:
- 1:04 AM Changeset in webkit [92103] by
-
- 2 edits in trunk/Source/WebCore
application/json MIME type shouldn't cause warnings in <script> tags
https://bugs.webkit.org/show_bug.cgi?id=65448
Reviewed by Pavel Feldman.
This patch stops the web inspector from logging a ton of spam warnings
when a web page uses a JSONP service (which points script tags at
application/json resources).
- inspector/front-end/inspector.js:
(WebInspector.reset):
- 12:26 AM Changeset in webkit [92102] by
-
- 10 edits in trunk/Source
WebSocket: Rename SocketStreamHandleClient member functions
https://bugs.webkit.org/show_bug.cgi?id=65374
Reviewed by Kent Tamura.
Source/WebCore:
Rename SocketStreamHandleClient member functions to avoid conflict of the names of
FileReaderLoaderClient functions.
No change in behavior, thus no new tests are added.
- platform/network/SocketStreamHandleClient.h:
(WebCore::SocketStreamHandleClient::didOpenSocketStream):
(WebCore::SocketStreamHandleClient::didCloseSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData):
(WebCore::SocketStreamHandleClient::didFailSocketStream):
- platform/network/brew/SocketStreamHandleBrew.cpp:
(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosed):
(WebCore::SocketStreamHandlePrivate::socketError):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::platformClose):
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::socketConnected):
(WebCore::SocketStreamHandlePrivate::socketReadyRead):
(WebCore::SocketStreamHandlePrivate::socketClosedCallback):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::resumeTimerFired):
- websockets/WebSocketChannel.h:
Source/WebKit/chromium:
- src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
Jul 31, 2011:
- 11:05 PM Changeset in webkit [92101] by
-
- 4 edits1 delete in trunk/LayoutTests
These results appear to differ only in text rendering.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
- platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png:
- 10:36 PM Changeset in webkit [92100] by
-
- 1 edit10 adds in trunk/LayoutTests
Adding expected results. These results appear to differ only in the scrollbar.
- platform/chromium-linux/svg/custom/external-paintserver-reference-expected.png: Added.
- platform/chromium-linux/svg/custom/linking-base-external-reference-expected.png: Added.
- platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
- platform/chromium-mac/svg/custom/external-paintserver-reference-expected.txt: Added.
- platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
- platform/chromium-mac/svg/custom/linking-base-external-reference-expected.txt: Added.
- platform/chromium-win/svg/custom/external-paintserver-reference-expected.png: Added.
- platform/chromium-win/svg/custom/external-paintserver-reference-expected.txt: Added.
- platform/chromium-win/svg/custom/linking-base-external-reference-expected.png: Added.
- platform/chromium-win/svg/custom/linking-base-external-reference-expected.txt: Added.
- 10:33 PM Changeset in webkit [92099] by
-
- 2 edits in trunk/LayoutTests
Update baseline. This patch might cause Linux to start failing, but in
that case, we can add a more specific Linux result. This approach is
somewhat of an exploration of this automated rebaselining algorithm.
- platform/chromium-win/svg/batik/text/textLength-expected.txt:
- 9:25 PM Changeset in webkit [92098] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r92094.
http://trac.webkit.org/changeset/92094
https://bugs.webkit.org/show_bug.cgi?id=65443
Triggered many asserts (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-31
Source/WebCore:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
LayoutTests:
- fast/events/event-target-reset-expected.txt: Removed.
- fast/events/event-target-reset.html: Removed.
- 9:17 PM Changeset in webkit [92097] by
-
- 2 edits in trunk/Tools
DownloadDecideDestinationCrash WebKit2 API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=65442
Reviewed by Sam Weinig.
Copy the 18-characters.html file to the destination directory so we won't
crash trying to make an URL for it.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 9:10 PM Changeset in webkit [92096] by
-
- 2 adds in trunk/Tools/TestWebKitAPI
Add forgotten files.
- 8:32 PM Changeset in webkit [92095] by
-
- 8 edits in trunk/Tools
Fix SpacebarScrolling WebKit2 API test
https://bugs.webkit.org/show_bug.cgi?id=65431
Reviewed by Sam Weinig.
Add a way to do platform-specific bundle initialization, and use it to disable smooth
scrolling. Also make it possible for a test to load the injected bundle without actually running
a test from it.
- TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
- TestWebKitAPI/InjectedBundleController.h:
- TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createContextWithInjectedBundle):
- TestWebKitAPI/PlatformUtilities.h:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 7:53 PM Changeset in webkit [92094] by
-
- 3 edits2 adds in trunk
Event target set to null post event dispatch
https://bugs.webkit.org/show_bug.cgi?id=63934
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/events/event-target-reset.html
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Reset target to outermost
shadow host.
LayoutTests:
- fast/events/event-target-reset-expected.txt: Added.
- fast/events/event-target-reset.html: Added.
- 6:50 PM Changeset in webkit [92093] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Unreviewed - rolling out r91290.
Source/JavaScriptCore:
Looks like the wild wild web isn't ready for this yet.
This change broke http://slides.html5rocks.com/#landing-slide.
Interestingly, this might only be due to our lack of bind support -
it looks like this site is calling Array.prototype.slice as a part
of its bind implementation.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
LayoutTests:
Checking in failing results - we can't fix this bug just yet
for web compatibility reasons.
- fast/js/array-prototype-properties-expected.txt:
- ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
- ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
- 4:48 PM Changeset in webkit [92092] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC GC lays out size classes under wrong assumptions about expected
object size.
https://bugs.webkit.org/show_bug.cgi?id=65437
Reviewed by Oliver Hunt.
Changed the atom size - which is both the smallest allocation size and
the smallest possible stepping unit for size class spacing - from
8 bytes to 4 pointer-size words. This is a 1% win on SunSpider.
- heap/MarkedBlock.h:
- 4:17 PM Changeset in webkit [92091] by
-
- 2 edits in trunk/LayoutTests
Fix fast/dom/Range/getBoundingClientRect.html after r92089.
- fast/dom/Range/getBoundingClientRect.html:
- 2:14 PM Changeset in webkit [92090] by
-
- 2 edits in trunk/LayoutTests
[Chromium] editing/execCommand/4786404-1.html,editing/execCommand/break-out-of-empty-list-item.html are slow/timeout
https://bugs.webkit.org/show_bug.cgi?id=65019
This bug was invalid; neither test is slow nor timing out.
- platform/chromium/test_expectations.txt:
- 2:05 PM Changeset in webkit [92089] by
-
- 7 edits in trunk
REGRESSION: getBoundingClientRect() method of Range incorrectly returns null for collapsed Range
https://bugs.webkit.org/show_bug.cgi?id=65324
Reviewed by Ryosuke Niwa.
Source/WebCore:
Update to more closely match the spec.
- dom/Range.cpp:
(WebCore::Range::getClientRects):
Return an empty ClientRectList instead of null when the range is empty.
(WebCore::Range::getBoundingClientRect):
Always return a ClientRect, even for an empty bounding rect.
LayoutTests:
- fast/dom/Range/getBoundingClientRect-expected.txt:
- fast/dom/Range/getBoundingClientRect.html:
- fast/dom/Range/getClientRects-expected.txt:
- fast/dom/Range/getClientRects.html:
Add test cases for empty and collapsed ranges.
- 1:44 PM Changeset in webkit [92088] by
-
- 10 edits2 copies4 adds in trunk
[HTML5] Implement the selectionDirection property on input and textarea
https://bugs.webkit.org/show_bug.cgi?id=60403
Reviewed by Darin Adler.
Source/WebCore:
Implements selectionDirection property as specified in HTML5 section 4.10.20:
http://www.whatwg.org/specs/web-apps/current-work/#textFieldSelection
selectionDirection is a property on input and textarea elements, which, on getting returns either "none",
"forward", or "backward" corresponding to the current selection direction, and on setting, modifies
the direction of the current selection. When selection doesn't exist or direction is unknown, "none"
is returned on getting. Setting the property value to neither of above values will result in setting "none".
This patch also adds the optional third argument, direction, to setSelectionRange.
Test: fast/forms/selection-direction.html
fast/forms/selection-wrongtype.html
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::selectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionDirection): Added.
(WebCore::JSHTMLInputElement::setSelectionRange): Processes the third argument.
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter): Added.
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter): Added.
(WebCore::V8HTMLInputElement::setSelectionRangeCallback): Processes the third argument.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance): Calls hasCachedSelection.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
(WebCore::HTMLInputElement::setValue): Calls cacheSelection with SelectionHasNoDirection.
- html/HTMLTextAreaElement.idl: Added selectionDirection and the third argument to setSelectionRange.
- html/HTMLInputElement.idl: Ditto.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initializes
m_cachedSelectionDirection.
(WebCore::HTMLTextFormControlElement::setSelectionStart): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto.
(WebCore::HTMLTextFormControlElement::setSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::select): Calls setSelectionRange with SelectionHasNoDirection.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Added the version that takes direction
string as the third argument, which calls the version that takes two ints and TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::selectionStart): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::selectionEnd): Ditto.
(WebCore::directionString): Added.
(WebCore::HTMLTextFormControlElement::selectionDirection): Added.
(WebCore::HTMLTextFormControlElement::computeSelectionDirection): Added.
(WebCore::HTMLTextFormControlElement::selection): Calls hasCachedSelection.
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Calls setSelectionRange.
(WebCore::HTMLTextFormControlElement::selectionChanged): Calls cacheSelection.
- html/HTMLTextFormControlElement.h:
(WebCore::HTMLTextFormControlElement::cacheSelection): Takes TextFieldSelectionDirection.
(WebCore::HTMLTextFormControlElement::hasCachedSelection): Extracted from hasCachedSelectionStart;
cacheSelection is the only function that modifies m_cacheSelectionStart and m_cacheSelectionEnd
and none of its callers ever set one of them be -1 so they are always both -1 or both non-negative.
Thus, having two separate functions for m_cacheSelectionStart and m_cacheSelectionEnd was redundant.
LayoutTests:
Added a test to ensure WebKit sets and gets selectionDirection property.
Also added a test to ensure WebKit throws exceptions when retrieving or assigning values to selectionStart,
selectionEnd, and selectionDirection property of the input element when the element isn't a text field.
- fast/forms/selection-direction-expected.txt: Added.
- fast/forms/selection-direction.html: Added.
- fast/forms/selection-wrongtype-expected.txt: Added.
- fast/forms/selection-wrongtype.html: Added.
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt; editing delegate change.
- platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Copied from
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt since Windows port fallbacks to Mac.
- 1:40 PM Changeset in webkit [92087] by
-
- 3 edits in trunk/Tools
Use set comparison to find duplicate or overlapping specifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65430
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
of a set is wrong.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
regressions.
- 1:32 PM Changeset in webkit [92086] by
-
- 1 edit2 adds in trunk/LayoutTests
Add expected results for Snow Leopard and earlier for fast/css/font-family-pictograph.html
Fixes REGRESSION (r91777): fast/css/font-family-pictograph.html failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=65433
- platform/mac-snowleopard/fast/css: Added.
- platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Added.
- 1:13 PM Changeset in webkit [92085] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG non-speculative JIT does not optimize PutByVal
https://bugs.webkit.org/show_bug.cgi?id=65424
Reviewed by Gavin Barraclough.
Added code to emit PutByVal inline fast path.
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
- 12:03 PM Changeset in webkit [92084] by
-
- 6 edits in trunk/Source/JavaScriptCore
The JSC garbage collector returns memory to the operating system too
eagerly.
https://bugs.webkit.org/show_bug.cgi?id=65382
Reviewed by Oliver Hunt.
This introduces a memory reuse model similar to the one in FastMalloc.
A periodic scavenger thread runs in the background and returns half the
free memory to the OS on each timer fire. New block allocations first
attempt to get the memory from the collector's internal pool, reverting
to OS allocation only when this pool is empty.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::waitForRelativeTimeWhileHoldingLock):
(JSC::Heap::waitForRelativeTime):
(JSC::Heap::blockFreeingThreadStartFunc):
(JSC::Heap::blockFreeingThreadMain):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::releaseFreeBlocks):
- heap/Heap.h:
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::reset):
- heap/MarkedBlock.h:
- wtf/Platform.h:
- 9:30 AM Changeset in webkit [92083] by
-
- 6 edits in trunk/Source/WebKit/chromium
[Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader
overload, and change the overload that takes WebURLLoaderOptions to
use a default value. This is equivalent to the original parameterless
overload.
https://bugs.webkit.org/show_bug.cgi?id=65280
Patch by Bill Budge <bbudge@chromium.org> on 2011-07-31
Reviewed by Darin Fisher.
- public/WebFrame.h:
- src/AssociatedURLLoader.cpp:
- src/AssociatedURLLoader.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
- 1:48 AM Changeset in webkit [92082] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove unused variable coreChild in WebCore::getChildForTable()
https://bugs.webkit.org/show_bug.cgi?id=65427
This variable was unused when it was initially added in <http://trac.webkit.org/changeset/89660> (bug #62718)
and it is unused today. We should remove it. This will also resolve a compiler warning.
Reviewed by Xan Lopez.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getChildForTable):
- 1:34 AM Changeset in webkit [92081] by
-
- 2 edits in trunk
2011-07-31 Daniel Bates <dbates@webkit.org>
Add missing semicolons to build fix attempt in <http://trac.webkit.org/changeset/92080>.
- Source/autotools/symbols.filter:
- 1:18 AM Changeset in webkit [92080] by
-
- 2 edits in trunk
2011-07-31 Daniel Bates <dbates@webkit.org>
Some more fixes to the GTK build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
- Source/autotools/symbols.filter: Export symbols needed by Internals.
- 1:06 AM Changeset in webkit [92079] by
-
- 2 edits in trunk/Source/WebKit2
2011-07-31 Daniel Bates <dbates@webkit.org>
Try again to fix the WinCairo Debug build after r92059 ( https://bugs.webkit.org/show_bug.cgi?id=65419).
- win/WebKit2CFLite.def: Export symbols needed by Internals.
- 12:37 AM Changeset in webkit [92078] by
-
- 3 edits in trunk/Source/WebKit/win
2011-07-31 Daniel Bates <dbates@webkit.org>
Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
- WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
- WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
- 12:16 AM Changeset in webkit [92077] by
-
- 2 edits in trunk/Tools
2011-07-31 Xan Lopez <xlopez@igalia.com>
Group dependencies CFLAGS together.
- GNUmakefile.am: ditto.
- 12:04 AM Changeset in webkit [92076] by
-
- 2 edits in trunk/Tools
2011-07-31 Daniel Bates <dbates@webkit.org>
Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
(https://bugs.webkit.org/show_bug.cgi?id=65419).
- GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
Jul 30, 2011:
- 11:47 PM Changeset in webkit [92075] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-30
- DEPS:
- 11:44 PM Changeset in webkit [92074] by
-
- 2 edits in trunk/Source/WebCore
2011-07-30 Daniel Bates <dbates@webkit.org>
Fix the WinCairo Debug build after <http://trac.webkit.org/changeset/91914>
(https://bugs.webkit.org/show_bug.cgi?id=64744)
- WebCore.vcproj/WebCore.vcproj: Remove ContextShadowCairo.cpp from the build since this file was deleted in <http://trac.webkit.org/changeset/91914>.
- 11:36 PM Changeset in webkit [92073] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2011-07-30 Daniel Bates <dbates@webkit.org>
Fix my email address in the changelog entry for <http://trac.webkit.org/changeset/92072>.
- 11:29 PM Changeset in webkit [92072] by
-
- 2 edits in trunk/Source/WebCore
2011-07-30 Daniel Bates <dbates@webkit.com>
Fix the Chromium Linux Release Flexbot build after <http://trac.webkit.org/changeset/92004>
(https://bugs.webkit.org/show_bug.cgi?id=65342)
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Update the definition of RenderFlexibleBox::layoutBlock() to be consistent with its declaration in RenderFlexibleBox.h; Add argument layoutPass of type BlockLayoutPass.
- 11:14 PM Changeset in webkit [92071] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG JIT speculation failure pass sometimes forgets to emit code to
move certain registers.
https://bugs.webkit.org/show_bug.cgi?id=65421
Reviewed by Oliver Hunt.
Restructured the offending loops (for gprs and fprs). It's once again
possible to use spreadsheets on docs.google.com.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
- 10:56 PM Changeset in webkit [92070] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Windows build after r92059.
- win/WebKit2.def: Export symbols needed by Internals.
- 9:46 PM Changeset in webkit [92069] by
-
- 2 edits in trunk/Source/WebCore
Update run-bindings-tests results after
http://trac.webkit.org/changeset/92068
- bindings/scripts/test/JS/JSTestCallback.cpp:
- 7:23 PM Changeset in webkit [92068] by
-
- 112 edits in trunk/Source
Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081
Reviewed by Darin Adler.
Source/JavaScriptCore:
Add missing and remove unneeded include statements for MainThread.
- wtf/CryptographicallyRandomNumber.cpp:
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
- wtf/text/StringStatics.cpp:
Source/WebCore:
Add missing include statements for MainThread.
- bindings/js/DOMWrapperWorld.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- bindings/v8/DOMDataStore.cpp:
- bindings/v8/DOMWrapperWorld.cpp:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8DOMMap.cpp:
- bindings/v8/V8DOMWrapper.h:
- dom/EventTarget.cpp:
- fileapi/LocalFileSystem.cpp:
- loader/CrossOriginPreflightResultCache.cpp:
- loader/ResourceLoadScheduler.cpp:
- loader/WorkerThreadableLoader.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- page/DOMWindow.cpp:
- page/History.cpp:
- page/SecurityOrigin.cpp:
- page/mac/EventHandlerMac.mm:
- platform/MIMETypeRegistry.cpp:
- platform/ThreadGlobalData.cpp:
- platform/ThreadTimers.cpp:
- platform/TreeShared.h:
- platform/audio/HRTFDatabaseLoader.cpp:
- platform/graphics/Font.cpp:
- platform/graphics/FontFallbackList.h:
- platform/graphics/FontFastPath.cpp:
- platform/graphics/Image.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
- platform/mac/LocalizedStringsMac.mm:
- platform/mac/SharedBufferMac.mm:
- platform/network/BlobResourceHandle.cpp:
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/text/LocalizedNumberICU.cpp:
- platform/text/TextEncodingRegistry.cpp:
- platform/text/mac/LocalizedNumberMac.mm:
- platform/win/LocalizedStringsWin.cpp:
- storage/LocalStorageThread.cpp:
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaSync.cpp:
- storage/StorageNamespaceImpl.cpp:
- storage/StorageSyncManager.cpp:
- webaudio/AsyncAudioDecoder.cpp:
- webaudio/AudioBufferSourceNode.cpp:
- webaudio/AudioContext.h
- webaudio/AudioContext.cpp:
- webaudio/AudioNode.cpp:
- webaudio/ConvolverNode.cpp:
- webaudio/OfflineAudioDestinationNode.cpp:
- webaudio/RealtimeAnalyser.cpp:
- webaudio/WaveShaperNode.cpp:
- websockets/WorkerThreadableWebSocketChannel.cpp:
- workers/WorkerMessagingProxy.cpp:
Source/WebKit/chromium:
Add missing include statements for MainThread.
- src/WebKit.cpp:
- src/WebViewImpl.cpp:
- tests/CCThreadTest.cpp:
Source/WebKit/gtk:
Add missing include statements for MainThread.
- webkit/webkitglobals.cpp:
Source/WebKit/mac:
Add missing include statements for MainThread.
- Carbon/CarbonWindowAdapter.mm:
- History/WebBackForwardList.mm:
- History/WebHistoryItem.mm:
- Misc/WebElementDictionary.mm:
- Misc/WebIconDatabase.mm:
- Misc/WebLocalizableStrings.mm:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginView.mm:
- WebCoreSupport/WebEditorClient.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm:
- WebView/WebDataSource.mm:
- WebView/WebHTMLView.mm:
- WebView/WebResource.mm:
- WebView/WebTextIterator.mm:
- WebView/WebView.mm:
- WebView/WebViewData.mm:
Source/WebKit/qt:
Add missing include statements for MainThread.
- Api/qwebpage.cpp:
Source/WebKit/win:
Add missing include statements for MainThread.
- WebKitClassFactory.cpp:
- WebView.cpp:
Source/WebKit/wx:
Add missing include statements for MainThread.
- WebView.cpp:
Source/WebKit2:
Add missing include statements for MainThread.
- PluginProcess/gtk/PluginProcessMainGtk.cpp:
- PluginProcess/mac/PluginProcessMainMac.mm:
- PluginProcess/qt/PluginProcessMainQt.cpp:
- UIProcess/API/mac/WKPrintingView.mm:
- UIProcess/Launcher/mac/ThreadLauncherMac.mm:
- UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
- UIProcess/Launcher/win/ThreadLauncherWin.cpp:
- UIProcess/WebContext.cpp:
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
- WebProcess/efl/WebProcessMainEfl.cpp:
- WebProcess/gtk/WebProcessMainGtk.cpp:
- WebProcess/mac/KeychainItemShimMethods.mm:
- WebProcess/mac/WebProcessMainMac.mm:
- WebProcess/qt/WebProcessMainQt.cpp:
- WebProcess/win/WebProcessMainWin.cpp:
- 6:19 PM Changeset in webkit [92067] by
-
- 2 edits in trunk/Tools
Fix ports_unittest.py on native windows
https://bugs.webkit.org/show_bug.cgi?id=64959
Reviewed by Adam Barth.
Replace WebKitPort.script_path with WebKitPort.script_shell_command.
The latter includes the interpreter executable required on native windows.
- Scripts/webkitpy/common/config/ports_unittest.py:
- 5:51 PM Changeset in webkit [92066] by
-
- 1 edit17 adds7 deletes in trunk/LayoutTests
Update baselines. This patch cleans up after http://trac.webkit.org/changeset/92042.
- platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
- platform/chromium-mac/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/chromium-mac/fast/repaint/absolute-position-moved-expected.png: Added.
- platform/chromium-mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/chromium-mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
- platform/chromium-mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/chromium-mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/chromium-mac/fast/repaint/overflow-hide-expected.png: Added.
- platform/chromium-mac/fast/repaint/overflow-show-expected.png: Added.
- platform/chromium-win/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/chromium-win/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/chromium-win/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/chromium-win/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/chromium-win/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/chromium-win/fast/repaint/overflow-hide-expected.png: Added.
- platform/chromium-win/fast/repaint/overflow-show-expected.png: Added.
- platform/chromium/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Removed.
- platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Removed.
- platform/chromium/fast/repaint/overflow-hide-expected.png: Removed.
- platform/chromium/fast/repaint/overflow-show-expected.png: Removed.
- 5:46 PM Changeset in webkit [92065] by
-
- 16 edits1 delete in trunk/LayoutTests
Update more baselines. This completes the cleanup after
http://trac.webkit.org/changeset/92047.
- platform/chromium-win-xp/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
- platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
- platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
- platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
- platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/batik/text/textLayout-expected.png:
- platform/chromium-win/svg/batik/text/textLayout-expected.txt:
- platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
- 5:39 PM Changeset in webkit [92064] by
-
- 17 edits2 deletes in trunk/LayoutTests
More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)
- platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
- platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
- platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
- platform/chromium-win-xp/svg/batik/text/verticalText-expected.txt: Removed.
- platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
- platform/chromium-win/svg/batik/text/textAnchor-expected.png:
- platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
- platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
- platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
- platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties-expected.png:
- platform/chromium-win/svg/batik/text/textProperties-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties2-expected.png:
- platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
- platform/chromium-win/svg/batik/text/textStyles-expected.png:
- platform/chromium-win/svg/batik/text/textStyles-expected.txt:
- platform/chromium-win/svg/batik/text/verticalText-expected.txt:
- 5:33 PM Changeset in webkit [92063] by
-
- 5 edits in trunk/LayoutTests
More baseline updates. (I'm going slowly because I'm using a new
toolchain to do the rebaselining.)
- platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
- platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
- platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/chromium-win/svg/batik/text/textPosition-expected.txt:
- 5:25 PM Changeset in webkit [92062] by
-
- 2 edits in trunk/LayoutTests
Update baseline.
- platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- 5:05 PM Changeset in webkit [92061] by
-
- 2 edits in trunk/Tools
Properly escape regular expressions. (Maybe these shouldn't be regular
expressions?)
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:57 PM Changeset in webkit [92060] by
-
- 3 edits in trunk/Tools
Add support for Win7 to garden-o-matic.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:51 PM Changeset in webkit [92059] by
-
- 7 edits2 adds in trunk
REGRESSION: culledInlineAbsoluteRects needs to translate a 0,0 point to absolute
coordinates so that the top left position is accurate.
https://bugs.webkit.org/show_bug.cgi?id=65419
<rdar://problem/9408862>
Source/WebCore:
This patch fixes a regression introduced in r83075.
Make sure that culledInlineAbsoluteRects still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.
This code path could not be tested via JavaScript. The patch
extends the Internals object to be able to test this case.
Reviewed by Dan Bernstein.
Test: fast/inline/skipped-whitespace-boundingBox.html
- WebCore.exp.in: Added some exports.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
- testing/Internals.cpp:
(WebCore::Internals::boundingBox):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Reviewed by Dan Bernstein.
- fast/inline/skipped-whitespace-boundingBox-expected.txt: Added.
- fast/inline/skipped-whitespace-boundingBox.html: Added.
- 4:10 PM Changeset in webkit [92058] by
-
- 3 edits in trunk/Source/JavaScriptCore
Reduce the size of JSGlobalObject slightly
https://bugs.webkit.org/show_bug.cgi?id=65417
Reviewed by Dan Bernstein.
Push a few members that either aren't commonly used,
or aren't frequently accessed into a separate struct.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::WeakMapsFinalizer::finalize):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::createRareDataIfNeeded):
(JSC::JSGlobalObject::setProfileGroup):
(JSC::JSGlobalObject::profileGroup):
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):
- 11:27 AM Changeset in webkit [92057] by
-
- 2 edits in trunk/Tools
garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406
Reviewed by Dimitri Glazkov.
Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range. Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.
This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
- 11:26 AM Changeset in webkit [92056] by
-
- 3 edits in trunk/Tools
garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403
Reviewed by Dimitri Glazkov.
The refresh button should be faster and less disruptive than the browser's reload button.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- 11:25 AM Changeset in webkit [92055] by
-
- 2 edits in trunk/Tools
garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=65231
Reviewed by Dimitri Glazkov.
The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
- 11:24 AM Changeset in webkit [92054] by
-
- 5 edits in trunk/Tools
garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227
Reviewed by Dimitri Glazkov.
This helps gardeners keep track of which problems have been solved.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
- 11:12 AM Changeset in webkit [92053] by
-
- 2 edits in trunk/Tools
Add missing files to the server.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- 10:39 AM Changeset in webkit [92052] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Fix the build afer r92014
https://bugs.webkit.org/show_bug.cgi?id=65410
Reviewed by Noam Rosenthal.
- Shared/ShareableBitmap.h:
- UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::paintContent):
- 5:42 AM Changeset in webkit [92051] by
-
- 4 edits2 adds in trunk
Web Inspector: move location conversion functions to SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65185
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/source-file.html
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
- inspector/front-end/SourceFile.js:
(WebInspector.SourceFile.prototype.rawLocationToUILocation):
(WebInspector.SourceFile.prototype.uiLocationToRawLocation):
(WebInspector.SourceFile.prototype._scriptForRawLocation):
(WebInspector.SourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype.createSourceMappingIfNeeded):
(WebInspector.FormattedSourceFile.prototype._didRequestContent):
LayoutTests:
- inspector/debugger/source-file-expected.txt: Added.
- inspector/debugger/source-file.html: Added.
- 4:43 AM Changeset in webkit [92050] by
-
- 3 edits in trunk/Source/JavaScriptCore
MessageQueue::waitForMessageFilteredWithTimeout can triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=65263
Reviewed by Dmitry Titov.
- wtf/Deque.h:
(WTF::::operator): Don't check the validity of an iterator
that will be reassigned right now.
- wtf/MessageQueue.h:
(WTF::::removeIf): Revert r51198 as I beleave this is the better
solution for the problem that was solved by that.
- 12:16 AM Changeset in webkit [92049] by
-
- 23 edits in trunk/LayoutTests
[Qt] Update platform specific expected files after r92047.
- platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt:
- platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt:
- platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt:
- platform/qt-4.8/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt:
- platform/qt-4.8/svg/batik/text/smallFonts-expected.txt:
- platform/qt-4.8/svg/batik/text/textAnchor-expected.txt:
- platform/qt-4.8/svg/batik/text/textDecoration-expected.txt:
- platform/qt-4.8/svg/batik/text/textEffect-expected.txt:
- platform/qt-4.8/svg/batik/text/textEffect2-expected.txt:
- platform/qt-4.8/svg/batik/text/textEffect3-expected.txt:
- platform/qt-4.8/svg/batik/text/textFeatures-expected.txt:
- platform/qt-4.8/svg/batik/text/textLayout2-expected.txt:
- platform/qt-4.8/svg/batik/text/textLength-expected.txt:
- platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
- platform/qt-4.8/svg/batik/text/textPosition-expected.txt:
- platform/qt-4.8/svg/batik/text/textPosition2-expected.txt:
- platform/qt-4.8/svg/batik/text/textProperties-expected.txt:
- platform/qt-4.8/svg/batik/text/textProperties2-expected.txt:
- platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/qt-mac/Skipped: Skip failing tests.
Jul 29, 2011:
- 11:48 PM Changeset in webkit [92048] by
-
- 32 edits in trunk/LayoutTests
[Qt] Update platform specific expected files after r92047.
- platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- platform/qt/svg/batik/filters/filterRegions-expected.txt:
- platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/qt/svg/batik/paints/patternRegionA-expected.txt:
- platform/qt/svg/batik/paints/patternRegions-expected.txt:
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/qt/svg/batik/text/longTextOnPath-expected.txt:
- platform/qt/svg/batik/text/smallFonts-expected.txt:
- platform/qt/svg/batik/text/textAnchor-expected.txt:
- platform/qt/svg/batik/text/textDecoration-expected.png:
- platform/qt/svg/batik/text/textDecoration-expected.txt:
- platform/qt/svg/batik/text/textEffect-expected.txt:
- platform/qt/svg/batik/text/textEffect2-expected.txt:
- platform/qt/svg/batik/text/textEffect3-expected.txt:
- platform/qt/svg/batik/text/textFeatures-expected.txt:
- platform/qt/svg/batik/text/textLayout2-expected.txt:
- platform/qt/svg/batik/text/textLength-expected.txt:
- platform/qt/svg/batik/text/textOnPath-expected.txt:
- platform/qt/svg/batik/text/textPosition-expected.txt:
- platform/qt/svg/batik/text/textPosition2-expected.txt:
- platform/qt/svg/batik/text/textProperties-expected.txt:
- platform/qt/svg/batik/text/textProperties2-expected.txt:
- platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/qt/svg/hixie/error/014-expected.txt:
- platform/qt/svg/hixie/use/002-expected.txt:
- svg/custom/external-paintserver-reference-expected.png:
- svg/custom/external-paintserver-reference-expected.txt:
- svg/custom/linking-base-external-reference-expected.png:
- svg/custom/linking-base-external-reference-expected.txt:
- 8:22 PM Changeset in webkit [92047] by
-
- 53 edits9 adds in trunk
2011-07-29 Rob Buis <rbuis@rim.com>
URL references are completely broken in SVG
https://bugs.webkit.org/show_bug.cgi?id=63283
Reviewed by Nikolas Zimmermann.
Change SVGURIElement::getTarget to be more strict about iri resolving and make it serve as a central
place to resolve a iri to a SVGElement. The iri can be same-document or external, for now we only handle
the former, the latter will be handled in bug 65344.
Accept as same-document if the iri combined with the base uri equals the document url (ignoring
the fragment identifier). For convenience a method is added to lookup the element, if found.
Tests: svg/custom/external-paintserver-reference.svg
svg/custom/linking-base-external-reference.xhtml
svg/custom/uri-reference-handling.svg
- css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.h: (WebCore::CSSFontSelector::document):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
- rendering/svg/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::paintingResourceFromSVGPaint):
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
- svg/SVGGlyphRefElement.cpp: (WebCore::SVGGlyphRefElement::hasValidGlyphElement):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
- svg/SVGPaint.cpp: (WebCore::SVGPaint::matchesTargetURI):
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::svgAttributeChanged): (WebCore::SVGTRefElement::buildPendingResource):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
- svg/SVGURIReference.cpp: (WebCore::SVGURIReference::fragmentIdentifierFromIRIString): (WebCore::SVGURIReference::targetElementFromIRIString):
- svg/SVGURIReference.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
- 7:49 PM Changeset in webkit [92046] by
-
- 20 edits2 deletes in trunk/Source/JavaScriptCore
JSC GC zombie support no longer works, and is likely no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=65404
Reviewed by Darin Adler.
This removes zombies, because they no longer work, are not tested, are
probably not needed, and are getting in the way of GC optimization
work.
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
- heap/HandleHeap.cpp:
(JSC::HandleHeap::isValidWeakNode):
- heap/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::collect):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::clearMarks):
- interpreter/Register.h:
(JSC::Register::Register):
(JSC::Register::operator=):
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):
- runtime/JSCell.cpp:
(JSC::isZombie):
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
- runtime/JSGlobalData.h:
- runtime/JSValue.h:
- runtime/JSValueInlineMethods.h:
(JSC::JSValue::JSValue):
- runtime/JSZombie.cpp: Removed.
- runtime/JSZombie.h: Removed.
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
- wtf/Platform.h:
- 7:26 PM Changeset in webkit [92045] by
-
- 29 edits1 add1 delete in trunk/LayoutTests
Unreviewed, rebaseline, gardener stuff.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Removed.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-win-vista/fast/text/international/khmer-selection-expected.png: Added.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png:
- platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png:
- platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png:
- platform/chromium-win/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-win/fast/text/international/khmer-selection-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
- 7:17 PM Changeset in webkit [92044] by
-
- 2 edits in trunk/Tools
Actually import the logging module!
- Scripts/webkitpy/common/checkout/scm/git.py:
- 7:14 PM Changeset in webkit [92043] by
-
- 2 edits in trunk/Tools
More debug logging. Maybe we're running the git version of this
function somehow? (That would explain why it doesn't work!)
- Scripts/webkitpy/common/checkout/scm/git.py:
- 7:12 PM Changeset in webkit [92042] by
-
- 2 edits39 adds in trunk/LayoutTests
Add more testing to RenderLayer [ct'd]
https://bugs.webkit.org/show_bug.cgi?id=65059
Reviewed by James Robinson.
This change adds testing with <iframe>, position: absolute elements and scrolling.
- fast/repaint/absolute-position-change-containing-block.html: Added.
- fast/repaint/absolute-position-changed.html: Added.
- fast/repaint/absolute-position-moved.html: Added.
- fast/repaint/fixed-and-absolute-position-scrolled.html: Added.
- fast/repaint/fixed-position-transparency-with-overflow.html: Added.
- fast/repaint/fixed-to-relative-position-with-absolute-child.html: Added.
- fast/repaint/nested-iframe-scroll-inner.html: Added.
- fast/repaint/nested-iframe-scroll-outer.html: Added.
- fast/repaint/overflow-hide.html: Added.
- fast/repaint/overflow-show.html: Added.
New test cases.
- fast/repaint/resources/iframe-inner.html: Added.
- fast/repaint/resources/iframe-outer.html: Added.
- fast/repaint/resources/default.css:
Added more shared code here.
- fast/repaint/absolute-position-change-containing-block-expected.png: Added.
- fast/repaint/absolute-position-change-containing-block-expected.txt: Added.
- fast/repaint/absolute-position-changed-expected.txt: Added.
- fast/repaint/absolute-position-moved-expected.png: Added.
- fast/repaint/absolute-position-moved-expected.txt: Added.
- fast/repaint/fixed-and-absolute-position-scrolled-expected.txt: Added.
- fast/repaint/fixed-position-transparency-with-overflow-expected.txt: Added.
- fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
- fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt: Added.
- fast/repaint/nested-iframe-scroll-inner-expected.txt: Added.
- fast/repaint/nested-iframe-scroll-outer-expected.txt: Added.
- fast/repaint/overflow-hide-expected.txt: Added.
- fast/repaint/overflow-show-expected.txt: Added.
- platform/chromium/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/chromium/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/chromium/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/chromium/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/chromium/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/chromium/fast/repaint/overflow-hide-expected.png: Added.
- platform/chromium/fast/repaint/overflow-show-expected.png: Added.
- platform/mac/fast/repaint/absolute-position-changed-expected.png: Added.
- platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
- platform/mac/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
- platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
- platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
- platform/mac/fast/repaint/overflow-hide-expected.png: Added.
- platform/mac/fast/repaint/overflow-show-expected.png: Added.
Those 2 results are strange and a bug will be opened about them.
- 7:11 PM Changeset in webkit [92041] by
-
- 2 edits in trunk/Source/WebCore
Remove zipcar.com site specific hack added in r87361
https://bugs.webkit.org/show_bug.cgi?id=65405
Reviewed by Adam Barth.
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedIntoDocument):
- 7:06 PM Changeset in webkit [92040] by
-
- 1 edit3 adds in trunk/LayoutTests
LayoutTests does not have a test for array speculation pathologies in the JavaScriptCore DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=65397
Reviewed by Darin Adler.
This test reproduces the crash seen in https://bugs.webkit.org/show_bug.cgi?id=65327, and is
designed to guard itself against possible variants of array speculation failure. It will
test both the case where a speculate-array value is actually a non-array object, and the
case where it is a number. Particular care is taken to increase the likelihood that the
test remains relevant if the JIT performs speculation based on actual argument types and
values at the time of compilation.
- fast/js/array-type-speculation-expected.txt: Added.
- fast/js/array-type-speculation.html: Added.
- fast/js/script-tests/array-type-speculation.js: Added.
- 7:00 PM Changeset in webkit [92039] by
-
- 7 edits in trunk/Source/WebKit/efl
[EFL] Implement EditorClientEfl::respondToChangedContents
http://bugs.webkit.org/show_bug.cgi?id=64259
Implements respondToChangedContents by calling callback both from
ewk_frame and ewk_view with frame and view objects respectively.
Patch by Michal Pakula vel Rutka <Michał Pakuła vel Rutka> on 2011-07-29
Reviewed by Antonio Gomes.
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedContents):
- ewk/ewk_frame.cpp:
(ewk_frame_editor_client_contents_changed):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
- ewk/ewk_view.cpp:
(ewk_view_editor_client_contents_changed):
- ewk/ewk_view.h:
- 7:00 PM Changeset in webkit [92038] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG JIT verbose mode provides no details about predictions
https://bugs.webkit.org/show_bug.cgi?id=65389
Reviewed by Darin Adler.
Added a print-out of the predictions to the IR dump, with names as follows:
"p-bottom" = the parser made no predictions
"p-int32" = the parser predicted int32
... (same for array, cell, double, number)
"p-top" = the parser made conflicting predictions which will be ignored.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::predictionToString):
- 6:26 PM Changeset in webkit [92037] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
https://bugs.webkit.org/show_bug.cgi?id=65354
Reviewed by Kenneth Russell.
This moves a few function definitions in LayerRendererChromium around to make the patch on bug 58840 easier to
review. In that patch, updatePropertiesAndRenderSurfaces() becomes a templated free function instead of a
member function, so it has to be near the top of the .cpp.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateLayers):
- 5:53 PM Changeset in webkit [92036] by
-
- 2 edits in trunk/Tools
Add some temporary debug logging messages to try to understand why the
windows bots can't figure out their current SVN revision.
- Scripts/webkitpy/common/checkout/scm/svn.py:
- 5:51 PM Changeset in webkit [92035] by
-
- 3 edits2 adds in trunk/Source/WebCore
Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>
Prepare WebCore.vcproj to support AVCF media back end on Windows.
Reviewed by Darin Adler.
No changes to functionality so no new tests.
- WebCore.vcproj/WebCore.vcproj: Added MediaPlayerPrivateAVFoundation and MediaPlayerPrivateAVFoundationCF sources.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Added additional include directories and dleay load DLLs for AVCF.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added, just a stub for now.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added, just a stub for now.
- 5:47 PM Changeset in webkit [92034] by
-
- 3 edits in trunk/Source/WebCore
Work-in-progress on Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9083559>
Make MediaPlayerPrivateAVFoundation::setDelayCallbacks() const and make the ivars
it references mutable so other const member functions can call it.
Reviewed by Darin Adler.
No changes to functionality so no new tests.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- 5:09 PM Changeset in webkit [92033] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectations update, gardener stuff.
- platform/chromium/test_expectations.txt:
- 4:27 PM Changeset in webkit [92032] by
-
- 22 edits in trunk/Source
Unreviewed, rolling out r92011.
http://trac.webkit.org/changeset/92011
https://bugs.webkit.org/show_bug.cgi?id=65044
break chromium win build
Source/WebCore:
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
- dom/WheelEvent.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::resetGestureRecognizer):
- page/EventHandler.h:
- page/FrameView.cpp:
(WebCore::FrameView::reset):
- platform/PlatformGestureEvent.h:
- platform/PlatformGestureRecognizer.h:
- platform/ScrollAnimatorWin.cpp:
- platform/chromium/FramelessScrollView.h:
- platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
(WebCore::InnerGestureRecognizer::processTouchEventForGesture):
(WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
- platform/chromium/GestureRecognizerChromium.h:
(WebCore::GestureRecognizerChromium::reset):
(WebCore::GestureRecognizerChromium::processTouchEventForGesture):
- platform/chromium/PopupMenuChromium.cpp:
- platform/chromium/PopupMenuChromium.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):
Source/WebKit/chromium:
- features.gypi:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
- src/WebViewImpl.h:
- 4:13 PM Changeset in webkit [92031] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:11 PM Changeset in webkit [92030] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394
Reviewed by James Robinson.
The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path. Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.
- page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
- 4:11 PM Changeset in webkit [92029] by
-
- 1 copy in tags/Safari-534.51.5
New tag.
- 4:03 PM Changeset in webkit [92028] by
-
- 1 edit2 copies in branches/chromium/835
Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7537012
- 4:00 PM Changeset in webkit [92027] by
-
- 2 edits4 copies in branches/chromium/835
Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7540005
- 4:00 PM Changeset in webkit [92026] by
-
- 2 edits in trunk/Tools
Chromium try servers should use downstream test_expectations
https://bugs.webkit.org/show_bug.cgi?id=65390
Reviewed by Dirk Pranke.
Otherwise the try servers will report bogus failures.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 3:48 PM Changeset in webkit [92025] by
-
- 3 edits2 adds in trunk
-webkit-marquee with anonymous node causes segmentation fault in Node::document
https://bugs.webkit.org/show_bug.cgi?id=64693
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/webkit-marquee-anonymous-node-crash.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
Add null check as renderer()->node() is null for anonymous nodes.
LayoutTests:
- fast/css/webkit-marquee-anonymous-node-crash-expected.txt: Added.
- fast/css/webkit-marquee-anonymous-node-crash.html: Added.
Add test for using -webkit-marquee with an anonymous node.
- 3:40 PM Changeset in webkit [92024] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG JIT does not have any way of undoing double speculation.
https://bugs.webkit.org/show_bug.cgi?id=65334
Reviewed by Gavin Barraclough.
This adds code to do a branchConvertDoubleToInt on specualtion failure.
This is performance-neutral on most benchmarks but does result in
a slight improvement in Kraken.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::GeneralizedRegister::moveTo):
(JSC::DFG::GeneralizedRegister::swapWith):
(JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
(JSC::DFG::ShuffledRegister::handleCyclingPermutation):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
- 3:38 PM Changeset in webkit [92023] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r91964.
- 3:17 PM Changeset in webkit [92022] by
-
- 9 edits in trunk
[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203
Reviewed by Kenneth Russell.
Source/WebCore:
- platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
- platform/graphics/skia/PlatformContextSkia.cpp:
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaFontWin.cpp:
- platform/graphics/skia/SkiaFontWin.h:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 3:16 PM Changeset in webkit [92021] by
-
- 2 edits in branches/chromium/835/Source/WebCore
Merge 91721
BUG=88944
Review URL: http://codereview.chromium.org/7457026
- 3:16 PM Changeset in webkit [92020] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r91271.
- 3:14 PM Changeset in webkit [92019] by
-
- 7 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r91266.
- 3:13 PM Changeset in webkit [92018] by
-
- 3 edits in branches/safari-534.51-branch/Source/WebCore
Merge r91222.
- 3:08 PM Changeset in webkit [92017] by
-
- 15 edits2 copies in branches/safari-534.51-branch
Merge r91219.
- 2:58 PM Changeset in webkit [92016] by
-
- 7 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r91085.
- 2:57 PM Changeset in webkit [92015] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit/mac
Merge r90855.
- 2:54 PM Changeset in webkit [92014] by
-
- 21 edits2 moves in trunk/Source
Move Region code from WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=65392
Reviewed by David Hyatt.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Update project files.
- WebCore.exp.in:
Update exports.
- platform/graphics/Region.cpp: Copied from Source/WebKit2/Platform/Region.cpp.
- platform/graphics/Region.h: Copied from Source/WebKit2/Platform/Region.h.
Add files.
Source/WebKit2:
- CMakeLists.txt:
- GNUmakefile.am:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Update project files.
- Platform/Region.cpp: Removed.
- Platform/Region.h: Removed.
Remove Region files.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw):
- UIProcess/API/mac/WKView.mm:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/qt/qdesktopwebpageproxy.cpp:
- UIProcess/win/WebView.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h:
Update for new namespace and include type.
- 2:48 PM Changeset in webkit [92013] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r90295.
- 2:44 PM Changeset in webkit [92012] by
-
- 6 edits in branches/safari-534.51-branch/Source
Merge r90293.
- 2:41 PM Changeset in webkit [92011] by
-
- 22 edits in trunk/Source
[chromium] Layering violations in gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=65044
Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-29
Reviewed by Adam Barth.
Source/WebCore:
Divided the gesture recognizer up to correct a layering
violation by moving gesture implementation from it to
EventHandler::handleGestureEvent so that the gesture recognizer
could simply be an engine for generating gesture events from
touch events.
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
- dom/WheelEvent.h:
Added symbolic contstant for tick multiplier.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
Removed construction of gesture recognizer.
(WebCore::EventHandler::handleGestureEvent):
Extended for new gesture events added in this patch.
(WebCore::EventHandler::handleTouchEvent):
Removed call into gesture recognizer.
- page/EventHandler.h:
- page/FrameView.cpp:
(WebCore::FrameView::reset):
Removed code to reset gesture recognizer.
- platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::deltaX):
(WebCore::PlatformGestureEvent::deltaY):
(WebCore::PlatformGestureEvent::shiftKey):
(WebCore::PlatformGestureEvent::ctrlKey):
(WebCore::PlatformGestureEvent::altKey):
(WebCore::PlatformGestureEvent::metaKey):
Added additional gesture types and parameters.
- platform/PlatformGestureRecognizer.h:
- platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::handleGestureEvent):
Added missing method needed to fix the build on windows.
- platform/chromium/FramelessScrollView.h:
Added support for displatching gesture and touch events.
- platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::reset):
(WebCore::InnerGestureRecognizer::constructClickGestureEvent):
(WebCore::InnerGestureRecognizer::processTouchEventForGestures):
Removed all depedencies on EventHandler. Instead, create gesture
events from touch event stream.
(WebCore::InnerGestureRecognizer::constructScrollGesture):
(WebCore::touchDown):
(WebCore::noGesture):
(WebCore::click):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
(WebCore::GestureRecognizerChromium::processTouchEventForGestures):
(WebCore::GestureRecognizerChromium::reset):
- platform/chromium/GestureRecognizerChromium.h:
- platform/chromium/PopupMenuChromium.cpp:
Added support to handle touch events and gesture events.
(WebCore::PopupContainer::handleTouchEvent):
(WebCore::PopupContainer::handleGestureEvent):
(WebCore::PopupListBox::handleTouchEvent):
(WebCore::PopupListBox::handleGestureEvent):
- platform/chromium/PopupMenuChromium.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleGestureEvent):
Ignores the newly added gesture event types.
Source/WebKit/chromium:
Moved gesture recognition higher up the event delivery code
path so that recognition of gestures is completely separated
from gesture handling.
- features.gypi:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
Added code to reset the gesture recognizer to preserve parallel
layout test execution.
- src/WebPopupMenuImpl.cpp:
Support dispatching touch and gesture events to Popups.
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::TouchEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Added gesture recognition creation.
(WebKit::WebViewImpl::touchEvent):
Added recognition of gestures and dispatch of gesture events.
(WebKit::WebViewImpl::resetGestureRecognizer):
- src/WebViewImpl.h:
- 2:34 PM Changeset in webkit [92010] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash when opening docs.google.com
https://bugs.webkit.org/show_bug.cgi?id=65327
Reviewed by Gavin Barraclough.
The speculative JIT was only checking whether a value is an array when
we had already checked that it was, rather then when we hadn't.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:29 PM Changeset in webkit [92009] by
-
- 2 edits in trunk/Source/WebCore
2011-07-29 Eric Carlson <eric.carlson@apple.com>
Load delegate not consulted before loading some poster images
https://bugs.webkit.org/show_bug.cgi?id=65270
Reviewed by Joseph Pecoraro.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::setDisplayMode): Don't ask a load delegate if it is OK to
load an empty poster url.
- 2:17 PM Changeset in webkit [92008] by
-
- 2 edits in trunk/Source/WebCore
Re-sort one more file in the WebCore project with Visual Studio.
- WebCore.vcproj/WebCore.vcproj:
- 2:14 PM Changeset in webkit [92007] by
-
- 2 edits in trunk/Source/WebCore
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
- WebCore.vcproj/WebCore.vcproj:
- 2:04 PM Changeset in webkit [92006] by
-
- 3 edits in trunk/Tools
Fix an error in macro collapsing, refactor code to be pretty.
https://bugs.webkit.org/show_bug.cgi?id=65387
My set math was wrong.
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
- Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
- 1:20 PM Changeset in webkit [92005] by
-
- 3 edits2 adds in trunk
Source/WebCore: Added the regional indicator symbols to the set of codepoints that force use of the complex text code path.
Fixes <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380
Reviewed by Anders Carlsson.
Test: fast/text/regional-indicator-symobls.html
- platform/graphics/Font.cpp:
(WebCore::Font::codePath): Added handling of surrogate pairs, which returns Complex for characters in
the range U+1F1E6..U+1F1FF.
LayoutTests: Test for <rdar://problem/9864578> Regional indicator symbols do not combine into national flags
https://bugs.webkit.org/show_bug.cgi?id=65380
Reviewed by Anders Carlsson.
- fast/text/regional-indicator-symobls-expected.txt: Added.
- fast/text/regional-indicator-symobls.html: Added.
- 1:19 PM Changeset in webkit [92004] by
-
- 8 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=65342
Add support for positioned floats being placed into a RenderBlock's FloatingObject list and for
correct propagation of those floating objects into descendants.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
The positioned float layout algorithm is 2-pass. You lay out without the positioned objects, and then
once they have been placed, you lay out again and use that placement to determine the float positions.
layoutBlock now has an extra parameter to indicate which layout pass you are in.
(WebCore::RenderBlock::addOverflowFromFloats):
Don't add overflow from positioned floats ever, since the positioning overflow function takes care of that
already.
(WebCore::RenderBlock::layoutBlockChild):
Include positioned floats in the lowestFloatLogicalBottom we look at so that overhang is computed properly.
(WebCore::RenderBlock::simplifiedLayout):
If layoutPositionedObjects indicates that a positioned float moved, then we can't do simplified layout. Bail
instead and do a full layout.
(WebCore::RenderBlock::positionedFloatsNeedRelayout):
Helper for layoutBlock in order to bypass the 2-pass model if we can detect that none of the positioned objects
will actually need to lay out again. This allows incremental layout to not always fault back to 2-pass as normal
flow content streams in.
(WebCore::RenderBlock::layoutPositionedObjects):
Modified to return a boolean indicating whether a positioned float got a layout. If so, we will lay out again
once our positioned objects are placed.
(WebCore::RenderBlock::insertFloatingObject):
insertFloatingObject can now handle positioned objects being inserted.
(WebCore::RenderBlock::positionNewFloats):
positionNewFloats doesn't attempt to position this new type of float. It only handles left/right floats.
(WebCore::RenderBlock::addPositionedFloats):
Helper to add in the floating objects for positioned floats. This is used instead of positionNewFloats and
just walks the positioned objects instead.
(WebCore::RenderBlock::clearFloats):
clearFloats now handles adding in positioned floats if the layout pass says they should be included.
(WebCore::RenderBlock::marginLogicalLeftForChild):
(WebCore::RenderBlock::marginLogicalRightForChild):
New helpers used by addPositionedFloats.
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
Make sure the object count tracking handles positioned floats as well as left/right floats.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalLeftForChild):
New helper used by addPositionedFloats.
(WebCore::RenderBlock::FloatingObject::FloatingObject):
Change the constructor to take the RenderStyle enum. This makes the construction simpler.
(WebCore::RenderBlock::hasPositionedFloats):
A bit tracks whether or not a block has positioned floats in its positioned objects list.
(WebCore::RenderBlock::hasOverhangingFloats):
Modified to include positioned floats.
(WebCore::RenderBlock::lowestFloatLogicalBottom):
This function excludes positioned floats by default, so that places that - for example - expand to
encompass their lowestFloatLogicalBottom won't accidentally expand to encompass positioned objects.
(WebCore::RenderBlock::lowestFloatLogicalBottomIncludingPositionedFloats):
A new function that includes positioned floats for callers that care.
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::hasPositionedObjects):
The object count tracking for positioned floats within a block's FloatingObjects list.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateBoxModelInfoFromStyle):
Make sure isFloating is set even if isPositioned is also set for the positioned float case.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Modified to do the extra layout pass if needed.
- 12:56 PM Changeset in webkit [92003] by
-
- 5 edits55 adds in trunk/LayoutTests
Tests for validating a new WebVTT parser for <track>
https://bugs.webkit.org/show_bug.cgi?id=64921
Patch by Anna Cavender <annacc@chromium.org> on 2011-07-29
Reviewed by Eric Carlson.
- media/track/captions/tc000_empty.vtt: Added.
- media/track/captions/tc001_iso2022jp3.vtt: Added.
- media/track/captions/tc001_utf8.vtt: Added.
- media/track/captions/tc002_bom.vtt: Added.
- media/track/captions/tc003_newlines.vtt: Added.
- media/track/captions/tc003_nonewlineateof.vtt: Added.
- media/track/captions/tc004_nowebvtt.vtt: Added.
- media/track/captions/tc004_webvttfile.vtt: Added.
- media/track/captions/tc004_webvttrubbish.vtt: Added.
- media/track/captions/tc005_defaultstyles.vtt: Added.
- media/track/captions/tc005_metadataarea.vtt: Added.
- media/track/captions/tc006_cueid.vtt: Added.
- media/track/captions/tc006_cueiderror.vtt: Added.
- media/track/captions/tc007_cuenoid.vtt: Added.
- media/track/captions/tc007_cuenoiderror.vtt: Added.
- media/track/captions/tc008_timingsnohour.vtt: Added.
- media/track/captions/tc008_timingsnohourerrors.vtt: Added.
- media/track/captions/tc009_timingshour.vtt: Added.
- media/track/captions/tc009_timingshourerror.vtt: Added.
- media/track/captions/tc010_notimings.vtt: Added.
- media/track/captions/tc011_cues.vtt: Added.
- media/track/captions/tc011_cuesnosep.vtt: Added.
- media/track/captions/tc012_outoforder.vtt: Added.
- media/track/captions/tc013_settings.vtt: Added.
- media/track/captions/tc013_settingsbadsep.vtt: Added.
- media/track/track-webvtt-tc000-empty-expected.txt: Added.
- media/track/track-webvtt-tc000-empty.html: Added.
- media/track/track-webvtt-tc001-utf8-expected.txt: Added.
- media/track/track-webvtt-tc001-utf8.html: Added.
- media/track/track-webvtt-tc002-bom-expected.txt: Added.
- media/track/track-webvtt-tc002-bom.html: Added.
- media/track/track-webvtt-tc003-newlines-expected.txt: Added.
- media/track/track-webvtt-tc003-newlines.html: Added.
- media/track/track-webvtt-tc004-magicheader-expected.txt: Added.
- media/track/track-webvtt-tc004-magicheader.html: Added.
- media/track/track-webvtt-tc005-headercomment-expected.txt: Added.
- media/track/track-webvtt-tc005-headercomment.html: Added.
- media/track/track-webvtt-tc006-cueidentifiers-expected.txt: Added.
- media/track/track-webvtt-tc006-cueidentifiers.html: Added.
- media/track/track-webvtt-tc007-cuenoid-expected.txt: Added.
- media/track/track-webvtt-tc007-cuenoid.html: Added.
- media/track/track-webvtt-tc008-timingsnohours-expected.txt: Added.
- media/track/track-webvtt-tc008-timingsnohours.html: Added.
- media/track/track-webvtt-tc009-timingshour-expected.txt: Added.
- media/track/track-webvtt-tc009-timingshour.html: Added.
- media/track/track-webvtt-tc010-notimings-expected.txt: Added.
- media/track/track-webvtt-tc010-notimings.html: Added.
- media/track/track-webvtt-tc011-blanklines-expected.txt: Added.
- media/track/track-webvtt-tc011-blanklines.html: Added.
- media/track/track-webvtt-tc012-outoforder-expected.txt: Added.
- media/track/track-webvtt-tc012-outoforder.html: Added.
- media/track/track-webvtt-tc013-settings-expected.txt: Added.
- media/track/track-webvtt-tc013-settings.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/wk2/Skipped:
- 12:11 PM Changeset in webkit [92002] by
-
- 5 edits in trunk/Source
Scroll animation refinements.
https://bugs.webkit.org/show_bug.cgi?id=65154
Patch by Scott Byer <scottbyer@chromium.org> on 2011-07-29
Reviewed by Adam Barth.
Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.
Source/WebCore:
Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):
- platform/ScrollAnimatorNone.h:
Source/WebKit/chromium:
Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper
- tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):
- 10:47 AM Changeset in webkit [92001] by
-
- 1 edit3 moves in trunk/LayoutTests
rename css3/flexbox/display-property.html to css3/flexbox/css-properties.html
https://bugs.webkit.org/show_bug.cgi?id=65343
Reviewed by Mihai Parparita.
I plan on adding more tests for the other flexbox properties
(flex-order, flex-direction, flex-pack, flex-align) to this file.
- css3/flexbox/css-properties-expected.txt: Copied from LayoutTests/css3/flexbox/display-property-expected.txt.
- css3/flexbox/css-properties.html: Copied from LayoutTests/css3/flexbox/display-property.html.
- css3/flexbox/display-property-expected.txt: Removed.
- css3/flexbox/display-property.html: Removed.
- css3/flexbox/script-tests/css-properties.js: Copied from LayoutTests/css3/flexbox/script-tests/display-property.js.
- css3/flexbox/script-tests/display-property.js: Removed.
- 10:37 AM Changeset in webkit [92000] by
-
- 8 edits in trunk/Source/WebCore
Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994
To support searching the AccessibilityObject cache, we first need to
implement a minimal set of functions that will allow AccessibilityObjects
to be identified when searching using common search criteria. The additional
functions below complement the existing identification functionality already
available and together provide a basic working set to build search on top of.
Additionally, the blockquoteLevel function has been moved into the AccessibilityObject
class to make it available to all platforms.
Patch by Samuel White <Samuel White> on 2011-07-29
Reviewed by Chris Fleizach.
New tests will be included in the following patch that will also implement
basic search functionality.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isBlockquote):
(WebCore::AccessibilityObject::isLandmark):
(WebCore::AccessibilityObject::hasMisspelling):
(WebCore::AccessibilityObject::blockquoteLevel):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isUnvisited):
(WebCore::AccessibilityObject::hasBoldFont):
(WebCore::AccessibilityObject::hasItalicFont):
(WebCore::AccessibilityObject::hasPlainText):
(WebCore::AccessibilityObject::hasSameFont):
(WebCore::AccessibilityObject::hasSameFontColor):
(WebCore::AccessibilityObject::hasSameStyle):
(WebCore::AccessibilityObject::hasStaticText):
(WebCore::AccessibilityObject::hasUnderline):
(WebCore::AccessibilityObject::tableLevel):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isUnvisited):
(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasSameFont):
(WebCore::AccessibilityRenderObject::hasSameFontColor):
(WebCore::AccessibilityRenderObject::hasSameStyle):
(WebCore::AccessibilityRenderObject::hasUnderline):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableLevel):
- accessibility/AccessibilityTable.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetBlockquoteLevel):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- 10:23 AM Changeset in webkit [91999] by
-
- 2 edits in trunk/Source/WebCore
Avoid calling animation timer updates while the page is loading
https://bugs.webkit.org/show_bug.cgi?id=64851
Patch by Zeng Huiqing <huiqing.zeng@intel.com> on 2011-07-29
Reviewed by Simon Fraser.
There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
- 10:18 AM Changeset in webkit [91998] by
-
- 4 edits in trunk/Source
Pass the HTTP referrer header for URLs loaded by plug-ins
https://bugs.webkit.org/show_bug.cgi?id=65379
<rdar://problem/9822116>
Reviewed by Sam Weinig.
../WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
../WebKit2:
Set the HTTP referrer if necessary.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):
- 9:10 AM Changeset in webkit [91997] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed typo fix.
- platform/qt/Skipped:
- 8:59 AM Changeset in webkit [91996] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking some media tests as passing and removing from
expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 8:39 AM Changeset in webkit [91995] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r91986
- platform/qt-arm/Skipped: Skip failing tests.
- 8:28 AM Changeset in webkit [91994] by
-
- 2 edits in trunk/Source/WebKit2
Fix the QTouchWebView in debug segfault on shutdown introduced in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728
Reviewed by Benjamin Poulain.
unregisterTile is called in the tile's destructor, triggered in the TileSet's
destruction, which happens in the middle of the proxy's destruction
(after the m_tilesByID HashMap destruction).
Detach the tiles in the proxy's destructor to make sure they can cleanup
using a valid proxy.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):
- 6:47 AM Changeset in webkit [91993] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r91986
- platform/qt-mac/Skipped: Skip one more failing test.
- 6:42 AM Changeset in webkit [91992] by
-
- 2 edits in trunk/LayoutTests
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810
- platform/qt/Skipped: Add 4 new failing tests.
- 6:38 AM Changeset in webkit [91991] by
-
- 2 edits in trunk/LayoutTests
[Qt][ARM]REGRESSION(r91752): It made audio related tests fail
https://bugs.webkit.org/show_bug.cgi?id=65369
- platform/qt-arm/Skipped: Skip failing tests.
- 6:36 AM Changeset in webkit [91990] by
-
- 3 edits in trunk/Source/WebKit2
Fix the QTouchWebView in debug broke in 91979.
https://bugs.webkit.org/show_bug.cgi?id=64728
Reviewed by Benjamin Poulain.
registerTile is called in the Tile's constructor, before adoptRef.
Change the pointer parameter to use the raw type instead.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::registerTile):
- UIProcess/TiledDrawingAreaProxy.h:
- 5:49 AM Changeset in webkit [91989] by
-
- 3 edits79 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r91986
- platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
- platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
- platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- platform/qt-4.8/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
- platform/qt-4.8/svg/batik/filters/filterRegions-expected.png: Added.
- platform/qt-4.8/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/qt-4.8/svg/batik/masking/maskRegions-expected.png: Added.
- platform/qt-4.8/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
- platform/qt-4.8/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
- platform/qt-4.8/svg/batik/paints/patternRegionA-expected.png: Added.
- platform/qt-4.8/svg/batik/paints/patternRegionA-expected.txt: Added.
- platform/qt-4.8/svg/batik/paints/patternRegions-expected.png: Added.
- platform/qt-4.8/svg/batik/paints/patternRegions-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/longTextOnPath-expected.png: Added.
- platform/qt-4.8/svg/batik/text/longTextOnPath-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/smallFonts-expected.png: Added.
- platform/qt-4.8/svg/batik/text/smallFonts-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textAnchor-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textAnchor-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textAnchor2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textAnchor2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textAnchor3-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textAnchor3-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textDecoration2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textDecoration2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textEffect-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textEffect-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textEffect2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textEffect2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textEffect3-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textEffect3-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textFeatures-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textFeatures-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textLayout2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textLayout2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textLength-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textLength-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textOnPath-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textOnPath-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textOnPath2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textOnPath3-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textPCDATA-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textPCDATA-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textPosition-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textPosition-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textPosition2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textPosition2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textProperties-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textProperties-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/textProperties2-expected.png: Added.
- platform/qt-4.8/svg/batik/text/textProperties2-expected.txt: Added.
- platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.png: Added.
- platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/button-expected.png: Added.
- platform/qt-4.8/svg/carto.net/button-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/colourpicker-expected.png: Added.
- platform/qt-4.8/svg/carto.net/colourpicker-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/combobox-expected.png: Added.
- platform/qt-4.8/svg/carto.net/combobox-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/scrollbar-expected.png: Added.
- platform/qt-4.8/svg/carto.net/scrollbar-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/selectionlist-expected.png: Added.
- platform/qt-4.8/svg/carto.net/selectionlist-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/slider-expected.png: Added.
- platform/qt-4.8/svg/carto.net/slider-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/tabgroup-expected.png: Added.
- platform/qt-4.8/svg/carto.net/tabgroup-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/textbox-expected.png: Added.
- platform/qt-4.8/svg/carto.net/textbox-expected.txt: Added.
- platform/qt-4.8/svg/carto.net/window-expected.png: Added.
- platform/qt-4.8/svg/carto.net/window-expected.txt: Added.
- platform/qt-mac/Skipped: Skip failing tests.
- platform/qt-wk2/Skipped: Skip failing tests.
- 5:49 AM Changeset in webkit [91988] by
-
- 2 edits in trunk/Source/WebCore
Fix speech input icon rect on RTL directions.
https://bugs.webkit.org/show_bug.cgi?id=65333
Reviewed by Tony Gentilcore.
No new tests. This is used by platforms, not WebCore, and
the base functionality is not changed but only the failing cases.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
- 5:32 AM Changeset in webkit [91987] by
-
- 3 edits10 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r91984
- platform/qt-4.8/fast/block/positioning/047-expected.png: Added.
- platform/qt-4.8/fast/block/positioning/047-expected.txt: Added.
- platform/qt-4.8/fast/block/positioning/051-expected.png: Added.
- platform/qt-4.8/fast/block/positioning/051-expected.txt: Added.
- platform/qt-4.8/fast/invalid/019-expected.png: Added.
- platform/qt-4.8/fast/invalid/019-expected.txt: Added.
- platform/qt-4.8/fast/lists/003-expected.png: Added.
- platform/qt-4.8/fast/lists/003-expected.txt: Added.
- platform/qt-4.8/fast/text/basic/generic-family-reset-expected.png: Added.
- platform/qt-4.8/fast/text/basic/generic-family-reset-expected.txt: Added.
- platform/qt-mac/Skipped: Skip failing tests.
- platform/qt-wk2/Skipped: Skip failing tests.
- 5:14 AM Changeset in webkit [91986] by
-
- 7 edits243 adds in trunk/LayoutTests
[Qt] Add platform specific expected results
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
- platform/qt/svg/batik/filters/filterRegions-expected.png: Added.
- platform/qt/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/qt/svg/batik/masking/maskRegions-expected.png: Added.
- platform/qt/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
- platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
- platform/qt/svg/batik/paints/patternRegionA-expected.png: Added.
- platform/qt/svg/batik/paints/patternRegionA-expected.txt: Added.
- platform/qt/svg/batik/paints/patternRegions-expected.png: Added.
- platform/qt/svg/batik/paints/patternRegions-expected.txt: Added.
- platform/qt/svg/batik/text/longTextOnPath-expected.png: Added.
- platform/qt/svg/batik/text/longTextOnPath-expected.txt: Added.
- platform/qt/svg/batik/text/smallFonts-expected.png: Added.
- platform/qt/svg/batik/text/smallFonts-expected.txt: Added.
- platform/qt/svg/batik/text/textAnchor-expected.png: Added.
- platform/qt/svg/batik/text/textAnchor-expected.txt: Added.
- platform/qt/svg/batik/text/textAnchor2-expected.png: Added.
- platform/qt/svg/batik/text/textAnchor2-expected.txt: Added.
- platform/qt/svg/batik/text/textAnchor3-expected.png: Added.
- platform/qt/svg/batik/text/textAnchor3-expected.txt: Added.
- platform/qt/svg/batik/text/textDecoration2-expected.png: Added.
- platform/qt/svg/batik/text/textDecoration2-expected.txt: Added.
- platform/qt/svg/batik/text/textEffect-expected.png: Added.
- platform/qt/svg/batik/text/textEffect-expected.txt: Added.
- platform/qt/svg/batik/text/textEffect2-expected.png: Added.
- platform/qt/svg/batik/text/textEffect2-expected.txt: Added.
- platform/qt/svg/batik/text/textEffect3-expected.png: Added.
- platform/qt/svg/batik/text/textEffect3-expected.txt: Added.
- platform/qt/svg/batik/text/textFeatures-expected.png: Added.
- platform/qt/svg/batik/text/textFeatures-expected.txt: Added.
- platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
- platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
- platform/qt/svg/batik/text/textLayout2-expected.png: Added.
- platform/qt/svg/batik/text/textLayout2-expected.txt: Added.
- platform/qt/svg/batik/text/textLength-expected.png: Added.
- platform/qt/svg/batik/text/textLength-expected.txt: Added.
- platform/qt/svg/batik/text/textOnPath-expected.png: Added.
- platform/qt/svg/batik/text/textOnPath-expected.txt: Added.
- platform/qt/svg/batik/text/textOnPath2-expected.png: Added.
- platform/qt/svg/batik/text/textOnPath2-expected.txt: Added.
- platform/qt/svg/batik/text/textOnPath3-expected.png: Added.
- platform/qt/svg/batik/text/textOnPath3-expected.txt: Added.
- platform/qt/svg/batik/text/textPCDATA-expected.png: Added.
- platform/qt/svg/batik/text/textPCDATA-expected.txt: Added.
- platform/qt/svg/batik/text/textPosition-expected.png: Added.
- platform/qt/svg/batik/text/textPosition-expected.txt: Added.
- platform/qt/svg/batik/text/textPosition2-expected.png: Added.
- platform/qt/svg/batik/text/textPosition2-expected.txt: Added.
- platform/qt/svg/batik/text/textProperties-expected.png: Added.
- platform/qt/svg/batik/text/textProperties-expected.txt: Added.
- platform/qt/svg/batik/text/textProperties2-expected.png: Added.
- platform/qt/svg/batik/text/textProperties2-expected.txt: Added.
- platform/qt/svg/batik/text/verticalTextOnPath-expected.png: Added.
- platform/qt/svg/batik/text/verticalTextOnPath-expected.txt: Added.
- platform/qt/svg/carto.net/button-expected.png: Added.
- platform/qt/svg/carto.net/button-expected.txt: Added.
- platform/qt/svg/carto.net/colourpicker-expected.png: Added.
- platform/qt/svg/carto.net/colourpicker-expected.txt: Added.
- platform/qt/svg/carto.net/combobox-expected.png: Added.
- platform/qt/svg/carto.net/combobox-expected.txt: Added.
- platform/qt/svg/carto.net/scrollbar-expected.png: Added.
- platform/qt/svg/carto.net/scrollbar-expected.txt: Added.
- platform/qt/svg/carto.net/selectionlist-expected.png: Added.
- platform/qt/svg/carto.net/selectionlist-expected.txt: Added.
- platform/qt/svg/carto.net/slider-expected.png: Added.
- platform/qt/svg/carto.net/slider-expected.txt: Added.
- platform/qt/svg/carto.net/tabgroup-expected.png: Added.
- platform/qt/svg/carto.net/tabgroup-expected.txt: Added.
- platform/qt/svg/carto.net/textbox-expected.png: Added.
- platform/qt/svg/carto.net/textbox-expected.txt: Added.
- platform/qt/svg/carto.net/window-expected.png: Added.
- platform/qt/svg/carto.net/window-expected.txt: Added.
- platform/qt/svg/css/css-box-min-width-expected.png: Added.
- platform/qt/svg/css/css-box-min-width-expected.txt: Added.
- platform/qt/svg/css/getComputedStyle-basic-expected.png: Added.
- platform/qt/svg/custom/foreign-object-skew-expected.png: Added.
- platform/qt/svg/custom/foreign-object-skew-expected.txt: Added.
- platform/qt/svg/custom/grayscale-gradient-mask-expected.png: Added.
- platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Added.
- platform/qt/svg/custom/group-opacity-expected.png: Added.
- platform/qt/svg/custom/group-opacity-expected.txt: Added.
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
- platform/qt/svg/custom/js-late-clipPath-creation-expected.png: Added.
- platform/qt/svg/custom/js-late-clipPath-creation-expected.txt: Added.
- platform/qt/svg/custom/percentage-rect-expected.png: Added.
- platform/qt/svg/custom/percentage-rect-expected.txt: Added.
- platform/qt/svg/custom/pointer-events-image-expected.png: Added.
- platform/qt/svg/custom/pointer-events-image-expected.txt: Added.
- platform/qt/svg/custom/text-linking-expected.png: Added.
- platform/qt/svg/custom/text-linking-expected.txt: Added.
- platform/qt/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
- platform/qt/svg/hixie/cascade/001-broken-expected.png: Added.
- platform/qt/svg/hixie/cascade/001-broken-expected.txt: Added.
- platform/qt/svg/hixie/data-types/001-expected.png: Added.
- platform/qt/svg/hixie/data-types/001-expected.txt: Added.
- platform/qt/svg/hixie/dynamic/002-expected.png: Added.
- platform/qt/svg/hixie/dynamic/002-expected.txt:
- platform/qt/svg/hixie/dynamic/003-expected.png: Added.
- platform/qt/svg/hixie/dynamic/003-expected.txt: Added.
- platform/qt/svg/hixie/dynamic/004-expected.png: Added.
- platform/qt/svg/hixie/dynamic/004-expected.txt: Added.
- platform/qt/svg/hixie/dynamic/005-expected.png: Added.
- platform/qt/svg/hixie/dynamic/005-expected.txt: Added.
- platform/qt/svg/hixie/dynamic/006-expected.png: Added.
- platform/qt/svg/hixie/dynamic/006-expected.txt: Added.
- platform/qt/svg/hixie/error/001-expected.png: Added.
- platform/qt/svg/hixie/error/001-expected.txt: Added.
- platform/qt/svg/hixie/error/002-expected.png: Added.
- platform/qt/svg/hixie/error/002-expected.txt: Added.
- platform/qt/svg/hixie/error/003-expected.png: Added.
- platform/qt/svg/hixie/error/003-expected.txt: Added.
- platform/qt/svg/hixie/error/007-expected.png: Added.
- platform/qt/svg/hixie/error/007-expected.txt: Added.
- platform/qt/svg/hixie/error/008-expected.png: Added.
- platform/qt/svg/hixie/error/008-expected.txt: Added.
- platform/qt/svg/hixie/error/009-expected.png: Added.
- platform/qt/svg/hixie/error/009-expected.txt: Added.
- platform/qt/svg/hixie/error/010-expected.png: Added.
- platform/qt/svg/hixie/error/010-expected.txt: Added.
- platform/qt/svg/hixie/error/011-expected.png: Added.
- platform/qt/svg/hixie/error/011-expected.txt: Added.
- platform/qt/svg/hixie/error/013-expected.png: Added.
- platform/qt/svg/hixie/error/013-expected.txt: Added.
- platform/qt/svg/hixie/error/014-expected.png: Added.
- platform/qt/svg/hixie/error/014-expected.txt: Added.
- platform/qt/svg/hixie/error/014-test-expected.png: Added.
- platform/qt/svg/hixie/error/014-test-expected.txt: Added.
- platform/qt/svg/hixie/error/015-expected.png: Added.
- platform/qt/svg/hixie/error/015-expected.txt: Added.
- platform/qt/svg/hixie/error/016-expected.png: Added.
- platform/qt/svg/hixie/error/016-expected.txt: Added.
- platform/qt/svg/hixie/error/017-expected.png: Added.
- platform/qt/svg/hixie/error/017-expected.txt: Added.
- platform/qt/svg/hixie/links/001-expected.png: Added.
- platform/qt/svg/hixie/links/001-expected.txt: Added.
- platform/qt/svg/hixie/links/002-expected.png: Added.
- platform/qt/svg/hixie/links/002-expected.txt: Added.
- platform/qt/svg/hixie/mixed/003-expected.png: Added.
- platform/qt/svg/hixie/mixed/003-expected.txt: Added.
- platform/qt/svg/hixie/mixed/004-expected.png: Added.
- platform/qt/svg/hixie/mixed/004-expected.txt: Added.
- platform/qt/svg/hixie/mixed/005-expected.png: Added.
- platform/qt/svg/hixie/mixed/005-expected.txt: Added.
- platform/qt/svg/hixie/mixed/006-expected.png: Added.
- platform/qt/svg/hixie/mixed/006-expected.txt: Added.
- platform/qt/svg/hixie/mixed/007-expected.png: Added.
- platform/qt/svg/hixie/mixed/007-expected.txt:
- platform/qt/svg/hixie/mixed/008-expected.png: Added.
- platform/qt/svg/hixie/mixed/008-expected.txt: Added.
- platform/qt/svg/hixie/mixed/009-expected.png: Added.
- platform/qt/svg/hixie/mixed/009-expected.txt: Added.
- platform/qt/svg/hixie/mixed/010-expected.png: Added.
- platform/qt/svg/hixie/mixed/010-expected.txt: Added.
- platform/qt/svg/hixie/mixed/011-expected.png: Added.
- platform/qt/svg/hixie/mixed/011-expected.txt: Added.
- platform/qt/svg/hixie/painting/001-expected.png: Added.
- platform/qt/svg/hixie/painting/001-expected.txt: Added.
- platform/qt/svg/hixie/perf/001-expected.png: Added.
- platform/qt/svg/hixie/perf/001-expected.txt: Added.
- platform/qt/svg/hixie/perf/002-expected.png: Added.
- platform/qt/svg/hixie/perf/002-expected.txt: Added.
- platform/qt/svg/hixie/perf/003-expected.png: Added.
- platform/qt/svg/hixie/perf/003-expected.txt: Added.
- platform/qt/svg/hixie/perf/004-expected.png: Added.
- platform/qt/svg/hixie/perf/004-expected.txt: Added.
- platform/qt/svg/hixie/perf/005-expected.png: Added.
- platform/qt/svg/hixie/perf/005-expected.txt: Added.
- platform/qt/svg/hixie/perf/006-expected.png: Added.
- platform/qt/svg/hixie/perf/006-expected.txt: Added.
- platform/qt/svg/hixie/perf/007-expected.png: Added.
- platform/qt/svg/hixie/perf/007-expected.txt: Added.
- platform/qt/svg/hixie/processing-model/003-expected.png: Added.
- platform/qt/svg/hixie/processing-model/003-expected.txt:
- platform/qt/svg/hixie/processing-model/004-expected.png: Added.
- platform/qt/svg/hixie/processing-model/004-expected.txt:
- platform/qt/svg/hixie/processing-model/005-expected.png: Added.
- platform/qt/svg/hixie/processing-model/005-expected.txt: Added.
- platform/qt/svg/hixie/rendering-model/001-expected.png: Added.
- platform/qt/svg/hixie/rendering-model/001-expected.txt: Added.
- platform/qt/svg/hixie/rendering-model/002-expected.png: Added.
- platform/qt/svg/hixie/rendering-model/002-expected.txt: Added.
- platform/qt/svg/hixie/rendering-model/003-expected.png: Added.
- platform/qt/svg/hixie/rendering-model/003-expected.txt: Added.
- platform/qt/svg/hixie/rendering-model/003a-expected.png: Added.
- platform/qt/svg/hixie/rendering-model/003a-expected.txt: Added.
- platform/qt/svg/hixie/rendering-model/004-expected.png: Added.
- platform/qt/svg/hixie/rendering-model/004-expected.txt: Added.
- platform/qt/svg/hixie/shapes/path/001-expected.png: Added.
- platform/qt/svg/hixie/shapes/path/001-expected.txt: Added.
- platform/qt/svg/hixie/text/002-expected.png: Added.
- platform/qt/svg/hixie/text/002-expected.txt: Added.
- platform/qt/svg/hixie/text/003-expected.png: Added.
- platform/qt/svg/hixie/text/003-expected.txt: Added.
- platform/qt/svg/hixie/text/003a-expected.png: Added.
- platform/qt/svg/hixie/text/003a-expected.txt: Added.
- platform/qt/svg/hixie/text/003b-expected.png: Added.
- platform/qt/svg/hixie/text/003b-expected.txt: Added.
- platform/qt/svg/hixie/transform/001-expected.png: Added.
- platform/qt/svg/hixie/transform/001-expected.txt: Added.
- platform/qt/svg/hixie/use/001-expected.png: Added.
- platform/qt/svg/hixie/use/001-expected.txt: Added.
- platform/qt/svg/hixie/use/002-expected.png: Added.
- platform/qt/svg/hixie/use/002-expected.txt: Added.
- platform/qt/svg/hixie/use/002-test-expected.png: Added.
- platform/qt/svg/hixie/use/002-test-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/001-expected.png: Added.
- platform/qt/svg/hixie/viewbox/001-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/002-expected.png: Added.
- platform/qt/svg/hixie/viewbox/002-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/003-expected.png: Added.
- platform/qt/svg/hixie/viewbox/003-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/004-expected.png: Added.
- platform/qt/svg/hixie/viewbox/004-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png: Added.
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png: Added.
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
- 4:55 AM Changeset in webkit [91985] by
-
- 11 edits in trunk/Source/WebKit2
[Qt] Make QDesktopWebView/QTouchWebView loadProgress property more usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65315
Reviewed by Benjamin Poulain.
In order to use the loadProgress value in QML we need to make it
a Q_PROPERTY, therefore we need a getter to get it.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didChangeLoadProgress):
(QDesktopWebView::url):
(QDesktopWebView::loadProgress):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::loadProgress):
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::stop):
(tst_CommonViewTests::loadProgress):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::loadProgress):
(WebViewAbstraction::desktopViewLoadFailed):
(WebViewAbstraction::touchViewLoadProgressChanged):
(WebViewAbstraction::desktopViewLoadProgressChanged):
- UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didChangeLoadProgress):
- UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::loadProgress):
- UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::didChangeLoadProgress):
- 4:30 AM Changeset in webkit [91984] by
-
- 68 edits186 adds in trunk/LayoutTests
[Qt] Update platform specific expected results
Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-29
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/fast/backgrounds/opacity-on-document-element-expected.png: Added.
- platform/qt/fast/backgrounds/opacity-on-document-element-expected.txt:
- platform/qt/fast/block/basic/010-expected.png: Added.
- platform/qt/fast/block/basic/010-expected.txt:
- platform/qt/fast/block/float/004-expected.png: Added.
- platform/qt/fast/block/float/004-expected.txt:
- platform/qt/fast/block/float/010-expected.png: Added.
- platform/qt/fast/block/float/010-expected.txt:
- platform/qt/fast/block/float/017-expected.png: Added.
- platform/qt/fast/block/float/017-expected.txt:
- platform/qt/fast/block/float/021-expected.png: Added.
- platform/qt/fast/block/float/021-expected.txt:
- platform/qt/fast/block/float/032-expected.png: Added.
- platform/qt/fast/block/float/032-expected.txt:
- platform/qt/fast/block/float/br-with-clear-expected.png: Added.
- platform/qt/fast/block/float/br-with-clear-expected.txt: Added.
- platform/qt/fast/block/float/float-in-float-hit-testing-expected.png: Added.
- platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
- platform/qt/fast/block/margin-collapse/006-expected.png: Added.
- platform/qt/fast/block/margin-collapse/006-expected.txt:
- platform/qt/fast/block/margin-collapse/055-expected.png: Added.
- platform/qt/fast/block/margin-collapse/055-expected.txt:
- platform/qt/fast/block/positioning/047-expected.png: Added.
- platform/qt/fast/block/positioning/047-expected.txt:
- platform/qt/fast/block/positioning/051-expected.png: Added.
- platform/qt/fast/block/positioning/051-expected.txt:
- platform/qt/fast/block/positioning/056-expected.png: Added.
- platform/qt/fast/block/positioning/056-expected.txt:
- platform/qt/fast/block/positioning/061-expected.png: Added.
- platform/qt/fast/block/positioning/061-expected.txt:
- platform/qt/fast/block/positioning/move-with-auto-width-expected.png: Added.
- platform/qt/fast/block/positioning/move-with-auto-width-expected.txt: Added.
- platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
- platform/qt/fast/css/beforeSelectorOnCodeElement-expected.txt:
- platform/qt/fast/dynamic/containing-block-change-expected.png: Added.
- platform/qt/fast/dynamic/containing-block-change-expected.txt:
- platform/qt/fast/dynamic/floating-to-positioned-2-expected.png: Added.
- platform/qt/fast/dynamic/floating-to-positioned-2-expected.txt: Added.
- platform/qt/fast/dynamic/floating-to-positioned-expected.png: Added.
- platform/qt/fast/dynamic/floating-to-positioned-expected.txt: Added.
- platform/qt/fast/events/focusingUnloadedFrame-expected.png: Added.
- platform/qt/fast/flexbox/002-expected.png: Added.
- platform/qt/fast/flexbox/002-expected.txt:
- platform/qt/fast/flexbox/003-expected.png: Added.
- platform/qt/fast/flexbox/003-expected.txt:
- platform/qt/fast/forms/listbox-clip-expected.png: Added.
- platform/qt/fast/forms/listbox-clip-expected.txt:
- platform/qt/fast/forms/menulist-clip-expected.png: Added.
- platform/qt/fast/forms/menulist-clip-expected.txt:
- platform/qt/fast/forms/minWidthPercent-expected.png: Added.
- platform/qt/fast/forms/minWidthPercent-expected.txt:
- platform/qt/fast/forms/onchange-enter-submit-expected.png: Added.
- platform/qt/fast/gradients/background-clipped-expected.png: Added.
- platform/qt/fast/gradients/background-clipped-expected.txt: Added.
- platform/qt/fast/gradients/generated-gradients-expected.png: Added.
- platform/qt/fast/gradients/generated-gradients-expected.txt: Added.
- platform/qt/fast/gradients/simple-gradients-expected.png: Added.
- platform/qt/fast/gradients/simple-gradients-expected.txt: Added.
- platform/qt/fast/inline-block/001-expected.png: Added.
- platform/qt/fast/inline-block/001-expected.txt:
- platform/qt/fast/inline/continuation-outlines-expected.png: Added.
- platform/qt/fast/inline/continuation-outlines-expected.txt:
- platform/qt/fast/inline/continuation-outlines-with-layers-expected.png: Added.
- platform/qt/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png: Added.
- platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
- platform/qt/fast/invalid/019-expected.png: Added.
- platform/qt/fast/invalid/019-expected.txt:
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
- platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
- platform/qt/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
- platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- platform/qt/fast/layers/self-painting-outline-expected.png: Added.
- platform/qt/fast/layers/self-painting-outline-expected.txt: Added.
- platform/qt/fast/lists/003-expected.png: Added.
- platform/qt/fast/lists/003-expected.txt:
- platform/qt/fast/media/mq-animation-expected.png: Added.
- platform/qt/fast/media/mq-animation-expected.txt: Added.
- platform/qt/fast/media/mq-js-media-except-01-expected.png: Added.
- platform/qt/fast/media/mq-js-media-except-01-expected.txt:
- platform/qt/fast/media/mq-js-media-except-02-expected.png: Added.
- platform/qt/fast/media/mq-js-media-except-02-expected.txt:
- platform/qt/fast/overflow/table-overflow-float-expected.png: Added.
- platform/qt/fast/overflow/table-overflow-float-expected.txt:
- platform/qt/fast/repaint/4774354-expected.png: Added.
- platform/qt/fast/repaint/4774354-expected.txt:
- platform/qt/fast/repaint/4776765-expected.png: Added.
- platform/qt/fast/repaint/4776765-expected.txt:
- platform/qt/fast/repaint/backgroundSizeRepaint-expected.png: Added.
- platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
- platform/qt/fast/repaint/body-background-image-expected.png: Added.
- platform/qt/fast/repaint/body-background-image-expected.txt:
- platform/qt/fast/repaint/border-fit-lines-expected.png: Added.
- platform/qt/fast/repaint/border-fit-lines-expected.txt:
- platform/qt/fast/repaint/border-radius-repaint-expected.png: Added.
- platform/qt/fast/repaint/border-radius-repaint-expected.txt:
- platform/qt/fast/repaint/border-repaint-glitch-expected.png: Added.
- platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
- platform/qt/fast/repaint/box-shadow-dynamic-expected.png: Added.
- platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
- platform/qt/fast/repaint/bugzilla-3509-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-3509-expected.txt:
- platform/qt/fast/repaint/bugzilla-5699-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-5699-expected.txt:
- platform/qt/fast/repaint/bugzilla-6278-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-6278-expected.txt:
- platform/qt/fast/repaint/bugzilla-6388-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-6388-expected.txt:
- platform/qt/fast/repaint/bugzilla-6473-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-6473-expected.txt:
- platform/qt/fast/repaint/bugzilla-7235-expected.png: Added.
- platform/qt/fast/repaint/bugzilla-7235-expected.txt:
- platform/qt/fast/repaint/caret-outside-block-expected.png: Added.
- platform/qt/fast/repaint/caret-outside-block-expected.txt: Added.
- platform/qt/fast/repaint/change-transform-expected.png: Added.
- platform/qt/fast/repaint/change-transform-expected.txt: Added.
- platform/qt/fast/repaint/clip-with-layout-delta-expected.png: Added.
- platform/qt/fast/repaint/clip-with-layout-delta-expected.txt: Added.
- platform/qt/fast/repaint/clipped-relative-expected.png: Added.
- platform/qt/fast/repaint/clipped-relative-expected.txt:
- platform/qt/fast/repaint/containing-block-position-change-expected.png: Added.
- platform/qt/fast/repaint/containing-block-position-change-expected.txt:
- platform/qt/fast/repaint/continuation-after-outline-expected.png: Added.
- platform/qt/fast/repaint/continuation-after-outline-expected.txt:
- platform/qt/fast/repaint/create-layer-repaint-expected.png: Added.
- platform/qt/fast/repaint/create-layer-repaint-expected.txt: Added.
- platform/qt/fast/repaint/delete-into-nested-block-expected.png: Added.
- platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
- platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
- platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
- platform/qt/fast/repaint/float-move-during-layout-expected.png: Added.
- platform/qt/fast/repaint/float-move-during-layout-expected.txt:
- platform/qt/fast/repaint/float-overflow-expected.png: Added.
- platform/qt/fast/repaint/float-overflow-expected.txt:
- platform/qt/fast/repaint/float-overflow-right-expected.png: Added.
- platform/qt/fast/repaint/float-overflow-right-expected.txt:
- platform/qt/fast/repaint/focus-layers-expected.png: Added.
- platform/qt/fast/repaint/focus-layers-expected.txt:
- platform/qt/fast/repaint/inline-color-change-expected.png: Added.
- platform/qt/fast/repaint/inline-color-change-expected.txt: Added.
- platform/qt/fast/repaint/invisible-objects-expected.png: Added.
- platform/qt/fast/repaint/invisible-objects-expected.txt: Added.
- platform/qt/fast/repaint/layout-state-only-positioned-expected.png: Added.
- platform/qt/fast/repaint/layout-state-only-positioned-expected.txt: Added.
- platform/qt/fast/repaint/layout-state-relative-expected.png: Added.
- platform/qt/fast/repaint/layout-state-relative-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-1-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-10-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-2-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-3-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-4-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-5-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-6-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-7-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-8-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt: Added.
- platform/qt/fast/repaint/line-flow-with-floats-9-expected.png: Added.
- platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt: Added.
- platform/qt/fast/repaint/line-overflow-expected.png: Added.
- platform/qt/fast/repaint/line-overflow-expected.txt:
- platform/qt/fast/repaint/lines-with-layout-delta-expected.png: Added.
- platform/qt/fast/repaint/lines-with-layout-delta-expected.txt: Added.
- platform/qt/fast/repaint/list-marker-2-expected.png: Added.
- platform/qt/fast/repaint/list-marker-2-expected.txt:
- platform/qt/fast/repaint/make-children-non-inline-expected.png: Added.
- platform/qt/fast/repaint/make-children-non-inline-expected.txt: Added.
- platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
- platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
- platform/qt/fast/repaint/outline-child-repaint-expected.png: Added.
- platform/qt/fast/repaint/outline-child-repaint-expected.txt: Added.
- platform/qt/fast/repaint/outline-inset-expected.png: Added.
- platform/qt/fast/repaint/outline-inset-expected.txt:
- platform/qt/fast/repaint/outline-repaint-glitch-expected.png: Added.
- platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
- platform/qt/fast/repaint/outline-shrinking-expected.png: Added.
- platform/qt/fast/repaint/outline-shrinking-expected.txt:
- platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
- platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
- platform/qt/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/qt/fast/repaint/overflow-delete-line-expected.txt:
- platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
- platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
- platform/qt/fast/repaint/overflow-scroll-delete-expected.png: Added.
- platform/qt/fast/repaint/overflow-scroll-delete-expected.txt: Added.
- platform/qt/fast/repaint/reflection-redraw-expected.png: Added.
- platform/qt/fast/repaint/reflection-redraw-expected.txt: Added.
- platform/qt/fast/repaint/reflection-repaint-test-expected.png: Added.
- platform/qt/fast/repaint/reflection-repaint-test-expected.txt: Added.
- platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
- platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
- platform/qt/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
- platform/qt/fast/repaint/selected-replaced-expected.png: Added.
- platform/qt/fast/repaint/selected-replaced-expected.txt: Added.
- platform/qt/fast/repaint/selection-clear-expected.png: Added.
- platform/qt/fast/repaint/selection-clear-expected.txt: Added.
- platform/qt/fast/repaint/static-to-positioned-expected.png: Added.
- platform/qt/fast/repaint/static-to-positioned-expected.txt:
- platform/qt/fast/repaint/subtree-root-clip-2-expected.png: Added.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Added.
- platform/qt/fast/repaint/subtree-root-clip-3-expected.png: Added.
- platform/qt/fast/repaint/subtree-root-clip-3-expected.txt: Added.
- platform/qt/fast/repaint/subtree-root-clip-expected.png: Added.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Added.
- platform/qt/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/qt/fast/repaint/subtree-root-skipped-expected.txt: Added.
- platform/qt/fast/repaint/table-cell-collapsed-border-expected.png: Added.
- platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/qt/fast/repaint/table-cell-move-expected.png: Added.
- platform/qt/fast/repaint/table-cell-move-expected.txt:
- platform/qt/fast/repaint/table-collapsed-border-expected.png: Added.
- platform/qt/fast/repaint/table-collapsed-border-expected.txt:
- platform/qt/fast/repaint/table-extra-bottom-grow-expected.png: Added.
- platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.png: Added.
- platform/qt/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Added.
- platform/qt/fast/repaint/text-append-dirty-lines-expected.png: Added.
- platform/qt/fast/repaint/text-append-dirty-lines-expected.txt: Added.
- platform/qt/fast/repaint/transform-absolute-child-expected.png: Added.
- platform/qt/fast/repaint/transform-absolute-child-expected.txt: Added.
- platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
- platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
- platform/qt/fast/repaint/transform-disable-layoutstate-expected.png: Added.
- platform/qt/fast/repaint/transform-disable-layoutstate-expected.txt: Added.
- platform/qt/fast/repaint/transform-layout-repaint-expected.png: Added.
- platform/qt/fast/repaint/transform-layout-repaint-expected.txt: Added.
- platform/qt/fast/repaint/transform-relative-position-expected.png: Added.
- platform/qt/fast/repaint/transform-relative-position-expected.txt: Added.
- platform/qt/fast/repaint/transform-repaint-descendants-expected.png: Added.
- platform/qt/fast/repaint/transform-repaint-descendants-expected.txt: Added.
- platform/qt/fast/repaint/transform-replaced-shadows-expected.png: Added.
- platform/qt/fast/repaint/transform-replaced-shadows-expected.txt: Added.
- platform/qt/fast/repaint/transform-translate-expected.png: Added.
- platform/qt/fast/repaint/transform-translate-expected.txt: Added.
- platform/qt/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
- platform/qt/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
- platform/qt/fast/text/basic/generic-family-reset-expected.png: Added.
- platform/qt/fast/text/basic/generic-family-reset-expected.txt:
- platform/qt/fast/text/whitespace/002-expected.png: Added.
- platform/qt/fast/text/whitespace/002-expected.txt:
- platform/qt/fast/text/whitespace/003-expected.png: Added.
- platform/qt/fast/text/whitespace/003-expected.txt:
- 4:21 AM Changeset in webkit [91983] by
-
- 2 edits in trunk/LayoutTests
[chromium] Fail new fast/js/parseInt.html test
https://bugs.webkit.org/show_bug.cgi?id=65366
Unreviewed expectaions update.
- platform/chromium/test_expectations.txt:
- 3:26 AM Changeset in webkit [91982] by
-
- 7 edits in trunk/Source/WebCore
Make the ExceptionCode argument of Element::setShadowPseudoId() ASSERT_NO_EXCEPTION by default
https://bugs.webkit.org/show_bug.cgi?id=65363
Reviewed by Hajime Morita.
No new tests. Cleanup-only.
- dom/Element.h: Make the ExceptionCode argument ASSERT_NO_EXCEPTION by default.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree): Remove the ExceptionCode argument and ASSERT(!ec).
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText): ditto.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree): ditto.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree): ditto.
(WebCore::TextFieldInputType::updatePlaceholderText): ditto.
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree): ditto.
- 2:59 AM Changeset in webkit [91981] by
-
- 6 edits in trunk/Source/WebKit/efl
[EFL] Move ewk_view API documentation to the header file
https://bugs.webkit.org/show_bug.cgi?id=65305
There are two arguments for this:
- Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
- It will be consistent with structures descriptions.
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-07-29
Reviewed by Kent Tamura.
- ewk/ewk_tiled_model.c:
- ewk/ewk_view.cpp:
- ewk/ewk_view.h:
- ewk/ewk_view_single.c:
- ewk/ewk_view_tiled.c:
- 2:50 AM Changeset in webkit [91980] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
- platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
- platform/qt-mac/Skipped:
- platform/qt-wk2/Skipped:
- 1:37 AM Changeset in webkit [91979] by
-
- 5 edits in trunk/Source/WebKit2
TiledDrawingArea: Use tile sets to paint old content while rendering for a new scale.
https://bugs.webkit.org/show_bug.cgi?id=64728
Reviewed by Benjamin Poulain.
We currently delete all the tiles when setContentsScale is called. This shows a blank
background to the user while the web process render tiles for the new scale.
This patch extracts the ownership of individual tiles from TiledDrawingAreaProxy to
TiledDrawingAreaTileSet to allow the proxy to paint tiles with different scales.
We can then paint the tiles we already have on top of the tiles we are rendering for
the new scale until enough content is available.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaTileSet::tiles):
(WebKit::TiledDrawingAreaTileSet::contentsScale):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::mapToContents):
(WebKit::TiledDrawingAreaTileSet::mapFromContents):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::registerTile):
(WebKit::TiledDrawingAreaProxy::unregisterTile):
Added those two methods to allow the tiles to clean
themselves on destruction.
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::cancelTileUpdate):
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::updateTileBuffers):
(WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::coverageRatio):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::resizeEdgeTiles):
(WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect):
(WebKit::TiledDrawingAreaProxy::disableTileSetUpdates):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):
(WebKit::TiledDrawingAreaProxy::contentsRect):
(WebKit::TiledDrawingAreaProxy::visibleRect):
(WebKit::TiledDrawingAreaProxy::hasPendingUpdates):
- UIProcess/TiledDrawingAreaProxy.h:
- UIProcess/TiledDrawingAreaTile.h:
- UIProcess/qt/TiledDrawingAreaTileQt.cpp:
(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::updateBackBuffer):
- 1:16 AM Changeset in webkit [91978] by
-
- 2 edits in trunk/LayoutTests
[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364
- platform/qt/Skipped: Skip failing tests.
- 1:04 AM Changeset in webkit [91977] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
- 12:38 AM Changeset in webkit [91976] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix incorrect ChangeLog entry from r91954.
- 12:11 AM QtWebKitForQt5 edited by
- (diff)
- 12:11 AM QtWebKitForQt5 edited by
- WebGL option (diff)
