Timeline



Aug 7, 2011:

11:38 PM Changeset in webkit [92583] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754

Unreviewed chromium test_expectations.txt update
No more failure as r92439 was rolled out by r92453

  • platform/chromium/test_expectations.txt:
11:02 PM Changeset in webkit [92582] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
9:06 PM Changeset in webkit [92581] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix after r92578. I accidentally added the call to dumpAsText(true).

  • editing/pasteboard/nested-blocks-with-text-area.html:
8:46 PM Changeset in webkit [92580] by rniwa@webkit.org
  • 3 edits
    2 adds
    17 deletes in trunk/LayoutTests

Dump-as-markup conversion: paste-blockquote-into-blockquote.html and prevent-block-nesting-01.html
https://bugs.webkit.org/show_bug.cgi?id=65837

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt: Added.
  • editing/pasteboard/prevent-block-nesting-01.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/gtk/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.png: Removed.
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Removed.
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt: Removed.
8:31 PM Changeset in webkit [92579] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758

Test is now green on chromium and webkit build bots.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:47 PM Changeset in webkit [92578] by rniwa@webkit.org
  • 3 edits
    2 adds
    23 deletes in trunk/LayoutTests

Dump-as-markup conversion: nested-blocks-with-text-area.html and nested-blocks-with-text-field.html
https://bugs.webkit.org/show_bug.cgi?id=65836

Reviewed by Kent Tamura.

Converted the tests to dump-as-markup tests to improve the readability of the expected results.

  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-area.html:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-field.html:
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/gtk/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt: Removed.
  • platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt: Removed.
7:28 PM Changeset in webkit [92577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757

This test and the others mentioned in the bug are now green on chromium
and webkit build bots.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-07
Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [92576] by koz@chromium.org
  • 8 edits in trunk/Source

Make the fullscreen JS API enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

  • dom/Document.idl:
  • dom/Element.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

3:16 PM Changeset in webkit [92575] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-through-* results diverging between bots
https://bugs.webkit.org/show_bug.cgi?id=65831

Unreviewed Qt gardening.

  • platform/qt/Skipped:
12:42 PM Changeset in webkit [92574] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

  • UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

6:47 AM Changeset in webkit [92573] by Martin Robinson
  • 5 edits in trunk/Source

Distribution fix for GTK+.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Strip removed files from the source list.

Source/WebCore:

  • GNUmakefile.am: Add some files to the distribution list.
  • GNUmakefile.list.am: Strip removed files from the source list.
4:29 AM Changeset in webkit [92572] by jochen@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

Move FrameLoadRequest to loader/
https://bugs.webkit.org/show_bug.cgi?id=65817

Reviewed by Alexey Proskuryakov.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::requester):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):

2:48 AM Changeset in webkit [92571] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Source/WebCore: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

New AccessibilityObject cache search functionality and API for the mac
platform to expose it. At this point the AccessibilityObject cache can
be searched using one of the supported search keys that have been defined
in AccessibilityObject.h, or by passing search text.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/search-predicate.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
(WebCore::AccessibilityObject::accessibilityObjectContainsText):
(WebCore::AccessibilityObject::accessibleObjectsWithAccessibilitySearchPredicate):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

Added testing support for AccessibilityObject cache searching. Currently,
only the mac platform is full supported and has had API exposed. Other
platforms have only have this new functionality stubbed. Full implementation
is a job suited only for an accessibility expert of each respective platform.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests: Add the ability to search the AccessibilityObject cache
https://bugs.webkit.org/show_bug.cgi?id=64994

Tests for the new AccessibilityObject cache search API and the additional
functionality in the AccessibilityObject class that makes AccessibilityObject
cache searching possible.

Additional tests for finding frames, misspellings, and visited links will be
included in a subsequent patch.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-07
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/search-predicate-expected.txt: Added.
  • platform/mac/accessibility/search-predicate.html: Added.
1:01 AM Changeset in webkit [92570] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Rebaseline a test on GTK+ for which r92554 checked in an
incorrect result.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Update results.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Ditto.

Aug 6, 2011:

8:44 PM Changeset in webkit [92569] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=65821
Don't form identifiers the first time a string is used as a property name.

Reviewed by Oliver Hunt.

This is a 1% win on SunSpider.

  • dfg/DFGOperations.cpp:
    • Use fastGetOwnProperty.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Use fastGetOwnProperty.
  • runtime/JSCell.h:
  • runtime/JSObject.h:

(JSC::JSCell::fastGetOwnProperty):

  • Fast call to get a property without creating an identifier the first time.
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):

  • Add interface to look up by either strinsg or identifiers.
  • runtime/Structure.h:

(JSC::Structure::get):

  • Add a get() call that takes a UString, not an Identifier.
  • wtf/text/StringImpl.h:

(WTF::StringImpl::hasHash):

  • Add a call to check if the has has been set (to detect the first use as a property name).
6:09 PM Changeset in webkit [92568] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.

6:09 PM Changeset in webkit [92567] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): Adopt the newly-allocated WebHTMLConverter
instance so that it does not leak.

4:35 PM Changeset in webkit [92566] by kbalazs@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.
Fix environmental differencies in the results added in r92564.
I was in the wrong chroot.

  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
3:36 PM Changeset in webkit [92565] by siddharth.mathur@nokia.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add Siddharth Mathur to committer list. Unreviewed

3:29 PM Changeset in webkit [92564] by kbalazs@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

Unreviewed gardening.
Add missing Qt results.

  • platform/qt/Skipped:
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-lr-expected.txt: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.png: Added.
  • platform/qt/fast/writing-mode/border-styles-vertical-rl-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
3:19 PM Changeset in webkit [92563] by abarth@webkit.org
  • 6 edits
    6 deletes in trunk/Tools

Remove dead code in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=65818

Reviewed by Dimitri Glazkov.

This code was added to support the rebaseline2 command six months ago,
but the rebaseline2 command was never finished and no one else has used
this code since it was landed. This patch removes the dead code. If
we revive rebaseline2, then we can revert this patch and recover the
code. Until then, this code is just dead weight.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/testoutput.py: Removed.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset.py: Removed.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset.py: Removed.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:17 PM Changeset in webkit [92562] by abarth@webkit.org
  • 3 edits in trunk/Tools

webkit-patch optimize-baselines can't handle promotions to base results directory
https://bugs.webkit.org/show_bug.cgi?id=65819

Reviewed by Dimitri Glazkov.

This bug came up when testing the optimizer on some editing baselines.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3:04 PM Changeset in webkit [92561] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Fix baselines for cross-origin-xsl-BLOCKED.html. These results
uncovered a subtle bug in webkit-patch bulk-optimize-baselines, which
I'll fix in a follow-up patch.

  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
2:24 PM Changeset in webkit [92560] by abarth@webkit.org
  • 1 edit
    3 adds
    8 deletes in trunk/LayoutTests

Optimize expected results for editing.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/copy-paste-float-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/chromium/editing/pasteboard/copy-paste-float-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
  • platform/chromium/editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
2:11 PM Changeset in webkit [92559] by abarth@webkit.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Optimize expected results for animations.
This patch was created with webkit-patch bulk-optimize-baselines.

  • platform/chromium-mac/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium-win/animations/keyframes-rule-expected.txt: Removed.
  • platform/chromium/animations/keyframes-rule-expected.txt: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Removed.
2:07 PM Changeset in webkit [92558] by abarth@webkit.org
  • 2 edits in trunk/Tools

Add a small command to optimize baselines in bulk.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
1:48 PM Changeset in webkit [92557] by abarth@webkit.org
  • 1 edit
    50 adds
    82 deletes in trunk/LayoutTests

Optimize expected results for http/tests/security.
This patch was created with webkit-patch optimize-baselines.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-enumeration-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-get-override-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-location-put-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xss-eval-expected.txt: Removed.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt: Added.
  • platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium/http/tests/security/dataURL: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Added.
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt: Added.
  • platform/chromium/http/tests/security/frameNavigation: Added.
  • platform/chromium/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/http/tests/security/listener: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Added.
  • platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium/http/tests/security/xss-eval-expected.txt: Added.
1:17 PM Changeset in webkit [92556] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Fix Timer heap implementation to work with more libraries (other versions of STL)
https://bugs.webkit.org/show_bug.cgi?id=65782

Reviewed by Anders Carlsson.

No behavior change, so no tests needed. Existing tests pass.

  • platform/Timer.cpp: Added TimerHeapPointer and TimerHeapReference class

alongside the TimerHeapIterator class. Also added a swap function. Also
added a TimerHeapLessThanFunction class.
(WebCore::TimerBase::heapDecreaseKey): Pass pointers in to the TimerHeapIterator
since that's how the class works now. Pass a TimerHeapLessThanFunction object
instead of letting the library use the < operator directly.
(WebCore::TimerBase::heapPopMin): Ditto.

  • platform/Timer.h: Updated for above changes.
12:52 PM Changeset in webkit [92555] by commit-queue@webkit.org
  • 11 edits in trunk

Patch by Aron Rosenberg <arosenberg@logitech.com> on 2011-08-06
Reviewed by Benjamin Poulain.

[Qt] Fix build with Intel compiler on Windows
https://bugs.webkit.org/show_bug.cgi?id=65088

.:

Disable Intel Compiler warning 873 - function "" has no corresponding operator
delete (to be called if an exception is thrown during initialization of an
allocated object).

  • Source/WebKit.pri:

Source/JavaScriptCore:

Intel compiler needs .lib suffixes instead of .a
Intel compiler doesn't support nullptr
Intel compiler supports unsized arrays

Source/WebCore:

Intel compiler needs .lib suffixes instead of .a

  • WebCore.pri:

Source/WebKit2:

Intel compiler needs .lib suffixes instead of .a

  • WebKit2.pri:
10:09 AM Changeset in webkit [92554] by Nikolas Zimmermann
  • 6 edits
    2 deletes in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Rebaseline some tests on Leopard/gtk/qt in order to get the bots greener.

Not reviewed.


  • platform/gtk/Skipped:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
10:00 AM Changeset in webkit [92553] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
https://bugs.webkit.org/show_bug.cgi?id=65809

Reviewed by Darin Adler and Sam Weinig.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.

  • platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.

9:17 AM Changeset in webkit [92552] by Joseph Pecoraro
  • 5 edits in trunk/Source

Potential Leaks - RetainPtr<> over retaining Create'd objects
https://bugs.webkit.org/show_bug.cgi?id=65806

Reviewed by Darin Adler.

Fix a possible leak by adopting an allocation instead of retaining it.

Source/WebCore:

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView previousValidKeyView]):

8:57 AM Changeset in webkit [92551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION (r91540): Favicons are not loaded
https://bugs.webkit.org/show_bug.cgi?id=65692

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.

The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.cpp:

(WebCore::documentCanHaveIcon):

  • loader/icon/IconDatabaseBase.h:
8:23 AM Changeset in webkit [92550] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)

  • try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.

Rubber-stamped by Antti Koivisto.

  • svg/zoom/resources/testPageZoom.js: (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().
3:02 AM Changeset in webkit [92549] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Should use C++-style cast in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=65807

Replaces C-style cast with C++style cast.

Reviewed by Shinichiro Hamaji.

No new tests because no behavior change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):

2:40 AM Changeset in webkit [92548] by Nikolas Zimmermann
  • 3 edits
    6 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.


Not reviewed.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1: Added.
  • platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
2:27 AM Changeset in webkit [92547] by Nikolas Zimmermann
  • 4 edits
    2 adds in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.

Not reviewed.

  • platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
2:19 AM Changeset in webkit [92546] by Nikolas Zimmermann
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

Follow-up for r92545.


Rebaseline some tests on gtk/qt and win.

  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
1:25 AM Changeset in webkit [92545] by Nikolas Zimmermann
  • 6 edits
    6 moves
    30 adds in trunk

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
Add several new tests in svg/as-object - covering bug 64974.

  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
  • svg/as-object/embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
  • svg/as-object/embedded-svg-size-changes.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
  • svg/as-object/nested-embedded-svg-size-changes.html: Added.
  • svg/as-object/resources: Added.
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
  • svg/as-object/resources/embedded-svg-size-changes.svg: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.

2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Reviewed by Zoltan Herczeg.

Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
through RenderSVGRoot::layout.

And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
document to be laid out again, now that the size of the embedded SVG document is known.

As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
right before painting.

A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
FrameView::layout().

Consider following document:
<body><iframe src="some.svg"></body>


After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
(in the simplest case, where width/height are both auto).

Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.

After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).

The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).

Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.

Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html

svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/embedded-svg-immediate-offsetWidth-query.html
svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
svg/as-object/embedded-svg-size-changes.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
svg/as-object/nested-embedded-svg-size-changes.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-auto-size.html
svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-override-size.html
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished. (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method. (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
  • page/FrameView.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
  • rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
  • rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic. (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument. (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).

Aug 5, 2011:

9:19 PM BuildingQtOnLinux edited by rafael.lobo@openbossa.org
(diff)
9:14 PM Changeset in webkit [92544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove HaltablePlugin references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=65808

HaltablePlugin and related classes were removed in r92492. Remove any
reference to the deleted files from the gyp project files.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Adam Barth.

  • WebCore.gypi: remove HaltablePlugin.h reference.
8:49 PM Changeset in webkit [92543] by mitz@apple.com
  • 6 edits
    13 moves in trunk/LayoutTests

Renamed fast/blockflow to fast/writing-mode.

Rubber-stamped by Sam Weinig.

  • fast/blockflow: Removed.
  • fast/writing-mode: Copied from fast/blockflow.
  • platform/chromium-linux/fast/blockflow: Removed.
  • platform/chromium-linux/fast/writing-mode: Copied from platform/chromium-linux/fast/blockflow.
  • platform/chromium-mac-leopard/fast/blockflow: Removed.
  • platform/chromium-mac-leopard/fast/writing-mode: Copied from platform/chromium-mac-leopard/fast/blockflow.
  • platform/chromium-mac/fast/blockflow: Removed.
  • platform/chromium-mac/fast/writing-mode: Copied from platform/chromium-mac/fast/blockflow.
  • platform/chromium-win-vista/fast/blockflow: Removed.
  • platform/chromium-win-vista/fast/writing-mode: Copied from platform/chromium-win-vista/fast/blockflow.
  • platform/chromium-win-xp/fast/blockflow: Removed.
  • platform/chromium-win-xp/fast/writing-mode: Copied from platform/chromium-win-xp/fast/blockflow.
  • platform/chromium-win/fast/blockflow: Removed.
  • platform/chromium-win/fast/writing-mode: Copied from platform/chromium-win/fast/blockflow.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/blockflow: Removed.
  • platform/gtk/fast/writing-mode: Copied from platform/gtk/fast/blockflow.
  • platform/mac-leopard/fast/blockflow: Removed.
  • platform/mac-leopard/fast/writing-mode: Copied from platform/mac-leopard/fast/blockflow.
  • platform/mac-wk2/fast/blockflow: Removed.
  • platform/mac-wk2/fast/writing-mode: Copied from platform/mac-wk2/fast/blockflow.
  • platform/mac/Skipped:
  • platform/mac/fast/blockflow: Removed.
  • platform/mac/fast/writing-mode: Copied from platform/mac/fast/blockflow.
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/blockflow: Removed.
  • platform/qt/fast/writing-mode: Copied from platform/qt/fast/blockflow.
  • platform/win/fast/blockflow: Removed.
  • platform/win/fast/writing-mode: Copied from platform/win/fast/blockflow.
  • platform/wk2/Skipped:
8:09 PM Changeset in webkit [92542] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build after r92538.

Like all of the recent "track"-related work the new files in r92538 appear to have
been added to completely random places in the Xcode project. However, this time
the file paths were marked as being relative to their containing group resulting in
Xcode being unable to find the files on disk.

I've attempted to clean up all of the "track"-related mess in the Xcode project.
The location of the files in the project now reflect their locations on disk, and
are all correctly marked as being relative to their containing group as is our
convention.

  • WebCore.xcodeproj/project.pbxproj:
7:25 PM Changeset in webkit [92541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.

Patch by Tom Hudson <tomhudson@google.com> on 2011-08-05
Reviewed by James Robinson.

No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

7:17 PM Changeset in webkit [92540] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String replace with the empty string means string removal
https://bugs.webkit.org/show_bug.cgi?id=65799

Reviewed by Sam Weinig.

Optimization for String.prototype.replace([RegExp], ""), this improves v8-regexp by ~3%.

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::stringProtoFuncReplace):

7:07 PM Changeset in webkit [92539] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

r92330 has been rolled out so its rebaseline needs to be reverted as well
https://bugs.webkit.org/show_bug.cgi?id=65805

  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Added.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
7:00 PM Changeset in webkit [92538] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Adding a WebVTTParser for <track>.
https://bugs.webkit.org/show_bug.cgi?id=62882

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-05
Reviewed by Eric Carlson.

Feature is hidden behind VIDEO_TRACK feature define, which is turned off, but
new tests have been added in media/track/ (and are skipped).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextTrackCue.cpp:
  • html/TextTrackCue.h:
  • platform/track/CueParser.cpp:
  • platform/track/CueParser.h:
  • platform/track/CueParserPrivate.h:
  • platform/track/WebVTTParser.cpp: Added.
  • platform/track/WebVTTParser.h: Added.
6:47 PM Changeset in webkit [92537] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r92330.
http://trac.webkit.org/changeset/92330
https://bugs.webkit.org/show_bug.cgi?id=65804

caused various regressions in paste (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::doApply):

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearance):

  • editing/markup.h:

LayoutTests:

  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-paste-text-in-h1-expected.txt: Removed.
  • editing/pasteboard/copy-paste-text-in-h1.html: Removed.
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
6:45 PM Changeset in webkit [92536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Chromium] Remove JSZombie references from gyp project files.
https://bugs.webkit.org/show_bug.cgi?id=65798

JSC runtime/JSZombie.{cpp,h} were removed in r92046. Remove references to these
file names from the gyp projects.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Darin Adler.

6:33 PM Changeset in webkit [92535] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/835

Merge 91908
BUG=90668

6:31 PM Changeset in webkit [92534] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91908
BUG=90668
Review URL: http://codereview.chromium.org/7550057

6:06 PM Changeset in webkit [92533] by tkent@chromium.org
  • 15 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r92477.
http://trac.webkit.org/changeset/92477
https://bugs.webkit.org/show_bug.cgi?id=62619

Layering violation. We should not use WebCore/dom/ in
WebCore/platform/.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::valueChanged):

  • html/ColorInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::chrome):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach):

  • html/InputType.cpp:
  • html/InputType.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Removed.
  • platform/ColorChooser.h: Removed.
5:47 PM Changeset in webkit [92532] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Qt Mac build.

  • plugins/mac/PluginViewMac.mm: Removed PluginHalter functions.
5:41 PM Changeset in webkit [92531] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a failing test added by r92526 to Qt's skipped list.
The failure is tracked by the bug 65801.

  • platform/qt/Skipped:
5:24 PM Changeset in webkit [92530] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
https://bugs.webkit.org/show_bug.cgi?id=65789

Reviewed by David Kilzer.

Fix a leak by adopting an allocation instead of retaining it.

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::httpBodyFromRequest):

5:15 PM Changeset in webkit [92529] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

5:06 PM Changeset in webkit [92528] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on 32-bit Mac.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag): Added a cast to int.

4:53 PM Changeset in webkit [92527] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip test eeza-Pro-vertical-metrics-adjustment.html in chromium.

  • platform/chromium/test_expectations.txt:
4:41 PM Changeset in webkit [92526] by rniwa@webkit.org
  • 3 edits
    4 copies in trunk

Upwards cursor movement incorrect when previous block ends with <br>
https://bugs.webkit.org/show_bug.cgi?id=33247

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by previousLinePosition's trying to obtain the root line box at the position
after the previous line's br. This obviously fails because the the position after br is considered
as a part of the next line.

Fixed the bug by obtaining root inline boxes using position at the minimum caret offset as supposed
to maximum caret offset. The code was initially introduced by r32508 to fix arrow key movement in RTL text
but the test added by the revision continues to pass after this change. Furthermore, this change makes
new code consistent with nextLinePosition.

Also reverted the change added by r55613 because it is no longer needed.

Tests: editing/execCommand/move-selection-back-line-rtl.html

editing/execCommand/move-selection-back-line-strict.html

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):

LayoutTests:

Added tests to ensure WebKit lets user move caret up in strict mode and in RTL content
when the previous line ends with a br.

  • editing/execCommand/move-selection-back-line-rtl-expected.txt: Copied from

LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.

  • editing/execCommand/move-selection-back-line-rtl.html: Copied from

LayoutTests/editing/execCommand/move-selection-back-line.html.

  • editing/execCommand/move-selection-back-line-strict-expected.txt: Copied from

LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.

  • editing/execCommand/move-selection-back-line-strict.html: Copied from

LayoutTests/editing/execCommand/move-selection-back-line.html.

4:03 PM Changeset in webkit [92525] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

4:02 PM Changeset in webkit [92524] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.7

New tag.

3:36 PM Changeset in webkit [92523] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
is tied to a particular dispatch queue

A RefCounted object can be opted in to this mode by calling setDispatchQueueForVerifier
with the dispatch queue it will be tied to. This will cause ThreadRestrictionVerifier
to ensure that all operations are performed on the given dispatch queue.

Reviewed by Anders Carlsson.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::setDispatchQueueForVerifier):

  • wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::~ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::setShared):
(WTF::ThreadRestrictionVerifier::isSafeToUse):

3:33 PM Changeset in webkit [92522] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Build Fix.

3:15 PM Changeset in webkit [92521] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91531
BUG=89552
Review URL: http://codereview.chromium.org/7585022

3:14 PM Changeset in webkit [92520] by commit-queue@webkit.org
  • 24 edits
    2 adds in trunk/Source

[chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402

Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.

Source/WebCore:

Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.

  • page/Page.cpp:

(WebCore::Page::sharedGraphicsContext3D):

  • page/Page.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::CanvasLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

Source/WebKit/chromium:

Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:
3:12 PM Changeset in webkit [92519] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91308
BUG=89575
Review URL: http://codereview.chromium.org/7541053

3:08 PM Changeset in webkit [92518] by andersca@apple.com
  • 6 edits
    5 copies
    9 adds in trunk/LayoutTests

Add more Lion specific test results and add more tests to the skipped list.

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/fast/dom: Added.
  • platform/mac-snowleopard/fast/dom/52776-expected.png: Copied from platform/mac/fast/dom/52776-expected.png.
  • platform/mac-snowleopard/fast/dom/52776-expected.txt: Copied from platform/mac/fast/dom/52776-expected.txt.
  • platform/mac-snowleopard/fast/loader: Added.
  • platform/mac-snowleopard/fast/preloader: Added.
  • platform/mac-snowleopard/fast/preloader/document-write-2-expected.txt: Copied from fast/preloader/document-write-2-expected.txt.
  • platform/mac-snowleopard/fast/preloader/document-write-expected.txt: Copied from fast/preloader/document-write-expected.txt.
  • platform/mac-snowleopard/fast/preloader/script-expected.txt: Copied from fast/preloader/script-expected.txt.
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/preloader: Added.
  • platform/mac/fast/preloader/document-write-2-expected.txt: Added.
  • platform/mac/fast/preloader/document-write-expected.txt: Added.
  • platform/mac/fast/preloader/script-expected.txt: Added.
3:02 PM Changeset in webkit [92517] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip canvas-putImageData.html in chromium.

  • platform/chromium/test_expectations.txt:
2:57 PM Changeset in webkit [92516] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Build Fix.

2:33 PM Changeset in webkit [92515] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Fix unit test breakage by plumbing convert_404_to_None in MockWeb.

  • Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
2:09 PM Changeset in webkit [92514] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Garden-o-matic updateexpectations needs a unit test.
https://bugs.webkit.org/show_bug.cgi?id=65780

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
2:07 PM Changeset in webkit [92513] by andersca@apple.com
  • 5 edits in trunk

Future proof an Objective-C test
https://bugs.webkit.org/show_bug.cgi?id=65788

Tools:

Reviewed by Dan Bernstein.

Add isObjectInstanceOf to ObjCController.

  • DumpRenderTree/mac/ObjCController.m:

(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController isObject:instanceOf:]):

LayoutTests:

Don't check explicitly for class names; just check that the objects are instances of the right classes.

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
2:00 PM Changeset in webkit [92512] by Lucas Forschler
  • 6 edits in branches/safari-534.51-branch/Source/WebKit/win

Merge r92414.

1:55 PM Changeset in webkit [92511] by Lucas Forschler
  • 8 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92404.

1:50 PM Changeset in webkit [92510] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 91957
BUG=89453
Review URL: http://codereview.chromium.org/7569017

1:49 PM Changeset in webkit [92509] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebKit2

Merge r92345.

1:47 PM Changeset in webkit [92508] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92398.

1:40 PM Changeset in webkit [92507] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92309.

1:38 PM Changeset in webkit [92506] by Lucas Forschler
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92308.

1:34 PM Changeset in webkit [92505] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/835

Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7585017

1:33 PM Changeset in webkit [92504] by Lucas Forschler
  • 4 edits in branches/safari-534.51-branch/Source

Merge r92210.

1:33 PM Changeset in webkit [92503] by cevans@google.com
  • 2 edits
    4 copies in branches/chromium/782

Merge 92413
BUG=91598
Review URL: http://codereview.chromium.org/7491067

1:29 PM Changeset in webkit [92502] by andersca@apple.com
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Add a Lion specific test for fast/repaint/canvas-putImageData.html

  • platform/mac-snowleopard/fast/repaint: Added.
  • platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from fast/repaint/canvas-putImageData-expected.txt.
  • platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
1:26 PM Changeset in webkit [92501] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 91781
BUG=82552
Review URL: http://codereview.chromium.org/7550046

1:20 PM Changeset in webkit [92500] by andersca@apple.com
  • 1 edit in trunk/Source/WebCore/WebCore.gypi

Actually commit the file.

1:19 PM Changeset in webkit [92499] by andersca@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix Chromium build.

  • WebCore.gypi:
1:03 PM Changeset in webkit [92498] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Inline allocation of function objects
https://bugs.webkit.org/show_bug.cgi?id=65779

Reviewed by Gavin Barraclough.

Inline allocation and initilisation of function objects
in generated code. This ended up being a 60-70% improvement
in function allocation performance. This improvement shows
up as a ~2% improvement in 32bit sunspider and V8, but is a
wash on 64-bit.

We currently don't inline the allocation of named function
expressions, as that requires being able to gc allocate a
variable object.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emitStoreCell):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):

  • jit/JITOpcodes32_64.cpp:

Removed duplicate implementation of op_new_func and op_new_func_exp

  • runtime/JSFunction.h:

(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):

12:55 PM Changeset in webkit [92497] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Tools

trac.js needs unittests
https://bugs.webkit.org/show_bug.cgi?id=65673

Reviewed by Dimitri Glazkov.

This tests also have somewhat large fixtures. I've trimmed the example
XML down a bunch while still hitting interesting cases in the parsing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
12:49 PM Changeset in webkit [92496] by andersca@apple.com
  • 24 edits
    20 copies
    1 add in trunk/LayoutTests

Add more Lion specific test results.

  • platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Copied from platform/mac/fast/text/capitalize-boundaries-expected.png.
  • platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.txt: Copied from platform/mac/fast/text/capitalize-boundaries-expected.txt.
  • platform/mac-snowleopard/fast/text/complex-text-opacity-expected.png: Copied from platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-snowleopard/fast/text/complex-text-opacity-expected.txt: Copied from platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-snowleopard/fast/text/international: Added.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
  • platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.png.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
  • platform/mac-snowleopard/fast/text/international/bold-bengali-expected.png: Copied from platform/mac/fast/text/international/bold-bengali-expected.png.
  • platform/mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Copied from platform/mac/fast/text/international/bold-bengali-expected.txt.
  • platform/mac-snowleopard/fast/text/international/khmer-selection-expected.png: Copied from platform/mac/fast/text/international/khmer-selection-expected.png.
  • platform/mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Copied from platform/mac/fast/text/international/khmer-selection-expected.txt.
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bold-bengali-expected.png:
  • platform/mac/fast/text/international/bold-bengali-expected.txt:
  • platform/mac/fast/text/international/khmer-selection-expected.png:
  • platform/mac/fast/text/international/khmer-selection-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
12:41 PM Changeset in webkit [92495] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two fast/text tests to the skipped list.

  • platform/mac-lion/Skipped:
12:24 PM Changeset in webkit [92494] by andersca@apple.com
  • 11 edits
    10 copies
    3 adds in trunk/LayoutTests

Add Lion specific test results for css1 and css2.1.

  • platform/mac-snowleopard/css1: Added.
  • platform/mac-snowleopard/css1/font_properties: Added.
  • platform/mac-snowleopard/css1/font_properties/font-expected.png: Copied from platform/mac/css1/font_properties/font-expected.png.
  • platform/mac-snowleopard/css1/font_properties/font-expected.txt: Copied from platform/mac/css1/font_properties/font-expected.txt.
  • platform/mac-snowleopard/css2.1: Added.
  • platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.png.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.txt.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.png.
  • platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.txt.
  • platform/mac/css1/font_properties/font-expected.png:
  • platform/mac/css1/font_properties/font-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/css2.1/t1508-c527-font-05-b-expected.png:
  • platform/mac/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/mac/css2.1/t1508-c527-font-10-c-expected.png:
  • platform/mac/css2.1/t1508-c527-font-10-c-expected.txt:
11:50 AM Changeset in webkit [92493] by abarth@webkit.org
  • 10 edits in trunk/Tools

Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
https://bugs.webkit.org/show_bug.cgi?id=65759

Reviewed by Dimitri Glazkov.

rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
architecture, is poorly tested, and has a bunch of quirks. This patch
rebuilds the core functionality of rebaseline-chromium-webkit-tests on
top of more modern infrastructure. In the process, we get more code
re-use and better testing.

Once we're satisfied with this new implementation, we can delete the
old implementation.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  • Scripts/webkitpy/common/net/web.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
11:44 AM Changeset in webkit [92492] by andersca@apple.com
  • 45 edits
    9 deletes in trunk

Remove PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=65729

Reviewed by Darin Adler.

Source/WebCore:

Remove plug-in halter and associated classes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h:
  • page/HaltablePlugin.h: Removed.
  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:
  • page/PluginHalter.cpp: Removed.
  • page/PluginHalter.h: Removed.
  • page/PluginHalterClient.h: Removed.
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

  • rendering/RenderWidget.h:

Source/WebKit:

Remove deleted files from Xcode project.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Remove plug-in halter and associated classes.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):

  • WebCoreSupport/WebPluginHalterClient.h: Removed.
  • WebCoreSupport/WebPluginHalterClient.mm: Removed.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/win:

Remove plug-in halter and associated classes.

  • Interfaces/IWebPluginHalterDelegate.idl: Removed.
  • Interfaces/IWebPreferencesPrivate.idl:
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebPluginHalterClient.cpp: Removed.
  • WebCoreSupport/WebPluginHalterClient.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::close):
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
(WebView::unused1):
(WebView::unused2):
(WebView::unused3):
(WebView::unused4):
(WebView::unused5):

  • WebView.h:

Source/WebKit/wx:

Don't include PluginHalterClient.h, it's been removed.

  • WebView.cpp:

Tools:

Remove call to set the allowed plug-in run time.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

11:23 AM Changeset in webkit [92491] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

[WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state
https://bugs.webkit.org/show_bug.cgi?id=63779

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent): Unrelated cleanup. Removed unneeded local variable.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates): Rearranged code so that the call to
setPaintBehavior is after the early exit. Also got rid of unneeded save/restore since
the function uses a graphics context that it then throws away.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Ditto.

11:18 AM Changeset in webkit [92490] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-534.51-branch/Source/WebCore

Merge r92035.

11:14 AM Changeset in webkit [92489] by Lucas Forschler
  • 3 edits in branches/safari-534.51-branch/Source/WebCore

Merge r92034.

11:04 AM Changeset in webkit [92488] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip those tests still failing on chromium due to incomplete
baseline caused by r92466.

  • platform/chromium/test_expectations.txt:
11:02 AM Changeset in webkit [92487] by jochen@chromium.org
  • 5 edits in trunk/Source

Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
10:58 AM Changeset in webkit [92486] by thakis@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92319 - Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7584008

10:56 AM Changeset in webkit [92485] by thakis@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 92316 - Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7582015

10:19 AM BuildingQtOnLinux edited by cavalcantii@gmail.com
Note about how to choose webkit2 as the build target. (diff)
10:13 AM Changeset in webkit [92484] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r92433): media/video-src-change.html fails
https://bugs.webkit.org/show_bug.cgi?id=65771

Reviewed by Dimitri Glazkov.

Give the listener as the second argument to removeEventListener.

  • media/video-src-change.html:
9:56 AM Changeset in webkit [92483] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

compositing/video/video-background-color.html test does not produce correct output
https://bugs.webkit.org/show_bug.cgi?id=55519

Unreviewed.

Chromium doesn't support video codecs that support alpha, so stop
running (and failing) a test that depends on codecs supporting alpha.

Patch by Ami Fischman <fischman@chromium.org> on 2011-08-05

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [92482] by senorblanco@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 92388 - Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700

Reviewed by James Robinson.

No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7582010

8:40 AM Changeset in webkit [92481] by Ademar Reis
  • 2 edits in trunk/Tools

Unreviewed build fix for Qt-Minimal buildbot

Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
is disabled.

Rubber-stamped by Holger Freyther.

  • QtTestBrowser/cookiejar.cpp:

(TestBrowserCookieJar::TestBrowserCookieJar):

8:08 AM BuildingQtOnLinux edited by cavalcantii@gmail.com
Adding a small remark about QT5 and QTDIR environment variable. (diff)
7:36 AM Changeset in webkit [92480] by yael.aharon@nokia.com
  • 6 edits
    6 adds in trunk

dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428

Reviewed by Darin Adler.

Source/WebCore:

Changed the directionality algorithm to evaluate the value of input elements and textarea elements when
they have the attribute dir-auto Set.
Also skip these elements when evaluating the directionality of their ancestors.

HTMLTextAreaElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

HTMLInputElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

Tests: fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html

fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
fast/dom/HTMLElement/attr-dir-auto-text-form-control.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality):

  • html/HTMLElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::subtreeHasChanged):

LayoutTests:

  • fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.
7:17 AM Changeset in webkit [92479] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-05
Reviewed by Andreas Kling.

Reverted commit r87797, http://trac.webkit.org/changeset/87797, because it
causes the regression reported under bug# 63582.

[Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.
https://bugs.webkit.org/show_bug.cgi?id=63582

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):

7:03 AM Changeset in webkit [92478] by Ademar Reis
  • 5 edits
    2 adds in trunk/Tools

[Qt] QtTestBrowser: Add support for saving cookies on disk
https://bugs.webkit.org/show_bug.cgi?id=65328

Simple cookiejar that saves cookies on disk.

Added menu options to clear cookies (Edit->Clear cookies) and
disable disk cookies (Settings->[ ]Save Cookies on Disk).

Option -no-disk-cookies is also available.

Reviewed by Andreas Kling.

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/cookiejar.cpp: Added.
  • QtTestBrowser/cookiejar.h: Added.
  • QtTestBrowser/launcherwindow.cpp:
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/main.cpp:
6:45 AM Changeset in webkit [92477] by keishi@webkit.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

  • WebCore.exp.in: Added ZN7WebCore12ColorChooser7chooserEv and

ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE

  • WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::closeColorChooserIfClientIsInDocument): Close color chooser if element is in
document. Called when the page navigates away.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.

  • html/ColorInputType.h:
  • html/FileInputType.cpp:
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::detach): Calls InputType::detach

  • html/InputType.cpp:

(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.

  • html/InputType.h:
  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::openColorChooser): Added.
(WebCore::EmptyChromeClient::closeColorChooser): Added.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Added.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Close color chooser when
navigating away from the page.

  • page/Chrome.cpp:

(WebCore::Chrome::openColorChooser): Added. Opens the color chooser.
(WebCore::Chrome::closeColorChooser): Added. Tries to close the color chooser. Might not close if the
listener of the color chooser is another part of the browser or another render process.
(WebCore::Chrome::setSelectedColorInColorChooser): Added. Sets the selected color in the color chooser.
Again, might not be executed if the listener of the color chooser is another part of the browser or another render process.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ColorChooser.cpp: Added.

(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::closeColorChooserIfClientIsInDocument): Close the color chooser if the client is
inside the document.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.

  • platform/ColorChooser.h: Added.

(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

6:16 AM Changeset in webkit [92476] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: check that detaching frame has been attached before removing it from the console selector
https://bugs.webkit.org/show_bug.cgi?id=65686

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager.prototype._frameDetached):

5:18 AM Changeset in webkit [92475] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
4:39 AM Changeset in webkit [92474] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364

Unreviewed: unskipping tests now that the test was fixed.

  • platform/qt/Skipped:
3:16 AM Changeset in webkit [92473] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebKit/efl

[EFL] Move API documentation of ewk files to the headers
https://bugs.webkit.org/show_bug.cgi?id=65373

There are two arguments for this:

  1. Developers using webkit-efl from packages probably won't have the C/CPP files with them and the doxygen documentation can be generated from the headers without the need for the whole source files.
  2. It will be consistent with structures descriptions.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-05
Reviewed by Kent Tamura.

  • ewk/ewk_auth.cpp:
  • ewk/ewk_auth.h:
  • ewk/ewk_contextmenu.cpp:
  • ewk/ewk_contextmenu.h:
  • ewk/ewk_cookies.cpp:
  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_history.cpp:
  • ewk/ewk_history.h:
  • ewk/ewk_main.cpp:
  • ewk/ewk_main.h:
  • ewk/ewk_network.cpp:
  • ewk/ewk_network.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
  • ewk/ewk_window_features.cpp:
  • ewk/ewk_window_features.h:
2:40 AM Changeset in webkit [92472] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip 2 crashy tests on Qt SnowLeopard Intel Release bot to make a green world,

  • platform/qt-mac/Skipped:
2:37 AM Changeset in webkit [92471] by yurys@chromium.org
  • 8 edits in trunk

Web Inspector: constrain maximum depth for returnByValue objects
https://bugs.webkit.org/show_bug.cgi?id=65761

Source/WebCore:

Set maximum depth to 20 for objects returned by value as a result of evaluations.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptValue.cpp:

(WebCore::jsToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.cpp:

(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

  • inspector/InspectorValues.h:

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/protocol/runtime-agent-expected.txt:
  • inspector/protocol/runtime-agent.html:
2:30 AM Changeset in webkit [92470] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Add http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
to Skiplist because it makes ARMv5 Linux Qt Release weepy.

  • platform/qt-arm/Skipped:
1:57 AM Changeset in webkit [92469] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from appcache IDL files
https://bugs.webkit.org/show_bug.cgi?id=65752

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • loader/appcache/DOMApplicationCache.idl:
1:42 AM Changeset in webkit [92468] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Stop using free-lists for database/object store/index ids.
https://bugs.webkit.org/show_bug.cgi?id=65678

Reviewed by Tony Chang.

Don't use free-lists for database/object store/index ids,
just assign increasing numbers.

It turns out that deleting an object store and creating a new one with
the same id would cause the delete markers from the old object store to
slow down lookups into the new one. Therefore we should generate
a new id every time. Running out of ids (64 bits for databases and
object stores, 32 bits for indices) is not realistic.

Also make functions that generate new ids report errors, and make the
callers of those functions check the return values.

We must still delete free-lists when deleting an object store, and we
must keep the code for encoding/decoding/comparison of free-list keys
since users might have them in their databases.

This is just a performance optimization, so no new tests.

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):

1:37 AM Changeset in webkit [92467] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Ossyize fast/forms/enter-clicks-buttons.html because
it makes Qt SnowLeopard Intel Release bot bleeding after r92375.

  • platform/qt-mac/Skipped:
1:33 AM Changeset in webkit [92466] by commit-queue@webkit.org
  • 48 edits in trunk/LayoutTests

[chromium] Rebaseline following r92255.
https://bugs.webkit.org/show_bug.cgi?id=65736

Patch by David Reveman <reveman@chromium.org> on 2011-08-05
Reviewed by James Robinson.

  • platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
  • platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [92465] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
1:24 AM Changeset in webkit [92464] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
1:21 AM Changeset in webkit [92463] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: change an instance of isImportRule() that was overlooked in commit 92448.

No new tests. (No functional change)

  • xml/XSLImportRule.h:

(WebCore::XSLImportRule::isImportRule):

1:19 AM Changeset in webkit [92462] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from remaining SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65751

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • svg/SVGElementInstance.idl:
12:51 AM Changeset in webkit [92461] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: do not delay scroll event handling - scroll is already async.
https://bugs.webkit.org/show_bug.cgi?id=65693

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-05
Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._syncScroll):

12:48 AM Changeset in webkit [92460] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
12:45 AM Changeset in webkit [92459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from web audio API
https://bugs.webkit.org/show_bug.cgi?id=65750

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • webaudio/AudioBufferSourceNode.idl:
12:43 AM Changeset in webkit [92458] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Web Workers
https://bugs.webkit.org/show_bug.cgi?id=65746

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
12:34 AM Changeset in webkit [92457] by bashi@chromium.org
  • 17 edits
    6 adds in trunk

Parsing CSS3 font-feature-settings property
https://bugs.webkit.org/show_bug.cgi?id=63618

Source/WebCore:

Introduces CSS3 font-feature-settings property as -webkit-font-feature-settings. This change only contains parsing part. Parsed information are stored in FontDescription class.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

Test: css3/font-feature-settings-parsing.html

  • CMakeLists.txt: Added FontFeatureValue.{h,cpp} and FontFeatureSettings.{h,cpp}.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added CSSPropertyWebkitFontFeatureSettings.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added parsing code for -webkit-font-feature-settings.
(WebCore::CSSParser::parseFontFeatureTag): Added.
(WebCore::CSSParser::parseFontFeatureSettings): Added.

  • css/CSSParser.h: Added parseFontFeatureSettings().
  • css/CSSPropertyNames.in: Added -webkit-font-feature-settings.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Modified a compile assert to follow adding -webkit-font-feature-settings.
(WebCore::CSSStyleSelector::applyProperty): Added a case clause for CSSPropertyWebkitFontFeatureSettings.

  • css/CSSValue.h:

(WebCore::CSSValue::isFontFeatureValue): Added.

  • css/CSSValueKeywords.in: Added 'on' and 'off' keywords.
  • css/FontFeatureValue.cpp: Added.

(WebCore::FontFeatureValue::FontFeatureValue):
(WebCore::FontFeatureValue::value):
(WebCore::FontFeatureValue::cssText):

  • css/FontFeatureValue.h: Added.

(WebCore::FontFeatureValue::create):
(WebCore::FontFeatureValue::tag):
(WebCore::FontFeatureValue::isFontFeatureValue):

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::makeNormalFeatureSettings): Added.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Added m_featureSettings member variable.
(WebCore::FontDescription::featureSettings): Added.
(WebCore::FontDescription::setFeatureSettings): Added.
(WebCore::FontDescription::operator==): Modified to take into account m_featureSettings

  • platform/graphics/FontFeatureSettings.cpp: Added.

(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator=):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):

  • platform/graphics/FontFeatureSettings.h: Added.

(WebCore::FontFeature::tag):
(WebCore::FontFeature::value):
(WebCore::FontFeatureSettings::create):
(WebCore::FontFeatureSettings::append):
(WebCore::FontFeatureSettings::size):
(WebCore::FontFeatureSettings::operator[]):
(WebCore::FontFeatureSettings::at):

LayoutTests:

Add parsing test case for -webkit-font-feature-settings property.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

  • css3/font-feature-settings-parsing-expected.txt: Added.
  • css3/font-feature-settings-parsing.html: Added.
12:32 AM Changeset in webkit [92456] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from websockets
https://bugs.webkit.org/show_bug.cgi?id=65749

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • websockets/WebSocket.idl:
12:30 AM Changeset in webkit [92455] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to heal media/video-can-play-type.html and media/video-src-change.html.

  • html/HTMLMediaElement.idl:
12:18 AM Changeset in webkit [92454] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from notifications IDL files
https://bugs.webkit.org/show_bug.cgi?id=65747

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • notifications/Notification.idl:
  • notifications/NotificationCenter.idl:
12:00 AM Changeset in webkit [92453] by commit-queue@webkit.org
  • 4 edits
    4 deletes in trunk

Unreviewed, rolling out r92439.
http://trac.webkit.org/changeset/92439
https://bugs.webkit.org/show_bug.cgi?id=65753

Caused 9 tests to fail on Qt (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::implicitOpen):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

  • loader/document-destruction-within-unload-expected.txt: Removed.
  • loader/document-destruction-within-unload.html: Removed.
  • loader/resources/document-destruction-within-unload-iframe.html: Removed.
  • loader/resources/document-destruction-within-unload.svg: Removed.

Aug 4, 2011:

11:58 PM Changeset in webkit [92452] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update after r92341.

  • platform/chromium/test_expectations.txt:
11:26 PM Changeset in webkit [92451] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Use RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=65647

Reviewed by Hajime Morita.

Encapsulated the use of getInlineBoxAndOffset in Editor.cpp and AccessibilityObject.cpp by RenderedPosition.

Also added rendererFromPosition that returns the renderer of deprecatedNode but using a proper Position interface.

  • accessibility/AccessibilityObject.cpp:

(WebCore::updateAXLineStartForVisiblePosition):

  • editing/Editor.cpp:

(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::rendererFromPosition):
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::absoluteRect):

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):

11:14 PM Changeset in webkit [92450] by hayato@chromium.org
  • 8 edits in trunk/Source/WebCore

Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
https://bugs.webkit.org/show_bug.cgi?id=65613

Reviewed by Dimitri Glazkov.

No changes to functionality so no new tests.

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):

  • dom/EventDispatcher.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchScopedEventDispatchMediator):

  • dom/Node.h:
  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEventDispatchMediator):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):

  • dom/ScopedEventQueue.h:
11:05 PM Changeset in webkit [92449] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

11:04 PM Changeset in webkit [92448] by rolandsteiner@chromium.org
  • 12 edits in trunk/Source/WebCore

Improve const-correctness in CSS code: type information methods
https://bugs.webkit.org/show_bug.cgi?id=65506

Reviewed by Simon Fraser.

Make "is...()" functions (e.g., "isStyleRule()") const.
Also, change CSSRule's type() function to return CSSRuleType.

No new tests. (no change in semantics)

  • css/CSSCharsetRule.h:

(WebCore::CSSCharsetRule::isCharsetRule):
(WebCore::CSSCharsetRule::type):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::isFontFaceRule):
(WebCore::CSSFontFaceRule::type):

  • css/CSSImportRule.h:

(WebCore::CSSImportRule::isImportRule):
(WebCore::CSSImportRule::type):

  • css/CSSMediaRule.h:

(WebCore::CSSMediaRule::isMediaRule):
(WebCore::CSSMediaRule::type):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::isPageRule):
(WebCore::CSSPageRule::type):

  • css/CSSRule.h:

(WebCore::CSSRule::isRule):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::isStyleRule):
(WebCore::CSSStyleRule::type):

  • css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::type):

  • css/StyleBase.h:

(WebCore::StyleBase::isCharsetRule):
(WebCore::StyleBase::isFontFaceRule):
(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isKeyframeRule):
(WebCore::StyleBase::isKeyframesRule):
(WebCore::StyleBase::isMediaRule):
(WebCore::StyleBase::isPageRule):
(WebCore::StyleBase::isRule):
(WebCore::StyleBase::isStyleRule):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::isKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::type):

  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::isKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::type):

10:42 PM Changeset in webkit [92447] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from plugin IDL files
https://bugs.webkit.org/show_bug.cgi?id=65745

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
10:37 PM Changeset in webkit [92446] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
https://bugs.webkit.org/show_bug.cgi?id=65740

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • xml/DOMParser.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:
10:27 PM Changeset in webkit [92445] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04

  • DEPS:
9:51 PM Changeset in webkit [92444] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

Add a performance test for floating elements layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=65741

The test creating lots of small floats and randomly changes
the width of one element at a time. It measures how often it can do that.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-04
Reviewed by Adam Barth.

  • Layout/floats.html: Added.
8:50 PM Changeset in webkit [92443] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • html/canvas/CanvasGradient.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
8:26 PM Changeset in webkit [92442] by abarth@webkit.org
  • 2 edits
    1 add in trunk/Tools

model.js needs some unit testing
https://bugs.webkit.org/show_bug.cgi?id=65730

Reviewed by Dimitri Glazkov.

These tests do not cover all the functions exported by the model
module. We'll need to add the remaining ones in the future.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
8:25 PM Changeset in webkit [92441] by morrita@google.com
  • 11 edits
    1 add in trunk/Source/WebCore

Reviewed by Ryosuke Niwa.

DocumentMarker: Type specific details should be separately held by other object.
https://bugs.webkit.org/show_bug.cgi?id=59855

  • Introduced DocumentMarkerDetails abstract class and two its subclasses DocumentMarkerDescription and DocumentMarkerActiveMatch,
  • Replacing DocumentMarker::m_description and DocumentMarker::m_activeMatch with these new details classes.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DocumentMarker.cpp: Added.

(WebCore::emptyDescription):
(WebCore::DocumentMarkerDetails::DocumentMarkerDetails):
(WebCore::DocumentMarkerDetails::~DocumentMarkerDetails):
(WebCore::DocumentMarkerDescription::description):
(WebCore::DocumentMarkerDescription::isDescription):
(WebCore::DocumentMarkerDescription::DocumentMarkerDescription):
(WebCore::DocumentMarkerDescription::createUnlessEmpty):
(WebCore::DocumentMarkerDescription::compatibleTypes):
(WebCore::DocumentMarkerTextMatch::activeMatch):
(WebCore::DocumentMarkerTextMatch::isTextMatch):
(WebCore::DocumentMarkerTextMatch::DocumentMarkerTextMatch):
(WebCore::DocumentMarkerTextMatch::instanceFor):
(WebCore::DocumentMarkerTextMatch::compatibleTypes):
(WebCore::DocumentMarker::DocumentMarker):
(WebCore::DocumentMarker::shiftOffsets):
(WebCore::DocumentMarker::setActiveMatch):
(WebCore::DocumentMarker::description):
(WebCore::DocumentMarker::activeMatch):

  • dom/DocumentMarker.h:

(WebCore::DocumentMarker::details):
(WebCore::DocumentMarker::clearDetails):
(WebCore::DocumentMarkerDetails::isDescription):
(WebCore::DocumentMarkerDetails::isTextMatch):
(WebCore::DocumentMarkerDetails::isAllowedFor):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

6:45 PM Changeset in webkit [92440] by abarth@webkit.org
  • 2 edits in trunk/Tools

Another speculative fix for the "svn revision on Windows" problem.

  • Scripts/webkitpy/common/checkout/scm/git.py:
6:32 PM Changeset in webkit [92439] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Bad interaction between document destruction and unload events
https://bugs.webkit.org/show_bug.cgi?id=64741

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

Source/WebCore:

Three different errors triggered by this test case. The case to
consider is a subdocument with an onunload on an element, that
destroys the parent document during the onunload. One fix was a
lifetime issue fixed by a protecting RefPtr, and another was an
additional cancel of event triggers. The main fix was that during the
transition to commited state, the documentLoader is being replaced by
the provisionalDocumentLoader. But, because during firing events in
the subdocument the parent is destroyed, that subevent caused the
provisionalDocumentLoader to be detached from its frame. By marking
the page as being in committed state before the parent documentLoader
is set, this is avoided.

Test: loader/document-destruction-within-unload.html

  • dom/Document.cpp:

(WebCore::Document::implicitOpen):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

  • loader/document-destruction-within-unload-expected.txt: Added.
  • loader/document-destruction-within-unload.html: Added.
  • loader/resources/document-destruction-within-unload-iframe.html: Added.
  • loader/resources/document-destruction-within-unload.svg: Added.
6:07 PM Changeset in webkit [92438] by Simon Fraser
  • 24 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <Simon Fraser>

Add code to determine whether a Range in inside fixed position content
https://bugs.webkit.org/show_bug.cgi?id=65720

Reviewed by Sam Weinig.

Propagate the 'wasFixed' flag out from various methods that
are used when computing the collection of rects or quads
for a range. Use the flag in Range to computer whether
the Range is entirely within, partially within, or outside
of fixed-position content.

  • WebCore.exp.in:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect):
  • dom/Range.cpp: (WebCore::Range::textRects): (WebCore::Range::textQuads):
  • dom/Range.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteQuads):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteQuads):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteQuads):
  • rendering/RenderInline.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteQuads):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuads): (WebCore::RenderText::absoluteQuadsForRange):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteQuads):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteQuads):
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteQuads):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteQuads):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteQuads):
  • rendering/svg/RenderSVGText.h:
5:51 PM Changeset in webkit [92437] by levin@chromium.org
  • 4 edits in trunk/Source

CStringBuffer should have thread safety checks turned on.
https://bugs.webkit.org/show_bug.cgi?id=58093

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

  • wtf/text/CString.h:

(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
turned this off for Chromium.

Source/WebKit/chromium:

  • DEPS: Roll far enough to pick up the latest WebKit::initialize

fix for Linux.

5:39 PM Changeset in webkit [92436] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65717

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • dom/Document.idl:
5:26 PM Changeset in webkit [92435] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <Simon Fraser>

Fix release build failure with last commit.

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
5:19 PM Changeset in webkit [92434] by Simon Fraser
  • 21 edits in trunk/Source/WebCore

2011-08-04 Simon Fraser <Simon Fraser>

Add code to determine whether a Range in inside fixed position content
https://bugs.webkit.org/show_bug.cgi?id=65720

Reviewed by Dan Bernstein.

Add an out param for various coordinate mapping functions
that tells us whether the point or rectangle being
mapped is inside fixed-position content.

This brings back some of the changes from r89754.

No behavior changes, so no tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad):
  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer):
  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer):
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer):
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer):
  • rendering/svg/SVGRenderSupport.h:
5:03 PM Changeset in webkit [92433] by commit-queue@webkit.org
  • 25 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65715

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItems.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/MediaStream.idl:
  • dom/MediaStreamList.idl:
  • dom/MediaStreamTrackList.idl:
  • dom/MessagePort.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/Range.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/StringCallback.idl:
  • dom/Text.idl:
  • dom/TouchList.idl:
4:58 PM Changeset in webkit [92432] by mrowe@apple.com
  • 45 edits in trunk

Future-proof Xcode configuration settings.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

Source/JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/CompilerVersion.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKit2.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/CompilerVersion.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4:56 PM Changeset in webkit [92431] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

A few purely stylistic modifications to visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=65723

Patch by Van Lam <vanlam@google.com> on 2011-08-04
Reviewed by Ryosuke Niwa.

Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox
to positionIsInBoxButNotOnBoundary (to avoid confusion with
positionIsInBox, which is just a getInlineBoxAndOffset check).
Removed use of invalidOffset as an error value in greatestOffsetUnder
and smallestOffsetAbove since semantically it should only be used to
check if it makes sense to compare offsets in a single box.

  • editing/visible_units.cpp:

(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):
(WebCore::positionIsInBoxButNotOnBoundary):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):

4:46 PM Changeset in webkit [92430] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:
4:25 PM Changeset in webkit [92429] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fancier debug logging.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
4:20 PM Changeset in webkit [92428] by mitz@apple.com
  • 2 edits in trunk/Websites/webkit.org

Fixed a typo.

  • coding/contributing.html:
4:17 PM Changeset in webkit [92427] by tkent@chromium.org
  • 15 edits
    7 copies
    6 moves
    8 adds
    3 deletes in trunk/LayoutTests

Move <input type=week> tests to fast/forms/week/
https://bugs.webkit.org/show_bug.cgi?id=65676

Reviewed by Tony Chang.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-week-expected.txt: Removed.
  • fast/forms/ValidityState-typeMismatch-week.html: Removed.
  • fast/forms/date-input-visible-strings-expected.txt:
  • fast/forms/date-input-visible-strings.html:
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/input-type-change3-expected.txt:
  • fast/forms/input-valueasdate-week-expected.txt: Removed.
  • fast/forms/input-valueasdate-week.html: Removed.
  • fast/forms/input-valueasnumber-week-expected.txt: Removed.
  • fast/forms/input-valueasnumber-week.html: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js:
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/input-type-change3.js:
  • fast/forms/script-tests/input-valueasdate-week.js: Removed.
  • fast/forms/script-tests/input-valueasnumber-week.js: Removed.
  • fast/forms/week: Added.
  • fast/forms/week/ValidityState-rangeOverflow-week-expected.txt: Added.
  • fast/forms/week/ValidityState-rangeOverflow-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
  • fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt: Added.
  • fast/forms/week/ValidityState-rangeUnderflow-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
  • fast/forms/week/ValidityState-stepMismatch-week-expected.txt: Added.
  • fast/forms/week/ValidityState-stepMismatch-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
  • fast/forms/week/ValidityState-typeMismatch-week-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-week-expected.txt.
  • fast/forms/week/ValidityState-typeMismatch-week.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-week.js.
  • fast/forms/week/input-valueasdate-week-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-week-expected.txt.
  • fast/forms/week/input-valueasdate-week.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-week.js.
  • fast/forms/week/input-valueasnumber-week-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-week-expected.txt.
  • fast/forms/week/input-valueasnumber-week.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-week.js.
  • fast/forms/week/week-input-type-expected.txt: Added.
  • fast/forms/week/week-input-type.html: Copied from LayoutTests/fast/forms/script-tests/input-type-change3.js.
  • fast/forms/week/week-input-visible-string-expected.txt: Added.
  • fast/forms/week/week-input-visible-string.html: Copied from LayoutTests/fast/forms/date-input-visible-strings.html.
  • fast/forms/week/week-stepup-stepdown-expected.txt: Added.
  • fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/week/week-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
  • fast/forms/week/week-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
3:54 PM Changeset in webkit [92426] by timothy_horton@apple.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Move Tim Horton to committers section of committers.py

No review necessary.

3:53 PM Changeset in webkit [92425] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Reduce memory consumption of HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=65688

Adds a cache for HB_FaceRec to eliminate multiple allocation for the same font.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-04
Reviewed by Tony Chang.

No new tests since there is no behavior change.

  • platform/graphics/chromium/HarfbuzzSkia.cpp:

(WebCore::getCachedHarfbuzzFace): Added.
(WebCore::releaseCachedHarfbuzzFace): Ditto.
(WebCore::HarfbuzzFace::HarfbuzzFace): Calls getCachedHarfbuzzFace() instead of allocating HB_FaceRec.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Calls releaseCachedHarfbuzzFace() to release the onership of the cache.

  • platform/graphics/chromium/HarfbuzzSkia.h:
3:51 PM Changeset in webkit [92424] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r92415.
http://trac.webkit.org/changeset/92415
https://bugs.webkit.org/show_bug.cgi?id=65728

Causes many DEBUG crashes (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-04

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
3:46 PM Changeset in webkit [92423] by timothy_horton@apple.com
  • 39 edits in trunk

Reviewed by Nikolas Zimmermann.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
<rdar://problem/9727074>

Make use of SVGLength::construct when parsing Length attributes; we will
now propagate errors which occur while parsing SVGLength attributes to the
Web Inspector console.

3:42 PM Changeset in webkit [92422] by commit-queue@webkit.org
  • 39 edits in trunk

Unreviewed, rolling out r92419.
http://trac.webkit.org/changeset/92419
https://bugs.webkit.org/show_bug.cgi?id=65726

"committed partially to branch" (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-04

Source/WebCore:

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::parseMappedAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::parseMappedAttribute):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::parseMappedAttribute):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::parseMappedAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::parseMappedAttribute):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::parseMappedAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseMappedAttribute):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::parseMappedAttribute):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::parseMappedAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::parseMappedAttribute):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::parseMappedAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseMappedAttribute):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::parseMappedAttribute):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::parseMappedAttribute):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseMappedAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseMappedAttribute):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::parseMappedAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::parseMappedAttribute):

LayoutTests:

  • platform/chromium-win/svg/hixie/error/013-expected.txt:
  • platform/gtk/svg/hixie/error/001-expected.txt:
  • platform/gtk/svg/hixie/error/007-expected.txt:
  • platform/gtk/svg/hixie/error/013-expected.txt:
  • platform/gtk/svg/hixie/error/015-expected.txt:
  • platform/mac/svg/hixie/error/001-expected.txt:
  • platform/mac/svg/hixie/error/007-expected.txt:
  • platform/mac/svg/hixie/error/013-expected.txt:
  • platform/mac/svg/hixie/error/015-expected.txt:
  • platform/qt/svg/hixie/error/001-expected.txt:
  • platform/qt/svg/hixie/error/007-expected.txt:
  • platform/qt/svg/hixie/error/013-expected.txt:
  • platform/qt/svg/hixie/error/015-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/svg-parse-overflow-1-expected.txt:
  • svg/custom/svg-parse-overflow-2-expected.txt:
  • svg/custom/svg-parse-overflow-3-expected.txt:
  • svg/custom/svg-parse-overflow-4-expected.txt:
  • svg/custom/svg-parse-overflow-5-expected.txt:
3:41 PM Changeset in webkit [92421] by thakis@chromium.org
  • 2 edits in trunk/Websites/webkit.org

Update the contributors page to recommend webkit-patch instead of many manual steps
https://bugs.webkit.org/show_bug.cgi?id=65714

Reviewed by Adam Barth.

asvitkine followed the contributing instructions for his first patch, and got
the ChangeLog entry wrong: https://bugs.webkit.org/show_bug.cgi?id=65707
webkit-patch prevents errors like this and more.

  • coding/contributing.html:
3:39 PM Changeset in webkit [92420] by levin@chromium.org
  • 2 edits in trunk/Tools

[chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
https://bugs.webkit.org/show_bug.cgi?id=65685

Reviewed by Dmitry Titov.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::WebViewHost): Intialize WTF threading before
anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
but in some cases code may use WTF without creating WebViewImpl and
WTF code functionality may call WTF::currentThread, which requires
this initialization now.

3:15 PM Changeset in webkit [92419] by timothy_horton@apple.com
  • 39 edits in /

Reviewed by Nikolas Zimmermann.

Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
<rdar://problem/9727074>

Make use of SVGLength::construct when parsing Length attributes; we will
now propagate errors which occur while parsing SVGLength attributes to the
Web Inspector console.

3:03 PM Changeset in webkit [92418] by abarth@webkit.org
  • 3 edits in trunk/Tools

An educated guess at causing the Windows bots on build.webkit.org to
find the SVN revision number.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
3:00 PM Changeset in webkit [92417] by fsamuel@chromium.org
  • 5 edits
    3 adds in trunk

Source/WebCore: Background Does Not Scale Correctly with Page
https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

Test: fast/repaint/background-scaling.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):

  • rendering/RenderView.h:

LayoutTests: Background Does Not Scale Correctly with Page

Scaling is applied twice to the background (the paint area is doubly scaled).
This patch fixes this issue by passing the unscaled document rect to paintFillLayers
in paintRootBoxFillLayers.

https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

  • fast/repaint/background-scaling-expected.png: Added.
  • fast/repaint/background-scaling-expected.txt: Added.
  • fast/repaint/background-scaling.html: Added.
2:50 PM Changeset in webkit [92416] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed.

Skipping tests until rebaseline.

  • platform/qt/Skipped:
2:50 PM Changeset in webkit [92415] by jochen@chromium.org
  • 5 edits in trunk/Source

Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

  • platform/network/chromium/ResourceRequest.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

  • public/WebURLRequest.h:
2:40 PM Changeset in webkit [92414] by jeffm@apple.com
  • 6 edits in trunk/Source/WebKit/win

Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718

Reviewed by Adam Roben.

  • Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
  • WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.

  • WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.

2:37 PM Changeset in webkit [92413] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Fix integer overflow in custom bindings for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=65646

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-08-04
Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/uniform-array-length-overflow.html

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toVector): Don't crash if allocation fails.

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

LayoutTests:

  • fast/canvas/webgl/resources/floatArrayUniformShader.vert: Added.
  • fast/canvas/webgl/resources/intArrayUniformShader2.vert: Added.
  • fast/canvas/webgl/uniform-array-length-overflow-expected.txt: Added.
  • fast/canvas/webgl/uniform-array-length-overflow.html: Added.
2:29 PM Changeset in webkit [92412] by Lucas Forschler
  • 4 edits in tags/Safari-534.49.1/Source

Merge r90705.

2:13 PM Changeset in webkit [92411] by Lucas Forschler
  • 2 edits in tags/Safari-534.49.1/Source/WebCore

Merge r89214.

2:12 PM Changeset in webkit [92410] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Implement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=65704
<rdar://problem/9877734>

Reviewed by Oliver Hunt.

Implement support for client side certificate authentication in the CFNetwork based loader.

  • platform/network/cf/AuthenticationCF.cpp:

(WebCore::createCF):
(WebCore::core): Also fix leak of password string.

2:11 PM Changeset in webkit [92409] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Refine some test expectations to account for flakiness.

  • platform/chromium/test_expectations.txt:
2:07 PM Changeset in webkit [92408] by crogers@google.com
  • 6 edits in trunk/Source/WebCore

Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):

  • webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::setFftSize):

1:38 PM Changeset in webkit [92407] by abarth@webkit.org
  • 2 edits in trunk/Tools

More logging to help debug the "no SVN rev on Chromium Windows bots"
bug. My current theory is that we're trying to detect the SCM system
in the wrong directory.

  • Scripts/webkitpy/layout_tests/port/base.py:
1:14 PM Changeset in webkit [92406] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_bug.cgi?id=65712
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.

Reviewed by Darin Adler.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a

whole bunch of stuff that might need to check it.

1:09 PM Changeset in webkit [92405] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Make fast/css/import-and-insert-rule-no-update.html less flaky
https://bugs.webkit.org/show_bug.cgi?id=65713

Reviewed by Dan Bernstein.

Wait until the @imported style sheet has finished loading before running the test.

  • fast/css/import-and-insert-rule-no-update.html:
1:06 PM Changeset in webkit [92404] by jeffm@apple.com
  • 8 edits in trunk/Source/WebCore

Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9894105>

First cut at implementation in MediaPlayerPrivateAVFoundationCF.cpp/.h, based on
work by Eric Carlson. Note that use of AVFoundation is determined at runtime, and
defaults to off.

Reviewed by Darin Adler.

No new tests, uses existing media tests.

  • config.h: Turn on WTF_USE_AVFOUNDATION on Windows if AVFoundationCF is available.


  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationCF on Windows.

  • platform/graphics/MediaPlayer.h: Add support for an AVCFPlayer.


  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Workaround an AVCF limitation that prevents an AVCFPlayer from being created without an AVCFItem.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Added support for ContentsNeedsDisplay notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::contentsNeedsDisplay): Added support for ContentsNeedsDisplay notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added implementation.

(WebCore::AVFWrapper::caVideoLayer):
(WebCore::AVFWrapper::videoLayerWrapper):
(WebCore::AVFWrapper::videoLayer):
(WebCore::AVFWrapper::avPlayer):
(WebCore::AVFWrapper::avAsset):
(WebCore::AVFWrapper::avPlayerItem):
(WebCore::AVFWrapper::timeObserver):
(WebCore::AVFWrapper::imageGenerator):
(WebCore::AVFWrapper::dispatchQueue):
(WebCore::LayerClient::LayerClient):
(WebCore::LayerClient::~LayerClient):
(WebCore::LayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::LayerClient::platformCALayerAnimationStarted):
(WebCore::LayerClient::platformCALayerContentsOrientation):
(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerShowDebugBorders):
(WebCore::LayerClient::platformCALayerShowRepaintCounter):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
(WebCore::LayerClient::platformCALayerContentsOpaque):
(WebCore::LayerClient::platformCALayerDrawsContent):
(WebCore::LayerClient::platformCALayerLayerDidDisplay):
(WebCore::boolString):
(WebCore::metadataKeyNames):
(WebCore::CMTimeRangeStartKey):
(WebCore::CMTimeRangeDurationKey):
(WebCore::CACFContextNeedsFlushNotification):
(WebCore::videoLayer):
(WebCore::avPlayer):
(WebCore::avAsset):
(WebCore::avPlayerItem):
(WebCore::imageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationCF::create):
(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationCF::MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::~MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationCF::checkPlayability):
(WebCore::MediaPlayerPrivateAVFoundationCF::beginLoadingMetadata):
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMedia):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationCF::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::setVolume):
(WebCore::MediaPlayerPrivateAVFoundationCF::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::rate):
(WebCore::timeRangeIsValidAndNotEmpty):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationCF::paint):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes):
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationCF::mediaTimeForTimeValue):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::contentsNeedsDisplay):
(WebCore::AVFWrapper::AVFWrapper):
(WebCore::AVFWrapper::~AVFWrapper):
(WebCore::AVFWrapper::scheduleDisconnectAndDelete):
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper):
(WebCore::AVFWrapper::deleteAVFWrapper):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::periodicTimeObserverCallback):
(WebCore::AVFWrapper::notificationCallback):
(WebCore::AVFWrapper::loadPlayableCompletionCallback):
(WebCore::AVFWrapper::checkPlayability):
(WebCore::AVFWrapper::loadMetadataCompletionCallback):
(WebCore::AVFWrapper::beginLoadingMetadata):
(WebCore::AVFWrapper::seekCompletedCallback):
(WebCore::AVFWrapper::seekToTime):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::destroyVideoLayer):
(WebCore::AVFWrapper::setVideoLayerNeedsCommit):
(WebCore::AVFWrapper::setVideoLayerHidden):
(WebCore::AVFWrapper::createImageGenerator):
(WebCore::AVFWrapper::destroyImageGenerator):
(WebCore::AVFWrapper::createImageForTimeInRect):
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added implementation.
1:04 PM Changeset in webkit [92403] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Speed up webkit-patch optimize-expectations significantly by not collecting test files.
https://bugs.webkit.org/show_bug.cgi?id=65697

I neglected to realize that collecting test names is not necessary for this operation.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
12:42 PM Changeset in webkit [92402] by Lucas Forschler
  • 6 edits in tags/Safari-534.49.1/Source

Merge r92231.

12:35 PM Changeset in webkit [92401] by Lucas Forschler
  • 5 edits in tags/Safari-534.49.1/Source

Versioning.

12:33 PM Changeset in webkit [92400] by Lucas Forschler
  • 1 copy in tags/Safari-534.49.1

New tag.

12:23 PM Changeset in webkit [92399] by jochen@chromium.org
  • 15 edits in trunk/Source

Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=48483

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/chromium/ResourceRequest.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

  • platform/network/chromium/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::targetType):
(WebCore::ResourceRequest::setTargetType):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:

(WebCore::WorkerScriptLoader::create):
(WebCore::WorkerScriptLoader::setTargetType):

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):

12:21 PM Changeset in webkit [92398] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCE build after r92308.

  • config.h: Don't try to include WebCoreHeaderDetection.h for WinCE.
12:20 PM Changeset in webkit [92397] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add more failing tests to the skipped list.

  • platform/mac-lion/Skipped:
12:19 PM Changeset in webkit [92396] by abarth@webkit.org
  • 3 edits in trunk/Tools

checkout_unittest.js should have better coverage of checkout.js
https://bugs.webkit.org/show_bug.cgi?id=65671

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
    • Remove unused functions.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
    • Test remaining public functions in the checkout module.
12:11 PM Changeset in webkit [92395] by Lucas Forschler
  • 5 edits in branches/safari-534.51-branch/Source

Versioning.

12:09 PM Changeset in webkit [92394] by Lucas Forschler
  • 1 copy in tags/Safari-534.51.6

New tag.

11:50 AM Maintenance and architecture list edited by tony@gonk.net
Tweaked formatting. (diff)
11:40 AM Memory Use edited by tony@gonk.net
Added formatting for readability. Tweaked a few words and phrases. (diff)
11:26 AM Changeset in webkit [92393] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Interpreter can potentially GC in the middle of initializing a structure chain
https://bugs.webkit.org/show_bug.cgi?id=65638

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-04
Reviewed by Oliver Hunt.

Moved the allocation of a prototype StructureChain before the initialization of
the structure chain within the interpreter that was causing intermittent GC crashes.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::tryCachePutByID):

  • wtf/Platform.h:
11:19 AM Changeset in webkit [92392] by darin@chromium.org
  • 2 edits in trunk/Source/WebCore

webkitRequestAnimationFrame's element argument needs to be marked optional
https://bugs.webkit.org/show_bug.cgi?id=65698

Reviewed by James Robinson.

  • page/DOMWindow.idl:
11:17 AM Changeset in webkit [92391] by dslomov@google.com
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=65706
Run run-unit-tests on release mode test bots.
Reenabling after 61812 is fixed.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
11:11 AM Changeset in webkit [92390] by Adam Roben
  • 3 edits
    8 deletes in trunk/Source/WebCore

Delete some unused code from platform/graphics/win

MediaPlayerPrivateQuickTimeWin has been unused since r72117, and the GraphicsLayer-related
classes have been unused since r75262.

Fixes <http://webkit.org/b/65689> platform/graphics/win has a bunch of unused code

Reviewed by Eric Carlson.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:

Removed now-deleted files.

  • platform/graphics/win/GraphicsLayerCACF.cpp: Removed.
  • platform/graphics/win/GraphicsLayerCACF.h: Removed.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: Removed.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Removed.
  • platform/graphics/win/WebLayer.cpp: Removed.
  • platform/graphics/win/WebLayer.h: Removed.
  • platform/graphics/win/WebTiledLayer.cpp: Removed.
  • platform/graphics/win/WebTiledLayer.h: Removed.
11:11 AM Changeset in webkit [92389] by Adam Roben
  • 3 edits
    2 adds in trunk

Detect and handle overflow in PlatformCALayerWinInternal::constrainedSize

Google Maps sometimes requests very large (i.e., 250 pixels or greater) layers when
zooming. PlatformCALayerWinInternal has code to limit tiled layers to 2
27 pixels, but it
was not correctly handling overflow. In some cases, this would lead to creating a tiled
layer with 0 tiles, which was the cause of this crash.

Fixes <http://webkit.org/b/65637> <rdar://problem/9784849> Crash beneath
PlatformCALayerWinInternal::updateTiles when zooming on Google Maps

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::constrainedSize): Check for overflow before seeing if the
number of required tiles is larger than the maximum number of allowed tiles.
(PlatformCALayerWinInternal::updateTiles): Added an assertion to catch cases where we have a
non-empty tiled layer that contains 0 tiles, which would cause the crash in this bug report.

LayoutTests:

Test that a 225x225 pixel layer doesn't cause a crash

  • compositing/tiling/crash-huge-layer-expected.txt: Added.
  • compositing/tiling/crash-huge-layer.html: Added.
11:00 AM Changeset in webkit [92388] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700

Reviewed by James Robinson.

No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

10:52 AM Changeset in webkit [92387] by dslomov@google.com
  • 2 edits in trunk/Source/ThirdParty

https://bugs.webkit.org/show_bug.cgi?id=61812
TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc

Disable fast malloc for offending class (::std::strstream) in gtest.
This looks like the most non-intrusive solution.

Reviewed by David Levin.

10:48 AM Changeset in webkit [92386] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Eval handling attempts literal parsing even when the eval
string is in the cache
https://bugs.webkit.org/show_bug.cgi?id=65675

Reviewed by Oliver Hunt.

This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
in SunSpider. It's neutral on V8.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

10:48 AM Changeset in webkit [92385] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark gain.html as flaky on Linux chromium.

  • platform/chromium/test_expectations.txt:
10:45 AM Changeset in webkit [92384] by bweinstein@apple.com
  • 20 edits in trunk/Source

Source/WebCore: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Expose some methods on InspectorFrontendClient through the InspectorController so WebKit2
can request the inspector be docked, or ask whether or not it can be docked.

  • WebCore.exp.in: Export needed methods.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::requestAttachWindow): Call through to InspectorFrontendClient.
(WebCore::InspectorController::canAttachWindow): Ditto.

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Add a stub method for Chromium.

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canAttachWindow):

  • src/InspectorFrontendClientImpl.h:

Source/WebKit2: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

When opening the inspector, the web process tells the UI process that the inspector page has loaded,
but now will pass another bit of data, whether the inspector can start attached, so the UI process
doesn't need to ask the web process to do another calculation on whether or not it can be attached.

If the user prefers the inspector to start docked (this defaults to true), and there is room for the
window, we send a message to the web process to try and attach the inspector. This makes sure that the
inspector knows it is docked (in the web process).

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::attach): Update the user's docked/undocked preference if the inspector is visible

when it was attached.

(WebKit::WebInspectorProxy::detach): Ditto (but when it was detached).
(WebKit::WebInspectorProxy::didLoadInspectorPage): If we can start docked, and the user prefers to start docked,

then request the inspector be attached to the window.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformOpen): Only show the window if we are going to start undocked.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformOpen): Ditto.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didLoadInspectorPage): Pass whether or not we can attach the window.
(WebKit::WebInspector::requestAttachWindow): Call through to the InspectorController to attach the inspector.
(WebKit::WebInspector::canAttachWindow): Ask the InspectorController if we can attach the inspector.

  • WebProcess/WebPage/WebInspector.h:
  • Shared/WebPreferencesStore.h: Add a new preference for whether or not the inspector should

start attached.

  • UIProcess/WebInspectorProxy.messages.in: When the inspector page is loaded, tell the UI Process whether

we can attach the inspector without needing another message.

  • WebProcess/WebPage/WebInspector.messages.in: Add a new message for RequestAttachWindow
10:25 AM Changeset in webkit [92383] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702.

  • platform/gtk/Skipped:
9:51 AM Changeset in webkit [92382] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

builders.js needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=65670

Reviewed by Dimitri Glazkov.

This test requires somewhat large test fixtures, but using real
examples seemed better than trimming them down too much.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
    • Note: trac_unittests.js doesn't exist (yet!).
9:41 AM Changeset in webkit [92381] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, skip some svg tests on GTK, likely affected by bug 39022.

  • platform/gtk/Skipped:
9:33 AM Changeset in webkit [92380] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and test_expectations update (2 tests
now passing).

  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/gtk/test_expectations.txt:
9:22 AM Changeset in webkit [92379] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Normalize test_expectations.txt file.

  • platform/chromium/test_expectations.txt: Ran webkit-path optimize-expectations.
9:10 AM Changeset in webkit [92378] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65665

Reviewed by Simon Fraser.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBorderFit.
(WebCore::CSSPrimitiveValue::operator EBorderFit):
Support cast to EBorderFit.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use new cast to allow use of appropriate macro.

9:09 AM Changeset in webkit [92377] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=65687

Reviewed by Yury Semikhatsky.

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

  • inspector/InspectorRuntimeAgent.h:
8:41 AM Changeset in webkit [92376] by jocelyn.turcotte@nokia.com
  • 11 edits
    1 copy
    3 adds in trunk/Source/WebKit2

[Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using imperative painting.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

Converts QTouchWebPage from QSGPaintedItem to a straight QSGItem.

  • A SGTileNode is created and added to the scene graph for each tile, positioning them relatively to the page. It's basically a QSGSimpleTextureNode with support for specifying a source rect plus for owning the QSGTexture for proper destruction on shutdown by the rendering thread.
  • Scale nodes are used as parent of tile nodes to revert the scaling set on the QTouchWebPage and allow us to keep using integer coordinates.
  • The SGAgent class is introduced to carry scene graph update request up to the updatePaintNode call of the item, which may be on the scene graph rendering thread.
  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::updatePaintNode):
Delegate scene graph updates to the SGAgent which received update requests from the tiled drawing area.
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

Manage the scale node in the TileSet, it will be the parent node of Tile nodes.
(WebKit::TiledDrawingAreaTileSet::sgNodeID):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::~TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):

  • UIProcess/TiledDrawingAreaTile.h:

(WebKit::TiledDrawingAreaTile::create):

  • UIProcess/qt/SGAgent.cpp: Added.
  • UIProcess/qt/SGAgent.h: Added.
  • UIProcess/qt/SGTileNode.cpp: Added.
  • UIProcess/qt/SGTileNode.h: Added.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

Disable the paint call and update the scene graph on incorporateUpdate through the SGAgent.
(WebKit::TiledDrawingAreaProxy::updateWebView):

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:

(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::isReadyToPaint):
(WebKit::TiledDrawingAreaTile::swapBackBufferToFront):
(WebKit::TiledDrawingAreaTile::paint):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::setParentNodeID):

  • UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::sceneGraphAgent):
(WebKit::TouchViewInterface::setViewNeedsDisplay):

  • UIProcess/qt/TouchViewInterface.h:
  • WebKit2.pro:
8:22 AM Changeset in webkit [92375] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk/Source/WebCore

Use -webkit-locale for font selection.
https://bugs.webkit.org/show_bug.cgi?id=10874

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-04
Reviewed by Dan Bernstein.

Infer a script from -webkit-locale to use to choose a font for generic
font families and the default unstyled font. The font is retrieved
from per-script font settings (see bug 20797). Since these settings
have not changed there should be no visible effect yet.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontSelector.cpp: Use script when getting font from Settings

(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSPropertyNames.in: Increase priority of -webkit-locale since it affects font
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty): Set script in font based on -webkit-locale

  • page/Settings.cpp:

(WebCore::getGenericFontFamilyForScript): Fallback to USCRIPT_COMMON

  • platform/graphics/FontDescription.h: Add m_script

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::script):
(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):

  • platform/text/LocaleToScriptMapping.h: Added.
  • platform/text/LocaleToScriptMappingDefault.cpp: Added.

(WebCore::localeToScriptCodeForFontSelection):
(WebCore::LocaleScript::if):
(WebCore::LocaleScript::while):

  • platform/text/LocaleToScriptMappingICU.cpp: Added.

(WebCore::scriptCodeForFontSelection):
(WebCore::localeToScriptCodeForFontSelection):

8:04 AM Changeset in webkit [92374] by Philippe Normand
  • 1 edit
    93 adds in trunk/LayoutTests

Unreviewed, GTK new baselines for new tests.

  • platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
  • platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
  • platform/gtk/fast/blockflow/broken-ideographic-font-expected.png: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.png: Added.
  • platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
  • platform/gtk/fast/css/color-leakage-expected.png: Added.
  • platform/gtk/fast/css/color-leakage-expected.txt: Added.
  • platform/gtk/fast/css/font-family-pictograph-expected.png: Added.
  • platform/gtk/fast/css/font-family-pictograph-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Added.
  • platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
  • platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
  • platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
  • platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
  • platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/gtk/svg/as-border-image/svg-as-border-image-expected.txt: Added.
  • platform/gtk/svg/custom/absolute-root-position-masking-expected.png: Added.
  • platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Added.
  • platform/gtk/svg/custom/linking-uri-01-b-expected.png: Added.
  • platform/gtk/svg/custom/linking-uri-01-b-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-shadow-expected.png: Added.
  • platform/gtk/svg/custom/repaint-shadow-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-fallback-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-segmented-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-segmented-expected.txt: Added.
  • platform/gtk/svg/custom/svg-fonts-word-spacing-expected.png: Added.
  • platform/gtk/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
  • platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
  • platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
  • platform/gtk/svg/custom/tref-own-content-removal-expected.png: Added.
  • platform/gtk/svg/custom/tref-own-content-removal-expected.txt: Added.
  • platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
  • platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
7:57 AM Changeset in webkit [92373] by alexis.menard@openbossa.org
  • 15 edits
    2 adds in trunk

[Qt] Make navigation actions properly usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65624

Source/WebKit2:

Add a new class that is exposed in QML to control the navigation
like reload/stop/back/forward. Enums are not very QML friendly,
it not possible to use enums that are not declared in the same class
than the object exposed in QML, therefore it makes hard the sharing
between the desktop and the touch views. In addition namespaced enums are
even harder to support in QML. QWebNavigationController is
not really meant to be used in C++ but it is exported for convenience
reason (tests and MiniBrowser) so its API is not meant to be public but
exposed in QML through properties and convenience slots. The QML code to use
the navigation action in QML will look like "desktopView.navigation.reload();"
or "if (desktopView.navigation.reloadAction.enabled) ...".

Reviewed by Benjamin Poulain.

  • UIProcess/API/qt/WKView.h: To get the forward header generated
  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebView::navigationController):

  • UIProcess/API/qt/qdesktopwebview.h:
  • UIProcess/API/qt/qdesktopwebview_p.h:
  • UIProcess/API/qt/qmlplugin/plugin.cpp:

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::navigationController):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

  • UIProcess/API/qt/qtouchwebpage.h:
  • UIProcess/API/qt/qtouchwebpage_p.h:
  • UIProcess/API/qt/qwebnavigationcontroller.cpp: Added.

(QWebNavigationControllerPrivate::QWebNavigationControllerPrivate):
(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::~QWebNavigationController):
(QWebNavigationController::backAction):
(QWebNavigationController::forwardAction):
(QWebNavigationController::stopAction):
(QWebNavigationController::reloadAction):
(QWebNavigationController::navigationAction):
(QWebNavigationController::back):
(QWebNavigationController::forward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):

  • UIProcess/API/qt/qwebnavigationcontroller.h: Added.
  • UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:

(WebViewAbstraction::triggerNavigationAction):

  • UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:

(tst_QDesktopWebView::navigationActionsStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):

  • UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:

(tst_QTouchWebView::navigationActionsStatusAtStartup):

  • WebKit2API.pri:

Tools:

Fix compilation after the introduction of QWebNavigationController.

Reviewed by Benjamin Poulain.

  • MiniBrowser/qt/BrowserView.cpp:

(BrowserView::navigationAction):

7:39 AM Changeset in webkit [92372] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Pretty print JSONP in network panel preview tab.
https://bugs.webkit.org/show_bug.cgi?id=65559

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-preview-json.html

  • inspector/front-end/ResourceJSONView.js:

(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ParsedJSON):

  • inspector/front-end/ResourcePreviewView.js:

(WebInspector.ResourcePreviewView.prototype._createPreviewView):

LayoutTests:

  • http/tests/inspector/network/network-preview-json-expected.txt: Added.
  • http/tests/inspector/network/network-preview-json.html: Added.
6:54 AM Changeset in webkit [92371] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
https://bugs.webkit.org/show_bug.cgi?id=65684

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpoint):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
  • inspector/debugger/debugger-set-breakpoint-regex.html:
6:42 AM Changeset in webkit [92370] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GTK] fullscreen/video-controls-override.html fails
https://bugs.webkit.org/show_bug.cgi?id=65618

Reviewed by Martin Robinson.

Implement extraFullScreenStyleSheet() and provide the QuickTime
stylesheet for now, later we might want our own stylesheet.

  • GNUmakefile.am:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::extraFullScreenStyleSheet):
  • platform/gtk/RenderThemeGtk.h:
6:07 AM Changeset in webkit [92369] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
https://bugs.webkit.org/show_bug.cgi?id=65682

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

():

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.setScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.registerAnchor):
(WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set _debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.sourceLine):

  • inspector/front-end/EventListenersSidebarPane.js:

(.):
():

  • inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):

  • inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._concatenateScriptsContent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/source-file.html:
5:43 AM Changeset in webkit [92368] by Philippe Normand
  • 5 edits
    4 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt:
  • platform/gtk/fast/dom/Range/getClientRects-expected.txt:
  • platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
4:24 AM Changeset in webkit [92367] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Unreviewed chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
4:04 AM Changeset in webkit [92366] by vsevik@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Merge 91829 - Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

TBR=mnaganov@chromium.org
BUG=91535
Review URL: http://codereview.chromium.org/7575008

3:07 AM Changeset in webkit [92365] by commit-queue@webkit.org
  • 16 edits
    3 moves in trunk/Source/WebCore

MediaStream API: Rename StreamEvent to MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=65669

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-04
Reviewed by Tony Gentilcore.

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp:

(WebCore::Event::isMediaStreamEvent):

  • dom/Event.h:
  • p2p/MediaStreamEvent.cpp: Renamed from Source/WebCore/dom/StreamEvent.cpp.

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
(WebCore::MediaStreamEvent::~MediaStreamEvent):
(WebCore::MediaStreamEvent::initMediaStreamEvent):
(WebCore::MediaStreamEvent::stream):

  • p2p/MediaStreamEvent.h: Renamed from Source/WebCore/dom/StreamEvent.h.

(WebCore::MediaStreamEvent::isMediaStreamEvent):

  • p2p/MediaStreamEvent.idl: Renamed from Source/WebCore/dom/StreamEvent.idl.
  • p2p/PeerConnection.cpp:

(WebCore::PeerConnection::dispatchStreamEvent):

2:32 AM Changeset in webkit [92364] by hans@chromium.org
  • 6 edits
    2 adds in trunk

IndexedDB: Fix index data invalidation bugs.
https://bugs.webkit.org/show_bug.cgi?id=65547

Reviewed by Tony Chang.

Source/WebCore:

The function that checks whether a key exists in an index failed
to check whether that key was still valid or not.

Deleting a record from an object store must also delete its exists
entry, thus invalidating index keys pointing to that record.

Test: storage/indexeddb/index-unique.html

  • storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::CursorOptions::IndexKeyCursorImpl::loadCurrentRow):

LayoutTests:

Add layout test to verify that update object store data causes old
index data to be invalidated.

  • storage/indexeddb/index-unique.html: Added.
2:19 AM WikiStart edited by wesley
(diff)
2:10 AM Changeset in webkit [92363] by commit-queue@webkit.org
  • 1 edit
    4 moves in trunk/Source/WebCore

Move PODIntervalTree to Source/WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=65667

It seems the files were not part of any project, so no project files were modified.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-04
Reviewed by Adam Barth.

No new tests, just moving files from one folder to the other.

  • platform/PODArena.h: Renamed from Source/WebCore/platform/graphics/gpu/PODArena.h.

(WebCore::PODArena::Allocator::~Allocator):
(WebCore::PODArena::FastMallocAllocator::create):
(WebCore::PODArena::FastMallocAllocator::allocate):
(WebCore::PODArena::FastMallocAllocator::free):
(WebCore::PODArena::FastMallocAllocator::FastMallocAllocator):
(WebCore::PODArena::create):
(WebCore::PODArena::allocateObject):
(WebCore::PODArena::~PODArena):
(WebCore::PODArena::PODArena):
(WebCore::PODArena::minAlignment):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::roundUp):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(WebCore::PODArena::Chunk::allocate):

  • platform/PODInterval.h: Renamed from Source/WebCore/platform/graphics/gpu/PODInterval.h.

(WebCore::PODInterval::PODInterval):
(WebCore::PODInterval::low):
(WebCore::PODInterval::high):
(WebCore::PODInterval::data):
(WebCore::PODInterval::overlaps):
(WebCore::PODInterval::operator<):
(WebCore::PODInterval::operator==):
(WebCore::PODInterval::maxHigh):
(WebCore::PODInterval::setMaxHigh):
(WebCore::PODInterval::toString):

  • platform/PODIntervalTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODIntervalTree.h.

(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::createInterval):
(WebCore::PODIntervalTree::checkInvariants):
(WebCore::PODIntervalTree::init):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
(WebCore::PODIntervalTree::updateNode):
(WebCore::PODIntervalTree::checkInvariantsFromNode):

  • platform/PODRedBlackTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODRedBlackTree.h.

(WebCore::PODRedBlackTree::Visitor::~Visitor):
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::~PODRedBlackTree):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::setNeedsFullOrderingComparisons):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::setVerboseDebugging):
(WebCore::PODRedBlackTree::Node::Node):
(WebCore::PODRedBlackTree::Node::~Node):
(WebCore::PODRedBlackTree::Node::color):
(WebCore::PODRedBlackTree::Node::setColor):
(WebCore::PODRedBlackTree::Node::data):
(WebCore::PODRedBlackTree::Node::copyFrom):
(WebCore::PODRedBlackTree::Node::left):
(WebCore::PODRedBlackTree::Node::setLeft):
(WebCore::PODRedBlackTree::Node::right):
(WebCore::PODRedBlackTree::Node::setRight):
(WebCore::PODRedBlackTree::Node::parent):
(WebCore::PODRedBlackTree::Node::setParent):
(WebCore::PODRedBlackTree::root):
(WebCore::PODRedBlackTree::updateNode):
(WebCore::PODRedBlackTree::treeSearch):
(WebCore::PODRedBlackTree::treeSearchNormal):
(WebCore::PODRedBlackTree::treeSearchFullComparisons):
(WebCore::PODRedBlackTree::treeInsert):
(WebCore::PODRedBlackTree::treeSuccessor):
(WebCore::PODRedBlackTree::treeMinimum):
(WebCore::PODRedBlackTree::propagateUpdates):
(WebCore::PODRedBlackTree::leftRotate):
(WebCore::PODRedBlackTree::rightRotate):
(WebCore::PODRedBlackTree::insertNode):
(WebCore::PODRedBlackTree::deleteFixup):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::visitInorderImpl):
(WebCore::PODRedBlackTree::Counter::Counter):
(WebCore::PODRedBlackTree::Counter::visit):
(WebCore::PODRedBlackTree::Counter::count):
(WebCore::PODRedBlackTree::checkInvariantsFromNode):
(WebCore::PODRedBlackTree::logIfVerbose):
(WebCore::PODRedBlackTree::dumpFromNode):

1:52 AM Changeset in webkit [92362] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65666

Chromium test_expectations.txt update

  • platform/chromium/test_expectations.txt:
1:39 AM Changeset in webkit [92361] by hamaji@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Chromium test rebaselining

  • platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:56 AM Changeset in webkit [92360] by abarth@webkit.org
  • 2 edits in trunk/Tools

Another subtle bug due to lack of testing in main.js. :(

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
12:52 AM Changeset in webkit [92359] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

Test progression after <http://trac.webkit.org/changeset/92341>.

  • platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt:
  • platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt:
12:49 AM Changeset in webkit [92358] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

Update baselines after <http://trac.webkit.org/changeset/92340>.

  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
12:41 AM Changeset in webkit [92357] by abarth@webkit.org
  • 2 edits in trunk/Tools

Fix types. Sadly, main.js has no test coverage. (I need to think
about how to test this part of the code.)

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
12:14 AM Changeset in webkit [92356] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

bugzilla.js is missing unit tests
https://bugs.webkit.org/show_bug.cgi?id=65656

Reviewed by Adam Roben.

Testing makes perfect.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:

(NetworkSimulator.prototype.runTest.get if):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
12:14 AM Changeset in webkit [92355] by abarth@webkit.org
  • 19 edits in trunk/Tools

Add missing license blocks to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65654

Reviewed by Dimitri Glazkov.

This patch is entirely boilerplate.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
12:13 AM Changeset in webkit [92354] by abarth@webkit.org
  • 12 edits
    2 adds in trunk/Tools

garden-o-matic needs a way to mock out the network
https://bugs.webkit.org/show_bug.cgi?id=65653

Reviewed by Dimitri Glazkov.

This patch introduces the net module, which is a useful mock point for
abstracting away the network. Future patches will use this
infrastructure to test some currently untested code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.

(NetworkSimulator):
(NetworkSimulator.prototype.scheduleCallback):
(NetworkSimulator.prototype.runTest):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
12:10 AM Changeset in webkit [92353] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test triggers a crasher on some ports. The crasher is filed already.

  • platform/qt/Skipped:

Aug 3, 2011:

11:35 PM Changeset in webkit [92352] by commit-queue@webkit.org
  • 5 edits in trunk

An element with role=textbox should have settable AXValue unless read-only
https://bugs.webkit.org/show_bug.cgi?id=65664

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-03
Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetValueAttribute):
Return true for non-native text field with aria-readonly not set.

LayoutTests:

  • accessibility/aria-readonly-expected.txt:
  • accessibility/aria-readonly.html:
11:08 PM Changeset in webkit [92351] by abarth@webkit.org
  • 6 edits in trunk/Tools

Use failureInfo more pervasively in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65650

Reviewed by Dimitri Glazkov.

These three variable appears in concert together many places. This
patch unifies the remaining uses into being failureInfo objects, which
saves some marshalling.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
10:34 PM Changeset in webkit [92350] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/win

[Windows] Fix build without ENABLE_VIDEO.

  • WebView.cpp:

(WebView::enterFullscreenForNode):

9:40 PM Changeset in webkit [92349] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Clean up value clamping in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65588

Reviewed by Darin Adler.

No new tests / trivial code cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Replace (unsigned int)primitiveValue->getDoubleValue() with primtiveValue->getValue<unsigned>() for correct clamping.
Replace clampToInteger(primitiveValue->getDoubleValue()) with primitiveValue->getIntValue().

9:38 PM Changeset in webkit [92348] by abarth@webkit.org
  • 4 edits in trunk/Tools

garden-o-matic should be able to update expecations from the details pane
https://bugs.webkit.org/show_bug.cgi?id=65648

Reviewed by Dimitri Glazkov.

The new button queues up the updates, which get executed all at once.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
9:38 PM Changeset in webkit [92347] by tkent@chromium.org
  • 13 edits in trunk/Source

Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590

Reviewed by Dimitri Glazkov.

<video> and <audio> can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.

Source/WebCore:

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedIntoTree):
(WebCore::HTMLSourceElement::willRemove):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):

  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaMuteButton):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _isAnyMoviePlaying]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::enterFullscreenForNode):

9:16 PM Changeset in webkit [92346] by abarth@webkit.org
  • 7 edits in trunk/Tools

Add UI to garden-o-matic for updating expectations
https://bugs.webkit.org/show_bug.cgi?id=65644

Reviewed by Dimitri Glazkov.

The patch plumbs the UI back to the gardening server, but the gardening
server endpoint is just a stub at this point.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
8:54 PM Changeset in webkit [92345] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Use of AVFoundation should default to off on Windows
https://bugs.webkit.org/show_bug.cgi?id=65660

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.
8:02 PM Changeset in webkit [92344] by abarth@webkit.org
  • 5 edits in trunk/Tools

garden-o-matic details view should queue rebaselines for later execution
https://bugs.webkit.org/show_bug.cgi?id=65636

Reviewed by Dimitri Glazkov.

This patch doesn't contain any confirmation UI, but we'll probably want
that at some point.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
7:35 PM Changeset in webkit [92343] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
https://bugs.webkit.org/show_bug.cgi?id=65659

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

ScrollbarOverlayUtilitiesChromiumMac.h couldn't be included from pure c++ code because it used NSInteger. I fixed this by checking for OBJC before using NSInteger.

Currently no pure c++ files are including ScrollbarOverlayUtilitiesChromiumMac.h but this will change in future patches from jam@chromium.org.

  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
  • platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:

(wkScrollbarPainterControllerStyle):
(wkSetScrollbarPainterControllerStyle):

7:09 PM Changeset in webkit [92342] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65657

Reviewed by Simon Fraser.

No new tests / refactoring only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Implement cast from EBoxSizing.
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
Implement cast to EBoxSizing.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to simplify code using cast.

7:01 PM Changeset in webkit [92341] by commit-queue@webkit.org
  • 10 edits
    4 adds
    6 deletes in trunk

Implement EventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Patch by Kentaro Hara <haraken@google.com> on 2011-08-03
Reviewed by Darin Fisher.

Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
and then sets a scroll position to (x, y). Enabled the tests that had been waiting
for the implementation of EventSender.scalePageBy(f, x, y).

Source/WebKit/chromium:

Tests: compositing/scaling/tiled-layer-recursion.html

fast/repaint/scale-page-shrink.html
fast/dom/Element/scale-page-client-rects.html
fast/dom/Range/scale-page-client-rects.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-bounding-client-rect.html

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scalePage): A wrapper method for scalePage() in WebCore.

  • src/WebViewImpl.h:

Tools:

Tests: compositing/scaling/tiled-layer-recursion.html

fast/repaint/scale-page-shrink.html
fast/dom/Element/scale-page-client-rects.html
fast/dom/Range/scale-page-client-rects.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-bounding-client-rect.html

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender): Added bindings for scalePageBy().
(EventSender::scalePageBy): A wrapper method for scalePage() in WebView.

  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController): Resets the scale factor to 1.

LayoutTests:

  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Enabled one test. Enabled two tests for chromium-linux.
6:51 PM Changeset in webkit [92340] by Joseph Pecoraro
  • 10 edits
    3 adds in trunk

<http://webkit.org/b/65006> Draw rectangular box shadow for elements with border-radius if no corners are visible

Patch by Ian Henderson <ianh@apple.com> on 2011-08-03
Reviewed by Simon Fraser.

Source/WebCore:

Change "unroundClippedCorners" to "allCornersClippedOut" and use it to
determine when the corners' influence affects the blurred shadow in
the current drawing region.

Test: fast/box-shadow/box-shadow-clipped-slices.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxShadow): Pass PaintInfo through to
RenderBoxModelObject::paintBoxShadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Ditto.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::allCornersClippedOut): Determines whether the bounding rects
for any of the given rounded rect's corners intersects the clip rect.
(WebCore::RenderBoxModelObject::paintBorder): Instead of "unrounding"
any corner outside the clip rect, unround all corners at once, and
only if they are all outside the clip rect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Determine whether any
corner will influence shadow drawing using allCornersClippedOut on the
influenceRect, whose corners extend past the fillRect's corners by the
blur radius and inside the fillRect's corners by the blur radius.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
RenderBoxModelObject::paintBoxShadow.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

LayoutTests:

  • fast/box-shadow/box-shadow-clipped-slices.html: Added.
  • platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
  • platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.txt: Added.
6:44 PM Changeset in webkit [92339] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
https://bugs.webkit.org/show_bug.cgi?id=65521

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-03
Reviewed by Adam Barth.

file: scheme URI paths on Windows include the disk drive reference (C: for example).
Refer to http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.

  • fast/dom/resource-locations-in-created-html-document.html:
  • platform/chromium/test_expectations.txt:
6:41 PM Changeset in webkit [92338] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Revert an erroneous rebaseline from r92315.

  • fast/dom/navigator-detached-no-crash-expected.txt:
5:22 PM Changeset in webkit [92337] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn't show composited content
https://bugs.webkit.org/show_bug.cgi?id=65629

Reviewed by Benjamin Poulain.

Some non-ES2 initialization was wrongfully #ifdefed in CPU(X86) and thus compiled-out.
When put it in the correct #ifdef, composited layers which require an intermediate buffer
work again.

No new tests. Existing opacity tests in LayoutTests/compositing test this.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::bind):

5:16 PM Changeset in webkit [92336] by rniwa@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Chromium Windows and Linux rebaselines after r92330.

  • platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
4:57 PM Changeset in webkit [92335] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp

Merge 92331 - [chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::protectTileTextures):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7508041

4:53 PM Changeset in webkit [92334] by levin@chromium.org
  • 3 edits in trunk/Tools

Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=65652

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
4:51 PM Changeset in webkit [92333] by mrowe@apple.com
  • 8 edits in trunk/Source

Bring some order to FeatureDefines.xcconfig to make it easier to follow.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
4:50 PM Changeset in webkit [92332] by mrowe@apple.com
  • 8 edits in trunk/Source

Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings

Reviewed by Dave Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
4:43 PM Changeset in webkit [92331] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::protectTileTextures):

4:42 PM Changeset in webkit [92330] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
https://bugs.webkit.org/show_bug.cgi?id=26483

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit serializing pre, h1, etc... to retain structure and appearance when copying
rich content and pasting did not remove such nodes wrapping the copied contents.

Fixed the bug by extending r81887 and r83322 to remove those elements from where WebKit pastes into.

Test: editing/pasteboard/copy-paste-text-in-h1.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::nodeHasAttributesToPreserve): Extracted from isInlineNodeWithStyle.
(WebCore::isInlineNodeWithStyle): Calls nodeHasAttributesToPreserve.
(WebCore::ReplaceSelectionCommand::doApply): Calls ancestorToRetainStructureAndAppearance.
Remove nodes copied by ancestorToRetainStructureAndAppearance at insertionPos before pasting the fragment.

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearance): Takes ShouldIncludeParagraphSeparators.

  • editing/markup.h:

LayoutTests:

  • editing/pasteboard/5065605-expected.txt:
  • editing/pasteboard/copy-paste-text-in-h1-expected.txt: Added.
  • editing/pasteboard/copy-paste-text-in-h1.html: Added.
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
4:35 PM Changeset in webkit [92329] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641

Reviewed by Darin Adler.

Fix build on non-x86 platforms, by ensuring that the relevant
parameter always appears to be used even when it isn't.

  • heap/Heap.cpp:
4:31 PM Changeset in webkit [92328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Console.idl
https://bugs.webkit.org/show_bug.cgi?id=65569

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/Console.idl:
4:20 PM Changeset in webkit [92327] by commit-queue@webkit.org
  • 34 edits in trunk

Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

  • html/DOMFormData.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/TimeRanges.idl:

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt:
  • fast/files/create-blob-url-crash.html:
  • fast/files/revoke-blob-url-expected.txt:
  • fast/files/revoke-blob-url.html:
  • fast/forms/ValidityState-customError-expected.txt:
  • fast/forms/ValidityState-customError.html:
4:19 PM Changeset in webkit [92326] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Adding Filip Pizlo to committer list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
4:18 PM Changeset in webkit [92325] by jpfau@apple.com
  • 6 edits in trunk/Source/WebCore

Make atomic XML token
https://bugs.webkit.org/show_bug.cgi?id=65639

Reviewed by Adam Barth.

Create a shared AtomicMarkupTokenBase that is shared by AtomicHTMLToken and the new AtomicXMLToken

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::setForceQuirks):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::forceQuirks):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::type):
(WebCore::AtomicMarkupTokenBase::name):
(WebCore::AtomicMarkupTokenBase::setName):
(WebCore::AtomicMarkupTokenBase::selfClosing):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAtributes):
(WebCore::AtomicMarkupTokenBase::characters):
(WebCore::AtomicMarkupTokenBase::comment):
(WebCore::AtomicMarkupTokenBase::publicIdentifier):
(WebCore::AtomicMarkupTokenBase::systemIdentifier):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):
(WebCore::AtomicXMLToken::prefix):
(WebCore::AtomicXMLToken::target):
(WebCore::AtomicXMLToken::data):
(WebCore::AtomicXMLToken::xmlVersion):
(WebCore::AtomicXMLToken::xmlStandalone):

  • xml/parser/XMLTokenizer.cpp:

(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):

4:03 PM Changeset in webkit [92324] by Dimitri Glazkov
  • 2 edits
    1 add in trunk/Tools

Add "optimize-expectations" command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=65633

For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/init.py: Added command.
  • Scripts/webkitpy/tool/commands/expectations.py: Added.
4:01 PM Changeset in webkit [92323] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
https://bugs.webkit.org/show_bug.cgi?id=65355

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/Geolocation.idl:
  • page/PositionCallback.idl:
  • page/PositionErrorCallback.idl:
3:59 PM Changeset in webkit [92322] by darin@chromium.org
  • 104 edits in trunk/Source/WebKit/chromium

2011-08-03 Darin Fisher <darin@chromium.org>

[Chromium] Rename WEBKIT_API to WEBKIT_EXPORT.
https://bugs.webkit.org/show_bug.cgi?id=65649

Reviewed by Adam Barth.

  • README:
  • public/WebAccessibilityCache.h:
  • public/WebAccessibilityObject.h:
  • public/WebArrayBufferView.h:
  • public/WebAttribute.h:
  • public/WebAudioBus.h:
  • public/WebBindings.h:
  • public/WebBlobData.h:
  • public/WebBlobRegistry.h:
  • public/WebCString.h:
  • public/WebCache.h:
  • public/WebColor.h:
  • public/WebCommon.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMMouseEvent.h:
  • public/WebDOMMutationEvent.h:
  • public/WebDOMStringList.h:
  • public/WebData.h:
  • public/WebDatabase.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDocumentType.h:
  • public/WebDragData.h:
  • public/WebElement.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHTTPBody.h:
  • public/WebHTTPLoadInfo.h:
  • public/WebHistoryItem.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebImage.h:
  • public/WebImageDecoder.h:
  • public/WebInputElement.h:
  • public/WebInputEvent.h:
  • public/WebKit.h:
  • public/WebLabelElement.h:
  • public/WebMediaElement.h:
  • public/WebNamedNodeMap.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebOptionElement.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPluginDocument.h:
  • public/WebPopupMenu.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScriptController.h:
  • public/WebScrollbar.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSerializedScriptValue.h:
  • public/WebSharedWorker.h:
  • public/WebSpeechInputControllerMock.h:
  • public/WebSpeechInputResult.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebStorageNamespace.h:
  • public/WebString.h:
  • public/WebTestingSupport.h:
  • public/WebThreadSafeData.h:
  • public/WebURLLoadTiming.h:
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • public/WebView.h:
  • public/WebWorker.h:
  • public/gtk/WebFontInfo.h:
  • public/gtk/WebInputEventFactory.h:
  • public/linux/WebFontRenderStyle.h:
  • public/linux/WebFontRendering.h:
  • public/linux/WebRenderTheme.h:
  • public/mac/WebInputEventFactory.h:
  • public/mac/WebScreenInfoFactory.h:
  • public/mac/WebSubstringUtil.h:
  • public/win/WebInputEventFactory.h:
  • public/win/WebScreenInfoFactory.h:
  • public/x11/WebScreenInfoFactory.h:
  • tests/WebUnitTests.h:
3:50 PM Changeset in webkit [92321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
https://bugs.webkit.org/show_bug.cgi?id=65566

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • page/DOMSelection.idl:
3:47 PM Changeset in webkit [92320] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from Location.idl
https://bugs.webkit.org/show_bug.cgi?id=65565

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Darin Adler.

No new tests, all existing tests pass.

  • page/Location.idl:
3:42 PM Changeset in webkit [92319] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

3:36 PM Changeset in webkit [92318] by Michael Nordman
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Minor cleanup, remove a deprecated method.
The old WebDatabase::updateDatabaseSize method has been replaced with
updateDatabaseSize, updateSpaceAvailable, and resetSpaceAvailable.
https://bugs.webkit.org/show_bug.cgi?id=65553

Reviewed by Adam Barth.

  • public/WebDatabase.h:
  • src/WebDatabase.cpp:
3:34 PM Changeset in webkit [92317] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Allow multiple bug identifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65642

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
3:24 PM Changeset in webkit [92316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

  • platform/chromium/ScrollAnimatorChromiumMac.mm:

(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

2:58 PM Changeset in webkit [92315] by commit-queue@webkit.org
  • 7 edits in trunk

Remove LegacyDefaultOptionalArguments flag from navigator IDL files
https://bugs.webkit.org/show_bug.cgi?id=65370

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

  • page/Navigator.idl:
  • page/NavigatorUserMediaErrorCallback.idl:
  • page/NavigatorUserMediaSuccessCallback.idl:

LayoutTests:

  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
2:53 PM Changeset in webkit [92314] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

webarchive/loading/missing-data.html is failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=63507

Reviewed by Adam Barth.

When loading a main resource from a web archive, make sure that the working URL is actually
the URL of the resource, and not the URL of the web archive itself.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):

2:50 PM Changeset in webkit [92313] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=65353

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):

  • page/DOMWindow.idl:
2:22 PM Changeset in webkit [92312] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91447.

2:16 PM Changeset in webkit [92311] by Lucas Forschler
  • 2 edits in branches/safari-534.51-branch/Source/WebCore

Merge r91438.

2:04 PM Changeset in webkit [92310] by Lucas Forschler
  • 17 edits in branches/safari-534.51-branch/Source

Merge r91435.

1:52 PM Changeset in webkit [92309] by jeffm@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Chromimum and Qt builds after r92308.

  • config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.
1:15 PM Changeset in webkit [92308] by jeffm@apple.com
  • 3 edits in trunk/Source/WebCore

Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
https://bugs.webkit.org/show_bug.cgi?id=65634

AVFoundation support on Windows will (eventually) be predicated on the
availability of AVFoundationCF headers and libraries in the WebKit Support
Libraries, so we test for the existence of one of the header files (AVCFBase.h)
to determine whether to AVCF is available.

For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).

Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.

Reviewed by Adam Roben.

No change in functionality, so new tests.

  • DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
  • config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.
1:13 PM Changeset in webkit [92307] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fix an error in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:57 PM Changeset in webkit [92306] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [92305] by Michael Nordman
  • 10 edits in branches/chromium/835/Source/WebCore/storage

Merge 92155 - [Chromium] WebSQLDatabase version handling is broken in multi-process browsers.
https://bugs.webkit.org/show_bug.cgi?id=65486

The WebCore::AbstractDatabase class maintains a global in-memory map of
the version numbers associated with open database files, but that map is
not reliable in a multi-process system like Chrome. So instead of relying
on the cached values in that map, we read the value from the database (and
update the cached value) where possible. There are two edge cases where that's
not possible because the scriptable interface requires synchronous access
to the version: the .version attribute getter and the .openDatabase() method.
In those cases, we have no choice but to use the potentially stale cached value.

Reviewed by Darin Fisher.

No new tests. Existing layout tests cover the version handling functionality.

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
(WebCore::AbstractDatabase::setCachedVersion):
(WebCore::AbstractDatabase::getActualVersionForTransaction):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::expectedVersion):

  • storage/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):

  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):

  • storage/SQLTransactionSync.h:

TBR=Michael Nordman
Review URL: http://codereview.chromium.org/7563014

12:54 PM Changeset in webkit [92304] by commit-queue@webkit.org
  • 27 edits
    2 copies
    7 adds in trunk

MediaStream API: Implement PeerConnection and SignalingCallback
https://bugs.webkit.org/show_bug.cgi?id=65101

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-03
Reviewed by Adam Barth.

LayoutTests will be provided by a follow-up CL, see <https://bugs.webkit.org/show_bug.cgi?id=56587>.

Source/WebCore:

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSPeerConnectionCustom.cpp: Copied from Source/WebCore/page/MediaStreamClient.h.

(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/custom/V8PeerConnectionCustom.cpp: Added.

(WebCore::V8PeerConnection::constructorCallback):

  • dom/DispatchTask.h: Added.

(WebCore::SimpleDispatchTask::create):
(WebCore::SimpleDispatchTask::performTask):
(WebCore::SimpleDispatchTask::SimpleDispatchTask):
(WebCore::DispatchTask::create):
(WebCore::DispatchTask::performTask):
(WebCore::DispatchTask::DispatchTask):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toPeerConnection):

  • dom/EventTarget.h:
  • p2p/PeerConnection.cpp: Added.

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::init):
(WebCore::PeerConnection::~PeerConnection):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::onNegotiationStarted):
(WebCore::PeerConnection::onNegotiationDone):
(WebCore::PeerConnection::streamAdded):
(WebCore::PeerConnection::streamRemoved):
(WebCore::PeerConnection::onMessage):
(WebCore::PeerConnection::onSignalingMessage):
(WebCore::PeerConnection::toPeerConnection):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::eventTargetData):
(WebCore::PeerConnection::ensureEventTargetData):
(WebCore::PeerConnection::postMessageEvent):
(WebCore::PeerConnection::postSignalingEvent):
(WebCore::PeerConnection::postStreamAddedEvent):
(WebCore::PeerConnection::postStreamRemovedEvent):
(WebCore::PeerConnection::postSimpleEvent):
(WebCore::PeerConnection::postStartNegotiationTask):
(WebCore::PeerConnection::dispatchMessageEvent):
(WebCore::PeerConnection::dispatchSignalingEvent):
(WebCore::PeerConnection::dispatchStreamEvent):
(WebCore::PeerConnection::dispatchSimpleEvent):
(WebCore::PeerConnection::dispatchStartNegotiationTask):

  • p2p/PeerConnection.h: Added.

(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

  • p2p/PeerConnection.idl: Added.
  • p2p/SignalingCallback.h: Copied from Source/WebCore/page/MediaStreamClient.h.

(WebCore::SignalingCallback::~SignalingCallback):

  • p2p/SignalingCallback.idl: Added.
  • page/DOMWindow.idl:
  • page/MediaStreamClient.h:
  • page/MediaStreamController.cpp:

(WebCore::MediaStreamController::MediaStreamController):
(WebCore::MediaStreamController::unregisterFrameController):
(WebCore::MediaStreamController::onSignalingMessage):
(WebCore::MediaStreamController::frameToPagePeerConnectionId):
(WebCore::MediaStreamController::processSignalingMessage):
(WebCore::MediaStreamController::message):
(WebCore::MediaStreamController::onMessage):
(WebCore::MediaStreamController::addStream):
(WebCore::MediaStreamController::onAddStream):
(WebCore::MediaStreamController::removeStream):
(WebCore::MediaStreamController::onRemoveStream):
(WebCore::MediaStreamController::newPeerConnection):
(WebCore::MediaStreamController::closePeerConnection):
(WebCore::MediaStreamController::startNegotiation):
(WebCore::MediaStreamController::onNegotiationStarted):
(WebCore::MediaStreamController::onNegotiationDone):

  • page/MediaStreamController.h:
  • page/MediaStreamFrameController.cpp:

(WebCore::MediaStreamFrameController::Request::isSignalingRequest):
(WebCore::MediaStreamFrameController::createPeerConnection):
(WebCore::MediaStreamFrameController::newPeerConnection):
(WebCore::MediaStreamFrameController::closePeerConnection):
(WebCore::MediaStreamFrameController::startNegotiation):
(WebCore::MediaStreamFrameController::processSignalingMessage):
(WebCore::MediaStreamFrameController::message):
(WebCore::MediaStreamFrameController::addStream):
(WebCore::MediaStreamFrameController::removeStream):
(WebCore::MediaStreamFrameController::onMessage):
(WebCore::MediaStreamFrameController::onAddStream):
(WebCore::MediaStreamFrameController::onRemoveStream):
(WebCore::MediaStreamFrameController::onSignalingMessage):
(WebCore::MediaStreamFrameController::onNegotiationStarted):
(WebCore::MediaStreamFrameController::onNegotiationDone):

  • page/MediaStreamFrameController.h:

(WebCore::MediaStreamFrameController::ClientBase::isPeerConnection):
(WebCore::MediaStreamFrameController::PeerConnectionClient::PeerConnectionClient):
(WebCore::MediaStreamFrameController::PeerConnectionClient::~PeerConnectionClient):
(WebCore::MediaStreamFrameController::PeerConnectionClient::isPeerConnection):

LayoutTests:

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
12:38 PM Changeset in webkit [92303] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix after gesture recognizer changes.

12:36 PM Changeset in webkit [92302] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Improve position of context menu for QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65635

Reviewed by Andreas Kling.

Do not assume that the QDesktopWebView takes the entire canvas when
positioning the context menu.

  • UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebViewPrivate::showContextMenu):

12:18 PM Changeset in webkit [92301] by Lucas Forschler
  • 4 edits in branches/safari-534.51-branch/Source

Merge r90705.

12:09 PM Changeset in webkit [92300] by Joseph Pecoraro
  • 15 edits in trunk/Source

Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582

Reviewed by Pavel Feldman.

Source/WebCore:

Remove stale code. WebInspector.settings uses localStorage and
handles the "debuggerEnabled" state. So remove the only remaining
usage of load/saveSessionSetting.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebCoreSupport/WebInspectorClient.h:
12:06 PM Changeset in webkit [92299] by enne@google.com
  • 1 edit in branches/chromium/835/Source/WebCore/page/FrameView.cpp

Merge 92030 - [chromium] Only force slow scrolling for iframes under --force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=65394

Reviewed by James Robinson.

The previous code introduced by r91591 made composited frames as well
as non-composited subframes go down the slow scrolling path. Adjust
the check to use ownerElement to test for subframe and use
hasCompositedContent() which is a more correct test for compositing
than isEnclosedInCompositingLayer.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

TBR=enne@google.com
Review URL: http://codereview.chromium.org/7565014

11:56 AM Changeset in webkit [92298] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Crash in DocumentWriter::endIfNotLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=65581

Reviewed by Nate Chapin.

Source/WebCore:

This function is poorly designed because isLoadingMainResource is a
poor proxy for determing whether to flush/finish the parser. Really,
we should change how loads complete to match the model in HTML5, but
that's pretty tricky. In the meantime, this null check fixes the
crash.

I'm sure there's another bug on file about this crash, but we've never
been able to reproduce it. Thanks to Berend-Jan Wever for the test
case!

Test: fast/loader/reload-zero-byte-plugin.html

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::endIfNotLoadingMainResource):

LayoutTests:

  • fast/loader/reload-zero-byte-plugin-expected.txt: Added.
  • fast/loader/reload-zero-byte-plugin.html: Added.
11:40 AM Changeset in webkit [92297] by senorblanco@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

Merge 92227 - [Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560

Reviewed by James Robinson.

No new tests. (Printing has few tests, sadly.)

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7465097

11:38 AM Changeset in webkit [92296] by senorblanco@chromium.org
  • 2 edits in branches/chromium/835/Source/WebCore

Merge 91870 - Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests. Printing itself in Chrome has few tests, sadly. :(

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/7564022

11:38 AM Changeset in webkit [92295] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

WebCore images backing CG patterns should be released on the main thread
https://bugs.webkit.org/show_bug.cgi?id=65630

Reviewed by Sam Weinig.

  • platform/graphics/cg/PatternCG.cpp:

(WebCore::patternReleaseOnMainThreadCallback):
Deref the image.

(WebCore::patternReleaseCallback):
Call callOnMainThread.

11:11 AM Changeset in webkit [92294] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Teach BuilderToPort to distinguish between Release and Debug builders.
https://bugs.webkit.org/show_bug.cgi?id=65628

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
10:55 AM Changeset in webkit [92293] by leviw@chromium.org
  • 16 edits
    343 deletes in branches/chromium/835

REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
https://bugs.webkit.org/show_bug.cgi?id=64974

Reviewed by James Robinson.

Rolling back r87526 for Chrome 14.

Source/WebCore:

  • platform/Length.h:

(WebCore::Length::isIntrinsicOrAuto):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::embeddedContentBox):

  • rendering/RenderReplaced.cpp:

(WebCore::lengthIsSpecified):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):

  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::viewBoxToViewTransform):

  • svg/SVGSVGElement.h:

LayoutTests:

  • css2.1/20110323/replaced-intrinsic-001.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-002.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-003.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-004.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-005.htm: Removed.
  • css2.1/20110323/replaced-intrinsic-ratio-001.htm: Removed.
  • http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm: Removed.
  • http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Removed.
  • http/tests/misc/resources/embedded.svg: Removed.
  • http/tests/misc/resources/intrinsic-ratio-slow.pl: Removed.
  • http/tests/misc/resources/intrinsic-ratio.svg: Removed.
  • http/tests/misc/resources/svg-slow.pl: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/chromium-win/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Removed.
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/mac/svg/custom/object-no-size-attributes-expected.png: Removed.
  • platform/mac/svg/custom/object-no-size-attributes-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/mac/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/mac/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/mac/svg/hixie/text/003-expected.png: Removed.
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Removed.
  • platform/qt-4.8/svg/custom/object-sizing-expected.png: Removed.
  • platform/qt-4.8/svg/custom/object-sizing-expected.txt: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt-4.8/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-004-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-005-expected.txt: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Removed.
  • platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/qt/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/qt/svg/hixie/intrinsic/003-expected.txt: Removed.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt: Removed.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png: Removed.
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Removed.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
  • platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
  • platform/win/svg/hixie/intrinsic/003-expected.png: Removed.
  • platform/win/svg/hixie/intrinsic/003-expected.txt: Removed.
  • svg/custom/object-no-size-attributes.xhtml: Removed.
  • svg/custom/object-sizing-explicit-height.xhtml: Removed.
  • svg/custom/object-sizing-explicit-width-height.xhtml: Removed.
  • svg/custom/object-sizing-explicit-width.xhtml: Removed.
  • svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Removed.
  • svg/custom/object-sizing-no-width-height.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Removed.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Removed.
  • svg/custom/object-sizing.xhtml: Removed.
  • svg/custom/resources/embedded.svg: Removed.
  • svg/custom/resources/red-circle.svg: Removed.
  • svg/hixie/intrinsic/001.html: Removed.
  • svg/hixie/intrinsic/002.html: Removed.
  • svg/hixie/intrinsic/003.html: Removed.
  • svg/hixie/intrinsic/resources: Removed.
  • svg/hixie/intrinsic/resources/001.svg: Removed.
  • svg/hixie/intrinsic/resources/002.svg: Removed.
  • svg/hixie/intrinsic/resources/003.svg: Removed.
  • svg/hixie/intrinsic/resources/test-bl: Removed.
  • svg/hixie/intrinsic/resources/test-br: Removed.
  • svg/hixie/intrinsic/resources/test-tl: Removed.
  • svg/hixie/intrinsic/resources/test-tr: Removed.
  • svg/in-html/by-reference-expected.png: Removed.
  • svg/wicd/rightsizing-grid.xhtml: Removed.
  • svg/wicd/test-rightsizing-a.xhtml: Removed.
  • svg/wicd/test-rightsizing-b.xhtml: Removed.
  • svg/zoom/page/resources/intrinsic-ratio.svg: Removed.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Removed.
10:41 AM Changeset in webkit [92292] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix API tests.

Initialize threading before trying to allocate the WebContext.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::create):

10:22 AM Changeset in webkit [92291] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Windows nightly build fix after r91777

  • Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the

interface to maintain binary compatibility with Safari 5.1.

10:06 AM Changeset in webkit [92290] by andersca@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a Mac Lion skipped list.

  • platform/mac-lion: Added.
  • platform/mac-lion/Skipped: Added.
9:48 AM Changeset in webkit [92289] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Use appropriate macro for CSSPropertyImageRendering.
https://bugs.webkit.org/show_bug.cgi?id=65594

Reviewed by Simon Fraser.

No new tests / trivial code cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

9:48 AM Changeset in webkit [92288] by vsevik@chromium.org
  • 1 edit
    2 copies in branches/chromium/835

Merge 92167 - Web Inspector: button + "New style rule"
https://bugs.webkit.org/show_bug.cgi?id=65409

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-add-new-rule.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

  • inspector/styles/styles-add-new-rule-expected.txt: Added.
  • inspector/styles/styles-add-new-rule.html: Added.

TBR=pfeldman@chromium.org
BUG=91217
Review URL: http://codereview.chromium.org/7566008

9:46 AM Changeset in webkit [92287] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

FontCache::getFontData() does not set the familyIndex to cAllFamiliesScanned if the last font is a custom font
https://bugs.webkit.org/show_bug.cgi?id=65597

Reviewed by Simon Fraser.

No test added because behavior is unchanged, but this saves a call to getFontData().

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getFontData): Eliminated early return inside the loop, allowing execution
to continue and familyIndex to be set.

9:27 AM Changeset in webkit [92286] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Add RenderedPosition
https://bugs.webkit.org/show_bug.cgi?id=65221

Reviewed by Hajime Morita.

Add the skeleton for RenderedPosition and use it in rootBoxForLine.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/EditingAllInOne.cpp:
  • editing/RenderedPosition.cpp: Added.

(WebCore::RenderedPosition::RenderedPosition):

  • editing/RenderedPosition.h: Added.

(WebCore::RenderedPosition::isNull):
(WebCore::RenderedPosition::rootBox):
(WebCore::RenderedPosition::RenderedPosition):

  • editing/visible_units.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):

9:15 AM Changeset in webkit [92285] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] V8CSSRuleCustom.cpp: not all enum values are listed in switch statement
https://bugs.webkit.org/show_bug.cgi?id=65598

Reviewed by Dimitri Glazkov.

Added UNKNOWN_RULE to the switch statement.

No new tests. (No semantic change)

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

9:11 AM Changeset in webkit [92284] by pfeldman@chromium.org
  • 26 edits in trunk/Source

Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
https://bugs.webkit.org/show_bug.cgi?id=65510

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawRectHighlight):

  • inspector/DOMNodeHighlighter.h:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::drawHighlight):

  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):

  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelinePanel.prototype._hideRectHighlight):

  • inspector/front-end/inspector.js:

(WebInspector.highlightDOMNode):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::paintPageOverlay):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(paintWebView):

Source/WebKit/mac:

  • WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView drawRect:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderRelativeCoords):

Source/WebKit/win:

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

8:56 AM QtWebKitBuildBots edited by Csaba Osztrogonác
Update Qt and Mobility version on 4.7.x QtWebKit2.2 bot (diff)
8:49 AM Changeset in webkit [92283] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

[Qt] Fix running qmltests for WK2 in the bot
https://bugs.webkit.org/show_bug.cgi?id=65621

Reviewed by Csaba Osztrogonác.

The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
but now there's the case for WK2 UIProcess tests as well.

  • Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
8:33 AM Changeset in webkit [92282] by Dimitri Glazkov
  • 3 edits in trunk/Tools

Add a way to edit test expectations.
https://bugs.webkit.org/show_bug.cgi?id=64922

Implements a TestExpectationsEditor, which provides a standard way to
update and remove test expectations.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,

added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
enchilada.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
8:30 AM Changeset in webkit [92281] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Added two compositing tests whose pixel results on the
Mesa bots are different following
http://trac.webkit.org/changeset/92255.

Unreviewed.

  • platform/chromium/test_expectations.txt:
8:09 AM Changeset in webkit [92280] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: make text in popover selectable + make popover re-appear faster.
https://bugs.webkit.org/show_bug.cgi?id=65603

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype.setTimeout):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._handleMouseAction):

  • inspector/front-end/popover.css:

(.popover .content):

7:40 AM Changeset in webkit [92279] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for media/media-controls-clone.html.

  • platform/gtk/media/media-controls-clone-expected.png: Added.
  • platform/gtk/media/media-controls-clone-expected.txt: Added.
7:33 AM Changeset in webkit [92278] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Console scroll position should be saved when switching panels.
https://bugs.webkit.org/show_bug.cgi?id=65607

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._formatAsArrayEntry):
(WebInspector.ConsoleView.prototype.get scrollLeft):
(WebInspector.ConsoleView.prototype.set scrollLeft):
(WebInspector.ConsoleView.prototype.get scrollTop):
(WebInspector.ConsoleView.prototype.set scrollTop):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype._endStatusBarDragging):
(WebInspector.Drawer.prototype.get scrollLeft):
(WebInspector.Drawer.prototype.set scrollLeft):
(WebInspector.Drawer.prototype.get scrollTop):
(WebInspector.Drawer.prototype.set scrollTop):

7:25 AM Changeset in webkit [92277] by caio.oliveira@openbossa.org
  • 6 edits
    13 adds in trunk

[Qt] [WK2] Expose web view classes to QML
https://bugs.webkit.org/show_bug.cgi?id=65339

Reviewed by Benjamin Poulain.

.:

  • Source/WebKit.pro: Include QML plugin subdir in the build system for WK2.

Source/WebKit2:

This patch also uses QuickTest from QtDeclarative to provide the basic autotest
infrastructure for the exposed elements.

  • UIProcess/API/qt/qmlplugin/plugin.cpp: Added.

(WebKit2QmlPlugin::registerTypes):

  • UIProcess/API/qt/qmlplugin/qmldir: Added.
  • UIProcess/API/qt/qmlplugin/qmlplugin.pro: Added.
  • UIProcess/API/qt/qtouchwebpage.h: Expose load() to QML environment.
  • UIProcess/API/qt/qtouchwebview.h: Since QTouchWebPage* doesn't change once set

in the constructor, we mark the page property as CONSTANT. This avoid QML
warnings for not having a NOTIFY signal for the property change.

  • UIProcess/API/qt/tests/tests.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Added.
  • UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/test1.html: Added.
  • UIProcess/API/qt/tests/qmltests/qmltests.pro: Added.
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Added.
6:15 AM Changeset in webkit [92276] by andreas.kling@nokia.com
  • 3 edits in trunk/Tools

[Qt] MiniBrowser: Unbreak load progress indication.
https://bugs.webkit.org/show_bug.cgi?id=65614

Reviewed by Kenneth Rohde Christiansen.

loadProgress() was renamed to loadProgressChanged().

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onLoadProgressChanged):

  • MiniBrowser/qt/BrowserWindow.h:
6:05 AM Changeset in webkit [92275] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove flaky failures of fast/speech/input-appearance-*.html.

  • platform/chromium/test_expectations.txt:
5:29 AM Changeset in webkit [92274] by Martin Robinson
  • 2 edits in trunk/Tools

Build fix for WebKit2GTK+.

  • WebKitTestRunner/GNUmakefile.am: Include libInternals as one of

of the library dependencies of the injected bundle.

5:20 AM Changeset in webkit [92273] by Carlos Garcia Campos
  • 10 edits in trunk

[GTK] Install web and plugin processes in libexecdir instead of bindir
https://bugs.webkit.org/show_bug.cgi?id=65600

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Initialize libexec_PROGRAMS, only used by

WebKit2 in this moment.

Source/WebKit2:

Launch processes from libexecdir or WEBKIT_EXEC_PATH
environment variable when it's set. This variable will be used by
MiniBrowser and unit tests to find processes without having to
install them.

  • GNUmakefile.am:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

Tools:

Set WEBKIT_EXEC_PATH environment variable to use web and plugin
process from current directory instead of the intalled ones.

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c:

(main):

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/gtk/main.cpp:

(main):

4:55 AM Changeset in webkit [92272] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

[Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout
https://bugs.webkit.org/show_bug.cgi?id=65605

  • platform/qt/Skipped: Skip failing tests:
    • fast/frames/lots-of-objects.html
    • fast/frames/lots-of-iframes.html
    • editing/text-iterator/basic-iteration.html
4:14 AM Changeset in webkit [92271] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

libsoup-CRITICAL : soup_message_io_pause: assertion `io != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=64263

Reviewed by Martin Robinson.

Avoid any operation on not yet started messages and completed messages.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::startHTTPRequest): (WebCore::ResourceHandle::platformSetDefersLoading):
3:50 AM Changeset in webkit [92270] by vsevik@chromium.org
  • 8 edits
    1 copy in branches/chromium/835

Merge 91858 - Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/network/network-disable-cache-memory-expected.txt:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/resources/random-script.php: Added.

TBR=pfeldman@chromium.org
BUG=90757
Review URL: http://codereview.chromium.org/7563005

3:48 AM Changeset in webkit [92269] by jeremy@chromium.org
  • 7 edits in trunk/Source

[Chromium] Fix OOP font loading to work on 10.6.6 and above.
https://bugs.webkit.org/show_bug.cgi?id=65543

In 10.6.6 the function used to get the unique ID for an NSFont in the
renderer was changed so it fails in the sandbox (it now tries to access
the on-disk font file). In order to work around this, we get the font
ID from the browser process.

To speed things up, we introduce 2 levels of caching in WebKit. A font
name cache where we can perform a quick lookup without the need for the
font id and a font id cache which we can only lookup in after getting
the unique ID from the browser process.

Reviewed by Kenneth Russell.

No new tests since this is not readily testable.

Source/WebCore:

  • platform/chromium/PlatformBridge.h:
  • platform/graphics/chromium/CrossProcessFontLoading.h:
  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

  • public/mac/WebSandboxSupport.h: Plumb font ID parameter through.
  • src/PlatformBridge.cpp:

(WebCore::PlatformBridge::loadFont): ditto.

3:46 AM Changeset in webkit [92268] by Philippe Normand
  • 31 edits
    3 adds in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r92047.

  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/smallFonts-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/custom/external-paintserver-reference-expected.txt: Added.
  • platform/gtk/svg/custom/linking-base-external-reference-expected.txt: Added.
  • platform/gtk/svg/custom/text-linking-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
3:18 AM Changeset in webkit [92267] by vsevik@chromium.org
  • 1 edit in branches/chromium/835/Source/WebCore/inspector/InspectorPageAgent.cpp

Merge 91901 - Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::open):

TBR=vsevik@chromium.org
BUG=87345
Review URL: http://codereview.chromium.org/7565004

3:17 AM Changeset in webkit [92266] by hayato@chromium.org
  • 12 edits in trunk/Source/WebCore

Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529

Reviewed by Hajime Morita.

Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.

This is a minor update of r92256, which failed on chromium win builds.

No changes to functionality so no new tests.

  • dom/Event.cpp:

(WebCore::EventDispatchMediator::create):

  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEventDispatchMediator::create):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):

  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::create):

  • dom/WheelEvent.h:
1:28 AM Changeset in webkit [92265] by pfeldman@chromium.org
  • 38 edits in trunk/Source

Web Inspector: remove Node parameter from the InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorClient.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlight):

  • loader/EmptyClients.h:

(WebCore::EmptyInspectorClient::highlight):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::highlight):

  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::highlight):

  • src/WebDevToolsAgentImpl.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::highlight):

  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::highlight):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/haiku:

  • WebCoreSupport/InspectorClientHaiku.cpp:

(WebCore::InspectorClientHaiku::highlight):

  • WebCoreSupport/InspectorClientHaiku.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::highlight):

  • WebInspector/WebNodeHighlighter.h:
  • WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::highlight):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::highlight):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/InspectorClientWinCE.cpp:

(WebKit::InspectorClientWinCE::highlight):

  • WebCoreSupport/InspectorClientWinCE.h:

Source/WebKit/wx:

  • WebKitSupport/InspectorClientWx.cpp:

(WebCore::InspectorClientWx::highlight):

  • WebKitSupport/InspectorClientWx.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
1:20 AM Changeset in webkit [92264] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=65599
Image loads should trigger didFirstVisuallyNonEmptyLayout more easily

Reviewed by Dan Bernstein.

Tweak the heuristic pixel count so logo-sized images trigger didFirstVisuallyNonEmptyLayout.

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):

12:43 AM Changeset in webkit [92263] by Carlos Garcia Campos
  • 9 edits
    2 moves in trunk

[GTK] Reorganize pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=65548

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Initialize pkgconfigdir and pkgconfig_DATA which

are common to all libraries.

  • configure.ac: Update pkg-config files.

Source/JavaScriptCore:

  • GNUmakefile.am:
  • javascriptcoregtk.pc.in: Renamed from Source/WebKit/gtk/javascriptcoregtk.pc.in.

Source/WebKit/gtk:

  • GNUmakefile.am: Remove javascriptcore pc file references.

Source/WebKit2:

  • GNUmakefile.am: Rename pc file as webkit2gtk.pc.in. WebKit2

depends on gtk3 unconditionally so we don't need to use
WEBKITGTK_PC_NAME.

  • webkit2gtk.pc.in: Renamed from Source/WebKit2/gtk/webkit2.pc.in.
12:06 AM Changeset in webkit [92262] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebSocket: Could not handle zero length text frame.
https://bugs.webkit.org/show_bug.cgi?id=65592

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/zero-length-text.html

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

LayoutTests:

  • http/tests/websocket/tests/hybi/zero-length-text-expected.txt: Added.
  • http/tests/websocket/tests/hybi/zero-length-text.html: Added.
  • http/tests/websocket/tests/hybi/zero-length-text_wsh.py: Added.
Note: See TracTimeline for information about the timeline view.