Timeline
Aug 20, 2011:
- 11:26 PM Changeset in webkit [93489] by
-
- 1 edit2 copies in branches/chromium/835
Merge 93382 - REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
LayoutTests:
- fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
- fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/7703003
- 10:27 PM Changeset in webkit [93488] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
- ewk/ewk_view.h:
Fixes description of method, parameters and returned value of API
related to settings.
- 10:21 PM Changeset in webkit [93487] by
-
- 5 edits in trunk
JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572
Source/JavaScriptCore:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Changed the handling of const to add the dynamic scope depth.
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
LayoutTests:
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.
Added tests that reproduce the failure.
- fast/js/const-expected.txt:
- fast/js/resources/const.js:
(tryCatch1):
(tryCatch2):
(with1):
(with2):
- 10:14 PM Changeset in webkit [93486] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.
- ewk/ewk_view.h:
- 9:50 PM Changeset in webkit [93485] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.
Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.
- ewk/ewk_view.h:
- 9:37 PM Changeset in webkit [93484] by
-
- 5 edits in trunk/Source
Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
Covered by existing tests, and no code was changed.
- WebCore.gyp/WebCore.gyp:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573
Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.
- DEPS:
- 1:37 PM Changeset in webkit [93483] by
-
- 7 edits2 adds in trunk/Tools
garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625
Reviewed by Dimitri Glazkov.
This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction. The
patch also adds an Examine button to failure notifications. In a
future patch, I'll add a controller that wires this button up to
something useful.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
- 11:40 AM Changeset in webkit [93482] by
-
- 14 edits in trunk
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.
Source/WebCore:
Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
- bindings/generic/RuntimeEnabledFeatures.h:
- page/DOMWindow.idl:
LayoutTests:
Updated test results after adding HTMLSourceElement to the DOMWindow
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- 11:11 AM Changeset in webkit [93481] by
-
- 9 edits2 adds in trunk
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/dom/Range/insertNode-empty-fragment-crash.html
- dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.
LayoutTests:
- fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
- fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
- 8:54 AM Changeset in webkit [93480] by
-
- 4 edits in trunk/Tools
garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624
Reviewed by Dimitri Glazkov.
This patch creates a notification-based UI for build failures. The new
UI displays the same information that used to be displayed in the
infobar. There's lots of room for improvement in surfacing more
information, but this is a start.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 5:27 AM Changeset in webkit [93479] by
-
- 2 edits in trunk/LayoutTests
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515
Unreviewed gardening.
- platform/wk2/Skipped: Skip dependent test.
- 5:15 AM Changeset in webkit [93478] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626
Unreviewed gardening.
- platform/qt/Skipped:
- 12:30 AM Changeset in webkit [93477] by
-
- 3 edits2 adds in trunk
OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858
Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.
Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):
LayoutTests:
Added test case covering keySpline array length problem.
- svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
- svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.
Aug 19, 2011:
- 11:32 PM Changeset in webkit [93476] by
-
- 8 edits3 deletes in trunk
Unreviewed, rolling out r93415.
http://trac.webkit.org/changeset/93415
https://bugs.webkit.org/show_bug.cgi?id=66623
Introduces failing test (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Removed.
- inspector/front-end/DebuggerModel.js:
- inspector/front-end/SourceFile.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt: Removed.
- inspector/debugger/breakpoint-manager.html: Removed.
- 11:19 PM Changeset in webkit [93475] by
-
- 2 edits2 copies2 deletes in trunk/LayoutTests
Chromium Windows and Linux rebaselines. These baselines were so wrong.
- platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
- platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium/test_expectations.txt:
- 9:32 PM Changeset in webkit [93474] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93369 on GTK; the failure is tracked by the bug 66621.
- platform/gtk/Skipped:
- 9:27 PM Changeset in webkit [93473] by
-
- 1 edit1 copy1 delete in trunk/LayoutTests
Remove the left over from r93468; also fix Chromium Windows expectation
(Copied it over from fast/css/getComputedStyle/ and replaced Times with 'times new roman')
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- 8:41 PM Changeset in webkit [93472] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93392 on Windows; the failure is tracked by the bug 66620.
- platform/win/Skipped:
- 8:36 PM Changeset in webkit [93471] by
-
- 1 edit3 adds in trunk/LayoutTests
More rebaseline after r93068. Apparently Windows XP needs a separate baseline.
- platform/win-xp/editing: Added.
- platform/win-xp/editing/deleting: Added.
- platform/win-xp/editing/deleting/regional-indicators-expected.txt: Added.
- 8:29 PM Changeset in webkit [93470] by
-
- 1 edit1 move in trunk/LayoutTests
Redo the rebaseline done by r93353. The test that has been failing on GTK is
editing/deleting/regional-indicators.html, not editing/selection/regional-indicators.
The failure is still tracked by the bug 66501.
- platform/gtk/editing/deleting/regional-indicators-expected.txt: Copied from
LayoutTests/platform/gtk/editing/selection/regional-indicators-expected.txt.
- platform/gtk/editing/selection/regional-indicators-expected.txt: Removed.
- 8:19 PM Changeset in webkit [93469] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93392 on Qt. The failure is tracked by the bug 66619.
- platform/qt/Skipped:
- 8:12 PM Changeset in webkit [93468] by
-
- 1 edit1 copy4 deletes in trunk/LayoutTests
Rebaseline after r93430. Also removed superfluous expected result from Chromium directories.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced with
LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/chromium-cg-mac/fast/css/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt: Removed.
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- 7:59 PM Changeset in webkit [93467] by
-
- 2 edits in trunk/Source/JavaScriptCore
Only #include <signal.h> and require SA_RESTART when building with JSC_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=66617
Both <signal.h> and SA_RESTART usage are guarded behind ENABLE(JSC_MULTIPLE_THREADS).
But we cause a compile error if the platform doesn't support SA_RESTART regardless of
whether JSC_MULTIPLE_THREADS is enabled for the port. Instead, we shouldn't require
SA_RESTART support unless we are building with JSC_MULTIPLE_THREADS enabled.
Reviewed by Antonio Gomes.
- heap/MachineStackMarker.cpp:
- 7:17 PM Changeset in webkit [93466] by
-
- 12 edits1 add in trunk/Source/JavaScriptCore
The JSC JIT currently has no facility to profile and report
the types of values
https://bugs.webkit.org/show_bug.cgi?id=65901
Reviewed by Gavin Barraclough.
Added the ability to profile the values seen at function calls (both
arguments and results) and heap loads. This is done with emphasis
on performance. A value profiling site consists of: add, and,
move, and store; no branching is necessary. Each value profiling
site (called a ValueProfile) has a ring buffer of 8 recently-seen
values. ValueProfiles are stored in the CodeBlock; there will be
one for each argument (excluding this) and each heap load or callsite.
Each time a value profiling site executes, it stores the value into
a pseudo-random element in the ValueProfile buffer. The point is
that for frequently executed code, we will have 8 somewhat recent
values in the buffer and will be able to not only figure out what
type it is, but also to be able to reason about the actual values
if we wish to do so.
This feature is currently disabled by default. When enabled, it
results in a 3.7% slow-down on SunSpider.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addValueProfile):
(JSC::CodeBlock::numberOfValueProfiles):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
- bytecode/ValueProfile.h: Added.
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::computeProbability):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::probabilityOfInt32):
(JSC::ValueProfile::probabilityOfDouble):
(JSC::ValueProfile::probabilityOfCell):
(JSC::getValueProfileBytecodeOffset):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITCall.cpp:
(JSC::JIT::emit_op_call_put_result):
- jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
- jit/JSInterfaceJIT.h:
- wtf/Platform.h:
- wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::genericBinarySearch):
- 6:55 PM UsingGitWithWebKit edited by
- Update the git instructions so that git-svn and git update the same … (diff)
- 6:47 PM Changeset in webkit [93465] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't include DisallowCType.h when building on QNX
https://bugs.webkit.org/show_bug.cgi?id=66616
Reviewed by Antonio Gomes.
- config.h:
- 6:46 PM Changeset in webkit [93464] by
-
- 2 edits in trunk/LayoutTests
Skip the test added by r93369 because Window's DRT actually sleeps for
the amount of time leapForward is called upon. The failure is tracked by the bug 66551.
- platform/win/Skipped:
- 6:31 PM Changeset in webkit [93463] by
-
- 4 edits in trunk/Tools
[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606
Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.
The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 6:17 PM Changeset in webkit [93462] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement ExecutableAllocator::cacheFlush() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66611
Reviewed by Antonio Gomes.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 6:14 PM Changeset in webkit [93461] by
-
- 4 edits in trunk/Source/WebCore
AX WK2 Regression: WebKit outputs incorrect AX position in frames/iframes
https://bugs.webkit.org/show_bug.cgi?id=61289
Update the code to determine the position of accessibility elements on Mac for WK2,
so that elements within iframes are positioned correctly.
Reviewed by Darin Adler..
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::page):
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
- 5:45 PM Changeset in webkit [93460] by
-
- 4 edits in trunk/Source/WebCore
New XML parser: text nodes outside of root element not created for document fragments
https://bugs.webkit.org/show_bug.cgi?id=66604
When intializing a fragment parser, declare that the first element has been seen. Also, flush the text nodes when finishing parsing a document.
Reviewed by Darin Adler.
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::finish):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::finish):
- xml/parser/XMLTreeBuilder.h:
- 5:41 PM Changeset in webkit [93459] by
-
- 3 edits in trunk/Source/WebCore
MediaPlayerPrivateAVFoundationCF should use AVCFURLAssetCopyAudiovisualMIMETypes() to get list of supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=66612
Reviewed by Darin Adler.
No new tests, should be covered by existing media tests.
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added AVCFURLAssetCopyAudiovisualMIMETypes().
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::mimeTypeCache): Use AVCFURLAssetCopyAudiovisualMIMETypes() to build the cache of supported MIME types.
- 5:20 PM Changeset in webkit [93458] by
-
- 2 edits in trunk/Source/WebKit2
Another attempt at fixing the Windows build.
- UIProcess/PageClient.h:
- 4:59 PM Changeset in webkit [93457] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Fix for mis-merge. Radar 9750868
- 4:56 PM Changeset in webkit [93456] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build.
- WebProcess/Plugins/PluginController.h:
- 4:54 PM Changeset in webkit [93455] by
-
- 2 edits4 adds in trunk/LayoutTests
[chromium] GPU test expectation baseline update
Update pixel baselines for this test on mac and linux.
- platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:50 PM Changeset in webkit [93454] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Regression: Fix clang errors from r93424
https://bugs.webkit.org/show_bug.cgi?id=66609
Reviewed by James Robinson.
The invalidateRect function does not appear to be used anywhere
because the setNeedsDisplay function is used instead. Fix the Clang
error by just removing this unused vestigial base class function.
- platform/graphics/chromium/LayerChromium.h:
- 4:45 PM Changeset in webkit [93453] by
-
- 2 edits in trunk/Source/WebCore
Add new enums to npapi.h
https://bugs.webkit.org/show_bug.cgi?id=66608
Reviewed by Sam Weinig.
- bridge/npapi.h:
- 4:37 PM Changeset in webkit [93452] by
-
- 4 edits3 adds in trunk
libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423
Source/WebCore:
This makes the loop over the elements outside of the context actually update the element it's processing.
Reviewed by Darin Adler.
Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
LayoutTests:
Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
Reviewed by Darin Adler.
- fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
- platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
- 4:24 PM Changeset in webkit [93451] by
-
- 8 edits in trunk
Unreviewed, rolling out r93426.
http://trac.webkit.org/changeset/93426
https://bugs.webkit.org/show_bug.cgi?id=66607
Broke the Mac build by not building gtest.framework anymore
(Requested by andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/ThirdParty:
- gtest/README.WebKit:
- gtest/include/gtest/internal/gtest-port.h:
- gtest/msvc/gtest-md.vcproj:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
Tools:
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
- 4:22 PM Changeset in webkit [93450] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement WTF::atomic{Increment, Decrement}() for QNX
https://bugs.webkit.org/show_bug.cgi?id=66605
Reviewed by Darin Adler.
- wtf/Atomics.h:
(WTF::atomicIncrement):
(WTF::atomicDecrement):
- 4:18 PM Changeset in webkit [93449] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Remove various unreferenced bits from Chromium API headers
https://bugs.webkit.org/show_bug.cgi?id=66575
Reviewed by Tony Chang.
- public/WebApplicationCacheHost.h:
(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
- public/WebFrame.h:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didReceiveTitle):
- public/WebVideoFrame.h:
- 3:53 PM Changeset in webkit [93448] by
-
- 2 edits1 move1 delete in trunk/LayoutTests
[chromium] Cleanup some old plugin tests. Rebase plugin-javascript-access.html
on win and run plugin-initiate-popup-window on mac/linux to get results.
- platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/win/plugins/plugin-javascript-access-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/plugin-javascript-access-expected.txt.
- 3:50 PM Changeset in webkit [93447] by
-
- 23 edits2 adds in trunk/Source/WebKit2
Make the complex text input state a tri-state enum instead of a boolean
https://bugs.webkit.org/show_bug.cgi?id=62245
Reviewed by Sam Weinig.
This is to prepare the infrastructure for supporting the updated Cocoa text input model for plug-ins.
- PluginProcess/PluginControllerProxy.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setComplexTextInputState):
(WebKit::PluginControllerProxy::compositingRenderServerPort):
- Shared/Plugins/mac: Added.
- Shared/Plugins/mac/PluginComplexTextInputState.h: Added.
(WebKit::isValidPluginComplexTextInputState):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setPluginComplexTextInputState):
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPluginComplexTextInputState):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::setComplexTextInputEnabled):
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::setComplexTextInputState):
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginProxy.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::setComplexTextInputState):
(WebKit::PluginView::compositingRenderServerPort):
- WebProcess/Plugins/PluginView.h:
- 3:38 PM Changeset in webkit [93446] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update chromium test expectations
Remove = CRASH expectations for tests fixed by r93441.
- platform/chromium/test_expectations.txt:
- 3:34 PM Changeset in webkit [93445] by
-
- 9 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=66590
Re-name scrollbar painter types
Reviewed by Sam Weinig.
Source/JavaScriptCore:
WTF_USE_WK_SCROLLBAR_PAINTER is now WTF_USE_SCROLLBAR_PAINTER since WK no longer
applies.
- wtf/Platform.h:
Source/WebCore:
Names changed to remove references to WebKitSystemInterface since the
implementation is now in WebCore. And the type names changed to be more Objective-
Cish instead of C++ish
WTF_USE_WK_SCROLLBAR_PAINTER -> WTF_USE_SCROLLBAR_PAINTER
WKScrollbarPainterRef -> ScrollbarPainter
WKScrollbarPainterControllerRef -> ScrollbarPainterController
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
- 3:26 PM Changeset in webkit [93444] by
-
- 3 edits in trunk/Tools
[chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
https://bugs.webkit.org/show_bug.cgi?id=66603
Reviewed by Dirk Pranke.
The various ChromiumGpu ports should use the same child worker
selection logic as other ports so they can run with full
parallelization on multicore systems.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 3:20 PM Changeset in webkit [93443] by
-
- 4 edits in trunk/Source/WebCore
Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
https://bugs.webkit.org/show_bug.cgi?id=66499
Patch by Van Lam <vanlam@google.com> on 2011-08-19
Reviewed by Ryosuke Niwa.
Renamed VisiblePosition::honorEditableBoundary* to
honorEditingBoundary.
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
- editing/VisiblePosition.h:
- editing/visible_units.cpp:
(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
- 3:12 PM Changeset in webkit [93442] by
-
- 4 edits in trunk/LayoutTests
[chromium] Update results for japanese-rl-selection-repaint-in-regions.html that
changed after r93428.
- platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- 2:50 PM Changeset in webkit [93441] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=65063
Reviewed by Darin Fisher.
Fixes crashes due to a bad cast from Image to BitmapImage on skia ports
that use BitmapImageSingleFrameSkia. In the skia port
Image::isBitmapImage() returning true does not necessarily mean that
Image is of type BitmapImage.
Covered by fast/canvas/canvas-as-image.html and many other canvas
tests.
Patch originally by Tom Hudson.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
(WebCore::Image::currentFrameHasAlpha):
(WebCore::Image::notSolidColor):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
- 2:40 PM Changeset in webkit [93440] by
-
- 14 edits in trunk/Source/WebCore
Switch clipping for svg to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66586
Reviewed by Eric Seidel.
No new tests as no new functionality.
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
- rendering/svg/RenderSVGText.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
- svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):
(WebCore::SVGImage::setContainerSize):
- svg/graphics/SVGImage.h:
- 2:37 PM Changeset in webkit [93439] by
-
- 5 edits16 deletes in trunk
Unreviewed, rolling out r93425.
http://trac.webkit.org/changeset/93425
https://bugs.webkit.org/show_bug.cgi?id=66591
"The newly-added ASSERT is being triggered on several bots"
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
Source/WebCore:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabled):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::disabled):
- html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript):
LayoutTests:
- fast/css/link-disabled-attr-expected.txt:
- fast/css/stylesheet-enable-first-alternate-expected.txt: Removed.
- fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Removed.
- fast/css/stylesheet-enable-first-alternate-on-load.html: Removed.
- fast/css/stylesheet-enable-first-alternate.html: Removed.
- fast/css/stylesheet-enable-second-alternate-expected.txt: Removed.
- fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Removed.
- fast/css/stylesheet-enable-second-alternate-on-load.html: Removed.
- fast/css/stylesheet-enable-second-alternate.html: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Removed.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Removed.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Removed.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Removed.
- http/tests/css/resources/slow-loading-sheet-in-error.php: Removed.
- http/tests/css/resources/slow-loading-sheet.php: Removed.
- 2:24 PM Changeset in webkit [93438] by
-
- 11 edits in trunk/Source/WebCore
[chromium] Refactor updateCompositorResources to take an explicit GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=66432
Reviewed by James Robinson.
Covered by existing tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
- platform/graphics/chromium/VideoLayerChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
- platform/graphics/chromium/WebGLLayerChromium.h:
- 2:12 PM Changeset in webkit [93437] by
-
- 3 edits2 adds in trunk
Tell media player to prepareToPlay() at end of HTMLMediaElement::load()
https://bugs.webkit.org/show_bug.cgi?id=66414
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-load-preload-none.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
LayoutTests:
- media/video-load-preload-none-expected.txt: Added.
- media/video-load-preload-none.html: Added.
- 1:57 PM Changeset in webkit [93436] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66502
Reviewed by Eric Seidel.
Convert RenderBlock to new layout abstraction. Leave m_lineHight as a 30
bit int for now to avoid unnecessarily increasing the memory usage.
No new tests as no new functionality.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- 1:40 PM Changeset in webkit [93435] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderBoxModelObject to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66534
Reviewed by Eric Seidel.
Convert RenderBoxModelObject to new layout abstraction.
No new tests as no new functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::set):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::backgroundRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::borderWillArcInnerEdge):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):
- rendering/RenderBoxModelObject.h:
- 1:37 PM Changeset in webkit [93434] by
-
- 4 edits in trunk/Source/WebKit/chromium
Expose Fixed Layout Size mode to Chromium's WebKit API
https://bugs.webkit.org/show_bug.cgi?id=66568
Reviewed by Darin Fisher.
- public/WebView.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isFixedLayoutModeEnabled):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setFixedLayoutSize):
- src/WebViewImpl.h:
- 1:22 PM Changeset in webkit [93433] by
-
- 3 edits in trunk/Tools
[chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=66570
Reviewed by Mihai Parparita.
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h:
- 1:03 PM Changeset in webkit [93432] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions]Speed up RenderFlowThread repaint of regions
https://bugs.webkit.org/show_bug.cgi?id=66566
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.
When in printing or the repaint rectangle is empty, there is no need to iterate
the render flow regions in order to repaint.
Covered by existing tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::shouldRepaint):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- 12:44 PM Changeset in webkit [93431] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark touch tests as failing on OSX 10.5.
- platform/chromium/test_expectations.txt:
- 12:27 PM Changeset in webkit [93430] by
-
- 13 edits in trunk
[CSSRegions]Parse -webkit-region-break(after, before, inside)
https://bugs.webkit.org/show_bug.cgi?id=66559
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by David Hyatt.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSMutableStyleDeclaration.cpp:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionBreakBefore):
(WebCore::InheritedFlags::regionBreakInside):
(WebCore::InheritedFlags::regionBreakAfter):
(WebCore::InheritedFlags::setRegionBreakBefore):
(WebCore::InheritedFlags::setRegionBreakInside):
(WebCore::InheritedFlags::setRegionBreakAfter):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:26 PM Changeset in webkit [93429] by
-
- 8 edits in trunk/Source/WebCore
Switch RenderLayer to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66507
Reviewed by Eric Seidel.
Convert RenderLayer to new layout abstraction.
No new tests as no new functionality.
- rendering/LayoutTypes.h:
(WebCore::flooredLayoutSize):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
- rendering/RenderLayerCompositor.h:
- 12:19 PM Changeset in webkit [93428] by
-
- 3 edits2 adds in trunk
[CSSRegions]Content displayed in regions should not be scrollable
https://bugs.webkit.org/show_bug.cgi?id=66459
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-19
Reviewed by Darin Adler.
Source/WebCore:
Initially, when creating the style for the RenderFlowThread, overflowX and overflowY were both set to hidden,
so that RenderView did not display scrollbars when a RenderFlowThread exists. However, this allowed the possibility
of scrolling the content displayed in region.
Now, the RenderFlowThread objects are ignored in RenderBlock::insertPositionedObject and the style of the RenderFlowThread
can be set to visible, thus preventing scrolling of the content displayed in regions.
Test: fast/regions/content-flowed-into-regions-no-scroll.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::createFlowThreadStyle):
LayoutTests:
- fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
- fast/regions/content-flowed-into-regions-no-scroll.html: Added.
- 12:15 PM Changeset in webkit [93427] by
-
- 13 edits3 adds in trunk/Source/WebKit2
[Qt] [WK2] Provide API for intercept (and possible ignore) links clicked in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=65920
Reviewed by Benjamin Poulain.
This patch makes QDesktopWebView delegate the decision of whether a navigation
should proceed to a slot in QML. The user of the DesktopWebView must implement a
'navigationPolicyForUrl()' if it wants to use the feature.
Such feature is useful for implementing opening links in "new tab" by using a
specific mouse button or mouse button plus keyboard modifiers.
The patch introduces a internal Qt-level interface called PolicyInterface, that
is used by QtWebPageProxy to delegate policy calls. A concrete implementation is
provided for QDesktopWebView.
- Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Implement the serialization of the Request URL, which is the only data
we exposing from the Request.
- WebKit2.pro:
- UIProcess/qt/PolicyInterface.h: Added.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
- UIProcess/qt/QtWebPageProxy.h:
Register a Policy Client in the WK2 C API only if there's a PolicyInterface available.
- UIProcess/qt/ClientImpl.h:
- UIProcess/qt/ClientImpl.cpp:
(toPolicyInterface):
(toQtMouseButton):
(toQtKeyboardModifiers):
(qt_wk_decidePolicyForNavigationAction):
Implement the callback for the Page Policy Client. It will translate the
arguments to Qt jargon and call PolicyInterface.
- UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::QDesktopWebPageProxy):
- UIProcess/API/qt/qdesktopwebview.h:
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qdesktopwebview.cpp:
(toPolicyAction):
(hasMetaMethod):
(QDesktopWebViewPrivate::navigationPolicyForURL):
The concrete implementation for QDesktopWebView. Its private object implements
the PolicyInterface and try to call a possible function defined in QML (so return
value and arguments all QVariants). If there's no such a function, returns the
default UsePolicy, like if we haven't registered a PolicyClient in WK2 C API.
- UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml: Added.
- UIProcess/API/qt/tests/qmltests/common/test2.html: Added.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
Add a test for DesktopWebView QML element making use of a button and a modifier to
ignore a navigation.
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
For now, we don't have a PolicyInterface for QTouchWebView.
- 12:08 PM Changeset in webkit [93426] by
-
- 8 edits in trunk
TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
https://bugs.webkit.org/show_bug.cgi?id=66521
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
Reviewed by David Levin.
- gtest/include/gtest/internal/gtest-port.h:
- gtest/msvc/gtest-md.vcproj:
- gtest/README.WebKit:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
Tools:
This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=66521
Reviewed by David Levin.
- TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
- 11:54 AM Changeset in webkit [93425] by
-
- 5 edits16 adds in trunk
REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page
https://bugs.webkit.org/show_bug.cgi?id=65140
<rdar://problem/9835905>
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/css/stylesheet-enable-first-alternate-on-load.html
fast/css/stylesheet-enable-first-alternate.html
fast/css/stylesheet-enable-second-alternate-on-load.html
fast/css/stylesheet-enable-second-alternate.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html
The gist of the issue is that we were ignoring calls to HTMLLinkElement::setDisabled that would enable a
style sheet when we were loading a stylesheet (m_sheet was 0 and thus ignored the call per the spec).
FF goes against the CSS OM spec in this case and always keep an associated sheet as long as 'rel' hints
at a stylesheet link and href is present. Instead of siding with FF, I continued to follow the
specification and store the enabled via javascript state into m_scriptState (renamed from
m_isEnabledViaScript). This information gets merged back into the style sheet disabled state when it is
available.
While debugging the case at hand, I found some cases that were not properly handled and were fixed as
part of this change.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setDisabled): Always call setIsEnabledViaScript so that
the information is properly stored (either for recalcStyleSelector or just to store
the state during loading).
(WebCore::HTMLLinkElement::sheetLoaded): Merge back the state from m_scriptState to
the sheet's disabled state.
(WebCore::HTMLLinkElement::disabled): Account for the temporary state and return the
right value. It matches FF and what people would expect.
(WebCore::HTMLLinkElement::areDisabledAndScriptStatesConsistent): Debug only method
that checks that disabled() and isEnabledViaScript() are consistent with each other
(under some circumstances).
- html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript): Updated after m_isEnabledViaScript rename.
(WebCore::HTMLLinkElement::setIsEnabledViaScript): Added setter.
LayoutTests:
- fast/css/link-disabled-attr-expected.txt: This change is a progression, but we are still
not handling updates to the selected style set properly (already covered by bug 62407).
- fast/css/stylesheet-enable-first-alternate-expected.txt: Added.
- fast/css/stylesheet-enable-first-alternate-on-load-expected.txt: Added.
- fast/css/stylesheet-enable-first-alternate-on-load.html: Added.
- fast/css/stylesheet-enable-first-alternate.html: Added.
- fast/css/stylesheet-enable-second-alternate-expected.txt: Added.
- fast/css/stylesheet-enable-second-alternate-on-load-expected.txt: Added.
- fast/css/stylesheet-enable-second-alternate-on-load.html: Added.
- fast/css/stylesheet-enable-second-alternate.html: Added.
Those are a variation on the same theme: we disable some stylesheet and enable others,
either directly or later.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-expected.txt: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html: Added.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html: Added.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Added.
(onSheetLoaded):
(testWhenLoaded):
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Added.
(onSheetLoaded):
(testWhenLoaded):
- http/tests/css/resources/slow-loading-sheet-in-error.php: Added.
- http/tests/css/resources/slow-loading-sheet.php: Added.
Those 2 test cases relies on a slow loading stylesheet so that we can test the disabled() value while the alternate
sheet is asynchronously loading and then check them again once the sheet is loaded.
- 11:07 AM Changeset in webkit [93424] by
-
- 16 edits2 adds2 deletes in trunk/Source
[chromium] Split tiler into main thread / compositor thread versions
https://bugs.webkit.org/show_bug.cgi?id=66065
Reviewed by James Robinson.
Source/WebCore:
Covered by existing tests.
LayerTilerChromium is renamed to be CCLayerTilingData. Invalidation
and paint functionality is pushed into TiledLayerChromium and drawing
with GL is pushed into CCTiledLayerImpl. During tree synchronization,
the tiler properties and texture IDs are synchronized into
CCTiledLayerImpl.
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::bestTextureFormat):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tilerProgram):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::tilerProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzleAA):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/LayerTextureUpdater.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: Removed.
- platform/graphics/chromium/ManagedTexture.h:
(WebCore::ManagedTexture::textureId):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::UpdatableTile::dirty):
(WebCore::UpdatableTile::clearDirty):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::dumpLayerProperties):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::tileAt):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateTiles):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::protectVisibleTileTextures):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerTilingData.cpp: Added.
(WebCore::CCLayerTilingData::create):
(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
(WebCore::CCLayerTilingData::reset):
(WebCore::CCLayerTilingData::contentRectToTileIndices):
(WebCore::CCLayerTilingData::contentRectToLayerRect):
(WebCore::CCLayerTilingData::layerRectToContentRect):
(WebCore::CCLayerTilingData::tileContentRect):
(WebCore::CCLayerTilingData::tileLayerRect):
(WebCore::CCLayerTilingData::setLayerPosition):
(WebCore::CCLayerTilingData::growLayerToContain):
- platform/graphics/chromium/cc/CCLayerTilingData.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h.
(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::numTilesX):
(WebCore::CCLayerTilingData::numTilesY):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::textureOffset):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::hasBorderTexels):
(WebCore::CCLayerTilingData::isEmpty):
(WebCore::CCLayerTilingData::Tile::Tile):
(WebCore::CCLayerTilingData::Tile::i):
(WebCore::CCLayerTilingData::Tile::j):
(WebCore::CCLayerTilingData::Tile::moveTo):
(WebCore::CCLayerTilingData::TileMapKeyTraits::emptyValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::constructDeletedValue):
(WebCore::CCLayerTilingData::TileMapKeyTraits::isDeletedValue):
(WebCore::CCLayerTilingData::tiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::DrawableTile):
(WebCore::DrawableTile::textureId):
(WebCore::DrawableTile::setTextureId):
(WebCore::CCTiledLayerImpl::CCTiledLayerImpl):
(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::tileAt):
(WebCore::CCTiledLayerImpl::createTile):
(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::setTilingData):
(WebCore::CCTiledLayerImpl::syncTextureId):
(WebCore::isCCW):
(WebCore::computeEdge):
(WebCore::intersect):
(WebCore::CCTiledLayerImpl::drawTiles):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::setSkipsDraw):
(WebCore::CCTiledLayerImpl::setTextureOrientation):
(WebCore::CCTiledLayerImpl::setSampledTexelFormat):
- platform/graphics/gpu/TilingData.h:
Source/WebKit/chromium:
Add a test for assignment and copy constructor for TilingData.
- tests/TilingDataTest.cpp:
(WebCore::TEST):
- 10:51 AM Changeset in webkit [93423] by
-
- 2 edits in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Cleaning up test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 10:47 AM Changeset in webkit [93422] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Add correct baseline for merge-end-list.html on OSX 10.5.
- platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-list-expected.png: Added.
- 9:29 AM Changeset in webkit [93421] by
-
- 2 edits in trunk/Source/WebCore
Better build fix after r93384.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use WTF::Unicode wrapper instead of ICU.
- 9:22 AM Changeset in webkit [93420] by
-
- 2 edits in trunk/Source/WebKit2
WebProcess crashes during startup if libdispatch is initialized by WebProcessShim.dylib
https://bugs.webkit.org/show_bug.cgi?id=66508
<rdar://problem/9828476>
Reviewed by Mark Rowe.
- mac/MainMac.cpp:
(closeUnusedFileDescriptors):
Check if a file descriptor is a kqueue and don't close it if that is the case. While this
isn't a complete fix, (it won't work if other initializers end up creating non-kqueue file descriptors)
it's good enough for Snow Leopard. For Lion, we should use the new posix_spawn API that lets you whitelist
file descriptors from the parent process.
- 9:17 AM Changeset in webkit [93419] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: update scope variables upon value changes via console.
https://bugs.webkit.org/show_bug.cgi?id=54720
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- 9:16 AM Changeset in webkit [93418] by
-
- 2 edits in trunk/Tools
Add project file changes I left out in r93417
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 9:14 AM Changeset in webkit [93417] by
-
- 1 edit5 adds in trunk/Tools
Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
NSScreen
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
(-[SimpleObject setValue:]): Original implementation.
(TestWebKitAPI::setValue2):
(TestWebKitAPI::setValue3):
Swizzled implementations.
(TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
instance method.
- TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
- TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
(TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
(TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
- 9:06 AM Changeset in webkit [93416] by
-
- 2 edits in trunk/Tools
Fix _path_to_apache() error reporting
https://bugs.webkit.org/show_bug.cgi?id=66486
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-19
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- 8:50 AM Changeset in webkit [93415] by
-
- 8 edits3 adds in trunk
Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/breakpoint-manager.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/BreakpointManager.js: Added.
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt: Added.
- inspector/debugger/breakpoint-manager.html: Added.
- 8:39 AM Changeset in webkit [93414] by
-
- 2 edits in trunk/Tools
Windows build fix after r93404
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
- 8:37 AM Changeset in webkit [93413] by
-
- 2 edits in trunk/Tools
Add leandrogracia to the committers list
https://bugs.webkit.org/show_bug.cgi?id=66552
Also fix line endings in file.
No reviewed required.
- Scripts/webkitpy/common/config/committers.py:
- 8:29 AM Changeset in webkit [93412] by
-
- 2 edits in trunk/Tools
Fix compilation issue in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66554
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-19
Reviewed by Martin Robinson.
- WebKitTestRunner/PixelDumpSupport.cpp:
- 8:27 AM Changeset in webkit [93411] by
-
- 2 edits in trunk/Source/WebCore
Fix typo
- dom/DOMAllInOne.cpp:
- 8:25 AM Changeset in webkit [93410] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
https://bugs.webkit.org/show_bug.cgi?id=65408
Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_frame.cpp:
(_ewk_frame_smart_add):
- 8:19 AM Changeset in webkit [93409] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Change condition checking logic related with both change of position and offset for backing store.
https://bugs.webkit.org/show_bug.cgi?id=66028
As backing store's position and offset change can occur at the same time,
the checking of offset change shouldn't be "else if" statement.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_smart_calculate):
- 8:11 AM Changeset in webkit [93408] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r93385
- dom/DOMAllInOne.cpp: Added EventDispatcMediator.cpp.
- 7:56 AM Changeset in webkit [93407] by
-
- 24 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] Add a basic engine to control the content of the viewport
https://bugs.webkit.org/show_bug.cgi?id=66383
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-19
Reviewed by Andreas Kling.
Add ViewportInteractionEngine to handle the content of the viewport. The class make
sure the QTouchWebPage stays in the viewport and in the boundaries.
- UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::loadDidCommit):
- UIProcess/API/qt/qdesktopwebview_p.h:
- UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage): Set the transform origin to the top left so
we can asume the position 0, 0 is always the top left of the page.
(QTouchWebPagePrivate::_q_commitScaleChange): Make commitScaleChange a slot
in order to completely decouple the ViewportInteractionEngine and the WebKit classes.
- UIProcess/API/qt/qtouchwebpage.h:
- UIProcess/API/qt/qtouchwebpage_p.h:
- UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::loadDidCommit):
(QTouchWebViewPrivate::_q_viewportRectUpdated): Make _q_viewportRectUpdated() a slot
for reducing coupling.
(QTouchWebViewPrivate::updateViewportConstraints):
(QTouchWebViewPrivate::setViewportArguments):
(QTouchWebView::geometryChanged):
- UIProcess/API/qt/qtouchwebview.h:
- UIProcess/API/qt/qtouchwebview_p.h:
- UIProcess/qt/ClientImpl.cpp:
(qt_wk_didCommitLoadForFrame):
- UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
- UIProcess/qt/QtGestureRecognizer.h: Change the gesture recognizer to talk directly
to the ViewportInteractionEngine instead of interacting through TouchViewInterface.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::QtPanGestureRecognizer):
(WebKit::QtPanGestureRecognizer::recognize):
- UIProcess/qt/QtPanGestureRecognizer.h:
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::QtPinchGestureRecognizer):
(WebKit::QtPinchGestureRecognizer::recognize):
- UIProcess/qt/QtPinchGestureRecognizer.h:
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadDidCommit): Add the loadCommited callback in order
to reset the viewport state when the page change.
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::TouchViewInterface):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::loadDidCommit):
- UIProcess/qt/TouchViewInterface.h:
- UIProcess/qt/ViewInterface.h:
- UIProcess/qt/ViewportInteractionEngine.cpp: Added.
(WebKit::visibleRectInContentCoordinate):
(WebKit::contentRectInViewportCoordinate):
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::reset):
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::panGestureStarted):
(WebKit::ViewportInteractionEngine::panGestureRequestScroll):
(WebKit::ViewportInteractionEngine::panGestureCancelled):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentGeometryChanged):
(WebKit::ViewportInteractionEngine::contentScaleChanged):
(WebKit::ViewportInteractionEngine::updateContentIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentScaleIfNeeded):
(WebKit::ViewportInteractionEngine::updateContentPositionIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionToBoundaries):
(WebKit::ViewportInteractionEngine::animateContentScaleToBoundaries):
(WebKit::ViewportInteractionEngine::scaleContent):
- UIProcess/qt/ViewportInteractionEngine.h: Added.
(WebKit::ViewportInteractionEngine::Constraints::Constraints):
(WebKit::operator==):
- UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::QTouchWebPageProxy):
- UIProcess/qt/qtouchwebpageproxy.h:
- WebKit2.pro:
- 7:55 AM Changeset in webkit [93406] by
-
- 2 edits in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:51 AM Changeset in webkit [93405] by
-
- 3 edits1 copy1 add in trunk/Tools
Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
This will make it easier to write other WebKit-agnostic tests
Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
code in other WebKit-agnostic tests
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
(TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
WebKitAgnosticTest handles for us.
(TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
- TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
(TestWebKitAPI::WebKitAgnosticTest::loadSynchronously): Code came from
DynamicDeviceScaleFactor::runTest.
- TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
DynamicDeviceScaleFactor.WebKit.
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
DynamicDeviceScaleFactor.WebKit2.
- 7:50 AM Changeset in webkit [93404] by
-
- 46 edits in trunk/Tools
Clean up #includes in TestWebKitAPI
Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
Reviewed by Anders Carlsson.
- TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
files and WebKit/WebKit.h for ObjC files.
- TestWebKitAPI/InjectedBundleController.cpp:
- TestWebKitAPI/JavaScriptTest.h:
- TestWebKitAPI/PlatformUtilities.h:
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/Test.h:
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
- TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
- TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
- TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
- TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
- TestWebKitAPI/Tests/WebKit2/Find.cpp:
- TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
- TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
- TestWebKitAPI/Tests/WebKit2/WKString.cpp:
- TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
- TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
- TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
- TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
- TestWebKitAPI/TestsController.cpp:
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
- 7:47 AM Changeset in webkit [93403] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-08-19 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating baselines.
Unreviewed.
- platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/merge-end-list-expected.png: Added.
- platform/chromium-cg-mac/editing/pasteboard/paste-text-008-expected.png: Added.
- 7:46 AM Changeset in webkit [93402] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
https://bugs.webkit.org/show_bug.cgi?id=66549
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-19
Reviewed by Benjamin Poulain.
- UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::paint):
- UIProcess/qt/QtWebPageProxy.h:
- 7:12 AM Changeset in webkit [93401] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-19
Reviewed by Kent Tamura.
Adds doxygen documentation to the structures in ewk_view.cpp.
- ewk/ewk_view.cpp:
- 6:41 AM Changeset in webkit [93400] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Extensions API][chromium] webInspector.resources deprecation warning is given even for extensions that don't use webInspector.resources
https://bugs.webkit.org/show_bug.cgi?id=66553
Reviewed by Pavel Feldman.
- src/js/DevTools.js:
(WebInspector.platformExtensionAPI):
- 6:23 AM Changeset in webkit [93399] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Modify type of both col and row parameters for backing store's internal api.
https://bugs.webkit.org/show_bug.cgi?id=65302
As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill
and ewk_tiled_backing_store_item_add are different from each other, I modify type of them.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.
- ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
- 5:50 AM Changeset in webkit [93398] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: getAttributes should work on a single node, not array.
https://bugs.webkit.org/show_bug.cgi?id=66544
Reviewed by Adam Roben.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getAttributes):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
- 5:26 AM Changeset in webkit [93397] by
-
- 4 edits in trunk
[v8] CSS wrapper objects retention
https://bugs.webkit.org/show_bug.cgi?id=66377
Reviewed by Pavel Feldman.
Disable object grouping for CSS object wrappers.
This logic leads to hard to debug use-after-free problems.
Source/WebCore:
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 5:23 AM Changeset in webkit [93396] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: introduce NodeId inherited from integer in the DOM domain description.
https://bugs.webkit.org/show_bug.cgi?id=66491
Drive-by rename of couple of DOM domain protocol methods.
Reviewed by Adam Roben.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::requestNode):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
- inspector/generate-inspector-idl:
- 5:13 AM Changeset in webkit [93395] by
-
- 2 edits in trunk/Source/WebCore
IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity.
https://bugs.webkit.org/show_bug.cgi?id=66470
Reviewed by Tony Gentilcore.
- storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::deleteObjectStore):
- 4:37 AM Changeset in webkit [93394] by
-
- 2 edits in trunk/LayoutTests
[Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369
https://bugs.webkit.org/show_bug.cgi?id=66514
Skip it.
- platform/qt/Skipped:
- 3:16 AM Changeset in webkit [93393] by
-
- 13 edits6 adds in trunk
[WebSocket] CloseEvent's code and reason properties support.
https://bugs.webkit.org/show_bug.cgi?id=66362
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-19
Reviewed by Kent Tamura.
Current WebSocket implementation miss code and reason properties
in CloseEvent. This change expose incoming closing frame's code
and reason to JavaScript API.
Source/WebCore:
Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html
http/tests/websocket/tests/hybi/workers/close-code-and-reason.html
- websockets/CloseEvent.h:
(WebCore::CloseEvent::initCloseEvent):
(WebCore::CloseEvent::code):
(WebCore::CloseEvent::reason):
(WebCore::CloseEvent::CloseEvent):
- websockets/CloseEvent.idl:
Add code and reason properies.
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
Add implement to handle code and reason.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::processFrame):
- websockets/WebSocketChannel.h:
Add closing frame payload parser.
- websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerContextDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
Add implement to handle code and reason.
LayoutTests:
- http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt: Added.
- http/tests/websocket/tests/hybi/close-code-and-reason.html: Added.
- http/tests/websocket/tests/hybi/close-code-and-reason_wsh.py: Added.
- http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt: Added.
- http/tests/websocket/tests/hybi/workers/close-code-and-reason.html: Added.
- http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Added.
(postResult):
(ws.onopen):
(ws.onmessage):
(ws.onclose):
- 2:43 AM Changeset in webkit [93392] by
-
- 19 edits2 adds in trunk
.: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Add export for window.internals object.
- Source/autotools/symbols.filter:
Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
But these are low-level API and caller should take care of word boundary.
This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
which handles word boundary correctly.
Test: editing/spelling/spelling-insert-html.html
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAndBadGrammar):
- testing/Internals.cpp:
(WebCore::Internals::markerCountOf): Added.
(WebCore::Internals::markedRangeAt): Added.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Add exports for window.internals object.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
https://bugs.webkit.org/show_bug.cgi?id=65902
Reviewed by Ryosuke Niwa.
Existing expectation was wrong because of some markers on substrings of words.
With this fix, Editor now rejects such markers.
- editing/spelling/spelling-insert-html-expected.txt: Added.
- editing/spelling/spelling-insert-html.html: Added.
- platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
- platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
- platform/mac/editing/pasteboard/merge-after-delete-expected.png:
- platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/mac/editing/pasteboard/merge-end-list-expected.png:
- platform/mac/editing/pasteboard/merge-end-table-expected.png:
- platform/mac/editing/pasteboard/paste-text-008-expected.png:
- 1:58 AM Changeset in webkit [93391] by
-
- 2 edits in trunk/Source/WebCore
Run-time error fix in WebKit-GTK with video support disabled.
https://bugs.webkit.org/show_bug.cgi?id=66541
Definition of the function extraFullScreenStyleSheet() in webkit-gtk
lies outside ENABLE(VIDEO) guard, resulting in runtime error while
trying to launch GtkLauncher with video support disabled.
Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-19
Reviewed by Philippe Normand.
Run-time error fix. No test cases were added.
- platform/gtk/RenderThemeGtk.h:
- 1:46 AM Changeset in webkit [93390] by
-
- 7 edits in trunk
input[maxlength=0] should ignore text input.
https://bugs.webkit.org/show_bug.cgi?id=65497
Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-19
Reviewed by Kent Tamura.
Source/WebCore:
Changed the valid range of maxlength.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
Changed maxlength check condition.
LayoutTests:
- fast/forms/input-text-paste-maxlength-expected.txt: Added a case that maxlength=0
- fast/forms/input-text-paste-maxlength.html: ditto.
- fast/forms/script-tests/textarea-maxlength.js: ditto.
(createFocusedTextAreaWithMaxLength):
- fast/forms/textarea-maxlength-expected.txt: ditto.
- 1:42 AM Changeset in webkit [93389] by
-
- 5 edits in trunk
Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
https://bugs.webkit.org/show_bug.cgi?id=66482
There are functions in the API with multiple optional arguments.
When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
This can be solved with passing the arguments as an object.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/CodeGeneratorInspector.pm:
- inspector/front-end/RemoteObject.js:
LayoutTests:
- inspector/debugger/debugger-set-breakpoint-regex.html:
- 12:54 AM Changeset in webkit [93388] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix after r93384.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Aug 18, 2011:
- 10:44 PM Changeset in webkit [93387] by
-
- 5 edits3 adds in trunk
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114
Source/WebCore:
Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).
Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the world space transform.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Test: compositing/backface-visibility-hierarchical-transform.html
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):
LayoutTests:
This case tests if backface visibility properly accounts for a hierarchy
of transforms. In particular, this test forces Chromium to create a
hierarchy of RenderSurfaces.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by James Robinson.
- compositing/backface-visibility-hierarchical-transform-expected.png: Added.
- compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
- compositing/backface-visibility-hierarchical-transform.html: Added.
- 9:51 PM Changeset in webkit [93386] by
-
- 6 edits2 adds in trunk
[skia] -webkit-transform breaks -webkit-mask
https://bugs.webkit.org/show_bug.cgi?id=66442
Source/WebCore:
The problem here is that in RenderBox::paintMaskImages, if we are in
a transform with a rotation, scale or skew we set the composite mode to
be DestinationIn and then create a transparency layer, then paint the
mask with SourceOver and end the transparency layer. (The normal case
is just to use DestinationIn to paint the mask.)
In skia when we create transparency layers we don't pass on the composite
mode, so when we end the transparency layer it is composited back using
SourceOver. The fix is to pass on the composite mode when creating
transparency layers in skia.
Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::getXfermodeMode):
- platform/graphics/skia/PlatformContextSkia.h:
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- platform/chromium-linux/fast/css/transformed-mask-expected.png: Added.
- platform/chromium-linux/fast/css/transformed-mask-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:46 PM Changeset in webkit [93385] by
-
- 16 edits2 adds in trunk/Source/WebCore
Isolate EventDispatchMediator into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=66458
Reviewed by Ryosuke Niwa.
Extracted EventDispatchMediator.h and EventDispatchMediator.cpp
out of Event.h and Event.cpp Also moved FocusEventDispatchMediator
and BlurEventDispatchMediator from Event.{h|cpp} to
EventDispatchMediator.{h|cpp}.
No new tests since this is just refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Event.cpp:
- dom/Event.h:
- dom/EventDispatchMediator.cpp: Added.
(WebCore::EventDispatchMediator::create):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::dispatchEvent):
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
- dom/EventDispatchMediator.h: Added.
(WebCore::EventDispatchMediator::~EventDispatchMediator):
(WebCore::EventDispatchMediator::event):
(WebCore::EventDispatchMediator::EventDispatchMediator):
(WebCore::EventDispatchMediator::setEvent):
- dom/EventDispatcher.cpp:
- dom/KeyboardEvent.h:
- dom/MouseEvent.h:
- dom/Node.cpp:
- dom/ScopedEventQueue.cpp:
- dom/UIEvent.h:
- dom/WheelEvent.h:
- 8:34 PM Changeset in webkit [93384] by
-
- 2 edits in trunk/Source/WebCore
Mid-word break can occur between a character and a combining mark
https://bugs.webkit.org/show_bug.cgi?id=66529
Reviewed by Simon Fraser.
No test added because I could not find a combining mark with a non-zero advance in
any of the system fonts and tests fonts.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a
combining mark.
- 6:58 PM Changeset in webkit [93383] by
-
- 2 edits in trunk/Tools
new-run-webkit-tests hung while acquiring http lock on snow leopard bots
https://bugs.webkit.org/show_bug.cgi?id=64886
Temporarily disable the http locking to work around the issue.
I'm not actually sure if this is going to work or improve things
much.
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 6:33 PM Changeset in webkit [93382] by
-
- 3 edits2 adds in trunk
REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
LayoutTests:
- fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
- fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
- 6:17 PM Changeset in webkit [93381] by
-
- 6 edits in trunk/Source/WebKit/chromium
Chromium plumbing for webkitRequestFullScreen
https://bugs.webkit.org/show_bug.cgi?id=66031
Reviewed by Darin Fisher.
- public/WebView.h:
- public/WebViewClient.h:
(WebKit::WebViewClient::enterFullscreenForElement):
(WebKit::WebViewClient::exitFullscreenForElement):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::enterFullScreenForElement):
(WebKit::ChromeClientImpl::exitFullScreenForElement):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::exitFullscreen):
- src/WebViewImpl.h:
- 6:09 PM Changeset in webkit [93380] by
-
- 5 edits in trunk/Source/WebCore
New XML parser: scripting support
https://bugs.webkit.org/show_bug.cgi?id=66406
Reviewed by Adam Barth.
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::resumeParsing):
(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing
(WebCore::NewXMLDocumentParser::notifyFinished):
- xml/parser/NewXMLDocumentParser.h:
(WebCore::NewXMLDocumentParser::pauseParsing):
- xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags
(WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
- xml/parser/XMLTreeBuilder.h:
- 6:04 PM Changeset in webkit [93379] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Broken rendering occured when resized in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=66271
Force rendering when ewk_view resized.
It's because Evas_Object doesn't generate any rendering request although
it was changed.
Reviewed by Tony Chang.
- ewk/ewk_view.cpp:
(_ewk_view_smart_calculate):
- 5:58 PM Changeset in webkit [93378] by
-
- 35 edits in trunk/Source
Move allocation in constructors into separate constructorBody() methods
https://bugs.webkit.org/show_bug.cgi?id=66265
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-18
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jsc.cpp:
(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
- runtime/ErrorInstance.h:
(JSC::ErrorInstance::constructorBody):
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::constructorBody):
- runtime/ErrorPrototype.h:
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::FunctionExecutable::constructorBody):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/InternalFunction.h:
(JSC::InternalFunction::constructorBody):
- runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
- runtime/JSByteArray.h:
(JSC::JSByteArray::constructorBody):
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::constructorBody):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::constructorBody):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::constructorBody):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
- runtime/NativeErrorPrototype.h:
- runtime/StringObject.cpp:
- runtime/StringObject.h:
(JSC::StringObject::create):
- runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
- runtime/StringPrototype.h:
(JSC::StringPrototype::create):
Source/WebCore:
No new tests.
Refactoring to put all allocations that need to be done after the object's
initialization list has executed but before the object is ready for use
into a separate constructorBody() method. This method is still called by the constructor,
so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.mm:
- bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
- bridge/runtime_array.cpp:
- bridge/runtime_array.h:
(JSC::RuntimeArray::create):
- 5:44 PM Changeset in webkit [93377] by
-
- 18 edits1 add in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
Reviewed by Sam Weinig.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/NSScrollerImpDetails.h: Added.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries: Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=66495
Lion-specific scroller SPIs can use forward declaration instead of
WebKitSystemInterface
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:23 PM Changeset in webkit [93376] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline
https://bugs.webkit.org/show_bug.cgi?id=66515
Reviewed by Darin Adler.
No test because none of the system fonts and test fonts have an incorrectly-specified descender value.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant
the same amount, but negative. This is consistent with what Core Text does.
- 5:18 PM Changeset in webkit [93375] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025
Reviewed by Gavin Barraclough.
This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
stanford-crypto-sha256-iterative). It looks like it might have
a speed-up in SunSpider (though not statistically significant or
particularly reproducible) and a slight slow-down in V8 (0.14%,
not statistically significant). It does slow down v8-crypto by
1.5%.
- dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
- dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
- dfg/DFGOperations.cpp:
- 5:00 PM Changeset in webkit [93374] by
-
- 3 edits in trunk/LayoutTests
[chromium] Fix results. Just copy over the platform independent results.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png:
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.png:
- 4:55 PM Changeset in webkit [93373] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:52 PM Changeset in webkit [93372] by
-
- 1 copy in tags/Safari-534.51.17
New tag.
- 4:29 PM Changeset in webkit [93371] by
-
- 1 edit22 adds in trunk/LayoutTests
Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac
https://bugs.webkit.org/show_bug.cgi?id=66493
The expected results of the layout tests written for
https://bugs.webkit.org/show_bug.cgi?id=57785
differ between WebKitt Mac and WebKit2 Mac.
WebKit2 Mac matches the cross-platform results.
WebKit1 Mac has a special set of test results.
Reviewed by Tony Chang.
- platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.
- 4:28 PM Changeset in webkit [93370] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Mark editing/selection/regional-indicators.html as timing
out on Linux debug and rebaseline 2 tests.
- platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
- platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:07 PM Changeset in webkit [93369] by
-
- 4 edits2 adds in trunk
positionForPoint returns wrong VisiblePosition at bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=65356
Reviewed by David Hyatt.
Source/WebCore:
The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.
For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
until the end to obtain the offset 7 from the inline box for "DC".
Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
on the left or the right of the position to compute the appropriate offset following the NSTextView convention.
This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
LTR or RTL text in a RTL or LTR block respectively.
Test: editing/selection/caret-at-bidi-boundary.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
- rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
(WebCore::createVisiblePositionForBox):
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
(WebCore::RenderText::positionForPoint):
LayoutTests:
- editing/selection/caret-at-bidi-boundary-expected.txt: Added.
- editing/selection/caret-at-bidi-boundary.html: Added.
- 4:05 PM Changeset in webkit [93368] by
-
- 2 edits in trunk/Source/WebCore
--webkit-visual-word renaming right/leftWordPositionAcrossBoundary
https://bugs.webkit.org/show_bug.cgi?id=66436
Reviewed by Ryosuke Niwa.
Rename them to right/leftWordPositionIgnoringEditingBoundary.
- editing/visible_units.cpp:
(WebCore::leftWordPositionIgnoringEditingBoundary):
(WebCore::rightWordPositionIgnoringEditingBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
- 4:05 PM Changeset in webkit [93367] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium
https://bugs.webkit.org/show_bug.cgi?id=66441
Reviewed by Darin Fisher.
- public/WebAudioSourceProvider.h: Added.
(WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):
- public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::audioSourceProvider):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
- src/WebMediaPlayerClientImpl.h:
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):
- 4:02 PM Changeset in webkit [93366] by
-
- 1 edit in branches/safari-534.51-branch/Source/JavaScriptCore/ChangeLog
Merge r92804.
- 4:01 PM Changeset in webkit [93365] by
-
- 1 edit in branches/safari-534.51-branch/Source/WebKit2/ChangeLog
Merge r92729.
- 4:00 PM Changeset in webkit [93364] by
-
- 4 edits in branches/safari-534.51-branch/Source
Merge r91998.
- 3:57 PM Changeset in webkit [93363] by
-
- 5 edits2 adds in trunk/Source/WebCore
Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725
Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with declspec(dllimport),
and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
until a media element is used.
Reviewed by Eric Carlson.
No new tests as no change in functionality.
- WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
- platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
- platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
- 3:49 PM Changeset in webkit [93362] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebKit2
Merge r92729. Needed for <rdar://problem/9966800>
- 3:46 PM Changeset in webkit [93361] by
-
- 5 edits in trunk/Source
Chromium Mac: Show scrollbar when doing search
https://bugs.webkit.org/show_bug.cgi?id=66209
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Source/WebCore:
Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.
No tests because there are no Mac 10.7 chromium bots yet.
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Source/WebKit/chromium:
Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.
No tests because there are no Mac 10.7 chromium bots yet.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::invalidateArea):
- 3:42 PM Changeset in webkit [93360] by
-
- 33 edits2 adds in trunk
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834
Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Kenneth Russell.
Source/WebCore:
Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
draw-time transform.
*) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel
AA trashing the alpha channel. The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.
Covered by compositing/
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
- platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.
- compositing/checkerboard-expected.png:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 3:23 PM Changeset in webkit [93359] by
-
- 8 edits3 deletes in trunk
Unreviewed, rolling out r93354.
http://trac.webkit.org/changeset/93354
https://bugs.webkit.org/show_bug.cgi?id=66503
"consensus was not reached" (Requested by senorblanco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
Source/WebCore:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
LayoutTests:
- fast/canvas/drawImage-clipped-source-expected.txt: Removed.
- fast/canvas/drawImage-clipped-source.html: Removed.
- fast/canvas/drawImage-clipped-source.js: Removed.
- fast/canvas/drawImage-with-invalid-args-expected.txt:
- fast/canvas/drawImage-with-invalid-args.html:
- platform/chromium/test_expectations.txt:
- platform/mac/Skipped:
- 3:19 PM Changeset in webkit [93358] by
-
- 6 edits in trunk/Source
GestureRecognizer: Update how gesture-scroll works.
Source/WebCore:
Instead of just sending a series of 'GestureUpdate' events, send a
single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
and end with a 'GestureEnd' event.
https://bugs.webkit.org/show_bug.cgi?id=66267
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
(WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
(WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
(WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
(WebCore::scrollEnd):
(WebCore::isClickOrScroll):
(WebCore::inScroll):
- platform/chromium/GestureRecognizerChromium.h:
(WebCore::InnerGestureRecognizer::firstTouchPosition):
Source/WebKit/chromium:
Add a unit-test to make sure the correct gesture events are being
generated.
https://bugs.webkit.org/show_bug.cgi?id=66267
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
Reviewed by Adam Barth.
- tests/InnerGestureRecognizerTest.cpp:
(WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
(WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(WebCore::TEST_F):
- 3:16 PM Changeset in webkit [93357] by
-
- 2 edits in trunk/LayoutTests
Fix r93349.
- platform/gtk/Skipped:
- 3:14 PM Changeset in webkit [93356] by
-
- 6 edits1 delete in trunk
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=65555
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
Reviewed by James Robinson.
Source/WebCore:
Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
- platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):
LayoutTests:
Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.
- platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.
- 3:08 PM Changeset in webkit [93355] by
-
- 7 edits2 copies2 adds in trunk/Tools
add embedded png checksums to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=66494
Looks like WebKitTestRunner has never supported embedded checksums. This copies
some code from DRT and adds it to the WebKitTestRunner.
Reviewed by Darin Adler.
- WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
- WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
- WebKitTestRunner/GNUmakefile.am: Add new files
- WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
- WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
- WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::dumpBitmap): Refactor to use PixelDumpSupport.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
- 3:03 PM Changeset in webkit [93354] by
-
- 8 edits3 adds in trunk
Source/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.
Test: fast/canvas/drawImage-clipped-source.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
Removed the unnecessary dom exceptions for out of bounds source rectangles
The overloads that receive video and image elements as source images
now use the normalized versions of the source rectangle, which
GraphicsContext (and its various platform flavors) can handle correctly.
The normalized rectangle is the equivalent rectangle with width and height
greater than 0. The canvas version of this method, which had better layout
test coverage, was already correctly using the normalized rectangle. The
newly added layout test verifies correct behavior with negative
source rectangle dimensions.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
Fixed algorithm that adjusts the destination rectangle to match the clipping
applied to the source rect. The case of scaled filtered images with source
rectangles that overlap the edge of the image was not being handled
correctly. This use case was previously unsupported and used to trigger
a DOM exception.
LayoutTests: Unwarranted DOM Exception when when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709
Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
Reviewed by Stephen White.
- fast/canvas/drawImage-clipped-source-expected.txt: Added.
- fast/canvas/drawImage-clipped-source.html: Added.
New test that verifies the clipping behavior when source rectangles
are partially out of the bounds of the source image
- fast/canvas/drawImage-clipped-source.js: Added.
(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testPattern):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):
- fast/canvas/drawImage-with-invalid-args-expected.txt:
- fast/canvas/drawImage-with-invalid-args.html:
This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions
- platform/chromium/test_expectations.txt:
Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail
- platform/mac/Skipped:
Skipping canvas/philip/tests/2d.drawImage.outsidesource.html
- 2:55 PM Changeset in webkit [93353] by
-
- 1 edit1 add in trunk/LayoutTests
[Gtk] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66501
- platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.
- 2:53 PM Changeset in webkit [93352] by
-
- 1 move in trunk/LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt
Use a correct name for expected results.
- platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
- platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.
- 2:50 PM Changeset in webkit [93351] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] editing/selection/regional-indicators.html fails
https://bugs.webkit.org/show_bug.cgi?id=66500
- platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.
- 2:00 PM Changeset in webkit [93350] by
-
- 38 edits2 deletes in trunk
Unreviewed, rolling out r93329.
http://trac.webkit.org/changeset/93329
https://bugs.webkit.org/show_bug.cgi?id=66497
Turned text on chromium win blue (Requested by jamesr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::dumpLayerProperties):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::updateRootLayerContents):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::rootLayerChanged):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
- platform/graphics/chromium/NonCompositedContentHost.h: Removed.
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::dumpSurface):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createTilerIfNeeded):
(WebCore::TiledLayerChromium::tilingTransform):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::createRootLayerPainter):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportContentRect):
(WebCore::CCLayerTreeHost::viewportScrollPosition):
(WebCore::CCLayerTreeHost::viewportVisibleRect):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setRootPlatformLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 1:52 PM Changeset in webkit [93349] by
-
- 2 edits in trunk/LayoutTests
Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
which is tracked by the bug 66496.
- platform/gtk/Skipped:
- 1:43 PM Changeset in webkit [93348] by
-
- 1 edit1 copy in trunk/LayoutTests
GTK rebaseline after r93221.
- platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:
Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
- 1:41 PM Changeset in webkit [93347] by
-
- 6 edits2 adds in trunk
SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule
https://bugs.webkit.org/show_bug.cgi?id=66086
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
Fixing the bug by detecting RenderTextFragment in handleTextNode.
Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
the next call to handleTextNode needs to process the first-letter part of the text fragment.
Test: editing/text-iterator/backward-textiterator-first-letter-crash.html
- editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
(WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
- editing/TextIterator.h:
LayoutTests:
Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
from 0 to 1 because there is unrendered space before "hello".
- editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
- editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
- editing/text-iterator/first-letter-word-boundary-expected.txt:
- editing/text-iterator/first-letter-word-boundary.html:
- 1:37 PM Changeset in webkit [93346] by
-
- 8 edits in trunk/Source/WebCore
[chromium] Assert that main thread and compositor thread are used safely
https://bugs.webkit.org/show_bug.cgi?id=66145
CCLayerTreeHostImplProxy now has public static methods isMainThread()
and isImplThread(), and we ASSERT these in various places. If threaded
compositing is disabled, we fake isImplThread() by setting a flag for
the duration of compositing, so the assert is still valid.
Patch by Iain Merrick <husky@google.com> on 2011-08-18
Reviewed by James Robinson.
Covered by existing tests.
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::doComposite):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::isMainThread):
(WebCore::CCLayerTreeHostImplProxy::isImplThread):
(WebCore::CCLayerTreeHostImplProxy::setImplThread):
(WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
(WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
- platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
- 1:36 PM Changeset in webkit [93345] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=47240
Fixed a cygwin path problem in the chromium port of diff_image;
Also made the return values of the diff_image function more consistent.
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 1:32 PM Changeset in webkit [93344] by
-
- 3 edits2 adds in trunk
Regional indicator symbols that are combined should behave as a single character when editing
https://bugs.webkit.org/show_bug.cgi?id=65395
Reviewed by Dan Bernstein.
Source/WebCore:
Part two: make cursor movement iterator work. This fixes the problem for strings that don't
contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.
Test: editing/selection/regional-indicators.html
- platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom
rules for regional indicator symbols.
LayoutTests:
- editing/selection/regional-indicators-expected.txt: Added.
- editing/selection/regional-indicators.html: Added.
- 1:22 PM Changeset in webkit [93343] by
-
- 2 edits in trunk/Source/WebCore
Fix rubber band gutter drawing for Skia on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=66478
Reviewed by James Robinson.
No new tests. The Skia on Chromium Mac platform has
not been enabled.
This break was detected at compile time; there is no
behavior change.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Convert the CGImage into an SkBitmap if Skia is present.
- 1:22 PM Changeset in webkit [93342] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add a bunch of accessors to WebAccessibilityObject to expose more of
AccessibilityObject to Chromium, including range control values,
document load state, live region attributes, and a few other
ARIA attributes.
https://bugs.webkit.org/show_bug.cgi?id=66411
Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
Reviewed by Dimitri Glazkov.
- public/WebAccessibilityObject.h:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isAriaReadOnly):
(WebKit::WebAccessibilityObject::isButtonStateMixed):
(WebKit::WebAccessibilityObject::isControl):
(WebKit::WebAccessibilityObject::isFocused):
(WebKit::WebAccessibilityObject::isLoaded):
(WebKit::WebAccessibilityObject::isRequired):
(WebKit::WebAccessibilityObject::isVertical):
(WebKit::WebAccessibilityObject::accessKey):
(WebKit::WebAccessibilityObject::ariaHasPopup):
(WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
(WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
(WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
(WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
(WebKit::WebAccessibilityObject::estimatedLoadingProgress):
(WebKit::WebAccessibilityObject::hierarchicalLevel):
(WebKit::WebAccessibilityObject::valueDescription):
(WebKit::WebAccessibilityObject::valueForRange):
(WebKit::WebAccessibilityObject::maxValueForRange):
(WebKit::WebAccessibilityObject::minValueForRange):
- 1:20 PM Changeset in webkit [93341] by
-
- 3 edits in trunk/Source/WebCore
Implement a faster path for painting tables with overflowing cells
https://bugs.webkit.org/show_bug.cgi?id=65491
This change introduces a smarter way of painting if the table is big enough and we have a small amount
of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
the overflowing cells to the repainting cells.
This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
memory.
Reviewed by David Hyatt.
No new tests as the behavior should be the same.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
care about the cell's information. Make sure that the "has overflowing cells" information is still
properly encoded on our 2 values.
(WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
complicated sort:
- the old path would sort one (mostly sorted) array by rows only as the stable sort would take care of keeping the column ordering inside a row.
- the new path basically has to sort an unsorted array (taken partly from the HashSet).
(WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
repaint the same cell twice.
(WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
fast path optimization here.
- rendering/RenderTableSection.h: Transformed our original boolean into
a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
until we reach the memory threshold. After this is hit, we just set the boolean
to avoid using too much memory.
(WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
if we have any overflowing cell, used only for hit testing.
- 1:11 PM Changeset in webkit [93340] by
-
- 5 edits in trunk
An EventSource constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66454
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/eventsource/eventsource-constructor.html
- bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8EventSourceConstructor.cpp:
(WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.
- 1:09 PM Changeset in webkit [93339] by
-
- 5 edits in trunk
A SharedWorker constructor should throw TypeError, when the number of arguments is not enough.
https://bugs.webkit.org/show_bug.cgi?id=66455
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/workers/shared-worker-constructor.html
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8SharedWorkerCustom.cpp:
(WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.
- 1:08 PM Changeset in webkit [93338] by
-
- 9 edits in trunk
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- platform/gtk/GtkAuthenticationDialog.cpp: (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added gtk_box_new conditional compilation for gtk+-3.
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have GTK_TYPE_SCALE in gtk+3.
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (main): G_CONST_RETURN was deprecated
- GtkLauncher/main.c: (createWindow): Added gtk_box_new conditional compilation for gtk+-3.
- MiniBrowser/gtk/BrowserWindow.c: (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we are just supporting gtk+-3 for WebKit2.
2011-08-17 Alejandro G. Castro <alex@igalia.com>
[GTK] Fix compilation problems with deprecations in gtk+
https://bugs.webkit.org/show_bug.cgi?id=66073
Reviewed by Martin Robinson.
- WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Added gtk_box_new conditional compilation for gtk+-3.
- 1:01 PM Changeset in webkit [93337] by
-
- 4 edits in trunk/Source/WebKit2
Made some code even more private to a particular file and class
https://bugs.webkit.org/show_bug.cgi?id=66428
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]): Made this file internal.
- UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
- UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.
- 12:43 PM Changeset in webkit [93336] by
-
- 5 edits in trunk
A Worker constructor should throw TypeError, when the number of arguments is not enough
https://bugs.webkit.org/show_bug.cgi?id=66456
Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
Reviewed by Adam Barth.
Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
Source/WebCore:
Test: fast/workers/worker-constructor.html
- bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.
LayoutTests:
- fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.
- 12:32 PM Changeset in webkit [93335] by
-
- 2 edits in trunk/Source/WebCore
Fix logic error causing reverse of desired WebGL rate limiting behavior
https://bugs.webkit.org/show_bug.cgi?id=66445
Patch by John Bates <jbates@google.com> on 2011-08-18
Reviewed by Kenneth Russell.
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setTextureUpdated):
- 12:28 PM Changeset in webkit [93334] by
-
- 8 edits in trunk/Source/WebCore
Switch RenderTextControl* to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66250
Reviewed by Eric Seidel.
Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.
No new tests as no change in behavior.
- rendering/LayoutTypes.h:
(WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::preferredContentWidth):
(WebCore::RenderTextControlMultiLine::baselinePosition):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
- rendering/RenderTextControlSingleLine.h:
- 12:23 PM Changeset in webkit [93333] by
-
- 7 edits in trunk/Source/WebCore
Switch Inline rendering classes to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66239
Reviewed by Eric Seidel.
Converting inline rendering classes to use the LayoutUnit abstraction from ints.
No new tests as no change in functionality.
- rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::computeMargin):
(WebCore::RenderInline::culledInlineBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
(WebCore::RenderInline::addDashboardRegions):
- rendering/RenderInline.h:
- 12:19 PM Changeset in webkit [93332] by
-
- 2 edits in trunk/Source/WebCore
New XML parser: add doctype to DOM tree
https://bugs.webkit.org/show_bug.cgi?id=66408
Reviewed by Adam Barth.
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):
- 12:17 PM Changeset in webkit [93331] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test to ensure WebKit does not paste contents before
https://bugs.webkit.org/show_bug.cgi?id=66481
Reviewed by Alexey Proskuryakov.
Add a regression test since this bug has been fixed by r92695.
- editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
- editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.
- 12:10 PM Changeset in webkit [93330] by
-
- 12 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=61016
[WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers.
This adds an implementation of in-process dedicated workers to chromium port.
The crux of the matter is the reimplementation of WebWorkerClientImpl. WebWorkerClientImpl now
implements all three of Worker{Loader,Context,Object}Proxies and delegates the implementation to
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:
- In-process dedicated workers (this checkin)
- Inter-process shared workers
- Inter-process dedicated workers (defunct after this checkin)
This patch extracts some new common interfaces (NewWebWorkerBase and NewWebWorkerClient) for these
three implementations.
Removing the remainings of inter-process dedicated workers -related classes is left for a separate patch
(it will require coordinated changes on chromuium side).
Reviewed by David Levin.
- public/WebCommonWorkerClient.h:
- src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
- src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
- src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::newCommonClient):
- src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
(WebKit::WebWorkerClientImpl::hasPendingActivity):
(WebKit::WebWorkerClientImpl::workerObjectDestroyed):
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::sendMessageToInspector):
(WebKit::WebWorkerClientImpl::postMessageToPageInspector):
(WebKit::WebWorkerClientImpl::postTaskToLoader):
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
(WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
(WebKit::WebWorkerClientImpl::reportPendingActivity):
(WebKit::WebWorkerClientImpl::workerContextClosed):
(WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
(WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
(WebKit::WebWorkerClientImpl::~WebWorkerClientImpl):
- src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
- src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::newCommonClient):
- src/WebWorkerImpl.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
- src/WorkerFileSystemCallbacksBridge.h:
- 12:06 PM Changeset in webkit [93329] by
-
- 38 edits2 adds in trunk
[chromium] Draw the root/"non-composited content" in compositor side
https://bugs.webkit.org/show_bug.cgi?id=58834
Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
Reviewed by Darin Fisher.
Source/WebCore:
Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:
*) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
draw-time transform.
*) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha
channel. The root layer is always opaque so this is fine.
*) The root layer does not have border texels and does have subpixel AA for text.
Covered by compositing/
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollPosition):
(WebCore::LayerChromium::setScrollPosition):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
- platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
(WebCore::NonCompositedContentHost::~NonCompositedContentHost):
(WebCore::NonCompositedContentHost::invalidateRect):
(WebCore::NonCompositedContentHost::invalidateEntireLayer):
(WebCore::NonCompositedContentHost::setScrollPosition):
(WebCore::NonCompositedContentHost::notifyAnimationStarted):
(WebCore::NonCompositedContentHost::notifySyncRequired):
(WebCore::NonCompositedContentHost::paintContents):
(WebCore::NonCompositedContentHost::showDebugBorders):
(WebCore::NonCompositedContentHost::showRepaintCounter):
- platform/graphics/chromium/NonCompositedContentHost.h: Added.
(WebCore::NonCompositedContentHost::create):
(WebCore::NonCompositedContentHost::graphicsLayer):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollPosition):
(WebCore::CCLayerImpl::setScrollPosition):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::invalidateRootLayerRect):
(WebCore::CCLayerTreeHost::setRootLayer):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::reallocateRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):
(WebCore::CCLayerTreeHost::viewportSize):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::didRecreateGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
LayoutTests:
Update pixel baselines that changes due to subtle blending
differences, primarily on scrollbars. I don't know why these keep
changing.
- compositing/checkerboard-expected.png:
- platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
- platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 11:51 AM Changeset in webkit [93328] by
-
- 2 edits in trunk/Source/WebCore
Fix "missing return" gcc warning in ScrollAnimatorNone
https://bugs.webkit.org/show_bug.cgi?id=66480
Reviewed by Tony Chang.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
- 11:49 AM Changeset in webkit [93327] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Activating sub menus cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=66471
Patch by Amruth Raj <amruthraj@motorola.com> on 2011-08-18
Reviewed by Anders Carlsson.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::createGtkMenu):
- 11:41 AM Changeset in webkit [93326] by
-
- 3 edits2 adds in trunk
Revalidate expired resources if they're requested after the initial document load
https://bugs.webkit.org/show_bug.cgi?id=52153
Reviewed by Antti Koivisto.
Source/WebCore:
Test: http/tests/cache/subresource-multiple-instances.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
LayoutTests:
- http/tests/cache/subresource-multiple-instances-expected.txt: Added.
- http/tests/cache/subresource-multiple-instances.html: Added.
- 11:29 AM Changeset in webkit [93325] by
-
- 2 edits in trunk/LayoutTests
[chromium] Marking tests needing win/linux baselines as such in
test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [93324] by
-
- 2 edits1 add12 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/block-wrappers-necessary.html
https://bugs.webkit.org/show_bug.cgi?id=66420
Reviewed by Kent Tamura.
Converted the test.
- editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
- editing/pasteboard/block-wrappers-necessary.html:
- platform/chromium-cg-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win-vista/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/gtk/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
- platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt: Removed.
- 11:21 AM Changeset in webkit [93323] by
-
- 1 edit1 move1 add8 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/5368833.html
https://bugs.webkit.org/show_bug.cgi?id=66416
Reviewed by Kent Tamura.
Converted the test and also renamed the test to a more descriptive name.
- editing/pasteboard/5368833.html: Removed.
- editing/pasteboard/paste-blockquote-and-paragraph-break-expected.txt: Added.
- editing/pasteboard/paste-blockquote-and-paragraph-break.html: Copied from LayoutTests/editing/pasteboard/5368833.html.
- platform/chromium-linux/editing/pasteboard/5368833-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5368833-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5368833-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5368833-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/5368833-expected.png: Removed.
- platform/mac/editing/pasteboard/5368833-expected.png: Removed.
- platform/mac/editing/pasteboard/5368833-expected.txt: Removed.
- platform/qt/editing/pasteboard/5368833-expected.txt: Removed.
- 11:09 AM Changeset in webkit [93322] by
-
- 2 edits1 delete in trunk/LayoutTests
Update chromium gpu expected results after r93275.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 10:59 AM Changeset in webkit [93321] by
-
- 4 edits1 add in trunk/LayoutTests
Update baselines for mac and win after test changes/fixes in r93275.
- platform/chromium-cg-mac/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:48 AM Changeset in webkit [93320] by
-
- 6 edits in trunk/LayoutTests
Add checksums to png results. Still trying to find out why they
went missing in the first place.
- fast/frames/frame-set-scaling-3d-expected.png:
- fast/frames/frame-set-scaling-centered-expected.png:
- fast/frames/frame-set-scaling-expected.png:
- fast/frames/frame-set-scaling-rotate-expected.png:
- fast/frames/frame-set-scaling-skew-expected.png:
- 10:21 AM Changeset in webkit [93319] by
-
- 3 edits in trunk/Tools
Fix libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66479
Reviewed by Adam Roben.
Add missing includes.
- DumpRenderTree/LayoutTestController.cpp:
- DumpRenderTree/mac/CheckedMalloc.cpp:
- 10:20 AM Changeset in webkit [93318] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
dump-as-markup conversion: editing/pasteboard/testcase-9507.html
https://bugs.webkit.org/show_bug.cgi?id=66448
Reviewed by Kent Tamura.
Converted the test.
- editing/pasteboard/testcase-9507-expected.txt: Added.
- editing/pasteboard/testcase-9507.html:
- platform/chromium-linux/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/gtk/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/gtk/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/mac-leopard/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/mac/editing/pasteboard/testcase-9507-expected.png: Removed.
- platform/mac/editing/pasteboard/testcase-9507-expected.txt: Removed.
- platform/qt/editing/pasteboard/testcase-9507-expected.txt: Removed.
- 10:16 AM Changeset in webkit [93317] by
-
- 3 edits in trunk/Source/WebKit/mac
More C++0x libc++ build fixes
https://bugs.webkit.org/show_bug.cgi?id=66476
Reviewed by Adam Roben.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCSetException):
Use a WTF String here instead of an STL string.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
std::make_pair now takes rvalue references, so get rid of the template arguments and let
the compiler deduce them instead.
- 9:56 AM Changeset in webkit [93316] by
-
- 3 edits in trunk/Source/WebCore
Fix clang libc++ C++0x build
https://bugs.webkit.org/show_bug.cgi?id=66475
Reviewed by Adam Roben.
Remove calls to isnan and isfinite with integer arguments.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::viewport):
- 9:43 AM Changeset in webkit [93315] by
-
- 8 edits3 copies3 adds in trunk
Update the device scale factor when the WebView's window changes
Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
WebView is moved between windows with different backing scale factors
Reviewed by Anders Carlsson.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
window at all) might have a different backing scale factor than the previous one.
(-[WKView _deviceScaleFactor]): Moved to the new FileInternal category.
Tools:
Test that WebKit updates style when a WebView is moved between differently-scaled windows
- TestWebKitAPI/JavaScriptTest.cpp:
(TestWebKitAPI::runJSTest): Moved a little bit of code from here...
(TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
gtest's built-in error messages.
- TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
WKView * for convenience on Mac. Added compareJSResult helper function for implementing
those overloads.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
(-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Set up the client.
(TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
SyntheticBackingScaleFactorWindow and returns it.
(TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
window, is moved to a differently-scaled window, and is taken out of the window.
(TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
WebKit1 and WebKit2.
(TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
- TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
- TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
(TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
initializer.
(-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
(-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
(-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
- 9:43 AM Changeset in webkit [93314] by
-
- 12 edits in trunk/Source/WebKit2
Make WebPageProxy keep track of the current device scale factor
The device scale factor is no longer considered part of WebPageProxy's "view state". It now
has its own setter/getter. This made the code a little simpler and more similar to the page
scale factor. Each port-specific WebKit2 view is now responsible for calling
WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
changed.
Fixes <http://webkit.org/b/66466> WebKit2 requires every port-specific view to keep track of
the current device scale factor
Reviewed by Anders Carlsson.
- UIProcess/API/efl/PageClientImpl.cpp:
- UIProcess/API/efl/PageClientImpl.h:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/PageClient.h:
- UIProcess/qt/QtWebPageProxy.h:
- UIProcess/win/WebView.h:
Removed deviceScaleFactor.
- UIProcess/API/mac/WKView.mm:
(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
tells the DrawingAreaProxy about it if it's actually changed.
(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
to the PageClient.
- UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
replaces the DeviceScaleFactor ViewStateFlag.
(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.
- 9:39 AM Changeset in webkit [93313] by
-
- 2 edits in trunk/Source/WebKit/chromium
Revert r93294, doesn't compile on Chromium Mac.
- features.gypi:
- 9:36 AM Changeset in webkit [93312] by
-
- 10 edits4 moves1 add1 delete in trunk
2011-08-18 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460
Reviewed by Pavel Feldman.
Tests: http/tests/inspector/extensions-network-redirect.html
inspector/extensions/extensions-network.html
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Network.requestDispatch): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Network.prototype.getHAR): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter): (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._inspectedURLChanged): (WebInspector.ExtensionServer.prototype._notifyRequestFinished): (WebInspector.ExtensionServer.prototype._onGetHAR): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._requestId): (WebInspector.ExtensionServer.prototype._requestById): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype.initExtensions): (WebInspector.ExtensionServer.prototype._onmessage):
2011-08-18 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
https://bugs.webkit.org/show_bug.cgi?id=66460
Reviewed by Pavel Feldman.
- http/tests/inspector/extensions-network-redirect-expected.txt: Added.
- http/tests/inspector/extensions-network-redirect.html: Renamed from LayoutTests/http/tests/inspector/extensions-resources-redirect.html.
- http/tests/inspector/extensions-network-test.js: Renamed from LayoutTests/http/tests/inspector/extensions-resources-test.js. (extension_getRequestByUrl.onHAR): (extension_getRequestByUrl):
- http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
- http/tests/inspector/extensions-useragent-expected.txt:
- http/tests/inspector/extensions-useragent.html:
- inspector/extensions/extensions-api-expected.txt:
- inspector/extensions/extensions-events-expected.txt:
- inspector/extensions/extensions-events.html:
- inspector/extensions/extensions-network-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-resources-expected.txt.
- inspector/extensions/extensions-network.html: Renamed from LayoutTests/inspector/extensions/extensions-resources.html.
- 8:51 AM Changeset in webkit [93311] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
https://bugs.webkit.org/show_bug.cgi?id=66243
Reviewed by Martin Robinson.
The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.
This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.
- tests/testwebview.c:
(test_webkit_web_view_grab_focus):
- 8:39 AM Changeset in webkit [93310] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Chang Shu <cshu@webkit.org>
[Windows] editing/input/password-echo-passnode2.html, editing/input/password-echo-passnode3.html,
editing/input/password-echo-passnode.html, editing/input/password-echo-textnode.html
failing on Windows since they were added
https://bugs.webkit.org/show_bug.cgi?id=66461
Reviewed by Adam Roben.
Skip the above tests as window.textInputController is not supported on windows.
- platform/win/Skipped:
- 7:59 AM Changeset in webkit [93309] by
-
- 1 edit2 adds in trunk/LayoutTests
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785
Add missing Qt results for tests added in r93287.
Unreviewed gardening.
- platform/qt/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
- 7:56 AM Changeset in webkit [93308] by
-
- 4 edits2 adds in trunk
Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.
https://bugs.webkit.org/show_bug.cgi?id=66237
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/content-providers.html
- inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
LayoutTests:
- inspector/debugger/content-providers-expected.txt: Added.
- inspector/debugger/content-providers.html: Added.
- 7:36 AM Changeset in webkit [93307] by
-
- 11 edits4 adds in trunk
[CSSRegions] RenderRegion should not reference a parent RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142
Source/WebCore:
Added code that checks the parent RenderFlowThread of a RenderRegion and creates
a dependency for its referenced RenderFlowThread (from CSS style).
There are two cases:
- A RenderRegion tries to display the flow thread that laid it out. In this case
the region will be ignored and will not participate in the flow threads regions list.
- A RenderRegion tries to display a flow thread that contains another region that
tries to display the first region's flow thread. This one can be generalized with any
number of intermediate flow threads. In this case the recursion is detected and only the
first added region will actually be selected. The other region will be ignored. However,
when the recursion is removed the invalid regions will be recovered.
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-18
Reviewed by David Hyatt.
Tests: fast/regions/flows-dependency-dynamic-remove.html
fast/regions/flows-dependency-same-flow.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::dependsOn):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::checkInvalidRegions):
(WebCore::RenderFlowThread::addDependencyOnFlowThread):
(WebCore::RenderFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderFlowThread::pushDependencies):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::~RenderRegion):
(WebCore::RenderRegion::paintReplaced):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::detachRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::parentFlowThread):
(WebCore::RenderRegion::isValid):
(WebCore::RenderRegion::setIsValid):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):
(WebCore::writeLayers):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::renderFlowThreadWithName):
(WebCore::RenderView::layoutRenderFlowThreads):
- rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
(WebCore::RenderView::isRenderFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderFlowThreadOrderDirty):
(WebCore::RenderView::renderFlowThreadList):
LayoutTests:
Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-18
Reviewed by David Hyatt.
- fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- fast/regions/flows-dependency-dynamic-remove.html: Added.
- fast/regions/flows-dependency-same-flow-expected.txt: Added.
- fast/regions/flows-dependency-same-flow.html: Added.
- 7:32 AM Changeset in webkit [93306] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 7:12 AM Changeset in webkit [93305] by
-
- 2 edits in trunk/LayoutTests
2011-08-18 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Updating test expectations.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 6:49 AM Changeset in webkit [93304] by
-
- 6 edits3 adds in trunk
Web Inspector: add UISourceCode class.
https://bugs.webkit.org/show_bug.cgi?id=66233
Source/WebCore:
This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.
UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.
UISourceCode represents a single entry in scripts panel's files select.
Reviewed by Pavel Feldman.
Test: inspector/debugger/ui-source-code.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/UISourceCode.js: Added.
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get id):
(WebInspector.UISourceCode.prototype.get url):
(WebInspector.UISourceCode.prototype.get isContentScript):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.requestContent):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/debugger/ui-source-code-expected.txt: Added.
- inspector/debugger/ui-source-code.html: Added.
- 6:26 AM Changeset in webkit [93303] by
-
- 54 edits in trunk/Source
Make WebCore keep track of the current device scale factor
Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.
- css/MediaQueryEvaluator.cpp:
(WebCore::device_pixel_ratioMediaFeatureEval):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::devicePixelRatio):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceScaleFactor):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addDashboardRegions):
Changed to get the device scale factor from Page.
- loader/EmptyClients.h:
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
Removed Chrome[Client]::deviceScaleFactor.
- page/Frame.cpp:
- page/Frame.h:
Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.
- page/Page.cpp:
(WebCore::Page::Page): Initialize m_deviceScaleFactor.
(WebCore::Page::setDeviceScaleFactor): Added. Code came from
Frame::deviceScaleFactorChanged.
- page/Page.h: Added m_deviceScaleFactor.
(WebCore::Page::deviceScaleFactor): Added simple getter.
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
Removed deviceScaleFactor.
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/ChromeClientEfl.h:
Removed deviceScaleFactor.
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ChromeClientGtk.h:
Removed deviceScaleFactor.
Source/WebKit/haiku:
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
Removed deviceScaleFactor.
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
Moved code to calculate the device scale factor from here...
- WebView/WebView.mm:
(-[WebView _deviceScaleFactor]):
...to here.
(-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.
- Api/qwebpage_p.h: Removed pixelRatio.
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
Removed deviceScaleFactor.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
Removed deviceScaleFactor.
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
Removed deviceScaleFactor.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactor):
Changed to get the device scale factor from WebCore.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setDeviceScaleFactor):
- WebProcess/WebPage/WebPage.h:
Removed m_deviceScaleFactor. We always get the scale factor from WebCore now.
- 6:06 AM Changeset in webkit [93302] by
-
- 3 edits2 adds14 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/paste-text-010.html and editing/pasteboard/paste-text-015.html
https://bugs.webkit.org/show_bug.cgi?id=66440
Reviewed by Kent Tamura.
Converted the tests.
- editing/pasteboard/paste-text-010-expected.txt: Added.
- editing/pasteboard/paste-text-010.html:
- editing/pasteboard/paste-text-015-expected.txt: Added.
- editing/pasteboard/paste-text-015.html:
- platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-010-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-015-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-015-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-010-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-015-expected.txt: Removed.
- 5:36 AM Changeset in webkit [93301] by
-
- 3 edits1 move1 add15 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/pasteboard/paste-text-017.html and editing/pasteboard/paste-text-018.html
https://bugs.webkit.org/show_bug.cgi?id=66443
Reviewed by Kent Tamura.
Converted the tests.
- editing/pasteboard/paste-text-017-expected.txt: Added.
- editing/pasteboard/paste-text-017.html:
- editing/pasteboard/paste-text-018-expected.txt: Added.
- editing/pasteboard/paste-text-018.html:
- platform/chromium-linux/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-017-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-018-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-018-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-017-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-018-expected.txt: Removed.
- 5:25 AM Changeset in webkit [93300] by
-
- 11 edits in trunk/Source/WebCore
SVG and HTML editing have conflicting inline isWhitespace functions
https://bugs.webkit.org/show_bug.cgi?id=65145
Reviewed by Nikolas Zimmermann.
Renamed the SVG-specific whitespace functions to call it "SVG space"
rather than just "whitespace". An alternative would have been to put
the functions into an SVG namespace instead of the top level WebCore
namespace.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::parsePoint): Call skipOptionalSVGSpaces.
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines): Ditto.
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox): Ditto.
- svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseArcFlag): Ditto.
(WebCore::parseRect): Call skipOptionalSVGSpaces.
(WebCore::pointsListFromSVGData): Ditto.
(WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,
and skipOptionalSVGSpacesOrDelimiter.
(WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.
- svg/SVGParserUtilities.h:
(WebCore::isSVGSpace): Renamed from isWhitespace. This better matches
the comment which specifically talks about SVG.
(WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.
(WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGPathStringSource.cpp:
(WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.
- svg/SVGStringList.cpp:
(WebCore::SVGStringList::parse): Call isSVGSpace and
skipOptionalSVGSpacesOrDelimiter.
- svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and
skipOptionalSVGSpacesOrDelimiter.
(WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.
- 4:52 AM Changeset in webkit [93299] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove a superfluous 'using' from WebBindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=66046
Reviewed by Alexey Proskuryakov.
- src/WebBindings.cpp:
- 4:47 AM Changeset in webkit [93298] by
-
- 3 edits3 adds in trunk
[jsfunfuzz] DFG speculative JIT does divide-by-zero checks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66426
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Changed the branchTestPtr to branchTest32.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Oliver Hunt.
Added a trivial test of mod-by-zero, which fails with the previous version
of the DFG speculative JIT.
- fast/js/mod-by-zero-expected.txt: Added.
- fast/js/mod-by-zero.html: Added.
- fast/js/script-tests/mod-by-zero.js: Added.
(mod):
- 4:43 AM Changeset in webkit [93297] by
-
- 3 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=66425
check-webkit-style should detect incorrectly formatted file change descriptions.
Description, if present, should be separated from colon with a space.
Reviewed by David Levin.
- Scripts/webkitpy/style/checkers/changelog.py: Fix.
- Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
- 4:10 AM Changeset in webkit [93296] by
-
- 5 edits in trunk/Source
Prepare frames for history navigation.
Before beginning an explicit history navigation in a newly initialized
frame, it's important to give a "previous" item to avoid crashes, and
give a state to the state machine to avoid extra validating loads.
https://bugs.webkit.org/show_bug.cgi?id=66322
Reviewed by Darin Fisher.
Source/WebCore:
No new tests, as history navigation is very difficult to test in
DumpRenderTree.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation):
- loader/FrameLoader.h:
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadHistoryItem):
- 4:05 AM Changeset in webkit [93295] by
-
- 2 edits in trunk/Source/WebCore
When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
https://bugs.webkit.org/show_bug.cgi?id=66282
Patch by Jing Zhao <jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.
No new tests since it only changes the behavior in Android Browser.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
- 4:02 AM Changeset in webkit [93294] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium/mac] Enable smooth scrolling
https://bugs.webkit.org/show_bug.cgi?id=66418
Reviewed by Dimitri Glazkov.
- features.gypi:
- 3:33 AM Changeset in webkit [93293] by
-
- 2 edits in trunk/LayoutTests
Remove TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html
http://code.google.com/p/chromium/issues/detail?id=93044
This test should now pass after Chromium rolled V8 to 3.5.6 in r97287.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:22 AM Changeset in webkit [93292] by
-
- 8 edits2 adds in trunk
Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices
https://bugs.webkit.org/show_bug.cgi?id=66321
Reviewed by Darin Adler.
Source/WebCore:
This is simply a cleanup change: there's no need that I can see for
HTMLFormControlElement and HTMLObjectElement to override
Element::attributeChanged since they can properly handle form
attribute changes in parseMappedAttribute, which they also override.
Though no change in behavior, I've added test coverage of the moved
code to an existing test (fast/forms/form-attribute.html) and added
a new test.
Test: fast/forms/radio-remove-form-attr.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseMappedAttribute):
- html/HTMLFormControlElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
- html/HTMLObjectElement.h:
LayoutTests:
Added new coverage to ensure that adding a radio button to a radio
group in the document by removing a form attribute leaves the group in
a valid state (no more than one button checked).
Beefed up coverage of form associated elements to better cover
HTMLObjectElement.
- fast/forms/form-attribute-expected.txt:
- fast/forms/radio-remove-form-attr-expected.txt: Added.
- fast/forms/radio-remove-form-attr.html: Added.
- fast/forms/script-tests/form-attribute.js:
Added coverage of <object form=""> behavior.
- 3:19 AM Changeset in webkit [93291] by
-
- 10 edits10 adds in trunk
Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052
Patch by Chang Shu <cshu@webkit.org> on 2011-08-18
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Added runtime settings in WebCore.
Added support in window.internals for testing.
Tests: editing/input/password-echo-passnode.html
editing/input/password-echo-passnode2.html
editing/input/password-echo-passnode3.html
editing/input/password-echo-textnode.html
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setPasswordEchoEnabled):
(WebCore::Settings::passwordEchoEnabled):
(WebCore::Settings::setPasswordEchoDurationInSeconds):
(WebCore::Settings::passwordEchoDurationInSeconds):
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setPasswordEchoEnabled):
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/qt:
Enable password echo under the build flag.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
LayoutTests:
Added tests.
- editing/input/password-echo-passnode-expected.txt: Added.
- editing/input/password-echo-passnode.html: Added.
- editing/input/password-echo-passnode2-expected.txt: Added.
- editing/input/password-echo-passnode2.html: Added.
- editing/input/password-echo-passnode3-expected.txt: Added.
- editing/input/password-echo-passnode3.html: Added.
- editing/input/password-echo-textnode-expected.txt: Added.
- editing/input/password-echo-textnode.html: Added.
- editing/input/resources: Added.
- editing/input/resources/password-echo.js: Added.
(secureChar):
(secureText):
(log):
(assert):
(run.else):
(run):
(init):
- platform/wk2/Skipped: No support yet.
- 1:44 AM Changeset in webkit [93290] by
-
- 3 edits2 adds in trunk
Selecting all and inserting text into a page with a frameset leads to a NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=66288
Source/WebCore:
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.
VisibleSelection returns a NoSelection to InsertTextCommand::doApply as
a new endingSelection, which isn't a sane state to be in. The code
tries to get a position on a higher node for a better selection, but
cannot go above the frameset (which exists in place of the body tag),
which lacks a renderer, and therefore cannot have a non-NoSelection
VisibleSelection.
Because this is a rare corner case, it seemed more reasonable to bail
out in this circumstance than to change the way VisibleSelection
canonicalization works. The new behavior is to delete the content, but
insert nothing. I investigated the possibility of trying to move above
or below the frameset in this particular case, but there still isn't a
renderer, so it didn't prevent the crash.
Test: editing/inserting/insert-text-into-empty-frameset-crash.html
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
LayoutTests:
This test selects all and inserts text in a page which contains a frameset.
It tests for a crash caused by a NULL ptr which can occur in InsertText::doApply.
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-18
Reviewed by Tony Chang.
- editing/inserting/insert-text-into-empty-frameset-crash-expected.txt: Added.
- editing/inserting/insert-text-into-empty-frameset-crash.html: Added.
- 1:09 AM Changeset in webkit [93289] by
-
- 2 edits in trunk/LayoutTests
[Qt] Correct the path in the Skipped list after 93283.
Unreviewed gardening.
- platform/qt/Skipped:
- 1:02 AM Changeset in webkit [93288] by
-
- 3 edits in trunk/Source/WebCore
Remove arguments from CloseEvent::create().
https://bugs.webkit.org/show_bug.cgi?id=66294
Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.
CloseEvent objects are initialized by initCloseEvent() in all cases.
Initialization in create() is redundant.
No new tests for no functional difference.
- websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::CloseEvent):
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):
- 12:23 AM Changeset in webkit [93287] by
-
- 6 edits20 adds in trunk
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785
Source/WebCore:
Reviewed by Simon Fraser.
Fixed two iframe and frameset scaling bugs:
#1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
#2 frameset does not respect -webkit-transform-origin when scaled
Tests: fast/frames/frame-set-scaling-3d.html
fast/frames/frame-set-scaling-centered.html
fast/frames/frame-set-scaling-rotate.html
fast/frames/frame-set-scaling-skew.html
fast/frames/frame-set-scaling.html
fast/frames/iframe-scaling-with-scroll.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.
LayoutTests:
Added tests to verify that framesets and iframes are scaled and positioned correctly.
Reviewed by Simon Fraser.
- fast/frames/frame-set-scaling-3d-expected.png: Added.
- fast/frames/frame-set-scaling-3d-expected.txt: Added.
- fast/frames/frame-set-scaling-3d.html: Added.
- fast/frames/frame-set-scaling-centered-expected.png: Added.
- fast/frames/frame-set-scaling-centered-expected.txt: Added.
- fast/frames/frame-set-scaling-centered.html: Added.
- fast/frames/frame-set-scaling-expected.png: Added.
- fast/frames/frame-set-scaling-expected.txt: Added.
- fast/frames/frame-set-scaling-rotate-expected.png: Added.
- fast/frames/frame-set-scaling-rotate-expected.txt: Added.
- fast/frames/frame-set-scaling-rotate.html: Added.
- fast/frames/frame-set-scaling-skew-expected.png: Added.
- fast/frames/frame-set-scaling-skew-expected.txt: Added.
- fast/frames/frame-set-scaling-skew.html: Added.
- fast/frames/frame-set-scaling.html: Added.
- fast/frames/iframe-scaling-with-scroll.html: Added.
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
- platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
- 12:21 AM Changeset in webkit [93286] by
-
- 2 edits in trunk/Tools
webkit-patch pretty-diff should be shown in main help
https://bugs.webkit.org/show_bug.cgi?id=66404
Reviewed by Dimitri Glazkov.
As requested by dglazkov.
- Scripts/webkitpy/tool/commands/prettydiff.py:
Aug 17, 2011:
- 11:58 PM Changeset in webkit [93285] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix after r93268.
- dom/Document.cpp:
(WebCore::disableRangeMutation):
- 11:37 PM Changeset in webkit [93284] by
-
- 3 edits in trunk/Source/WebCore
Switch RenderBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66156
Reviewed by Eric Seidel.
Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.
No new tests as no new functionality.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):
- 11:34 PM Changeset in webkit [93283] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening
Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-08-17
- platform/qt/Skipped: Skip new failures.
- 9:47 PM Changeset in webkit [93282] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=66400
Fix TestWebKitAPI build on Mac OS.
Reviewed by David Levin.
- TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
- 9:22 PM Changeset in webkit [93281] by
-
- 6 edits in trunk/Source/WebCore
Reduce usages of String::createUninitialized
https://bugs.webkit.org/show_bug.cgi?id=66399
Constructs Strings with StringBuilder instead of calling createUninitialized.
Reviewed by Adam Barth.
No new tests; no functional change.
- dom/StyleElement.cpp:
(WebCore::StyleElement::process):
- dom/Text.cpp:
(WebCore::Text::wholeText):
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
- platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces):
- platform/text/TextCodecUserDefined.cpp:
(WebCore::TextCodecUserDefined::decode):
- 9:06 PM Changeset in webkit [93280] by
-
- 6 edits in trunk/Source/WebCore
Switch FrameView to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66147
Reviewed by Eric Seidel.
Convert Frame & FrameView to new layout abstraction as a part of the
ongoing conversion work.
No new tests, no new functionality.
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::scalePage):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::create):
(WebCore::FrameView::reset):
(WebCore::FrameView::init):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setMarginWidth):
(WebCore::FrameView::setMarginHeight):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::scrollOffsetForFixedPosition):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
- page/FrameView.h:
(WebCore::FrameView::marginWidth):
(WebCore::FrameView::marginHeight):
- page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):
- 8:38 PM Changeset in webkit [93279] by
-
- 15 edits in trunk/Source/WebCore
Switch html/* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66347
Reviewed by Eric Seidel.
Convert HTML* and shadow element to new layout abstraction as a part of
the ongoing conversion work.
No new tests, no new functionality.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::invalidateCachedRegion):
(WebCore::HTMLAreaElement::mapMouseEvent):
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::getRegion):
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent):
- html/HTMLMapElement.h:
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::continueDrag):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::defaultEventHandler):
- html/shadow/MediaControlElements.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom):
(WebCore::SliderThumbElement::setPositionFromPoint):
- html/shadow/SliderThumbElement.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
- 8:24 PM Changeset in webkit [93278] by
-
- 2 edits in trunk/Source/WebCore
Change references to leveldb.gyp to leveldatabase.gyp as part of the
leveldb refactoring going on in chromium: crbug.com/89378
https://bugs.webkit.org/show_bug.cgi?id=66332
Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Gentilcore.
Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb
- WebCore.gyp/WebCore.gyp:
- 7:56 PM Changeset in webkit [93277] by
-
- 4 edits in trunk/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=66379
implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-08-17
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):
- jit/JIT.h:
- 7:41 PM Changeset in webkit [93276] by
-
- 16 edits in trunk
Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=61421
Reviewed by Dimitri Glazkov.
Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
that focus/blue events are stopped at the lowest common shadow boundary.
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Event.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
- dom/Event.h:
- dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
- dom/Node.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchBlurEvent):
- html/HTMLFormControlElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
- html/HTMLSelectElement.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
- html/HTMLTextFormControlElement.h:
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
LayoutTests:
- fast/dom/shadow/shadow-boundary-events.html:
- 7:14 PM Changeset in webkit [93275] by
-
- 10 edits4 adds in trunk
Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66036
Source/WebCore:
These modes cannot be passed straight through to the underlying graphics context as the graphics context
and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
the entire canvas.
The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
area being filled.
Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
transformed path being filled contained anti-aliasing at its edges artifacts were introduced.
With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
appropriate mode, with any areas outside the draw area being cleared.
Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.
Test: fast/canvas/canvas-composite-transformclip.html
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
- html/canvas/CanvasRenderingContext2D.h:
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
LayoutTests:
Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.
- fast/canvas/canvas-composite-alpha.html:
- fast/canvas/canvas-composite-transformclip-expected.txt: Added.
- fast/canvas/canvas-composite-transformclip.html: Added.
- platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
- platform/chromium-linux/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/canvas/canvas-composite-expected.png:
- platform/mac/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- 7:00 PM Changeset in webkit [93274] by
-
- 8 edits in trunk/Source/WebCore
Switch inspector to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66358
Reviewed by Eric Seidel.
Convert inspector code to new layout abstraction as a part of the ongoing
conversion work.
No new tests, no new functionality.
- inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawNodeHighlight):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willPaintImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willPaint):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willPaint):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createPaintData):
- inspector/TimelineRecordFactory.h:
- 6:31 PM Changeset in webkit [93273] by
-
- 4 edits in trunk/Source/WebCore
Switch Editing code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66355
Reviewed by Eric Seidel.
Converting remaining editing code to the LayoutUnit abstraction.
No new tests, no change in functionality.
- editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::insideVisibleArea):
(WebCore::Editor::countMatchesForText):
- editing/Editor.h:
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- 6:18 PM Changeset in webkit [93272] by
-
- 25 edits in trunk/Source/WebCore
Switch Accessibility code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66348
Reviewed by Eric Seidel.
Converting remaining Accessibility code to the LayoutUnit abstraction.
No new tests, no change in functionality
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::elementRect):
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::elementRect):
- accessibility/AccessibilityMenuListOption.h:
(WebCore::AccessibilityMenuListOption::size):
- accessibility/AccessibilityMenuListPopup.h:
(WebCore::AccessibilityMenuListPopup::elementRect):
(WebCore::AccessibilityMenuListPopup::size):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint):
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::boundingBoxRect):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::elementRect):
(WebCore::AccessibilityRenderObject::size):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::elementRect):
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::elementRect):
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
(WebCore::AccessibilitySliderThumb::size):
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
- 6:02 PM Changeset in webkit [93271] by
-
- 2 edits in trunk/Websites/webkit.org
Updating the forms survey to include various element sizes.
- projects/forms/survey.html:
- 5:49 PM Changeset in webkit [93270] by
-
- 5 edits in trunk/Source/WebCore
Switch focus handling to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66331
Reviewed by Eric Seidel.
Convert FocusController and SpatialNavigation to new layout abstraction
as a part of the ongoing conversion work.
No new tests, no new functionality.
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
- page/FocusController.h:
- page/SpatialNavigation.cpp:
(WebCore::alignmentForRects):
(WebCore::start):
(WebCore::middle):
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::deflateIfOverlapped):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::distanceDataForNode):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):
- page/SpatialNavigation.h:
- 5:36 PM Changeset in webkit [93269] by
-
- 8 edits in trunk/Source/WebCore
Switch Document, DocumentMarker, Clipboard, and Range to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66330
Reviewed by Eric Seidel.
Converting the remaining DOM classes to use the LayoutUnit abstraction.
No new tests, no new behavior.
- dom/Clipboard.h:
(WebCore::Clipboard::dragLocation):
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
(WebCore::nodeFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::prepareMouseEvent):
- dom/Document.h:
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
- dom/DocumentMarkerController.h:
- dom/Range.cpp:
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
- dom/RenderedDocumentMarker.h:
(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setRenderedRect):
(WebCore::RenderedDocumentMarker::renderedRect):
(WebCore::RenderedDocumentMarker::invalidMarkerRect):
(WebCore::RenderedDocumentMarker::invalidate):
- 5:17 PM Changeset in webkit [93268] by
-
- 8 edits in trunk/Source
Source/WebCore: Removed an unused setting.
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- page/Settings.cpp:
(WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.
- page/Settings.h: Removed accessors.
Source/WebKit/mac: Removed some code that is not needed when building for Leopard or later.
Reviewed by Anders Carlsson.
- WebCoreSupport/WebContextMenuClient.mm:
(fixMenusToSendToOldClients): Removed check for Tiger Mail.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):
- 5:11 PM Changeset in webkit [93267] by
-
- 5 edits in tags/Safari-535.1.2
Merge r93070.
- 5:11 PM Changeset in webkit [93266] by
-
- 5 edits in tags/Safari-535.1.2/Source
Versioning.
- 5:09 PM Changeset in webkit [93265] by
-
- 1 copy in tags/Safari-535.1.2
New tag.
- 5:08 PM Changeset in webkit [93264] by
-
- 2 edits in trunk/Source/WebCore
Move towards supporting user controlled prototypes on CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=66429
Reviewed by Gavin Barraclough.
Start using a per-global object structure for canvas pixel array.
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- 5:06 PM Changeset in webkit [93263] by
-
- 3 edits in trunk/Source/WebCore
Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=66281
Reviewed by Eric Seidel.
No new tests - refactoring only.
The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from unsigned to CSSPrimitiveValue
(WebCore::CSSPrimitiveValue::operator unsigned):
Support cast from CSSPrimitiveValue to unsigned
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.
- 4:55 PM Changeset in webkit [93262] by
-
- 5 edits in trunk/Source
ScrollAnimatorNone: Remove unused field
https://bugs.webkit.org/show_bug.cgi?id=66312
Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-17
Reviewed by Adam Barth.
Source/WebCore:
No functional change; no test needed.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):
- platform/ScrollAnimatorNone.h:
Source/WebKit/chromium:
- tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):
- 4:37 PM Changeset in webkit [93261] by
-
- 2 edits in trunk/Source/WebKit/mac
Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
Rubber-stamped by Anders Carlsson.
- WebView/WebHTMLViewPrivate.h:
- 4:32 PM Changeset in webkit [93260] by
-
- 2 edits in trunk/Source/WebCore
Work-in-progress on Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725
Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
is enabled.
Reviewed by Anders Carlsson.
No new tests; no functional change.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).
(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.
- 4:28 PM Changeset in webkit [93259] by
-
- 7 edits53 moves1 add in trunk/Tools
garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
https://bugs.webkit.org/show_bug.cgi?id=66427
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
():
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
- 4:16 PM Changeset in webkit [93258] by
-
- 12 edits in trunk/Source/WebKit/mac
Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
needed for Tiger.
Reviewed by Darin Adler.
- History/WebBackForwardList.h:
- WebView/WebDocumentInternal.h:
- WebView/WebHTMLRepresentation.h:
- WebView/WebPreferences.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebResourceLoadDelegatePrivate.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebTextIterator.h:
- WebView/WebUIDelegate.h:
- WebView/WebView.h:
- WebView/WebViewPrivate.h:
- 4:14 PM Changeset in webkit [93257] by
-
- 2 edits in trunk/Tools
Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=65877
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- 4:08 PM Changeset in webkit [93256] by
-
- 4 edits in trunk/Tools
Remove base.keys and replace it with Object.keys.
https://bugs.webkit.org/show_bug.cgi?id=66422
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
- 4:04 PM Changeset in webkit [93255] by
-
- 24 edits2 copies in branches/chromium/835/Source
Merge 92520 - [chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402
Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.
Source/WebCore:
Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages. Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.
- page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
- page/Page.h:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.h:
Source/WebKit/chromium:
Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.
- public/WebGraphicsContext3D.h:
- src/Extensions3DChromium.cpp:
- src/GraphicsContext3DChromium.cpp:
- src/GraphicsContext3DInternal.h:
TBR=apatrick@chromium.org
BUG=80703
Review URL: http://codereview.chromium.org/7671031
- 3:51 PM Changeset in webkit [93254] by
-
- 4 edits in trunk/Tools
garden-o-matic Summary view should have items in descending chronological order.
https://bugs.webkit.org/show_bug.cgi?id=66403
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
- 3:41 PM Changeset in webkit [93253] by
-
- 3 edits in branches/chromium/835/Source/WebCore
Merge 92430 - [chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655
Patch by James Robinson <jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h:
TBR=commit-queue@webkit.org
BUG=80703
Review URL: http://codereview.chromium.org/7670046
- 3:41 PM Changeset in webkit [93252] by
-
- 4 edits in trunk/Tools
Fix a few errors in garden-o-matic frontend unit tests.
https://bugs.webkit.org/show_bug.cgi?id=66421
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
- 3:31 PM Changeset in webkit [93251] by
-
- 2 edits2 deletes in trunk/LayoutTests
[chromium] remove stale result and mark 3 new authentication tests as
failing because chromium drt is missing a function. Also mark
midword-break-before-surrogate-pair-2.html as failing on mac.
- platform/chromium-cg-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
- platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 3:17 PM Changeset in webkit [93250] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/text/midword-break-before-surrogate-pair-2.html is failing
on win and linux due to missing glyph.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [93249] by
-
- 10 edits in trunk
Use the LLVM Compiler for optimized builds when recent enough versions of it are available.
Rubber-stamped by Sam Weinig.
- 2:57 PM Changeset in webkit [93248] by
-
- 15 edits in trunk
Bring some consistency to the CompilerVersion.xcconfig files. They all now include REAL_PLATFORM_NAME in the relevant setting names.
Rubber-stamped by Sam Weinig.
- 2:43 PM Changeset in webkit [93247] by
-
- 4 edits4 copies4 moves11 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
Regression: On Lion, redirects lose HTTP authentication headers
Source/WebCore:
Reviewed by Alexey Proskuryakov and Darin Adler.
This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
assuming the redirected URL did not contain credentials directly.
Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.
LayoutTests:
These have to be in different paths to prevent credentials from leaking over from test to test.
Sad sad sad...
Reviewed by Alexey Proskuryakov.
- http/tests/misc/authentication-redirect-1: Added.
- http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect-expected.txt.
- http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect.html.
- http/tests/misc/authentication-redirect-1/resources: Added.
- http/tests/misc/authentication-redirect-1/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
- http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
- http/tests/misc/authentication-redirect-2: Added.
- http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
- http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html: Added.
- http/tests/misc/authentication-redirect-2/resources: Added.
- http/tests/misc/authentication-redirect-2/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
- http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
- http/tests/misc/authentication-redirect-3: Added.
- http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
- http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html: Added.
- http/tests/misc/authentication-redirect-3/resources: Added.
- http/tests/misc/authentication-redirect-3/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
- http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php: Added.
- http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
- http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
- http/tests/misc/authentication-sent-to-redirect.html: Removed.
- http/tests/misc/resources/auth-echo.php: Removed.
- http/tests/misc/resources/auth-then-redirect.php: Removed.
- 2:34 PM Changeset in webkit [93246] by
-
- 2 edits in trunk/Source/WebCore
Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174
Reviewed by Darin Adler.
Forgot to commit review comments.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
- 2:29 PM Changeset in webkit [93245] by
-
- 2 edits1 add9 deletes in trunk/LayoutTests
Dump-as-markup conversion: editing/inserting/insert-3786362-fix.html
https://bugs.webkit.org/show_bug.cgi?id=66396
Reviewed by Chang Shu.
Converted the test.
- editing/inserting/insert-3786362-fix-expected.txt: Added.
- editing/inserting/insert-3786362-fix.html:
- platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png: Removed.
- platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png: Removed.
- platform/chromium-win/editing/inserting/insert-3786362-fix-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-3786362-fix-expected.png: Removed.
- platform/gtk/editing/inserting/insert-3786362-fix-expected.txt: Removed.
- platform/mac-leopard/editing/inserting/insert-3786362-fix-expected.png: Removed.
- platform/mac/editing/inserting/insert-3786362-fix-expected.png: Removed.
- platform/mac/editing/inserting/insert-3786362-fix-expected.txt: Removed.
- platform/qt/editing/inserting/insert-3786362-fix-expected.txt: Removed.
- 2:26 PM Changeset in webkit [93244] by
-
- 11 edits in branches/chromium/835/Source
Merge 91736 - Source/WebCore: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replaced calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=65043
BUG=80703
Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):
- platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium: Removed support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
https://bugs.webkit.org/show_bug.cgi?id=65043
Patch by Al Patrick <apatrick@chromium.org> on 2011-07-25
Reviewed by James Robinson.
- public/WebGraphicsContext3D.h:
- src/Extensions3DChromium.cpp:
- src/GraphicsContext3DChromium.cpp:
- src/GraphicsContext3DInternal.h:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7631029
- 2:24 PM Changeset in webkit [93243] by
-
- 5 edits2 adds in trunk
Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174
Source/WebCore:
Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
creation flow. That can lead to loops.
Reviewed by Darin Adler.
Tests: accessibility/crash-determining-aria-role-when-label-present.html
- accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
Reviewed by Darin Adler.
- accessibility/crash-determining-aria-role-when-label-present-expected.txt: Added.
- accessibility/crash-determining-aria-role-when-label-present.html: Added.
- 2:16 PM Changeset in webkit [93242] by
-
- 8 edits in trunk/Tools
Update Tools to account for (CG) being added to Chromium builder names
https://bugs.webkit.org/show_bug.cgi?id=66410
Reviewed by Adam Barth.
Some of these names will change back once we turn on Skia bots.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 2:13 PM Changeset in webkit [93241] by
-
- 6 edits in trunk/Tools
Wire up relative time to garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=66343
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
- 2:08 PM Changeset in webkit [93240] by
-
- 2 edits in trunk/Tools
Make run-api-tests run tests in alphabetical order
Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
Reviewed by David Kilzer.
- Scripts/run-api-tests:
(runAllTests):
(runAllTestsInSuite):
Sort the lists of tests and suites before iterating over them.
- 1:58 PM Changeset in webkit [93239] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Crash if compositing is disabled during updateLayers()
https://bugs.webkit.org/show_bug.cgi?id=66353
Reviewed by Kenneth Russell.
If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
drawLayers() has to return without doing anything if the root layer is null.
Crash fixed based on crash reports. No known reliably repro case, unfortunately.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
- 1:54 PM Changeset in webkit [93238] by
-
- 5 edits in trunk/Source/JavaScriptCore
JSC verbose debugging output sometimes doesn't work as expected.
https://bugs.webkit.org/show_bug.cgi?id=66107
Reviewed by Gavin Barraclough.
Hardened the CodeBlock::dump() code so that it no longer crashes. Improved
the DFG verbose code so that it prints slightly more useful information.
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugSize):
- bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::dump):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfRegExps):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- 1:52 PM Changeset in webkit [93237] by
-
- 3 edits3 adds in trunk
<rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=66402
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/text/midword-break-before-surrogate-pair-2.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
break before a trailing surrogate.
LayoutTests:
- fast/text/midword-break-before-surrogate-pair-2.html: Added.
- 1:15 PM Changeset in webkit [93236] by
-
- 8 edits5 adds in trunk/Tools
garden-o-matic should be able to rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=66204
Reviewed by Dimitri Glazkov.
This patch introduces a new view for displaying expect, actual, and
differences between results. The new view also has a fledgling
controller that handles some basic operations. The new view is
exercised by rebaseline.html, which lets you rebaselines expected
failures, but the new view is not fully integrated into
garden-o-matic.html
More patches will be required to make this stuff fully working, but
this patch was already somewhat spiraling out of control. Hopefully
this patch will serve as a good starting point for further development.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
- 12:59 PM Changeset in webkit [93235] by
-
- 17 edits in trunk
2011-08-16 Chang Shu <cshu@webkit.org>
Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307
Reviewed by Dimitri Glazkov.
New tests will be added when function reset is implemented.
Added framework code in WebCoreTestSupport. The real implementation of
Internals::reset() depends on the need from the settings that require a reset.
- testing/Internals.cpp: (WebCore::Internals::reset):
- testing/Internals.h:
- testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
- testing/js/WebCoreTestSupport.h:
- testing/v8/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject):
- testing/v8/WebCoreTestSupport.h:
2011-08-16 Chang Shu <cshu@webkit.org>
Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307
Reviewed by Dimitri Glazkov.
Added framework code in WebKit.
- public/WebTestingSupport.h:
- src/WebTestingSupport.cpp: (WebKit::WebTestingSupport::resetInternalsObject):
2011-08-16 Chang Shu <cshu@webkit.org>
Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307
Reviewed by Dimitri Glazkov.
Added framework code in WebKit.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::resetInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-08-16 Chang Shu <cshu@webkit.org>
Support reset in WebCore::Internals
https://bugs.webkit.org/show_bug.cgi?id=66307
Reviewed by Dimitri Glazkov.
Added call to resetInternalsObject in DRT.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
- 12:44 PM Changeset in webkit [93234] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline for Windows, Chromium Windows, and Chromium Linux after r93221.
- platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
- 12:11 PM Changeset in webkit [93233] by
-
- 2 edits4 deletes in trunk/Source/WebKit2
Remove unused Core Animation related classes
https://bugs.webkit.org/show_bug.cgi?id=66393
Reviewed by Darin Adler.
- Shared/mac/CoreAnimationRenderer.h: Removed.
- Shared/mac/CoreAnimationRenderer.mm: Removed.
- Shared/mac/ShareableSurface.cpp: Removed.
- Shared/mac/ShareableSurface.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [93232] by
-
- 4 edits1 copy in trunk/LayoutTests
Update Windows Results for svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
- platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
- platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
These results were checked in to platform/win but were really XP-specific.
- platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
- platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
Updated these results for Windows 7.
- 11:56 AM Changeset in webkit [93231] by
-
- 2 edits in trunk/Tools
Add a new build slave for the Qt port on Mac OS SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=66392
Modify the config file to include the new build slave.
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:53 AM Changeset in webkit [93230] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark fast/canvas/webgl/data-view-crash.html as flaky
on linux debug.
- platform/chromium/test_expectations.txt:
- 11:44 AM Changeset in webkit [93229] by
-
- 2 edits in trunk/Source/WebCore
Fix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved
and the WebCore.gypi file wasn't updated.
- WebCore.gypi:
- 11:39 AM Changeset in webkit [93228] by
-
- 1 edit in trunk/Source/WebKit/chromium/ChangeLog
Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249
Reviewed by Darin Fisher.
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):
- 11:29 AM Changeset in webkit [93227] by
-
- 8 edits3 adds in trunk
Source/WebCore: Crash in Document::recalcStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=66335
Reviewed by Simon Fraser.
When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.
Test: svg/dom/stylesheet-candidate-node-crash-main.html
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::~HTMLStyleElement):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::~SVGStyleElement):
LayoutTests: Tests that we do not crash when iterating through stylesheet
candidate list hashset.
https://bugs.webkit.org/show_bug.cgi?id=66335
Reviewed by Simon Fraser.
- svg/dom/resources/stylesheet-candidate-node-crash.svg: Added.
- svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added.
- svg/dom/stylesheet-candidate-node-crash-main.html: Added.
- 11:28 AM Changeset in webkit [93226] by
-
- 10 edits2 adds in trunk
Source/WebCore: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180
Updated accessibilityTable to return level values consistent with other accessibilityObjects that
return level values. This means a value of 0 is now only returned when tableLevel() is called on a
non-table element.
Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.
Test: platform/mac/accessibility/element-level.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableLevel):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180
Added the ability to get numeric attribute values using numberAttributeValue. This
function complements the existing stringAttributeValue and boolAttributeValue functions.
The addition of numberAttributeValue was necessary because the stringAttributeValue
function does a type check and will only return strings. This limitation made it
impossible to get values for attributes that returned an NSNumber.
Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.
- DumpRenderTree/AccessibilityUIElement.cpp:
(numberAttributeValueCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::numberAttributeValue):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::numberAttributeValue):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::numberAttributeValue):
LayoutTests: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180
This test ensures that all AccessibilityObjects that return a level value return consistent results.
For example, a level of 0 should only be returned by a level function when it is called on an
AccessibilityObject of the wrong type. It's especially important that we enforce this consistency
using layout tests because these level values are not defined by the W3C but are still used by
popular screen readers such as VoiceOver.
Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.
- platform/mac/accessibility/element-level-expected.txt: Added.
- platform/mac/accessibility/element-level.html: Added.
- 11:21 AM Changeset in webkit [93225] by
-
- 3 edits in trunk/Source/WebKit/chromium
Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249
Reviewed by Darin Fisher.
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):
- 11:17 AM Changeset in webkit [93224] by
-
- 4 edits in trunk/Tools
Tell Trac logs always to display all specified revisions in a single page
Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.
Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
Updated tests for the above.
- 11:13 AM Changeset in webkit [93223] by
-
- 2 edits in trunk/Tools
Fix TestFailures's link to file a bug about TestFailures itself
Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
bug about itself is broken
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
the host from the path.
- 11:13 AM Changeset in webkit [93222] by
-
- 4 edits in trunk/Tools
Teach TestFailures to ignore unbelievably short test runs
Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
that caused it not to run any tests at all (as happened for a while due to
<http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Test for the above.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
- 11:07 AM Changeset in webkit [93221] by
-
- 4 edits2 adds in trunk
An arrow key collapses directionless selection range in the wrong direction in BiDi
https://bugs.webkit.org/show_bug.cgi?id=64626
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.
Test: editing/selection/collapse-selection-in-bidi.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.
- editing/FrameSelection.h:
LayoutTests:
Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.
- editing/selection/collapse-selection-in-bidi-expected.txt: Added.
- editing/selection/collapse-selection-in-bidi.html: Added.
- 11:04 AM Changeset in webkit [93220] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove onTimeout from WebIDBTransactionCallbacks.h
https://bugs.webkit.org/show_bug.cgi?id=66326
Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.
- public/WebIDBTransactionCallbacks.h:
- 10:57 AM Changeset in webkit [93219] by
-
- 4 edits4 moves2 adds in trunk/Source/WebCore
Some AVFoundation source files should be in platform-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66352
Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.
Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.
Reviewed by Eric Carlson.
No new tests; no functional change.
- WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.
- WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.
- WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.
- platform/graphics/avfoundation/cf: Added.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.
- platform/graphics/avfoundation/objc: Added.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.
- 10:45 AM Changeset in webkit [93218] by
-
- 4 edits in trunk/Source/WebCore
Only set m_fontDirty if TextSizeAdjust is actually changed.
https://bugs.webkit.org/show_bug.cgi?id=66022
Reviewed by Darin Adler.
No new tests. Refactoring only.
Reduces instances where the font information is dirtied to save recalculation where it is not necessary.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.
- 10:45 AM Changeset in webkit [93217] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r93204.
http://trac.webkit.org/changeset/93204
https://bugs.webkit.org/show_bug.cgi?id=66375
Test no longer crashing since r93171
- platform/chromium/test_expectations.txt:
- 10:23 AM Changeset in webkit [93216] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=66211
Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.
Reviewed by Tony Chang.
No new tests; no functional change.
- platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
- platform/graphics/chromium/HarfbuzzSkia.h:
- 10:16 AM Changeset in webkit [93215] by
-
- 2 edits in trunk/Source/WebCore
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.
- WebCore.vcproj/WebCore.vcproj:
- 10:16 AM Changeset in webkit [93214] by
-
- 2 edits6 adds in trunk/LayoutTests
[chromium] Add chromium baselines for tests added in r93144.
- platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
- platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
- platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:59 AM Changeset in webkit [93213] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark svg/custom/repaint-shadow.svg and
media/media-blocked-by-beforeload.html as flaky.
- platform/chromium/test_expectations.txt:
- 9:25 AM Changeset in webkit [93212] by
-
- 2 edits in trunk/LayoutTests
[chromium] Fix typo in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 9:02 AM Changeset in webkit [93211] by
-
- 2 edits in trunk/LayoutTests
Skip another <progress> test on Windows
- platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.
- 8:49 AM Changeset in webkit [93210] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: http/tests/inspector/network/disabled-cache-crash.html flaky
https://bugs.webkit.org/show_bug.cgi?id=65558
Add TIMEOUT expectation.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 8:22 AM Changeset in webkit [93209] by
-
- 3 edits in trunk/LayoutTests
Add Windows expected failure results for text-combine-image-test.html
Failure is tracked by <http://webkit.org/b/66376>.
- platform/win/fast/text/international/text-combine-image-test-expected.png:
- platform/win/fast/text/international/text-combine-image-test-expected.txt:
- 8:21 AM Changeset in webkit [93208] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows expected failure results for new test added in r93068
Failure is tracked by <http://webkit.org/b/66374>.
- platform/win/editing/deleting/regional-indicators-expected.txt: Added.
- 8:21 AM Changeset in webkit [93207] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows results for new test added in r91777
- platform/win/fast/css/font-family-pictograph-expected.png: Added.
- platform/win/fast/css/font-family-pictograph-expected.txt: Added.
- 7:05 AM Changeset in webkit [93206] by
-
- 1 edit9 adds in trunk/LayoutTests
Add Windows results for tests that differ from Lion due to font differences
These tests started failing in r93107 when I made Windows fall back to Lion results instead
of SnowLeopard results. This is good in general, but these particular tests happen to give
SnowLeopard-ish results due to some fonts that changed in Lion.
- platform/win/css1/font_properties/font-expected.png: Added.
- platform/win/css1/font_properties/font-expected.txt: Copied from platform/mac-snowleopard/css1/font_properties/font-expected.txt.
- platform/win/css2.1/t1508-c527-font-05-b-expected.png: Added.
- platform/win/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Added.
- platform/win/css2.1/t1508-c527-font-10-c-expected.png: Added.
- platform/win/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt.
- platform/win/fast/text/capitalize-boundaries-expected.png: Added.
- platform/win/fast/text/capitalize-boundaries-expected.txt: Copied from platform/win/fast/text/capitalize-boundaries-expected.txt.
- 7:04 AM Changeset in webkit [93205] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows expected failures results for new test added in r93144
Failure is tracked by <http://webkit.org/b/56101>.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- 6:50 AM Changeset in webkit [93204] by
-
- 2 edits in trunk/LayoutTests
http/tests/misc/font-face-in-multiple-segmented-faces.html assertion failure on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66375
Sets a CRASH expectation for Windows debug.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 6:05 AM Changeset in webkit [93203] by
-
- 2 edits in trunk/LayoutTests
Set failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin-in-iframe.html for all build flavors
http://crbug.com/26042
The test already has a failing TEXT expectation for DEBUG and for
LINUX RELEASE, but we're now seeing failures on Mac10.6. It looks like
it's generally flaky.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:45 AM Changeset in webkit [93202] by
-
- 2 edits in trunk/Source/WebCore
Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=66311
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.
Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarMinimumTotalLengthNeededForThumb):
- 4:42 AM Changeset in webkit [93201] by
-
- 5 edits3 deletes in trunk
Unreviewed, rolling out r93186.
http://trac.webkit.org/changeset/93186
https://bugs.webkit.org/show_bug.cgi?id=66114
Breaks LayoutTests on Chromium canary bots
Source/WebCore:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
LayoutTests:
- compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
- compositing/backface-visibility-hierarchical-transform-expected.txt: Removed.
- compositing/backface-visibility-hierarchical-transform.html: Removed.
- 3:54 AM Changeset in webkit [93200] by
-
- 3 edits in trunk/LayoutTests
[Qt] REGRESSION after r93011
https://bugs.webkit.org/show_bug.cgi?id=66212
Unreviewed gardening.
- platform/qt-4.8/Skipped:
- Unskip fast/css/font-face-opentype.html.
- Unskip http/tests/security/cross-frame-access-put.html, because it passes now.
- platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Update Qt 4.8 specific expected result.
- 3:52 AM Changeset in webkit [93199] by
-
- 8 edits in trunk/Source/WebCore
Get rid of calls to deprecatedNode and deprecatedEditingOffset in
AccessibilityRenderObject.cpp and InsertTextCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=66014
Reviewed by Hajime Morita.
Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
and deprecatedEditingOffset.
(WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.
- dom/Position.h:
(WebCore::Position::rootEditableElement): Added.
- dom/Range.cpp:
(WebCore::Range::setStart): Added.
(WebCore::Range::setEnd): Added.
- dom/Range.h:
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
- editing/RenderedPosition.cpp:
(WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.
- editing/RenderedPosition.h:
- 3:49 AM Changeset in webkit [93198] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped:
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added. (test introduced in r93144)
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added. (test introduced in r93144)
- platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added. (test introduced in r93144)
- platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added. (test introduced in r93144)
- 1:28 AM Changeset in webkit [93197] by
-
- 3 edits in trunk/Source/WebCore
Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
https://bugs.webkit.org/show_bug.cgi?id=66238
Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.
Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:
- -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
- animation is delayed because shouldSuspendScrollAnimations() is true
- ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
- At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.
It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.
Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.
- platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
- platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterForceFlashScrollers):
- 1:26 AM Changeset in webkit [93196] by
-
- 30 edits2 adds in trunk
2011-08-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131
Reviewed by Pavel Feldman.
Test: inspector/view-events.html
- added a notion of an optional parent to a View
- maintain a list of View children
- dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
- promoted Panel's logic of (re)storing scroll positions to view
- demoted inheritScrollPositionFromView to a couple of views that need it.
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype.onResize):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.populateStatusBar): (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.onResize): (WebInspector.SimpleCookiesTable.prototype.onResize):
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.onResize):
- inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype.onResize):
- inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.onResize): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.onResize):
- inspector/front-end/ExtensionPanel.js:
- inspector/front-end/FontView.js: (WebInspector.FontView.prototype.onResize):
- inspector/front-end/IFrameView.js: (WebInspector.IFrameView):
- inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView.prototype._installHighlightSupport):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView): (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkLogView.prototype.onResize): (WebInspector.NetworkLogView.prototype.wasShown): (WebInspector.NetworkLogView.prototype.willHide): (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype._showResource): (WebInspector.NetworkPanel.prototype._closeVisibleResource):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.performSearch.processChunk): (WebInspector.Panel.prototype.performSearch): (WebInspector.Panel.prototype.updateSidebarWidth):
- inspector/front-end/PanelEnablerView.js: (WebInspector.PanelEnablerView.prototype.show): (WebInspector.PanelEnablerView.prototype.onResize):
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.onResize):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
- inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.onResize):
- inspector/front-end/ResourcePreviewView.js: (WebInspector.ResourcePreviewView.prototype.contentLoaded):
- inspector/front-end/ResourceResponseView.js: (WebInspector.ResourceResponseView.prototype.contentLoaded):
- inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.prototype.show):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._innerShowView): (WebInspector.ResourcesPanel.prototype.closeVisibleView): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.willHide): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.inheritScrollPositions):
- inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TextViewer.prototype.inheritScrollPositions): (WebInspector.TextViewer.prototype.onResize):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.onResize): (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.TimelinePanel.prototype.show):
- inspector/front-end/View.js: (WebInspector.View): (WebInspector.View.prototype.wasShown): (WebInspector.View.prototype.willHide): (WebInspector.View.prototype._innerShow): (WebInspector.View.prototype.show): (WebInspector.View.prototype._innerHide): (WebInspector.View.prototype.hide): (WebInspector.View.prototype._detach): (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.View.prototype.storeScrollPositions): (WebInspector.View.prototype.restoreScrollPositions): (WebInspector.View.prototype.addChildView): (WebInspector.View.prototype.removeChildView): (WebInspector.View.prototype.onResize): (WebInspector.View.prototype.doResize): (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren): (WebInspector.View.prototype.dispatchToVisibleChildren):
- inspector/front-end/inspector.js: (WebInspector.windowResize):
2011-08-16 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131
Reviewed by Pavel Feldman.
- inspector/view-events-expected.txt: Added.
- inspector/view-events.html: Added.
Aug 16, 2011:
- 9:51 PM Changeset in webkit [93195] by
-
- 6 edits in trunk/Source/WebCore
Represent RenderStyle::textOverflow property using an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356
Reviewed by Dan Bernstein.
No new tests - no behavioral changes.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.
- rendering/style/RenderStyleConstants.h:
Define TextOverflow enum.
- rendering/style/StyleRareNonInheritedData.h:
Change representation of text overflow from bool to one-bit unsigned.
- 9:49 PM Changeset in webkit [93194] by
-
- 2 edits in trunk/Source/WebCore
Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339
Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
Reviewed by Darin Adler.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
- 6:54 PM Changeset in webkit [93193] by
-
- 1 edit in branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp
Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340
Reviewed by Adam Barth.
Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669011
- 6:41 PM Changeset in webkit [93192] by
-
- 1 edit in branches/chromium/782/Source/WebCore/loader/CrossOriginAccessControl.cpp
Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340
Reviewed by Adam Barth.
Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7669010
- 6:41 PM Changeset in webkit [93191] by
-
- 1 edit1 add in trunk/LayoutTests
Add new chromium-mac-leopard directory to match the chromium-mac that
tonywork added. This directory will house Skia results for Chromium Mac.
- platform/chromium-mac-leopard: Added.
- 6:38 PM Changeset in webkit [93190] by
-
- 3 edits in trunk/Tools
Add a CG qualifier similar to the GPU qualifier
https://bugs.webkit.org/show_bug.cgi?id=66359
Reviewed by Eric Seidel.
Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- 6:34 PM Changeset in webkit [93189] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351
JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively. In some cases,
we may get to this generated code with one or both of these
registers trash. One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress(). This patch uses the
values on the stack. A longer term solution is to work out all
cases so that the register entry assumptions can assured.
While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.
Reviewed by Gavin Barraclough.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 6:32 PM Changeset in webkit [93188] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340
Reviewed by Adam Barth.
Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.
- 6:29 PM Changeset in webkit [93187] by
-
- 6 edits4 adds in trunk/LayoutTests
Add two sample mismatch reftests to make sure that reftests work correctly.
https://bugs.webkit.org/show_bug.cgi?id=66218
Reviewed by Tony Chang.
One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.
- fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
- fast/harness/sample-fail-mismatch-reftest.html: Added.
- fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
- fast/harness/sample-mismatch-reftest.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 6:24 PM Changeset in webkit [93186] by
-
- 5 edits3 adds in trunk
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.
Source/WebCore:
Test: compositing/backface-visibility-hierarchical-transform.html
Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform. The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl). This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.
Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility. Now it simply uses the screen space transform.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):
LayoutTests:
This case tests if backface visibility properly accounts for a hierarchy
of transforms.
- compositing/backface-visibility-hierarchical-transform-expected.png: Added.
- compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
- compositing/backface-visibility-hierarchical-transform.html: Added.
- 6:11 PM Changeset in webkit [93185] by
-
- 4 edits in trunk/LayoutTests
More rebaselines for Windows WebKit2 port.
- platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
- platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
- platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
- 5:57 PM Changeset in webkit [93184] by
-
- 3 edits2 adds2 deletes in trunk
Implement proper handling of events which happen in children of shadow hosts.
https://bugs.webkit.org/show_bug.cgi?id=66285
Reviewed by Dimitri Glazkov.
Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.
Source/WebCore:
Test: fast/dom/shadow/shadow-contents-event.html
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):
LayoutTests:
- fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
- fast/dom/shadow/details-summary-mouseover.html: Removed.
- fast/dom/shadow/shadow-contents-event-expected.txt: Added.
- fast/dom/shadow/shadow-contents-event.html: Added.
- 5:55 PM Changeset in webkit [93183] by
-
- 3 edits in trunk/Tools
REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325
Unreviewed. Fixing an exception/typo seen on the bots (and testing to make sure it works).
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- 5:16 PM Changeset in webkit [93182] by
-
- 8 edits in trunk/Source
Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=65694
Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests since there is no change in behavior.
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
- loader/ThreadableLoader.h:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
- notifications/Notification.cpp:
(WebCore::Notification::startLoading):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit/chromium:
- src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::loadAsynchronously):
- 5:07 PM Changeset in webkit [93181] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 5:06 PM Changeset in webkit [93180] by
-
- 1 copy in tags/Safari-534.51.16
New tag.
- 5:05 PM Changeset in webkit [93179] by
-
- 5 edits in branches/safari-534.51-branch/Source
Versioning.
- 4:51 PM Changeset in webkit [93178] by
-
- 2 edits in trunk/Tools
Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349
Reviewed by James Robinson.
As requested by jamesr.
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:30 PM Changeset in webkit [93177] by
-
- 1 edit4 copies1 add in trunk/LayoutTests
win-wk2 needs updated baselines for some editing tests
https://bugs.webkit.org/show_bug.cgi?id=66344
win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.
- platform/win-wk2/editing/deleting: Added.
- platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
- platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
- platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
- platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
- 4:30 PM Changeset in webkit [93176] by
-
- 6 edits3 adds in trunk/Tools
REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325
Reviewed by Adam Barth.
WinPort didn't have any port_name parsing logic.
Seemed it was best to just share the logic from MacPort.
Sharing the logic from MacPort seemed easiest with a shared superclass.
Once I created ApplePort (the superclass) there was a bunch of logic to share.
I found LeakDetector was just in the way when switching back and forth
between win.py and mac.py so I moved it into its own file.
The only logic change here is that WinPort should now be
able to parse port_name values like MacPort (and other ports)
can. The fact that ports do this in their constructors is
wrong and a source of many bugs. But at least now WinPort
matches the status-quo.
- Scripts/webkitpy/layout_tests/port/apple.py: Added.
- Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
- Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/win.py:
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
- 4:26 PM Changeset in webkit [93175] by
-
- 3 edits in trunk/Tools
Add webkit-patch analyze-baselines, as requested by jamesr.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:16 PM Changeset in webkit [93174] by
-
- 9 edits in trunk/Source/WebCore
Fix spelling error.
https://bugs.webkit.org/show_bug.cgi?id=66261
Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-16
Reviewed by Adam Barth.
No functional change, no tests needed.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::notifyPositionChanged):
- platform/ScrollAnimator.h:
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
- platform/chromium/ScrollAnimatorChromiumMac.h:
- platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
- 4:12 PM Changeset in webkit [93173] by
-
- 2 edits in trunk/Tools
Fold bulk-optimize-baselines into optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=66345
Reviewed by James Robinson.
bulk-optimize-baselines is now a superset of optimize-baselines, so
they can be combined.
- Scripts/webkitpy/tool/commands/rebaseline.py:
- 4:12 PM Changeset in webkit [93172] by
-
- 1 edit8 adds in trunk/LayoutTests
Add placeholder directories so the chromium canary bots can update.
- platform/chromium-mac: Added.
- platform/chromium-mac/fast: Added.
- platform/chromium-mac/fast/events: Added.
- platform/chromium-mac/http: Added.
- platform/chromium-mac/http/tests: Added.
- platform/chromium-mac/http/tests/workers: Added.
- platform/chromium-mac/storage: Added.
- platform/chromium-mac/storage/domstorage: Added.
- 3:58 PM Changeset in webkit [93171] by
-
- 4 edits in trunk
<http://webkit.org/b/66328> ASSERT in fast/css/custom-font-xheight.html
Reviewed by Dan Bernstein.
In r93140 the temporary font created for a remote CSS font face
was created without being retained. We need to protect the
font from being purged while we hold onto it, so add a font cache
purge preventer.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- platform/chromium/test_expectations.txt:
Unskipped.
- 3:35 PM Changeset in webkit [93170] by
-
- 2 edits in trunk/LayoutTests
Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
which WebKitTestRunner does not support yet.
- platform/wk2/Skipped:
- 3:25 PM Changeset in webkit [93169] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] cleanup after previous webkit change rolled into chrome
https://bugs.webkit.org/show_bug.cgi?id=66177
Reviewed by James Robinson.
- DEPS:
- WebKit.gyp:
- public/WebScrollbar.h:
- 3:21 PM Changeset in webkit [93168] by
-
- 1 move in trunk/LayoutTests/platform/chromium-cg-mac-leopard
This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.
- 3:20 PM Changeset in webkit [93167] by
-
- 1 move in trunk/LayoutTests/platform/chromium-cg-mac
This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.
- 3:20 PM Changeset in webkit [93166] by
-
- 19 edits in trunk/Tools
Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
https://bugs.webkit.org/show_bug.cgi?id=66334
Reviewed by Tony Chang.
This patch moves us closer to switching the Chromium port from
CoreGraphics to Skia. This patch teaches our tools that the current
Chromium Mac configuration is actually chromium-cg-mac, which makes
room for a future chromium-mac configuration that uses Skia.
Shortly after this patch lands, I'll do a server-side move of the
chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
and chromium-cg-mac-leopard.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
- Scripts/webkitpy/common/config/build.py:
- Scripts/webkitpy/common/config/build_unittest.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- 3:15 PM Changeset in webkit [93165] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/css/custom-font-xheight.html is asserting on all
chromium builds.
Also mark 2 repaint tests as failing on mac.
- platform/chromium/test_expectations.txt:
- 3:10 PM Changeset in webkit [93164] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/repaint/canvas-putImageData.html is now passing
because of the win baselines added in r93139.
- platform/chromium/test_expectations.txt:
- 3:07 PM Changeset in webkit [93163] by
-
- 5 edits in trunk/Tools
garden-o-matic frontend needs a friendly relative time description method.
https://bugs.webkit.org/show_bug.cgi?id=66324
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
- 3:01 PM Changeset in webkit [93162] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows results for scripts-panel.html
The Windows results match the cross-platform results, not the Mac results.
- platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
- 2:55 PM Changeset in webkit [93161] by
-
- 4 edits in trunk/Tools
Summary view should not add multiple entries for the same test failure.
https://bugs.webkit.org/show_bug.cgi?id=66318
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
- 2:39 PM Changeset in webkit [93160] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium Windows build fix after r93140. Take 4.
Namespace the now public enum as FontCache::ShouldRetain.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
- 2:35 PM Changeset in webkit [93159] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows results for overlapped-iframe-iframe.html
The Windows results match the cross-platform results, not the Mac results.
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
- 2:32 PM Changeset in webkit [93158] by
-
- 2 edits in trunk/LayoutTests
Skip another test that relies on eventSender.scalePageBy on Windows
- platform/win/Skipped: Added fast/repaint/background-scaling.html.
- 2:32 PM Changeset in webkit [93157] by
-
- 15 edits in trunk/Source/WebCore
Canvas resizing can be slow
https://bugs.webkit.org/show_bug.cgi?id=66251
Canvas resizing was slow due to re-allocation of the ImageBuffer on
each size change (width or height). This was introduced inadvertently
by calls to isAccelerated() during canvas reset(). Since we won't
know if we have successfully accelerated until ImageBuffer creation,
move the compositor invalidation to createImageBuffer() as well.
This patch also attempts to unify the Skia and CG accelerated canvas
paths. The DrawingBuffer used by the Skia path is now owned by
ImageBuffer[Skia], similar to how the IOSurface is owned by
ImageBuffer[CG]. Some of the logic for when to accelerate was moved
into HTMLCanvasElement and unified with the CG path. Acceleration is
also now enabled by the same "Accelerated" ImageBuffer create flag
used by the CG path. DrawingBuffer is now re-created even for a
same-size change (same as the memory buffer), but we speed it up
by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
clear it, since it's done with a glClear anyway).
Reviewed by Kenneth Russell.
Covered by existing tests in fast/canvas and canvas/philip.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
Don't call isAccelerated() from reset(), since we don't want to
inadvertently create the ImageBuffer. Also, since we won't know if
we have successfully accelerated until createImageBuffer() is
called, defer the compositor invalidation to createImageBuffer() as
well.
(WebCore::HTMLCanvasElement::shouldAccelerate):
Unify the CG and Skia ports' logic for when to accelerate (Skia
logic moved in from CanvasRenderingContext2D).
(WebCore::HTMLCanvasElement::createImageBuffer):
Use the unified shouldAccelerate() logic, and pass it as a flag
to ImageBuffer. Do compositor invalidation as well.
- html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
Expose hasCreatedImageBuffer() publically, so
CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
it.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Remove all acceleration setting and resetting, since it's now done
during ImageBuffer creation.
(WebCore::CanvasRenderingContext2D::isAccelerated):
Check if the image buffer was created, so we don't inadvertently
create it here.
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
WebViewImpl may be null. Ask the render tree instead.
(WebCore::CanvasRenderingContext2D::reset):
Don't reset acceleration here, since we don't own it anymore.
(WebCore::CanvasRenderingContext2D::platformLayer):
Call into the ImageBuffer to get our PlatformLayer.
- html/canvas/CanvasRenderingContext2D.h:
Remove m_drawingBuffer, and all acceleration-related calls.
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::platformLayer):
Implement a dummy platformLayer() call for non-skia ports.
- platform/graphics/ImageBuffer.h:
Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
- platform/graphics/chromium/ImageBufferDataSkia.h:
Add a DrawingBuffer data member.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
Since we immediately clear the framebuffer via glClear(), this whole
resource safe business is overkill.
- platform/graphics/skia/GraphicsContextSkia.cpp:
Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This
functionality is handled by ImageBuffer now.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Give the ImageBufferData ownership of the DrawingBuffer.
(WebCore::ImageBuffer::platformLayer):
Implement an accessor for the DrawingBuffer's PlatformLayer.
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setGraphicsContext3D):
- platform/graphics/skia/PlatformContextSkia.h:
Remove isPathSkiaSafe() extern (unused).
Remove paintsIntoImageBuffer() (now unused). Remove IntSize param
from setGraphicsContext3D() (unused).
- 2:19 PM Changeset in webkit [93156] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium Windows build fix after r93140. Take 3.
Include the proper includes!
- platform/graphics/FontCache.h:
- 2:12 PM Changeset in webkit [93155] by
-
- 3 edits in trunk/Tools
Teach TestFailures that tests that have failed or passed many times in a row are not flaky
The basic strategy here is that once a test has failed or passed many times in a row we
never again consider it as a possibly flaky test. It's a simple strategy but seems to result
in many fewer false positives than our current behavior.
Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
flaky, including tests that failed for a while but then were fixed
Reviewed by Dan Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
(FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
number of non-too-many-failure builds we've seen.
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
tests, keep track of how many times they have passed or failed in a row. If they pass or
fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
considered flaky it doesn't matter how many times it passes or fails.)
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
Added tests for the above.
- 2:12 PM Changeset in webkit [93154] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/css/custom-font-xheight.html is hitting an assert
in debug on Linux.
- platform/chromium/test_expectations.txt:
- 2:01 PM Changeset in webkit [93153] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark new tests as failing. Will pull results from the
bots when they cycle.
- platform/chromium/test_expectations.txt:
- 1:57 PM Changeset in webkit [93152] by
-
- 2 edits8 adds in trunk/Tools
garden-o-matic needs a summary view with actions for each problem.
https://bugs.webkit.org/show_bug.cgi?id=66144
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
- 1:47 PM Changeset in webkit [93151] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium Windows build fix after r93140. Take 2.
This just makes the troublesome enum public. If this
fixes the build I will file a follow-up bug to clean-up
these build issues and either keep the enum public and
cleanup other functions or restore the enum to private.
There is no harm in making the enum public right now.
- platform/graphics/FontCache.h:
- 1:44 PM Changeset in webkit [93150] by
-
- 3 edits2 adds in trunk
Unmatrix algorithm implementation is wrong
https://bugs.webkit.org/show_bug.cgi?id=66080
Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-08-16
Reviewed by Dean Jackson.
Source/WebCore:
Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.
Test: animations/animation-matrix-negative-scale-unmatrix.html
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose):
LayoutTests:
- animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
- animations/animation-matrix-negative-scale-unmatrix.html: Added.
- 1:28 PM Changeset in webkit [93149] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Chromium Windows build fix after r93140.
- platform/graphics/FontCache.h:
- 1:13 PM Changeset in webkit [93148] by
-
- 3 edits1 delete in trunk/LayoutTests
Make video-controls-no-scripting.html results platform independent.
- media/video-controls-no-scripting-expected.txt:
- media/video-controls-no-scripting.html:
- platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
- 1:10 PM Changeset in webkit [93147] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed Windows and Chromium Windows build fix after r93140.
- platform/graphics/FontCache.h:
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
- 12:50 PM Changeset in webkit [93146] by
-
- 3 edits in trunk/Source/WebCore
Make placeholder text remain visible until a character is typed on Windows
Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields
Covered by existing tests (which are currently failing on the bots until this patch lands).
Reviewed by Dave Hyatt.
- rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
- rendering/RenderThemeWin.h:
(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.
- 12:48 PM Changeset in webkit [93145] by
-
- 2 edits in trunk/Tools
Adding Ted "hober" O'Connor as a non-committing contributor.
- Scripts/webkitpy/common/config/committers.py:
- 12:43 PM Changeset in webkit [93144] by
-
- 8 edits9 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=66254
Source/WebCore:
Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
content.
Reviewed by Simon Fraser.
Added new tests in fast/repaint.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):
- rendering/RenderObject.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::renderFlowThreadWithName):
- rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):
LayoutTests:
Make regions repaint properly. Added new repaint tests.
Reviewed by Simon Fraser.
- fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
- fast/repaint/line-flow-with-floats-in-regions.html: Added.
- fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
- platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
- 12:42 PM Changeset in webkit [93143] by
-
- 5 edits in branches/safari-534.51-branch
Merge r93070.
- 12:40 PM Changeset in webkit [93142] by
-
- 5 edits in branches/safari-534.51-branch
Merge r93048.
- 12:34 PM Changeset in webkit [93141] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r93047.
- 12:18 PM Changeset in webkit [93140] by
-
- 14 edits in trunk/Source/WebCore
Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153
Reviewed by Dan Bernstein.
While a remote CSS font face is loading we fallback to a
temporary font. We don't want to retain the fallback font
because noone takes ownership of the temporary font. This
patch adds a way to get an uncached fallback font, which
plumbs the ShouldRetain enum through the different platform
implementations of getLastResortFallbackFont.
No new tests, no functional change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
- platform/graphics/FontCache.h:
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wince/FontCacheWinCE.cpp:
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 12:12 PM Changeset in webkit [93139] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows expected results for some <canvas> tests
<canvas> doesn't use accelerated compositing on Windows like it does on Lion.
- platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
- platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
- 11:56 AM Changeset in webkit [93138] by
-
- 2 edits in trunk/Websites/webkit.org
2011-08-16 Daniel Bates <dbates@webkit.org>
Add myself to the list of individual members in the WebKit Security Group.
Rubber-stamped by Eric Seidel.
- security/security-group-members.html:
- 11:49 AM Changeset in webkit [93137] by
-
- 2 edits in branches/safari-534.51-branch/Source/WebCore
Merge r92977.
- 11:45 AM Changeset in webkit [93136] by
-
- 8 edits in trunk/Source/WebCore
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226
Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.
No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
- platform/ScrollbarThemeComposite.h:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
- 11:44 AM Changeset in webkit [93135] by
-
- 3 edits in branches/safari-534.51-branch/Source
Merge r88444.
- 11:39 AM Changeset in webkit [93134] by
-
- 72 edits2 adds in trunk
Programmatically set selection should not have direction on Mac
https://bugs.webkit.org/show_bug.cgi?id=60529
Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
Reviewed by Ryosuke Niwa.
Source/WebCore:
Modified default value of VisibleSelection->m_isDirectional from 'true'
to 'false' by adding a defaulted argument to several VisibleSelection
constructors to make programmatic selection be directionless by default
on Mac. Also modified several calls to VisibleSelection's constructors
to correctly preserve directionality.
Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
a call to setExtent triggers an editing delegate that uses the
FrameSelection. The direction here should have been preserved from before,
but setIsDirectional was not called until after FrameSelection.cpp:869. It
has been moved up to make things behave.
- WebCore.exp.in:
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::doApply):
- editing/Editor.cpp:
(WebCore::Editor::selectionForCommand):
- editing/FrameSelection.cpp:
(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):
- editing/FrameSelection.h:
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::doApply):
- editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::VisibleSelection):
- editing/VisibleSelection.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):
LayoutTests:
Added editing/selection/programmatic-selection-on-mac-is-directionless
to test selection direction in programmatically set selections on
windows, unix, and mac, in plain text, editable divs, text-input
fields, and textareas. Modified text baselines for many editing tests,
which had a delegate change as a result of the cpp patch.
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/selection/after-line-break-expected.txt:
- platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- platform/mac/editing/deleting/delete-and-undo-expected.txt:
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
- platform/mac/editing/deleting/delete-br-002-expected.txt:
- platform/mac/editing/deleting/delete-br-004-expected.txt:
- platform/mac/editing/deleting/delete-br-005-expected.txt:
- platform/mac/editing/deleting/delete-br-006-expected.txt:
- platform/mac/editing/deleting/delete-br-009-expected.txt:
- platform/mac/editing/deleting/delete-br-010-expected.txt:
- platform/mac/editing/deleting/delete-br-011-expected.txt:
- platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
- platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
- platform/mac/editing/deleting/smart-delete-002-expected.txt:
- platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
- platform/mac/editing/inserting/insert-at-end-01-expected.txt:
- platform/mac/editing/inserting/insert-at-end-02-expected.txt:
- platform/mac/editing/inserting/insert-div-010-expected.txt:
- platform/mac/editing/inserting/insert-div-013-expected.txt:
- platform/mac/editing/inserting/insert-div-015-expected.txt:
- platform/mac/editing/inserting/insert-div-019-expected.txt:
- platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
- platform/mac/editing/pasteboard/3976872-expected.txt:
- platform/mac/editing/pasteboard/4076267-2-expected.txt:
- platform/mac/editing/pasteboard/4076267-expected.txt:
- platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
- platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
- platform/mac/editing/pasteboard/paste-text-014-expected.txt:
- platform/mac/editing/pasteboard/paste-text-015-expected.txt:
- platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
- platform/mac/editing/selection/4932260-1-expected.txt:
- platform/mac/editing/selection/anchor-focus2-expected.txt:
- platform/mac/editing/selection/anchor-focus3-expected.txt:
- platform/mac/editing/selection/expanding-selections-expected.txt:
- platform/mac/editing/selection/expanding-selections2-expected.txt:
- platform/mac/editing/selection/fake-drag-expected.txt:
- platform/mac/editing/selection/move-by-word-001-expected.txt:
- platform/mac/editing/selection/transformed-selection-rects-expected.txt:
- platform/mac/editing/selection/triple-click-in-pre-expected.txt:
- platform/mac/editing/style/create-block-for-style-008-expected.txt:
- platform/mac/editing/undo/4063751-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/mac/editing/undo/undo-forward-delete-expected.txt:
- 11:36 AM Changeset in webkit [93133] by
-
- 7 edits in trunk/Source/WebCore
New XML parser: Add document fragment parser
https://bugs.webkit.org/show_bug.cgi?id=66317
Reviewed by Adam Barth.
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseXML):
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::parseDocumentFragment):
- xml/parser/NewXMLDocumentParser.h:
(WebCore::NewXMLDocumentParser::create):
- xml/parser/XMLTokenizer.h:
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::pushCurrentNode):
- xml/parser/XMLTreeBuilder.h:
(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::node):
- 11:36 AM Changeset in webkit [93132] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.
- platform/chromium/test_expectations.txt:
- 11:23 AM Changeset in webkit [93131] by
-
- 3 edits in trunk/Source/WebKit/chromium
GraphicsContext3D should allow its hostWindow to be NULL
https://bugs.webkit.org/show_bug.cgi?id=66305
Allow the hostWindow param (and m_webViewImpl) to be NULL. This
makes it much easier to enable GPU acceleration at a lower level
in WebKit's platform/graphics layer, without needing access to the
Page* or HostWindow*. Also bump the chromium DEPS to chrome r96940,
which includes a similar change for the in-process GraphicsContext3D
implementations.
Reviewed by James Robinson.
- DEPS:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::initialize):
(WebCore::GraphicsContext3DInternal::platformTexture):
(WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):
- 11:07 AM Changeset in webkit [93130] by
-
- 3 edits in trunk/Source/WebCore
New XML parser: Replace assertions regarding character data in the prolog with proper checks
https://bugs.webkit.org/show_bug.cgi?id=66269
Reviewed by Adam Barth.
This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):
- xml/parser/XMLTreeBuilder.h:
- 11:04 AM Changeset in webkit [93129] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).
- platform/chromium/test_expectations.txt:
- 11:03 AM Changeset in webkit [93128] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows expected results for resource-har-conversion.html
While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
extra fields in the request objects.
- platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
- 10:58 AM Changeset in webkit [93127] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: word wrap long edits
https://bugs.webkit.org/show_bug.cgi?id=65512
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.css:
(.styles-section .properties li.child-editing):
- 10:31 AM Changeset in webkit [93126] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
https://bugs.webkit.org/show_bug.cgi?id=66316
Reviewed by NOBODY (OOPS!).
- WebKit.gyp:
- 10:27 AM Changeset in webkit [93125] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: convert DOM breakpoint types to strings.
https://bugs.webkit.org/show_bug.cgi?id=66304
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):
- 10:23 AM Changeset in webkit [93124] by
-
- 1 edit1 add in trunk/LayoutTests
Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir. The mac result (r93112) was getting
picked up by the chromium port.
- platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
- 10:16 AM Changeset in webkit [93123] by
-
- 2 edits1 move1 add in trunk/LayoutTests
Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.
Also add chromium baseline (the top of the video control is in a
different place).
- media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
- media/video-controls-no-scripting.html:
- platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
- 10:15 AM Changeset in webkit [93122] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: force pseudo element state when checking it in the styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=66292
This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.
Reviewed by David Hyatt.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- css/CSSStyleSelector.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::forcePseudoStateImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::forcePseudoState):
- 9:59 AM Changeset in webkit [93121] by
-
- 1 edit in branches/safari-534.51-branch/LayoutTests/ChangeLog
rollout incorrect submit of 93118.
- 9:57 AM Changeset in webkit [93120] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r93114.
http://trac.webkit.org/changeset/93114
https://bugs.webkit.org/show_bug.cgi?id=66226
broke the chromium mac compile
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollbarTheme.h:
- platform/ScrollbarThemeComposite.cpp:
- platform/ScrollbarThemeComposite.h:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
- platform/mac/ScrollbarThemeMac.h:
- 9:56 AM Changeset in webkit [93119] by
-
- 2 edits in trunk/LayoutTests
Update Windows results for a fast/text test for Safari 5.1's AAS
The results are now more like Mac's. Dan Bernstein says this is probably a progression.
- platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
- 9:55 AM Changeset in webkit [93118] by
-
- 1 edit in branches/safari-534.51-branch/LayoutTests/ChangeLog
Merge r36608.
- 9:46 AM Changeset in webkit [93117] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark media/video-source-error.html as flaky in Debug.
- platform/chromium/test_expectations.txt:
- 9:44 AM Changeset in webkit [93116] by
-
- 3 edits in trunk/LayoutTests
Update Windows results after r92890
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 9:39 AM Changeset in webkit [93115] by
-
- 1 edit3 deletes in trunk/LayoutTests
Remove Windows-specific hyphenation test results now that hyphenation works on Windows
- platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
- platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
- platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
- 9:34 AM Changeset in webkit [93114] by
-
- 8 edits in trunk/Source/WebCore
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226
Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.
No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
- platform/ScrollbarThemeComposite.h:
- platform/chromium/ScrollbarThemeChromiumMac.h:
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
- 9:31 AM Changeset in webkit [93113] by
-
- 1 edit3 adds in trunk/LayoutTests
Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir. The mac failing results (r93105) were
getting picked up by the chromium port.
- platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
- platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
- 9:28 AM Changeset in webkit [93112] by
-
- 1 edit3 adds in trunk/LayoutTests
Add Lion/Windows expected results for an Inspector test
The only difference from the cross-platform results is that the .js resources are now given
a MIME type of "text/plain".
This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.
- platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
- platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
- 9:27 AM Changeset in webkit [93111] by
-
- 4 edits in trunk/Tools
Teach TestFailures how to interpret unfinished test runs
Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
rather than "isStarted" so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.
- 9:19 AM Changeset in webkit [93110] by
-
- 3 edits in trunk/Source/WebCore
Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=66273
Reviewed by Simon Fraser.
No new tests - no functionality changed - refactoring only.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Define cast from CSSPrimitiveValue to ETransformStyle3D.
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
Define cast from ETransformStyle3D to CSSPrimitiveValue.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to handle CSSPropertyWebkitTransformStyle.
- 9:18 AM Changeset in webkit [93109] by
-
- 2 edits in trunk/Source/WebCore
Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=66279
Reviewed by Simon Fraser.
No new tests - no functionality changed - simple refactoring only.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.
- 9:13 AM Changeset in webkit [93108] by
-
- 4 edits3 adds in trunk
2011-08-16 Eric Carlson <eric.carlson@apple.com>
[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303
Reviewed by Dimitri Glazkov.
Tests: media/video-controls-no-scripting-iframe.html
media/video-controls-no-scripting.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
to configureMediaControls.
(WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
(WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in
attributeChanged and preDispatchEventHandler here.
(WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
to configureMediaControls.
- html/HTMLMediaElement.h:
2011-08-16 Eric Carlson <eric.carlson@apple.com>
[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303
Reviewed by Dimitri Glazkov.
- media/video-controls-no-scripting-expected.txt: Added.
- media/video-controls-no-scripting-iframe.html: Added.
- media/video-controls-no-scripting.html: Added.
- 9:03 AM Changeset in webkit [93107] by
-
- 6 edits in trunk/Tools
Make Apple's Windows port fall back to Lion results instead of SnowLeopard
Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
should match Lion's behavior.
Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
but doesn't use Lion results
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(expectedDirectoryForTest):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.baseline_search_path):
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_baseline_search_path):
Replaced mac-snowleopard with mac-lion.
- Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
directory, which all Apple Mac platforms and Apple Win platforms could potentially use
results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
will no longer look there for results.
- Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build): Tests for the above changes.
- 9:00 AM Changeset in webkit [93106] by
-
- 2 edits in trunk/LayoutTests
Stop skipping the web-apps tests I just landed results for on Lion
- platform/mac-lion/Skipped:
- 8:57 AM Changeset in webkit [93105] by
-
- 1 edit7 adds in trunk/LayoutTests
Check in expected failure results for some web-apps tests on Lion and Windows
Since these failures are likely due to bugs in non-WebKit components, they are tracked by
<rdar://problem/9313271>.
- platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
- platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
- platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
- platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
- 8:51 AM Changeset in webkit [93104] by
-
- 2 edits4 copies10 adds1 delete in trunk/LayoutTests
Share Sputnik Unicode results between Lion and Windows
Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.
- platform/mac-lion/Skipped: Removed these tests.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
- platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
- platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
- platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
- platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
- platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
- 8:41 AM WebKit Team edited by
- (diff)
- 8:33 AM Changeset in webkit [93103] by
-
- 5 edits in trunk/LayoutTests
Update Windows Sputnik results for ICU 4.6
Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.
- platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
- platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
- platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
- platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
- 8:16 AM Changeset in webkit [93102] by
-
- 2 edits in trunk/LayoutTests
Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)
Since these failures are likely to be due to bugs in non-WebKit components, they are tracked
by Radars.
- platform/win/Skipped: Added http/tests/multipart/invalid-image-data-standalone.html,
http/tests/cookies/simple-cookies-expired.html, and
http/tests/cookies/simple-cookies-max-age.html.
- 7:53 AM Changeset in webkit [93101] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: hide non-conservative methods from the protocol documentation.
https://bugs.webkit.org/show_bug.cgi?id=66301
Reviewed by Yury Semikhatsky.
- inspector/Inspector.json:
- 7:50 AM Changeset in webkit [93100] by
-
- 2 edits in trunk/LayoutTests
Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg
See http://code.google.com/p/chromium/issues/detail?id=93044
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 7:42 AM Changeset in webkit [93099] by
-
- 2 edits in trunk/LayoutTests
Add TIMEOUT expectation for editing/deleting/regional-indicators.html
https://bugs.webkit.org/show_bug.cgi?id=66268
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 7:39 AM Changeset in webkit [93098] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296
Fix the GTK build after r93095.
Unreviewed build fix.
No new tests neede.
- GNUmakefile.list.am: Remove nonexistent sources.
- 7:26 AM Changeset in webkit [93097] by
-
- 20 edits1 add in trunk
Reviewed by Csaba Osztrogonác.
Need AtomicStrings for the various font family names
https://bugs.webkit.org/show_bug.cgi?id=28024
.:
- Source/cmake/WebKitMacros.cmake: Add new macro.
Source/WebCore:
Unify the usage of '-webkit' prefixed font family names by using
global AtomicStrings.
Use a .in file to generate the needed sources through make_names.pl.
No new tests needed.
- CMakeLists.txt:
- CodeGenerators.pri:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::identifierForFamily):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::fontDataForGenericFamily):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/WebKitFontFamilyNames.in: Added.
- dom/make_names.pl:
- page/Frame.cpp:
(WebCore::Frame::Frame):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::useFixedDefaultSize):
- 7:15 AM Changeset in webkit [93096] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
https://bugs.webkit.org/show_bug.cgi?id=66300
Reviewed by Pavel Feldman.
- WebKit.gyp:
- 6:41 AM Changeset in webkit [93095] by
-
- 12 edits10 deletes in trunk
Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296
Reviewed by Yury Semikhatsky.
Source/WebCore:
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/EventsCollector.cpp: Removed.
- inspector/EventsCollector.h: Removed.
- inspector/Inspector.json:
- inspector/InspectorFrontendProxy.cpp: Removed.
- inspector/InspectorFrontendProxy.h: Removed.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
LayoutTests:
- http/tests/inspector/network-test.js:
- http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
- http/tests/inspector/network/network-clear-after-disabled.html: Removed.
- http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
- http/tests/inspector/network/network-close-load-open.html: Removed.
- http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
- http/tests/inspector/network/network-open-load-reopen.html: Removed.
- 6:38 AM Changeset in webkit [93094] by
-
- 2 edits in trunk/LayoutTests
fix
- 6:11 AM Changeset in webkit [93093] by
-
- 9 edits2 adds in trunk/Source
[Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114
Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-16
Reviewed by Benjamin Poulain.
Source/WebCore:
Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):
Source/WebKit/qt:
Added a platform plugin to allow spell and grammar check in QtWebKit.
- Api/qwebkitplatformplugin.h:
- QtWebKit.pro:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):
- WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::textChecker):
- WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::QtPlatformPlugin::createSpellChecker):
- WebCoreSupport/QtPlatformPlugin.h:
- WebCoreSupport/TextCheckerClientQt.cpp: Added.
(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):
- WebCoreSupport/TextCheckerClientQt.h: Added.
(WebCore::TextCheckerClientQt::requestCheckingOfString):
- 6:01 AM Changeset in webkit [93092] by
-
- 2 edits in trunk/Source/WebKit/gtk
Add javascriptcoregtk to the introspection build, to fix it.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> in 2011-08-16
Reviewed by Xan Lopez.
- GNUmakefile.am:
- 5:46 AM Changeset in webkit [93091] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194
Unreviewed gardening.
- platform/wk2/Skipped: skip editing/input/style-change-during-input.html
- 4:35 AM Changeset in webkit [93090] by
-
- 2 edits in trunk/Tools
Move me from contributor to reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 3:04 AM Changeset in webkit [93089] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217
Reviewed by Pavel Feldman.
- http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
- 1:57 AM Changeset in webkit [93088] by
-
- 2 edits in trunk/LayoutTests
[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
https://bugs.webkit.org/show_bug.cgi?id=66268
- platform/qt/Skipped:
- 12:00 AM Changeset in webkit [93087] by
-
- 3 edits2 adds in trunk
REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
https://bugs.webkit.org/show_bug.cgi?id=66216
Reviewed by Ryosuke Niwa.
Source/WebCore:
Element::spellcheckAttributeState() uses Element::hasAttribute(),
which calls updateStyleAttribute(), which potentially makes style
dirty. But that is problematic since Editor calls spellcheckAttributeState()
during the spell-checking phase and make the style dirty,
which can trigger re-layout, which wipes the shadow tree of a textarea
out by pre-committed "value" text.
This change removes the hasAttribute() call from
spellcheckAttributeState().
Test: editing/input/style-change-during-input.html
- dom/Element.cpp:
(WebCore::Element::spellcheckAttributeState):
LayoutTests:
- editing/input/style-change-during-input-expected.txt: Added.
- editing/input/style-change-during-input.html: Added.
