Context Navigation

← Previous Period
Next Period →

Timeline

Sep 11, 2011:

10:46 PM Changeset in webkit [94946] by hayato@chromium.org

8 edits in trunk

Implement a ProgressEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67800

Patch by Kentaro Hara <haraken@google.com> on 2011-09-11
Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/progress-event-constructor.html

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Replaced UnsignedLongLongMax with std::numeric_limits<unsigned long long>::max().

bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::getKeyValue): Returns an unsigned long long value corresponding to a given key. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long

bindings/v8/OptionsObject.h:
bindings/v8/custom/V8EventConstructors.cpp: Added the ProgressEvent constructor.
dom/ProgressEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled fast/events/constructors/progress-event-constructor.html

platform/chromium/test_expectations.txt:

10:26 PM Changeset in webkit [94945] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: slow perf/show-hide-table-rows.html

9:20 PM Changeset in webkit [94944] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: slow perf/document-contains.html

9:00 PM Changeset in webkit [94943] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: add svg/custom/simple-text-double-shadow.svg

8:42 PM Changeset in webkit [94942] by fpizlo@apple.com

16 edits in trunk/Source/JavaScriptCore

DFGNode.h has macros that indicate the enabling of a feature, but
they do not use the ENABLE() idiom.
https://bugs.webkit.org/show_bug.cgi?id=67907

Reviewed by Oliver Hunt.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::stronglyPredict):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGJITCodeGenerator.cpp:
dfg/DFGJITCodeGenerator.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:
dfg/DFGNode.h:
dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):

dfg/DFGScoreBoard.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

8:34 PM Changeset in webkit [94941] by koz@chromium.org

6 edits
14 moves
34 adds
28 deletes in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 3
https://bugs.webkit.org/show_bug.cgi?id=67830

Patch by Ben Wells <benwells@chromium.org> on 2011-09-11
Reviewed by Kenneth Russell.

fast/borders/: 13 changes
fast/frames/iframe-scaling-with-scroll-expected.txt: Renamed from LayoutTests/platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt.
platform/chromium-linux/fast/: 18 changes
platform/chromium-win/fast/: 21 changes
platform/chromium/test_expectations.txt:
platform/mac/fast/: 13 removals
platform/qt/fast/: 14 removals

8:34 PM Changeset in webkit [94940] by mrowe@apple.com

3 edits in trunk/Source/WebKit2

<rdar://problem/9878268> Pressing caps lock after closing a showModalDialog window results in WebProcess exiting

It's incorrect to try and use -[NSApplication run] to run nested runloops as it is not possible to
interrupt a nested invocation of -run without also causing outer invocations to exit after processing
their next event. We can avoid this issue by using -[NSApplication run] for the outermost invocation
of the main runloop, while using CFRunLoopRun for any nested invocations.

Reviewed by Anders Carlsson.

Platform/RunLoop.h:
Platform/mac/RunLoopMac.mm:

(RunLoop::RunLoop): Initialize the nesting level to 0.
(RunLoop::run): Bump the nesting level, and only use -[NSApplication run] for the outermost invocation of the
runloop. We also switch from -[NSRunloop run] to CFRunLoopRun as the former will only exit when it has no sources
left to process, while CFRunLoopRun will return immediately after CFRunLoopStop is called on it.
(RunLoop::stop): Only go down the NSApp path for the outermost invocation of the runloop.

8:31 PM Changeset in webkit [94939] by ukai@chromium.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for chromium/mac & clang.

Fix the macro redefinition error by r94927, because chromium set
ENABLE_JSC_MULTIPLE_THREADS=0 in WebKit/chromium/features.gypi and
it is not PLATFORM(QT).

../../JavaScriptCore/wtf/Platform.h:512:9: error: 'ENABLE_JSC_MULTIPLE_THREADS' macro redefined [-Werror]
#define ENABLE_JSC_MULTIPLE_THREADS 1
<command line>:43:9: note: previous definition is here
#define ENABLE_JSC_MULTIPLE_THREADS 0
1 error generated.

wtf/Platform.h:

8:25 PM Changeset in webkit [94938] by Dimitri Glazkov

4 edits
2 adds in trunk

REGRESSION (r87351): toggling display of lots (thousands) of elements with display:none is very slow
https://bugs.webkit.org/show_bug.cgi?id=67581

Reviewed by Darin Adler.

Source/WebCore:

Test: perf/show-hide-table-rows.html

dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererAndStyle): Moved style-creating code into createRendererIfNeeded, renamed

to createRenderer.

(WebCore::NodeRendererFactory::createRendererIfNeeded): Re-arrange code to avoid unnecessary creation of renderers.

LayoutTests:

perf/show-hide-table-rows-expected.txt: Added.
perf/show-hide-table-rows.html: Added.

8:21 PM Changeset in webkit [94937] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Qt layer should be hardened against C API versioning in the sense of build failures
https://bugs.webkit.org/show_bug.cgi?id=67094

Reviewed by Andreas Kling.

UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

8:14 PM Changeset in webkit [94936] by jeremy@chromium.org

7 edits in trunk/Source

[Chromium] Change OOP Font loading code to use CGFont*() APIs.
https://bugs.webkit.org/show_bug.cgi?id=66935

This change is necessary due a bug in ATSFontDeactivate() on 10.7.
See crbug.com/93191 for details.

Reviewed by Eric Seidel.

Source/WebCore:

No new tests - covered by existing tests.

platform/chromium/PlatformBridge.h:
platform/graphics/chromium/CrossProcessFontLoading.h:
platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::MemoryActivatedFont::create):
(WebCore::MemoryActivatedFont::MemoryActivatedFont):
(WebCore::MemoryActivatedFont::~MemoryActivatedFont):

Source/WebKit/chromium:

public/mac/WebSandboxSupport.h:
src/PlatformBridge.cpp:

(WebCore::PlatformBridge::loadFont):

7:22 PM Changeset in webkit [94935] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Add more key codes to WebInputEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=67887

Reviewed by Darin Fisher.

src/WebInputEvent.cpp:

(WebKit::staticKeyIdentifiers):

7:19 PM Changeset in webkit [94934] by ukai@chromium.org

2 edits
1 delete in trunk/LayoutTests

Unreviewed, one more rebaseline for r94912

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:

6:52 PM Changeset in webkit [94933] by ukai@chromium.org

4 edits
2 deletes in trunk/LayoutTests

Unreviewed, update chromium test expectations and rebaselines for r94912

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium/test_expectations.txt:

3:41 PM Changeset in webkit [94932] by weinig@apple.com

3 edits in trunk/Source/JavaScriptCore

Remove JSCell::isPropertyNameIterator(), it is unused
https://bugs.webkit.org/show_bug.cgi?id=67911

Reviewed by Oliver Hunt.

runtime/JSCell.h:
runtime/JSPropertyNameIterator.h:

3:29 PM Changeset in webkit [94931] by weinig@apple.com

5 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::isAPIValueWrapper
https://bugs.webkit.org/show_bug.cgi?id=67909

Reviewed by Oliver Hunt.

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):
Set the correct type on structure creation.

runtime/JSCell.h:

Remove virtual keyword and default implementation.

runtime/JSType.h:

Add type for APIValueWrapper. It must come after CompoundType since
the APIValueWrapper has children in need of marking.

runtime/Structure.h:

(JSC::JSCell::isAPIValueWrapper):
Implement predicate using type info.

2:45 PM Changeset in webkit [94930] by weinig@apple.com

8 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::isGetterSetter, type information is available for it
https://bugs.webkit.org/show_bug.cgi?id=67902

Reviewed by Dan Bernstein.

runtime/GetterSetter.cpp:
runtime/GetterSetter.h:

Remove override of isGetterSetter.

runtime/JSCell.cpp:
runtime/JSCell.h:

De-virtualize and remove silly base implementation.

runtime/Structure.h:

(JSC::JSCell::isGetterSetter):
Use type info to determine getter-setter-hood.

2:11 PM Changeset in webkit [94929] by oliver@apple.com

110 edits in trunk/Source

Remove support for anonymous storage from jsobjects
https://bugs.webkit.org/show_bug.cgi?id=67881

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Remove all use of anonymous slots, essentially a mechanical change
in JavaScriptCore

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::createStructure):

API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::createStructure):

API/JSCallbackObject.h:

(JSC::JSCallbackObject::createStructure):

JavaScriptCore.exp:
debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::createStructure):

heap/MarkStack.cpp:

(JSC::MarkStack::validateValue):

heap/MarkStack.h:
runtime/Arguments.h:

(JSC::Arguments::createStructure):

runtime/ArrayConstructor.h:

(JSC::ArrayConstructor::createStructure):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::createStructure):

runtime/BooleanObject.h:

(JSC::BooleanObject::createStructure):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

runtime/BooleanPrototype.h:

(JSC::BooleanPrototype::createStructure):

runtime/DateConstructor.h:

(JSC::DateConstructor::createStructure):

runtime/DateInstance.h:

(JSC::DateInstance::createStructure):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

runtime/DatePrototype.h:

(JSC::DatePrototype::createStructure):

runtime/ErrorInstance.h:

(JSC::ErrorInstance::createStructure):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::createStructure):

runtime/ExceptionHelpers.h:

(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::createStructure):

runtime/Executable.h:

(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):

runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::createStructure):

runtime/GetterSetter.h:

(JSC::GetterSetter::createStructure):

runtime/InternalFunction.h:

(JSC::InternalFunction::createStructure):

runtime/JSAPIValueWrapper.h:

(JSC::JSAPIValueWrapper::createStructure):

runtime/JSActivation.h:

(JSC::JSActivation::createStructure):

runtime/JSArray.h:

(JSC::JSArray::createStructure):

runtime/JSByteArray.cpp:

(JSC::JSByteArray::createStructure):

runtime/JSCell.h:
runtime/JSFunction.h:

(JSC::JSFunction::createStructure):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::createStructure):

runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::createStructure):

runtime/JSONObject.h:

(JSC::JSONObject::createStructure):

runtime/JSObject.h:

(JSC::JSObject::createStructure):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSFinalObject::createStructure):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::createStructure):

runtime/JSString.h:

(JSC::RopeBuilder::createStructure):

runtime/JSVariableObject.h:

(JSC::JSVariableObject::createStructure):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::createStructure):

runtime/MathObject.h:

(JSC::MathObject::createStructure):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::createStructure):

runtime/NumberConstructor.h:

(JSC::NumberConstructor::createStructure):

runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

runtime/ObjectConstructor.h:

(JSC::ObjectConstructor::createStructure):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::createStructure):

runtime/RegExp.h:

(JSC::RegExp::createStructure):

runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::createStructure):

runtime/RegExpObject.h:

(JSC::RegExpObject::createStructure):

runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::createStructure):

runtime/ScopeChain.h:

(JSC::ScopeChainNode::createStructure):

runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::createStructure):

runtime/StringConstructor.h:

(JSC::StringConstructor::createStructure):

runtime/StringObject.h:

(JSC::StringObject::createStructure):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:

(JSC::StringPrototype::createStructure):

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):

runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):

runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

Source/JavaScriptGlue:

Don't need an anonymous slot count anymore

UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

Remove all use of anonymous slots, this required modifying
bindings generation to add member variables for cached attributes,
and override visitChildren with the necessary logic to mark those
new members.

I added bindings generation tests for these values.

bindings/js/JSAudioConstructor.h:

(WebCore::JSAudioConstructor::createStructure):

bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::createStructure):

bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::createStructure):

bindings/js/JSDOMWindowBase.h:

(WebCore::JSDOMWindowBase::createStructure):

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::createStructure):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::createStructure):

bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::createStructure):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::JSMessageEvent::initMessageEvent):

bindings/js/JSOptionConstructor.h:

(WebCore::JSOptionConstructor::createStructure):

bindings/js/JSWorkerContextBase.h:

(WebCore::JSWorkerContextBase::createStructure):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::createStructure):
(WebCore::JSTestInterfacePrototype::createStructure):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::createStructure):
(WebCore::JSTestMediaQueryListListenerPrototype::createStructure):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::createStructure):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::createStructure):
(WebCore::JSTestObjPrototype::createStructure):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::createStructure):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::createStructure):

bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::createStructure):

bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::createStructure):

bridge/jni/jsc/JavaRuntimeObject.h:

(JSC::Bindings::JavaRuntimeObject::createStructure):

bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::createStructure):

bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::createStructure):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::createStructure):

bridge/runtime_array.h:

(JSC::RuntimeArray::createStructure):

bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::createStructure):

Source/WebKit/mac:

Remove the use of AnonymousSlotCount

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::createStructure):

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

Source/WebKit2:

Remove the use of AnonymousSlotCount.

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

1:49 PM Changeset in webkit [94928] by mitz@apple.com

4 edits in trunk/Source/WebCore/svg

Removed the svn:executable property from some source files

11:34 AM Changeset in webkit [94927] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[Qt] Win32 build broken due to MachineStackMarker.cpp/.o failing to link against pthreads library
https://bugs.webkit.org/show_bug.cgi?id=67864

Qt Win32 is not pthread compatible and cannot participate in multithreaded JSC or it fails to build.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-11
Reviewed by Csaba Osztrogonác.

wtf/Platform.h:

10:21 AM Changeset in webkit [94926] by Martin Robinson

3 edits
2 deletes in trunk/LayoutTests

Remove two platform-specific results for GTK+ that no longer apply and
rebaseline one more test.

platform/gtk/fast/multicol/inherit-column-values-expected.txt: Removed.
platform/gtk/fast/multicol/initial-column-values-expected.txt: Removed.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Rebaselined.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Ditto.

9:56 AM Changeset in webkit [94925] by Martin Robinson

2 edits in trunk/LayoutTests

Unskip two tests that should be passing now that 67383 is resolved.

platform/gtk/Skipped: Unskip passing tests.

12:27 AM Changeset in webkit [94924] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening. Paint the Qt-Mac bot green.

platform/qt-mac/Skipped: Skip new failing tests.

12:13 AM Changeset in webkit [94923] by fpizlo@apple.com

2 edits in trunk/Tools

Added my IRC nick to the committers file.

Scripts/webkitpy/common/config/committers.py:

12:08 AM Changeset in webkit [94922] by Csaba Osztrogonác

5 edits in trunk/Source/JavaScriptCore

ARM and MIPS assemblers still refer to executable pools.
https://bugs.webkit.org/show_bug.cgi?id=67903

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-11
Reviewed by Csaba Osztrogonác.

assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

assembler/ARMAssembler.h:
assembler/AssemblerBufferWithConstantPool.h:
assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::executableCopy):

12:06 AM Changeset in webkit [94921] by Csaba Osztrogonác

1 edit
16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results for new passing tests.

platform/qt/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/qt/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-expected.png: Added.
platform/qt/fast/borders/border-image-outset-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/qt/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-split-inline-expected.png: Added.
platform/qt/fast/borders/border-image-outset-split-inline-expected.txt: Added.
platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
platform/qt/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
platform/qt/fast/reflections/reflection-masks-outset-expected.png: Added.
platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Added.

Sep 10, 2011:

10:49 PM Changeset in webkit [94920] by fpizlo@apple.com

41 edits
8 adds in trunk

The executable allocator makes it difficult to free individual
chunks of executable memory
https://bugs.webkit.org/show_bug.cgi?id=66363

Reviewed by Oliver Hunt.

Introduced a best-fit, balanced-tree based allocator. The allocator
required a balanced tree that does not allocate memory and that
permits the removal of individual nodes directly (as opposed to by
key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
Changed all references to executable code to use a reference counted
handle.

Source/JavaScriptCore:

GNUmakefile.list.am:
JavaScriptCore.exp:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::executableCopy):

assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::finalizeCode):
(JSC::LinkBuffer::linkCode):

assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::createSelfManagedCodeRef):
(JSC::MacroAssemblerCodeRef::executableMemory):
(JSC::MacroAssemblerCodeRef::code):
(JSC::MacroAssemblerCodeRef::size):
(JSC::MacroAssemblerCodeRef::operator!):

assembler/X86Assembler.h:

(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):

bytecode/CodeBlock.h:
bytecode/Instruction.h:
bytecode/StructureStubInfo.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):

jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::dumpProfile):

jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compileCTINativeCall):

jit/JITCode.h:

(JSC::JITCode::operator !):
(JSC::JITCode::addressForCall):
(JSC::JITCode::offsetOf):
(JSC::JITCode::execute):
(JSC::JITCode::start):
(JSC::JITCode::size):
(JSC::JITCode::getExecutableMemory):
(JSC::JITCode::HostFunction):
(JSC::JITCode::JITCode):

jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

jit/JITPropertyAccess32_64.cpp:

jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

jit/JITStubs.h:
jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):

jit/ThunkGenerators.h:
runtime/Executable.h:

(JSC::NativeExecutable::create):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::dumpSampleData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

wtf/CMakeLists.txt:
wtf/MetaAllocator.cpp: Added.

(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::shrink):
(WTF::MetaAllocator::MetaAllocator):
(WTF::MetaAllocator::allocate):
(WTF::MetaAllocator::currentStatistics):
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpaceFromReleasedHandle):
(WTF::MetaAllocator::addFreshFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::incrementPageOccupancy):
(WTF::MetaAllocator::decrementPageOccupancy):
(WTF::MetaAllocator::roundUp):
(WTF::MetaAllocator::allocFreeSpaceNode):
(WTF::MetaAllocator::freeFreeSpaceNode):
(WTF::MetaAllocator::dumpProfile):

wtf/MetaAllocator.h: Added.

(WTF::MetaAllocator::bytesAllocated):
(WTF::MetaAllocator::bytesReserved):
(WTF::MetaAllocator::bytesCommitted):
(WTF::MetaAllocator::dumpProfile):
(WTF::MetaAllocator::~MetaAllocator):

wtf/MetaAllocatorHandle.h: Added.
wtf/RedBlackTree.h: Added.

(WTF::RedBlackTree::Node::Node):
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::reset):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::Node::color):
(WTF::RedBlackTree::Node::setColor):
(WTF::RedBlackTree::RedBlackTree):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::isEmpty):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):

wtf/wtf.pri:
yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

yarr/YarrJIT.h:

(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::getAddr):

Source/JavaScriptGlue:

ForwardingHeaders/wtf/MetaAllocatorHandle.h: Added.

Source/WebCore:

No new layout tests because behavior is not changed. New API unit
tests:
Tests/WTF/RedBlackTree.cpp
Tests/WTF/MetaAllocator.cpp

ForwardingHeaders/wtf/MetaAllocatorHandle.h: Added.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.

(TestWebKitAPI::Pair::findExact):
(TestWebKitAPI::Pair::remove):
(TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
(TestWebKitAPI::Pair::assertFoundAndRemove):
(TestWebKitAPI::Pair::assertEqual):
(TestWebKitAPI::Pair::assertSameValuesForKey):
(TestWebKitAPI::Pair::testDriver):
(TestWebKitAPI::TEST_F):

10:24 PM Changeset in webkit [94919] by weinig@apple.com

4 edits in trunk/Source/JavaScriptCore

Remove JSC::isZombie() function, it did nothing and was called by no-one.
https://bugs.webkit.org/show_bug.cgi?id=67901

Reviewed by Andy Estes.

JavaScriptCore.exp:
runtime/JSCell.cpp:
runtime/JSValue.h:

10:16 PM Changeset in webkit [94918] by weinig@apple.com

10 edits in trunk/Source

Add isInterruptedExecutionException and isTerminatedExecutionException predicates
https://bugs.webkit.org/show_bug.cgi?id=67892

Reviewed by Andy "First Time Reviewer" Estes.

../JavaScriptCore:

JavaScriptCore.exp:

Add symbols.

interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
Use new predicates.

runtime/ExceptionHelpers.cpp:

(JSC::createInterruptedExecutionException):
(JSC::isInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::isTerminatedExecutionException):

runtime/ExceptionHelpers.h:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
Add predicates.

../WebCore:

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
Use the new predicates instead of probing the ClassInfo directly.

10:16 PM Changeset in webkit [94917] by aestes@apple.com

2 edits in trunk/Tools

Move myself from committers_unable_to_review to reviewers_list.

Scripts/webkitpy/common/config/committers.py:

5:52 PM Changeset in webkit [94916] by kevino@webkit.org

5 edits in trunk

[wx] Unreviewed build fix. MSW build fixes.

5:17 PM Changeset in webkit [94915] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip fast/images/support-broken-image-delegate.html temporarily on Mac.
The failure is tracked by the bug 67898.

platform/mac/Skipped:

2:23 PM Changeset in webkit [94914] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

DFG JIT completely undoes speculative compilation even in the case of
a partial static speculation failure
https://bugs.webkit.org/show_bug.cgi?id=67798

Reviewed by Geoffrey Garen.

This is a regression with static speculation, so it is turned off by
default. But it is a necessary prerequisite for further work on
dynamic speculation.

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::clearGenerationInfo):

dfg/DFGJITCodeGenerator.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

2:14 PM Changeset in webkit [94913] by hyatt@apple.com

1 delete in trunk/LayoutTests/fast/borders/block-mask-overlay-image.html~

Remove emacs backup file that got committed by mistake.

2:08 PM Changeset in webkit [94912] by hyatt@apple.com

30 edits
25 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=67861

Implement border-image-outset (and the mask equivalents).

Reviewed by Beth Dakin.

Source/WebCore:

Added new tests in fast/borders and fast/reflections.

css/CSSBorderImageValue.cpp:

(WebCore::CSSBorderImageValue::CSSBorderImageValue):
(WebCore::CSSBorderImageValue::cssText):

css/CSSBorderImageValue.h:

(WebCore::CSSBorderImageValue::create):
Add m_outset field to CSSBorderImageValue and teach it how to dump the field as
part of cssText().

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImage):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Add support for border-image-outset and -webkit-mask-box-image-outset. Refactor
the code so that border-image-width and border-image-outset use a common
function.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowOutset):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::BorderImageParseContext::commitBorderImage):
(WebCore::CSSParser::parseBorderImage):
Teach the border image parsing code about outsets. This code will soon be
replaced by true shorthand parsing code, but for now keep it working and add
outset support to it.

(WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderImageWidth):
(WebCore::CSSParser::parseBorderImageOutset):

css/CSSParser.h:

Refactor the border-image-width code so that it can be shared by border-image-outset, since
they are extremely similar.

css/CSSPropertyNames.in:

Add the new properties.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::mapNinePieceImageQuad):
(WebCore::CSSStyleSelector::loadPendingImages):

css/CSSStyleSelector.h:

Refactor the code so that width/outset share common mapping functions. Add support for outset.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
Add new functions for computing the visual overflow caused by border outsets. Fix bugs in
the shadow overflow code as well.

(WebCore::clipRectForNinePieceImageStrip):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

rendering/InlineFlowBox.h:

Make sure the clip rect pushed when painting one piece of a split inline strip is expanded to
include the border and mask outsets. Always include the block direction expansion, and conditionally
include the inline direction expansion based off includeLogicalLeftEdge()/includeLogicalRightEdge().
clipRectForNinePieceImageStrip is a common function shared by masks and border images that does this
work.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

rendering/RenderBox.cpp:

(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::addBoxShadowAndBorderOverflow):

rendering/RenderBox.h:

Rename addShadowOverflow to addBoxShadowAndBorderOverflow. Have it compute both shadow and border image
outset overflow. Fix bugs with shadow overflow computation.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):
Change painting to apply the outsets to inflate the border image drawing area.

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::layout):
Patched to call the renamed addBoxShadowAndBorderOverflow function instead of addShadowOverflow.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateRects):
Patched to no longer apply box-shadow to overflow clip areas when inflating the intersection area for the
layer bounds. Instead we generically apply all visual overflow so that border image outsets will also be
included. This fixes https://bugs.webkit.org/show_bug.cgi?id=37467.

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):
Patched to call the renamed addBoxShadowAndBorderOverflow function instead of addShadowOverflow.

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::operator==):

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):
(WebCore::NinePieceImage::copyOutsetFrom):
Add the outset field to NinePieceImage along with some helpers for manipulating outsets.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getImageOutsets):
(WebCore::RenderStyle::getImageHorizontalOutsets):
(WebCore::RenderStyle::getImageVerticalOutsets):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasBorderImageOutsets):
(WebCore::InheritedFlags::getBorderImageOutsets):
(WebCore::InheritedFlags::getBorderImageHorizontalOutsets):
(WebCore::InheritedFlags::getBorderImageVerticalOutsets):
(WebCore::InheritedFlags::getBorderImageInlineDirectionOutsets):
(WebCore::InheritedFlags::getBorderImageBlockDirectionOutsets):
(WebCore::InheritedFlags::getImageInlineDirectionOutsets):
(WebCore::InheritedFlags::getImageBlockDirectionOutsets):
Helpers for outset computation used by painting and overflow functions.

LayoutTests:

fast/borders/block-mask-overlay-image-outset.html: Added.
fast/borders/block-mask-overlay-image.html~: Added.
fast/borders/border-image-outset-in-shorthand.html: Added.
fast/borders/border-image-outset-split-inline-vertical-lr.html: Added.
fast/borders/border-image-outset-split-inline.html: Added.
fast/borders/border-image-outset.html: Added.
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html: Added.
fast/borders/inline-mask-overlay-image-outset.html: Added.
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
fast/reflections/reflection-computed-style-expected.txt:
fast/reflections/reflection-masks-outset.html: Added.
platform/mac/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/mac/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
platform/mac/fast/borders/border-image-outset-expected.png: Added.
platform/mac/fast/borders/border-image-outset-expected.txt: Added.
platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
platform/mac/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
platform/mac/fast/borders/border-image-outset-split-inline-expected.png: Added.
platform/mac/fast/borders/border-image-outset-split-inline-expected.txt: Added.
platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Added.
platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
platform/mac/fast/reflections/reflection-masks-outset-expected.png: Added.
platform/mac/fast/reflections/reflection-masks-outset-expected.txt: Added.
svg/css/getComputedStyle-basic-expected.txt:

12:17 PM Changeset in webkit [94911] by mitz@apple.com

2 edits in trunk/Source/WebCore

Actually prevent unnecessary casts to MediaControls*.

Reviewed by Oliver Hunt.

html/shadow/MediaControls.h:

11:54 AM Changeset in webkit [94910] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove printf added by r94900.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

10:52 AM Changeset in webkit [94909] by commit-queue@webkit.org

2 edits in trunk/Tools

Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=59328

Patch by Andreas Kling <kling@webkit.org> on 2011-09-10
Reviewed by Kenneth Rohde Christiansen.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.

7:21 AM Changeset in webkit [94908] by cmarrin@apple.com

20 edits in trunk/Source

requestAnimationFrame doesn't throttle on Mac
https://bugs.webkit.org/show_bug.cgi?id=67171

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Added WTF_USE_REQUEST_ANIMATION_FRAME_TIMER to allow any platform to run
requestAnimationFrame callbacks on a Timer defined in ScriptedAnimationController.
Currently only enabled for PLATFORM(MAC)

wtf/Platform.h:

Source/WebCore:

Changed requestAnimationFrame to use a Timer in ScriptedAnimationController
on Mac, rather than runLoopObservers. The Timer is throttled to fire no
faster than every 15ms. It is behind a WTF_USE_REQUEST_ANIMATION_FRAME_TIMER
flag and can be used by any implementation, but currently it is only enabled
by PLATFORM(MAC).

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::resume):
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):

dom/ScriptedAnimationController.h:
loader/EmptyClients.h:
page/Chrome.cpp:

(WebCore::Chrome::scheduleAnimation):

page/ChromeClient.h:

Source/WebKit/mac:

Removed runLoopObserver for requestAnimationFrame. It's now
done by a Timer in ScriptedAnimationController in WebCore.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:
WebView/WebView.mm:

(-[WebView _close]):

WebView/WebViewData.h:
WebView/WebViewInternal.h:

Source/WebKit2:

Removed runLoopObserver for requestAnimationFrame. It's now
done by a Timer in ScriptedAnimationController in WebCore.

WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

7:06 AM Changeset in webkit [94907] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r94897.

platform/qt/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/qt/svg/custom/simple-text-double-shadow-expected.txt: Added.

6:15 AM Changeset in webkit [94906] by commit-queue@webkit.org

4 edits
1 add in trunk/Source

Source/WebCore: [Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows paths that contain drive letters
https://bugs.webkit.org/show_bug.cgi?id=34884

KURL::path() alone does not handle removing the leading slash from a windows file path.
Using QUrl::toLocalFile() will turn file:///C:/path into C:/path appropriately.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-10
Reviewed by Andreas Kling.

platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath):

Source/WebKit/qt: [Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows paths that contain drive letters
https://bugs.webkit.org/show_bug.cgi?id=34884

KURL::path() alone does not handle removing the leading slash from a windows file path.
Using QUrl::toLocalFile() will turn file:///C:/path into C:/path appropriately.

New test case that ensures a user stylesheet from the file system will load correctly
on all platforms.

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-10
Reviewed by Andreas Kling.

tests/qwebpage/resources/user.css: Added.

(p):

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::userStyleSheetFromFile):

4:25 AM Changeset in webkit [94905] by commit-queue@webkit.org

8 edits
3 adds in trunk

Source/WebCore: Crash due to bad data in SVGDocumentExtensions m_pendingResources
https://bugs.webkit.org/show_bug.cgi?id=67488

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-09-10
Reviewed by Nikolas Zimmermann.

Resolving a crash condition caused by the deletion of
elements while pending resource entries for those elements are still
recorded.

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource)

svg/SVGDocumentExtensions.h:

(WebCore::SVGDocumentExtensions::isElementInPendingResources)

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource)
(WebCore::SVGDocumentExtensions::isElementInPendingResources)
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources)

svg/SVGStyledElement.h:

(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible)

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded)
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible)

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged)

LayoutTests: Crash due to bad data in SVGDocumentExtensions m_pendingResources.
https://bugs.webkit.org/show_bug.cgi?id=67488

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-09-10
Reviewed by Nikolas Zimmermann.

Test added: validating that the crash referenced in the bug is not present.

svg/dom/SVGStyledElement-pendingResource-crash.html: Added.
svg/dom/SVGStyledElement-pendingResource-crash-expected.txt: Added.
svg/dom/resources/SVGStyledElement-pendingResource-crash.svg: Added.

1:33 AM Changeset in webkit [94904] by abarth@webkit.org

2 edits in trunk/Tools

Build fix for Android. DumpRenderTree is a client of the WebKit API
and does not have access to notImplemented().

DumpRenderTree/chromium/TestShellAndroid.cpp:

(openStartupDialog):

12:56 AM Changeset in webkit [94903] by abarth@webkit.org

2 edits in trunk/Source/WebKit/gtk

Fix build break.

webkit/webkitwebview.cpp:

(webkit_web_view_get_encoding):

12:54 AM Changeset in webkit [94902] by abarth@webkit.org

6 edits in trunk/Source/WebCore

Remove DocumentWriter::deprecatedFrameEncoding()
https://bugs.webkit.org/show_bug.cgi?id=67882

Reviewed by Eric Seidel.

Three years ago, in http://trac.webkit.org/changeset/39026, Alexey
Proskuryakov added ContentDispositionEncodingFallbackArray to work
around a web site compatibility issue with a non-ASCII file name
becoming garbled when received in the Content-Disposition header.

Since that time, there has been copious discussion of this topic among
browser vendors, in the IETF, and in the broader web community. For
example, here is a Stack Overflow thread about this topic:

http://stackoverflow.com/questions/93551/how-to-encode-the-filename-parameter-of-content-disposition-header-in-http

Eric Lawrence has written a blog post that summarizes IE's perspective
on this issue:

http://blogs.msdn.com/b/ieinternals/archive/2010/06/07/content-disposition-attachment-and-international-unicode-characters.aspx

The current consensus is that browsers should implement RFC 6266,
which is a new RFC that updates the definition of the
Content-Disposition header. Chrome and Firefox have both implemented
RFC 6266 and have encountered only one issue, which was then fixed by
the web site operator. IE has also implemented RFC 6266, but I don't
have detailed information about their compatibility experience.

This patch add explicit PLATFORM #ifdefs around the quirky
implementation previously used in Apple's Mac and Windows ports. This
code is already only used on Apple's ports, so this patch introduces no
functional changes. It does, however, discourage other ports from
adopting this quirk. IMHO, Apple should remove this quirk as soon as
compatibility allows and converge behavior with the other major browser
vendors.

See bug for manual test (the bug manifests in Safari download UI).

loader/DocumentWriter.cpp:
loader/DocumentWriter.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):

platform/network/ResourceRequestBase.h:

Sep 9, 2011:

11:47 PM Changeset in webkit [94901] by Beth Dakin

3 edits in trunk/Source/WebCore

Attempted Leopard build fix.

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

11:28 PM Changeset in webkit [94900] by Beth Dakin

11 edits
5 adds in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=67819
Use high resolution platform images when the deviceScaleFactor > 1
-and corresponding-
<rdar://problem/10003098>

Reviewed by Darin Adler.

Add all of the new high resolution images. I also removed some tiffs from the
project and replaced them with png equivalents (that are already checked into
WebCore anyway). Since the high resolution images are pngs, it makes sense to use
pngs for all of the images that load through Image::loadPlatformResource()

WebCore.xcodeproj/project.pbxproj:
platform/graphics/mac/ImageMac.mm:

(WebCore::Image::loadPlatformResource):

Load the @2x resource for deviceScaleFactors >= 2.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

CachedImage::brokenImage() is no longer a static helper function, but a real
member function. It also now loads the @2x resource for deviceScaleFactors >= 2
and takes a parameter for the deviceScaleFactor. When CachedImage::image() returns
the brokenImage(), it just returns the 1x version. brokenImage() has to be called
directly to reliably return the deviceScaleFactor-appropriate resource.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):

loader/cache/CachedImage.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):
(WebCore::RenderLayer::paintResizer):

rendering/RenderLayer.h:

New static function to retrieve the deviceScaleFactor for callers that do not have
direct access to a Page.

page/Page.cpp:

(WebCore::Page::deviceScaleFactor):

page/Page.h:

Call CachedImage::brokenImage() for the broken-image image at an accurate
resolution.

rendering/RenderImage.cpp:

(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):

9:00 PM Changeset in webkit [94899] by ap@apple.com

1 edit
1 add in trunk/Tools

Add a script to create a monolithic script-test
https://bugs.webkit.org/show_bug.cgi?id=67747

Reviewed by Darin Adler.

Scripts/make-new-script-test: Added.

8:55 PM WebKit Team edited by luiz@webkit.org

(diff)

8:21 PM Changeset in webkit [94898] by arv@chromium.org

12 edits
1 move
4 adds
2 deletes in trunk

Move Element.contains to Node
https://bugs.webkit.org/show_bug.cgi?id=67651

Reviewed by Darin Adler.

This moves the contains method from Element to Node as in the DOM4 working draft:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains

This also special cases Document contains to make it O(1) instead of O(depth).

Source/WebCore:

Tests: fast/dom/Node/contains-method.html

perf/document-contains.html

bindings/objc/PublicDOMInterfaces.h: Move contains from DOMElement to DOMNode.
dom/Element.idl:
dom/Node.cpp:

(WebCore::Node::contains): Added document special case.

dom/Node.idl:
editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): Added a null check.

LayoutTests:

fast/dom/Element/contains-method-expected.txt: Removed.
fast/dom/Element/script-tests/contains-method.js: Removed.
fast/dom/Node/contains-method-expected.txt: Added.
fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html.
fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests.
fast/dom/Window/window-properties-expected.txt:
perf/document-contains-expected.txt: Added.
perf/document-contains.html: Added.

Perf test to ensure that document.contains is O(1).

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:

7:56 PM Changeset in webkit [94897] by timothy_horton@apple.com

22 edits
3 adds in trunk

Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Darin Adler.

Source/WebCore:

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::isInTransparencyLayer):

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::isInTransparencyLayer):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::getWindowsContext):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/win/ScrollbarThemeWin.cpp:
plugins/win/PluginViewWin.cpp:
rendering/RenderThemeWin.cpp:

LayoutTests:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
svg/custom/simple-text-double-shadow.svg: Added.

7:49 PM Changeset in webkit [94896] by luiz@webkit.org

2 edits in trunk/Tools

Adding myself to the reviewers list.

Scripts/webkitpy/common/config/committers.py:

6:58 PM Changeset in webkit [94895] by mdelaney@apple.com

3 edits in trunk/LayoutTests

Update Skipped lists for mac and mac-lion w.r.t. canvas
https://bugs.webkit.org/show_bug.cgi?id=67867

Reviewed by Simon Fraser.

platform/mac-lion/Skipped:
platform/mac/Skipped:

6:16 PM Changeset in webkit [94894] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

[V8] V8WebKitPoint::constructorCallback leaks
https://bugs.webkit.org/show_bug.cgi?id=67865

Reviewed by Adam Barth.

Covered by fast/js/instanceof-XMLHttpRequest.html under Valgrind.

bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback): Changed the code
to use a RefPtr (per our usual style). Also use toV8 that will
take care of properly wrapping the object.

5:59 PM Changeset in webkit [94893] by crogers@google.com

3 edits in trunk/Source/WebCore

HRTFDatabaseLoader should not call WTF::waitForThreadCompletion() more than once
https://bugs.webkit.org/show_bug.cgi?id=67866

Reviewed by David Levin.

No new tests since this is difficult to test.
This is designed to fix existing webaudio layout test failures.

platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loadAsynchronously):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

platform/audio/HRTFDatabaseLoader.h:

5:57 PM Changeset in webkit [94892] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Cookies are not available after turning off Private Browsing after the last window has been
closed.
https://bugs.webkit.org/show_bug.cgi?id=67874

Reviewed by Darin Adler.

The private browsing storage session is a global setting that is being incorrectly set on a
per-page basis (see http://webkit.org/b/67870).

In this case, the global value was getting out of sync with the per-page setting:

The global value was getting set to true when setPrivateBrowsingEnabled(true) was called.
All Pages were then closed, destroying their Settings objects.
When a new Page was created, a new Settings object was created and its m_privateBrowsingEnabled value was getting set to false.
The WebPage settings were then applied to the new Settings object, resulting in setPrivateBrowsingEnabled(false) to be called.
An if (m_privateBrowsingEnabled == privateBrowsingEnabled) early return prevented the global value for the storage session from being destroyed.

page/Settings.cpp:

(WebCore::Settings::setPrivateBrowsingEnabled):
Move the early return to be after setting the global private browsing values, and add a
clearer comment + FIXME.

5:29 PM Changeset in webkit [94891] by rolandsteiner@chromium.org

13 edits
1 delete in trunk

Generate a WebKitCSSMatrix constructor of V8 using the IDL 'Constructor' extended attribute
https://bugs.webkit.org/show_bug.cgi?id=67458

Patch by Kentaro Hara <haraken@google.com> on 2011-09-09
Reviewed by Adam Barth.

Source/WebCore:

Added a 'CallWithNullValue' extended attribute.
If a parameter is optional and missing, 'CallWithDefaultValue'
handles it as a string "undefined". On the other hand,
'CallWithNullValue' handles it as a null string
(Note: not a string "null", but a null string).

Tests: fast/dom/Window/custom-constructors.html

transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtmlGenerate a WebKitCSSMatrix constructor

WebCore.gypi: Removed V8WebKitCSSMatrixConstructor.cpp.
WebCore.pro: Removed V8WebKitCSSMatrixConstructor.cpp.
bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck): If the 'CallWithNullValue' extended attribute is set, we call MAYBE_MISSING_PARAMETER() with MissingIsEmpty mode to obtain a maybe missing parameter. Otherwise, we call MAYBE_MISSING_PARAMETER() with MissingIsUndefined mode.
(RequiresCustomSignature):

bindings/scripts/test/V8/V8TestInterface.cpp: Updated test results.

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.

(WebCore::TestMediaQueryListListenerInternal::methodCallback):

bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):

bindings/v8/V8Binding.h:

(WebCore::V8ParameterBase::prepareBase): The fact that V8ParameterBase does not have any object means that we do not need to prepare anything, i.e. we should just return true in this case.
(WebCore::::prepare): If V8ParameterBase does not have any object, then we set a null string.

bindings/v8/custom/V8BindingMacros.h: MAYBE_MISSING_PARAMETER() returns the parameter of a given index if the parameter exists. If the parameter does not exist and MissingIsUndefined is set, this macro returns an object that represents undefined. If the parameter does not exist and MissingIsEmpty is set, this macro returns an empty object.
bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Removed.
css/WebKitCSSMatrix.idl: Added the 'Constructor' extended attribute.

LayoutTests:

Added a test case for "new WebKitCSSMatrix(null)" and "new WebKitCSSMatrix(undefined)".

fast/dom/Window/custom-constructors-expected.txt:
fast/dom/Window/custom-constructors.html:

5:05 PM Changeset in webkit [94890] by ggaren@apple.com

12 edits in trunk/Source

2011-09-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Removed ENABLE(SINGLE_THREADED) support, since it is always false
https://bugs.webkit.org/show_bug.cgi?id=67862

Next step toward making the baseline platform assumption that threads exist.

wtf/wtf.pri:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/WTF/WTF.vcproj: Removed references to ThreadingNone.cpp, which was only compiled in single-threaded mode.

wtf/Platform.h:
wtf/ThreadSpecific.h: (WTF::::destroy):
wtf/qt/ThreadingQt.cpp: Removed now-dead code.

wtf/ThreadingNone.cpp: Removed.

2011-09-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Removed ENABLE(SINGLE_THREADED) support, since it is always false
https://bugs.webkit.org/show_bug.cgi?id=67862

Next step toward making the baseline platform assumption that threads exist.

WebCore.pri:
features.pri:
platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::interrupt): Removed now-dead code.

4:39 PM Changeset in webkit [94889] by fsamuel@chromium.org

23 edits in trunk/Source

Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
https://bugs.webkit.org/show_bug.cgi?id=67250

Reviewed by Simon Fraser.

Source/WebCore:

No new tests because there's no change in functionality.

WebCore.exp.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

dom/Range.cpp:

(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):

loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::pageScaleFactor):

page/Frame.h:
page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setPageScaleFactor):

page/Page.h:

(WebCore::Page::pageScaleFactor):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::pageScaleFactor):

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageScaleFactor):
(WebKit::WebViewImpl::scalePage):

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::scalePageBy):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _scaleWebView:atOrigin:]):
(-[WebView _viewScaleFactor]):

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::scalePageBy):

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scalePage):
(WebKit::WebPage::pageScaleFactor):

4:24 PM Changeset in webkit [94888] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore: AX: Images within anchors causes crash
https://bugs.webkit.org/show_bug.cgi?id=44149

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

Fixes the way parent RenderObject of an AccessibilityRenderObject
is computed in the presence of adjacent continuations.

Test: accessibility/div-within-anchors-causes-crash.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add a test to catch a case where an assertion failure or
crash is triggered in AccessibilityRenderObject when deleting
a node that includes a continuation.
https://bugs.webkit.org/show_bug.cgi?id=44149

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

accessibility/div-within-anchors-causes-crash.html: Added.
platform/mac/accessibility/div-within-anchors-causes-crash-expected.txt: Added.

4:22 PM Changeset in webkit [94887] by commit-queue@webkit.org

7 edits
2 adds in trunk

CSS rules not being applied when a hidden field is inserted between an input[type=checkbox] and a label
https://bugs.webkit.org/show_bug.cgi?id=66887

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-09-09
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/adjacent-sibling-selector.html

This patch addresses the problem of elements not getting their style recomputed
when they are affected by direct adjacent sibling rules and one of their sibling in
their corresponding rules is modified dynamically.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::affectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setAffectedByDirectAdjacentRules):

LayoutTests:

fast/css/adjacent-sibling-selector-expected.txt: Added.
fast/css/adjacent-sibling-selector.html: Added.

4:14 PM Changeset in webkit [94886] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Make the EFL port use the correct rendering file.
https://bugs.webkit.org/show_bug.cgi?id=66323

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-09-09
Reviewed by Martin Robinson.

When compiling with Pango support, the EFL port should use
FontPango.cpp instead of FontEfl.cpp (which is just full of stubs).

No new functionality so no new tests.

CMakeListsEfl.txt:

4:10 PM Changeset in webkit [94885] by sullivan@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 94841 - Crashes in WebCore::AppendNodeCommand::create().
https://bugs.webkit.org/show_bug.cgi?id=67767

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Darin Adler.

Source/WebCore:

In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node.
The current code assumes lastNode is an Element node. This patch checks it.

Test: editing/execCommand/ident-crashes-topnode-is-text.html

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check.

LayoutTests:

Added a crash test case.

editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added.
editing/execCommand/ident-crashes-topnode-is-text.html: Added.

TBR=sullivan@chromium.org
BUG=95550
Review URL: http://codereview.chromium.org/7863014

4:05 PM Changeset in webkit [94884] by commit-queue@webkit.org

2 edits
4 adds in trunk/LayoutTests

Add test cases for xss auditor encoding bugs.
https://bugs.webkit.org/show_bug.cgi?id=67134

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-09
Reviewed by Daniel Bates.

http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt: Added.
http/tests/security/xssAuditor/xss-filter-bypass-big5.html: Added.
http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt: Added.
http/tests/security/xssAuditor/xss-filter-bypass-sjis.html: Added.

4:05 PM Changeset in webkit [94883] by isherman@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 94637 - REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
https://bugs.webkit.org/show_bug.cgi?id=67681

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.

Test: fast/forms/suggested-value-after-setvalue.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

LayoutTests:

Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.

fast/forms/suggested-value-after-setvalue-expected.txt: Added.
fast/forms/suggested-value-after-setvalue.html: Added.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/7768005

4:03 PM Changeset in webkit [94882] by isherman@chromium.org

11 edits
2 copies in branches/chromium/874

Merge 94586 - REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium
https://bugs.webkit.org/show_bug.cgi?id=67453

Reviewed by Kent Tamura.

Add symbols for internals.

Source/autotools/symbols.filter:

Source/WebCore:

Fixed the bug by updating inner text value in setSuggestedValue.

Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.

Test: fast/forms/suggested-value.html

WebCore.exp.in:
testing/Internals.cpp:

(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium:

Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.

src/WebNode.cpp:

(WebKit::WebNode::isFocusable):

Source/WebKit2:

Add symbols for internals.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.

fast/forms/suggested-value-expected.txt: Added.
fast/forms/suggested-value.html: Added.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/7796022

4:01 PM Changeset in webkit [94881] by sullivan@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 94840 - Crashes in WebCore::ApplyStyleCommand.doApply()
https://bugs.webkit.org/show_bug.cgi?id=67765

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Ryosuke Niwa.

WebCore::enclosingBlock may return null, but ApplyStyleCommand::applyBlockStyle did not check it. This patch make it to be checked.

Source/WebCore:

Test: editing/style/remove-format-without-enclosing-block.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): Added null check.

LayoutTests:

editing/style/remove-format-without-enclosing-block-expected.txt: Added.
editing/style/remove-format-without-enclosing-block.html: Added.

TBR=sullivan@chromium.org
BUG=95550
Review URL: http://codereview.chromium.org/7862013

3:51 PM Changeset in webkit [94880] by sullivan@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 94832 - Crashes in WebCore::InsertNodeBeforeCommand constructor.
https://bugs.webkit.org/show_bug.cgi?id=67763

Reviewed by Ryosuke Niwa.

Source/WebCore:

Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that
positions which are before or after a given node cannot return that node as the editable root.

Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html

editing/htmlediting.cpp:

(WebCore::editableRootForPosition): use containerNode instead of deprecatedNode.

LayoutTests:

Tests for crash when the selection is outside the contenteditable node.

editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added.
editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added.

TBR=sullivan@chromium.org
BUG=95550
Review URL: http://codereview.chromium.org/7866016

3:47 PM Changeset in webkit [94879] by sullivan@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 94793 - Crashes in WebCore::ReplaceSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=67762

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.

Tests: editing/inserting/insert-without-enclosing-block.html

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Added null check.

LayoutTests:

WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.

editing/inserting/insert-without-enclosing-block-expected.txt: Added.
editing/inserting/insert-without-enclosing-block.html: Added.

TBR=sullivan@chromium.org
Review URL: http://codereview.chromium.org/7780011

3:15 PM Changeset in webkit [94878] by crogers@google.com

7 edits
1 copy
2 adds in trunk

AudioBufferSourceNode must validate AudioBuffer in .buffer attribute setter
https://bugs.webkit.org/show_bug.cgi?id=67749

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/audiobuffersource-channels.html

WebCore.gypi:
bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::setBuffer):

bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp: Copied from Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp.

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

webaudio/AudioBufferSourceNode.h:
webaudio/AudioBufferSourceNode.idl:

LayoutTests:

webaudio/audiobuffersource-channels-expected.txt: Added.
webaudio/audiobuffersource-channels.html: Added.

3:08 PM Changeset in webkit [94877] by mitz@apple.com

3 edits in trunk/Source/WebCore

RenderBlock::addOverhangingFloats() takes superfluous parameters
https://bugs.webkit.org/show_bug.cgi?id=67863

Reviewed by Dave Hyatt.

No new tests, because behavior is unchanged.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::addOverhangingFloats): Removed the logical{Left, Top}Offset parameters,
since they were always the inverse of the logical{Left, Top}() of the child parameter.

rendering/RenderBlock.h:

3:06 PM Changeset in webkit [94876] by commit-queue@webkit.org

7 edits
2 adds in trunk

Add replacement functions for gdk ones.
https://bugs.webkit.org/show_bug.cgi?id=66323

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-09-09
Reviewed by Martin Robinson.

Source/cmake/FindPango.cmake:

Source/WebCore:

This will allow the EFL port to don't depend on gdk anymore.

No new functionality so no new tests.

CMakeListsEfl.txt:
platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::appendRegionToCairoContext):

platform/graphics/cairo/CairoUtilities.h:
platform/graphics/pango/FontPango.cpp:

(WebCore::drawGlyphsShadow):
(WebCore::Font::drawComplexText):

platform/graphics/pango/PangoUtilities.cpp: Added.

(WebCore::getLineClipRegionFromLayoutIter):
(WebCore::getClipRegionFromPangoLayoutLine):

platform/graphics/pango/PangoUtilities.h: Added.

2:43 PM Changeset in webkit [94875] by mhahnenberg@apple.com

114 edits in trunk/Source

Unzip initialization lists and constructors in JSCell hierarchy (5/7)
https://bugs.webkit.org/show_bug.cgi?id=67420

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the second level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one. Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::finishCreation):

API/JSCallbackFunction.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):
(JSC::::finishCreation):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:
debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):

jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject::GlobalObject):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):
(JSC::ArrayConstructor::finishCreation):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):
(JSC::BooleanConstructor::finishCreation):

runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

runtime/BooleanObject.h:

(JSC::BooleanObject::create):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):
(JSC::BooleanPrototype::finishCreation):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):
(JSC::DateConstructor::finishCreation):

runtime/DateConstructor.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h:

(JSC::DateInstance::create):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):
(JSC::DatePrototype::finishCreation):

runtime/DatePrototype.h:
runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):
(JSC::ErrorConstructor::finishCreation):

runtime/ErrorConstructor.h:
runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):
(JSC::FunctionConstructor::finishCreation):

runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::finishCreation):

runtime/FunctionPrototype.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

runtime/InternalFunction.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):

runtime/JSONObject.h:

(JSC::JSONObject::create):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSString.cpp:

(JSC::StringObject::create):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

runtime/MathObject.h:

(JSC::MathObject::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::finishCreation):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):
(JSC::NumberConstructor::finishCreation):

runtime/NumberConstructor.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

runtime/NumberObject.h:

(JSC::NumberObject::create):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):
(JSC::NumberPrototype::finishCreation):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):
(JSC::ObjectConstructor::finishCreation):

runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):
(JSC::RegExpMatchesArray::RegExpMatchesArray):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

runtime/RegExpObject.h:

(JSC::RegExpObject::create):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):
(JSC::StringConstructor::finishCreation):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

runtime/StringObject.h:

(JSC::StringObject::create):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):
(JSC::StringPrototype::finishCreation):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

No new tests.

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::create):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):

bridge/c/CRuntimeObject.h:
bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
(JSC::Bindings::JavaRuntimeObject::finishCreation):

bridge/jni/jsc/JavaRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

bridge/runtime_array.h:

(JSC::RuntimeArray::create):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):
(JSC::RuntimeMethod::finishCreation):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

Plugins/Hosted/ProxyRuntimeObject.h:
Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):

Source/WebKit2:

Completed the fifth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::finishCreation):

WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):

WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::create):

2:40 PM Changeset in webkit [94874] by commit-queue@webkit.org

2 edits
1 move in trunk/Source/WebCore

Rename FontGtk.cpp to FontPango.cpp
https://bugs.webkit.org/show_bug.cgi?id=66323

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-09-09
Reviewed by Martin Robinson.

This file will be used by the EFL port too, and since it's not GTK
specific anymore, rename it to something better.

No new functionality so no new tests.

GNUmakefile.list.am:
platform/graphics/pango/FontPango.cpp: Renamed from Source/WebCore/platform/graphics/gtk/FontGtk.cpp.

2:17 PM Changeset in webkit [94873] by rniwa@webkit.org

2 edits in trunk/LayoutTests

GTK rebaseline.

platform/gtk/css2.1/t090204-display-change-01-b-ao-expected.txt:

1:42 PM Changeset in webkit [94872] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-09-09 Geoffrey Garen <ggaren@apple.com>

Build fix: Guard against double-#define for something already #defined
by the build system.

wtf/Platform.h:

12:44 PM Changeset in webkit [94871] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-09-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or
!ENABLE_WTF_MULTIPLE_THREADS
https://bugs.webkit.org/show_bug.cgi?id=67860

First step toward making the baseline platform assumption that threads
exist: Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS,
or !ENABLE_WTF_MULTIPLE_THREADS.

wtf/Platform.h:

11:37 AM Changeset in webkit [94870] by levin@chromium.org

1 edit in branches/chromium/874/Source/WebCore/platform/KURLGoogle.cpp

Merge 94821 - [chromium] KURL::copy doesn't produce something usable on another thread.
https://bugs.webkit.org/show_bug.cgi?id=67809

Reviewed by Adam Barth.

No new functionality exposed so no new test. This was caught by testing code: the thread
sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708).

platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will
not be used on another thread.

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7867002

11:37 AM Changeset in webkit [94869] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Initialize ExceptionCode in Element::removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=67820

Reviewed by Darin Adler.

Silences valgrind warning reported in http://crbug.com/76490.

No new tests since this would only very occasionally be flaky,
and in the codepath in the valgrind report, the ec is ignored anyway.

dom/Element.cpp:

(WebCore::Element::removeAttribute): Initialize ec to 0.

11:21 AM Changeset in webkit [94868] by rniwa@webkit.org

2 edits in trunk/Tools

Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
https://bugs.webkit.org/show_bug.cgi?id=67855

Reviewed by Dirk Pranke.

The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.

Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

11:17 AM Changeset in webkit [94867] by mhahnenberg@apple.com

2 edits in trunk/Tools

Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=67853

Reviewed by Darin Adler.

Scripts/webkitpy/common/config/committers.py:

11:11 AM Changeset in webkit [94866] by Laszlo Gombos

9 edits
1 delete in trunk

[Qt] Remove common.pri
https://bugs.webkit.org/show_bug.cgi?id=67814

Reviewed by Andreas Kling.

Source/WebKit.pri: Move rules from common.pri to WebKit.pri.
Source/common.pri: Removed.

Source/JavaScriptCore:

JavaScriptCore.pri:

Source/WebCore:

No new tests, no change in functionality.

CodeGenerators.pri:
WebCore.pri:

Tools:

Tools.pro:

11:08 AM Changeset in webkit [94865] by inferno@chromium.org

1 edit
8 adds
1 delete in trunk/LayoutTests

Unreviewed. Chromium, GTK, Qt rebaselines for r94857.

platform/chromium-linux/fast/lists/list-marker-before-content-table-expected.png: Added.
platform/chromium-linux/fast/runin/runin-generated-before-content-expected.png: Added.
platform/chromium-win-xp/fast/lists: Removed.
platform/chromium-win/fast/lists/list-marker-before-content-table-expected.png: Added.
platform/chromium-win/fast/runin/runin-generated-before-content-expected.png: Added.
platform/gtk/fast/lists/list-marker-before-content-table-expected.txt: Added.
platform/gtk/fast/runin/runin-generated-before-content-expected.txt: Added.
platform/mac/fast/lists/list-marker-before-content-table-expected.txt: Added.
platform/mac/fast/runin/runin-generated-before-content-expected.txt: Added.
platform/qt/fast/lists/list-marker-before-content-table-expected.txt: Added.
platform/qt/fast/runin/runin-generated-before-content-expected.txt: Added.

11:06 AM Changeset in webkit [94864] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore: Assert being hit in AccessibilityRenderObject::addChildren()
https://bugs.webkit.org/show_bug.cgi?id=61805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

Fix nextSibling and previousSibling to handle adjacent continuations
properly, otherwise nodes end up appearing in the accessibility
tree twice (or a debug assertion could be raised).

Test: accessibility/adjacent-continuations-cause-assertion-failure.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):

LayoutTests: Add a test to catch a case where adjacent continuations were
causing nodes to get added to the accessibility tree twice, leading
to an assertion failure or a crash. The test expectations are
currently Mac-specific, so added the test to the Skipped file for
gtk and win.
https://bugs.webkit.org/show_bug.cgi?id=61805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

accessibility/adjacent-continuations-cause-assertion-failure.html: Added.
platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.

11:00 AM Changeset in webkit [94863] by commit-queue@webkit.org

3 edits in trunk/Tools

[NRWT] the nrwt check httpd with --no-http option
https://bugs.webkit.org/show_bug.cgi?id=67835

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09
Reviewed by Tony Chang.

Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

10:37 AM Changeset in webkit [94862] by commit-queue@webkit.org

7 edits
1 add in trunk

[chromium] Implement DRT support for Android.
https://bugs.webkit.org/show_bug.cgi?id=67590

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-09
Reviewed by Tony Chang.

Source/WebKit/chromium:

Exclude Android specific files of DRT from other platforms.

WebKit.gyp:

Tools:

Add 2 mechanism to make DRT interaction more robust on Android:

Send 'QUIT' to DRT to make it stop.
Wait until receiving '#READY' from DRT, so that DRT won't miss any

input commands before it starts.
And LayoutTestController.cpp needs to include <cctype> for 'tolower'
and <clocale> for 'LC_ALL' to compile on Android.

Also change to use sigaction instead of signal for TestShellGtk.cpp,
as signal() man page recommends using sigaction().

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/LayoutTestController.cpp:
DumpRenderTree/chromium/TestShellAndroid.cpp: Added.

(AlarmHandler):
(TestShell::waitTestFinished):
(platformInit):
(openStartupDialog):
(checkLayoutTestSystemDependencies):

DumpRenderTree/chromium/TestShellGtk.cpp:

(AlarmHandler):
(TestShell::waitTestFinished):

10:27 AM Changeset in webkit [94861] by rolandsteiner@chromium.org

9 edits
2 adds in trunk

Implement a WebKitAnimationEvent constructor.
https://bugs.webkit.org/show_bug.cgi?id=67825

Source/WebCore:

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

There is no spec for the WebKitAnimationEvent constructor
since it is WebKit-specific. However, based on the current
IDL of initWebKitAnimationEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
interface WebKitAnimationEvent : Event {

...;

}

dictionary WebKitAnimationEventInit : EventInit {

DOMString animationName;
double elapsedTime;

}

Test: fast/events/constructors/webkit-animation-event-constructor.html

bindings/generic/EventConstructors.h: Added a definition for the WebKitAnimationEvent constructor.
bindings/js/JSEventConstructors.cpp: Added #includes for WebKitAnimationEvent.
dom/WebKitAnimationEvent.cpp:

(WebCore::WebKitAnimationEventInit::WebKitAnimationEventInit):
(WebCore::WebKitAnimationEvent::WebKitAnimationEvent):

dom/WebKitAnimationEvent.h: Added a definition for WebKitAnimationEventInit.

(WebCore::WebKitAnimationEvent::create):

dom/WebKitAnimationEvent.idl: Makes WebKitAnimationEvent constructible.

LayoutTests:

Checks the behavior of the WebKitAnimationEvent constructor.

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

fast/dom/constructed-objects-prototypes-expected.txt:
fast/events/constructors/webkit-animation-event-constructor-expected.txt: Added.
fast/events/constructors/webkit-animation-event-constructor.html: Added.
platform/chromium/test_expectations.txt: Skipped webkit-animation-event-constructor.html, since V8 does not yet have the WebKitAnimationEvent constructor.

10:24 AM Changeset in webkit [94860] by Csaba Osztrogonác

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r94857. Add platform specific expected files.

platform/qt/fast/lists/list-marker-before-content-table-expected.png: Added.
platform/qt/fast/lists/list-marker-before-content-table-expected.txt: Added.
platform/qt/fast/runin/runin-generated-before-content-expected.png: Added.
platform/qt/fast/runin/runin-generated-before-content-expected.txt: Added.

9:58 AM Changeset in webkit [94859] by commit-queue@webkit.org

4 edits
3 adds in trunk/Source/WebKit/chromium

[Chromium] Add WebSandboxSupport and WebThemeEngine for Android.
https://bugs.webkit.org/show_bug.cgi?id=67584

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-09
Reviewed by Steve Block.

Make src/PlatformSupport.cpp and src/WebFrameImpl.cpp compile on
Chromium port for Android.

WebKit.gyp:
public/android: Added.
public/android/WebSandboxSupport.h: Added.
public/android/WebThemeEngine.h: Added.

(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFontFamilyForCharacters):
(WebCore::PlatformSupport::getRenderStyleForStrike):

src/WebFrameImpl.cpp:

9:49 AM Changeset in webkit [94858] by kevino@webkit.org

2 edits in trunk/Tools

[wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.

9:23 AM Changeset in webkit [94857] by inferno@chromium.org

3 edits
6 adds in trunk

:before content rendering issues with list markers and run-ins.
https://bugs.webkit.org/show_bug.cgi?id=67735

Source/WebCore:

1) Remove the isAnonymous checks for run-in detection since the
run-in can belong to a node.
2) When the parent has block children, then the list marker will
be enclosed in an anonymous block. In that case, for going to the
next list marker, we need to traverse one level up. We don't need
this check when searching for generated run-in (loop 2), since we
know parent will have inline children, so the list marker wont be
enclosed in an anonymous block.

Reviewed by Dave Hyatt.

Tests: fast/lists/list-marker-before-content-table.html

fast/runin/runin-generated-before-content.html

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::beforePseudoElementRenderer):

LayoutTests:

Reviewed by Dave Hyatt.

fast/lists/list-marker-before-content-table-expected.png: Added.
fast/lists/list-marker-before-content-table-expected.txt: Added.
fast/lists/list-marker-before-content-table.html: Added.
fast/runin/runin-generated-before-content-expected.png: Added.
fast/runin/runin-generated-before-content-expected.txt: Added.
fast/runin/runin-generated-before-content.html: Added.

9:16 AM Changeset in webkit [94856] by Nate Chapin

2 edits
7 adds
1 delete in trunk/LayoutTests

2011-09-09 Nate Chapin <Nate Chapin>

Chromium leopard css3 baselines, and new mac gpu baselines.

platform/chromium-cg-mac-leopard/css3: Added.
platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Added.
platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Added.
platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Added.
platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png: Added.
platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed.
platform/chromium-gpu/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
platform/chromium/test_expectations.txt:

8:21 AM Changeset in webkit [94855] by podivilov@chromium.org

6 edits
1 add in trunk/Source/WebCore

Web Inspector: introduce JavaScriptSourceFrame class.
https://bugs.webkit.org/show_bug.cgi?id=67838

SourceFrame should not deal with JavaScript debugging since it is a base class for all source frame implementations.

Reviewed by Pavel Feldman.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/JavaScriptSourceFrame.js: Added.

(WebInspector.JavaScriptSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel): moved from ScriptsPanel.js
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

8:15 AM Changeset in webkit [94854] by caryclark@google.com

1 edit
199 adds in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, GPU edition)
Added reference images.

platform/chromium-gpu-mac: Added.

(remaining files omitted for brevity)

7:47 AM Changeset in webkit [94853] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed, rolling out r94851.
http://trac.webkit.org/changeset/94851
https://bugs.webkit.org/show_bug.cgi?id=67847

It broke a webkitpy test (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

Scripts/webkitpy/layout_tests/controllers/manager.py:

7:32 AM Changeset in webkit [94852] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt] QWebElement::encloseWith doesn't work at all
https://bugs.webkit.org/show_bug.cgi?id=62464

Enclosing an element means wrapping something around an element,
not inserting something into an element. Therefore we need to check
if the parent of the element allows insertion rather than checking
the element itself.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-09
Reviewed by Andreas Kling.

Api/qwebelement.cpp:

(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseWith):

tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::appendAndPrepend):
(tst_QWebElement::encloseWith):

6:08 AM Changeset in webkit [94851] by Csaba Osztrogonác

2 edits in trunk/Tools

[NRWT] the nrwt check httpd with --no-http option
https://bugs.webkit.org/show_bug.cgi?id=67835

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09
Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/layout_tests/controllers/manager.py:

5:55 AM Changeset in webkit [94850] by zoltan@webkit.org

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed. Update test expectations for css3/bdi-element.html after r94822

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09

platform/qt/css3/bdi-element-expected.png: Added.
platform/qt/css3/bdi-element-expected.txt: Added.

5:41 AM Changeset in webkit [94849] by kov@webkit.org

1 edit
1 add in trunk/Source/WebKit/gtk/po

Canadian English translation.
https://bugzilla.gnome.org/show_bug.cgi?id=610152

Patch by Tiffany Antopolski <tiffany@antopolski.com> on 2011-09-09
Reviewed by Gustavo Noronha.

en_CA.po: Added.

5:27 AM Changeset in webkit [94848] by zoltan@webkit.org

2 edits in trunk/LayoutTests

[Qt] http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=67842

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09

platform/qt/Skipped:

4:39 AM Changeset in webkit [94847] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Exposing the isLink method on WebNode for the Chromium port on Android.

Patch by Martin Kosiba <mkosiba@chromium.org> on 2011-09-09
Reviewed by Darin Fisher.

public/WebNode.h:
src/WebNode.cpp:

(WebKit::WebNode::isLink):

4:34 AM Changeset in webkit [94846] by Csaba Osztrogonác

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r94845.
http://trac.webkit.org/changeset/94845
https://bugs.webkit.org/show_bug.cgi?id=67839

This patch kicked Qt-SL bots, but we don't need this
modification. (Requested by ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
platform/mac/WebVideoFullscreenController.mm:
platform/mac/WebVideoFullscreenHUDWindowController.mm:

4:04 AM Changeset in webkit [94845] by Csaba Osztrogonác

4 edits in trunk/Source/WebCore

[Qt][Mac]REGRESSION(r94774): Build is broken
https://bugs.webkit.org/show_bug.cgi?id=67799

It seems these files didn't rebuilt because of a
dependency bug. Touch them to trigger a rebuild.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
platform/mac/WebVideoFullscreenController.mm:
platform/mac/WebVideoFullscreenHUDWindowController.mm:

3:41 AM Changeset in webkit [94844] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, Chromium valgrind build fix.

Web Inspector: [Chromium] Valgrind signals use of uninitialized field in InspectorStyleSheetForInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=67837

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

3:32 AM Changeset in webkit [94843] by commit-queue@webkit.org

3 edits
3 deletes in trunk

Unreviewed, rolling out r94536.
http://trac.webkit.org/changeset/94536
https://bugs.webkit.org/show_bug.cgi?id=67836

breaks absoluteLocation() of RelatedMouseEvent (Requested by
jknotten on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

Source/WebCore:

dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

fast/events/page-scaled-mouse-click-expected.txt: Removed.
fast/events/page-scaled-mouse-click.html: Removed.
fast/events/script-tests/page-scaled-mouse-click.js: Removed.

3:16 AM Changeset in webkit [94842] by apavlov@chromium.org

9 edits in trunk

Web Inspector: live edit both for JS and CSS is not discoverable.
https://bugs.webkit.org/show_bug.cgi?id=65962

Source/WebCore:

Add the "Edit" button to SourceFrame, so that resources/scripts can be edited both in the
Resources and the Scripts panels. The button is grayed out if the resource/script is not editable.

Reviewed by Yury Semikhatsky.

inspector/front-end/Images/statusbarButtonGlyphs.png:
inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype.set visibleView):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._editButtonClicked):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):

inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):

inspector/front-end/inspector.css:

(button.edit-source-status-bar-item .glyph):
(button.edit-source-status-bar-item.toggled-on .glyph):

LayoutTests:

Reviewed by Yury Semikhatsky.

inspector/debugger/scripts-panel.html:

2:13 AM Changeset in webkit [94841] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crashes in WebCore::AppendNodeCommand::create().
https://bugs.webkit.org/show_bug.cgi?id=67767

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Darin Adler.

Source/WebCore:

In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node.
The current code assumes lastNode is an Element node. This patch checks it.

Test: editing/execCommand/ident-crashes-topnode-is-text.html

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check.

LayoutTests:

Added a crash test case.

editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added.
editing/execCommand/ident-crashes-topnode-is-text.html: Added.

2:02 AM Changeset in webkit [94840] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crashes in WebCore::ApplyStyleCommand.doApply()
https://bugs.webkit.org/show_bug.cgi?id=67765

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Ryosuke Niwa.

WebCore::enclosingBlock may return null, but ApplyStyleCommand::applyBlockStyle did not check it. This patch make it to be checked.

Source/WebCore:

Test: editing/style/remove-format-without-enclosing-block.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): Added null check.

LayoutTests:

editing/style/remove-format-without-enclosing-block-expected.txt: Added.
editing/style/remove-format-without-enclosing-block.html: Added.

1:16 AM Changeset in webkit [94839] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-09-09 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Update test expectations for hyphenate-limit-lines.html.

platform/chromium/test_expectations.txt:

12:14 AM Changeset in webkit [94838] by simonjam@chromium.org

3 edits in trunk/Source/WebCore

[Chromium] Fix leak of Skia stream with custom CSS fonts
https://bugs.webkit.org/show_bug.cgi?id=67815

Reviewed by Adam Barth.

Test: fast/css/font-face-opentype.html under valgrind

platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

Sep 8, 2011:

11:48 PM Changeset in webkit [94837] by loislo@chromium.org

2 edits
5 deletes in trunk/LayoutTests

2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed, remove wrong chromium expectations for hyphenate-limit-lines.html and mark the test as failing IMAGE+TEXT.

I rebaselined the expectations yesterday but actualy Chromium doesn't support hyphenation yet.
See CR47083.

platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Removed.
platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Removed.
platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Removed.
platform/chromium/test_expectations.txt:

11:16 PM Changeset in webkit [94836] by rniwa@webkit.org

19 edits in trunk/Source/WebCore

Push more code from HTMLInputElement::setValue to TextFieldInputType::setValue
https://bugs.webkit.org/show_bug.cgi?id=67742

Reviewed by Darin Adler.

Moved more code in HTMLInputElement::setValue to TextFieldInputType::setValue, and merged
InputType::valueChanged into InputType::setValue. Also introduced
InputType::dispatchChangeEventInResponseToSetValue to be overridden by TextFieldInputType.

html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

html/BaseButtonInputType.h:
html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

html/BaseCheckableInputType.h:
html/ColorInputType.cpp:
html/ColorInputType.h:
html/FileInputType.cpp:

(WebCore::FileInputType::setValue):

html/FileInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

html/HTMLInputElement.h:

(WebCore::HTMLInputElement::cacheSelectionInResponseToSetValue):

html/HiddenInputType.cpp:

(WebCore::HiddenInputType::setValue):

html/HiddenInputType.h:
html/InputType.cpp:

(WebCore::InputType::setValue):
(WebCore::InputType::dispatchChangeEventInResponseToSetValue):

html/InputType.h:
html/RangeInputType.cpp:

(WebCore::RangeInputType::setValue):

html/RangeInputType.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue):
(WebCore::TextFieldInputType::dispatchChangeEventInResponseToSetValue):

html/TextFieldInputType.h:

11:07 PM Changeset in webkit [94835] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r94811): Assertion failure in 2 worker tests
https://bugs.webkit.org/show_bug.cgi?id=67829

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Sam Weinig.

Fixing a couple tests that were broken due to the wrong values being
set in the parent class pointers in the ClassInfo structs for
TerminatedExecutionError and InterruptedExecutionError.

runtime/ExceptionHelpers.cpp:

10:52 PM Changeset in webkit [94834] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: chromium/compositing/zoom-animator-scale-test missing on leopard gpu

10:39 PM Changeset in webkit [94833] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

platform/chromium/test_expectations.txt: add webaudio/sample-accurate-scheduling.html

9:03 PM Changeset in webkit [94832] by sullivan@chromium.org

3 edits
2 adds in trunk

Crashes in WebCore::InsertNodeBeforeCommand constructor.
https://bugs.webkit.org/show_bug.cgi?id=67763

Reviewed by Ryosuke Niwa.

Source/WebCore:

Changes editableRootForPosition() to use the position's containerNode instead of deprecatedNode so that
positions which are before or after a given node cannot return that node as the editable root.

Test: editing/inserting/insert-paragraph-selection-outside-contenteditable.html

editing/htmlediting.cpp:

(WebCore::editableRootForPosition): use containerNode instead of deprecatedNode.

LayoutTests:

Tests for crash when the selection is outside the contenteditable node.

editing/inserting/insert-paragraph-selection-outside-contenteditable-expected.txt: Added.
editing/inserting/insert-paragraph-selection-outside-contenteditable.html: Added.

8:20 PM Changeset in webkit [94831] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Release the reference to the HTMLPlugInElement's script object, when the element is removed from the document. This breaks a cyclical reference that would otherwise cause the element to be retained until the document is torn down.
https://bugs.webkit.org/show_bug.cgi?id=66181

Patch by James Weatherall <wez@chromium.org> on 2011-09-08
Reviewed by Anders Carlsson.

No new tests - no functional change.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::removedFromDocument):

html/HTMLPlugInElement.h:

8:19 PM Changeset in webkit [94830] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/rendering/RenderScrollbar.cpp

Merge 94690 - Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.

BUG=95552
Review URL: http://codereview.chromium.org/7787021

7:57 PM Changeset in webkit [94829] by commit-queue@webkit.org

1 edit
2 adds in trunk

Test how HTMLAnchorElement.getParameter reacts to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66522

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-08
Reviewed by Adam Barth.

LayoutTests/fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Added.
LayoutTests/fast/dom/HTMLAnchorElement/get-parameter.html: Added.

7:40 PM Changeset in webkit [94828] by dbates@webkit.org

10 edits
18 adds in trunk

XSS filter bypass via non-standard URL encoding
https://bugs.webkit.org/show_bug.cgi?id=66588

Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html

http/tests/security/xssAuditor/script-tag-with-16bit-unicode.html
http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html
http/tests/security/xssAuditor/script-tag-with-16bit-unicode3.html
http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html
http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html
http/tests/security/xssAuditor/window-open-without-url-should-not-assert.html

Implement support for decoding non-standard 16-bit Unicode escape sequences of
the form %u26C4 as described in <http://www.w3.org/International/iri-edit/draft-duerst-iri.html#anchor29>.

See also <http://en.wikipedia.org/wiki/Percent-encoding#Non-standard_implementations>.

GNUmakefile.list.am: Added DecodeEscapeSequences.h.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
html/parser/XSSAuditor.cpp:

(WebCore::decode16BitUnicodeEscapeSequences): Added.
(WebCore::decodeStandardURLEscapeSequences): Added.
(WebCore::fullyDecodeString): Modified to call decode16BitUnicodeEscapeSequences().
(WebCore::XSSAuditor::init): Modified to return early when the URL of the document
is the empty string. This can happen when opening a new browser window or calling
window.open("").

platform/KURL.cpp:

(WebCore::decodeURLEscapeSequences): Abstracted code into template-function decodeEscapeSequences().
This function just calls decodeEscapeSequences<URLEscapeSequence>().

platform/text/DecodeEscapeSequences.h: Added.

(WebCore::Unicode16BitEscapeSequence::findInString):
(WebCore::Unicode16BitEscapeSequence::matchStringPrefix):
(WebCore::Unicode16BitEscapeSequence::decodeRun):
(WebCore::URLEscapeSequence::findInString):
(WebCore::URLEscapeSequence::matchStringPrefix):
(WebCore::URLEscapeSequence::decodeRun):
(WebCore::decodeEscapeSequences):

LayoutTests:

Add tests for decoding non-standard 16-bit Unicode escape sequences.

Also add a test to ensure that we don't cause an assertion failure when
calling window.open("").

http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl: Added.

(isUTF16Surrogate):
(decodeRunOf16BitUnicodeEscapeSequences):
(decode16BitUnicodeEscapeSequences):

http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode.html: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode2.html: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode3.html: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode4.html: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html: Added.
http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Updated expected

result since we now pass this test. We should rename this file to something more descriptive,
see <https://bugs.webkit.org/show_bug.cgi?id=67818>.

http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html: Added.
http/tests/security/xssAuditor/window-open-without-url-should-not-assert-expected.txt: Added.
http/tests/security/xssAuditor/window-open-without-url-should-not-assert.html: Added.

7:02 PM Changeset in webkit [94827] by ukai@chromium.org

1 edit
8 adds in trunk/LayoutTests

Unreviewed. Chromium rebaseline of css3/bdi-element.html

platform/chromium-cg-mac/css3/bdi-element-expected.png: Added.
platform/chromium-linux/css3/bdi-element-expected.png: Added.
platform/chromium-mac/css3/bdi-element-expected.png: Added.
platform/chromium-win/css3/bdi-element-expected.png: Added.
platform/chromium-win/css3/bdi-element-expected.txt: Added.
platform/chromium/css3/bdi-element-expected.txt: Added.
platform/chromium/test_expectations.txt:

6:29 PM Changeset in webkit [94826] by dbates@webkit.org

2 edits in trunk/Source/WebKit/gtk

2011-09-08 Daniel Bates <dbates@webkit.org>

Fix the GTK build after <http://trac.webkit.org/changeset/94810>
(https://bugs.webkit.org/show_bug.cgi?id=67807).

webkit/webkitwebview.cpp: (webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for DocumentWriter::encoding().

6:25 PM Changeset in webkit [94825] by abarth@webkit.org

2 edits in trunk/Source/WebCore

DocumentWriter::deprecatedFrameEncoding doesn't need to refert to Settings
https://bugs.webkit.org/show_bug.cgi?id=67812

Reviewed by Eric Seidel.

The one caller of this function does this work already.

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::deprecatedFrameEncoding):

6:14 PM Changeset in webkit [94824] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=67810

Reviewed by Tony Chang.

Reported as a valgrind failure in http://crbug.com/84777.

No possible change in behavior, so no tests. The unitialized read
could never have an impact:

if (m_sortedTextBoxesPosition + 1 < m_sortedTextBoxes.size()) ...

Since m_sortedTextBoxes.size() will be zero here if
m_sortedTextBoxesPosition is uninitialized, and they're both unsigned,
so no possible value of m_sortedTextBoxesPosition could be < 0.

editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator):

5:50 PM Changeset in webkit [94823] by tony@chromium.org

3 edits in trunk/Source/WebCore

Cleanup of switch statements with default cases
https://bugs.webkit.org/show_bug.cgi?id=67808

Reviewed by Adam Barth.

No new tests, just a small refactoring.

page/WebKitAnimation.cpp:

(WebCore::WebKitAnimation::fillMode):

platform/audio/Distance.cpp:

(WebCore::DistanceEffect::gain):

5:34 PM Changeset in webkit [94822] by eric@webkit.org

3 edits
3 adds in trunk

[BiDi] Add support for the BDI element
https://bugs.webkit.org/show_bug.cgi?id=50913

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch is ridiculously trivial now that we have unicode-bidi: isolate support in WebKit.

Test: css3/bdi-element.html

css/html.css:

(bdi):

LayoutTests:

css3/bdi-element.html: Added.
platform/mac/css3/bdi-element-expected.png: Added.
platform/mac/css3/bdi-element-expected.txt: Added.

5:13 PM BuildBot edited by rniwa@webkit.org

Add an explicit step to run "buildbot create-master" (diff)

4:52 PM UsingGitWithWebKit edited by davidbarr@chromium.org

Update suggested repack parameters from experiments (diff)

4:48 PM Changeset in webkit [94821] by levin@chromium.org

2 edits in trunk/Source/WebCore

[chromium] KURL::copy doesn't produce something usable on another thread.
https://bugs.webkit.org/show_bug.cgi?id=67809

Reviewed by Adam Barth.

No new functionality exposed so no new test. This was caught by testing code: the thread
sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708).

platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will
not be used on another thread.

4:35 PM Changeset in webkit [94820] by ap@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r66874): Missing RefPtr in ScriptController
https://bugs.webkit.org/show_bug.cgi?id=67748

Reviewed by Adam Barth.

bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):

4:30 PM Changeset in webkit [94819] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Another attempt to fix the Chromium build. (Missed one.)

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::serialize):

4:29 PM Changeset in webkit [94818] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/9742393> Spell checking a text area causes the page to reload

Ensure that m_pendingLearnOrIgnoreWordMessageCount is incremented when we use
executeEditCommand to ignore a word. This will ensure that WebPageProxy::ignoreWord
is expecting to be called, and will not turn around and terminate the web process.

Reviewed by Anders Carlsson.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand):

4:15 PM Changeset in webkit [94817] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Second attempt to fix Chromium build.

dom/Document.h:

4:03 PM Changeset in webkit [94816] by abarth@webkit.org

6 edits in trunk/Source/WebKit/chromium

Attempt to fix Chromium build. We can just grab the encoding from the document.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

src/WebDocument.cpp:

(WebKit::WebDocument::encoding):

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):

src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageEncoding):

3:56 PM Changeset in webkit [94815] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Remove accidentally committed typo.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):

3:52 PM Changeset in webkit [94814] by oliver@apple.com

15 edits
2 adds in trunk/Source

Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Use a bump allocator for initial allocation of property storage,
and promote to fastMalloc memory only if it survives a GC pass.

Comes out as a 1% win on v8, and is a useful step on the way to
GC allocation of all property storage.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.cpp:

(JSC::Heap::collect):

heap/Heap.h:

(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursery):

heap/MarkedBlock.h:
heap/NewSpace.cpp:

(JSC::NewSpace::NewSpace):

heap/NewSpace.h:

(JSC::NewSpace::resetPropertyStorageNursery):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

runtime/JSObject.h:

(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
(JSC::JSObject::propertyStorage):
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

runtime/StorageBarrier.h: Added.

(JSC::StorageBarrier::StorageBarrier):
(JSC::StorageBarrier::set):
(JSC::StorageBarrier::operator->):
(JSC::StorageBarrier::operator*):
(JSC::StorageBarrier::operator[]):
(JSC::StorageBarrier::get):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header.

ForwardingHeaders/runtime/StorageBarrier.h: Added.

3:45 PM Changeset in webkit [94813] by rolandsteiner@chromium.org

6 edits
2 deletes in trunk

Unreviewed, rolling out r94809.
http://trac.webkit.org/changeset/94809
https://bugs.webkit.org/show_bug.cgi?id=67718

commit _still_ premature, despite CQ eagerness

Source/WebCore:

html/HTMLAttributeNames.in:
html/HTMLStyleElement.cpp:
html/HTMLStyleElement.h:
html/HTMLStyleElement.idl:

LayoutTests:

fast/css/style-scoped/basic-attribute-expected.txt: Removed.
fast/css/style-scoped/basic-attribute.html: Removed.

3:45 PM Changeset in webkit [94812] by bweinstein@apple.com

7 edits
3 adds in trunk

Source/WebKit2: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
https://bugs.webkit.org/show_bug.cgi?id=67794
<rdar://problem/9892024>

Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string
is empty or null.

If we call didPerformClientRedirect or didPerformServerRedirect when the source or destination is null,
it causes an assert in WKURLCF::WKURLCopyCFURL when we try to convert the WKURLRef into a CFURLRef.

Reviewed by Brady Eidson.

UIProcess/WebContext.cpp:

(WebKit::WebContext::didPerformClientRedirect): Return early if the source or destination URL string is empty or null.
(WebKit::WebContext::didPerformServerRedirect): Ditto.

Tools: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
https://bugs.webkit.org/show_bug.cgi?id=67794
<rdar://problem/9892024>

Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.

Reviewed by Brady Eidson.

TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
(TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
(TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.

Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
didPerformServerRedirect.

TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.

(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize

our InjectedBundleTest.

(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request

from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
the request.

(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.

TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
TestWebKitAPI/win/copy-resources.cmd: Ditto.

3:38 PM Changeset in webkit [94811] by weinig@apple.com

33 edits in trunk/Source

Remove the Completion object from JSC, I have never liked it
https://bugs.webkit.org/show_bug.cgi?id=67755

Reviewed by Gavin Barraclough.

../JavaScriptCore:

Removes the Completion object and replaces its use with out parameter exceptions.
Remove ComplType and virtual exceptionType() function on JSObject. Replace with ClassInfo for InterruptedExecutionError and TerminatedExecutionError.

API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

jsc.cpp:

(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):

runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

runtime/Completion.h:
runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::toString):
(JSC::TerminatedExecutionError::toString):
(JSC::createInterruptedExecutionException):

runtime/ExceptionHelpers.h:

(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
(JSC::TerminatedExecutionError::createStructure):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSObject.h:

../JavaScriptGlue:

JSRun.cpp:

(JSRun::Evaluate):
(JSRun::CheckSyntax):

JSRun.h:
JavaScriptGlue.cpp:

(JSRunEvaluate):

../WebCore:

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::evaluate):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject evaluateWebScript:]):

bridge/NP_jsobject.cpp:

(_NPN_Evaluate):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::eval):

../WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluate):

../WebKit/qt:

Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

../WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

3:20 PM Changeset in webkit [94810] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Inline DocumentWriter::encoding() into it's only caller: deprecatedFrameEncoding()
https://bugs.webkit.org/show_bug.cgi?id=67807

Reviewed by Eric Seidel.

This function is super nutty. We don't want any more folks to call it
thinking that it does something sane.

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::deprecatedFrameEncoding):

loader/DocumentWriter.h:

3:17 PM Changeset in webkit [94809] by rolandsteiner@chromium.org

6 edits
2 adds in trunk

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/basic-attribute.html

html/HTMLAttributeNames.in:
html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):

html/HTMLStyleElement.h:
html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.

Reviewed by Dimitri Glazkov.

fast/css/style-scoped/basic-attribute-expected.txt: Added.
fast/css/style-scoped/basic-attribute.html: Added.

3:10 PM Changeset in webkit [94808] by tony@chromium.org

1 edit
1 delete in trunk/LayoutTests

remove fast/exclusions/triangle-exclusion.html which was originally added as a placeholder
https://bugs.webkit.org/show_bug.cgi?id=67795

fast/exclusions/triangle-exclusion.html: Removed.

3:04 PM Changeset in webkit [94807] by Nate Chapin

2 edits
2 adds
2 deletes in trunk/LayoutTests

2011-09-08 Nate Chapin <Nate Chapin>

Chromium rebaseline zoom-animator-scale-test.html and mark a couple
svg-as-background tests flaky on chromium-win.

platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Removed.
platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed.
platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:53 PM Changeset in webkit [94806] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

Build fix.

dfg/DFGCapabilities.cpp:

2:52 PM Changeset in webkit [94805] by commit-queue@webkit.org

11 edits
1 move
2 adds
4 deletes in trunk

Unreviewed, rolling out r94781.
http://trac.webkit.org/changeset/94781
https://bugs.webkit.org/show_bug.cgi?id=67806

Broke Objective-C binding on Mac (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

dom/Element.idl:
dom/Node.cpp:

(WebCore::Node::contains):

dom/Node.idl:
editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

fast/dom/Element/contains-method-expected.txt: Added.
fast/dom/Element/contains-method.html: Renamed from LayoutTests/fast/dom/Node/contains-method.html.
fast/dom/Element/script-tests/contains-method.js: Added.
fast/dom/Node/contains-method-expected.txt: Removed.
fast/dom/Node/script-tests/contains-method.js: Removed.
fast/dom/Window/window-properties-expected.txt:
perf/document-contains-expected.txt: Removed.
perf/document-contains.html: Removed.
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:

2:51 PM Changeset in webkit [94804] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Don't release the modal placeholder window if it's closed
https://bugs.webkit.org/show_bug.cgi?id=67801
<rdar://problem/10088059>

Reviewed by Adam Roben.

This is a speculative fix - nothing should really be able to close the modal placeholder window.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::beginModal):

2:50 PM Changeset in webkit [94803] by levin@chromium.org

3 edits in trunk/Tools

check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
https://bugs.webkit.org/show_bug.cgi?id=67797

Reviewed by Eric Seidel.

Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.

2:38 PM Changeset in webkit [94802] by fpizlo@apple.com

8 edits
2 adds in trunk/Source/JavaScriptCore

Value profling and execution count profiling is performed even for
code that cannot be optimized
https://bugs.webkit.org/show_bug.cgi?id=67694

Reviewed by Gavin Barraclough.

This is a 2% speed-up on V8 when tiered compilation is enabled.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::ProgramCodeBlock::canCompileWithDFG):
(JSC::EvalCodeBlock::canCompileWithDFG):
(JSC::FunctionCodeBlock::canCompileWithDFG):

bytecode/CodeBlock.h:
dfg/DFGCapabilities.cpp: Added.

(JSC::DFG::canCompileOpcodes):

dfg/DFGCapabilities.h: Added.

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):

jit/JIT.cpp:

(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::JIT::shouldEmitProfiling):

jit/JITInlineMethods.h:

(JSC::JIT::emitValueProfilingSite):

2:36 PM Changeset in webkit [94801] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG speculative JIT does not initialize integer tags for PredictInt32 temporaries
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Gavin Barraclough.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::initializeVariableTypes):

2:31 PM Changeset in webkit [94800] by eric@webkit.org

3 edits in trunk/Source/WebCore

Remove DocumentWriter::setDecoder as a grep of WebKit shows no callers
https://bugs.webkit.org/show_bug.cgi?id=67803

Reviewed by Adam Barth.

Smells like dead code.

loader/DocumentWriter.cpp:
loader/DocumentWriter.h:

2:30 PM Changeset in webkit [94799] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[WK2] evetSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

platform/wk2/Skipped: Skip fast/dom/shadow/access-key.html.

2:16 PM Changeset in webkit [94798] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Chromium shadow-buffer-partial test change.
Part1: Update and disable test.
https://bugs.webkit.org/show_bug.cgi?id=67724

Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
platform/chromium/test_expectations.txt:

2:11 PM Changeset in webkit [94797] by commit-queue@webkit.org

7 edits in trunk

Implement double tap detection in GestureRecognizerChromium
https://bugs.webkit.org/show_bug.cgi?id=67709

Patch by Varun Jain <varunjain@google.com> on 2011-09-08
Reviewed by Dimitri Glazkov.

Source/WebCore/page/EventHandler.cpp:
Source/WebCore/platform/PlatformGestureEvent.h:

2:00 PM Changeset in webkit [94796] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

frame-loading-via-document-write.html test cases have extra slash in path
https://bugs.webkit.org/show_bug.cgi?id=67784

Removing extra slash in path: file:////tmp/... => file:///tmp/...

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-08
Reviewed by Andreas Kling.

fast/dom/frame-loading-via-document-write.html:
http/tests/security/frame-loading-via-document-write.html:

1:54 PM Changeset in webkit [94795] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=67771

Fix sequenceGetByIdSlowCaseInstructionSpace, sequenceGetByIdSlowCaseConstantSpace
and patchOffsetGetByIdSlowCaseCall
and enables DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS flag for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-08
Reviewed by Gavin Barraclough.

jit/JIT.h:
wtf/dtoa/utils.h:

1:53 PM Changeset in webkit [94794] by ap@apple.com

5 edits in trunk/LayoutTests

Some file-url-mimetypes subtests fail on rare extensions
https://bugs.webkit.org/show_bug.cgi?id=67679

platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Update platform specific results, too.

1:50 PM Changeset in webkit [94793] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crashes in WebCore::ReplaceSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=67762

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.

Tests: editing/inserting/insert-without-enclosing-block.html

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Added null check.

LayoutTests:

WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.

editing/inserting/insert-without-enclosing-block-expected.txt: Added.
editing/inserting/insert-without-enclosing-block.html: Added.

1:48 PM Changeset in webkit [94792] by Nate Chapin

1 edit
8 adds in trunk/LayoutTests

2011-09-08 Nate Chapin <Nate Chapin>

Chromium baselines for new tests added in r94775 and r94779.

platform/chromium-cg-mac/platform/chromium/fast/repaint: Added.
platform/chromium-cg-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Added.
platform/chromium-linux/css3/unicode-bidi-isolate-basic-expected.png: Added.
platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Added.
platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.png: Added.
platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.txt: Added.

1:46 PM Changeset in webkit [94791] by Csaba Osztrogonác

2 edits
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening after r94771.

fast/dom/constructed-objects-prototypes-expected.txt: Update, it will pass on Qt, GTK, SL, Win.
platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.

1:33 PM Changeset in webkit [94790] by commit-queue@webkit.org

6 edits
2 deletes in trunk

Unreviewed, rolling out r94784.
http://trac.webkit.org/changeset/94784
https://bugs.webkit.org/show_bug.cgi?id=67796

Commit was premature (Requested by rolandsteiner on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

html/HTMLAttributeNames.in:
html/HTMLStyleElement.cpp:
html/HTMLStyleElement.h:
html/HTMLStyleElement.idl:

LayoutTests:

fast/css/style-scoped/basic-attribute-expected.txt: Removed.
fast/css/style-scoped/basic-attribute.html: Removed.

1:31 PM Changeset in webkit [94789] by wjmaclean@chromium.org

15 edits
3 adds in trunk

[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
https://bugs.webkit.org/show_bug.cgi?id=66472

Source/WebCore:

This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.

Reviewed by James Robinson.

Test: platform/chromium/compositing/zoom-animator-scale-test.html

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::setZoomAnimatorScale):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorScale):
(WebCore::CCLayerTreeHost::updateLayers):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setZoomAnimatorScale):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
testing/Internals.cpp:

(WebCore::Internals::setZoomAnimatorScale):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium:

This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.

Reviewed by James Robinson.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

Initial tests for zoomAnimatorChromium backend.

Reviewed by James Robinson.

platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
platform/chromium/compositing/zoom-animator-scale-test.html: Added.

1:23 PM Changeset in webkit [94788] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)

1:19 PM Changeset in webkit [94787] by eric.carlson@apple.com

8 edits
2 adds in trunk

HTMLMediaElement is missing initialTime attribute
https://bugs.webkit.org/show_bug.cgi?id=67791

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-initialTime.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::initialTime):

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::initialTime):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::initialTime):

LayoutTests:

media/media-initialTime-expected.txt: Added.
media/media-initialTime.html: Added.

1:03 PM Changeset in webkit [94786] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Compile in ScrollAnimator for Chromium on all platforms by default.
https://bugs.webkit.org/show_bug.cgi?id=67650

Patch by Scott Byer <scottbyer@chromium.org> on 2011-09-08
Reviewed by Adam Barth.

features.gypi:

12:58 PM Changeset in webkit [94785] by robert@webkit.org

4 edits
3 adds in trunk

Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html

Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.

Note: This was originally landed in r94755 but positioned-float-layout-after-image-load.html exposed

an ASSERT bug, unrelated to this change, and was rolled out. That issue is tracked separately
in bug 67759.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when

deciding whether to mark children for layout

LayoutTests:

fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
fast/block/positioning/absolute-layout-after-image-load.html: Added.
fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.

12:56 PM Changeset in webkit [94784] by rolandsteiner@chromium.org

6 edits
3 adds in trunk

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/basic-attribute.html

html/HTMLAttributeNames.in:
html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):

html/HTMLStyleElement.h:
html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.

Reviewed by Dimitri Glazkov.

fast/css/style-scoped/basic-attribute-expected.txt: Added.
fast/css/style-scoped/basic-attribute.html: Added.

12:55 PM Changeset in webkit [94783] by commit-queue@webkit.org

7 edits
3 adds in trunk

[v8] Improve performance of typed array set() taking Array
https://bugs.webkit.org/show_bug.cgi?id=63644

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

Overwrite the native 'set' method of the type arrays with JS
implementation after initialization of the global context.

Add tests for invalid and boundary offsets. No performance tests.

LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt:
LayoutTests/fast/canvas/webgl/array-unit-tests.html:
Source/WebCore/WebCore.gyp/WebCore.gyp:
Source/WebCore/WebCore.gypi:
Source/WebCore/bindings/v8/V8BindingScripts.cpp: Added.
Source/WebCore/bindings/v8/V8BindingScripts.h: Added.
Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js: Added.

12:44 PM Changeset in webkit [94782] by commit-queue@webkit.org

29 edits
12 moves
12 adds
18 deletes in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 2
https://bugs.webkit.org/show_bug.cgi?id=67751

Patch by Ben Wells <benwells@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

fast/borders/border-radius-circle-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-circle-expected.txt.
fast/borders/border-radius-groove-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-01-expected.txt.
fast/borders/border-radius-groove-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-02-expected.txt.
fast/borders/border-radius-groove-03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-03-expected.txt.
fast/borders/border-radius-wide-border-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt.
fast/borders/border-radius-wide-border-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-02-expected.txt.
fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
fast/gradients/background-clipped-expected.txt: Renamed from LayoutTests/platform/gtk/fast/gradients/background-clipped-expected.txt.
fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt.
fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt.
fast/transforms/shadows-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/shadows-expected.txt.
platform/chromium-linux/fast/: 20 changes.
platform/chromium-win/fast/: 19 changes.
platform/chromium/test_expectations.txt:
platform/mac/fast/: 9 changes.
platform/qt/fast/: 10 removals.

12:38 PM Changeset in webkit [94781] by arv@chromium.org

11 edits
1 move
4 adds
2 deletes in trunk

Move Element.contains to Node
https://bugs.webkit.org/show_bug.cgi?id=67651

Reviewed by Darin Adler.

This moves the contains method from Element to Node as in the DOM4 working draft:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains

This also special cases Document contains to make it O(1) instead of O(depth).

Source/WebCore:

Tests: fast/dom/Node/contains-method.html

perf/document-contains.html

dom/Element.idl:
dom/Node.cpp:

(WebCore::Node::contains): Added document special case.

dom/Node.idl:
editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): Added a null check.

LayoutTests:

fast/dom/Element/contains-method-expected.txt: Removed.
fast/dom/Element/script-tests/contains-method.js: Removed.
fast/dom/Node/contains-method-expected.txt: Added.
fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html.
fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests.
fast/dom/Window/window-properties-expected.txt:
perf/document-contains-expected.txt: Added.
perf/document-contains.html: Added.

Perf test to ensure that document.contains is O(1).

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt:
platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-expected.txt:

12:22 PM Changeset in webkit [94780] by crogers@google.com

4 edits
2 adds in trunk

Check AudioContext createChannelMerger() for thread safety
https://bugs.webkit.org/show_bug.cgi?id=67247

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/audiochannelmerger-stereo.html

webaudio/AudioChannelMerger.cpp:

(WebCore::AudioChannelMerger::process):
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):

webaudio/AudioChannelMerger.h:

LayoutTests:

webaudio/audiochannelmerger-stereo-expected.txt: Added.
webaudio/audiochannelmerger-stereo.html: Added.

12:20 PM Changeset in webkit [94779] by fsamuel@chromium.org

5 edits
3 adds in trunk

Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=67723

Reviewed by Adam Barth.

Tools:

DumpRenderTree/chromium/EventSender.h:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):

DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added.
platform/chromium/fast/repaint/fixed-layout-360x240.html: Added.

12:18 PM Changeset in webkit [94778] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Refactor hyphen measurement
https://bugs.webkit.org/show_bug.cgi?id=67728

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-08
Reviewed by Darin Adler.

No new tests, purely refactoring.

rendering/RenderBlockLineLayout.cpp:

(WebCore::measureHyphenWidth): Added.
(WebCore::setLogicalWidthForTextRun): Use measureHyphenWidth().
(WebCore::tryHyphenating): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

11:54 AM Changeset in webkit [94777] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Remove LayoutStateDisabler instances from RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=66896

Reviewed by Simon Fraser.

As part of r93614, scrollTo does not call updateLayerPositions anymore.
This means that we don't need to disable LayoutState from the scrolling code
in RenderLayer.

This change is covered by the existing tests.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Updated the comment
that was not accurate anymore. Also explained what is wrong with
LayoutState vs RenderLayer now. Note that the ASSERT is still
valid and will not trigger as the remaining calls to updateLayerPositions
are done *outside* layout() where LayoutState is not set (thus disabled).

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed
2 LayoutStateDisabler surrounding scrollToOffset.

11:53 AM Changeset in webkit [94776] by jchaffraix@webkit.org

6 edits in trunk/Source/WebCore

Factor out the code to get the first non-null RenderTableSection in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=66972

Reviewed by Darin Adler.

Refactoring only, covered by existing tests.

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):

accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::rowIndexRange):
Updated those for the signature change in sectionBelow. Also added
a FIXME where topSection should be used instead of iterating
over the section (and likely missing some corner cases).

rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
(WebCore::RenderTable::firstLineBoxBaseline):
Updated all those functions to use the newly added functions. Also changed
the variable names to match the functions.

(WebCore::RenderTable::layout):
(WebCore::RenderTable::topNonEmptySection): Newly added function
that returns the top non null section of the table that has at least a
row.

(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
Update the signature of those 2 functions to take an enum as it makes the
rest of the code more readable.

rendering/RenderTable.h:

(WebCore::RenderTable::topSection): Newly added function to return
the top non null section in the table.

11:46 AM Changeset in webkit [94775] by eric@webkit.org

7 edits
6 adds in trunk

Reviewed by Ryosuke Niwa.

[BiDi] [CSS3] MASTER: Add support for the unicode-bidi:isolate CSS property
https://bugs.webkit.org/show_bug.cgi?id=50912

Source/WebCore:

This patch adds support for CSS3 unicode-bidi: isolate property, under the -webkit- vendor prefix.
Parsing support was added in a previous patch, this wires up the RenderStyle values
to code changes in the BidiResolver.

The effect of this patch is that it makes it possible to "isolate" runs of text
so that their RTL-ness or LTR-ness does not bleed out into the rest of your text
and effect layout. This is important because many unicode characters (like parenthesis, ':', '-', etc.)
do not have intrinsic directionality and are affected by whatever characters come before/after.
If you have usernames which include RTL text, if you inject those usernames in your page
you might end up with nearby characters moving!
(like 'RTL USERNAME - my awesome site' as a title, could end up as
'my awesome site - USERNAME RTL' when correct would be 'USERNAME RTL - my awesome site'.)
This patch makes it possible to wrap sections of text in isolated spans, so that
they correctly order all their RTL/LTR contents, but also correctly participate in the
larger RTL/LTR ordering without affecting nearby characters.

Because much of this code is old and rarely touched, I've included extra background
information in hopes of expanding my set of potential reviewers:

WebKit uses the standard "Unicode Bidi Algorithm" henceforth known as the UBA.
The UBA is defined at http://unicode.org/reports/tr9/ for those not faint of heart.

Text layout is done per-block (<div>, <p>, etc), and begins with a string of text
(which in our case comes from the rendering tree) and a specified width.
First: Text is measured and wrapped into lines.
Second: The UBA is run over the lines of text.
Third: WebKit builds InlineBoxes (its linebox tree) and eventually render the text.

This patch modifies our UBA to ignore all text content inside "isolated" inlines (treating them as neutral characters)
and then adds another step after running the UBA, where we run the UBA recursively on any
previously identified "isolated" content.

The result of the UBA is an ordered list of "runs" of text with the RTL runs
correctly RTL and the LTR runs LTR.

The UBA does three things:

It assigns a "class" to each character in a text stream (like neutral, strongly-RTL, strongly-LTR, etc.)
Divides the text stream up into "runs" of characters of the same directionality (all RTL, all LTR).
Re-orders those runs.

The UBA in WebKit is implemented by BidiResolver<T> in BidiResolver.h

The InlineBidiResolver (BidiResolver specialization which knows about the rendering tree)
walks along its InlineIterators, looking at each character and running the
Unicode Bidi Algorithm (UBA). It walks through the rendering tree subtree under
a block, using a (poorly named) bidiNext function which returns the next inline object.
Each inline object (or text character there-in) has a corresponding meaning in the UBA
such as a "strong RTL" character or a "neutral" character. The UBA reads these sequence
of characters, and figures out what direction (RTL or LTR) to assign to any neutral
characters it encounters, based on surrounding characters.

As the InlineBidiResolver is walking the rendering tree, the InlineIterator::advance()
function calls bidiNext(), which in turn can call notifyObserverEnteredObject/notifyObserverWillExitObject
notifying InlineBidiResolver that it is entering or exiting an "isolated"
span, at which point it will either start or stop ignoring the stream of characters
from the InlineIterator. When the InlineBidiResolver is ignoring the stream of
characters, instead of creating separate BidiRuns at each RTL/LTR boundary
as it normally would, it instead creates one "fake" run for the entire
isolated span. These fake runs participate in the normal UBA run ordering process,
but after the main UBA, a second pass is made where we examine
the list of isolatedRuns() and run the UBA on each of them, replacing the fake
run we previously inserted, with the resulting list of runs from that inner UBA run.
The way it "ignores" characters is by treating them all as neutral when inside an isolate.
Thus all the characters end up grouped in a single run, but their directionality (as a group)
is correctly affected by any surrounding strong characters.

If you understood that last paragraph, than the rest of the change is just plumbing.

I added a huge number of FIXMEs to this code, because this code has a variety of
design choices (or lack there of) which make some of this very difficult.

For example the bidiNext iterator function has two sets of mutually exclusive
parameters and can be used optionally with or without an observer. Prior to this
change there was only ever one object which cared about observing a walk over inlines
and that was InlineBidiResolver. This patch (regretfully) templatizes bidiNext
to support a new Observer type. The correct fix would be to rip bidiNext into
multiple functions and rip need for observation out of InlineBidiResolver.
Unfortunately I've tried both in separate bugs and failed. This code is very very
old and very poorly understood. We're slowly moving forward, this is another tiny step.

This is my fourth iteration of this patch (I'm happy to do more!), but I believe
it's a good compromise between fixing all of the design gotcha's of our bidi
system and doing the minimum amount to add this killer CSS feature.

I ran the PLT. (It averaged 0.2% faster with this change, but I attribute that to noise).

Test: css3/unicode-bidi-isolate-basic.html and css3/unicode-bidi-isolate-aharon.html

platform/text/BidiResolver.h:

(WebCore::BidiCharacterRun::setNext):

Needed by the new replaceRunWithRuns function.

(WebCore::BidiResolver::BidiResolver):
(WebCore::BidiResolver::~BidiResolver):
(WebCore::BidiResolver::enterIsolate):
(WebCore::BidiResolver::exitIsolate):
(WebCore::BidiResolver::inIsolate):
(WebCore::BidiResolver::isolatedRuns):

Used to track isolated spans of text as they're encoutered. They're stuffed away here to be processed recursively after the main UBA has done its thang.

(WebCore::::appendRun):
(WebCore::::embed):
(WebCore::::commitExplicitEmbedding):
(WebCore::::createBidiRunsForLine):

platform/text/BidiRunList.h:

(WebCore::::replaceRunWithRuns):

This effectively takes all the runs from one runlist and adds them to this one, replacing the fake run we inserted during a previous pass of the UBA.
This RunList now owns the runs, so we call clear() on the other RunList so that we don't end up double-freeing the runs.

(WebCore::::clear):

This allows us to "take" runs from another run list and then clear it.

rendering/BidiRun.h:

(WebCore::BidiRun::object):

rendering/InlineIterator.h:

(WebCore::InlineIterator::object):
(WebCore::InlineIterator::offset):
(WebCore::notifyObserverEnteredObject): Mostly just renaming and adding a FIXME about plaintext.
(WebCore::notifyObserverWillExitObject): Mostly just renaming.
(WebCore::addPlaceholderRunForIsolatedInline):
(WebCore::isIsolatedInline):
(WebCore::InlineBidiResolver::appendRun):

rendering/RenderBlockLineLayout.cpp:

(WebCore::statusWithDirection):
(WebCore::constructBidiRuns):

This is the heavy-lifting of this change. This function runs the UBA recursively on all the previously identified isolated spans.
If we encounter more isolated spans in our run, we just add them to the main list an keep going. Because the runs are linked lists and we have direct pointers to our placeholder objects, we don't care what order we process the placeholders in, so long as when we're done, they're all processed.

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Two new tests for testing unicode-bidi: isolate behavior.
Note that the test from Aharon Lanin has one failing subtest
I've asked him if the test might have a typo in:
https://bugs.webkit.org/show_bug.cgi?id=50912#c30

css3/unicode-bidi-isolate-aharon.html: Added.
- Some various unicode-bidi: isolate tests from Aharon.
css3/unicode-bidi-isolate-basic.html: Added.
- This test tries all possible orderings of strong-LTR, strong-RTL and neutral characters across unicode-bidi: isolate spans to make sure that we match expected rendering.
- A little red bleeds through the test, but that appears to be from anti-aliasing and possible automatic font kerning, not layout failures.
platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
platform/mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
platform/mac/css3/unicode-bidi-isolate-basic-expected.txt: Added.

11:41 AM Changeset in webkit [94774] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Oliver Hunt.

We don't use JSCell::getUInt32 anymore, so it has been removed.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:
runtime/JSCell.h:

11:38 AM Changeset in webkit [94773] by macpherson@chromium.org

5 edits in trunk/LayoutTests

Update tests for inherit and initial values for -webkit-columns and related CSS properties.
https://bugs.webkit.org/show_bug.cgi?id=67685

Reviewed by Eric Seidel.

fast/multicol/inherit-column-values-expected.txt:
fast/multicol/inherit-column-values.html:
fast/multicol/initial-column-values-expected.txt:
fast/multicol/initial-column-values.html:

11:30 AM Changeset in webkit [94772] by commit-queue@webkit.org

7 edits in trunk

Split Tap gesture detection into TapDown and Tap.
We need this distinction to highlight links when they are first touched. The link is
followed only if the tap is completed, otherwise, if a scroll is detected, the highlight
goes away.
https://bugs.webkit.org/show_bug.cgi?id=67645

Patch by Varun Jain <varunjain@google.com> on 2011-09-08
Reviewed by Dimitri Glazkov.

Source/WebCore/page/EventHandler.cpp:
Source/WebCore/platform/PlatformGestureEvent.h:

11:28 AM Changeset in webkit [94771] by commit-queue@webkit.org

9 edits
2 adds in trunk

Implement a ProgressEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67537

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ProgressEvent constructor is here:
http://www.w3.org/TR/progress-events/#interface-progressevent

Test: fast/events/constructors/progress-event-constructor.html

bindings/generic/EventConstructors.h: Added a definition for the ProgressEvent constructor.
bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Converts an ECMA-262 Number into an IDL unsigned long long value. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long

bindings/js/JSEventConstructors.cpp: Added #includes for ProgressEvent.
dom/ProgressEvent.cpp:

(WebCore::ProgressEventInit::ProgressEventInit):
(WebCore::ProgressEvent::ProgressEvent):

dom/ProgressEvent.h: Added a definition for ProgressEventInit.

(WebCore::ProgressEvent::create):

dom/ProgressEvent.idl: Makes ProgressEvent constructible.

LayoutTests:

fast/events/constructors/progress-event-constructor-expected.txt: Added.
fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.

11:22 AM Changeset in webkit [94770] by Nate Chapin

1 edit
1 add
3 deletes in trunk/LayoutTests

2011-09-08 Nate Chapin <Nate Chapin>

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-05-f.svg text for chromium win/linux.

platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Removed.
platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

11:18 AM Changeset in webkit [94769] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Test how animation methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-08
Reviewed by Darin Adler.

fast/animation/request-animation-frame-missing-arguments-expected.txt: Added.
fast/animation/request-animation-frame-missing-arguments.html: Added.

11:14 AM Changeset in webkit [94768] by hayato@chromium.org

1 edit
2 adds in trunk/LayoutTests

Add a layout test for the case where an accesskey is defined in shadow DOM.

https://bugs.webkit.org/show_bug.cgi?id=67096

Reviewed by Dimitri Glazkov.

fast/dom/shadow/access-key-expected.txt: Added.
fast/dom/shadow/access-key.html: Added.

11:05 AM Changeset in webkit [94767] by ap@apple.com

5 edits in trunk/LayoutTests

Some file-url-mimetypes subtests fail on rare extensions
https://bugs.webkit.org/show_bug.cgi?id=67679

Reviewed by Darin Adler.

platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
platform/mac/fast/loader/file-url-mimetypes-2.html:
platform/mac/fast/loader/file-url-mimetypes-expected.txt:
platform/mac/fast/loader/file-url-mimetypes.html:

It doesn't appear important to investigate why a few subtests fail on some machines, so
just removing those.

10:41 AM Changeset in webkit [94766] by rniwa@webkit.org

9 edits in trunk/Source/WebCore

Make bindings tests quiet after r94701.

bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObjPrototype::JSTestObjPrototype):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

10:18 AM Changeset in webkit [94765] by ap@apple.com

4 edits in trunk/LayoutTests

Some cookie related tests fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=67674

Reviewed by Mark Rowe.

Use private browsing mode to work around a CFNetwork issue where these tests can affect each
other's results. This should not affect their behavior in any other way.

http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
http/tests/security/cookies/third-party-cookie-blocking.html:

10:09 AM Changeset in webkit [94764] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=67781

Unreviewed rebaseline for Mac.

platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

9:56 AM Changeset in webkit [94763] by Nate Chapin

2 edits
1 add in trunk/LayoutTests

2011-09-08 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations tweaks.

platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
platform/chromium/test_expectations.txt:

9:38 AM Changeset in webkit [94762] by podivilov@chromium.org

6 edits
1 delete in trunk

Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=67717

Source/WebCore:

Listen to SourceMappingUpdated event instead of using createSourceMappingIfNeeded.

Reviewed by Yury Semikhatsky.

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):

inspector/front-end/SourceFile.js:

LayoutTests:

Merge source-file.html into raw-source-code.html.

Reviewed by Yury Semikhatsky.

inspector/debugger/raw-source-code.html:
inspector/debugger/source-file.html: Removed.

9:03 AM Changeset in webkit [94761] by caryclark@google.com

1 edit
1 delete in trunk/LayoutTests

Unreviewed; removed one erroneous baseline (Skia on Mac)

platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed.

8:45 AM WebKitGtkLayoutTests edited by Philippe Normand

(diff)

8:05 AM Changeset in webkit [94760] by podivilov@chromium.org

7 edits
2 adds in trunk

Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

inspector/debugger/raw-source-code-expected.txt: Added.
inspector/debugger/raw-source-code.html: Added.
inspector/debugger/script-formatter.html:
inspector/debugger/source-file.html:

7:46 AM Changeset in webkit [94759] by caryclark@google.com

11 edits
28 adds
16 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

platform/chromium-mac/http/tests/eventsource: Added.

(remaining files omitted for brevity)

6:58 AM Changeset in webkit [94758] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
https://bugs.webkit.org/show_bug.cgi?id=67711

Reviewed by Yury Semikhatsky.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._promptKeyDown):

6:52 AM Changeset in webkit [94757] by abecsi@webkit.org

4 edits in trunk/Source

[Qt] Build fails with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67778

Reviewed by Csaba Osztrogonác.

Source/ThirdParty/ANGLE:

src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex

to suppress warning and fix the build when using [-Werror=unused-result]

Source/WebCore:

No new tests needed.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].

6:44 AM Changeset in webkit [94756] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening.

platform/qt-mac/Skipped: Skip a new failing test.

5:58 AM Changeset in webkit [94755] by commit-queue@webkit.org

3 edits
6 deletes in trunk

Unreviewed, rolling out r94695.
http://trac.webkit.org/changeset/94695
https://bugs.webkit.org/show_bug.cgi?id=67776

Hitting an assertion on Snow Leopard, Qt, GTK (Requested by
Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionedFloatsNeedRelayout):
(WebCore::RenderBlock::layoutPositionedObjects):

LayoutTests:

fast/block/positioning/absolute-layout-after-image-load-expected.txt: Removed.
fast/block/positioning/absolute-layout-after-image-load.html: Removed.
fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Removed.
fast/block/positioning/positioned-float-layout-after-image-load.html: Removed.
fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Removed.
fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Removed.

5:15 AM Changeset in webkit [94754] by apavlov@chromium.org

63 edits in trunk/Source/WebCore

Unreviewed, strip trailing whitespace in the Web Inspector frontend (*.js and *.css).

inspector/front-end/ApplicationCacheItemsView.js:
inspector/front-end/AuditResultView.js:
inspector/front-end/BinarySearch.js:
inspector/front-end/CSSStyleModel.js:
inspector/front-end/ConsoleMessage.js:
inspector/front-end/ConsoleModel.js:
inspector/front-end/ConsoleView.js:
inspector/front-end/CookieItemsView.js:
inspector/front-end/CookieParser.js:
inspector/front-end/DOMAgent.js:
inspector/front-end/DOMStorage.js:
inspector/front-end/DOMStorageItemsView.js:
inspector/front-end/DataGrid.js:
inspector/front-end/Database.js:
inspector/front-end/DatabaseQueryView.js:
inspector/front-end/DetailedHeapshotGridNodes.js:
inspector/front-end/DetailedHeapshotView.js:
inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/EmptyView.js:
inspector/front-end/EventListenersSidebarPane.js:
inspector/front-end/ExtensionCommon.js:
inspector/front-end/GoToLineDialog.js:
inspector/front-end/HeapSnapshot.js:
inspector/front-end/HeapSnapshotProxy.js:
inspector/front-end/HeapSnapshotWorkerDispatcher.js:
inspector/front-end/ImageView.js:
inspector/front-end/InjectedFakeWorker.js:
inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/MetricsSidebarPane.js:
inspector/front-end/NetworkManager.js:
inspector/front-end/NetworkPanel.js:
inspector/front-end/ObjectPropertiesSection.js:
inspector/front-end/PartialQuickSort.js:
inspector/front-end/ProfileView.js:
inspector/front-end/ProfilesPanel.js:
inspector/front-end/RemoteObject.js:
inspector/front-end/Resource.js:
inspector/front-end/ResourceCategory.js:
inspector/front-end/ResourceHTMLView.js:
inspector/front-end/ResourceHeadersView.js:
inspector/front-end/ResourceJSONView.js:
inspector/front-end/ResourceTimingView.js:
inspector/front-end/ResourceTreeModel.js:
inspector/front-end/ResourceView.js:
inspector/front-end/ResourcesPanel.js:
inspector/front-end/SearchController.js:
inspector/front-end/SettingsScreen.js:
inspector/front-end/ShortcutsScreen.js:
inspector/front-end/SourceCSSTokenizer.js:
inspector/front-end/SourceHTMLTokenizer.js:
inspector/front-end/SourceJavaScriptTokenizer.js:
inspector/front-end/StatusBarButton.js:
inspector/front-end/TextEditorModel.js:
inspector/front-end/TimelineGrid.js:
inspector/front-end/View.js:
inspector/front-end/heapProfiler.css:
inspector/front-end/inspector.css:
inspector/front-end/inspector.js:
inspector/front-end/inspectorSyntaxHighlight.css:
inspector/front-end/networkPanel.css:
inspector/front-end/treeoutline.js:
inspector/front-end/utilities.js:

5:07 AM Changeset in webkit [94753] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

platform/qt/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg, because it fails on 64 bit.

4:36 AM Changeset in webkit [94752] by loislo@chromium.org

3 edits in trunk/LayoutTests

2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rebaseline for chromium.

platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png:

3:16 AM Changeset in webkit [94751] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] fast/css/line-after-floating-div.html fails
https://bugs.webkit.org/show_bug.cgi?id=67772

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip it until fix.

3:11 AM Changeset in webkit [94750] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

Gardening: add missing result after: r94710.
https://bugs.webkit.org/show_bug.cgi?id=67768

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Zoltan Herczeg.

platform/qt/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/qt/fast/text/hyphenate-limit-lines-expected.txt: Added.

1:55 AM Changeset in webkit [94749] by caseq@chromium.org

2 edits in trunk/Source/WebCore

2011-09-07 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
https://bugs.webkit.org/show_bug.cgi?id=67715

Reviewed by Yury Semikhatsky.

avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.

inspector/front-end/TextViewer.js: (WebInspector.TextViewer.forwardWheelEvent): (WebInspector.TextViewer):

1:55 AM Changeset in webkit [94748] by loislo@chromium.org

7 edits
6 adds
1 delete in trunk/LayoutTests

2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Rebaselines for chromium.

platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png:
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Removed.
platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/chromium-linux/fast/css/line-after-floating-div-expected.png:
platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-win/fast/css/line-after-floating-div-expected.png:
platform/chromium-win/fast/css/line-after-floating-div-expected.txt:
platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Added.
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/chromium/test_expectations.txt:

12:30 AM Changeset in webkit [94747] by abarth@webkit.org

1 edit in branches/chromium/874/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

Merge 94721 - FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21. This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6. I would really much
rather include a test with this patch, but my attempts to write a test
have failed. :(

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7846013

12:05 AM Changeset in webkit [94746] by mdelaney@apple.com

3 edits
1 add in trunk/Tools

Add standalone script that filters the output of build-webkit to be more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081

Reviewed by Daniel Bates.

Scripts/filter-build-webkit: Added. Just need to feed it the output of

a build script (e.g. build-webkit) and it spits out a prettier version.

Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"

Sep 7, 2011:

9:31 PM Changeset in webkit [94745] by noel.gordon@gmail.com

2 edits in trunk/Tools

Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=67696

Reviewed by Kent Tamura.

Scripts/webkitpy/common/config/committers.py:

9:03 PM Changeset in webkit [94744] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix typo in test_expectations introduced with r94725
https://bugs.webkit.org/show_bug.cgi?id=67758

image-makering.html -> image-color-matching.html

Patch by Ben Wells <benwells@chromium.org> on 2011-09-07
Reviewed by Ryosuke Niwa.

platform/chromium/test_expectations.txt:

8:39 PM Changeset in webkit [94743] by mitz@apple.com

1 edit
1 add in trunk/LayoutTests

Added Snow Leopard results for this new test.

platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.

8:00 PM Changeset in webkit [94742] by commit-queue@webkit.org

7 edits
2 deletes in trunk

Unreviewed, rolling out r94674 and r94689.
http://trac.webkit.org/changeset/94674
http://trac.webkit.org/changeset/94689
https://bugs.webkit.org/show_bug.cgi?id=67754

Broke inspector/debugger/script-formatter.html (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

inspector/front-end/SourceFile.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

inspector/debugger/raw-source-code-expected.txt: Removed.
inspector/debugger/raw-source-code.html: Removed.
inspector/debugger/script-formatter.html:
inspector/debugger/source-file.html:

6:38 PM Changeset in webkit [94741] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

offsetFromRoot optimization is disabled after r93837
https://bugs.webkit.org/show_bug.cgi?id=67677

Reviewed by Simon Fraser.

Unfortunately not covered by any test as it does not change updateLayerPosition complexity (it is still O(n^{2)

because of clippedOverflowRectForRepaint). However it is a noticeable slowdown on some use cases but we don't

have a good test harness to cover such slowdown.}

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions): Pass offsetFromRoot as not doing so means that we miss
the optimization altogether.

(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

rendering/RenderLayer.h:

Renamed |cachedOffset| to |offsetFromRoot| to be consistent with our latest renaming.

6:31 PM Changeset in webkit [94740] by rniwa@webkit.org

1 edit in trunk/Source/WebCore/rendering/RenderBlock.cpp

Fix my commit per darin's suggestion.

6:27 PM Changeset in webkit [94739] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Windows build fix after r94737.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):

5:55 PM Changeset in webkit [94738] by mitz@apple.com

2 edits in trunk/Source/WebCore

Removed hyphenation function implementations for an usupported build configuration.

Reviewed by Sam Weinig.

platform/text/cf/HyphenationCF.cpp:

5:50 PM Changeset in webkit [94737] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67739

adjustRectForColumns is O(# of columns) when it can be O(1). Fix the slow performance of this
function by removing the loop and just computing the start and end column for a repaint rect
and uniting everything in between.

Reviewed by Dan Bernstein.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):

5:26 PM Changeset in webkit [94736] by abarth@webkit.org

8 edits
8 adds
4 deletes in trunk/LayoutTests

Update baselines for svg/as-background-image. These results all appear
correct and test_expectations indicates that they just need new
baselines.

platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-win-vista/svg/as-background-image: Added.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Added.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Added.
platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium/test_expectations.txt:
platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
svg/as-background-image/animated-svg-as-background-expected.txt: Added.
svg/as-background-image/svg-as-background-1-expected.txt: Added.
svg/as-background-image/svg-as-background-3-expected.txt: Added.
svg/as-background-image/svg-as-background-5-expected.txt: Added.

5:18 PM Changeset in webkit [94735] by abarth@webkit.org

2 edits
4 adds in trunk/LayoutTests

These tests just differ in how JSC and V8 report error messages.

platform/chromium-cg-mac-leopard/http/tests/security: Added.
platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:13 PM Changeset in webkit [94734] by abarth@webkit.org

2 edits
2 adds in trunk/LayoutTests

Our results here reflect an intentional difference between GURL and
KURL. KURL doesn't handle non-ASCII characters in the fragment in the
same was as IE whereas GURL does.

platform/chromium/http/tests/uri: Added.
platform/chromium/http/tests/uri/resolve-encoding-relative-expected.txt: Added.
platform/chromium/test_expectations.txt:

5:01 PM Changeset in webkit [94733] by abarth@webkit.org

2 edits
2 adds in trunk/LayoutTests

Our behavior is correct with respect to the new cookie RFC. I'm told
that CFNetwork is going to change this behavior to match every other
browser.

platform/chromium/http/tests/cookies: Added.
platform/chromium/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:51 PM Changeset in webkit [94732] by commit-queue@webkit.org

22 edits
6 deletes in trunk

Unreviewed, rolling out r94714 and r94723.
http://trac.webkit.org/changeset/94714
http://trac.webkit.org/changeset/94723
https://bugs.webkit.org/show_bug.cgi?id=67746

breaks gtk-linux tests with assertion failure (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::inTransparencyLayer):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::getWindowsContext):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):

platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):

rendering/RenderThemeWin.cpp:

(WebCore::drawControl):

LayoutTests:

platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Removed.
platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Removed.
platform/chromium-win/svg/custom/simple-text-double-shadow.png: Removed.
platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
svg/custom/simple-text-double-shadow.svg: Removed.

4:48 PM Changeset in webkit [94731] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PPC build fix.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

4:48 PM Changeset in webkit [94730] by abarth@webkit.org

2 edits
1 add
3 deletes in trunk/LayoutTests

Update results. The actual results are only off by a fraction of a
pixel around the curve in the zero.

platform/chromium-cg-mac/media/audio-repaint-expected.txt: Removed.
platform/chromium-mac/media/audio-repaint-expected.txt: Removed.
platform/chromium-win-xp/media: Removed.
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium/media/audio-repaint-expected.txt: Added.

4:43 PM Changeset in webkit [94729] by abarth@webkit.org

8 edits in trunk/LayoutTests

These results are also off by just factional pixels.

platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

4:38 PM Changeset in webkit [94728] by abarth@webkit.org

11 edits
1 add in trunk/LayoutTests

These results all differ only in less than one pixel border or text rendering.

platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
platform/chromium-cg-mac/tables/mozilla/bugs/bug82946-2-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2886-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug6674-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2886-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug6674-expected.png:

4:35 PM Changeset in webkit [94727] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Mac baseline for the test added by r94331.

platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

4:26 PM Changeset in webkit [94726] by rniwa@webkit.org

4 edits in trunk/LayoutTests

Rebaseline for r94710.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

4:25 PM Changeset in webkit [94725] by Nate Chapin

25 edits
9 adds
3 deletes in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium svg/ rebaselines.

platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-cg-mac-leopard/svg/batik/filters/feTile-expected.png:
platform/chromium-cg-mac-leopard/svg/batik/text/textFeatures-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-cg-mac-leopard/svg/filters/filterRes-expected.png:
platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-cg-mac/svg/batik/filters/feTile-expected.png:
platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png:
platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
platform/chromium-cg-mac/svg/custom/feComponentTransfer-Linear-expected.png:
platform/chromium-cg-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-cg-mac/svg/filters/filterRes-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Removed.
platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-win-vista/svg/filters: Removed.
platform/chromium-win-xp/svg/css: Removed.
platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-win/svg/filters/filterRes-expected.png:
platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [94724] by rniwa@webkit.org

5 edits
2 moves in trunk/LayoutTests

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.

Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

css2.1/t090204-display-change-01-b-ao.html:
fast/css/line-after-floating-div-expected.png: Removed.
fast/css/line-after-floating-div-expected.txt: Removed.
fast/css/line-after-floating-div.html:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
platform/mac/fast/css/line-after-floating-div-expected.png: Copied from

LayoutTests/fast/css/line-after-floating-div-expected.png.

platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from

LayoutTests/fast/css/line-after-floating-div-expected.txt.

4:10 PM Changeset in webkit [94723] by timothy_horton@apple.com

1 edit
3 adds in trunk/LayoutTests

Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Added.
platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Added.
platform/chromium-win/svg/custom/simple-text-double-shadow.png: Added.

4:08 PM Changeset in webkit [94722] by abarth@webkit.org

6 edits in trunk/Tools

rebaseline button in garden-o-matic details view should work
https://bugs.webkit.org/show_bug.cgi?id=67738

Reviewed by Dimitri Glazkov.

This patch wires up the rebaseline button in garden-o-matic results
details view. The button is current per-test, so there isn't a way to
rebaseline individual bots. This is a place to start. If we decide we
want per-bot rebaselining, we'll need to think of some better UI.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

3:54 PM Changeset in webkit [94721] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::loadFrameRequest):

3:49 PM Changeset in webkit [94720] by Nate Chapin

3 edits
7 adds
3 deletes in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium fast/css/ rebaslines.

platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Added.
platform/chromium-linux/fast/css/getComputedStyle: Removed.
platform/chromium-linux/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/css/line-after-floating-div-expected.png: Added.
platform/chromium-win/fast/css/line-after-floating-div-expected.txt: Added.

3:23 PM Changeset in webkit [94719] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, patch up some chromium gpu expectations
that are failing on the cg mac builds.

platform/chromium/test_expectations.txt:

3:19 PM Changeset in webkit [94718] by eric@webkit.org

5 edits in trunk/Tools

Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
https://bugs.webkit.org/show_bug.cgi?id=67737

Reviewed by Adam Barth.

I got a little over-eager when deprecating host.port_factory in the previous commit.
Turns out that Host.port_factory was already the "modern" port/factory.py
it was just the Module object. I un-deprecated the variable, and changed it from
being the module to being an actual PortFactory, passing it a host object.
I also taught PortFactory how to set user/executive/filesystem in the kwargs
when instantiating a new Port object.
This magically fixed the test_rebaseline test, since its now no longer talking
to the real filesystem.

Scripts/webkitpy/common/host.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/mocktool.py:

2:44 PM Changeset in webkit [94717] by eric@webkit.org

5 edits in trunk/Tools

Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
https://bugs.webkit.org/show_bug.cgi?id=67734

Reviewed by Adam Barth.

Right now every place that creates a Port object has to be very careful
to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
The correct fix is for port/factory.py (which creates most port objects)
to know how to pass these in automatically. However, currently all port/factory.py
functions are free functions instead of being on an object. This patch
adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.

In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
pass along the proper scm/user/filesystem to the Port object.

Scripts/webkitpy/common/host.py:
Scripts/webkitpy/layout_tests/port/factory.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/mocktool.py:

2:42 PM Changeset in webkit [94716] by Chris Fleizach

4 edits
2 adds in trunk

Changes to aria-hidden don't change VO navigation
https://bugs.webkit.org/show_bug.cgi?id=67722

Reviewed by Darin Adler.

Source/WebCore:

When altering aria-hidden, WebCore needs to update the children caches of
affected elements. However, for elements that were children, but ignored, their
caches did not get updated, and stale information would be propagated.

The fix is to always clearChildren() when a parent is asking for children. This
ensures information is always up to date when the parent itself is asking for new data.

Test: accessibility/aria-hidden-updates-alldescendants.html

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

accessibility/aria-hidden-updates-alldescendants-expected.txt: Added.
accessibility/aria-hidden-updates-alldescendants.html: Added.

2:39 PM Changeset in webkit [94715] by Nate Chapin

2 edits
2 adds in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, upstream some chromium expected failure after skia roll,
and rebaseline 2 tests for leopard cg.

platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
platform/chromium/test_expectations.txt:

2:35 PM Changeset in webkit [94714] by timothy_horton@apple.com

22 edits
3 adds in trunk

Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Simon Fraser.

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

platform/graphics/GraphicsContext.cpp:

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/qt/GraphicsContextQt.cpp:

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::releaseWindowsContext):

platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::getWindowsContext):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):

platform/win/ScrollbarThemeWin.cpp:
plugins/win/PluginViewWin.cpp:
rendering/RenderThemeWin.cpp:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
svg/custom/simple-text-double-shadow.svg: Added.

2:10 PM Changeset in webkit [94713] by abarth@webkit.org

3 edits in branches/chromium/835/Source/WebKit/chromium/src

Merge 94102 - [Chromium] Add null checks for document()->loader()
https://bugs.webkit.org/show_bug.cgi?id=67077

Reviewed by Nate Chapin.

Document::loader can return 0 for a number of reasons. Call sites need
to null check the result, like we do for Document::frame. I suspect
some of these are real crashes, along the lines of
http://trac.webkit.org/changeset/93692, but null checking this function
is just good practice.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

src/WebSearchableFormData.cpp:

(HTMLNames::GetFormEncoding):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::pageEncoding):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/7782040

2:04 PM Changeset in webkit [94712] by Nate Chapin

2 edits in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.
Make the WONTFIX WIN LINUX for platform/chromium/rubberbanding/
FAIL instead of IMAGE, so it's less likely to flake out.

platform/chromium/test_expectations.txt:

2:01 PM Changeset in webkit [94711] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add the forgotten expected results for r94696.

fast/css/line-after-floating-div-expected.png: Added.
fast/css/line-after-floating-div-expected.txt: Added.

1:59 PM Changeset in webkit [94710] by mitz@apple.com

14 edits
5 adds in trunk

<rdar://problem/8881922> Support the hyphenate-limit-lines property
https://bugs.webkit.org/show_bug.cgi?id=67730

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/css/parsing-hyphenate-limit-lines.html

fast/text/hyphenate-limit-lines.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added hyphenate-limit-lines.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto. Valid values are non-negative integers and the keyword
"no-limit".

css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-lines.
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Added hyphenate-limit-lines.

css/CSSValueKeywords.in: Added the "no-limit" value keyword.
rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats): Count the number of consecutive hyphenated lines
before the start line and pass it to layoutRunsAndFloatsInRange().
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Keep track of the number of consecutive
hyphenated lines before the current line and pass it to LineBreaker::nextLineBreak().
(WebCore::tryHyphenating): Added parameters for the number of consecutive hyphenated lines before
the current line and the limit on consecutive hyphenated lines, and an early return if the limit
has been reached.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Added a parameter for the number of consecutive
hyphenated lines before the current line, which is passed through to tryHyphenating, along with
the value of hyphenate-limit-lines.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::isHyphenated): Added. Returns true if the line was hyphenated.

rendering/RootInlineBox.h:
rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphenationLimitLines): Added this getter.
(WebCore::InheritedFlags::setHyphenationLimitLines): Added this setter.
(WebCore::InheritedFlags::initialHyphenationLimitLines): Added. The initial value is -1,
corresponding to "no-limit".

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize new member variable.
(WebCore::StyleRareInheritedData::operator==): Compare new member variable.

rendering/style/StyleRareInheritedData.h:

LayoutTests:

fast/css/parsing-hyphenate-limit-lines-expected.txt: Added.
fast/css/parsing-hyphenate-limit-lines.html: Added.
fast/text/hyphenate-limit-lines.html: Added.
platform/mac/fast/text/hyphenate-limit-lines-expected.png: Added.
platform/mac/fast/text/hyphenate-limit-lines-expected.txt: Added.

1:58 PM Changeset in webkit [94709] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r94697.

platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

1:56 PM Changeset in webkit [94708] by Nate Chapin

5 edits
1 delete in trunk/LayoutTests

2011-09-07 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

platform/chromium-cg-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-cg-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-win-xp/svg/transforms: Removed.
platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium/test_expectations.txt:

1:56 PM Changeset in webkit [94707] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r94441.
http://trac.webkit.org/changeset/94441
https://bugs.webkit.org/show_bug.cgi?id=67731

"MacEWSes are backed up due to new machines not able to reach
git.webkit.org. Disabling tests for now" (Requested by
eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

1:18 PM Changeset in webkit [94706] by ojan@chromium.org

10 edits in trunk/Source/WebCore

split overrideSize into overrideHeight and overrideWidth
https://bugs.webkit.org/show_bug.cgi?id=67550

Reviewed by Sam Weinig.

All uses of overrideSize only set one of the width or the height.
This change removes a bool from RenderObject and removes some
flexbox specific logic from RenderBox.

The only downside is that we have two global maps where we used
to have one.

No functional changes so existing tests are sufficient.

rendering/RenderBox.cpp:

(WebCore::RenderBox::hasOverrideHeight):
(WebCore::RenderBox::hasOverrideWidth):
(WebCore::RenderBox::setOverrideHeight):
(WebCore::RenderBox::setOverrideWidth):
(WebCore::RenderBox::clearOverrideSize):
(WebCore::RenderBox::overrideWidth):
(WebCore::RenderBox::overrideHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):

rendering/RenderBox.h:
rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):

rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

rendering/RenderObject.h:
rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

rendering/RenderTableCell.h:
rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

1:13 PM Changeset in webkit [94705] by commit-queue@webkit.org

14 edits
25 adds in trunk

Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
https://bugs.webkit.org/show_bug.cgi?id=67511

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-07
Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore:

Tests: platform/chromium-mac/rubberbanding/overhang-e.html

platform/chromium-mac/rubberbanding/overhang-n.html
platform/chromium-mac/rubberbanding/overhang-ne.html
platform/chromium-mac/rubberbanding/overhang-nw.html
platform/chromium-mac/rubberbanding/overhang-s.html
platform/chromium-mac/rubberbanding/overhang-se.html
platform/chromium-mac/rubberbanding/overhang-sw.html
platform/chromium-mac/rubberbanding/overhang-w.html

WebCore.exp.in:
platform/ScrollableArea.h:
testing/Internals.cpp:

(WebCore::Internals::setScrollViewPosition):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

platform/chromium-mac/rubberbanding: Added.
platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-e.html: Added.
platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-n.html: Added.
platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-s.html: Added.
platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-se.html: Added.
platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
platform/chromium-mac/rubberbanding/overhang-w.html: Added.

1:06 PM Changeset in webkit [94704] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Release mode build fix.

1:00 PM Changeset in webkit [94703] by commit-queue@webkit.org

30 edits
2 adds in trunk

[Chromium] Render surface anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=66437

Patch by David Reveman <reveman@chromium.org> on 2011-09-07
Reviewed by James Robinson.

Source/WebCore:

Add CCLayerQuad class and CCLayerQuad::Edge subclass to allow
edge computations to be shared between tiled layers and render
surfaces. Move isCCW utility function to FloatQuad class and
add to2dTransform method to TransformationMatrix class. Add
necessary anti-aliasing shaders for render surfaces and use them
to avoid aliased edges.

Tests: compositing/reflections/nested-reflection-transformed.html (existing)

WebCore.gypi:
platform/graphics/FloatQuad.cpp:

(WebCore::FloatQuad::isCounterclockwise):

platform/graphics/FloatQuad.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::drawTexturedQuad):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgram):
(WebCore::LayerRendererChromium::renderSurfaceProgramAA):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgram):
(WebCore::LayerRendererChromium::renderSurfaceMaskProgramAA):
(WebCore::LayerRendererChromium::tilerProgramSwizzle):
(WebCore::LayerRendererChromium::canvasLayerProgram):
(WebCore::LayerRendererChromium::pluginLayerProgram):
(WebCore::LayerRendererChromium::videoLayerRGBAProgram):
(WebCore::LayerRendererChromium::videoLayerYUVProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::sharedGeometryQuad):

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderQuad::VertexShaderQuad):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderQuad::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaAA::FragmentShaderRGBATexAlphaAA):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentTexClampAlphaAABinding::FragmentTexClampAlphaAABinding):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::FragmentShaderRGBATexAlphaMaskAA):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

platform/graphics/chromium/ShaderChromium.h:

(WebCore::VertexShaderQuad::matrixLocation):
(WebCore::VertexShaderQuad::pointLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaAA::edgeLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::alphaLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::samplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::maskSamplerLocation):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::edgeLocation):

platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::draw):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

platform/graphics/chromium/cc/CCLayerQuad.cpp: Added.

(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::floatQuad):
(WebCore::CCLayerQuad::toFloatArray):

platform/graphics/chromium/cc/CCLayerQuad.h: Added.

(WebCore::CCLayerQuad::Edge::Edge):
(WebCore::CCLayerQuad::Edge::x):
(WebCore::CCLayerQuad::Edge::y):
(WebCore::CCLayerQuad::Edge::z):
(WebCore::CCLayerQuad::Edge::setX):
(WebCore::CCLayerQuad::Edge::setY):
(WebCore::CCLayerQuad::Edge::setZ):
(WebCore::CCLayerQuad::Edge::set):
(WebCore::CCLayerQuad::Edge::moveX):
(WebCore::CCLayerQuad::Edge::moveY):
(WebCore::CCLayerQuad::Edge::moveZ):
(WebCore::CCLayerQuad::Edge::move):
(WebCore::CCLayerQuad::Edge::scaleX):
(WebCore::CCLayerQuad::Edge::scaleY):
(WebCore::CCLayerQuad::Edge::scaleZ):
(WebCore::CCLayerQuad::Edge::scale):
(WebCore::CCLayerQuad::Edge::intersect):
(WebCore::CCLayerQuad::CCLayerQuad):
(WebCore::CCLayerQuad::left):
(WebCore::CCLayerQuad::top):
(WebCore::CCLayerQuad::right):
(WebCore::CCLayerQuad::bottom):
(WebCore::CCLayerQuad::inflateX):
(WebCore::CCLayerQuad::inflateY):
(WebCore::CCLayerQuad::inflate):
(WebCore::CCLayerQuad::inflateAntiAliasingDistance):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

platform/graphics/chromium/cc/CCRenderSurface.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:
platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::to2dTransform):

platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
platform/chromium-gpu-linux/compositing/scaling/tiled-layer-recursion-expected.png:
platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
platform/chromium-gpu-linux/media/video-transformed-expected.png:
platform/chromium/test_expectations.txt:

12:51 PM Changeset in webkit [94702] by xji@chromium.org

2 edits in trunk/LayoutTests

Rebaseline after r93935.

platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

12:40 PM Changeset in webkit [94701] by oliver@apple.com

55 edits
2 deletes in trunk/Source

Remove JSObjectWithGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=67689

Reviewed by Geoff Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Remove JSObjectWithGlobalObject, and update code to stop using anonymous
storage to access the global object that a JSObject comes from. Largely
mechanical change to remove the use of anonymous storage and JSObjectWithGlobalObject.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):
(JSC::JSCallbackConstructor::finishCreation):

API/JSCallbackConstructor.h:
API/JSCallbackObject.cpp:
API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

API/JSCallbackObjectFunctions.h:

(JSC::::JSCallbackObject):
(JSC::::finishCreation):
(JSC::::staticFunctionGetter):

API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

API/JSValueRef.cpp:

(JSValueIsObjectOfClass):

API/JSWeakObjectMapRefPrivate.cpp:
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:
dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):

jit/JIT.h:
jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSFunction):

jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/DatePrototype.cpp:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):
(JSC::InternalFunction::finishCreation):

runtime/InternalFunction.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::finishCreation):

runtime/JSFunction.h:

(JSC::JSFunction::create):
(JSC::JSFunction::createStructure):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):

runtime/JSONObject.h:
runtime/JSObject.h:

(JSC::JSObject::globalObject):

runtime/JSObjectWithGlobalObject.cpp: Removed.
runtime/JSObjectWithGlobalObject.h: Removed.
runtime/JSValue.cpp:

(JSC::JSValue::isValidCallee):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/Lookup.h:
runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::MathObject::finishCreation):

runtime/MathObject.h:
runtime/NumberPrototype.cpp:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::finishCreation):

runtime/RegExpObject.h:
runtime/Structure.cpp:

(JSC::Structure::Structure):

runtime/Structure.h:

(JSC::Structure::create):
(JSC::Structure::globalObject):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Remove use of anonymous storage and JSObjectWithGlobalObject for
accessing a JSObject's global object now that they're available
on the object's structure.

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
(JSC::Bindings::ObjcFallbackObjectImp::finishCreation):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):

bridge/runtime_object.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebKit2:

Remove JSObjectWithGlobalObject usage.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::finishCreation):

WebProcess/Plugins/Netscape/JSNPObject.h:

12:31 PM Changeset in webkit [94700] by commit-queue@webkit.org

8 edits in trunk

Tools: filter test_expectations properly for chromium-mac vs chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
Scripts/webkitpy/layout_tests/port/factory_unittest.py:

LayoutTests: now that layout tests distinguish between Core Graphics and Skia
expectations, update test_expectations accordingly.
https://bugs.webkit.org/show_bug.cgi?id=67324

Patch by Elliot Poger <epoger@google.com> on 2011-09-07
Reviewed by Dirk Pranke.

platform/chromium/test_expectations.txt:

12:30 PM UsingGitWithWebKit edited by dpranke@chromium.org

(diff)

12:29 PM Changeset in webkit [94699] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Mac build fix after r94694.

WebCore.xcodeproj/project.pbxproj:

12:27 PM Changeset in webkit [94698] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

FELighting is using width instead of height to determine skip for parallel(n>2) case
https://bugs.webkit.org/show_bug.cgi?id=67719
<rdar://problem/10086178>

Reviewed by Dirk Schulze.

No new tests, because the bug only exhibits under conditions which are currently
impossible by default (using more than 2 cores) on some platforms.

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplyGeneric):

12:20 PM Changeset in webkit [94697] by wjmaclean@chromium.org

9 edits
5 adds in trunk

Eliminate motion jitter in animated, blurred SVG image
https://bugs.webkit.org/show_bug.cgi?id=67503

Fixes filter shear-free transform applied to SVG images.

Source/WebCore:

In applyResource() the shearFreeAbsoluteTransform is applied to the drawing region,
which is based on the object bounding box (which doesn't move). For a rotation
around the centre of the box, this should really just be the identity matrix,
since the BB should neither change size nor location. So really, we're just interested
in the scale change of the BB here, and not in moving it.

This impacts how slices are extracted, and affects the {x|y}Mid and {x|y}Max extractions
for vertical and horizontal slices, so the test verifies these.

Reviewed by Dirk Schulze.

Test: svg/W3C-SVG-1.1-SE/filters-image-05-f.svg

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

Reviewed by Dirk Schulze.

platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-linux/svg/filters/filterRes-expected.png:
platform/chromium-linux/svg/filters/filterRes-expected.txt: Added.
platform/chromium/test_expectations.txt:
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg: Added.

12:14 PM Changeset in webkit [94696] by rniwa@webkit.org

4 edits
1 copy in trunk/LayoutTests

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by David Hyatt.

Fixed the test to properly attach load event listener on window instead of document.

Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.

css2.1/t090204-display-change-01-b-ao.html:
fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:

11:59 AM Changeset in webkit [94695] by robert@webkit.org

3 edits
6 adds in trunk

Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html

fast/block/positioning/positioned-float-layout-after-image-load.html

In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check. Do the same
for positioned floats in RenderBlock::positionedFloatsNeedRelayout(), although currently layoutPositionedObjects()
takes care of it this at least ensures no regression in future.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when

deciding whether to mark children for layout

(WebCore::RenderBlock::positionedFloatsNeedRelayout): ditto

LayoutTests:

fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
fast/block/positioning/absolute-layout-after-image-load.html: Added.
fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.
fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Added.
fast/block/positioning/positioned-float-layout-after-image-load.html: Added.
fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Added.

11:50 AM Changeset in webkit [94694] by commit-queue@webkit.org

8 edits
8 moves
1 add in trunk/Source/WebCore

Moving platform/track to html/track to avoid layering violation.
https://bugs.webkit.org/show_bug.cgi?id=67680

Patch by Anna Cavender <annacc@chromium.org> on 2011-09-07
Reviewed by Adam Barth.

No new tests. No new functionality.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
html/track/CueParser.cpp: Renamed from Source/WebCore/platform/track/CueParser.cpp.
html/track/CueParser.h: Renamed from Source/WebCore/platform/track/CueParser.h.
html/track/CueParserPrivate.h: Renamed from Source/WebCore/platform/track/CueParserPrivate.h.
html/track/WebVTTParser.cpp: Renamed from Source/WebCore/platform/track/WebVTTParser.cpp.
html/track/WebVTTParser.h: Renamed from Source/WebCore/platform/track/WebVTTParser.h.
html/track/WebVTTToken.h: Renamed from Source/WebCore/platform/track/WebVTTToken.h.
html/track/WebVTTTokenizer.cpp: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.cpp.
html/track/WebVTTTokenizer.h: Renamed from Source/WebCore/platform/track/WebVTTTokenizer.h.

11:48 AM Changeset in webkit [94693] by hyatt@apple.com

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67286

REGRESSION: css2.1/t090204-display-change-01-b-ao.html fails after r94084.

Make sure that the trailing floats line box explicitly sets the line top with leading and line bottom with
leading to just be the block height.

Reviewed by Dan Bernstein.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::linkToEndLineIfNeeded):

11:32 AM Changeset in webkit [94692] by abarth@webkit.org

7 edits in trunk

[Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=66800

Patch by Eric Boren <borenet@gmail.com> on 2011-09-07
Reviewed by Darin Fisher.

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):

src/WebInputEventConversion.h:

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

11:16 AM Changeset in webkit [94691] by inferno@chromium.org

1 edit in branches/chromium/835/Source/WebCore/rendering/RenderScrollbar.cpp

Merge 94690 - Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
BUG=95552
Review URL: http://codereview.chromium.org/7782035

11:15 AM Changeset in webkit [94690] by inferno@chromium.org

2 edits in trunk/Source/WebCore

Null owningRenderer crash in RenderScrollbar::updateScrollbarParts.
https://bugs.webkit.org/show_bug.cgi?id=67669

Reviewed by James Robinson.

Owning renderer can be cleared for custom scrollbars in clearOwningRenderer()
call. We need a null check in updateScrollbarParts, so that we do not crash.

No tests since issue seen in crash reports only and I donot know a way to
reproduce.

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarParts):

11:14 AM Changeset in webkit [94689] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2011-09-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix after r94674.

inspector/debugger/script-formatter.html:

10:55 AM Changeset in webkit [94688] by barraclough@apple.com

9 edits in trunk/Source/JavaScriptCore

Refactor JIT checks for ObjectType into helper functions.

Rubber stamped by Sam Weinig.

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchIfNotObject):

dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JIT.h:
jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret_object_or_this):

jit/JITInlineMethods.h:

(JSC::JIT::emitJumpIfNotObject):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_this):

10:55 AM Changeset in webkit [94687] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip media/media-controls-invalid-url.html on Mac for now because it has been failing.
The failure is tracked by the bug 67716.

platform/mac/Skipped:

10:41 AM Changeset in webkit [94686] by rniwa@webkit.org

1 edit
1 copy in trunk/LayoutTests

Finally, Mac rebaseline for r93237.

platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Copied from

LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt.

10:35 AM Changeset in webkit [94685] by jocelyn.turcotte@nokia.com

19 edits in trunk/Source

[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to.
https://bugs.webkit.org/show_bug.cgi?id=67606

Source/WebCore:

Reviewed by Noam Rosenthal.

TiledBackingStore previously used different values for horizontal and vertial multiplication
to calculate the cover area.
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
of the viewport.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setKeepAndCoverAreaMultipliers):
(WebCore::TiledBackingStore::setCoverAreaFocusVector):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::calculateKeepRect):
(WebCore::TiledBackingStore::calculateCoverRect):

platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::getKeepAndCoverAreaMultipliers):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

Source/WebKit2:

UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportMotionVectorChanged):

UIProcess/API/qt/qtouchwebview.h:
UIProcess/API/qt/qtouchwebview_p.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::setVisibleContentRectMotionVector):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):

UIProcess/qt/ViewportInteractionEngine.h:
UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRectMotionVector):

UIProcess/qt/qtouchwebpageproxy.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRectMotionVector):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectMotionVector):

WebProcess/WebPage/TiledDrawingArea.h:

10:34 AM Changeset in webkit [94684] by rniwa@webkit.org

1 edit
1 copy in trunk/LayoutTests

Fix my accidental svn mv (instead of cp) in r94680.

fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from

LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt.

10:34 AM Changeset in webkit [94683] by Dimitri Glazkov

1 add in branches/chromium/874/codereview.settings

Added codereview.settings to 874 branch.

10:30 AM Changeset in webkit [94682] by Dimitri Glazkov

1 copy in branches/chromium/874

Branched for Chromium 874.

10:19 AM Changeset in webkit [94681] by jocelyn.turcotte@nokia.com

9 edits in trunk/Source

[Qt] TiledBackingStore: Import the resizeEdgeTiles logic from TiledDrawindAreaProxy.
https://bugs.webkit.org/show_bug.cgi?id=67416

Reviewed by Kenneth Rohde Christiansen.

Original code by Antti Koivisto.
With the current code, when the page is layouted during load, edge tiles will
get removed instead of continuing to show their front buffer while the tile
is being rendered for the new size.

Source/WebCore:

platform/graphics/Tile.h:
platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):

platform/graphics/TiledBackingStore.h:
platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::resize):

platform/graphics/qt/TileQt.h:

Source/WebKit2:

WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):
(WebKit::TiledBackingStoreRemoteTile::resize):

WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

10:17 AM Changeset in webkit [94680] by rniwa@webkit.org

1 edit
1 move in trunk/LayoutTests

GTK+ rebaseline after r94357. GTK+ port apparently implements PeerConnection.

fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt: Copied from

LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt.

10:17 AM Changeset in webkit [94679] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Don't round-trip through TransformationMatrix in SVGImageBufferTools::clearAffineTransform2DRotation
https://bugs.webkit.org/show_bug.cgi?id=67242
<rdar://problem/10069770>

Reviewed by Dirk Schulze.

No new tests, minor performance improvement.

platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::blend):
(WebCore::AffineTransform::decompose):
(WebCore::AffineTransform::recompose):

platform/graphics/transforms/AffineTransform.h:
rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clear2DRotation):

10:07 AM Changeset in webkit [94678] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

TiledDrawingArea: Fix issues where the tiles of the previous scale would be removed too early.
https://bugs.webkit.org/show_bug.cgi?id=67390

Reviewed by Tor Arne Vestbø.

The two issues addresssed are:

The previous instance of the tile backing store would be destroyed in createTile which would send removeTile messages for all its tiles before the DidRenderFrame message is sent for the new tiles.
When quickly changing the scale a second time after a scale change, the previous tile set would be replaced by the current incomplete tile set which may contain no tiles at all.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):
(WebKit::TiledDrawingArea::createTile):

10:05 AM Changeset in webkit [94677] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Skip accessibility/textbox-role-reports-selection.html on GTK+ bots because it has been failing.
The failure is tracked by the bug 67713.

platform/gtk/Skipped:

10:04 AM Changeset in webkit [94676] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::pathToLocalResource):
(LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource

9:43 AM Changeset in webkit [94675] by jocelyn.turcotte@nokia.com

3 edits in trunk/Source/WebKit2

[Qt][WK2] The scene graph is rendered continuously even when the page is idle.
https://bugs.webkit.org/show_bug.cgi?id=67195

Reviewed by Tor Arne Vestbø.

Since tiledBackingStorePaintEnd is called even when no tile is dirty, the TiledDrawingArea
and its proxy are looping over DidRenderFrame and RenderNextFrame messages.
This causes QSGItem::update() to be called and consumes a lot of useless CPU cycles on the UI process.

Introduce a bool to send DidRenderFrame only when dirty content was rendered.

WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::TiledDrawingArea):
(WebKit::TiledDrawingArea::tiledBackingStorePaint):
(WebKit::TiledDrawingArea::tiledBackingStorePaintEnd):

WebProcess/WebPage/TiledDrawingArea.h:

9:42 AM Changeset in webkit [94674] by podivilov@chromium.org

7 edits
2 adds in trunk

Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

inspector/front-end/DebuggerPresentationModel.js:

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

inspector/front-end/SourceFile.js:

LayoutTests:

inspector/debugger/raw-source-code-expected.txt: Added.
inspector/debugger/raw-source-code.html: Added.
inspector/debugger/script-formatter.html:
inspector/debugger/source-file.html:

9:40 AM Changeset in webkit [94673] by jocelyn.turcotte@nokia.com

17 edits in trunk/Source/WebKit2

[Qt][WK2] Make sure that the visible content rect and the content scale get to the web process in one single message.
https://bugs.webkit.org/show_bug.cgi?id=67189

Reviewed by Kenneth Rohde Christiansen.

The TiledBackingStore needs to know the screen size of the viewport to know how many tiles to
create, and since the visible content rect is given in page coordinates, the contents scale is
necessary to calculate the viewport size.
Both the rect and the scale then need to arrive to the web process at the same time to prevent
picking the new visible rect with the old scale or vice-versa which can produce a huge viewport size
and create/render an insane amount of tiles.

Things this patch does:

Merge the visible contents rect and content scale handling together.
Make QTouchWebView responsible for telling those viewport values to the web process instead of QTouchWebPage.
Prevent updating the viewport in ViewportInteractionEngine while a pinch is in progress and update the viewport at the end.

UIProcess/API/qt/qtouchwebpage.cpp:
UIProcess/API/qt/qtouchwebpage.h:
UIProcess/API/qt/qtouchwebpage_p.h:
UIProcess/API/qt/qtouchwebview.cpp:

(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebView::geometryChanged):

UIProcess/API/qt/qtouchwebview.h:
UIProcess/API/qt/qtouchwebview_p.h:
UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::setVisibleContentRectAndScale):

UIProcess/TiledDrawingAreaProxy.h:
UIProcess/qt/ViewportInteractionEngine.cpp:

(WebKit::ViewportInteractionEngine::ViewportInteractionEngine):
(WebKit::ViewportInteractionEngine::~ViewportInteractionEngine): Allows OwnPtr with the forward declaration of ViewportUpdateGuard.
(WebKit::ViewportInteractionEngine::setConstraints):
(WebKit::ViewportInteractionEngine::pinchGestureStarted):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::contentViewportChanged):

UIProcess/qt/ViewportInteractionEngine.h:
UIProcess/qt/qtouchwebpageproxy.cpp:

(QTouchWebPageProxy::setVisibleContentRectAndScale):

UIProcess/qt/qtouchwebpageproxy.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setVisibleContentRectAndScale):

WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::setVisibleContentRectAndScale):

WebProcess/WebPage/TiledDrawingArea.h:

9:35 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update on 3 more bots (diff)

9:18 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt to 4.7.4 and Mobility to 1.2.0 on 3 bots (diff)

8:54 AM Changeset in webkit [94672] by jocelyn.turcotte@nokia.com

7 edits
2 moves in trunk/Source/WebKit2

[Qt][WK2] Rename SGAgent to SGUpdateQueue to sharpen it's responsability.
https://bugs.webkit.org/show_bug.cgi?id=67122

Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/qtouchwebpage.cpp:

(QTouchWebPage::updatePaintNode):
(QTouchWebPagePrivate::QTouchWebPagePrivate):

UIProcess/API/qt/qtouchwebpage_p.h:
UIProcess/qt/SGUpdateQueue.cpp: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.cpp.

(WebKit::NodeUpdateCreateTile::NodeUpdateCreateTile):
(WebKit::NodeUpdateRemoveTile::NodeUpdateRemoveTile):
(WebKit::NodeUpdateSetBackBuffer::NodeUpdateSetBackBuffer):
(WebKit::NodeUpdateSwapTileBuffers::NodeUpdateSwapTileBuffers):
(WebKit::SGUpdateQueue::SGUpdateQueue):
(WebKit::SGUpdateQueue::createTileNode):
(WebKit::SGUpdateQueue::removeTileNode):
(WebKit::SGUpdateQueue::setNodeBackBuffer):
(WebKit::SGUpdateQueue::swapTileBuffers):
(WebKit::SGUpdateQueue::applyUpdates):
(WebKit::SGUpdateQueue::getScaleNode):

UIProcess/qt/SGUpdateQueue.h: Renamed from Source/WebKit2/UIProcess/qt/SGAgent.h.

(WebKit::SGUpdateQueue::isSwapPending):
(WebKit::NodeUpdate::NodeUpdate):
(WebKit::NodeUpdate::~NodeUpdate):

UIProcess/qt/TiledDrawingAreaProxyQt.cpp:

(WebKit::TiledDrawingAreaProxy::updateWebView):
(WebKit::TiledDrawingAreaProxy::createTile):
(WebKit::TiledDrawingAreaProxy::updateTile):
(WebKit::TiledDrawingAreaProxy::didRenderFrame):
(WebKit::TiledDrawingAreaProxy::removeTile):

UIProcess/qt/TouchViewInterface.cpp:

(WebKit::TouchViewInterface::sceneGraphUpdateQueue):

UIProcess/qt/TouchViewInterface.h:
WebKit2.pro:

8:15 AM Changeset in webkit [94671] by apavlov@chromium.org

5 edits in trunk

Web Inspector: Implement circular tabbing through the Styles sidebar pane contents
https://bugs.webkit.org/show_bug.cgi?id=67127

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/Section.js:

(WebInspector.Section.prototype.get firstSibling):
(WebInspector.Section.prototype.get lastSibling):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
(WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertiesSection.prototype._moveEditorFromSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):

LayoutTests:

inspector/styles/styles-commit-editing.html:

8:09 AM Changeset in webkit [94670] by caseq@chromium.org

3 edits in trunk/LayoutTests

2011-09-07 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix (removed a call to console.trace() to avoid having platform-specific expectations).

inspector/extensions/extensions-console-expected.txt:
inspector/extensions/extensions-console.html:

7:12 AM Changeset in webkit [94669] by caryclark@google.com

16 edits
19 adds
181 deletes in trunk/LayoutTests

Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

platform/chromium-mac/media/media/video-defaultmuted-expected.txt: Removed.

(remaining files omitted for brevity)

6:33 AM Changeset in webkit [94668] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebKit2

[Qt] Unreviewed suppression of an unnecessary debug output.

UIProcess/API/qt/tests/qmltests/qmltests.pro:

6:30 AM Changeset in webkit [94667] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Symbian
https://bugs.webkit.org/show_bug.cgi?id=67706

Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.

(buildQMakeProject):

6:12 AM Changeset in webkit [94666] by caseq@chromium.org

8 edits
2 adds in trunk

2011-09-02 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506

Reviewed by Pavel Feldman.

Test: inspector/extensions/extensions-console.html

inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessage.prototype.get text): (WebInspector.ConsoleMessage.prototype.get parameters):
inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.Console.prototype.getMessages): (WebInspector.injectedExtensionAPI.Console.prototype.addMessage): (WebInspector.injectedExtensionAPI.Console.prototype.get MessageLevel): (WebInspector.injectedExtensionAPI.Network.dispatchRequestEvent): (WebInspector.injectedExtensionAPI.Network): (WebInspector.injectedExtensionAPI.AuditCategoryImpl.dispatchAuditEvent): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceEvent): (WebInspector.injectedExtensionAPI.InspectedWindow.dispatchResourceContentEvent): (WebInspector.injectedExtensionAPI.InspectedWindow):
inspector/front-end/ExtensionCommon.js: (WebInspector.commonExtensionSymbols):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyConsoleMessageAdded): (WebInspector.ExtensionServer.prototype._onGetConsoleMessages): (WebInspector.ExtensionServer.prototype._onAddConsoleMessage): (WebInspector.ExtensionServer.prototype._makeConsoleMessage): (WebInspector.ExtensionServer.prototype._makeConsoleMessage.convertParameter): (WebInspector.ExtensionServer.prototype._dispatchCallback): (WebInspector.ExtensionServer.prototype.initExtensions):

2011-09-02 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: [Extensions API] expose console API
https://bugs.webkit.org/show_bug.cgi?id=67506

Reviewed by Pavel Feldman.

http/tests/inspector/resources/extension-main.js:
inspector/extensions/extensions-api-expected.txt:
inspector/extensions/extensions-console-expected.txt: Added.
inspector/extensions/extensions-console.html: Added.

5:31 AM Changeset in webkit [94665] by caseq@chromium.org

3 edits in trunk/Source/WebCore

2011-09-05 Andrey Kosyakov <caseq@chromium.org>

Web Inspector: disable popover when a mouse button is pressed
https://bugs.webkit.org/show_bug.cgi?id=67610

Reviewed by Pavel Feldman.

disable popover when a mouse button is pressed
disable popover in a SourceFrame when the source is being edited

inspector/front-end/Popover.js: (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype._mouseUp): (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._handleMouseAction):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._onHidePopover): (WebInspector.SourceFrame.prototype.doubleClick):

5:31 AM Changeset in webkit [94664] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

Update LayoutTests/platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-07

platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:

5:26 AM Changeset in webkit [94663] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Roll back r94655 with a small fix.

Scripts/webkitdirs.pm:

(buildQMakeProject):

4:10 AM Changeset in webkit [94662] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[WK2] evetSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening, skip dependent new test.

platform/wk2/Skipped: Skip fast/forms/number-input-changeevent.html.

3:36 AM Changeset in webkit [94661] by loislo@chromium.org

7 edits in trunk

Unreviewed, rolling out r94635.
http://trac.webkit.org/changeset/94635
https://bugs.webkit.org/show_bug.cgi?id=67704

Linux Touch build is failing to compile this change.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):

public/WebTouchPoint.h:

(WebKit::WebTouchPoint::WebTouchPoint):

src/WebInputEventConversion.cpp:

(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):

src/WebInputEventConversion.h:

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::sendCurrentTouchEvent):

3:28 AM Changeset in webkit [94660] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed, rolling out r94655.
http://trac.webkit.org/changeset/94655
https://bugs.webkit.org/show_bug.cgi?id=67703

It broke Leopard debug bot (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Scripts/webkitdirs.pm:

3:16 AM Changeset in webkit [94659] by Antti Koivisto

17 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67634
De-virtualize styleForRenderer()

Reviewed by Sam Weinig.

This has performance and code clarity benefits.

move styleForRenderer from Node to Element
get rid of the now unnecessary NodeRenderingContext parameter
de-virtualize, add virtual customStyleForRenderer()

dom/Element.cpp:

(WebCore::Element::customStyleForRenderer):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):

dom/Element.h:
dom/Node.cpp:
dom/Node.h:

(WebCore::Node::hasCustomWillOrDidRecalcStyle):
(WebCore::Node::setHasCustomWillOrDidRecalcStyle):
(WebCore::Node::hasCustomStyleForRenderer):
(WebCore::Node::setHasCustomStyleForRenderer):

Move styleForRenderer, add customStyleForRenderer, add a bit.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRendererFactory::createRendererAndStyle):

Handle non-element case separately since styleForRenderer was moved from Node to Element.

html/HTMLNoScriptElement.cpp:

(WebCore::HTMLNoScriptElement::HTMLNoScriptElement):
(WebCore::HTMLNoScriptElement::customStyleForRenderer):

html/HTMLNoScriptElement.h:

Move a strange XHTMLMP special case to where it belongs.

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::attach):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::attach):

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::textWithDirection):

html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):

html/shadow/TextControlInnerElements.h:
rendering/svg/SVGShadowTreeElements.cpp:

(WebCore::SVGShadowTreeContainerElement::customStyleForRenderer):

rendering/svg/SVGShadowTreeElements.h:
svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):

svg/SVGElement.h:

Adopt customStyleForRenderer().

3:07 AM Changeset in webkit [94658] by rniwa@webkit.org

12 edits
2 adds in trunk

Change event is not fired for input[type=number] when the user reverts a change made by script
https://bugs.webkit.org/show_bug.cgi?id=67697

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue not calling setTextAsOfLastFormControlChangeEvent
for text fields other than type=text.

Also fixed a that stepUpFromRenderer does not call setTextAsOfLastFormControlChangeEvent at appropriate
timing due to setValueAsNumber always passing sendChangeEvent=false to setValue by propagating values
through setValueAsNumber and applyStep. This refactoring allows us to remove calls to dispatch* in
stepUpFromRenderer because they're now called in setValueAsNumber or applyStep.

Test: fast/forms/number-input-changeevent.html

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsNumber):

html/BaseDateAndTimeInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueAsNumber):
(WebCore::HTMLInputElement::stepUpFromRenderer):

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::setValueAsNumber):

html/InputType.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsNumber):

html/NumberInputType.h:
html/RangeInputType.cpp:

(WebCore::RangeInputType::setValueAsNumber):
(WebCore::RangeInputType::handleKeydownEvent):

html/RangeInputType.h:

LayoutTests:

Add a regression test to ensure WebKit fires change event when the user reverts a change made by script.

fast/forms/number-input-changeevent-expected.txt: Added.
fast/forms/number-input-changeevent.html: Added.

2:52 AM Changeset in webkit [94657] by Antti Koivisto

3 edits in trunk/Source/WebCore

Try to fix Qt build by moving the Qt specific include (which is not really allowed here!).

Not reviewed.

css/CSSStyleSelector.cpp:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkStateSlowCase):

2:36 AM Changeset in webkit [94656] by Antti Koivisto

12 edits
2 adds in trunk/Source/WebCore

Move SelectorChecker out from CSSStyleSelector scope
https://bugs.webkit.org/show_bug.cgi?id=67648

Reviewed by Sam Weinig.

Move SelectorChecker to SelectorChecker.h/cpp
Make private functions private
Make members private, add accessors
Move m_sameOriginOnly to CSSStyleSelector as it is not used by SelectorChecker

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::style):
(WebCore::CSSStyleSelector::parentStyle):
(WebCore::CSSStyleSelector::rootElementStyle):
(WebCore::CSSStyleSelector::element):
(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):
(WebCore::CSSStyleSelector::setZoom):
(WebCore::CSSStyleSelector::setEffectiveZoom):
(WebCore::CSSStyleSelector::setTextSizeAdjust):
(WebCore::CSSStyleSelector::setStyle):
(WebCore::CSSStyleSelector::fontSelector):
(WebCore::CSSStyleSelector::allVisitedStateChanged):
(WebCore::CSSStyleSelector::visitedStateChanged):
(WebCore::CSSStyleSelector::usesSiblingRules):
(WebCore::CSSStyleSelector::usesFirstLineRules):
(WebCore::CSSStyleSelector::usesBeforeAfterRules):
(WebCore::CSSStyleSelector::usesLinkRules):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::isRightPage):
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
(WebCore::CSSStyleSelector::styleNotYetAvailable):

css/SelectorChecker.cpp: Added.

(WebCore::SelectorChecker::SelectorChecker):
(WebCore::linkAttribute):
(WebCore::SelectorChecker::determineLinkStateSlowCase):
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::addLocalNameToSet):
(WebCore::createHtmlCaseInsensitiveAttributesSet):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::attributeQualifiedNameMatches):
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::allVisitedStateChanged):
(WebCore::SelectorChecker::visitedStateChanged):

css/SelectorChecker.h: Added.

(WebCore::SelectorChecker::document):
(WebCore::SelectorChecker::strictParsing):
(WebCore::SelectorChecker::isCollectingRulesOnly):
(WebCore::SelectorChecker::setCollectingRulesOnly):
(WebCore::SelectorChecker::isMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::setMatchingVisitedPseudoClass):
(WebCore::SelectorChecker::pseudoStyle):
(WebCore::SelectorChecker::setPseudoStyle):
(WebCore::SelectorChecker::hasUnknownPseudoElements):
(WebCore::SelectorChecker::clearHasUnknownPseudoElements):
(WebCore::SelectorChecker::determineLinkState):

dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):

dom/SelectorQuery.h:

2:28 AM Changeset in webkit [94655] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r94288) build-webkit doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=67646

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-07
Reviewed by Csaba Osztrogonác.

Scripts/webkitdirs.pm:

2:24 AM Changeset in webkit [94654] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening after r94646.

platform/qt-mac/Skipped: Paint the Qt-Mac bot green.

2:23 AM Changeset in webkit [94653] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Revert expectation that was wrongly generated for textStyles.svg.

platform/chromium-linux/svg/batik/text/textStyles-expected.png:

2:21 AM Changeset in webkit [94652] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Unreviewed Windows rebaselines.

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

2:17 AM Changeset in webkit [94651] by rniwa@webkit.org

2 edits in trunk/LayoutTests

One last GTK+ rebaseline for r94614.

platform/gtk/fast/js/global-constructors-expected.txt:

2:11 AM Changeset in webkit [94650] by rniwa@webkit.org

4 edits in trunk/LayoutTests

GTK+ rebaselines after r94614.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

2:06 AM Changeset in webkit [94649] by loislo@chromium.org

2 edits
3 deletes in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Rebaseline expectations after r94593

platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

12:55 AM Changeset in webkit [94648] by commit-queue@webkit.org

3 edits
1 add
11 deletes in trunk/LayoutTests

fast/dom/replaceChild.html may not test what it's supposed to test and may sometimes be flaky
https://bugs.webkit.org/show_bug.cgi?id=67629

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-07
Reviewed by Darin Adler.

The test is supposed to test Node.replaceChild() called from a frame.
However, in most cases, it's not executed because the test finishes before
the iframe's onload event handler. For now, the expected result is just
the original render tree before replaceChild(). In chance that iframe's
onload is executed earlier, the actual result might be different from
expected (that is, replaceChild() is executed and the DOM is actually changed.)

Use waitUntilDone() and notifyDone() to ensure the frame's onload handler
is called.

BTW changed it to a pure text test to avoid platform branches.

fast/dom/replaceChild.html:
fast/dom/replaceChild-expected.txt: Added.
fast/dom/resources/replaceChildHelper.html:
platform/chromium-linux/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-mac/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-win/fast/dom/replaceChild-expected.png: Removed.
platform/chromium-win/fast/dom/replaceChild-expected.txt: Removed.
platform/gtk/fast/dom/replaceChild-expected.png: Removed.
platform/gtk/fast/dom/replaceChild-expected.txt: Removed.
platform/mac-leopard/fast/dom/replaceChild-expected.png: Removed.
platform/mac/fast/dom/replaceChild-expected.png: Removed.
platform/mac/fast/dom/replaceChild-expected.txt: Removed.
platform/qt/fast/dom/replaceChild-expected.png: Removed.
platform/qt/fast/dom/replaceChild-expected.txt: Removed.

12:50 AM Changeset in webkit [94647] by dslomov@google.com

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=67413
[Chromium]Web Inspector: inspected page with dedicated worker crashes on refresh.
This patch enforces lifetime ordering between WorkerInspectorController and WorkerScriptController.

Reviewed by Yury Semikhatsky.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::clearInspector):

workers/WorkerContext.h:
workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):

12:45 AM Changeset in webkit [94646] by Csaba Osztrogonác

1 edit
6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected results for new passing tests.

platform/qt/fast/borders/border-image-longhand-expected.png: Added.
platform/qt/fast/borders/border-image-longhand-expected.txt: Added.
platform/qt/fast/borders/border-image-scaled-expected.png: Added.
platform/qt/fast/borders/border-image-scaled-expected.txt: Added.
platform/qt/fast/borders/border-image-side-reduction-expected.png: Added.
platform/qt/fast/borders/border-image-side-reduction-expected.txt: Added.

12:12 AM Changeset in webkit [94645] by loislo@chromium.org

3 edits in trunk/LayoutTests

2011-09-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Rebaseline expectations for svg/batik/text/textStyles.svg after r94624.

platform/chromium-linux/svg/batik/text/textStyles-expected.png:
platform/chromium-win/svg/batik/text/textStyles-expected.txt:

12:01 AM Changeset in webkit [94644] by Csaba Osztrogonác

112 edits in trunk/Source

Unreviewed, rolling out r94627 and r94632.
http://trac.webkit.org/changeset/94627
http://trac.webkit.org/changeset/94632
https://bugs.webkit.org/show_bug.cgi?id=67698

It broke tests on GTK and Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/JavaScriptCore:

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::JSCallbackConstructor):

API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::JSCallbackFunction):

API/JSCallbackFunction.h:
JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::create):

debugger/DebuggerActivation.h:
jsc.cpp:

(GlobalObject::constructorBody):
(GlobalObject::GlobalObject):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::ArrayConstructor):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::ArrayPrototype):

runtime/ArrayPrototype.h:

(JSC::ArrayPrototype::create):

runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::BooleanConstructor):

runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp:

(JSC::BooleanObject::BooleanObject):

runtime/BooleanObject.h:

(JSC::BooleanObject::create):

runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::BooleanPrototype):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::DateConstructor):

runtime/DateConstructor.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h:

(JSC::DateInstance::create):

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype):

runtime/DatePrototype.h:
runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::ErrorConstructor):

runtime/ErrorConstructor.h:

(JSC::ErrorConstructor::create):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::FunctionConstructor):

runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

runtime/FunctionPrototype.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

runtime/InternalFunction.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

runtime/JSActivation.h:

(JSC::JSActivation::create):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::JSGlobalObject):

runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):

runtime/JSONObject.h:

(JSC::JSONObject::create):

runtime/JSStaticScopeObject.h:

(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):

runtime/JSString.cpp:

(JSC::StringObject::create):

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

runtime/MathObject.h:

(JSC::MathObject::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::constructorBody):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):

runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::NumberConstructor):

runtime/NumberConstructor.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::NumberObject):

runtime/NumberObject.h:

(JSC::NumberObject::create):

runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::NumberPrototype):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::ObjectConstructor):

runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::create):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):

runtime/RegExpObject.h:

(JSC::RegExpObject::create):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::StringObject):

runtime/StringObject.h:

(JSC::StringObject::create):

runtime/StringObjectThatMasqueradesAsUndefined.h:

(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::StringPrototype):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

JSRun.cpp:

(JSGlueGlobalObject::JSGlueGlobalObject):

Source/WebCore:

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::create):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

bridge/c/CRuntimeObject.h:
bridge/jni/jsc/JavaRuntimeObject.cpp:

(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):

bridge/jni/jsc/JavaRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.h:
bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):

bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):

bridge/runtime_array.h:

(JSC::RuntimeArray::create):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):

Source/WebKit/mac:

Plugins/Hosted/ProxyRuntimeObject.h:
Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):
(WebKit::JSNPMethod::create):

WebProcess/Plugins/Netscape/JSNPMethod.h:
WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::create):

WebProcess/Plugins/Netscape/JSNPObject.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed