Timeline
Feb 5, 2012:
- 11:54 PM Changeset in webkit [106779] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829
This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
- 11:52 PM Changeset in webkit [106778] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):
- 11:39 PM Changeset in webkit [106777] by
-
- 27 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.
All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.
- inspector/CodeGeneratorInspector.py:
(DomainNameFixes.get_fixed_data):
(Generator.go):
- inspector/InspectorAgent.h:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightNode):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorFileSystemAgent.h:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):
- inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::sendMessageToWorker):
- inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
- 11:06 PM Changeset in webkit [106776] by
-
- 52 edits in trunk/Source/WebCore
Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611
Reviewed by Adam Barth.
While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm: Added FIXME.
(JSValueToNative):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GetNativeTypeFromSignature):
- bindings/scripts/test/TestObj.idl:
- css/CSSCharsetRule.idl:
- css/CSSPageRule.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/WebKitCSSKeyframesRule.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/ProcessingInstruction.idl:
- dom/ShadowRoot.idl:
- fileapi/Blob.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.idl:
- fileapi/Entry.idl:
- fileapi/EntrySync.idl:
- fileapi/WebKitBlobBuilder.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOutputElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- page/Console.idl:
- page/DOMWindow.idl:
- storage/StorageEvent.idl:
- svg/SVGAngle.idl:
- svg/SVGElement.idl:
- svg/SVGLength.idl:
- svg/SVGScriptElement.idl:
- 10:44 PM Changeset in webkit [106775] by
-
- 15 edits2 adds in trunk/Source/JavaScriptCore
DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797
Reviewed by Oliver Hunt.
The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).
The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.
This is performance-neutral on all benchmarks we track.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
(AbstractState):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):
- dfg/DFGCommon.h:
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):
- dfg/DFGNodeReferenceBlob.h: Added.
(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):
- dfg/DFGNodeUse.h: Added.
(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- 9:55 PM Changeset in webkit [106774] by
-
- 6 edits in trunk/LayoutTests
xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849
Reviewed by Kentaro Hara.
This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
- platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:47 PM Changeset in webkit [106773] by
-
- 12 edits in trunk/Source/WebCore
Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844
Reviewed by Adam Barth.
Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- css/CSSStyleDeclaration.idl:
- html/HTMLDocument.idl:
- html/canvas/DataView.idl:
- page/DOMWindow.idl:
- page/MemoryInfo.idl:
- webaudio/ConvolverNode.idl:
- webaudio/DOMWindowWebAudio.idl:
- webaudio/WaveShaperNode.idl:
- websockets/DOMWindowWebSocket.idl:
- workers/WorkerContext.idl:
- 8:01 PM Changeset in webkit [106772] by
-
- 14 edits1 add in trunk
[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-05
Reviewed by Martin Robinson.
.:
Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.
- Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.
Source/WebCore:
Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.
No new tests required. We can verify this feature with the existing test cases.
- CMakeLists.txt: Revised common files required for WebGL.
- PlatformEfl.cmake: Added EFL specific files.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/GraphicsContext3D.h:
(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
- platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.
(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
Source/WebKit/efl:
Activated WebGL feature.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
- 7:53 PM Changeset in webkit [106771] by
-
- 3 edits2 adds in trunk
Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/form-submission-create-crash.xhtml
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
LayoutTests:
- fast/forms/form-submission-create-crash-expected.txt: Added.
- fast/forms/form-submission-create-crash.xhtml: Added.
- 6:25 PM Changeset in webkit [106770] by
-
- 6 edits1 delete in trunk/Source/WebCore
Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>
Reviewed by Anders Carlsson.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/MappedAttributeEntry.h: Removed.
- dom/StyledElement.h:
- 6:21 PM Changeset in webkit [106769] by
-
- 253 edits in trunk/Source/WebCore
StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>
Reviewed by Anders Carlsson.
Rename across the board and decorate subclasses with OVERRIDE.
- 6:06 PM Changeset in webkit [106768] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed syntax fix.
- English.lproj/localizedStrings.js:
- 5:33 PM Changeset in webkit [106767] by
-
- 2 edits in trunk/Source/WebCore
Swedish buildfix.
- dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):
- 4:43 PM Changeset in webkit [106766] by
-
- 8 edits in trunk/Source/WebCore
The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840
Reviewed by Andreas Kling.
If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.
- dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.
(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.
(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.
(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.
- 2:27 PM Changeset in webkit [106765] by
-
- 2 edits1 add in trunk/LayoutTests
Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.
In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.
- platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:16 PM Changeset in webkit [106764] by
-
- 2 edits1 add in trunk/LayoutTests
Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.
- platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:02 PM Changeset in webkit [106763] by
-
- 2 edits in trunk/LayoutTests
Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.
- platform/chromium/test_expectations.txt:
- 1:54 PM Changeset in webkit [106762] by
-
- 2 edits in trunk/LayoutTests
This test is no longer flaky. It appears to pass all the time.
- platform/chromium/test_expectations.txt:
- 10:51 AM Changeset in webkit [106761] by
-
- 7 edits in trunk
<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823
Reviewed by Anders Carlsson.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
- 6:02 AM Changeset in webkit [106760] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828
Reviewed by Andreas Kling.
g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.
- ewk/ewk_main.cpp:
(_ewk_init_body):
- 1:36 AM Changeset in webkit [106759] by
-
- 4 edits in trunk
[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425
Reviewed by Daniel Bates.
Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.
.:
- Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.
Source/JavaScriptCore:
- shell/CMakeLists.txt:
- 1:27 AM Changeset in webkit [106758] by
-
- 2 edits in trunk
[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826
Reviewed by Daniel Bates.
Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.
- CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.
- 1:26 AM Changeset in webkit [106757] by
-
- 14 edits in trunk/Source/WebCore
Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>
Reviewed by Antti Koivisto.
Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.
The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)
- dom/Attribute.cpp:
(WebCore::Attribute::clone):
- dom/Attribute.h:
(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):
- dom/Document.cpp:
(WebCore::Document::createAttributeNS):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Element.h:
(Element):
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):
- dom/StyledElement.h:
(StyledElement):
- html/parser/HTMLConstructionSite.cpp:
(WebCore):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- xml/parser/MarkupTokenBase.h:
(WebCore::::initializeAttributes):
- 12:29 AM Changeset in webkit [106756] by
-
- 18 edits2 deletes in trunk/Source/WebCore
Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>
Reviewed by Antti Koivisto.
Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.
This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/CSSMappedAttributeDeclaration.cpp: Removed.
- dom/CSSMappedAttributeDeclaration.h: Removed.
- dom/DOMAllInOne.cpp:
Remove CSSMappedAttributeDeclaration.{cpp,h}
- css/CSSParser.h:
- css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):
Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureAttributeStyle):
- dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):
- dom/StyledElement.cpp:
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
- dom/StyledElement.h:
(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
- 12:27 AM Changeset in webkit [106755] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
- inspector/front-end/heapProfiler.css:
(.cycled-ancessor-node):
- inspector/front-end/profilesPanel.css:
Feb 4, 2012:
- 10:13 PM Changeset in webkit [106754] by
-
- 5 edits in trunk/Source
[chromium] Add support to force full damage in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76805
Reviewed by James Robinson.
Source/WebCore:
Unit test added to CCDamageTrackerTest.cpp.
This feature is needed for events that should cause the entire
surface to be damaged, even if layers themselves had only partial
damage or no damage at all. For example, tab-switching is one such
event.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore::CCDamageTracker::forceFullDamageNextUpdate):
(CCDamageTracker):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 6:53 PM Changeset in webkit [106753] by
-
- 9 edits in trunk
<rdar://problem/10660698> Clients cannot prevent caching of individual responses
https://bugs.webkit.org/show_bug.cgi?id=77822
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/APIClientTraits.cpp: Added definition of interfaceSizesByVersion for
WKBundlePageResourceLoadClient.
- Shared/APIClientTraits.h: Added APIClientTraits specialization for WKBundlePageResourceLoadClient.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added WKBundlePageShouldCacheResponseCallback
typedef, added shouldCacheResponse member to WKBundlePageResourceLoadClient, and bumped
kWKBundlePageResourceLoadClientCurrentVersion to 1.
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse): Added. Calls through
to the client if it implements shouldCacheResponse. Returns true otherwise.
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse() and return nil if the former
returns false.
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse().
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
- 5:03 PM Changeset in webkit [106752] by
-
- 6 edits in trunk/Source/WebCore
Remove dead code from ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=77821
Reviewed by Sam Weinig.
- WebCore.exp.in:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
- 4:55 PM Changeset in webkit [106751] by
-
- 7 edits2 adds in trunk
Add ability to send WKURLRequests in WebKit2 API user messages
https://bugs.webkit.org/show_bug.cgi?id=77819
Reviewed by Anders Carlsson.
Source/WebKit2:
Test: WebKit2UserMessageRoundTripTest API test.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encode/decode for WebURLRequest.
Tools:
Add testing for round-tripping WKTypes from the UIProcess,
to the WebProcess, and back.
- This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef. More can easily be added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
(TestWebKitAPI):
(WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
(TestWebKitAPI):
(UserMessageTest):
(TestWebKitAPI::UserMessageTest::UserMessageTest):
(TestWebKitAPI::UserMessageTest::didReceiveMessage):
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI):
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
- 4:43 PM Changeset in webkit [106750] by
-
- 6 edits in trunk/Source/WebCore
The scrolling tree should inform the main scrolling coordinator when the scroll position changes
https://bugs.webkit.org/show_bug.cgi?id=77818
Reviewed by Sam Weinig.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
Set the main frame scroll position.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::scrollBy):
Call ScrollingTree::updateMainFrameScrollPosition.
- 4:18 PM Changeset in webkit [106749] by
-
- 7 edits in trunk
<rdar://problem/10772406> WKPreferences instances cannot be copied
https://bugs.webkit.org/show_bug.cgi?id=77816
Reviewed by Sam Weinig.
Source/WebKit2:
Test added in TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateCopy): Added.
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences): Added this constructor that copies the
WebPreferencesStore of the given WebPreferences.
- UIProcess/WebPreferences.h:
(WebKit::WebPreferences::create): Added this create function that takes a WebPreferences
instance and creates a new instance with a copy of the given instance’s store.
Tools:
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):
- 3:49 PM Changeset in webkit [106748] by
-
- 2 edits in trunk/Source/JavaScriptCore
Rubber stamped by Sam Weinig.
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::quantifyAtom):
- Fix comment.
- 2:56 PM Changeset in webkit [106747] by
-
- 2 edits in trunk
Fix bug in svg-link-hover-use.svg
https://bugs.webkit.org/show_bug.cgi?id=77768
Patch by Philip Rogers <pdr@google.com> on 2012-02-04
Reviewed by Eric Seidel.
- ManualTests/svg-link-hover-use.svg:
- 2:56 PM Changeset in webkit [106746] by
-
- 19 edits in trunk/Source/WebCore
Element: Remove unnecessary attributeChanged() argument.
<http://webkit.org/b/77814>
Reviewed by Ryosuke Niwa.
Remove the 'preserveDecls' argument to Element::attributeChanged() as that is no
longer needed after the removal of per-attribute style declarations.
Decorated subclass overrides with OVERRIDE since we're touching the lines.
Also removed an old inaccurate comment in NamedNodeMap::setAttributes() - calling
attributeChanged() is absolutely necessary to initialize element-specific state.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Element.h:
(Element):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setAttributes):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
- dom/StyledElement.h:
(StyledElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::attributeChanged):
- html/HTMLScriptElement.h:
(HTMLScriptElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::attributeChanged):
- html/HTMLTrackElement.h:
(HTMLTrackElement):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::attributeChanged):
- svg/SVGAnimationElement.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
- svg/SVGElement.h:
(SVGElement):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::attributeChanged):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
- 2:44 PM Changeset in webkit [106745] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] CurrentTime: Reorder headers for win32
https://bugs.webkit.org/show_bug.cgi?id=77808
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.
In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.
CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]
- wtf/CurrentTime.cpp:
- 2:40 PM Changeset in webkit [106744] by
-
- 3 edits2 adds in trunk
Crash when reparenting children of flexible boxes
https://bugs.webkit.org/show_bug.cgi?id=77458
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-04
Reviewed by Ojan Vafai.
Source/WebCore:
This fixes some regressions I introduced in r106150. RenderBlock::
removeChild needs to be careful about not collapsing anonymous
blocks underneath flexible boxes, and also about node ordering
when there is an after block.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
LayoutTests:
This test case reparents a block node from under a flexible box so
that only anonymous blocks and floating generated blocks remain.
A recent patch caused these anonymous blocks to be collapsed, which
is incorrect.
- fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash-expected.txt: Added
- fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html: Added
- 2:26 PM Changeset in webkit [106743] by
-
- 2 edits in trunk/Source/WebCore
Debug build fix after r106715.
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::create):
- 2:24 PM Changeset in webkit [106742] by
-
- 2 edits in trunk
[GTK] Use the wide character version of win32 API by default
https://bugs.webkit.org/show_bug.cgi?id=77809
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.
Certain win32-specific files (like PluginDatabaseWin.cpp) make the
assumption that the wide character version of win32 API is the default.
Define _UNICODE and UNICODE to do this, similar to what other win32
ports are doing.
- GNUmakefile.am:
- 1:31 PM Changeset in webkit [106741] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed test fix after r106740.
<http://webkit.org/b/77204>
Disable matched declaration caching for elements with attribute style until we can
figure out how it's supposed to work.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
- 4:24 AM Changeset in webkit [106740] by
-
- 74 edits in trunk
Kill per-Attribute style declarations.
<http://webkit.org/b/77204>
Reviewed by Antti Koivisto.
Source/WebCore:
TL;DR summary: Remove the per-Attribute style declarations and replace them by a single
style declaration on StyledElement that acts as a secondary inline style.
The previous design was conceived in the Age of the Old Web(tm) where the majority of
element styling was accomplished via attributes. Nowadays, CSS is a much better tool for
this and we should optimize around that instead.
StyledElements now have an attributeStyle() which contains all the styling from attributes.
parseMappedAttribute() is responsible for adding/removing properties to the attributeStyle
as the corresponding attributes come in/out of the element.
Each Attribute instance shrinks by one pointer, each element that has attributes grows by
one pointer. The styles from individual attributes are no longer shared, so content that
uses a lot of repeating styling attributes will see a slight memory regression from this.
Future improvements to this could enable sharing the attributeStyle between elements that
have the same exact attributes to mitigate some of the damage.
There should be no web-facing behavior change from this, but it does break two things:
- The Inspector feature for displaying per-attribute styles. To keep things manageable, this patch simply files all the attribute styles together under an anonymous attribute in the Inspector.
- The Obj-C DOM binding for Attr::style() has to be kept for compatibility reasons, though it's already deprecated. It will now always return nil, since there's no way to retrieve a live style declaration that's specific to a certain Attr.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
- dom/Attr.h:
(WebCore):
(Attr):
(WebCore::Attr::style):
- dom/Attribute.cpp:
(WebCore::Attribute::clone):
- dom/Attribute.h:
(WebCore):
(WebCore::Attribute::create):
(WebCore::Attribute::createMapped):
(Attribute):
(WebCore::Attribute::Attribute):
- dom/CSSMappedAttributeDeclaration.cpp:
(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
- dom/CSSMappedAttributeDeclaration.h:
(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureAttributeStyle):
(WebCore):
- dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):
- dom/StyledElement.cpp:
(WebCore):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::parseMappedAttribute):
- html/HTMLBRElement.h:
(HTMLBRElement):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLBodyElement.h:
(HTMLBodyElement):
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::parseMappedAttribute):
- html/HTMLDivElement.h:
(HTMLDivElement):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttribute):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::removeHTMLAlignment):
(WebCore):
(WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
(WebCore::HTMLElement::setContentEditable):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
- html/HTMLEmbedElement.h:
(HTMLEmbedElement):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::parseMappedAttribute):
- html/HTMLFontElement.h:
(HTMLFontElement):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute):
- html/HTMLFrameSetElement.h:
(HTMLFrameSetElement):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::parseMappedAttribute):
- html/HTMLHRElement.h:
(HTMLHRElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
- html/HTMLIFrameElement.h:
(HTMLIFrameElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLImageElement.h:
(HTMLImageElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::parseMappedAttribute):
- html/HTMLLIElement.h:
(HTMLLIElement):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::parseMappedAttribute):
- html/HTMLMarqueeElement.h:
(HTMLMarqueeElement):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::parseMappedAttribute):
- html/HTMLOListElement.h:
(HTMLOListElement):
- html/HTMLOutputElement.cpp:
- html/HTMLOutputElement.h:
(HTMLOutputElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::parseMappedAttribute):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::parseMappedAttribute):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::parseMappedAttribute):
- html/HTMLPreElement.h:
(HTMLPreElement):
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::parseMappedAttribute):
- html/HTMLTableCaptionElement.h:
(HTMLTableCaptionElement):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::parseMappedAttribute):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseMappedAttribute):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore):
(WebCore::HTMLTablePartElement::parseMappedAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::parseMappedAttribute):
- html/HTMLUListElement.h:
(HTMLUListElement):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseMappedAttribute):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::parseMappedAttribute):
- mathml/MathMLElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseMappedAttribute):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::parseMappedAttribute):
(WebCore::SVGStyledElement::getPresentationAttribute):
- svg/SVGStyledElement.h:
(SVGStyledElement):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::parseMappedAttribute):
LayoutTests:
Rebaselined 3 inspector tests since attribute styles are no longer shown per-attribute.
- inspector/elements/elements-panel-styles-expected.txt:
- inspector/styles/styles-computed-trace-expected.txt:
- inspector/styles/styles-new-API-expected.txt:
- 2:22 AM Changeset in webkit [106739] by
-
- 7 edits in trunk/Tools
garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=77802
Reviewed by Eric Seidel.
This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js. It then adds
an Examine action to each group of failures that triggers the "results"
view.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
- 2:20 AM Changeset in webkit [106738] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: get rid of cycles in retaining tree
https://bugs.webkit.org/show_bug.cgi?id=77801
Drive by fix: 'retained by' prefix was removed.
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
- inspector/front-end/profilesPanel.css:
(.cycled-ancessor-node):
- 2:12 AM Changeset in webkit [106737] by
-
- 152 edits in trunk/Source/WebCore
Add the "JS" prefix to JSC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77693
Reviewed by Darin Adler.
Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.
This patch renames the following JSC specific IDLs:
CustomFinalize => JSCustomFinalize
CustomIsReachable => JSCustomIsReachable
CustomMarkFunction => JSCustomMarkFunction
CustomToJS => JSCustomToJS
CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
GenerateIsReachable => JSGenerateIsReachable
GenerateToJS => JSGenerateToJS
NoStaticTables => JSNoStaticTables
WindowEventListener => JSWindowEventListener
InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation):
- bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- dom/Attr.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringMap.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/ErrorEvent.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/EventListener.idl:
- dom/MessageChannel.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeIterator.idl:
- dom/NodeList.idl:
- dom/TreeWalker.idl:
- dom/WebKitNamedFlow.idl:
- fileapi/Blob.idl:
- fileapi/DOMFileSystem.idl:
- fileapi/DOMFileSystemSync.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.idl:
- fileapi/DirectoryReader.idl:
- fileapi/DirectoryReaderSync.idl:
- fileapi/Entry.idl:
- fileapi/EntryArray.idl:
- fileapi/EntryArraySync.idl:
- fileapi/EntrySync.idl:
- fileapi/File.idl:
- fileapi/FileEntry.idl:
- fileapi/FileEntrySync.idl:
- fileapi/FileError.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- fileapi/FileWriter.idl:
- fileapi/Metadata.idl:
- fileapi/OperationNotAllowedException.idl:
- fileapi/WebKitBlobBuilder.idl:
- html/DOMFormData.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLBodyElement.idl:
- html/HTMLCollection.idl:
- html/HTMLFrameSetElement.idl:
- html/ImageData.idl:
- html/MediaController.idl:
- html/TextTrack.idl:
- html/TextTrackCue.idl:
- html/VoidCallback.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/ArrayBufferView.idl:
- html/canvas/CanvasRenderingContext.idl:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- html/canvas/WebGLCompressedTextures.idl:
- html/canvas/WebGLDebugRendererInfo.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/track/TextTrackList.idl:
- loader/appcache/DOMApplicationCache.idl:
- mediastream/LocalMediaStream.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/Geolocation.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Screen.idl:
- page/WorkerNavigator.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPluginArray.idl:
- storage/Database.idl:
- storage/DatabaseSync.idl:
- storage/IDBAny.idl:
- storage/IDBKey.idl:
- storage/SQLError.idl:
- storage/SQLException.idl:
- storage/SQLResultSet.idl:
- storage/SQLResultSetRowList.idl:
- storage/SQLTransaction.idl:
- storage/SQLTransactionSync.idl:
- storage/Storage.idl:
- svg/SVGElementInstance.idl:
- svg/SVGPathSeg.idl:
- webaudio/AudioBufferCallback.idl:
- webaudio/AudioBufferSourceNode.idl:
- webaudio/AudioContext.idl:
- webaudio/AudioDestinationNode.idl:
- webaudio/AudioGain.idl:
- webaudio/AudioGainNode.idl:
- webaudio/AudioPannerNode.idl:
- webaudio/AudioProcessingEvent.idl:
- webaudio/BiquadFilterNode.idl:
- webaudio/ConvolverNode.idl:
- webaudio/DelayNode.idl:
- webaudio/DynamicsCompressorNode.idl:
- webaudio/HighPass2FilterNode.idl:
- webaudio/JavaScriptAudioNode.idl:
- webaudio/LowPass2FilterNode.idl:
- webaudio/MediaElementAudioSourceNode.idl:
- webaudio/OfflineAudioCompletionEvent.idl:
- webaudio/RealtimeAnalyserNode.idl:
- webaudio/WaveShaperNode.idl:
- websockets/CloseEvent.idl:
- websockets/WebSocket.idl:
- workers/AbstractWorker.idl:
- workers/DedicatedWorkerContext.idl:
- workers/SharedWorker.idl:
- workers/SharedWorkerContext.idl:
- workers/Worker.idl:
- workers/WorkerContext.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestProgressEvent.idl:
- xml/XMLHttpRequestUpload.idl:
- xml/XPathResult.idl:
- 2:09 AM Changeset in webkit [106736] by
-
- 4 edits in trunk/LayoutTests
http/tests/security/xss-eval fails due to difference in JSC and V8 eval
https://bugs.webkit.org/show_bug.cgi?id=77806
Reviewed by Eric Seidel.
Both the JSC and V8 behaviors are reasonable in this case. This patch
modifies the test to show that either behavior isn't a security
vulnerability.
- http/tests/security/xss-eval.html:
- platform/chromium/http/tests/security/xss-eval-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:50 AM Changeset in webkit [106735] by
-
- 3 edits in trunk/Tools
check-webkit-style is throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=77744
Reviewed by David Levin.
If the test_list is None, then we don't need to check for unsupported
feature tests to skip.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._has_test_in_directories):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_skipped_tests_for_unsupported_features_empty_test_list):
- 1:42 AM Changeset in webkit [106734] by
-
- 13 edits in trunk/Source/WebCore
Convert RenderTheme over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77783
Reviewed by Eric Seidel.
Change the RenderTheme classes to use the new layout abstraction as a
part of the ongoing conversion work.
No new tests.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):
- rendering/RenderTheme.h:
(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):
- rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::baselinePosition):
- rendering/RenderThemeSafari.h:
(RenderThemeSafari):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
- rendering/RenderThemeWin.h:
(RenderThemeWin):
- 1:40 AM Changeset in webkit [106733] by
-
- 2 edits in trunk/LayoutTests
IndexedDB: mark quota layout test WONTFIX
https://bugs.webkit.org/show_bug.cgi?id=77459
Reviewed by Tony Chang.
- platform/chromium/test_expectations.txt:
- 1:26 AM Changeset in webkit [106732] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774
Reviewed by James Robinson.
Correctness covered by existing tests.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.
- 1:24 AM Changeset in webkit [106731] by
-
- 1 edit4 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77751
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-04
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/ClientExtension.cpp: Added.
- blackberry/WebCoreSupport/ClientExtension.h: Added.
- blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h: Added.
- 1:19 AM Changeset in webkit [106730] by
-
- 4 edits in trunk
Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect
Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Did change inorder to print correct log as per the description provided in test case.
- fast/events/autoscroll-with-non-scrollable-parent.html:
Feb 3, 2012:
- 10:43 PM Changeset in webkit [106729] by
-
- 2 edits in trunk/Source/WebCore
Canvas-into-canvas drawing should respect backing store scale ratio
https://bugs.webkit.org/show_bug.cgi?id=77784
<rdar://problem/10549729>
Reviewed by Dan Bernstein.
Respect the backing store scale ratio when drawing a canvas into another
canvas via ctx.drawImage(canvas, x, y). Previous behavior caused canvas
drawing to differ based on the size of the backing store, which is ideally
an implementation detail to authors.
Also, rename the source canvas arguments to CanvasRenderingContext2D::drawImage
to be more clear.
No new tests.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- 8:45 PM Changeset in webkit [106728] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Add a Chromium-specific baseline for this test. These results appear to be passing.
- platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt: Removed.
- platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 7:59 PM Changeset in webkit [106727] by
-
- 5 edits in trunk/Tools
List of all failures in garden-o-matic should actually list all the failures
https://bugs.webkit.org/show_bug.cgi?id=77796
Reviewed by Eric Seidel.
This patch wires a bit more data into the new "All Failures" tab. I've
also iterated on how we enable this experimental feature. The tab is
still just a dumb list, but we'll make it smarter.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- 7:50 PM Changeset in webkit [106726] by
-
- 2 edits in trunk/Tools
Windows build fix after r106692.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_reference_files):
- 6:01 PM Changeset in webkit [106725] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=77782
WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
once on some pages with frames
-and corresponding-
<rdar://problem/10798474>
Reviewed by Sam Weinig.
Source/WebCore:
startCountingRelevantRepaintedObjects() should only be called for the main
frame. Otherwise, the counter will be re-set inappropriately, and
didNewFirstVisuallyNonEmptyLayout may even end up firing more than once.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Tools:
One new test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
- TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
- 5:59 PM Changeset in webkit [106724] by
-
- 2 edits in trunk/Source/WebCore
Reduce the memory allocations of WebCore's cssPropertyName()
https://bugs.webkit.org/show_bug.cgi?id=74782
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-03
Reviewed by Geoffrey Garen.
Add a fast path to avoid the use of the StringBuilder.
The string builder is needed for two cases:
-CSS prefix (the character after the prefix must be uppercase)
-JavaScript CamelCase name for CSS properties
We can skip all memory allocations if the property is not in those
two cases. We start by testing the string for uppercase characters,
and just return the an identical string.
This patch create a "fast case" 2.7 times faster than previously.
The "slow case" is 2-3% slower due to the additional check at the beginning.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore):
(WebCore::containsASCIIUpperChar):
(WebCore::cssPropertyName):
(WebCore::isCSSPropertyName):
- 5:56 PM Changeset in webkit [106723] by
-
- 9 edits in trunk/Source
WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Add new symbols needed by WebKit2.
- WebCore.xcodeproj/project.pbxproj:
Make ScrollingTree.h private so it can be included by WebKit2.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollingTree):
- page/scrolling/ScrollingCoordinator.h:
Add a scrolling tree getter.
Source/WebKit2:
Replace all uses of ScrollingCoordinator with ScrollingTree instead.
Also, don't try to handle gesture events on the scrolling thread anymore;
we don't need to to that right now.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
- WebProcess/WebPage/EventDispatcher.h:
(WebCore):
(EventDispatcher):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
- 5:45 PM Changeset in webkit [106722] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.
Reviewed by Adam Barth.
- bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
- 5:41 PM Changeset in webkit [106721] by
-
- 12 edits in trunk/Tools
webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
https://bugs.webkit.org/show_bug.cgi?id=77781
Reviewed by Eric Seidel.
This change fixes a couple of issues discovered while debugging
test-webkitpy; both calling exit() instead of sys.exit() --
which is discouraged in program code instead of the interpreter
-- and a particular usage of outputcapture were stdin to get whacked
and preventing debugging.
This change introduces a couple of common _exit() methods that
will standardize how webkit-patch exit's, in case we need to do
something different in the future.
- Scripts/webkitpy/common/system/deprecated_logging.py:
(error):
- Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.assert_outputs):
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.exit_after_handled_error):
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand.execute):
- Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue.handle_script_error):
- Scripts/webkitpy/tool/commands/upload.py:
(MarkBugFixed.execute):
- Scripts/webkitpy/tool/multicommandtool.py:
(Command._exit):
- Scripts/webkitpy/tool/steps/abstractstep.py:
(AbstractStep._exit):
- Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle.run):
- Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
- Scripts/webkitpy/tool/steps/confirmdiff.py:
(ConfirmDiff.run):
- 5:33 PM Changeset in webkit [106720] by
-
- 6 edits in trunk/Source/WebCore
The scrolling tree should be able to handle wheel events
https://bugs.webkit.org/show_bug.cgi?id=77794
Reviewed by Andreas Kling.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
New function. Currently this always returns that it was able to handle the wheel event,
but this will change in the future.
(WebCore::ScrollingTree::handleWheelEvent):
Ask the root node to handle the wheel event.
- page/scrolling/ScrollingTreeNode.h:
Add a handleWheelEvent pure virtual member function.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
things like rubber-banding.
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Add getters and setters for the scroll position.
(WebCore::ScrollingTreeNodeMac::scrollBy):
Update the scroll position given the offset.
- 5:32 PM Changeset in webkit [106719] by
-
- 1 edit in trunk/Tools/Scripts/update-webkit-dependency
buildbot fix for curl.
- 5:30 PM Changeset in webkit [106718] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106672 - REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491
Reviewed by Simon Fraser.
Source/WebCore:
The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).
Test: animations/animation-border-overflow.html
- platform/animation/AnimationUtilities.h:
(WebCore::blend):
LayoutTests:
- animations/animation-border-overflow-expected.txt: Added.
- animations/animation-border-overflow.html: Added.
TBR=alexis.menard@openbossa.org
Review URL: https://chromiumcodereview.appspot.com/9328025
- 5:29 PM Changeset in webkit [106717] by
-
- 2 edits in trunk/Source/WebKit2
[WK2 Mac] No need to allow access to input methods or keyboard layouts
https://bugs.webkit.org/show_bug.cgi?id=77775
<rdar://problem/9276253>
<rdar://problem/9276268>
Reviewed by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb: These rules were likely only necessary in early days
of WebKit2. If there are cases when this happens, that's likely wrong, and we need to know
about that.
- 5:26 PM Changeset in webkit [106716] by
-
- 1 edit in trunk/Tools/Scripts/update-webkit-dependency
Another http -> https fix for curl
- 5:22 PM Changeset in webkit [106715] by
-
- 3 edits2 adds in trunk
Crash in Node::dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=77449
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The bug was caused by appendChild not retaining this pointer.
This is normally okay because there's another owner within JSC/V8 binding code that
holds onto the node but this isn't the case when nodes are created as a part
of setting document.title. Fixed the crash by retaining the pointer as needed.
Test: fast/dom/remove-body-during-title-creation.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::appendChild):
LayoutTests:
Add a regression test for the crash.
- fast/dom/remove-body-during-title-creation-expected.txt: Added.
- fast/dom/remove-body-during-title-creation.html: Added.
- 5:19 PM Changeset in webkit [106714] by
-
- 2 edits in trunk/Tools
Perf bot build fix.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_json):
- 5:18 PM Changeset in webkit [106713] by
-
- 6 edits in trunk/Tools
Add a blank "Expected Failures" tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=77793
Reviewed by Eric Seidel.
This tab will help us explore and manage our expected failures. The
tab is hidden by default via a new "experimental features" flag.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#unexpected):
(#onebar.partytime #unexpected):
- 5:09 PM Changeset in webkit [106712] by
-
- 2 edits in trunk/Tools/Scripts
Fix other instances of http://developer links which should be https://developer
- 5:05 PM Changeset in webkit [106711] by
-
- 6 edits in trunk/Source/WebCore
Apply changed properties from the updated scrolling tree state
https://bugs.webkit.org/show_bug.cgi?id=77792
Reviewed by Andreas Kling.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
Update the tree node properties from the scrolling tree state.
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::scrollingTree):
(WebCore::ScrollingTreeNode::viewportRect):
(WebCore::ScrollingTreeNode::contentsSize):
Add getters.
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::changedProperties):
New function for accessing the changed properties of the scrolling tree state.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Update the scroll layer from the scrolling tree if necessary.
- 4:57 PM Changeset in webkit [106710] by
-
- 1 edit in trunk/Tools/Scripts/update-webkit-support-libs
Fix URL string
- 4:31 PM Changeset in webkit [106709] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Use properly quoted string literals
https://bugs.webkit.org/show_bug.cgi?id=77583
Reviewed by Darin Adler.
Also added some FIXMEs.
- WebProcess/com.apple.WebProcess.sb:
- 4:29 PM Changeset in webkit [106708] by
-
- 2 edits in trunk/Tools
update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=77785
Fix the build bots.
Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
- Scripts/update-webkit-support-libs:
(downloadExpectedVersionNumber):
- 4:24 PM Changeset in webkit [106707] by
-
- 2 edits in trunk/Source/JavaScriptCore
Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
https://bugs.webkit.org/show_bug.cgi?id=77788
Reviewed by Andreas Kling.
The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.
- wtf/FastAllocBase.h:
- 4:22 PM Changeset in webkit [106706] by
-
- 10 edits in trunk/Source
2012-02-03 Brady Eidson <beidson@apple.com>
<rdar://problem/10742441> and https://bugs.webkit.org/show_bug.cgi?id=77766
Need a WK2 API to filter which subframes go into WebArchives as they are created.
Reviewed by Darin Adler.
Source/WebCore:
This adds a filter callback object that allows clients to get called back for each
subframe that might be added to a WebArchive.
API only, No new layout tests.
- WebCore.exp.in:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):
- loader/archive/cf/LegacyWebArchive.h:
(FrameFilter):
(WebCore:: FrameFilter::~ FrameFilter):
(LegacyWebArchive):
Source/WebKit2:
Add a new WKBundleFrame API that takes a filter callback object to allow or reject
subframes from a WebArchive:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyWebArchive):
(WKBundleFrameCopyWebArchiveFilteringSubframes):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Implement the above API by calling through to WebCore:
- WebProcess/WebPage/WebFrame.cpp:
(WebFrameFilter):
(WebKit::WebFrameFilter::WebFrameFilter):
(WebKit::WebFrameFilter::shouldIncludeSubframe):
(WebKit::WebFrame::webArchiveData):
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
- 4:16 PM Changeset in webkit [106705] by
-
- 4 edits2 adds in trunk
IndexedDB: Key generators not rolled back if insertion fails or is aborted
https://bugs.webkit.org/show_bug.cgi?id=77060
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/key-generator.html
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put): Add abort task to reset cache.
(WebCore::IDBObjectStoreBackendImpl::revertAutoIncrementKeyCache):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal): Reset cache on error.
- storage/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
LayoutTests:
- storage/indexeddb/key-generator-expected.txt: Added.
- storage/indexeddb/key-generator.html: Added.
- 4:10 PM Changeset in webkit [106704] by
-
- 3 edits2 adds in trunk
positive and negative flex values are not being cleared on style changes
https://bugs.webkit.org/show_bug.cgi?id=77771
Reviewed by Ojan Vafai.
Source/WebCore:
If the width or height was a flex() value, but is no longer a flex
value, we weren't clearing the positive and negative flex values in
RenderStyle.
Test: css3/flexbox/flex-no-flex.html
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
LayoutTests:
- css3/flexbox/flex-no-flex-expected.txt: Added.
- css3/flexbox/flex-no-flex.html: Added.
- 4:01 PM Changeset in webkit [106703] by
-
- 3 edits in trunk/Tools
Add a Mac Lion Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=77765
Reviewed by Adam Roben.
This will update the master configuration in the following ways:
Add a new performance slave (apple-xseve-11)
Add a new Factory to download a build and run perf tests.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadAndPerfTestFactory):
(DownloadAndPerfTestFactory.init):
- 3:53 PM Changeset in webkit [106702] by
-
- 1 edit1 delete in trunk/Tools
Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
https://bugs.webkit.org/show_bug.cgi?id=77752
Reviewed by James Robinson.
Delete unneeded file accidentally checked in in r106481.
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
- 3:47 PM Changeset in webkit [106701] by
-
- 3 edits in trunk/Source/WebKit2
[Mac WK2] Use a minimally invasive way to fake plug-in process name
https://bugs.webkit.org/show_bug.cgi?id=77682
Reviewed by Darin Adler.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::netscapePluginModule):
Only change the name as it's seen from within the process.
- Shared/Plugins/PluginQuirks.h: Fixed a typo.
- 3:18 PM Changeset in webkit [106700] by
-
- 20 edits in trunk/Source
[chromium] Defer makeContextCurrent in compositor until first frame
https://bugs.webkit.org/show_bug.cgi?id=77269
Reviewed by Kenneth Russell.
Source/WebCore:
There are situations where we need to instantiate a compositor, but can't call makeContextCurrent() until some
initialization work completes on another thread that we cannot block for. This defers the first
makeContextCurrent() call until we need to produce the first frame at which point we know the call can succeed,
assuming that the scheduler does the right thing.
This is accomplished by splitting up proxy initialization into two pieces:
*) initializeContext() which attempts to instantiate a GraphicsContext3D. This can fail if we can't make a
context at all, in which case we abort completely and return NULL from CCLayerTreeHost::create().
*) initializeLayerRenderer() which uses the previously-created context to instantiate our compositor objects and
grab our renderer capabilities. This can fail if the context is not usable for compositing, which we report
to the client as a lost context event.
Internally this introduces a new state to the CCLayerTreeHostImpl where it has a context but does not yet have a
LayerRendererChromium, which has fairly minimal impact. One other change is that we don't instantiate the
TextureManagers until we have the renderer capabilities, but this isn't necessary until we want to start
painting so it doesn't have any impact outside of some overly intrustive unit tests.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::setSampledTexelFormat):
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
():
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::isContextLost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeContext):
(WebCore):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 3:13 PM Changeset in webkit [106699] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed compile fix for chromium - add commas after entries in list in WebCore.gypi
- WebCore.gypi:
- 3:03 PM Changeset in webkit [106698] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed build fix attempt after r106695.
CSSMutableStyleDeclaration was renamed to StylePropertySet.
- bindings/scripts/CodeGeneratorCPP.pm:
(AddIncludesForType):
- bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8Proxy.cpp:
- 2:52 PM Changeset in webkit [106697] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Let userIdleTime() return maximum number instead of 0 as
most of other ports do.
https://bugs.webkit.org/show_bug.cgi?id=77769
Patch by Yong Li <yoli@rim.com> on 2012-02-03
Reviewed by Rob Buis.
userIdleTime() should return a big number so it won't block page cache
from releasing cached pages. See PageCache::releaseAutoreleasedPagesNowOrReschedule().
No new tests as no visible functional changes.
- platform/blackberry/SystemTimeBlackBerry.cpp:
(WebCore::userIdleTime):
- 2:46 PM Changeset in webkit [106696] by
-
- 6 edits4 copies in trunk/Source/WebCore
Commit scrolling tree state changes to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=77780
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::commitTreeState):
Send the new scrolling tree state over to the ScrollingTree on the scrolling thread.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Create a root node.
(WebCore::ScrollingTree::commitNewTreeState):
Update the root node.
- page/scrolling/ScrollingTreeNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
- page/scrolling/ScrollingTreeNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
Stub out an abstract ScrollingTreeNode class.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
Update the scroll layer on the tree state.
- page/scrolling/mac/ScrollingTreeNodeMac.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
- page/scrolling/mac/ScrollingTreeNodeMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
Stub out the concrete ScrollingTreeNodeMac subclass.
- 2:41 PM Changeset in webkit [106695] by
-
- 49 edits2 moves in trunk/Source
Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=77779
Reviewed by Darin Adler.
Source/WebCore:
Match the new class name.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue):
- bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
- css/CSSAllInOne.cpp:
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSFontFaceRule.cpp:
- css/CSSFontFaceRule.h:
- css/CSSFontSelector.cpp:
- css/CSSMutableStyleDeclaration.cpp: Removed.
- css/CSSMutableStyleDeclaration.h: Removed.
- css/CSSPageRule.cpp:
- css/CSSParser.cpp:
- css/CSSStyleRule.cpp:
- css/CSSStyleRule.h:
- css/StylePropertySet.cpp: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.cpp.
- css/StylePropertySet.h: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.h.
- css/WebKitCSSKeyframeRule.cpp:
- css/WebKitCSSKeyframeRule.h:
- css/WebKitCSSKeyframesRule.cpp:
- css/WebKitCSSMatrix.cpp:
- dom/CSSMappedAttributeDeclaration.h:
- dom/ElementAttributeData.h:
- dom/StyledElement.cpp:
- dom/StyledElement.h:
- editing/ApplyStyleCommand.cpp:
- editing/DeleteButtonController.cpp:
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
- editing/EditorCommand.cpp:
- editing/RemoveCSSPropertyCommand.cpp:
- editing/ReplaceSelectionCommand.cpp:
- editing/markup.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/shadow/MeterShadowElement.cpp:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorDOMAgent.cpp:
- page/DragController.cpp:
- page/Frame.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderTreeAsText.cpp:
- svg/SVGFontFaceElement.h:
(WebCore):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
Source/WebKit/qt:
- Api/qwebelement.cpp:
- 2:23 PM Changeset in webkit [106694] by
-
- 9 edits4 adds in trunk
Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=77474
Reviewed by David Hyatt.
Source/WebCore:
Flexbox and deprecated flexible box should also compute their region range
when they are part of a named flow. Until now, only RenderBlock elements
were doing that. Flexbox and deprecated flexible box, while implementing
their own layoutBlock method, were not doing that.
Tests: fast/regions/flexbox-in-region-crash.html
fast/regions/select-in-region-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
- fast/regions/flexbox-in-region-crash-expected.txt: Added.
- fast/regions/flexbox-in-region-crash.html: Added.
- fast/regions/select-in-region-crash-expected.txt: Added.
- fast/regions/select-in-region-crash.html: Added.
- 2:07 PM Changeset in webkit [106693] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Fixing a use of enclosingIntRect in Accessibility code. Should be pixelSnapped instead.
- 1:48 PM Changeset in webkit [106692] by
-
- 7 edits in trunk/Tools
Ref Tests should support plain SVG files
https://bugs.webkit.org/show_bug.cgi?id=77685
Reviewed by Tony Chang.
Don't assume reference files always use .html as the extension.
Instead, use the list of supported extension to look for -expected.* and -mismatch.*
Also fix various bugs in MockFileSystem and TestPort.
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.isdir):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_is_test_file):
(PortTest.test_reference_files):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestInstance.init):
- 1:28 PM Changeset in webkit [106691] by
-
- 5 edits in branches/chromium/1025/Source
Merge 106663 - [Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.
Source/WebCore:
New unit test in PlatformContextSkiaTest.cpp
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
- platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9328008
- 1:25 PM Changeset in webkit [106690] by
-
- 6 edits in trunk/Source/WebCore
Update the tree state after layout and add a way to commit it
https://bugs.webkit.org/show_bug.cgi?id=77767
Reviewed by Andreas Kling.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Call ScrollingCoordinator::frameViewLayoutUpdated if we have a scrolling coordinator.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Initialize m_scrollingTreeStateCommitterTimer.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Update the viewport rect and contents size of the frame view.
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
Schedule a tree state commit unless we've already scheduled one or there are no changed properties.
(WebCore::ScrollingCoordinator::scrollingTreeStateCommitterTimerFired):
Call commitTreeState().
(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
Commit the tree state unless there are no changed properties.
(WebCore::ScrollingCoordinator::commitTreeState):
Commit the tree state. We currently don't do anything with the committed state yet.
- page/scrolling/ScrollingCoordinator.h:
Add new member functions and the timer member variable.
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::commit):
Copy the current tree state and restore the changed properties on the original.
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::hasChangedProperties):
Return whether there are any changed properties in the tree state.
- 1:25 PM Changeset in webkit [106689] by
-
- 2 edits in trunk/LayoutTests
complete rebaseline of box-shadow-clipped-slices
https://bugs.webkit.org/show_bug.cgi?id=77565
Patch by Elliot Poger <epoger@google.com> on 2012-02-03
Reviewed by Darin Adler.
- platform/chromium/test_expectations.txt:
- 1:13 PM Changeset in webkit [106688] by
-
- 2 edits in trunk
[GTK] configure: Print out the -Wno-c++0x-compat test result
https://bugs.webkit.org/show_bug.cgi?id=77757
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-03
Reviewed by Martin Robinson.
The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.
checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes
- configure.ac:
- 1:10 PM Changeset in webkit [106687] by
-
- 15 edits in trunk
perf-o-matic should store chromium svn revision
https://bugs.webkit.org/show_bug.cgi?id=77725
Reviewed by Dirk Pranke.
.:
Store both WebKit and Chromium revisions when both are reported.
- Websites/webkit-perf.appspot.com/models.py:
(Build):
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):
- Websites/webkit-perf.appspot.com/static/manual-submit.html:
Tools:
Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
is implemented in terms of newly added svn_revision.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.svn_revision):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.head_svn_revision):
(SCM):
(SCM.svn_revision):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.svn_revision):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.svn_revision):
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.init):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase._insert_generic_metadata):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.repository_paths):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_json):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
- 12:59 PM Changeset in webkit [106686] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368
Patch by Rob Buis <rbuis@rim.com> on 2012-02-03
Reviewed by Filip Pizlo.
Use reinterpret_cast_ptr and static_cast to get rid of alignment issues in ARMv7 code.
- heap/HandleTypes.h:
(JSC::HandleTypes::getFromSlot):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::forEachCell):
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::unvalidatedGet):
- 12:57 PM Changeset in webkit [106685] by
-
- 2 edits in trunk/Source/WebCore
HTMLElement: Clean up tabindex attribute parsing.
<http://webkit.org/b/77763>
Reviewed by Antti Koivisto.
Remove an unnecessary getAttribute() call when parsing tabindexAttr.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- 12:46 PM Changeset in webkit [106684] by
-
- 3 edits in trunk/LayoutTests
Make js-test-pre.js more worker friendly
https://bugs.webkit.org/show_bug.cgi?id=77487
Replace uses of 'window' with 'self'.
Reviewed by Ojan Vafai.
- fast/js/resources/js-test-pre.js:
- storage/indexeddb/resources/basics.js:
- 12:22 PM Changeset in webkit [106683] by
-
- 3 edits1 copy in trunk/Source/WebCore
ScrollingTreeState should keep track of the scroll layer
https://bugs.webkit.org/show_bug.cgi?id=77762
Reviewed by Andreas Kling.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingTreeState.h:
(ScrollingTreeState):
- page/scrolling/mac/ScrollingTreeStateMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTreeState.h.
(WebCore):
(WebCore::ScrollingTreeState::platformScrollLayer):
(WebCore::ScrollingTreeState::setScrollLayer):
- 12:08 PM Changeset in webkit [106682] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/page/DOMTimer.cpp
Merge 106636 - Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692
Reviewed by Alexey Proskuryakov.
In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317088
- 11:46 AM Changeset in webkit [106681] by
-
- 63 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=77740
Split CSSMutableStyleDeclaration into separate internal and CSSOM types
Reviewed by Andreas Kling and Darin Adler.
Source/WebCore:
Split the CSSMutableStyleDeclaration into an internal type (StylePropertySet) and a CSSOM implementation type (PropertySetCSSStyleDeclaration).
To keep things somewhat manageable, this patch does NOT
- rename or add any files (so files names won't match types)
- rename fields, methods or variables to match new type names (like CSSStyleRule::declaration() -> CSSStyleRule::propertySet())
- try to realize any memory or performance gains (StylePropertySet loses the vptr but gains PropertySetCSSStyleDeclaration*)
- WebCore.exp.in:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copy):
(WebCore::CSSComputedStyleDeclaration::makeMutable):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
- css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
(WebCore::CSSFontFaceRule::setDeclaration):
(CSSFontFaceRule):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSMutableStyleDeclaration.cpp:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::create):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::deref):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setNeedsStyleRecalc):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::copyBlockProperties):
(WebCore::StylePropertySet::removeBlockProperties):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::parentRule):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
- css/CSSMutableStyleDeclaration.h:
(WebCore):
(StylePropertySet):
(WebCore::StylePropertySet::create):
(WebCore::StylePropertySet::createInline):
- css/CSSPageRule.h:
(WebCore):
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
- css/CSSParser.h:
(WebCore):
(CSSParser):
- css/CSSStyleDeclaration.h:
(WebCore):
(CSSStyleDeclaration):
- css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
(WebCore::CSSStyleRule::declaration):
(CSSStyleRule):
- css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::matchPageRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(MatchedStyleDeclaration):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
- css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- dom/Attr.h:
(WebCore::Attr::style):
- dom/Attribute.h:
(WebCore::Attribute::decl):
- dom/CSSMappedAttributeDeclaration.h:
(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
(CSSMappedAttributeDeclaration):
- dom/Document.cpp:
(WebCore::Document::createCSSStyleDeclaration):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::ensureInlineStyleDecl):
- dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore):
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(HTMLAttributeEquivalent):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::EditingStyle):
(WebCore::getRGBAFontColor):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::EditingStyle::forceInline):
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::getTextAlignment):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::isTransparentColorValue):
(WebCore::hasTransparentBackgroundColor):
- editing/EditingStyle.h:
(WebCore):
(WebCore::EditingStyle::create):
(EditingStyle):
(WebCore::EditingStyle::style):
(StyleChange):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::applyEditingStyleToElement):
- editing/EditorCommand.cpp:
(WebCore::applyCommandToFrame):
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- editing/FrameSelection.h:
(WebCore):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/ReplaceSelectionCommand.h:
(WebCore):
- editing/markup.cpp:
(WebCore):
(StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
- page/PageSerializer.h:
(WebCore):
(PageSerializer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 11:32 AM Changeset in webkit [106680] by
-
- 6 edits3 adds in trunk
Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
https://bugs.webkit.org/show_bug.cgi?id=76704
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/isolatedWorld/sandboxed-iframe.html
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::callListenerFunction):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::toV8Context):
LayoutTests:
- http/tests/security/isolatedWorld/resources/fail.html:
- http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
- http/tests/security/isolatedWorld/sandboxed-iframe.html:
- 11:30 AM Changeset in webkit [106679] by
-
- 4 edits2 adds in trunk/Source/WebCore
Add ScrollingTreeState class
https://bugs.webkit.org/show_bug.cgi?id=77756
Reviewed by Andreas Kling.
Add a new ScrollingTreeState whose intent is to be a data container for the current
scrolling tree state. the ScrollingCoordinator class will update it and periodically
send over the new state to the ScrollingTree object on the scrolling thread.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
- page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
- page/scrolling/ScrollingTreeState.cpp: Added.
(WebCore):
(WebCore::ScrollingTreeState::create):
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::~ScrollingTreeState):
(WebCore::ScrollingTreeState::setViewportRect):
(WebCore::ScrollingTreeState::setContentsSize):
- page/scrolling/ScrollingTreeState.h: Added.
(WebCore):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::viewportRect):
(WebCore::ScrollingTreeState::contentsSize):
- 11:29 AM Changeset in webkit [106678] by
-
- 18 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=77691
Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
of device scale
Reviewed by Andy Estes.
Source/WebCore:
Make screenAvailableRect() and screenRect() take a Widget again instead of a
FrameView since taking a FrameView is a layering violation.
- WebCore.exp.in:
- platform/PlatformScreen.h:
(WebCore):
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/qt/PlatformScreenQt.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/wx/ScreenWx.cpp:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
It's wrong for the deviceScaleFactor to be taken into consideration here at
all.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):
Source/WebKit/chromium:
These two functions now take a Widget again rather than a FrameView.
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):
Source/WebKit/mac:
toUserSpace() and toDeviceSpace() don't need to take device scale. Also
restore a comment that I needlessly removed.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setWindowRect):
(WebChromeClient::windowRect):
Source/WebKit2:
toUserSpace() and toDeviceSpace() don't need to take device scale.
- UIProcess/API/mac/WKView.mm:
(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):
- 11:27 AM Changeset in webkit [106677] by
-
- 1 edit2 adds in trunk/Source/JavaScriptCore
Build fix
Unreviewed build fix
Forgot to add a couple files.
- heap/MarkedAllocator.cpp: Added.
(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
- heap/MarkedAllocator.h: Added.
(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):
- 11:21 AM Changeset in webkit [106676] by
-
- 13 edits in trunk/Source/JavaScriptCore
Refactor MarkedBlock::SizeClass into a separate class
https://bugs.webkit.org/show_bug.cgi?id=77600
Reviewed by Geoffrey Garen.
We pulled SizeClass out into its own class, named MarkedAllocator, and gave it
the responsibility of allocating objects from the collection of MarkedBlocks
that it manages. Also limited the amount of coupling to internal data fields
from other places, although it's mostly unavoidable in the JIT code.
Eventually MarkedAllocator will implement various policies to do with object
management, e.g. whether or not to run destructors on objects that it manages.
MarkedSpace will manage a collection of MarkedAllocators with varying policies,
as it does now but to a larger extent.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
- heap/Heap.cpp:
(JSC::Heap::collect):
(JSC::Heap::resetAllocators):
- heap/Heap.h:
(JSC::Heap::allocatorForObject):
(Heap):
- heap/MarkedAllocator.cpp: Added.
(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
- heap/MarkedAllocator.h: Added.
(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):
- heap/MarkedSpace.h:
(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAddBlock):
(JSC::MarkedSpace::didConsumeFreeList):
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
- 10:39 AM Changeset in webkit [106675] by
-
- 2 edits in branches/chromium/1025/Source/WebCore
Merge 106610 - Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9309085
- 10:25 AM Changeset in webkit [106674] by
-
- 2 edits in trunk
Added Radar links
- 10:23 AM Changeset in webkit [106673] by
-
- 3 edits2 adds in trunk
Floating image leaves hole in previous column when wrapped to next column
https://bugs.webkit.org/show_bug.cgi?id=77694
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/dynamic/float-moved-downwards-for-pagination-expected.html
fast/dynamic/float-moved-downwards-for-pagination.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats): When determining which lines to dirty,
also check for changes to the top edge of the float, which can happen when
float gets pushed down by a pagination strut.
LayoutTests:
- fast/dynamic/float-moved-downwards-for-pagination-expected.html: Added.
- fast/dynamic/float-moved-downwards-for-pagination.html: Added.
- 10:21 AM Changeset in webkit [106672] by
-
- 3 edits2 adds in trunk
REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491
Reviewed by Simon Fraser.
Source/WebCore:
The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).
Test: animations/animation-border-overflow.html
- platform/animation/AnimationUtilities.h:
(WebCore::blend):
LayoutTests:
- animations/animation-border-overflow-expected.txt: Added.
- animations/animation-border-overflow.html: Added.
- 10:02 AM Changeset in webkit [106671] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074
Reviewed by Csaba Osztrogonác.
Test http/tests/security/contentSecurityPolicy/eval-blocked.html
is now passing, unskipping it.
- platform/qt-wk2/Skipped:
- 9:38 AM Changeset in webkit [106670] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] ImageBufferSkia: remove unnecessary overload of flush in
AcceleratedDeviceContext
https://bugs.webkit.org/show_bug.cgi?id=77741
Patch by Justin Novosad <junov@chromium.org> on 2012-02-03
Reviewed by Stephen White.
Removing dead code.
- platform/graphics/skia/ImageBufferSkia.cpp:
(AcceleratedDeviceContext):
- 9:31 AM Changeset in webkit [106669] by
-
- 3 edits in trunk/Source/WebKit/chromium
[skia] Fix unit test PlatformContextSkiaTest.trackOpaqueOvalTest
https://bugs.webkit.org/show_bug.cgi?id=77738
We need to clear the bitmap before the test runs, otherwise the
contents of the bitmap will be uninitialised. This causes an
unpredicatable result as the canvas draw operations blend the
destination bitmap with the source colour.
Similarly, valgrind discovered that
PlatformContextSkiaTest.trackOpaqueTest and
PlatformContextSkiaTest.trackOpaqueLineTest suffers from the same
problem.
Also, re-enable WebFrameTest.FindInPage which was falsely
blamed for making this test fail.
Reviewed by Stephen White.
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- tests/WebFrameTest.cpp:
(WebKit::TEST_F):
- 9:02 AM Changeset in webkit [106668] by
-
- 2 edits in trunk/Source/WebCore
Speculative unreviewed build fix for Qt-Windows
after http://trac.webkit.org/changeset/106659.
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::platformCreateAccelerated):
- 8:56 AM Changeset in webkit [106667] by
-
- 35 edits4 deletes in trunk
Unreviewed, rolling out r106654.
http://trac.webkit.org/changeset/106654
https://bugs.webkit.org/show_bug.cgi?id=77742
triggers asserts on mac, win, gtk, qt debug bots (Requested by
philn-tp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-03
Source/WebCore:
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::create):
- bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
- dom/ActiveDOMObject.h:
(ActiveDOMObject):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
- fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::create):
- fileapi/FileReader.cpp:
(WebCore):
- fileapi/FileReader.h:
(WebCore::FileReader::create):
- fileapi/FileWriter.cpp:
(WebCore):
- fileapi/FileWriter.h:
(WebCore::FileWriter::create):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::create):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::create):
- notifications/Notification.cpp:
(WebCore::Notification::create):
- notifications/NotificationCenter.cpp:
- notifications/NotificationCenter.h:
(WebCore::NotificationCenter::create):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
- page/EventSource.cpp:
(WebCore::EventSource::create):
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
- websockets/WebSocket.cpp:
- websockets/WebSocket.h:
(WebCore::WebSocket::create):
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/Worker.cpp:
(WebCore::Worker::create):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
LayoutTests:
- fast/events/resources/suspend-subframe-1.html: Removed.
- fast/events/resources/suspend-subframe-2.html: Removed.
- fast/events/suspend-timers-expected.txt: Removed.
- fast/events/suspend-timers.html: Removed.
- platform/chromium/test_expectations.txt:
- 8:53 AM Changeset in webkit [106666] by
-
- 27 edits in trunk/Source/WebCore
Add the "V8" prefix to V8 specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77713
Reviewed by Adam Barth.
This patch adds the "V8" prefix to a V8 specific IDL attribute:
[EnabledAtRuntime] => [V8EnabledAtRuntime]
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
(GetRuntimeEnableFunctionName):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: Updated the run-bindings-tests results.
(WebCore::ConfigureV8TestObjTemplate):
- Modules/gamepad/NavigatorGamepad.idl:
- dom/Clipboard.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/MouseEvent.idl:
- dom/ShadowRoot.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLTrackElement.idl:
- html/TextTrack.idl:
- html/TextTrackCue.idl:
- html/TextTrackCueList.idl:
- html/shadow/HTMLContentElement.idl:
- html/track/TextTrackList.idl:
- html/track/TrackEvent.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Navigator.idl:
- storage/DOMWindowSQLDatabase.idl:
- webaudio/DOMWindowWebAudio.idl:
- websockets/DOMWindowWebSocket.idl:
- workers/WorkerContext.idl:
- xml/XMLHttpRequest.idl:
- 8:50 AM Changeset in webkit [106665] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Retained size for classes is too conservative in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=77726
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-03
Reviewed by Yury Semikhatsky.
Makes retained size of all objects of particular class show correct value
in Summary view of heap profiler.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):
- 8:43 AM Changeset in webkit [106664] by
-
- 5 edits2 adds in trunk
Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements
https://bugs.webkit.org/show_bug.cgi?id=77619
Reviewed by Vsevolod Vlasov.
Source/WebCore:
XPath is optimized whenever an element has the "id" attribute.
Test: inspector/elements/node-xpath.xhtml
- English.lproj/localizedStrings.js:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.XPathStep):
(WebInspector.DOMNode.XPathStep.prototype.toString):
(WebInspector.DOMNode.prototype.copyXPath):
(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMNode.prototype.xPath):
(WebInspector.DOMNode.prototype._xPathValue):
(WebInspector.DOMNode.prototype._xPathIndex):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):
LayoutTests:
- inspector/elements/node-xpath-expected.txt: Added.
- inspector/elements/node-xpath.xhtml: Added.
- 8:28 AM Changeset in webkit [106663] by
-
- 5 edits in trunk/Source
[Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.
Source/WebCore:
New unit test in PlatformContextSkiaTest.cpp
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
- platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
- 8:20 AM Changeset in webkit [106662] by
-
- 10 edits in trunk
inspector/debugger/pause-in-inline-script.html asserts in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=77663
Source/WebCore:
Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.
Reviewed by Pavel Feldman.
Test: inspector/debugger/pause-in-inline-script.html
- bindings/js/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):
- bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didFinishLoading):
LayoutTests:
Reviewed by Pavel Feldman.
- platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html
- 7:56 AM Changeset in webkit [106661] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106560 - Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/updates-during-dom-traversal.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
LayoutTests:
- inspector/styles/updates-during-dom-traversal-expected.txt: Added.
- inspector/styles/updates-during-dom-traversal.html: Added.
TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310084
- 7:07 AM Changeset in webkit [106660] by
-
- 19 edits in trunk/Source/WebCore
Fix typo
https://bugs.webkit.org/show_bug.cgi?id=77708
Reviewed by Adam Roben.
This patch fixes typos: [ObjCLegacyUnamedParameters] => [ObjCLegacyUnnamedParameters]
No tests. No change in behavior.
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventTarget.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/Range.idl:
- dom/UIEvent.idl:
- html/HTMLSelectElement.idl:
- xml/XPathExpression.idl:
- 6:59 AM Changeset in webkit [106659] by
-
- 19 edits2 adds2 deletes in trunk/Source
[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148
Reviewed by Martin Robinson.
Source/WebCore:
Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.
To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.
Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689
Covered extensively by existing tests, no behavioral changes.
- Target.pri:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
- platform/graphics/cairo/TextureMapperCairo.cpp:
- platform/graphics/opengl/TextureMapperGL.cpp:
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):
- platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):
- platform/graphics/qt/TextureMapperQt.cpp: Removed.
- platform/graphics/qt/TextureMapperQt.h: Removed.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
- platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):
Source/WebKit/qt:
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
Source/WebKit2:
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
- 6:47 AM Changeset in webkit [106658] by
-
- 25 edits1 copy1 move1 add1 delete in trunk
[Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
https://bugs.webkit.org/show_bug.cgi?id=77632
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Replace the runtime property setting the desktop behavior on each instance
by a static boolean controlling the behavior used by future created WebViews.
- UIProcess/API/qt/qquickwebpage.cpp:
Let only setContentsSize control the size of the drawing area instead of deferring
it until geometryChanged is called.
(QQuickWebPagePrivate::QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
(createPrivateObject):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::loadDidCommit):
(QQuickWebViewFlickablePrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
(QQuickWebViewFlickablePrivate::PostTransitionState::apply):
(QQuickWebViewExperimental::setFlickableViewportEnabled):
The switch is now a static function that has to be called before a WebView
is created. The switch can have it's default defined by the deploying platform.
(QQuickWebViewExperimental::flickableViewportEnabled):
(QQuickWebView::QQuickWebView):
On creation of QQuickWebView, the static boolean is read to know if we want
a QQuickWebViewTouchPrivate or a QQuickWebViewDesktopPrivate.
(QQuickWebView::geometryChanged):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(PostTransitionState):
(QQuickWebViewFlickablePrivate::PostTransitionState::PostTransitionState):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
- UIProcess/API/qt/tests/publicapi/publicapi.pro:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Added.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Renamed
from Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml.
Moved to DesktopBehavior instead of using a DesktopWebView to workaround the touch event limitation.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
- UIProcess/API/qt/tests/qmltests/WebView.pro: Copied
from Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.
- UIProcess/API/qt/tests/qmltests/qmltests.pro:
Split qmltests in two executables, tst_qmltests_DesktopBehavior and tst_qmltests_WebView.
The former runs without setFlickableViewportEnabled and the later does.
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
- UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
- UIProcess/API/qt/tests/tests.pri:
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
Tools:
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::sendTouchEvent):
(MiniBrowserApplication::handleUserOptions):
- MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions):
(WindowOptions::WindowOptions):
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/qt/main.cpp:
(main):
- qmake/mkspecs/features/default_post.prf:
- 6:47 AM Changeset in webkit [106657] by
-
- 12 edits2 adds in trunk
Web Inspector: console evaluation doesn't work on breakpoint in pages with CSP
https://bugs.webkit.org/show_bug.cgi?id=77203
Inspector console evaluation now works when debugger is paused in a page with
content-security-policy prohibiting evals.
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/eval-on-pause-blocked.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/ScriptState.cpp:
(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):
- bindings/js/ScriptState.h:
(WebCore):
- bindings/v8/ScriptObject.h:
(WebCore::ScriptObject::ScriptObject):
- bindings/v8/ScriptState.cpp:
(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):
- bindings/v8/ScriptState.h:
(WebCore):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::makeCall):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
- inspector/debugger/eval-on-pause-blocked-expected.txt: Added.
- inspector/debugger/eval-on-pause-blocked.html: Added.
- 6:44 AM Changeset in webkit [106656] by
-
- 8 edits in trunk/Source/WebKit2
[Qt] Rename content* to contents* in QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=77629
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::setContentsSize):
(QQuickWebPage::contentsSize):
(QQuickWebPage::setContentsScale):
(QQuickWebPage::contentsScale):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::contentsSize):
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::scaleContent):
- 6:05 AM Changeset in webkit [106655] by
-
- 4 edits in trunk/Source/WebCore
2012-02-03 Rob Buis <rbuis@rim.com>
Upstream targetType usage on ResourceRequest for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77649
Reviewed by Antonio Gomes.
Upstream bits that make use of targetType enum.
- loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation):
- platform/network/blackberry/ResourceRequest.h: (ResourceRequest): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::setTargetType):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):
- 5:42 AM Changeset in webkit [106654] by
-
- 35 edits4 adds in trunk
Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733
ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.
All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.
Test: fast/events/suspend-timers.html
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::create):
- bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
- dom/ActiveDOMObject.h:
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):
- fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::create):
- fileapi/FileReader.cpp:
(WebCore::FileReader::create):
- fileapi/FileReader.h:
- fileapi/FileWriter.cpp:
(WebCore::FileWriter::create):
- fileapi/FileWriter.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::create):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::create):
- notifications/Notification.cpp:
(WebCore::Notification::create):
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::create):
- notifications/NotificationCenter.h:
- page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
- page/EventSource.cpp:
(WebCore::EventSource::create):
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
- websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
- websockets/WebSocket.h:
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/Worker.cpp:
(WebCore::Worker::create):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.
- fast/events/resources/suspend-subframe-1.html: Added.
- fast/events/resources/suspend-subframe-2.html: Added.
- fast/events/suspend-timers-expected.txt: Added.
- fast/events/suspend-timers.html: Added.
- platform/chromium/test_expectations.txt:
- 5:36 AM Changeset in webkit [106653] by
-
- 2 edits in trunk/Source/WebKit/chromium
2012-02-03 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium deps.
- DEPS:
- 5:23 AM Changeset in webkit [106652] by
-
- 2 edits in trunk/LayoutTests
New test introduced in r106642 failes on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=77729
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-02-03
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 5:05 AM Changeset in webkit [106651] by
-
- 4 edits in trunk/Source
[Qt] Fix build when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=77634
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
- WebKit2.pri: Link in -lrt on linux mkspecs, regardless of whether gcc
is in use or not. More specifically this fixes the case where the makespace
is not linux-g++* but for a cross-compiling one like linux-arm-gnueabi-g++.
Source/WTF:
- WTF.pri: Don't use icu-config for determining the library search
path and libraries needed for ICU. Either we use icu-config for includes
_and_ libraries or we don't. Right now we assume that icu is a system library
and expect the headers in the default include search pathes (/usr/include for example).
However we use icu-config to figure out where the libraries are, which breaks when
cross-compiling, because icu-config isn't cross-compile friendly (I wish icu was using
pkg-config). I think for the time being we should require ICU as a _system_ library,
which implies the header and library availability in default search paths. This also
makes the build succeed when cross-compiling with --sysroot.
- 4:51 AM Changeset in webkit [106650] by
-
- 6 edits1 delete in trunk
[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
https://bugs.webkit.org/show_bug.cgi?id=77723
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.
.:
- Source/api.pri: Remove use of GNU linker script on Linux.
- Source/qtwebkit-export.map: Removed.
Source/JavaScriptCore:
- wtf/Platform.h: Enable use of export macros.
Tools:
- Tools.pro: Compile WTR again on all platforms with WK2.
- 4:49 AM Changeset in webkit [106649] by
-
- 2 edits in trunk/Source/WebCore
Do not ASSERT on TouchStationary TouchPoint state.
https://bugs.webkit.org/show_bug.cgi?id=77620
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Kenneth Rohde Christiansen.
- page/EventHandler.cpp:
(WebCore::eventNameForTouchPointState): Explicitly show that TouchStationary is asserted.
(WebCore::EventHandler::handleTouchEvent):
Remove TouchStationary from ASSERT. The value of HitTestRequest is restored to the
value it should have if hittested, but is not used.
- 4:14 AM Changeset in webkit [106648] by
-
- 25 edits in trunk/Source/WebCore
Add the "ObjC" prefix to ObjC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77708
Reviewed by Adam Barth.
This patch adds the "ObjC" prefix to ObjC specific IDL attributes, as follows:
[Polymorphic] => [ObjCPolymorphic]
[OldStyleObjC] => [ObjCLegacyUnamedParameters]
[UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventTarget.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/Range.idl:
- dom/UIEvent.idl:
- html/HTMLCollection.idl:
- html/HTMLSelectElement.idl:
- svg/SVGPathSeg.idl:
- xml/XPathExpression.idl:
- 4:02 AM Changeset in webkit [106647] by
-
- 2 edits in trunk/Tools
Ensure that inspector disabled build works
https://bugs.webkit.org/show_bug.cgi?id=77604
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.
- qmake/mkspecs/features/features.prf:
- 3:39 AM Changeset in webkit [106646] by
-
- 2 edits in trunk/Source/WebCore
TypingCommand should be prepared against detached document.
https://bugs.webkit.org/show_bug.cgi?id=77216
Reviewed by Ryosuke Niwa.
Added null checks for document()->frame().
No new tests. Just tighten guards for possible codepaths.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
- 3:05 AM Changeset in webkit [106645] by
-
- 26 edits in trunk/Source/WebCore
Rename [DontEnum] IDL to [NotEnumerable] IDL
https://bugs.webkit.org/show_bug.cgi?id=77710
Reviewed by Adam Barth.
[DontEnum] is a negation of Enumerable in the ECMAScript spec
(8.6.1 of http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf).
This patch renames [DontEnum] to [NotEnumerable].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- css/WebKitCSSMatrix.idl:
- dom/DOMCoreException.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/EventException.idl:
- dom/RangeException.idl:
- fileapi/FileException.idl:
- fileapi/OperationNotAllowedException.idl:
- html/DOMTokenList.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLBodyElement.idl:
- html/HTMLFrameSetElement.idl:
- html/HTMLInputElement.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/Location.idl:
- storage/IDBDatabaseException.idl:
- storage/Storage.idl:
- svg/SVGElementInstance.idl:
- svg/SVGException.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequestException.idl:
- xml/XPathException.idl:
- 3:02 AM Changeset in webkit [106644] by
-
- 21 edits in trunk/Source/WebCore
Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=77711
Reviewed by Adam Barth.
[InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
is specified on the interface. This patch renames [InitializedByConstructor] to
[InitializedByEventConstructor] for clarification.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateEventConstructorCallback):
- bindings/scripts/test/TestEventConstructor.idl:
- bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.
(WebCore):
- dom/BeforeLoadEvent.idl:
- dom/CustomEvent.idl:
- dom/ErrorEvent.idl:
- dom/Event.idl:
- dom/HashChangeEvent.idl:
- dom/MessageEvent.idl:
- dom/OverflowEvent.idl:
- dom/PageTransitionEvent.idl:
- dom/PopStateEvent.idl:
- dom/ProgressEvent.idl:
- dom/WebKitAnimationEvent.idl:
- dom/WebKitTransitionEvent.idl:
- html/canvas/WebGLContextEvent.idl:
- html/track/TrackEvent.idl:
- storage/StorageEvent.idl:
- websockets/CloseEvent.idl:
- 2:31 AM Changeset in webkit [106643] by
-
- 6 edits in trunk/Source/WebCore
Add the "CPP" prefix to CPP specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77707
Reviewed by Adam Barth.
This patch adds the "CPP" prefix to a CPP specific IDL attribute.
Specifically, this patch renames [PureInterface] to [CPPPureInterface]
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
(GenerateImplementation):
- css/MediaQueryListListener.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/NodeFilter.idl:
- 2:10 AM Changeset in webkit [106642] by
-
- 10 edits2 adds in trunk
Implement touch event emulation in the WebCore layer
https://bugs.webkit.org/show_bug.cgi?id=77105
Reviewed by Ryosuke Niwa.
Source/WebCore:
This change essentially maps mouse events into single-touch events in the following way:
- mousedown -> touchstart
- mouseup -> touchend
- mousemove -> touchmove (between mousedown and mouseup).
Test: fast/events/touch/emulate-touch-events.html
- page/EventHandler.cpp:
(SyntheticTouchPoint): A synthetic touch point built from PlatformMouseEvent.
(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):
(SyntheticSingleTouchEvent): A synthetic touch point event built from PlatformMouseEvent.
(WebCore::SyntheticSingleTouchEvent::SyntheticSingleTouchEvent):
(WebCore::EventHandler::handleMouseReleaseEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::handleMousePressEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::mouseMoved): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Dispatch a synthetic touch event if necessary.
- page/EventHandler.h: Added new method.
- page/Settings.cpp:
(WebCore::Settings::Settings): Added m_touchEventEmulationEnabled initializer.
- page/Settings.h: Added m_touchEventEmulationEnabled, getter, and setter.
(WebCore::Settings::setTouchEventEmulationEnabled): Added.
(WebCore::Settings::isTouchEventEmulationEnabled): Added.
- platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint): Unconditionally compile the parameterless ctor.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setTouchEventEmulationEnabled): Added for testing.
- testing/InternalSettings.h: Added setTouchEventEmulationEnabled() for testing.
- testing/InternalSettings.idl: Added setTouchEventEmulationEnabled() for testing.
LayoutTests:
- fast/events/touch/emulate-touch-events-expected.txt: Added.
- fast/events/touch/emulate-touch-events.html: Added.
- 2:04 AM Changeset in webkit [106641] by
-
- 2 edits in trunk/LayoutTests
Group all the security failures together.
- platform/chromium/test_expectations.txt:
- 2:01 AM Changeset in webkit [106640] by
-
- 3 edits in trunk/Source/WebCore
Remove [NoCPPCustom] IDL
https://bugs.webkit.org/show_bug.cgi?id=77704
Reviewed by Adam Barth.
This patch removes [NoCPPCustom], by replacing [Custom, NoCPPCustom]
in HTMLDocument.idl with [JSCCustom, V8Custom].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorCPP.pm:
(ShouldSkipType):
- html/HTMLDocument.idl:
- 1:54 AM Changeset in webkit [106639] by
-
- 5 edits in trunk/Source/WebCore
Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
https://bugs.webkit.org/show_bug.cgi?id=77706
Reviewed by Adam Barth.
This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
- bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 1:28 AM Changeset in webkit [106638] by
-
- 5 edits2 adds in trunk
Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/elements/move-node.html
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):
LayoutTests:
- inspector/elements/move-node-expected.txt: Added.
- inspector/elements/move-node.html: Added.
- 12:30 AM Changeset in webkit [106637] by
-
- 13 edits in trunk
Source/WebCore: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.
DETAILS is reimplemented using content element and its fallback feature.
We don't need to recreate DOM even if SUMMARY is removed from or added into DETAILS.
No new tests, should be covered by existing tests.
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::fallbackSummary):
Takes fallback element of content summary.
(DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):
Creates a fallback element also.
(WebCore):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::toggleOpen):
- html/HTMLDetailsElement.h:
(HTMLDetailsElement):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::isMainSummary):
LayoutTests: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930
Since the implementation of DETAILS shadow tree, the path of caret position is also changed.
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- 12:19 AM Changeset in webkit [106636] by
-
- 2 edits in trunk/Source/WebCore
Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692
Reviewed by Alexey Proskuryakov.
In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
- 12:16 AM Changeset in webkit [106635] by
-
- 8 edits in trunk
Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().
As a first step, this patch removes ensureShadowRoot() in Internals.
No new tests, because no changes in behavior.
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
Source/WebKit2:
Exports symbols.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Feb 2, 2012:
- 11:44 PM Changeset in webkit [106634] by
-
- 2 edits in trunk
<http://webkit.org/b/77717> Makefile should provide control over output verbosity
Allow the filtering of the output of our Makefile to be configured via a user default
and overriden via a command-line argument to make.
The Makefile takes the verbosity from BuildTranscriptVerbosity default in the
org.webkit.BuildConfiguration domain. The supported values are "default", "quiet"
and "noisy". "default" maintains the existing behavior of only filtering out
the setenv lines from Xcode's shell script build phases. "quiet" filters all output
through filter-build-webkit. "noisy" provides unfiltered output. The verbosity can
be overriden for a single invocation of make by specifying the VERBOSITY variable
on the make command line.
To always get full output:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity noisy
To always get filtered ouptut:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity quiet
To get full output for a single build:
make VERBOSITY=noisy
Reviewed by Dan Bernstein.
- Makefile.shared:
- 11:37 PM Changeset in webkit [106633] by
-
- 8 edits in trunk
Web Inspector: Always show percents together with counters in heap inspector.
https://bugs.webkit.org/show_bug.cgi?id=77434
Source/WebCore:
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype.get _isShowingAsPercent):
(WebInspector.DetailedHeapshotView.prototype._percentClicked):
- inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid span.percent-column):
LayoutTests:
Added parseInt conversion as counters are now strings not ints.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.
- inspector/profiler/detailed-heapshots-comparison-show-all.html:
- inspector/profiler/detailed-heapshots-comparison-show-next.html:
- inspector/profiler/detailed-heapshots-summary-show-all.html:
- 11:30 PM Changeset in webkit [106632] by
-
- 17 edits8 adds in trunk
Use content-language from http-equiv to set document locale and font
https://bugs.webkit.org/show_bug.cgi?id=76701
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-02
Reviewed by Darin Adler.
Source/WebCore:
So far, only content-language set through http-equiv is used; the HTTP Content-Language
header is not yet supported.
Tests: fast/text/content-language-case-insensitivity.html
fast/text/content-language-mapped-to-webkit-locale.html
fast/text/international/content-language-font-selection-expected.html
fast/text/international/content-language-font-selection.html
fast/text/international/content-language-with-subtags-expected.html
fast/text/international/content-language-with-subtags.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument): Use content language when selecting initial font.
- dom/Document.cpp:
(WebCore::Document::setContentLanguage): Recalculate style so language is taken into account.
(WebCore):
- dom/Document.h:
(Document):
LayoutTests:
Add tests that content-language from http-equiv sets document locale and is used in font selection.
- fast/text/content-language-case-insensitivity-expected.txt: Added.
- fast/text/content-language-case-insensitivity.html: Added.
- fast/text/content-language-mapped-to-webkit-locale-expected.txt: Added.
- fast/text/content-language-mapped-to-webkit-locale.html: Added.
- fast/text/international/content-language-font-selection-expected.html: Added.
- fast/text/international/content-language-font-selection.html: Added.
- fast/text/international/content-language-with-subtags-expected.html: Added.
- fast/text/international/content-language-with-subtags.html: Added.
- fast/text/lang-mapped-to-webkit-locale-expected.txt:
- fast/text/lang-mapped-to-webkit-locale.xhtml: Fix some style issues.
- fast/text/xml-lang-ignored-in-html-expected.txt:
- fast/text/xml-lang-ignored-in-html.html: Fix some style issues.
- platform/efl/Skipped: Skip tests using overridePreference("WebKit*FontMap"...) on non-Chromium ports.
- platform/gtk-wk2/Skipped: Ditto.
- platform/gtk/Skipped: Ditto.
- platform/mac/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- platform/win/Skipped: Ditto.
- platform/wincairo/Skipped: Ditto.
- platform/wk2/Skipped: Ditto.
- 11:12 PM Changeset in webkit [106631] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r106554.
- platform/qt/Skipped: Skip one more failing test.
- 10:59 PM Changeset in webkit [106630] by
-
- 19 edits2 adds2 deletes in trunk/Source
Unreviewed, rolling out r106620.
http://trac.webkit.org/changeset/106620
https://bugs.webkit.org/show_bug.cgi?id=77716
It broke non ENABLE(3D_RENDERING) builds (Requested by
Ossy_morning on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02
Source/WebCore:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
- platform/graphics/cairo/TextureMapperCairo.cpp:
(WebCore::TextureMapper::create):
(WebCore):
- platform/graphics/opengl/TextureMapperGL.cpp:
(Entry):
(DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::findOrCreate):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::deref):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::~DirectlyCompositedImageRepository):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::isOpaque):
(WebCore::BitmapTextureGL::pack):
(WebCore::BitmapTextureGL::unpack):
(WebCore::BitmapTextureGL::isPacked):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::updateRawContents):
(WebCore::BitmapTextureGL::setContentsToImage):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
- platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
(WebCore::TextureMapperGL::allowSurfaceForRoot):
(BGRA32PremultimpliedBuffer):
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
(WebCore):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/TextureMapperQt.cpp: Added.
(WebCore):
(WebCore::BitmapTextureQt::destroy):
(WebCore::BitmapTextureQt::reset):
(WebCore::BitmapTextureQt::beginPaint):
(WebCore::BitmapTextureQt::endPaint):
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BitmapTextureQt::save):
(WebCore::BitmapTextureQt::setContentsToImage):
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapperQt::beginClip):
(WebCore::TextureMapperQt::endClip):
(WebCore::TextureMapperQt::viewportSize):
(WebCore::TextureMapperQt::TextureMapperQt):
(WebCore::TextureMapperQt::setGraphicsContext):
(WebCore::TextureMapperQt::graphicsContext):
(WebCore::TextureMapperQt::bindSurface):
(WebCore::TextureMapperQt::drawTexture):
(WebCore::TextureMapper::create):
(WebCore::TextureMapperQt::createTexture):
(WebCore::BitmapTextureQt::BitmapTextureQt):
(WebCore::TextureMapperQt::beginPainting):
(WebCore::TextureMapperQt::endPainting):
(BGRA32PremultimpliedBufferQt):
(WebCore::BGRA32PremultimpliedBufferQt::beginPaint):
(WebCore::BGRA32PremultimpliedBufferQt::endPaint):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
(WebCore::uidForImage):
- platform/graphics/qt/TextureMapperQt.h: Added.
(WebCore):
(BitmapTextureQt):
(WebCore::BitmapTextureQt::~BitmapTextureQt):
(WebCore::BitmapTextureQt::size):
(WebCore::BitmapTextureQt::isValid):
(WebCore::BitmapTextureQt::sourceRect):
(WebCore::BitmapTextureQt::isPacked):
(WebCore::BitmapTextureQt::painter):
(TextureMapperQt):
(WebCore::TextureMapperQt::allowSurfaceForRoot):
(WebCore::TextureMapperQt::initialize):
(WebCore::TextureMapperQt::create):
(WebCore::TextureMapperQt::currentPainter):
- platform/graphics/texmap/TextureMapper.cpp:
- platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::allowOfflineTextureUpload):
(BitmapTexture):
(WebCore::BitmapTexture::pack):
(WebCore::BitmapTexture::unpack):
(WebCore::BitmapTexture::isPacked):
(WebCore::BitmapTexture::updateRawContents):
(WebCore::BitmapTexture::beginPaintMedia):
(WebCore::BitmapTexture::save):
(WebCore::BitmapTexture::lock):
(WebCore::BitmapTexture::unlock):
(WebCore::BitmapTexture::isLocked):
(TextureMapper):
(WebCore::TextureMapper::viewportSize):
(WebCore::TextureMapper::setViewportSize):
(WebCore::TextureMapper::allowPartialUpdates):
(WebCore::TextureMapper::isOpenGLBacked):
(WebCore::TextureMapper::setTransform):
(WebCore::TextureMapper::transform):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp: Removed.
- platform/graphics/texmap/TextureMapperImageBuffer.h: Removed.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
- platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):
Source/WebKit/qt:
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
Source/WebKit2:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
- 10:44 PM Changeset in webkit [106629] by
-
- 1 edit4 adds in trunk/LayoutTests
gradient tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75822
Reviewed by Hajime Morita.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/css3-radial-gradients-expected-mismatch.html: Added.
- css3/calc/css3-radial-gradients.html: Added.
- css3/calc/gradient-color-stops-expected-mismatch.html: Added.
- css3/calc/gradient-color-stops.html: Added.
- 9:44 PM Changeset in webkit [106628] by
-
- 2 edits in trunk/Source/WebCore
ColorInputType needs to use ensureInlineStyleDecl
https://bugs.webkit.org/show_bug.cgi?id=77699
Reviewed by Kent Tamura.
Because WebCore internally should use the more specific CSSMutableStyleDeclaration
http://trac.webkit.org/changeset/105739
- html/ColorInputType.cpp:
(WebCore::ColorInputType::updateColorSwatch):
- 9:42 PM Changeset in webkit [106627] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
https://bugs.webkit.org/show_bug.cgi?id=77586
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-02-02
Reviewed by Andreas Kling.
As both zoom and content size change are identified by model flag,
ewk_tiled_backing_store can not detect the conflict between them.
In order to prevent conflict between zoom and contents size change,
contentsSize flag is newly added.
- ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_contents_resize):
- 9:29 PM Changeset in webkit [106626] by
-
- 4 edits in trunk/Source/WebCore
Simplify SelectorChecker::checkSelector and checkOneSelector
https://bugs.webkit.org/show_bug.cgi?id=77697
Make use of Element::previous/nextElementSibling.
Made those methods inline.
Simplify code in checkSelector and checkOneSelector, esp. for first/nth/nth-last/last/only-child implementations.
Reviewed by Andreas Kling.
No new tests. (refactoring)
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::checkOneSelector):
- dom/Element.cpp:
- dom/Element.h:
(WebCore::Element::previousElementSibling):
(WebCore):
(WebCore::Element::nextElementSibling):
- 9:26 PM Changeset in webkit [106625] by
-
- 2 edits in trunk/Source/WebCore
ColorChooserClient is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=77698
Reviewed by Kent Tamura.
- platform/ColorChooserClient.h:
(WebCore::ColorChooserClient::~ColorChooserClient): Added.
- 9:14 PM Changeset in webkit [106624] by
-
- 2 edits in trunk/Source/WebCore
Remove OVERRIDE from ColorInputType::valueAsColor
https://bugs.webkit.org/show_bug.cgi?id=77701
Reviewed by Kent Tamura.
- html/ColorInputType.h:
(WebCore::ColorInputType::valueAsColor):
- 8:51 PM Changeset in webkit [106623] by
-
- 5 edits3 adds in trunk
Support 'disabled' attribute on SVGStyleElement
https://bugs.webkit.org/show_bug.cgi?id=52130
Source/WebCore:
Adding disabled property to SVGStyleElement, which
mirrors the functionality added to HTMLStyleElement
for DOM1. The disabled property reflects and sets
the disabled state of its style sheet.
Based off of patch for bug 25287
Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.
Test: svg/dom/SVGStyleElement/disable-svg-style-element.html
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::disabled):
(WebCore):
(WebCore::SVGStyleElement::setDisabled):
- svg/SVGStyleElement.h:
(SVGStyleElement):
- svg/SVGStyleElement.idl:
LayoutTests:
Test the disabled property of an svg style element.
Based off of the patch for bug 25287.
Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.
- svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt: Added.
- svg/dom/SVGStyleElement/disable-svg-style-element.html: Added.
- svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js: Added.
(createStyle):
- 8:37 PM Changeset in webkit [106622] by
-
- 2 edits in trunk/Source/WebCore
Make ShadowRoot interface inherit DocumentFragment interface in IDL.
https://bugs.webkit.org/show_bug.cgi?id=77511
Reviewed by Kentaro Hara.
This patch contains only the change of IDL to isolate issues.
Other changes, such as tests for querySelector of ShadowRoot, will be added in follow-up patches.
No tests. No change in behavior.
- dom/ShadowRoot.idl:
- 8:08 PM Changeset in webkit [106621] by
-
- 3 edits17 adds in trunk
Check parameters to biquad filters
https://bugs.webkit.org/show_bug.cgi?id=71413
Source/WebCore:
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.
Tests added for each filter type and for the limiting cases for
each filter type.
- platform/audio/Biquad.cpp:
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
Check for invalid parameters and clip them to something sensible.
Also check for the limiting cases and try to use the limiting form
of the z-transform for the biquad. Some issues cannot be
consistently handled because the z-transform is not continuous as
the parameters approach the limit.
LayoutTests:
Patch by Raymond Toy <rtoy@chromium.org> on 2012-02-02
Reviewed by Kenneth Russell.
- webaudio/biquad-allpass-expected.txt: Added
- webaudio/biquad-allpass.html: Added
- webaudio/biquad-bandpass-expected.txt: Added
- webaudio/biquad-bandpass.html: Added
- webaudio/biquad-highpass-expected.txt: Added
- webaudio/biquad-highpass.html: Added
- webaudio/biquad-highshelf-expected.txt: Added
- webaudio/biquad-highshelf.html: Added
- webaudio/biquad-lowpass-expected.txt: Added
- webaudio/biquad-lowpass.html: Added
- webaudio/biquad-lowshelf-expected.txt: Added
- webaudio/biquad-lowshelf.html: Added
- webaudio/biquad-notch-expected.txt: Added
- webaudio/biquad-notch.html: Added
- webaudio/biquad-peaking-expected.txt: Added
- webaudio/biquad-peaking.html: Added
- webaudio/resources/biquad-testing.js: Added
- 8:00 PM Changeset in webkit [106620] by
-
- 19 edits2 adds2 deletes in trunk/Source
[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148
Reviewed by Martin Robinson.
Source/WebCore:
Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.
To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.
Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689
Covered extensively by existing tests, no behavioral changes.
- Target.pri:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
- platform/graphics/cairo/TextureMapperCairo.cpp:
- platform/graphics/opengl/TextureMapperGL.cpp:
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):
- platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):
- platform/graphics/qt/TextureMapperQt.cpp: Removed.
- platform/graphics/qt/TextureMapperQt.h: Removed.
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):
- platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
- platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):
Source/WebKit/qt:
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
Source/WebKit2:
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
- 7:33 PM Changeset in webkit [106619] by
-
- 3 edits1 add in trunk/LayoutTests
Refactoring: Share test drivers of shadow content tests.
https://bugs.webkit.org/show_bug.cgi?id=77584
Extracts shared test code from content-element-move.html and content-element-select-dynamic.html.
This test framework will be used a few more times.
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.
- fast/dom/resources/shadow-test-driver.js: Added.
(log):
(cleanUp):
(removeContainerLines):
(check):
(createSpanWithText):
(createContentWithSelect):
(appendShadow):
(appendShadowDeep):
(doTestIfLeft.callIfDone):
(doneTest):
(doTest):
- fast/dom/shadow/content-element-move.html:
- fast/dom/shadow/content-element-select-dynamic.html:
- 7:23 PM Changeset in webkit [106618] by
-
- 13 edits in trunk/Source/WebCore
Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796
Reviewed by Eric Seidel.
As requested by Darin Adler, this patch renames these functions be
clear that we're asking whether the access should be allowed rather
than explicitly allowing the access.
- bindings/generic/BindingSecurity.h:
(BindingSecurity):
(WebCore::::shouldAllowAccessToNode):
(WebCore::::allowSettingFrameSrcToJavascriptUrl):
- bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):
- bindings/js/JSDOMBinding.h:
(WebCore):
- bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::allowSettingJavascriptURL):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObject::getOwnPropertyDescriptor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):
- 7:18 PM Changeset in webkit [106617] by
-
- 2 edits in trunk/Tools
[chromium] add support for --makeargs to the ninja-based build
https://bugs.webkit.org/show_bug.cgi?id=77688
Reviewed by Adam Barth.
- Scripts/webkitdirs.pm:
(buildChromiumNinja):
- 7:03 PM Changeset in webkit [106616] by
-
- 3 edits in trunk/Tools
Run tests in serial on SnowLeopard to avoid CFURLCache crashes
https://bugs.webkit.org/show_bug.cgi?id=75145
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_operating_system):
(test_default_child_processes):
- 6:53 PM Changeset in webkit [106615] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Make gtk+ symbols available to WidgetBackingStoreCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=77679
WidgetBackingStoreCairo.cpp uses GTK+ symbols, so we need it in
webcoregtk_sources instead of webcore_sources.
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.
- GNUmakefile.list.am: Move WidgetBackingStoreCairo.cpp to webcoregtk.
- 6:52 PM Changeset in webkit [106614] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.
- interpreter/Interpreter.h:
(Interpreter):
- 6:47 PM Changeset in webkit [106613] by
-
- 8 edits2 adds in trunk
StyleRecalc should occur when shadow root exists and light children are changed.
https://bugs.webkit.org/show_bug.cgi?id=76262
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.
Source/WebCore:
When light children is changed, the element included in HTMLContentElement may also be changed.
So we have to recalculate inclusion of content element again.
Test: fast/dom/shadow/shadow-contents-fallback-dynamic.html
- dom/Element.cpp:
(WebCore::Element::childrenChanged):
LayoutTests:
Tests for dynamic content fallback.
Also, unnecessary RenderText objects in previous test expectations were removed.
- fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt: Added.
- fast/dom/shadow/shadow-contents-fallback-dynamic.html: Added.
- platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
- platform/gtk/fast/html/details-remove-child-2-expected.txt:
- platform/mac/fast/html/details-remove-child-2-expected.txt:
- platform/qt/fast/html/details-remove-child-2-expected.txt:
- 6:40 PM Changeset in webkit [106612] by
-
- 4 edits3 adds in trunk/LayoutTests
noteGrainOn needs more tests
https://bugs.webkit.org/show_bug.cgi?id=77225
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.
- webaudio/note-grain-on-play.html: Added.
- webaudio/note-grain-on-play-expected.txt: Added.
- webaudio/note-grain-on-timing.html: Refactored to use new
functions in note-grain-on-testing.js.
- webaudio/note-grain-on-timing-expected.txt: Updated.
- webaudio/resources/audio-testing.js:
(grainLengthInSampleFrames): Utility to compute length of a grain
in samples.
- webaudio/resources/note-grain-on-testing.js: Added.
(createSignalBuffer):
(findStartAndEndSamples):
(playGrain):
(playAllGrains):
(verifyStarAndtEndTimes): Common functions for note-grain-on-play and
note-grain-on-timing tests to use.
- 6:28 PM Changeset in webkit [106611] by
-
- 3 edits in trunk/LayoutTests
Typo in sample-accurate-scheduling layout test?
https://bugs.webkit.org/show_bug.cgi?id=75996
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.
- webaudio/sample-accurate-scheduling-expected.txt: Updated
- webaudio/sample-accurate-scheduling.html: Fix typo, add test for
expected number of events.
- 6:13 PM Changeset in webkit [106610] by
-
- 2 edits in trunk/Source/WebCore
Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
- 6:04 PM Changeset in webkit [106609] by
-
- 4 edits2 adds in trunk/Source/WebCore
Add ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77695
Reviewed by Andreas Kling.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Create a scrolling tree.
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
Assert that the scrolling tree is null.
(WebCore::ScrollingCoordinator::pageDestroyed):
Null out the scrolling tree member variable and tell it to invalidate itself.
- page/scrolling/ScrollingTree.cpp: Added.
(WebCore::ScrollingTree::invalidate):
Null out the scrolling coordinator, breaking the reference cycle between the scrolling
coordinator and the scrolling tree.
- page/scrolling/ScrollingTree.h: Added.
- 5:49 PM Changeset in webkit [106608] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Don't use uint
https://bugs.webkit.org/show_bug.cgi?id=77678
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.
With the MingGW cross compiler toolchain in Fedora, uint wasn't
defined, so use unsigned int instead.
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient): Use unsigned int instead of uint
- 5:35 PM Changeset in webkit [106607] by
-
- 8 edits in trunk/Source/WebCore
Refactor plugin drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76715
Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-02
Reviewed by James Robinson.
CCPluginLayerImpl no longer handles drawing itself, but produces a list of CCPluginDrawQuads.
These quads are then drawn by LayerRendererChromium.
CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
This allows for CCLayerImpl objects to allocate textures before appendQuads is called.
This is a refactor, so no new tests were added.
Flash was tested manually on Linux and Mac.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::PluginProgramBinding::set):
(PluginProgramBinding):
(WebCore):
(WebCore::TexStretchPluginProgramBinding::set):
(TexStretchPluginProgramBinding):
(WebCore::TexTransformPluginProgramBinding::set):
(TexTransformPluginProgramBinding):
(WebCore::LayerRendererChromium::drawPluginQuad):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCPluginDrawQuad.cpp:
(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):
- platform/graphics/chromium/cc/CCPluginDrawQuad.h:
(CCPluginDrawQuad):
(WebCore::CCPluginDrawQuad::uvRect):
(WebCore::CCPluginDrawQuad::textureId):
(WebCore::CCPluginDrawQuad::flipped):
(WebCore::CCPluginDrawQuad::ioSurfaceWidth):
(WebCore::CCPluginDrawQuad::ioSurfaceHeight):
(WebCore::CCPluginDrawQuad::ioSurfaceTextureId):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::willDraw):
(WebCore::CCPluginLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(CCPluginLayerImpl):
- 5:01 PM Changeset in webkit [106606] by
-
- 5 edits3 deletes in trunk/Source/JavaScriptCore
[Mac] eliminate JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=72854
Reviewed by Darin Adler.
- Removed exp files and corresponding makefile entries.
- Changed the build configuration no to use exp file.
- Configurations/JavaScriptCore.xcconfig:
- DerivedSources.make:
- JavaScriptCore.JSVALUE32_64only.exp: Removed.
- JavaScriptCore.JSVALUE64only.exp: Removed.
- JavaScriptCore.exp: Removed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Platform.h:
- 4:47 PM Changeset in webkit [106605] by
-
- 12 edits in trunk/Source/WebCore
V8 idl code generator doesn't handle SerializedScriptValue attributes properly.
https://bugs.webkit.org/show_bug.cgi?id=77295
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-29
Reviewed by Kentaro Hara.
Only the case of one (and only one) SerializedScriptValue attribute was
handled, and it was deserialized eagerly in the constructor instead of
generating getters/setters. This patch gets rid of that behavior and
generates the getters and setters instead (similar to what the JSC
generator does).
Also handle the case of SSV attributes with [CachedAttribute]
declaration, caching the deserialized value in a hidden attribute on the
object.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::setValue):
(WebDOMTestSerializedScriptValueInterface::readonlyValue):
(WebDOMTestSerializedScriptValueInterface::cachedValue):
(WebDOMTestSerializedScriptValueInterface::setCachedValue):
(WebDOMTestSerializedScriptValueInterface::cachedReadonlyValue):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
():
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSTestSerializedScriptValueInterface::put):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):
(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface setValue:]):
(-[DOMTestSerializedScriptValueInterface readonlyValue]):
(-[DOMTestSerializedScriptValueInterface cachedValue]):
(-[DOMTestSerializedScriptValueInterface setCachedValue:]):
(-[DOMTestSerializedScriptValueInterface cachedReadonlyValue]):
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedReadonlyValueAttrGetter):
():
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 4:47 PM Changeset in webkit [106604] by
-
- 2 edits in branches/chromium/1025/Source/WebCore/dom
Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312
Reviewed by Dimitri Glazkov.
When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp
This patch adds the check back.
Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.
We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.
The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.
- dom/EventFactory.in:
- dom/make_event_factory.pl:
(defaultItemFactory):
(generateImplementation):
TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9325015
- 4:26 PM Changeset in webkit [106603] by
-
- 3 edits in trunk/Source/WebCore
BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312
Reviewed by Dimitri Glazkov.
When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp
This patch adds the check back.
Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.
We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.
The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.
- dom/EventFactory.in:
- dom/make_event_factory.pl:
(defaultItemFactory):
(generateImplementation):
- 4:24 PM Changeset in webkit [106602] by
-
- 2 edits in trunk/LayoutTests
Fix up test expectations for two tests that now pass.
https://bugs.webkit.org/show_bug.cgi?id=77256
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Eric Seidel.
- platform/chromium/test_expectations.txt:
webaudio/audiobuffersource-playbackrate.html and
webaudio/gain.html pass on windows now after the fix for bug
- Delete these.
- 4:06 PM Changeset in webkit [106601] by
-
- 8 edits in trunk/Source/WebCore
[Chromium] Use SkCanvas::flush in skia port
https://bugs.webkit.org/show_bug.cgi?id=77463
Patch by Justin Novosad <junov@chromium.org> on 2012-02-02
Reviewed by Stephen White.
Code cleanup in skia port. Using SkCanvas::flush to remove
unnecessary dependency on GrContext. Removed unnecessary inclusions
and forward declarations of GrContext in several source files.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- platform/graphics/chromium/cc/CCProxy.h:
- platform/graphics/skia/PlatformContextSkia.cpp:
- 3:42 PM Changeset in webkit [106600] by
-
- 3 edits2 adds in trunk
Running a Web Worker on about:blank crashes the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77593
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-02
Reviewed by Michael Saboff.
Source/JavaScriptCore:
The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.
This patch shortcut the execution when the String is null to avoid invalid
memory access.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
LayoutTests:
The Worker thread should not crash if running on an empty page.
The timer is necessary to give a chance for the thread to start.
- fast/workers/empty-worker-nocrash-expected.txt: Added.
- fast/workers/empty-worker-nocrash.html: Added.
- 3:41 PM Changeset in webkit [106599] by
-
- 4 edits in trunk/Source
Versioning.
- 3:36 PM Changeset in webkit [106598] by
-
- 3 edits in trunk/Source/JavaScriptCore
[GTK] Use win32 native threading
https://bugs.webkit.org/show_bug.cgi?id=77676
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.
r97269 switched from glib threading to pthreads, breaking win32 GTK+.
This is a follow up, removing some leftovers in ThreadSpecific.h and
switching win32 to use the native threading in ThreadingWin.cpp.
- GNUmakefile.list.am: Compile in win32 native threading support
- wtf/ThreadSpecific.h: Remove GTK+-specific definitions
(ThreadSpecific):
(WTF::::destroy):
- 3:34 PM Changeset in webkit [106597] by
-
- 1 copy in tags/Safari-535.19
New Tag.
- 3:18 PM Changeset in webkit [106596] by
-
- 3 edits3 adds in trunk
retrieveCallerFromVMCode should call trueCallerFrame
https://bugs.webkit.org/show_bug.cgi?id=77684
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCallerFromVMCode):
LayoutTests:
Rubber stamped by Oliver Hunt.
- fast/js/dfg-inline-function-dot-caller-expected.txt: Added.
- fast/js/dfg-inline-function-dot-caller.html: Added.
- fast/js/script-tests/dfg-inline-function-dot-caller.js: Added.
(resultArray):
(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(object.inlineable):
(makeInlinableCall):
(g):
- 3:03 PM Changeset in webkit [106595] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] Implement current executable path finding for win32
https://bugs.webkit.org/show_bug.cgi?id=77677
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.
The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.
- wtf/gobject/GlibUtilities.cpp:
(getCurrentExecutablePath):
- 2:55 PM Changeset in webkit [106594] by
-
- 3 edits in trunk/Source/JavaScriptCore
Throwing away bytecode and then reparsing during DFG optimization is just
plain wrong and makes things crash
https://bugs.webkit.org/show_bug.cgi?id=77680
<rdar://problem/10798490>
Reviewed by Oliver Hunt.
This is the minimal surgical fix: it removes the code that triggered bytecode
throw-away. Once we're confident that this is a good idea, we can kill all of
the code that implements the feature.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::addValueProfile):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- 2:50 PM Changeset in webkit [106593] by
-
- 8 edits in trunk
Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667
Source/WebCore:
Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors
Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
WebKitLibraries:
Turned on CSS_FILTERS for Windows
Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
Skipped filter test files not supported on Windows
Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.
- platform/win/Skipped:
- 2:16 PM Changeset in webkit [106592] by
-
- 18 edits in trunk/Source
Clear shown notifications when context is no longer active
https://bugs.webkit.org/show_bug.cgi?id=77363
<rdar://problem/10568907>
Reviewed by Darin Adler.
Source/WebCore:
- notifications/NotificationPresenter.h: Add new virtual function to clear notifications
associated with a given execution context. By default the notifications are left alone, as
before. Individual implementations can override to allow notifications to clear them.
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::disconnectFrame): When disconnecting the page from the frame, we
call clearNotifications().
- page/Frame.cpp:
(WebCore::Frame::pageDestroyed): When the page is destroyed, tell the DOM window to reset notifications.
Source/WebKit/win:
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate): Add previously missing virtual functions.
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::notificationControllerDestroyed):
(WebDesktopNotificationsDelegate::cancelRequestsForPermission):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::clearNotifications): Forward the call to
WebNotificationManager.
- WebProcess/WebCoreSupport/WebNotificationClient.h:
(WebNotificationClient):
- WebProcess/Notifications/WebNotificationManager.h: Add an additional map that maps
all notifications associated with a given ScriptExecutionContext instance.
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Create a map entry for the notification's
context if it doesn't exist already, and note that notification's ID. Also, correct
the return value of show() if notifications are not enabled, to return false.
(WebKit::WebNotificationManager::didCloseNotifications): When the notification is closed,
we remove that notification from the map.
(WebKit::WebNotificationManager::clearNotifications): Use the map entry for the given
context, and pass that along to the proxy so that all of the notifications with those IDs
can be cleared. In the meantime, we remove that context's map entry.
- UIProcess/Notifications/WebNotificationManagerProxy.messages.in: New ClearNotifications()
message.
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::clearNotifications): Forward the call to the provider.
Then remove this proxy's entries for the given notification IDs.
- UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications): Convert the vector of IDs to a mutable
array.
- UIProcess/Notifications/WebNotificationProvider.h:
(WebNotificationProvider):
- UIProcess/API/C/WKNotificationProvider.h: Add WK API to tell the platform to clear the notifications.
Remove the #if guard since they already exist in WebNotificationManager functions:
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):
- 1:55 PM Changeset in webkit [106591] by
-
- 5 edits in trunk/Tools
nrwt shouldn't blow up when there are errors in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=73603
Reviewed by Ojan Vafai.
This change removes the distinction between 'errors' and 'warnings'
in the test expectations parser. Now, any problem is a
'warning', and if we are linting the file, warnings become fatal (errors).
This will allow a normal run-webkit-tests run to proceed even if
there are bad lines.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(ParseError.init):
(ParseError.str):
(ParseError.repr):
(TestExpectationSerializer.to_string):
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._parse_expectations):
(TestExpectationParser._check_modifiers_against_expectations):
(TestExpectationParser._tokenize):
(TestExpectationLine.init):
(TestExpectationLine.is_invalid):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.init):
(TestExpectations._report_warnings):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_bad_expectations):
(test_parse_warning):
(test_overridesduplicate):
(ExpectationSyntaxTests.test_missing_expectation):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_colons):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_slow_and_timeout):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RebaseliningTest.assertRemove):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationSerializerTests.test_unparsed_to_string):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
- 1:49 PM Changeset in webkit [106590] by
-
- 30 edits in trunk/Source/JavaScriptCore
Release build debugging should be easier
https://bugs.webkit.org/show_bug.cgi?id=77669
Reviewed by Gavin Barraclough.
- assembler/ARMAssembler.h:
(ARMAssembler):
(JSC::ARMAssembler::debugOffset):
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::debugOffset):
(ARMInstructionFormatter):
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
- assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::debugOffset):
- assembler/AssemblerBuffer.h:
(AssemblerBuffer):
(JSC::AssemblerBuffer::debugOffset):
- assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::debugSize):
- assembler/MIPSAssembler.h:
(MIPSAssembler):
(JSC::MIPSAssembler::debugOffset):
- assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::debugOffset):
(X86InstructionFormatter):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):
- bytecode/CodeBlock.cpp:
(JSC):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/CodeOrigin.h:
(CodeOrigin):
(JSC):
(JSC::CodeOrigin::inlineStack):
- bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- bytecode/PredictedType.cpp:
(JSC):
(JSC::predictionToString):
- bytecode/PredictedType.h:
(JSC):
- bytecode/ValueRecovery.h:
(ValueRecovery):
(JSC::ValueRecovery::dump):
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
(JSC::BytecodeGenerator::setDumpsGeneratedCode):
(JSC::BytecodeGenerator::dumpsGeneratedCode):
(JSC::BytecodeGenerator::generate):
- dfg/DFGAbstractValue.h:
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::dump):
(AbstractValue):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGAssemblyHelpers.h:
(DFG):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
- dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::debugName):
- dfg/DFGGraph.cpp:
(DFG):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::arithNodeFlagsAsString):
(Node):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::dumpChildren):
- dfg/DFGOSRExit.cpp:
(DFG):
(JSC::DFG::OSRExit::dump):
- dfg/DFGOSRExit.h:
(OSRExit):
- runtime/JSValue.cpp:
(JSC):
(JSC::JSValue::description):
- runtime/JSValue.h:
(JSValue):
- wtf/BitVector.cpp:
(WTF):
(WTF::BitVector::dump):
- wtf/BitVector.h:
(BitVector):
- 1:19 PM Changeset in webkit [106589] by
-
- 5 edits in trunk
Getters and setters cause line numbers in errors/console.log to be offset for the whole file
https://bugs.webkit.org/show_bug.cgi?id=77675
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Our default literal parsing logic doesn't handle the extra work required for
getters and setters. When it encounters one, it rolls back the lexer and
then switches to a more complete parsing function. Unfortunately it was only
winding back the character position, and was ignoring the line number and
other lexer data. This led to every getter and setter causing the line number
to be incorrectly incremented leading to increasingly incorrect numbers for
the rest of the file.
- parser/Parser.cpp:
(JSC::::parseObjectLiteral):
LayoutTests:
Add getter and setter line number tests.
- fast/js/exception-linenums-expected.txt:
- fast/js/script-tests/exception-linenums.js:
(firstPropIsGetter.get getter):
(secondPropIsGetter.prop.1.get getter):
(firstPropIsSetter.set setter):
(secondPropIsSetter.prop.1.set setter):
- 1:18 PM Changeset in webkit [106588] by
-
- 6 edits in trunk/Source/WebCore
The overhang area layer should have a linen background
https://bugs.webkit.org/show_bug.cgi?id=77670
<rdar://problem/10797727>
Reviewed by Andreas Kling.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Add an #ifdef so that scroll position clamping can be disabled. This will be
removed once rubber-banding works properly.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Add new empty function.
- platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::linenBackgroundColor):
Helper function for getting the CGColorRef that represents the linen background color.
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Set the linen background color as the overhang areas layer background color.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Call ScrollbarTheme::setUpOverhangAreasLayerContents.
- 1:15 PM Changeset in webkit [106587] by
-
- 2 edits1 delete in trunk/LayoutTests
2012-02-02 Nate Chapin <Nate Chapin>
Unreviewed, chromium expectations update.
Remove custom chromium-mac expectation for fast/canvas/fillPath-shadow.html,
since it's failing the same way as chromium win/linux.
- platform/chromium-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 1:12 PM BuildingQt5OnHarmattan edited by
- (diff)
- 1:10 PM Changeset in webkit [106586] by
-
- 7 edits in trunk
Unreviewed, rolling out r106566.
http://trac.webkit.org/changeset/106566
https://bugs.webkit.org/show_bug.cgi?id=77673
Broke the Windows build (Requested by jessieberlin on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02
Source/WebCore:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
- platform/win/Skipped:
- 1:04 PM Changeset in webkit [106585] by
-
- 2 edits in trunk/LayoutTests
2012-02-02 Andrew Scherkus <scherkus@chromium.org>
Unreviewed, updating Chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=73681
- platform/chromium/test_expectations.txt:
- 1:03 PM Changeset in webkit [106584] by
-
- 4 edits1 delete in trunk
Unreviewed, rolling out r106543.
http://trac.webkit.org/changeset/106543
https://bugs.webkit.org/show_bug.cgi?id=77671
Made tests less stable (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02
PerformanceTests:
- resources/init.html: Removed.
Tools:
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.TestDriver.run_test):
(run_test):
- 1:00 PM Changeset in webkit [106583] by
-
- 2 edits in trunk/LayoutTests
2012-02-02 Nate Chapin <Nate Chapin>
Unreviewed, chromium expectations update.
Mark some touch event tests as crashing, since they're
asserting as of r106554.
- platform/chromium/test_expectations.txt:
- 12:56 PM Changeset in webkit [106582] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebKit2
Merged r106508.
- 12:53 PM Changeset in webkit [106581] by
-
- 12 edits8 copies1 add in trunk/Source
[chromium] MediaStream API: Adding the embedding code for MediaStreamCenter
https://bugs.webkit.org/show_bug.cgi?id=73130
Reviewed by Darin Fisher.
Source/WebCore:
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- mediastream/UserMediaClient.h:
(UserMediaClient):
- mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCompleteQuery):
- mediastream/UserMediaRequest.h:
(UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
- platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamSourcesQueryClient):
(MediaStreamCenter):
Source/WebKit/chromium:
- WebKit.gyp:
- bridge/MediaStreamCenter.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
(WebCore::MediaStreamCenter::didConstructMediaStream):
- bridge/MediaStreamCenterInternal.cpp: Added.
(WebCore):
(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::~MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::queryMediaStreamSources):
(WebCore::MediaStreamCenterInternal::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterInternal::didStopLocalMediaStream):
(WebCore::MediaStreamCenterInternal::didConstructMediaStream):
(WebCore::MediaStreamCenterInternal::stopLocalMediaStream):
- bridge/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebCore):
(MediaStreamCenterInternal):
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::createMediaStreamCenter):
- public/platform/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::~WebMediaStreamCenter):
- public/platform/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebMediaStreamCenterClient):
(WebKit::WebMediaStreamCenterClient::~WebMediaStreamCenterClient):
- public/platform/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebKit):
(WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::~WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::isNull):
- public/platform/WebMediaStreamDescriptor.h:
(WebKit):
(WebMediaStreamDescriptor):
- public/platform/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebKit):
(WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::~WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::isNull):
- src/UserMediaClientImpl.h:
(UserMediaClientImpl):
- src/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebKit::WebMediaStreamComponent::reset):
(WebKit::WebMediaStreamComponent::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamComponent::operator MediaStreamComponent*):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::source):
- src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
- src/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::reset):
(WebKit::WebMediaStreamSourcesRequest::audio):
(WebKit::WebMediaStreamSourcesRequest::video):
(WebKit::WebMediaStreamSourcesRequest::didCompleteQuery):
- 12:46 PM Changeset in webkit [106580] by
-
- 4 edits7 adds in trunk
Constant values to set "distanceModel" are undefined
https://bugs.webkit.org/show_bug.cgi?id=74273
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.
Source/WebCore:
Tests: webaudio/distance-exponential.html
webaudio/distance-inverse.html
webaudio/distance-linear.html
- webaudio/AudioPannerNode.h: Define enum for the new constants
for the distance models.
- webaudio/AudioPannerNode.idl: Define matching constants for the
distance models.
LayoutTests:
- webaudio/distance-exponential-expected.txt: Added.
- webaudio/distance-exponential.html: Added.
- webaudio/distance-inverse-expected.txt: Added.
- webaudio/distance-inverse.html: Added.
- webaudio/distance-linear-expected.txt: Added.
- webaudio/distance-linear.html: Added.
- webaudio/resources/distance-model-testing.js: Added.
(createImpulseBuffer):
(linearDistance):
(exponentialDistance):
(inverseDistance):
(createGraph):
(startSources):
(equalPowerGain):
(checkDistanceResult.return.renderedBuffer):
(checkDistanceResult):
- 12:29 PM Changeset in webkit [106579] by
-
- 8 edits in trunk
Illegal panner model values should throw an exception
https://bugs.webkit.org/show_bug.cgi?id=77235
Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.
Source/WebCore:
Modified existing panner-set-model test to catch exceptions.
Debug build should not crash anymore.
- webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setPanningModel): Throw exception for
invalid model values.
- webaudio/AudioPannerNode.h:
(AudioPannerNode): Update declaration
- webaudio/AudioPannerNode.idl: Setting panner model can throw
exception.
LayoutTests:
- webaudio/panner-set-model-expected.txt: Updated.
- webaudio/panner-set-model.html: Catch the errors that are thrown
for invalid panning model values.
- platform/chromium/test_expectations.txt: Remove test that no
longer crashes.
- 12:02 PM Changeset in webkit [106578] by
-
- 2 edits in trunk/LayoutTests
2012-02-02 Nate Chapin <Nate Chapin>
Unreviewed, chromium expectations update.
- platform/chromium/test_expectations.txt:
- 12:02 PM Changeset in webkit [106577] by
-
- 2 edits4 adds in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=77664
Add API tests for didNewFirstVisuallyNonEmptyLayout
Reviewed by Darin Adler.
Two new tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
- 11:49 AM Changeset in webkit [106576] by
-
- 1 edit1 add in trunk/LayoutTests
Chromium rebaseline after r106543.
- platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
- 11:24 AM Changeset in webkit [106575] by
-
- 23 edits in trunk/Source/WebCore
Rename [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77611
Reviewed by Adam Barth.
This patch renames [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString], according to the spec
(http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs,
http://dev.w3.org/2006/webapi/WebIDL/#TreatUndefinedAs).
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeFromSignature):
- dom/DOMImplementation.idl:
- dom/Document.idl:
- fileapi/Blob.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.idl:
- fileapi/Entry.idl:
- fileapi/EntrySync.idl:
- fileapi/WebKitBlobBuilder.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOutputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- page/Console.idl:
- page/DOMWindow.idl:
- bindings/scripts/test/TestObj.idl: No changes in run-bindings-tests results.
- 11:12 AM Changeset in webkit [106574] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix type punning warning in HashTable.h debug builds
https://bugs.webkit.org/show_bug.cgi?id=77422
Patch by Andy Wingo <wingo@igalia.com> on 2012-02-02
Reviewed by Gavin Barraclough.
- wtf/HashTable.h (WTF::HashTable::checkKey): Fix type punning
warning appearing in debug builds with gcc-4.6.2 on GNU/Linux.
- 11:06 AM Changeset in webkit [106573] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02
- DEPS:
- 11:03 AM Changeset in webkit [106572] by
-
- 4 edits in trunk/Source
NPAPI will not send mouse up events when mouse is outside plugin area
https://bugs.webkit.org/show_bug.cgi?id=77657
<rdar://problem/10160674>
Reviewed by Andreas Kling.
Source/WebCore:
Export EventHandler::setCapturingMouseEventsNode.
- WebCore.exp.in:
Source/WebKit2:
Use EventHandler::setCapturingMouseEventsNode to ensure we get all the mouse events when the mouse is down.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
- 10:59 AM Changeset in webkit [106571] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=67485
- platform/qt-wk2/Skipped:
- fast/dom/Window/window-properties.html: unskip, it needed only update
- fast/text/complex-preferred-logical-widths.html: unskip, it passes now
- http/tests/loading/empty-urls.html: unskip, it doesn't exist now
- http/tests/loading/progress-finished-callback.html: move to the correct place
- platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
- 10:37 AM Changeset in webkit [106570] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Unskip a now passing test.
- 10:08 AM Changeset in webkit [106569] by
-
- 2 edits in trunk/LayoutTests
Paint the Qt Mac bot green.
- platform/qt-mac/Skipped:
- 10:08 AM Changeset in webkit [106568] by
-
- 15 edits in trunk/Source/WebCore
Move remaining implementation from CSSStyleDeclaration to subclasses
https://bugs.webkit.org/show_bug.cgi?id=77621
Reviewed by Andreas Kling.
This leaves CSSStyleDeclaration a near-pure CSSOM interface.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::parentRule):
(WebCore):
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::contextStyleSheet):
(WebCore):
(WebCore::CSSMutableStyleDeclaration::parentRule):
- css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentRuleInternal):
(WebCore::CSSMutableStyleDeclaration::clearParentRule):
(CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentElement):
(WebCore::CSSMutableStyleDeclaration::clearParentElement):
(WebCore::CSSMutableStyleDeclaration::parentStyleSheet):
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
- css/CSSStyleDeclaration.cpp:
(WebCore):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()
- css/CSSStyleRule.h:
(WebCore::CSSStyleRule::setDeclaration):
- css/CSSStyleSelector.cpp:
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
- page/PageSerializer.h:
Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()
(WebCore):
(PageSerializer):
- 10:03 AM Changeset in webkit [106567] by
-
- 4 edits in trunk/LayoutTests
[Qt] One more unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628
- platform/qt-5.0/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/Skipped: Skip new crashing tests after r106554.
- 9:58 AM Changeset in webkit [106566] by
-
- 7 edits in trunk
Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667
Source/WebCore:
Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors
Reviewed by Adele Peterson.
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):
WebKitLibraries:
Turned on CSS_FILTERS for Windows
Reviewed by Adele Peterson.
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
Skipped filter test files not supported on Windows
Reviewed by Adele Peterson.
- platform/win/Skipped:
- 9:44 AM Changeset in webkit [106565] by
-
- 5 edits3 adds in trunk/Source/WebCore
Move ScrollingThread to its own file
https://bugs.webkit.org/show_bug.cgi?id=77652
Reviewed by Sam Weinig.
This just shuffles some classes around and makes ScrollingCoordinator call into ScrollingThread.
Hopefully we'll be able to make ScrollingThread use the new WebCore::RunLoop class eventually.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/ScrollingThread.cpp: Added.
(WebCore):
(WebCore::ScrollingThread::ScrollingThread):
(WebCore::ScrollingThread::isCurrentThread):
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback):
(WebCore::ScrollingThread::threadBody):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h: Added.
(WebCore):
(ScrollingThread):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPositionOnScrollingThread):
- page/scrolling/mac/ScrollingThreadMac.mm: Added.
(WebCore):
(WebCore::ScrollingThread::initializeRunLoop):
(WebCore::ScrollingThread::wakeUpRunLoop):
(WebCore::ScrollingThread::threadRunLoopSourceCallback):
- 9:39 AM Changeset in webkit [106564] by
-
- 1 edit14 adds in trunk/LayoutTests
Unreviewed chromium baselines for new tests in r106551.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
- platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png: Added.
- platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- 9:20 AM Changeset in webkit [106563] by
-
- 5 edits9 deletes in trunk
Unreviewed, rolling out r106551.
http://trac.webkit.org/changeset/106551
https://bugs.webkit.org/show_bug.cgi?id=77648
Breaking mac and gtk tests due to font differences. (Requested
by _pdr_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02
Source/WebCore:
- platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontData.h:
(SVGFontData):
LayoutTests:
- svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
- svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- svg/custom/glyph-selection-arabic-forms.svg: Removed.
- svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
- svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
- svg/custom/glyph-selection-bidi-mirror.svg: Removed.
- svg/custom/glyph-selection-non-bmp-expected.png: Removed.
- svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- svg/custom/glyph-selection-non-bmp.svg: Removed.
- 9:15 AM Changeset in webkit [106562] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=77647
Reviewed by Martin Robinson.
There is no clear reason why this check was in place (it came with the
upstreaming of the port), but ENABLE_GTK_PLUGINS_SUPPORT is not set
anywhere, and the build system does not even check for the presence of
GTK+ when building.
- ewk/ewk_main.cpp:
(_ewk_init_body):
- 8:59 AM Changeset in webkit [106561] by
-
- 2 edits in trunk/Tools
Add myself as a reviewer.
- 8:51 AM WebKit Team edited by
- (diff)
- 8:40 AM Changeset in webkit [106560] by
-
- 3 edits2 adds in trunk
Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/updates-during-dom-traversal.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
LayoutTests:
- inspector/styles/updates-during-dom-traversal-expected.txt: Added.
- inspector/styles/updates-during-dom-traversal.html: Added.
- 8:28 AM Changeset in webkit [106559] by
-
- 13 edits in trunk/Source
[GTK] WebKitWebView won't work in a GtkOffscreenWindow
https://bugs.webkit.org/show_bug.cgi?id=76911
Patch by Claudio Saavedra <Claudio Saavedra> and Martin Robinson <mrobinson@igalia.com> on 2012-02-02
Reviewed by Philippe Normand.
Source/WebCore:
- platform/gtk/GtkUtilities.cpp:
(WebCore::widgetIsOnscreenToplevelWindow): Added this helper.
- platform/gtk/GtkUtilities.h:
(WebCore): Added helper declaration.
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowRect): Use the new widgetIsOnscreenToplevelWindow helper.
(WebKit::ChromeClient::setWindowRect): Ditto.
(WebKit::ChromeClient::unfocus): Ditto.
(WebKit::ChromeClient::runOpenPanel): Ditto.
- tests/testwebview.c: Added a test to ensure that loading a page in an offscreen window does not crash.
- webkit/webkitglobals.cpp:
(currentToplevelCallback):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_print_full):
(webkit_web_frame_print):
- webkit/webkitwebview.cpp:
(webkit_web_view_focus_in_event):
(webkit_web_view_script_dialog):
Source/WebKit2:
- UIProcess/API/gtk/WebKitUIClient.cpp:
(getWindowFrame): Use the new helper.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreateJavaScriptDialog): Ditto
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Ditto.
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseFocusInEvent): Ditto.
- 7:53 AM Changeset in webkit [106558] by
-
- 2 edits in trunk/LayoutTests
fast/speech/bubble-position.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=77641
Unreviewed expectations update.
- platform/chromium/test_expectations.txt: Test introduced by 106438, never passed on mac.
- 7:48 AM Changeset in webkit [106557] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 7:27 AM Changeset in webkit [106556] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of imperceptible shadow change.
- platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- 7:13 AM Changeset in webkit [106555] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r106551.
- platform/qt/Skipped: Skip new tests because of missing testfonts.
- 7:09 AM Changeset in webkit [106554] by
-
- 7 edits in trunk/Source
Source/WebCore: Update active and hover state on touch release.
https://bugs.webkit.org/show_bug.cgi?id=77620
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::move):
(WebCore::HitTestRequest::release):
(WebCore::HitTestRequest::touchEvent):
(WebCore::HitTestRequest::mouseEvent):
(WebCore::HitTestRequest::touchMove):
(WebCore::HitTestRequest::touchRelease):
Rename the enum values in HitTestRequest to be mouse/touch
agnostic, and add value for recognizing touch events.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint): Update for HitTestRequest rename.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest): ditto
(WebCore::RenderLayer::updateHoverActiveState): Reset hoverstate on touch release.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag): Update for HitTestRequest rename.
(WebCore::EventHandler::handleMouseMoveEvent): ditto
(WebCore::EventHandler::handleMouseReleaseEvent): ditto
(WebCore::EventHandler::hoverTimerFired): ditto
(WebCore::EventHandler::dragSourceEndedAt): ditto
(WebCore::EventHandler::handleTouchEvent): Hittest touch release to reset
active and hover states and add touch enum to all touch hittests.
Source/WebKit/chromium: Update enum name for HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=77620
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
- 6:47 AM Changeset in webkit [106553] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628
Patch by János Badics <dicska@gmail.com> on 2012-02-02
- platform/qt-wk2/Skipped: Skip the test made fast/events/resize-subframe.html timeout.
- platform/qt/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
- 6:42 AM BuildingQt5OnHarmattan edited by
- Add information about qt5 packages for n9. (diff)
- 6:28 AM Changeset in webkit [106552] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: enable editing of selected rows on single click in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=77627
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.onattach):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype._mouseDown):
- inspector/front-end/treeoutline.js:
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):
- 6:27 AM Changeset in webkit [106551] by
-
- 5 edits9 adds in trunk
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067
Patch by Philip Rogers <pdr@google.com> on 2012-02-02
Reviewed by Nikolas Zimmermann.
Source/WebCore:
SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.
Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.
Tests: svg/custom/glyph-selection-arabic-forms.svg
svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg
- platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):
- svg/SVGFontData.h:
(SVGFontData):
LayoutTests:
SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.
Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.
- svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- svg/custom/glyph-selection-arabic-forms.svg: Added.
- svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- svg/custom/glyph-selection-bidi-mirror.svg: Added.
- svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- svg/custom/glyph-selection-non-bmp.svg: Added.
- 6:25 AM Changeset in webkit [106550] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add experiment for single click styles editing.
https://bugs.webkit.org/show_bug.cgi?id=77624
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype._mouseDown):
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
- 6:13 AM Changeset in webkit [106549] by
-
- 2 edits in trunk/Tools
Add myself as a commiter
- 5:58 AM Changeset in webkit [106548] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking a new test as flaky on GTK.
- platform/gtk/test_expectations.txt:
fast/forms/radio/radio-group.html fails on and off.
- 5:53 AM Changeset in webkit [106547] by
-
- 2 edits in trunk/Source/WebCore
Make the tap highlighting work for all test cases
https://bugs.webkit.org/show_bug.cgi?id=77626
Reviewed by Simon Hausmann.
Clean up of the current code to make it more generic. Now uses
addFocusRingRects for finding the areas to highlight.
Tested by current manual tests.
- page/GestureTapHighlighter.cpp:
(WebCore::GestureTapHighlighter::pathForNodeHighlight):
- 5:42 AM Changeset in webkit [106546] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed, GTK rebaseline and skipping 3 new test failures.
- platform/gtk/Skipped:
- platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
- 5:18 AM Changeset in webkit [106545] by
-
- 4 edits in trunk/Source
[Gtk] atk_text_get_text_at_offset() sometimes fails to provide the correct line
https://bugs.webkit.org/show_bug.cgi?id=72382
Reviewed by Martin Robinson.
Source/WebCore:
Do not add unnecesary blanks at the end of a line of text.
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Do not just append a '\n' at the end of a line
if the linebreak for that line was already considered.
Source/WebKit/gtk:
New unit test to ensure the right line is retrieved for the first
position of each line in a multiline preformatted portion of text.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithPreformattedText): New unit test.
(main): Add the new unit test.
- 2:25 AM Changeset in webkit [106544] by
-
- 3 edits2 adds in trunk
Regions should ignore the saved currentRenderFlowThread during repainting
because if there are imbricated flow threads, it might end using the wrong one.
[CSSRegions] Assert failure in RenderView::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=77430
Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-02
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/imbricated-flow-threads-crash.html
- rendering/RenderFlowThread.cpp:
(CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
(WebCore):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
LayoutTests:
- fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
- fast/regions/imbricated-flow-threads-crash.html: Added.
- 2:24 AM Changeset in webkit [106543] by
-
- 4 edits1 add in trunk
[PerformanceTests] tests have dependencies
https://bugs.webkit.org/show_bug.cgi?id=77506
Reviewed by Hajime Morita.
PerformanceTests:
- resources/init.html: Added.
Tools:
Load an initialization page before each test after starting a DRT so that
warming up DRT won't affect the performance test results.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.TestDriver.run_test):
(test_initial_page_loaded):
(test_initial_page_loaded.run_test):
- 1:31 AM Changeset in webkit [106542] by
-
- 16 edits in trunk/Source
Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory (re-landing r105395)
https://bugs.webkit.org/show_bug.cgi?id=76551
Source/WebCore:
Reviewed by David Levin.
Moved the implementation of crackFileSystemURL() and toURL() from
WebCore/fileapi/DOMFileSystemBase into WebCore/platform/AsyncFileSystem
so that each platform can extend/implement their behavior if necessary.
No new tests as it has no functional changes.
- fileapi/DOMFileSystemBase.cpp: Moved crackFileSystemURL() to AsyncFileSystem.
- fileapi/DOMFileSystemBase.h:
(DOMFileSystemBase):
- fileapi/EntryBase.cpp: Moved toURL() to AsyncFileSystem.
(WebCore::EntryBase::toURL):
- page/DOMWindow.cpp: Made corresponding callsite changes.
(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
- page/DOMWindow.h:
- platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::isValidType): Added.
- platform/AsyncFileSystem.h:
(AsyncFileSystem):
- workers/WorkerContext.cpp: Made corresponding callsite changes.
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
(WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
- workers/WorkerContext.h:
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp: Removed the matching assertion for AsyncFileSystem::External (as now we directly use WebFileSystem::TypeExternal).
- src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystem::crackFileSystemURL): Added.
(WebCore::AsyncFileSystem::isValidType): Added.
(WebCore::AsyncFileSystemChromium::toURL): Added.
- src/AsyncFileSystemChromium.h:
(AsyncFileSystemChromium):
- src/WorkerAsyncFileSystemChromium.cpp: Made this subclass of AsyncFileSystemChromium (rather than that of AsyncFileSystem)
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
- src/WorkerAsyncFileSystemChromium.h:
(WorkerAsyncFileSystemChromium):
- 1:12 AM Changeset in webkit [106541] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: pause on uncaugh exceptions state is not properly restored
https://bugs.webkit.org/show_bug.cgi?id=77558
'Pause on exceptions' state is now stored in InspectorState object so that it is
properly restored on inspected process change.
Reviewed by Vsevolod Vlasov.
- inspector/InspectorDebuggerAgent.cpp:
(DebuggerAgentState):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::restore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
(WebCore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- 12:27 AM Changeset in webkit [106540] by
-
- 3 edits in trunk/Tools
Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.init):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
- 12:23 AM Changeset in webkit [106539] by
-
- 3 edits2 adds in trunk
The third argument of addEventListener/removeEventListener of PeerConnection should be optional
https://bugs.webkit.org/show_bug.cgi?id=77606
Reviewed by Adam Barth.
Source/WebCore:
This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional].
Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html
- mediastream/PeerConnection.idl:
LayoutTests:
The added test confirms if the third argument of addEventListener() and
removeEventListener() is optional.
- fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added.
- fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added.
- 12:09 AM Changeset in webkit [106538] by
-
- 3 edits1 add in trunk
hidden attribute on <input type=file /> suppresses the file selection dialog
https://bugs.webkit.org/show_bug.cgi?id=58208
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-02-02
Reviewed by Ryosuke Niwa.
.:
- ManualTests/input-file-hidden-open-dialog-on-click.html: Added.
Adding manual test as the file dialog opens only in User gesture.
Source/WebCore:
We want to allow opening file dialog on hidden element when click() is called
on the element. The behaviour is similar to Firefox and IE.
Added manual test as the file dialog opens only on user gesture.
- html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
Removed renderer check as input can be hidden.
- 12:04 AM Changeset in webkit [106537] by
-
- 13 edits in trunk
[GStreamer] FFTFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=73545
Reviewed by Chris Rogers.
.:
- configure.ac: Enable the WebAudio option again and remove
libfftw checks.
Source/WebCore:
FFTFrame implementation based on GStreamer's FFT processing
library.
No new tests, existing WebAudio tests cover this.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/audio/FFTFrame.h:
- platform/audio/FFTFrameStub.cpp:
- platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
Source/WebKit/gtk:
- GNUmakefile.am: Remove libfftw compilation flags.
Source/WebKit2:
- GNUmakefile.am: Remove libfftw compilation flags.
LayoutTests:
- webaudio/resources/convolution-testing.js:
(checkTail1): Adapt convolution threshold for GStreamerFFTFrame
implementation, as advised by Chris Rogers.
- 12:00 AM Changeset in webkit [106536] by
-
- 9 edits in trunk/Source/WebCore
Rename [CheckFrameSecurity] and [SVGCheckSecurity] to [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77601
Reviewed by Adam Barth.
[CheckFrameSecurity] and [SVGCheckSecurity] have the same meaning; i.e. generate code
to check allowAccessToNode() for a given attribute or method. This patch renames them
to [CheckAccessToNode].
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLObjectElement.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp: Updated the test results.
(WebCore):
Feb 1, 2012:
- 11:48 PM Changeset in webkit [106535] by
-
- 4 edits in trunk/Source/WebCore
Rename [V8DisallowShadowing] to [V8Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=77599
Reviewed by Adam Barth.
This patch renames [V8DisallowShadowing] to [V8Unforgeable], following the Web IDL
spec (http://dev.w3.org/2006/webapi/WebIDL/#Unforgeable).
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- page/DOMWindow.idl:
- page/Location.idl:
- 11:07 PM Changeset in webkit [106534] by
-
- 41 edits in trunk/Source/WebCore
Rename [ConvertNullToNullString] to [TreatNullAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77602
Reviewed by Adam Barth.
This patch renames [ConvertNullToNullString] to [TreatNullAs=EmptyString],
according to the spec (http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs).
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeFromSignature):
- css/CSSCharsetRule.idl:
- css/CSSPageRule.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/WebKitCSSKeyframesRule.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/ProcessingInstruction.idl:
- dom/ShadowRoot.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLOutputElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLTitleElement.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- page/DOMWindow.idl:
- storage/StorageEvent.idl:
- svg/SVGAngle.idl:
- svg/SVGElement.idl:
- svg/SVGLength.idl:
- svg/SVGScriptElement.idl:
- bindings/scripts/test/TestObj.idl: No change in the run-bindings-tests results.
- 10:31 PM Changeset in webkit [106533] by
-
- 2 edits in trunk/Tools
Webkit generate-coverage-data script needs update to use new test script
https://bugs.webkit.org/show_bug.cgi?id=77597
Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-02-01
Reviewed by Dirk Schulze.
- Scripts/generate-coverage-data:
- 10:24 PM Changeset in webkit [106532] by
-
- 6 edits in trunk/Source/WebCore
Remove [GenerateConstructor] from IDL files
https://bugs.webkit.org/show_bug.cgi?id=77598
Reviewed by Adam Barth.
[GenerateConstructor] is used in some IDL files but it is not implemented
in code generators. I could not find any history about [GenerateConstructor]
in code generators. This patch removes them from IDL files.
Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
So simply removing them would make sense.
No new tests. No change in behavior.
- dom/DOMStringList.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- svg/SVGFEConvolveMatrixElement.idl:
- webaudio/AudioPannerNode.idl:
- 9:10 PM Changeset in webkit [106531] by
-
- 9 edits4 adds in trunk
Consider user's preferred language when choosing text tracks
https://bugs.webkit.org/show_bug.cgi?id=74121
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: media/track/track-language-preference.html
media/track/track-prefer-captions.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired): configureTextTracks -> configureNewTextTracks.
(WebCore::HTMLMediaElement::textTracksAreReady): Add more comments.
(WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
(WebCore::HTMLMediaElement::showingTrackWithSameKind): Minor restructuring.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Renamed from userIsInterestedInThisTrack,
don't consider user's language preference.
(WebCore::HTMLMediaElement::configureTextTrackGroup): New, configure all tracks in a group,
considering user's kind and language preferences.
(WebCore::HTMLMediaElement::configureNewTextTracks): New, configure all newly added tracks.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::TrackGroup::TrackGroup):
(TrackGroup):
- platform/Language.cpp:
(WebCore::canonicalLanguageIdentifier): New, create a canonicalized version of a language string.
(WebCore::bestMatchingLanguage): New, return the language from the list that best matches the
specified language.
(WebCore::preferredLanguageFromList): New, return the language in the specified list that best
matches the user's language preference.
- platform/Language.h:
- testing/Internals.cpp:
(WebCore::Internals::setShouldDisplayTrackType): New, allow DRT to set the track type preference.
(WebCore::Internals::shouldDisplayTrackType): New, allow DRT to read the track type preference.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/track/track-language-preference-expected.txt: Added.
- media/track/track-language-preference.html: Added.
- media/track/track-prefer-captions-expected.txt: Added.
- media/track/track-prefer-captions.html: Added.
- platform/mac/Skipped:
- 8:21 PM Changeset in webkit [106530] by
-
- 13 edits in trunk/Source/WebCore
Change class hierarycy so that ShadowRoot can inherit DocumentFragment.
https://bugs.webkit.org/show_bug.cgi?id=76693
Reviewed by Darin Adler.
Make ShadowRoot inherit DocumentFragment so that it matches the class hierarchy of IDL in the spec.
TreeScope becomes a separated class, which is now inherited by Document and ShadowRoot using multiple-inheritance.
This patch is pre-requirement for coming IDL change.
No tests. No change in behavior.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::childrenChanged):
(WebCore::Document::attach):
(WebCore::Document::detach):
- dom/Document.h:
(Document):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment):
- dom/DocumentFragment.h:
(DocumentFragment):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::get):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::attach):
- dom/ShadowRoot.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::findAnchor):
- dom/TreeScope.h:
(WebCore):
(WebCore::TreeScope::rootNode):
(TreeScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
- page/DragController.cpp:
(WebCore::asFileInput):
- page/FocusController.cpp:
(WebCore::ownerOfTreeScope):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):
- 8:11 PM Changeset in webkit [106529] by
-
- 5 edits in trunk/Source/WebCore
WorkerScriptController::evaluate() should not return anything
https://bugs.webkit.org/show_bug.cgi?id=77587
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-01
Reviewed by Adam Barth.
Remove the return value from WorkerScriptController as it is
(and should be) unused.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/js/WorkerScriptController.h:
(WorkerScriptController):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
- 7:25 PM Changeset in webkit [106528] by
-
- 13 edits in trunk/Source/WebCore
Remove [DelegatingPrototypeGetOwnPropertySlot], [HasCustomIndexGetter],
[HasIndexSetter], [JSConstructorTemplate] and [NonEmpty] from code generators
https://bugs.webkit.org/show_bug.cgi?id=77585
Reviewed by Adam Barth.
This patch removes [DelegatingPrototypeGetOwnPropertySlot], [HasCustomIndexGetter],
[HasIndexSetter], [JSConstructorTemplate] and [NonEmpty] from code generators,
since they are not used by no IDL files.
No tests. No change in behavior.
- bindings/scripts/CodeGenerator.pm:
(GetterExpression):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(IsConstructable):
(IsConstructorTemplate):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated the run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore):
- 7:22 PM Changeset in webkit [106527] by
-
- 4 edits2 adds in trunk
Select attribute of HTMLContentElement should be able be changed dynamically.
https://bugs.webkit.org/show_bug.cgi?id=76261
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-01
Reviewed by Hajime Morita.
Source/WebCore:
When select attribute is changed, the flag to recalc style is set.
Test: fast/dom/shadow/content-element-select-dynamic.html
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseMappedAttribute):
Sets recalc style when select is changed.
- html/shadow/HTMLContentElement.h:
(HTMLContentElement):
LayoutTests:
Test cases for changing select attribute dynamically.
- fast/dom/shadow/content-element-select-dynamic-expected.txt: Added.
- fast/dom/shadow/content-element-select-dynamic.html: Added.
- 6:47 PM Changeset in webkit [106526] by
-
- 6 edits in trunk/Source/WebCore
Remove [ImplementationUUID] and [InterfaceUUID] from html/canvas/*.idl
https://bugs.webkit.org/show_bug.cgi?id=77589
Reviewed by Adam Barth.
[ImplementationUUID] and [InterfaceUUID] are used in html/canvas/*.idl,
but they are not implemented in code generators and thus have no meaning.
This patch removes them.
No tests. No change in behavior.
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasPattern.idl: The file is now empty though.
- html/canvas/CanvasRenderingContext.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/WebGLRenderingContext.idl:
- 6:46 PM Changeset in webkit [106525] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r106408.
http://trac.webkit.org/changeset/106408
https://bugs.webkit.org/show_bug.cgi?id=77592
crashes in chromium mac release tests (Requested by japhet on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
- platform/graphics/Region.cpp:
- platform/graphics/Region.h:
(Region):
(Shape):
- 6:42 PM Changeset in webkit [106524] by
-
- 10 edits in trunk/Source
[Texmap] Use glScissors for clipping in TextureMapperGL when possible
https://bugs.webkit.org/show_bug.cgi?id=77575
Reviewed by Martin Robinson.
Source/WebCore:
Maintain a clipping stack, that helps us use stencils in conjunction with scissors.
We apply scissors when the clip region is rectalinear, and stencil when it's not.
No behavior changes so no new tests.
- platform/graphics/opengl/TextureMapperGL.cpp:
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::bindSurface):
(WebCore):
(WebCore::scissorClip):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
- platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
Source/WebKit2:
Instead of applying the scissor clip in QQuickWebPage, we trickle it down to
TextureMapperGL, and apply it there as part of beginClip(). All direct GL operations are
now cleaned out of QQuickWebPage.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
- 6:34 PM Changeset in webkit [106523] by
-
- 2 edits3 moves2 adds in trunk/Source/WebCore
Move the scrolling coordinator to page/scrolling
https://bugs.webkit.org/show_bug.cgi?id=77590
Reviewed by Dan Bernstein.
Put scrolling related files in page/scrolling to avoid cluttering the page directory.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingCoordinator.cpp: Renamed from Source/WebCore/page/ScrollingCoordinator.cpp.
- page/scrolling/ScrollingCoordinator.h: Renamed from Source/WebCore/page/ScrollingCoordinator.h.
- page/scrolling/mac/ScrollingCoordinatorMac.mm: Renamed from Source/WebCore/page/mac/ScrollingCoordinatorMac.mm.
- 6:27 PM Changeset in webkit [106522] by
-
- 4 edits in trunk/Source/WebCore
Remove [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators
https://bugs.webkit.org/show_bug.cgi?id=77588
Reviewed by Adam Barth.
This patch removes [ObjCPrefix], [V8ConstructorTemplate], [allowAccessToNode],
[v8implname] and [v8referenceattr] from code generators, since they are not used
by any IDL files.
No tests. No changes in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(IsConstructable):
(IsConstructorTemplate):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
- 6:19 PM Changeset in webkit [106521] by
-
- 5 edits in trunk
Yarr crash with regexp replace
https://bugs.webkit.org/show_bug.cgi?id=67454
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Properly handle the case of a back reference to an unmatched
subpattern by always matching without consuming any characters.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchBackReference):
(JSC::Yarr::Interpreter::backtrackBackReference):
LayoutTests:
New tests to check for proper handling of back references to
unmatched subpatterns.
- fast/js/regexp-backreferences-expected.txt:
- fast/js/script-tests/regexp-backreferences.js:
- 6:11 PM Changeset in webkit [106520] by
-
- 2 edits in trunk/Tools
Update the tests to show that the mac-ews processes patches from
non-committers.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest.test_committer_only_ewses):
(EarlyWarningSytemTest.test_builder_ewses):
- 6:08 PM Changeset in webkit [106519] by
-
- 2 edits in branches/chromium/1025/Source/WebCore/platform/network
Merge 106514 - contentDispositionType misparses the Content-Disposition header in some obscure corner cases
https://bugs.webkit.org/show_bug.cgi?id=77577
Reviewed by Eric Seidel.
The contentDispositionType extracts the disposition-type from the
Content-Disposition header. According to RFC 6266 (and previous RFCs),
the disposition-type must be an RFC 2616 token. Rather than enforce
this general rule, we had special-cased some examples (including
name=foo and filename=bar). This patch generalizes our check to
properly validate that the disposition-type is an RFC 2616 token.
In conjunction with some other work in the Chromium network stack, this
causes Chromium to pass the following tests:
http://greenbytes.de/tech/tc2231/#inlonlyquoted
http://greenbytes.de/tech/tc2231/#attonlyquoted
Without this patch, these test cases neither trigger a navigation nor a
download in Chromium. This patch does not appear to cause any visible
change in Safari. (Safari passes these tests both before and after
this patch.)
- platform/network/HTTPParsers.cpp:
(WebCore::isRFC2616Token):
(WebCore::contentDispositionType):
- This patch also adds a comment to filenameFromHTTPContentDisposition, which explains some of the was this function incorrectly implements the requirements in RFC 6266. Resolving these issues is a subject for a future patch.
- platform/network/HTTPParsers.h:
TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9309049
- 5:56 PM Changeset in webkit [106518] by
-
- 9 edits in trunk/Tools
Mac-ews logs are huge
https://bugs.webkit.org/show_bug.cgi?id=77045
Reviewed by Eric Seidel.
In order to get the cr-linux-ews bot to run tests on EC2, we created
the chromium-xvfb port, which contained a number of tweaks to the
Chromium port's behavior. This patch refactors those tweaks so they
can be shared with the mac-ews, mostly by moving them into the
non-interactive mode of RunTests.
- Scripts/webkitpy/common/config/ports.py:
(WebKitPort):
(WebKitPort.layout_tests_results_path):
(ChromiumPort.run_javascriptcore_tests_command):
(ChromiumXVFBPort):
(ChromiumXVFBPort.run_webkit_tests_command):
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort):
(MockPort.layout_tests_results_path):
- Scripts/webkitpy/common/config/ports_unittest.py:
(WebKitPortTest.test_chromium_xvfb_port):
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_no_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
- 5:40 PM Changeset in webkit [106517] by
-
- 3 edits in trunk/Tools
Roll out r106442. It made some tests more stable but others less stable.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set):
- 5:39 PM Changeset in webkit [106516] by
-
- 5 edits in trunk
Support targetOrigin = "/" in postMessage for sending messages to same origin as source document.
https://bugs.webkit.org/show_bug.cgi?id=77580
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-01
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Modified http/tests/security/postMessage/target-origin.html
to test this case as well.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
LayoutTests:
- http/tests/security/postMessage/target-origin-expected.txt:
- http/tests/security/postMessage/target-origin.html:
- 4:20 PM Changeset in webkit [106515] by
-
- 32 edits in trunk/Source
Avoid creating NamedNodeMap unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=77574
Reviewed by Ryosuke Niwa.
Source/WebCore:
The method Element::attributes() was being used for multiple things in our
codebase: (1) as the getter for NamedNodeMap exposed to DOM, (2) as a way to other WebCore
code get the "attribute storage" (currently inside NamedNodeMap), and (3) as a way to
get the attribute storage creating one if necessary.
This commit separate the jobs in different functions:
1) attributes() keeps being the DOM getter, and loses its boolean parameter.
2) updatedAttributes() updates the invalid attributes and returns the attribute
storage. If we don't have one, return 0.
3) ensureUpdatedAttributes() updates the invalid attributes and forces the
creation of attribute storage to return.
There is also another way to get to the attribute storage currently, via
attributeMap(), which doesn't update the attributes for possible changes in Style
or SVG attributes.
Note that the new functions are not available in Node class, so C++ code manipulating
attributes should cast to Element.
This separation also made easier to spot and fix some places where we do not
need to create the attribute storage if it doesn't exist.
No new tests, this commit shouldn't change the behavior of existing code.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
- dom/Document.cpp:
(WebCore::Document::importNode):
- dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::hasAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
- dom/Element.h:
(Element):
(WebCore::Element::attributes):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributes):
(WebCore::Element::updatedAttributes):
(WebCore::Element::setAttributesFromElement):
(WebCore::Element::ensureAttributeMap): Made const to be reused by ensureUpdatedAttributes().
(WebCore::Element::updateInvalidAttributes):
(WebCore):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mapsEquivalent): Having no attributes is equivalent to
not having an attribute storage because the attribute storage is lazily created.
- dom/Node.cpp:
(WebCore::Node::isEqualNode): Do not force the creation of attribute storage to
compare two nodes.
(WebCore::Node::isDefaultNamespace): Use updatedAttributes(). Since we iterate
using length, it's OK if the attribute storage is empty.
(WebCore::Node::lookupNamespaceURI): Ditto.
(WebCore::Node::lookupNamespacePrefix): Ditto.
(WebCore::Node::compareDocumentPosition): Ditto.
- editing/ApplyStyleCommand.cpp:
(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::isRemovableBlock): Use isElementNode() explicitly
to identify non-Element nodes, then use hasAttributes() if is Element.
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::highestVisuallyEquivalentDivBelowRoot):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendElement): Do not create the attribute storage
unnecessarily.
- editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Do not create the attribute storage
unnecessarily. Use mapsEquivalent() for comparing the attributes.
- editing/markup.cpp:
(WebCore::completeURLs): Do not create the attribute storage unnecessarily.
(WebCore::StyledMarkupAccumulator::appendElement): Ditto.
(WebCore::isPlainTextMarkup): hasAttributes() will avoid creating the attribute
storage unnecessarily.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parametersForPlugin):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
- html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLAttribute): Do not create the attribute storage
unnecessarily.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement): Use
ensureUpdatedAttributes() since we will add new attributes.
(WebCore):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
- page/PageSerializer.cpp:
(WebCore::isCharsetSpecifyingNode): Do not assume attributeMap will exist.
- svg/properties/SVGAnimatedPropertySynchronizer.h: Use ensureUpdatedAttributes()
since we will add new attributes.
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate): Do not create the attribute storage
unnecessarily.
- xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::traversalSort):
- xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Use isElementNode() instead of comparing
nodeType() manually. Do not create the attribute storage unnecessarily.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser): Do not create the attribute
storage unnecessarily.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser): Ditto.
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::XMLTreeBuilder): Ditto.
Source/WebKit/chromium:
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::openTagToString): use updatedAttributes().
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::attributeNames): use updateAttributes().
- 4:14 PM Changeset in webkit [106514] by
-
- 3 edits in trunk/Source/WebCore
contentDispositionType misparses the Content-Disposition header in some obscure corner cases
https://bugs.webkit.org/show_bug.cgi?id=77577
Reviewed by Eric Seidel.
The contentDispositionType extracts the disposition-type from the
Content-Disposition header. According to RFC 6266 (and previous RFCs),
the disposition-type must be an RFC 2616 token. Rather than enforce
this general rule, we had special-cased some examples (including
name=foo and filename=bar). This patch generalizes our check to
properly validate that the disposition-type is an RFC 2616 token.
In conjunction with some other work in the Chromium network stack, this
causes Chromium to pass the following tests:
http://greenbytes.de/tech/tc2231/#inlonlyquoted
http://greenbytes.de/tech/tc2231/#attonlyquoted
Without this patch, these test cases neither trigger a navigation nor a
download in Chromium. This patch does not appear to cause any visible
change in Safari. (Safari passes these tests both before and after
this patch.)
- platform/network/HTTPParsers.cpp:
(WebCore::isRFC2616Token):
(WebCore::contentDispositionType):
- This patch also adds a comment to filenameFromHTTPContentDisposition, which explains some of the was this function incorrectly implements the requirements in RFC 6266. Resolving these issues is a subject for a future patch.
- platform/network/HTTPParsers.h:
- 4:09 PM Changeset in webkit [106513] by
-
- 2 edits in trunk/Source/WebKit/win
Another attempt to fix the Windows build.
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
- 4:08 PM Changeset in webkit [106512] by
-
- 12 edits in trunk
calling function on catch block scope containing an eval result in wrong this value being passed
https://bugs.webkit.org/show_bug.cgi?id=77581
Reviewed by Oliver Hunt.
javascript:function F(){ return 'F' in this; }; try { throw F; } catch (e) { eval(""); alert(e()); }
Source/JavaScriptCore:
- bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createTryStatement):
- parser/NodeConstructors.h:
(JSC::TryNode::TryNode):
- parser/Nodes.h:
(TryNode):
- parser/Parser.cpp:
(JSC::::parseTryStatement):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createTryStatement):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::isStaticScopeObject):
(JSC):
LayoutTests:
- fast/js/eval-var-decl-expected.txt:
- fast/js/script-tests/eval-var-decl.js:
(checkThis):
(testEvalInCatch):
- 4:01 PM Changeset in webkit [106511] by
-
- 23 edits in trunk/Source
Source/WebCore: WebCore part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=77505
Reviewed by Darin Adler.
- page/Page.h:
(WebCore::Page::Pagination::Pagination): Added initializer for the behavesLikeColumns member
variable.
(WebCore::Page::Pagination::operator==): Added comparison of behavesLikeColumns values.
(Pagination): Added behavesLikeColumns member variable. When set to false (the default),
paginated display respects the page-break-{before,after} properties rather than the
column-break-{before,after} ones.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo): Added initializer for the m_paginationUnit member.
(WebCore::ColumnInfo::paginationUnit): Added this getter.
(WebCore::ColumnInfo::setPaginationUnit): Added this setter.
(ColumnInfo): Added m_paginationUnit member. It defaults to Column.
- rendering/LayoutState.h:
(WebCore::LayoutState::isPaginatingColumns): Changed to check the pagination unit.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Added code to set the pagination unit in the ColumnInfo.
(WebCore::RenderBlock::paginationUnit): Added. The base class implementation returns Column.
- rendering/RenderBlock.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::paginationUnit): Added this override that returns Page, unless
this is the RenderView for the main frame and pagination is set to behave like columns.
- rendering/RenderView.h:
Source/WebKit/mac: WebKit/mac part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=77505
Reviewed by Darin Adler.
- WebView/WebView.mm:
(-[WebView _setPaginationBehavesLikeColumns:]): Added this setter.
(-[WebView _paginationBehavesLikeColumns]): Added this getter.
- WebView/WebViewPrivate.h:
Source/WebKit2: WebKit2 part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=77505
Reviewed by Darin Adler.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode): Encode paginationBehavesLikeColumns.
(WebKit::WebPageCreationParameters::decode): Decode paginationBehavesLikeColumns.
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters): Added paginationBehavesLikeColumns boolean.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationBehavesLikeColumns): Added this setter.
(WKPageGetPaginationBehavesLikeColumns): Added this getter.
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Added this Objective-C
wrapper around WKPageSetPaginationBehavesLikeColumns.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Added this Objective-C wrapper
around WKPageGetPaginationBehavesLikeColumns.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Added call to setPaginationBehavesLikeColumns() with
the value from the creation parameters.
(WebKit::WebPageProxy::setPaginationBehavesLikeColumns): Added this setter.
(WebKit::WebPageProxy::creationParameters): Populate paginationBehavesLikeColumns.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::paginationBehavesLikeColumns): Added this getter.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaginationBehavesLikeColumns): Added this setter.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Added SetPaginationBehavesLikeColumns message.
- 3:59 PM Changeset in webkit [106510] by
-
- 3 edits3 adds in trunk
Backgrounds in HTML inside foreignObject don't draw
https://bugs.webkit.org/show_bug.cgi?id=23111
Patch by Florin Malita <fmalita@google.com> on 2012-02-01
Reviewed by Eric Seidel.
Source/WebCore:
Test: svg/foreignObject/body-background.svg
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackground):
Tweak the <body> background inhibiting logic to allow drawing when the element is embedded in FOs.
LayoutTests:
- svg/foreignObject/body-background-expected.png: Added.
- svg/foreignObject/body-background-expected.txt: Added.
- svg/foreignObject/body-background.svg: Added.
- 3:58 PM Changeset in webkit [106509] by
-
- 2 edits in trunk/Tools
Enable EWS for non-contributers.
https://bugs.webkit.org/show_bug.cgi?id=77576
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
- 3:54 PM Changeset in webkit [106508] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r104727): Strange graphics corruption opening a new tab in Safari
https://bugs.webkit.org/show_bug.cgi?id=77578
<rdar://problem/10767174>
Reviewed by Dan Bernstein.
Resizing a window will always invalidate the window backing store, so make sure to set
_data->_windowHasValidBackingStore to NO whenever that happens.
- UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
Use separate methods for the NSWindowDidMoveNotification and NSWindowDidResizeNotification notifications.
(-[WKView _windowDidMove:]):
Call -[WKView _updateWindowAndViewFrames].
(-[WKView _windowDidResize:]):
Call -[WKView _updateWindowAndViewFrames] and mark the window backing store as invalid.
- 3:36 PM Changeset in webkit [106507] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 3:32 PM Changeset in webkit [106506] by
-
- 3 edits in trunk/Source/WebCore
Make one able to set the local storage (tracker) database dir's path
https://bugs.webkit.org/show_bug.cgi?id=77006
Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-01
Reviewed by Darin Adler.
There are no behavior changes with the diff, so no need for new tests.
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore):
(WebCore::StorageTracker::databaseDirectoryPath):
- storage/StorageTracker.h:
(StorageTracker):
- 3:29 PM Changeset in webkit [106505] by
-
- 3 edits in trunk/Source/WebCore
Fix Window build.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDidCreateTiles):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDidCreateTiles):
- 3:23 PM Changeset in webkit [106504] by
-
- 24 edits in trunk
Add support for inferred function names
https://bugs.webkit.org/show_bug.cgi?id=77579
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Add new "inferred" names to function expressions, getters, and setters.
This property is not exposed to JS, so is only visible in the debugger
and profiler.
- JavaScriptCore.exp:
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::makeAssignNode):
- parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
(JSC::FunctionBodyNode::inferredName):
(FunctionBodyNode):
- profiler/Profiler.cpp:
(JSC):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/Executable.h:
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::inferredName):
(FunctionExecutable):
- runtime/JSFunction.cpp:
(JSC::JSFunction::calculatedDisplayName):
(JSC):
(JSC::getCalculatedDisplayName):
- runtime/JSFunction.h:
(JSC):
LayoutTests:
Update test case results.
- fast/profiler/anonymous-event-handler-expected.txt:
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
- fast/profiler/anonymous-function-calls-eval-expected.txt:
- fast/profiler/built-in-function-calls-anonymous-expected.txt:
- fast/profiler/inline-event-handler-expected.txt:
- fast/profiler/many-calls-in-the-same-scope-expected.txt:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt:
- fast/profiler/nested-anonymous-functon-expected.txt:
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
- 3:11 PM Changeset in webkit [106503] by
-
- 6 edits in trunk/Source/WebCore
GetMIMEDescription should return const char *
https://bugs.webkit.org/show_bug.cgi?id=77297
Patch by John Yani <vanuan@gmail.com> on 2012-02-01
Reviewed by Alexey Proskuryakov.
No new tests. No change in behaviour.
- plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::fetchInfo):
- plugins/efl/PluginPackageEfl.cpp:
(WebCore):
(WebCore::PluginPackage::fetchInfo):
- plugins/npapi.h:
- plugins/npfunctions.h:
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo):
- 3:08 PM Changeset in webkit [106502] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG should fold double-to-int conversions
https://bugs.webkit.org/show_bug.cgi?id=77532
Reviewed by Oliver Hunt.
Performance neutral on major benchmarks. But it makes calling V8's
Math.random() 4x faster.
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::addOrFindConstant):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addConstant):
(CodeBlock):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::isInt32Constant):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
(DFG):
(JSC::DFG::SpeculativeJIT::compileArithSub):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::valueOfNumberConstantAsInt32):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSValueInlineMethods.h:
(JSC::JSValue::asDouble):
- 3:08 PM Changeset in webkit [106501] by
-
- 2 edits in trunk/Source/WebCore
Consolidate duplicate "willHide" functions in DetailedHeapshotView.js to fix
a syntax error in JSC and make the Inspector open again in Release builds.
Reviewed by Brian Weinstein.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide): Consolidated.
(WebInspector.DetailedHeapshotView.prototype.willHide): Removed.
- 3:05 PM Changeset in webkit [106500] by
-
- 18 edits in trunk/Source
[Chromium] Enable deferred canvas rendering in the skia port
https://bugs.webkit.org/show_bug.cgi?id=76732
Patch by Justin Novosad <junov@chromium.org> on 2012-02-01
Reviewed by Stephen White.
Source/WebCore:
No new tests: covered by existing canvas layout tests
Adding a new setting to enable deferred 2d canvas rendering.
Added support for deferred 2d canvas rendering in ImageBufferSkia
and Canvas2DLayerChromium, mostly plumbing. Deffered rendering
implementation is provided by skia (class SkDeferredCanvas).
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldDefer):
(WebCore):
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setAccelerated2dCanvasEnabled):
(WebCore):
(WebCore::Settings::setDeferred2dCanvasEnabled):
- page/Settings.h:
(Settings):
(WebCore::Settings::deferred2dCanvasEnabled):
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(ImageBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore):
(WebCore::Canvas2DLayerChromium::setCanvas):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp:
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::AcceleratedDeviceContext::flush):
(WebCore):
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Source/WebKit/chromium:
Adding a new setting for enabling deferred 2d canvas rendering
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- 2:58 PM Changeset in webkit [106499] by
-
- 1 copy in tags/Safari-534.54.13
New tag.
- 2:55 PM Changeset in webkit [106498] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 2:27 PM Changeset in webkit [106497] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG graph dump for GetScopedVar should show the correct prediction
https://bugs.webkit.org/show_bug.cgi?id=77530
Reviewed by Geoff Garen.
GetScopedVar has a heap prediction, not a variable prediction. But it does
have a variable. Hence we need to check for heap predictions before checking
for variable predictions.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- 2:15 PM Changeset in webkit [106496] by
-
- 7 edits in trunk
Replace JSArray destructor with finalizer
https://bugs.webkit.org/show_bug.cgi?id=77488
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- runtime/JSArray.cpp:
(JSC::JSArray::finalize): Added finalizer.
(JSC::JSArray::allocateSparseMap): Factored out code for allocating new sparse maps.
(JSC):
(JSC::JSArray::deallocateSparseMap): Factored out code for deallocating sparse maps.
(JSC::JSArray::enterDictionaryMode): Renamed enterSparseMode to enterDictionaryMode
because the old name was confusing because we could have a sparse array that never
called enterSparseMode.
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
- runtime/JSArray.h:
(JSArray):
LayoutTests:
- fast/js/script-tests/sparse-array.js: Added code to test oscillation between
sparse and dense arrays.
- fast/js/sparse-array-expected.txt:
- 2:12 PM Changeset in webkit [106495] by
-
- 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merged r106207.
- 2:05 PM Changeset in webkit [106494] by
-
- 2 edits in trunk/Source/WebCore
Gcc build fix after r106482.
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- 2:02 PM Changeset in webkit [106493] by
-
- 4 edits in trunk/LayoutTests
rebaseline box-shadow-clipped-slices
https://bugs.webkit.org/show_bug.cgi?id=77565
Patch by Elliot Poger <epoger@google.com> on 2012-02-01
Reviewed by Stephen White.
- platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- 1:52 PM Changeset in webkit [106492] by
-
- 34 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=77383
Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
-and corresponding-
<rdar://problem/10709560>
Reviewed by Sam Weinig.
Source/WebCore:
The goal is to re-vamp didFirstVisuallyNonEmptyLayout to be more accurate.
This patch adds a new heuristic called didNewFirstVisuallNonEmptyLayout and
leaves the old one for the time being. That is temporary.
The heuristic for didNewFirstVisuallNonEmptyLayout is to count relevant
painted RenderObjects on Page.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setPaintedObjectsCounterThreshold):
(WebCore::Page::addRelevantRepaintedObject):
- page/Page.h:
(WebCore):
(Page):
(WebCore::Page::startCountingRepaintedObjects):
- WebCore.exp.in:
Start counting relevant painted RenderObjects on the page once the first
layout is complete.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Machinery for firing didNewFirstVisuallNonEmptyLayout.
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didNewFirstVisuallyNonEmptyLayout):
(WebCore):
- loader/FrameLoader.h:
(FrameLoader):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
These RenderObjects are the ones that this api currently consider to be
relevant. If their repaint rects intersect with the viewRect, then they are
added to the relevant objects set on the Page.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintReplaced):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
Source/WebKit2:
Machinery for didNewFirstVisuallNonEmptyLayout.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didNewFirstVisuallyNonEmptyLayout):
(WebKit):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout):
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout):
(WebKit):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
This temporary API allows the client to specify the threshold for the painted
objects counter on Page. This is temporary.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPaintedObjectsCounterThreshold):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaintedObjectsCounterThreshold):
(WebKit):
- WebProcess/WebPage/WebPage.h:
(WebPage):
Tools:
WebKit2's WebLoaderClient has a temporary new function that must be accounted
for.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 1:49 PM Changeset in webkit [106491] by
-
- 2 edits in branches/safari-534.54-branch/Source/WebCore
Merged r106286.
- 1:48 PM Changeset in webkit [106490] by
-
- 8 edits2 adds in trunk
CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
https://bugs.webkit.org/show_bug.cgi?id=49058
Reviewed by Andreas Kling.
Source/WebCore:
CSSMutableStyleDeclaration::getPropertyPriority was not handling shorthands properly. Shorthands are
not part of the property list of the style so we need to query the longhands which are the one added
in the list. Only if the longhands have equal priority the shorthand priority is known. I also renamed
getPropertyPriority (not the CSSOM exposed method) to something more consistent with WebKit naming guidelines.
Test: fast/css/shorthand-priority.html
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::propertyIsImportant):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
- css/CSSMutableStyleDeclaration.h:
(CSSMutableStyleDeclaration):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::collapseTextDecorationProperties):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::setTextDecorationProperty):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
Source/WebKit/qt:
Update the code as getPropertyPriority has been renamed to propertyIsImportant.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
LayoutTests:
- fast/css/shorthand-priority-expected.txt: Added.
- fast/css/shorthand-priority.html: Added.
- 1:46 PM Changeset in webkit [106489] by
-
- 10 edits in branches/safari-534.54-branch/Source
Merged r106271.
- 1:34 PM Changeset in webkit [106488] by
-
- 3 edits2 adds in trunk
Crash in EventHandler::updateDragAndDrop
https://bugs.webkit.org/show_bug.cgi?id=77569
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/events/remove-target-with-shadow-in-drag.html
- page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
LayoutTests:
- fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
- fast/events/remove-target-with-shadow-in-drag.html: Added.
- 1:18 PM Changeset in webkit [106487] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r106382.
http://trac.webkit.org/changeset/106382
https://bugs.webkit.org/show_bug.cgi?id=77571
Causing chromium crashes in PNGImageDecoder (Requested by
japhet on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
Source/WebCore:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
- page/Console.cpp:
(WebCore::Console::time):
(WebCore::Console::timeEnd):
- platform/chromium/PlatformSupport.h:
- platform/chromium/TraceEvent.h:
(internal):
(ScopeTracer):
(WebCore::internal::ScopeTracer::ScopeTracer):
(WebCore::internal::ScopeTracer::~ScopeTracer):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::isTraceEventEnabled):
(WebKit::WebKitPlatformSupport::traceEventBegin):
(WebKit::WebKitPlatformSupport::traceEventEnd):
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::isTraceEventEnabled):
(WebCore):
(WebCore::PlatformSupport::traceEventBegin):
(WebCore::PlatformSupport::traceEventEnd):
- 12:48 PM Changeset in webkit [106486] by
-
- 4 edits in releases/WebKitGTK/webkit-1.6
.: Update the version number in preparation for the 1.6.3 release.
Reviewed by Xan Lopez.
- configure.ac: Update the library version.
Source/WebKit/gtk: Update the NEWS file in preparation for the 1.6.3 release.
Reviewed by Xan Lopez.
- NEWS: Update this file.
- 12:39 PM Changeset in webkit [106485] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6
Manually pull in the gthread library, as it seems that
with gold it doesn't happen automatically.
Reviewed by Xan Lopez.
- Source/autotools/webkit.m4:
- 12:10 PM Changeset in webkit [106484] by
-
- 2 edits in releases/WebKitGTK/webkit-1.6
Restore Source/WebKit/gtk/webkit/webkitversion.h to the list of files
processed by autoconfig.
- configure.ac: Re-add the file.
- 12:02 PM Changeset in webkit [106483] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Darin Adler.
Simplify the code that creates a new tile layer by getting a reference to the RetainPtr<WebTileLayer>&
slot in the hash map and assign directly into it.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):
- 11:59 AM Changeset in webkit [106482] by
-
- 6 edits in trunk/Source/WebCore
Tile cache doesn't have an upper limit
https://bugs.webkit.org/show_bug.cgi?id=77564
<rdar://problem/10710744>
Reviewed by Darin Adler.
Cache enough tiles to cover 3x the visible height and 2x the visible width of the page,
and drop tiles that are outside that area.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
Call GraphicsLayerClient::notifySyncRequired here, which will schedule a layer flush and ensure that
the page layout is up to date before the new tiles are painted.
- platform/graphics/ca/PlatformCALayerClient.h:
Add platformCALayerDidCreateTiles member function.
- platform/graphics/ca/mac/TileCache.h:
Update for new/removed member functions and member variables.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
Initialize the tile revalidation timer.
(WebCore::TileCache::tileCacheLayerBoundsChanged):
If we don't have any tiles at all right now, revalidate the tiles immediately. Otherwise,
schedule the revalidation timer.
(WebCore::TileCache::setNeedsDisplayInRect):
Return early if we have no tiles.
(WebCore::TileCache::visibleRectChanged):
Schedule tile revalidation.
(WebCore::TileCache::rectForTileIndex):
New helper function that returns the bounds rect of a tile given its tile index.
(WebCore::TileCache::getTileIndexRangeForRect):
Clamp the rect to the bounds of the tile cache layer.
(WebCore::TileCache::scheduleTileRevalidation):
Schedule the revalidation timer if it hasn't already been scheduled.
(WebCore::TileCache::tileRevalidationTimerFired):
Call revalidateTiles.
(WebCore::TileCache::revalidateTiles):
Compute the tile coverage rect and remove all tiles that are outside. Create new tiles for any
parts of the tile coverage rect that don't have tiles already.
(WebCore::TileCache::tileLayerAtIndex):
Remove invalid assertions.
- 11:52 AM Changeset in webkit [106481] by
-
- 4 edits3 adds in trunk
TestWebKitAPI isn't being built on chromium bots any more
https://bugs.webkit.org/show_bug.cgi?id=77563
Reviewed by Dimitri Glazkov.
I accidentally dropped it in the refactoring in r105449.
Source/WebKit/chromium:
- All.gyp:
Tools:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
- 11:41 AM Changeset in webkit [106480] by
-
- 3 edits in trunk/LayoutTests
Fixed some lines in the date-constructor.js test.
https://bugs.webkit.org/show_bug.cgi?id=75892
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-01
Reviewed by Gavin Barraclough.
- fast/js/date-constructor-expected.txt:
- fast/js/script-tests/date-constructor.js:
- 11:38 AM Changeset in webkit [106479] by
-
- 5 edits14 adds in trunk
Source/WebCore: Add support for fixed and percent min-width on the table element for table-layout: auto to
match Firefox and Opera's behavior.
In FixedTableLayout.cpp, the computePreferredLogicalWidths method looks like it has
issues based on the comment: "FIXME: This entire calculation is incorrect for both
minwidth and maxwidth." (minwidth and maxwidth refer to the preferred widths, not the
min-width and max-width styles). I have not implemented min-width for FixedTableLayout
in this patch since it requires some more research around that comment.
min-width and max-width on the table element was discussed on the www-style list:
http://lists.w3.org/Archives/Public/www-style/2012Jan/0684.html
min-width is not implemented on <table> for table-layout: auto
https://bugs.webkit.org/show_bug.cgi?id=76553
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-01
Reviewed by Julien Chaffraix.
Test: fast/table/min-width.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
If the min or max preferred logical width is less than a fixed min width style, it is
set to the fixed min width style. Like a percent width style, a percent min-width style
does not affect the min or max preferred logical widths computed by the table layout
algorithm. RenderTable's computeLogicalWidth method handles percent min-width styles.
min-width for the table-layout: fixed case has been split out into this bug:
https://bugs.webkit.org/show_bug.cgi?id=76948
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
If the RenderStyle's logical min width is defined and greater than the logical width
calculation, this method sets the logical width to the logical min width.
(WebCore::RenderTable::convertStyleWidthToComputedWidth):
This new method generalizes and factors out logic from RenderTable::computeLogicalWidth
that converted the width style to a computed value in the fixed and percent case.
RenderTable::computeLogicalWidth now calls this method to determine the computed values
for both the width style and the min-width style. In the future, it can also be used for
the max-width style.
Note that this method handles the special CSS table case, which requires borders and
paddings to be included in the computed width calculation. This applies to all width
styles, including width, min-width, and max-width. Before, this special case was handled
in RenderTable::computeLogicalWidth.
- rendering/RenderTable.h:
LayoutTests: Add support for min-width on the table element.
min-width is not implemented on <table> for table-layout: auto
https://bugs.webkit.org/show_bug.cgi?id=76553
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-01
Reviewed by Julien Chaffraix.
- fast/table/min-width-css-block-table.html: Added.
- fast/table/min-width-css-block-table-expected.txt: Added.
- fast/table/min-width-css-inline-table.html: Added.
- fast/table/min-width-css-inline-table-expected.txt: Added.
- fast/table/min-width-html-block-table.html: Added.
- fast/table/min-width-html-block-table-expected.txt: Added.
- fast/table/min-width-html-inline-table.html: Added.
- fast/table/min-width-html-inline-table-expected.txt: Added.
- fast/table/script-tests/min-width-css-block-table.js: Added.
(computeLogicalWidth):
- fast/table/script-tests/min-width-css-inline-table.js: Added.
(computeLogicalWidth):
- fast/table/script-tests/min-width-helpers.js: Added.
(runTests):
(createTableStyle):
(computeLogicalWidthHelper):
(createSpan):
- fast/table/script-tests/min-width-html-block-table.js: Added.
(computeLogicalWidth):
- fast/table/script-tests/min-width-html-inline-table.js: Added.
(computeLogicalWidth):
- 11:37 AM Changeset in webkit [106478] by
-
- 4 edits in trunk/Source/JavaScriptCore
Refactor identifier resolution in BytecodeGenerator
https://bugs.webkit.org/show_bug.cgi?id=76285
Patch by Andy Wingo <wingo@igalia.com> on 2012-02-01
Reviewed by Geoffrey Garen.
- bytecompiler/BytecodeGenerator.h:
(JSC::ResolveResult): New class, to describe the storage
location corresponding to an identifier in a program.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve): New function, replacing
findScopedProperty.
(JSC::BytecodeGenerator::resolveConstDecl): New function,
encapsulating what ConstDeclNode::emitBytecode used to do.
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar): New functions,
corresponding to the old emitGetScopedVar and emitPutScopedVar.
(JSC::BytecodeGenerator::registerFor): Remove version that took an
Identifier&; replaced by ResolveResult::local().
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis): Change to accept a
"resolveResult" argument. This is more clear, and reduces the
amount of double analysis happening at compile-time.
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode): Refactor to use the new
ResolveResult structure.
- 11:21 AM Changeset in webkit [106477] by
-
- 4 edits in trunk
[SKIA/CHROMIUM] Perform getImageData format conversions using Skia
https://bugs.webkit.org/show_bug.cgi?id=77553
Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.
Source/WebCore:
Many existing canvas tests exercise this functionality.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 10:45 AM Changeset in webkit [106476] by
-
- 3 edits3 adds in trunk
Source/WebCore: preventDefault() in a mousedown in a subframe should not
prevent the scrollbar from handling mouse movements if the
cursor leaves the subframe.
https://bugs.webkit.org/show_bug.cgi?id=73097
Reviewed by Darin Adler.
Test: fast/events/scroll-div-with-prevent-default-in-subframe.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=73097.
Test adapted from repro case provided by zacklloyd@google.com.
Reviewed by Darin Adler.
- fast/events/resources/subframe-with-scrollable-div.html: Added.
- fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added.
- fast/events/scroll-div-with-prevent-default-in-subframe.html: Added.
- 10:29 AM Changeset in webkit [106475] by
-
- 5 edits in trunk
Rename WebSpeechInputResult::set() to assign()
https://bugs.webkit.org/show_bug.cgi?id=77540
Reviewed by Darin Fisher.
Source/WebKit/chromium:
It was suggested in a previous code review
(https://bugs.webkit.org/show_bug.cgi?id=77083#c5)
that this function should be called assign().
- public/WebSpeechInputResult.h:
(WebSpeechInputResult):
(WebKit::WebSpeechInputResult::set):
- src/WebSpeechInputResult.cpp:
(WebKit::WebSpeechInputResult::assign):
Tools:
- DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(MockWebSpeechInputController::addMockRecognitionResult):
(MockWebSpeechInputController::speechTaskFired):
- 10:04 AM Changeset in webkit [106474] by
-
- 3 edits in trunk/Tools
[GTK] WebKit1 API documentation is not generated when building with gtk-2.0
https://bugs.webkit.org/show_bug.cgi?id=77542
Reviewed by Martin Robinson.
- gtk/generate-gtkdoc: Check first whether there's
webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
instead.
(get_webkit2_options): Return just the options since the
pkg_config_path doesn't depend on options
(get_webkit1_options): Ditto.
(generate_doc): Helper function to create a generator and generate
documentation for the given pkg-config file with the given options.
- gtk/gtkdoc.py:
(GTKDoc.init): Don't use for args parameter, since it's
used as a dict and never expanded.
(PkgConfigGTKDoc.init): Ditto.
- 10:01 AM Changeset in webkit [106473] by
-
- 2 edits in trunk/Tools
[GTK] API documentation is not installed even when building with --enable-gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=77094
Reviewed by Martin Robinson.
- GNUmakefile.am: Add install-data-local and uninstall-local rules
to install/uninstall WebKit1 and WebKit2 API documentation.
- 9:58 AM Changeset in webkit [106472] by
-
- 4 edits in trunk
[GTK] editing/inserting/4960120-2.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=76815
Reviewed by Martin Robinson.
Source/WebCore:
Check if the node for the first parent object not ignoring
accessibility is null before using it. This might happen with
certain kind of accessibility objects, such as the root one (the
scroller containing the webArea object as its only child).
- accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(objectFocusedAndCaretOffsetUnignored): Add missing null check.
LayoutTests:
- platform/gtk/test_expectations.txt: Unskipping tests that
shouldn't be crashing from now on.
- 9:41 AM Changeset in webkit [106471] by
-
- 10 edits in trunk/Source/WebCore
Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
https://bugs.webkit.org/show_bug.cgi?id=77545
Reviewed by Andreas Kling.
This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.
On negative side this increases memory use of CSSMappedAttributeDeclaration by one ptr and refcount
(it loses the vptr) in total.
This is not meant to be the end state, just an intermediate refactoring step. CSSMappedAttributeDeclaration
should clearly be renamed too but this patch doesn't do that. It might not exist in its current form
much longer.
- css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
(WebCore::CSSMutableStyleDeclaration::merge):
- css/CSSMutableStyleDeclaration.h:
Remove protected section. No subclasses remain.
Rename setPropertyInternal() to setProperty(). All public methods here are internal.
(CSSMutableStyleDeclaration):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseMappedAttributeValue):
- dom/Attribute.cpp:
(WebCore::Attribute::clone):
- dom/Attribute.h:
(Attribute):
(WebCore::Attribute::decl):
(WebCore::Attribute::mappedAttributeDeclaration):
(WebCore::Attribute::setMappedAttributeDeclaration):
(WebCore::Attribute::Attribute):
- dom/CSSMappedAttributeDeclaration.cpp:
(WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
(WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):
- dom/CSSMappedAttributeDeclaration.h:
(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
Make CSSMutableStyleDeclaration a member instead of the base class.
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):
(WebCore::StyledElement::createMappedDecl):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 9:38 AM Changeset in webkit [106470] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Set all PlatformTouchPoint values possible from a QTouch event.
https://bugs.webkit.org/show_bug.cgi?id=77442
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-01
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
- 9:22 AM Changeset in webkit [106469] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: move type builder code to dedicated InspectorTypeBuilder .h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=77471
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-01
Reviewed by Yury Semikhatsky.
Code is moved physically to other file -- generator is changed accrodingly.
- inspector/CodeGeneratorInspector.py:
(String):
(provides):
(typename):
(Array):
- 9:03 AM Changeset in webkit [106468] by
-
- 6 edits2 adds in trunk
Web Inspector: debugger reports wrong sources when paused in inline script on page reload
https://bugs.webkit.org/show_bug.cgi?id=77548
Source/WebCore:
V8 returns treats each script source as ending with \n, now we take
this into account when reporting script line count to the inspector
front-end.
Reviewed by Vsevolod Vlasov.
Test: inspector/debugger/pause-in-inline-script.html
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
- bindings/v8/DebuggerScript.js:
LayoutTests:
Reviewed by Vsevolod Vlasov.
- inspector/debugger/debugger-scripts-expected.txt:
- inspector/debugger/pause-in-inline-script-expected.txt: Added.
- inspector/debugger/pause-in-inline-script.html: Added.
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
- 8:50 AM Changeset in webkit [106467] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] unittests/testloading crashes
https://bugs.webkit.org/show_bug.cgi?id=77544
Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-01
Reviewed by Xan Lopez.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Bail out
early from dispatchDidFailLoading if the error is the result of an
interrupted load.
- 6:54 AM Changeset in webkit [106466] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r106460.
http://trac.webkit.org/changeset/106460
https://bugs.webkit.org/show_bug.cgi?id=77552
It break unit tests if WEBKIT_TESTFONTS isn't defined.
(Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
- Scripts/webkitpy/layout_tests/port/qt.py:
- 5:53 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 5:50 AM Changeset in webkit [106465] by
-
- 6 edits2 adds in trunk
Content element should be able to be dynamically added/removed/replaced in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=76611
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-01
Reviewed by Hajime Morita
Source/WebCore:
When a content element is added/removed/replaced in a shadow tree, we have to recreate
the shadow tree to recalculate inclusions of content elements. Currently we didn't recalculate it
when content element is removed. (When added, it is recalculated.)
This patch enables us to recalcurate the shadow tree when content element is removed.
Test: fast/dom/shadow/content-element-move.html
- dom/Element.cpp:
(WebCore::Element::attach):
If a shadow root exists, attaches shadow tree before attaching child elements.
- dom/ShadowRoot.cpp: Added a flag to recalculate shadow tree.
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::recalcShadowTreeStyle):
Recalculates light children and shadow tree.
(WebCore::ShadowRoot::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRoot::reattachHostChildrenAndShadow):
Detaches shadow tree and host light children, and attaches them again.
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRoot::needsReattachHostChildrenAndShadow):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
Does not need to detach included elements, because they are not attached in ContainerNode anymore.
(WebCore::HTMLContentElement::detach):
When a content element detached, reattaches a shadow tree.
LayoutTests:
Test cases for appending/removing/replacing content element in a shadow tree.
- fast/dom/shadow/content-element-move-expected.txt: Added.
- fast/dom/shadow/content-element-move.html: Added.
- 5:31 AM Changeset in webkit [106464] by
-
- 3 edits3 adds in trunk
getIntersectionList causes transforms to be recalculated in SVG
https://bugs.webkit.org/show_bug.cgi?id=77179
Reviewed by Nikolas Zimmermann.
Introduce a local variable to store the element's local-to-parent
transformation matrix in, removing the need for the const_cast and
stopping us from modifying any matrices elsewhere.
Source/WebCore:
Test: svg/custom/intersection-list-transforms.svg
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::getElementCTM):
LayoutTests:
- svg/custom/intersection-list-transforms-expected.png: Added.
- svg/custom/intersection-list-transforms-expected.txt: Added.
- svg/custom/intersection-list-transforms.svg: Added.
- 4:02 AM Changeset in webkit [106463] by
-
- 9 edits6 adds in trunk
Web Inspector: [InspectorIndexedDB] Add tests for database names and database structure requests.
https://bugs.webkit.org/show_bug.cgi?id=77439
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: http/tests/inspector/indexeddb/database-names.html
http/tests/inspector/indexeddb/database-structure.html
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype.refreshDatabase):
LayoutTests:
- http/tests/inspector/indexeddb/database-names-expected.txt: Added.
- http/tests/inspector/indexeddb/database-names.html: Added.
- http/tests/inspector/indexeddb/database-structure-expected.txt: Added.
- http/tests/inspector/indexeddb/database-structure.html: Added.
- http/tests/inspector/indexeddb/indexeddb-test.js: Added.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 3:37 AM Changeset in webkit [106462] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Scripts navigator becomes empty after "show folders" settings change.
https://bugs.webkit.org/show_bug.cgi?id=77441
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._reset):
- inspector/front-end/utilities.js:
- 2:55 AM Changeset in webkit [106461] by
-
- 2 edits in trunk/Tools
[Qt] Automatic clean build feature always do clean build with --no-webkit2
https://bugs.webkit.org/show_bug.cgi?id=74519
Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-02-01
Reviewed by Tor Arne Vestbø.
Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
- qmake/mkspecs/features/features.prf:
- 2:37 AM Changeset in webkit [106460] by
-
- 2 edits in trunk/Tools
[Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
https://bugs.webkit.org/show_bug.cgi?id=77466
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-01
Reviewed by Kenneth Rohde Christiansen.
Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
is set or if we should raise an error.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.setup_environ_for_server):
- 2:31 AM Changeset in webkit [106459] by
-
- 6 edits in trunk
Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975
Reviewed by Simon Fraser.
Source/WebCore:
This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
- compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
- compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
- platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.
- 2:25 AM Changeset in webkit [106458] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r106445
- platform/gtk/security/block-test-expected.txt:
- platform/gtk/security/block-test-no-port-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
- 2:20 AM Changeset in webkit [106457] by
-
- 3 edits in trunk/LayoutTests
[WK2] Unreviewed gardening after r106426.
Skip new failing tests because of missing layoutTestController.dumpResourceResponseMIMETypes().
https://bugs.webkit.org/show_bug.cgi?id=42543
- platform/qt-wk2/Skipped: Remove a test also skipped in wk2/Skipped.
- platform/wk2/Skipped:
- 2:08 AM Changeset in webkit [106456] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, another GTK build fix after r106446.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
Restore webKitWebSrcGetProtocols as it was before r106446.
- 2:05 AM Changeset in webkit [106455] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectaion change.
plugins/createScriptableObject-before-start.html is flaky on LINUX.
- platform/chromium/test_expectations.txt:
- 2:00 AM Changeset in webkit [106454] by
-
- 15 edits3 deletes in trunk
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994
Unreviewed, rolling out r106407.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(JSC):
(Interpreter):
- jsc.cpp:
(GlobalObject::finishCreation):
- parser/Parser.h:
(JSC::::parse):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
- runtime/Error.h:
(JSC):
LayoutTests:
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js: Removed.
- fast/js/stack-trace-expected.txt: Removed.
- fast/js/stack-trace.html: Removed.
- platform/chromium/test_expectations.txt:
- 1:54 AM Changeset in webkit [106453] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectaion change.
media/controls-drag-timebar.html passes or times out on WIN and LINUX.
- platform/chromium/test_expectations.txt:
- 1:50 AM Changeset in webkit [106452] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, GTK build fix after r106446.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- 1:49 AM Changeset in webkit [106451] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r106432.
http://trac.webkit.org/changeset/106432
https://bugs.webkit.org/show_bug.cgi?id=77529
it breaks tests (Requested by shinyak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-01
Source/WebCore:
- dom/Element.cpp:
(WebCore::Element::attach):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
- dom/ShadowRoot.h:
(ShadowRoot):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
LayoutTests:
- fast/dom/shadow/content-element-move-expected.txt: Removed.
- fast/dom/shadow/content-element-move.html: Removed.
- 1:47 AM Changeset in webkit [106450] by
-
- 2 edits in trunk/PerformanceTests
Fix after r106386. The empty anchor element was generating an erroneous whitespace.
- Bindings/event-target-wrapper.html:
- 1:44 AM Changeset in webkit [106449] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary [OldStyleObjC] from ShadowRoot.idl.
https://bugs.webkit.org/show_bug.cgi?id=77516
Reviewed by Kentaro Hara.
No new tests. No change in behavior.
- dom/ShadowRoot.idl:
- 1:39 AM Changeset in webkit [106448] by
-
- 2 edits in trunk/PerformanceTests
Another fix after r106379.
- Parser/html5-full-render.html:
- 1:38 AM Changeset in webkit [106447] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectaion change.
svg/text/text-align-04-b.svg is flaky on WIN and LINUX.
- platform/chromium/test_expectations.txt:
- 1:36 AM Changeset in webkit [106446] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] 0.11 webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=77086
Port the webkitwebsrc element to GStreamer 0.11 APIs.
Reviewed by Gustavo Noronha Silva.
No new tests, existing http media layout tests should cover this.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
- 1:29 AM Changeset in webkit [106445] by
-
- 11 edits1 add in trunk
Source/WebKit/gtk: Patch by Philippe Normand <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.
[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543
New signals:
WebKitWebFrame::resource-request-starting
WebKitWebFrame::resource-response-received
WebKitWebFrame::resource-load-finished
WebKitWebFrame::resource-content-length-received
WebKitWebFrame::resource-load-failed
WebKitWebResource::response-received
WebKitWebResource::load-failed
WebKitWebResource::load-finished
WebKitWebResource::content-length-received
WebKitWebView::resource-response-received
WebKitWebView::resource-load-finished
WebKitWebView::resource-content-length-received
WebKitWebView::resource-load-failed
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchWillSendRequest):
(WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::FrameLoaderClient::dispatchDidFinishLoading):
(WebKit::FrameLoaderClient::dispatchDidFailLoading):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
- webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init):
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- webkitmarshal.list:
Tools: Patch by Philippe Normand <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com> on 2012-02-01
Reviewed by Martin Robinson.
[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543
Support for the new loader signals in DRT.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(urlPath):
(willSendRequestCallback):
(urlSuitableForTestResult):
(descriptionSuitableForTestResult):
(didReceiveResponse):
(didFinishLoading):
(didFailLoadingWithError):
(createWebView):
LayoutTests: Reviewed by Martin Robinson.
[GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543
Unskip tests now passing.
- platform/gtk/Skipped:
- platform/gtk/fast/loader/file-protocol-fragment-expected.txt: Added.
- platform/gtk/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- 1:22 AM Changeset in webkit [106444] by
-
- 7 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r106373.
- fast/forms/implicit-submission-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
- 1:19 AM Changeset in webkit [106443] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectation change.
https://bugs.webkit.org/show_bug.cgi?id=77521
fast/repaint/search-field-cancel.html is failing on LINUX.
- platform/chromium/test_expectations.txt:
- 1:15 AM Changeset in webkit [106442] by
-
- 4 edits in trunk/Tools
run-perf-tests should restart DRT for each test
https://bugs.webkit.org/show_bug.cgi?id=77506
Reviewed by Adam Barth.
Always restart DRT when running performance tests in order to minimize the dependency between tests.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.stop):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.init):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
- 1:13 AM Changeset in webkit [106441] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectation change.
fast/repaint/textarea-set-disabled.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=77521
- platform/chromium/test_expectations.txt:
- 1:06 AM Changeset in webkit [106440] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectation change.
Layout Test fast/forms/textfield-overflow.html is failing on WIN and LINUX.
- platform/chromium/test_expectations.txt:
- 1:01 AM Changeset in webkit [106439] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disable WebFrameTest.FindInPage
https://bugs.webkit.org/show_bug.cgi?id=77186
Disable it because PlatformContextSkiaTest.trackOpaqueOvalTest has
been failing since FindInPage test was committed.
- tests/WebFrameTest.cpp:
(WebKit::TEST_F):
- 12:52 AM Changeset in webkit [106438] by
-
- 17 edits2 adds in trunk
Speech Input: Report speech element rect relative to window rather than frame
https://bugs.webkit.org/show_bug.cgi?id=76443
Reviewed by Darin Fisher.
Source/WebCore:
When requesting speech input, report the speech element rect relative
to the window rather than the frame. The embedder will typically use
this position to show a bubble indicating that speech recognition is
in progress.
Test: fast/speech/bubble-position.html
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
Tools:
Update LayoutTestController to allow for retrieving the speech
element's position used in a request.
In Chromium this is handled by the MockWebSpeechInputController;
adding stubs for the other implementations.
- DumpRenderTree/LayoutTestController.cpp:
(setMockSpeechInputDumpRectCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(MockWebSpeechInputController::setDumpRect):
(MockWebSpeechInputController::clearResults):
(MockWebSpeechInputController::startRecognition):
(MockWebSpeechInputController::MockWebSpeechInputController):
(makeRectResult):
(MockWebSpeechInputController::speechTaskFired):
- DumpRenderTree/chromium/MockWebSpeechInputController.h:
(MockWebSpeechInputController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setMockSpeechInputDumpRect):
LayoutTests:
Add layout test to check that the element position used when
requesting speech input is relative to the window, not the frame.
- fast/speech/bubble-position-expected.txt: Added.
- fast/speech/bubble-position.html: Added.
- 12:09 AM Changeset in webkit [106437] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r106373 and r106361.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
