Timeline
Feb 11, 2012:
- 11:59 PM Changeset in webkit [107503] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT calls fprintf() instead of dataLog in terminateSpeculativeExecution()
https://bugs.webkit.org/show_bug.cgi?id=78431
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- 10:32 PM Changeset in webkit [107502] by
-
- 5 edits14 adds in trunk
Add back WTFURL to WebKit
https://bugs.webkit.org/show_bug.cgi?id=77291
Reviewed by Adam Barth.
Source/JavaScriptCore:
WTFURL was removed from WebKit in r86787.
This patch adds the code back to WTF with the following changes:
-Guard the feature with USE(WTFURL).
-Change the typename CHAR to CharacterType to follow recent WebKit conventions.
-Fix some coding style to make check-webkit-style happy.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Platform.h:
- wtf/url/api/ParsedURL.cpp: Added.
(WTF):
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):
- wtf/url/api/ParsedURL.h: Added.
(WTF):
(ParsedURL):
(WTF::ParsedURL::spec):
- wtf/url/api/URLString.h: Added.
(WTF):
(URLString):
(WTF::URLString::URLString):
(WTF::URLString::string):
- wtf/url/src/RawURLBuffer.h: Added.
(WTF):
(RawURLBuffer):
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):
- wtf/url/src/URLBuffer.h: Added.
(WTF):
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
- wtf/url/src/URLCharacterTypes.cpp: Added.
(WTF):
():
- wtf/url/src/URLCharacterTypes.h: Added.
(WTF):
(URLCharacterTypes):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
():
(WTF::URLCharacterTypes::isCharOfType):
- wtf/url/src/URLComponent.h: Added.
(WTF):
(URLComponent):
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
- wtf/url/src/URLEscape.cpp: Added.
(WTF):
():
- wtf/url/src/URLEscape.h: Added.
(WTF):
(WTF::appendURLEscapedCharacter):
- wtf/url/src/URLParser.h: Added.
(WTF):
(URLParser):
():
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):
- wtf/url/src/URLQueryCanonicalizer.h: Added.
(WTF):
(URLQueryCanonicalizer):
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::isRaw8Bit):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):
- wtf/url/src/URLSegments.cpp: Added.
(WTF):
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):
- wtf/url/src/URLSegments.h: Added.
(WTF):
(URLSegments):
():
(WTF::URLSegments::URLSegments):
Tools:
Add a flag to build-webkit to easily build WebKit with WTFURL.
- Scripts/build-webkit:
- 7:54 PM Changeset in webkit [107501] by
-
- 3 edits in trunk/Source/JavaScriptCore
Old JIT put_by_id profiling counts every put_by_id_transition as taking slow path
https://bugs.webkit.org/show_bug.cgi?id=78430
<rdar://problem/10849469> <rdar://problem/10849684>
Reviewed by Gavin Barraclough.
The old JIT's put_by_id transition caching involves repatching the slow call to
a generated stub. That means that the call is counted as "slow case". So, this
patch inserts code to decrement the slow case count if the stub succeeds.
Looks like a ~1% speed-up on V8.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 7:38 PM Changeset in webkit [107500] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for Qt.
- wtf/DataLog.h:
- 7:21 PM Changeset in webkit [107499] by
-
- 50 edits3 adds in trunk/Source
It should be possible to send all JSC debug logging to a file
https://bugs.webkit.org/show_bug.cgi?id=78418
Reviewed by Sam Weinig.
Introduced wtf/DataLog, which defines WTF::dataFile, WTF::dataLog,
and WTF::dataLogV. Changed all debugging- and profiling-related printfs
to use WTF::dataLog() or one of its friends. By default, debug logging
goes to stderr, unless you change the setting in wtf/DataLog.cpp.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::vprintfStdoutInstr):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/Opcode.cpp:
(JSC::OpcodeStats::~OpcodeStats):
- bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::dump):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::dump):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- heap/Heap.cpp:
(JSC::Heap::destroy):
- heap/MarkedBlock.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::dumpRegExpTrace):
- runtime/RegExp.cpp:
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/SamplingCounter.cpp:
(JSC::AbstractSamplingCounter::dump):
- runtime/SamplingCounter.h:
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::report):
- tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
- wtf/CMakeLists.txt:
- wtf/DataLog.cpp: Added.
(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLog):
- wtf/DataLog.h: Added.
(WTF):
- wtf/HashTable.cpp:
(WTF::HashTableStats::~HashTableStats):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
- wtf/text/WTFString.cpp:
(String::show):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::dumpDisjunction):
Source/WebCore:
No new tests because behavior is unchanged.
- ForwardingHeaders/wtf/DataLog.h: Added.
Source/WTF:
- WTF.pro:
- 6:47 PM Changeset in webkit [107498] by
-
- 29 edits in trunk
Move special proto property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409
Reviewed by Oliver Hunt.
Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- No need to prohibit functions named proto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Add proto accessor to Object.prototype.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
- Definition of the proto accessor functions.
- runtime/JSGlobalObjectFunctions.h:
- Declaration of the proto accessor functions.
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.
(JSC::JSObject::putDirectAccessor):
- Track on the structure whether an object contains accessors other than one for proto.
(JSC::JSObject::defineOwnProperty):
- No need to prohibit definition of own properties named proto.
- runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
- Remove the special handling for proto.
(JSC::JSValue::get):
- Remove the special handling for proto.
- runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
- Remove the special handling for proto.
- runtime/JSValue.h:
(JSValue):
- Made synthesizePrototype public (this may be needed by the proto getter).
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
- Perform the security check & call prototype() directly.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
- runtime/Structure.h:
(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):
- expose allowsAccessFrom check to JSC.
- bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
- expose allowsAccessFrom check to JSC.
LayoutTests:
- fast/js/Object-getOwnPropertyNames-expected.txt:
- fast/js/cyclic-prototypes-expected.txt:
- fast/js/parser-syntax-check-expected.txt:
- fast/js/preventExtensions-expected.txt:
- fast/js/prototypes-expected.txt:
- Update results
- fast/js/script-tests/Object-getOwnPropertyNames.js:
- proto is now a property of Object Prototype.
- fast/js/script-tests/cyclic-prototypes.js:
- setting an object's prototype to null removes proto setter, future usage won't set prototype.
- fast/js/script-tests/parser-syntax-check.js:
- Allow functions named proto
- fast/js/script-tests/preventExtensions.js:
- Setting proto should not throw.
- fast/js/script-tests/prototypes.js:
- Objects may contained own properties named proto, add new test cases.
- 6:33 PM Changeset in webkit [107497] by
-
- 6 edits1 delete in trunk/Source/WebCore
Get rid of WebCore::URLString
https://bugs.webkit.org/show_bug.cgi?id=78429
Reviewed by Adam Barth.
URLString is unused, remove the class.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp:
- platform/KURL.h:
(KURL):
- platform/URLString.h: Removed.
- 6:26 PM Changeset in webkit [107496] by
-
- 3 edits3 adds in trunk
DFG CFA assumes that a WeakJSConstant's structure is known
https://bugs.webkit.org/show_bug.cgi?id=78428
<rdar://problem/10849492> <rdar://problem/10849621>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
LayoutTests:
Rubber stamped by Gavin Barraclough.
- fast/js/dfg-put-by-id-prototype-check-expected.txt: Added.
- fast/js/dfg-put-by-id-prototype-check.html: Added.
- fast/js/script-tests/dfg-put-by-id-prototype-check.js: Added.
(foo):
(Foo):
- 5:27 PM Changeset in webkit [107495] by
-
- 2 edits in trunk/Source/JavaScriptCore
Qt debug build fix
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Platforms that don't use clang will allocate
JSFinalObjects in the destuctor subspace, so we should remove this assert so it
doesn't cause crashes.
- 5:24 PM Changeset in webkit [107494] by
-
- 2 edits in trunk/Source/JavaScriptCore
Old 32_64 JIT should assert that its use of map() is consistent with the DFG
OSR exit's expectations
https://bugs.webkit.org/show_bug.cgi?id=78419
<rdar://problem/10817121>
Reviewed by Oliver Hunt.
- jit/JITInlineMethods.h:
(JSC::JIT::map):
- 5:18 PM Changeset in webkit [107493] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reduce the reentrancy limit of the interpreter for the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=78400
Reviewed by Gavin Barraclough.
- interpreter/Interpreter.h: Lowered the maximum reentrancy limit for large thread stacks.
(JSC):
- 4:08 PM Changeset in webkit [107492] by
-
- 3 edits3 adds in trunk
[DFG] Misuse of WeakJSConstants in silentFillGPR code.
https://bugs.webkit.org/show_bug.cgi?id=78423
<rdar://problem/10849353> <rdar://problem/10804043>
Source/JavaScriptCore:
Reviewed by Sam Weinig.
The code was using Node::isConstant(), when it was supposed to use Node::hasConstant().
This patch is a surgical fix; the bigger problem is: why do we have isConstant() and
hasConstant() when hasConstant() is correct and isConstant() is almost always wrong?
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
LayoutTests:
Rubber stamped by Sam Weinig.
- fast/js/dfg-weak-js-constant-silent-fill.html: Added.
- fast/js/dfg-weak-js-constant-silent-fill-expected.txt: Added.
- fast/js/script-tests/dfg-weak-js-constant-silent-fill.js: Added.
- 3:58 PM Changeset in webkit [107491] by
-
- 11 edits in trunk/Source/WebCore
Fix the windows build.
Since Windows uses an all-in-one file to compile, the isRespectedPresentationAttribute()
functions all need unique names.
- html/HTMLBodyElement.cpp:
- html/HTMLHRElement.cpp:
- html/HTMLIFrameElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMarqueeElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLTableCellElement.cpp:
- html/HTMLTablePartElement.cpp:
- mathml/MathMLElement.cpp:
- 3:36 PM Changeset in webkit [107490] by
-
- 5 edits in trunk/Source/WebCore
Overlay scrollbars don't appear when scrolling on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78427
Reviewed by Sam Weinig.
Add a ScrollAnimator::notifyContentAreaScrolled and call it from ScrollAnimator::notifyContentAreaScrolled.
It is then overridden in ScrollAnimatorMac to tickle AppKit so that overlay scrollbars will be shown.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):
(ScrollAnimator):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore):
- 3:10 PM Changeset in webkit [107489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Prepare JavaScriptCore to build with libc++
<rdar://problem/10426673>
https://bugs.webkit.org/show_bug.cgi?id=78424
Reviewed by Anders Carlsson.
- wtf/NullPtr.cpp:
- wtf/NullPtr.h:
libc++ provides std::nullptr emulation, so we don't have to.
- 3:02 PM Changeset in webkit [107488] by
-
- 4 edits in trunk/Source/WebCore
Implement more ScrollElasticityControllerClient member functions
https://bugs.webkit.org/show_bug.cgi?id=78425
<rdar://problem/10710727>
Reviewed by Sam Weinig.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeNode::verticalScrollElasticity):
(WebCore::ScrollingTreeNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeNode::hasEnabledVerticalScrollbar):
Add new getters.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Implement ScrollElasticityControllerClient member functions.
- 1:44 PM Changeset in webkit [107487] by
-
- 2 edits in trunk/Source/WebCore
Add size assert for Length
https://bugs.webkit.org/show_bug.cgi?id=78420
Rubber-stamped by Andreas Kling.
Length type is memory critical and must not grow.
- platform/Length.cpp:
(SameSizeAsLength):
(WebCore):
- 1:37 PM Changeset in webkit [107486] by
-
- 3 edits in trunk/Source/WebCore
Pass wheel events to a scroll elasticity controller on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78421
Reviewed by Sam Weinig.
Add a ScrollElasticityController to ScrollingTreeNodeMac and pass wheel events to it.
Fix ScrollingTreeNodeMac::scrollBy to clamp by the minimum and maximum scroll positions.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::ScrollingTreeNodeMac):
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollBy):
- 1:07 PM Changeset in webkit [107485] by
-
- 13 edits3 adds in trunk/Source/JavaScriptCore
DFG should have polymorphic put_by_id caching
https://bugs.webkit.org/show_bug.cgi?id=78062
<rdar://problem/10326439> <rdar://problem/10824839>
Reviewed by Oliver Hunt.
Implemented polymorphic put_by_id caching in the DFG, and added much of the
machinery that would be needed to implement it in the old JIT as well.
I decided against using the old PolymorphicAccessStructureList mechanism as
this didn't quite fit with put_by_id. In particular, I wanted the ability to
have one list that captured all relevant cases (including proto put_by_id
if we ever decided to do it). And I wanted the code to have better
encapsulation. And I didn't want to get confused by the fact that the
original (non-list) put_by_id cache may itself consist of a stub routine.
This code is still sub-optimal (for example adding a replace to a list whose
previous elements are all transitions should just repatch the original code,
but here it will generate a stub) but it already generates a >20% speed-up
on V8-splay, leading to a 2% win overall in splay. Neutral elsewhere.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/PolymorphicPutByIdList.cpp: Added.
(JSC):
(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::from):
(JSC::PolymorphicPutByIdList::~PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::isFull):
(JSC::PolymorphicPutByIdList::isAlmostFull):
(JSC::PolymorphicPutByIdList::addAccess):
(JSC::PolymorphicPutByIdList::visitWeak):
- bytecode/PolymorphicPutByIdList.h: Added.
(JSC):
(PutByIdAccess):
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::isSet):
(JSC::PutByIdAccess::operator!):
(JSC::PutByIdAccess::type):
(JSC::PutByIdAccess::isTransition):
(JSC::PutByIdAccess::isReplace):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
(JSC::PolymorphicPutByIdList::isEmpty):
(JSC::PolymorphicPutByIdList::size):
(JSC::PolymorphicPutByIdList::at):
(JSC::PolymorphicPutByIdList::operator[]):
(JSC::PolymorphicPutByIdList::kind):
- bytecode/PutKind.h: Added.
(JSC):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdList):
(StructureStubInfo):
(JSC::StructureStubInfo::reset):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
(DFG):
- dfg/DFGRepatch.cpp:
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(DFG):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgBuildPutByIdList):
(JSC::DFG::dfgResetPutByID):
- dfg/DFGRepatch.h:
(DFG):
- runtime/WriteBarrier.h:
(WriteBarrierBase):
(JSC::WriteBarrierBase::copyFrom):
- 11:29 AM Changeset in webkit [107484] by
-
- 67 edits in trunk/Source/WebCore
Attribute styles should be created lazily.
<http://webkit.org/b/78381>
Reviewed by Antti Koivisto.
TL;DR summary: Lazily construct the StyledElement::attributeStyle() instead of
moving properties in/out of it in parseAttribute(). This allows us to enable
the matched declaration cache for elements with presentation attributes.
The matched declaration cache has been disabled for elements with presentation
attributes because attributeStyle() was mutable, and (simply put) the cache maps
a set of StylePropertySet pointers to a resulting RenderStyle. This requires
that the StylePropertySets are immutable.
To make them immutable, we now construct the attribute style lazily by adding
a flag (to Node) that gets set in parseAttribute() when a presentation attribute
respected by the element changes. A subsequent call to attributeStyle() checks
the flag and rebuilds the style by looping over the attributes and calling the
new virtual StyledElement::collectStyleForAttribute() on each one. Any dangling
references to the previous attribute style will be garbage collected by the
cache in CSSStyleSelector::sweepMatchedDeclarationCache().
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
Enable matched declaration cache for elements with attribute style.
- dom/Node.h:
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
Add a Node flag to signify that a presentation attribute has changed and
the attribute style needs to be rebuilt.
- dom/ElementAttributeData.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::setAttributeStyle):
Added a setter for the attribute style, called by updateAttributeStyle().
- dom/StyledElement.cpp:
(WebCore::StyledElement::addHTMLLengthToStyle):
(WebCore::StyledElement::addHTMLColorToStyle):
Moved and renamed two of the old addCSS* helpers from StyledElement.
(WebCore::StyledElement::updateAttributeStyle):
Called by attributeStyle() in case the "attribute style dirty" flag is
set. Rebuilds the attribute style from scratch by looping over the
attribute map and calling collectStyleForAttribute() on each attribute.
- dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::setNeedsAttributeStyleUpdate):
Helper, sets the attribute style dirty flag and marks the element for
full style recalc. This is what parseAttribute() calls in subclasses
when they encounter a presentation attribute.
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
(WebCore::HTMLBRElement::parseAttribute):
- html/HTMLBRElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):
- html/HTMLBodyElement.h:
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForAttribute):
(WebCore::HTMLDivElement::parseAttribute):
- html/HTMLDivElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
(WebCore::HTMLFontElement::parseAttribute):
- html/HTMLFontElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):
(WebCore::HTMLHRElement::parseAttribute):
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
- html/HTMLInputElement.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):
- html/HTMLLIElement.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):
- html/HTMLMarqueeElement.h:
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):
- html/HTMLOListElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):
- html/HTMLObjectElement.h:
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForAttribute):
(WebCore::HTMLParagraphElement::parseAttribute):
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
(WebCore::HTMLPlugInElement::parseAttribute):
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForAttribute):
(WebCore::HTMLPreElement::parseAttribute):
- html/HTMLPreElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):
- html/HTMLTableColElement.h:
- html/HTMLTableElement.cpp:
(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
(WebCore::HTMLTablePartElement::parseAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):
- html/HTMLTextAreaElement.h:
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForAttribute):
(WebCore::HTMLUListElement::parseAttribute):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):
- html/HTMLVideoElement.h:
- mathml/MathMLElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):
(WebCore::MathMLElement::parseAttribute):
- mathml/MathMLElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):
- svg/SVGImageElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):
- svg/SVGStyledElement.h:
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
- svg/SVGTextContentElement.h:
Split handling of presentation attributes between parseAttribute() and
collectStyleForAttribute() as appropriate. Some minor refactorings here and
there (mostly in HTMLTableElement) to avoid excessive code duplication.
Also sprinkled FIXMEs about inefficiencies we should clean up.
- 10:51 AM Changeset in webkit [107483] by
-
- 6 edits2 adds in trunk
HTML 5: Support click() method on HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=27880
Patch by Arko Saha <arko@motorola.com> on 2012-02-11
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: fast/dom/click-method-on-html-element.html
- bindings/objc/PublicDOMInterfaces.h: Added click() method in DOMHTMLElement
with availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1.
- html/HTMLButtonElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
- html/HTMLElement.idl: Added click() IDL method.
- html/HTMLInputElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
LayoutTests:
- fast/dom/click-method-on-html-element-expected.txt: Added.
- fast/dom/click-method-on-html-element.html: Added.
- 10:36 AM Changeset in webkit [107482] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
https://bugs.webkit.org/show_bug.cgi?id=78244
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-11
Reviewed by Eric Seidel.
Specifically advertise support for audio/webm when we support the vorbis
audio codec. This is necessary because gstreamer doesn't advertise it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Add an override for audio/webm.
- 10:18 AM Changeset in webkit [107481] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
- 9:46 AM Changeset in webkit [107480] by
-
- 12 edits2 adds in trunk/Source/WebCore
[chromium] Enable CSS filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=77266
Reviewed by James Robinson.
Will be covered by existing tests in css3/filters (when enabled).
- WebCore.gypi:
Add CCRenderSurfaceFilters.* to the Chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setFilters):
- platform/graphics/chromium/GraphicsLayerChromium.h:
Override setFilters() virtual from GraphicsLayer.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Implement setFilters() to cache the filters here...
(WebCore::LayerChromium::pushPropertiesTo):
... and push them to the CCLayerImpl at commit time.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::filters):
Implement accessor.
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
Implement stub version of setFilters(), to satisfy the templates.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Implement setter to receive filters at commit time.
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::filters):
Implement member var and accessor for filters.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
Add another clause here to force creation of a RenderSurface when
filters are present, and to forward them from the layer to the
RenderSurface.
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
Check for filters at draw time, apply them, and forward the result
through the drawing traversal.
(WebCore::CCRenderSurface::drawSurface):
If filter bitmap is present, bind it instead of the normal
RenderSurface texture.
(WebCore::CCRenderSurface::applyFilters):
Apply filters to the render surface texture, and return the result.
This function is a no-op for the threaded compositor, due to use
of the SharedGraphicsContext3D.
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setFilters):
(WebCore::CCRenderSurface::filters):
(CCRenderSurface):
Filters getters and setters.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Added.
(WebCore::CCRenderSurfaceFilters::apply):
External interface for this (static) class. All internal
implementation and helper functions are in the unnamed namespace.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Added.
- 8:17 AM Changeset in webkit [107479] by
-
- 3 edits2 adds in trunk
Node.isEqualNode() compares attributes twice.
<http://webkit.org/b/78414>
Reviewed by Anders Carlsson.
Source/WebCore:
A single pass across the attribute maps should be enough for anyone.
Added a test verifying correct behavior of Node.isEqualNode() when comparing
two elements, one of which has had attributes that were all removed,
resulting in an empty but non-null NamedNodeMap hanging off of the element.
Note that this change is not fixing a regression, I'm just adding the test
since I came close to introducing a bug here.
Test: fast/dom/isEqualNode-after-removeAttribute.html
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
LayoutTests:
- fast/dom/isEqualNode-after-removeAttribute-expected.txt: Added.
- fast/dom/isEqualNode-after-removeAttribute.html: Added.
- 6:54 AM Changeset in webkit [107478] by
-
- 6 edits in trunk/Source/WebCore
HTMLTablePartElement: Add helper method to find parent table.
<http://webkit.org/b/78413>
Reviewed by Anders Carlsson.
Add HTMLTablePartElement::findParentTable() and use that in subclasses instead
of duplicating the code.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
(WebCore):
- html/HTMLTablePartElement.h:
(WebCore):
(HTMLTablePartElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- 6:50 AM Changeset in webkit [107477] by
-
- 22 edits in trunk/Source/WebCore
Use Element's hasName/hasID flags to avoid unnecessary work when looking up name/id attributes.
<http://webkit.org/b/77845>
Reviewed by Anders Carlsson.
Have Element::getIdAttribute() check the hasID() flag before looking up the attribute.
Add an Element::getNameAttribute() to do the same thing with hasName().
Update call sites to make use of these helpers whenever possible.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
- dom/Element.h:
(Element):
(WebCore::Element::getIdAttribute):
(WebCore):
(WebCore::Element::getNameAttribute):
- dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches):
- dom/StaticHashSetNodeList.cpp:
(WebCore::StaticHashSetNodeList::itemWithName):
- dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::name):
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::name):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::name):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::formControlName):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- page/Frame.cpp:
(WebCore::Frame::matchLabelsAgainstElement):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
- 12:56 AM Changeset in webkit [107476] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt/Skipped: Skip tests because ENABLE(MUTATION_OBSERVERS) is disabled.
- 12:33 AM Changeset in webkit [107475] by
-
- 14 edits3 deletes in trunk/Source
Unreviewed, rolling out r107435.
http://trac.webkit.org/changeset/107435
https://bugs.webkit.org/show_bug.cgi?id=78410
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-11
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
- platform/Pasteboard.h:
(WebCore):
(Pasteboard):
- platform/PasteboardStrategy.h: Removed.
- platform/PlatformPasteboard.h: Removed.
- platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore):
(WebCore::selectionPasteboardTypes):
(WebCore::writableTypesForURL):
(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeSelection):
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragment):
- platform/mac/PlatformPasteboardMac.mm: Removed.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::addVisitedLink):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Feb 10, 2012:
- 11:52 PM Changeset in webkit [107474] by
-
- 3 edits in trunk/Source/WebCore
Move CSSOM wrapper pointer out of StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=78406
Reviewed by Andreas Kling.
Most StylePropertySet instances never have CSSOM wrappers so having a pointer to one in
each and and every object makes no sense.
Move the PropertySetCSSStyleDeclaration instances to a global HashMap. This shrinks
StylePropertySet by a pointer.
Added COMPILE_ASSERT for StylePropertySet size.
- css/StylePropertySet.cpp:
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
- 8:28 PM Changeset in webkit [107473] by
-
- 9 edits in trunk/Source/WebCore
MathML internals - use createXXX() function naming, ASSERT()s
https://bugs.webkit.org/show_bug.cgi?id=78384
Patch by David Barton <Dave Barton> on 2012-02-10
Reviewed by Eric Seidel.
Standard RefPtr function naming uses "createXXX" instead of "makeXXX".
I also added a couple of ASSERT()s.
No new tests.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createBlockStyle):
- rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::RenderMathMLSubSup):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
(WebCore::RenderMathMLUnderOver::addChild):
- 8:00 PM Changeset in webkit [107472] by
-
- 2 edits in trunk/Source/WebCore
Non-threaded scrolling build fix.
- page/FrameView.cpp:
(WebCore::FrameView::requestScrollPositionUpdate):
- 7:58 PM Changeset in webkit [107471] by
-
- 2 edits in trunk/Source/WebKit
BlackBerry Port - Input focus is suppressed during XHR loads
https://bugs.webkit.org/show_bug.cgi?id=78368
Allow JS to trigger the VKB and input focus when XHR scripting
is active.
This switching the loaded state to checking the webpages loaded state
which is only updated after initial load. When additional loading
events happen for XHR, it remains false and focus events function.
Also add detailed FocusLog's to shouldAcceptInputFocus.
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.
- blackberry/WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
- 7:10 PM Changeset in webkit [107470] by
-
- 6 edits in trunk
Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE
https://bugs.webkit.org/show_bug.cgi?id=71293
Patch by Edward O'Connor <Theresa O'Connor> on 2012-02-10
Reviewed by Chris Marrin.
Source/WebCore:
Tests: animations/animation-css-rule-types.html
- css/CSSRule.h: Change WEBKIT_KEYFRAMES_RULE to 7 and
WEBKIT_KEYFRAME_RULE to 8.
- css/CSSRule.idl: Ditto.
LayoutTests:
- animations/animation-css-rule-types-expected.txt:
- animations/script-tests/animation-css-rule-types.js: Update
expected WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_RULE values.
- 6:53 PM Changeset in webkit [107469] by
-
- 17 edits8 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening.
svg/text/non-bmp-positioning-lists.svg is missing glyphs. The other
tests are additional fallout from r107417.
- platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
- platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
- platform/chromium-mac-leopard/svg/carto.net/window-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac-leopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/chromium-mac-leopard/svg/custom/mask-invalidation-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-repaint-including-stroke-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-clipped-hit-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
- platform/chromium-mac-leopard/svg/filters/filter-refresh-expected.txt:
- platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/filters/filter-refresh-expected.txt:
- platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium/test_expectations.txt:
- 6:35 PM Changeset in webkit [107468] by
-
- 2 edits in trunk/Source/WebCore
AtomicMarkupTokenBase::initializeAttributes should not create a StringImpl if it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=78394
Reviewed by Adam Barth.
On the very next line is passes value to Attribute::create which takes
an AtomicString, so this code was just allocating a StringImpl (every time)
only to (much of the time) just release that StringImpl on the next line
when it got the AtomicString instead.
I discovered this while looking at DOM/Events.html, but it's unclear
if this fix actually makes that benchmark faster.
- xml/parser/MarkupTokenBase.h:
(WebCore::::initializeAttributes):
- 6:33 PM Changeset in webkit [107467] by
-
- 12 edits in trunk/Source/WebCore
Always update the scroll position through the scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=78403
Reviewed by Sam Weinig.
To get correct behavior, we always want to update the scrolling layer position
on the scrolling thread. Do this by allowing the scrolling coordinator to intercept
scroll position update requests and send them to the scrolling tree.
- page/FrameView.cpp:
(WebCore::FrameView::requestScrollPositionUpdate):
Let the scrolling coordinator have a go at updating the scroll position for this frame view.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
If it's a frame view we're coordinating scrolling for, tell the scrolling tree to update
the scroll position.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::setMainFrameScrollPosition):
Call through to the scrolling tree node.
- page/scrolling/ScrollingTreeNode.h:
Add a new pure virtual setScrollPosition member function.
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Move most of the code from scrollBy here.
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
Rename this member function from setScrollPosition to avoid conflicts.
(WebCore::ScrollingTreeNodeMac::scrollBy):
Just call setScsrollPosition.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call requestScrollPositionUpdate, which allows subclasses of scrollable area to intercept
the scroll operation and call it asynchronously.
- 6:08 PM LayoutUnit edited by
- Removed duplicate borders entry. (diff)
- 6:03 PM Changeset in webkit [107466] by
-
- 4 edits in trunk/Source/WebCore
ScrollableArea should have a function for noting that the scroll position changed
https://bugs.webkit.org/show_bug.cgi?id=78402
Reviewed by Sam Weinig.
The scrolling coordinator needs a specialized function to call whenever the main frame
scrolling position has changed, so add ScrollableArea::notifyScrollPositionChanged and
call it from the scrolling coordinator.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
New function.
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call ScrollableArea::notifyScrollPositionChanged.
- 5:41 PM Changeset in webkit [107465] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
Fixing the build by removing a duplicate definition of pixelSnappedIntRect in LayoutTypes.h and
removing conflict markers from the changelog.
- rendering/LayoutTypes.h:
(pixelSnappedIntRect):
- ChangeLog:
- 5:37 PM Changeset in webkit [107464] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: convert font-size-fractional test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78347
Reviewed by Ojan Vafai.
- css3/calc/font-size-fractional-expected.txt:
- css3/calc/font-size-fractional.html:
- 5:20 PM Changeset in webkit [107463] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disable IndexedDB permissions check from shared workers
https://bugs.webkit.org/show_bug.cgi?id=78316
We want to temporarily bypass this check because it causes a crash
when called from a shared worker. We'll have to fix it before
including idb on shared workers in a release but don't want to stop
developers from testing out idb on shared workers.
No new tests because it affects shared workers only, which aren't
testable by DRT.
Reviewed by Tony Chang.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):
- 5:03 PM Changeset in webkit [107462] by
-
- 1 edit1 delete in trunk/LayoutTests
[chromium] Unreviewed, remove a linux gpu result that is not needed after r107448.
- platform/chromium-gpu-linux/media/video-empty-source-expected.png: Removed.
- 4:58 PM Changeset in webkit [107461] by
-
- 23 edits in trunk/Source/WebCore
Add pixelSnappedIntRect method
https://bugs.webkit.org/show_bug.cgi?id=78054
Reviewed by Eric Seidel.
This patch introduces a pixelSnappedIntRect method that will snap a sub-pixel LayoutRect to
pixel boundaries. These pixel snapped forms are what is used to communicate with the graphics
engine (to paint at whole pixel boundaries) and the embedding app (so they don't need to
understand we're using sub-pixel units).
No new tests. No change in behavior.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
- dom/Range.cpp:
(WebCore::Range::boundingBox):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
- page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::windowClipRectForLayer):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::selectionGaps):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::calculateRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::paintScrollbar):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::paint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):
- 4:55 PM Changeset in webkit [107460] by
-
- 15 edits in trunk/Source
Source/WebCore: Web Inspector: Add the ability to jump to the source for a given frame
https://bugs.webkit.org/show_bug.cgi?id=78396
Reviewed by Tim Hatcher.
- WebCore.exp.in: Add a new exported function.
- inspector/InspectorController.cpp: Add and expose the InspectorPageAgent.
(WebCore::InspectorController::InspectorController): Set m_pageAgent.
- inspector/InspectorController.h: Add m_pageAgent.
(WebCore::InspectorController::pageAgent): Return m_pageAgent.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame): Get the inspector's frame ID
of the frame that was passed in, and add a call to evaluate on load.
- inspector/InspectorFrontendClientLocal.h:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.showMainResourceForFrame): Add a FIXME to show the source code for the main
resource of the given frame.
Source/WebKit2: Web Inspector: Add the ability to jump to the source for a given frame
https://bugs.webkit.org/show_bug.cgi?id=78396
Add WebKit2 API for the ability to show the source of a frame in the web inspector. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showMainResourceForFrame.
Reviewed by Tim Hatcher.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorShowMainResourceForFrame): Call WebInspectorProxy::showMainResourceForFrame.
- UIProcess/API/C/WKInspector.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showMainResourceForFrame): Send a message to the web process, passing
the frame ID of the frame we want to show the main resource of.
- UIProcess/WebInspectorProxy.h:
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showMainResourceForFrame): Get the WebFrame for the frame we want to show the
main resource of from its ID. If we found a frame, call InspectorFrontendClientLocal::showMainResourceForFrame.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in: Add a new message.
- 4:42 PM Changeset in webkit [107459] by
-
- 11 edits in trunk/Source
Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it
Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.
- API/WebKitAvailability.h: Added AVAILABLE_AFTER_WEBKIT_VERSION_5_1 and AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1 for the new versions.
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it.
Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.
No new tests.
- bindings/objc/PublicDOMInterfaces.h: Moving accessKey property to DOMHTMLElement with an appropriate availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1. Also Moving accessKey property to HTMLAnchorElement, HTMLAreaElement, HTMLButtonElement, HTMLInputElement, HTMLLabelElement, HTMLLegendElement and HTMLTextAreaElement idls with an availability macro AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1.
- html/HTMLAnchorElement.idl: Adding accessKey entries back to idls under LANGUAGE_OBJECTIVE_C.
- html/HTMLAreaElement.idl: Ditto.
- html/HTMLButtonElement.idl: Ditto.
- html/HTMLInputElement.idl: Ditto.
- html/HTMLLabelElement.idl: Ditto.
- html/HTMLLegendElement.idl: Ditto.
- html/HTMLTextAreaElement.idl: Ditto.
- 4:36 PM Changeset in webkit [107458] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
- 4:35 PM Changeset in webkit [107457] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/rendering
Switching positionOverflowControls to operate on integers, as these overflow controls are always widgets on integer boundaries.
- 4:32 PM Changeset in webkit [107456] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixing windows build
Unreviewed build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:13 PM Changeset in webkit [107455] by
-
- 2 edits in trunk/LayoutTests
These SVG tests all appear to pass (many due to my updating their
baselines last night).
- platform/chromium/test_expectations.txt:
- 4:06 PM Changeset in webkit [107454] by
-
- 26 edits in trunk
Enable MUTATION_OBSERVERS by default on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78196
Reviewed by Ojan Vafai.
.:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- UseV8.cmake: Add some previously-missing files.
- WebCore.vcproj/WebCore.vcproj: ditto.
- bindings/js/JSBindingsAllInOne.cpp: ditto.
- dom/DOMAllInOne.cpp: ditto.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
- platform/efl/Skipped: Stop skipping the tests except for those known to fail.
- platform/gtk/Skipped: ditto.
- platform/mac/Skipped: ditto.
- platform/qt/Skipped: ditto.
- platform/win/Skipped: ditto.
- platform/wincairo/Skipped: ditto.
- 4:00 PM Changeset in webkit [107453] by
-
- 3 edits1 add in trunk/Source/WebCore
Add FractionalLayoutUnit type for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=77485
Reviewed by Eric Seidel.
Add fixed point implementation (FractionalLayoutUnit).
FractionalLayoutUnit represents values as multiples of 1/60th pixel. This allows us
to represent sub-pixel values using integer math and avoids floating point precision
problems.
No new tests.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h: Added.
- 3:53 PM Changeset in webkit [107452] by
-
- 3 edits in trunk/LayoutTests
Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
https://bugs.webkit.org/show_bug.cgi?id=78058
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-10
Reviewed by Eric Carlson.
File was created with ffmpeg2theora v0.24, command-line:
ffmpeg2theora --no-upscaling --no-skeleton -e 6.02 -K 21 test.mp4 -o test.ogv
The important bit was the addition of "-K 21" to force keyframe creation.
The other flags are important to minimize breakage of tests that hardcode
expectations like "the first 100k will contain the metadata" etc.
Before this, seeking to 5.6s would use the (only) keyframe at 2.4s and
have to decode all the way forward from there, which would be sometimes
timeout (presumably on overloaded bots).
- media/content/test.ogv:
- platform/chromium/test_expectations.txt:
- 3:53 PM Changeset in webkit [107451] by
-
- 2 edits in trunk/Tools
Move garden-o-matic's All Failures out of experimental
https://bugs.webkit.org/show_bug.cgi?id=78395
Reviewed by Dimitri Glazkov.
Several folks have tried this feature and found it useful.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 3:49 PM Changeset in webkit [107450] by
-
- 7 edits1 move in trunk
Don't lowercase ping URLs.
Previously, ping URLs would be lowercased when splitting them apart.
URLs are not, however, case-insensitive.
https://bugs.webkit.org/show_bug.cgi?id=78371
Reviewed by Tony Chang.
Source/WebCore:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings): Don't lowercase URL.
LayoutTests:
- http/tests/navigation/image-load-in-unload-handler.html: update to new URL
- http/tests/navigation/ping-cookie.html:
- http/tests/navigation/ping-cross-origin.html:
- http/tests/navigation/ping-same-origin.html:
- http/tests/navigation/resources/save-Ping.php: Renamed from LayoutTests/http/tests/navigation/resources/save-ping.php.
- 3:41 PM WikiStart edited by
- Added link to LayoutUnit wiki page (diff)
- 3:39 PM LayoutUnit edited by
- (diff)
- 3:38 PM Changeset in webkit [107449] by
-
- 3 edits in trunk/Source/WebKit
BlackBerry Port - JS focus on blur can cause recursion
https://bugs.webkit.org/show_bug.cgi?id=78368
Prevent JS recursion of blur/focus by allowing focus
if we are already trying to prevent focus.
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.
- blackberry/WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
- blackberry/WebKitSupport/InputHandler.h:
(InputHandler):
- 3:30 PM Changeset in webkit [107448] by
-
- 7 edits9 adds in trunk/LayoutTests
media/video-empty-source.html needs a rebaseline for chromium
https://bugs.webkit.org/show_bug.cgi?id=78233
Unreviewed rebaselining.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-10
- platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-linux/media/video-empty-source-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-mac-leopard/media/video-empty-source-expected.png:
- platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Added.
- platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-win-xp/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-win/media/video-empty-source-expected.png:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:01 PM Changeset in webkit [107447] by
-
- 2 edits in trunk/Source/JavaScriptCore
ENABLE(ASSEMBLER_WX_EXCLUSIVE): LinkBuffer can leave pages not marked as executable.
https://bugs.webkit.org/show_bug.cgi?id=76724
Patch by Yong Li <yoli@rim.com> on 2012-02-10
Reviewed by Rob Buis.
This issue only exists when both ENABLE(ASSEMBLER_WX_EXCLUSIVE) and ENABLE(BRANCH_COMPACTION) are on.
The size used to call makeExecutable can be smaller than the one that was used for makeWritable.
So it can leave pages behind that are not set back to default flags. When an assembly on one of those
pages is executed or JIT returns to those pages in the case it was already executing from there, the
software will crash.
- assembler/LinkBuffer.h: Add m_initialSize and use it in performFinalization().
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(LinkBuffer):
- 3:01 PM Changeset in webkit [107446] by
-
- 4 edits2 adds in trunk
flex-pack:center and flex-item-align:center should do true centering
https://bugs.webkit.org/show_bug.cgi?id=77385
Reviewed by Tony Chang.
Source/WebCore:
Also, removed passing totalPositiveFlexibility around. We don't
need to know about positive/negative flex once we run the flexing algorithm.
We used to need to know this in order to flex margins, but margins can
no longer be flexed.
Test: css3/flexbox/true-centering.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
- css3/flexbox/true-centering-expected.txt: Added.
- css3/flexbox/true-centering.html: Added.
- 2:44 PM Changeset in webkit [107445] by
-
- 22 edits in trunk/Source
Split MarkedSpace into destructor and destructor-free subspaces
https://bugs.webkit.org/show_bug.cgi?id=77761
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Switched over to use destructor-free space.
- heap/Heap.h:
(JSC::Heap::allocatorForObjectWithoutDestructor): Added to give clients (e.g. the JIT) the ability to
pick which subspace they want to allocate out of.
(JSC::Heap::allocatorForObjectWithDestructor): Ditto.
(Heap):
(JSC::Heap::allocateWithDestructor): Added private function for CellAllocator to use.
(JSC):
(JSC::Heap::allocateWithoutDestructor): Ditto.
- heap/MarkedAllocator.cpp: Added the cellsNeedDestruction flag to allocators so that they can allocate
their MarkedBlocks correctly.
(JSC::MarkedAllocator::allocateBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::cellsNeedDestruction):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC):
(JSC::MarkedAllocator::init): Replaced custom set functions, which were only used upon initialization, with
an init function that does all of that stuff in fewer lines.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor): Templatized, along with specializedSweep and sweepHelper, to make
checking the m_cellsNeedDestructor flag faster and cleaner looking.
(JSC):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
- heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::cellsNeedDestruction):
(JSC):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):
- heap/MarkedSpace.h:
(MarkedSpace):
(Subspace):
(JSC::MarkedSpace::allocatorFor): Needed function to differentiate between the two broad subspaces of
allocators.
(JSC):
(JSC::MarkedSpace::destructorAllocatorFor): Ditto.
(JSC::MarkedSpace::allocateWithoutDestructor): Ditto.
(JSC::MarkedSpace::allocateWithDestructor): Ditto.
(JSC::MarkedSpace::forEachBlock):
- jit/JIT.h:
- jit/JITInlineMethods.h: Modified to use the proper allocator for JSFinalObjects and others.
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
- runtime/JSArray.cpp:
(JSC):
- runtime/JSArray.h:
(JSArray):
(JSC::JSArray::create):
(JSC):
(JSC::JSArray::tryCreateUninitialized):
- runtime/JSCell.h:
(JSCell):
(JSC):
(NeedsDestructor): Template struct that calculates at compile time whether the class in question requires
destruction or not using the compiler type trait has_trivial_destructor. allocateCell then checks this
constant to decide whether to allocate in the destructor or destructor-free parts of the heap.
(JSC::allocateCell):
- runtime/JSFunction.cpp:
(JSC):
- runtime/JSFunction.h:
(JSFunction):
- runtime/JSObject.cpp:
(JSC):
- runtime/JSObject.h:
(JSNonFinalObject):
(JSC):
(JSFinalObject):
(JSC::JSFinalObject::create):
Source/WebCore:
No new tests.
- bindings/js/JSDOMWindowShell.cpp: Removed old operator new, which was just used in the create
function so that we can use allocateCell instead.
(WebCore):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
(JSDOMWindowShell):
- bindings/scripts/CodeGeneratorJS.pm: Added destructor back to root JS DOM nodes (e.g. JSNode, etc)
because their destroy functions need to be called, so we don't want the NeedsDestructor struct to
think they don't need destruction due to having empty/trivial destructors.
Removed ASSERT_HAS_TRIVIAL_DESTRUCTOR from all JS DOM wrapper auto-generated objects because their
ancestors now have non-trivial destructors.
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):
- 2:42 PM Changeset in webkit [107444] by
-
- 1 edit2 adds in trunk/LayoutTests
[chromium] Unreviewed, adding Leopard pixel baselines for
fast/forms/select-overflow-scroll* tests. This was missed in r107084.
- platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- 2:25 PM Changeset in webkit [107443] by
-
- 3 edits in trunk/Source/WebCore
Remove a bunch of unused ScrollableArea member functions
https://bugs.webkit.org/show_bug.cgi?id=78388
Reviewed by Beth Dakin.
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
- 2:20 PM Changeset in webkit [107442] by
-
- 4 edits in trunk/Source/WebCore
Fix a few typos in IDL exception names.
https://bugs.webkit.org/show_bug.cgi?id=78356
Reviewed by Adam Barth.
- dom/Node.idl:
- notifications/NotificationCenter.idl:
- page/Navigator.idl:
- 2:19 PM Changeset in webkit [107441] by
-
- 9 edits1 copy2 deletes in trunk/LayoutTests
[chromium] Unreviewed, fix up some baselines that were landed in r107417.
Some bad results were checked in.
- platform/chromium-linux-x86/svg/filters/filter-refresh-expected.txt:
- platform/chromium-linux/svg/filters/filter-refresh-expected.txt:
- platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Renamed from LayoutTests/platform/chromium/svg/filters/animate-fill-expected.txt.
- platform/chromium-win-vista/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win-xp/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
- platform/chromium-win/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
- platform/chromium-win/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- 2:17 PM Changeset in webkit [107440] by
-
- 3 edits in trunk/Source/WebCore
DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
https://bugs.webkit.org/show_bug.cgi?id=78374
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.
The value comes from size_t and is converted to int for no good reason. We should use
size_t.
- platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
- platform/DefaultLocalizationStrategy.h:
(DefaultLocalizationStrategy):
- 2:17 PM Changeset in webkit [107439] by
-
- 2 edits in trunk/LayoutTests
Remove platform/win/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=78382
Reviewed by Adam Barth.
This files is unused, since the Apple win port does not use new-run-webkit-tests, and causes unnecessary
confusion.
- platform/win/test_expectations.txt:
- 2:01 PM Changeset in webkit [107438] by
-
- 4 edits in trunk/Source/WebCore
More ScrollableArea cleanup
https://bugs.webkit.org/show_bug.cgi?id=78383
Reviewed by Beth Dakin.
Get rid of setScrollOriginX and setScrollOriginY. Make ScrollableArea::setScrollOrigin private.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOrigin):
- platform/ScrollableArea.h:
(ScrollableArea):
- 1:52 PM Changeset in webkit [107437] by
-
- 3 edits in branches/subpixellayout/Source
Remove unnecessary type conversions.
- 1:43 PM Changeset in webkit [107436] by
-
- 3 edits in trunk/Source/WebCore
Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
https://bugs.webkit.org/show_bug.cgi?id=78353
Reviewed by Adam Barth.
[JSCustomPrototypePutDelegate] is used to write custom code for named
getters on a prototype interface. "PutDelegate" is just a method name
in implementation and not so descriptive. This patch renames it to
[JSCustomNamedGetterOnPrototype]. This is also for naming consistency
with [CustomNamedGetter].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- page/Location.idl:
- 1:40 PM Changeset in webkit [107435] by
-
- 14 edits3 adds in trunk/Source
Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. No change in behavior, just code refactoring.
- WebCore.exp.in: Added exported class PlatformPasteboard.
- WebCore.xcodeproj/project.pbxproj: Added new files to the build.
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
- platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pasteboardStrategy): Added.
- platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.
- platform/mac/PlatformPasteboardMac.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
- WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
(WebPlatformStrategies::createPasteboardStrategy):
(WebPlatformStrategies::getTypes):
(WebPlatformStrategies::bufferForType):
(WebPlatformStrategies::getPathnamesForType):
(WebPlatformStrategies::stringForType):
(WebPlatformStrategies::copy):
(WebPlatformStrategies::setTypes):
(WebPlatformStrategies::setBufferForType):
(WebPlatformStrategies::setPathnamesForType):
(WebPlatformStrategies::setStringForType):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy
interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
- 1:33 PM Changeset in webkit [107434] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
[chromium] Unreviewed, update SnowLeopard results for
compositing/geometry/fixed-position-composited.html. Minor differences
in fonts between Leopard and SL.
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
- 1:16 PM Changeset in webkit [107433] by
-
- 4 edits in branches/chromium/1025
Merge 106730 - Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect
Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Did change inorder to print correct log as per the description provided in test case.
- fast/events/autoscroll-with-non-scrollable-parent.html:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9385018
- 1:03 PM Changeset in webkit [107432] by
-
- 8 edits in trunk/Source/WebCore
Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
https://bugs.webkit.org/show_bug.cgi?id=78352
Reviewed by Adam Barth.
[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/History.idl:
- page/Location.idl:
- workers/WorkerContext.idl:
- 1:00 PM Changeset in webkit [107431] by
-
- 3 edits in trunk/Source/WebCore
Minor ScrollAnimatorMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=78375
Reviewed by Beth Dakin.
Get rid of adjustScrollXPositionIfNecessary and adjustScrollYPositionIfNecessary.
Also, reduce nesting in willAdd/didAdd functions by using early returns.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
- 1:00 PM Changeset in webkit [107430] by
-
- 4 edits in branches/chromium/1025/Source/WebKit/chromium
Merge 106401 (part of http://crbug.com/111266) -
[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453
Needed for http://crbug.com/111266
Reviewed by Darin Fisher.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9384018
- 12:49 PM Changeset in webkit [107429] by
-
- 4 edits in trunk/Source/WebCore
Minor ScrollableArea cleanup
https://bugs.webkit.org/show_bug.cgi?id=78372
Reviewed by Beth Dakin.
Get rid of scrollToXOffsetWithoutAnimation and scrollToYOffsetWithoutAnimation.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
- platform/ScrollableArea.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight):
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::setScrollTop):
- 12:17 PM Changeset in webkit [107428] by
-
- 4 edits in trunk/Source
[Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT
https://bugs.webkit.org/show_bug.cgi?id=78320
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.
<rdar://problem/10839750>
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- 12:15 PM Changeset in webkit [107427] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, mark compositing/rubberbanding tests as failing.
There's too much flipping in the tests for me to narrow it down to a revision.
- platform/chromium/test_expectations.txt:
- 12:11 PM Changeset in webkit [107426] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/RenderQueue.cpp: Added.
- blackberry/WebKitSupport/RenderQueue.h: Added.
- 12:07 PM Changeset in webkit [107425] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: update font-size test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78325
Reviewed by Ojan Vafai.
- css3/calc/font-size-expected.txt:
- css3/calc/font-size.html:
- 12:06 PM Changeset in webkit [107424] by
-
- 2 edits in trunk/Source/WebCore
Update the non-fast-scrollable region for subframe layout as well
https://bugs.webkit.org/show_bug.cgi?id=78366
<rdar://problem/10844064>
Reviewed by Beth Dakin.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Move the non-fast-scrollable region computation out into a new function.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Always recompute the non-fast-scrollable region whenever a frame view's layout is updated,
not just the main frame.
- 11:54 AM Changeset in webkit [107423] by
-
- 1 edit4 adds in trunk/LayoutTests
[chromium] Unreviewed: The Leopard results were missed in r107140.
The getComputedStyle change is due to r107289.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug23151-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
- 11:41 AM Changeset in webkit [107422] by
-
- 14 edits12 adds in trunk
Implement hardware animation of CSS filters
https://bugs.webkit.org/show_bug.cgi?id=78155
Source/WebCore:
Added logic to PlatformCAAnimation to return enough information
to GraphicsLayerCA to be able to construct a keyPath animation
for each filter property. Some filters need to animate multiple
properties per filter, so PlatformCAAnimation also returns the number
of properties per filter and then an animation is constructed for
each one. Also added all the support logic to handle hardware filter
animation in the higher level logic, just like we do for transforms and
opacity.
Also stubbed out new PlatformCAAnimation functions for Windows. We don't yet
support hardware filters on Windows.
Reviewed by Dean Jackson.
Tests: css3/filters/filter-animation-from-none-hw.html
css3/filters/filter-animation-from-none-multi-hw.html
css3/filters/filter-animation-from-none-multi.html
css3/filters/filter-animation-hw.html
css3/filters/filter-animation-multi-hw.html
css3/filters/filter-animation-multi.html
- page/animation/AnimationBase.cpp:
(WebCore):
(PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::animationIsAccelerated):
(WebCore::PropertyWrapperAcceleratedFilter::blend):
(WebCore::AnimationBase::ensurePropertyMap):
- platform/graphics/GraphicsLayer.cpp:
(WebCore):
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
- platform/graphics/GraphicsLayer.h:
(WebCore):
(FilterAnimationValue):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(WebCore::FilterAnimationValue::clone):
(WebCore::FilterAnimationValue::value):
(GraphicsLayer):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::propertyIdToString):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::cloneLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- platform/graphics/ca/PlatformCAAnimation.h:
(PlatformCAAnimation):
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):
- platform/graphics/filters/FilterOperation.h:
(FilterOperation):
(WebCore::FilterOperation::isDefault):
(DefaultFilterOperation):
(WebCore::DefaultFilterOperation::create):
(WebCore::DefaultFilterOperation::operator==):
(WebCore::DefaultFilterOperation::isDefault):
(WebCore::DefaultFilterOperation::DefaultFilterOperation):
(WebCore):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasFilter):
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):
LayoutTests:
New tests for hardware animated filters, cribbed from software animation tests.
Also added a -multi test, which uses 3 keyframes for each filter. Hardware animations
use the same logic for 2 keyframe animations and transitions, so this exercises the
other logic path.
Reviewed by Dean Jackson.
- css3/filters/filter-animation-from-none-hw-expected.txt: Added.
- css3/filters/filter-animation-from-none-hw.html: Added.
- css3/filters/filter-animation-from-none-multi-expected.txt: Added.
- css3/filters/filter-animation-from-none-multi-hw-expected.txt: Added.
- css3/filters/filter-animation-from-none-multi-hw.html: Added.
- css3/filters/filter-animation-from-none-multi.html: Added.
- css3/filters/filter-animation-hw-expected.txt: Added.
- css3/filters/filter-animation-hw.html: Added.
- css3/filters/filter-animation-multi-expected.txt: Added.
- css3/filters/filter-animation-multi-hw-expected.txt: Added.
- css3/filters/filter-animation-multi-hw.html: Added.
- css3/filters/filter-animation-multi.html: Added.
- 11:36 AM Changeset in webkit [107421] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove implicit copy constructor usage in HashMaps with OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78071
Reviewed by Darin Adler.
Change the return type of emptyValue() in PairHashTraits to be the
actual type returned rather than the trait type to avoid an implicit
generation of the OwnPtr copy constructor. This happens for hash
traits involving OwnPtr where the empty value is not zero and each
hash bucket needs to be initialized with emptyValue().
Also, update StructureTransitionTable to use default hash traits
rather than rolling its own, in order to update it to handle
EmptyValueType.
Test: patch from bug 74154 compiles on Clang with this patch
- runtime/StructureTransitionTable.h:
(StructureTransitionTable):
- wtf/HashTraits.h:
(GenericHashTraits):
(PairHashTraits):
(WTF::PairHashTraits::emptyValue):
- 11:33 AM Changeset in webkit [107420] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: convert font test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78321
Reviewed by Ojan Vafai.
- css3/calc/font-expected.txt:
- css3/calc/font.html:
- 11:31 AM Changeset in webkit [107419] by
-
- 5 edits in trunk/LayoutTests
[chromium] Unreviewed: Add baselines on Mac for 2 tests that got
missed in the jpeg change (r107389). I verified that the only diffs
were in the jpeg and very minor.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
- 11:20 AM Changeset in webkit [107418] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed: Give fast/js/dfg-int8array.html more time to run in debug.
The flakiness dashboard show it timing out regularly on Mac and occasionally on Windows.
- platform/chromium/test_expectations.txt:
- 11:16 AM Changeset in webkit [107417] by
-
- 93 edits62 adds55 deletes in trunk/LayoutTests
Massive SVG rebaselining on Chromium after bug 77736 and al.
Output trimmed.
- 11:02 AM Changeset in webkit [107416] by
-
- 7 edits in branches/subpixellayout/Source/WebCore
Switching RenderLayer's tracked repaint and outline rects, and LayoutRepainter's tracked boundary rects to LayoutRects. This keeps us from losing precision and conducting unnecessary repaints.
- 10:50 AM Changeset in webkit [107415] by
-
- 2 edits in trunk/Tools
NRWT should categorize options in --help
https://bugs.webkit.org/show_bug.cgi?id=76221
Reviewed by Eric Seidel.
Use optparse's OptionGroup mechanism to logically group NRWT's options,
providing a better experience when scanning all the options.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 10:45 AM Changeset in webkit [107414] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106488
BUG=112259
Review URL: https://chromiumcodereview.appspot.com/9379014
- 10:41 AM Changeset in webkit [107413] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106488
BUG=112259
Review URL: https://chromiumcodereview.appspot.com/9385008
- 10:39 AM Changeset in webkit [107412] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: properly resolve output types of commands
https://bugs.webkit.org/show_bug.cgi?id=78025
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-10
Reviewed by Vsevolod Vlasov.
Code for generating ad-hoc types is added. It was reused from event
generator part.
- inspector/CodeGeneratorInspector.py:
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.add_type):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener.add_type_data):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceResolveContext):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator):
- 10:35 AM Changeset in webkit [107411] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107369
BUG=112055
Review URL: https://chromiumcodereview.appspot.com/9381012
- 10:28 AM Changeset in webkit [107410] by
-
- 9 edits in trunk/Source/WebCore
Rename [CustomPropertyNames] to [CustomEnumerateProperty]
https://bugs.webkit.org/show_bug.cgi?id=78351
Reviewed by Adam Barth.
This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):
- css/CSSStyleDeclaration.idl:
- dom/DOMStringMap.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- 10:27 AM Changeset in webkit [107409] by
-
- 3 edits in branches/chromium/1025/Source/WebKit/chromium/src
Merge 107174
BUG=108695
Review URL: https://chromiumcodereview.appspot.com/9380014
- 10:22 AM Changeset in webkit [107408] by
-
- 3 edits in branches/chromium/963/Source/WebKit/chromium/src
Merge 107174
BUG=108695
Review URL: https://chromiumcodereview.appspot.com/9383008
- 10:22 AM Changeset in webkit [107407] by
-
- 21 edits in trunk/Source
Use underlying property set to refcount PropertySetCSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=78257
Reviewed by Andreas Kling.
Clean up the PropertySetCSSStyleDeclaration refcounting. PropertySetCSSStyleDeclaration now
forwards the ref/deref to the underlying StylePropertySet.
Also made CSSComputedStyleDeclaration construction use the standard create() pattern.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::ref):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::deref):
- css/CSSComputedStyleDeclaration.h:
(WebCore::CSSComputedStyleDeclaration::create):
(CSSComputedStyleDeclaration):
(WebCore):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
- css/StylePropertySet.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::backgroundColorInEffect):
- editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
- svg/SVGAnimateElement.cpp:
(WebCore::getPropertyValue):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::baseValueFor):
- 9:27 AM Changeset in webkit [107406] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
The test is not finishing on windows so now we are waiting 30 seconds
before killing it. Replacing the SLOW keyword with TIMEOUT as it did
not help.
- 9:19 AM Changeset in webkit [107405] by
-
- 2 edits in trunk/LayoutTests
win test_expectations and Skipped have duplicates
https://bugs.webkit.org/show_bug.cgi?id=78260
Reviewed by Anders Carlsson.
- platform/win/test_expectations.txt: Remove duplicated entries
from this file. They were wrongly added to Skipped too and looking
at the comment in r103876, it's better to keep the Skipped entries.
- 8:32 AM Changeset in webkit [107404] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Fix compiler warning in Visual Studio 2010 about TR1
https://bugs.webkit.org/show_bug.cgi?id=63642
Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-10
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 7:41 AM Changeset in webkit [107403] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-10
- DEPS:
- 7:41 AM Changeset in webkit [107402] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
https://bugs.webkit.org/show_bug.cgi?id=78236
Reviewed by Vsevolod Vlasov.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
- 7:41 AM Changeset in webkit [107401] by
-
- 1 edit4 adds in trunk/Source/WebKit
[BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/SurfacePool.cpp: Added.
- blackberry/WebKitSupport/SurfacePool.h: Added.
- blackberry/WebKitSupport/TileIndex.h: Added.
- blackberry/WebKitSupport/TileIndexHash.h: Added.
- 7:31 AM Changeset in webkit [107400] by
-
- 3 edits3 adds in trunk
Yarr assert with regexp where alternative in *-quantified group matches empty
https://bugs.webkit.org/show_bug.cgi?id=67752
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Added backtracking for the prior alternative if it matched
but didn't consume any input characters.
- yarr/YarrJIT.cpp:
(YarrOp): New jump.
(JSC::Yarr::YarrGenerator::generate): Emit conditional jump
when an alternative matches and no input was consumed. Moved the
zero length match check for a set of alternatives to the alternative
code from the parentheses cases to the alternative end cases.
Converted the existing zero length checks in the parentheses cases
to runtime assertion checks.
(JSC::Yarr::YarrGenerator::backtrack): Link new jump to backtrack
to prior term.
LayoutTests:
Added new tests for alternatives that match without consuming
any input characters.
- fast/js/regexp-zero-length-alternatives-expected.txt: Added.
- fast/js/regexp-zero-length-alternatives.html: Added.
- fast/js/script-tests/regexp-zero-length-alternatives.js: Added.
- 5:15 AM Changeset in webkit [107399] by
-
- 17 edits2 copies2 adds in trunk
Web Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands.
https://bugs.webkit.org/show_bug.cgi?id=78346
Reviewed by Yury Semikhatsky.
Source/WebCore:
Tests: inspector/elements/undo-set-outer-html-2.html
inspector/elements/undo-set-outer-html.html
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::undo):
(WebCore):
(DOMEditor::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::undo):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
(WebCore::DOMEditor::replaceChild):
(WebCore::DOMEditor::setNodeValue):
(WebCore::populateErrorString):
- inspector/DOMEditor.h:
(DOMEditor):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
(WebCore):
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::insertBeforeAndMarkAsUsed):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
- inspector/DOMPatchSupport.h:
(WebCore):
(DOMPatchSupport):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::toErrorString):
(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::undo):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::undo):
- inspector/InspectorHistory.h:
(WebCore):
(Action):
(InspectorHistory):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
- inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
LayoutTests:
- inspector/elements/set-outer-html-2-expected.txt:
- inspector/elements/set-outer-html-test.js:
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML):
(initialize_SetOuterHTMLTest):
- inspector/elements/undo-dom-edits-expected.txt:
- inspector/elements/undo-set-outer-html-2-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
- inspector/elements/undo-set-outer-html-2.html: Added.
- inspector/elements/undo-set-outer-html-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
- inspector/elements/undo-set-outer-html.html: Added.
- 5:04 AM Changeset in webkit [107398] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450
- platform/qt-4.8/Skipped: Add after r107397, because it was missing accidentally.
- 4:48 AM Changeset in webkit [107397] by
-
- 6 edits2 moves in trunk
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-10
Reviewed by Csaba Osztrogonác.
Tools:
Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
to qt-5.0-wk2 and qt-5.0-wk1.
- Scripts/old-run-webkit-tests:
(buildPlatformResultHierarchy):
(readSkippedFiles):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._wk2_port_name):
(QtPort._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._wk2_port_name):
LayoutTests:
The folders qt-wk2 and qt-wk1 have been renamed to qt-5.0-wk2 and qt-5.0-wk1, respectively,
and the skipped list from qt-wk1 has been copied into qt-4.8/Skipped.
- platform/qt-4.8/Skipped: Copy entries from platform/qt-wk1.
- platform/qt-5.0-wk1/: Renamed from platform/qt-wk1.
- platform/qt-5.0-wk2/: Renamed from platform/qt-wk1.
- platform/qt-wk1/: Removed.
- platform/qt-wk2/: Removed.
- 4:38 AM Changeset in webkit [107396] by
-
- 18 edits in trunk/Source/WebCore
Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327
Reviewed by Adam Barth.
This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm: Modified to replace
[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateCallWith):
- bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(SkipFunction):
(GenerateFunction):
- bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):
- bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
(WebCore::V8Console::assertCallback):
- page/Console.cpp: Ditto.
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
- page/Console.h: Ditto.
(Console):
- bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- 3:51 AM Changeset in webkit [107395] by
-
- 2 edits in trunk/Source/WebCore
[GTK] KURL::fileSystemPath() doesn't work if uri contains #
https://bugs.webkit.org/show_bug.cgi?id=78339
Reviewed by Philippe Normand.
- platform/gtk/KURLGtk.cpp:
(WebCore::KURL::fileSystemPath): Use GFile API instead of
g_filename_from_uri() to convert the uri to a local
path. g_file_get_path() removes the anchor from the uri and
returns a valid path instead of NULL.
- 3:46 AM Changeset in webkit [107394] by
-
- 3 edits in trunk/Source/WebCore
CodeGeneratorJS doesn't always generate visitChildren() implementation when required
https://bugs.webkit.org/show_bug.cgi?id=78336
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-10
Reviewed by Kentaro Hara.
In an IDL for an interface that declares no functions, but has
attributes with [CachedAttribute], the implementation of visitChildren()
is not generated by the JSC code generator.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::visitChildren):
(WebCore):
- 3:25 AM Changeset in webkit [107393] by
-
- 5 edits in trunk
Perf-o-matic build fix after r107386.
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
- Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.get):
- Websites/webkit-perf.appspot.com/report_logs_handler.py:
(ReportLogsHandler.get):
(ReportLogsHandler.post):
- 3:23 AM Changeset in webkit [107392] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 3:04 AM Changeset in webkit [107391] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline and skipping another svg test
presenting floating-point issues.
- platform/gtk/Skipped:
- platform/gtk/editing/execCommand/insertImage-expected.txt:
- platform/gtk/security/block-test-expected.txt:
- 2:48 AM Changeset in webkit [107390] by
-
- 6 edits in trunk/Source/JavaScriptCore
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-10
Reviewed by Zoltan Herczeg.
These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.
Measurement results:
V8 speed-up: 1.025x as fast [From: 663.4ms To: 647.0ms ]
V8 Splay speed-up: 1.185x as fast [From: 138.4ms To: 116.8ms ]
Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
- JavaScriptCore.order:
- wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
- wtf/MainThread.h:
(WTF):
- wtf/Platform.h:
- wtf/mac/MainThreadMac.mm:
(WTF):
- 2:46 AM Changeset in webkit [107389] by
-
- 4 edits in trunk
[chromium] Increase JPEG decoding performance some more
https://bugs.webkit.org/show_bug.cgi?id=78323
Reviewed by Adam Barth.
Source/WebCore:
Increase JPEG image decoding speed by another 9% (avg) according to libjpeg-turbo tjbench.
No new tests. Covered by many existing tests, all requiring subsequent rebaselines.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(dctMethod): Fast decode on the jpeg-turbo using ports (Chrome Android, Chrome, Chromium).
(WebCore::JPEGImageReader::decode): Select DCT method via a helper routine.
LayoutTests:
- platform/chromium/test_expectations.txt: tests containing jpeg images that will require
rebaselines, mostly together in a group, but some other expectations unattended to at the
current time, spread changes throughout the file. The following lists changed tests for
chrome mac and win:
compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
compositing/overflow/overflow-scaled-descendant-overlapping.html
fast/backgrounds/size/backgroundSize17.html
fast/backgrounds/size/backgroundSize18.html
fast/backgrounds/size/backgroundSize19.html
fast/backgrounds/size/backgroundSize20.html
fast/backgrounds/size/backgroundSize21.html
fast/backgrounds/size/backgroundSize22.html
fast/block/float/014.html
fast/images/color-jpeg-with-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/image-css3-content-data.html
fast/images/ycbcr-with-cmyk-color-profile.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
fast/replaced/absolute-image-sizing.html
fast/replaced/image-onload.html
fast/replaced/image-sizing.html
fast/replaced/image-tag.html
fast/replaced/width100percent-image.html
fast/writing-mode/background-horizontal-bt.html
fast/writing-mode/background-vertical-lr.html
fast/writing-mode/background-vertical-rl.html
platform/chromium/compositing/img-layer-grow.html
svg/W3C-SVG-1.1/animate-elem-30-t.svg
svg/W3C-SVG-1.1/animate-elem-36-t.svg
svg/W3C-SVG-1.1/animate-elem-39-t.svg
svg/W3C-SVG-1.1/animate-elem-40-t.svg
svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/W3C-SVG-1.1/struct-image-01-t.svg
svg/W3C-SVG-1.1/struct-image-02-b.svg
svg/W3C-SVG-1.1/struct-image-04-t.svg
svg/carto.net/scrollbar.svg
svg/carto.net/selectionlist.svg
svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
tables/mozilla/bugs/bug101674.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
tables/mozilla/bugs/bug1188.html
tables/mozilla/bugs/bug120107.html
tables/mozilla/bugs/bug1271.html
tables/mozilla/bugs/bug12908-1.html
tables/mozilla/bugs/bug12908-2.html
tables/mozilla/bugs/bug1296.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug1430.html
tables/mozilla/bugs/bug15544.html
tables/mozilla/bugs/bug17138.html
tables/mozilla/bugs/bug196870.html
tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug2981-2.html
tables/mozilla/bugs/bug4093.html
tables/mozilla/bugs/bug4284.html
tables/mozilla/bugs/bug4427.html
tables/mozilla/bugs/bug50695-2.html
tables/mozilla/bugs/bug56563.html
tables/mozilla/bugs/bug5797.html
tables/mozilla/bugs/bug625.html
tables/mozilla/bugs/bug6404.html
tables/mozilla/bugs/bug82946-2.html
tables/mozilla/bugs/bug86708.html
tables/mozilla/core/bloomberg.html
tables/mozilla/core/col_widths_auto_autoFix.html
tables/mozilla/core/misc.html
tables/mozilla/core/row_span.html
tables/mozilla/marvin/tbody_valign_baseline.html
tables/mozilla/marvin/tbody_valign_bottom.html
tables/mozilla/marvin/tbody_valign_middle.html
tables/mozilla/marvin/tbody_valign_top.html
tables/mozilla/marvin/td_valign_baseline.html
tables/mozilla/marvin/td_valign_bottom.html
tables/mozilla/marvin/td_valign_middle.html
tables/mozilla/marvin/td_valign_top.html
tables/mozilla/marvin/tfoot_valign_baseline.html
tables/mozilla/marvin/tfoot_valign_bottom.html
tables/mozilla/marvin/tfoot_valign_middle.html
tables/mozilla/marvin/tfoot_valign_top.html
tables/mozilla/marvin/th_valign_baseline.html
tables/mozilla/marvin/th_valign_bottom.html
tables/mozilla/marvin/th_valign_middle.html
tables/mozilla/marvin/th_valign_top.html
tables/mozilla/marvin/thead_valign_baseline.html
tables/mozilla/marvin/thead_valign_bottom.html
tables/mozilla/marvin/thead_valign_middle.html
tables/mozilla/marvin/thead_valign_top.html
tables/mozilla/marvin/tr_valign_baseline.html
tables/mozilla/marvin/tr_valign_bottom.html
tables/mozilla/marvin/tr_valign_middle.html
tables/mozilla/marvin/tr_valign_top.html
tables/mozilla/other/cell_widths.html
tables/mozilla_expected_failures/bugs/bug6933.html
tables/mozilla_expected_failures/bugs/bug85016.html
tables/mozilla_expected_failures/other/test4.html
- 2:10 AM Changeset in webkit [107388] by
-
- 3 edits3 deletes in trunk/LayoutTests
Unreviewed, rebaseline svg/carto.net/selectionlist.svg.
- platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
- 2:02 AM Changeset in webkit [107387] by
-
- 4 edits1 copy1 delete in trunk/LayoutTests
Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
- platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
- platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
- 1:56 AM Changeset in webkit [107386] by
-
- 6 edits1 copy1 move2 adds in trunk
Perf-o-matic should process reports in background
https://bugs.webkit.org/show_bug.cgi?id=78309
Reviewed by Hajime Morita.
Split the logic to create Build, Test, and TestResult objects from ReportHandler into ReportProcessHandler.
ReportHandler now merely creates ReportLog and schedules a task to process it.
Also added ReportLogHandler to manage stale ReportLogs.
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
(CachedRunsHandler.get):
(schedule_report_process):
- Websites/webkit-perf.appspot.com/main.py:
- Websites/webkit-perf.appspot.com/merge_tests.html: Renamed from Websites/webkit-perf.appspot.com/merge_tests.yaml.
- Websites/webkit-perf.appspot.com/models.py:
(ReportLog):
(ReportLog._parsed_payload):
(ReportLog.get_value):
(ReportLog.results):
(ReportLog.builder):
(ReportLog.branch):
(ReportLog.platform):
(ReportLog.build_number):
(ReportLog.webkit_revision):
(ReportLog.chromium_revision):
(ReportLog._model_by_key_name_in_payload):
(ReportLog._integer_in_payload):
(ReportLog.timestamp):
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._output):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler):
- Websites/webkit-perf.appspot.com/report_logs.html: Added.
- Websites/webkit-perf.appspot.com/report_logs_handler.py: Added.
(ReportLogsHandler):
(ReportLogsHandler.get):
(ReportLogsHandler.post):
(ReportLogsHandler._error):
- Websites/webkit-perf.appspot.com/report_process_handler.py: Copied from Websites/webkit-perf.appspot.com/report_handler.py.
(ReportProcessHandler):
(ReportProcessHandler.post):
(ReportProcessHandler._create_build_if_possible):
(ReportProcessHandler._create_build_if_possible.execute):
(ReportProcessHandler._add_test_if_needed):
- 1:41 AM Changeset in webkit [107385] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test fix following r107373.
https://bugs.webkit.org/show_bug.cgi?id=78254
This also resolves https://bugs.webkit.org/show_bug.cgi?id=77416.
- inspector/timeline/timeline-receive-response-event.html:
- platform/chromium/test_expectations.txt:
- 1:34 AM Changeset in webkit [107384] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: FileSelector should not depend on DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=78337
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.FileSelector.prototype.reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.reset):
- 1:29 AM Changeset in webkit [107383] by
-
- 2 edits in trunk/LayoutTests
Unreviewed attempt to fix the test failure.
- editing/spelling/spelling-marker-description.html:
- 1:28 AM Changeset in webkit [107382] by
-
- 2 edits in trunk/Source/WebCore
Remove [ConvertingNullStringTo] from CloseEvent.idl
https://bugs.webkit.org/show_bug.cgi?id=78328
Reviewed by Adam Barth.
In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
Test: fast/events/constructors/close-event-constructor.html
- websockets/CloseEvent.idl:
- 1:13 AM Changeset in webkit [107381] by
-
- 2 edits in trunk/LayoutTests
2012-02-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix error in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 1:06 AM Changeset in webkit [107380] by
-
- 5 edits in trunk
[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78330
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchChildren):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:04 AM Changeset in webkit [107379] by
-
- 2 edits2 deletes in trunk/LayoutTests
- platform/chromium-mac/storage/domstorage/quota-expected.txt: Removed.
- platform/chromium-win/storage/domstorage/quota-expected.txt: Removed.
- These baselines are wrong. Removing them shows that we pass this test now.
- platform/chromium/test_expectations.txt:
- According to the flakiness dashboard, these tests always pass now.
- 12:56 AM Changeset in webkit [107378] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new asserting tests to paint the debug bot green.
- platform/qt/Skipped:
- 12:52 AM Changeset in webkit [107377] by
-
- 52 edits54 adds36 deletes in trunk/LayoutTests
Update a large number of baselines for svg/custom. These baselines all
appear to be correct (or at least no less correct than the previous
baselines). There are a number of svg/custom tests that appear to be
actually failing, which I haven't rebaselined.
This patch does not update the test_expectations.txt file. Once this
patch has cycled through the bots, I'll clean up the expectations file
as appropriate.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/chromium-linux/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/chromium-linux/svg/custom/getTransformToElement-expected.png:
- platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
- platform/chromium-linux/svg/custom/js-update-style-expected.txt: Removed.
- platform/chromium-linux/svg/custom/marker-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/chromium-linux/svg/custom/text-ctm-expected.png:
- platform/chromium-linux/svg/custom/text-hit-test-expected.png:
- platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- platform/chromium-linux/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
- platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac-leopard/svg/custom/getTransformToElement-expected.png:
- platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/getTransformToElement-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/gradient-stroke-width-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/repaint-on-image-bounds-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-forward-refs-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
- platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png: Removed.
- platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Removed.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Removed.
- platform/chromium-mac/svg/custom/pointer-events-text-expected.png: Removed.
- platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Removed.
- platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-font-face-crash-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-forward-refs-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/chromium-win/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/getTransformToElement-expected.png:
- platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
- platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
- platform/chromium-win/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
- platform/chromium-win/svg/custom/marker-changes-expected.png: Added.
- platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt:
- platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
- platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
- platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.txt:
- platform/chromium-win/svg/custom/text-hit-test-expected.png:
- platform/chromium-win/svg/custom/text-hit-test-expected.txt:
- platform/chromium-win/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Added.
- platform/chromium-win/svg/custom/use-forward-refs-expected.png:
- platform/chromium/svg/custom/js-update-style-expected.txt: Removed.
- platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/gtk/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/gtk/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/gtk/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/mac/svg/custom/absolute-root-position-masking-expected.png: Removed.
- platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/mac/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/mac/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/mac/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/mac/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/qt/svg/custom/absolute-root-position-masking-expected.png: Removed.
- platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/qt/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/qt/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/qt/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- svg/custom/absolute-root-position-masking-expected.png: Added.
- svg/custom/absolute-root-position-masking-expected.txt: Added.
- svg/custom/gradient-stroke-width-expected.txt: Added.
- svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
- svg/custom/repaint-on-image-bounds-change-expected.txt: Added.
- svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
- svg/custom/use-forward-refs-expected.txt: Added.
- svg/custom/use-invalid-style-expected.txt: Added.
- svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Added.
- 12:32 AM Changeset in webkit [107376] by
-
- 2 edits in trunk/LayoutTests
2012-02-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing.
- platform/chromium/test_expectations.txt:
- 12:21 AM Changeset in webkit [107375] by
-
- 31 edits8 adds5 deletes in trunk/LayoutTests
Update baselines for svg/batik. These baselines either look quite
similar to the previous baselines or look like improvements (e.g., text
masking seems to work now).
- platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
- platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt: Added.
- platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
- platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac-leopard/svg/batik/text/xmlSpace-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Added.
- platform/chromium-mac/svg/batik/filters: Removed.
- platform/chromium-mac/svg/batik/filters/feTile-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/textStyles-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/verticalText-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/xmlSpace-expected.png: Removed.
- platform/chromium-win-xp/svg/batik/masking: Removed.
- platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
- platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-win/svg/batik/text/textAnchor-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png:
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/batik/text/textLayout-expected.png:
- platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
- platform/chromium-win/svg/batik/text/textProperties-expected.png:
- platform/chromium-win/svg/batik/text/textProperties2-expected.png:
- platform/chromium-win/svg/batik/text/textStyles-expected.png:
- platform/chromium-win/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:05 AM Changeset in webkit [107374] by
-
- 3 edits in trunk/Tools
[GTK] EWS command-line option to run the tests
https://bugs.webkit.org/show_bug.cgi?id=78211
Reviewed by Adam Barth.
New --run-tests option (defaults to False) for the EWS commands.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.review_patch):
(ChromiumLinuxEWS):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):
- 12:05 AM Changeset in webkit [107373] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
https://bugs.webkit.org/show_bug.cgi?id=78254
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._reset):
Feb 9, 2012:
- 11:58 PM Changeset in webkit [107372] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening after r107289.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 11:55 PM Changeset in webkit [107371] by
-
- 19 edits in trunk/Source/WebCore
Unreviewed, rolling out r107368.
http://trac.webkit.org/changeset/107368
https://bugs.webkit.org/show_bug.cgi?id=78327
break GTK build
- bindings/scripts/CodeGeneratorCPP.pm:
(ShouldSkipType):
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
(GenerateFunction):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateCallWith):
(GenerateFunctionCallString):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj customArgsAndException:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(TestObjInternal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::assertCallback):
- page/Console.cpp:
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
- page/Console.h:
(Console):
- page/Console.idl:
- 11:55 PM Changeset in webkit [107370] by
-
- 12 edits13 adds15 deletes in trunk/LayoutTests
Update baselines for W3C-SVG-1.1-SE. These new baselines all appear to
be correct.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
- platform/chromium/test_expectations.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
- svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- 11:49 PM Changeset in webkit [107369] by
-
- 3 edits2 adds in trunk
Heap-buffer-overflow in WebCore::CSSParser::lex
https://bugs.webkit.org/show_bug.cgi?id=77402
Reviewed by Antti Koivisto.
Source/WebCore:
Comments should check only a single \0 terminator.
Test: fast/css/parsing-css-comment.html
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
LayoutTests:
Test various comment types.
- fast/css/parsing-css-comment-expected.txt: Added.
- fast/css/parsing-css-comment.html: Added.
- 11:38 PM Changeset in webkit [107368] by
-
- 19 edits in trunk/Source/WebCore
Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327
Reviewed by Adam Barth.
This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm: Modified to replace
[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateCallWith):
- bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):
- bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(SkipFunction):
(GenerateFunction):
- bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
(WebCore::V8Console::assertCallback):
- page/Console.cpp: Ditto.
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
- page/Console.h: Ditto.
(Console):
- bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- 11:09 PM Changeset in webkit [107367] by
-
- 5 edits in trunk/Source/WebCore
Dromaeo/dom-traverse.html should go fast
https://bugs.webkit.org/show_bug.cgi?id=78307
Reviewed by Eric Seidel.
This patch improves Dromaeo/dom-traverse.html by roughly 2.5% by
removing a branch. Previously, we null-checked the result of
V8DOMWrapper::getWrapper in a hot code path, but the only case where we
return a non-empty wrapper comes from a cold code path. By pushing the
null check into the cold codepath, we eliminate the branch from the
hot code path.
This patch also annotates the branches in the hot code path with their
likely outcome. I didn't measure a statistically significant
improvement with that aspect of the change, but it seems worthwhile.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::getExistingWrapperInline):
(WebCore):
(WebCore::V8DOMWrapper::getExistingWrapperSlow):
(WebCore::V8DOMWrapper::getWrapperSlow):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getExistingWrapper):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::getWrapper):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 11:07 PM Changeset in webkit [107366] by
-
- 8 edits in trunk/Source/WebCore
Convert Frame/FrameView to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78311
Reviewed by Eric Seidel.
No new tests, no new functionality.
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRectForLayer):
Pixel snap clip rects as all window coordinates and sizes are exposed as
integers.
- page/GestureTapHighlighter.cpp:
- page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
As the painting is done aligned on pixel boundaries we need to pixel snap
the view rect when checking if it intersects the objects paint rect.
- page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.
- page/win/FrameCGWin.cpp:
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
No-op implementation of pixelSnappedIntRect for now.
- 10:44 PM Changeset in webkit [107365] by
-
- 13 edits4 adds in trunk
Add WebSocket extension support
https://bugs.webkit.org/show_bug.cgi?id=78079
Source/WebCore:
This patch introduces WebSocketExtensionDispatcher class, which creates client's
Sec-WebSocket-Extensions header field and parses the server response.
This patch doesn't add any actual extension, so no changes in behavior.
Reviewed by Kent Tamura.
No new tests except for chromium port.
- CMakeLists.txt: Added WebSocketExtensionDispatcher.(cpp|h) and WebSocketExtensionProcessor.h.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocketExtensionDispatcher.cpp: Added.
(WebCore):
(ExtensionParser):
(WebCore::ExtensionParser::ExtensionParser):
(WebCore::ExtensionParser::currentToken):
(WebCore::ExtensionParser::finished):
(WebCore::ExtensionParser::parsedSuccessfully):
(WebCore::isTokenCharacter):
(WebCore::isSeparator):
(WebCore::ExtensionParser::skipSpaces):
(WebCore::ExtensionParser::consumeToken):
(WebCore::ExtensionParser::consumeQuotedString):
(WebCore::ExtensionParser::consumeQuotedStringOrToken):
(WebCore::ExtensionParser::consumeCharacter):
(WebCore::WebSocketExtensionDispatcher::reset):
(WebCore::WebSocketExtensionDispatcher::addProcessor):
(WebCore::WebSocketExtensionDispatcher::createHeaderValue):
(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
(WebCore::WebSocketExtensionDispatcher::failureReason):
- websockets/WebSocketExtensionDispatcher.h: Added.
(WebCore):
(WebSocketExtensionDispatcher):
(WebCore::WebSocketExtensionDispatcher::WebSocketExtensionDispatcher):
- websockets/WebSocketExtensionProcessor.h: Added.
(WebCore):
(WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::~WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::extensionToken):
(WebCore::WebSocketExtensionProcessor::failureReason):
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):
- websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage): Adds extension header value if exists.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::reset): Resets WebSocketExtensionDispatcher object.
(WebCore::WebSocketHandshake::serverHandshakeResponse): Removed.
(WebCore::WebSocketHandshake::addExtensionProcessor): Added.
(WebCore::WebSocketHandshake::readHTTPHeaders): Parses and checks every time Sec-WebSocket-Extensions header appears.
(WebCore::WebSocketHandshake::checkResponseHeaders): Removed the check of Sec-WebSocket-Extensions.
- websockets/WebSocketHandshake.h: Removed serverHandshakeResponse().
Source/WebKit/chromium:
Add some tests which check WebSocketExtensions::processHeaderValue()
parses the given response correctly.
Reviewed by Kent Tamura.
- WebKit.gypi:
- tests/WebSocketExtensionDispatcherTest.cpp: Added.
(WebCore):
(MockWebSocketExtensionProcessor):
(WebCore::MockWebSocketExtensionProcessor::MockWebSocketExtensionProcessor):
(WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::SetUp):
(WebCore::WebSocketExtensionDispatcherTest::TearDown):
(WebCore::WebSocketExtensionDispatcherTest::addMockProcessor):
(WebCore::WebSocketExtensionDispatcherTest::appendResult):
(WebCore::MockWebSocketExtensionProcessor::processResponse):
(WebCore::TEST_F):
LayoutTests:
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Rebaselined.
- 10:34 PM Changeset in webkit [107364] by
-
- 3 edits2 adds in trunk
Avoid compositing invisible fixed positioned elements
https://bugs.webkit.org/show_bug.cgi?id=78186
Reviewed by James Robinson.
Source/WebCore:
Test: compositing/layer-creation/fixed-position-out-of-view.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
- compositing/layer-creation/fixed-position-out-of-view.html: Added.
- 10:26 PM Changeset in webkit [107363] by
-
- 17 edits1 add1 delete in trunk/LayoutTests
[chromium] Update compositing test baselines for mock scrollbars
- platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-mac/compositing/direct-image-compositing-expected.png: Added.
- platform/chromium-mac/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
- platform/chromium-mac/compositing/masks/multiple-masks-expected.png:
- platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-mac/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-win/compositing/direct-image-compositing-expected.png:
- platform/chromium-win/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-win/compositing/iframes/iframe-copy-on-scroll-expected.png:
- platform/chromium-win/compositing/masks/multiple-masks-expected.png:
- platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-win/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-win/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium/test_expectations.txt:
- 10:23 PM Changeset in webkit [107362] by
-
- 5 edits in trunk/Source
Prevent attaching when inspecting the Web Inspector.
Source/WebCore:
Reviewed by Brian Weinstein.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow): Prevent attaching when the page is an inspector page.
Source/WebKit2:
Also adds some comments about keeping in sync with InspectorFrontendClientLocal::canAttachWindow
and why there are two implementations of the same function.
Reviewed by Brian Weinstein.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::canAttach): Prevent attaching when the page is an inspector page.
Added comments about InspectorFrontendClientLocal::canAttachWindow.
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy): Added comment about keeping in sync with InspectorFrontendClientLocal.
- 10:18 PM Changeset in webkit [107361] by
-
- 10 edits in trunk/Tools
Rename compare_text and compare_audio to make it clear that they're !=
https://bugs.webkit.org/show_bug.cgi?id=78301
Reviewed by Adam Barth.
I also removed the maybe_create_directory function which was redundant.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.set_up_run):
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter._make_output_directory):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.do_text_results_differ):
(Port.do_audio_results_differ):
(Port.diff_text):
(Port.driver_name):
(Port.skips_perf_test):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.do_text_results_differ):
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_do_text_results_differ):
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.init):
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.init):
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
(Rebaseliner._diff_baselines):
- 10:08 PM Changeset in webkit [107360] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Assertion failure minX <= maxX in Region.cpp
https://bugs.webkit.org/show_bug.cgi?id=78038
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-09
Reviewed by James Robinson.
Covered by existing tests (should make them stop asserting).
Clamp sizes for composited layers coming out of WebCore to make sure they are valid non-negative values.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):
- 9:59 PM Changeset in webkit [107359] by
-
- 2 edits in trunk/Source/WebKit2
Managed network proxy settings are not used in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=78288
<rdar://problem/9962116>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb: Allow reading managed preferences.
- 9:58 PM Changeset in webkit [107358] by
-
- 2 edits in trunk/Source/WebCore
Make WebGLRenderingContext::printWarningToConsole safer
https://bugs.webkit.org/show_bug.cgi?id=78284
Patch by Gregg Tavares <gman@google.com> on 2012-02-09
Reviewed by Kenneth Russell.
No new tests because no change in functionality.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
- 9:51 PM Changeset in webkit [107357] by
-
- 14 edits in trunk/Source
[chromium] Add support for starting page/scale animations on CC impl thread from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=77872
Reviewed by James Robinson.
Source/WebCore:
Added unit test.
Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.
- platform/CrossThreadCopier.h:
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startPageScaleAnimation):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.
- src/WebViewImpl.cpp:
(WebKit):
(WebKit::WebViewImpl::startPageScaleAnimation):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::beginTest):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::requestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::afterTest):
(WTF::TEST_F):
- 9:45 PM Changeset in webkit [107356] by
-
- 10 edits in trunk/Source/WebKit2
ASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL) loading a local file, if the WebProcess crashed
https://bugs.webkit.org/show_bug.cgi?id=70845
<rdar://problem/10269985>
Reviewed by Anders Carlsson.
This also fixes some case where WebProcess did not get a sandbox extension after a crash.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): We no longer need to pass a sandbox
extension here, we're now passing it at b/f navigation bottleneck.
(WebKit::WebPageProxy::reload): Pass a sandbox extension - reload may mean reloading an error
page after a crash, so WebProcess may no longer have the extension.
(WebKit::WebPageProxy::goForward): We no longer need to pass a sandbox extension here,
we're now passing it at b/f navigation bottleneck. Also, fixed a bug where we first null checked
a WebBackForwardListItem pointer, and then used it anyway.
(WebKit::WebPageProxy::goBack): Ditto.
(WebKit::WebPageProxy::goToBackForwardItem): Ditto.
(WebKit::WebPageProxy::backForwardGoToItem): This is the bottleneck. We get here both for UI
actions like pressing the Back button, and for window.history.go() navigations. JS navigations
previously didn't open up the sandbox. URLs in UI process b/f list are trusted, so it's
always OK to grant a sandbox extension if one of them is a file: one.
- UIProcess/WebPageProxy.h: backForwardGoToItem() now returns a sandbox extension handle.
- UIProcess/WebPageProxy.messages.in: Ditto.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): If a URL is in UI process b/f
list, then it has been already vetted as something the Web process knows about. No need to
crash if it actually attempts going there.
(WebKit::WebProcessProxy::didReceiveInvalidMessage): Removed a useless comment (we have tons
of fprintfs besides this one). Fixed log message syntax.
- UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData):
We no longer need to pass a sandbox extension here, we're now passing it at b/f navigation
bottleneck.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::goToItem):
We now get an extension here, when telling UI process that we're navigating to a b/f list item.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reload): Use the extension we're getting.
(WebKit::WebPage::goForward): Don't use one we're not getting.
(WebKit::WebPage::goBack): Ditto.
(WebKit::WebPage::goToBackForwardItem): Ditto.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem): Ditto.
- WebProcess/WebPage/WebPage.h: Adjusted signatures accordingly.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- 9:42 PM Changeset in webkit [107355] by
-
- 4 edits in trunk/Source/WebKit/mac
REGRESSION (r104885): Articles not displayed in Vienna RSS reader
https://bugs.webkit.org/show_bug.cgi?id=78280
<rdar://problem/10762545>
Reviewed by Oliver Hunt.
- Misc/WebNSURLExtras.h:
- Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]):
Added a method to create a URL from a path, similarly to what KURL used to do.
- WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
Use it in an API where a known regression occurred.
- 9:28 PM Changeset in webkit [107354] by
-
- 2 edits in trunk/LayoutTests
[Gtk] http/tests/workers/terminate-during-sync-operation.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=78270
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.
Skip a workers http test that utilizes not-yet-supported File System API.
- platform/gtk/Skipped:
- 9:23 PM Changeset in webkit [107353] by
-
- 2 edits in trunk/LayoutTests
[chromium] skip tests affected by deprecation of in-url identities.
https://bugs.webkit.org/show_bug.cgi?id=78259
Reviewed by Adam Barth.
- platform/chromium/test_expectations.txt:
- 9:02 PM Changeset in webkit [107352] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] TiledLayerChromium::protectVisibleTileTextures() should only protect the visible textures
https://bugs.webkit.org/show_bug.cgi?id=78249
Reviewed by James Robinson.
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectVisibleTileTextures):
- 8:33 PM Changeset in webkit [107351] by
-
- 9 edits in trunk
[GTK] Add DRT support for modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=53600
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add support for running modal dialogs.
A new signal is added to the WebKitWebView. When emitted, the web view
is requesting to be displayed as a modal dialog. If accepted, the
ChromeClient then establishes a loop that is run until the chrome is destroyed.
If denied, nothing is done.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
Tools:
Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
Most significantly, when creating a new web view in GtkLauncher, the window
of the web view opener is passed around. In DumpRenderTree, the window of
the main web view is always considered as the opener. This is required so
the modal dialog's toplevel can be made transient for the opener's toplevel.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewRunModalDialog):
(createWebView):
- GtkLauncher/main.c:
(createWebViewCb):
(runModalDialogCb):
(createBrowser):
(createWindow):
(main):
LayoutTests:
Unskip the passing modal dialogs tests and log the remaining skipped test.
- platform/gtk/Skipped:
- 8:30 PM Changeset in webkit [107350] by
-
- 7 edits in trunk
[Gtk] security/set-form-autocomplete-attribute.html fails
https://bugs.webkit.org/show_bug.cgi?id=78261
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a helper function to DumpRenderTreeSupportGtk, returning
whether or not an element does perform autocompletion.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Use the new helper in DumpRenderTreeSupportGtk to properly
test whether an element performs autocompletion.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::elementDoesAutoCompleteForElementWithId):
LayoutTests:
Unskip the newly-passing test
- platform/gtk/Skipped:
- 8:14 PM Changeset in webkit [107349] by
-
- 2 edits in trunk/LayoutTests
Unreviewed attempt to fix a test flakiness.
- editing/spelling/spelling-marker-description.html:
- 7:48 PM Changeset in webkit [107348] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate dead code in BytecodeGenerator::resolve()
https://bugs.webkit.org/show_bug.cgi?id=78242
Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
BytecodeGenerator::shouldOptimizeLocals() is only true for
FunctionCode, and thus cannot be true for GlobalCode.
- 7:45 PM Changeset in webkit [107347] by
-
- 3 edits in trunk/Source/WebCore
Add Node::isShadowElement() member function.
https://bugs.webkit.org/show_bug.cgi?id=78201
Reviewed by Dimitri Glazkov.
No tests. No change in behavior. An upcoming change requires this to detect HTMLShadowElement.
- dom/Node.h:
(Node):
(WebCore::Node::isShadowElement):
- html/shadow/HTMLShadowElement.h:
(WebCore::HTMLShadowElement::isShadowElement):
- 7:34 PM Changeset in webkit [107346] by
-
- 2 edits in trunk/Source/WebCore
CachedResourceLoader is destroyed before CSSFontSelector is destroyed
https://bugs.webkit.org/show_bug.cgi?id=77817
Reviewed by Adam Barth.
Explicitly clear style selector before destorying the cached resource loader.
No new tests but PerformanceTests/Parser/html5-full-render.html was crashing
on performance bots due to this bug.
- dom/Document.cpp:
(WebCore::Document::~Document):
- 7:14 PM Changeset in webkit [107345] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove BytecodeGenerator::isLocal
https://bugs.webkit.org/show_bug.cgi?id=78241
Minor refactor to BytecodeGenerator.
Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant): Remove now-unused
methods.
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure): Use the ResolveResult mechanism
instead of isLocal. This will recognize more resolve nodes as
being pure.
(JSC::PrefixResolveNode::emitBytecode): Use isReadOnly on the
location instead of isLocalConstant.
- 6:55 PM Changeset in webkit [107344] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream JavaScriptDebuggerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78203
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Added.
- 6:47 PM Changeset in webkit [107343] by
-
- 1 edit4 copies in branches/chromium/1025
Merge 106972
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9371041
- 6:45 PM Changeset in webkit [107342] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106715
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9374044
- 6:35 PM Changeset in webkit [107341] by
-
- 1 edit4 copies in branches/chromium/963
Merge 106972
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9375043
- 6:33 PM Changeset in webkit [107340] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed expectation followup for r107329
- platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium/test_expectations.txt:
- 6:32 PM Changeset in webkit [107339] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106715
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9374043
- 6:26 PM Changeset in webkit [107338] by
-
- 5 edits in trunk/Source/JavaScriptCore
The JS Parser scope object needs a VectorTrait specialization
https://bugs.webkit.org/show_bug.cgi?id=78308
Reviewed by Gavin Barraclough.
This showed up as a periodic crash in various bits of generated code
originally, but I've added an assertion in the bytecode generator
that makes the effected code much more crash-happy should it go
wrong again.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
- parser/Parser.cpp:
- parser/Parser.h:
(JSC):
- runtime/JSActivation.h:
(JSC::JSActivation::isValidScopedLookup):
(JSActivation):
- 6:19 PM Changeset in webkit [107337] by
-
- 3 edits in trunk
Perf-o-matic shouldn't rely on memcache to store cached JSON responses
https://bugs.webkit.org/show_bug.cgi?id=78306
Reviewed by Adam Barth.
Added PersistentCache model that stores the generated JSON responses.
- Websites/webkit-perf.appspot.com/controller.py:
(set_persistent_cache):
(set_persistent_cache.execute):
(get_persistent_cache):
(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):
- Websites/webkit-perf.appspot.com/models.py:
(TestResult):
(ReportLog):
(PersistentCache):
- 6:13 PM Changeset in webkit [107336] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106744
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9374042
- 6:10 PM Changeset in webkit [107335] by
-
- 13 edits in trunk/Source/WebCore
Update the scroll layer position on the main thread when we have slow repaint objects
https://bugs.webkit.org/show_bug.cgi?id=78300
<rdar://problem/10710754>
Reviewed by Dan Bernstein.
When we have slow repaint objects (background-attachment: fixed), we need to update the
scroll layer position on the main thread, otherwise the web page will appear to jiggle.
- page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
Call ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange if needed.
- page/FrameView.h:
(WebCore::FrameView::hasSlowRepaintObjects):
Add new getter.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
New function that will update both the main frame scroll position and the scroll layer position.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):
Dispatch a call to ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition on the main thread.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.
(WebCore::ScrollingTreeNode::update):
Set m_shouldUpdateScrollLayerPositionOnMainThread.
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
Update m_shouldUpdateScrollLayerPositionOnMainThread if needed.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Assert that we're not supposed to update the scroll layer position on the main thread.
(WebCore::ScrollingTreeNodeMac::scrollBy):
If we're supposed to update the scroll layer position on the main thread,
call ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
If the frame view has its scrolling coordinated by a scrolling coordinator, don't update the scroll layer position.
- 5:58 PM Changeset in webkit [107334] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106744
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9375041
- 5:57 PM Changeset in webkit [107333] by
-
- 2 edits6 copies in branches/chromium/963
Merge 106150
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9371039
- 5:54 PM Changeset in webkit [107332] by
-
- 2 edits in trunk/Source/WebCore
FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
https://bugs.webkit.org/show_bug.cgi?id=78291
Reviewed by Dan Bernstein.
m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
because otherwise useSlowRepaints() will return false even though we have to use slow repaints.
I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
called again after m_slowRepaintObjectCount has been incremented.
- page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
- 5:48 PM Changeset in webkit [107331] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106852
BUG=106336
Review URL: https://chromiumcodereview.appspot.com/9373051
- 5:47 PM Changeset in webkit [107330] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106852
BUG=106336
Review URL: https://chromiumcodereview.appspot.com/9371036
- 5:45 PM Changeset in webkit [107329] by
-
- 16 edits1 move1 add9 deletes in trunk
[chromium] Enable mock scrollbars for compositing layout tests
https://bugs.webkit.org/show_bug.cgi?id=78299
Reviewed by Dirk Pranke.
Tools:
This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
LayoutTests:
- platform/chromium-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
- platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png: Removed.
- platform/chromium-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
- platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
- platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
- platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
- platform/chromium-linux/compositing/overflow/scrollbar-painting-expected.png:
- platform/chromium-mac/compositing/geometry/tall-page-composited-expected.png: Removed.
- platform/chromium-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
- platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
- platform/chromium-win/compositing/geometry/tall-page-composited-expected.png: Removed.
- platform/chromium-win/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
- platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
- platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium/compositing/geometry/tall-page-composited-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/chromium/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/chromium/test_expectations.txt:
- 5:44 PM Changeset in webkit [107328] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/dom/Node.cpp
Merge 107123
BUG=112694
Review URL: https://chromiumcodereview.appspot.com/9372049
- 5:43 PM Changeset in webkit [107327] by
-
- 1 edit in branches/chromium/963/Source/WebCore/dom/Node.cpp
Merge 107123
BUG=112694
Review URL: https://chromiumcodereview.appspot.com/9375040
- 5:38 PM Changeset in webkit [107326] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106968
BUG=112847
Review URL: https://chromiumcodereview.appspot.com/9372048
- 5:36 PM Changeset in webkit [107325] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106968
BUG=112847
Review URL: https://chromiumcodereview.appspot.com/9375039
- 5:24 PM Changeset in webkit [107324] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106771
BUG=112735
Review URL: https://chromiumcodereview.appspot.com/9369055
- 5:24 PM Changeset in webkit [107323] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
Correcting remaining usage of enclosingIntRect in RenderLayer.cpp. These should all be pixel snapped.
- 5:23 PM Changeset in webkit [107322] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106771
BUG=112735
Review URL: https://chromiumcodereview.appspot.com/9369053
- 5:18 PM Changeset in webkit [107321] by
-
- 1 edit4 copies in branches/chromium/963
Merge 107023
BUG=111088
Review URL: https://chromiumcodereview.appspot.com/9371035
- 5:17 PM Changeset in webkit [107320] by
-
- 1 edit4 copies in branches/chromium/1025
Merge 107023
BUG=111088
Review URL: https://chromiumcodereview.appspot.com/9370044
- 5:17 PM Changeset in webkit [107319] by
-
- 4 edits in trunk/Source
Versioning.
- 5:16 PM Changeset in webkit [107318] by
-
- 1 edit in trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Quick fix for an omission from r107301 caught by jchaffraix
- 5:15 PM Changeset in webkit [107317] by
-
- 3 edits in trunk/Source/WebCore
Remove TreeOrderIterator and iterate over the child boxes directly.
https://bugs.webkit.org/show_bug.cgi?id=78294
Reviewed by Tony Chang.
No new tests. This is purely a refactor. No change in behavior.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
(FlexOrderHashTraits):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::isDeletedValue):
- 5:13 PM Changeset in webkit [107316] by
-
- 1 edit3 copies in branches/chromium/963
Merge 106818
BUG=111779
Review URL: https://chromiumcodereview.appspot.com/9371034
- 5:12 PM Changeset in webkit [107315] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 106818
BUG=111779
Review URL: https://chromiumcodereview.appspot.com/9374039
- 5:11 PM Changeset in webkit [107314] by
-
- 14 edits in trunk/Source/WebCore
Code generators should support multiple values for the [CallWith=] attribute
https://bugs.webkit.org/show_bug.cgi?id=78224
Reviewed by Adam Barth.
Currently we can specify only one value for one [CallWith=],
like [CallWith=ScriptExecutionContext] or [CallWith=ScriptState].
To reduce redundant IDL attributes, we are planning to support multiple
values for [CallWith=], like [CallWith=ScriptExecutionContext|ScriptArguments|CallStack].
This patch makes a change on code generators to support it.
Test: bindings/scripts/test/TestObj.idl
No change in WebKit behavior since IDL files have not yet used [CallWith=X|Y|Z].
- bindings/scripts/CodeGenerator.pm: Modified to support [CallWith=X|Y|Z].
(ExtendedAttributeContains):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateCallWith):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):
- bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=X|Y|Z].
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptState):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateObjException):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpaces):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptExecutionContextAndScriptStateAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpacesAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateWithSpacesAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptState]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateObjException]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpaces]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore):
- 5:09 PM Changeset in webkit [107313] by
-
- 1 copy in tags/Safari-535.20
New Tag.
- 4:56 PM Changeset in webkit [107312] by
-
- 40 edits in trunk/Source/WebCore
Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108
Reviewed by Adam Barth.
[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
(NativeToJSValue):
- bindings/scripts/test/TestObj.idl:
- css/CSSCharsetRule.idl:
- css/CSSImportRule.idl:
- css/CSSPageRule.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- css/WebKitCSSKeyframesRule.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/Clipboard.idl:
- dom/DOMStringList.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/MutationRecord.idl:
- dom/Node.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLMediaElement.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLRenderingContext.idl:
- page/DOMWindow.idl:
- storage/IDBObjectStore.idl:
- storage/IDBRequest.idl:
- storage/Storage.idl:
- storage/StorageEvent.idl:
- websockets/WebSocket.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- xml/XSLTProcessor.idl:
- 4:54 PM Changeset in webkit [107311] by
-
- 4 edits in branches/subpixellayout/Source/WebCore/rendering
Removing an unnecessary parameter from LayoutPainter and switching it to use pixelSnapped instead of enclosingIntRect. This fixes some unnecessary repaints.
- 4:42 PM Changeset in webkit [107310] by
-
- 3 edits in trunk/Source/WebCore
more refactoring of RenderFlexibleBox in preparation for multiline
https://bugs.webkit.org/show_bug.cgi?id=78281
Reviewed by Ojan Vafai.
Previously, we were creating Vector of each flex item's preferred size in document order,
but for multiline, we need to break the lines in the flex order. I just removed this code
since it was the wrong order.
Instead, have 2 funtions, computeMainAxisPreferredSizes which only does the necessary
layouts and margin computations to compute preferred sizes and computeFlexOrder which
does the work of computing the flex order, preferred sizes, positive/negative flex.
For multiline, we will have computeFlexOrder drive a while loop and it will return the
flex items, preferred size, and positive/negative flex values for each line.
No new tests, just refactoring.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Only layout auto sized children and set margins.
(WebCore::RenderFlexibleBox::computeFlexOrder): Compute flex order, preferred size, positive/negative flex.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::alignChildren): Use the precomputed flex order.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- 4:40 PM Changeset in webkit [107309] by
-
- 11 edits3 adds27 deletes in trunk/LayoutTests
Another unreviewed massive SVG rebaseline (all our windows bots that I missed).
- platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Removed.
- platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Removed.
- platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Removed.
- platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Removed.
- platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Removed.
- platform/chromium-linux/svg/custom/js-update-container-expected.txt: Removed.
- platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Removed.
- platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Removed.
- platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
- platform/chromium-linux/svg/custom/prevent-default-expected.png: Removed.
- platform/chromium-linux/svg/custom/prevent-default-expected.txt: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
- platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Removed.
- platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/repaint-stroke-width-changes-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
- platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Added.
- platform/chromium-win/svg/custom/animate-target-id-changed-expected.png:
- platform/chromium-win/svg/custom/animate-target-id-changed-expected.txt: Removed.
- platform/chromium-win/svg/custom/clip-path-href-changes-expected.png:
- platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/chromium-win/svg/custom/prevent-default-expected.png:
- platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png:
- platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
- platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
- platform/chromium/svg/custom/clip-path-href-changes-expected.txt: Removed.
- platform/chromium/svg/custom/fill-opacity-update-expected.txt: Removed.
- platform/chromium/svg/custom/js-update-container-expected.txt: Removed.
- platform/chromium/svg/custom/js-update-gradient-expected.txt: Removed.
- platform/chromium/svg/custom/marker-child-changes-expected.txt: Removed.
- platform/chromium/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
- platform/chromium/svg/custom/prevent-default-expected.txt: Removed.
- platform/chromium/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
- platform/chromium/svg/custom/stroke-opacity-update-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
Marked the really fishy rebaseline here.
- 4:36 PM Changeset in webkit [107308] by
-
- 3 edits3 copies in branches/safari-534.54-branch
Merged r106596.
- 4:36 PM Changeset in webkit [107307] by
-
- 2 edits in trunk/Source/WebKit2
HiDPI: WebKit2's drag images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779
Use the proper deviceScaleFactor() instead of accessing _intrinsicDeviceScaleFactor
Reviewed by Beth Dakin.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDragImage:at:linkDrag:]):
- 4:35 PM Changeset in webkit [107306] by
-
- 1 edit2 moves2 adds in trunk/LayoutTests
Split one MutationObserver layout test into two
https://bugs.webkit.org/show_bug.cgi?id=78285
Reviewed by Ojan Vafai.
Rather than a single non-event-delivery.html test,
created seperate tests for SQL database and FileSystem,
making it easy to skip them separately if the underlying
feature isn't supported by a particular platform.
- fast/mutation/database-callback-delivery-expected.txt: Added.
- fast/mutation/database-callback-delivery.html: Added.
- fast/mutation/filesystem-callback-delivery-expected.txt: Added.
- fast/mutation/filesystem-callback-delivery.html: Added.
- fast/mutation/non-event-delivery-expected.txt: Removed.
- fast/mutation/non-event-delivery.html: Removed.
- 4:31 PM Changeset in webkit [107305] by
-
- 5 edits in branches/subpixellayout/Source/WebCore
Remove unnecessary type conversions.
- 4:25 PM Changeset in webkit [107304] by
-
- 141 edits in trunk/Source/WebCore
Rename [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200
Reviewed by Adam Barth.
[Optional=CallWithDefaultValue] and [Optional=CallWithNullValue] are confusing.
- [Optional=CallWithDefaultValue] indicates that a missing value should be treated
as if the JavaScript undefined is passed.
- [Optional=CallWithNullValue] indicates that a missing value should be treated as
the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
- Actually, the difference between [Optional=CallWithDefaultValue] and
[Optional=CallWithNullValue] will appear only when the type of the missing value
is DOMString. In case of [Optional=CallWithDefaultValue], the missing value is
converted to the string "undefined". On the other hand, in case of
[Optional=CallWithNullValue], the missing value is converted to the WebKit null string.
With these observations, this patch renames as follows:
- Rename [Optional=CallWithDefaultValue] to [Optional=DefaultIsUndefined].
- Rename [Optional=CallWithNullValue] to [Optional=DefaultIsNullString].
Test: bindings/scripts/test/TestObj.idl
- bindings/js/JSDOMBinding.h: Renamed MissingIsEmpty to DefaultIsNullString,
renamed MissingIsUndefined to DefaultIsUndefined.
- bindings/v8/V8Binding.h: Ditto.
- bindings/v8/custom/V8BindingMacros.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Modified to support the renaming.
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
(RequiresCustomSignature):
- bindings/scripts/test/TestObj.idl: Renamed [Optional=...] as described above.
- bindings/scripts/test/TestInterface.idl: Ditto.
- bindings/scripts/test/TestNamedConstructor.idl: Ditto.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalStringIsUndefinedString):
(WebDOMTestObj::methodWithOptionalStringIsNullString):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined_string):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalStringIsUndefinedString:]):
(-[DOMTestObj methodWithOptionalStringIsNullString:]):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalStringIsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalStringIsNullStringCallback):
(WebCore):
- Modules/gamepad/GamepadList.idl: Renamed [Optional=...] as described above.
- Modules/intents/Intent.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- dom/CharacterData.idl:
- dom/ClientRectList.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringList.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/HashChangeEvent.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeList.idl:
- dom/OverflowEvent.idl:
- dom/Range.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- html/DOMFormData.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAudioElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/TextTrackCue.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- storage/IDBDatabase.idl:
- storage/StorageEvent.idl:
- svg/ElementTimeControl.idl:
- svg/SVGDocument.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGLocatable.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStylable.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- webaudio/AudioNode.idl:
- workers/SharedWorker.idl:
- workers/WorkerContext.idl:
- xml/DOMParser.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- 4:21 PM Changeset in webkit [107303] by
-
- 7 edits4 copies in branches/chromium/1025
Merge 106694
BUG=112151
Review URL: https://chromiumcodereview.appspot.com/9371032
- 4:09 PM Changeset in webkit [107302] by
-
- 28 edits in trunk/Tools
Remove more uses of "os" from our webkitpy code
https://bugs.webkit.org/show_bug.cgi?id=78292
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.init):
(MockCheckout.is_path_to_changelog):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem._split):
- Scripts/webkitpy/common/system/zipfileset_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/sheriff_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/rebaselineserver.py:
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
(CreateBug.prompt_for_bug_title_and_comment):
- Scripts/webkitpy/tool/servers/reflectionhandler.py:
- Scripts/webkitpy/tool/steps/attachtobug.py:
(AttachToBug.run):
- Scripts/webkitpy/tool/steps/checkstyle.py:
- Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
- Scripts/webkitpy/tool/steps/commit_unittest.py:
- Scripts/webkitpy/tool/steps/editchangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url):
- Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 4:05 PM Changeset in webkit [107301] by
-
- 3 edits2 adds in trunk
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230
Reviewed by Beth Dakin.
Source/WebCore:
Test: fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fillSizeToCSSValue): Pass down the RenderStyle for use in adjusting
values to account for zoom.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Adjust additional
properties that are affected by zoom.
LayoutTests:
- fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html: Added.
- 3:59 PM Changeset in webkit [107300] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 107046
BUG=113160
Review URL: https://chromiumcodereview.appspot.com/9370040
- 3:41 PM Changeset in webkit [107299] by
-
- 5 edits in trunk/Source/WebCore
Rename [Return] to [CustomReturn]
https://bugs.webkit.org/show_bug.cgi?id=78225
Reviewed by Adam Barth.
[Return] is used to handle custom code for a returned value.
To clarify it, this patch renames [Return] to [CustomReturn].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
- dom/Node.idl:
- 3:33 PM Changeset in webkit [107298] by
-
- 5 edits1 add3 deletes in trunk/LayoutTests
Unreviewed gardening.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced.
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
Updated those baseline for line-grid-snap to line-snap renaming.
- platform/chromium/test_expectations.txt:
Added another crasher following r107242.
- 3:09 PM Changeset in webkit [107297] by
-
- 4 edits in trunk/Tools
Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267
Reviewed by Adam Barth.
- QueueStatusServer/model/queues.py:
(Queue):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumWindowsEWS):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):
- 3:09 PM Changeset in webkit [107296] by
-
- 17 edits in trunk/Source/WebCore
Add roundedIntPoint method for LayoutPoints
https://bugs.webkit.org/show_bug.cgi?id=78262
Reviewed by Eric Seidel.
Adding a roundedIntPoint method that operates on a LayoutPoint. Currently, this does
nothing as LayoutPoint is a typedef to IntPoint. When we enable sub-pixel LayoutUnits,
this is a critical part in our pixel snapping strategy, where we round the logical top-
left point, then snap the right and bottom edges.
Also using this new method where we wish to convert LayoutPoints to IntPoints, which
we're currently doing implicitly (since they're the same thing).
No new tests. No change in functionality.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
- page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
- rendering/LayoutTypes.h:
(WebCore::roundedIntPoint):
(WebCore):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::getCursor):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::paintLayerContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintContents):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
- rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
- 3:06 PM Changeset in webkit [107295] by
-
- 3 edits1 move in trunk/LayoutTests
[chromium] Update baselines for compositing/iframes/iframe-content-flipping.html
- platform/chromium-mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/iframes/iframe-content-flipping-expected.png.
- platform/chromium-win/compositing/iframes/iframe-content-flipping-expected.png:
- platform/chromium/test_expectations.txt:
- 2:46 PM Changeset in webkit [107294] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebKitSupport WebPageCompositor class
https://bugs.webkit.org/show_bug.cgi?id=78276
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/WebPageCompositor.cpp: Added.
- blackberry/WebKitSupport/WebPageCompositor.h: Added.
- 2:33 PM Changeset in webkit [107293] by
-
- 3 edits in trunk/Tools
some tests in webkitpy are being run three times
https://bugs.webkit.org/show_bug.cgi?id=78283
Reviewed by Ryosuke Niwa.
It turns out that if you import a class derived from
unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
the unittest framework treats it as if the class was defined in
the file (as well in the original file). This led us to running
the tests in ChangeLogTest three times.
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
(_assert_message_for_revert_output):
- 2:19 PM Changeset in webkit [107292] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Merge trunk changes for xcode project file up until 107124.
- 2:18 PM Changeset in webkit [107291] by
-
- 8 edits in trunk/Source
[Chromium] Add chromium-style tracing support
https://bugs.webkit.org/show_bug.cgi?id=76885
Patch by John Bates <jbates@google.com> on 2012-02-09
Reviewed by Darin Fisher.
This code enables WebKit trace events to pass through more data to the
chromium platform tracing API and generally to use the full tracing
API provided by chromium.
Source/WebCore:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate): Replace old tracing API.
- page/Console.cpp:
(WebCore::Console::time): Replace old tracing API.
(WebCore::Console::timeEnd): Replace old tracing API.
- platform/chromium/PlatformSupport.h:
- platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceID::TraceID):
(WebCore::TraceEvent::TraceID::data):
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
(WebCore::TraceEvent::setTraceValue):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
(WebKit::WebKitPlatformSupport::addTraceEvent):
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
(WebCore::PlatformSupport::addTraceEvent):
- 2:17 PM Changeset in webkit [107290] by
-
- 8 edits in branches/subpixellayout/Source/WebKit/qt
Changed QWebElement::geometry to pixel snap values as opposed to returning a QRectF
- 1:59 PM Changeset in webkit [107289] by
-
- 23 edits3 adds3 deletes in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256
Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.
Reviewed by Dan Bernstein.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineSnap):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSnapAdjustment):
- rendering/RootInlineBox.h:
(RootInlineBox):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78256
Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.
Reviewed by Dan Bernstein.
- fast/line-grid/line-grid-contains-value.html:
- fast/line-grid/line-grid-floating.html:
- fast/line-grid/line-grid-inside-columns.html:
- fast/line-grid/line-grid-into-columns.html:
- fast/line-grid/line-grid-into-floats.html:
- fast/line-grid/line-grid-nested.html:
- fast/line-grid/line-grid-positioned.html:
- fast/line-grid/line-grid-snap-parsing.html: Removed.
- fast/line-grid/line-snap-parsing-expected.txt: Added.
- fast/line-grid/line-snap-parsing.html: Added.
- fast/line-grid/script-tests/line-grid-snap-parsing.js: Removed.
- fast/line-grid/script-tests/line-snap-parsing.js: Added.
- 1:47 PM Changeset in webkit [107288] by
-
- 3 edits in trunk/Source/WebCore
The localization of htmlSelectMultipleItems() needs better support of pluralization
https://bugs.webkit.org/show_bug.cgi?id=78197
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-09
Reviewed by Joseph Pecoraro.
For translation, the localization of 0 and 1 depends on the language.
- English.lproj/Localizable.strings:
- platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
- 1:40 PM Changeset in webkit [107287] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Plumb setNeedsRedraw.
https://bugs.webkit.org/show_bug.cgi?id=78248
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.
- public/platform/WebLayerTreeView.h:
(WebLayerTreeView):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit):
- 1:37 PM Changeset in webkit [107286] by
-
- 2 edits in trunk/Tools
Remove extraneous line in previous patch. I forgot to remove this
before landing.
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.start):
- 1:31 PM Changeset in webkit [107285] by
-
- 3 edits in trunk/Source/WebCore
ScrollingTreeNodeMac should implement ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=78277
Reviewed by Andreas Kling.
Add stubbed out implementations of the ScrollElasticityController member functions.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):
- 1:26 PM Changeset in webkit [107284] by
-
- 9 edits in trunk/Tools
run-perf-tests should have an option to pause before running tests so we can attach Instruments
https://bugs.webkit.org/show_bug.cgi?id=78271
Reviewed by Ryosuke Niwa.
This lets me attach instruments to profile the performance of the test.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.start):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.start):
(DriverProxy.start):
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.start):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.start):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.start):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(get_tests_run.RecordingTestDriver.start):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(start):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
- 1:23 PM Changeset in webkit [107283] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/WebCore.vcproj/WebCore.vcproj
Merged windows project file
- 1:20 PM Changeset in webkit [107282] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78258
Reviewed by James Robinson.
This isn't a problem currently, because scrollbar layers don't create
render surfaces. However, if this ever got used for other layers, we
could call reserve on them twice needlessly. It's also just bad form
to have an iterator doing the wrong thing.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::reserveTextures):
- 1:07 PM Changeset in webkit [107281] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed rebaseline, yet another small font difference.
- platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Added.
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Added.
- 1:02 PM Changeset in webkit [107280] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Allow reading some debug-only preference files
https://bugs.webkit.org/show_bug.cgi?id=78255
<rdar://problem/9382382>
<rdar://problem/10830558>
Reviewed by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb:
- 1:01 PM Changeset in webkit [107279] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r107261.
http://trac.webkit.org/changeset/107261
https://bugs.webkit.org/show_bug.cgi?id=78274
It has regressed svg/W3C-SVG-1.1/styling-css-05-b.svg (using
lang() selectors) (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):
- 12:49 PM Changeset in webkit [107278] by
-
- 3 edits2 adds in trunk
[Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=78167
Source/WebCore:
Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.
Reviewed by Adam Barth.
Test: storage/indexeddb/versionchangerequest-activedomobject.html
- storage/IDBVersionChangeRequest.idl:
LayoutTests:
Reviewed by Adam Barth.
- storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
- storage/indexeddb/versionchangerequest-activedomobject.html: Added.
- 12:44 PM Changeset in webkit [107277] by
-
- 6 edits in trunk/Source/WebCore
The scrolling tree should know more about the scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=78268
Reviewed by Andreas Kling.
With this change, the scroll tree now keeps track of the horizontal scroll elasticity,
the vertical scroll elasticity and whether the page has enabled scrollbars.
This is needed in order to make rubber-banding work correctly when doing fast scrolling.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollElasticity):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollElasticity):
(WebCore::ScrollingTreeState::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::setHasEnabledVerticalScrollbar):
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::horizontalScrollElasticity):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollElasticity):
(WebCore::ScrollingTreeState::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::hasEnabledVerticalScrollbar):
- 12:43 PM Changeset in webkit [107276] by
-
- 2 edits in branches/chromium/1025/Source/WebCore/rendering
Merge 107024 - Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033
Reviewed by James Robinson.
There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9369039
- 12:21 PM Changeset in webkit [107275] by
-
- 2 edits in trunk/Tools
run-perf-tests --chromium should run the chromium port
https://bugs.webkit.org/show_bug.cgi?id=78266
Reviewed by Ryosuke Niwa.
This patch makes run-perf-tests work more like run-webkit-tests.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- 12:20 PM Changeset in webkit [107274] by
-
- 9 edits1 add in trunk
Perf-o-matic should update memcache in taskqueue
https://bugs.webkit.org/show_bug.cgi?id=78209
Reviewed by Adam Barth.
Update dashboard, manifest, and runs memcaches in taskqueue.
Also centralized the management of caches in controller.py.
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/controller.py: Added.
(cache_manifest):
(schedule_manifest_update):
(CachedManifestHandler):
(CachedManifestHandler.get):
(cache_dashboard):
(schedule_dashboard_update):
(CachedDashboardHandler):
(CachedDashboardHandler.get):
(cache_runs):
(schedule_runs_update):
(CachedRunsHandler):
(CachedRunsHandler.get):
- Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler.post):
- Websites/webkit-perf.appspot.com/dashboard_handler.py:
(DashboardHandler.post):
- Websites/webkit-perf.appspot.com/main.py:
- Websites/webkit-perf.appspot.com/manifest_handler.py:
(ManifestHandler.post):
- Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.post):
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
- Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):
- 12:18 PM Changeset in webkit [107273] by
-
- 3 edits in trunk/Tools
[Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
https://bugs.webkit.org/show_bug.cgi?id=77466
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-09
Reviewed by Dirk Pranke.
Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
is set or if we should raise an error. A unit test was added.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.operating_system):
(QtPort):
(QtPort.check_sys_deps):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_operating_system):
(QtPortTest):
(QtPortTest.test_check_sys_deps):
- 12:11 PM Changeset in webkit [107272] by
-
- 3 edits in branches/subpixellayout/Source
Fix usage of LayoutUnit in GestureTapHighlighter and update QT port to use explicit subpixel to platform types conversion.
- 12:11 PM Changeset in webkit [107271] by
-
- 8 edits in trunk/Tools
Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
https://bugs.webkit.org/show_bug.cgi?id=78263
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.layout_tests_results_path):
(MacPort):
(WinPort):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(EflPort):
(EflPort.build_webkit_command):
(ChromiumPort):
(ChromiumPort.update_webkit_command):
(ChromiumPort.build_webkit_command):
(ChromiumPort.run_webkit_tests_command):
(ChromiumPort.run_javascriptcore_tests_command):
(ChromiumXVFBPort):
(ChromiumXVFBPort.run_webkit_tests_command):
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_xvfb_port):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.init):
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/main.py:
(WebKitPatch):
(WebKitPatch.handle_global_options):
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
- 12:04 PM Changeset in webkit [107270] by
-
- 2 edits in trunk/Source/WebCore
Unnecessary and incorrect invalidation about composited fixed-position layers
https://bugs.webkit.org/show_bug.cgi?id=75638
When a FrameView scrolls, composited fixed-position layers should
not contribute to the invalidation rect of the root layer.
Reviewed by Simon Fraser.
No new tests. Haven't found a good way to test this programatically.
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
- 11:56 AM Changeset in webkit [107269] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp
Fixing an overflow rect calculated in RenderListMarker to use pixelSnapped instead of enclosingIntRect.
- 11:44 AM Changeset in webkit [107268] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
Mark fast/workers/storage/interrupt-database.html as slow to see if it helps with the flakiness.
Mark a new animation test as flaky (already know issue in the animation testing framework).
- 11:35 AM Changeset in webkit [107267] by
-
- 3 edits in trunk/Source/WebKit2
HiDPI: WebKit2's link-dragging images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779
Reviewed by Beth Dakin.
Teach startDrag about the deviceScaleFactor so that it creates
an appropriately scaled bitmap image to ship over.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
(WebKit::convertImageToBitmap):
Have setDragImage assume that it's receiving a bitmap image scaled
up by the deviceScaleFactor that it sees.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDragImage:at:linkDrag:]):
- 11:16 AM Changeset in webkit [107266] by
-
- 9 edits1 copy in trunk
Unreviewed, rolling out r107035.
http://trac.webkit.org/changeset/107035
https://bugs.webkit.org/show_bug.cgi?id=78253
Regressed DOMDivWalk (Requested by arv on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09
Source/WebCore:
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp.
(WebCore):
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 11:15 AM Changeset in webkit [107265] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
isPointInResizeControl should not truncate LayoutUnits when determining its boundaries.
- 11:12 AM Changeset in webkit [107264] by
-
- 19 edits2 adds2 deletes in trunk/LayoutTests
Another unreviewed svg rebaselining after r107207.
- platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-late-clipPath-creation-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-content-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-inner-svg-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/chromium-mac-leopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-disappears-after-style-update-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/use-elementInstance-methods-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-event-handler-on-use-element-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
- 11:11 AM Changeset in webkit [107263] by
-
- 19 edits in trunk/Source/WebCore
MathML internals for bug 52444 fix - type checking, PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=78180
Patch by David Barton <Dave Barton> on 2012-02-09
Reviewed by Eric Seidel.
static_cast<Element*>(node()) is done in methods in RenderMathMLFenced.cpp and a few
other files. It is more type-safe if the RenderMathMLFenced() or other constructor only
accepts an Element*, not a Node*. Also a couple functions were changed to return a
PassRefPtr instead of a RefPtr.
No new tests.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::makeOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
- rendering/mathml/RenderMathMLFraction.h:
(RenderMathMLFraction):
- rendering/mathml/RenderMathMLMath.cpp:
(WebCore::RenderMathMLMath::RenderMathMLMath):
- rendering/mathml/RenderMathMLMath.h:
(RenderMathMLMath):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::layout):
- rendering/mathml/RenderMathMLRoot.h:
(RenderMathMLRoot):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
- rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
- rendering/mathml/RenderMathMLSquareRoot.h:
(RenderMathMLSquareRoot):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
- rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
- rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):
- 11:01 AM Changeset in webkit [107262] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Added.
New baseline (font issue).
- platform/chromium/test_expectations.txt:
Added 2 tests that started asserting on one bot.
- 10:56 AM Changeset in webkit [107261] by
-
- 2 edits in trunk/Source/WebCore
Avoid unnecessary work when evaluating style sharing candidates.
<http://webkit.org/b/78220>
Reviewed by Antti Koivisto.
Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding,
lang and xml:lang.) Moved comparison of "type" and "readonly" attributes into the more
specific canShareStyleWithControl() since they are only relevant for input elements.
Don't bother calling isFormControlElement() on both elements since we already know they
have the same tagQName().
Altogether this knocks off 8-9ms worth of samples per cycle of the "Moz" page cycler test.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):
- 10:38 AM Changeset in webkit [107260] by
-
- 5 edits2 adds in trunk/Source/WebKit/efl
[EFL] Introducing functions to set local storage db path and clear
those dbs.
https://bugs.webkit.org/show_bug.cgi?id=77107
This patch exposes the web local storage tracker database path
setting cabability, introduced on bug 77006, to the EFL port of
WebKit. Particularly, we have our own storage tracker client
object, to initialize the storage tracker backend on ewk_init().
Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-09
Reviewed by Kenneth Rohde Christiansen.
- CMakeListsEfl.txt:
- WebCoreSupport/StorageTrackerClientEfl.cpp: Added.
(WebCore):
(WebCore::StorageTrackerClientEfl::dispatchDidModifyOrigin):
(WebCore::StorageTrackerClientEfl::didFinishLoadingOrigins):
- WebCoreSupport/StorageTrackerClientEfl.h: Added.
(WebCore):
(StorageTrackerClientEfl):
- ewk/ewk_main.cpp:
(trackerClient):
(_ewk_init_body):
- ewk/ewk_settings.cpp:
(ewk_settings_local_storage_path_set):
(ewk_settings_local_storage_path_get):
(ewk_settings_local_storage_database_clear):
(ewk_settings_local_storage_database_origin_clear):
- ewk/ewk_settings.h:
- 10:27 AM Changeset in webkit [107259] by
-
- 7 edits in trunk
CSS3 calc() - remove mod
https://bugs.webkit.org/show_bug.cgi?id=78226
Source/WebCore:
mod has been removed from the spec for calc().
Reviewed by Ojan Vafai.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
- css/CSSGrammar.y:
- platform/CalculationValue.h:
LayoutTests:
Reviewed by Ojan Vafai.
- css3/calc/simple-calcs-expected.txt:
- css3/calc/simple-calcs.html:
- 9:59 AM WebKitGTK/1.6.x edited by
- (diff)
- 9:42 AM Changeset in webkit [107258] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing file for fast/events/scroll-event-during-modal-dialog.html
https://bugs.webkit.org/show_bug.cgi?id=78234
Reviewed by Mihai Parparita.
- fast/events/resources/scroll-event-modal-dialog.html: Added.
- 9:42 AM Changeset in webkit [107257] by
-
- 12 edits2 copies in trunk/Source/WebCore
Web Inspector: rename DOMEditor to DOMPatchSupport, move undoable actions from
InspectorDOMAgent to the new DOMEditor.
https://bugs.webkit.org/show_bug.cgi?id=78245
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/DOMEditor.cpp:
(DOMEditor::DOMAction):
(WebCore::DOMEditor::DOMAction::DOMAction):
(WebCore::DOMEditor::DOMAction::perform):
(WebCore::DOMEditor::DOMAction::undo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::undo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::perform):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::undo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(WebCore::DOMEditor::SetOuterHTMLAction::newNode):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::undo):
(WebCore::DOMEditor::DOMEditor):
(WebCore):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
- inspector/DOMEditor.h:
(WebCore):
(DOMEditor):
- inspector/DOMPatchSupport.cpp: Copied from Source/WebCore/inspector/DOMEditor.cpp.
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::~DOMPatchSupport):
(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::createDigest):
(WebCore::DOMPatchSupport::insertBefore):
(WebCore::DOMPatchSupport::removeChild):
(WebCore::DOMPatchSupport::markNodeAsUsed):
(WebCore::DOMPatchSupport::dumpMap):
- inspector/DOMPatchSupport.h: Copied from Source/WebCore/inspector/DOMEditor.h.
(DOMPatchSupport):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
- inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
- 9:31 AM Changeset in webkit [107256] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r104746): iframes load PDFs as media documents
<http://webkit.org/b/77079> / <rdar://problem/10757933>
Roll out r104746 since it completely broke support for loading PDF documents in subframes.
Reviewed by Adam Treat.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- 9:25 AM Changeset in webkit [107255] by
-
- 2 edits in trunk/Tools
[chromium] always initialize makeArgs in buildChromiumNinja
https://bugs.webkit.org/show_bug.cgi?id=78231
Reviewed by Tony Gentilcore.
- Scripts/webkitdirs.pm:
(buildChromiumNinja):
- 9:18 AM Changeset in webkit [107254] by
-
- 2 edits in trunk/Tools
[GTK] Show url of current hovered link in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78098
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewMouseTargetChanged): Check whether hit test result is a
link and use the url to update the status bar text.
(browserWindowConstructed): Connect to
WebKitWebView::mouse-target-changed signal.
- 9:11 AM Changeset in webkit [107253] by
-
- 3 edits in trunk/LayoutTests
2012-02-09 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, gardening, more svg fixes.
Mark svg/custom/absolute-sized-content-with-resources.xhtml as IMAGE+TEXT and
rebaseline svg/carto.net/slider-expected.png.
- platform/chromium-linux/svg/carto.net/slider-expected.png:
- platform/chromium/test_expectations.txt:
- 9:09 AM Changeset in webkit [107252] by
-
- 2 edits in trunk/Source/WebKit/gtk
Build fix for GTK+ 2.x after my previous commit.
- webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): The name of the event is expose_event and not expose.
- 8:53 AM Changeset in webkit [107251] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [refactoring] take _showShortEvents out of timeline calculator
https://bugs.webkit.org/show_bug.cgi?id=78230
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._addToRecordsWindow):
- 8:51 AM Changeset in webkit [107250] by
-
- 17 edits2 copies2 adds in trunk
[GTK] Add WebKitWebView::mouse-target-changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=78097
Reviewed by Martin Robinson.
.:
- Source/autotools/symbols.filter: Add freeOwnedGPtr<_GdkEvent>
symbol to be able to use GOwnPtr<GdkEvent> in WebKit2 GTK+ unit
tests.
Source/WebKit2:
- GNUmakefile.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitHitTestResult.cpp: Added.
(webkitHitTestResultFinalize):
(webkitHitTestResultGetProperty):
(webkitHitTestResultSetProperty):
(webkit_hit_test_result_init):
(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate): Create a new WebKitHitTestResult for
the given WKHitTestResult.
(stringIsEqualToCString): Helper function to compare String and
CString considering String::isEmpty() == CString.isNull().
(webkitHitTestResultCompare): Helper function to check whether a
WebKitHitTestResult contains the same information than the given
WKHitTestResult.
(webkit_hit_test_result_get_context):
(webkit_hit_test_result_context_is_link):
(webkit_hit_test_result_context_is_image):
(webkit_hit_test_result_context_is_media):
(webkit_hit_test_result_get_link_uri):
(webkit_hit_test_result_get_link_title):
(webkit_hit_test_result_get_link_label):
(webkit_hit_test_result_get_image_uri):
(webkit_hit_test_result_get_media_uri):
- UIProcess/API/gtk/WebKitHitTestResult.h: Added.
- UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
(webkitNavigationPolicyDecisionCreate): Use
wkEventModifiersToGdkModifiers.
- UIProcess/API/gtk/WebKitPrivate.cpp:
(wkEventModifiersToGdkModifiers): Moved from
WebKitNavigationPolicyDecision and renamed to wkEventModifiersToGdkModifiers.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitUIClient.cpp:
(mouseDidMoveOverElement): UI client callback that calls
webkitWebViewMouseTargetChanged().
(attachUIClientToView): Add implementation for callback
mouseDidMoveOverElement.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add
WebKitWebView::mouse-target-changed signal.
(webkitWebViewMouseTargetChanged): Emit
WebKitWebView::mouse-target-changed signal.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitHitTestResult.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget):
(beforeAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::WebViewTest):
(WebViewTest::~WebViewTest):
(parentWindowMapped):
(WebViewTest::showInWindowAndWaitUntilMapped): Method to add the
view into a popup window and show it running the main loop until
the window is mapped.
(WebViewTest::mouseMoveTo): Method to synthesize a
GDK_MOTION_EVENT on the given coordinates and using the given
modifiers.
- UIProcess/API/gtk/tests/WebViewTest.h:
- UIProcess/API/gtk/webkit2.h: Include WebKitHitTestResult.h.
- UIProcess/API/gtk/webkit2marshal.list:
- 8:38 AM Changeset in webkit [107249] by
-
- 6 edits in trunk/Source
[GTK] Embedded GtkWidgets are not drawn
https://bugs.webkit.org/show_bug.cgi?id=63451
Source/WebCore:
Remove widget from it's parent container when GtkPluginWidget is destroyed.
Remove paint() method because real expose even is used for drawing child widgets now.
Patch by Dan Vrátil <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.
- platform/gtk/GtkPluginWidget.cpp:
(WebCore::GtkPluginWidget::~GtkPluginWidget):
(WebCore):
- platform/gtk/GtkPluginWidget.h:
(GtkPluginWidget):
Source/WebKit/gtk:
Insert plugin widgets to WebKitWebView container as it's children.
Chain up to parent in webkit_web_view_draw() to ensure the child widgets are drawn.
Patch by Dan Vrátil <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createPlugin):
- webkit/webkitwebview.cpp:
(webkit_web_view_draw):
- 8:25 AM Changeset in webkit [107248] by
-
- 13 edits2 copies21 adds17 deletes in trunk/LayoutTests
2012-02-09 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, update chromium svg expectations after r107207.
- platform/chromium-linux-x86/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
- platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Added.
- platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Added.
- platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Added.
- platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Added.
- platform/chromium-linux/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/chromium-linux/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
- platform/chromium-linux/svg/custom/glyph-selection-non-bmp-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
- platform/chromium-linux/svg/custom/hit-test-with-br-expected.png:
- platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
- platform/chromium-linux/svg/custom/js-update-container-expected.txt: Added.
- platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Added.
- platform/chromium-linux/svg/custom/js-update-style-expected.txt: Added.
- platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Added.
- platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
- platform/chromium-linux/svg/custom/prevent-default-expected.png: Added.
- platform/chromium-linux/svg/custom/prevent-default-expected.txt: Added.
- platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png:
- platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
- platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Added.
- platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
- platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Added.
- platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/clip-path-href-changes-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/fill-opacity-update-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png:
- platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png:
- platform/chromium-mac-leopard/svg/custom/hit-test-with-br-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/js-update-container-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/js-update-gradient-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/js-update-style-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/marker-child-changes-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/prevent-default-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/stroke-opacity-update-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png:
- platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png:
- platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- platform/chromium-win/svg/custom/hit-test-with-br-expected.png:
- platform/chromium-win/svg/custom/hit-test-with-br-expected.txt:
- 8:12 AM Changeset in webkit [107247] by
-
- 1 edit5 adds in trunk/Tools
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042
Reviewed by Antonio Gomes.
Upstream final part of our DRT implementation.
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
- DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
- DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
- 8:00 AM Changeset in webkit [107246] by
-
- 2 edits2 adds204 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0/fast/images/embed-image-expected.txt: Add after Qt5 update.
- platform/qt-wk2/ [...] .png: Remove obsolete png files.
- platform/qt/Skipped: Skip new tests without expected files.
- 7:53 AM Changeset in webkit [107245] by
-
- 5 edits in trunk/LayoutTests
update CSS3 calc() color tests to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=77596
Note that these tests are intended to 'fail' as calc() functionality
had not yet landed (see http://webkit.org/b/16662)
Reviewed by Kent Tamura.
- css3/calc/color-hsl-expected.txt:
- css3/calc/color-hsl.html:
- css3/calc/color-rgb-expected.txt:
- css3/calc/color-rgb.html:
- 7:49 AM Changeset in webkit [107244] by
-
- 6 edits2 adds in trunk
Setting media element 'src' attribute to "" should trigger load
https://bugs.webkit.org/show_bug.cgi?id=47907
Patch by Arun Patole <arun.patole@motorola.com> on 2012-02-09
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-src-empty.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):Trigger a load, as long as the 'src' attribute is present.
LayoutTests:
- media/video-src-empty-expected.txt: Added, test for <video> with empty src.
- media/video-src-empty.html: Added.
- media/video-src-none-expected.txt:
- media/video-src-none.html: removed "empty src" test as it is handled in separate test: video-src-empty.html.
- platform/chromium/test_expectations.txt: media/video-empty-source.html needs a rebaseline.
- 7:40 AM Changeset in webkit [107243] by
-
- 11 edits in trunk/Source
[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setFullRootLayerDamageOnImplThread):
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 7:26 AM Changeset in webkit [107242] by
-
- 8 edits in trunk
Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
https://bugs.webkit.org/show_bug.cgi?id=78235
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):
- inspector/DOMEditor.h:
(DOMEditor):
LayoutTests:
- inspector/elements/set-outer-html-2-expected.txt:
- inspector/elements/set-outer-html-2.html:
- inspector/elements/set-outer-html-expected.txt:
- inspector/elements/set-outer-html.html:
- 7:23 AM Changeset in webkit [107241] by
-
- 162 edits38 copies61 moves41 adds97 deletes in trunk/LayoutTests
2012-02-09 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, update chromium svg expectations after r107207.
- 400 platform/chromium*/svg/custom/* files
- 7:05 AM Changeset in webkit [107240] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac] Skip new failing tests to paint the bot green.
- platform/qt-mac/Skipped:
- 6:49 AM Changeset in webkit [107239] by
-
- 36 edits4 adds in trunk
Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733
ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.
All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.
Test: fast/events/suspend-timers.html
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::create):
- bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):
- dom/ActiveDOMObject.h:
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::DocumentEventQueue):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):
- fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::create):
- fileapi/FileReader.cpp:
(WebCore::FileReader::create):
- fileapi/FileReader.h:
- fileapi/FileWriter.cpp:
(WebCore::FileWriter::create):
- fileapi/FileWriter.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::create):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::create):
- notifications/Notification.cpp:
(WebCore::Notification::create):
- notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::create):
- notifications/NotificationCenter.h:
- page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
- page/EventSource.cpp:
(WebCore::EventSource::create):
- page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
- storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::create):
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
(WebCore::AudioContext::createOfflineContext):
- websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
- websockets/WebSocket.h:
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/Worker.cpp:
(WebCore::Worker::create):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.
- fast/events/resources/suspend-subframe-1.html: Added.
- fast/events/resources/suspend-subframe-2.html: Added.
- fast/events/suspend-timers-expected.txt: Added.
- fast/events/suspend-timers.html: Added.
- platform/chromium/test_expectations.txt:
- 6:45 AM Changeset in webkit [107238] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed followup for r107235.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):
- 6:40 AM Changeset in webkit [107237] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer.
https://bugs.webkit.org/show_bug.cgi?id=78009
Reviewed by Noam Rosenthal.
Since WebGraphicsLayers are now accessed directly from LayerTreeHost, they don't
need to keep the visible rect to pass it down their child layers anymore.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::registerLayer):
(WebKit::LayerTreeHostQt::visibleContentsRect):
(WebKit):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 6:38 AM Changeset in webkit [107236] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=78005
Reviewed by Noam Rosenthal.
This makes sure that no empty tiles are generated for layers without contents and that
no interaction is made with the TiledBackingStore until we got a WebGraphicsLayerClient.
- Create the main TiledBackingStore only when the layer has drawsContent and has no directly composited image
- Removed recreateBackingStoreIfNeeded and do the (re)creation of the backing stores in updateContentBuffers
- Call purgeBackingStores on registered layers instead of passing it down the layer tree
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit):
(WebKit::LayerTreeHostQt::purgeBackingStores):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 6:37 AM Changeset in webkit [107235] by
-
- 14 edits3 adds in trunk/Source/WebCore
Web Inspector: Support hiding scripts panel debug sidebar.
https://bugs.webkit.org/show_bug.cgi?id=77543
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.DialogDelegate.prototype.show):
- inspector/front-end/Images/navigatorPinButton.png: Added.
- inspector/front-end/Images/navigatorShowHideButton.png: Added.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get view):
(WebInspector.ScriptsNavigator.prototype.get element):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.focus):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createNavigatorControls):
(WebInspector.ScriptsPanel.prototype._createNavigatorControlButton):
(WebInspector.ScriptsPanel.prototype._toggleNavigator):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):
- inspector/front-end/SidebarOverlay.js: Added.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype.get resizable):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.hideSidebarElement):
(WebInspector.SplitView.prototype.showSidebarElement):
(WebInspector.SplitView.prototype._resizerDragging):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get element):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/dialog.css:
- inspector/front-end/inspector.html:
- inspector/front-end/scriptsPanel.css:
- 6:35 AM Changeset in webkit [107234] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Remove WebGraphicsLayer::updateTileBuffersRecursively
https://bugs.webkit.org/show_bug.cgi?id=78105
Reviewed by Kenneth Rohde Christiansen.
The method is unused.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayer):
- 6:33 AM Changeset in webkit [107233] by
-
- 5 edits in trunk/Source/WebKit2
[Qt] Register individual WebGraphicsLayers to LayerTreeHost instead of handling the tree as a whole.
https://bugs.webkit.org/show_bug.cgi?id=77976
Reviewed by Kenneth Rohde Christiansen.
The LayerTreeHost association had to be maintained between re-parented layers and it would be
impossible to know if the layer would be disconnected from the LayerTreeHost only for reparenting
or disconnected for good (in other words, that the LayerTreeHost could be deleted meanwhile).
Instead, this patch assumes that graphics layers will only be in contact with one instance of
LayerTreeHost, and that this association can be kept until either the graphics layer or the layer
tree host gets deleted.
The registered layers are kept in a set and the visible rect and scales are passed directly
to layers instead of down the tree, through the root layer.
This also fixes the !m_layerInfo.imageBackingStoreID ASSERT that was popping in unit tests.
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectAndScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebCore):
(WebGraphicsLayerClient):
(WebGraphicsLayer):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::attachLayer):
(WebKit):
(WebKit::LayerTreeHostQt::detachLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 6:31 AM Changeset in webkit [107232] by
-
- 12 edits2 adds in trunk/Source/WebKit2
[Qt][WK2] WebView should use Flickable instead of QScroller to handle positioning
https://bugs.webkit.org/show_bug.cgi?id=76275
Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.
The current WebView implementation uses QScroller to manage positioning but other
similar items in QML (ie. ListView, GridView) use Flickable as their base class.
Since QScroller will be dropped from Qt5 this patch removes the QScroller code
and redirects pan gestures to a dynamically created encapsulated Flickable instance
(QtFlickProvider) which handles the positioning.
This implementation only uses public QML API and does not depend on declarative-private.
It propagates a small subset of the Flickable API as the public API of the WebView.
This minimalistic API is accessible via the experimental extension and makes it possible
in QML to place additional items (such as toolbars, scroll indicators and floating menus)
aroud the page.
These items can use anchoring and binding for positioning on the flickable contentItem.
The patch depends however on the automatic touch->mouse event synthetization of Qt5.
The touch events sent to the flickProvider are translated to mouse events automatically
as long as the Flickable does not handle touch events directly.
After this change QtWebKit2 does no longer depend on QtWidgets and this dependency can be
removed in a follow-up patch.
- Target.pri: Added QtFlickProvider source.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::flickableData):
(QQuickWebViewExperimental::contentItem):
(QQuickWebViewExperimental::contentWidth):
(QQuickWebViewExperimental::setContentWidth):
(QQuickWebViewExperimental::contentHeight):
(QQuickWebViewExperimental::setContentHeight):
(QQuickWebViewExperimental::contentX):
(QQuickWebViewExperimental::setContentX):
(QQuickWebViewExperimental::contentY):
(QQuickWebViewExperimental::setContentY):
(QQuickWebView::pageItemPos):
(QQuickWebView::updateContentsSize):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate):
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):
- UIProcess/qt/QtFlickProvider.cpp: Added.
(QtFlickProvider::QtFlickProvider):
(QtFlickProvider::handleTouchFlickEvent):
(QtFlickProvider::contentItem):
(QtFlickProvider::flickableData):
(QtFlickProvider::contentPos):
(QtFlickProvider::setContentPos):
(QtFlickProvider::viewportSize):
(QtFlickProvider::setViewportSize):
(QtFlickProvider::returnToBounds):
(QtFlickProvider::cancelFlick):
(QtFlickProvider::isMoving):
(QtFlickProvider::isDragging):
(QtFlickProvider::isFlicking):
(QtFlickProvider::contentWidth):
(QtFlickProvider::setContentWidth):
(QtFlickProvider::contentHeight):
(QtFlickProvider::setContentHeight):
(QtFlickProvider::contentX):
(QtFlickProvider::setContentX):
(QtFlickProvider::contentY):
(QtFlickProvider::setContentY):
- UIProcess/qt/QtFlickProvider.h: Added.
(QtFlickProvider):
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
- UIProcess/qt/QtPanGestureRecognizer.h:
(QtPanGestureRecognizer):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::doneWithTouchEvent):
- 6:26 AM Changeset in webkit [107231] by
-
- 2 edits in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Update expectations. svg/custom/nested-embedded-svg-size-changes.html no longer timeouts.
- platform/chromium/test_expectations.txt:
- 5:58 AM Changeset in webkit [107230] by
-
- 2 edits in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Make the hit-test-with-br.xhtml work on non-Mac platforms.
it was skipped on Chromium Win/Linux before, as the click on the <rect> never suceeeded.
On Mac the coordinate 10x70, was the upper left corner of the rectangle, so if the font
size is just slightly larger, or the size of the <br/>, then we failed to fire the click
event - so just click at 50x80, to be on the safe side.
- svg/custom/hit-test-with-br.xhtml:
- 5:53 AM Changeset in webkit [107229] by
-
- 7 edits in branches/chromium/1025/Source/WebCore
Merge 106662 - inspector/debugger/pause-in-inline-script.html asserts in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=77663
Source/WebCore:
Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.
Reviewed by Pavel Feldman.
Test: inspector/debugger/pause-in-inline-script.html
- bindings/js/ScriptDebugServer.h:
(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):
- bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didFinishLoading):
LayoutTests:
Reviewed by Pavel Feldman.
- platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html
TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9375012
- 5:46 AM Changeset in webkit [107228] by
-
- 4 edits2 copies in branches/chromium/1025
Merge 106468 - Web Inspector: debugger reports wrong sources when paused in inline script on page reload
https://bugs.webkit.org/show_bug.cgi?id=77548
Source/WebCore:
V8 returns treats each script source as ending with \n, now we take
this into account when reporting script line count to the inspector
front-end.
Reviewed by Vsevolod Vlasov.
Test: inspector/debugger/pause-in-inline-script.html
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
- bindings/v8/DebuggerScript.js:
LayoutTests:
Reviewed by Vsevolod Vlasov.
- inspector/debugger/debugger-scripts-expected.txt:
- inspector/debugger/pause-in-inline-script-expected.txt: Added.
- inspector/debugger/pause-in-inline-script.html: Added.
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9371015
- 5:39 AM Changeset in webkit [107227] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183
Reviewed by Zoltan Herczeg.
Another attempt at fixing svg/as-object/nested-embedded-svg-size-changes.html,
by guessing from the JS trace, where it might happened.
- svg/as-object/nested-embedded-svg-size-changes.html:
- 5:37 AM Changeset in webkit [107226] by
-
- 2 edits in trunk/LayoutTests
LayoutTests/fast/harness/resources/modal-dialog.html is missing the opening html tag
https://bugs.webkit.org/show_bug.cgi?id=78217
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Andreas Kling.
Add the missing opening <html> tag.
- fast/harness/resources/modal-dialog.html:
- 5:23 AM Changeset in webkit [107225] by
-
- 7 edits in trunk
Source/WebCore: Web Inspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):
- inspector/front-end/UIUtils.js:
(Number.withThousandsSeparator):
- inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid span.percent-column):
LayoutTests: WebInspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.
- inspector/profiler/detailed-heapshots-test.js:
- 5:14 AM Changeset in webkit [107224] by
-
- 2 edits in trunk/LayoutTests
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396
Unreviewed gardening, skip svg/animations/animate-color-fill-from-by.html because of this bug.
- platform/wk2/Skipped:
- 5:04 AM Changeset in webkit [107223] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222
Reviewed by Pavel Feldman.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
- inspector/front-end/timelinePanel.css:
(.memory-graph-label):
(.max.memory-graph-label):
(.min.memory-graph-label):
- 4:55 AM Changeset in webkit [107222] by
-
- 1 edit6 moves3 adds in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Move platform dependant results where they belong, and add Qt specific ones.
- platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.png.
- platform/mac/svg/custom/glyph-selection-arabic-forms-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.txt.
- platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.png.
- platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.txt.
- platform/mac/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.png.
- platform/mac/svg/custom/glyph-selection-non-bmp-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.txt.
- platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- 4:50 AM Changeset in webkit [107221] by
-
- 6 edits in trunk/Source/WebKit/qt
[Qt] Fix compilation with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=77653
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-09
Reviewed by Tor Arne Vestbø.
- Api/qgraphicswebview.cpp: Removed unnecessary inclusion of removed header file.
- declarative/public.pri: Use quick1 instead of qtquick1. It's mandator with Qt 5.
- tests/tests.pri: Ditto.
- declarative/qdeclarativewebview_p.h: Fix includes, just use the module-less
version that works with all Qt versions.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Ditto.
- 4:41 AM Changeset in webkit [107220] by
-
- 13 edits in trunk
Web Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style declarations)
https://bugs.webkit.org/show_bug.cgi?id=77962
Reviewed by Pavel Feldman.
Source/WebCore:
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):
LayoutTests:
- inspector/elements/elements-panel-styles-expected.txt:
- inspector/styles/styles-computed-trace-expected.txt:
- inspector/styles/styles-new-API-expected.txt:
- inspector/styles/styles-new-API.html:
- 4:33 AM Changeset in webkit [107219] by
-
- 2 edits1 add in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing Mac/Lion result.
- platform/mac/svg/carto.net/scrollbar-expected.png: Added.
- svg/custom/glyph-selection-bidi-mirror-expected.txt:
- 4:26 AM Changeset in webkit [107218] by
-
- 2 edits in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115
Not reviewed. Fix last minute typo, in nested-embedded-svg-size-changes.html, that may lead to flakiness.
- svg/as-object/nested-embedded-svg-size-changes.html:
- 4:24 AM Changeset in webkit [107217] by
-
- 10 edits in trunk
Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up / Down.
https://bugs.webkit.org/show_bug.cgi?id=78123
Reviewed by Yury Semikhatsky.
Source/WebCore:
- English.lproj/localizedStrings.js:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._registerShortcuts):
(WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondragstart):
(WebInspector.ElementsTreeOutline.prototype._ondragover):
(WebInspector.ElementsTreeOutline.prototype._doMove):
(WebInspector.ElementsTreeOutline.prototype._ondragend):
(WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeOutline.prototype._toggleEditAsHTML):
(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
- inspector/front-end/UIUtils.js:
LayoutTests:
- inspector/elements/move-node.html:
- inspector/elements/undo-dom-edits-expected.txt:
- inspector/elements/undo-dom-edits.html:
- 4:02 AM Changeset in webkit [107216] by
-
- 11 edits in trunk/LayoutTests
2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline some Qt svg results.
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
- platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
- platform/qt/svg/custom/js-update-bounce-expected.txt:
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
- platform/qt/svg/custom/js-update-style-expected.txt:
- platform/qt/svg/custom/mask-invalidation-expected.txt:
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/qt/svg/custom/use-clipped-hit-expected.txt:
- 3:58 AM Changeset in webkit [107215] by
-
- 2 edits1 move in trunk/LayoutTests
Unreviewed test expectation update.
- platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/layout-width-change-expected.png.
- 3:56 AM Changeset in webkit [107214] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525
Added 'SelectorCheckingContext' struct to hold parameters for the function.
Adapted calling sites.
(fixing change log after the commit message got bungled up).
Reviewed by Antti Koivisto.
No new tests. (refactoring)
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
- css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): (WebCore): (WebCore::SelectorChecker::checkOneSelector):
- css/SelectorChecker.h: (SelectorCheckingContext): (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): (SelectorChecker):
- 3:44 AM Changeset in webkit [107213] by
-
- 4 edits in trunk/LayoutTests
[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78026
[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183
Reviewed by Andreas Kling.
Rework testcases, to wait for the embedded SVG of the embedded HTML that we're loading.
Should fix the flakiness for both Qt/Chromium.
- platform/qt/Skipped: Unskip test.
- svg/as-object/nested-embedded-svg-size-changes.html: Wait for the embedded SVG to load, before trying to access it.
- svg/as-object/resources/nested-embedded-svg-size-changes-target.html:
- 3:44 AM Changeset in webkit [107212] by
-
- 4 edits in trunk/Source/WebCore
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067
Patch by Philip Rogers <pdr@google.com> on 2012-02-09
Reviewed by Nikolas Zimmermann.
SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.
Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.
Tests: svg/custom/glyph-selection-arabic-forms.svg
svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg
- platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):
- svg/SVGFontData.h:
(SVGFontData):
- 3:40 AM Changeset in webkit [107211] by
-
- 7 edits9 adds in trunk
2012-02-09 Philip Rogers <pdr@google.com>
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067
Reviewed by Nikolas Zimmermann.
SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.
Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.
- platform/gtk/test_expectations.txt:
- platform/win/test_expectations.txt:
- svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
- svg/custom/glyph-selection-arabic-forms.svg: Added.
- svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
- svg/custom/glyph-selection-bidi-mirror.svg: Added.
- svg/custom/glyph-selection-non-bmp-expected.png: Added.
- svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- svg/custom/glyph-selection-non-bmp.svg: Added.
2012-02-09 Philip Rogers <pdr@google.com>
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067
Reviewed by Nikolas Zimmermann.
SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.
Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.
Tests: svg/custom/glyph-selection-arabic-forms.svg
svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg
- platform/graphics/SVGGlyph.cpp: (WebCore::charactersWithArabicForm):
- svg/SVGFontData.cpp: (WebCore::SVGFontData::applySVGGlyphSelection): (WebCore::SVGFontData::createStringWithMirroredCharacters):
- svg/SVGFontData.h: (SVGFontData):
- 3:37 AM Changeset in webkit [107210] by
-
- 11 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107207.
- platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/gtk/svg/custom/foreignObject-crash-on-hover-expected.txt:
- platform/gtk/svg/custom/hit-test-unclosed-subpaths-expected.txt:
- platform/gtk/svg/custom/js-update-bounce-expected.txt:
- platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
- platform/gtk/svg/custom/js-update-style-expected.txt:
- platform/gtk/svg/custom/mask-invalidation-expected.txt:
- platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/gtk/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/gtk/svg/custom/use-clipped-hit-expected.txt:
- 3:28 AM Changeset in webkit [107209] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Scripts navigator fails to reopen previously closed script.
https://bugs.webkit.org/show_bug.cgi?id=78212
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._editorClosed):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
- 3:21 AM Changeset in webkit [107208] by
-
- 3 edits in trunk/Source/WebCore
ASSERT_NO_EXCEPTION should be initialized with non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=78194
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.
ExceptionCode should not be checked without initializing it.
However, we encountered a bug that breaks this rule.
It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
This patch ensures it is initialized as non-zero value.
No new tests, no change in behavior.
- dom/ExceptionCodePlaceholder.cpp:
(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
- dom/ExceptionCodePlaceholder.h:
(NoExceptionAssertionChecker):
- 3:21 AM Changeset in webkit [107207] by
-
- 204 edits1 delete in trunk/LayoutTests
Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115
Reviewed by Andreas Kling.
Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/mac/svg/custom/animate-path-discrete-expected.png:
- platform/mac/svg/custom/animate-path-morphing-expected.png:
- platform/mac/svg/custom/animate-target-id-changed-expected.png:
- platform/mac/svg/custom/animate-target-removed-from-document-expected.png:
- platform/mac/svg/custom/circle-move-invalidation-expected.png:
- platform/mac/svg/custom/clip-path-child-changes-expected.png:
- platform/mac/svg/custom/clip-path-href-changes-expected.png:
- platform/mac/svg/custom/clip-path-id-changes-expected.png:
- platform/mac/svg/custom/clip-path-units-changes-expected.png:
- platform/mac/svg/custom/deep-dynamic-updates-expected.png:
- platform/mac/svg/custom/fill-opacity-update-expected.png:
- platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
- platform/mac/svg/custom/gradient-add-stops-expected.png:
- platform/mac/svg/custom/gradient-stop-style-change-expected.png:
- platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.txt:
- platform/mac/svg/custom/hit-test-with-br-expected.png:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-gradient-creation-expected.png:
- platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-marker-creation-expected.png:
- platform/mac/svg/custom/js-late-mask-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-mask-creation-expected.png:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-pattern-creation-expected.png:
- platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
- platform/mac/svg/custom/js-update-bounce-expected.png:
- platform/mac/svg/custom/js-update-bounce-expected.txt:
- platform/mac/svg/custom/js-update-container-expected.png:
- platform/mac/svg/custom/js-update-container2-expected.png:
- platform/mac/svg/custom/js-update-gradient-expected.png:
- platform/mac/svg/custom/js-update-image-expected.png:
- platform/mac/svg/custom/js-update-path-changes-expected.png:
- platform/mac/svg/custom/js-update-path-removal-expected.png:
- platform/mac/svg/custom/js-update-pattern-child-expected.png:
- platform/mac/svg/custom/js-update-pattern-expected.png:
- platform/mac/svg/custom/js-update-polygon-changes-expected.png:
- platform/mac/svg/custom/js-update-polygon-removal-expected.png:
- platform/mac/svg/custom/js-update-stop-expected.png:
- platform/mac/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/mac/svg/custom/js-update-stop-linked-gradient-expected.txt:
- platform/mac/svg/custom/js-update-style-expected.png:
- platform/mac/svg/custom/js-update-style-expected.txt:
- platform/mac/svg/custom/js-update-transform-addition-expected.png:
- platform/mac/svg/custom/js-update-transform-changes-expected.png:
- platform/mac/svg/custom/marker-child-changes-css-expected.png:
- platform/mac/svg/custom/marker-child-changes-expected.png:
- platform/mac/svg/custom/marker-strokeWidth-changes-expected.png:
- platform/mac/svg/custom/marker-viewBox-changes-expected.png:
- platform/mac/svg/custom/mask-child-changes-expected.png:
- platform/mac/svg/custom/mask-invalidation-expected.png:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png:
- platform/mac/svg/custom/prevent-default-expected.png:
- platform/mac/svg/custom/relative-sized-content-expected.png:
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
- platform/mac/svg/custom/relative-sized-image-expected.png:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/mac/svg/custom/repaint-moving-svg-and-div-expected.png:
- platform/mac/svg/custom/repaint-on-image-bounds-change-expected.png:
- platform/mac/svg/custom/resource-client-removal-expected.png:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/mac/svg/custom/scroll-hit-test-expected.png:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac/svg/custom/stroke-opacity-update-expected.png:
- platform/mac/svg/custom/svg-absolute-children-expected.png:
- platform/mac/svg/custom/text-dom-removal-expected.png:
- platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
- platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/mac/svg/custom/use-clipped-hit-expected.png:
- platform/mac/svg/custom/use-clipped-hit-expected.txt:
- platform/mac/svg/custom/use-detach-expected.png:
- platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
- platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
- platform/mac/svg/custom/use-elementInstance-methods-expected.png:
- platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.png:
- platform/mac/svg/custom/use-event-handler-on-use-element-expected.png:
- platform/mac/svg/custom/use-inherit-style-expected.png:
- platform/mac/svg/custom/use-instanceRoot-as-event-target-expected.png: Removed.
- platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
- platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
- platform/mac/svg/custom/use-setAttribute-crash-expected.png:
- svg/custom/absolute-sized-content-with-resources.xhtml:
- svg/custom/animate-path-discrete.svg:
- svg/custom/animate-path-morphing.svg:
- svg/custom/animate-target-id-changed.svg:
- svg/custom/animate-target-removed-from-document.svg:
- svg/custom/circle-move-invalidation.svg:
- svg/custom/clip-path-child-changes.svg:
- svg/custom/clip-path-href-changes.svg:
- svg/custom/clip-path-id-changes.svg:
- svg/custom/clip-path-units-changes.svg:
- svg/custom/deep-dynamic-updates.svg:
- svg/custom/fill-opacity-update.svg:
- svg/custom/foreignObject-crash-on-hover.xml:
- svg/custom/gradient-add-stops.svg:
- svg/custom/gradient-stop-style-change.svg:
- svg/custom/hit-test-path-stroke.svg:
- svg/custom/hit-test-path.svg:
- svg/custom/hit-test-unclosed-subpaths.svg:
- svg/custom/hit-test-with-br.xhtml:
- svg/custom/js-late-clipPath-and-object-creation.svg:
- svg/custom/js-late-clipPath-creation.svg:
- svg/custom/js-late-gradient-and-object-creation.svg:
- svg/custom/js-late-gradient-creation.svg:
- svg/custom/js-late-marker-and-object-creation.svg:
- svg/custom/js-late-marker-creation.svg:
- svg/custom/js-late-mask-and-object-creation.svg:
- svg/custom/js-late-mask-creation.svg:
- svg/custom/js-late-pattern-and-object-creation.svg:
- svg/custom/js-late-pattern-creation.svg:
- svg/custom/js-repaint-rect-on-path-with-stroke.svg:
- svg/custom/js-update-bounce.svg:
- svg/custom/js-update-container.svg:
- svg/custom/js-update-container2.svg:
- svg/custom/js-update-gradient.svg:
- svg/custom/js-update-image.svg:
- svg/custom/js-update-path-changes.svg:
- svg/custom/js-update-path-removal.svg:
- svg/custom/js-update-pattern-child.svg:
- svg/custom/js-update-pattern.svg:
- svg/custom/js-update-polygon-changes.svg:
- svg/custom/js-update-polygon-removal.svg:
- svg/custom/js-update-stop-linked-gradient.svg:
- svg/custom/js-update-stop.svg:
- svg/custom/js-update-style.svg:
- svg/custom/js-update-transform-addition.svg:
- svg/custom/js-update-transform-changes.svg:
- svg/custom/linking-a-03-b-all.svg:
- svg/custom/linking-a-03-b-preserveAspectRatio.svg:
- svg/custom/linking-a-03-b-transform.svg:
- svg/custom/linking-a-03-b-viewBox-transform.svg:
- svg/custom/linking-a-03-b-viewBox.svg:
- svg/custom/linking-a-03-b-viewTarget.svg:
- svg/custom/linking-a-03-b-zoomAndPan.svg:
- svg/custom/marker-child-changes-css.svg:
- svg/custom/marker-child-changes.svg:
- svg/custom/marker-strokeWidth-changes.svg:
- svg/custom/marker-viewBox-changes.svg:
- svg/custom/mask-child-changes.svg:
- svg/custom/mask-invalidation.svg:
- svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml:
- svg/custom/pending-resource-after-removal-expected.png:
- svg/custom/pending-resource-after-removal.xhtml:
- svg/custom/pending-resource-leak-2.svg:
- svg/custom/pending-resource-leak-3.svg:
- svg/custom/prevent-default.svg:
- svg/custom/relative-sized-content-with-resources.xhtml:
- svg/custom/relative-sized-content.xhtml:
- svg/custom/relative-sized-deep-shadow-tree-content.xhtml:
- svg/custom/relative-sized-image.xhtml:
- svg/custom/relative-sized-inner-svg.xhtml:
- svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
- svg/custom/relative-sized-shadow-tree-content.xhtml:
- svg/custom/relative-sized-use-on-symbol.xhtml:
- svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml:
- svg/custom/repaint-moving-svg-and-div.xhtml:
- svg/custom/repaint-on-constant-size-change.svg:
- svg/custom/repaint-on-image-bounds-change.svg:
- svg/custom/repaint-shadow.svg:
- svg/custom/repaint-stroke-width-changes.svg:
- svg/custom/resource-client-removal.svg:
- svg/custom/resource-invalidate-on-target-update.svg:
- svg/custom/resources/use-instanceRoot-event-bubbling.js:
(repaintTest):
- svg/custom/resources/use-instanceRoot-event-listeners.js:
(repaintTest):
- svg/custom/scroll-hit-test.xhtml:
- svg/custom/scroll-to-anchor-in-symbol.svg:
- svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
- svg/custom/stroke-opacity-update.svg:
- svg/custom/svg-absolute-children.svg:
- svg/custom/svg-disallowed-in-dashboard-object.html:
- svg/custom/svg-fonts-in-html-linebreaks.html:
- svg/custom/text-dom-removal.svg:
- svg/custom/text-repaint-including-stroke.svg:
- svg/custom/text-xy-updates-SVGList.xhtml:
- svg/custom/use-animation-in-fill.html:
- svg/custom/use-clipped-hit.svg:
- svg/custom/use-crash-in-non-wellformed-document.svg:
- svg/custom/use-crash-when-href-change.svg:
- svg/custom/use-detach.svg:
- svg/custom/use-disappears-after-style-update.svg:
- svg/custom/use-elementInstance-event-target.svg:
- svg/custom/use-elementInstance-methods.svg:
- svg/custom/use-event-handler-on-referenced-element.svg:
- svg/custom/use-event-handler-on-use-element.svg:
- svg/custom/use-inherit-style.svg:
- svg/custom/use-instanceRoot-as-event-target.xhtml:
- svg/custom/use-instanceRoot-event-bubbling.xhtml:
- svg/custom/use-instanceRoot-event-listeners.xhtml:
- svg/custom/use-multiple-on-nested-disallowed-font.html:
- svg/custom/use-setAttribute-crash.svg:
- 2:28 AM Changeset in webkit [107206] by
-
- 1 edit34 adds in trunk/LayoutTests
Unreviewed, GTK baselines for new tests.
- platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Added.
- platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Added.
- platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
- platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Added.
- platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Added.
- platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
- platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Added.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
- platform/gtk/svg/filters/feImage-late-indirect-update-expected.txt: Added.
- platform/gtk/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
- platform/gtk/svg/filters/feImage-position-expected.txt: Added.
- platform/gtk/svg/filters/feImage-remove-target-expected.txt: Added.
- platform/gtk/svg/filters/feImage-subregions-expected.txt: Added.
- platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
- platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-add-to-document-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-attribute-change-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-changes-id-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-id-change-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-property-change-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
- platform/gtk/svg/filters/feImage-target-style-change-expected.txt: Added.
- platform/gtk/svg/filters/filter-placement-issue-expected.txt: Added.
- platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
- platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
- platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Added.
- 2:21 AM Changeset in webkit [107205] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r107197.
http://trac.webkit.org/changeset/107197
https://bugs.webkit.org/show_bug.cgi?id=77525
broke Chromium Linux
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
(WebCore):
(WebCore::SelectorChecker::checkOneSelector):
- css/SelectorChecker.h:
- 2:00 AM Changeset in webkit [107204] by
-
- 165 edits in trunk/Source/WebCore
Unreviewed, rolling out r107182, r107186, r107189, r107191,
and r107199.
http://trac.webkit.org/changeset/107182
http://trac.webkit.org/changeset/107186
http://trac.webkit.org/changeset/107189
http://trac.webkit.org/changeset/107191
http://trac.webkit.org/changeset/107199
https://bugs.webkit.org/show_bug.cgi?id=78200
Layout tests of JSC-related port are crashing
- Modules/gamepad/GamepadList.idl:
- Modules/intents/Intent.idl:
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateParametersCheck):
(NativeToJSValue):
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
(GenerateImplementationIndexer):
(RequiresCustomSignature):
(NativeToJSValue):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestNamedConstructor.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayInternal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8BindingMacros.h:
- css/CSSCharsetRule.idl:
- css/CSSImportRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPageRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/ClientRectList.idl:
- dom/Clipboard.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringList.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/Event.idl:
- dom/HashChangeEvent.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/MutationRecord.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeList.idl:
- dom/Notation.idl:
- dom/OverflowEvent.idl:
- dom/ProcessingInstruction.idl:
- dom/Range.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- html/DOMFormData.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAudioElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/TextTrackCue.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLRenderingContext.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- storage/IDBDatabase.idl:
- storage/IDBObjectStore.idl:
- storage/IDBRequest.idl:
- storage/Storage.idl:
- storage/StorageEvent.idl:
- svg/ElementTimeControl.idl:
- svg/SVGDocument.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGLocatable.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStylable.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- webaudio/AudioNode.idl:
- websockets/WebSocket.idl:
- workers/SharedWorker.idl:
- workers/WorkerContext.idl:
- xml/DOMParser.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- xml/XSLTProcessor.idl:
- 1:55 AM Changeset in webkit [107203] by
-
- 4 edits5 adds in trunk/LayoutTests
Unreviewed, add chromium expectations for new tests added in r107160.
- platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
- platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
- platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
- platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- 1:54 AM Changeset in webkit [107202] by
-
- 17 edits2 adds in trunk
Disable adding a shadow root to elements having a dynamic built-in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77935
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.
Source/WebCore:
We temporarily disable adding a shadow root in elements having a dynamic user agent shadow root.
These shadow roots are currently created using Element::ensureShadowRoot.
So we don't check the condition if a shadow root is created eaither using Element::ensureShadowRoot
or ShadowRoot::CreatingUserAgentShadowRoot is specified for ShadowRoot::create.
Test: fast/dom/shadow/shadow-disable.html
- dom/Element.cpp:
(WebCore::Element::ensureShadowRoot):
- dom/ShadowRoot.cpp:
(WebCore::allowsUserShadowRoot):
(WebCore):
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(ShadowRoot):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
ShadowRoot::CreatingUserAgentShadowRoot is specified.
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): ditto.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree): ditto.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree): ditto.
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree): ditto.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree): ditto.
LayoutTests:
- fast/dom/shadow/shadow-disable-expected.txt: Added.
- fast/dom/shadow/shadow-disable.html: Added.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 1:51 AM Changeset in webkit [107201] by
-
- 3 edits2 adds in trunk
Web Inspector: hovering over element with :hover style halts inspector
https://bugs.webkit.org/show_bug.cgi?id=78086
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/updates-throttled.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
LayoutTests:
- inspector/styles/updates-throttled-expected.txt: Added.
- inspector/styles/updates-throttled.html: Added.
- 1:50 AM Changeset in webkit [107200] by
-
- 2 edits1 copy7 adds in trunk/LayoutTests
Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-09
Reviewed by Alexey Proskuryakov.
Add tests for mapping http-equiv content-language to -webkit-locale to cover dynamic changes to the meta
element and a comma-separated list of languages. The desired behavior of some of these is not yet decided, so
some of the tests currently fail and the expectations may change. See comments in bug and in the tests.
- fast/text/content-language-comma-separated-list-expected.txt: Added.
- fast/text/content-language-comma-separated-list.html: Added.
- fast/text/content-language-dynamically-added-expected.txt: Added.
- fast/text/content-language-dynamically-added.html: Added.
- fast/text/content-language-dynamically-changed-expected.txt: Added.
- fast/text/content-language-dynamically-changed.html: Added.
- fast/text/content-language-dynamically-removed-expected.txt: Added.
- fast/text/content-language-dynamically-removed.html: Added.
- fast/text/content-language-multiple.html: Fix to actually test http-equiv content-language.
- 1:46 AM Changeset in webkit [107199] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Fix build failure caused by r107191.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- 1:42 AM Changeset in webkit [107198] by
-
- 1 edit3 deletes in trunk/LayoutTests
2012-02-09 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed.
- platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed.
- platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed.
- 1:36 AM Changeset in webkit [107197] by
-
- 4 edits in trunk/Source/WebCore
2012-02-09 Roland Steiner <rolandsteiner@chromium.org>
SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525
Added 'SelectorCheckingContext' struct to hold parameters for the function.
Adapted calling sites.
Reviewed by Antti Koivisto.
No new tests. (refactoring)
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
- css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): (WebCore): (WebCore::SelectorChecker::checkOneSelector):
- css/SelectorChecker.h: (SelectorCheckingContext): (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): (SelectorChecker):
- 1:33 AM Changeset in webkit [107196] by
-
- 4 edits in trunk
Do not localize numbers in scientific notation
https://bugs.webkit.org/show_bug.cgi?id=78208
Reviewed by Hajime Morita.
.:
- ManualTests/input-number-localization.html: Updated for scientific notation.
Source/WebCore:
For a preparation of fixing http://wkb.ug/62939, we stop supporting
localized numbers in scientific notation in <input type=number>.
We're going to change number localization processing so that it replaces
letters one by one. It will be very hard to support scientific notation.
- html/NumberInputType.cpp:
(WebCore::isE): A helper functio for String::find() to detect scientific notation.
(WebCore::NumberInputType::visibleValue): Avoid localization for scientific notation.
(WebCore::NumberInputType::convertFromVisibleValue): ditto.
(WebCore::NumberInputType::isAcceptableValue):
Use convertFromVisibleValue, also stop accepting a standard format as a fallback.
- 1:18 AM Changeset in webkit [107195] by
-
- 2 edits in trunk/Tools
kill-old-processes should kill gcc and clang
https://bugs.webkit.org/show_bug.cgi?id=78189
Reviewed by Eric Seidel.
Added a bunch of processes names of gcc and clang to the list.
- BuildSlaveSupport/kill-old-processes:
- 1:05 AM Changeset in webkit [107194] by
-
- 2 edits in trunk/Source/WebCore
EntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78190
Reviewed by Antonio Gomes.
EntryBase.cpp is not in the CMake build system, which causes build failure (undefined
symbols to EntryBase) when turning on ENABLE_FILE_SYSTEM.
Build system fix, no new tests.
- CMakeLists.txt:
- 1:03 AM Changeset in webkit [107193] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r53878): Input elements don't share their styles if the document contains no validity style rules.
<http://webkit.org/b/69400>
Reviewed by Kent Tamura.
Don't reject style sharing candidates prematurely just because the document doesn't
have any :valid or :invalid selectors.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
- 1:03 AM Changeset in webkit [107192] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test_expectations change.
[chromium] remove expectation for css3/calc/block-mask-overlay-image-outset.html
https://bugs.webkit.org/show_bug.cgi?id=78183
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Fblock-mask-overlay
shows this test has not failed as far back as its history is recorded.
- platform/chromium/test_expectations.txt:
- 12:55 AM Changeset in webkit [107191] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalIsUndefinedString):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_optional_is_undefined_string):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionConvert5):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithOptionalIsUndefinedString:]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithOptionalIsUndefinedStringCallback):
(WebCore):
- 12:50 AM Changeset in webkit [107190] by
-
- 2 edits in trunk
[CMAKE] Change lowercase variable with uppercase's.
https://bugs.webkit.org/show_bug.cgi?id=78198
Reviewed by Daniel Bates.
CMake variable is only written by uppercase.
- CMakeLists.txt:
- 12:31 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 12:28 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 12:25 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 12:16 AM Changeset in webkit [107189] by
-
- 38 edits in trunk/Source/WebCore
Unreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [TreatReturnedNullStringAs=].
- bindings/scripts/test/TestObj.idl:
- css/CSSCharsetRule.idl:
- css/CSSImportRule.idl:
- css/CSSPageRule.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- css/WebKitCSSKeyframesRule.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/Clipboard.idl:
- dom/DOMStringList.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/MutationRecord.idl:
- dom/Node.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLMediaElement.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLRenderingContext.idl:
- page/DOMWindow.idl:
- storage/IDBObjectStore.idl:
- storage/IDBRequest.idl:
- storage/Storage.idl:
- storage/StorageEvent.idl:
- websockets/WebSocket.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- xml/XSLTProcessor.idl:
Feb 8, 2012:
- 11:58 PM Changeset in webkit [107188] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline.
- platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/forms/select-overflow-scroll-expected.txt:
- platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt:
- platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
- 11:52 PM Changeset in webkit [107187] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix a typo for r107125
https://bugs.webkit.org/show_bug.cgi?id=77804
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by James Robinson.
- tests/WebCompositorInputHandlerImplTest.cpp:
- 11:20 PM Changeset in webkit [107186] by
-
- 40 edits in trunk/Source/WebCore
Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108
Reviewed by Adam Barth.
[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer):
(NativeToJSValue):
- bindings/scripts/test/TestObj.idl: No change in run-bindings-tests results.
- css/CSSCharsetRule.idl:
- css/CSSImportRule.idl:
- css/CSSPageRule.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleRule.idl:
- css/CSSValue.idl:
- css/MediaList.idl:
- css/StyleSheet.idl:
- css/WebKitCSSKeyframesRule.idl:
- dom/Attr.idl:
- dom/CharacterData.idl:
- dom/Clipboard.idl:
- dom/DOMStringList.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Entity.idl:
- dom/MutationRecord.idl:
- dom/Node.idl:
- dom/Notation.idl:
- dom/ProcessingInstruction.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLMediaElement.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLRenderingContext.idl:
- page/DOMWindow.idl:
- storage/IDBObjectStore.idl:
- storage/IDBRequest.idl:
- storage/Storage.idl:
- storage/StorageEvent.idl:
- websockets/WebSocket.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- xml/XSLTProcessor.idl:
- 11:14 PM Changeset in webkit [107185] by
-
- 11 edits in trunk/Source/WebCore
Simplify ownership of StyledElement::additionalAttributeStyles().
<http://webkit.org/b/78204>
Reviewed by Anders Carlsson.
Change additionalAttributeStyle() to return a raw pointer rather than a PassRefPtr.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableCellElement.h:
(HTMLTableCellElement):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTableColElement.h:
(HTMLTableColElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
- 11:14 PM Changeset in webkit [107184] by
-
- 1 edit2 adds in trunk/PerformanceTests
[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
https://bugs.webkit.org/show_bug.cgi?id=78174
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-08
Reviewed by Ryosuke Niwa.
Pulled back removed files.
- Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
- Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.
- 11:02 PM Changeset in webkit [107183] by
-
- 1 edit4 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=78049
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-08
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.h: Added.
- blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h: Added.
- 10:58 PM Changeset in webkit [107182] by
-
- 141 edits in trunk/Source/WebCore
Rename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200
Reviewed by Adam Barth.
[Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] are confusing.
- [Optional=CallWithDefalutValue] indicates that a missing value should be treated
as if the JavaScript undefined is passed.
- [Optional=CallWithNullValue] indicates that a missing value should be treated as
the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
- Actually, the difference between [Optional=CallWithDefalutValue] and
[Optional=CallWithNullValue] appears only when the type of the missing value is DOMString.
In case of [Optional=CallWithDefalutValue], the missing value is converted to the string
"undefined". On the other hand, in case of [Optional=CallWithNullValue], the missing
value is converted to the WebKit null string.
With these observations, this patch renames them as follows:
- Rename [Optional=CallWithDefalutValue] to [Optional=TreatAsUndefined].
- Remove [Optional=CallWithNullValue]. Instead, we use
[Optional=TreatAsUndefined, TreatUndefinedAs=NullString].
Test: bindings/scripts/test/TestInterface.idl
- bindings/js/JSDOMBinding.h: Renamed MissingIsUndefined to MissingIsUndefinedValue,
renamed MissingIsEmpty to MissingIsNullValue.
- bindings/v8/V8Binding.h: Ditto.
- bindings/v8/custom/V8BindingMacros.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Modified to support the IDL attribute renaming.
(GenerateParametersCheck):
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheck):
(RequiresCustomSignature):
- Modules/gamepad/GamepadList.idl: Renamed IDL attributes as described above.
- Modules/intents/Intent.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- dom/CharacterData.idl:
- dom/ClientRectList.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMImplementation.idl:
- dom/DOMStringList.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/HashChangeEvent.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeList.idl:
- dom/OverflowEvent.idl:
- dom/Range.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- html/DOMFormData.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAudioElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/TextTrackCue.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- page/Console.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- storage/IDBDatabase.idl:
- storage/StorageEvent.idl:
- svg/ElementTimeControl.idl:
- svg/SVGDocument.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGLocatable.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStylable.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- webaudio/AudioNode.idl:
- workers/SharedWorker.idl:
- workers/WorkerContext.idl:
- xml/DOMParser.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- bindings/scripts/test/TestInterface.idl: Added test cases for [Optional],
[Optional=TreatAsUndefined] and [Optional=TreatAsUndefined, TreatUndefinedAs=NullString]
- bindings/scripts/test/TestNamedConstructor.idl: Renamed IDL attributes as described above.
- bindings/scripts/test/TestObj.idl: Ditto.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalIsTreatAsUndefinedString):
(WebDOMTestObj::methodWithOptionalIsNullStringString):
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_is_treat_as_undefined_string):
(webkit_dom_test_obj_method_with_optional_is_null_string_string):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSFloat64Array.cpp: Ditto.
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Ditto.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
- bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
- bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsTreatAsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
(WebCore):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalIsTreatAsUndefinedString:]):
(-[DOMTestObj methodWithOptionalIsNullStringString:]):
- bindings/scripts/test/V8/V8Float64Array.cpp: Ditto.
(WebCore::Float64ArrayInternal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Ditto.
(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp: Ditto.
(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalIsTreatAsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalIsNullStringStringCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
- 10:43 PM Changeset in webkit [107181] by
-
- 14 edits in trunk/Source/WebCore
Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
https://bugs.webkit.org/show_bug.cgi?id=78096
Reviewed by Adam Barth.
This patch renames [HasNumericIndexGetter] to [NumericIndexedGetter],
for naming consistency with [IndexedGetter] and [CustomIndexedGetter].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
- bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
- html/canvas/CanvasPixelArray.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- 10:12 PM Changeset in webkit [107180] by
-
- 4 edits1 copy1 add in trunk/Source/WebKit2
[WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.
https://bugs.webkit.org/show_bug.cgi?id=76171
Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.
FileDownloaderEfl is a practical class to operate file download.
It communicates with Download class to start download
and to notify downloading states to user(e.g. client application).
Besides FileDownloaderEfl derives from ResourceHandleClient
and receives chunked data from ResourceHandle directly
or redirects data flow which is started from MainResourceLoader
by mean of exchanging ResourceHandle's existing client for FileDownloaderEfl.
This patch has only dummy functions to make easy to review.
Working patch will be uploaded on another bug thread.
- PlatformEfl.cmake: added new file to compile.
- WebProcess/Downloads/Download.h: added FileDownloaderEfl's instance as a form of OwnPtr<FileDownloaderEfl>.
(WebKit):
(Download):
- WebProcess/Downloads/efl/DownloadEfl.cpp:
(WebKit::Download::start): calling to FileDownloaderEfl::start() to start download for passing ResourceRequest.
- WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Added. a practical class to operate file download.
(WebKit):
(WebKit::FileDownloaderEfl::create): create function, which returns PassOwnPtr<FileDownloaderEfl>.
(WebKit::FileDownloaderEfl::FileDownloaderEfl): constructor, which receives Download* as a parameter.
(WebKit::FileDownloaderEfl::~FileDownloaderEfl): deconstructor.
(WebKit::FileDownloaderEfl::start): a function to start downloading for passed ResourceRequest.
It does nothing for now, but shows how Download class can call FileDownloaderEfl's function.
(WebKit::FileDownloaderEfl::didReceiveResponse): virtual function for ResourceHandleClient.
It will receive response header information from ResourceHandle.
(WebKit::FileDownloaderEfl::didReceiveData): virtual function for ResourceHandleClient.
It will receive chunk data from ResourceHandle.
(WebKit::FileDownloaderEfl::didFinishLoading): virtual function for ResourceHandleClient.
It will be notified loading is finished from ResourceHandle.
(WebKit::FileDownloaderEfl::didFail): virtual function for ResourceHandleClient.
It will be notified loading is fail with ResourceError from ResourceHandle.
(WebKit::FileDownloaderEfl::shouldUseCredentialStorage): virtual function for ResourceHandleClient.
It returns whether to use credential storage or not.
(WebKit::FileDownloaderEfl::didReceiveAuthenticationChallenge): virtual function for ResourceHandleClient.
It will receive AuthenticationChallenge.
(WebKit::FileDownloaderEfl::didCancelAuthenticationChallenge): virtual function for ResourceHandleClient.
It will be notified AuthenticationChallenge is canceled.
(WebKit::FileDownloaderEfl::receivedCancellation): virtual function for ResourceHandleClient.
- WebProcess/Downloads/efl/FileDownloaderEfl.h: Added.
(WebCore):
(WebKit):
(FileDownloaderEfl):
- 9:57 PM Changeset in webkit [107179] by
-
- 3 edits in trunk/Source/WebCore
refactor RenderFlexibleBox to return preferred sizes of all children
https://bugs.webkit.org/show_bug.cgi?id=78169
Reviewed by Ojan Vafai.
This is in preparation for multi-line flexbox. We need the preferred
size of each child so we can compute where the multi-line breaks happen.
No new tests, just refactoring.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Renamed from preferredMainAxisContentExtentForFlexItem because
other methods are ForChild rather than ForFlexItem.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- 9:46 PM Changeset in webkit [107178] by
-
- 8 edits in trunk/Source/WebCore
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.
ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.
No new tests, no change in behavior.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
Initialize exception code before calling appendChild.
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
- 9:26 PM Changeset in webkit [107177] by
-
- 15 edits in trunk/Source
[Chromium] Avoid unnecessary full tile updates without breaking atomicity of commits.
https://bugs.webkit.org/show_bug.cgi?id=76740
Patch by David Reveman <reveman@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Source/WebCore:
Allow the final batch of texture uploads to be performed without
allocating new textures and re-painting complete tiles.
This patch is tested by the following unit test:
- CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
- TiledLayerChromiumTest.partialUpdates
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::requestPartialTextureUpdate):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::CCSingleThreadProxy::maxPartialTextureUpdates):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::append):
(WebCore):
(WebCore::CCTextureUpdater::appendPartial):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Add CCLayerTreeHostTestAtomicCommitWithPartialUpdate and
TiledLayerChromiumTest.partialUpdates tests that verifies
atomicity of commits with partial updates.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(CCLayerTreeHostTestAtomicCommit):
(CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::afterTest):
(WTF):
(WTF::TEST_F):
- tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::Texture::Texture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(Texture):
(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::updateCount):
(WTF::FakeLayerTextureUpdater::clearUpdateCount):
(WTF::FakeLayerTextureUpdater::updateRect):
(WTF::FakeLayerTextureUpdater::createTexture):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):
- 9:23 PM Changeset in webkit [107176] by
-
- 23 edits2 adds in trunk
Replacement text should be available from the marker.
https://bugs.webkit.org/show_bug.cgi?id=77934
.:
Reviewed by Kent Tamura.
- Source/autotools/symbols.filter: Added an exporting symbol.
Source/WebCore:
Reviewed by Kent Tamura.
On spellchecking, TextCheckingResult can contain a replacement text
which is usable both for an automatic replacement and for showing a suggestion.
But when marking a misspelled word ragarding to returned
TextCheckingResult, Editor uses only the misspelled range data and
discards the replacement value. Then it asks the same value again
when showing suggestion/autocorrection.
It would be great if the marker holds the replacement text
and Editor can use it on suggesting a correction, without any re-request.
This is especially true in the case when it needs IPC messaging for spellchecking:
We can save one round-trip by this technique.
Here is actual change:
- Passed the replacement text to addMarker() for for misspelling markers. Note that this is done only for the unified checker path because legacy TextCheckerClient API doesn't provide such a replacement.
- Added an Internals API to retrieve a description text on a marker.
Test: editing/spelling/spelling-marker-description.html
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
- testing/Internals.cpp:
(WebCore::Internals::markerAt):
(WebCore):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::markerDescriptionForNode):
- testing/Internals.h:
(WebCore):
(Internals):
- testing/Internals.idl:
Source/WebKit/chromium:
didFinishCheckingText() accidentally dropped the description text
given from the backend. Fixed to copy it on the API-to-Core
convertion. The test won't work without this fix.
Reviewed by Kent Tamura.
- src/WebTextCheckingCompletionImpl.cpp:
(WebKit::toCoreResults):
Source/WebKit/win:
Reviewed by Kent Tamura.
- WebKit.vcproj/WebKit_Cairo.def:
- WebKit.vcproj/WebKit_Cairo_debug.def:
Source/WebKit2:
Reviewed by Kent Tamura.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Tools:
Made the mock requestCheckingOfText() implementation to return
a replacement text for each misspelled word if available.
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):
LayoutTests:
Reviewed by Kent Tamura.
- editing/spelling/spelling-marker-description-expected.txt: Added.
- editing/spelling/spelling-marker-description.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:06 PM Changeset in webkit [107175] by
-
- 14 edits2 deletes in trunk
Remove more cruft now that HTMLIsIndexElement is gone
https://bugs.webkit.org/show_bug.cgi?id=77887
Reviewed by Darin Adler.
Just removing dead code, thus no tests.
There is likely more to remove after this.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
- html/InputType.h:
(InputTypeNames):
- html/IsIndexInputType.cpp: Removed.
- html/IsIndexInputType.h: Removed.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
- 8:49 PM Changeset in webkit [107174] by
-
- 4 edits in trunk/Source/WebKit/chromium
[V8][Chromium] Race between worker accessing WebDatabase and frame closing down.
https://bugs.webkit.org/show_bug.cgi?id=78150
Handle case when the frame is shut down under us gracefully.
Patch by Dmitry Lomov <dslomov@chromium.org> on 2012-02-08
Reviewed by David Levin.
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase): Handle WebWorkerBase::view returning 0.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker): Handle WebWorkerBase::view returning 0.
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::view):
- 8:41 PM Changeset in webkit [107173] by
-
- 2 edits in trunk/Source/WebCore
Increased style sharing for elements with presentation attributes.
<http://webkit.org/b/78199>
Reviewed by Antti Koivisto.
When determining whether two elements can share style, we can do a lot better.
Instead of comparing the attribute maps for exact equality, do a property-by-property
comparison of the attributeStyle() and the additionalAttributeStyle() (if any.)
This increases our style sharing hit rate and shaves 100ms off of each cycle on
Chromium's "Moz" page cycler test on my machine.
The function that compares attribute styles has O(n2) runtime in the worst case,
where n is the number of properties in the styles. However, given the low number of
properties found in attribute styles, this should be fine, and it doesn't seem to
heat up in profiles.
- css/CSSStyleSelector.cpp:
(WebCore::attributeStylesEqual):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
- 8:34 PM Changeset in webkit [107172] by
-
- 2 edits in trunk/Source/WebCore
Fix the caculation of preDelayFrames in DynamicsCompressorKernel
https://bugs.webkit.org/show_bug.cgi?id=78057
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by Chris Rogers.
No new tests required.
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
- 8:04 PM Changeset in webkit [107171] by
-
- 6 edits in trunk/Tools
[Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
https://bugs.webkit.org/show_bug.cgi?id=78146
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-08
Reviewed by Ryosuke Niwa.
Our DumpRenderTree should support --no-timeout and --timeout options in order
to be able to use run-perf-tests and have a Performance Bot.
This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
and the necessary code to handle such command line arguments to our DumpRenderTree.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::setTimeout):
(WebCore):
(WebCore::DumpRenderTree::setShouldTimeout):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::setTimeout):
(LayoutTestController::setShouldTimeout):
(LayoutTestController):
- DumpRenderTree/qt/main.cpp:
(isOption):
(printUsage):
(main):
- 7:34 PM Changeset in webkit [107170] by
-
- 13 edits in trunk/Source
DOM mutations should not be delivered on worker threads
https://bugs.webkit.org/show_bug.cgi?id=77898
Reviewed by Dmitry Titov.
Source/WebCore:
In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.
This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).
Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.
See also http://crbug.com/112586, where the problem was initially
reported.
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallback::call):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8Proxy.h:
(WebCore):
(V8Proxy):
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
- bindings/v8/V8RecursionScope.h:
(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
- bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
- bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):
Source/WebKit/chromium:
- src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- 7:20 PM Changeset in webkit [107169] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78082
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/InspectorClientBlackBerry.h: Added.
- 7:02 PM Changeset in webkit [107168] by
-
- 13 edits in trunk/Source
Don't use the wheel event handler count to track if a page has horizontal scrollbars
https://bugs.webkit.org/show_bug.cgi?id=78192
Reviewed by Andreas Kling.
Source/WebCore:
Stop calling Document::didAddWheelEventHandler and Document::didRemoveWheelEventHandler when
adding and removing scrollbars.
- page/FrameView.cpp:
- page/FrameView.h:
(FrameView):
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
Source/WebKit2:
Prior to this change, we were incrementing and decrementing the wheel event handler count
whenever a scrollable area gained or lost a horizontal scrollbar, so we could use the count
to determine if Safari can handle horizontal wheel events directly or whether they have to be sent
to the web process first.
What this meant was that whenever a page had horizontal scrollbars we'd have to send all scroll wheel events
to the main thread instead of the scrolling thread, regardless of whether there were any wheel event handlers.
After this change, we traverse the tree of scrollable areas after every layout and check if any of them
have a horizontal scrollbar. (We still also check if there are wheel event handlers).
If traversing the tree after every layout is deemed to slow we can go back to caching the number of horizontal scrollbars
in a page, but the number of subframes in a page is usually very small and the number of other scrollable areas is even smaller.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::willHandleHorizontalScrollEvents):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setCanShortCircuitHorizontalWheelEvents):
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::numWheelEventHandlersChanged):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::numWheelEventHandlersChanged):
(WebKit):
(WebKit::hasEnabledHorizontalScrollbar):
(WebKit::pageContainsAnyHorizontalScrollbars):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- 6:55 PM Changeset in webkit [107167] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/WebCore.gypi
Remove skia FixedPoint/Rect/Size files from build
- 6:45 PM Changeset in webkit [107166] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=78152
Patch by Scott Graham <scottmg@chromium.org> on 2012-02-08
Reviewed by Adam Barth.
- DEPS:
- 6:38 PM Changeset in webkit [107165] by
-
- 2 edits in trunk/Tools
Rubber-stamped by Martin Robinson.
- gtk/common.py:
(get_build_path): Move test for current directory being a valid
directory up so it takes precedence over WebKitBuild/Release and
WebKitBuild/Debug when they exist as well.
- 6:28 PM Changeset in webkit [107164] by
-
- 4 edits in trunk/Tools
[GTK] doc rebasing does not respect DESTDIR
https://bugs.webkit.org/show_bug.cgi?id=78177
Reviewed by Martin Robinson.
- GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
calling it for rebasing.
- gtk/generate-gtkdoc:
(get_common_options): Handle the new --virtual-root option.
- gtk/gtkdoc.py:
(GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
- 6:20 PM Changeset in webkit [107163] by
-
- 17 edits11 deletes in branches/subpixellayout/Source
Remove platform specific implicit conversions from/to FloatRect/Point/Size and make conversions explicit in platform code.
- 6:07 PM Changeset in webkit [107162] by
-
- 10 edits6 adds in trunk
Source/WebCore: Implement reverse animation direction
Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525
Implement reverse and alternate-reverse direction.
Reviewed by Dean Jackson.
Tests: animations/animation-direction-alternate-reverse.html
animations/animation-direction-reverse.html
animations/fill-mode-reverse.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationDirection):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapAnimationDirection):
- css/CSSValueKeywords.in:
- page/WebKitAnimation.cpp:
(WebCore::WebKitAnimation::direction):
- page/WebKitAnimation.h:
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::fractionalTime):
- platform/animation/Animation.h:
(Animation):
- platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore):
(WebCore::shouldReverseAnimationValue):
(WebCore::normalizedAnimationValue):
LayoutTests: Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525
Add test for the new animation-direction values.
Reviewed by Dean Jackson.
- animations/animation-direction-alternate-reverse-expected.txt: Added.
- animations/animation-direction-alternate-reverse.html: Added.
- animations/animation-direction-reverse-expected.txt: Added.
- animations/animation-direction-reverse.html: Added.
- animations/fill-mode-reverse-expected.txt: Added.
- animations/fill-mode-reverse.html: Added.
- 5:56 PM Changeset in webkit [107161] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Avoid creating a temporary GraphicsContext3D if someone requests the WebView's GraphicsContext3D before initialization is complete
https://bugs.webkit.org/show_bug.cgi?id=78154
Patch by James Robinson <jamesr@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::context):
- 5:50 PM Changeset in webkit [107160] by
-
- 8 edits3 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78157
Make multi-column layout work with line grids that are outside of the multi-column
block.
Reviewed by Dan Bernstein.
Added new tests in fast/line-grid.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):
(WebCore):
(WebCore::LayoutState::computeLineGridPaginationOrigin):
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::lineGrid):
(WebCore::LayoutState::lineGridOffset):
(WebCore::LayoutState::lineGridPaginationOrigin):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):
(LayoutState):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineGridSnapAdjustment):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78157
Make multi-column layout work with line grids that are outside of the multi-column
block.
Reviewed by Dan Bernstein.
- fast/line-grid/line-grid-into-columns.html: Added.
- platform/mac/fast/line-grid/line-grid-into-columns-expected.png: Added.
- platform/mac/fast/line-grid/line-grid-into-columns-expected.txt: Added.
- 5:41 PM Changeset in webkit [107159] by
-
- 5 edits3 copies9 adds in trunk/LayoutTests
Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-08
Reviewed by Alexey Proskuryakov.
Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.
- fast/text/content-language-case-insensitivity-expected.txt:
- fast/text/content-language-case-insensitivity.html: Style fixes.
- fast/text/content-language-empty-expected.txt: Added.
- fast/text/content-language-empty.html: Added.
- fast/text/content-language-late-expected.txt: Added.
- fast/text/content-language-late.html: Added.
- fast/text/content-language-mapped-to-webkit-locale-expected.txt:
- fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
- fast/text/content-language-multiple-expected.txt: Added.
- fast/text/content-language-multiple.html: Added.
- fast/text/content-language-no-content-expected.txt: Added.
- fast/text/content-language-no-content.html: Added.
- fast/text/content-language-only-whitespace-expected.txt: Added.
- fast/text/content-language-only-whitespace.html: Added.
- fast/text/content-language-with-whitespace-expected.txt: Added.
- fast/text/content-language-with-whitespace.html: Added.
- 5:41 PM Changeset in webkit [107158] by
-
- 2 edits in trunk/Source/WebKit
[BlackBerry] Remove EditCommandBlackBerry.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78078
Reviewed by Rob Buis.
WebKit/blackberry/WebCoreSupport/EditCommandBlackBerry.cpp which hasn't
been upstreamed has been removed from the BlackBerry porting internally.
So we should remove it from the build system.
- blackberry/CMakeListsBlackBerry.txt:
- 5:30 PM Changeset in webkit [107157] by
-
- 3 edits in trunk/Source/WebCore
GeneratorGeneratedImage::drawPattern does not factor in its destination context's scale when generating its image tiles
https://bugs.webkit.org/show_bug.cgi?id=67729
<rdar://problem/10087050>
Reviewed by Beth Dakin.
No new tests, current pixel tests will cover this. Though some pixel results might improve to become less pixel-y.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw): Updated context to destContext for consistency.
(WebCore::GeneratorGeneratedImage::drawPattern): Taught drawPattern about the destination
scale factor to avoid having low-res generated images such as gradients in certain cases.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer): Have the image buffer match the
context acceleration setting as well.
- 4:50 PM Changeset in webkit [107156] by
-
- 2 edits in trunk/Tools
Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593
Reviewed by Eric Seidel.
This is the last vestige of our Python 2.5 support.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_from_script_error_for_upload):
- 4:46 PM Changeset in webkit [107155] by
-
- 2 edits in trunk/Tools
version_check.py should inform users that we don't support Python 2.5 anymore
https://bugs.webkit.org/show_bug.cgi?id=78179
Reviewed by Eric Seidel.
We don't support Python 2.5 anymore.
- Scripts/webkitpy/common/version_check.py:
- 4:37 PM Changeset in webkit [107154] by
-
- 1 delete in trunk/Tools/Scripts/webkitpy/python24
Remove empty directory.
- 4:32 PM Changeset in webkit [107153] by
-
- 2 edits in trunk/Tools
test_configuration.py shouldn't re-implement itertools
https://bugs.webkit.org/show_bug.cgi?id=78178
Reviewed by Eric Seidel.
- Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):
- 4:30 PM Changeset in webkit [107152] by
-
- 3 edits3 adds1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/mac-future/svg/carto.net: Added.
- platform/mac-future/svg/carto.net/scrollbar-expected.png: Added.
- platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Added.
Updated the baseline here, thanks to the text on the button...
- platform/chromium/test_expectations.txt:
Marked one test as failing as some output don't make much sense.
- 4:27 PM Changeset in webkit [107151] by
-
- 7 edits in trunk/Tools
webkitpy should reply upon the multiprocessing package existing
https://bugs.webkit.org/show_bug.cgi?id=78176
Reviewed by Eric Seidel.
Now that we don't support Python 2.5, this import can't fail.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(_Process):
(_Process.init):
(_Process.run):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(FunctionTests.test_getprocesses):
(MultiProcessBrokerTests.setUp):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
(Port.default_worker_model):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.check_build):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_default_worker_model):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- 4:25 PM Changeset in webkit [107150] by
-
- 2 edits in trunk/Tools
Unreviewed typo fix that makes docs build again for the gtk2-based
library.
- gtk/generate-gtkdoc:
- 4:24 PM Changeset in webkit [107149] by
-
- 3 edits in trunk/Source/WebCore
Simplify and correct mutation delivery timing for JSC
https://bugs.webkit.org/show_bug.cgi?id=78172
Reviewed by Adam Barth.
Instead of keeping a static recursion counter in JSMainThreadExecState,
simply wait for a state change from non-null ExecState to null ExecState.
Because s_mainThreadState is initially null, this equivalent to
waiting for s_recursionLevel to rewind to zero.
This also properly handles the usage of JSMainThreadNullState (and
does not do mutation delivery), since that class is only used by
non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
fails, whereas it was passing before due to usage of the ObjC DOM API
from DumpRenderTree.
- bindings/js/JSMainThreadExecState.cpp:
(WebCore):
- bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
(WebCore):
- 4:21 PM Changeset in webkit [107148] by
-
- 4 edits in trunk/Source/WebCore
Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
https://bugs.webkit.org/show_bug.cgi?id=78100
Reviewed by Eric Seidel.
Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
- html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec
says HTMLInputElement.size should be unsigned long.
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)
- 4:10 PM Changeset in webkit [107147] by
-
- 2 edits in trunk/Tools
Don't re-implement ZipFile.extractall
https://bugs.webkit.org/show_bug.cgi?id=78173
Reviewed by Eric Seidel.
We can use ZipFile.extractall now that we don't support Python 2.5.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._extract_targz):
(AutoInstaller._unzip):
- 4:04 PM Changeset in webkit [107146] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78088
Reviewed by Antonio Gomes.
WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.
Build fix, no new tests.
- bindings/js/JSEntryCustom.cpp:
(WebCore::toJS):
- bindings/js/JSEntrySyncCustom.cpp:
(WebCore::toJS):
- 3:59 PM Changeset in webkit [107145] by
-
- 5 edits2 deletes in trunk/Tools
Remove the ospath compat shim from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78170
Reviewed by Eric Seidel.
We no longer need this compat shim now that we don't support Python 2.5.
- Scripts/webkitpy/common/checkout/scm/git.py:
- Scripts/webkitpy/common/checkout/scm/svn.py:
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.relpath):
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.relpath):
- Scripts/webkitpy/common/system/ospath.py: Removed.
- Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
- 3:57 PM Changeset in webkit [107144] by
-
- 2 edits in trunk/Tools
Build fix attempt after r107053.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):
- 3:48 PM Changeset in webkit [107143] by
-
- 12 edits6 adds in trunk
[Chromium] Fix opaque tracking for box shadows and non-composited child elements
https://bugs.webkit.org/show_bug.cgi?id=78073
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-08
Reviewed by Stephen White.
Source/WebCore:
Tests: compositing/culling/scrolled-within-boxshadow.html
compositing/culling/translated-boxshadow.html
Unit tests: PlatformContextSkiaTest.cpp
When painting a box shadow, a filter is applied to the skia canvas, that can make
pixels painted with an opaque color end up non-opaque. So consider image/mask/color
filters when deciding if a paint is opaque.
Also when painting the background of an element with a box shadow, the background is
painted with a transform on the skia canvas based on the size of the box shadow. This
transform needs to be considered when tracking an opaque paint.
However, when a layer's contentRect position is non-zero, we translate the GraphicsContext
to put the contentRect at 0,0 in the skia canvas. For tracking opaque regions in the resulting
layer, we need to unto this translation. Scaling can also occur which we must undo. So we pass
the transform in to PlatformContextSkia to go from the SkCanvas back to the layer's content
coordinate space. Opaque paints can then be tracked in the layer's content space rather than
in the skia canvas space.
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(WebCore):
(CanvasLayerTextureUpdater):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
- platform/graphics/skia/OpaqueRegionSkia.h:
(WebCore):
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::setOpaqueRegionTransform):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
LayoutTests:
- compositing/culling/scrolled-within-boxshadow-expected.png: Added.
- compositing/culling/scrolled-within-boxshadow-expected.txt: Added.
- compositing/culling/scrolled-within-boxshadow.html: Added.
- compositing/culling/translated-boxshadow-expected.png: Added.
- compositing/culling/translated-boxshadow-expected.txt: Added.
- compositing/culling/translated-boxshadow.html: Added.
- 3:46 PM Changeset in webkit [107142] by
-
- 1050 edits233 copies1 add50 deletes in branches/subpixellayout
Merging trunk changes up until 107124 into subpixel branch.
- 3:35 PM Changeset in webkit [107141] by
-
- 1 edit1 delete in trunk/Tools
Remove simplejson because it's no longer used by webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78164
Reviewed by Eric Seidel.
All the importers of this code were removed in a previous patch.
- Scripts/webkitpy/thirdparty/simplejson: Removed.
- Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
- Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
- Scripts/webkitpy/thirdparty/simplejson/init.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
- Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
- Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
- 3:34 PM Changeset in webkit [107140] by
-
- 2 edits9 adds1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
- platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.
Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.
- platform/chromium/test_expectations.txt:
Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.
- 3:26 PM Changeset in webkit [107139] by
-
- 12 edits in trunk/Tools
webkitpy still imports simplejson
https://bugs.webkit.org/show_bug.cgi?id=78161
Reviewed by Eric Seidel.
We no longer support Python 2.5, so we can rely upon Python's built-in
JSON package.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/resultsjsonparser.py:
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/style/checkers/jsonchecker.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
- Scripts/webkitpy/tool/servers/reflectionhandler.py:
- 3:20 PM Changeset in webkit [107138] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118
- gtk/common.py:
(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.
- 3:14 PM Changeset in webkit [107137] by
-
- 4 edits in trunk/Source/WebCore
Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
https://bugs.webkit.org/show_bug.cgi?id=78089
Reviewed by Adam Barth.
This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on JavaScript bindings.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- dom/Node.idl:
- html/canvas/CanvasPixelArray.idl:
- 3:08 PM Changeset in webkit [107136] by
-
- 26 edits in trunk/Tools
Stop importing with_statement from the mysterious future
https://bugs.webkit.org/show_bug.cgi?id=78156
Reviewed by Eric Seidel.
The future is now! (Well, at least 2008, when Python 2.6 was released,
is no longer the future.)
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- Scripts/webkitpy/common/net/credentials_unittest.py:
- Scripts/webkitpy/common/net/file_uploader.py:
- Scripts/webkitpy/common/newstringio_unittest.py:
- Scripts/webkitpy/common/system/autoinstall.py:
- Scripts/webkitpy/common/system/crashlogs.py:
- Scripts/webkitpy/common/system/fileset.py:
- Scripts/webkitpy/common/system/filesystem.py:
- Scripts/webkitpy/common/system/filesystem_unittest.py:
- Scripts/webkitpy/common/system/path.py:
- Scripts/webkitpy/common/thread/threadedmessagequeue.py:
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/port/base.py:
(of):
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/style/filereader_unittest.py:
- Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
- Scripts/webkitpy/tool/commands/analyzechangelog.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/servers/reflectionhandler.py:
- Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
- 2:44 PM Changeset in webkit [107135] by
-
- 2 edits in trunk/Source/WebCore
Dispatch updateViewportArguments(), when Document is finished
restoring from page cache.
https://bugs.webkit.org/show_bug.cgi?id=77943
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.
Move updateViewportArguments() call from setPageInCache() to
documentDidResumeFromPageCache() to ensure, that the Document is
fully resumed from the page cache and attached to the mainframe,
when the viewport arguments are updated.
No tests. No change in behaviour.
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidResumeFromPageCache):
- 2:38 PM Changeset in webkit [107134] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
Add those 2 new baselines.
- 2:17 PM Changeset in webkit [107133] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp
Prevent painting rects that snap to zero width or height.
- 1:49 PM BuildingQt5OnHarmattan edited by
- (diff)
- 1:47 PM Changeset in webkit [107132] by
-
- 1 edit3 adds in trunk/LayoutTests
[chromium] Add a layout test for losing the compositor context with a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060
Reviewed by Eric Carlson.
Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).
Prior to r106610 this test times out in debug and crashes in ASAN.
- platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
- platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
- platform/chromium/compositing/lost-compositor-context-with-video.html: Added.
- 1:46 PM Changeset in webkit [107131] by
-
- 2 edits in trunk/Source/JavaScriptCore
Whoops, fix the build.
- 1:41 PM Changeset in webkit [107130] by
-
- 6 edits in trunk/Source
[chromium] Remove incorrect early exit in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76924
Reviewed by James Robinson.
Source/WebCore:
New unit test added to CCDamageTrackerTest.cpp
This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- 1:37 PM Changeset in webkit [107129] by
-
- 1 edit6 adds in trunk/Tools
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042
Reviewed by Antonio Gomes.
Upstream more parts of our DRT implementation.
- DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
- DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
- DumpRenderTree/blackberry/EventSender.cpp: Added.
- DumpRenderTree/blackberry/EventSender.h: Added.
- DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
- DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
- 1:35 PM Changeset in webkit [107128] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147
Reviewed by Gavin Barraclough.
Debugging is easier if we always ensure that we have a non-null
inferred name.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
- 1:32 PM Changeset in webkit [107127] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Check that we can make the SharedGraphicsContext3D current before returning
https://bugs.webkit.org/show_bug.cgi?id=78142
Reviewed by Stephen White.
If we can't make the context current, we can't use it.
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::get):
- 1:30 PM BuildingQt5OnHarmattan edited by
- (diff)
- 1:22 PM Changeset in webkit [107126] by
-
- 5 edits in trunk/Source/JavaScriptCore
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145
Reviewed by Gavin Barraclough.
Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.
- interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):
- jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):
- 1:12 PM Changeset in webkit [107125] by
-
- 8 edits in trunk/Source/WebKit/chromium
Add support for pinch gesture processing in the MT compositor.
https://bugs.webkit.org/show_bug.cgi?id=77804
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-08
Reviewed by James Robinson.
- public/WebInputEvent.h:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
- tests/WebCompositorInputHandlerImplTest.cpp:
- 1:02 PM Changeset in webkit [107124] by
-
- 3 edits in trunk/Tools
check-webkit-style failing with "Path does not exist."
https://bugs.webkit.org/show_bug.cgi?id=77873
Reviewed by Ojan Vafai.
This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.init):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- 12:53 PM Changeset in webkit [107123] by
-
- 2 edits in trunk/Source/WebCore
Crash in Node::normalize.
https://bugs.webkit.org/show_bug.cgi?id=78135
Reviewed by Ryosuke Niwa.
No new tests. Original testcase does not reduce to manageable
extent.
- dom/Node.cpp:
(WebCore::Node::normalize):
- 12:42 PM Changeset in webkit [107122] by
-
- 60 edits in trunk/LayoutTests
Update pixel table test expectations for mac to match new DRT scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76938
Rubber stamped by Eric Seidel.
- platform/mac/tables/mozilla/bugs/bug101674-expected.png:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/mac/tables/mozilla/bugs/bug11944-expected.png:
- platform/mac/tables/mozilla/bugs/bug120364-expected.png:
- platform/mac/tables/mozilla/bugs/bug131020-expected.png:
- platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug22019-expected.png:
- platform/mac/tables/mozilla/bugs/bug23151-expected.png:
- platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug29314-expected.png:
- platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug38916-expected.png:
- platform/mac/tables/mozilla/bugs/bug43039-expected.png:
- platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug44505-expected.png:
- platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug56405-expected.png:
- platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug73321-expected.png:
- platform/mac/tables/mozilla/bugs/bug92143-expected.png:
- platform/mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/mac/tables/mozilla/bugs/bug96343-expected.png:
- platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
- platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
- platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
- platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
- platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
- platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
- platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
- platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
- platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
- platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
- platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
- platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
- platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
- 12:39 PM Changeset in webkit [107121] by
-
- 2 edits in trunk/Source/WebCore
Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141
Patch by Antoine Labour <piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Covered by existing tests
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
- 12:35 PM Changeset in webkit [107120] by
-
- 15 edits in trunk
[chromium] Disable root layer clears on release builds.
https://bugs.webkit.org/show_bug.cgi?id=77478
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
LayoutTests:
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
- platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
- platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
- platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
- 12:24 PM Changeset in webkit [107119] by
-
- 6 edits in trunk/Source/WebCore
Add a content shadow layer to the render layer compositor
https://bugs.webkit.org/show_bug.cgi?id=78133
<rdar://problem/10797742>
Reviewed by Beth Dakin.
Have the render layer compositor optionally create a content shadow layer,
and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
can use to set content shadow properties.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Set the layer properties once, and set the shadow path on every call, since we know that this
function will be called every time the size of the content shadow layer changes.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
Add new helper function.
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Create a content shadow layer if needed.
- 12:20 PM Changeset in webkit [107118] by
-
- 5 edits2 adds in trunk
REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
https://bugs.webkit.org/show_bug.cgi?id=77167
Reviewed by Eric Seidel.
Source/WebCore:
Test: plugins/layout-in-beforeload-listener-affects-plugin-loading.html
r102983 made FrameView::updateWidgets() check if the DOM node actually
needs a widget update before calling updateWidget(). Due to historical
reasons, however, updateWidget() can be legitimately called twice: once
at attach time for non-Netscape plug-ins and once at layout time for
Netscape plug-ins.
If the widget represents a Netscape plug-in, but updateWidget() is
called for the CreateOnlyNonNetscapePlugins case after the DOM node was
marked as needing an update, updateWidget() will clear the update flag
and prevent a second call to updateWidget() at layout time for the
CreateAnyWidgetType case.
As much as I loathe adding to the code duplication between
HTMLEmbedElement::updateWidget() and HTMLObjectElement::updateWidget(),
the simplest solution seems to be marking the DOM node as needing
update in the case where we are calling updateWidget() for the
CreateOnlyNonNetscapePlugins case and we know we will be loading a
Netscape plug-in.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Call
setNeedsWidgetUpdate(true) if pluginCreationOption is
CreateOnlyNonNetscapePlugins but we will load a Netscape plug-in.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Ditto.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Remove an
invalid assertion that prevents the layout test from running in a Debug
configuration.
LayoutTests:
- plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
- plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.
- 12:17 PM Changeset in webkit [107117] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Make dependency on Accelerate.framework explicit.
https://bugs.webkit.org/show_bug.cgi?id=78131
It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
dependency is needed to build a libwebkit.dylib.
Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.
- WebKit.gyp:
- 12:17 PM Changeset in webkit [107116] by
-
- 2 edits in branches/chromium/1025
Merge 106888 - WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654
Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.
Test: fast/canvas/webgl/drawingbuffer-test.html
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9359020
- 12:16 PM Changeset in webkit [107115] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Don't add selection from password fields to context menu.
https://bugs.webkit.org/show_bug.cgi?id=77733
Patch by Bernhard Bauer <bauerb@google.com> on 2012-02-08
Reviewed by Adam Barth.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 12:11 PM Changeset in webkit [107114] by
-
- 19 edits28 adds8 deletes in trunk/LayoutTests
Unreviewed rebaselines for vertical text tests.
See https://bugs.webkit.org/show_bug.cgi?id=78120
- platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
[...]
- platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:59 AM Changeset in webkit [107113] by
-
- 11 edits in trunk/Tools
nrwt: make --skip-pixel-test-if-no-baseline option
https://bugs.webkit.org/show_bug.cgi?id=70484
Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2012-02-08
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
(SingleTestRunner._should_fetch_expected_checksum):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.init):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_pixel_test_if_no_baseline_option):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
- WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::setSkipPixelTestOption):
(TestInvocation):
- 11:58 AM Changeset in webkit [107112] by
-
- 3 edits2 adds in trunk
Floated flexboxes render as regular RenderBlocks
https://bugs.webkit.org/show_bug.cgi?id=77909
Reviewed by Eric Seidel.
Source/WebCore:
Add grid/flexbox cases to adjusting the display of floated/positioned
elements. Also, move this logic into a switch statement. This makes
the code more readable and gives compile warnings when new display types
are added that aren't handled here.
Test: css3/flexbox/floated-flexbox.html
- css/CSSStyleSelector.cpp:
(WebCore::adjustDisplay):
(WebCore):
(WebCore::CSSStyleSelector::adjustRenderStyle):
LayoutTests:
- css3/flexbox/floated-flexbox-expected.txt: Added.
- css3/flexbox/floated-flexbox.html: Added.
- 11:44 AM Changeset in webkit [107111] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
https://bugs.webkit.org/show_bug.cgi?id=78130
Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.
- WebKit.gyp:
- 11:29 AM Changeset in webkit [107110] by
-
- 2 edits1 delete in trunk/Source/Platform
r107042 caused compile breakages on chromium try bots
https://bugs.webkit.org/show_bug.cgi?id=78125
Reviewed by Adam Barth.
Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
basis.
- Platform.gyp/Platform.gyp:
- Platform.gyp/copy_webcore_headers.py: Removed.
- 11:26 AM Changeset in webkit [107109] by
-
- 6 edits4 adds1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.
More rebaseline of those (I pulled the trigger too early).
- platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
- platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
- platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
- platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:
Update the expected files. I don't know how we ended up with a blue color when the html specifies
an orange.
- platform/chromium/test_expectations.txt:
Mark a test as timing out as it has been raising an exception on the bots fairly regularly.
- 11:19 AM Changeset in webkit [107108] by
-
- 9 edits3 adds in trunk
viewBox on nested SVG causes wrong content size for relative values
https://bugs.webkit.org/show_bug.cgi?id=69459
Reviewed by Nikolas.
Source/WebCore:
In the past we just checked the change of the viewport size of the root SVG element. If the size changed, all childs
with relative length values needed a relayout. We did not consider that we might have other viewports in the document.
Childs with relative lengths had a strange zooming, if just the viewport size of an inner SVG element changed.
With this patch we check if the size of the nearest viewport changes. Is this the case, childs with relative lengths
need a relayout.
Test: inner-svg-change-viewBox.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/RenderSVGContainer.h:
(RenderSVGContainer):
(WebCore::RenderSVGContainer::determineIfLayoutSizeChanged): Check if we need layout and have relative length values.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout): Remove resetting 'viewport size changed' flag for code operability. No influence on the layout.
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): Add a flag that indicates that the viewport size changes.
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged): The flag gets set during the layout phase of the SVG element if the size changes.
(WebCore):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::isLayoutSizeChanged): Added getter to get flag status.
(RenderSVGViewportContainer):
(WebCore::toRenderSVGViewportContainer): Added casting function for constant RenderObjects.
(WebCore):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::layoutSizeOfNearestViewportChanged): Search the nearest viewport and check if the size changed.
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren): Don't check the roots viewport for size changes, but the nearest viewport.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged): Added viewBoxAttr to the list of attributes that cause relayout.
LayoutTests:
Test relayout of content of inner SVG on change of relative length values.
- svg/repaint/inner-svg-change-viewBox-expected.png: Added.
- svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
- svg/repaint/inner-svg-change-viewBox.svg: Added.
- 11:13 AM Changeset in webkit [107107] by
-
- 21 edits1 copy1 move1 add2 deletes in trunk
Implement new WEBGL compressed texture extensions
https://bugs.webkit.org/show_bug.cgi?id=77066
Source/WebCore:
This removes the old experimental compressed
texture extension and implements the first new
one.
A test is in the WebGL conformance tests in
extensions/webgl-compressed-texture-s3tc.html
and will be copied here in a future patch.
Patch by Gregg Tavares <gman@google.com> on 2012-02-08
Reviewed by Kenneth Russell.
No new tests. Test coming in future patch.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLCompressedTextureS3TC.cpp: Added.
(WebCore):
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::~WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::getName):
(WebCore::WebGLCompressedTextureS3TC::create):
(WebCore::WebGLCompressedTextureS3TC::supported):
- html/canvas/WebGLCompressedTextureS3TC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLCompressedTextureS3TC):
- html/canvas/WebGLCompressedTextureS3TC.idl: Renamed from Source/WebCore/html/canvas/WebGLCompressedTextures.idl.
- html/canvas/WebGLCompressedTextures.cpp: Removed.
- html/canvas/WebGLCompressedTextures.h: Removed.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore):
(WebCore::WebGLGetInfo::getWebGLUnsignedIntArray):
- html/canvas/WebGLGetInfo.h:
- html/canvas/WebGLObject.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::addCompressedTextureFormat):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFormat):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- html/canvas/WebGLRenderingContext.idl:
LayoutTests:
Patch by Gregg Tavares <Gregg Tavares> on 2012-02-08
Reviewed by Kenneth Russell.
- fast/canvas/webgl/constants.html:
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- 10:49 AM Changeset in webkit [107106] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113
Retaining path list was replaced with Retaining tree some time ago.
But it was not so useful when we want to track the retaining path from an object to a DOM Window node.
Drive by fix: sort doesn't work in retaining tree panel.
Drive by fix: save/load child nodes doesn't work for the retaining tree panel.
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndEdge):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
- inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid td.distanceToWindow-column):
- 10:35 AM Changeset in webkit [107105] by
-
- 2 edits4 adds in trunk
[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042
Patch by Rob Buis <rbuis@rim.com> on 2012-02-08
Reviewed by Antonio Gomes.
Source/WebKit:
Add abstract interface for our DumpRenderTree solution.
- blackberry/Api/DumpRenderTreeClient.h: Added.
Tools:
Add implementation for our DumpRenderTree solution.
- DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
- 10:29 AM Changeset in webkit [107104] by
-
- 2 edits in trunk/LayoutTests
[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=78128
- platform/qt/Skipped: Skip it until fix.
- 10:27 AM Changeset in webkit [107103] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed morning gardening.
- platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.
Rebaselined this file (font difference).
- platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.
- 10:00 AM Changeset in webkit [107102] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
https://bugs.webkit.org/show_bug.cgi?id=78126
Reviewed by Dan Bernstein.
This broke in r106977 when I tried to change an early return into an ASSERT,
so let's bring back the early return.
- page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
- 9:56 AM Changeset in webkit [107101] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r106920, r106924, r106933, r106939,
and r107090.
http://trac.webkit.org/changeset/106920
http://trac.webkit.org/changeset/106924
http://trac.webkit.org/changeset/106933
http://trac.webkit.org/changeset/106939
http://trac.webkit.org/changeset/107090
https://bugs.webkit.org/show_bug.cgi?id=78124
Something is completely wrong this change (Requested by
Ossy_gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08
Source/WebCore:
- platform/FileSystem.h:
(WebCore):
- platform/qt/FileSystemQt.cpp:
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):
- 9:35 AM Changeset in webkit [107100] by
-
- 4 edits1 add in trunk
REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
https://bugs.webkit.org/show_bug.cgi?id=78080
Source/WebKit/mac:
Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):
Tools:
Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
Add API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 9:34 AM Changeset in webkit [107099] by
-
- 3 edits3 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78122
Add support for the "contains" value for line-grid-snap. This value centers the line box in between the
text-top and text-bottom of the minimum number of grid lines that enclose the line box. This is useful for
centering headers in a line grid.
Reviewed by Adam Roben.
Added a new test in fast/line-grid.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineGridSnapAdjustment):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78122
Add a new test that shows the "contains" value in action.
Reviewed by Adam Roben.
- fast/line-grid/line-grid-contains-value.html: Added.
- platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
- platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
- 9:31 AM Changeset in webkit [107098] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-02-08
Reviewed by Martin Robinson.
- gtk/common.py:
(get_build_path): also try the current directory as a valid build
dir, which makes non-standard build directories such as build-2.0
and build-3.0 work
- 9:15 AM Changeset in webkit [107097] by
-
- 2 edits in trunk/Source/WebCore
[Skia Mac] Make misspelling underline dots unclipped
https://bugs.webkit.org/show_bug.cgi?id=78117
http://code.google.com/p/chromium/issues/detail?id=113154
Reviewed by Stephen White.
No new tests. Existing layout tests cover this.
As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
- 9:05 AM Changeset in webkit [107096] by
-
- 1 edit2 moves in trunk/LayoutTests
Moved a Mac-specific test to platform/mac.
- fast/text/synthetic-bold-transformed-expected.html: Removed.
- fast/text/synthetic-bold-transformed.html: Removed.
- platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
- platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.
- 9:01 AM Changeset in webkit [107095] by
-
- 1 edit2 adds in trunk/Source/WebKit
Initial upstreaming of input handling for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77992
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-08
Reviewed by Rob Buis.
- blackberry/WebKitSupport/InputHandler.cpp: Added.
- blackberry/WebKitSupport/InputHandler.h: Added.
- 8:57 AM Changeset in webkit [107094] by
-
- 26 edits in trunk
Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007
This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 8:42 AM Changeset in webkit [107093] by
-
- 5 edits in trunk
Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
https://bugs.webkit.org/show_bug.cgi?id=78116
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):
LayoutTests:
- inspector/elements/insert-node-expected.txt:
- inspector/elements/insert-node.html:
- 8:31 AM Changeset in webkit [107092] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Fix a crash when WebKitWebView is created without a WebContext
https://bugs.webkit.org/show_bug.cgi?id=78104
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.
- 8:17 AM Changeset in webkit [107091] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
https://bugs.webkit.org/show_bug.cgi?id=77967
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-08
Reviewed by Yury Semikhatsky.
Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.
- inspector/CodeGeneratorInspector.py:
(Generator.process_command):
- 8:02 AM Changeset in webkit [107090] by
-
- 4 edits in trunk
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.
LayoutTests:
- platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.
- 7:51 AM Changeset in webkit [107089] by
-
- 12 edits in trunk/Source/WebCore
Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
https://bugs.webkit.org/show_bug.cgi?id=77972
When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.
Reviewed by Pavel Feldman.
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
- bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
- bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- inspector/Inspector.json:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
- inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
- 7:51 AM Changeset in webkit [107088] by
-
- 2 edits in trunk/Tools
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78099
Reviewed by Martin Robinson.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.
- 7:48 AM Changeset in webkit [107087] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix WebKitWebView::decide-policy API documentation
https://bugs.webkit.org/show_bug.cgi?id=78101
Reviewed by Martin Robinson.
- It refers to WebKitPolicyClient instead of WebKitWebView
- Trailing ':' is missing
- References @decision as WebKitNavigationPolicyDecision instead
of WebKitPolicyDecision
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
- 7:38 AM Changeset in webkit [107086] by
-
- 4 edits in trunk/Source
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=73431
Reviewed by Chris Fleizach.
Source/WebCore:
Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.
Source/WebKit/gtk:
Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.
- 7:11 AM Changeset in webkit [107085] by
-
- 2 edits in trunk/Source/WebKit/qt
Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022
Patch by Leo Franchi <lfranchi@kde.org> on 2012-02-08
Reviewed by Joseph Pecoraro.
- WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
- 6:57 AM Changeset in webkit [107084] by
-
- 1 edit12 adds in trunk/LayoutTests
Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.
- platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- 6:49 AM Changeset in webkit [107083] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: do not clear entire tree map upon last element deletion.
https://bugs.webkit.org/show_bug.cgi?id=78112
Reviewed by Yury Semikhatsky.
- inspector/front-end/treeoutline.js:
(TreeOutline.prototype._forgetChildrenRecursive):
- 6:39 AM Changeset in webkit [107082] by
-
- 23 edits1 copy2 adds in trunk
Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
Move createObjectURL & revokeObjectURL from DOMURL implementation to
static methods as per specs - http://www.w3.org/TR/FileAPI/#creating-revoking
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
- dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
- html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
- html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
- html/DOMURL.idl:
- html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
- page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
- page/DOMWindow.h: ditto.
(DOMWindow):
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WorkerContext):
- workers/WorkerContext.idl:
LayoutTests:
Added test to check if createObjectURL & revokeObjectURL are static functions.
- fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
- platform/gtk/fast/js/global-constructors-expected.txt: ditto.
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
- platform/qt/fast/js/global-constructors-expected.txt: ditto.
- 6:06 AM Changeset in webkit [107081] by
-
- 2 edits in trunk/LayoutTests
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.
- platform/chromium/test_expectations.txt:
- 6:02 AM Changeset in webkit [107080] by
-
- 1 edit21 adds in trunk/LayoutTests
Unreviewed, update chromium svg expectations after r107067.
- platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.
- 5:48 AM WebKitGTK/1.6.x edited by
- (diff)
- 5:47 AM WebKitGTK/1.6.x edited by
- (diff)
- 5:22 AM Changeset in webkit [107079] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Add changes for Spectrum colorpicker
https://bugs.webkit.org/show_bug.cgi?id=75454
Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-01
Reviewed by Pavel Feldman.
- inspector/front-end/Color.js:
(WebInspector.Color.fromRGB):
- inspector/front-end/utilities.js:
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():
- 5:00 AM Changeset in webkit [107078] by
-
- 2 edits in trunk/LayoutTests
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
https://bugs.webkit.org/show_bug.cgi?id=78084
- platform/chromium/test_expectations.txt:
- 4:59 AM Changeset in webkit [107077] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline and skipping 2 new failing tests.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- 4:58 AM Changeset in webkit [107076] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=78102
Reviewed by Vsevolod Vlasov.
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
- 4:48 AM Changeset in webkit [107075] by
-
- 5 edits in trunk/LayoutTests
[Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093
Unskip these tests and rebaselines for Qt and GTK.
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.
- platform/gtk/Skipped:
- platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
- platform/qt/Skipped:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
- 4:38 AM Changeset in webkit [107074] by
-
- 7 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.
- platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/qt/svg/custom/getTransformToElement-expected.png:
- platform/qt/svg/custom/getTransformToElement-expected.txt:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
- platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
- platform/qt/svg/custom/text-ctm-expected.png:
- platform/qt/svg/custom/text-ctm-expected.txt:
- platform/qt/svg/custom/text-hit-test-expected.png:
- platform/qt/svg/custom/text-hit-test-expected.txt:
- 4:37 AM Changeset in webkit [107073] by
-
- 3 edits in trunk/LayoutTests
2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline Gtk/SVG results.
- platform/gtk/svg/carto.net/scrollbar-expected.txt:
- platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
- 4:34 AM Changeset in webkit [107072] by
-
- 4 edits6 adds in trunk
CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
https://bugs.webkit.org/show_bug.cgi?id=69993
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-08
Reviewed by Simon Fraser.
Source/WebCore:
The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.
Tests: fast/css/getComputedStyle/computed-style-select-overflow.html
fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
LayoutTests:
- fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
- fast/forms/select-overflow-scroll-inherited.html: Added.
- fast/forms/select-overflow-scroll.html: Added.
- platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- 4:31 AM Changeset in webkit [107071] by
-
- 7 edits in trunk/LayoutTests
qt fixes
- 4:24 AM Changeset in webkit [107070] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Build broken if qt missing openssl
https://bugs.webkit.org/show_bug.cgi?id=77894
Reviewed by Chang Shu.
Build fix. No new test content.
- WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::onSslErrors):
- 4:18 AM Changeset in webkit [107069] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rebaselined the test that has been failing since r107046.
- http/tests/security/cross-frame-access-put-expected.txt:
- 4:13 AM Changeset in webkit [107068] by
-
- 11 edits in trunk/Source/WebKit2
[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968
Reviewed by Simon Hausmann.
Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.
- UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyiconURL):
- UIProcess/API/C/WKNotification.h:
- UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
- UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
- 4:12 AM Changeset in webkit [107067] by
-
- 9 edits14 copies10 moves19 adds in trunk
feImage doesn't invalidate when its target SVG element is animated
https://bugs.webkit.org/show_bug.cgi?id=73860
Reviewed by Dirk Schulze.
Source/WebCore:
Consider following testcase:
<defs>
<rect id="rect" fill="red" width="50" height="50"/>
<filter id="filter">
<feImage xlink:href="#rect"/>
</filter>
</defs>
<rect width="50" height="50" filter="url(#filter)"/>
If the <rect id="rect"> gets changed dynamically (attribute/property/style change) the <feImage>
doesn't notice this, as there's no link between the <rect> and the <feImage>, as the <rect> is not
a child of the <feImage/>. To get invalidations working for these situations, we have to track
the referencingElement & referencedElement in SVGDocumentExtensions.
Fixes parts the SVG-Wow twirl testcase and David Daileys SVG waves example.
Tests: svg/filters/feImage-animated-transform-on-target-rect.svg
svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-mutliple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-target-style-change.svg
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromFilterCacheAndInvalidateDependencies): Renamed from removeFromFilterCache, as it has another purpose now.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): s/removeFromFilterCache/removeFromFilterCacheAndInvalidateDependencies/.
- rendering/svg/RenderSVGResource.h: Removed removeFromFilterCache, it got inlined.
- svg/SVGDocumentExtensions.cpp: Add a new HashMap<SVGElement*, OwnPtr<HashSet<SVGElement*> > > used for dependency tracking.
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Returns all elements the passed in element depends on.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Register element 'a' referencing target 'b'.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Called by element 'a' on destruction or any target change.
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Called by element 'b' on destruction.
- svg/SVGDocumentExtensions.h: Expose new methods.
- svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement): Call remove removeAllElementReferencesForTarget on destruction.
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):
LayoutTests:
Add lots of new testcases covering <feImage> invalidation, when the referenced target changes.
Thanks to the repaint harness, it uncovered a bug with feImage-late-indirect-update.svg - there no gray
overlay rects are visible, as the whole screen gets repainted, which is a bug!
- platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/mac/svg/filters/feImage-change-target-id-expected.png: Added.
- platform/mac/svg/filters/feImage-change-target-id-expected.txt: Added.
- platform/mac/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/mac/svg/filters/feImage-late-indirect-update-expected.txt: Added.
- platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
- platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
- platform/mac/svg/filters/feImage-remove-target-expected.png: Added.
- platform/mac/svg/filters/feImage-remove-target-expected.txt: Added.
- platform/mac/svg/filters/feImage-target-add-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-add-to-document-expected.png.
- platform/mac/svg/filters/feImage-target-add-to-document-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt.
- platform/mac/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/mac/svg/filters/feImage-target-attribute-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
- platform/mac/svg/filters/feImage-target-changes-id-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.png.
- platform/mac/svg/filters/feImage-target-changes-id-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
- platform/mac/svg/filters/feImage-target-id-change-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.png.
- platform/mac/svg/filters/feImage-target-id-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.txt.
- platform/mac/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/mac/svg/filters/feImage-target-inline-style-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
- platform/mac/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/mac/svg/filters/feImage-target-property-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
- platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png.
- platform/mac/svg/filters/feImage-target-reappend-to-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt.
- platform/mac/svg/filters/feImage-target-remove-from-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png.
- platform/mac/svg/filters/feImage-target-remove-from-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt.
- platform/mac/svg/filters/feImage-target-style-change-expected.png: Added.
- platform/mac/svg/filters/feImage-target-style-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
- svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
- svg/filters/feImage-animated-transform-on-target-rect.svg: Added.
- svg/filters/feImage-change-target-id.svg: Added.
- svg/filters/feImage-late-indirect-update.svg: Added.
- svg/filters/feImage-multiple-targets-id-change.svg: Added.
- svg/filters/feImage-remove-target.svg: Added.
- svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg: Added.
- svg/filters/feImage-target-attribute-change-with-use-indirection.svg: Added.
- svg/filters/feImage-target-attribute-change.svg: Added.
- svg/filters/feImage-target-inline-style-change.svg: Added.
- svg/filters/feImage-target-property-change.svg: Added.
- svg/filters/feImage-target-style-change.svg: Added.
- 4:02 AM Changeset in webkit [107066] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- 3:53 AM Changeset in webkit [107065] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Using string method instead of char* operation in the platformLanguage().
https://bugs.webkit.org/show_bug.cgi?id=78077
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.
No new tests. Just fix a bug of platformLanguage function.
- platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):
Change char* operation to string operation.
- 3:40 AM Changeset in webkit [107064] by
-
- 2 edits in trunk/Tools
Revert a part of the change in r106687 as a build fix.
Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run "svn info" on webkit_base.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
- 3:15 AM Changeset in webkit [107063] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:13 AM Changeset in webkit [107062] by
-
- 3 edits3 adds in trunk
Web Inspector: Touch event emulation fails for iframes
https://bugs.webkit.org/show_bug.cgi?id=77987
Reviewed by Pavel Feldman.
Source/WebCore:
Test: fast/events/touch/emulated-touch-iframe.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
LayoutTests:
- fast/events/touch/emulated-touch-iframe-expected.txt: Added.
- fast/events/touch/emulated-touch-iframe.html: Added.
- fast/events/touch/resources/emulated-touch-iframe2.html: Added.
- 3:03 AM Changeset in webkit [107061] by
-
- 2 edits in trunk/Source/WebCore
StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
<http://webkit.org/b/78068>
Rubber-stamped by Ryosuke Niwa.
Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).
- dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
- 2:55 AM Changeset in webkit [107060] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r107050.
http://trac.webkit.org/changeset/107050
https://bugs.webkit.org/show_bug.cgi?id=78094
May crash editing tests (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
- 2:42 AM Changeset in webkit [107059] by
-
- 5 edits in trunk
[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=77995
Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-08
Reviewed by Csaba Osztrogonác.
Source/WebCore:
From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.
Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.
- svg/graphics/SVGImage.h:
LayoutTests:
- platform/qt/Skipped: Unskip previously skipped tests.
- 2:39 AM Changeset in webkit [107058] by
-
- 8 edits4 adds in trunk
Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
Tests: fast/loader/stateobjects/state-attribute-object-types.html
fast/loader/stateobjects/state-attribute-only-one-deserialization.html
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):
- page/History.cpp:
(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):
- page/History.h:
(History):
- page/History.idl:
LayoutTests:
- fast/dom/Window/window-appendages-cleared-expected.txt:
- fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
- fast/loader/stateobjects/state-attribute-object-types.html: Added.
- fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
- fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.
- 2:21 AM Changeset in webkit [107057] by
-
- 64 edits in trunk
SVGLoad event fires too early
https://bugs.webkit.org/show_bug.cgi?id=78084
Reviewed by Hajime Morita.
Source/WebCore:
SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest).
We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer,
which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event",
thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document,
<svg onload="alert(evt.target)"> will say SVGSVGElement).
Consider:
<svg onload="alert('1')>
<g onload="alert('2)">
<rect onload="alert('3')"/>
</svg>
As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired.
So first you'll see '3', then '2', then '1'.
Using:
<svg onload="alert('1')>
<g onload="alert('2)">
<image xlink:href="someExternal.jpg" onload="alert('3')"/>
</svg>
will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire,
then '3', then '2', all as expected and specified in SVG.
http://www.w3.org/TR/SVG/interact.html#LoadEvent says:
"The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is
ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced
external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional
external resources are not required to be ready for the event to be triggered."
What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that
element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after
</svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for
WebKit, as we're not yet "ready to render".
HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent.
At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be
equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks.
Covered by existing tests.
- dom/Document.cpp:
(WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event.
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible.
There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element.
- svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper.
- svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG().
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet.
(WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements.
- svg/SVGElement.h: Add isOutermostSVGSVGElement().
- svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement.
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::createRenderer):
- svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement.
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement.
LayoutTests:
Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly.
This is now possible as the outermost <svg> elements load event timing as aligned with HTML.
- fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed.
(runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken).
- platform/chromium/test_expectations.txt:
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/mac/svg/custom/getTransformToElement-expected.png:
- platform/mac/svg/custom/getTransformToElement-expected.txt:
- platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
- platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
- platform/mac/svg/custom/text-ctm-expected.png:
- platform/mac/svg/custom/text-ctm-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.png:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- platform/mac/svg/filters/filter-refresh-expected.png:
- svg/carto.net/tabgroup.svg:
- svg/carto.net/window.svg:
- svg/css/shadow-changes.svg:
- svg/custom/loadevents-externalresourcesrequired.svg:
- svg/dom/SVGPathSegList-segment-modification.svg:
- svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
- svg/dom/SVGRectElement/rect-modify-rx.svg:
- svg/filters/animate-fill.svg:
- svg/filters/feImage-reference-invalidation.svg:
- svg/filters/feImage-target-add-to-document.svg:
- svg/filters/feImage-target-changes-id.svg:
- svg/filters/feImage-target-id-change.svg:
- svg/filters/feImage-target-reappend-to-document.svg:
- svg/filters/feImage-target-remove-from-document.svg:
- svg/filters/filter-refresh.svg:
- svg/filters/filter-width-update.svg:
- svg/filters/invalidate-on-child-layout.svg:
- svg/hixie/perf/001.xml:
- svg/hixie/perf/002.xml:
- svg/hixie/perf/003.xml:
- svg/hixie/perf/004.xml:
- svg/hixie/perf/005.xml:
- svg/hixie/perf/006.xml:
- svg/hixie/perf/007.xml:
- svg/repaint/container-repaint.svg:
- svg/repaint/filter-child-repaint.svg:
- svg/repaint/image-href-change.svg:
- svg/repaint/image-with-clip-path.svg:
- svg/text/text-text-05-t.svg:
- svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
- svg/zoom/page/absolute-sized-document-scrollbars.svg:
- svg/zoom/page/relative-sized-document-scrollbars.svg:
- svg/zoom/page/zoom-coords-viewattr-01-b.svg:
- svg/zoom/page/zoom-foreignObject.svg:
- svg/zoom/page/zoom-mask-with-percentages.svg:
- svg/zoom/resources/testPageZoom.js:
(repaintTest):
- svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
- svg/zoom/text/absolute-sized-document-scrollbars.svg:
- svg/zoom/text/relative-sized-document-scrollbars.svg:
- svg/zoom/text/zoom-coords-viewattr-01-b.svg:
- svg/zoom/text/zoom-foreignObject.svg:
- 2:11 AM Changeset in webkit [107056] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
https://bugs.webkit.org/show_bug.cgi?id=78090
Reviewed by Vsevolod Vlasov.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):
- 2:00 AM Changeset in webkit [107055] by
-
- 7 edits2 adds in trunk
Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/lazy-computed-style.html
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
- inspector/elements/elements-panel-styles.html:
- inspector/styles/css-live-edit.html:
- inspector/styles/lazy-computed-style-expected.txt: Added.
- inspector/styles/lazy-computed-style.html: Added.
- inspector/styles/styles-computed-trace.html:
- 1:52 AM Changeset in webkit [107054] by
-
- 6 edits in trunk/Source/WebCore
MediaStream API: Adding the onstatechange callback to PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=77954
When readyState changes a callback should be triggered.
Reviewed by Adam Barth.
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- dom/EventNames.h:
(WebCore):
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::changeReadyState):
- mediastream/PeerConnection.h:
(PeerConnection):
(WebCore::PeerConnection::didChangeState):
- mediastream/PeerConnection.idl:
- platform/mediastream/PeerConnectionHandlerClient.h:
(PeerConnectionHandlerClient):
- 1:51 AM Changeset in webkit [107053] by
-
- 3 edits in trunk/Tools
run-perf-tests doesn't recognize paths that start with PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=78012
Reviewed by Adam Barth.
Use resolve paths using filesystem.relpath before passing it to find_files.find.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests):
(test_collect_tests.add_file):
- 1:17 AM Changeset in webkit [107052] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.
- platform/qt/Skipped:
- platform/wk2/Skipped:
- 12:57 AM Changeset in webkit [107051] by
-
- 12 edits in trunk/Source/WebCore
Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963
Reviewed by Adam Barth.
This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
- bindings/scripts/test/TestInterface.idl:
- css/CSSStyleDeclaration.idl:
- dom/DOMStringMap.idl:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- 12:57 AM Changeset in webkit [107050] by
-
- 7 edits in trunk
Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.
ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.
No new tests, no change in behavior.
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
- 12:47 AM Changeset in webkit [107049] by
-
- 1 edit2 adds in trunk/LayoutTests
2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing results for a new SVG test.
- platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
- platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- 12:37 AM Changeset in webkit [107048] by
-
- 2 edits in trunk/LayoutTests
2012-02-08 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 12:29 AM Changeset in webkit [107047] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.
- 12:13 AM Changeset in webkit [107046] by
-
- 4 edits3 adds in trunk
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971
Reviewed by Adam Barth.
Source/WebCore:
[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].
Test: http/tests/security/cross-frame-access-frameelement.html
- page/DOMWindow.idl:
LayoutTests:
The added test checks if frameElement is accessible from the same or cross origin iframe.
- http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
- http/tests/security/cross-frame-access-frameelement.html: Added.
- http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
- platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
- 12:05 AM Changeset in webkit [107045] by
-
- 4 edits in trunk/Source/WebCore
Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081
Reviewed by Adam Barth.
[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- dom/Node.idl:
- html/HTMLElement.idl:
- 12:05 AM Changeset in webkit [107044] by
-
- 5 edits in trunk/Source/WebKit2
[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959
Reviewed by Martin Robinson.
Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
Feb 7, 2012:
- 11:21 PM Changeset in webkit [107043] by
-
- 6 edits3 adds in trunk/Source/WebKit2
[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789
Reviewed by Philippe Normand.
Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.
- GNUmakefile.am: Added new source files to the list.
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
- UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
- UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
- UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:
(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.
- 10:56 PM Changeset in webkit [107042] by
-
- 11 edits6 copies1 move1 add in trunk/Source
[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067
Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
Source/Platform:
This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.
Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.
- Platform.gyp/Platform.gyp:
- Platform.gyp/copy_webcore_headers.py: Added.
(CopyHeaders):
(Main):
- chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.
(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.
(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):
- chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.
(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.
(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.
(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.
(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):
Source/WebKit/chromium:
Add forwarding headers for several API types moved into Platform.
- public/platform/WebFloatPoint.h:
- public/platform/WebFloatQuad.h:
- public/platform/WebFloatRect.h:
- public/platform/WebPoint.h:
- public/platform/WebRect.h:
- public/platform/WebSize.h:
- 10:40 PM Changeset in webkit [107041] by
-
- 51 edits in trunk/Source/WebCore
Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846
Reviewed by Darin Adler.
In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:
[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/TestTypedArray.idl:
- dom/Attr.idl:
- dom/DataTransferItemList.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Node.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.idl:
- fileapi/File.idl:
- fileapi/FileEntry.idl:
- fileapi/FileEntrySync.idl:
- fileapi/WebKitBlobBuilder.idl:
- html/DOMFormData.idl:
- html/DOMURL.idl:
- html/HTMLAppletElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLTableCaptionElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLVideoElement.idl:
- html/TextTrackCue.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- mediastream/LocalMediaStream.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/StorageInfo.idl:
- svg/SVGElement.idl:
- svg/SVGElementInstance.idl:
- workers/DedicatedWorkerContext.idl:
- workers/SharedWorker.idl:
- workers/SharedWorkerContext.idl:
- workers/Worker.idl:
- workers/WorkerContext.idl:
- 10:33 PM Changeset in webkit [107040] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066
Reviewed by Ryosuke Niwa.
Added a new default constructor. ex-default constructor will be removed
in an upcoming change.
- public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):
- 9:47 PM Changeset in webkit [107039] by
-
- 6 edits11 moves2 adds2 deletes in trunk/Source/WebCore
Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076
Reviewed by Adam Barth.
This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].
Test: bindings/scripts/test/TestCustomNamedGetter.idl
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):
- html/HTMLDocument.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameSetElement.idl:
- bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.
- bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):
- bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.
(WebCore):
(WebDOMTestCustomNamedGetter):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.
(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.
(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.
(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
- bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.
(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.
(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- 9:37 PM Changeset in webkit [107038] by
-
- 3 edits in trunk/Source/WebCore
Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918
Reviewed by Eric Seidel.
Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.
No new tests.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):
- 9:34 PM Changeset in webkit [107037] by
-
- 4 edits in trunk/Source/WebKit/chromium
Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061
Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- 9:06 PM Changeset in webkit [107036] by
-
- 22 edits10 deletes in trunk
Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
- wtf/Platform.h:
Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
- WebCore.gypi:
- platform/PlatformGestureRecognizer.h: Removed.
- platform/chromium/FramelessScrollView.h:
(WebCore):
(FramelessScrollView):
- platform/chromium/GestureRecognizerChromium.cpp: Removed.
- platform/chromium/GestureRecognizerChromium.h: Removed.
- platform/chromium/PopupContainer.cpp:
(WebCore):
- platform/chromium/PopupContainer.h:
- platform/chromium/PopupListBox.cpp:
(WebCore):
- platform/chromium/PopupListBox.h:
(PopupListBox):
Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
- blackberry/WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
- WebKit.gypi:
- features.gypi:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/InnerGestureRecognizerTest.cpp: Removed.
LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.
- fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
- fast/events/touch/page-scaled-touch-gesture-click.html:
- fast/events/touch/touch-gesture-click-expected.txt: Removed.
- fast/events/touch/touch-gesture-click.html: Removed.
- fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
- fast/events/touch/touch-gesture-scroll.html: Removed.
- platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
- platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
- 8:23 PM Changeset in webkit [107035] by
-
- 9 edits1 delete in trunk
[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052
Reviewed by Nate Chapin.
Source/WebCore:
Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.
Covered by existing tests
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 8:14 PM Changeset in webkit [107034] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059
Reviewed by Adam Barth.
CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- 8:05 PM Changeset in webkit [107033] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
- 7:56 PM Changeset in webkit [107032] by
-
- 14 edits in trunk/Source/WebCore
Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040
Reviewed by Eric Seidel.
Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.
When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.
In summary, the values are computed as follows:
x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)
We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.
No new tests, no functionality changes.
- page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
- rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
- rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- 7:53 PM Changeset in webkit [107031] by
-
- 1 edit10 adds in trunk/LayoutTests
Unreviewed gardening.
Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.
- platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
- platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
- platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
- platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
- platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- 7:40 PM Changeset in webkit [107030] by
-
- 7 edits in trunk
CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960
Source/WebCore:
Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.
Reviewed by Ojan Vafai.
- css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parsedDouble):
LayoutTests:
Reviewed by Ojan Vafai.
- css3/calc/color-hsl-expected.txt:
- css3/calc/color-rgb-expected.txt:
- 7:26 PM Changeset in webkit [107029] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>
Reviewed by Ryosuke Niwa.
Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.
- dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):
- 7:20 PM Changeset in webkit [107028] by
-
- 4 edits in trunk/Source/WebKit2
Avoid making a window for the Web Inspector when it is docked.
This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.
Reviewed by Brian Weinstein.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.
- 7:10 PM Changeset in webkit [107027] by
-
- 2 edits in trunk/Source/WebCore
Remove TextureMapperQt from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=78055
Reviewed by Noam Rosenthal.
TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.
- WebCore.gypi:
- 7:00 PM Changeset in webkit [107026] by
-
- 12 edits1 delete in trunk/Source
merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036
Reviewed by Darin Adler.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
Source/WebCore:
In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.
No new tests, build refactoring.
- Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
- DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
- DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
- WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
- css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
- css/DashboardSupportCSSPropertyNames.in: Removed.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
- 6:51 PM Changeset in webkit [107025] by
-
- 5 edits2 adds in trunk/Source/WebCore
Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.
Add the FFTFrame implementation using Intel IPP's DFT algorithm.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/audio/FFTFrame.h:
(FFTFrame):
- platform/audio/FFTFrameStub.cpp:
- platform/audio/ipp/FFTFrameIPP.cpp: Added.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):
- 6:47 PM Changeset in webkit [107024] by
-
- 3 edits in trunk/Source/WebCore
Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033
Reviewed by James Robinson.
There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 6:21 PM Changeset in webkit [107023] by
-
- 3 edits4 adds in trunk
Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907
Patch by Chris Palmer <palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.
Source/WebCore:
Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):
LayoutTests:
- http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
- http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
- http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
- http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
- 6:06 PM Changeset in webkit [107022] by
-
- 6 edits in trunk/Tools
[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039
Patch by Justin Novosad <junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.
Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setDeferred2dCanvasEnabled):
(TestShell):
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
- DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
- 6:05 PM Changeset in webkit [107021] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029
Patch by Yong Li <yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.
When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.
No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):
- 5:51 PM Changeset in webkit [107020] by
-
- 13 edits in trunk
[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928
Reviewed by Daniel Bates.
CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.
.:
- CMakeLists.txt: Set library output path.
- Source/cmake/WebKitFS.cmake: Remove *Programs* creation.
Source/JavaScriptCore:
- shell/CMakeLists.txt: Change *Programs* with *bin*.
Source/WebKit2:
- CMakeLists.txt:
Tools:
- DumpRenderTree/efl/CMakeLists.txt:
- EWebLauncher/CMakeLists.txt:
- Scripts/run-launcher:
- Scripts/webkitdirs.pm:
(jscProductDir):
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_driver):
(EflPort._path_to_image_diff):
- 5:49 PM Changeset in webkit [107019] by
-
- 20 edits in trunk
Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034
Source/WebCore:
Patch by David Barton <Dave Barton> on 2012-02-07
Reviewed by Eric Seidel.
Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.
No new tests.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore):
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):
- changed to a static member function since 'this' is unused; removed redundant non-const version
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):
- changed to a static member function since 'this' is unused; removed redundant non-const version
(WebCore):
- rendering/mathml/RenderMathMLFraction.cpp:
- rendering/mathml/RenderMathMLMath.cpp:
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLOperator.h:
(WebCore):
- rendering/mathml/RenderMathMLRoot.cpp:
- rendering/mathml/RenderMathMLRow.cpp:
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLSquareRoot.cpp:
- rendering/mathml/RenderMathMLSquareRoot.h:
- rendering/mathml/RenderMathMLSubSup.cpp:
- rendering/mathml/RenderMathMLSubSup.h:
- rendering/mathml/RenderMathMLUnderOver.cpp:
- rendering/mathml/RenderMathMLUnderOver.h:
LayoutTests:
Patch by David Barton <Dave Barton> on 2012-02-07
Reviewed by Eric Seidel.
The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.
- mathml/presentation/row.xhtml:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- 5:37 PM Changeset in webkit [107018] by
-
- 1 edit1 add in trunk/LayoutTests
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030
Unreviewed.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
- platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
- 5:28 PM Changeset in webkit [107017] by
-
- 2 edits in trunk/Source/WebKit2
Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.
If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.
- 5:16 PM Changeset in webkit [107016] by
-
- 2 edits1 delete in trunk
Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.
Move checks from webkit.m4 to configure.ac and modernize macros:
. Check for visibility flags after CXX has been defined
. Use PKG_PROG_PKG_CONFIG for pkg-config lookup
. Drop unused LIBFFTW_REQUIRED_VERSION
. Update ICU libs for mingw (bug 77837).
. Require Pango 1.21.0 (as per unicode backend)
. Bump minimum glib version due to g_thread_init changes
- Source/autotools/webkit.m4: Removed.
- configure.ac:
- 5:15 PM Changeset in webkit [107015] by
-
- 5 edits in branches/safari-534.54-branch/Source
Versioning.
- 5:03 PM Changeset in webkit [107014] by
-
- 6 edits in trunk/Source
[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020
Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.
Source/WebCore:
Revert r101854.
This patch is tested by the following unit test:
- TextureManagerTest.requestTextureExceedingPreferredLimit
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::reserve):
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture):
- platform/graphics/chromium/TextureManager.h:
(TextureManager):
Source/WebKit/chromium:
Update TextureManagerTest.requestTextureExceedingPreferredLimit test.
- tests/TextureManagerTest.cpp:
(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):
- 5:00 PM Changeset in webkit [107013] by
-
- 6 edits in trunk/Source/WebCore
Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/10247932>
Reviewed by Sam Weinig.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.
(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.
- platform/graphics/Region.cpp:
- platform/graphics/Region.h:
Add a simple contains(const IntPoint&) member function.
- 4:59 PM Changeset in webkit [107012] by
-
- 3 edits2 adds in trunk
<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044
Reviewed by Beth Dakin.
Source/WebCore:
Tests: fast/text/synthetic-bold-transformed-expected.html
fast/text/synthetic-bold-transformed.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.
LayoutTests:
- fast/text/synthetic-bold-transformed-expected.html: Added.
- fast/text/synthetic-bold-transformed.html: Added.
- 4:58 PM Changeset in webkit [107011] by
-
- 1 copy in tags/Safari-534.54.14
New tag.
- 4:55 PM Changeset in webkit [107010] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add missing initialization of editable variable.
https://bugs.webkit.org/show_bug.cgi?id=77948
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.
The value of editable in Ewk_Frame_Smart_Data struct is not set.
- ewk/ewk_frame.cpp:
(ewk_frame_editable_set):
- 4:52 PM Changeset in webkit [107009] by
-
- 4 edits in trunk/Source/WebCore
Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914
Reviewed by Eric Seidel.
Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.
No new tests. No changed behavior.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
- rendering/RenderFrameSet.h:
(RenderFrameSet):
- 4:40 PM Changeset in webkit [107008] by
-
- 17 edits in trunk
Add JSC support for delivering mutations when the outermost script context exits
https://bugs.webkit.org/show_bug.cgi?id=70289
Reviewed by Eric Seidel.
Source/WebCore:
The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).
The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.
- bindings/js/JSDictionary.h:
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.
- bindings/js/JSMainThreadExecState.cpp:
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.
- bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.
Tools:
- DumpRenderTree/mac/EventSendingController.mm: Add support for
eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
- Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
LayoutTests:
With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).
- fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
- fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
- fast/mutation/observe-characterdata.html: ditto.
- 4:26 PM Changeset in webkit [107007] by
-
- 4 edits7 copies in branches/safari-534.54-branch
Merged r106982.
- 4:17 PM Changeset in webkit [107006] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollableAreaBoundingBox):
- 4:14 PM Changeset in webkit [107005] by
-
- 3 edits3 adds in trunk
[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392
Reviewed by Eric Seidel.
Source/WebCore:
Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.
Test: svg/custom/use-disappears-after-style-update.svg
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::didRecalcStyle):
LayoutTests:
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
- svg/custom/use-disappears-after-style-update.svg: Added.
- 4:00 PM Changeset in webkit [107004] by
-
- 2 edits in trunk/Source/WebCore
Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973
Reviewed by Adam Barth.
This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- 3:58 PM Changeset in webkit [107003] by
-
- 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore
Merge patch for 78045.
- 3:53 PM Changeset in webkit [107002] by
-
- 2 edits in trunk/Source/WebCore
media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779
Reviewed by Eric Carlson.
Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
- 3:47 PM Changeset in webkit [107001] by
-
- 13 edits in trunk/Source/WebCore
Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050
Reviewed by Dan Bernstein.
We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.
- page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.
- platform/ScrollableArea.h:
Add scrollableAreaBoundingBox member function.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.
- 3:46 PM Changeset in webkit [107000] by
-
- 5 edits6 adds in trunk
unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310
Reviewed by Eric Seidel.
Source/WebCore:
Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.
Tests: fast/text/international/inline-plaintext-is-isolated-expected.html
fast/text/international/inline-plaintext-is-isolated.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
fast/text/international/inline-plaintext-with-generated-content-expected.html
fast/text/international/inline-plaintext-with-generated-content.html
- platform/text/UnicodeBidi.h:
(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.
- rendering/InlineIterator.h:
(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.
LayoutTests:
Ref tests for unicode-bidi: plaintext on inlines.
- fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
- fast/text/international/inline-plaintext-is-isolated.html: Added.
- fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
- fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
- fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
- fast/text/international/inline-plaintext-with-generated-content.html: Added.
- 3:43 PM Changeset in webkit [106999] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045
Reviewed by Darin Adler.
Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.
- runtime/JSType.h:
- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType, and thus is excluded from isVariableObject() checks.
- 3:38 PM Changeset in webkit [106998] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957
Reviewed by Adam Barth.
This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):
- 3:29 PM Changeset in webkit [106997] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715
Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.
PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.
Tested with manual tests.
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
- 3:12 PM Changeset in webkit [106996] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.
- platform/mac/PlatformClockCM.mm:
- 3:07 PM Changeset in webkit [106995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening after r106982.
- platform/chromium/test_expectations.txt:
We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.
- 3:03 PM Changeset in webkit [106994] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):
- 2:52 PM Changeset in webkit [106993] by
-
- 1 edit3 adds in trunk/Source/WebKit
[BlackBerry] Upstream DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=77991
Patch by Rob Buis <rbuis@rim.com> on 2012-02-07
Reviewed by Antonio Gomes.
No functionalities changed, no new tests.
- blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.
(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::javaScriptObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
- blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.
(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):
- 2:20 PM Changeset in webkit [106992] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
https://bugs.webkit.org/show_bug.cgi?id=77923
Reviewed by Kenneth Russell.
Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.
Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):
- 2:18 PM Changeset in webkit [106991] by
-
- 4 edits in trunk/LayoutTests
IndexedDB createIndex should fail if options arg is invalid
https://bugs.webkit.org/show_bug.cgi?id=58467
Patch by Eugene Girard <girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.
This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics-workers-expected.txt:
- storage/indexeddb/resources/index-basics.js:
(deleteExisting):
- 2:08 PM Changeset in webkit [106990] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.
- 2:02 PM Changeset in webkit [106989] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, paint the bots green.
- platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk.
- 1:52 PM Changeset in webkit [106988] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=77912
Removing old CG shadow code.
A CG-specific shadow offset hack was added in http://trac.webkit.org/changeset/34317
for this particular setShadow method. However, this shadow offset adjustment for CG
has since moved down into platform specific code. Thus, this offset adjustment here
is now redundant.
The CG-only shadow setting code block in this setShadow method is now redundant.
Since it sets the shadow values to the CGContext directly - and not to the State object -
it will be overwritten later by any subsequent calls to setting shadow values such as
blur, offset, or shadow color.
Reviewed by Simon Fraser.
No new tests. Current canvas tests cover this path.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
- 1:52 PM Changeset in webkit [106987] by
-
- 4 edits in trunk/Source/WebKit/chromium
Process Scroll-gesture events from the compositor.
https://bugs.webkit.org/show_bug.cgi?id=77477
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-07
Reviewed by James Robinson.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- 1:50 PM Changeset in webkit [106986] by
-
- 6 edits in trunk/Source/WebCore
[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013
Reviewed by Kenneth Russell.
If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.
Tested manually by forcing the first makeContextCurrent() call fail.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- 1:48 PM Changeset in webkit [106985] by
-
- 2 edits in trunk/Source/WebKit2
Keep a reference in didReceiveInvalidMessage.
https://bugs.webkit.org/show_bug.cgi?id=78024
Reviewed by Anders Carlsson.
- UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
- 1:46 PM Changeset in webkit [106984] by
-
- 2 edits in trunk/Tools
Add Chris Rogers to reviewers section
https://bugs.webkit.org/show_bug.cgi?id=78016
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/committers.py:
- 1:37 PM Changeset in webkit [106983] by
-
- 2 edits in trunk/Tools
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021
Reviewed by Dan Bernstein.
Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.
- DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):
- 1:37 PM Changeset in webkit [106982] by
-
- 4 edits7 adds in trunk
<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
Associate the credential with the URL of the challenge itself, not the original request:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
LayoutTests:
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
- 1:24 PM Changeset in webkit [106981] by
-
- 2 edits in trunk/LayoutTests
Revert r106958.
- platform/chromium/test_expectations.txt:
It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see http://webkit.org/b/77997).
- 1:22 PM Changeset in webkit [106980] by
-
- 6 edits in trunk/Source/WebCore
move warning about css values and render style constants closer to where it applies
https://bugs.webkit.org/show_bug.cgi?id=78017
Reviewed by Darin Adler.
Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.
Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.
No new tests, just refactoring and comment cleanup.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().
- css/CSSValueKeywords.in:
- css/SVGCSSPropertyNames.in:
- css/SVGCSSValueKeywords.in:
- rendering/style/RenderStyleConstants.h:
- 1:06 PM Changeset in webkit [106979] by
-
- 6 edits in branches/subpixellayout/Source/WebCore
Various build fixes for branch
- 12:48 PM Changeset in webkit [106978] by
-
- 5 edits1 copy1 add in trunk/Source
Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885
Reviewed by Eric Carlson.
Source/JavaScriptCore:
- wtf/Platform.h: Added WTF_USE_COREMEDIA.
Source/WebCore:
No new tests; performance improvement covered by existing test cases.
- WebCore.xcodeproj/project.pbxproj:
- platform/Clock.cpp:
(Clock::create): Use PlatformClockCM if available.
- platform/mac/PlatformClockCM.h: Added.
(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):
- platform/mac/PlatformClockCM.mm: Added.
(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):
- 12:45 PM Changeset in webkit [106977] by
-
- 21 edits in trunk/Source
ScrollableAreaSet should be moved from Page to FrameView
https://bugs.webkit.org/show_bug.cgi?id=62762
Reviewed by Beth Dakin.
Source/WebCore:
It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.
- WebCore.exp.in:
Replace the Page member functions with FrameView member functions instead.
- page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.
(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.
- page/FocusController.cpp:
(WebCore::contentAreaDidShowOrHide):
Add helper function.
(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.
(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.
(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame->page() instead.
(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.
(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.
(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.
(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.
- page/FrameView.h:
Move the member function declarations and the scrollable area set member variable here from Page.
- page/Page.cpp:
(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.
- platform/ScrollView.h:
(ScrollView):
Make addChild and removeChild virtual.
- platform/ScrollableArea.h:
Remove disconnectFromPage.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.
- rendering/RenderLayer.h:
Remove the page member variable and disconnectFromPage.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.
- rendering/RenderListBox.h:
Remove the page member variable and disconnectFromPage.
Source/WebKit/chromium:
Update for changes to WebCore now that the scrollable area set is kept per frame view.
- src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
- src/ScrollbarGroup.h:
(WebCore):
(ScrollbarGroup):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollbarGroup):
Source/WebKit2:
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.
(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
Remove disconnectFromPage since it no longer exists on ScrollableArea.
- 12:40 PM Changeset in webkit [106976] by
-
- 1 edit4 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77993
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-07
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added.
- blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added.
- 12:28 PM Changeset in webkit [106975] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
- platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
- platform/chromium/test_expectations.txt:
Rebaseline some old entries in test_expectations.
- 12:16 PM Changeset in webkit [106974] by
-
- 2 edits in trunk/LayoutTests
createImpulseBuffer uses incorrect length
https://bugs.webkit.org/show_bug.cgi?id=77665
Patch by Raymond Toy <Raymond Toy> on 2012-02-07
Reviewed by Kenneth Russell.
- webaudio/resources/audio-testing.js:
(createImpulseBuffer): Fix bug so the buffer has the correct
length.
- 12:04 PM Changeset in webkit [106973] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant checks in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=78000
Reviewed by Dan Bernstein.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):
- 12:01 PM Changeset in webkit [106972] by
-
- 3 edits4 adds in trunk
Crash in ContainerNode functions due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=77999
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add RefPtr to protect premature deletion of this due to mutation events.
Tests: fast/dom/remove-body-during-body-replacement.html
fast/dom/remove-body-during-body-replacement2.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):
LayoutTests:
- fast/dom/remove-body-during-body-replacement-expected.txt: Added.
- fast/dom/remove-body-during-body-replacement.html: Added.
- fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
- fast/dom/remove-body-during-body-replacement2.html: Added.
- 11:59 AM Changeset in webkit [106971] by
-
- 2 edits in trunk/LayoutTests
[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862
Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.
- platform/chromium/test_expectations.txt:
- 11:50 AM Changeset in webkit [106970] by
-
- 6999 edits925 copies33 adds113 deletes in branches/subpixellayout
Merging trunk changes up until 106956 into subpixel branch.
- 11:46 AM Changeset in webkit [106969] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Memory bug during occlusion tracking if Vector::append() needs to reallocate the buffer
https://bugs.webkit.org/show_bug.cgi?id=77996
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.
We're holding onto the last element in the Vector and then calling
append(). If append() reallocates the Vector's buffer, the pointer
is no longer valid.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::enterTargetRenderSurface):
- 11:37 AM Changeset in webkit [106968] by
-
- 3 edits2 adds in trunk
Source/WebCore: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939
Reviewed by Julien Chaffraix.
Test: fast/multicol/span/split-inline-wrong-post-block-crash.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
LayoutTests: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939
Reviewed by Julien Chaffraix.
- fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added.
- fast/multicol/span/split-inline-wrong-post-block-crash.html: Added.
- 11:34 AM Changeset in webkit [106967] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
- platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen
on the bots.
- 11:30 AM Changeset in webkit [106966] by
-
- 2 edits in trunk/LayoutTests
[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
https://bugs.webkit.org/show_bug.cgi?id=77896
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by Kenneth Russell.
- platform/chromium/test_expectations.txt:
- 11:26 AM Changeset in webkit [106965] by
-
- 4 edits in trunk
Chromium: remove WebSpeechInputResult::set
https://bugs.webkit.org/show_bug.cgi?id=77977
Reviewed by Darin Fisher.
It was renamed to assign() in r106475.
Source/WebKit/chromium:
- public/WebSpeechInputResult.h:
Tools:
- DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(makeRectResult):
- 11:18 AM Changeset in webkit [106964] by
-
- 2 edits in trunk/Source/WebCore
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922
Address review comments by Alexey Proskuryakov and Mark Rowe.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):
- 11:18 AM Changeset in webkit [106963] by
-
- 1 edit3 adds in trunk/LayoutTests
composited mask test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76006
Reviewed by Ojan Vafai.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/resources/alpha-gradient.png: Added.
- css3/calc/simple-composited-mask-expected-mismatch.html: Added.
- css3/calc/simple-composited-mask.html: Added.
- 11:03 AM Changeset in webkit [106962] by
-
- 2 edits in trunk/LayoutTests
[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
https://bugs.webkit.org/show_bug.cgi?id=75132
Unreviewed, chromium expectations update.
Fixed with http://crrev.com/120714.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
- platform/chromium/test_expectations.txt:
- 10:57 AM Changeset in webkit [106961] by
-
- 11 edits2 adds in trunk/Source/WebKit2
[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76998
Reviewed by Martin Robinson.
- GNUmakefile.am: Add WebKitEditingCommands.h.
- UIProcess/API/gtk/WebKitEditingCommands.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.
- UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest
instead of LoadTrackingTest.
- UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.
- UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
- UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.
- 10:55 AM WebKitGTK/1.6.x edited by
- (diff)
- 10:54 AM Changeset in webkit [106960] by
-
- 2 edits in trunk
Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924
Reviewed by Tony Chang.
Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.
- Websites/webkit-perf.appspot.com/js/config.js:
(fetchDashboardManifest):
- 10:49 AM Changeset in webkit [106959] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update.
[Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD
https://bugs.webkit.org/show_bug.cgi?id=77412
Fixed with http://crrev.com/120714.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
- platform/chromium/test_expectations.txt:
- 9:45 AM Changeset in webkit [106958] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
Mark an SVG test as SLOW.
- 9:38 AM Changeset in webkit [106957] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
https://bugs.webkit.org/show_bug.cgi?id=77919
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Reviewed by Yury Semikhatsky.
Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.
- inspector/CodeGeneratorInspector.py:
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):
- 9:34 AM Changeset in webkit [106956] by
-
- 2 edits in trunk/Source/WebCore
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922
Reviewed by Chris Marrin.
Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.
No new tests. Covered by existing tests.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):
- 9:21 AM Changeset in webkit [106955] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Layout Test media/controls-drag-timebar.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77531
No more flakiness.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
Reviewed by Eric Carlson.
- platform/chromium/test_expectations.txt:
- 9:19 AM Changeset in webkit [106954] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening.
- platform/qt-wk2/Skipped: Skip failing tests, because we like regressions in trunk.
- 9:00 AM Changeset in webkit [106953] by
-
- 20 edits12 adds in trunk
Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.
Tests: inspector/elements/undo-dom-edits-2.html
inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCSSAgent.cpp:
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.cpp:
(InspectorDOMAgent::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::perform):
(WebCore::InspectorDOMAgent::DOMAction::undo):
(WebCore):
(InspectorDOMAgent::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::perform):
(WebCore::InspectorDOMAgent::RemoveChildAction::undo):
(InspectorDOMAgent::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::perform):
(WebCore::InspectorDOMAgent::InsertBeforeAction::undo):
(InspectorDOMAgent::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::perform):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::undo):
(InspectorDOMAgent::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::perform):
(WebCore::InspectorDOMAgent::SetAttributeAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::perform):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::newNode):
(InspectorDOMAgent::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::perform):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::undo):
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::markUndoableState):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):
- inspector/InspectorHistory.cpp: Added.
(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):
- inspector/InspectorHistory.h: Added.
(WebCore):
(InspectorHistory):
(Action):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):
- inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):
- inspector/elements/undo-dom-edits-2-expected.txt: Added.
- inspector/elements/undo-dom-edits-2.html: Added.
- inspector/elements/undo-dom-edits-expected.txt: Added.
- inspector/elements/undo-dom-edits.html: Added.
- inspector/styles/undo-add-property-expected.txt: Added.
- inspector/styles/undo-add-property.html: Added.
- inspector/styles/undo-change-property-expected.txt: Added.
- inspector/styles/undo-change-property.html: Added.
- inspector/styles/undo-property-toggle-expected.txt: Added.
- inspector/styles/undo-property-toggle.html: Added.
- 8:55 AM Changeset in webkit [106952] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, more svg rebaselines following change in r106918.
- platform/chromium-linux/svg/text/text-text-05-t-expected.png:
- 8:43 AM Changeset in webkit [106951] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994
"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- public/WebWidget.h:
(WebWidget):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebViewImpl):
- 8:28 AM Changeset in webkit [106950] by
-
- 2 edits in trunk/LayoutTests
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810
- platform/qt/Skipped: Skip one more test because of this bug.
- 8:18 AM Changeset in webkit [106949] by
-
- 4 edits in trunk/Source/WebKit2
Encode radius, force and rotationAngle in WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=77986
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
- Shared/WebEvent.h:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
- 8:16 AM Changeset in webkit [106948] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening after r106898. Update platform specific expected results
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- 8:13 AM Changeset in webkit [106947] by
-
- 20 edits12 deletes in trunk
Unreviewed, rolling out r106932.
http://trac.webkit.org/changeset/106932
https://bugs.webkit.org/show_bug.cgi?id=77988
Breaks Mac bots (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorHistory.cpp: Removed.
- inspector/InspectorHistory.h: Removed.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):
- inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
- inspector/elements/undo-dom-edits-2-expected.txt: Removed.
- inspector/elements/undo-dom-edits-2.html: Removed.
- inspector/elements/undo-dom-edits-expected.txt: Removed.
- inspector/elements/undo-dom-edits.html: Removed.
- inspector/styles/undo-add-property-expected.txt: Removed.
- inspector/styles/undo-add-property.html: Removed.
- inspector/styles/undo-change-property-expected.txt: Removed.
- inspector/styles/undo-change-property.html: Removed.
- inspector/styles/undo-property-toggle-expected.txt: Removed.
- inspector/styles/undo-property-toggle.html: Removed.
- 8:09 AM Changeset in webkit [106946] by
-
- 4 edits in trunk/Tools
[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985
Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- MiniBrowser/qt/qml/MockTouchPoint.qml:
- 8:00 AM Changeset in webkit [106945] by
-
- 2 edits in trunk
Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984
Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.
- .gitignore: Ignore temp files created by Qt Creator and KDevelop.
- 7:55 AM Changeset in webkit [106944] by
-
- 2 edits in trunk
[GTK] Broken "HTML5 <scoped style>" detection
https://bugs.webkit.org/show_bug.cgi?id=77979
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.
- configure.ac: Fix wrong variable for HTML5 <style scoped> detection
- 7:54 AM Changeset in webkit [106943] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Unreviewed, a couple more chromium rebaselines after r106918.
- platform/chromium-mac-leopard/svg/hixie/perf/006-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
- 7:51 AM Changeset in webkit [106942] by
-
- 4 edits3 moves11 adds10 deletes in trunk/LayoutTests
Unreviewed, more chromium rebaselines as a result of change in r106918.
- platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png: Added.
- platform/chromium-mac-leopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
- platform/chromium-mac-leopard/svg/filters/filter-width-update-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
- platform/chromium-mac-leopard/svg/hixie/perf/005-expected.png: Removed.
- platform/chromium-mac-leopard/svg/hixie/perf/007-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/filter-width-update-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
- platform/chromium-mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
- platform/chromium-mac/svg/filters/filter-width-update-expected.png: Removed.
- platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
- platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
- svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
- 7:46 AM Changeset in webkit [106941] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build failure with --enable-web-audio
https://bugs.webkit.org/show_bug.cgi?id=77978
Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.list.am: Include AudioSourceProviderClient.h
- 7:46 AM Changeset in webkit [106940] by
-
- 25 edits2 copies6 moves15 adds5 deletes in trunk/LayoutTests
Unreviewed chromium rebaseline to account for change in r106918.
- platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png: Added.
- platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png: Added.
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
- platform/chromium-mac-leopard/svg/text/text-text-05-t-expected.png: Added.
- platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt.
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt.
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt:
- platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png.
- platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png.
- platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png.
- platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
- platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
- platform/chromium-win/svg/carto.net/window-expected.png:
- platform/chromium-win/svg/carto.net/window-expected.txt:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.txt:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.txt:
- platform/chromium-win/svg/text/append-text-node-to-tspan-expected.png: Added.
- platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt: Added.
- platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.png: Added.
- platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt: Added.
- platform/chromium-win/svg/text/text-text-05-t-expected.png:
- platform/chromium-win/svg/text/text-text-05-t-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
- 7:33 AM Changeset in webkit [106939] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] [WK2] Fix the debug build after r106920
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.
- 7:29 AM Changeset in webkit [106938] by
-
- 34 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Update platform specific expected files after r106918.
- platform/qt/Skipped: Unskip non-existing tests.
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/qt/svg/carto.net/tabgroup-expected.png:
- platform/qt/svg/carto.net/tabgroup-expected.txt:
- platform/qt/svg/carto.net/window-expected.png:
- platform/qt/svg/carto.net/window-expected.txt:
- platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
- platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
- platform/qt/svg/filters/filter-width-update-expected.png:
- platform/qt/svg/filters/filter-width-update-expected.txt:
- platform/qt/svg/hixie/perf/003-expected.png:
- platform/qt/svg/hixie/perf/003-expected.txt:
- platform/qt/svg/hixie/perf/004-expected.png:
- platform/qt/svg/hixie/perf/004-expected.txt:
- platform/qt/svg/hixie/perf/005-expected.png:
- platform/qt/svg/hixie/perf/005-expected.txt:
- platform/qt/svg/hixie/perf/006-expected.png:
- platform/qt/svg/hixie/perf/006-expected.txt:
- platform/qt/svg/zoom/page/zoom-background-images-expected.png:
- platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- 7:27 AM Changeset in webkit [106937] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
- 7:22 AM Changeset in webkit [106936] by
-
- 2 edits in trunk/Tools
[GTK] Include gdk-pixbuf in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=77980
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
- 7:16 AM Changeset in webkit [106935] by
-
- 9 edits in trunk/Source
[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-07
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
- 6:58 AM BuildingGtk edited by
- Add libtiff4-dev as a dependency (diff)
- 6:52 AM Changeset in webkit [106934] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
- 6:32 AM Changeset in webkit [106933] by
-
- 2 edits in trunk/Source/WebCore
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
No new tests. (build fix)
- platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):
- 6:00 AM Changeset in webkit [106932] by
-
- 20 edits12 adds in trunk
Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.
Tests: inspector/elements/undo-dom-edits-2.html
inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCSSAgent.cpp:
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore):
(WebCore::InspectorDOMAgent::markUndoableState):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):
- inspector/InspectorHistory.cpp: Added.
(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):
- inspector/InspectorHistory.h: Added.
(WebCore):
(InspectorHistory):
(Action):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):
- inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):
- inspector/elements/undo-dom-edits-2-expected.txt: Added.
- inspector/elements/undo-dom-edits-2.html: Added.
- inspector/elements/undo-dom-edits-expected.txt: Added.
- inspector/elements/undo-dom-edits.html: Added.
- inspector/styles/undo-add-property-expected.txt: Added.
- inspector/styles/undo-add-property.html: Added.
- inspector/styles/undo-change-property-expected.txt: Added.
- inspector/styles/undo-change-property.html: Added.
- inspector/styles/undo-property-toggle-expected.txt: Added.
- inspector/styles/undo-property-toggle.html: Added.
- 5:41 AM Changeset in webkit [106931] by
-
- 3 edits in trunk/Source/WebCore
[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-07
Reviewed by Rob Buis.
- rename clientIsOk to isClientAvailable.
- m_isRunning is only for an ASSERT in NetWorkManager, So move out from
release build but keep available in debug build.
No changes in behavior, so no new tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):
- 5:09 AM Changeset in webkit [106930] by
-
- 9 edits in trunk/Source/WebKit2
[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111
Reviewed by Simon Hausmann.
Move the initialization of the interaction engine to componentComplete
in preparation of switching to a Flickable based content positioning
for the touch based WebView.
Suspend the page and delay the dispatch of load success on startup until
the component finished initialization. With this patch instantiating the
WebView in C++ is only possible by creating a QDeclarativeComponent as
the initialization depends on the componentComplete method being called.
Also return valid default values in the viewport info functions if the
interaction engine is not yet initialized because the viewport info
component could finish initialization earlier than the WebView, which
results in QML warnings during MiniBrowser startup.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
- UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::dispatchLoadSucceeded):
- 4:55 AM Changeset in webkit [106929] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
- DEPS:
- 4:52 AM Changeset in webkit [106928] by
-
- 4 edits in trunk
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
LayoutTests:
- inspector/profiler/heap-snapshot.html:
- 4:44 AM Changeset in webkit [106927] by
-
- 2 edits in trunk/LayoutTests
[Qt] New svg/hittest tests introduced in r106882 fail
https://bugs.webkit.org/show_bug.cgi?id=77964
Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Skip failing tests until fix.
- 4:43 AM Changeset in webkit [106926] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r106909.
http://trac.webkit.org/changeset/106909
https://bugs.webkit.org/show_bug.cgi?id=77965
~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
- 4:29 AM Changeset in webkit [106925] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
<http://webkit.org/b/77952>
Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.
The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes ("style" and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.
- dom/Element.h:
(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):
- dom/StyledElement.h:
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):
- 4:23 AM Changeset in webkit [106924] by
-
- 2 edits in trunk/Source/WebCore
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.
No new tests. (build fix).
- platform/qt/FileSystemQt.cpp:
- 4:12 AM Changeset in webkit [106923] by
-
- 16 edits in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r106918.
- platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
- platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/gtk/svg/carto.net/tabgroup-expected.txt:
- platform/gtk/svg/carto.net/window-expected.txt:
- platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt:
- platform/gtk/svg/filters/filter-width-update-expected.txt:
- platform/gtk/svg/text/text-text-05-t-expected.txt:
- platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
- platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- 3:50 AM Changeset in webkit [106922] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, rolling out r106915.
http://trac.webkit.org/changeset/106915
https://bugs.webkit.org/show_bug.cgi?id=77961
because 106912 was rolled out (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 3:45 AM Changeset in webkit [106921] by
-
- 2 edits2 adds in trunk/Source/WebKit2
[EFL][WK2] Add ModuleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=63608
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-07
Reviewed by Andreas Kling.
Add first version of ModuleEfl.cpp including load(), unload() and platformFunctionPointer().
- Platform/Module.h:
- Platform/efl/ModuleEfl.cpp: Added.
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
- 3:42 AM Changeset in webkit [106920] by
-
- 8 edits in trunk/Source
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
No new tests. (Not applicable)
Added OS-specific implementation for retrieving the free disk space.
- platform/FileSystem.h:
(WebCore):
- platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):
(WebCore):
Source/WebKit2:
First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):
- 3:19 AM Changeset in webkit [106919] by
-
- 2 edits in trunk/Tools
[Qt] Prevent early test termination with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=77945
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.
QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.
- DumpRenderTree/qt/main.cpp:
(main): Don't quit on last window closed.
- 3:19 AM Changeset in webkit [106918] by
-
- 181 edits1 copy2 adds in trunk/LayoutTests
Rewrite SVG tests to make extensive use of display() in repaint tests
https://bugs.webkit.org/show_bug.cgi?id=77736
Reviewed by Andreas Kling.
Convert all tests in svg/ (except svg/custom & svg/dynamic-updates) that exercise repainting to use the
fast/repaint/resources/repaint.js harness, which forces a layout, and calls layoutTestController.display()
before executing the actual repaint test, so that repaint rectangles are properly tracked and shown (white
areas that are redrawn, on top of the gray background, painted over the web view after the initial painting).
Previously SVG tests used to work like this: (using an HTML example, but it doesn't matter)
<html><body><svg><rect/><script>function change() { rect.setAttribute(...); layoutTestController.notifyDone(); } setTimeout(change, 0); </script></svg></body></html>
We expected that the initial painting was done, before change() as called. This is unreliable for various reasons:
- the timeout is not guaranteed to fire after the document loaded, it may happen inbetween on eg. a slow connection.
- nor is it guaranteed that the document has painted initially before we enter change(). This leads to the current regressions -- if we break repainting, we can't see it in the current layout tests, as the initial painting always happens after change() executed in trunk, at least on a fast machine.
In order to make repaint testing reliable we have to use following scheme:
<html><body onload="runRepaintTest()"><svg><rect/><script>function repaintTest() { rect.setAttribute(...); }</script></svg></body></html>
runRepaintTest() is provided by the repaint.js harness and does:
if (window.layoutTestController) {
document.body.offsetTop;
layoutTestController.display();
repaintTest();
} else {
setTimeout(repaintTest, 100);
}
Using this harness outside of DRT allows to test SVG repainting tests in the browser as well, as the repainting changes
aren't immediately fired (0ms timer) but instead delayed by 100ms, so a visual "flash" is visible, if something changes.
For DRT it does two things. First it forces Document::updateLayout() to be called, and then forces the web view to paint
immediately, and then it starts tracking any repaint rects, that are fired _after_ the initial painting, which are then
highlighted in the pixel test dump later on. Using display() is the only way to get reliable painting results across
DRT/WebKitTestRunner, and to get rid of the flakiness.
All *.xml/*.html/*.htm/*.xhtml tests which excersise repainting can be moved to use runRepaintTest() from repaint.js.
<body> needs to be changed to <body onload="runRepaintTest()">, and the timeouts & waitUntilDone/notifyDone calls can
be removed from the tests, leading to much nicer testcases, removing lots of boilerplate.
Pure *.svg tests unfortunately can't use <svg onload="runRepaintTest()"> at the moment, due timing differences between
the HTML load and the SVGLoad event, that's out of scope for this bug report. To remove any hacks from the testcases
themselves, I centralized following work-around in a new function in repaint.js, and let all *.svg tests use it.
function runSVGRepaintTest() {
if (window.layoutTestController) {
layoutTestController.waitUntilDone();
setTimeout(runRepaintTest, 0);
} else
runRepaintTest();
}
runRepaintTest() has to be called from a timer at the moment, as the SVGLoad event fires earlier as HTML load event.
Before that is fixed, we have to use <svg onload="runSVGRepaintTest()"> instead of <svg onload="runRepaintTest()">
and append: layoutTestController.notifyDone() to the repaintTest() functions in the testcases. That should explain
the testcase differences between pure-SVG and non-pure-SVG tests, and why I treated them differently. This approach
is unfortunately as flakey as the old, so to make pure *.svg tests test repainting reliable, the bug needs to be fixed.
Note that svg/custom, and svg/dynamic-updates will be fixed in another chunk, as they also require large amounts
of rebaselines.
- fast/repaint/resources/repaint.js:
(runRepaintTest):
(runSVGRepaintTest):
- platform/chromium/test_expectations.txt:
- platform/mac/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/mac/svg/as-image/animated-svg-as-image-expected.png:
- platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
- platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
- platform/mac/svg/as-object/embedded-svg-size-changes-expected.png:
- platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
- platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png:
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
- platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
- platform/mac/svg/carto.net/tabgroup-expected.png:
- platform/mac/svg/carto.net/tabgroup-expected.txt:
- platform/mac/svg/carto.net/window-expected.png:
- platform/mac/svg/carto.net/window-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.png:
- platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png:
- platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
- platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
- platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
- platform/mac/svg/filters/filter-refresh-expected.png:
- platform/mac/svg/filters/filter-width-update-expected.png:
- platform/mac/svg/filters/filter-width-update-expected.txt:
- platform/mac/svg/filters/invalidate-on-child-layout-expected.png:
- platform/mac/svg/hixie/perf/001-expected.png:
- platform/mac/svg/hixie/perf/002-expected.png:
- platform/mac/svg/hixie/perf/003-expected.png:
- platform/mac/svg/hixie/perf/003-expected.txt:
- platform/mac/svg/hixie/perf/004-expected.png:
- platform/mac/svg/hixie/perf/004-expected.txt:
- platform/mac/svg/hixie/perf/005-expected.png:
- platform/mac/svg/hixie/perf/005-expected.txt:
- platform/mac/svg/hixie/perf/006-expected.png:
- platform/mac/svg/hixie/perf/006-expected.txt:
- platform/mac/svg/hixie/perf/007-expected.png:
- platform/mac/svg/hixie/perf/007-expected.txt:
- platform/mac/svg/repaint/filter-child-repaint-expected.png:
- platform/mac/svg/repaint/image-href-change-expected.png:
- platform/mac/svg/repaint/image-with-clip-path-expected.png:
- platform/mac/svg/text/append-text-node-to-tspan-expected.png:
- platform/mac/svg/text/modify-text-node-in-tspan-expected.png:
- platform/mac/svg/text/remove-text-node-from-tspan-expected.png:
- platform/mac/svg/text/remove-tspan-from-text-expected.png:
- platform/mac/svg/text/text-text-05-t-expected.png:
- platform/mac/svg/text/text-text-05-t-expected.txt:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
- platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
- platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
- platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
- platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
- platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
- platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
- svg/as-background-image/animated-svg-as-background.html:
- svg/as-background-image/resources/animated-rect-relative-size.svg:
- svg/as-background-image/svg-as-background-5.html:
- svg/as-background-image/svg-background-partial-redraw.html:
- svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
- svg/as-image/animated-svg-as-image-same-image.html:
- svg/as-image/animated-svg-as-image.html:
- svg/as-image/resources/animated-rect-fixed-size-2.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-same-image.svg.
- svg/as-image/resources/animated-rect-fixed-size.svg:
- svg/as-image/resources/animated-rect-relative-size.svg:
- svg/as-image/resources/animated-rect-same-image.svg:
- svg/as-image/svg-image-change-content-size.xhtml:
- svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
- svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
- svg/as-object/embedded-svg-size-changes.html:
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
- svg/as-object/nested-embedded-svg-size-changes.html:
- svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
- svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
- svg/carto.net/tabgroup.svg:
- svg/carto.net/window.svg:
- svg/css/shadow-changes.svg:
- svg/dom/SVGPathSegList-segment-modification.svg:
- svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
- svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
- svg/dom/SVGRectElement/rect-modify-rx.svg:
- svg/filters/animate-fill-expected.png:
- svg/filters/animate-fill.svg:
- svg/filters/feImage-reference-invalidation-expected.png:
- svg/filters/feImage-reference-invalidation.svg:
- svg/filters/feImage-target-add-to-document-expected.png:
- svg/filters/feImage-target-add-to-document.svg:
- svg/filters/feImage-target-changes-id-expected.png:
- svg/filters/feImage-target-changes-id.svg:
- svg/filters/feImage-target-id-change-expected.png:
- svg/filters/feImage-target-id-change.svg:
- svg/filters/feImage-target-reappend-to-document-expected.png:
- svg/filters/feImage-target-reappend-to-document.svg:
- svg/filters/feImage-target-remove-from-document-expected.png:
- svg/filters/feImage-target-remove-from-document.svg:
- svg/filters/filter-refresh.svg:
- svg/filters/filter-width-update.svg:
- svg/filters/invalidate-on-child-layout.svg:
- svg/hixie/perf/001.xml:
- svg/hixie/perf/002.xml:
- svg/hixie/perf/003.xml:
- svg/hixie/perf/004.xml:
- svg/hixie/perf/005.xml:
- svg/hixie/perf/006.xml:
- svg/hixie/perf/007.xml:
- svg/hixie/perf/resources/smallcats.gif: Added.
- svg/repaint/container-repaint-expected.png:
- svg/repaint/container-repaint.svg:
- svg/repaint/filter-child-repaint.svg:
- svg/repaint/image-href-change.svg:
- svg/repaint/image-with-clip-path.svg:
- svg/text/append-text-node-to-tspan.html:
- svg/text/modify-text-node-in-tspan.html:
- svg/text/remove-text-node-from-tspan.html:
- svg/text/remove-tspan-from-text.html:
- svg/text/text-text-05-t.svg:
- svg/transforms/animated-path-inside-transformed-html.xhtml:
- svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
- svg/zoom/page/absolute-sized-document-scrollbars.svg:
- svg/zoom/page/relative-sized-document-scrollbars.svg:
- svg/zoom/page/zoom-background-image-tiled.html:
- svg/zoom/page/zoom-background-images.html:
- svg/zoom/page/zoom-coords-viewattr-01-b.svg:
- svg/zoom/page/zoom-foreignObject.svg:
- svg/zoom/page/zoom-getBoundingClientRect.xhtml:
- svg/zoom/page/zoom-hixie-mixed-008.xml:
- svg/zoom/page/zoom-hixie-mixed-009.xml:
- svg/zoom/page/zoom-hixie-rendering-model-004.xhtml:
- svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html:
- svg/zoom/page/zoom-mask-with-percentages.svg:
- svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
- svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html:
- svg/zoom/page/zoom-svg-as-background-with-relative-size.html:
- svg/zoom/page/zoom-svg-as-image.html:
- svg/zoom/page/zoom-svg-as-object.html:
- svg/zoom/page/zoom-svg-as-relative-image.html:
- svg/zoom/page/zoom-svg-float-border-padding.xml:
- svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml:
- svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml:
- svg/zoom/page/zoom-svg-through-object-with-auto-size.html:
- svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml:
- svg/zoom/page/zoom-svg-through-object-with-override-size.html:
- svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml:
- svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled:
- svg/zoom/page/zoom-zoom-coords.xhtml:
- svg/zoom/resources/testPageZoom.js:
(repaintTest):
- svg/zoom/resources/testTextZoom.js:
(repaintTest):
- svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
- svg/zoom/text/absolute-sized-document-scrollbars.svg:
- svg/zoom/text/relative-sized-document-scrollbars.svg:
- svg/zoom/text/zoom-coords-viewattr-01-b.svg:
- svg/zoom/text/zoom-foreignObject.svg:
- svg/zoom/text/zoom-hixie-mixed-008.xml:
- svg/zoom/text/zoom-hixie-mixed-009.xml:
- svg/zoom/text/zoom-hixie-rendering-model-004.xhtml:
- svg/zoom/text/zoom-svg-float-border-padding.xml:
- 3:10 AM Changeset in webkit [106917] by
-
- 2 edits in trunk/Source/WebCore
[Inspector] Add the Nokia N9 user agent
https://bugs.webkit.org/show_bug.cgi?id=77949
Reviewed by Simon Hausmann.
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
- 2:29 AM Changeset in webkit [106916] by
-
- 2 edits in trunk/Source/WebCore
[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=77953
Reviewed by Andreas Kling.
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
- 2:22 AM Changeset in webkit [106915] by
-
- 6 edits in trunk/LayoutTests
GTK & QT Rebaseline after r106912.
https://bugs.webkit.org/show_bug.cgi?id=77942
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-07
Reviewed by David Levin.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 1:51 AM Applications using WebKit edited by
- (diff)
- 1:44 AM Changeset in webkit [106914] by
-
- 13 edits3 deletes in trunk
Unreviewed, rolling out r106912.
http://trac.webkit.org/changeset/106912
https://bugs.webkit.org/show_bug.cgi?id=77947
"AppleWebKit build is broken" (Requested by haraken on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07
Source/WebCore:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
- dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
- html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):
- html/DOMURL.h:
(WebCore::DOMURL::create):
(DOMURL):
- html/DOMURL.idl:
- html/PublicURLManager.h: Removed.
- page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::webkitURL):
- page/DOMWindow.h:
(DOMWindow):
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore):
(WebCore::WorkerContext::webkitURL):
- workers/WorkerContext.h:
(WorkerContext):
- workers/WorkerContext.idl:
LayoutTests:
- fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
- fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
- 1:28 AM Applications using WebKit edited by
- (diff)
- 12:54 AM Changeset in webkit [106913] by
-
- 4 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r106862.
http://trac.webkit.org/changeset/106862
https://bugs.webkit.org/show_bug.cgi?id=77510
Mac build fails if we manually remove generated code
- DerivedSources.make:
- bindings/scripts/generate-bindings.pl:
(generateEmptyHeaderAndCpp):
- bindings/scripts/resolve-supplemental.pl:
- bindings/scripts/update-idl-needs-rebuild.pl: Removed.
- 12:40 AM Applications using WebKit edited by
- (diff)
- 12:18 AM Changeset in webkit [106912] by
-
- 13 edits1 copy2 adds in trunk
Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-07
Reviewed by David Levin.
Source/WebCore:
Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
- dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
- html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
- html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
- html/DOMURL.idl:
- html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
- page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
- page/DOMWindow.h: ditto.
(DOMWindow):
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WorkerContext):
- workers/WorkerContext.idl:
LayoutTests:
Added test to check if createObjectURL & revokeObjectURL are static functions.
- fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
- fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
- 12:16 AM Changeset in webkit [106911] by
-
- 4 edits in trunk
http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=77661
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 12:09 AM Changeset in webkit [106910] by
-
- 2 edits in trunk/Source/WebCore
Fix build on Mac with '--shadow-dom'.
https://bugs.webkit.org/show_bug.cgi?id=77940
Reviewed by Hajime Morita.
- WebCore.xcodeproj/project.pbxproj:
