Context Navigation

← Previous Period
Next Period →

Timeline

Sep 24, 2012:

11:51 PM Changeset in webkit [129462] by commit-queue@webkit.org

24 edits
8 adds in trunk

Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations
https://bugs.webkit.org/show_bug.cgi?id=97055

Patch by Bo Liu <boliu@chromium.org> on 2012-09-24
Reviewed by Adam Barth.

Relanding 128780, 128676, 128645. Was reverted in 128914 due to
performance regression in Chromium.

New changes in addition to previously reverted patches:

Refactored CachedResource::requestResource, loadResource, and
revalidateResource. Moved CachedResource::load method to end of
requestResource so there is one place where load is called for all
resources.

Added a enum parameter for requestResource and
determineRevalidationPolicy so that FrameLoaderClient::allowImage call
do not need to be called multiple times.

Removed CachedImage::load call in requestImage so it is not called
twice.

Removed unnecessary Frame.h includes in CachedResource and
CachedImage.

Removed dead load() method declaration in CachedImage.

Updated text expectation for two image-permissions tests to reflect
the removed calls to allowImage.

Source/autotools/symbols.filter:

Source/WebCore:

Tests: fast/loader/display-image-unset-allows-cached-image-load.html

fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html

WebCore.exp.in:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

loader/cache/CachedImage.cpp:
loader/cache/CachedImage.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):

loader/cache/CachedResource.h:

(WebCore):
(WebCore::CachedResource::stillNeedsLoad):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore):
(WebCore::CachedResourceLoader::setImagesEnabled):
(WebCore::CachedResourceLoader::clientDefersImage):
(WebCore::CachedResourceLoader::shouldDeferImageLoad):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

page/Settings.cpp:

(WebCore::setImageLoadingSettings):
(WebCore::Settings::Settings):
(WebCore::Settings::setLoadsImagesAutomatically):
(WebCore::Settings::imageLoadingSettingsTimerFired):
(WebCore::Settings::setImagesEnabled):

page/Settings.h:

(Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setImagesEnabled):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit2:

win/WebKit2.def:

LayoutTests:

fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
fast/loader/display-image-unset-allows-cached-image-load.html: Added.
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
fast/loader/resources/image1.html: Added.
fast/loader/resources/image2.html: Added.
platform/chromium/permissionclient/image-permissions-expected.txt:
platform/chromium/permissionclient/image-permissions.html:
platform/chromium/permissionclient/resources/image.html:
platform/wk2/Skipped:

11:48 PM Changeset in webkit [129461] by barraclough@apple.com

5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=97530
Regression, freeze applied to numeric properties of non-array objects

Reviewed by Filip Pizlo.

Object.freeze has a fast implementation in JSObject, but this hasn't been updated to take into account numeric properties in butterflies.
For now, just fall back to the generic implementation if the object has numeric properties.

Source/JavaScriptCore:

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorFreeze):

fallback if the object has a non-zero indexed property vector length.

LayoutTests:

fast/js/preventExtensions-expected.txt:
fast/js/script-tests/preventExtensions.js:
- Added a test case for freezing an object with a numeric property.

11:32 PM Changeset in webkit [129460] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for http/tests/security/xss-eval.html as the
test started failing after r129456.

platform/gtk/TestExpectations:

11:17 PM Changeset in webkit [129459] by zandobersek@gmail.com

12 edits in trunk

Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
https://bugs.webkit.org/show_bug.cgi?id=97426

Reviewed by Ojan Vafai.

Tools:

The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
member which is a set containing either '!=', '==', both or none if the test represented
by the object is not a reftest.

When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
if the test is a reftest. The value of this key is a list of all the reftest types of this test.

The test failure interpretation method has been refactored, it now reports only
missing results of various formats and image diff percent in case of image or
reftest mismatch.

Unit tests have been modified accordingly.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):

Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):
(summarize_results):

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.run):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Report unexpectedly passing reftests as well. Test cases included.

fast/harness/resources/results-test.js:
fast/harness/results-expected.txt:
fast/harness/results.html:

11:12 PM Changeset in webkit [129458] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Bug in numeric accessors on global environment
https://bugs.webkit.org/show_bug.cgi?id=97526

Reviewed by Geoff Garen.

I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/
The sparsemap is failing to map back from the global object to the window shell.
A test case would need to resolve a numeric property name against the global environment.

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

Add missing toThisObject calls.

10:27 PM Changeset in webkit [129457] by fpizlo@apple.com

6 edits
3 adds in trunk

SerializedScriptValue isn't aware of indexed storage, but should be
https://bugs.webkit.org/show_bug.cgi?id=97515
<rdar://problem/12361874>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Export a method that WebCore now uses.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSObject.h:

(JSObject):

Source/WebCore:

New test: fast/js/post-message-numeric-property.html

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

LayoutTests:

fast/js/post-message-numeric-property-expected.txt: Added.
fast/js/post-message-numeric-property.html: Added.
fast/js/script-tests/post-message-numeric-property.js: Added.

(window.onmessage):

9:52 PM Changeset in webkit [129456] by barraclough@apple.com

7 edits in trunk/Source

Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject()
https://bugs.webkit.org/show_bug.cgi?id=97519

Reviewed by Geoff Garen.

../JavaScriptCore:

unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
simply keeping the structure up to date as the window navigates, obviating the need for this function.

The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
of getting the globalObject from the provided this value & comparing to the expected globalObject, we
can get the this value from the expected globalObject, and compare to that provided.

runtime/JSGlobalObject.cpp:
- Call globalObject() instead of unwrappedGlobalObject().
runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

Changed to compare this object values, instead of globalObjects - this means we only need to be able to map globalObject -> this, and not vice versa.

runtime/JSObject.cpp:

(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::createInheritorID):

Call globalObject() instead of unwrappedGlobalObject().

runtime/JSObject.h:

(JSObject):

Removed unwrappedGlobalObject(), unwrappedObject().

../WebCore:

JSDOMWindowShell::setWindow should update the structure's globalObject.

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::setWindow):

Update the JSDOMWindowShell's structure's globalObject when the window changes.

9:50 PM EFLWebKit edited by Laszlo Gombos

Baseline minimal required tool versions (diff)

9:40 PM Changeset in webkit [129455] by yosin@chromium.org

7 edits in trunk/Source/WebCore

[Forms] We should remove DateTimeEditElement::valueAsDouble()
https://bugs.webkit.org/show_bug.cgi?id=97327

Reviewed by Kent Tamura.

This patch removes unused function DateTimeEditElement::valueAsDouble()
and related functions in DateTimeFieldElement.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.

(DateTimeEditElement):

html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.

(DateTimeFieldElement):

html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
html/shadow/DateTimeFieldElements.h:

(DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
(DateTimeHourFieldElement): ditto.
(DateTimeMillisecondFieldElement): ditto.
(DateTimeMinuteFieldElement): ditto.
(DateTimeSecondFieldElement): ditto.

9:33 PM Changeset in webkit [129454] by weinig@apple.com

2 edits in trunk/Source/WebKit2

WKProcessGroup can't load injected bundle with file URL
<rdar://problem/12322774>
https://bugs.webkit.org/show_bug.cgi?id=97520

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
Fix typo. We need to pass the string as path, not as a URL.

9:30 PM Changeset in webkit [129453] by mark.lam@apple.com

20 edits in trunk/Source

Deleting the classic interpreter and cleaning up some build options.
https://bugs.webkit.org/show_bug.cgi?id=96969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):

bytecode/Instruction.h:

(JSC::Instruction::Instruction):

interpreter/AbstractPC.cpp:

(JSC::AbstractPC::AbstractPC):

interpreter/AbstractPC.h:

(AbstractPC):

interpreter/CallFrame.h:

(ExecState):

interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::retrieveLastCaller):

interpreter/Interpreter.h:

(JSC::Interpreter::getOpcodeID):
(Interpreter):

jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

offlineasm/asm.rb:
offlineasm/offsets.rb:
runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC::NativeExecutable::create):
(NativeExecutable):
(JSC::NativeExecutable::finishCreation):

runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):

runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):

runtime/Options.cpp:

(JSC::Options::initialize):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

wtf/Platform.h:

9:25 PM Changeset in webkit [129452] by Antti Koivisto

8 edits in trunk/Source/WebCore

Don't use StyleSheetList internally.
https://bugs.webkit.org/show_bug.cgi?id=97504

Reviewed by Ryosuke Niwa.

StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore::StyleResolver::collectMatchingRulesForList):

css/StyleSheetList.cpp:

(WebCore::StyleSheetList::StyleSheetList):
(WebCore::StyleSheetList::styleSheets):
(WebCore):
(WebCore::StyleSheetList::detachFromDocument):

Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document.
When detached copy the stylesheet vector to a member field and use that instead.

(WebCore::StyleSheetList::length):
(WebCore::StyleSheetList::item):
(WebCore::StyleSheetList::getNamedItem):

css/StyleSheetList.h:

Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.

(WebCore):
(WebCore::StyleSheetList::create):
(StyleSheetList):
(WebCore::StyleSheetList::document):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::styleSheets):

dom/Document.h:

(Document):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollec

9:09 PM Changeset in webkit [129451] by weinig@apple.com

11 edits
3 adds in trunk

Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=97514

Reviewed by Anders Carlsson.

Source/WebKit2:

GNUmakefile.list.am:
PlatformEfl.cmake:
Target.pri:

Add new files.

UIProcess/Launcher/ProcessLauncher.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connect):
Move platform specific launch options to a new function, platformConnect.

UIProcess/WebProcessProxy.h:
UIProcess/efl/WebProcessProxyEfl.cpp: Added.

Move Efl specific launch options here.

(WebKit::WebProcessProxy::platformConnect):

UIProcess/gtk/WebProcessProxyGtk.cpp: Added.

Add stub.

(WebKit::WebProcessProxy::platformConnect):

UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::platformConnect):
Move Mac specific launch option setting here, and switch from
using an environment variable to NSUserDefaults.

UIProcess/qt/WebProcessProxyQt.cpp: Added.

(WebKit::WebProcessProxy::platformConnect):
Add stub.

UIProcess/win/WebProcessProxyWin.cpp:

(WebKit::WebProcessProxy::platformConnect):
Add stub.

Tools:

Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):
Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
is provided to set the user default. Move adding of @ARGV to after custom additions as calling
shouldUseXPCServiceForWebProcess() can change @ARGV.

(runMacWebKitApp):
(execMacWebKitAppForDebugging):
Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.

8:55 PM Changeset in webkit [129450] by commit-queue@webkit.org

7 edits in trunk/Source

Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

No new tests as there is no new functionality.

platform/cairo/WidgetBackingStoreCairo.cpp:
platform/gtk/GtkWidgetBackingStoreX11.cpp:
plugins/gtk/PluginViewGtk.cpp:

Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
https://bugs.webkit.org/show_bug.cgi?id=97509

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Gyuyoung Kim.

Make the build system consistent by always assuming that directory
that includes the cairo headers is included in the include path.

UIProcess/cairo/BackingStoreCairo.cpp:
WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

8:53 PM Changeset in webkit [129449] by commit-queue@webkit.org

3 edits in trunk/Tools

[GTK][EFL] Make sure cairo is built with fontconfig support
https://bugs.webkit.org/show_bug.cgi?id=97513

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-09-24
Reviewed by Martin Robinson.

The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.

efl/jhbuild.modules:
gtk/jhbuild.modules:

8:26 PM Changeset in webkit [129448] by yosin@chromium.org

4 edits
1 copy
3 adds in trunk

Document::adoptNode for multiple fields time input UI should not crash
https://bugs.webkit.org/show_bug.cgi?id=97428

Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch changes Document::removeFocusedNodeOfSubtree() to check
focused node in shadow DOM tree for avoiding Document::m_focusedNode
not to have dangling pointer to field owner in DateTimeFieldElement.

Test:

fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.

dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
focused node in shadow DOM tree in addition to descendant node.

LayoutTests:

This patch adds a test for checking removeChild() of shadow host
dispatches blur event if focused node in shadow tree, a test for
checking adoptNode() doesn't causes crash and dispatches blur event
during document.adoptNode() and updates expectation for focus/blur event test.

fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.

8:22 PM Changeset in webkit [129447] by commit-queue@webkit.org

2 edits in trunk

[CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
https://bugs.webkit.org/show_bug.cgi?id=97419

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
Reviewed by Gyuyoung Kim.

Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.

CMakeLists.txt:

Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".

8:13 PM Changeset in webkit [129446] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Blackberry] Add a software rendering path for media player
https://bugs.webkit.org/show_bug.cgi?id=97443

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-24
Reviewed by Yong Li.

This patch adds a software rendering path for media player. When accelerated rendering
is not supported by the media engine for the current media, the rendering will fallback
to this software path.

PR #212386
Reviewed internally by Max Feil.

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

7:56 PM Changeset in webkit [129445] by benjamin@webkit.org

9 edits in trunk/LayoutTests

We should not expect percent-escaped hostname for invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=97415

Reviewed by Adam Barth.

The URL layout tests encode some Chromium specific behavior.
Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
do that.

This patch fix the tests and expectations for the IP tests.

fast/url/invalid-urls-utf8-expected.txt:
fast/url/invalid-urls-utf8.html:

Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
for a standard URL causes an invalid URL, it should be kept as is.

fast/url/ipv4-expected.txt:
fast/url/ipv6-expected.txt:
fast/url/script-tests/ipv4.js:
fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.

Invalid URLs should not be escaped.

7:30 PM Changeset in webkit [129444] by benjamin@webkit.org

46 edits in trunk

Fix Geolocation error reporting in the test support
https://bugs.webkit.org/show_bug.cgi?id=97386

Source/WebCore:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

GeolocationController currently expose GeolocationError which can be either
PermissionDenied or PositionUnavailable.

In practice, only PositionUnavailable is supported and tested, only Chrome
somewhat expose PermissionDenied.
The correct way to deny the permission is through Geolocation::setIsAllowed().

This patch does some of the initial cleanup toward that goal, reducing how
far GeolocationError is spread.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:

Mac does not use GeolocationClientMock, it should not be compiled in WebCore.

platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPosition):
(WebCore::GeolocationClientMock::setPositionUnavailableError):
This method replace setError(). It is limited to PositionUnavailable errors.

(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::controllerTimerFired):
(WebCore):
(WebCore::GeolocationClientMock::clearError):

platform/mock/GeolocationClientMock.h:

(WebCore):
(GeolocationClientMock):

Source/WebKit/blackberry:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):

WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/chromium:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

public/WebGeolocationClientMock.h:

(WebGeolocationClientMock):

src/WebGeolocationClientMock.cpp:

(WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):

Source/WebKit/gtk:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):

WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

WebView/WebView.mm:

(-[WebView _geolocationDidFailWithMessage:]):

WebView/WebViewPrivate.h:

Source/WebKit/qt:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):

WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
Reviewed by Sam Weinig.
The TestRunner was exposing internal implementation details of
the Geolocation object through setMockGeolocationError().

In practice, only the error code PositionUnavailable is supported
or even implemented.

Exposing setMockGeolocationError() does not make sense for WebKit2 as
passing generic errors from the UIProcess is a bad idea. This is the
opportunity to clean TestRunner and prepare and interface suitable for WebKit2.

DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionUnavailableErrorCallback):
(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: