Timeline



Mar 28, 2013:

11:31 PM Changeset in webkit [147198] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
​https://bugs.webkit.org/show_bug.cgi?id=113496

Reviewed by Pavel Feldman.

Integrate CookiesTable with DataGrid context menu
instead of overriding it.

  • inspector/front-end/CookiesTable.js:

Pass context menu callback to DataGrid constructor.

  • inspector/front-end/DataGrid.js:

Added context menu callback constructor parameter. Fixed JSDoc.

10:53 PM Changeset in webkit [147197] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

[EFL] Build break with latest EFL libraries after r146265
​https://bugs.webkit.org/show_bug.cgi?id=113558

Unreviewed build fix.

  • TestWebKitAPI/PlatformWebView.h:
  • WebKitTestRunner/PlatformWebView.h:
10:40 PM Changeset in webkit [147196] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Fix build break when running --update-efl in WebKit EFL.

  • efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail

in libgcrypt build.

9:33 PM Changeset in webkit [147195] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r147123.
​http://trac.webkit.org/changeset/147123
​https://bugs.webkit.org/show_bug.cgi?id=113557

wrong TextExpectation removal (Requested by shinyak|gardener
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-28

  • platform/chromium/TestExpectations:
9:12 PM Changeset in webkit [147194] by shinyak@chromium.org
  • 8 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Test expectations update and rebaselining.

  • platform/chromium-mac-lion/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
8:47 PM Changeset in webkit [147193] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

  • platform/chromium/TestExpectations:
6:48 PM Changeset in webkit [147192] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk/Source/WebKit/chromium

[chromium] Remove unused WebRegularExpression API
​https://bugs.webkit.org/show_bug.cgi?id=113520

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-28
Reviewed by Kent Tamura.

Last reference to these files removed in r190880.

  • WebKit.gyp:
  • public/WebRegularExpression.h: Removed.
  • public/WebTextCaseSensitivity.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/WebRegularExpression.cpp: Removed.
6:16 PM Changeset in webkit [147191] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

We leak NetworkConnectionToWebProcess objects.
<rdar://problem/13393118> and ​https://bugs.webkit.org/show_bug.cgi?id=113551

Reviewed by Anders Carlsson.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose): Remove this from the global set

of NetworkConnectionToWebProcess objects.

6:09 PM Changeset in webkit [147190] by ggaren@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Simplified the bytecode by removing op_loop and op_loop_if_*
​https://bugs.webkit.org/show_bug.cgi?id=113548

Reviewed by Filip Pizlo.

Regular jumps will suffice.

These opcodes are identical to branches, except they also do timeout
checking. That style of timeout checking has been broken for a long
time, and when we add back timeout checking, it won't use these opcodes.

(JSC::CodeBlock::dumpBytecode):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):
(JSC):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
6:01 PM Changeset in webkit [147189] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't cross editing boundary when touch hold selection expands
​https://bugs.webkit.org/show_bug.cgi?id=113537

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Set editing boundary crossing rule to make sure it won't cross
editing boundary when selection expands.

Reviewed Internally By Genevieve Mak and Mike Fenton.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):

5:51 PM Changeset in webkit [147188] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
crashes sometimes. Applying the patch from wkbug.com/111902 fixes it
locally for me: skipping it until that patch lands.

  • platform/mac/TestExpectations:

Marking http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
as crashy in Debug.

5:50 PM Changeset in webkit [147187] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Fix compiler warning in IDBTransaction::modeToString
​https://bugs.webkit.org/show_bug.cgi?id=113547

Reviewed by Darin Adler.

Not all compilers are smart enough to handle this switch. This patch refactors
modeToString to not return from the default case.

No new tests as this is just a compiler fix.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeToString):

5:18 PM Changeset in webkit [147186] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
​https://bugs.webkit.org/show_bug.cgi?id=113544

Reviewed by Tim Horton.

The functions added in r147058 to update the visible rects of GraphicsLayerCAs
should not have actually set the m_visibleRect on the layer, because this
caused a later call to adjustTiledLayerVisibleRect() to think that the visible
rect had not changed, so it did no expansion.

Clarify the logic to ask the GraphicsLayer whether, given a new visible
rect, it would need to make new tiles (which happens later during a flush).

Add a function to RenderLayerCompositor to call this code (but which has
no callers yet).

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::visibleRectChangeRequiresFlush): Make private.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::noteVisibleRectChanged):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

5:13 PM Changeset in webkit [147185] by rafaelw@chromium.org
  • 4 edits in trunk

[HTMLTemplateElement] <template> should be able to be a foster parent
​https://bugs.webkit.org/show_bug.cgi?id=113541

Source/WebCore:

Reviewed by Eric Seidel

This adds to the check in findFosterSite to include whether the parent is a DocumentFragment which is a template contents.

Tests added to html5lib suite.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::findFosterSite):

LayoutTests:

Reviewed by Eric Seidel.

  • html5lib/resources/template.dat:
5:09 PM Changeset in webkit [147184] by ggaren@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

Simplified the bytecode by removing op_jmp_scopes
​https://bugs.webkit.org/show_bug.cgi?id=113545

Reviewed by Filip Pizlo.

We already have op_pop_scope and op_jmp, so we don't need op_jmp_scopes.
Using op_jmp_scopes was also adding a "jump to self" to codegen for
return statements, which was pretty silly.

(JSC::CodeBlock::dumpBytecode):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitPopScopes):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:
  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
4:46 PM Changeset in webkit [147183] by tony@chromium.org
  • 9 edits in trunk/LayoutTests

Convert some flexbox layout tests to using flexbox.css
​https://bugs.webkit.org/show_bug.cgi?id=113534

Reviewed by Ojan Vafai.

This allows tests to be run without the -webkit prefix for flexbox tests allowing
some of them to run in Firefox.

  • css3/flexbox/flex-align-baseline.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-max.html:
  • css3/flexbox/flex-align-percent-height.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
4:43 PM Changeset in webkit [147182] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, fix up some lint errors in TestExpectations.

  • platform/chromium/TestExpectations:
4:40 PM Changeset in webkit [147181] by aelias@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Use widget.parent() for plugin WebMouseEvents
​https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
​http://crbug.com/223335).

  • src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

4:12 PM Changeset in webkit [147180] by Lucas Forschler
  • 10 edits in tags/Safari-537.35.3

Merged r146955. <rdar://problem/12324224>

4:09 PM Changeset in webkit [147179] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

Resources are never revalidated/reloaded if a cached response exists on disk.
<rdar://problem/13479890> and ​https://bugs.webkit.org/show_bug.cgi?id=113542

Reviewed by Alexey Proskuryakov.

Trying to get a cached resource in didReceiveResponse and then aborting the load
meant we never performed any new loads.

We can check and see if the data is cached data inside didReceiveBuffer, instead.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse): Don't try for cached resources here.
(WebKit::NetworkResourceLoader::didReceiveData): This callback should never be used.
(WebKit::NetworkResourceLoader::didReceiveBuffer): Try to see if this data objected represents

a file based mmaped buffer.

  • NetworkProcess/NetworkResourceLoader.h:

Refactor these utility functions to start from either a CFURLCachedResponse or a SharedBuffer:

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(CFCachedURLResponseGetMemMappedData):
(CFURLCacheIsMemMappedData):
(WebKit::tryGetShareableHandleFromCFData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

4:08 PM Changeset in webkit [147178] by wangxianzhu@chromium.org
  • 4 edits in trunk/Source

[Chromium] Don't create SolidColorLayer for full transparent background
​https://bugs.webkit.org/show_bug.cgi?id=113524

Reviewed by James Robinson.

Source/WebCore:

Test: GraphicsLayerChromiumTest.setContentsToSolidColor

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(GraphicsLayerChromiumTest::setContentsToSolidColor):

4:07 PM Changeset in webkit [147177] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.3/Source/WebCore

Merged r147050. <rdar://problem/13205610>

4:03 PM Changeset in webkit [147176] by Lucas Forschler
  • 5 edits
    2 copies in tags/Safari-537.35.3

Merged r147018. <rdar://problem/13205610>

4:00 PM Changeset in webkit [147175] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.3/Source/WebKit2

Merged r146722. <rdar://problem/13205610>

3:55 PM Changeset in webkit [147174] by Lucas Forschler
  • 10 edits in tags/Safari-537.35.3/Source

Merged r146664. <rdar://problem/13205610>

3:48 PM Changeset in webkit [147173] by Lucas Forschler
  • 12 edits
    4 copies in tags/Safari-537.35.3

Merged r146946. <rdar://problem/13486852>

3:39 PM Changeset in webkit [147172] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk

use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
​https://bugs.webkit.org/show_bug.cgi?id=113518

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum XMLHttpRequestResponseType type instead of DOMString for
XMLHttpRequest responseType.

Argument validation now happens in the bindings.
XMLHttpRequest::setResponseType should then never receive invalid
arguments. So, replace console message with ASSERT_NOT_REACHED();

Test: fast/xmlhttprequest/xmlhttprequest-set-responsetype.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType):

  • xml/XMLHttpRequest.idl:

LayoutTests:

Update xmlhttprequest-responsetype-set-invalidtype expected result:
Test all valide responseType. Remove expected console message in case
of invalid responseType. Rename to xmlhttprequest-set-responsetype

  • fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-set-responsetype.html: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:
3:29 PM Changeset in webkit [147171] by Lucas Forschler
  • 326 edits
    17 copies
    2 deletes in tags/Safari-537.35.3

Merged r146531. <rdar://problem/12324224>

3:25 PM Changeset in webkit [147170] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[css3-text] Add platform support for "wavy" text decoration style
​https://bugs.webkit.org/show_bug.cgi?id=92868

Patch by Lamarque V. Souza <​Lamarque.Souza@basyskom.com> on 2013-03-28
Reviewed by Benjamin Poulain.

Source/WebCore:

This patch uses GraphicsContext::strokePath() to implement
wavy decoration for the CSS3 property "text-decoration-style".

No new tests as this is covered with existing tests.

  • rendering/InlineTextBox.cpp:

(WebCore::textDecorationStyleToStrokeStyle): Remove obsolete comment.
(WebCore::adjustStepToDecorationLength): Add function to adjust
variables used to calculate the lenght of Bezier curves.
(WebCore::strokeWavyTextDecoration): Add function to stroke wavy
decoration based on cubic Bezier curve.
(WebCore::InlineTextBox::paintDecoration): Call
strokeWavyTextDecoration when necessary.

LayoutTests:

Rebaseline chromium-linux expectation for
fast/css3-text/css3-text-decoration/text-decoration-style.html.

  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.
3:17 PM Changeset in webkit [147169] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

REGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=113538

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Simon Fraser.

Run run-bindings-tests --reset-results to fix broken tests after
r147149.

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::shortAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::createAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetter):
(WebCore::TestObjV8Internal::anyAttributeAttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::strictFloatAttrSetter):
(WebCore::TestObjV8Internal::idAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetter):

3:07 PM Changeset in webkit [147168] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
​https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

​http://trac.webkit.org/changeset/147152 was wrong, and should have been
(as the ChangeLog stated) testing the argument to redirectDataToPlugin,
not the value of m_pluginView.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

3:07 PM Changeset in webkit [147167] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r147130.
​http://trac.webkit.org/changeset/147130
​https://bugs.webkit.org/show_bug.cgi?id=113539

Not needed now that we do not sleep in preprocessor.pm
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-28

  • WebCore.gyp/WebCore.gyp:
  • bindings/scripts/CodeGenerator.pm:

(ParseInterface):

  • bindings/scripts/IDLParser.pm:

(Parse):

  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/generate-preprocessed-idls.pl: Removed.
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

3:01 PM Changeset in webkit [147166] by Lucas Forschler
  • 2 edits in trunk/Tools

Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.

Unreviewed.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

2:58 PM Changeset in webkit [147165] by Nate Chapin
  • 6 edits in trunk

Source/WebCore: Don't grant local content permissions for appcache loads.
​https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

No new tests, fixing http/tests/appcache/local-content.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::commitData): Don't grant local load permissions

to all SubstituteData loads, only give them to loads that were SubstituteData
loads at the time of DocumentLoader construction. This constitutes all
SubstituteData loads except those triggered by appcache.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Move granting local load

permissions for SubstituteData loads to DocumentLoader::commitData().

LayoutTests: Remove expected failure for ​https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

  • platform/qt-5.0-wk1/TestExpectations:
2:56 PM Changeset in webkit [147164] by mkwst@chromium.org
  • 15 edits in trunk

X-Frame-Options: Blocked resources should fire load events.
​https://bugs.webkit.org/show_bug.cgi?id=113192

Reviewed by Nate Chapin.

Source/WebCore:

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Fire a load event on the frame's owner element when denying access
due to X-Frame-Options header content. This brings us in-line with
Gecko and IE, which both trigger load events currently.

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:

Add some expectations around the 'load' event to ensure it's fired.

2:50 PM Changeset in webkit [147163] by commit-queue@webkit.org
  • 11 edits
    1 add in trunk/Source

Support bottom-right anchored fixed-position elements during a pinch gesture
​https://bugs.webkit.org/show_bug.cgi?id=111670

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-03-28
Reviewed by James Robinson.

Source/Platform:

Added WebLayerPositionConstraint for layers that need position
adjustment during threaded scrolling.
Currently it is only used for fixed-position layers.

  • Platform.gypi:
  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):
(WebKit::WebLayer::setPositionConstraint):
(WebKit::WebLayer::positionConstraint):
(WebKit::WebLayer::setFixedToContainerLayer):
(WebKit::WebLayer::fixedToContainerLayer):

  • chromium/public/WebLayerPositionConstraint.h: Added.

(WebKit):
(WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::fixedPosition):

Source/WebCore:

This patch adds support to bottom-right fixed-position elements by
introducing WebLayerPositionConstraint to WebLayer.

No new tests. Can't test until chromium patch landed.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateLayerPositionConstraint):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::clearPositionConstraintExceptForLayer):
(WebCore):
(WebCore::computePositionConstraint):
(WebCore::ScrollingCoordinatorChromium::updateLayerPositionConstraint):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.h:

(ScrollingCoordinatorChromium):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::registerScrollingLayers):

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::contentsContainmentLayer):
(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:
2:50 PM Changeset in webkit [147162] by Lucas Forschler
  • 20 edits in tags/Safari-537.35.3/Source

Merged r146823. <rdar://problem/13475462>

2:46 PM Changeset in webkit [147161] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
​https://bugs.webkit.org/show_bug.cgi?id=113377

Reviewed by Dimitri Glazkov.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.

2:46 PM Changeset in webkit [147160] by Lucas Forschler
  • 1 edit in tags/Safari-537.35.3/Source/WTF/ChangeLog

Fix revision number in ChangeLog.

2:45 PM Changeset in webkit [147159] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.3/Source/WTF

Merge portion of r146823 needed for <rdar://problem/13475462>

  • wtf/HashSet.h:

(WTF):
(WTF::copyToVector):

2:44 PM Changeset in webkit [147158] by jshin@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/TestExpectations

[Chromium] Unreviewed. Test Expectations update.

  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [147157] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary 1 second sleep on windows from preprocessor.pm
​https://bugs.webkit.org/show_bug.cgi?id=113536

Unreviewed, partial rollout of r146661.

This rolls out one line of 146661 that slows down the windows build significantly.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

2:03 PM Changeset in webkit [147156] by leviw@chromium.org
  • 5 edits in trunk

Source/WebCore: Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.

Enable measure-once optimization on Chromium-Mac
​https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

Bugs in Chromium-mac's -webkit-font-feature-settings support prevented us from enabling the
optimization when it was enabled for all other platforms. This was believed to be related to
kerning, but the bug shows up when there are any font-feature-settings specified. For now,
optimizing the common case and only turning off the optimization when there are font-feature-
settings in play.

Updated test fast/text/shaping/shaping-selection-rect.html to avoid breaking due to
​https://bugs.webkit.org/show_bug.cgi?id=113418

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests: Disable font measurement optimization for Chromium-mac when there are font-feature-settings.

Enable measure-once optimization on Chromium-Mac
​https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

  • fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing

due to ​https://bugs.webkit.org/show_bug.cgi?id=113418.

2:01 PM Changeset in webkit [147155] by zoltan@webkit.org
  • 3 edits
    2 moves
    3 adds in trunk

[CSS Exclusions][CSS Regions] Block children do not layout inline content correctly in a region with shape-inside set
​https://bugs.webkit.org/show_bug.cgi?id=112177

Reviewed by David Hyatt.

Source/WebCore:

When we had two multiple regions and a shape-inside was applied on the second region, but not on the first region and the content contained
paragraphs, the content was pushed down almost to the bottom in the second region. In a flow thread this behavior caused by the lack of the
proper updating of absoluteLogicalTop in RenderBlock::layoutRunsAndFloatsInRange function.

Tests: fast/regions/shape-inside/shape-inside-on-additional-regions.html

fast/regions/shape-inside/shape-inside-on-regions.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the value of absoluteLogicalTop in every run when we are in a flow thread.

LayoutTests:

Add a new subdirectory for regions shape-inside tests. Move old and add new test files to the directory.

  • fast/regions/shape-inside: Added.
  • fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-additional-regions.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-expected.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions-expected.html.
  • fast/regions/shape-inside/shape-inside-on-regions.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions.html.
1:52 PM Changeset in webkit [147154] by alokp@chromium.org
  • 1 edit
    1 copy
    1 move
    2 adds in trunk/LayoutTests

Unreviewed rebaseline.
Adding missing baseline for new test compositing/contents-opaque/control-layer.html

  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer-expected.txt: Copied from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
  • platform/chromium-win/compositing/contents-opaque/control-layer-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
1:38 PM Changeset in webkit [147153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r191172. Requested by
pdr2 via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-28

  • DEPS:
1:24 PM Changeset in webkit [147152] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
​https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

Ignore redirectDataToPlugin(0), which is only called from PluginDocument::detach(),
and only after r125500. Otherwise, PluginDocuments that are put into the page cache
but leave later can clear a totally different and legitimate PluginView from the
WebFrameLoaderClient, causing data to be lost and PluginDocument loads to stall.

This restores our behavior to the pre-r125500 state, which should be fine, as we
clear WebFrameLoaderClient's m_pluginView when the load fails or finishes. This
matches the changes made in r125500 for every platform other than Chromium and WebKit2.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

1:21 PM Changeset in webkit [147151] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: shouldUsePDFPlugin can't use pdfLayerControllerClass() because it asserts if it's not available
​https://bugs.webkit.org/show_bug.cgi?id=113533
<rdar://problem/13528720>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldUsePDFPlugin):
Move shouldUsePDFPlugin to WebPageMac, where it belongs, and explicitly look up PDFLayerController
instead of using pdfLayerControllerClass(), which ASSERT()s if it isn't available.

1:21 PM Changeset in webkit [147150] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Safari hangs during test262 run in CodeCache::pruneSlowCase
​https://bugs.webkit.org/show_bug.cgi?id=113469

Reviewed by Geoffrey Garen.

We can end up hanging for quite some time if we add a lot of small keys to the CodeCache.
By the time we get around to pruning the cache, we have a potentially tens or hundreds of
thousands of small entries, which can cause a noticeable hang when pruning them.

To fix this issue we added a hard cap to the number of entries in the cache because we
could potentially have to remove every element in the map.

  • runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): We need to prune until we're both under the hard cap and the
capacity in bytes.

  • runtime/CodeCache.h:

(CodeCacheMap):
(JSC::CodeCacheMap::numberOfEntries): Convenience accessor function to the number of entries in
the map that does the cast to size_t of m_map.size() for us.
(JSC::CodeCacheMap::canPruneQuickly): Checks that the total number is under the hard cap. We put this
check inside a function to more accurately describe why we're doing the check and to abstract out
the actual calculation in case we want to coalesce calls to pruneSlowCase in the future.
(JSC::CodeCacheMap::prune): Check the number of entries against our hard cap. If it's greater than
the cap then we need to drop down to pruneSlowCase.

1:08 PM Changeset in webkit [147149] by commit-queue@webkit.org
  • 5 edits in trunk

exceptions are not checked after toInt32 calls in bindings.
​https://bugs.webkit.org/show_bug.cgi?id=113218

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

In attribute setter, wrap JSValue to native value conversion in a try
catch block.

Define a new macro binding: V8TRYCATCH_VOID

No new tests: covered by fast/dom/exception-in-binding.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):

  • bindings/v8/V8BindingMacros.h:

(WebCore):

LayoutTests:

  • platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html
1:05 PM Changeset in webkit [147148] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening on AppleWin port.
More tests that use mouseScrollBy event which hasn't been implemented yet on Windows.

  • platform/win/TestExpectations:
1:01 PM Changeset in webkit [147147] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Use the right OS name on Mac EWS instead of mac-future.

Rubber-stamped by Dirk Pranke.

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):
(PatchProcessingQueue.begin_work_queue):
(PatchProcessingQueue._upload_results_archive_for_patch):

12:59 PM Changeset in webkit [147146] by Claudio Saavedra
  • 2 edits
    2 moves in trunk/LayoutTests

Prepare extend-selection-enclosing-block test to support different editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=113424

Reviewed by Ryosuke Niwa.

We make this test Mac specific and change
extendAndLogSelectionWithinBlock() to take the platform as a
parameter. When bug 110487 is fixed this should be extended to
test the Windows editing behavior.

  • editing/selection/extend-selection-enclosing-block-mac-expected.txt:

Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt.

  • editing/selection/extend-selection-enclosing-block-mac.html:

Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block.html.

  • editing/selection/resources/extend-selection.js:

(extendAndLogSelectionWithinBlock): Extend to receive platform as
a parameter. Only "mac" is supported for now.

12:59 PM Changeset in webkit [147145] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GTK][AC] Use transform property of ClutterActor
​https://bugs.webkit.org/show_bug.cgi?id=113317

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

ClutterActor has a transform property to set transformation matrix directly
since version 1.12. So we don't need to keep and use the matrix property of GraphicsLayerActor.

No new tests because of no functionality change.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphicsLayerActorDispose):
(graphicsLayerActorApplyTransform):

  • platform/graphics/clutter/GraphicsLayerActor.h:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::updateTransform):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::addTransformTransition):

12:57 PM Changeset in webkit [147144] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r143834.
​http://trac.webkit.org/changeset/143834
​https://bugs.webkit.org/show_bug.cgi?id=113530

Multiple use-after-free regressions on ClusterFuzz (Requested
by inferno-sec on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-28

  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/Attr.h:

(Attr):

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

  • dom/Element.h:

(Element):

12:52 PM Changeset in webkit [147143] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test
​https://bugs.webkit.org/show_bug.cgi?id=113490

Reviewed by Ryosuke Niwa.

  • editing/selection/move-vertically-with-paddings-borders.html:

(selectWord): Use String.trim() to drop trailing whitespaces that
might be added depending on the editing behavior. See related bug
110487.

12:46 PM Changeset in webkit [147142] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.3/Source

Versioning

12:42 PM Changeset in webkit [147141] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.3

New Tag.

12:24 PM Changeset in webkit [147140] by jchaffraix@webkit.org
  • 5 edits
    6 adds in trunk

[CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
​https://bugs.webkit.org/show_bug.cgi?id=113351

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-element-border-grid-item.html

fast/css-grid-layout/grid-element-border-padding-grid-item.html
fast/css-grid-layout/grid-element-padding-grid-item.html

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
Added this helper function (we do have borderAndPaddingStart but didn't have this
one for some reason).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::findChildLogicalPosition):
Shifted |offset| by the paddings and borders before / start.

LayoutTests:

  • fast/css-grid-layout/resources/grid.css:

(.verticalLR):
(.horizontalBT):
(.directionRTL):
Added more helper classes.

  • fast/css-grid-layout/grid-element-border-grid-item-expected.txt: Added.
  • fast/css-grid-layout/grid-element-border-grid-item.html: Added.
  • fast/css-grid-layout/grid-element-border-padding-grid-item-expected.txt: Added.
  • fast/css-grid-layout/grid-element-border-padding-grid-item.html: Added.
  • fast/css-grid-layout/grid-element-padding-grid-item-expected.txt: Added.
  • fast/css-grid-layout/grid-element-padding-grid-item.html: Added.
12:08 PM Changeset in webkit [147139] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip some layout test folder on Windows port.

  • platform/win/TestExpectations:
12:00 PM Changeset in webkit [147138] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Reduce PluginProcess lifetime.
<rdar://problem/12465479> and ​https://bugs.webkit.org/show_bug.cgi?id=113523

Reviewed by Sam Weinig.

Lower the minimum process lifetime from 30 minutes to 2 minutes.
Lower the "shutdown after last plugin goes away" period from 10 minutes to 1 minute.

  • UIProcess/Plugins/PluginProcessProxy.cpp:
11:58 AM Changeset in webkit [147137] by zandobersek@gmail.com
  • 18 edits
    2 adds
    2 deletes in trunk

[GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
​https://bugs.webkit.org/show_bug.cgi?id=112546

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Define the new platform_webcore_cppflags.

Source/Platform:

  • GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform

directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
CPPFLAGS.

  • GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the

GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
GNUmakefile.list.am placed in the same framework directory in which the source file is located.

Source/WebCore:

No new tests - no new functionality.

  • GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now

built into libPlatformGtk.la.

  • GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the

libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.

  • platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
  • platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.

Source/WebKit/gtk:

  • GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.

Source/WebKit2:

  • GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the

libPlatformGtk2's CPPFLAGS.

  • Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched

for forwarding headers, it's at the moment not necessary to be included.

  • Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the

WebCore framework.

  • Shared/gtk/WebEventFactory.cpp: Ditto.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.

Tools:

  • GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has

moved back to Source/WebCore/platform. Fix an indentation issue as well.

11:44 AM Changeset in webkit [147136] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
​https://bugs.webkit.org/show_bug.cgi?id=113447
Internal PR 313452

Patch by Jakob Petsovits <​jpetsovits@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Potential threading problems are avoided by moving from
WebPage members and mapToTransformed() to the web page
client's userInterfaceViewportAccessor().

As part of this cleaning effort, the WebPageCompositor's
render() method is changed to now take document instead of
pixel coordinates.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):

  • Api/WebPageCompositor.h:
  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

11:38 AM Changeset in webkit [147135] by falken@chromium.org
  • 55 edits in trunk/Source

Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
​https://bugs.webkit.org/show_bug.cgi?id=113273

Reviewed by Kent Tamura.

Element::disabled is about form controls and Element::isEnabledFormControl
is redundant with it, so replace them with a single function
Element::isDisabledFormControl.

Source/WebCore:

No new tests, there should be no behavior change.

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::canSetFocusAttribute):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isEnabled):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):

  • dom/Element.cpp:

(WebCore::Element::isDisabledFormControl):

  • dom/Element.h:

(Element):
(WebCore::isDisabledFormControl): Add helper function for convenience.
(WebCore):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::DOMFormData):

  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::disabledAttributeChanged):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
(WebCore::HTMLButtonElement::isSuccessfulSubmitButton):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
(WebCore::HTMLFormControlElement::isDisabledFormControl):
(WebCore::HTMLFormControlElement::supportsFocus):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isSuccessfulSubmitButton):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::isDisabledFormControl):

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLOptionElement.h:

(HTMLOptionElement):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::optionAtIndex):

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/ResetInputType.cpp:

(WebCore::ResetInputType::handleDOMActivateEvent):

  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isDisabledFormControl):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

  • html/shadow/SliderThumbElement.h:

(SliderThumbElement):

  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::updateImage):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemIsEnabled):

  • rendering/RenderTextControl.cpp:

(WebCore::updateUserModifyProperty):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isEnabled):

  • rendering/RenderThemeMac.mm:

(WebCore::getMediaUIPartStateFlags):

  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustMenuListStyle):

Source/WebKit/blackberry:

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::findPasswordFormFields):

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

Source/WebKit/chromium:

  • src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::isEnabled):

  • src/WebOptionElement.cpp:

(WebKit::WebOptionElement::isEnabled):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebSearchableFormData.cpp:

(HTMLNames::findSuitableSearchInputElement):
(HTMLNames::buildSearchString):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::disabled):

11:24 AM Changeset in webkit [147134] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Remove workaround for <rdar://problem/5321972>.
<rdar://problem/12022862> and ​https://bugs.webkit.org/show_bug.cgi?id=113516

Reviewed by Sam Weinig.

No new tests (No point in testing the removal of bizarre behavior).

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary): This workaround isn't needed on Lion+

11:13 AM Changeset in webkit [147133] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
​https://bugs.webkit.org/show_bug.cgi?id=113456

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum CanvasWindingRule type instead of DOMString for winding
arguments when needed. Changed methods are: fill, stroke and isPointInPath.

Test: fast/canvas/winding-enumeration.html

  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When calling methods accepting a CanvasWindingRule with an invalid
string, check that a TypeError is thrown.

  • fast/canvas/winding-enumeration-expected.txt: Added.
  • fast/canvas/winding-enumeration.html: Added.
10:47 AM Changeset in webkit [147132] by allan.jensen@digia.com
  • 1 edit
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Rebaseline font-face-woff after r147020

Unreviewed gardening.

Updated using garden-o-matic.

  • fast/css/font-face-woff-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/font-face-woff-expected.txt.
  • platform/mac/fast/css/font-face-woff-expected.txt: Removed.
  • platform/qt/fast/css/font-face-woff-expected.png: Added.
  • platform/qt/fast/css/font-face-woff-expected.txt: Added.
10:40 AM Changeset in webkit [147131] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove-iframe-crash.html.

Not Reviewed.

  • platform/mac-wk2/TestExpectations:
10:27 AM Changeset in webkit [147130] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

Move preprocessing of idl to pre-pass for gyp
​https://bugs.webkit.org/show_bug.cgi?id=113448

Patch by Scott Graham <​scottmg@chromium.org> on 2013-03-28
Reviewed by Tony Chang.

Moves the preprocessor invocations when parsing IDL files to a
pre-pass to avoid reinvocations when IDLs are referenced from others.
This reduces the number of invocations of the preprocessor from 20071
to 633, which reduces the runtime from 12m30 to 1m (on a Windows box).

No new tests, this is a build time improvement, and shouldn't have any
visible effect.

  • WebCore.gyp/WebCore.gyp:
  • bindings/scripts/CodeGenerator.pm:

(ParseInterface):

  • bindings/scripts/IDLParser.pm:

(Parse):

  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/generate-preprocessed-idls.pl: Added.
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:25 AM Changeset in webkit [147129] by kadam@inf.u-szeged.hu
  • 1 edit
    74 adds in trunk/LayoutTests

[Qt] Unreviewed gardneing. Updated png expected results after r146206.

  • platform/qt-5.0-wk2/editing/deleting/5126166-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/5206311-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/5369009-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/5433862-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-br-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-br-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-br-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-br-006-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-hr-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-listitem-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/merge-different-styles-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/pruning-after-merge-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/smart-delete-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/type-delete-after-quote-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/4580583-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/4924441-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/indent-empty-root-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/insertImage-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/nsresponder-indent-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/nsresponder-outdent-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/remove-list-item-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/4875189-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/4875189-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/4959067-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/5418891-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-3778059-fix-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-3800346-fix-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-div-025-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-paragraph-02-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/paragraph-separator-03-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/redo-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4076267-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4242293-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4641033-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/5032095-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/5134759-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/merge-end-borders-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/merge-start-list-expected.png: Added.
  • platform/qt-5.0-wk2/editing/pasteboard/styled-element-markup-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/13804-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/4866671-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/5099303-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/expanding-selections-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/expanding-selections2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-character-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-character-005-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-sentence-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/inline-table-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/mixed-editability-4-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/mixed-editability-5-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/move-by-character-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/move-by-character-005-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/replace-selection-1-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/table-caret-3-expected.png: Added.
  • platform/qt-5.0-wk2/editing/style/4916887-expected.png: Added.
  • platform/qt-5.0-wk2/editing/style/5084241-expected.png: Added.
10:14 AM Changeset in webkit [147128] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix layout test for blending in the background
​https://bugs.webkit.org/show_bug.cgi?id=113402

Patch by Mirela Budaes <​mbudaes@adobe.com> on 2013-03-28
Reviewed by Dirk Schulze.

Fixed the layout test effect-background-blend-mode.html typo
Also rebaselined the test

  • css3/compositing/effect-background-blend-mode.html:
  • platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
10:03 AM Changeset in webkit [147127] by alokp@chromium.org
  • 3 edits
    3 adds in trunk

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
​https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

  • compositing/contents-opaque/control-layer-expected.txt: Added.
  • compositing/contents-opaque/control-layer.html: Added.
  • platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
9:46 AM Changeset in webkit [147126] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding failure expectation for a reftest added in r147111
that's failing due to subpixel layout being disabled on the GTK port.

  • platform/gtk/TestExpectations:
9:38 AM Changeset in webkit [147125] by Martin Robinson
  • 4 edits
    1 add in trunk/Source/WebKit/gtk

[GTK] [gyp] Improve support for rerunning gyp automatically
​https://bugs.webkit.org/show_bug.cgi?id=113360

Reviewed by Gustavo Noronha Silva.

Add support for automatically rerunning gyp when input file changes are detected
while running make.

  • gyp/GNUmakefile: Added. A wrapper that invokes the generated makefile.
  • gyp/autogen.sh: Add a symlink to the wrapper script.
  • gyp/configure.ac: "Freeze" the TOPLEVEL_DIRECTORY command-line argument so that

run-gyp reads it properly when configure is run independently of autogen.sh.

  • gyp/run-gyp: Prevent generation of auto-regeneration rules in gyp. They are buggy.
9:32 AM Changeset in webkit [147124] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Committer Email Updates
​https://bugs.webkit.org/show_bug.cgi?id=113435

Patch by Ming Xie <​mxie@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Add the @blackberry.com email address for all our BlackBerry
WebKit committers. This is the first step for our email address
migration.

  • Scripts/webkitpy/common/config/committers.py:
9:31 AM Changeset in webkit [147123] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test inspector/console/console-css-warnings.html is failing on debug.
​https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

This test is temporatily disabled in TestExpectations. platform/chromium/TestExpectations override this expectation for chromium/debug.
It removed for now.

  • platform/chromium/TestExpectations:
9:05 AM Changeset in webkit [147122] by Philippe Normand
  • 3 edits in trunk/Tools

[jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=113508

Reviewed by Martin Robinson.

Prevent the GStreamer plugin scanner to load system-wide
plugins. Only the ones built in JHBuild should be loaded and used
at runtime.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
9:00 AM Changeset in webkit [147121] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK][AC] Animating layer disappears while running with clutter backend
​https://bugs.webkit.org/show_bug.cgi?id=110470

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

The reason of this issue is that clutter_actor_remove_child leads to stopping animations
of child actor. ClutterActor's animation could be defined only when it has a parent actor.
So we should avoid the case calling the api as much as we can. At least we don't
need to reset a actor's parent at all if the current parent is same with new one.
If we can't avoid invoking clutter_actor_remove_child for an animating actor, we may apply
a more complicated way to keep the animation. But I haven't faced such a case yet.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetSublayers):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::updateSublayerList):

8:48 AM Changeset in webkit [147120] by wangxianzhu@chromium.org
  • 4 edits
    4 adds in trunk

Non-painting fixed elements should not cause repaints on scroll
​https://bugs.webkit.org/show_bug.cgi?id=110430

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/scroll-fixed-layer-no-content.html
Test: compositing/repaint/scroll-fixed-layer-out-of-view.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.

LayoutTests:

  • compositing/repaint/scroll-fixed-layer-no-content.html: Added.
  • compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
  • compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
  • compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.
8:46 AM Changeset in webkit [147119] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Fix bad rebaseline in r147115.

  • fast/forms/validationMessage-expected.txt:
  • platform/efl/fast/forms/validationMessage-expected.txt:
8:35 AM Changeset in webkit [147118] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, revert accidentally added line committed in r147117.

  • inspector/front-end/ElementsTreeOutline.js:
8:15 AM Changeset in webkit [147117] by apavlov@chromium.org
  • 8 edits in trunk

Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor
​https://bugs.webkit.org/show_bug.cgi?id=113306

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use CodeMirror as the raw HTML editor for the "Edit as HTML" menu item
(and all multiline editors for WebInspector.startEditing()).
Drive-by fix for handling the editing when the editor has been invoked on the closing tag.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.commit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

  • inspector/front-end/UIUtils.js:

(WebInspector.EditingConfig.prototype.setMultiline):
(WebInspector.startEditing):
(WebInspector.CodeMirrorCSSLoadView): A bogus view to load-unload CodeMirror-related CSS on demand.

  • inspector/front-end/elementsPanel.css:

(#elements-content .CodeMirror):
(#elements-content .CodeMirror pre):
(#elements-content .CodeMirror-lines):

  • inspector/front-end/elementsPanel.css: CodeMirror styles for the "Edit as HTML" editor.
  • inspector/front-end/externs.js: Declare CodeMirror type with some members, as it is third-party code.
  • inspector/front-end/inspector.html: Fix script order (UIUtils.js requires View.js).

LayoutTests:

  • inspector/elements/edit-dom-actions.html:
7:53 AM Changeset in webkit [147116] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several tests as failing due to missing WKTR / DRT functionality.

  • platform/efl/TestExpectations:
7:44 AM Changeset in webkit [147115] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/forms/validationMessage.html after r145024.

  • fast/forms/validationMessage-expected.txt:
7:41 AM Changeset in webkit [147114] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening of test failures after r147086 and r147090.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
7:34 AM Changeset in webkit [147113] by morrita@google.com
  • 7 edits
    2 adds in trunk

Custom Elements: should support non-HTML namespaces.
​https://bugs.webkit.org/show_bug.cgi?id=111693

Reviewed by Dimitri Glazkov.

Source/WebCore:

Some existing code assumes that the element extends HTMLElements.
This change allow it to extend from Element. Note that the
namespace URI of a custom element is determined by given element
prototype: An element will have XHTML namespace if its prototype
chain includes HTMLElements, SVGElement leads SVG namespace and
null otherwise, respectively.

Test: fast/dom/custom/document-register-namespace.html

  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::hasValidPrototypeChainFor): Factored out from isValidPrototypeParameter()
(WebCore::CustomElementHelpers::isValidPrototypeParameter): Extend to support non HTMLElement prototype
(WebCore::CustomElementHelpers::findLocalName): Support non-HTML element names.

  • bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

  • dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElementInternal):

  • dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::registerElement): No longer hard-codes namespace and picks one based on the prototype value.

  • dom/CustomElementRegistry.h:

(CustomElementRegistry):

LayoutTests:

  • fast/dom/custom/document-register-namespace-expected.txt: Added.
  • fast/dom/custom/document-register-namespace.html: Added.
7:28 AM Changeset in webkit [147112] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform specific expectation for http/tests/inspector/console-resource-errors.html.
We get the same result as mac port.

  • platform/efl/http/tests/inspector/console-resource-errors-expected.txt: Added.
7:20 AM Changeset in webkit [147111] by hmuller@adobe.com
  • 4 edits
    6 adds in trunk

[CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside
​https://bugs.webkit.org/show_bug.cgi?id=112592

Reviewed by Dirk Schulze.

Source/WebCore:

First pass at computing the padded or inset boundary of a polygon. This version does not handle
self-intersecting polygons, or values of shape-padding large enough to change the shape of the
original polygon. The implementation computes an offset edge for each polgon edge, where the offset
edge is parallel to the original edge and separated by shape-padding. The padded polygon's vertices
are the intersections of each pair of adjacent offset edges. When adjacent offset edges do not intersect,
because they share a reflex vertex in the original polygon, an approximation to a circular arc
connects the offset edges.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html

fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::isReflexVertex): Just moved this function earlier in the file.
(WebCore::inwardEdgeNormal): Unit vector that's perpindicular to the edge and that points inwards.
(WebCore::outwardEdgeNormal): Unit vector that's perpindicular to the edge and that points outwards.
(WebCore::appendArc): Append a linear approximation to a circular arc to a vector of vertices.
(WebCore::computeShapePaddingBounds): Return a polygon whose edges are all inset by shape-padding from m_polygon.
(WebCore::computeShapeMarginBounds): Just a stub, see bug 112917.
(WebCore::ExclusionPolygon::shapePaddingBounds): Lazily use computeShapePaddingBounds() to initialize m_paddingBounds.
(WebCore::ExclusionPolygon::shapeMarginBounds): Lazily use computeShapeMarginBounds() to initialize m_marginBounds.
(WebCore::ExclusionPolygon::getIncludedIntervals): Now based on the value of shapePaddingBounds().
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Now based on the value of shapePaddingBounds().

  • rendering/ExclusionPolygon.h:

(WebCore::ExclusionPolygon::ExclusionPolygon):

LayoutTests:

Verify that the CSS shape-padding property works correctly for some simple polygonal shapes:
a rectangle, a rectangle rotated 45 degress, and rectangular shape with a single reflex vertex.

  • fast/exclusions/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html: Added.
7:04 AM Changeset in webkit [147110] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Handle EXIF orientation for ImageDocuments
​https://bugs.webkit.org/show_bug.cgi?id=113423

Internal Bug: PR 293648
Informally Reviewed by Jeff Rogers
Patch by Chris Hutten-Czapski <​chutten@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Support image orientation in our image draw calls, and advertise
the capability to the calling code. This allows us to respect EXIF
orientation data.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::BitmapImage::draw):
(WebCore):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

6:46 AM Changeset in webkit [147109] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: name timeline overview controls consistently
​https://bugs.webkit.org/show_bug.cgi?id=113503

Reviewed by Yury Semikhatsky.

Refactoring, covered by existing tests.

  • rename HeapGraph to TimelineMemoryOverview;
  • rename TimelineCategoryStrips to TimelineEventOvrview.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setMinimumRecordDuration):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):

6:43 AM Changeset in webkit [147108] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK] run-launcher --gtk -2 fails on a WK2-only build
​https://bugs.webkit.org/show_bug.cgi?id=113386

Reviewed by Carlos Garcia Campos.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName): The WebKit2GTK .so name change from 1.0
version to 3.0. Reflect this change so the builtDylibPathForName
function doesn't fail to report the library as found.

6:39 AM Changeset in webkit [147107] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Correct glyph contour winding direction when fake-bolding
​https://bugs.webkit.org/show_bug.cgi?id=113411

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

  • platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:

(WebCore::FontPlatformData::applyState):

6:35 AM Changeset in webkit [147106] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSourceCode does not have a scriptFile.
​https://bugs.webkit.org/show_bug.cgi?id=113500

Reviewed by Pavel Feldman.

JavaScriptSourceFrame now listens for uiSourceCode working copy related events and supports muting breakpoints without script file.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyChanged):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.dispose):

6:25 AM Changeset in webkit [147105] by caseq@chromium.org
  • 11 edits
    1 add in trunk/Source/WebCore

Web Inspector: factor out node search controller from inspector.js
​https://bugs.webkit.org/show_bug.cgi?id=112689

Reviewed by Pavel Feldman.

This just extracts the existing logic of toggling node search
from inspector.js into a class of its own, InspectElementModeController.
Drive-by: add CtrlOrMeta+Shift+C to help screen.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/compile-front-end.py:
  • inspector/front-end/InspectElementModeController.js: Added.

(WebInspector.InspectElementModeController):
(WebInspector.InspectElementModeController.createShortcut):
(WebInspector.InspectElementModeController.prototype.enabled):
(WebInspector.InspectElementModeController.prototype.disable):
(WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
(WebInspector.InspectElementModeController.prototype.toggleSearch):
(WebInspector.InspectElementModeController.prototype.handleShortcut):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._updateFocusedNode):

6:09 AM Changeset in webkit [147104] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
​https://bugs.webkit.org/show_bug.cgi?id=113375

Reviewed by Pavel Feldman.

Serialized "previouslyViewedFiles" may make local storage overflow.
Two fixed applied:

  • limit number of history log items
  • limit length of URIs that get serialized; this would affect only data-url URIs.
  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
Added length check.
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
Added output array length limit.

6:07 AM Changeset in webkit [147103] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
​https://bugs.webkit.org/show_bug.cgi?id=113497

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):

  • inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .data-grid div.heap-snapshot-multiple-values):

6:06 AM Changeset in webkit [147102] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: ResourceScriptFile should check if resource content really matches VM script when determining hasDiverged state.
​https://bugs.webkit.org/show_bug.cgi?id=113488

Reviewed by Pavel Feldman.

Source/WebCore:

Enabled support for checking that file content matches VM script in ResourceScriptFile (For script resources only).
This check is never done before content is loaded in corresponding editor to avoid regressing performance.
File - script content matching is done bearing in mind sourceURLs.
Live edit keeps sourceURL in script content now even if it is not present in file's content.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditScriptFile.prototype.checkMapping):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ScriptFile.prototype.checkMapping):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._sourceMatchesScriptSource):
(WebInspector.ResourceScriptFile.prototype._sourceEndsWithSourceURL):
(WebInspector.ResourceScriptFile.prototype.checkMapping.callback):
(WebInspector.ResourceScriptFile.prototype.checkMapping):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptFile.prototype.checkMapping):

LayoutTests:

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/file-system-project-mapping-expected.txt:
  • inspector/debugger/file-system-project-mapping.html:
6:04 AM Changeset in webkit [147101] by kadam@inf.u-szeged.hu
  • 196 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png expected results after r146206.

  • platform/qt/editing/deleting/5126166-expected.png:
  • platform/qt/editing/deleting/5206311-1-expected.png:
  • platform/qt/editing/deleting/5272440-expected.png:
  • platform/qt/editing/deleting/5369009-expected.png:
  • platform/qt/editing/deleting/5433862-2-expected.png:
  • platform/qt/editing/deleting/delete-3608445-fix-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-003-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
  • platform/qt/editing/deleting/delete-br-002-expected.png:
  • platform/qt/editing/deleting/delete-br-003-expected.png:
  • platform/qt/editing/deleting/delete-br-004-expected.png:
  • platform/qt/editing/deleting/delete-br-005-expected.png:
  • platform/qt/editing/deleting/delete-br-006-expected.png:
  • platform/qt/editing/deleting/delete-hr-expected.png:
  • platform/qt/editing/deleting/delete-image-002-expected.png:
  • platform/qt/editing/deleting/delete-line-003-expected.png:
  • platform/qt/editing/deleting/delete-line-004-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-listitem-001-expected.png:
  • platform/qt/editing/deleting/forward-delete-expected.png:
  • platform/qt/editing/deleting/merge-different-styles-expected.png:
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/qt/editing/deleting/smart-delete-003-expected.png:
  • platform/qt/editing/deleting/smart-delete-004-expected.png:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.png:
  • platform/qt/editing/execCommand/4580583-1-expected.png:
  • platform/qt/editing/execCommand/4924441-expected.png:
  • platform/qt/editing/execCommand/5482023-expected.png:
  • platform/qt/editing/execCommand/findString-2-expected.png:
  • platform/qt/editing/execCommand/indent-empty-root-expected.png:
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/qt/editing/execCommand/insertImage-expected.png:
  • platform/qt/editing/execCommand/nsresponder-indent-expected.png:
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/qt/editing/execCommand/paste-1-expected.png:
  • platform/qt/editing/execCommand/paste-2-expected.png:
  • platform/qt/editing/execCommand/remove-list-item-1-expected.png:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
  • platform/qt/editing/inserting/4875189-1-expected.png:
  • platform/qt/editing/inserting/4875189-2-expected.png:
  • platform/qt/editing/inserting/4959067-expected.png:
  • platform/qt/editing/inserting/5418891-expected.png:
  • platform/qt/editing/inserting/before-after-input-element-expected.png:
  • platform/qt/editing/inserting/editable-html-element-expected.png:
  • platform/qt/editing/inserting/edited-whitespace-1-expected.png:
  • platform/qt/editing/inserting/insert-3654864-fix-expected.png:
  • platform/qt/editing/inserting/insert-3778059-fix-expected.png:
  • platform/qt/editing/inserting/insert-3800346-fix-expected.png:
  • platform/qt/editing/inserting/insert-3851164-fix-expected.png:
  • platform/qt/editing/inserting/insert-div-011-expected.png:
  • platform/qt/editing/inserting/insert-div-012-expected.png:
  • platform/qt/editing/inserting/insert-div-013-expected.png:
  • platform/qt/editing/inserting/insert-div-014-expected.png:
  • platform/qt/editing/inserting/insert-div-015-expected.png:
  • platform/qt/editing/inserting/insert-div-016-expected.png:
  • platform/qt/editing/inserting/insert-div-017-expected.png:
  • platform/qt/editing/inserting/insert-div-018-expected.png:
  • platform/qt/editing/inserting/insert-div-019-expected.png:
  • platform/qt/editing/inserting/insert-div-020-expected.png:
  • platform/qt/editing/inserting/insert-div-025-expected.png:
  • platform/qt/editing/inserting/insert-div-027-expected.png:
  • platform/qt/editing/inserting/insert-paragraph-02-expected.png:
  • platform/qt/editing/inserting/paragraph-separator-03-expected.png:
  • platform/qt/editing/inserting/redo-expected.png:
  • platform/qt/editing/pasteboard/4076267-expected.png:
  • platform/qt/editing/pasteboard/4242293-expected.png:
  • platform/qt/editing/pasteboard/4641033-expected.png:
  • platform/qt/editing/pasteboard/4944770-1-expected.png:
  • platform/qt/editing/pasteboard/4944770-2-expected.png:
  • platform/qt/editing/pasteboard/4989774-expected.png:
  • platform/qt/editing/pasteboard/5028447-expected.png:
  • platform/qt/editing/pasteboard/5032095-expected.png:
  • platform/qt/editing/pasteboard/5134759-expected.png:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/qt/editing/pasteboard/input-field-1-expected.png:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.png:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.png:
  • platform/qt/editing/pasteboard/merge-start-list-expected.png:
  • platform/qt/editing/pasteboard/paste-text-004-expected.png:
  • platform/qt/editing/pasteboard/paste-text-008-expected.png:
  • platform/qt/editing/pasteboard/paste-text-009-expected.png:
  • platform/qt/editing/pasteboard/paste-text-013-expected.png:
  • platform/qt/editing/pasteboard/paste-text-014-expected.png:
  • platform/qt/editing/pasteboard/paste-text-016-expected.png:
  • platform/qt/editing/pasteboard/styled-element-markup-expected.png:
  • platform/qt/editing/selection/13804-expected.png:
  • platform/qt/editing/selection/4402375-expected.png:
  • platform/qt/editing/selection/4776665-expected.png:
  • platform/qt/editing/selection/4866671-expected.png:
  • platform/qt/editing/selection/4889598-expected.png:
  • platform/qt/editing/selection/4895428-2-expected.png:
  • platform/qt/editing/selection/4895428-3-expected.png:
  • platform/qt/editing/selection/4947387-expected.png:
  • platform/qt/editing/selection/4960116-expected.png:
  • platform/qt/editing/selection/4960137-expected.png:
  • platform/qt/editing/selection/4975120-expected.png:
  • platform/qt/editing/selection/4983858-expected.png:
  • platform/qt/editing/selection/5076323-1-expected.png:
  • platform/qt/editing/selection/5081257-1-expected.png:
  • platform/qt/editing/selection/5081257-2-expected.png:
  • platform/qt/editing/selection/5099303-expected.png:
  • platform/qt/editing/selection/5195166-2-expected.png:
  • platform/qt/editing/selection/5240265-expected.png:
  • platform/qt/editing/selection/7152-1-expected.png:
  • platform/qt/editing/selection/7152-2-expected.png:
  • platform/qt/editing/selection/addRange-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-left-expected.png:
  • platform/qt/editing/selection/caret-ltr-expected.png:
  • platform/qt/editing/selection/caret-ltr-right-expected.png:
  • platform/qt/editing/selection/caret-rtl-2-left-expected.png:
  • platform/qt/editing/selection/caret-rtl-right-expected.png:
  • platform/qt/editing/selection/clear-selection-expected.png:
  • platform/qt/editing/selection/contenteditable-click-inside-expected.png:
  • platform/qt/editing/selection/drag-select-1-expected.png:
  • platform/qt/editing/selection/editable-html-element-expected.png:
  • platform/qt/editing/selection/expanding-selections-expected.png:
  • platform/qt/editing/selection/expanding-selections2-expected.png:
  • platform/qt/editing/selection/extend-by-character-003-expected.png:
  • platform/qt/editing/selection/extend-by-character-005-expected.png:
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/qt/editing/selection/focus_editable_html-expected.png:
  • platform/qt/editing/selection/inline-table-expected.png:
  • platform/qt/editing/selection/mixed-editability-1-expected.png:
  • platform/qt/editing/selection/mixed-editability-3-expected.png:
  • platform/qt/editing/selection/mixed-editability-4-expected.png:
  • platform/qt/editing/selection/mixed-editability-5-expected.png:
  • platform/qt/editing/selection/mixed-editability-8-expected.png:
  • platform/qt/editing/selection/mixed-editability-9-expected.png:
  • platform/qt/editing/selection/move-3875618-fix-expected.png:
  • platform/qt/editing/selection/move-3875641-fix-expected.png:
  • platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
  • platform/qt/editing/selection/move-by-character-003-expected.png:
  • platform/qt/editing/selection/move-by-character-005-expected.png:
  • platform/qt/editing/selection/node-removal-1-expected.png:
  • platform/qt/editing/selection/node-removal-2-expected.png:
  • platform/qt/editing/selection/paragraph-granularity-expected.png:
  • platform/qt/editing/selection/range-between-block-and-inline-expected.png:
  • platform/qt/editing/selection/replace-selection-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/qt/editing/selection/select-all-003-expected.png:
  • platform/qt/editing/selection/select-all-005-expected.png:
  • platform/qt/editing/selection/select-all-006-expected.png:
  • platform/qt/editing/selection/select-all-iframe-expected.png:
  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/qt/editing/selection/selectNode-expected.png:
  • platform/qt/editing/selection/selectNodeContents-expected.png:
  • platform/qt/editing/selection/selection-actions-expected.png:
  • platform/qt/editing/selection/selection-button-text-expected.png:
  • platform/qt/editing/selection/table-caret-3-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/qt/editing/selection/word-granularity-expected.png:
  • platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/qt/editing/style/4916887-expected.png:
  • platform/qt/editing/style/5084241-expected.png:
  • platform/qt/editing/style/apple-style-editable-mix-expected.png:
  • platform/qt/editing/style/block-style-001-expected.png:
  • platform/qt/editing/style/block-style-002-expected.png:
  • platform/qt/editing/style/block-style-003-expected.png:
  • platform/qt/editing/style/create-block-for-style-001-expected.png:
  • platform/qt/editing/style/create-block-for-style-002-expected.png:
  • platform/qt/editing/style/create-block-for-style-003-expected.png:
  • platform/qt/editing/style/create-block-for-style-004-expected.png:
  • platform/qt/editing/style/create-block-for-style-005-expected.png:
  • platform/qt/editing/style/create-block-for-style-006-expected.png:
  • platform/qt/editing/style/create-block-for-style-007-expected.png:
  • platform/qt/editing/style/create-block-for-style-008-expected.png:
  • platform/qt/editing/style/create-block-for-style-009-expected.png:
  • platform/qt/editing/style/create-block-for-style-010-expected.png:
  • platform/qt/editing/style/create-block-for-style-011-expected.png:
  • platform/qt/editing/style/create-block-for-style-012-expected.png:
  • platform/qt/editing/style/create-block-for-style-013-expected.png:
  • platform/qt/editing/style/designmode-expected.png:
  • platform/qt/editing/style/relative-font-size-change-001-expected.png:
  • platform/qt/editing/style/relative-font-size-change-002-expected.png:
  • platform/qt/editing/style/relative-font-size-change-003-expected.png:
  • platform/qt/editing/style/relative-font-size-change-004-expected.png:
5:45 AM Changeset in webkit [147100] by zarvai@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Rebaselining after r147086.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
5:34 AM Changeset in webkit [147099] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it.
​https://bugs.webkit.org/show_bug.cgi?id=113489

Reviewed by Pavel Feldman.

ResourceScriptFile._hasDiverged is the one flag that shows whether we have diverged from VM.
It's values is based both on dirty flag on uiSourceCode and information about live edit failures stored in _lastLiveEditFailed field.
Removed willMerge/Diverge events from ScriptFile.
JavaScriptSourceFrame now uses isMergingToVM/DivergingFromVM methods on ScriptFile.
to determine whether breakpointAdded/Removed events should be ignored.
Introduced muted state on JavaScriptSourceFrame to determine whether it should ignore user attempts to set/remove breakpoints.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._didMergeToVM):
(WebInspector.JavaScriptSourceFrame.prototype._didDivergeFromVM):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._shouldIgnoreExternalBreakpointEvents):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditScriptFile.prototype.isMergingToVM):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptFile.prototype.isMergingToVM):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._update):
(WebInspector.ResourceScriptFile.prototype._divergeFromVM):
(WebInspector.ResourceScriptFile.prototype._mergeToVM):
(WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ResourceScriptFile.prototype.isMergingToVM):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptFile.prototype.isMergingToVM):

5:31 AM Changeset in webkit [147098] by kadam@inf.u-szeged.hu
  • 4 edits
    19 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png expected results after r146206..

  • platform/qt-5.0-wk2/fast/backgrounds/mask-box-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize08-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-scaled-gradient-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-slices-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/inset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png:
  • platform/qt-5.0-wk2/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
  • platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png:
5:16 AM Changeset in webkit [147097] by caseq@chromium.org
  • 7 edits in trunk

Web Inspector: DOMContentLoaded event divider is not shown on Timeline's main view
​https://bugs.webkit.org/show_bug.cgi?id=113196

Reviewed by Pavel Feldman.

Source/WebCore:

  • keep event divider records in TimelinePresentationModel, not in TimelinePanel;
  • process event divider records on every level, not just on top.
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.checkVisible):
(WebInspector.TimelinePanel.prototype._resetPanel):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype.eventDividerRecords):

LayoutTests:

  • use TimelinePresentationModel to fetch list of event divider records;
  • http/tests/inspector/timeline-test.js:

(initialize_Timeline.InspectorTest.printTimestampRecords):

  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-load-event.html:
5:14 AM Changeset in webkit [147096] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilation fix.

  • inspector/front-end/CookiesTable.js:
5:11 AM Changeset in webkit [147095] by commit-queue@webkit.org
  • 11 edits in trunk

Web Inspector: [DTE] Paint overlay highlight over line background color
​https://bugs.webkit.org/show_bug.cgi?id=113346

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

Source/WebCore:

No new tests: no change in behaviour.

  • Append spans instead of text nodes to lineRows.
  • Set positioning of all spans inside of webkit-line-content as

relative

  • Set z-index property so that overlay highlight is above line

background but under text.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._measureSpans):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):

  • inspector/front-end/textEditor.css:

(.webkit-line-content > .text-editor-overlay-highlight):
(.webkit-line-content > *):

LayoutTests:

Updated test expectations to correspond to new DefaultTextEditor's DOM
layout.

  • inspector/editor/text-editor-brace-highlighter-expected.txt:
  • inspector/editor/text-editor-highlight-api-expected.txt:
  • inspector/editor/text-editor-highlight-token-expected.txt:
  • inspector/editor/text-editor-long-line-expected.txt:
  • inspector/editor/text-editor-remove-chunks-from-dom-expected.txt:
  • inspector/editor/text-editor-show-whitespace-expected.txt:
  • inspector/editor/text-editor-type-over-decoration-expected.txt:
5:02 AM Changeset in webkit [147094] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
​https://bugs.webkit.org/show_bug.cgi?id=113491

Reviewed by Pavel Feldman.

Source/WebCore:

Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.

Test: inspector/styles/paste-property.html

  • inspector/front-end/StylesSidebarPane.js:

(.selectElement):
(.moveDirection.alreadyNew):

LayoutTests:

  • inspector/styles/paste-property-expected.txt: Added.
  • inspector/styles/paste-property.html: Added.
3:54 AM Changeset in webkit [147093] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adjusting the expectation for media/track/track-in-band-legacy-api.html.
3:40 AM Changeset in webkit [147092] by kadam@inf.u-szeged.hu
  • 410 edits
    3 copies
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results after r146206.

  • platform/qt/fast/backgrounds/001-expected.png:
  • platform/qt/fast/backgrounds/background-clip-text-expected.png:
  • platform/qt/fast/backgrounds/background-origin-root-element-expected.png:
  • platform/qt/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/qt/fast/backgrounds/opacity-on-document-element-expected.png:
  • platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
  • platform/qt/fast/block/basic/001-expected.png:
  • platform/qt/fast/block/basic/004-expected.png:
  • platform/qt/fast/block/basic/005-expected.png:
  • platform/qt/fast/block/basic/007-expected.png:
  • platform/qt/fast/block/basic/008-expected.png:
  • platform/qt/fast/block/basic/010-expected.png:
  • platform/qt/fast/block/basic/011-expected.png:
  • platform/qt/fast/block/basic/015-expected.png:
  • platform/qt/fast/block/basic/016-expected.png:
  • platform/qt/fast/block/basic/018-expected.png:
  • platform/qt/fast/block/basic/019-expected.png:
  • platform/qt/fast/block/basic/min-pref-width-nowrap-floats-expected.png:
  • platform/qt/fast/block/basic/minheight-expected.png:
  • platform/qt/fast/block/basic/quirk-height-expected.png:
  • platform/qt/fast/block/basic/quirk-percent-height-grandchild-expected.png:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
  • platform/qt/fast/block/float/001-expected.png:
  • platform/qt/fast/block/float/003-expected.png:
  • platform/qt/fast/block/float/004-expected.png:
  • platform/qt/fast/block/float/005-expected.png:
  • platform/qt/fast/block/float/006-expected.png:
  • platform/qt/fast/block/float/010-expected.png:
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/016-expected.png:
  • platform/qt/fast/block/float/017-expected.png:
  • platform/qt/fast/block/float/021-expected.png:
  • platform/qt/fast/block/float/023-expected.png:
  • platform/qt/fast/block/float/024-expected.png:
  • platform/qt/fast/block/float/025-expected.png:
  • platform/qt/fast/block/float/027-expected.png:
  • platform/qt/fast/block/float/029-expected.png:
  • platform/qt/fast/block/float/030-expected.png:
  • platform/qt/fast/block/float/031-expected.png:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.png:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-on-zero-height-line-expected.png:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-offsets-expected.png:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
  • platform/qt/fast/block/float/width-update-after-clear-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
  • platform/qt/fast/block/lineboxcontain/replaced-expected.png:
  • platform/qt/fast/block/margin-collapse/001-expected.png:
  • platform/qt/fast/block/margin-collapse/005-expected.png:
  • platform/qt/fast/block/margin-collapse/006-expected.png:
  • platform/qt/fast/block/margin-collapse/010-expected.png:
  • platform/qt/fast/block/margin-collapse/011-expected.png:
  • platform/qt/fast/block/margin-collapse/012-expected.png:
  • platform/qt/fast/block/margin-collapse/015-expected.png:
  • platform/qt/fast/block/margin-collapse/016-expected.png:
  • platform/qt/fast/block/margin-collapse/017-expected.png:
  • platform/qt/fast/block/margin-collapse/018-expected.png:
  • platform/qt/fast/block/margin-collapse/019-expected.png:
  • platform/qt/fast/block/margin-collapse/020-expected.png:
  • platform/qt/fast/block/margin-collapse/025-expected.png:
  • platform/qt/fast/block/margin-collapse/030-expected.png:
  • platform/qt/fast/block/margin-collapse/031-expected.png:
  • platform/qt/fast/block/margin-collapse/037-expected.png:
  • platform/qt/fast/block/margin-collapse/038-expected.png:
  • platform/qt/fast/block/margin-collapse/043-expected.png:
  • platform/qt/fast/block/margin-collapse/056-expected.png:
  • platform/qt/fast/block/margin-collapse/059-expected.png:
  • platform/qt/fast/block/margin-collapse/100-expected.png:
  • platform/qt/fast/block/margin-collapse/103-expected.png:
  • platform/qt/fast/block/margin-collapse/104-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/qt/fast/block/positioning/047-expected.png:
  • platform/qt/fast/block/positioning/049-expected.png:
  • platform/qt/fast/block/positioning/051-expected.png:
  • platform/qt/fast/block/positioning/052-expected.png:
  • platform/qt/fast/block/positioning/054-expected.png:
  • platform/qt/fast/block/positioning/055-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/qt/fast/block/positioning/height-change-expected.png:
  • platform/qt/fast/block/positioning/pref-width-change-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.png:
  • platform/qt/fast/body-propagation/background-image/009-expected.png:
  • platform/qt/fast/body-propagation/background-image/009-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/001-expected.png:
  • platform/qt/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-expected.png:
  • platform/qt/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/qt/fast/borders/bidi-002-expected.png:
  • platform/qt/fast/borders/bidi-009a-expected.png:
  • platform/qt/fast/borders/bidi-012-expected.png:
  • platform/qt/fast/borders/border-color-inherit-expected.png:
  • platform/qt/fast/borders/border-radius-huge-assert-expected.png:
  • platform/qt/fast/borders/border-radius-inline-flow-expected.png:
  • platform/qt/fast/borders/border-radius-split-inline-expected.png:
  • platform/qt/fast/borders/borderRadiusArcs01-expected.png:
  • platform/qt/fast/borders/borderRadiusDotted05-expected.png:
  • platform/qt/fast/borders/borderRadiusDouble01-expected.png:
  • platform/qt/fast/borders/borderRadiusDouble02-expected.png:
  • platform/qt/fast/borders/borderRadiusDouble03-expected.png:
  • platform/qt/fast/borders/borderRadiusGroove01-expected.png:
  • platform/qt/fast/borders/borderRadiusGroove02-expected.png:
  • platform/qt/fast/borders/borderRadiusInset01-expected.png:
  • platform/qt/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/qt/fast/borders/borderRadiusOutset01-expected.png:
  • platform/qt/fast/borders/borderRadiusRidge01-expected.png:
  • platform/qt/fast/borders/borderRadiusSolid01-expected.png:
  • platform/qt/fast/borders/borderRadiusSolid02-expected.png:
  • platform/qt/fast/borders/borderRadiusSolid03-expected.png:
  • platform/qt/fast/borders/borderRadiusSolid04-expected.png:
  • platform/qt/fast/borders/different-color-borders-expected.png:
  • platform/qt/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png:
  • platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
  • platform/qt/fast/borders/rtl-border-05-expected.png:
  • platform/qt/fast/borders/table-borders-expected.png:
  • platform/qt/fast/borders/webkit-border-radius-expected.png:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
  • platform/qt/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/qt/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/qt/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/qt/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/qt/fast/box-sizing/box-sizing-expected.png:
  • platform/qt/fast/box-sizing/panels-one-expected.png:
  • platform/qt/fast/box-sizing/panels-two-expected.png:
  • platform/qt/fast/canvas/canvas-zoom-expected.png:
  • platform/qt/fast/clip/001-expected.png:
  • platform/qt/fast/clip/002-expected.png:
  • platform/qt/fast/clip/003-expected.png:
  • platform/qt/fast/clip/004-expected.png:
  • platform/qt/fast/clip/005-expected.png:
  • platform/qt/fast/clip/006-expected.png:
  • platform/qt/fast/clip/007-expected.png:
  • platform/qt/fast/clip/008-expected.png:
  • platform/qt/fast/clip/009-expected.png:
  • platform/qt/fast/clip/010-expected.png:
  • platform/qt/fast/clip/011-expected.png:
  • platform/qt/fast/clip/012-expected.png:
  • platform/qt/fast/clip/013-expected.png:
  • platform/qt/fast/clip/014-expected.png:
  • platform/qt/fast/clip/015-expected.png:
  • platform/qt/fast/clip/nestedTransparencyClip-expected.png:
  • platform/qt/fast/clip/outline-overflowClip-expected.png:
  • platform/qt/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/qt/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/qt/fast/clip/overflow-border-radius-composited-expected.png:
  • platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/qt/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/qt/fast/css-generated-content/001-expected.png:
  • platform/qt/fast/css-generated-content/002-expected.png:
  • platform/qt/fast/css-generated-content/008-expected.png:
  • platform/qt/fast/css-generated-content/009-expected.png:
  • platform/qt/fast/css-generated-content/013-expected.png:
  • platform/qt/fast/css-generated-content/016-expected.png:
  • platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.png:
  • platform/qt/fast/css-generated-content/after-order-expected.png:
  • platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.png:
  • platform/qt/fast/css-generated-content/inline-display-types-expected.png:
  • platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png:
  • platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png:
  • platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
  • platform/qt/fast/css-generated-content/table-row-before-after-expected.png:
  • platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.png:
  • platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
  • platform/qt/fast/css/002-expected.png:
  • platform/qt/fast/css/003-expected.png:
  • platform/qt/fast/css/004-expected.png:
  • platform/qt/fast/css/005-expected.png:
  • platform/qt/fast/css/008-expected.png:
  • platform/qt/fast/css/ZeroOpacityLayers-expected.png:
  • platform/qt/fast/css/ZeroOpacityLayers2-expected.png:
  • platform/qt/fast/css/absolute-poition-in-rtl-parent-expected.png:
  • platform/qt/fast/css/attribute-selector-dynamic-expected.png:
  • platform/qt/fast/css/attribute-selector-empty-value-expected.png:
  • platform/qt/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/qt/fast/css/begin-end-contain-selector-empty-value-expected.png:
  • platform/qt/fast/css/border-height-expected.png:
  • platform/qt/fast/css/border-radius-outline-offset-expected.png:
  • platform/qt/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/qt/fast/css/child-style-can-override-visited-style-expected.png:
  • platform/qt/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/qt/fast/css/continuationCrash-expected.png:
  • platform/qt/fast/css/create_element_align-expected.png:
  • platform/qt/fast/css/css-imports-expected.png:
  • platform/qt/fast/css/css3-modsel-22-expected.png:
  • platform/qt/fast/css/css3-nth-child-expected.png:
  • platform/qt/fast/css/error-in-last-decl-expected.png:
  • platform/qt/fast/css/first-letter-first-line-hover-expected.png:
  • platform/qt/fast/css/first-letter-float-after-float-expected.png:
  • platform/qt/fast/css/first-letter-float-expected.png:
  • platform/qt/fast/css/first-letter-punctuation-expected.png:
  • platform/qt/fast/css/first-letter-recalculation-expected.png:
  • platform/qt/fast/css/first-letter-visibility-expected.png:
  • platform/qt/fast/css/focus-ring-detached-expected.png:
  • platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
  • platform/qt/fast/css/focus-ring-outline-color-expected.png:
  • platform/qt/fast/css/focus-ring-outline-offset-expected.png:
  • platform/qt/fast/css/focus-ring-outline-width-expected.png:
  • platform/qt/fast/css/font-face-implicit-local-font-expected.png:
  • platform/qt/fast/css/font-face-multiple-faces-expected.png:
  • platform/qt/fast/css/font-face-multiple-remote-sources-expected.png:
  • platform/qt/fast/css/font-smoothing-expected.png:
  • platform/qt/fast/css/font_property_normal-expected.png:
  • platform/qt/fast/css/hsla-color-expected.png:
  • platform/qt/fast/css/import-rule-regression-11590-expected.png:
  • platform/qt/fast/css/inline-properties-important-expected.png:
  • platform/qt/fast/css/invalid-percentage-property-expected.png:
  • platform/qt/fast/css/invalidation-errors-2-expected.png:
  • platform/qt/fast/css/invalidation-errors-3-expected.png:
  • platform/qt/fast/css/invalidation-errors-expected.png:
  • platform/qt/fast/css/last-child-style-sharing-expected.png:
  • platform/qt/fast/css/layerZOrderCrash-expected.png:
  • platform/qt/fast/css/line-height-overflow-expected.png:
  • platform/qt/fast/css/link-outside-head-expected.png:
  • platform/qt/fast/css/list-outline-expected.png:
  • platform/qt/fast/css/margin-bottom-form-element-quirk-expected.png:
  • platform/qt/fast/css/margin-bottom-form-element-strict-expected.png:
  • platform/qt/fast/css/namespaces/004-expected.png:
  • platform/qt/fast/css/namespaces/005-expected.png:
  • platform/qt/fast/css/namespaces/006-expected.png:
  • platform/qt/fast/css/namespaces/namespaces-comments-expected.png:
  • platform/qt/fast/css/namespaces/namespaces-empty-expected.png:
  • platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.png:
  • platform/qt/fast/css/negative-leading-expected.png:
  • platform/qt/fast/css/non-empty-span-expected.png:
  • platform/qt/fast/css/pendingStylesheetFontSize-expected.png:
  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png:
  • platform/qt/fast/css/position-negative-top-margin-expected.png:
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
  • platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
  • platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
  • platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
  • platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
  • platform/qt/fast/css/rem-dynamic-scaling-expected.png:
  • platform/qt/fast/css/rem-units-on-root-expected.png:
  • platform/qt/fast/css/rgb-float-expected.png:
  • platform/qt/fast/css/selector-set-attribute-expected.png:
  • platform/qt/fast/css/shadow-multiple-expected.png:
  • platform/qt/fast/css/style-outside-head-expected.png:
  • platform/qt/fast/css/style-parsed-outside-head-expected.png:
  • platform/qt/fast/css/table-rules-attribute-groups-with-frame-expected.png:
  • platform/qt/fast/css/table-text-align-quirk-expected.png:
  • platform/qt/fast/css/table-text-align-strict-expected.png:
  • platform/qt/fast/css/target-fragment-match-expected.png:
  • platform/qt/fast/css/text-align-expected.png:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
  • platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.png:
  • platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
  • platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
  • platform/qt/fast/css/text-transform-select-expected.png:
  • platform/qt/fast/css/textCapitalizeEdgeCases-expected.png:
  • platform/qt/fast/css/transform-default-parameter-expected.png:
  • platform/qt/fast/css/transformed-mask-expected.png:
  • platform/qt/fast/css/transition-color-unspecified-expected.png:
  • platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png:
  • platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
  • platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
  • platform/qt/fast/css/visibility-hit-test-expected.png:
  • platform/qt/fast/css/zoom-font-size-expected.png:
  • platform/qt/fast/doctypes/001-expected.png:
  • platform/qt/fast/doctypes/002-expected.png:
  • platform/qt/fast/doctypes/003-expected.png:
  • platform/qt/fast/doctypes/004-expected.png:
  • platform/qt/fast/dom/34176-expected.png:
  • platform/qt/fast/dom/Element/null-offset-parent-expected.png:
  • platform/qt/fast/dom/HTMLElement/bdo-expected.png:
  • platform/qt/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/qt/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/qt/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/qt/fast/dom/Range/create-contextual-fragment-expected.png:
  • platform/qt/fast/dom/Range/surroundContents-1-expected.png:
  • platform/qt/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
  • platform/qt/fast/dom/anchor-text-expected.png:
  • platform/qt/fast/dom/blur-contenteditable-expected.png:
  • platform/qt/fast/dom/createDocumentType-expected.png:
  • platform/qt/fast/dom/css-rule-functions-expected.png:
  • platform/qt/fast/dom/delete-contents-expected.png:
  • platform/qt/fast/dom/gc-10-expected.png:
  • platform/qt/fast/dom/importNodeHTML-expected.png:
  • platform/qt/fast/dom/importNodeXML-expected.png:
  • platform/qt/fast/dynamic/002-expected.png:
  • platform/qt/fast/dynamic/011-expected.png:
  • platform/qt/fast/dynamic/014-expected.png:
  • platform/qt/fast/dynamic/015-expected.png:
  • platform/qt/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
  • platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png:
  • platform/qt/fast/dynamic/first-letter-display-change-expected.png:
  • platform/qt/fast/dynamic/float-at-line-break-expected.png:
  • platform/qt/fast/dynamic/float-no-longer-overhanging-expected.png:
  • platform/qt/fast/dynamic/float-withdrawal-2-expected.png:
  • platform/qt/fast/dynamic/float-withdrawal-expected.png:
  • platform/qt/fast/dynamic/noninlinebadness-expected.png:
  • platform/qt/fast/dynamic/outerHTML-doc-expected.png:
  • platform/qt/fast/dynamic/outerHTML-img-expected.png:
  • platform/qt/fast/dynamic/subtree-parent-static-y-expected.png:
  • platform/qt/fast/dynamic/unicode-bidi-expected.png:
  • platform/qt/fast/dynamic/view-overflow-expected.png:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.png:
  • platform/qt/fast/events/event-listener-on-link-expected.png:
  • platform/qt/fast/events/resize-events-expected.png:
  • platform/qt/fast/fast-mobile-scrolling/fixed-position-element-expected.png:
  • platform/qt/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png:
  • platform/qt/fast/flexbox/001-expected.png:
  • platform/qt/fast/flexbox/002-expected.png:
  • platform/qt/fast/flexbox/003-expected.png:
  • platform/qt/fast/flexbox/004-expected.png:
  • platform/qt/fast/flexbox/005-expected.png:
  • platform/qt/fast/flexbox/006-expected.png:
  • platform/qt/fast/flexbox/007-expected.png:
  • platform/qt/fast/flexbox/008-expected.png:
  • platform/qt/fast/flexbox/009-expected.png:
  • platform/qt/fast/flexbox/010-expected.png:
  • platform/qt/fast/flexbox/011-expected.png:
  • platform/qt/fast/flexbox/012-expected.png:
  • platform/qt/fast/flexbox/013-expected.png:
  • platform/qt/fast/flexbox/014-expected.png:
  • platform/qt/fast/flexbox/015-expected.png:
  • platform/qt/fast/flexbox/016-expected.png:
  • platform/qt/fast/flexbox/017-expected.png:
  • platform/qt/fast/flexbox/018-expected.png:
  • platform/qt/fast/flexbox/019-expected.png:
  • platform/qt/fast/flexbox/020-expected.png:
  • platform/qt/fast/flexbox/021-expected.png:
  • platform/qt/fast/flexbox/022-expected.png:
  • platform/qt/fast/flexbox/023-expected.png:
  • platform/qt/fast/flexbox/024-expected.png:
  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.png:
  • platform/qt/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/qt/fast/forms/basic-buttons-expected.png:
  • platform/qt/fast/forms/basic-textareas-quirks-expected.png:
  • platform/qt/fast/forms/button-default-title-expected.png:
  • platform/qt/fast/forms/button-inner-block-reuse-expected.png:
  • platform/qt/fast/forms/button-table-styles-expected.png:
  • platform/qt/fast/forms/button-text-transform-expected.png:
  • platform/qt/fast/forms/control-clip-overflow-expected.png:
  • platform/qt/fast/forms/disabled-select-change-index-expected.png:
  • platform/qt/fast/forms/fieldset-align-expected.png:
  • platform/qt/fast/forms/file/file-input-direction-expected.png:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.png:
  • platform/qt/fast/forms/form-hides-table-expected.png:
  • platform/qt/fast/forms/input-appearance-selection-expected.png:
  • platform/qt/fast/forms/input-placeholder-paint-order-expected.png:
  • platform/qt/fast/forms/listbox-clip-expected.png:
  • platform/qt/fast/forms/menulist-clip-expected.png:
  • platform/qt/fast/forms/menulist-option-wrap-expected.png:
  • platform/qt/fast/forms/negativeLineHeight-expected.png:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/option-strip-whitespace-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/qt/fast/forms/select-initial-position-expected.png:
  • platform/qt/fast/forms/select-item-background-clip-expected.png:
  • platform/qt/fast/forms/select-list-box-with-height-expected.png:
  • platform/qt/fast/forms/select/optgroup-rendering-expected.png:
  • platform/qt/fast/forms/textarea-align-expected.png:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
3:07 AM Changeset in webkit [147091] by zarvai@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147086.

  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
2:50 AM Changeset in webkit [147090] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: Auto expand retaining path until there are more than one retainer.
​https://bugs.webkit.org/show_bug.cgi?id=112596

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-28
Reviewed by Yury Semikhatsky.

Source/WebCore:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.

Test: inspector/profiler/heap-snapshot-summary-retainers.html

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.populateComplete):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.setDataSource):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):

LayoutTests:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.

  • Added a test for the new behavior.
  • Replaced hardcoded "populate complete" string with the event object.
  • inspector/profiler/heap-snapshot-summary-retainers-expected.txt:
  • inspector/profiler/heap-snapshot-summary-retainers.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

2:47 AM Changeset in webkit [147089] by zarvai@inf.u-szeged.hu
  • 412 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating PNG expected results after r146206.

  • platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46924-expected.png:
  • platform/qt/tables/mozilla/bugs/bug47432-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48827-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52506-expected.png:
  • platform/qt/tables/mozilla/bugs/bug53690-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug53690-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5538-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55789-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57300-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5799-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5835-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.png:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60804-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60807-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6184-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.png:
  • platform/qt/tables/mozilla/bugs/bug641-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug641-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug647-expected.png:
  • platform/qt/tables/mozilla/bugs/bug650-expected.png:
  • platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug68912-expected.png:
  • platform/qt/tables/mozilla/bugs/bug68998-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69187-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug709-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7471-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7714-expected.png:
  • platform/qt/tables/mozilla/bugs/bug78162-expected.png:
  • platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8411-expected.png:
  • platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug88524-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8858-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9072-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug92143-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug92868-expected.png:
  • platform/qt/tables/mozilla/bugs/bug93363-expected.png:
  • platform/qt/tables/mozilla/bugs/bug963-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96343-expected.png:
  • platform/qt/tables/mozilla/bugs/bug965-expected.png:
  • platform/qt/tables/mozilla/bugs/bug97138-expected.png:
  • platform/qt/tables/mozilla/bugs/bug97383-expected.png:
  • platform/qt/tables/mozilla/bugs/bug98196-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug99948-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/qt/tables/mozilla/core/borders-expected.png:
  • platform/qt/tables/mozilla/core/captions-expected.png:
  • platform/qt/tables/mozilla/core/col_span-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
  • platform/qt/tables/mozilla/core/margins-expected.png:
  • platform/qt/tables/mozilla/core/nested1-expected.png:
  • platform/qt/tables/mozilla/core/row_span-expected.png:
  • platform/qt/tables/mozilla/core/table_frame-expected.png:
  • platform/qt/tables/mozilla/core/table_rules-expected.png:
  • platform/qt/tables/mozilla/core/table_widths-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
  • platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
  • platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
  • platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
  • platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols3-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols4-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols5-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/qt/tables/mozilla/marvin/body_tbody-expected.png:
  • platform/qt/tables/mozilla/marvin/body_tfoot-expected.png:
  • platform/qt/tables/mozilla/marvin/body_thead-expected.png:
  • platform/qt/tables/mozilla/marvin/col_span-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_span-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/colgroup_width_px-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/qt/tables/mozilla/marvin/table_row_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/table_row_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/table_row_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_groups-expected.png:
  • platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_border_0-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_border_1-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_border_2-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_border_3-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_cellpadding-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_cellspacing-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_class-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_default-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_id-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_style-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_colspan-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_height-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_rowspan-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_td_width-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_colspan-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_height-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_rowspan-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_th_width-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_width_percent-expected.png:
  • platform/qt/tables/mozilla/marvin/tables_width_px-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/tbody_char-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/thead_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_span-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_width_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_width_px-expected.png:
  • platform/qt/tables/mozilla/marvin/x_col_width_rel-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_span-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_border-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_border_none-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_border_px-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_cellpadding-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_frame_void-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_rules_none-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_width_pct-expected.png:
  • platform/qt/tables/mozilla/marvin/x_table_width_px-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_td_width-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_th_width-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_align_left-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_align_right-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_class-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_id-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_style-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_thead_valign_top-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_align_center-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_align_char-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
  • platform/qt/tables/mozilla/marvin/x_tr_valign_top-expected.png:
  • platform/qt/tables/mozilla/other/cellspacing-expected.png:
  • platform/qt/tables/mozilla/other/nested2-expected.png:
  • platform/qt/tables/mozilla/other/nestedTables-expected.png:
  • platform/qt/tables/mozilla/other/padding-expected.png:
  • platform/qt/tables/mozilla/other/test3-expected.png:
  • platform/qt/tables/mozilla/other/test6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug17826-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug47163-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/cols1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
  • platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/qt/transforms/2d/transform-borderbox-expected.png:
  • platform/qt/transforms/2d/transform-fixed-container-expected.png:
  • platform/qt/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/qt/transforms/2d/zoom-menulist-expected.png:
  • platform/qt/transitions/cross-fade-background-image-expected.png:
  • platform/qt/transitions/cross-fade-border-image-expected.png:
  • platform/qt/transitions/svg-text-shadow-transition-expected.png:
2:33 AM Changeset in webkit [147088] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fixed property text indentation in Styles sidebar.
​https://bugs.webkit.org/show_bug.cgi?id=113409

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.

  • inspector/front-end/StylesSidebarPane.js:
2:13 AM Changeset in webkit [147087] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Regression: Crash when selecting Hebrew and numbers in a list
​https://bugs.webkit.org/show_bug.cgi?id=111894

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

There is a crash when trying to click/select an anonymous
renderer.

This is a regression due to r143313 which tries to add border/padding
to the computed caret rect in RenderBox::localCaretRect().
The patch calls on the node() method for the corresponding
renderer. For an anonymous renderer though, node() returns
null. Since no check had been added for this, a crash occurs when
caret rect for an anonymous renderer is being computed.

Test: editing/selection/click-on-anonymous-content-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):
Added a check for validating the return from the node() call.

LayoutTests:

  • editing/selection/click-on-anonymous-content-crash-expected.txt: Added.
  • editing/selection/click-on-anonymous-content-crash.html: Added.

Added a testcase for verifying that no crash occurs when trying to
select/click an anonymous renderer, in this case the list marker's
renderer.

1:59 AM Changeset in webkit [147086] by mkwst@chromium.org
  • 5 edits
    11 adds in trunk

X-Frame-Options: Multiple headers are ignored completely.
​https://bugs.webkit.org/show_bug.cgi?id=113387

Reviewed by Nate Chapin.

Source/WebCore:

If a server sends multiple 'X-Frame-Options' headers, we end up with a
value like 'SAMEORIGIN, SAMEORIGIN'. Currently, we're treating that as
invalid, and ignoring the header. It would be safer to follow Gecko's
lead[1] by:

  • Folding duplicated entries into their common value (that is: 'sameorigin, sameorigin' -> 'sameorigin').
  • Failing closed in the case of conflicts (that is: 'sameorigin, allowall' -> 'deny').

[1]: ​https://bugzilla.mozilla.org/show_bug.cgi?id=761655

Tests: http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html

http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

Call out to parseXFrameOptionsHeader to get the header's disposition
and deal with each case in a switch statement for clarity. Add a new
console warning for the conflict case described above.

  • platform/network/HTTPParsers.cpp:

(WebCore::parseXFrameOptionsHeader):

  • platform/network/HTTPParsers.h:

Move X-Frame-Options parsing out into HTTPParsers, as it's getting
more and more complicated. To do this, the patch defines a new enum
to pass around the header's disposition.

LayoutTests:

  • http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-conflict.cgi: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-sameorigin.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
1:48 AM Changeset in webkit [147085] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed GTK build fix after r147039.

  • Source/autotools/symbols.filter: Export the missing symbols.
1:37 AM Changeset in webkit [147084] by commit-queue@webkit.org
  • 3 edits
    2 adds
    30 deletes in trunk/LayoutTests

[CSS Regions] Convert layout tests region-style-block-background-color[2] to ref-tests
​https://bugs.webkit.org/show_bug.cgi?id=86339

Patch by Mihai Tica <​mitica@adobe.com> on 2013-03-28
Reviewed by Tony Chang.

This patch converts the pixel test baseline into ref-tests for the following tests:
fast/regions/region-style-block-background-color.html
fast/regions/region-style-block-background-color2.html

  • fast/regions/region-style-block-background-color-expected.html: Added.
  • fast/regions/region-style-block-background-color.html:
  • fast/regions/region-style-block-background-color2-expected.html: Added.
  • fast/regions/region-style-block-background-color2.html:
  • platform/chromium-linux/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/chromium-mac/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/chromium-mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/chromium-win/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/chromium/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/chromium/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/efl/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/efl/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/mac/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/mac/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Removed.
  • platform/qt/fast/regions/region-style-block-background-color-expected.png: Removed.
  • platform/qt/fast/regions/region-style-block-background-color-expected.txt: Removed.
  • platform/qt/fast/regions/region-style-block-background-color2-expected.png: Removed.
  • platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Removed.
1:30 AM Changeset in webkit [147083] by kadam@inf.u-szeged.hu
  • 4 edits
    2 copies
    6 deletes in trunk/LayoutTests

Gardening. Organize expected results, because the generic expected file should be the one that uses JSC.
​https://bugs.webkit.org/show_bug.cgi?id=113291.

Reviewed by Csaba Osztrogonác.

  • inspector/console/console-eval-syntax-error-expected.txt:
  • inspector/debugger/debugger-pause-in-eval-script-expected.txt:
  • inspector/extensions/extensions-eval-expected.txt:
  • platform/chromium/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-pause-in-eval-script-expected.txt.
  • platform/chromium/inspector/extensions/extensions-eval-expected.txt: Copied from LayoutTests/inspector/extensions/extensions-eval-expected.txt.
  • platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Removed.
  • platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
  • platform/mac/inspector/extensions/extensions-eval-expected.txt: Removed.
  • platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Removed.
  • platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
  • platform/qt/inspector/extensions/extensions-eval-expected.txt: Removed.
1:26 AM Changeset in webkit [147082] by mihnea@adobe.com
  • 4 edits in trunk/Source/WebCore

[CSSRegions] Consolidate use of RenderRegion::isValid
​https://bugs.webkit.org/show_bug.cgi?id=113154

Reviewed by David Hyatt.

After ​https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately than the list of valid regions.
A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code
instead of testing for both isValid() and m_flowThread.

No new tests since there is no change is functionality, just code refactoring.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread): Added a new function to keep the code
used in addRegionToThread and checkInvalidRegions.
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect):
(WebCore::RenderRegion::computePreferredLogicalWidths):

1:25 AM Changeset in webkit [147081] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
​https://bugs.webkit.org/show_bug.cgi?id=113484

Unreviewed build fix.

Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.

Patch by Jaehun Lim <​ljaehun.lim@samsung.com> on 2013-03-28

  • TestWebKitAPI/CMakeLists.txt:
  • WebKitTestRunner/CMakeLists.txt:
1:09 AM Changeset in webkit [147080] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

  • platform/chromium/TestExpectations:
12:51 AM Changeset in webkit [147079] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for the EFL and GTK ports.

  • runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): Pass a 0 casted to the int64_t type instead of 0LL
to the std::max call so the arguments' types match.

12:44 AM Changeset in webkit [147078] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r147049. <rdar://problem/13522909>

12:42 AM Changeset in webkit [147077] by Lucas Forschler
  • 27 edits
    7 copies in tags/Safari-537.35.2

Merged r147039. <rdar://problem/13383835>

12:40 AM Changeset in webkit [147076] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Timeline. Refresh is slow when user drags the overview window.
​https://bugs.webkit.org/show_bug.cgi?id=113371

Reviewed by Pavel Feldman.

The root of problem is the 300ms delay in scheduleRefresh method.
It was introduced for the case when we add a huge number of records per second.
The scheduleRefresh was written such a way that refresh happened immediately
only for the scrolling operations. Actually we would like to see fast
refresh every time when it is forced by an user action.

In this patch additional flag newRecordWasAdded was added to the
_invalidateAndScheduleRefresh. I made it mandatory because the function
is also used as a callback for an event and it is easy to make a mistake and
interpret the event as the flag.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._durationFilterChanged):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._invalidateAndScheduleRefresh):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.performFilter):

12:29 AM Changeset in webkit [147075] by Lucas Forschler
  • 14 edits in tags/Safari-537.35.2

Merged r146956. <rdar://problem/13032692>

12:08 AM Changeset in webkit [147074] by Lucas Forschler
  • 24 edits
    3 copies in tags/Safari-537.35.2/Source

Merged r146929. <rdar://problem/13194263>

12:05 AM Changeset in webkit [147073] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

  • platform/chromium/TestExpectations:

Mar 27, 2013:

11:48 PM Changeset in webkit [147072] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146928. <rdar://problem/13492038>

11:44 PM Changeset in webkit [147071] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

  • platform/chromium/TestExpectations:

compositing/rtl tests are failing also on Linux Debug.

11:39 PM Changeset in webkit [147070] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Dragging to edge should always snap to min/max.
​https://bugs.webkit.org/show_bug.cgi?id=113477

Reviewed by Kent Tamura.

Source/WebCore:

Dragging to the edge of a slider should always snap to the min/max.

Test: fast/forms/range/range-slow-drag-to-edge.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

LayoutTests:

  • fast/forms/range/range-slow-drag-to-edge-expected.txt: Added.
  • fast/forms/range/range-slow-drag-to-edge.html: Added.
11:33 PM Changeset in webkit [147069] by Lucas Forschler
  • 3 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146913. <rdar://problem/13492038>

11:32 PM Changeset in webkit [147068] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt build fix after ​http://trac.webkit.org/changeset/147067.

  • WebProcess/WebPage/WebPage.cpp:
11:24 PM Changeset in webkit [147067] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

PDFPlugin: Enable PDFPlugin only if its dependencies exist on the system
​https://bugs.webkit.org/show_bug.cgi?id=113372
<rdar://problem/12685301>

Reviewed by Alexey Proskuryakov.

  • Shared/mac/PDFKitImports.h: Wrap in #if PLATFORM(MAC).
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Use shouldUsePDFPlugin.
(WebKit::WebPage::shouldUsePDFPlugin): If the PDFPlugin setting is enabled but PDFLayerController is not available, don't use PDFPlugin.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Add shouldUsePDFPlugin

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Use shouldUsePDFPlugin.

11:13 PM Changeset in webkit [147066] by Lucas Forschler
  • 7 edits
    5 copies in tags/Safari-537.35.2/Source/WebCore

Merged r146667. <rdar://problem/13194263>

11:10 PM Changeset in webkit [147065] by Lucas Forschler
  • 5 edits
    3 copies in tags/Safari-537.35.2

Merged r146626. <rdar://problem/13462658>

11:06 PM Changeset in webkit [147064] by Lucas Forschler
  • 8 edits in tags/Safari-537.35.2/Source

Merged r146536. <rdar://problem/13194263>

10:57 PM Changeset in webkit [147063] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146513. <rdar://problem/13194263>

10:54 PM Changeset in webkit [147062] by Lucas Forschler
  • 11 edits
    1 copy in tags/Safari-537.35.2/Source/WebCore

Merged r146508. <rdar://problem/13194263>

10:51 PM Changeset in webkit [147061] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.2/Source/WebCore

Merged r146488. <rdar://problem/13194263>

10:24 PM Changeset in webkit [147060] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.2/Source

Versioning.

10:21 PM Changeset in webkit [147059] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.2

New Tag.

10:18 PM Changeset in webkit [147058] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Add a way to update GraphicsLayerCA visibleRects without having to do a flush
​https://bugs.webkit.org/show_bug.cgi?id=113459

Reviewed by Tim Horton.

Some platforms need to update TiledBacking visible rects from
outside of WebKit, for example if they use delegated scrolling.
They want to avoid forcing layout to be up-to-date when doing this.

Currently, updating the visibleRect happens when the GraphicsLayerCA
layer are being flushed, but that makes some assumptions about
layout being up-to-date.

To fix this, add a light-weight pass over the layer tree that
uses TransformState to compute the visibleRect for each
layer, and only if the visibleRect would cause a change in the
tiles in a TiledBacking trigger a layer flush.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::recomputeVisibleRects):

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveComputeVisibleRect):
(WebCore::GraphicsLayerCA::recomputeVisibleRects):
(WebCore::GraphicsLayerCA::computeVisibleRect):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):

10:04 PM Changeset in webkit [147057] by pdr@google.com
  • 10 edits in trunk/Source/WebCore

Rename toScriptElement -> toScriptElementIfPossible
​https://bugs.webkit.org/show_bug.cgi?id=113473

Reviewed by Ryosuke Niwa.

Rename ScriptElement::toScriptElement to ScriptElement::toScriptElementIfPossible to
differentiate this function from other to*Element functions, and to better describe the
function's behavior. Other to*Element functions do not return null if the cast fails,
whereas toScriptElementIfPossible does.

No new tests as this is just a refactoring.

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/ScriptElement.h:

(WebCore):

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

This is the only unchecked return value but there isn't a security issue here.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::collectOptionInnerText):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertForeignElement):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::requestPendingScript):
(WebCore::HTMLScriptRunner::runScript):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::notifyFinished):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement):

9:06 PM Changeset in webkit [147056] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

http/tests/cache/subresource-failover-to-network.html is failing.

  • platform/chromium/TestExpectations:
8:58 PM Changeset in webkit [147055] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2013-03-27 Geoffrey Garen <​ggaren@apple.com>

Unreviewed build fix: Removed a dead field.

Pointed out by Mark Lam.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (ByteCodeParser):
8:54 PM Changeset in webkit [147054] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2013-03-27 Geoffrey Garen <​ggaren@apple.com>

Unreviewed build fix: Removed a dead field.

  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (ByteCodeParser):
8:41 PM Changeset in webkit [147053] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed some dead code in the DFG bytecode parser
​https://bugs.webkit.org/show_bug.cgi?id=113472

Reviewed by Sam Weinig.

Now that Phi creation and liveness analysis are separate passes, we can
remove the vestiges of code that used to do that in the bytecode
parser.

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parse):

8:38 PM Changeset in webkit [147052] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

[WebKit2] Need SPI to determine whether a plug-in is blocked
​https://bugs.webkit.org/show_bug.cgi?id=113463

Reviewed by Anders Carlsson.

Add new SPI, WKContextCopyPlugInInfoForBundleIdetifier, to get data about a plug-in,
including whether it is blocked by x-protect.

  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
Move to a shared location.

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable):
(WKPlugInInfoPathKey):
(WKPlugInInfoBundleIdentifierKey):
(WKPlugInInfoVersionKey):
(WKPlugInInfoLoadPolicyKey):
(WKPlugInInfoUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WKContextCopyPlugInInfoForBundleIdetifier):
Add new SPI and dictionary keys.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifer):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifer):
Add function to lookup plug-ins by bundle identifier.

8:32 PM Changeset in webkit [147051] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

  • platform/chromium/TestExpectations:
8:24 PM Changeset in webkit [147050] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Debug test fix after r147018.

toElement() asserts. What we want here is isElementNode().

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):

8:24 PM Changeset in webkit [147049] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

WKBundlePagePrivateMac.h is not being exported
​https://bugs.webkit.org/show_bug.cgi?id=113470
-and corresponding-
<rdar://problem/13522909>

Reviewed by Sam Weinig.

Mark it as private instead of project.

  • WebKit2.xcodeproj/project.pbxproj:
8:04 PM Changeset in webkit [147048] by noel.gordon@gmail.com
  • 10 edits
    15 adds in trunk

Add webp image color profile support
​https://bugs.webkit.org/show_bug.cgi?id=113184

Reviewed by Eric Seidel.

Source/WebCore:

Requires libwebp version 0.3.0 (decoder ABI version 0x201). For images
with an ICC color profile chunk, poll the incremental decoder for the
current decoded height with the WebPIDecGetRGB() API and color correct
any newly decoded rows in-situ in the frame buffer.

Note: the ICC chunk appears before the encoded image frame in the webp
encoding (RIFF container) format. When the incremental decoder outputs
decoded pixels, enough encoded data has arrived to read the entire ICC
color profile data chunk.

Tests: fast/images/webp-color-profile-lossless.html

fast/images/webp-color-profile-lossy-alpha.html
fast/images/webp-color-profile-lossy.html

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::~WEBPImageDecoder): Call clear().
(WebCore):
(WebCore::WEBPImageDecoder::clear):
Added. Helper to clean up the webp decoder and color transform members.
(WebCore::WEBPImageDecoder::createColorTransform):
Create m_transform using the supplied profile memory data. Note that
the |deviceProfile| is not owned, but the |inputProfile| temporary is
so release it here with qcms_release_profile().
(WebCore::WEBPImageDecoder::readColorProfile):
Called once only when the decoder begins to output decoded rows of an
image containing an ICC chunk, to read the ICC color profile data from
the encoded data stream, verify it, and use it to create m_transform.
(WebCore::WEBPImageDecoder::applyColorProfile):
Since there is no row callback in libwebp, poll for the decoded height
of the image so far. If new rows are decoded, color correct the pixels
of those new rows and re-write them back into the frame buffer using
buffer.setRGBA() to 1) alpha pre-multiply the pixels if needed, and 2)
shuffle the pixel bytes into the platform's RGBA pixel endian-ness.
(WebCore::WEBPImageDecoder::decode):
If the container format indicates the image has an ICC color profile,
decode the image to RGBA format for subsequent input to the QCMS color
correction library in applyColorProfile().

  • platform/image-decoders/webp/WEBPImageDecoder.h:

(WEBPImageDecoder):
(WebCore::WEBPImageDecoder::colorTransform): m_transform getter.

LayoutTests:

  • fast/images/resources/webp-color-profile-lossless.webp: Added.
  • fast/images/resources/webp-color-profile-lossy-alpha.webp: Added.
  • fast/images/resources/webp-color-profile-lossy.webp: Added.
  • fast/images/webp-color-profile-lossless-expected.txt: Added.
  • fast/images/webp-color-profile-lossless.html: Added.
  • fast/images/webp-color-profile-lossy-alpha-expected.txt: Added.
  • fast/images/webp-color-profile-lossy-alpha.html: Added.
  • fast/images/webp-color-profile-lossy-expected.txt: Added.
  • fast/images/webp-color-profile-lossy.html: Added.
  • platform/chromium-mac/fast/images/webp-color-profile-lossless-expected.png: Added.
  • platform/chromium-mac/fast/images/webp-color-profile-lossy-alpha-expected.png: Added.
  • platform/chromium-mac/fast/images/webp-color-profile-lossy-expected.png: Added.
  • platform/chromium-win/fast/images/webp-color-profile-lossless-expected.png: Added.
  • platform/chromium-win/fast/images/webp-color-profile-lossy-alpha-expected.png: Added.
  • platform/chromium-win/fast/images/webp-color-profile-lossy-expected.png: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
7:47 PM Changeset in webkit [147047] by fpizlo@apple.com
  • 5 edits
    6 adds in trunk

JIT and DFG should NaN-check loads from Float32 arrays
​https://bugs.webkit.org/show_bug.cgi?id=113462
<rdar://problem/13490804>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitFloatTypedArrayGetByVal):

LayoutTests:

  • fast/js/dfg-float32-array-nan-expected.txt: Added.
  • fast/js/dfg-float32-array-nan.html: Added.
  • fast/js/jit-float32-array-nan-expected.txt: Added.
  • fast/js/jit-float32-array-nan.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-float32-array-nan.js: Added.

(foo):

  • fast/js/script-tests/jit-float32-array-nan.js: Added.
7:19 PM Changeset in webkit [147046] by mark.lam@apple.com
  • 4 edits in trunk/Source/WebKit

Rolling out r147044.
​https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
7:17 PM Changeset in webkit [147045] by keishi@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Enable touch events in PagePopup
​https://bugs.webkit.org/show_bug.cgi?id=113380

We want to use touch events inside the calendar picker. This patch adds
PagePopupChromeClient::needTouchEvents() and moved hasTouchEventHandlers()
from WebViewClient to WebWidgetClient.

Reviewed by Kent Tamura.

  • public/WebViewClient.h:
  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::hasTouchEventHandlers): Moved from WebViewClient.

  • src/WebPagePopupImpl.cpp:

(WebKit):

6:55 PM Changeset in webkit [147044] by mark.lam@apple.com
  • 4 edits in trunk/Source/WebKit

Greening the Apple Win bot (debug build).
​https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
6:40 PM Changeset in webkit [147043] by mark.lam@apple.com
  • 4 edits in trunk/Source/WebKit

Greening the Apple Win bot.
​https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
6:35 PM Changeset in webkit [147042] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor validation checks for texture uploads
​https://bugs.webkit.org/show_bug.cgi?id=111012

Patch by Jun Jiang <​jun.a.jiang@intel.com> on 2013-03-27
Reviewed by Kenneth Russell.

Move the validation checks to the entry level of tex{Sub}Image2D, return early for invalid parameters and avoid duplicated checks.
Moreover, turn all the validation checks at the bottom level - tex{Sub}Image2DBase into assertions.

Already covered by current tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::validateTexFunc): A helper function for tex{Sub}Image2D to check input parameters.
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateHTMLImageElement):
(WebCore::WebGLRenderingContext::validateHTMLCanvasElement):
(WebCore::WebGLRenderingContext::validateHTMLVideoElement):

  • html/canvas/WebGLRenderingContext.h:
6:11 PM Changeset in webkit [147041] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

remove parentsOnly variable in codeGenerator.pm
​https://bugs.webkit.org/show_bug.cgi?id=113457

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

Remove unused variable parentsOnly.

No new tests: no change in behaviour.

  • bindings/scripts/CodeGenerator.pm:

(ForAllParents):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(ParseInterface):
(InheritsInterface):
(InheritsExtendedAttribute):

  • bindings/scripts/CodeGeneratorV8.pm:

(BaseInterfaceName):

5:47 PM Changeset in webkit [147040] by Patrick Gansterer
  • 4 edits in trunk

Set WTF_ARM_ARCH_VERSION to correct value when used with MSVC
​https://bugs.webkit.org/show_bug.cgi?id=113436

Reviewed by Benjamin Poulain.

.:

  • Source/cmake/OptionsWinCE.cmake: CPU(ARM_TRADITIONAL) is now set correctly by Platform.h.

Source/WTF:

The Microsoft compiler defines _M_ARM with used ARM version.

  • wtf/Platform.h:
5:42 PM Changeset in webkit [147039] by Beth Dakin
  • 27 edits
    7 adds in trunk

Need WK2 API to give a WebView a header and footer
​https://bugs.webkit.org/show_bug.cgi?id=113352
-and corresponding-
<rdar://problem/13383835>

Reviewed by Simon Fraser.

Source/WebCore:

This API will require RenderLayerCompositor to keep layers for the header and
footer when the exist. It also requires the scrolling machinery to know that the
size of the scrollable area will differ from the contentsSize when there is a
header or footer.

setWantsLayerForHeader() and setWantsLayerForFooter() return GraphicsLayers to
WK2. setHeaderHeight() and setFooterHeight() set the header and footer heights
respectively.

  • WebCore.exp.in:
  • page/FrameView.h:

(FrameView):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):

Should use totalContentsSize() instead of contentsSize().
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::isScrollable):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

This should also use totalContentsSize() instead of contentsSize(), and while
we're at it, re-name the variable and function names in the scrolling tree code
from contentsSize to totalContentsSize.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
(WebCore::ScrollingStateScrollingNode::dumpProperties):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::totalContentsSize):
(ScrollingStateScrollingNode):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::totalContentsSize):
(ScrollingTreeScrollingNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollParameters):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):

Use totalContentsSize() instead of contentsSize().

  • platform/ScrollView.cpp:

(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::calculateOverhangAreasForPainting):

scrollOffset() represents the offset within the totalContentsSize, but that is
not what we need here. So subtract out the headerHeight() for the appropriate
value.
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):

Use totalContentsSize() instead of contentsSize().

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore):
(WebCore::ScrollableArea::totalContentsSize):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::headerHeight):
(WebCore::ScrollableArea::footerHeight):
(ScrollableArea):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::pinnedInDirection):

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView):

The rootContentLayer needs to be offset by the headerHeight().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

New member variables m_layerForHeader and m_layerForFooter. This code properly
creates and manages them.
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

Test infrastructure.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore):
(WebCore::Internals::setFooterHeight):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

New API allows setting and getting layers for a header and footer.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/mac: Added.
  • WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h: Added.
  • WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm: Added.

(WKBundlePageGetHeaderLayer):
(WKBundlePageSetHeaderLayer):
(WKBundlePageGetFooterLayer):
(WKBundlePageSetFooterLayer):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setTopOverhangImage):
(WebKit::WebPage::setBottomOverhangImage):
(WebKit):
(WebKit::WebPage::getHeaderLayer):
(WebKit::WebPage::setHeaderLayerWithHeight):
(WebKit::WebPage::getFooterLayer):
(WebKit::WebPage::setFooterLayerWithHeight):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html: Added.
  • platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html: Added.
5:41 PM Changeset in webkit [147038] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

javascriptcore bindings do not check exception after calling valueToStringWithNullCheck
​https://bugs.webkit.org/show_bug.cgi?id=113219

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

Source/WebCore:

When converting JSValue to native value in attribute setter, store the
native value in a temporary variable. After this variable assignment,
always check if an exception has been raised.

Update binding tests.

Test: fast/dom/exception-in-binding.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GetNativeType):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalNode):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):

LayoutTests:

  • fast/dom/exception-in-binding-expected.txt: Added.
  • fast/dom/exception-in-binding.html: Added.
  • platform/chromium/TestExpectations: new test fails for now
5:39 PM Changeset in webkit [147037] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

cache parsed interfaces in CodeGenerator.pm
​https://bugs.webkit.org/show_bug.cgi?id=113446

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

When generating binding for an interface, informations about parent
interfaces are sometimes needed several times. This patch caches
those the parsed interface. When generating all WebCore bindings, this
results in a speedup of about 40% for JavaScriptCore and about 80% for
V8.

No new tests: no change in behaviour.

  • bindings/scripts/CodeGenerator.pm:

(ParseInterface):

5:33 PM Changeset in webkit [147036] by Claudio Saavedra
  • 54 edits in trunk/LayoutTests

Explicitly set editingBehavior in some tests.
​https://bugs.webkit.org/show_bug.cgi?id=113383

Reviewed by Ryosuke Niwa.

These tests make assumptions on how word selection works.
Actually, word selection will work differently depending on the
editingBehavior in place, see bug 110487, so the only way to
ensure the following tests will do word selection as expected is
to use Mac editing behavior.

  • editing/deleting/delete-by-word-001.html: Call setEditingBehavior("mac").
  • editing/deleting/list-item-1.html: ditto.
  • editing/deleting/non-smart-delete.html: ditto.
  • editing/deleting/smart-delete-002.html: ditto.
  • editing/deleting/smart-delete-across-editable-boundaries.html: ditto.
  • editing/execCommand/hilitecolor.html: ditto.
  • editing/execCommand/remove-formatting-2.html: ditto.
  • editing/inserting/4960120-2.html: ditto.
  • editing/inserting/insert-paragraph-02.html: ditto. ditto.
  • editing/inserting/insert-paragraph-03.html: ditto.
  • editing/inserting/insert-paragraph-04.html: ditto.
  • editing/inserting/paragraph-outside-nested-divs.html: ditto.
  • editing/inserting/paragraph-separator-01.html: ditto.
  • editing/inserting/paragraph-separator-02.html: ditto.
  • editing/inserting/paragraph-separator-03.html: ditto.
  • editing/pasteboard/4242293-1.html: ditto.
  • editing/pasteboard/4806874.html: ditto.
  • editing/pasteboard/5006779.html: ditto.
  • editing/pasteboard/8145-2.html: ditto.
  • editing/pasteboard/bad-placeholder.html: ditto.
  • editing/pasteboard/copy-text-with-backgroundcolor.html: ditto.
  • editing/pasteboard/drag-drop-modifies-page.html: ditto.
  • editing/pasteboard/get-data-text-plain-drop.html: ditto.
  • editing/pasteboard/insert-div-text-into-text.html: ditto.
  • editing/pasteboard/merge-end-3.html: ditto.
  • editing/pasteboard/merge-end-5.html: ditto.
  • editing/pasteboard/merge-end-borders.html: ditto.
  • editing/pasteboard/paste-blockquote-3.html: ditto.
  • editing/pasteboard/paste-list-004.html: ditto.
  • editing/pasteboard/pasting-object.html: ditto.
  • editing/selection/4932260-2.html: ditto.
  • editing/selection/extend-by-word-002.html: ditto.
  • editing/selection/extend-forward-by-word-over-non-editable.html: ditto.
  • editing/selection/transformed-selection-rects.html: ditto.
  • editing/style/5046875-1.html: ditto.
  • editing/style/5046875-2.html: ditto.
  • editing/style/fore-color-by-name.html: ditto.
  • editing/style/relative-font-size-change-002.html: ditto.
  • editing/style/relative-font-size-change-003.html: ditto.
  • editing/style/relative-font-size-change-004.html: ditto.
  • editing/style/style-boundary-005.html: ditto.
  • editing/text-iterator/first-letter-word-boundary.html: ditto.
  • editing/undo/undo-combined-delete-boundary.html: ditto.
  • editing/undo/undo-combined-delete.html: ditto.
  • editing/undo/undo-delete-boundary.html: ditto.
  • editing/undo/undo-delete.html: ditto.
  • editing/undo/undo-forward-delete-boundary.html: ditto.
  • editing/undo/undo-forward-delete.html: ditto.
  • fast/dom/34176.html: ditto.
  • platform/chromium-win/editing/deleting/non-smart-delete-expected.txt: Updated.
  • platform/efl/editing/deleting/non-smart-delete-expected.txt: Updated.
  • platform/gtk/editing/deleting/non-smart-delete-expected.txt: Updated.
  • platform/qt/editing/deleting/non-smart-delete-expected.txt: Updated.
5:29 PM Changeset in webkit [147035] by Claudio Saavedra
  • 1 edit
    20 moves in trunk/LayoutTests

Rename Editing tests whose expectations are Mac specific
​https://bugs.webkit.org/show_bug.cgi?id=113414

Reviewed by Ryosuke Niwa.

These tests have expectations that assume that word selection
works always as in Mac and therefore will break when ran with
editingBehavior set, for instance, to Windows (see bug
110487). Rename them to have the suffix -mac and explicitly set
editingBehavior to Mac.

When the fix for 110487 lands, counterparts to these tests with
suffix -win, editingBehavior set to win, and updated expectations
will be added.

  • editing/deleting/smart-editing-disabled-mac-expected.txt:

Renamed from
LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.

  • editing/deleting/smart-editing-disabled-mac.html: Renamed from

LayoutTests/editing/deleting/smart-editing-disabled.html.

  • editing/execCommand/remove-format-multiple-elements-mac-expected.txt:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.

  • editing/execCommand/remove-format-multiple-elements-mac.html:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements.html.

  • editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:

Renamed from
LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.

  • editing/execCommand/script-tests/toggle-link-mac.js: Renamed

from LayoutTests/editing/execCommand/script-tests/toggle-link.js.

  • editing/execCommand/toggle-link-mac-expected.txt: Renamed from

LayoutTests/editing/execCommand/toggle-link-expected.txt.

  • editing/execCommand/toggle-link-mac.html: Renamed from

LayoutTests/editing/execCommand/toggle-link.html.

  • editing/style/make-text-writing-direction-inline-mac-expected.txt:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.

  • editing/style/make-text-writing-direction-inline-mac.html:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline.html.

  • editing/style/push-down-font-styles-mac-expected.txt: Renamed

from LayoutTests/editing/style/push-down-font-styles-expected.txt.

  • editing/style/push-down-font-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-implicit-styles.html.

  • editing/style/push-down-implicit-styles-around-list-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.

  • editing/style/push-down-implicit-styles-around-list-mac.html:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list.html.

  • editing/style/push-down-implicit-styles-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-expected.txt.

  • editing/style/push-down-implicit-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-font-styles.html.

  • editing/style/script-tests/make-text-writing-direction-inline-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.

  • editing/style/script-tests/push-down-font-styles-mac.js: Renamed

from
LayoutTests/editing/style/script-tests/push-down-font-styles.js.

  • editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.

  • editing/style/script-tests/push-down-implicit-styles-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.

5:25 PM Changeset in webkit [147034] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Add a settings to disallow initializing background-size if background shorthand doesn't include it.
​https://bugs.webkit.org/show_bug.cgi?id=113363

Source/WebCore:

Patch by KyungTae Kim <​ktf.kim@samsung.com> and Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-03-27
Reviewed by David Kilzer.

This is based on KyungTae Kim's patch in ​https://bugs.webkit.org/show_bug.cgi?id=97761. Many legacy sites set
background-size first and then set background for setting background-image. For backward-compatibility
in some WebKit based clients, if 'background' shorthand have no 'background-size' attribute, we could add
a settings to let the css parser not initialize 'background-size'.

Test: fast/backgrounds/background-shorthand-after-set-backgroundSize.html

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext): initialize useLegacyBackgroundSizeShorthandBehavior.
(WebCore::operator==):
(WebCore::CSSParser::useLegacyBackgroundSizeShorthandBehavior): add a method to return if we want background-size

to be initialized by background shorthand.

(WebCore):
(WebCore::CSSParser::parseFillShorthand): don't initialize background-size in background shorthand if we have

useLegacyBackgroundSizeShorthandBehavior set to true.

  • css/CSSParser.h:

(CSSParser):

  • css/CSSParserMode.h: add member useLegacyBackgroundSizeShorthandBehavior to CSSParserContext.

(CSSParserContext):

  • page/Settings.in: initialize useLegacyBackgroundSizeShorthandBehavior to false.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): add the new settings useLegacyBackgroundSizeShorthandBehavior to Backup.
(WebCore::InternalSettings::Backup::restoreTo): restore useLegacyBackgroundSizeShorthandBehavior from Backup.
(WebCore::InternalSettings::setUseLegacyBackgroundSizeShorthandBehavior):
(WebCore):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl: add a JS testing API setUseLegacyBackgroundSizeShorthandBehavior to turn on/off

the new settings.

LayoutTests:

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-03-27
Reviewed by David Kilzer.

Add test for the new settings useLegacyBackgroundSizeShorthandBehavior.

  • fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Added.
  • fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Added.
5:18 PM Changeset in webkit [147033] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused RenderLayer::renderBox{X,Y} methods
​https://bugs.webkit.org/show_bug.cgi?id=113408

Reviewed by Simon Fraser.

Minor cleanup - renderBoxX() and renderBox() are no longer used.

No new tests: no functional changes.

  • rendering/RenderLayer.h:
5:18 PM Changeset in webkit [147032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Show compositing on the Inspector timeline properly
​https://bugs.webkit.org/show_bug.cgi?id=113416

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-03-27
Reviewed by Rob Buis.

The call to willComposite was too early and encompased the paint calls
as well. Moving it lower will no longer encompass the paints.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):

5:16 PM Changeset in webkit [147031] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Plumb and expose cookie clearing options throughout the Resources Cookies tree and views
​https://bugs.webkit.org/show_bug.cgi?id=87140

Patch by PhistucK <​phistuck@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

Added cookie clearing buttons and context menu options
throughout the tree and views.
Drive by -

  • Made sure the delete button is only visible

when a cookie is selected.

  • Fixed a wrong JSDoc comment.
  • inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype.statusBarItems):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype.clear):
Added. Clears the entire cookie view.
(WebInspector.CookieItemsView.prototype._clearButtonClicked):
Added. Ditto (when clicking on the button).
(WebInspector.CookieItemsView.prototype._showDeleteButton):
Added. Shows the delete button when selecting a cookie row.

  • inspector/CookiesTable.js:

(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._clearAndRefresh):
Added. Clears the cookies of the current table and updates it.
(WebInspector.CookiesTable.prototype._handleContextMenuEvent):
Added. Manages the context menu within the table.
(WebInspector.CookiesTable.prototype.clear):
Added. Clears the cookies of the current table.
(WebInspector.CookiesTable.prototype.setCookies):

Fixed a wrong JSDoc comment structure.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.clearCookies):
Added. Clears the cookies of the given domain view.
(WebInspector.CookieTreeElement.prototype.onattach):
Added. Adds a contextmenu handler.
(WebInspector.CookieTreeElement.prototype._handleContextMenuEvent):
Added. Manages the context menu within cookie tree.
(WebInspector.CookieTreeElement.prototype._clearCookies):
Added. Clears the cookies of the view of the tree item.

  • inspector/front-end/treeoutline.js:

(TreeOutline): Fixed a wrong JSDoc comment.

  • English.lproj/localizedStrings.js:

Added strings for the context menu options.

5:14 PM Changeset in webkit [147030] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: [DTE] implement "tokenAtTextPosition" method
​https://bugs.webkit.org/show_bug.cgi?id=113390

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/editor/text-editor-token-at-position.html

  • Add TextEditor.tokenAtTextPosition method
  • Implement tokenAtTextPosition method in DefaultTextEditor
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.tokenAtTextPosition):
(WebInspector.TextEditorMainPanel.prototype.compare):
(WebInspector.TextEditorMainPanel.prototype.tokenAtTextPosition):
(WebInspector.TextEditorMainPanel.prototype._tokenAtUnhighlightedLine):
(WebInspector.TextEditorMainPanel.prototype.set mimeType):
(WebInspector.TextEditorMainPanel.prototype.get mimeType):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.tokenAtTextPosition):

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.get mimeType):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):

LayoutTests:

Add a test to verify TextEditor.tokenAtTextPosition method.

  • inspector/editor/text-editor-token-at-position-expected.txt: Added.
  • inspector/editor/text-editor-token-at-position.html: Added.
5:13 PM Changeset in webkit [147029] by charles.wei@torchmobile.com.cn
  • 13 edits in trunk/Source/WebCore

Remove build warning for unused function parameters in indexeddb.
​https://bugs.webkit.org/show_bug.cgi?id=113043

Reviewed by Tony Chang.

No new tests, just remove build warning.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::stringToDirection):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::prefetchReset):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIndexesReady):

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stringToMode):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

5:11 PM Changeset in webkit [147028] by commit-queue@webkit.org
  • 6 edits in trunk

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
​https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

5:10 PM Changeset in webkit [147027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: enhance Popover.js to rely on hover element coordinates
​https://bugs.webkit.org/show_bug.cgi?id=113340

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

Introduce a coordinates-based method that checks if mouse is inside hover
element and use it in PopoverHelper instead of DOM hierarchy.

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._eventInHoverElement): Added.
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._mouseOut):

5:08 PM Changeset in webkit [147026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] fix webinspector-css theme for CodeMirror
​https://bugs.webkit.org/show_bug.cgi?id=113399

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Alexander Pavlov.

Add style rule to highlight css properties for CodeMirror
webinspector-css theme.

No new tests: no change in behaviour.

  • inspector/front-end/cm/cmdevtools.css:

(.cm-s-web-inspector-css span.cm-property):

5:05 PM Changeset in webkit [147025] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [DTE] paint overlay highlight for unhighlighted lines
​https://bugs.webkit.org/show_bug.cgi?id=113344

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

No new tests.

Remove fast-return condition from paintLine method that checked for
highlight existence.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):

5:02 PM Changeset in webkit [147024] by anilsson@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Populate the mime type of the WebContext for images
​https://bugs.webkit.org/show_bug.cgi?id=113272

Reviewed by George Staikos.

PR 278967

Populate the mime type using the file extension reported by the image
decoder. This way we benefit from file type sniffing, instead of
relying on the mime type reported by the resource response.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

5:01 PM Changeset in webkit [147023] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Revision for the internal jhbuild is too old
​https://bugs.webkit.org/show_bug.cgi?id=113324

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-03-27
Reviewed by Martin Robinson.

Update the minimum required version to a point where jhbuild won't
fail installing packages when trying to remove a symlink to a directory.

  • jhbuild/jhbuild-wrapper: Updated revision.
5:01 PM Changeset in webkit [147022] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk

Shift clicking on an element with -webkit-user-select: all doesn't extend selection
​https://bugs.webkit.org/show_bug.cgi?id=113270

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by updateSelectionForMouseDownDispatchingSelectStart always replacing selection whenever
the target node was inside an element with -webkit-suer-select even when we were attemping to extend selection
in handleMousePressEventSingleClick.

Fixed the bug by extracting this logic as a separate function (expandSelectionToRespectUserSelectAll) and deploying
it in handleMousePressEventSingleClick to extend selection as needed.

Test: editing/selection/user-select-all-with-shift.html

  • page/EventHandler.cpp:

(WebCore::expandSelectionToRespectUserSelectAll): Extracted from updateSelectionForMouseDownDispatchingSelectStart.
(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick): Adjust "pos" as needed when extending selection.
Also use shouldConsiderSelectionAsDirectional() instead of manually peeking editingBehaviorType while we're at it.

LayoutTests:

Added a regression test for shift clicking on an element with -webkit-user-select: all.
Skip it on non-Mac platforms as -webkit-user-select: all hasn't been enabled on them.

  • editing/selection/user-select-all-with-shift-expected.txt: Added.
  • editing/selection/user-select-all-with-shift.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
4:59 PM Changeset in webkit [147021] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r143102): iframe with percentage height within table with anonymous cell fails.
​https://bugs.webkit.org/show_bug.cgi?id=113077

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-27
Reviewed by Antti Koivisto.

​http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level
"Anonymous block boxes are ignored when resolving percentage values that would refer to it:
the closest non-anonymous ancestor box is used instead."
When figuring out whether auto height needs to be applied on the current box, ignore anonymous
ancestors until the first non-anonymous containing block is found. This matches both
Firefox and Opera behaviour.

Test: fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight): Switch from
isAnonymousBlock() to isAnonymous() to make sure all anonymous boxes are ignored.
Remove isTableCell() check which is a noop as table cell isn't an anonymous block.

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-27
Reviewed by Antti Koivisto.

  • fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell-expected.txt: Added.
  • fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html: Added.
4:57 PM Changeset in webkit [147020] by pierre.rossi@gmail.com
  • 6 edits in trunk

[Qt] Add WOFF support when using zlib
​https://bugs.webkit.org/show_bug.cgi?id=112805

Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Covered by existing test:
fast/css/font-face-woff.html

  • Target.pri: Conditional inclusion of WOFFFileFormat
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::createFontCustomPlatformData): Try to unpack WOFF data, otherwise spit out a warning and bail.
(WebCore::FontCustomPlatformData::supportsFormat): accept WOFF webfonts if USE(ZLIB).

LayoutTests:

  • platform/qt-5.0-wk2/TestExpectations: keep skipped for WK2 due to a WTR bug.
  • platform/qt/TestExpectations: unskip font-face-woff.html
4:49 PM Changeset in webkit [147019] by robert@webkit.org
  • 7 edits
    2 adds in trunk

Growing a position:absolute element in a position:relative one in a table does not update scrollHeight
​https://bugs.webkit.org/show_bug.cgi?id=111977

Reviewed by David Hyatt.

Source/WebCore:

During simplified layout tables still need to know about overflow from positioned objects in any of
their cells.

Test: fast/table/cell-overflow-simplified-layout.html

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::simplifiedNormalFlowLayout):
(WebCore):

  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore):
(WebCore::RenderTableSection::computeOverflowFromCells):

  • rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

  • fast/table/cell-overflow-simplified-layout-expected.html: Added.
  • fast/table/cell-overflow-simplified-layout.html: Added.
4:45 PM Changeset in webkit [147018] by ggaren@apple.com
  • 5 edits
    2 adds in trunk

Honor the setting for whether JavaScript markup is enabled
​https://bugs.webkit.org/show_bug.cgi?id=113122

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • dom/ScriptableDocumentParser.cpp:

(WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Applied the
setting here, so all document parsing would be covered. This is similar
to what we do for plug-in stripping.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertForeignElement): Fixed a bug where
we would insert an SVG script element into the document even in script
markup disabled mode.

(This bug has existed for copy/paste for a long time, but other bugs and
quirks in SVG copy/paste papered over it. It's a serious issue now
that non-paste clients will rely on this mode.)

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Fixed the same
bug -- this time in the part of the parser that executes scripts as they
parse.

I adopted the toScriptElement() convention for testing for a script
element to match the XML parser.

LayoutTests:

  • editing/unsupported-content/script-markup-enabled-setting-expected.txt: Added.
  • editing/unsupported-content/script-markup-enabled-setting.html: Added.
4:37 PM Changeset in webkit [147017] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeCache::m_capacity can becoming negative, producing undefined results in pruneSlowCase
​https://bugs.webkit.org/show_bug.cgi?id=113453

Reviewed by Geoffrey Garen.

  • runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): We make sure that m_minCapacity doesn't drop below zero now.
This prevents m_capacity from doing the same.

4:12 PM Changeset in webkit [147016] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
​https://bugs.webkit.org/show_bug.cgi?id=113203

Reviewed by Philippe Normand.

We build our libsoup without GNOME support. gst-plugins-good does separate
pkg-config checks for libsoup-gnome and libsoup, causing the build to use
libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
build failures as the headers of those diverge. We do not use souphttpsrc, so
disable it when building gst-plugins-good.

  • gtk/jhbuild.modules: disable soup support in gst-plugins-good.
4:12 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
4:09 PM Changeset in webkit [147015] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore/platform/gtk/po

Tamil translation for Gnome 3.6
​https://bugs.webkit.org/show_bug.cgi?id=96995

Patch by Shantha kumar <​shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

  • ta.po: Added.
3:58 PM Changeset in webkit [147014] by fpizlo@apple.com
  • 27 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: JITCode should abstract exactly how the JIT code is structured and where it was allocated
​https://bugs.webkit.org/show_bug.cgi?id=113437

Reviewed by Mark Hahnenberg.

JITCode is now a virtual base class, which will allow different JITs to have radically
different memory allocation and management conventions in the future. It will also
make it easier to store JIT-specific meta-data in CodeBlock just by putting it into
an appropriate JITCode subclass.

For now there is one subclass, DirectJITCode, which just behaves like JITCode used to
behave.

  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::getJITType):
(CodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::codeLocationForRepatch):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compile):
(JIT):

  • jit/JITCode.cpp:

(JSC):
(JSC::JITCode::JITCode):
(JSC::JITCode::~JITCode):
(JSC::JITCode::execute):
(JSC::JITCode::hostFunction):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::~DirectJITCode):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):

  • jit/JITCode.h:

(JSC):
(JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JSC::JITCode::isOptimizingJIT):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::jitType):
(JSC::JITCode::jitTypeFor):
(JSC::JITCode::executableAddress):
(JSC::JITCode::start):
(JSC::JITCode::end):
(DirectJITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITStubs.cpp:

(JSC::lazyLinkFor):
(JSC::DEFINE_STUB_FUNCTION):

  • jit/ThunkGenerators.cpp:

(JSC::virtualForGenerator):

  • llint/LLIntEntrypoints.cpp:

(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h:

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::ExecutableBase::generatedJITCodeFor):
(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::EvalExecutable::generatedJITCode):
(JSC::ProgramExecutable::generatedJITCode):

  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

3:43 PM Changeset in webkit [147013] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Going full screen and cancelling gets system into a weird state
​https://bugs.webkit.org/show_bug.cgi?id=113445

Reviewed by Eric Carlson.

Replace an array of BOOL member variables to track full screen state with a single enum, and
add state tracking for the "waiting to enter" and "waiting to exit" states. Use this new,
more specific enum to be more stringent about the state when responding to WebProcess
messages. Also only set the placeholder view's target once in full screen mode.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController isFullScreen]): Yes when in full screen, entering full screen,

or waiting to enter full screen.

(-[WKFullScreenWindowController cancelOperation:]): Only requestExitFullScreen() if a watchdog

has not already been made active.

(-[WKFullScreenWindowController enterFullScreen:]): Use the new state variable.
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Ditto. Set the placeholder target.
(-[WKFullScreenWindowController exitFullScreen]): Ditto. Clear the placeholder target.
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Ditto.
(-[WKFullScreenWindowController performClose:]): Ditto.
(-[WKFullScreenWindowController close]): Ditto.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Ditto.

3:07 PM Changeset in webkit [147012] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Chromium Mac fails to build after r146995 because the new NSFont category
may conflict with the system. Add the WebCoreTheme category to the whitelist.

Unreviewed.

  • WebCore.gyp/WebCore.gyp:
2:56 PM Changeset in webkit [147011] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r146852. Please another reference to the Lion leaks builder.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:31 PM Changeset in webkit [147010] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Blind attempt at fixing the release build.

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::willCacheResponseAsync):

2:04 PM Changeset in webkit [147009] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Another Windows build fix attempt after r147004.

  • WebKit.vcproj/WebKitExports.def.in:
1:51 PM Changeset in webkit [147008] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Selection code spends a lot of time in InlineTextBox::localSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=113364

Reviewed by Enrica Casucci.

Avoid computing the font width when we're selecting the entire line box.

This appears to be 25-26% improvement on Interactive/SelectAll:Time.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):

1:47 PM Changeset in webkit [147007] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in

Windows build fix attempt.

1:38 PM Changeset in webkit [147006] by beidson@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Mem mapped resource data improvements.
<rdar://problem/13196481> and ​https://bugs.webkit.org/show_bug.cgi?id=113422

Reviewed by Alexey Proskuryakov (and looked over by Geoff Garen).

Remove timer-based approach support code:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::abortInProgressLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):

  • NetworkProcess/NetworkResourceLoader.h:

Add an object to encapsulate monitoring a resource going in to the disk cache.
It listens for a callback on the cached response indicating it is disk backed
and also sets a timeout so we don't keep the monitor alive and waiting forever.

  • NetworkProcess/mac/DiskCacheMonitor.h: Added.

(WebKit::DiskCacheMonitor::destinationID):
(WebKit::DiskCacheMonitor::connectionToWebProcess):
(WebKit::DiskCacheMonitor::resourceRequest):

  • NetworkProcess/mac/DiskCacheMonitor.mm: Added.

(CFCachedURLResponseSetBecameFileBackedCallBackBlock):
(WebKit::monitorFileBackingStoreCreation):
(WebKit::DiskCacheMonitor::DiskCachingMonitor):
(WebKit::DiskCacheMonitor::connection):

Refactoring and monitor certain cached responses:

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(CFCachedURLResponseGetMemMappedData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse): Use CFCachedURLResponseGetMemMappedData

to explicitly get an mem-mapped data object.

(WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):
(WebKit::NetworkResourceLoader::willCacheResponseAsync): If the resource is over the minimum

size then set up a disk caching monitor.

  • WebKit2.xcodeproj/project.pbxproj:
1:35 PM Changeset in webkit [147005] by timothy@apple.com
  • 2 adds in trunk/Source/WebKit2/Resources

Add missing images from my previous commit.

1:34 PM Changeset in webkit [147004] by timothy@apple.com
  • 48 edits
    1 delete in trunk

Add support for dock-to-right of the Web Inspector in the Mac port.

Unfortunately this requires Safari changes, so it is disabled in the nightly builds.

​https://webkit.org/b/113341
rdar://problem/10368152

Reviewed by Joseph Pecoraro.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setAttachedWindowWidth):
(WebCore):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):

  • inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.setAttachedWindowWidth):

  • testing/Internals.cpp:

Source/WebKit/chromium:

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::changeAttachedWindowWidth):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowWidth):

  • WebCoreSupport/InspectorClientEfl.h:

(InspectorFrontendClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorFrontendClient::attachWindow):
(WebKit::InspectorFrontendClient::setAttachedWindowWidth):

  • WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient):

Source/WebKit/mac:

  • Resources/Dock.pdf: Updated.
  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(-[WebInspectorWindowController attachWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):

  • WebInspector/WebInspectorFrontend.mm:

(-[WebInspectorFrontend attach]):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::frontendLoaded):
(WebCore::InspectorFrontendClientQt::attachWindow):
(WebCore::InspectorFrontendClientQt::setAttachedWindowWidth):

  • WebCoreSupport/InspectorClientQt.h:

(InspectorFrontendClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::setAttachedWindowWidth):

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

Source/WebKit2:

  • Resources/Dock.pdf: Removed.
  • Resources/DockBottom.pdf: Added.
  • Resources/DockRight.pdf: Added.
  • Shared/WebPreferencesStore.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::attachBottom):
(WebKit::WebInspectorProxy::attachRight):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::setAttachedWindowWidth):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter attachRight:]):
(-[WKWebInspectorProxyObjCAdapter attachBottom:]):
(-[WKWebInspectorWindow _cursorForResizeDirection:]):
(-[WKWebInspectorWindow _customTitleFrame]):
(WebKit::createDockButton):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
(WebKit::WebInspectorProxy::platformInspectedWindowWidth):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::attachWindow):
(WebKit::WebInspectorFrontendClient::setAttachedWindowWidth):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::attachBottom):
(WebKit::WebInspector::attachRight):
(WebKit::WebInspector::setAttachedWindowWidth):
(WebKit::WebInspector::attachedBottom):
(WebKit::WebInspector::attachedRight):
(WebKit::WebInspector::detached):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):

  • WebProcess/WebPage/WebInspector.messages.in:
12:55 PM Changeset in webkit [147003] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Slovenian translation
​https://bugs.webkit.org/show_bug.cgi?id=113151

Patch by Matej Urbančič <​mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

  • sl.po: translation update.
11:54 AM Changeset in webkit [147002] by zandobersek@gmail.com
  • 16 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r146992.

  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-strict-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
11:45 AM Changeset in webkit [147001] by eric.carlson@apple.com
  • 14 edits
    2 adds in trunk

[Mac] webkitClosedCaptionsVisible doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=113417

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-in-band-legacy-api.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Delete m_disableCaptions, it is no longer used.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Pass this to textTrackSelectionScore.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Delete m_disableCaptions, it is no longer used.

  • html/HTMLMediaElement.h: Ditto.
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::textTrackSelectionScore): Add an HTMLMediaElement parameter.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Return a score if the media element

is showing captions, even if the preference says captions are disabled.

LayoutTests:

  • media/track/track-in-band-legacy-api-expected.txt: Added.
  • media/track/track-in-band-legacy-api.html: Added.
  • platform/chromium/TestExpectations: Skip new test.
  • platform/efl/TestExpectations: Ditto.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
11:33 AM Changeset in webkit [147000] by eric.carlson@apple.com
  • 5 edits in trunk

[Mac] Text track menu items sometimes labeled incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=113406

Reviewed by Jer Noble.

Source/WebCore:

media/video-controls-captions-trackmenu-localized.html was updated to test this.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::trackDisplayName): Use the 'label' attribute for the menu text when necessary.

LayoutTests:

  • media/video-controls-captions-trackmenu-localized.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
11:26 AM Changeset in webkit [146999] by sergio@webkit.org
  • 6 edits in trunk

Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode
​https://bugs.webkit.org/show_bug.cgi?id=113413

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a "normal" insert instead of a replace when there is
nothing to replace (like at the end of a line) as this case is not
supported by the replacing code path. This will allow us to
properly rebalance whitespaces in those cases.

Updated the editing/execCommand/overtype.html test to check also
this use case.

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): use the recently added
setEndingSelectionWithoutValidation() to avoid code duplication.

  • editing/InsertTextCommand.h:

(InsertTextCommand):

LayoutTests:

Updated the test to include the case of inserting a whitespace
both in the middle or at the end of a line.

  • editing/execCommand/overtype-expected.txt:
  • editing/execCommand/overtype.html:
11:17 AM Changeset in webkit [146998] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
​https://bugs.webkit.org/show_bug.cgi?id=113421

Reviewed by Dirk Pranke.

When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
in the GTK-specific TestExpectations files.

To avoid this only enable the warnings only when not using WKTR.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.warn_if_bug_missing_in_test_expectations):

10:54 AM Changeset in webkit [146997] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/PerformanceTests

Add a performance tests for selecting all content in a document
​https://bugs.webkit.org/show_bug.cgi?id=113358

Reviewed by Levi Weintraub.

Add a performance test for selecting all. We wait for paint to happen by setTimeout(~, 0).

Example outputs:

RESULT Interactive: SelectAll: Time= 652.6 ms
median= 644.5 ms, stdev= 54.6177144967 ms, min= 599.0 ms, max= 773.0 ms

RESULT Interactive: SelectAll: Time= 654.4 ms
median= 633.5 ms, stdev= 55.9223145368 ms, min= 600.0 ms, max= 769.0 ms

RESULT Interactive: SelectAll: Time= 657.9 ms
median= 640.0 ms, stdev= 54.1420159833 ms, min= 604.0 ms, max= 774.0 ms

  • Interactive/SelectAll.html: Added.
  • Skipped:
10:54 AM Changeset in webkit [146996] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should use CheckStructure for typed array checks whenever possible
​https://bugs.webkit.org/show_bug.cgi?id=113374

Reviewed by Geoffrey Garen.

We used to do the right thing, but it appears that this regressed at some point. Since the
FixupPhase now has the ability to outright remove spurious CheckStructures on array
operations, it is profitable for the ByteCodeParser to insert CheckStructures whenver there
is a chance that it might be profitable, and when the profiling tells us what structure to
check.

Also added some code for doing ArrayProfile debugging.

This is a slightly speed-up. Maybe 3% on Mandreel.

  • bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::benefitsFromStructureCheck):

10:53 AM Changeset in webkit [146995] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

[Mac] Use fontName rather than familyName for internal fonts
​https://bugs.webkit.org/show_bug.cgi?id=113392
<rdar://problem/13474743>

Reviewed by Enrica Casucci.

Some internal fonts on OS X have a family name that
isn't listed in availableFontFamilies. In this case
we should use the font name rather than the family
name when looking for a match.

  • platform/mac/ThemeMac.h: NSFont category to provide a web-friendly family name.
  • platform/mac/ThemeMac.mm:

(-[NSFont webCoreFamilyName]): Returns the font name for internal fonts, otherwise the family name.
(WebCore::ThemeMac::controlFont):

  • rendering/RenderThemeMacShared.mm: Use the webCoreFamilyName.

(WebCore::RenderThemeMacShared::systemFont): Ditto.
(WebCore::RenderThemeMacShared::setFontFromControlSize): Ditto.

10:45 AM Changeset in webkit [146994] by zandobersek@gmail.com
  • 7 edits
    2 moves
    8 adds
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Addressing layout test failures that are specific to GTK-WK1 by moving the related expectations into the specific
TestExpectations file or adjusting and moving the baselines into the GTK-WK1 baseline search path.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk-wk1/fast: Added.
  • platform/gtk-wk1/fast/media: Added.
  • platform/gtk-wk1/fast/media/mq-transform-02-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-02-expected.html.
  • platform/gtk-wk1/fast/media/mq-transform-03-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-03-expected.html.
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/media/mq-transform-02-expected.html: Removed.
  • platform/gtk/fast/media/mq-transform-03-expected.html: Removed.
  • platform/gtk/fast/preloader: Added.
  • platform/gtk/fast/preloader/document-write-2-expected.txt: Added.
  • platform/gtk/fast/preloader/document-write-expected.txt: Added.
  • platform/gtk/fast/preloader/script-expected.txt: Added.
  • platform/gtk/http/tests/security/XFrameOptions: Removed.
  • platform/gtk/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed.
  • platform/gtk/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed.
10:32 AM Changeset in webkit [146993] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WTF

Support C++11 static_assert
​https://bugs.webkit.org/show_bug.cgi?id=113308

Reviewed by Alexey Proskuryakov.

Use the C++11 static_assert for COMPILE_ASSERT when it is available. Note that
even when compiling with C++11 support, static_assert will not always be available
since Assertions.h may also be used outside of C++.

C11 _Static_assert is enabled for GCC when it has C11 support (gcc>=4.7 -std=c11).

  • wtf/Assertions.h:
  • wtf/Compiler.h:
9:43 AM Changeset in webkit [146992] by jer.noble@apple.com
  • 27 edits
    1 add in trunk

Source/WebCore: Source/WebCore: Mac: Media Controls always hide time display elements
​https://bugs.webkit.org/show_bug.cgi?id=113355

Reviewed by Eric Carlson.

No new tests; rebaselined existing tests against correct behavior.

A prior commit set the "min-width:0" property on the time display elements, which, combined
with the "-webkit-flex-box:0 0" setting, caused the flex-box container to collapse the width
of the elements to zero. To achieve the desired effect of hiding the time display elements,
first set the elements' min-width to the desired width, as the new flex-box spec treats the
default value of "min-width:auto" as the intrinsic width, and will collapse the text display
elements to the intrinsic width of its contained text node.

The above allows the timeline container to collapse beyond the sum of its childrens'
intrinsic width. Create a custom renderer that detects when this happens, and hide the time
display controls.

  • css/mediaControls.css:
  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

Set the "min-width:" property to equal the "width:" property.

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):

Ditto.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):

Chromium assumes the time display controls are flex-boxes, so make that explicit.

  • html/shadow/MediaControlElementTypes.cpp: Removed MediaControlTimeDisplayElement::createRenderer().
  • html/shadow/MediaControlElementTypes.h:

(MediaControlTimeDisplayElement): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden): Added, walks through the

container's children and shows or hides time display elements.

(WebCore::MediaControlTimelineContainerElement::createRenderer): Added, creates a RenderMediaControlTimelineContainer.
(WebCore::getMediaControlTimeRemainingDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to

query against children's shadowPseudoId().

(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Moved contents to getMediaControlTimeRemainingDisplayElementShadowPseudoId.
(WebCore::getMediaControlCurrentTimeDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to

query against children's shadowPseudoId().

(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Moved contents to getMediaControlCurrentTimeDisplayElementShadowPseudoId.

  • html/shadow/MediaControlElements.h:

(MediaControlTimelineContainerElement):

  • rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer): Added, simple constructor.
(WebCore::RenderMediaControlTimelineContainer::layout): Detect when the controller's width is greater than

a certain value, and show or hide the time display elements in response.

  • rendering/RenderMediaControlElements.h:

(RenderMediaControlTimelineContainer):

LayoutTests: Mac: Media Controls always hide time display elements
​https://bugs.webkit.org/show_bug.cgi?id=113355

Reviewed by Eric Carlson.

Rebaseline mac results.

  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.png: Added.
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.png:
  • platform/mac/media/controls-without-preload-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.png:
  • platform/mac/media/video-playing-and-pause-expected.txt:
9:09 AM Changeset in webkit [146991] by Antti Koivisto
  • 2 edits in trunk/Tools

Fix Zalan's email.

  • Scripts/webkitpy/common/config/committers.py:
8:50 AM Changeset in webkit [146990] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

master.cfg cleanup
​https://bugs.webkit.org/show_bug.cgi?id=113195

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
8:44 AM Changeset in webkit [146989] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

master.cfg fine-tuning for Qt Mountain Lion Release bot
​https://bugs.webkit.org/show_bug.cgi?id=113191

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
    • Rename the slave due to its location change.
    • Update the platform of the slave.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests): Enable running WK2 API tests on Qt.
(RunQtAPITests.start):
(RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
(BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)

8:36 AM Changeset in webkit [146988] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Evas fails to build when Wayland is present on the system
​https://bugs.webkit.org/show_bug.cgi?id=113403

Reviewed by Kenneth Rohde Christiansen.

As of Evas 1.7.5, when Wayland is detected on the system, support for
both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
The code, however, seems to depend on a few other flags which must be
explicitly enabled.

If those additional GL-related options are passed, we end up
having issues on the WebKit side, so disable Wayland support for
now.

  • efl/jhbuild.modules:
8:35 AM Changeset in webkit [146987] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
​https://bugs.webkit.org/show_bug.cgi?id=113395

Reviewed by Pavel Feldman.

Looks like FlameChart is more powerful and flexible instrument
than plain old ProfileTree in DataGrid. The same action like
'look for the most expensive function in a frame' could be easily
done with FlameChart and need number of clicks in DataGrid.
So in an offline discussion we decided to place FlameChart on top of DataGrid.

  • inspector/front-end/CPUProfileView.js:
7:53 AM Changeset in webkit [146986] by Chris Fleizach
  • 4 edits in trunk

Regression in tests due to ​https://bugs.webkit.org/show_bug.cgi?id=113339
​https://bugs.webkit.org/show_bug.cgi?id=113361

Source/WebCore:

Fix the red bots. No review.

Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Remove skipped tests.

  • platform/mac/TestExpectations:
7:48 AM Changeset in webkit [146985] by zarvai@inf.u-szeged.hu
  • 1 edit
    14 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Cleanup after r146756 and r146786.

  • platform/qt/fast/frames/frame-set-scaling-rotate-expected.txt: Removed.
  • platform/qt/fast/frames/frame-set-scaling-skew-expected.txt: Removed.
  • platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
  • platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Removed.
  • platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.
  • platform/qt/fast/repaint/overhanging-float-detach-repaint-expected.txt: Removed.
  • platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed.
  • platform/qt/fast/replaced/border-radius-clip-content-edge-expected.txt: Removed.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Removed.
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed.
  • platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed.
7:46 AM Changeset in webkit [146984] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.0.0

Tagging the WebKitGTK+ 2.0.0 release

7:37 AM Changeset in webkit [146983] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added.
​https://bugs.webkit.org/show_bug.cgi?id=113381

Reviewed by Pavel Feldman.

Source/WebCore:

Breakpoint manager now restores breakpoints on UISourceCodeAdded event.
Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._resetBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.get isIdentity):

  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping.prototype.isIdentity):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.isIdentity):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype.isIdentity):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptMapping.prototype.isIdentity):

  • inspector/front-end/SourceMapping.js:

(WebInspector.SourceMapping.prototype.isIdentity):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype.isIdentity):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.setSourceMapping):

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
7:27 AM Changeset in webkit [146982] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
​https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Fixed assertion failure in debug mode after r146975.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

7:22 AM Changeset in webkit [146981] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: FlameChart. Provide 15px padding left for the chart so developers will see the first divider with '0' title.
​https://bugs.webkit.org/show_bug.cgi?id=113404

Reviewed by Pavel Feldman.

15px paddingLeft was added to the code for the chart.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype.draw):

7:18 AM Changeset in webkit [146980] by dominik.rottsches@intel.com
  • 6 edits in trunk

Unreviewed, rolling out r146864.
​http://trac.webkit.org/changeset/146864
​https://bugs.webkit.org/show_bug.cgi?id=113391

causes crashes on Wk2 EFL release bot (Requested by drott on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-27

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/TestExpectations:
7:14 AM Changeset in webkit [146979] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Correctly specify an alternate number of make jobs.
​https://bugs.webkit.org/show_bug.cgi?id=113396

Reviewed by Philippe Normand.

So far, we were using the `MAKEFLAGS' environment variable to pass the
number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
other hand, prefers to use the `jobs' variable from jhbuildrc for that.

We now behave more closely to the rest of the WebKit tools by first
checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
not set, just letting jhbuild itself figure out how many jobs to use.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
4:10 AM Changeset in webkit [146978] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove a duplicated test from TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=113385

Unreviewed, EFL gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-27

  • platform/efl/TestExpectations:
4:06 AM Changeset in webkit [146977] by tkent@chromium.org
  • 16 edits in trunk/Source

Rename HTMLFormControlElement::readOnly to isReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=113297

Reviewed by Alexey Proskuryakov.

Source/WebCore:

HTMLFormControlElement::readOnly is not an implementation of
'readOnly' IDL attribute. It's confusing and we don't need to
violate our naming convention.

No new tests. Just a refactoring.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseAttribute):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isReadOnly):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::updateImage):

  • rendering/RenderTextControl.cpp:

(WebCore::updateUserModifyProperty):

  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

Source/WebKit/chromium:

  • src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::isReadOnly):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::readOnly):

4:04 AM Changeset in webkit [146976] by zeno.albisser@digia.com
  • 8 edits in trunk

[Qt] Remove Qt specific WorkQueueItem definitions.
​https://bugs.webkit.org/show_bug.cgi?id=112891

This patch is preparation work for removing
WorkQueue related code from TestRunnerQt and
replacing it with generic TestRunner code.

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • API/JSStringRefQt.cpp:

(JSStringCreateWithQString):

Adding a convenience function to create a
JSStringRef from a QString.

  • API/JSStringRefQt.h:

Tools:

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunner::queueLoad):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • DumpRenderTree/qt/WorkQueueItemQt.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(LoadAlternateHTMLStringItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):

  • DumpRenderTree/qt/WorkQueueItemQt.h:

(LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
(LoadAlternateHTMLStringItem):

3:27 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:29 AM Changeset in webkit [146975] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
​https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Added missing fields to Timeline.TimelineEvent type definition in Inspector.json

  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
Switched InspectorTimelineAgent to the new typed event builders.
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

2:03 AM Changeset in webkit [146974] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 2.0.0 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.0.0.
1:33 AM Changeset in webkit [146973] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.
​https://bugs.webkit.org/show_bug.cgi?id=113368

Reviewed by Pavel Feldman.

Source/WebCore:

Added a missed line and a test.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._projectWillReset):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
1:12 AM Changeset in webkit [146972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
​https://bugs.webkit.org/show_bug.cgi?id=113348

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests.

  • Append additional "<class>-start" class to the first highlighted span

and "<class>-end" class to the last highlighted span to provide a way
to set up a css classes with borders.

  • Increment end column of the markup range to simulate inclusive range.
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):

1:04 AM Changeset in webkit [146971] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add isClean/markClean method pair to textEditor.js
​https://bugs.webkit.org/show_bug.cgi?id=112815

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests: no change in behaviour.

  • Add TextEditor.isClean and TextEditor.markClean methods
  • Implement these methods in DefaultTextEditor
  • Implement these methods in CodeMirrorTextEditor
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.isClean):
(WebInspector.CodeMirrorTextEditor.prototype.markClean):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.isClean):
(WebInspector.DefaultTextEditor.prototype.markClean):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.isClean):
(WebInspector.TextEditor.prototype.markClean):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

1:01 AM Changeset in webkit [146970] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed. Web Inspector. rename method Timeline.Calculator.grandMinimumBoundary to Timeline.Calculator.zeroTime

No changes in behaviour.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.Calculator.prototype.zeroTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.zeroTime):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkBaseCalculator.prototype.zeroTime):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.Calculator.prototype.zeroTime):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator.prototype.zeroTime):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineCalculator.prototype.zeroTime):

12:31 AM Changeset in webkit [146969] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Timeline. Scroll dividers with the underlying events.
​https://bugs.webkit.org/show_bug.cgi?id=113315

Reviewed by Pavel Feldman.

Now when TimelineGrid is able to draw dividers with any offset
we could cut away paddingLeft member of Timeline.Calculator
and clear the code of TimelineGrid.

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):

  • inspector/front-end/inspectorCommon.css:

(.resources-dividers-label-bar):

12:08 AM Changeset in webkit [146968] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[CoordGfx] Support to share GraphicsSurface flags with client.
​https://bugs.webkit.org/show_bug.cgi?id=112982

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-27
Reviewed by Noam Rosenthal.

Covered by existing WebGL tests.

Source/WebCore:

This patch adds support to pass GraphicsSurface flags during it's client creation.
This would be helpful to determine cases when blending can be disabled on client
side i.e When AlphaSupport is disabled during Graphics Surface creation.
With GLX, we rely on Window to provide us with necessary information on client side.
This might not be the case on other platforms or when not using Window on X.
This patch doesn't change original behaviour of creating GraphicsSurface client
with default flags GraphicsSurface::SupportsTextureTarget and GraphicsSurface::SupportsSharing.

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::graphicsSurfaceFlags):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(CoordinatedGraphicsLayerState):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initializeClient):

Source/WebKit2:

This patch adds support to pass GraphicsSurface flags
during it's client creation.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Mar 26, 2013:

11:39 PM Changeset in webkit [146967] by tasak@google.com
  • 3 edits
    2 adds in trunk

[shadow] styleForText should consider the case where parent node has no style
​https://bugs.webkit.org/show_bug.cgi?id=113275

Source/WebCore:

If a text node is distributed, its parent node for rendering and
styling might have no style. In the case, styleForText should return
default style.

Reviewed by Hajime Morrita.

Test: fast/dom/shadow/text-node-distributed-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForText):
Check whether a parent node has any style or not. If not, return
default style. This is the same behavior as styleForElement.

LayoutTests:

Reviewed by Hajime Morrita.

  • fast/dom/shadow/text-node-distributed-crash-expected.txt: Added.
  • fast/dom/shadow/text-node-distributed-crash.html: Added.
11:02 PM Changeset in webkit [146966] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/replaced/border-radius-clip-content-edge.html

  • platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:
10:03 PM Changeset in webkit [146965] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make SocketStreamHandle (Chromium port) fully use IPC window in send()
​https://bugs.webkit.org/show_bug.cgi?id=113304

Patch by Takeshi Yoshino <​tyoshino@chromium.org> on 2013-03-26
Reviewed by Kent Tamura.

socket_stream of Chromium buffers send data up to 32KiB (exact) bytes.

However, SocketStreamHandleInternal::send() method now keeps in-flight
send data not greater than m_maxPendingSendAllowed - 1 that is
32KiB - 1. This means that SocketStreamHandleInternal consumes the
buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory
copy operations unaligned unnecessarily. It should just use the
allowed size fully.

  • platform/network/chromium/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::send):
(WebCore):

8:49 PM Changeset in webkit [146964] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

RefCountedArray needs a size based constructor
​https://bugs.webkit.org/show_bug.cgi?id=113277

Reviewed by Benjamin Poulain.

Simple patch to add a size based constructor for RefCountedArray
so that we can create an sharable array without a copy.

  • wtf/RefCountedArray.h:

(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):

8:02 PM Changeset in webkit [146963] by pdr@google.com
  • 3 edits in trunk/LayoutTests

Rebaseline expectations for fast/replaced/border-radius-clip-content-edge.html

Unreviewed rebaseline of test expectations after r146955

  • platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
  • platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:
7:49 PM Changeset in webkit [146962] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed attempted cr-mac build fix.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:40 PM Changeset in webkit [146961] by hayato@chromium.org
  • 41 edits in trunk/Source

Allow ShadowContents in HitTests by default.
​https://bugs.webkit.org/show_bug.cgi?id=113171

Reviewed by Dimitri Glazkov.

Source/WebCore:

HitTestRequest is widely used in WebCore, but AllowShadowContents
flag is not turned on by default. In most places, we can set the
flag on.

This change makes HitTests allow shadow contents by default.

To track all existing HitTests which do not allow shadow contents,
and discourage such a HitTest in the future, I've introduced
disallowShadowContenet flag so that callers must turn on this flag
explicitly if they want to disallow shadow contents in their HitTests.

This change should be refactoring and should not include any
behavior changes. After this change, we'll investigate each place
where disallowShadowContents is used step by step and get rid of
the flag if it is okay to remove.

No new tests, no behavior change.

  • dom/Document.h:

(Document):

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::disallowsShadowContent):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

  • WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTapNode):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/gtk:

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_inspect_coordinates):

  • webkit/webkitwebview.cpp:

(prepareMouseEventForFrame):
(webkit_web_view_get_hit_test_result):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame elementAtPoint:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::hitTestContent):

Source/WebKit/win:

  • WebView.cpp:

(WebView::gestureNotify):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

7:20 PM Changeset in webkit [146960] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=112996

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.

PR 312552
Internally Reviewed by Anthony Scian.

NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
but not deleted anywhere. Fixed by creating an OwnPtr for it.
Also fixed some webkit-style errors.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

7:20 PM Changeset in webkit [146959] by wangxianzhu@chromium.org
  • 5 edits
    2 copies
    2 deletes in branches/chromium/1410

Merge 146940 "Non-paintsContent fixed position layer should not ..."

Non-paintsContent fixed position layer should not cause slow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=113238

Reviewed by James Robinson.

Source/WebCore:

Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

  • rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

LayoutTests:

  • compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
  • compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
  • compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
  • compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
  • platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/12499009

6:22 PM Changeset in webkit [146958] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Greening the mac bots.
​https://bugs.webkit.org/show_bug.cgi?id=113361.

Not Reviewed.

  • platform/mac/TestExpectations:
6:21 PM Changeset in webkit [146957] by danakj@chromium.org
  • 6 edits
    5 deletes in trunk/Source

[chromium] Remove the WebVideoFrame, WebVideoFrameProvider, WebStreamTextureClient, and WebVideoLayer classes.
​https://bugs.webkit.org/show_bug.cgi?id=112483

Reviewed by James Robinson.

Source/Platform:

These classes are no longer used, so remove them. And remove APIs
to provide them.

  • Platform.gypi:
  • chromium/public/WebCompositorSupport.h:

(WebKit):

  • chromium/public/WebVideoFrame.h: Removed.
  • chromium/public/WebVideoFrameProvider.h: Removed.
  • chromium/public/WebVideoLayer.h: Removed.

Source/WebKit/chromium:

These classes are no longer used, so remove them.

  • WebKit.gyp:
  • public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer):

  • public/WebStreamTextureClient.h: Removed.
  • public/WebVideoFrame.h: Removed.
6:20 PM Changeset in webkit [146956] by timothy_horton@apple.com
  • 14 edits in trunk

[ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing
​https://bugs.webkit.org/show_bug.cgi?id=107539
<rdar://problem/13032692>

Reviewed by Simon Fraser.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Update WebCoreSystemInterface.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initially move the Page out of the window if necessary;
Page defaults to in-window, which is wrong in many cases - we depend on
Page::isInWindow being accurate to decide whether WebPage::setIsInWindow is actually
a state change or not.
(WebKit::WebPage::setIsInWindow):

  • WebProcess/WebProcess.cpp: Inform WebProcess when we go on/off screen.

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pageDidMoveOnscreen): Keep track of the number of on-screen pages in this process.
(WebKit::WebProcess::pageWillMoveOffscreen): If the number of on-screen pages drops to zero, clean up unused rendering resources.

  • WebProcess/WebProcess.h:

Update WebSystemInterface.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
6:00 PM Changeset in webkit [146955] by Antti Koivisto
  • 10 edits in trunk

Test if non-immediate descendants obscure background
​https://bugs.webkit.org/show_bug.cgi?id=113137

Reviewed by Simon Fraser.

Source/WebCore:

The current obscuration test only covers immediate children. We can find more cases by looking deeper into descendants.

The patch makes the test sufficiently smart to stop a heavy fully obscured gif animation on micrsoft.com.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::animationAdvanced):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

Invalidate parents to max test depth.

(WebCore::RenderBox::backgroundPaintedExtent):

Background painting is pixel snapped.

(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect):

Separate foreground testing and make it recursive.
Add fast bailout for common static positioned case.
Remove maximum child count, the fast bailouts should prevent long tests.
Add maximum depth so we know how deep we need to invalidate in styleDidChange.

(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):

  • rendering/RenderImage.h:

(RenderImage):

LayoutTests:

  • fast/backgrounds/obscured-background-child-style-change-expected.html:
  • fast/backgrounds/obscured-background-child-style-change.html:
  • fast/repaint/obscured-background-no-repaint-expected.txt:
  • fast/repaint/obscured-background-no-repaint.html:
5:59 PM Changeset in webkit [146954] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Regression (r145601): out-of-bounds read in line breaking / new width cache
​https://bugs.webkit.org/show_bug.cgi?id=113347

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-26
Reviewed by Geoffrey Garen.

The values zero and 0xffff have special values with the default HashTraits. Those values
are also valid values for UChar.

To avoid any table inconsitency, switch from UChar to uint32_t as the key type for
the WidthCache's single char map. The traits is also changed to allow zero as a normal
value.

This makes no space or time change over the previous code because:
-The struct KeyValuePair was already 64bits due to the ABI alignment restrictions on floats.
-The two hashes take the same number of instructions.

  • platform/graphics/WidthCache.h:

(WidthCache):

5:43 PM Changeset in webkit [146953] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Make HTMLProgressElement::isDeterminate private
​https://bugs.webkit.org/show_bug.cgi?id=113299

Reviewed by Kentaro Hara.

The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.

No new tests. Just a refactoring.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.

  • html/HTMLProgressElement.h:

(HTMLProgressElement): Make isDeterminate private.

5:17 PM Changeset in webkit [146952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190706. Requested by
danakj_ via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-26

  • DEPS:
5:15 PM Changeset in webkit [146951] by jamesr@google.com
  • 2 edits in trunk/Source/WTF

Compile fix - OS(WINDOWS), not OS(WIN).

  • wtf/ProcessID.h:

(WTF::getCurrentProcessID):

5:12 PM Changeset in webkit [146950] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Histogram cause of LevelDB write errors
​https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

5:11 PM Changeset in webkit [146949] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebKit does not expose @required or @aria-required as AXRequired on select elements
​https://bugs.webkit.org/show_bug.cgi?id=113339

Reviewed by Tim Horton.

Source/WebCore:

Make sure button types can return the AXRequired attribute.

Tests: platform/mac/accessibility/aria-required-popup-button.html

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/aria-required-popup-button-expected.txt: Added.
  • platform/mac/accessibility/aria-required-popup-button.html: Added.
5:09 PM Changeset in webkit [146948] by jamesr@google.com
  • 2 edits in trunk/Source/WTF

Fix compile for OS(WIN) != PLATFORM(WIN)
​https://bugs.webkit.org/show_bug.cgi?id=113356

Reviewed by Tim Horton.

  • wtf/ProcessID.h:

(WTF::getCurrentProcessID):

5:03 PM Changeset in webkit [146947] by fpizlo@apple.com
  • 5 edits
    6 adds in trunk

REGRESSION: Sometimes, operations on proven strings ignore changes to the string prototype
​https://bugs.webkit.org/show_bug.cgi?id=113353
<rdar://problem/13510778>

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg and Geoffrey Garen.

ToString should call speculateStringObject() even if you know that it's a string object, since
it calls it to also get the watchpoint. Note that even with this change, if you do
Phantom(Check:StringObject:@a), it might get eliminated just because we proved that @a is a
string object (thereby eliminating the prototype watchpoint); that's fine since ToString is
MustGenerate and never decays to Phantom.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

LayoutTests:

Reviewed by Mark Hahnenberg and Geoffrey Garen.

  • fast/js/jsc-test-list:
  • fast/js/dfg-phantom-base-expected.txt: Added.
  • fast/js/dfg-phantom-base.html: Added.
  • fast/js/dfg-to-string-toString-becomes-bad-with-check-structure-expected.txt: Added.
  • fast/js/dfg-to-string-toString-becomes-bad-with-check-structure.html: Added.
4:52 PM Changeset in webkit [146946] by dino@apple.com
  • 12 edits
    4 adds in trunk

When a primary plugin is restarted, also start similar plugins
​https://bugs.webkit.org/show_bug.cgi?id=113265

Reviewed by Tim Horton.

Source/WebCore:

If we detect a primary plugin that is snapshotted, we immediately restart it.
When this happens, we should also restart any other plugins that
match the same origin and type. This allows sites with a lot of
(geometrically) nearby plugins to behave as if they are a single big plugin.

Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html

plugins/snapshotting/autoplay-similar-to-dominant.html

  • WebCore.exp.in: Export mimeTypeFromURL.
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the

existing code from userDidClickSnapshot.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection

out into another function and call it.

(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.

  • html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.

(WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this

code was being often duplicated.

Source/WebKit2:

Remember the origin of the primary plugin, so that we can
autostart anything that is similar.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::WebPlugInClient): Keep a pointer to the WebPage.
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Pass the page onto the process.

  • WebProcess/WebCoreSupport/WebPlugInClient.h:

(WebPlugInClient): New member variable for the WebPage we were created with.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Remember the origin information

for the primary plugin.

(WebKit::WebPage::matchesPrimaryPlugIn): Returns true if we're seeing something that

looks like the primary plugin.

  • WebProcess/WebPage/WebPage.h: New method matchesPrimaryPlugIn.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check if the page thinks this is

the primary plugin.

  • WebProcess/WebProcess.h: Accept a reference to the page in shouldPlugInAutoStartFromOrigin.

LayoutTests:

Two new tests. The first has one big plugin (that should be detected as the primary)
and then a few smaller versions (which should autostart along with the primary).
The second has one big plugin, and then adds a similar one after a short delay.

  • platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt: Added.
  • platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt: Added.
  • plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html: Added.
  • plugins/snapshotting/autoplay-similar-to-dominant.html: Added.
4:45 PM Changeset in webkit [146945] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r144131): It made fast/js/regress/string-repeat-arith.html assert on 32 bit
​https://bugs.webkit.org/show_bug.cgi?id=112106

Rubber stamped by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32): Get rid of the case for constants because
we would have done constant folding anyways on a ValueToInt32.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Fixed a random compile error with this flag enabled.

4:01 PM Changeset in webkit [146944] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebCore

Rollout r146806. <rdar://problem/13202277>

3:50 PM Changeset in webkit [146943] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
test should enable CSS Exclusions for the testrunners first.

  • fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.
3:21 PM Changeset in webkit [146942] by alokp@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.

  • platform/chromium/TestExpectations:
3:20 PM Changeset in webkit [146941] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Scroll offset being applied to plugins during print operations.
​https://bugs.webkit.org/show_bug.cgi?id=39889

Reviewed by Anders Carlsson.

This must be tested manually. See the issue for details.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext):
Revise the Windows implementation of the PluginView class
paintWindowedPluginIntoContext to use the containing window
position when computing the plugin's position for printing.

3:12 PM Changeset in webkit [146940] by wangxianzhu@chromium.org
  • 7 edits
    1 copy
    1 add
    2 deletes in trunk

Non-paintsContent fixed position layer should not cause slow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=113238

Reviewed by James Robinson.

Source/WebCore:

Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

  • rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

LayoutTests:

  • compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
  • compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
  • compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
  • compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
  • compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
  • platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
3:09 PM Changeset in webkit [146939] by alokp@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marked compositing/iframes/scrolling-iframe.html flaky on all platforms.

  • platform/chromium/TestExpectations:
3:08 PM Changeset in webkit [146938] by zoltan@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension
​https://bugs.webkit.org/show_bug.cgi?id=113255

Reviewed by Julien Chaffraix.

When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
use the smaller available space, so we won't render unnecessary circle shapes.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

LayoutTests:

  • fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
3:04 PM Changeset in webkit [146937] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Make the Web Inspector console work in strict mode with JavaScriptCore.

​https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Joseph Pecoraro.

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
allowed in strict mode). Swap window.eval with our known eval instead.

3:03 PM Changeset in webkit [146936] by jamesr@google.com
  • 23 edits in trunk/LayoutTests

Clean up last failing expectations from solid color layer patch.

  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
3:03 PM Changeset in webkit [146935] by rniwa@webkit.org
  • 8 edits in trunk/Source

Heap-use-after-free regression
​https://bugs.webkit.org/show_bug.cgi?id=113337

Reviewed by Abhishek Arya and Alexey Proskuryakov.

Source/WebCore:

Use RefPtr instead of raw pointer in m_associatedFormControls.

  • dom/Document.cpp:

(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/Document.h:

(Document):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::didAssociateFormControls):

  • page/ChromeClient.h:

(WebCore::ChromeClient::didAssociateFormControls):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

2:46 PM Changeset in webkit [146934] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Include accelerated compositing layers in screen captures.
​https://bugs.webkit.org/show_bug.cgi?id=113335

Patch by Mike Lattanzio <​mlattanzio@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

PR# 280374
Include accelerated compositing layers in screen captures.
Reviewed Internally By: Jakob Petsovits

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):

  • Api/BackingStore_p.h:
2:46 PM Changeset in webkit [146933] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
​https://bugs.webkit.org/show_bug.cgi?id=113144

Reviewed by Geoffrey Garen.

Forgot to include Geoff's requested change in the original commit.

  • profiler/ProfilerDatabase.cpp:

(Profiler):

2:43 PM Changeset in webkit [146932] by fpizlo@apple.com
  • 14 edits
    1 add in trunk/Source

JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
​https://bugs.webkit.org/show_bug.cgi?id=113144

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
to the current directory, or JSC_PROFILER_PATH if the latter was specified.

This works by saving the Profiler::Database either when it is destroyed or atexit(),
whichever happens first.

This allows use of the profiler from any WebKit client.

  • jsc.cpp:

(jscmain):

  • profiler/ProfilerDatabase.cpp:

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):

  • profiler/ProfilerDatabase.h:

(JSC::Profiler::Database::databaseID):
(Database):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Source/WTF:

Reviewed by Geoffrey Garen.

I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
_getpid() I believe), so I wrote a header that abstracts it. I also changed existing
code that uses getpid() to use WTF::getCurrentProcessID().

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

  • wtf/ProcessID.h: Added.

(WTF):
(WTF::getCurrentProcessID):

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::printStats):

2:42 PM Changeset in webkit [146931] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Follow-up to:
<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
​https://bugs.webkit.org/show_bug.cgi?id=113256

Reviewed by Mark Rowe.

  • NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.
2:29 PM Changeset in webkit [146930] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set mouse document position for mouse event in updateCursor
​https://bugs.webkit.org/show_bug.cgi?id=109094

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-03-26
Reviewed by Rob Buis.

Internally Reviewed by Jakob Petsovits.

Mouse content position should be in document coordinate.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

2:27 PM Changeset in webkit [146929] by ap@apple.com
  • 24 edits
    2 copies
    1 add in trunk/Source

<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
​https://bugs.webkit.org/show_bug.cgi?id=113256

Reviewed by Brady Eidson.

Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
version to forward calls to main thread.

2:26 PM Changeset in webkit [146928] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] Don't send intrinsic content size updates more than once per runloop
​https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Only start the zero-delay timer if it's not already active.

2:13 PM Changeset in webkit [146927] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

Convert test from UTF-16 to UTF-8

Rubber stamped by James Robinson.

  • fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8

to make git diff happy.

1:40 PM Changeset in webkit [146926] by jparent@chromium.org
  • 3 edits in trunk/Tools

Flakiness dashboard: simplify logic around which tests to show.
​https://bugs.webkit.org/show_bug.cgi?id=113250

Reviewed by Ojan Vafai.

The different filters for showing results are only used for layout
tests, otherwise, we show everything.

Change the defaults to false (what layout tests used), and only
look at the values when viewing layout tests.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):

1:33 PM Changeset in webkit [146925] by alokp@chromium.org
  • 21 edits
    10 copies
    1 add
    1 delete in trunk/LayoutTests

Rebaseline text output for opaque GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed rebaseline.

  • platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
  • platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
1:29 PM Changeset in webkit [146924] by tony@chromium.org
  • 15 edits in trunk/Source

Autogenerate the scrollAnimatorEnabled setting in Settings.in
​https://bugs.webkit.org/show_bug.cgi?id=113253

Reviewed by James Robinson.

Source/WebCore:

Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
updating the callers. I didn't change any WebKit API methods.

Also remove the code in InternalSettings since it's never used and will now be
autogenerated with proper resetting code.

No new tests, this is a refactor and should compile.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove code that is now autogenerated.

  • page/Settings.h:

(Settings): Remove code that is now autogenerated.

  • page/Settings.in: Add entry for scrollAnimatorEnabled.
  • testing/InternalSettings.cpp: Remove unused code.
  • testing/InternalSettings.h: Remove unused code.
  • testing/InternalSettings.idl: Remove unused code.

Source/WebKit/chromium:

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).

1:05 PM Changeset in webkit [146923] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Remove stray newline. This newline is messing up mozilla's test harness
and we share this file with them via html5lib.

  • html5lib/resources/template.dat:
1:04 PM Changeset in webkit [146922] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] In RSSFilterStream, don't swallow headers when there's no body
​https://bugs.webkit.org/show_bug.cgi?id=113334

Patch by Joe Mason <​jmason@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

RIM PR 316345

When receiving an HTTP response that has a Content-Type header such as text/xml, but no
body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
and then call sendSavedHeaders to pass on the headers. But since there is no body,
notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
send them again if they were already sent.)

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::notifyClose):

12:48 PM Changeset in webkit [146921] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update bots on test-results.appspot
​https://bugs.webkit.org/show_bug.cgi?id=113333

Patch by Isaac Levy <​ilevy@google.com> on 2013-03-26
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.jsonp:
12:46 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:44 PM Changeset in webkit [146920] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

[GTK] Bump required versions of some dependencies
​https://bugs.webkit.org/show_bug.cgi?id=113282

Reviewed by Martin Robinson.

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:
12:41 PM Changeset in webkit [146919] by kareng@chromium.org
  • 9 edits in branches/chromium/1453/Source

Revert 146672 "Add client callbacks to notify of changes of asso..."

Add client callbacks to notify of changes of associated from controls
​https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <​dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
​https://bugs.webkit.org/show_bug.cgi?id=110375

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/Document.h:

(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore):

  • html/HTMLFormElement.h:

add call to Document::didAssociateFormControl

  • loader/EmptyClients.h:

(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):

  • page/ChromeClient.h:

(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

  • public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12670015

12:30 PM Changeset in webkit [146918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Faster drawer animation.
​https://bugs.webkit.org/show_bug.cgi?id=113330

250ms -> 100ms

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.css:

(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):

12:12 PM Changeset in webkit [146917] by tony@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose setSelectionIncludesAltImageText in WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=113316

Reviewed by Dimitri Glazkov.

Enabling this setting allows plain text clipboard content to include alt
text like on Firefox and IE10.

  • public/WebSettings.h:

(WebSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

12:04 PM Changeset in webkit [146916] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove some entries since those tests have been passing.
Also update the test expectations for the bug 113227 flaky since they're passing most of the time.

  • platform/mac/TestExpectations:
12:01 PM Changeset in webkit [146915] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fails to start QtWebProcess.exe if installed in a path containing spaces
​https://bugs.webkit.org/show_bug.cgi?id=113328

Reviewed by Jocelyn Turcotte.

Downstream bugreport: ​https://bugreports.qt-project.org/browse/QTBUG-30249

We use QProcess::start() with a commandline string to start the web process
and the string is treated by QProcess as a whitespace delimeted list of the
command and the arguments, thus we have to escape the path to the process
binaries so that if the path contains spaces we still run the appropriate
command.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

11:57 AM Changeset in webkit [146914] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] QML WebView asserts when double clicking a link
​https://bugs.webkit.org/show_bug.cgi?id=113329

Reviewed by Jocelyn Turcotte.

Downstream bugreport: ​https://bugreports.qt-project.org/browse/QTBUG-30288

Remove an erroneous assert which is no longer valid if
mouse gestures are enabled.

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleInputEvent):

11:43 AM Changeset in webkit [146913] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] Don't send intrinsic content size updates more than once per runloop
​https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Start our new one-shot zero-delay timer.
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
Inform the WebPage that the intrinsic content size has changed.

11:30 AM Changeset in webkit [146912] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed Build fix.

  • platform/graphics/win/FontCustomPlatformDataCairo.h:

(FontCustomPlatformData): Correct signature in header to match
required implementation.

11:21 AM Changeset in webkit [146911] by anilsson@rim.com
  • 8 edits in trunk/Source

[BlackBerry] Scrolling up and down can cause the screen to flash black
​https://bugs.webkit.org/show_bug.cgi?id=113269

Reviewed by Rob Buis.

PR 296106

Source/WebCore:

The LayerRenderer should never clear before drawing the layers, from
now on that's the responsibility of the caller.

Only manually testable.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):

  • platform/graphics/blackberry/LayerRendererClient.h:

(LayerRendererClient):

Source/WebKit/blackberry:

Various flaws in the code could conspire to make the screen cleared to
black before rendering the web page. This only happened when the
BackingStore was inactive, and the LayerTiler takes on the job of
drawing the root layer. When tiles are missing, this made the
"checkerboard" effect especially noticeable since black color was seen
where the tile should have been. It would be better to clear to the web
page background color.

This was actually the intent of the code, but when the document
background color was invalid, we would still use it instead of the
background color from settings. Also, the LayerRenderer would clear to
black when WebPageCompositorPrivate::drawsRootLayer() was true.

Fixed by falling back to the settings background color when the
document background color is invalid, and removing the clearing code
from the LayerRenderer entirely. The appropriate clear already happens
near the beginning of BackingStorePrivate::blitVisibleContents().

Also slightly cleaned up the code for managing the background color.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
(BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):

  • Api/WebPageCompositor.cpp:
  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

  • Api/WebPage_p.h:

(WebPagePrivate):

11:10 AM Changeset in webkit [146910] by allan.jensen@digia.com
  • 5 edits in trunk

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
​https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Make it possible to read from a writable Clipboard.

Test: editing/pasteboard/can-read-in-copy-and-cut-events.html

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::readClipboardData):
(WebCore::ClipboardQt::hasData):
(WebCore::ClipboardQt::items):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

LayoutTests:

Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
The other test still needs better drag-and-drop support in DRT.

  • platform/qt/TestExpectations:
11:01 AM Changeset in webkit [146909] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Update
method signature to match CG variant.

10:59 AM Changeset in webkit [146908] by Christophe Dumez
  • 14 edits
    2 deletes in trunk/Source

Code duplication between HTTPParsers and HTTPValidation
​https://bugs.webkit.org/show_bug.cgi?id=113283

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
HTTPParsers.h. They were doing exactly the same thing and their
implementation was almost the same.

Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
seems like the proper place and it seems odd to keep HTTPValidation for
just one function.

No new tests, no behavior change for layout tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/HTTPParsers.cpp:

(WebCore::isValidHTTPHeaderValue):
(WebCore):
(WebCore::isValidHTTPToken): Implementation is slightly simplified based on

isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 replaced by (c >= 0x7F). (c <= 0x1F
c == 0x7F) is
c == ' ' c == '\t') is replaced

by (c <= 0x20). Those expressions are shorter but equivalent.
(WebCore::contentDispositionType):

  • platform/network/HTTPParsers.h:
  • platform/network/HTTPValidation.cpp: Removed.
  • platform/network/HTTPValidation.h: Removed.
  • xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.

Source/WebKit/chromium:

  • src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead

of HTTPValidation.h to use isValidHTTPToken().

10:58 AM Changeset in webkit [146907] by sergio@webkit.org
  • 17 edits
    4 adds in trunk

Implement overtype mode for editable content
​https://bugs.webkit.org/show_bug.cgi?id=112126

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/execCommand/overtype-support.html

editing/execCommand/overtype.html

Add a new Overwrite command to the editor. This command will
perform overtype operations when enabled instead of "normal" text
insertions. As IE does, we maintain a single toggle state in the
editor (enabled/disabled) for all the editable content in the
page.

This new command will be only available for richly editable
content via keybindings or the context menu. For testing purposes
it is also accessible via internals.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
local variables.

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(WebCore::Editor::isOverwriteModeEnabled):
(WebCore::Editor::toggleOverwriteModeEnabled):
(Editor): Added two new functions and a new attribute.

  • editing/EditorCommand.cpp:

(WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
(WebCore):
(WebCore::createCommandMap): New OverWrite command.

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
Refactored from performTrivialReplace(), shared by
performOverwrite().
(WebCore):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.

  • editing/InsertTextCommand.h:

(InsertTextCommand):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset OverWrite mode
to false.
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore):
(WebCore::Internals::toggleOverwriteModeEnabled): Provide access
to overwrite functionality in Editor for testing purposes.

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/mac:

Added the OverWrite editing command to the WebCore editing
commands lists.

  • WebView/WebHTMLView.mm:
  • WebView/WebView.h:
  • WebView/WebView.mm:

LayoutTests:

Two new layout tests for the new overtype mode. We use
overtype-support.html to check that the Overwrite command is not
exported to JavaScript but accessible through Internals. The
overtype.html one is used to test the actual behaviour of the
command.

The new command was also added to enabling-and-selection-2.js to
check that it is only available for richly editable content.

  • editing/execCommand/enabling-and-selection-2-expected.txt:

Updated expectations for OverWrite command.

  • editing/execCommand/overtype-expected.txt: Added.
  • editing/execCommand/overtype-support-expected.txt: Added.
  • editing/execCommand/overtype-support.html: Added.
  • editing/execCommand/overtype.html: Added.
  • editing/execCommand/script-tests/enabling-and-selection-2.js:

Added a check for OverWrite command.

10:44 AM Changeset in webkit [146906] by anilsson@rim.com
  • 6 edits in trunk/Source

[BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
​https://bugs.webkit.org/show_bug.cgi?id=113263

Reviewed by Rob Buis.

PR 312404

Source/WebCore:

Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
instead of the window rect. These are different if the web page is
rendered starting at a window coordinate other than 0,0. The clip rect
encodes the position we're rendered at, and can be used to translate
the rect expressed in window coordinates to the pixel viewport
coordinate system.

Also perform some cleanup of related code.

Only manually testable.

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::toPixelCoordinates):
(WebCore):
(WebCore::LayerRenderer::toWindowCoordinates):
(WebCore::LayerRenderer::toPixelViewportCoordinates):
(WebCore::LayerRenderer::toDocumentViewportCoordinates):
(WebCore::LayerRenderer::updateLayersRecursive):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

Source/WebKit/blackberry:

Fixed by returning pixel viewport coordinates instead of window
coordinates.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

10:31 AM Changeset in webkit [146905] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r146901.
​http://trac.webkit.org/changeset/146901
​https://bugs.webkit.org/show_bug.cgi?id=113321

Was landed to soon (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):

  • inspector/front-end/inspector.css:

(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

LayoutTests:

  • inspector/console/console-preserve-log.html:
10:24 AM Changeset in webkit [146904] by rafaelw@chromium.org
  • 4 edits in trunk

HTMLStackItem should include <template> as a special tag
​https://bugs.webkit.org/show_bug.cgi?id=113016

Reviewed by Eric Seidel.

Source/WebCore:

New test added to html5lib suite.

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isSpecialNode):

LayoutTests:

  • html5lib/resources/template.dat:
10:22 AM Changeset in webkit [146903] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Distinguish breakpoints and breakpoint locations in BreakpointManager API
​https://bugs.webkit.org/show_bug.cgi?id=113311

Reviewed by Pavel Feldman.

Source/WebCore:

Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpoints):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):

LayoutTests:

  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
10:21 AM Changeset in webkit [146902] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

bundle-ids need to be sanitized before using them in filesystem paths
​https://bugs.webkit.org/show_bug.cgi?id=113030
<rdar://problem/13300254>

Patch by Simon Cooper <​scooper@apple.com> on 2013-03-26
Reviewed by Alexey Proskuryakov.

When choosing / looking for a specialized Sandbox for a Plugin the
bundle-id needs to be sanitized before using it to construct a
filesystem name to look up. The “/“ character should not be allowed
and transformed into something else, in this case a “:”

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::loadSandboxProfile):

10:12 AM Changeset in webkit [146901] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Remove remainings of CSS-based console message filtering.
​https://bugs.webkit.org/show_bug.cgi?id=112710

Patch by Dmitry Zvorygin <​zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):

  • inspector/front-end/inspector.css:

(.console-debug-level.repeated-message):

LayoutTests:

  • inspector/console/console-preserve-log.html:
10:09 AM Changeset in webkit [146900] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
​https://bugs.webkit.org/show_bug.cgi?id=113211

Patch by Peter Rybin <​prybin@chromium.org> on 2013-03-26
Reviewed by Yury Semikhatsky.

A new method WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements is added and used
from 2 sites.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(.callback):
(WebInspector.ObjectPropertyTreeElement.populate):
(WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):

10:04 AM Changeset in webkit [146899] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

HTTPHeaderMap::copyData() could call uncheckedAppend()
​https://bugs.webkit.org/show_bug.cgi?id=113279

Reviewed by Alexey Proskuryakov.

HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
but then appends items using append() function. Since we already know
the capacity is sufficient, it is more efficient to call uncheckedAppend()
instead to bypass capacity checks.

No new tests, no behavior change for layout tests.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

10:01 AM Changeset in webkit [146898] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: UISourceCodes are leaking on reload sometimes.
​https://bugs.webkit.org/show_bug.cgi?id=113310

Reviewed by Pavel Feldman.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype.clearMessages):

9:45 AM Changeset in webkit [146897] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: [Elements] Unable to "Edit as HTML" XHTML/SVG documents.
​https://bugs.webkit.org/show_bug.cgi?id=113290

Reviewed by Pavel Feldman.

Source/WebCore:

DOMPatchSupport has been slightly augmented to handle XML (XHTML and SVG) documents.

Test: inspector/elements/set-outer-html-for-xhtml.xhtml

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML): Let HTML, XHTML, and SVG documents through.

LayoutTests:

  • inspector/elements/set-outer-html-for-xhtml-expected.txt: Added.
  • inspector/elements/set-outer-html-for-xhtml.xhtml: Added.
9:14 AM Changeset in webkit [146896] by morrita@google.com
  • 5 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=113164
Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML

Source/WebCore:

These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.

Reviewed by Dimitri Glazkov.

Test: Updated lifecycle-ready-creation-api.html.

  • html/HTMLElement.idl:

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
  • fast/dom/custom/lifecycle-ready-creation-api.html:
9:10 AM Changeset in webkit [146895] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Fix incorrect test name in content shell expectations

Unreviewed. Typing is hard.

  • platform/chromium/ContentShellTestExpectations:
9:05 AM Changeset in webkit [146894] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
​https://bugs.webkit.org/show_bug.cgi?id=113215

In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
is implemented as a Tap gesture with tap_count = 2.

In WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
regardless, even though the PlatfromEvent will never reach the WebCore. DoubleTap, in
our case, is only handled in WebViewImpl for doube-tap-to-zoom, will also go through
conversion in WebInpuEventConversion.cpp::PlatformGestureEventBuilder() and reach
ASSERT_NOT_REACHED()

This patch converts WebGestureEvent::DoubleTap to PlatformEvent::NoType, this makes the
conversion list from WebInputEvent to PlatformEvent complete and we don't need a special
handling for the DoubleTap event in WebViewImpl::handleGestureEvent()

Patch by Yufeng Shen <​miletus@chromium.org> on 2013-03-26
Reviewed by Antonio Gomes.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

9:02 AM Changeset in webkit [146893] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. WebInspector: remove unnecessary method.

  • inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.Window):

9:00 AM Changeset in webkit [146892] by kareng@chromium.org
  • 8 edits in branches/chromium/1453/Source/WebCore

Revert 146744 "Refactoring: Pull Node::disabled() and Node::isIn..."

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
​https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

  • dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

  • dom/Element.h:

(Element):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

  • dom/Node.h:

(Node):

TBR=​falken@chromium.org
Review URL: ​https://codereview.chromium.org/12703032

8:57 AM Changeset in webkit [146891] by kareng@chromium.org
  • 33 edits in branches/chromium/1453/Source/WebCore

Revert 146726 "AXObjectCache gets recreated during document tear..."

AXObjectCache gets recreated during document tear-down.
​https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

  • editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/InputType.cpp:

(WebCore::InputType::applyStep):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

  • page/Frame.cpp:

(WebCore::Frame::disconnectOwnerElement):

  • page/FrameView.cpp:

(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

  • platform/Scrollbar.h:

(Scrollbar):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

TBR=Chris Fleizach
Review URL: ​https://codereview.chromium.org/12703031

8:54 AM Changeset in webkit [146890] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
​http://bugs.webkit.org/show_bug.cgi?id=113080

Reviewed by Pavel Feldman.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
(WebInspector.FlameChart.prototype._canvasDragging):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

8:53 AM Changeset in webkit [146889] by kareng@chromium.org
  • 1 add in branches/chromium/1453/codereview.settings

for drovering

8:52 AM Changeset in webkit [146888] by kareng@chromium.org
  • 1 copy in branches/chromium/1453

hopefully m27 branch

8:36 AM Changeset in webkit [146887] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ArrayMode should not consider SpecOther when refining the base
​https://bugs.webkit.org/show_bug.cgi?id=113271

Reviewed by Geoffrey Garen.

9% speed-up on Octane/pdfjs.

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

8:22 AM Changeset in webkit [146886] by mkwst@chromium.org
  • 5 edits
    4 adds in trunk

CSP 1.1: Experiment with 'base-uri' directive.
​https://bugs.webkit.org/show_bug.cgi?id=113307

Reviewed by Jochen Eisinger.

Source/WebCore:

The 'base-uri' directive was introduced[1] as an experimental directive
in CSP 1.1 after a bit of discussion[2][3]. The exact semantics will
likely change, but it would be good for us to get some implementation
experience with the API as currently specified, and to allow folks to
play with the implementation to determine whether it meets the
requirements the way we think it might.

This patch is a first pass at that implementation: it will have no
effect on ports that haven't enabled the CSP_NEXT flag.

[1]: ​https://dvcs.w3.org/hg/content-security-policy/rev/4b89c246ea16
[2]: ​http://lists.w3.org/Archives/Public/public-webappsec/2012Oct/0022.html
[3]: ​http://lists.w3.org/Archives/Public/public-webappsec/2013Feb/0074.html

Tests: http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html

http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html

  • dom/Document.cpp:

(WebCore::Document::processBaseElement):

Check that the new base URI is allowed by CSP before using it as
the document's base URI.

  • page/ContentSecurityPolicy.cpp:

Add a constant for the new directive name (and, as a drive-by, split
the list into CSP 1.0 and CSP 1.1 for clarity).

(CSPDirectiveList):

Add a property to hold the base URI policy directive value.

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Customize the error message iff we're dealing with 'base-uri'.

(WebCore::CSPDirectiveList::allowBaseURI):

Check the given URI against the 'base-uri' directive's value,
exactly as we do for every other source-list type of directive.

(WebCore::CSPDirectiveList::addDirective):

Accept 'base-uri' as a valid directive iff CSP_NEXT is set, and
the embedder has opted-in via the runtime flag.

(WebCore::ContentSecurityPolicy::allowBaseURI):

Expose an API method on ContentSecurityPolicy to check URIs against
the 'base-uri' directive's value.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/base-uri-allow-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html: Added.
8:21 AM Changeset in webkit [146885] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Main frame fixed divs not positioned correctly
​https://bugs.webkit.org/show_bug.cgi?id=112889

Reviewed by Carlos Garcia Campos.

PR 283363

This was a regression from bug #112806. It caused main frame fixed
handling to enter the iframe/scrollable div code path in LayerRenderer.

Fixed by not setting the container for fixed flag on the main frame,
the LayerRenderer expects this flag to be set only on non-mainframe
containers.

Only manually testable.

  • page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:

(WebCore::scrollLayerForFrame):
(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):

8:17 AM Changeset in webkit [146884] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

FormData::deepCopy() could use Vector::uncheckedAppend()
​https://bugs.webkit.org/show_bug.cgi?id=113309

Reviewed by Kenneth Rohde Christiansen.

FormData::deepCopy() calls reserveInitialCapacity() on the Vector but then uses the
regular append() method. This patch switches to using uncheckedAppend() method
instead to bypass capacity checks as we already know it is sufficient.

No new tests, no behavior change.

  • platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):

8:15 AM Changeset in webkit [146883] by commit-queue@webkit.org
  • 13 edits in trunk

Unreviewed, rolling out r146879.
​http://trac.webkit.org/changeset/146879
​https://bugs.webkit.org/show_bug.cgi?id=113312

Multiple layout test crashes in
WebCore::RenderListItem::updateListMarkerNumbers (Requested by
yurys on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

  • dom/Node.cpp:
  • dom/Node.h:

(Node):

  • dom/NodeTraversal.cpp:
  • dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

  • rendering/RenderListItem.cpp:

(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

  • fast/dom/shadow/shadow-and-list-elements-expected.html:
  • fast/lists/positioned-count-crash-expected.txt:
8:06 AM Changeset in webkit [146882] by morrita@google.com
  • 6 edits
    3 adds in trunk

remoeveAllEventListeners() should be called to shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=113037

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::removeAllEventListeners() doesn't traverse shadow tree, but we should.
This change override Element::removeAllEventListeners() so that it cleans its shadow trees up.

Test: fast/dom/shadow/shadow-tree-listener-clearance.html

  • dom/Element.cpp:

(WebCore::Element::removeAllEventListeners):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::removeAllEventListeners): Added.
(WebCore):

  • dom/ElementShadow.h:

(ElementShadow):

LayoutTests:

  • fast/dom/shadow/resources/shadow-tree-listener-clearance-frame.html: Added.
  • fast/dom/shadow/shadow-tree-listener-clearance-expected.txt: Added.
  • fast/dom/shadow/shadow-tree-listener-clearance.html: Added.
8:04 AM Changeset in webkit [146881] by yurys@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Unreviewed. Updated test expectations for compositing/geometry/fixed-in-composited.html

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Removed.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
7:52 AM Changeset in webkit [146880] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] UIProcess should initialize WebCoreSystemInterface.
​https://bugs.webkit.org/show_bug.cgi?id=113300

The WebCoreSystemInterface is necessary to detect supported
mime types on Mac OS. In particular it is needed for download
support.
This patch fixes in particular the previously failing
Qt API qmltest WebViewDownload::test_downloadRequest.
The test was crashing when using QTKit, because functions
in WebCoreSystemInterface could not be resolved on the UIProcess side.

Reviewed by Jocelyn Turcotte.

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

6:53 AM Changeset in webkit [146879] by abucur@adobe.com
  • 13 edits in trunk

Use DOM ordering for list counts
​https://bugs.webkit.org/show_bug.cgi?id=110352

Reviewed by Elliott Sprehn.

Source/WebCore:

Currently the list items ordering is made by traversing the render tree. This gives bad results for:

  • list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
  • list items matched to insertion points inside a shadow tree. The insertion point may be a child of a

list so the numbering gets broken.

To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.

In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: ​https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: ​https://bugs.webkit.org/show_bug.cgi?id=103975

Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html

  • dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):

  • dom/Node.h:

(Node):

  • dom/NodeTraversal.cpp:

(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

  • dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

  • rendering/RenderListItem.cpp:

(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.

  • fast/dom/shadow/shadow-and-list-elements-expected.html:
  • fast/lists/positioned-count-crash-expected.txt:
6:51 AM Changeset in webkit [146878] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Poor rounding in GraphicsContext::drawLineForText
​https://bugs.webkit.org/show_bug.cgi?id=113301

Reviewed by Jocelyn Turcotte.

Round the position of the line decoration, so lines on subpixel
coordinates are not always rounded up.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):

6:45 AM Changeset in webkit [146877] by zarvai@inf.u-szeged.hu
  • 256 edits
    6 copies
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating PNG expected results. Making pixel test bot happier after r146206.

  • platform/qt/svg/custom/mask-excessive-malloc-expected.png:
  • platform/qt/svg/custom/mask-inside-defs-expected.png:
  • platform/qt/svg/custom/massive-coordinates-expected.png:
  • platform/qt/svg/custom/missing-xlink-expected.png:
  • platform/qt/svg/custom/non-circular-marker-reference-expected.png:
  • platform/qt/svg/custom/object-sizing-expected.png:
  • platform/qt/svg/custom/path-bad-data-expected.png:
  • platform/qt/svg/custom/path-update-expected.png:
  • platform/qt/svg/custom/pattern-no-pixelation-expected.png:
  • platform/qt/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
  • platform/qt/svg/custom/pattern-y-offset-expected.png:
  • platform/qt/svg/custom/percentage-of-html-parent-expected.png:
  • platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-image-expected.png:
  • platform/qt/svg/custom/pointer-events-path-expected.png:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-text-expected.png:
  • platform/qt/svg/custom/poly-identify-expected.png:
  • platform/qt/svg/custom/polyline-hittest-expected.png:
  • platform/qt/svg/custom/polyline-invalid-points-expected.png:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/rootelement-expected.png:
  • platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
  • platform/qt/svg/custom/second-inline-text-expected.png:
  • platform/qt/svg/custom/shape-rendering-expected.png:
  • platform/qt/svg/custom/sheet-title-expected.png:
  • platform/qt/svg/custom/stroke-fallback-expected.png:
  • platform/qt/svg/custom/svg-float-border-padding-expected.png:
  • platform/qt/svg/custom/svg-fonts-in-html-expected.png:
  • platform/qt/svg/custom/svg-fonts-segmented-expected.png:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/qt/svg/custom/svgpolyparser-extra-space-expected.png:
  • platform/qt/svg/custom/text-dom-01-f-expected.png:
  • platform/qt/svg/custom/text-filter-expected.png:
  • platform/qt/svg/custom/text-hit-test-expected.png:
  • platform/qt/svg/custom/text-letter-spacing-expected.png:
  • platform/qt/svg/custom/text-linking-expected.png:
  • platform/qt/svg/custom/text-whitespace-handling-expected.png:
  • platform/qt/svg/custom/text-x-dx-lists-expected.png:
  • platform/qt/svg/custom/text-x-dy-lists-expected.png:
  • platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/qt/svg/custom/transform-removeAttributeNS-expected.png:
  • platform/qt/svg/custom/transform-scale-parse-expected.png:
  • platform/qt/svg/custom/use-clipped-transform-expected.png:
  • platform/qt/svg/custom/use-dynamic-append-expected.png:
  • platform/qt/svg/custom/use-font-face-crash-expected.png:
  • platform/qt/svg/custom/use-nested-transform-expected.png:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
  • platform/qt/svg/custom/use-on-g-containing-use-expected.png:
  • platform/qt/svg/custom/use-on-g-expected.png:
  • platform/qt/svg/custom/use-on-rect-expected.png:
  • platform/qt/svg/custom/use-on-symbol-expected.png:
  • platform/qt/svg/custom/use-on-text-expected.png:
  • platform/qt/svg/custom/use-on-use-expected.png:
  • platform/qt/svg/custom/use-transform-expected.png:
  • platform/qt/svg/custom/viewport-no-width-height-expected.png:
  • platform/qt/svg/custom/viewport-update-expected.png:
  • platform/qt/svg/custom/visibility-override-clip-expected.png:
  • platform/qt/svg/custom/visibility-override-expected.png:
  • platform/qt/svg/custom/visibility-override-mask-expected.png:
  • platform/qt/svg/custom/width-full-percentage-expected.png:
  • platform/qt/svg/custom/xml-stylesheet-expected.png:
  • platform/qt/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
  • platform/qt/svg/filters/animate-fill-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
  • platform/qt/svg/filters/big-sized-filter-expected.png:
  • platform/qt/svg/filters/feColorMatrix-offset-expected.png:
  • platform/qt/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/qt/svg/filters/feDropShadow-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
  • platform/qt/svg/filters/feGaussianBlur-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
  • platform/qt/svg/filters/filter-empty-g-expected.png:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/qt/svg/filters/filter-on-tspan-expected.png:
  • platform/qt/svg/filters/filter-placement-issue-expected.png:
  • platform/qt/svg/filters/filter-source-position-expected.png:
  • platform/qt/svg/filters/filterRes2-expected.png:
  • platform/qt/svg/foreignObject/clip-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png:
  • platform/qt/svg/foreignObject/filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
  • platform/qt/svg/foreignObject/mask-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.png:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/qt/svg/hixie/cascade/001-broken-expected.png:
  • platform/qt/svg/hixie/error/012-expected.png:
  • platform/qt/svg/hixie/error/013-expected.png:
  • platform/qt/svg/hixie/links/001-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/shapes/path/001-expected.png:
  • platform/qt/svg/hixie/text/001-expected.png:
  • platform/qt/svg/hixie/text/003-expected.png:
  • platform/qt/svg/hixie/transform/001-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/qt/svg/text/bidi-embedded-direction-expected.png:
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/scaled-font-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/qt/svg/text/small-fonts-in-html5-expected.png:
  • platform/qt/svg/text/text-align-04-b-expected.png:
  • platform/qt/svg/text/text-align-05-b-expected.png:
  • platform/qt/svg/text/text-deco-01-b-expected.png:
  • platform/qt/svg/text/text-path-middle-align-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-07-t-expected.png:
  • platform/qt/svg/text/textPathBoundsBug-expected.png:
  • platform/qt/svg/wicd/rightsizing-grid-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt/tables/layering/paint-test-layering-1-expected.png:
  • platform/qt/tables/layering/paint-test-layering-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug101201-expected.png:
  • platform/qt/tables/mozilla/bugs/bug102145-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug102145-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug102145-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug102145-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10269-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10296-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug103533-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106158-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106795-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106816-expected.png:
  • platform/qt/tables/mozilla/bugs/bug109043-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11321-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11944-expected.png:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1224-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12709-expected.png:
  • platform/qt/tables/mozilla/bugs/bug127267-expected.png:
  • platform/qt/tables/mozilla/bugs/bug128229-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13118-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13196-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133948-expected.png:
  • platform/qt/tables/mozilla/bugs/bug137388-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14159-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14929-expected.png:
  • platform/qt/tables/mozilla/bugs/bug15247-expected.png:
  • platform/qt/tables/mozilla/bugs/bug154780-expected.png:
  • platform/qt/tables/mozilla/bugs/bug157890-expected.png:
  • platform/qt/tables/mozilla/bugs/bug15933-expected.png:
  • platform/qt/tables/mozilla/bugs/bug16012-expected.png:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17138-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17587-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1800-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1802-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1818-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1818-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1818-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18664-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18955-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug194024-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19599-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2050-expected.png:
  • platform/qt/tables/mozilla/bugs/bug20579-expected.png:
  • platform/qt/tables/mozilla/bugs/bug20804-expected.png:
  • platform/qt/tables/mozilla/bugs/bug21299-expected.png:
  • platform/qt/tables/mozilla/bugs/bug215629-expected.png:
  • platform/qt/tables/mozilla/bugs/bug219693-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug219693-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug221784-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug221784-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2267-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23072-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23299-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24627-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2469-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24880-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25074-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25086-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2509-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25367-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25663-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2684-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2773-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2886-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29429-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2981-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2997-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3037-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3037-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30418-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30559-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30692-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3103-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32447-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3260-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32841-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3309-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug34538-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3454-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3681-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3681-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug38916-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3977-expected.png:
  • platform/qt/tables/mozilla/bugs/bug41890-expected.png:
  • platform/qt/tables/mozilla/bugs/bug42187-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4284-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43039-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4427-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45350-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45486-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
6:29 AM Changeset in webkit [146876] by kadam@inf.u-szeged.hu
  • 2 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardneing. Unskipped and Updated inspector tests after r146863.

  • platform/qt/TestExpectations:
  • platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Added.
  • platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
  • platform/qt/inspector/extensions/extensions-eval-expected.txt: Added.
6:22 AM Changeset in webkit [146875] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Decorations in several consecutive lines are not moved correctly in DTE.
​https://bugs.webkit.org/show_bug.cgi?id=113296

Reviewed by Pavel Feldman.

Separated removing and adding decorations so that moved decorations are not removed when next line is processed.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorGutterPanel.prototype.textChanged):

6:17 AM Changeset in webkit [146874] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi (part 2)
​https://bugs.webkit.org/show_bug.cgi?id=103124

Reviewed by Pavel Feldman.

  • WebCore.gypi: removed unused references to gtk, cf, win and mac
5:31 AM Changeset in webkit [146873] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.

5:08 AM Changeset in webkit [146872] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebElement::render() API test
​https://bugs.webkit.org/show_bug.cgi?id=65243

Reviewed by Jocelyn Turcotte.

Unmark the passing part of this testcase.

  • tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

5:01 AM Changeset in webkit [146871] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r146767.
​http://trac.webkit.org/changeset/146767
​https://bugs.webkit.org/show_bug.cgi?id=113295

Rolling out until nicer fonts / sizes are chosen (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

  • inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

  • inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):
(.drawer-header-close-button):

  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):

  • inspector/front-end/timelinePanel.css:

(.timeline-tree-item .count):
(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.memory-counter-sidebar-info):
(.memory-counter-value):

Source/WebKit/chromium:

  • src/js/devTools.css:
4:57 AM Changeset in webkit [146870] by zarvai@inf.u-szeged.hu
  • 287 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

  • platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-a-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-14-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-image-09-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-css-06-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png:
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt/svg/as-image/same-image-two-instances-expected.png:
  • platform/qt/svg/batik/filters/feTile-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/text/textEffect-expected.png:
  • platform/qt/svg/batik/text/textEffect3-expected.png:
  • platform/qt/svg/batik/text/textLayout-expected.png:
  • platform/qt/svg/batik/text/textOnPath3-expected.png:
  • platform/qt/svg/batik/text/textStyles-expected.png:
  • platform/qt/svg/batik/text/xmlSpace-expected.png:
  • platform/qt/svg/clip-path/clip-in-mask-expected.png:
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/qt/svg/clip-path/clip-path-clipped-expected.png:
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/qt/svg/clip-path/clip-path-css-transform-1-expected.png:
  • platform/qt/svg/clip-path/clip-path-css-transform-2-expected.png:
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/qt/svg/clip-path/clip-path-on-g-expected.png:
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.png:
  • platform/qt/svg/clip-path/clip-path-recursive-call-expected.png:
  • platform/qt/svg/clip-path/clip-path-transform-1-expected.png:
  • platform/qt/svg/clip-path/clip-path-transform-2-expected.png:
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.png:
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/qt/svg/css/css-box-min-width-expected.png:
  • platform/qt/svg/css/group-with-shadow-expected.png:
  • platform/qt/svg/css/mask-with-shadow-expected.png:
  • platform/qt/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/qt/svg/custom/SVGMatrix-interface-expected.png:
  • platform/qt/svg/custom/SVGNumber-interface-expected.png:
  • platform/qt/svg/custom/SVGPoint-interface-expected.png:
  • platform/qt/svg/custom/SVGRect-interface-expected.png:
  • platform/qt/svg/custom/alignment-baseline-modes-expected.png:
  • platform/qt/svg/custom/bug45331-expected.png:
  • platform/qt/svg/custom/circular-marker-reference-2-expected.png:
  • platform/qt/svg/custom/class-baseValue-expected.png:
  • platform/qt/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/qt/svg/custom/clip-path-referencing-use-expected.png:
  • platform/qt/svg/custom/clip-path-with-transform-expected.png:
  • platform/qt/svg/custom/conditional-processing-outside-switch-expected.png:
  • platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/qt/svg/custom/control-points-for-S-and-T-expected.png:
  • platform/qt/svg/custom/convolution-crash-expected.png:
  • platform/qt/svg/custom/create-metadata-element-expected.png:
  • platform/qt/svg/custom/createelement-expected.png:
  • platform/qt/svg/custom/display-none-expected.png:
  • platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/qt/svg/custom/dominant-baseline-modes-expected.png:
  • platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/qt/svg/custom/embedding-external-svgs-expected.png:
  • platform/qt/svg/custom/empty-clip-path-expected.png:
  • platform/qt/svg/custom/evt-onload-expected.png:
  • platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
  • platform/qt/svg/custom/fill-fallback-expected.png:
  • platform/qt/svg/custom/fill-update-expected.png:
  • platform/qt/svg/custom/fractional-rects-expected.png:
  • platform/qt/svg/custom/getPresentationAttribute-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
  • platform/qt/svg/custom/getsvgdocument-expected.png:
  • platform/qt/svg/custom/gradient-attr-update-expected.png:
  • platform/qt/svg/custom/gradient-cycle-detection-expected.png:
  • platform/qt/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/qt/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/qt/svg/custom/group-opacity-expected.png:
  • platform/qt/svg/custom/hit-test-with-br-expected.png:
  • platform/qt/svg/custom/image-parent-translation-expected.png:
  • platform/qt/svg/custom/image-rescale-scroll-expected.png:
  • platform/qt/svg/custom/image-with-aspect-ratio-stretch-expected.png:
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/qt/svg/custom/inner-svg-hit-test-expected.png:
  • platform/qt/svg/custom/invalid-fill-expected.png:
  • platform/qt/svg/custom/invalid-fill-hex-expected.png:
  • platform/qt/svg/custom/invalid-lengthlist-expected.png:
  • platform/qt/svg/custom/invalid-stroke-hex-expected.png:
  • platform/qt/svg/custom/invalid-uri-stroke-expected.png:
  • platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/qt/svg/custom/junk-data-expected.png:
  • platform/qt/svg/custom/large-bounding-box-percents-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/qt/svg/custom/linking-uri-01-b-expected.png:
  • platform/qt/svg/custom/marker-changes-expected.png:
  • platform/qt/svg/custom/marker-empty-path-expected.png:
  • platform/qt/svg/custom/mask-changes-expected.png:
4:52 AM Changeset in webkit [146869] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Fix unused parameter warnings in JITInlines.h
​https://bugs.webkit.org/show_bug.cgi?id=112560

Reviewed by Zoltan Herczeg.

  • jit/JITInlines.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
(JSC):

4:49 AM Changeset in webkit [146868] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=113287

Reviewed by Jocelyn Turcotte.

  • Scripts/run-qtwebkit-tests:

(Options.init):

4:37 AM Changeset in webkit [146867] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Unable to insert a paragraph in between some text whose previous sibling is a non-editable block.
​https://bugs.webkit.org/show_bug.cgi?id=113007

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Unable to insert a line break in between a text that follows a
non-editable block but is itself contained within an editable
block.

While comparing the positions from the start block till the
insertion position, we should ignore the nodes that do not
generate a visiblePosition for the position before the node.
This ultimately results in an assert within comparePositions().

For this case, the firstChild of the start block is a text
node with no renderer which would thus not generate a candidate
position for itself.
There is also no candidate previous to it, and since
the position after it lies within a different editable element (root),
no candidate after it as well.
Such a point will thus return a null visiblePosition.

Test: editing/inserting/insert-paragraph-between-text.html

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):
Added a check to verify the generated visiblePosition (for the
position before the node) prior to carrying out a comparison with
the insertion point.

LayoutTests:

  • editing/inserting/insert-paragraph-between-text-expected.txt: Added.
  • editing/inserting/insert-paragraph-between-text.html: Added.

Added a layout test case for verifying the behavior when trying
to insert a line break between an editable text with a non-editable
block as it's previous sibling.

4:23 AM Changeset in webkit [146866] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error.
​https://bugs.webkit.org/show_bug.cgi?id=113138

Reviewed by Pavel Feldman.

The old version had problem with rounding because it recalculates the window size on each event.
The new version just calculates the dragging delta and moves the window
to the new position based on the initial values and the delta.

  • inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):

3:44 AM Changeset in webkit [146865] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Memory leak in UserMediaClientImpl
​https://bugs.webkit.org/show_bug.cgi?id=112998

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.

PR 312559
Internally Reviewed by Anthony Scian.

Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::pageDestroyed):

3:41 AM Changeset in webkit [146864] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Enable IndexedDB by default
​https://bugs.webkit.org/show_bug.cgi?id=107248

Patch by Rijubrata Bhaumik <​rijubrata.bhaumik@intel.com> on 2013-03-26
Reviewed by Laszlo Gombos.

.:

  • Source/cmake/OptionsEfl.cmake:

Enable IndexedDB by default on EFL.

Tools:

  • Scripts/webkitperl/FeatureList.pm:

Enable IndexedDB by default on EFL.

LayoutTests:

  • platform/efl/TestExpectations:

Unskip the tests now that IndexDB is enabled (except the ones
that actually fail).

3:39 AM Changeset in webkit [146863] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skipped some failing tests.
  • platform/qt/css3/filters/effect-reference-expected.png: Updated after r146779.
  • platform/qt/css3/filters/effect-reference-expected.txt: Update after r146779.
1:43 AM Changeset in webkit [146862] by zarvai@inf.u-szeged.hu
  • 10 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r146814.

  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt:
1:40 AM Changeset in webkit [146861] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Sheriffbot should explain rollout failures in a human readable form.
​https://bugs.webkit.org/show_bug.cgi?id=107092

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-03-26
Reviewed by Ryosuke Niwa.

Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout._check_diff_failure):
(Rollout.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_rollout):

1:26 AM Changeset in webkit [146860] by tkent@chromium.org
  • 11 edits in trunk/Source/WebCore

Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
​https://bugs.webkit.org/show_bug.cgi?id=113264

Reviewed by Kentaro Hara.

HTMLInputElement had indeterminate() and isIndeterminate(). It's very
confusing.

Because indeterminate is a public DOM function and isIndeterminate is
for CSS and rendering, we rename isIndetermiante to
shouldAppearIndeterminate. Also, HTMLProgressElement, which support
:indeterminate pseudo class, should follow it. We add
shouldAppearIndeterminate to Element.

No new tests. Just a refactoring.

  • dom/Element.cpp:

(WebCore::Element::shouldAppearIndeterminate): Added. Returns false.

  • dom/Element.h:

(Element): Declare shouldAppearIndeterminate.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldAppearIndeterminate):
Renamed from isIndeterminate.

  • html/HTMLInputElement.h:

(HTMLInputElement): Rename isIndeterminate to shouldAppearIndeterminate,
and overrides Element::shouldAppearIndeterminate.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::shouldAppearIndeterminate): Added.

  • html/HTMLProgressElement.h: Add shouldAppearIndeterminate.
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isIndeterminate):
Use shouldAppearIndeterminate.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl): Ditto.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isIndeterminate): Ditto.

1:21 AM Changeset in webkit [146859] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skipping a failing unit test after r146518.

1:20 AM Changeset in webkit [146858] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
​https://bugs.webkit.org/show_bug.cgi?id=113266.

Patch by Pan Deng <​pan.deng@intel.com> on 2013-03-26
Reviewed by Vsevolod Vlasov.

In Flamechart, the highlighted function bar is not consistent with cursor sometimes,
reason is that time range that converted from cursor position is truncated by floor.
Actually float value is expected to compare with function startTime and duration.

No new tests.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor

1:09 AM Changeset in webkit [146857] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adjusting expectation for inspector/debugger/live-edit-breakpoints.html after r146840.
  • platform/gtk/fast/text/international/khmer-selection-expected.txt: Rebaselining after r146778.
  • platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Rebaselining

after r146763.

12:54 AM Changeset in webkit [146856] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions]: Crash accessing offsetParent for contentNodes inside a flow thread
​https://bugs.webkit.org/show_bug.cgi?id=112730

Reviewed by Levi Weintraub.

Source/WebCore:

When computing the offsetParent for an element inside a flow thread, do not
let the algorithm process past the flow thread boundaries, until we figure out
the proper behavior. When reaching the flow thread, offsetParent will return 0,
thus preventing the assert while calling toElement inside Element::offsetParent.

The attached test sets the ground work and will be changed to match the right behavior.
For now, it makes sure we do not crash or return HTMLDocument as offsetParent for
elements inside the flow thread.

Test: fast/regions/offsetParent-in-flow-thread.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

LayoutTests:

  • fast/regions/offsetParent-in-flow-thread-expected.txt: Added.
  • fast/regions/offsetParent-in-flow-thread.html: Added.
12:51 AM Changeset in webkit [146855] by dominik.rottsches@intel.com
  • 6 edits
    2 deletes in trunk/Source/WebCore

Remove HarfBuzzShaperBase
​https://bugs.webkit.org/show_bug.cgi?id=112087

Reviewed by Martin Robinson.

Folding HarfBuzzShaperBase into HarfBuzzShaper since
there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.

No new tests, no change in behavior.

  • GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
  • PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
  • WebCore.gypi: Removing HarfBuzzShaperBase.*
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
(WebCore::HarfBuzzShaper::isWordEnd):
(WebCore::HarfBuzzShaper::determineWordBreakSpacing):
(WebCore::HarfBuzzShaper::setPadding):

  • platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.

(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::isCodepointSpace):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.
12:33 AM Changeset in webkit [146854] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/canvas/canvas-toDataURL-webp.html

  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:

Mar 25, 2013:

11:39 PM Changeset in webkit [146853] by morrita@google.com
  • 6 edits
    2 adds in trunk

Listening touch events on ShadowRoot can crash.
​https://bugs.webkit.org/show_bug.cgi?id=113035

Reviewed by Kentaro Hara.

Source/WebCore:

TreeScope destructor clears a document reference on ShadowRoot but
destructors of ContainerNode and Node assumed it being available
and tried to access it for some cleanup purposes.

This change extracts such cleanup to Node::willBeDeletedFrom() and
calls it from ShadowRoot dtor before the document reference gets cleared.

Test: fast/dom/shadow/shadow-root-touch-listener-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()

  • dom/Node.cpp:

(WebCore::Node::~Node): Adopted willBeDeletedFrom()
(WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
(WebCore):

  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()

LayoutTests:

  • fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt: Added.
  • fast/dom/shadow/shadow-root-touch-listener-crash.html: Added.
11:35 PM Changeset in webkit [146852] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove Lion leaks builder
​https://bugs.webkit.org/show_bug.cgi?id=113252

Reviewed by Andreas Kling.

Removed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:35 PM Changeset in webkit [146851] by morrita@google.com
  • 6 edits
    2 deletes in trunk/Source/WebCore

Custom Elements Refactoring: The name V8CustomElement is confusing.
​https://bugs.webkit.org/show_bug.cgi?id=113165

Reviewed by Kent Tamura.

This change moves functions from V8CustomElement to CustomElementHelpers and
removes V8CustomElement. V8CustomElement is just a heritage of old design
and no longer makes sense.

No new tests. No behavior change.

  • WebCore.gypi:
  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::createWrapper):
(WebCore):

  • bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):
(WebCore::CustomElementHelpers::wrap):
(WebCore):
(WebCore::CustomElementHelpers::constructorOf):

  • bindings/v8/V8CustomElement.cpp: Removed.
  • bindings/v8/V8CustomElement.h: Removed.
  • bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

  • dom/make_names.pl:

(printWrapperFactoryCppFile):

11:07 PM Changeset in webkit [146850] by jamesr@google.com
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Update a few more chromium compositor baselines.

  • platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
9:51 PM Changeset in webkit [146849] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Records sidebar is clipped.
​https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

  • inspector/front-end/timelinePanel.css:

(.timeline .sidebar): Make "bottom" value "important".

9:04 PM Changeset in webkit [146848] by noel.gordon@gmail.com
  • 4 edits in trunk/LayoutTests

[chromium] Rebaseline canvas-toDataURL-webp test expectations
​https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

  • platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png:
  • platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png:
  • platform/chromium/TestExpectations:
8:28 PM Changeset in webkit [146847] by tkent@chromium.org
  • 35 edits in trunk

Rename ENABLE_INPUT_TYPE_DATETIME
​https://bugs.webkit.org/show_bug.cgi?id=113254

Reviewed by Kentaro Hara.

Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
Actually I'd like to remove the code, but we shouldn't remove it yet
because we shipped products with it on some platforms.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • css/html.css:
  • html/DateTimeInputType.cpp:
  • html/DateTimeInputType.h:
  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):

  • tests/WebViewTest.cpp:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.props:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/chromium/TestExpectations:
8:19 PM Changeset in webkit [146846] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
​https://bugs.webkit.org/show_bug.cgi?id=113261

Reviewed by Dirk Pranke.

Fixed the bug by treating ['TEXT', 'IMAGE'] as a flaky pass when the pixel tests is disabled
since the second token implies that we've forced pixel tests in retry and didn't have text failures.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
  • fast/harness/results-expected.txt:
8:13 PM Changeset in webkit [146845] by mary.wu@torchmobile.com.cn
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] add needReferer in WebPage load() api
​https://bugs.webkit.org/show_bug.cgi?id=113167

Reviewed by Rob Buis.

PR310175, internally reviewed by Joe Mason.
Sometimes when client load request, it need to add referer with current frame like
save link/image in option menu, so we add needRef in load() interface in webpage.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

8:11 PM Changeset in webkit [146844] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Efl test expectations to mark new test as failing.
Efl doesn't implement the Pasteboard class.

  • platform/efl/TestExpectations: Mark editing/pasteboard/copy-image-with-alt-text.html as failing
8:02 PM Changeset in webkit [146843] by danakj@chromium.org
  • 7 edits
    1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

  • chromium/public/WebVideoFrame.h:
  • chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

  • WebKit.gypi:
  • public/WebMediaPlayer.h:

(WebKit):

  • public/WebMediaPlayerClient.h:
  • public/WebStreamTextureClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Removed.
7:51 PM Changeset in webkit [146842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190515. Requested by
"Dana Jansens" <​danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-25

  • DEPS:
7:43 PM Changeset in webkit [146841] by jamesr@google.com
  • 20 edits
    3 copies
    1 add
    10 deletes in trunk/LayoutTests

Update more expectations and baselines for r146826

  • platform/chromium-linux-x86/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt.
  • platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Removed.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
  • platform/chromium-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
7:35 PM Changeset in webkit [146840] by timothy@apple.com
  • 9 edits
    5 adds in trunk

Make the Web Inspector console work in strict mode with JavaScriptCore.

​https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Oliver Hunt.

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):
Return the evalFunction directly.

  • inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
Added. Return true on JSC and false on V8.

  • inspector/InjectedScriptHost.idl:

Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
a closure that evaluates the expression. The command line APIs are passed as parameters
to the closure so they are in scope but not injected. This allows the code evaluated in
the console to stay in strict mode (if is was already set), or to get strict mode by
prefixing expressions with 'use strict';.

LayoutTests:

  • inspector/debugger/mutation-observer-suspend-while-paused.html: Tweaked.
  • inspector/console/command-line-api-expected.txt: Updated.
  • platform/mac/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt: Updated.
  • platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Added.
  • platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
  • platform/mac/inspector/extensions/extensions-eval-expected.txt: Added.

Added new expectations to match the new console evaluate approach.

7:14 PM Changeset in webkit [146839] by jamesr@google.com
  • 3 edits
    4 copies
    2 moves
    5 adds
    10 deletes in trunk/LayoutTests

Update chromium baselines for windows related to r146826

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.
7:02 PM Changeset in webkit [146838] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove one more line that was intended to be removed in r146657.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

6:44 PM Changeset in webkit [146837] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r146816, r146821, and r146830.
​http://trac.webkit.org/changeset/146816
​http://trac.webkit.org/changeset/146821
​http://trac.webkit.org/changeset/146830
​https://bugs.webkit.org/show_bug.cgi?id=113262

Broke all the Windows tests (Requested by rfong on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-25

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

  • platform/win/TestExpectations:
6:36 PM Changeset in webkit [146836] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

Revert bad change to expectation from r146826

  • compositing/geometry/object-clip-rects-assertion-expected.txt:
6:33 PM Changeset in webkit [146835] by tony@chromium.org
  • 25 edits
    2 adds in trunk

Image alt text not included in plain-text version when copying
​https://bugs.webkit.org/show_bug.cgi?id=11200

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
This setting is disabled by default, so each port can enable if they want to match IE10 and
Firefox's behavior.

Test: editing/pasteboard/copy-image-with-alt-text.html

  • editing/Editor.cpp:

(WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
(WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.

  • editing/Editor.h:
  • editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
(WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.

  • editing/TextIterator.h:

(TextIterator):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
(WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
used by Services.
(WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
used by Services.

  • page/DragController.cpp:

(WebCore::DragController::startDrag): Use image alt text (matches Firefox).

  • page/Settings.in: Add a setting that disables image alt text by default.
  • platform/Pasteboard.h:
  • platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection): Update function param.

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
text is for the clipboard or not.
(WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

  • rendering/RenderImage.h:

(WebCore::RenderImage::altText): Add a getter for the alt text.

LayoutTests:

  • editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
  • editing/pasteboard/copy-image-with-alt-text.html: Added.
6:23 PM Changeset in webkit [146834] by jamesr@google.com
  • 3 edits
    9 moves
    13 adds
    2 deletes in trunk/LayoutTests

Update chromium mac 10.6 and 10.8 baselines for r146826.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
  • platform/chromium-win/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt.
6:02 PM Changeset in webkit [146833] by dino@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebCore

Remove autostart hashing code from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=113242

Reviewed by Tim Horton.

Remove PlugInOriginHash and all the related build entries.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLPlugInImageElement.cpp:
  • plugins/PlugInOriginHash.cpp: Removed.
  • plugins/PlugInOriginHash.h: Removed.
5:40 PM Changeset in webkit [146832] by pkasting@chromium.org
  • 7 edits
    7 adds in trunk/LayoutTests

[chromium] Rebaselining, etc.
​https://bugs.webkit.org/show_bug.cgi?id=109507
​https://bugs.webkit.org/show_bug.cgi?id=112927

Unreviewed, test expectations update.

  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/chromium-win-xp/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium/TestExpectations:
5:36 PM Changeset in webkit [146831] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Offlineasm cloop backend compiles op+branch incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=113146.

Reviewed by Geoffrey Garen.

  • dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

  • These functions never return when the DFG is dsiabled, not just when asserts are enabled. Changing the attribute from NO_RETURN_DUE_TO_ASSERT to NO_RETURN.
  • llint/LLIntOfflineAsmConfig.h:
  • Added some #defines needed to get the cloop building again.
  • offlineasm/cloop.rb:
  • Fix cloopEmitOpAndBranchIfOverflow() and cloopEmitOpAndBranch() to emit code that unconditionally executes the specified operation before doing the conditional branch.
5:27 PM Changeset in webkit [146830] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

5:14 PM Changeset in webkit [146829] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
​https://bugs.webkit.org/show_bug.cgi?id=113236

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.

LayoutTests:

New test case that tests calling Object.freeze on Array.prototype.

  • fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
  • fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
  • fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
5:11 PM Changeset in webkit [146828] by jamesr@google.com
  • 7 edits
    1 move
    29 adds
    5 deletes in trunk/LayoutTests

Update chromium baselines for r146826

  • platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
  • platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
4:46 PM Changeset in webkit [146827] by roger_fong@apple.com
  • 3 edits in trunk/Tools

No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
Re-enable WinEWS tests.

  • Scripts/webkitpy/common/config/ports.py:

(WinPort.run_bindings_tests_command):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [146826] by jamesr@google.com
  • 128 edits
    11 deletes in trunk

[chromium] Support GraphicsLayer::setContentsToSolidColor
​https://bugs.webkit.org/show_bug.cgi?id=104396

Reviewed by Adrienne Walker.

Source/WebCore:

This enables and implements the GraphicsLayer::setContentsToSolidColor
path for Chromium.

Tested by reftests in compositing/background-color/ and several other
compositing/ tests.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebKit):
(GraphicsLayerChromium):

Source/WebKit/chromium:

Updates some unit tests for better include discipline.

  • tests/GraphicsLayerChromiumTest.cpp:
  • tests/ImageLayerChromiumTest.cpp:
4:30 PM Changeset in webkit [146825] by vcarbune@chromium.org
  • 8 edits
    3 copies
    2 adds in trunk

TextTrack Extension for WebVTT Regions
​https://bugs.webkit.org/show_bug.cgi?id=109820

Reviewed by Eric Carlson.

Source/WebCore:

Implemented the TextTrackRegionList and extended TextTrack with
methods required for proper interaction with TextTrackRegion objects.

Test: media/track/regions-webvtt/text-track-region-list.html

  • WebCore.gypi: Added files for proper building of TextTrackRegionList.
  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore):
(WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
TextTrackRegionList associated with the current track, if it does exist
already.
(WebCore::TextTrack::regions): Getter for the regions object.
(WebCore::TextTrack::addRegion): Method for adding a region.
(WebCore::TextTrack::removeRegion): Method for removing a region.

  • html/track/TextTrack.h:

(WebCore):
(TextTrack):

  • html/track/TextTrack.idl: Added methods specific for region handling.
  • html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
(WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
(WebCore):
(WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
from a different region object.

  • html/track/TextTrackRegion.h: Added track member variable and copy method.

(WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
(TextTrackRegion):

  • html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.

(WebCore):
(WebCore::TextTrackRegionList::TextTrackRegionList):
(WebCore::TextTrackRegionList::length):
(WebCore::TextTrackRegionList::item):
(WebCore::TextTrackRegionList::getRegionById):
(WebCore::TextTrackRegionList::add):
(WebCore::TextTrackRegionList::remove):
(WebCore::TextTrackRegionList::clear):

  • html/track/TextTrackRegionList.h:

(WebCore):
(TextTrackRegionList):
(WebCore::TextTrackRegionList::create):
(WebCore::TextTrackRegionList::~TextTrackRegionList):

  • html/track/TextTrackRegionList.idl: IDL defined by the specification.

LayoutTests:

  • media/track/regions-webvtt/text-track-region-list-expected.txt: Added.
  • media/track/regions-webvtt/text-track-region-list.html: Added.
4:29 PM Changeset in webkit [146824] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

Unreviewed, rolling out r146819.
​http://trac.webkit.org/changeset/146819
​https://bugs.webkit.org/show_bug.cgi?id=113249

broke component build (Requested by danakj on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-25

Source/Platform:

  • chromium/public/WebVideoFrame.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebMediaPlayerClient.h:

(WebKit):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

4:27 PM Changeset in webkit [146823] by dino@apple.com
  • 20 edits in trunk/Source

Cleanup plugin snapshotting autostart decision making
​https://bugs.webkit.org/show_bug.cgi?id=113231

Reviewed by Tim Horton.

Source/WebCore:

Move the code that creates a hash of plugin origin info
out of WebCore. All WebCore needs to do now is simply ask its
host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
should autostart or not.

As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
restarting properly when the displayState was Restarting or
RestartingWithPendingMouseClick. It still worked most of the time, but usually
because the code ran soon after a mouse click. Now it should be explicit and
also allowed us to be more clear about snapshotting at the end of the method.

  • html/HTMLPlugInElement.h: No more pluginOriginHash().
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple

described above, and compare strings rather than hashes.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin

info rather than hash info.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that

the plugin was loaded from. Make some of the logging messages more clear. Test for
plugin and page origin rather than hash.

  • html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.

  • page/PlugInClient.h:

(PlugInClient): Change signature of virtual class to accept origin and mimeType info

rather than hash.

Source/WebKit2:

Two major changes to the way snapshotting plugins may autostart.

The first is that previously WebCore was keeping a hash that
represented the combination of page origin, plugin origin and
mime type. WebKit was responsible for deciding if that particular
hash should autostart. Now, WebKit keeps the hash, and WebCore
just asks us whether the combination of origins and mimetype
should start immediately. You can see this change the in WebPluginClient
and WebProcess APIs.

The second change is that we now keep two types of structures
around to decide whether a plugin should autostart. One is the
existing page + plugin origin combination. The other is simply
the plugin origin, which allows plugins from major providers
to autostart no matter what page they were embedded on.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the new parameter.
(WebKit::WebProcessCreationParameters::decode): Decode the new parameter.

  • Shared/WebProcessCreationParameters.h: Also keep a list of strings around.
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetPlugInAutoStartOrigins): The C API to send the list of plugin

origins over to the context.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash): Renamed from addAutoStartOrigin.

No functional change other than new names for members.

(WebKit::PlugInAutoStartProvider::autoStartOriginHashesCopy): Ditto.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray): New method that converts the

incoming ImmutableArray into a Vector of Strings.

(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Rename for new members.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Renaming member variables. Adding

some typedefs to clean up code.

(WebKit::PlugInAutoStartProvider::autoStartOrigins): New accessor.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess): Renaming, and copy the new parameter into the process creation.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Renaming.
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Renaming.
(WebKit::WebContext::setPlugInAutoStartOrigins): New method.

  • UIProcess/WebContext.h: Adds the new setPlugInAutoStartOrigin method.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin): Drive-by fix that was attempting to restart plugins

that were in the process of restarting.

(WebKit::PluginView::pluginDidReceiveUserInteraction): Temporarily suspend update of

expiration time if the user interacts with a plugin.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Renaming.
(WebKit::WebPlugInClient::didStartFromOrigin): Ditto.

  • WebProcess/WebCoreSupport/WebPlugInClient.h: Renaming.
  • WebProcess/WebProcess.cpp: Drive-by - noticed that we forgot to count seconds in

a timeout threshold.

(WebKit::WebProcess::initializeWebProcess): Also add the list of origins when we initialize.
(WebKit::addCaseFoldedCharacters): Copied from WebCore - adds a String to a hash input.
(WebKit::hashForPlugInOrigin): Copied from WebCore - hashing function.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Renaming.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check the list of pure origins first. If

that fails, fall back to the hash list of pairs.

(WebKit::WebProcess::plugInDidStartFromOrigin): Renaming.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Ditto.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Ditto.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Ditto.

  • WebProcess/WebProcess.h: Renaming some methods, but also adding the input of the new

origin-only list.

  • WebProcess/WebProcess.messages.in: Renaming a message.
4:07 PM Changeset in webkit [146822] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r146793.
​http://trac.webkit.org/changeset/146793
​https://bugs.webkit.org/show_bug.cgi?id=113248

Fix did not work (Requested by rfong on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-25

Source/WebCore:

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Tools:

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

3:58 PM Changeset in webkit [146821] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Disable fast/exclusions and fast/regions tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=113244

  • platform/win/TestExpectations:
3:51 PM Changeset in webkit [146820] by commit-queue@webkit.org
  • 14 edits
    3 copies
    3 adds in trunk

WEBGL_compressed_texture_pvrtc needs implementation
​https://bugs.webkit.org/show_bug.cgi?id=110497

Patch by Brandon Jones <​bajones@google.com> on 2013-03-25
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html

Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::getName):
(WebCore::WebGLCompressedTexturePVRTC::create):
(WebCore::WebGLCompressedTexturePVRTC::supported):

  • html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTexturePVRTC):

  • html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

LayoutTests:

  • webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
3:48 PM Changeset in webkit [146819] by danakj@chromium.org
  • 7 edits
    1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

  • chromium/public/WebVideoFrame.h:
  • chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

  • WebKit.gypi:
  • public/WebMediaPlayer.h:

(WebKit):

  • public/WebMediaPlayerClient.h:
  • public/WebStreamTextureClient.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Removed.
3:18 PM Changeset in webkit [146818] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed. Also enable CSS_REGIONS and EXCLUSIONS for VS2010 solution.

  • win/tools/vsprops/FeatureDefines.props:
3:08 PM Changeset in webkit [146817] by rniwa@webkit.org
  • 5 edits in trunk/Tools

REGRESSION(r146657): Test failures reported incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=113223

Reviewed by Dirk Pranke.

The bug was caused by BuildBotPrinter not taking the new behavior into account.

Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(RunDetails.init):
(summarize_results): Remove the line I intended to remove in r146657.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(logging_run): Return details instead of the exit code.
(run_and_capture): Ditto.

(RunTest.test_full_results_html):
(RunTest.test_hung_thread):
(RunTest.test_no_tests_found):
(RunTest.test_no_tests_found_2):
(RunTest.test_repeat_each_iterations_num_tests):
(RunTest.test_run_singly_actually_runs_tests):
(RunTest.test_test_list):
(RunTest.test_missing_and_unexpected_results):
(RunTest.test_pixel_test_directories):
(RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
(RunTest.test_crash_with_stderr):
(RunTest.test_no_image_failure_with_image_diff):
(RunTest.test_crash_log):
(RunTest.test_exit_after_n_failures_upload):
(RunTest.test_results_directory_absolute):
(RunTest.test_results_directory_relative):
(RunTest.test_retrying_and_flaky_tests):
(RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
(RunTest.test_retrying_uses_retries_directory):
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(RunTest.test_output_diffs):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_results):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
when we forced pixel tests in retry (i.e. pixel test was initially disabled).

2:01 PM Changeset in webkit [146816] by roger_fong@apple.com
  • 6 edits in trunk

Enable CSS_REGIONS and CSS_EXCLUSIONS and related tests.
​https://bugs.webkit.org/show_bug.cgi?id=87519

Reviewed by Timothy Horton.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • platform/win/TestExpectations:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

1:53 PM Changeset in webkit [146815] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebCore

Remove unused code from Frame class destructor
​https://bugs.webkit.org/show_bug.cgi?id=113181

Reviewed by Alexey Proskuryakov.

No new tests. No new functionality.

  • page/Frame.cpp:

(WebCore::Frame::~Frame):

Removed the code which could never have been executed
as m_view had been set to '0'.

1:41 PM Changeset in webkit [146814] by danakj@chromium.org
  • 21 edits in trunk/LayoutTests

Don't use video to trigger compositing for layout tests
​https://bugs.webkit.org/show_bug.cgi?id=113228

Reviewed by Adrienne Walker.

These tests used <video> to trigger compositing because a 3d identity
transform would have affected the overlap map differently. This is
no longer the case, so use translateZ(0) to trigger compositing instead,
which makes these tests more reliable and faster.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-opacity-transition.html:
  • compositing/geometry/limit-layer-bounds-overflow-repaint.html:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/scroll-partial-update.html:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
1:38 PM Changeset in webkit [146813] by Lucas Forschler
  • 1 edit
    2 copies in tags/Safari-537.35.1/LayoutTests

Merged r146685. <rdar://problem/13475726>

1:36 PM Changeset in webkit [146812] by Lucas Forschler
  • 8 edits in tags/Safari-537.35.1/Source

Merged r146679. <rdar://problem/13475726>

1:33 PM Changeset in webkit [146811] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146563. <rdar://problem/13435161>

1:30 PM Changeset in webkit [146810] by Lucas Forschler
  • 5 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146551. <rdar://problem/13355759>

1:28 PM Changeset in webkit [146809] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146542. <rdar://problem/13355808>

1:26 PM Changeset in webkit [146808] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Sheriffing.
​https://bugs.webkit.org/show_bug.cgi?id=112927
​https://bugs.webkit.org/show_bug.cgi?id=113067
​https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectation updates.

Removed crash expectations for fixed bug; added fail expectations for
results the bot won't give us; marked a test as slow.

  • platform/chromium/TestExpectations:
1:26 PM Changeset in webkit [146807] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146539. <rdar://problem/13355808>

1:23 PM Changeset in webkit [146806] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146373. <rdar://problem/13202277>

1:16 PM Changeset in webkit [146805] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect parsing due to hash collision
​https://bugs.webkit.org/show_bug.cgi?id=113235

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/tag-hash-collision.html

  • html/parser/HTMLIdentifier.cpp:

(WebCore::HTMLIdentifier::findIndex):

LayoutTests:

  • fast/parser/tag-hash-collision-expected.txt: Added.
  • fast/parser/tag-hash-collision.html: Added.
1:15 PM Changeset in webkit [146804] by eric.carlson@apple.com
  • 4 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Update three more tests that use "testRunner" instead of "layoutTestController".

  • fast/block/float/intruding-float-not-removed-writing-mode.xhtml:
  • mhtml/shared_buffer_bug.mht:
  • svg/custom/use-invalidate-click-crash.xhtml:
1:14 PM Changeset in webkit [146803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compile without SVG will fail
​https://bugs.webkit.org/show_bug.cgi?id=113234

Patch by Adenilson Cavalcanti <​cavalcantii@gmail.com> on 2013-03-25
Reviewed by Timothy Hatcher.

Only make the cast to SVGStyleElement if we have SVG support built.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

1:11 PM Changeset in webkit [146802] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
​https://bugs.webkit.org/show_bug.cgi?id=108438

Reviewed by Andreas Kling.

Remove the conditional code so it is turned on for all platforms.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allClientsRemoved):
(WebCore::CachedFont::reportMemoryUsage):

1:10 PM Changeset in webkit [146801] by eric.carlson@apple.com
  • 4 edits in trunk

REGRESSION(r146380): media/track/track-user-preferences.html
​https://bugs.webkit.org/show_bug.cgi?id=113083

Reviewed by Jer Noble.

Source/WebCore:

Ignore track change notifications triggered by automatic track selection so the
configuration is not changed.

No new tests, this fixes an existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all

track configuration is finished.

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange

is true.

LayoutTests:

  • platform/mac/TestExpectations: Remove test from expectations.
1:06 PM Changeset in webkit [146800] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Build the final piece of WebCore
​https://bugs.webkit.org/show_bug.cgi?id=113216

Reviewed by Nico Weber.

  • WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.
1:00 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:57 PM Changeset in webkit [146799] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WK2][GTK] MiniBrowser won't play video in <embed> tag
​https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Martin Robinson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

12:45 PM Changeset in webkit [146798] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Adding support for building WebCore rendering
​https://bugs.webkit.org/show_bug.cgi?id=113213

Reviewed by Gustavo Noronha Silva.

  • WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.
12:37 PM Changeset in webkit [146797] by jparent@chromium.org
  • 12 edits in trunk/Tools

Dashboard refactor: Move cross dashboard history related code into history.js.
​https://bugs.webkit.org/show_bug.cgi?id=113104

Reviewed by Ojan Vafai.

All functions relating to cross dashboard behavior move from being
globals to methods on the history.History object. Names stay the same,
except many are made private, ones that should have been constants now
are, and the long standing TODO to change "currentState" to
dashboardSpecificState is done.

We now create a global history object in dashboard_base, as an
intermediate measure. Once the dashboard specific code is
added to history, each DB will need to create its own, and this
global will be eliminated.

  • TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseDashboardSpecificParameters):
(defaultValue):
(currentBuilderGroupCategory):
(currentBuilderGroupName):
(handleLocationChange):
(expectationsMap):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(platformAndBuildType):
(individualTests):
(substringList):
(processMissingAndExtraExpectations):
(pathToFailureLog):
(showPopupForBuild):
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
(isCrossBuilderView):
(tableHeaders):
(htmlForSingleTestRow):
(htmlForTableColumnHeader):
(generatePageForExpectationsUpdate):
(handleUpdate):
(nextUpdate):
(setUpdateIndex):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(.appendExpectationsItem):
(loadExpectations):
(.dummyNode.onload):
(loadExpectationsLayoutTests):
(appendExpectations):
(htmlForNavBar):
(checkBoxToToggleState):
(linkHTMLToToggleState):
(generatePageForBuilder):
(isInvalidKeyForCrossBuilderView):
(handleQueryParameterChange):
(showLegend):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

  • TestResultServer/static-dashboards/history.js:

(.):

  • TestResultServer/static-dashboards/history_unittests.js:
  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):
(selectBuild):
(showResultsDelta):

  • TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleFocus):

  • TestResultServer/static-dashboards/ui.js:
12:16 PM Changeset in webkit [146796] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove TextIterator argumentless constructor
​https://bugs.webkit.org/show_bug.cgi?id=113226

Reviewed by Ryosuke Niwa.

The TextIterator argumentless constructors are never used and wouldn't be useful
since you can't specify a range.

No new tests, removing dead code. There should be no behavior change.

  • editing/TextIterator.cpp: Remove constructors.
  • editing/TextIterator.h:

(TextIterator):
(SimplifiedBackwardsTextIterator):
(CharacterIterator):
(BackwardsCharacterIterator):
(WordAwareIterator):

12:05 PM Changeset in webkit [146795] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Enabled canvas.getContext("webgl") on Desktop Chrome
​https://bugs.webkit.org/show_bug.cgi?id=113079

Patch by Brandon Jones <​bajones@chromium.org> on 2013-03-25
Reviewed by Dean Jackson.

Test: fast/canvas/webgl/webgl-unprefixed-context-id.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

11:51 AM Changeset in webkit [146794] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Windows rebaseline after r146779.

  • platform/win/css3/filters/effect-reference-expected.txt:
  • platform/win/css3/filters/effect-reference-hw-expected.txt:
11:43 AM Changeset in webkit [146793] by roger_fong@apple.com
  • 4 edits in trunk

Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
Enable WinEWS test again.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

11:40 AM Changeset in webkit [146792] by eric.carlson@apple.com
  • 2 edits in branches/safari-536.30-branch/LayoutTests

Merge r136586.

2012-12-04 Florin Malita <​fmalita@chromium.org>

Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

  • svg/custom/use-href-update-crash.svg:
11:36 AM Changeset in webkit [146791] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.1/Source

Versioning.

11:31 AM Changeset in webkit [146790] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.1

New Tag.

11:19 AM Changeset in webkit [146789] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] [gyp] Add support for building the platform directory
​https://bugs.webkit.org/show_bug.cgi?id=113212

Reviewed by Nico Weber.

  • WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including

two libraries, one for platform and one for geometry files. This follows the approach
of Chromium.

11:13 AM Changeset in webkit [146788] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223.

  • platform/mac/TestExpectations:
  • platform/mac/css3/filters/effect-reference-expected.png:
  • platform/mac/css3/filters/effect-reference-expected.txt:
  • platform/mac/css3/filters/effect-reference-hw-expected.png:
  • platform/mac/css3/filters/effect-reference-hw-expected.txt:
10:57 AM Changeset in webkit [146787] by jochen@chromium.org
  • 4 edits in trunk

Swap both the error and change event queue before processing fullscreen events
​https://bugs.webkit.org/show_bug.cgi?id=113194

Reviewed by Jer Noble.

Source/WebCore:

While processing the change events, not only new change events but
also new error events might get generated. However, for the timer, we
should only process preexisting events.

This is covered by fullscreen/full-screen-restrictions.html which times
out depending on the delay between requesting fullscreen and granting
fullscreen.

  • dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):

LayoutTests:

  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [146786] by zarvai@inf.u-szeged.hu
  • 215 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

  • platform/qt/fast/replaced/max-width-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-pxs-expected.png:
  • platform/qt/fast/replaced/maxwidth-percent-expected.png:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.png:
  • platform/qt/fast/replaced/minheight-percent-expected.png:
  • platform/qt/fast/replaced/minheight-pxs-expected.png:
  • platform/qt/fast/replaced/minwidth-percent-expected.png:
  • platform/qt/fast/replaced/minwidth-pxs-expected.png:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/width100percent-button-expected.png:
  • platform/qt/fast/ruby/ruby-inline-table-expected.png:
  • platform/qt/fast/runin/001-expected.png:
  • platform/qt/fast/runin/generated-expected.png:
  • platform/qt/fast/runin/runin-generated-before-content-expected.png:
  • platform/qt/fast/selectors/016-expected.png:
  • platform/qt/fast/selectors/017-expected.png:
  • platform/qt/fast/selectors/061-expected.png:
  • platform/qt/fast/selectors/062-expected.png:
  • platform/qt/fast/selectors/064-expected.png:
  • platform/qt/fast/table/003-expected.png:
  • platform/qt/fast/table/023-expected.png:
  • platform/qt/fast/table/027-vertical-expected.png:
  • platform/qt/fast/table/038-vertical-expected.png:
  • platform/qt/fast/table/040-expected.png:
  • platform/qt/fast/table/040-vertical-expected.png:
  • platform/qt/fast/table/100-percent-cell-width-expected.png:
  • platform/qt/fast/table/add-before-anonymous-child-expected.png:
  • platform/qt/fast/table/auto-100-percent-width-expected.png:
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.png:
  • platform/qt/fast/table/cell-absolute-child-expected.png:
  • platform/qt/fast/table/click-near-anonymous-table-expected.png:
  • platform/qt/fast/table/empty-cells-expected.png:
  • platform/qt/fast/table/empty-table-percent-height-expected.png:
  • platform/qt/fast/table/fixed-granular-cols-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-expected.png:
  • platform/qt/fast/table/generated-caption-expected.png:
  • platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
  • platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
  • platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
  • platform/qt/fast/table/row-height-recalc-expected.png:
  • platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/qt/fast/table/stale-grid-crash-expected.png:
  • platform/qt/fast/table/table-and-parts-outline-expected.png:
  • platform/qt/fast/table/table-display-types-vertical-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/unused-percent-heights-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.png:
  • platform/qt/fast/text/basic/001-expected.png:
  • platform/qt/fast/text/basic/002-expected.png:
  • platform/qt/fast/text/basic/004-expected.png:
  • platform/qt/fast/text/basic/008-expected.png:
  • platform/qt/fast/text/basic/009-expected.png:
  • platform/qt/fast/text/basic/011-expected.png:
  • platform/qt/fast/text/basic/012-expected.png:
  • platform/qt/fast/text/basic/generic-family-changes-expected.png:
  • platform/qt/fast/text/basic/generic-family-reset-expected.png:
  • platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.png:
  • platform/qt/fast/text/fake-italic-expected.png:
  • platform/qt/fast/text/fallback-traits-fixup-expected.png:
  • platform/qt/fast/text/firstline/001-expected.png:
  • platform/qt/fast/text/font-initial-expected.png:
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/qt/fast/text/international/arabic-justify-expected.png:
  • platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/qt/fast/text/international/hindi-whitespace-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/justified-selection-at-edge-expected.png:
  • platform/qt/fast/text/justified-selection-expected.png:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png:
  • platform/qt/fast/text/shadow-no-blur-expected.png:
  • platform/qt/fast/text/shadow-translucent-fill-expected.png:
  • platform/qt/fast/text/softHyphen-expected.png:
  • platform/qt/fast/text/unicode-variation-selector-expected.png:
  • platform/qt/fast/text/wbr-in-pre-crash-expected.png:
  • platform/qt/fast/text/wbr-styled-expected.png:
  • platform/qt/fast/text/whitespace/002-expected.png:
  • platform/qt/fast/text/whitespace/020-expected.png:
  • platform/qt/fast/text/whitespace/021-expected.png:
  • platform/qt/fast/text/whitespace/022-expected.png:
  • platform/qt/fast/text/whitespace/025-expected.png:
  • platform/qt/fast/text/whitespace/027-expected.png:
  • platform/qt/fast/text/whitespace/030-expected.png:
  • platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/qt/fast/text/word-break-expected.png:
  • platform/qt/fast/text/zero-font-size-expected.png:
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
  • platform/qt/fast/transforms/diamond-expected.png:
  • platform/qt/fast/transforms/matrix-01-expected.png:
  • platform/qt/fast/transforms/matrix-02-expected.png:
  • platform/qt/fast/transforms/overflow-with-transform-expected.png:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
  • platform/qt/fast/transforms/transform-on-inline-expected.png:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/qt/fast/transforms/transformed-document-element-expected.png:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.png:
  • platform/qt/fast/writing-mode/block-level-images-expected.png:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/english-bt-text-expected.png:
  • platform/qt/fast/writing-mode/english-rl-text-expected.png:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
  • platform/qt/fast/xsl/document-function-expected.png:
  • platform/qt/fonts/cursive-expected.png:
  • platform/qt/fonts/default-expected.png:
  • platform/qt/fonts/fantasy-expected.png:
  • platform/qt/fonts/monospace-expected.png:
  • platform/qt/fonts/sans-serif-expected.png:
  • platform/qt/fonts/serif-expected.png:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png:
  • platform/qt/http/tests/misc/iframe404-expected.png:
  • platform/qt/http/tests/navigation/postredirect-basic-expected.png:
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.png:
  • platform/qt/http/tests/uri/css-href-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.png:
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
  • platform/qt/printing/return-from-printing-mode-expected.png:
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/qt/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/qt/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
9:49 AM Changeset in webkit [146785] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
​https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-25
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters for a
small amount of frequently used functions / functions used by Dromaeo.

Added tests to TestObj.idl and updated bindings tests.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethod):
(WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • page/DOMWindow.idl:
9:47 AM Changeset in webkit [146784] by dcheng@chromium.org
  • 3 edits
    1 add in trunk

Don't allow drags to start after a mouse press that creates a context menu
​https://bugs.webkit.org/show_bug.cgi?id=112079

Reviewed by Tony Chang.

.:

  • ManualTests/context-menu-during-drag-selection.html: Added.

Source/WebCore:

This appears to be the intent of the original code anyway (the comments in the corresponding
context menu handlers indicate that they set m_mousePressed to false in order to suppress
drags from starting). Since exact platform behavior differs quite a bit in this area, this
will also make the behavior more consistent across different WebKit implementations.

Manually testable using context-menu-during-drag-selection.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):

9:36 AM Changeset in webkit [146783] by pdr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] Rebaseline svg/custom/marker-orient-auto

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux-x86/svg/custom/marker-orient-auto-expected.png: Added.
  • platform/chromium/TestExpectations:
9:29 AM Changeset in webkit [146782] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
​https://bugs.webkit.org/show_bug.cgi?id=113210

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
9:28 AM Changeset in webkit [146781] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: Remove console warnings for *_ prefixed CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=113175

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Source/WebCore:

Added separate error message for syntax CSS error in declaration list when no property detected.
Added filter for messages starting with '*'.

  • css/CSSGrammar.y.in:

LayoutTests:

  • inspector/console/console-css-warnings-expected.txt:
  • inspector/console/console-css-warnings.html:
9:16 AM Changeset in webkit [146780] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Triage more test failures on content_shell

Unreviewed gardening.

  • platform/chromium/ContentShellTestExpectations:
9:10 AM Changeset in webkit [146779] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk

Integration of the Skia displacement mapping into WebKit
​https://bugs.webkit.org/show_bug.cgi?id=112927

Patch by Alexis Hetu <​sugoi@chromium.org> on 2013-03-25
Reviewed by Stephen White.

Added displacement mapping to effect-reference.html and
effect-reference-hw.html

  • WebCore.gypi:
  • platform/graphics/filters/FEDisplacementMap.h:

(FEDisplacementMap):
Adding Skia specific declarations

  • platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
Provides conversion between the WebKit displacement mapping mode and
the Skia displacement mapping mode
(WebCore::FEDisplacementMap::platformApplySkia):
Displacement through the Skia API. (Accelerated only for now)
(WebCore::FEDisplacementMap::createImageFilter):
Displacement image filter creation through the Skia API.

9:05 AM Changeset in webkit [146778] by dominik.rottsches@intel.com
  • 3 edits
    2 deletes in trunk/Tools

[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
​https://bugs.webkit.org/show_bug.cgi?id=112166

HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.

Reviewed by Martin Robinson.

  • efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
  • efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
  • gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
  • gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
9:01 AM Changeset in webkit [146777] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Graduate some new Inspector APIs to public
​https://bugs.webkit.org/show_bug.cgi?id=113176

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Summary of changes:

DOM.highlightNode.nodeId: required parameter is now optional
Input: domain has been added
Runtime.enable: command has been added
Runtime.executionContextCreated: event has been added
Page.clearGeolocationOverride: command has been added
Page.setGeolocationOverride: command has been added
Page.captureScreenshot: command has been added
Debugger.setBreakpointByUrl.locations: optional response parameter is now required

  • inspector/Inspector.json:
8:56 AM Changeset in webkit [146776] by kadam@inf.u-szeged.hu
  • 341 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results.

  • platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
  • platform/qt/css3/unicode-bidi-isolate-basic-expected.png:
8:34 AM Changeset in webkit [146775] by kadam@inf.u-szeged.hu
  • 198 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png resutls after r146206.

  • platform/qt/css3/compositing/effect-background-blend-mode-expected.png: Added.
  • platform/qt/css3/css3-modsel-33-expected.png:
  • platform/qt/css3/css3-modsel-35-expected.png:
  • platform/qt/css3/css3-modsel-36-expected.png:
  • platform/qt/css3/css3-modsel-37-expected.png:
  • platform/qt/css3/filters/custom/custom-filter-color-matrix-expected.png: Added.
  • platform/qt/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
  • platform/qt/css3/filters/effect-invert-hw-expected.png:
  • platform/qt/css3/filters/filter-repaint-child-layers-expected.png: Added.
  • platform/qt/css3/filters/nested-filter-expected.png:
  • platform/qt/css3/filters/regions-expanding-expected.png:
  • platform/qt/css3/flexbox/flexbox-baseline-expected.png:
  • platform/qt/css3/images/cross-fade-background-size-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:
8:25 AM Changeset in webkit [146774] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
<​http://webkit.org/b/113170>

Reviewed by Dan Bernstein.

Fixes the following build failure:

/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]

int pos = (size - 1) >> 1;

~ ~~

1 error generated.

  • wtf/StdLibExtras.h:

(WTF::binarySearchImpl): Switch type from int to size_t.

8:09 AM Changeset in webkit [146773] by kadam@inf.u-szeged.hu
  • 123 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results r146206.

  • platform/qt-5.0-wk2/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
  • platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
  • platform/qt/css2.1/20110323/border-conflict-style-088-expected.png:
  • platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png:
  • platform/qt/css2.1/20110323/empty-inline-003-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
  • platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
  • platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
  • platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
  • platform/qt/css2.1/20110323/margin-applies-to-010-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/css2.1/20110323/table-caption-002-expected.png:
  • platform/qt/css2.1/20110323/table-caption-optional-001-expected.png:
  • platform/qt/css2.1/20110323/table-caption-optional-002-expected.png:
  • platform/qt/css2.1/20110323/table-height-algorithm-023-expected.png:
  • platform/qt/css2.1/20110323/table-height-algorithm-024-expected.png:
  • platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
  • platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
  • platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
  • platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/qt/css2.1/t1202-counters-08-b-expected.png:
  • platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
7:50 AM Changeset in webkit [146772] by kadam@inf.u-szeged.hu
  • 68 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png results after r146206.

  • platform/qt/css1/basic/class_as_selector-expected.png:
  • platform/qt/css1/basic/comments-expected.png:
  • platform/qt/css1/basic/contextual_selectors-expected.png:
  • platform/qt/css1/basic/grouping-expected.png:
  • platform/qt/css1/basic/id_as_selector-expected.png:
  • platform/qt/css1/box_properties/acid_test-expected.png:
  • platform/qt/css1/box_properties/border_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width-expected.png:
  • platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_color-expected.png:
  • platform/qt/css1/box_properties/border_color_inline-expected.png:
  • platform/qt/css1/box_properties/border_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_inline-expected.png:
  • platform/qt/css1/box_properties/border_left_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_right-expected.png:
  • platform/qt/css1/box_properties/border_right_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_style_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_inline-expected.png:
  • platform/qt/css1/box_properties/border_top_width-expected.png:
  • platform/qt/css1/box_properties/border_top_width_inline-expected.png:
  • platform/qt/css1/box_properties/border_width-expected.png:
  • platform/qt/css1/box_properties/border_width_inline-expected.png:
  • platform/qt/css1/box_properties/clear-expected.png:
  • platform/qt/css1/box_properties/float-expected.png:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.png:
  • platform/qt/css1/box_properties/height-expected.png:
  • platform/qt/css1/box_properties/margin-expected.png:
  • platform/qt/css1/box_properties/margin_bottom-expected.png:
  • platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
  • platform/qt/css1/box_properties/margin_left_inline-expected.png:
  • platform/qt/css1/box_properties/margin_right_inline-expected.png:
  • platform/qt/css1/box_properties/margin_top-expected.png:
  • platform/qt/css1/box_properties/margin_top_inline-expected.png:
  • platform/qt/css1/box_properties/padding-expected.png:
  • platform/qt/css1/box_properties/padding_left_inline-expected.png:
  • platform/qt/css1/box_properties/padding_right_inline-expected.png:
  • platform/qt/css1/box_properties/padding_top-expected.png:
  • platform/qt/css1/box_properties/padding_top_inline-expected.png:
  • platform/qt/css1/box_properties/width-expected.png:
  • platform/qt/css1/classification/list_style-expected.png:
  • platform/qt/css1/classification/list_style_image-expected.png:
  • platform/qt/css1/classification/list_style_position-expected.png:
  • platform/qt/css1/classification/list_style_type-expected.png:
  • platform/qt/css1/classification/white_space-expected.png:
  • platform/qt/css1/color_and_background/background-expected.png:
  • platform/qt/css1/color_and_background/background_attachment-expected.png:
  • platform/qt/css1/color_and_background/background_color-expected.png:
  • platform/qt/css1/color_and_background/background_image-expected.png:
  • platform/qt/css1/color_and_background/color-expected.png:
  • platform/qt/css1/font_properties/font_family-expected.png:
  • platform/qt/css1/font_properties/font_size-expected.png:
  • platform/qt/css1/font_properties/font_style-expected.png:
  • platform/qt/css1/font_properties/font_variant-expected.png:
  • platform/qt/css1/font_properties/font_weight-expected.png:
  • platform/qt/css1/formatting_model/canvas-expected.png:
  • platform/qt/css1/formatting_model/floating_elements-expected.png:
  • platform/qt/css1/formatting_model/height_of_lines-expected.png:
  • platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/qt/css1/formatting_model/replaced_elements-expected.png:
  • platform/qt/css1/text_properties/letter_spacing-expected.png:
  • platform/qt/css1/text_properties/line_height-expected.png:
  • platform/qt/css1/text_properties/text_align-expected.png:
  • platform/qt/css1/text_properties/vertical_align-expected.png:
  • platform/qt/css1/text_properties/word_spacing-expected.png:
  • platform/qt/css1/units/color_units-expected.png:
  • platform/qt/css1/units/length_units-expected.png:
  • platform/qt/css1/units/percentage_units-expected.png:
7:42 AM Changeset in webkit [146771] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: [Timeline] set glue records mode off by default
​https://bugs.webkit.org/show_bug.cgi?id=113189

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/

LayoutTests:

  • inspector/timeline/timeline-receive-response-event.html: enable glue records mode for the test.
7:29 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
Removing Amazon bot after its shutdown. (diff)
7:27 AM Changeset in webkit [146770] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

[EFL] Fix build break when media source is enabled
​https://bugs.webkit.org/show_bug.cgi?id=113143

Unreviewed. Build error needs to be fixed in order to start to implement
media source functionality.

  • CMakeLists.txt:
  • platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

7:26 AM Changeset in webkit [146769] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
​https://bugs.webkit.org/show_bug.cgi?id=113188

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

7:23 AM Changeset in webkit [146768] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=113182

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

6:56 AM Changeset in webkit [146767] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Fonts refactoring
​https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

  • inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

  • inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):

  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(select.tabbed-pane-header-tabs-drop-down-select):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

  • src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

6:54 AM Changeset in webkit [146766] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Qml WebKit needs preferences to change security knobs
​https://bugs.webkit.org/show_bug.cgi?id=111979

Patch by Maxim Ermilov <​maxim.ermilov@canonical.com> on 2013-03-25
Reviewed by Jocelyn Turcotte.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::universalAccessFromFileURLsAllowed):
(QWebPreferences::setUniversalAccessFromFileURLsAllowed):
(QWebPreferences::fileAccessFromFileURLsAllowed):
(QWebPreferences::setFileAccessFromFileURLsAllowed):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
6:52 AM Changeset in webkit [146765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
​https://bugs.webkit.org/show_bug.cgi?id=113148

Added --show-changes command line option.
Used existing compare_schemas method to do a reverse compare.
Fixed a number of small problems (missing domain name in the message,
incorrect error messages for command parameters).

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

  • inspector/generate-inspector-protocol-version:

(named_list_to_map):
(removed):
(required):
(compare_schemas):
(compare_domains):
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):
(self_test.create_test_schema_1):
(self_test.create_test_schema_2):
(self_test.is_subset):
(self_test.errors_match):
(main):

6:42 AM Changeset in webkit [146764] by alecflett@chromium.org
  • 17 edits
    9 adds in trunk

Support Quota API in Workers
​https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/workers/shared-worker-storagequota-query-usage.html

fast/workers/worker-storagequota-query-usage.html

  • Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
  • Modules/quota/WorkerNavigatorStorageQuota.h: Added.
  • Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
  • WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
  • page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.

LayoutTests:

  • fast/workers/resources/shared-worker-common.js:

(handleMessage): Allow port to be dynamically discovered from self.

  • fast/workers/resources/storagequota-query-usage.js: Added.

(worker.onmessage):

  • fast/workers/resources/worker-storagequota-query-usage.js: Added.

(requestUsage.errorCallback):
(requestUsage.usageCallback):
(requestUsage):

  • fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
  • fast/workers/shared-worker-storagequota-query-usage.html: Added.
  • fast/workers/worker-storagequota-query-usage-expected.txt: Added.
  • fast/workers/worker-storagequota-query-usage.html: Added.
6:39 AM Changeset in webkit [146763] by mkwst@chromium.org
  • 15 edits in trunk

CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
​https://bugs.webkit.org/show_bug.cgi?id=113033

Reviewed by Jochen Eisinger.

Source/WebCore:

Bringing our experimental implementation into line with the spec, which
has landed on the de facto standard name Gecko has been sending out for
years and years.

Spec: ​https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
Thread: ​http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html

  • dom/SecurityPolicyViolationEvent.h:

(SecurityPolicyViolationEventInit):
(WebCore::SecurityPolicyViolationEvent::sourceFile):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
(SecurityPolicyViolationEvent):

  • dom/SecurityPolicyViolationEvent.idl:
  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

s/sourceURL/sourceFile/

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
6:10 AM Changeset in webkit [146762] by Michelangelo De Simone
  • 8 edits
    20 adds in trunk

[CSS Filters] Using negative drop-shadow radius values has slow performance
​https://bugs.webkit.org/show_bug.cgi?id=107848

Source/WebCore:

Setting negative blur radius values in drop-shadow() and box-shadow() led to
significant rendering performance loss. The invalid value overflowed and the
embedder became unresponsive for few seconds.
This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).

Reviewed by Dirk Schulze.

Tests: css3/filters/effect-drop-shadow-negative-radius.html

fast/box-shadow/box-shadow-parsing-invalid.html
svg/filters/feDropShadow-negative-deviation-expected.svg
svg/filters/feDropShadow-negative-deviation.svg
svg/filters/feDropShadow-zero-deviation.svg
svg/filters/feGaussianBlur-negative-deviation-expected.svg
svg/filters/feGaussianBlur-negative-deviation.svg
svg/filters/feGaussianBlur-zero-deviation.svg

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
CSS Background and Borders specs, negative values shall not be allowed.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
negative deviations.

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
created with wrong and potentially overflowing values.

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build): Ditto.

LayoutTests:

Added a whole set of new tests for both CSS and SVG to assess the correctness of
blur(), drop-shadow() and box-shadow() blur radius values.

Reviewed by Dirk Schulze.

  • css3/filters/effect-drop-shadow-negative-radius-expected.html: Added.
  • css3/filters/effect-drop-shadow-negative-radius.html: Added.
  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:
  • fast/box-shadow/box-shadow-parsing-invalid-expected.txt: Added.
  • fast/box-shadow/box-shadow-parsing-invalid.html: Added.
  • fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: Added.

(testInvalidFilterRule):

  • platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • svg/filters/feDropShadow-negative-deviation-expected.svg: Added.
  • svg/filters/feDropShadow-negative-deviation.svg: Added.
  • svg/filters/feDropShadow-zero-deviation.svg: Added.
  • svg/filters/feGaussianBlur-negative-deviation-expected.svg: Added.
  • svg/filters/feGaussianBlur-negative-deviation.svg: Added.
  • svg/filters/feGaussianBlur-zero-deviation.svg: Added.
6:06 AM Changeset in webkit [146761] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
​https://bugs.webkit.org/show_bug.cgi?id=113179

Reviewed by Jocelyn Turcotte.

Test if range.start is within the valid range before testing the value at that point.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

5:55 AM Changeset in webkit [146760] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Properly handle the rule addition to an XML or SVG document.
​https://bugs.webkit.org/show_bug.cgi?id=113185

Reviewed by Pavel Feldman.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

5:38 AM Changeset in webkit [146759] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Web Inspector: support changing local variables in frontend
​https://bugs.webkit.org/show_bug.cgi?id=112470

Patch by Peter Rybin <​prybin@chromium.org> on 2013-03-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.

Test: inspector/debugger/debugger-change-variable.html

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.CallFrame.prototype.get id):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromScopePayload):
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.setVariableValueCallback):
(WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
(WebInspector.ScopeRef):

  • inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

LayoutTests:

  • inspector/debugger/debugger-change-variable-expected.txt: Added.
  • inspector/debugger/debugger-change-variable.html: Added.
  • platform/chromium/inspector/debugger/debugger-change-variable-expected.txt: Added.
5:20 AM Changeset in webkit [146758] by mkwst@chromium.org
  • 5 edits
    3 copies
    8 adds in trunk

CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
​https://bugs.webkit.org/show_bug.cgi?id=113039

Reviewed by Jochen Eisinger.

Source/WebCore:

I'd originally assumed that we didn't need to be quite so careful when
handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
a mistake. Cross-origin URLs aren't accessible to JavaScript currently
and there's no reason that we should begin exposing them via an event.

This patch extracts the stripping logic from the existing reports into
stripURLForUseInReport(), and uses that new method when populating the
event and report objects.

Relatedly, we were doing the wrong thing with 'file:' URLs, which this
patch made clear. Now they're treated the same as 'data:' et al.

Spec: ​https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::stripURLForUseInReport):

Extract the logic from blockedURI out into a reusable method:
cross-origin URLs are stripped down to the ASCII serialization of
their origin, and non-heirarchical (and 'file:') URLs are stripped
down to the ASCII serialization of their protocol.

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

Use ::stripURLForUseInReport for blockedURL and sourceFile
attributes in these two methods.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html: Added.
  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
  • http/tests/security/contentSecurityPolicy/resources/securitypolicyviolation-test.js: Added.

Updating tests to cover cross-origin scenarios: load cross-origin
images, and cross-origin scripts that inject images. The former
should strip the image URL down to the origin, the latter the
script URL.

  • http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.

This patch changes the behavior of 'file:' URLs to behave similarly
to 'data:'/'blob:', etc. We weren't previously testing this, now we
are. We need platform-specific results for Chromium and GTK, since
those ports have enabled CSP_NEXT, which adds a field to the report.

4:35 AM Changeset in webkit [146757] by eustas@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Fix JSDocs.
​https://bugs.webkit.org/show_bug.cgi?id=113025

Reviewed by Pavel Feldman.

Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.

  • inspector/InjectedScriptSource.js: Fix JSDocs.
  • inspector/front-end/ConsoleModel.js: Ditto.
  • inspector/front-end/CookieParser.js: Ditto.
  • inspector/front-end/FileContentView.js: Ditto.
  • inspector/front-end/HeapSnapshotView.js: Ditto.
  • inspector/front-end/IndexedDBModel.js: Ditto.
  • inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
  • inspector/front-end/utilities.js: Ditto.
4:30 AM Changeset in webkit [146756] by zarvai@inf.u-szeged.hu
  • 196 edits
    1 copy
    14 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Making pixel test bot happier after r146206.

  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.png:
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/frameset-style-recalc-expected.png:
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/qt/fast/frames/iframe-with-frameborder-expected.png:
  • platform/qt/fast/frames/viewsource-attribute-expected.png:
  • platform/qt/fast/gradients/background-clipped-expected.png:
  • platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.png:
  • platform/qt/fast/gradients/radial-centered-expected.png:
  • platform/qt/fast/html/details-nested-1-expected.png:
  • platform/qt/fast/html/details-nested-2-expected.png:
  • platform/qt/fast/html/details-writing-mode-expected.png:
  • platform/qt/fast/html/font-weight-bold-for-b-and-strong-expected.png:
  • platform/qt/fast/html/link-rel-stylesheet-expected.png:
  • platform/qt/fast/html/listing-expected.png:
  • platform/qt/fast/html/marquee-scroll-expected.png:
  • platform/qt/fast/html/marquee-scrollamount-expected.png:
  • platform/qt/fast/images/image-map-anchor-children-expected.png:
  • platform/qt/fast/images/imagemap-circle-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
  • platform/qt/fast/images/imagemap-polygon-focus-ring-expected.png:
  • platform/qt/fast/inline-block/001-expected.png:
  • platform/qt/fast/inline-block/002-expected.png:
  • platform/qt/fast/inline-block/003-expected.png:
  • platform/qt/fast/inline-block/006-expected.png:
  • platform/qt/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/qt/fast/inline-block/contenteditable-baseline-expected.png:
  • platform/qt/fast/inline-block/tricky-baseline-expected.png:
  • platform/qt/fast/inline/25277-2-expected.png:
  • platform/qt/fast/inline/25277-expected.png:
  • platform/qt/fast/inline/continuation-outlines-with-layers-2-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/qt/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/qt/fast/inline/inline-continuation-borders-expected.png:
  • platform/qt/fast/inline/inline-focus-ring-expected.png:
  • platform/qt/fast/inline/inline-text-quirk-bpm-expected.png:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/qt/fast/inline/long-wrapped-line-expected.png:
  • platform/qt/fast/inline/nested-top-alignment-expected.png:
  • platform/qt/fast/inline/vertical-align-text-bottom-expected.png:
  • platform/qt/fast/invalid/003-expected.png:
  • platform/qt/fast/invalid/004-expected.png:
  • platform/qt/fast/invalid/010-expected.png:
  • platform/qt/fast/invalid/014-expected.png:
  • platform/qt/fast/invalid/016-expected.png:
  • platform/qt/fast/invalid/019-expected.png:
  • platform/qt/fast/invalid/021-expected.png:
  • platform/qt/fast/invalid/missing-address-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-dl-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-dt-end-tag-expected.png:
  • platform/qt/fast/invalid/missing-font-end-tag-expected.png:
  • platform/qt/fast/invalid/nestedh3s-expected.png:
  • platform/qt/fast/invalid/td-inside-object-expected.png:
  • platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
  • platform/qt/fast/layers/opacity-transforms-expected.png:
  • platform/qt/fast/layers/remove-only-this-layer-update-expected.png:
  • platform/qt/fast/line-grid/line-align-left-edges-expected.png:
  • platform/qt/fast/line-grid/line-align-right-edges-expected.png:
  • platform/qt/fast/line-grid/line-grid-floating-expected.png:
  • platform/qt/fast/line-grid/line-grid-into-floats-expected.png:
  • platform/qt/fast/line-grid/line-grid-positioned-expected.png:
  • platform/qt/fast/lists/001-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/002-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/007-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/008-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/anonymous-items-expected.png:
  • platform/qt/fast/lists/big-list-marker-expected.png:
  • platform/qt/fast/lists/li-br-expected.png:
  • platform/qt/fast/lists/li-style-alpha-huge-value-crash-expected.png:
  • platform/qt/fast/lists/list-item-line-height-expected.png:
  • platform/qt/fast/lists/list-style-none-crash-expected.png:
  • platform/qt/fast/lists/ol-display-types-expected.png:
  • platform/qt/fast/lists/ol-start-parsing-expected.png:
  • platform/qt/fast/lists/olstart-expected.png:
  • platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png:
  • platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
  • platform/qt/fast/multicol/block-axis-vertical-lr-expected.png:
  • platform/qt/fast/multicol/block-axis-vertical-rl-expected.png:
  • platform/qt/fast/multicol/client-rects-expected.png:
  • platform/qt/fast/multicol/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/float-avoidance-expected.png:
  • platform/qt/fast/multicol/float-paginate-complex-expected.png:
  • platform/qt/fast/multicol/float-paginate-expected.png:
  • platform/qt/fast/multicol/layers-in-multicol-expected.png:
  • platform/qt/fast/multicol/margin-collapse-expected.png:
  • platform/qt/fast/multicol/max-height-columns-block-expected.png:
  • platform/qt/fast/multicol/overflow-across-columns-expected.png:
  • platform/qt/fast/multicol/overflow-unsplittable-expected.png:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png:
  • platform/qt/fast/multicol/positioned-split-expected.png:
  • platform/qt/fast/multicol/positive-leading-expected.png:
  • platform/qt/fast/multicol/progression-reverse-expected.png:
  • platform/qt/fast/multicol/shadow-breaking-expected.png:
  • platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
  • platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/qt/fast/multicol/table-margin-collapse-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/qt/fast/overflow/001-expected.png:
  • platform/qt/fast/overflow/002-expected.png:
  • platform/qt/fast/overflow/003-expected.png:
  • platform/qt/fast/overflow/004-expected.png:
  • platform/qt/fast/overflow/007-expected.png:
  • platform/qt/fast/overflow/008-expected.png:
  • platform/qt/fast/overflow/dynamic-hidden-expected.png:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.png:
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png:
  • platform/qt/fast/overflow/line-clamp-expected.png:
  • platform/qt/fast/overflow/overflow-auto-table-expected.png:
  • platform/qt/fast/overflow/overflow-float-stacking-expected.png:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-stacking-expected.png:
  • platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.png:
  • platform/qt/fast/overflow/table-overflow-float-expected.png:
  • platform/qt/fast/overflow/trailing-float-linebox-expected.png:
  • platform/qt/fast/parser/001-expected.png:
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/qt/fast/parser/entity-comment-in-style-expected.png:
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png:
  • platform/qt/fast/parser/open-comment-in-style-expected.png:
  • platform/qt/fast/reflections/inline-crash-expected.png:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/qt/fast/reflections/reflection-masks-expected.png:
  • platform/qt/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/qt/fast/reflections/reflection-masks-outset-expected.png:
  • platform/qt/fast/reflections/reflection-nesting-expected.png:
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.png:
  • platform/qt/fast/regions/flow-content-basic-expected.png:
  • platform/qt/fast/regions/flow-content-basic-vertical-expected.png:
  • platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png:
  • platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png:
  • platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
  • platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
  • platform/qt/fast/regions/region-style-block-background-color-expected.png:
  • platform/qt/fast/regions/region-style-block-background-color2-expected.png:
  • platform/qt/fast/regions/text-region-split-small-pagination-expected.png:
  • platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
  • platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
  • platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
  • platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png:
  • platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
  • platform/qt/fast/repaint/background-misaligned-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/focus-layers-expected.png:
  • platform/qt/fast/repaint/scale-page-shrink-expected.png:
  • platform/qt/fast/repaint/transform-absolute-child-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-relative-position-expected.png:
  • platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/qt/fast/replaced/004-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/applet-display-none-expected.png:
  • platform/qt/fast/replaced/image-resize-width-expected.png:
4:05 AM Changeset in webkit [146755] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
​https://bugs.webkit.org/show_bug.cgi?id=112784

Reviewed by Jochen Eisinger.

Just cleanup of three tiny nits I ran across in
ContentSecurityPolicy::reportViolation while doing other work.

  • 'directiveText' and 'effectiveDirective' can't be empty; we pass in values at every callsite. We can safely remove the 'isEmpty()' checks. Moreover, even if they could possibly somehow be empty, we should still include those empty strings in the report, rather than dropping the values entirely.
  • We don't need to hold 'document->referrer()' in a temp variable.
  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

3:55 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
(diff)
3:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:26 AM Changeset in webkit [146754] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.
​https://bugs.webkit.org/show_bug.cgi?id=113036

Patch by Dominique Leuenberger <​dimstar@opensuse.org> on 2013-03-25
Reviewed by Martin Robinson.

  • UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):

2:50 AM Changeset in webkit [146753] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
​https://bugs.webkit.org/show_bug.cgi?id=113032

Reviewed by Pavel Feldman.

To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.

This feature is hard to discover.

Setting "move" cursor will make this feature more discoverable.

  • inspector/front-end/inspectorCommon.css:

Set "move" cursor to draggable area.

  • inspector/front-end/OverviewGrid.js: Ditto.
2:33 AM Changeset in webkit [146752] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Profiles] Remove unused private member.
​https://bugs.webkit.org/show_bug.cgi?id=113015

Reviewed by Pavel Feldman.

_profileGroupsForLinks is not used anymore.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.

2:33 AM Changeset in webkit [146751] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardneing. Skip two tests, because they are failing with timed out.

  • platform/qt/TestExpectations:
2:01 AM Changeset in webkit [146750] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

Mark fast/css/font-family-pictograph.html as flaky on Linux

  • platform/chromium/TestExpectations:
1:55 AM Changeset in webkit [146749] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Exception when turning on pretty print without any displayed source in the editor
​https://bugs.webkit.org/show_bug.cgi?id=113136

Patch by PhistucK <​phistuck@chromium.org> on 2013-03-25
Reviewed by Vsevolod Vlasov.

No new tests.
Added a check for the existence of currently edited document.

  • inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

1:47 AM Changeset in webkit [146748] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions] Remove RenderRegion::printRegionObjectsStyles
​https://bugs.webkit.org/show_bug.cgi?id=113081

Reviewed by Tony Chang.

No change in functionality, remove unused function..

  • rendering/RenderRegion.h:
1:45 AM Changeset in webkit [146747] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Memory leak when closing a tab
​https://bugs.webkit.org/show_bug.cgi?id=112127

Patch by Hurnjoo Lee <​hurnjoo.lee@samsung.com> on 2013-03-25
Reviewed by Noam Rosenthal.

When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
render queue, the scene is not freed because reference count of m_scene is not zero.

No new tests.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
the reference count of m_scene is increasing, if m_renderQueue is not empty
before closing tab, then m_scene is never freed.
Hence, when closing tab, need to clear m_renderQueue explicitly in order to
destroy m_scene.

1:21 AM Changeset in webkit [146746] by keishi@webkit.org
  • 3 edits
    10 adds in trunk

Clear button visibility is not updated when restoring form state
​https://bugs.webkit.org/show_bug.cgi?id=113172

Source/WebCore:

Clear button wasn't showing up when restoring form state.

Reviewed by Kent Tamura.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html

fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):

LayoutTests:

Reviewed by Kent Tamura.

  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Added.
12:45 AM Changeset in webkit [146745] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Use registry to track settings objects.
​https://bugs.webkit.org/show_bug.cgi?id=113008

Reviewed by Pavel Feldman.

Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.

To resolve this issue we can use registry to make .createSetting return
same object for specific key.

  • inspector/front-end/Settings.js:

(WebInspector.Settings.prototype.createSetting): Use registry.

Mar 24, 2013:

9:58 PM Changeset in webkit [146744] by falken@chromium.org
  • 9 edits in trunk/Source/WebCore

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
​https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

  • dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

  • dom/Element.h:

(Element):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

  • dom/Node.h:

(Node):

9:27 PM Changeset in webkit [146743] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

Start generating test images on the bots now that libwebp 0.3.0
has landed in chromium webkit.

  • platform/chromium/TestExpectations:
8:55 PM Changeset in webkit [146742] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/text/international/danda-space.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
7:15 PM Changeset in webkit [146741] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146740 - [l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

  • pl.po: updated translation.
7:14 PM Changeset in webkit [146740] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

  • pl.po: updated translation.
6:57 PM Changeset in webkit [146739] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium deps to 190311.
​https://bugs.webkit.org/show_bug.cgi?id=113161

Unreviewed, rolling deps.

  • DEPS:
5:38 PM Changeset in webkit [146738] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Shadow] Add a test of insertionParent for <shadow> element.
​https://bugs.webkit.org/show_bug.cgi?id=113021

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/insertion-parent-shadow-expected.txt: Added.
  • fast/dom/shadow/insertion-parent-shadow.html: Added.
5:36 PM Changeset in webkit [146737] by hclam@chromium.org
  • 4 edits in trunk/Source

GIFImageReader should reports parsing error to client
​https://bugs.webkit.org/show_bug.cgi?id=113141

Reviewed by Stephen White.

Source/WebCore:

GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.

Unit test is updated to reflect change in behavior.
Tested with a local corpus which showed better handling of corrupted GIF images.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

Source/WebKit/chromium:

Updated unit test that runs on a broken GIF image file, decoding should fail.

  • tests/GIFImageDecoderTest.cpp:

(WebKit::TEST):

4:37 PM Changeset in webkit [146736] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Wire windows scrollByPage enum up to compositor thread input handling
​https://bugs.webkit.org/show_bug.cgi?id=113117

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):

4:15 PM Changeset in webkit [146735] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190276. Requested by
"Dana Jansens" <​danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-24

  • DEPS:
3:45 PM Changeset in webkit [146734] by mhahnenberg@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

HandleSet should use HeapBlocks for storing handles
​https://bugs.webkit.org/show_bug.cgi?id=113145

Reviewed by Geoffrey Garen.

  • GNUmakefile.list.am: Build project changes.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • heap/BlockAllocator.cpp: Rename the RegionSet to m_fourKBBlockRegionSet because there are

too many block types to include them all in the name now.
(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h:

(BlockAllocator): Add the appropriate override for regionSetFor.
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::HandleBlock):

  • heap/HandleBlock.h: Added.

(HandleBlock): New class for HandleBlocks.
(JSC::HandleBlock::blockFor): Static method to get the block of the given HandleNode pointer. Allows
us to quickly figure out which HandleSet the HandleNode belongs to without storing the pointer to it
in the HandleNode.
(JSC::HandleBlock::handleSet): Getter.

  • heap/HandleBlockInlines.h: Added.

(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
(JSC::HandleBlock::payload):
(JSC::HandleBlock::nodes):
(JSC::HandleBlock::nodeAtIndex):
(JSC::HandleBlock::nodeCapacity):

  • heap/HandleSet.cpp:

(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):

  • heap/HandleSet.h:

(HandleNode): Move the internal Node class from HandleSet to be its own public class so it can be
used by HandleBlock.
(HandleSet): Add a typedef so that Node refers to the new HandleNode class.
(JSC::HandleSet::toHandle):
(JSC::HandleSet::toNode):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleNode::HandleNode):
(JSC::HandleNode::slot):
(JSC::HandleNode::handleSet): Use the new blockFor static function to get the right HandleBlock and lookup
the HandleSet.
(JSC::HandleNode::setPrev):
(JSC::HandleNode::prev):
(JSC::HandleNode::setNext):
(JSC::HandleNode::next):
(JSC::HandleSet::forEachStrongHandle):

  • heap/Heap.h: Friend HandleSet so that it can access the BlockAllocator when allocating HandleBlocks.
12:16 PM Changeset in webkit [146733] by kareng@chromium.org
  • 9 edits
    2 copies in branches/chromium/1451/Source/WebCore

Revert 146458 "[EFL][WebGL] Implement a common GraphicsSurface I..."

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
​https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

  • PlatformEfl.cmake:
  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createTransportSurface):

  • platform/graphics/opengl/GLPlatformSurface.h:
  • platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

  • platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.

(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.

(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/13046002

12:13 PM Changeset in webkit [146732] by kareng@chromium.org
  • 1 add in branches/chromium/1451/codereview.settings

for drovering

12:12 PM Changeset in webkit [146731] by kareng@chromium.org
  • 1 copy in branches/chromium/1451

branching to revert a change for canary.

8:57 AM Changeset in webkit [146730] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Add support to check for current Drawable.
​https://bugs.webkit.org/show_bug.cgi?id=113103

Patch by KondapallyKalyan <​kalyan.kondapally@intel.com> on 2013-03-24
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

In MakeCurrent we do an early return if it is
the current GL context but ignore Surface. This
patch fixes the issue, we now check for both
context and surface before doing an early return
in MakeCurrent.

  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::destroy):

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore):
(WebCore::GLPlatformSurface::isCurrentDrawable):
(WebCore::GLPlatformSurface::onMakeCurrent):

  • platform/graphics/opengl/GLPlatformSurface.h:
8:47 AM Changeset in webkit [146729] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
<​http://webkit.org/b/112308>

  • WebCore.exp.in: Export

Settings::setHiddenPageDOMTimerThrottlingEnabled()
conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).

7:43 AM Changeset in webkit [146728] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifier::updateState() is called too often
​https://bugs.webkit.org/show_bug.cgi?id=113152

Reviewed by Kenneth Rohde Christiansen.

Wait until we have read all the data on the Netlink socket before
reporting a possible network interface change. This way, we make
sure we don't call NetworkStateNotifier::updateState() several
times in a row for no reason.

We also call NetworkStateNotifier::updateState() only if we get a
RTM_NEWADDR event and we are currently offline, or if we get a
RTM_DELADDR and we are currently online. This avoids calling
NetworkStateNotifier::updateState() uselessly as there is no way
the online state can change otherwise.

No new tests, no behavior change for layout tests.

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

3:36 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:20 AM Changeset in webkit [146727] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
​https://bugs.webkit.org/show_bug.cgi?id=111582

Reviewed by Tim Horton.

Source/WebCore:

There are two ways to create a spin button: from a textfield counter or from ARIA.
If an ARIA spin button is created, it was returning true for isSpinButton, so we were
casting to the other kind of spin button, leading to a crash.

We need to be more specific about our class types.

Test: platform/mac/accessibility/aria-spinbutton-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isNativeSpinButton):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::isNativeSpinButton):
(WebCore::toAccessibilitySpinButton):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
  • platform/mac/accessibility/aria-spinbutton-crash.html: Added.
12:37 AM Changeset in webkit [146726] by Chris Fleizach
  • 34 edits in trunk/Source/WebCore

AXObjectCache gets recreated during document tear-down.
​https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

  • editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

  • editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/InputType.cpp:

(WebCore::InputType::applyStep):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

  • page/Frame.cpp:

(WebCore::Frame::disconnectOwnerElement):

  • page/FrameView.cpp:

(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

  • platform/Scrollbar.h:

(Scrollbar):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

Note: See TracTimeline for information about the timeline view.