Timeline



Apr 2, 2013:

11:56 PM Changeset in webkit [147523] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
https://bugs.webkit.org/show_bug.cgi?id=113828

Reviewed by Tim Horton.

static_cast changed to toAccessibilityList().

  • accessibility/AccessibilityList.h:

(WebCore::toAccessibilityList):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

11:52 PM Changeset in webkit [147522] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Update expectations for fast/css3-text/css3-text-indent/text-indent-each-line.html
https://bugs.webkit.org/show_bug.cgi?id=113848

Mark as [ Failure ImageOnlyFailure ] for fast/css3-text/css3-text-indent/.

Unreviewed gardening.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02

  • platform/mac/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:40 PM Changeset in webkit [147521] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r147370.
http://trac.webkit.org/changeset/147370
https://bugs.webkit.org/show_bug.cgi?id=113850

This patch is causing crashes in video tests on all Mac bots.
(Requested by jernoble_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

11:17 PM Changeset in webkit [147520] by commit-queue@webkit.org
  • 21 edits in trunk

AXRoleDescripton for DL is "list"; should be "description list"
https://bugs.webkit.org/show_bug.cgi?id=111665

Patch by James Craig <james@cookiecrook.com> on 2013-04-02
Reviewed by Chris Fleizach.

Source/WebCore:

Defining the role and description strings, and accessors for DL.
This previously relied on getting the role and description from the platform API.

Updated existing test coverage.

  • English.lproj/Localizable.strings:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/chromium/LocalizedStringsChromium.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::AXDescriptionListText):
(WebCore):

Source/WebKit/chromium:

Defining the role and description strings.

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:

Tools:

Defining the role and description strings.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Updating expectation strings for DL role description.

  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
11:00 PM Changeset in webkit [147519] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Split business logic and presentation for initiator column.
https://bugs.webkit.org/show_bug.cgi?id=113486

Reviewed by Pavel Feldman.

Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying
viewport rendering, because initiator sorting function
depends on data written when cell is rendered.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Removed business logic. Use "initiatorInfo".
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Use "initiatorInfo".

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.initiatorInfo):
Extracted business logic from "refreshInitiatorCell".

10:39 PM Changeset in webkit [147518] by jer.noble@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed gardening; rebaseline mac expected results after r147470.

  • platform/mac/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/mac/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
9:56 PM Changeset in webkit [147517] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

needsLeopardMailQuirks should be removed
https://bugs.webkit.org/show_bug.cgi?id=113749

Reviewed by Benjamin Poulain.

Removed needsLeopardMailQuirks from settings.in after r147447.

  • page/Settings.in:
8:46 PM Changeset in webkit [147516] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=113840

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02

  • platform/efl/TestExpectations:
  • platform/efl/http/tests/inspector/console-websocket-error-expected.txt: Added.
7:50 PM Changeset in webkit [147515] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip filter-fallback-to-software.html on Mac WK2 Release

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02

  • platform/mac-wk2/TestExpectations:

The test seems to pass in Release. Let's see how the bots feel about that.

6:41 PM Changeset in webkit [147514] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835

Unreviewed.

Rolled out r147511 because it was based on incorrect performance
measurement.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor):

6:32 PM Changeset in webkit [147513] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Source/WebCore: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.

CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.

This patch is the rendering part to support each-line value for text-indent.
It's prefixed and guarded by CSS3_TEXT flag.

Test: fast/css3-text/css3-text-indent/text-indent-each-line.html

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):

Rename a parameter from firstLine to shouldIndentText.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::shouldIndentText): Return boolean according to m_shouldIndentText.
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::fitBelowFloats):

Add enum IndentTextOrNot and m_shouldIndentText.
Use m_shouldIndentText instead of m_isFirstLine.

(WebCore::requiresIndent): Decide whether text indentation is required.
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259

CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.

  • fast/css3-text/css3-text-indent/text-indent-each-line-expected.html: Added.
  • fast/css3-text/css3-text-indent/text-indent-each-line.html: Added.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:35 PM Changeset in webkit [147512] by Lucas Forschler
  • 8 edits in branches/safari-536.29-branch/Source/WebKit2

Merged 147052 <rdar://problem/13528851>

5:34 PM Changeset in webkit [147511] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835

Reviewed by Michael Saboff.

2% speedup on SunSpider.

2% speedup on JSRegress.

Neutral on Octane, v8, and Kraken.

The worst-hit single sub-test is kraken-stanford-crypto-ccm.js, which gets
18% slower. Since Kraken is neutral overall in its preferred mean, I
think that's OK for now.

(Our array indexing speculation fails pathologically on
kraken-stanford-crypto-ccm.js. Compiling sooner is a regression because
it triggers those failures sooner. I'm going to file some follow-up bugs
explaining how to fix our speculations on this sub-test, at which point
compiling earlier should become a slight speedup on Kraken overall.)

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor): I experimented
with a few different options, including reducing the coefficient 'a'.
A simple linear reduction on instruction count worked best.

5:28 PM Changeset in webkit [147510] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838

Temporarily marking as failing.

  • platform/mac/TestExpectations:
5:08 PM Changeset in webkit [147509] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Disable running tests on Win EWS queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [147508] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Be more robust against empty message receiver names in incoming messages
https://bugs.webkit.org/show_bug.cgi?id=113833
<rdar://problem/13284433>

Reviewed by Beth Dakin.

Turns out that we either send or receive messages whose receiver names are empty. This leads to bad things when we try to look
up the message receiver name in a hash map since the empty name is used to represent an empty hash map value.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
Sprinkle assertions.

(CoreIPC::Connection::processIncomingMessage):
If the message receiver name is not valid, make sure to call didReceiveInvalidMessage on the client thread.

(CoreIPC::Connection::dispatchDidReceiveInvalidMessage):
Add new helper function.

4:31 PM Changeset in webkit [147507] by glenn@skynav.com
  • 2 edits
    1 add in trunk/PerformanceTests

Need japanese line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=113811

Reviewed by Ryosuke Niwa.

Will be used by https://bugs.webkit.org/show_bug.cgi?id=105692 to test potential performance regression
for Japanese (and other CJK) line break changes.

  • Layout/LineLayoutJapanese.html: Added.
  • Skipped: Skip this test by default.
4:28 PM Changeset in webkit [147506] by glenn@skynav.com
  • 3 edits in trunk/Source/WebCore

Generalize prior line break context state and names.
https://bugs.webkit.org/show_bug.cgi?id=113823

Reviewed by Darin Adler.

No new tests required due to no behavioral change.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setPriorContext):
(WebCore::LazyLineBreakIterator::updatePriorContext):
(WebCore::LazyLineBreakIterator::resetPriorContext):
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator):
Store previous characters as prior context buffer used directly
by line break iterator implementation. Rename members to reflect
somewhat more general usage. Also fix bad indentations.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Use renamed line break iterator methods.

4:17 PM Changeset in webkit [147505] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Padding applied twice for empty generated RenderInlines
https://bugs.webkit.org/show_bug.cgi?id=113800

Source/WebCore:

Reviewed by Levi Weintraub.

The padding for empty generated content render objects is
incorrectly applied twice. Regression from r140693.

Test: fast/css-generated-content/margin-empty-content.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth):

LayoutTests:

Reviewed by Levi Weintraub.

Add test for empty generated content with padding.

  • fast/css-generated-content/margin-empty-content-expected.html: Added.
  • fast/css-generated-content/margin-empty-content.html: Added.
4:10 PM Changeset in webkit [147504] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113733

Reviewed by Emil A Eklund.

Update stale InlineIterators that point beyond the end of a RenderCombineText that's
shrunk when RenderCombineText::combineText() is called.

Test: fast/text/international/combine-at-line-break-crash.html

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
the bounds of their associated RenderText.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.

LayoutTests: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113732

Reviewed by Emil A Eklund.

  • fast/text/international/combine-at-line-break-crash-expected.txt: Added.
  • fast/text/international/combine-at-line-break-crash.html: Added.
3:51 PM Changeset in webkit [147503] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
https://bugs.webkit.org/show_bug.cgi?id=113827

Reviewed by Benjamin Poulain.

  • fast/loader/url-selected-user-gesture-expected.txt:
  • fast/loader/url-selected-user-gesture.html:
3:31 PM Changeset in webkit [147502] by mvujovic@adobe.com
  • 18 edits
    6 copies
    12 adds
    2 deletes in trunk

[CSS Filters] Filter outsets clipped on composited layers when filter is applied after first layout
https://bugs.webkit.org/show_bug.cgi?id=109098

Reviewed by Dean Jackson.

Source/WebCore:

This patch addresses the following issues:
(1) Compositors who can compute their own filter outsets don't need WebKit to inflate the

composited layer bounds. Eventually, all platforms' compositors should be able to
compute their own filter outsets.

(2) When filter outsets change, we need to update composited layer bounds if the filters are

painted in software.

(3) When filter outsets change, we need to recompute the overlap map to promote the correct

layers to composited layers on all platforms.

Tests: css3/filters/composited-layer-bounds-after-sw-blur-animation.html

css3/filters/composited-layer-bounds-with-composited-blur.html
css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html

  • platform/graphics/IntRectExtent.h:

(WebCore::IntRectExtent::isZero):
(IntRectExtent):

Make isZero public on IntRectExtent.

  • rendering/RenderLayer.cpp:

(WebCore::hasOrHadFilters):

Helper function used to exit early from filters related code.

(WebCore::RenderLayer::updateFilters):

Move filter updating code from RenderLayer::styleChanged into this new method.

This method calls RenderLayerBacking::updateFilters instead of
RenderLayerBacking::updateGraphicsLayerGeometry. RenderLayerBacking::updateFilters lets
us know whether there was a filter paint mode change (i.e. the filters were painted in
software and are now painted in the compositor, or vice-versa). We need to know this
earlier, in RenderLayer::styleChanged, because we may need to rebuild the compositing
layers due to a filter paint mode change.

(WebCore::RenderLayer::styleChanged):

Add a condition for filters for setCompositingLayersNeedRebuild. If the filter outsets
on a layer changed, we need to rebuild the compositing layers because there could be new
overlap. Likewise, if there are or were filter outsets and the filter paint mode changed
the layer bounds (and child positions) may have changed. In either case, we don't
rebuild the compositing layers if there is an accelerated filter animation running.

Remove old code to detect a filter paint mode change from the end of
RenderLayer::styleChanged because it could never be executed. The old code counted on
RenderLayerBacking::canCompositeFilters to change on its own, but it doesn't change
unless updateFilters gets called. Thus, we could never enter the if statement that
calls setBackingNeedsRepaint.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

Now return true if there was a filter paint mode change, so RenderLayer::styleChanged
can decide if it should rebuild the compositing layers.

Call updateOrRemoveFilterEffectRenderer and setContentsNeedDisplay if there was a
render mode change. We need to either destroy or create the software renderer and we
need to repaint the layer contents if there was a render mode change.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Don't call updateFilters here. Call it earlier in RenderLayer::styleChanged, for reasons
explained above.

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

Make updateFilters public so RenderLayer::styleChanged can call it.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

If the platform's compositor computes filter outsets for its layers internally, do not
inflate WebKit's composited bounds for filter outsets. This results in smaller layers
on Safari. Note that we still need to include filter outsets in layer bounds for other
situations like overlap testing in WebKit and when we're painting filters in software.

Source/WTF:

  • wtf/Platform.h:

Add flag for HAVE(COMPOSITOR_FILTER_OUTSETS) macro. This is used to check if a
platform's compositor expands layers internally for filter outsets when it applies
filters like drop-shadow and blur. Currently, only CoreAnimation does has this
capability.

LayoutTests:

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:

The above tests needed rebaselining because we're now using smaller layers on Safari.
We aren't inflating layers for filter outsets since CoreAnimation does it for us
already.

  • css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
  • css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Added.
  • css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
  • css3/filters/composited-layer-bounds-with-composited-blur.html: Added.
  • css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
  • css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
  • css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Added.

The above tests are all new. They mostly test edge cases with filter render mode
changes, filter outset changes, and composited layer promotion due to overlap.

Before this patch, composited-layer-bounds-after-sw-blur-animation.html breaks
visibly on Safari WebKit nightly. The blur filter in the test appears clipped before
this patch. The other tests render the same before and after this patch, but now their
layer sizes are smaller.

  • css3/filters/filter-change-repaint-composited-expected.png:
  • css3/filters/filter-change-repaint-composited.html:

This test has been expanded with two more cases, including the original reproduction of
this bug. The test needs rebaselining on Chromium Linux and Win.

  • platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
  • platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.

We need different expectations for Chromium for the new tests because layer bounds
include filter outsets on Chromium but not on Safari.

  • platform/chromium/css3/filters/filter-change-repaint-composited-expected.png: Added.
  • platform/qt/TestExpectations:

Note that we need baselines on Qt for the new and updated tests.

2:52 PM Changeset in webkit [147501] by benjamin@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed, rolling out r147423.

The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.

  • platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
2:49 PM Changeset in webkit [147500] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Don’t let plug-ins use System V shared memory
https://bugs.webkit.org/show_bug.cgi?id=113466
<rdar://problem/13159030>

Reviewed, tweaked and landed by Alexey Proskuryakov.

Instead of allowing plug-ins to request System V shm, give them a
temporary but usable alternative if they try to request it.

  • PluginProcess/mac/PluginProcessShim.mm:
2:31 PM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
2:24 PM Changeset in webkit [147499] by Martin Robinson
  • 9 edits in trunk

[GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821

Reviewed by Gustavo Noronha Silva.

.:

Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.

  • Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
  • Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
  • Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
  • Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.

Source/WebCore:

Don't try to use libsecret if credential storage is disabled.

  • platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
  • platform/gtk/GRefPtrGtk.h: Ditto.
  • platform/network/gtk/CredentialBackingStore.cpp: Ditto.
2:23 PM Changeset in webkit [147498] by Nate Chapin
  • 2 edits
    8 adds
    4 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Removed.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Removed.
  • platform/chromium-mac/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.txt: Added.
  • platform/chromium/TestExpectations:
2:21 PM Changeset in webkit [147497] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] API update for IntRect
https://bugs.webkit.org/show_bug.cgi?id=113824

Patch by Maxim Mogilnitsky <mmogilnitsky@rim.com> on 2013-04-02
Reviewed by Rob Buis.

Modifing IntRect and FloatRect API.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):

2:19 PM Changeset in webkit [147496] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r147423.
http://trac.webkit.org/changeset/147423
https://bugs.webkit.org/show_bug.cgi?id=113775

The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.

  • platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
2:18 PM Changeset in webkit [147495] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Exclusions] refactor shape-outside code to use isFloatingWithShapeOutside() helper method
https://bugs.webkit.org/show_bug.cgi?id=113799

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Dirk Schulze.

When reviewing my patch for bug 110349, Julien mentioned that the
common test for floating with shape outside should be factored out.
This patch does that.

No new functionality, so no new tests.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Use helper method.

  • rendering/RenderBox.h:

(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasPaintOffset): Ditto.
(WebCore::RenderObject::isFloatingWithShapeOutside): Add method to

encapsulate the common test.

1:49 PM Changeset in webkit [147494] by jer.noble@apple.com
  • 3 edits
    4 adds in trunk/Source/WebCore

Add platform AudioSession and iOS platform-specific code.
https://bugs.webkit.org/show_bug.cgi?id=113813
<rdar://problem/11701792>

Reviewed by Eric Carlson.

Replace the deprecated AudioToolbox AudioSession APIs with the new AVAudioSession API.
To protect against exposing platform specific intrinsics to cross-platform code, add a
platform generic class AudioSession, with port-specific implementations. A default
implementation is provided.

Add a new listener interface to receive interruption notifications:

  • platform/audio/AudioSessionListener.h: Added.

(WebCore::AudioSessionListener::AudioSessionListener):
(WebCore::AudioSessionListener::~AudioSessionListener):

Add a platform generic AudioSession class:

  • platform/audio/AudioSession.cpp: Added.

(AudioSession::sharedSession): AudioSession is a singleton object, and this is its accessor.
(AudioSession::addListener): Add the parameter to the listeners set.
(AudioSession::removeListener): Remove the parameter from the listers set.
(AudioSession::beganAudioInterruption): Iterate over the parameters.
(AudioSession::endedAudioInterruption): Ditto.
(AudioSession::AudioSession): Empty stub.
(AudioSession::~AudioSession): Ditto.
(AudioSession::setCategory): Ditto.
(AudioSession::category): Ditto.
(AudioSession::sampleRate): Ditto.
(AudioSession::numberOfOutputChannels): Ditto.
(AudioSession::setActive): Ditto.
(AudioSession::preferredBufferDuration): Ditto.
(AudioSession::setPreferredBufferDuration): Ditto.

  • platform/audio/AudioSession.h: Added.

Add IOS-specific AudioSession implementation:

  • platform/audio/ios/AudioSessionIOS.mm: Added.

(-[WebAudioSessionHelper initWithCallback:WebCore::]): Register for interruption notifications.
(-[WebAudioSessionHelper dealloc]): Unregister for interruption notifications.
(-[WebAudioSessionHelper interruption:]): Pass to AudioSession.
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Private storage for AudioSessionIOS.
(WebCore::AudioSession::AudioSession): Create AudioSessionPrivate and WebAudioSessionHelper.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::setCategory): Check the current categoryOverride, and refuse to overwrite

"MediaPlayback" with "AmbientSound".

(WebCore::AudioSession::setCategoryOverride): Simple setter.
(WebCore::AudioSession::categoryOverride): Simple getter.
(WebCore::AudioSession::category): Pass to AVAudioSession.
(WebCore::AudioSession::sampleRate): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::preferredBufferDuration): Ditto.
(WebCore::AudioSession::setPreferredBufferDuration): Ditto.

Use the new AudioSession class in place of explicit AudioToolbox or AVAudioSession calls:

  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestination::hardwareSampleRate): Pass to AudioSession.
(WebCore::AudioDestination::maxChannelCount): Ditto.
(WebCore::AudioDestinationIOS::AudioDestinationIOS): Register for listeners and activate.
(WebCore::AudioDestinationIOS::~AudioDestinationIOS): Unregister and deactivate.
(WebCore::AudioDestinationIOS::configure): Use AudioSession to set the buffer length.

  • platform/audio/ios/AudioDestinationIOS.h:

Add the new files to the project:

  • WebCore.xcodeproj/project.pbxproj:
1:47 PM Changeset in webkit [147493] by jer.noble@apple.com
  • 2 edits
    3 adds in trunk/Source/WebCore

Upstream AudioDestinationIOS.
https://bugs.webkit.org/show_bug.cgi?id=113806

Reviewed by Eric Carlson.

Upstream AudioDestinationIOS from the iOS repository.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/ios/AudioDestinationIOS.cpp: Added.

(WebCore::audioDestinations):
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):
(WebCore::AudioDestinationIOS::configure):
(WebCore::AudioDestinationIOS::audioDestinationInterruptionListener):
(WebCore::AudioDestinationIOS::initializeAudioSession):
(WebCore::AudioDestinationIOS::start):
(WebCore::AudioDestinationIOS::stop):
(WebCore::AudioDestinationIOS::beganAudioInterruption):
(WebCore::AudioDestinationIOS::endedAudioInterruption):
(WebCore::AudioDestinationIOS::render):
(WebCore::AudioDestinationIOS::inputProc):
(WebCore::AudioDestinationIOS::frameSizeChangedProc):

  • platform/audio/ios/AudioDestinationIOS.h: Added.

(AudioDestinationIOS):
(WebCore::AudioDestinationIOS::isPlaying):
(WebCore::AudioDestinationIOS::sampleRate):

1:35 PM Changeset in webkit [147492] by Christophe Dumez
  • 30 edits in trunk

fast/dom/HTMLImageElement/image-alt-text.html and fast/dom/HTMLInputElement/input-image-alt-text.html are failing
https://bugs.webkit.org/show_bug.cgi?id=94198

Reviewed by Darin Adler.

Source/WebCore:

Fix alt text not being displayed for img elements or input of type
"image" due to insufficient size. imageSizeForError() was adding
padding for the alt text but setImageSizeForAltText() was not. The
issue was occurring in paintReplaced() because the contentWidth() /
contentHeight() would be exactly the same size as the alt text.
However, paintReplaced() first draws an outline rect where the
image should be and then reduces the usable width / height for the
alt text by 2 so that the text does not get printed over the rect
borders. However, after decreasing the usable width / height, there
is no longer enough space to draw the text.

No new tests, already covered by existing tests.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::setImageSizeForAltText): Add padding to the text size
so that the alt text can still be drawn, despite the outline rect
borders. Such padding was already used in imageSizeForError(). Also use
ceilf() for the value returned by Font::width() instead of truncating it.
This is needed because we need to fit the whole text in the image and this
may not be the case if we truncate.
(WebCore::RenderImage::paintReplaced):

LayoutTests:

Rebaseline several test cases that have better result now and add those
tests to TestExpectations for other ports since they will need a
rebaseline.

  • platform/chromium/TestExpectations:
  • platform/efl/fast/block/float/002-expected.png:
  • platform/efl/fast/block/float/017-expected.png:
  • platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/flexbox/023-expected.png:
  • platform/efl/fast/flexbox/024-expected.png:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/invalid/012-expected.png:
  • platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.png:
  • platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • platform/efl/fast/parser/comment-in-script-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/tables/mozilla/bugs/bug2997-expected.png:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:24 PM Changeset in webkit [147491] by Raymond Toy
  • 8 edits
    1 add in trunk/Source

Add support for using ARM FFT in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=109755

Reviewed by Chris Rogers.

Source/WebCore:

No new tests.

  • WebCore.gyp/WebCore.gyp: Add dependency on openmax_dl when use_openmax_dl_fft is enabled.
  • WebCore.gypi: Add source FFTFrameOpenMAXDLAndroid.cpp
  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate): Need 32-byte aligntment with the
OpenMAX DL FFT.

  • platform/audio/FFTFrame.h:

(FFTFrame): Support OpenMAX DL FFT

  • platform/audio/FFTFrameStub.cpp: Support OpenMAX DL FFT
  • platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Added. Implements the

necessary interface using the OpenMAX DL FFT routines.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::contextForSize):

Source/WebKit/chromium:

  • features.gypi: Support building with the OpenMAX DL FFT.
1:04 PM Changeset in webkit [147490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=113762

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Philippe Normand.

Don't leak strings returned by gst_element_get_name() and
gst_missing_plugin_message_get_installer_detail().

No new tests. No change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

1:00 PM Changeset in webkit [147489] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add WKContextSetInvalidMessageFunction
https://bugs.webkit.org/show_bug.cgi?id=113820
<rdar://problem/12679817>

Reviewed by Tim Horton.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInvalidMessageFunction):
Call WebContext::didReceiveInvalidMessage.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setInvalidMessageCallback):
Set the global variable.

(WebKit::WebContext::didReceiveInvalidMessage):
Construct a message name string and call the invalid message callback.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Call WebContext::didReceiveInvalidMessage.

12:57 PM Changeset in webkit [147488] by benjamin@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Rebaseline overflowHidden.html's test results after r147245.

Unreviewed.

The patch r147245 (https://bugs.webkit.org/show_bug.cgi?id=106143) updated results for

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02
Reviewed by Tony Chang.
Chromium, but not for the other platforms.

The new results on Mac, EFL and Win match the common reference.

  • platform/efl/fast/table/overflowHidden-expected.txt: Removed.
  • platform/mac/fast/table/overflowHidden-expected.txt: Removed.
  • platform/win-7sp0/fast/table: Removed.
  • platform/win-7sp0/fast/table/overflowHidden-expected.txt: Removed.
12:54 PM Changeset in webkit [147487] by fpizlo@apple.com
  • 3 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should have the equivalent of a ValueRecovery
https://bugs.webkit.org/show_bug.cgi?id=113819

Reviewed by Mark Hahnenberg.

This adds a way of saying that we have a value, we don't want to say what
node the value came from, but we know specifics of how the value is
formatted. This is the LLVM equivalent of DFG's ValueRecovery.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLFormattedValue.h: Added.

(FTL):
(FormattedValue):
(JSC::FTL::FormattedValue::FormattedValue):
(JSC::FTL::FormattedValue::operator!):
(JSC::FTL::FormattedValue::format):
(JSC::FTL::FormattedValue::value):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

12:53 PM Changeset in webkit [147486] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix css style for CC button on android
https://bugs.webkit.org/show_bug.cgi?id=113815

Patch by Min Qin <qinmin@chromium.org> on 2013-04-02
Reviewed by Adam Barth.

The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
This change fixed that problem.
Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.

  • css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):

12:52 PM Changeset in webkit [147485] by ap@apple.com
  • 8 edits in trunk/Source

[Mac] Remove WKCreateNSURLConnectionDelegateProxy
https://bugs.webkit.org/show_bug.cgi?id=113810

Reviewed by Anders Carlsson.

This WKSI function is not used any more.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
12:50 PM Changeset in webkit [147484] by abucur@adobe.com
  • 3 edits in trunk/LayoutTests

[CSS Regions] Remove font-smoothing from fast/regions/region-style-inline-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=113814

Reviewed by James Robinson.

The test uses font smoothing and makes the test fail on Chromium Mountain Lion. This happens
because of how regions handle overflow and clipping. For now, disable the font smoothing in
the test.

  • fast/regions/region-style-inline-background-color-expected.html:
  • fast/regions/region-style-inline-background-color.html:
12:13 PM Changeset in webkit [147483] by Lucas Forschler
  • 2 edits in trunk/Tools

Disable running tests on the MAC WK2 EWS queue.

Unreviewed.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacWK2EWS):

12:06 PM Changeset in webkit [147482] by timothy@apple.com
  • 7 edits in trunk/Source/WebKit

Provide a user default that can be used to disable docking of the Web Inspector.

The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled".

https://webkit.org/b/113779
rdar://problem/13446021

Reviewed by Joseph Pecoraro.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::didResizeMainFrame):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController showWindow:]):
Check inspectorAttachDisabled() in places where we attach or update the dock button.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.

11:56 AM Changeset in webkit [147481] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should use the right abstract heap for Int32 array accesses
https://bugs.webkit.org/show_bug.cgi?id=113759

Reviewed by Mark Hahnenberg.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

11:54 AM Changeset in webkit [147480] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r147464.
http://trac.webkit.org/changeset/147464
https://bugs.webkit.org/show_bug.cgi?id=113812

JSSQLResultSet.cpp:131:24: error: implicit conversion loses
integer precision: 'int64_t' (aka 'long long') to 'int'
[-Werror,-Wshorten-64-to-32] (Requested by xenon on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):

11:42 AM Changeset in webkit [147479] by pdr@google.com
  • 7 edits in trunk/LayoutTests

Rebaseline svg/as-image/image-respects-pageScaleFactor expectations

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac-lion/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt:
11:37 AM Changeset in webkit [147478] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Make Source Frame & status bar a layout boundary
https://bugs.webkit.org/show_bug.cgi?id=112353

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

  • Add View.markAsLayoutBoundary method to mark a view as a layout

boundary. This will force this view to autoupdate its height to actual
pixel value.

  • Mark both CodeMirrorTextEditor and DefaultTextEditor as a layout

boundary.

  • Mark main-status-bar element with a layout-boundary class.
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):

  • inspector/front-end/DefaultTextEditor.js:
  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsLayoutBoundary):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processOnResize):

  • inspector/front-end/inspector.css:

(.layout-boundary):

  • inspector/front-end/inspector.html:
11:36 AM Changeset in webkit [147477] by danakj@chromium.org
  • 3 edits in trunk/Source/Platform

[chromium] Initialize all fields in WebFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=113807

Reviewed by James Robinson.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::WebFilterOperation):

  • chromium/src/WebFilterOperation.cpp:

(WebKit::WebFilterOperation::WebFilterOperation):

11:36 AM Changeset in webkit [147476] by ap@apple.com
  • 9 edits in trunk/Source

<rdar://problem/13551119> [WK2] Crashes in NetworkProcess when canceling loads
https://bugs.webkit.org/show_bug.cgi?id=113803

Reviewed by Darin Adler.

Stop using a delegate proxy. It hasn't been needed in years, and the extra layer
just adds bugs.

This specific issue gets fixed because connection retains its delegate is retained,
but a proxy does not.

  • WebCore.exp.in:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::platformLoadResourceSynchronously): Removed code that was dealing with delegate proxy.
11:35 AM Changeset in webkit [147475] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData
https://bugs.webkit.org/show_bug.cgi?id=113331

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Refactor to encapsulate uses of V8 Set/GetEmbedderData together
with uses of V8 Set/GetAlignedPointerInEmbedderData since these
functions operate on the same underyling array in V8.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setInjectedScriptContextDebugId):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextDebugData::setContextDebugData):
(WebCore):
(WebCore::V8PerContextDebugData::contextDebugId):
(WebCore::V8PerContextDebugData::createDebugData):
(WebCore::V8PerContextDebugData::getDebugData):
(WebCore::V8PerContextDebugData::setDebugData):

  • bindings/v8/V8PerContextData.h:

(V8PerContextDebugData):
(WebCore):

11:32 AM Changeset in webkit [147474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Adjust toolbar labels position
https://bugs.webkit.org/show_bug.cgi?id=113805

Patch by Alexei Filippov <alph@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Move the labels 1px up to make them centered.
Also fix font centering in native memory distribution snapshot.

  • inspector/front-end/inspector.css:

(.toolbar-label):

  • inspector/front-end/nativeMemoryProfiler.css:

(.native-snapshot-view .data-grid td):

11:30 AM Changeset in webkit [147473] by Nate Chapin
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.

  • platform/chromium/TestExpectations:
11:27 AM Changeset in webkit [147472] by timothy@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderLayer.cpp

Fix Windows build.

11:25 AM Changeset in webkit [147471] by Beth Dakin
  • 13 edits
    2 adds in trunk

Viewport constrained elements should work properly with headers and footers
https://bugs.webkit.org/show_bug.cgi?id=113743

Reviewed by Simon Fraser.

Source/WebCore:

ScrollableArea::constrainScrollPositionForOverhang() needs to take headerHeight
and footerHeight into account. It also needs to use totalContentsSize() instead of
contentsSize().

Send totalContentsSize() instead of contentsSize() and also send headerHeight()
and footerHeight().

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition):

  • page/FrameView.h:

(FrameView):

The scrolling tree will also need to know about header and footer heights since it
will need these values to call
ScrollableArea::constrainScrollPositionForOverhang().

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::headerHeight):
(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::footerHeight):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::headerHeight):
(WebCore::ScrollingTreeScrollingNode::footerHeight):
(ScrollingTreeScrollingNode):

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollParameters):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Use footerHeight when calculating the maxValue and use headerHeight in determining
what the minimum value is.

  • platform/ScrollableArea.cpp:

(WebCore::constrainedScrollPosition):
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):

  • platform/ScrollableArea.h:

(ScrollableArea):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html: Added.
11:23 AM Changeset in webkit [147470] by senorblanco@chromium.org
  • 4 edits
    7 adds in trunk

[Skia] Enable GPU-accelerated Skia path for FEComposite filter.
https://bugs.webkit.org/show_bug.cgi?id=113797

Reviewed by Adrienne Walker.

Source/WebCore:

Tests: css3/filters/effect-reference-composite-hw.html

css3/filters/effect-reference-composite.html

  • WebCore.gypi:
  • platform/graphics/filters/FEComposite.h:

Enable Skia DAG hook for FEComposite.

  • platform/graphics/filters/skia/FECompositeSkia.cpp: Added.

(WebCore::FEComposite::createImageFilter):
Implement skia DAG builder for FEComposite, and implement generic
skia version of composite filter.

LayoutTests:

  • css3/filters/effect-reference-composite-hw.html: Added.
  • css3/filters/effect-reference-composite.html: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Added.
11:20 AM Changeset in webkit [147469] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Avoid using style.display="inline-block"
https://bugs.webkit.org/show_bug.cgi?id=113802

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

  • Create class "inline-block" which will set "display: inline-block"

style.

  • Use this class with DIV elements to get "inline-block" element.
  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/inspector.css:

(.inline-block):

11:18 AM Changeset in webkit [147468] by caseq@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Timeline] warning markers are not propagated to coalesced records
https://bugs.webkit.org/show_bug.cgi?id=113789

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-coalescing.html

  • inspector/front-end/TimelinePresentationModel.js: set childHasWarning on coalescing record if the record it replaces had warnings.

(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):

LayoutTests:

  • inspector/timeline/timeline-coalescing-expected.txt: Added.
  • inspector/timeline/timeline-coalescing.html: Added.
11:17 AM Changeset in webkit [147467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Create a selection from two points irregardless of the caret position.
https://bugs.webkit.org/show_bug.cgi?id=113795

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-02
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR276577
If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
This prevents us from overwriting the previous calculation when setting extent.
Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
create a new directional selection so as to set the base and extent simultaneously.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):

11:16 AM Changeset in webkit [147466] by yurys@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: memory instrumentation for external strings is broken
https://bugs.webkit.org/show_bug.cgi?id=113788

Source/WebCore:

Reviewed by Pavel Feldman.

Native memory snapshot now provides information about JS external strings.

Test: inspector/profiler/memory-instrumentation-external-string.html

  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Test that native memory snapshot contains information about extenral strings.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-string.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
11:14 AM Changeset in webkit [147465] by yurys@chromium.org
  • 10 edits
    2 adds in trunk

Web Inspector: memory instrumentation for external arrays is broken
https://bugs.webkit.org/show_bug.cgi?id=113790

Source/WebCore:

Report pointers to external arrays as retaining ones to make sure their
size is counted correctly.

Reviewed by Pavel Feldman.

Test: inspector/profiler/memory-instrumentation-external-array.html

  • inspector/InspectorMemoryAgent.cpp:

Source/WTF:

Reviewed by Pavel Feldman.

  • wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as

we know that the pointer is not broken.
(WTF::reportMemoryUsage):

LayoutTests:

Test that JS external resources size includes size of JS external arrays
created in the inspected page.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-array.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
11:12 AM Changeset in webkit [147464] by peter@chromium.org
  • 4 edits in trunk/Source/WebCore

[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
https://bugs.webkit.org/show_bug.cgi?id=112711

Reviewed by Sam Weinig.

When nullable attributes are used, it's possible that we disregard the JSValue
when null should be returned instead. This is a waste, and we should cast the
native type to a JSValue as late as possible.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeValueToLocal):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):

11:10 AM Changeset in webkit [147463] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[css exclusions] overflow:hidden undoes shape-outside offsets
https://bugs.webkit.org/show_bug.cgi?id=110349

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Julien Chaffraix.

Source/WebCore:

When overflow: hidden was set on a float with shape-outside, the
offset from the shape-outside was being ignored. This was because the
float was being placed in the normal flow, causing the offsets to be
calculated differently. Since floats with shape outside behave like
positioned objects in many places, I have caused them to take the same
behavior as positioned objects in this case as well: the floats with
shape-outside do not get placed in the normal flow when overflow:
hidden is set.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly): Floats that have

shape-outside should not be in the normal flow.

LayoutTests:

Add a test to make sure the float is properly positioned with
overflow: hidden.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Added.
11:06 AM Changeset in webkit [147462] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.6/Source/WebCore

Merged r147373. <rdar://problem/13202277>

11:04 AM Changeset in webkit [147461] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: resource preview of html/js/css types should be on a grey background
https://bugs.webkit.org/show_bug.cgi?id=113791

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

  • Add a css rule to set grey background for SourceFrame in resource view.
  • Add "fill" style to SourceFrame element to setup its height.
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/resourceView.css:

(.resource-view .script-view):

11:04 AM Changeset in webkit [147460] by Lucas Forschler
  • 5 edits in tags/Safari-537.35.6/Source

Merged r147359. <rdar://problem/13549181>

11:02 AM Changeset in webkit [147459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] Editor doesn't have yellow background in DivergedFromVM state
https://bugs.webkit.org/show_bug.cgi?id=113783

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

No new tests.

Force CodeMirrorTextEditor to have transparent background to inherit
background color from source frame.

  • inspector/front-end/cm/cmdevtools.css:

(.CodeMirror):

11:01 AM Changeset in webkit [147458] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.6/Source

Versioning.

10:59 AM Changeset in webkit [147457] by jparent@chromium.org
  • 10 edits in trunk/Tools

Dashboard refactor: Move dashboard specific history related features to History.
https://bugs.webkit.org/show_bug.cgi?id=113717

Reviewed by Ojan Vafai.

Each dashboard now creates its own History object, with a custom
configuration. This changes from just overriding global functions
to passing in callbacks for generatePage, handleValidHashParameter,
and handleQueryParameterChange. Same with passing in defaultStateValues
and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
variables.

All functions related to these features are now (mostly) private
function on History.

Loader no longer needs a loadingComplete callback, since it can just
initialize the history object itself.

  • TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(handleQueryParameterChange):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):

  • TestResultServer/static-dashboards/history.js:

(.):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):

  • TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleQueryParameterChange):

10:58 AM Changeset in webkit [147456] by Lucas Forschler
  • 15 edits in tags/Safari-537.35.6

Merged r147260. <rdar://problem/13536343>

10:53 AM Changeset in webkit [147455] by aelias@chromium.org
  • 3 edits in branches/chromium/1410/Source/WebCore

Merge 147389 "Hide non-coordinated scrollbars for Android M26"

Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.

This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.

Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.

No new tests. Please revert immediately after landed.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13470017

10:53 AM Changeset in webkit [147454] by jochen@chromium.org
  • 3 edits
    2 adds in trunk

Check whether popups are allowed before creating a new window
https://bugs.webkit.org/show_bug.cgi?id=113782

Reviewed by Adam Barth.

Source/WebCore:

Otherwise, firing a generated mouse event at an anchor is enough to
work around the popup blocker.

Test: fast/loader/url-selected-user-gesture.html

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

  • fast/loader/url-selected-user-gesture-expected.txt: Added.
  • fast/loader/url-selected-user-gesture.html: Added.
10:50 AM Changeset in webkit [147453] by jochen@chromium.org
  • 5 edits in trunk

When computing the percentage of the logical height, use the logical top and bottom
https://bugs.webkit.org/show_bug.cgi?id=113761

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

  • fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
  • fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
10:50 AM Changeset in webkit [147452] by Lucas Forschler
  • 3 edits in tags/Safari-537.35.6/Source/WebCore

Merged r147240. <rdar://problem/13256956>

10:49 AM Changeset in webkit [147451] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] do not show cursor in read-only mode
https://bugs.webkit.org/show_bug.cgi?id=113793

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Alexander Pavlov.

No new tests.

Pass "nocursor" option to CodeMirror's "readonly" setting.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.setReadOnly):

10:47 AM Changeset in webkit [147450] by Nate Chapin
  • 22 edits in trunk

Unreviewed, rolling out r147402.
http://trac.webkit.org/changeset/147402
https://bugs.webkit.org/show_bug.cgi?id=112903

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
10:45 AM Changeset in webkit [147449] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.6/Source/WebCore

Merged r146995. <rdar://problem/13474743>

10:41 AM Changeset in webkit [147448] by alokp@chromium.org
  • 1 edit
    3 copies in branches/chromium/1453

Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..."

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

  • compositing/contents-opaque/control-layer-expected.txt: Added.
  • compositing/contents-opaque/control-layer.html: Added.
  • platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.

TBR=alokp@chromium.org
BUG=223490
Review URL: https://codereview.chromium.org/13465009

10:35 AM Changeset in webkit [147447] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebKit/mac

WebKit/mac shouldn't have code for Mac 10.5 and earlier
https://bugs.webkit.org/show_bug.cgi?id=113746

Reviewed by Darin Adler.

Deleted the code for 10.5 and removed if-defs for 10.6.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):

  • WebCoreSupport/WebEditorClient.mm:

(core):
(WebEditorClient::checkTextOfParagraph):
(WebEditorClient::requestCheckingOfString):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView reflectScrolledClipView:]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _updateMenuAndDockForFullScreen]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(writingDirectionKeyBindingsEnabled):
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView attachRootLayer:]):

  • WebView/WebHTMLViewInternal.h:
  • WebView/WebPDFDocumentExtras.mm:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResourceInternal.h:
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
(+[WebView initialize]):
(clientNeedsWebViewInitThreadWorkaround):
(-[WebView validateUserInterfaceItemWithoutDelegate:]):
(-[WebView setGrammarCheckingEnabled:]):
(-[WebView isAutomaticQuoteSubstitutionEnabled]):
(-[WebView isAutomaticLinkDetectionEnabled]):
(-[WebView isAutomaticDashSubstitutionEnabled]):
(-[WebView isAutomaticTextReplacementEnabled]):
(-[WebView isAutomaticSpellingCorrectionEnabled]):
(-[WebView _searchWithSpotlightFromMenu:]):
(WebInstallMemoryPressureHandler):

  • WebView/WebViewPrivate.h:
10:28 AM Changeset in webkit [147446] by fpizlo@apple.com
  • 8 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support fast property stores
https://bugs.webkit.org/show_bug.cgi?id=113757

Reviewed by Oliver Hunt.

Simplified the task of handling property transitions and reduced amount of code
duplication between the JITs.

Added PutByOffset, PutStructure, PhantomPutStructure, WeakJSConstant, and a
stub form of StructureTransitionWatchpoint to the FTL.

Also simplified the creation of pointer constants, and fixed a bug in
speculateObject().

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::notifyCompilingStructureTransition):
(Graph):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

  • ftl/FTLOutput.h:

(Output):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::absolute):

10:24 AM Changeset in webkit [147445] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907

Unreviewed Mac test expectation fix.

  • platform/mac/TestExpectations:

Removed grid-column-002.htm here too.

10:21 AM Changeset in webkit [147444] by Nate Chapin
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.

  • platform/chromium/TestExpectations: Mark svg/as-image/image-respects-pageScaleFactor.html as flaky.
10:16 AM Changeset in webkit [147443] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GTK][AC] Support preserves3D css property for clutter ac backend.
https://bugs.webkit.org/show_bug.cgi?id=113318

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-02
Reviewed by Gustavo Noronha Silva.

This patch brings preserve-3D css property support to WebKitGtk+ with clutter ac backed.
Most of the code is based on Mac port's implementation. The core concept is that
if a layer has preserve-3d property false, we mark itself and its immediate children
to make them flatten. And then we remove 3D factor in a modelView matrix
when applying it to each actor.

No new tests as this is covered with existing AC tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphics_layer_actor_init):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorNew):
(graphicsLayerActorRemoveFromSuperLayer):
(graphicsLayerActorSetDrawsContent):
(graphicsLayerActorSetFlatten):

  • platform/graphics/clutter/GraphicsLayerActor.h:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
(WebCore):
(WebCore::GraphicsLayerClutter::setPreserves3D):
(WebCore::GraphicsLayerClutter::flushCompositingState):
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::updateGeometry):
(WebCore::GraphicsLayerClutter::updateSublayerList):
(WebCore::GraphicsLayerClutter::updateStructuralLayer):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::structuralLayerPurpose):
(WebCore::GraphicsLayerClutter::layerForSuperlayer):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(CommitState):
(WebCore::GraphicsLayerClutter::CommitState::CommitState):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::primaryLayer):

10:10 AM Changeset in webkit [147442] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.6

New Tag.

9:14 AM Changeset in webkit [147441] by adamk@chromium.org
  • 8 edits
    5 adds in trunk

HTML parser should consistently inspect the namespace of elements on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=113723

Reviewed by Adam Barth.

Source/WebCore:

Added HTMLStackItem::matchesHTMLTag method and use that nearly
everywhere instead of HTMLStackItem::hasLocalName. The most important
of these changes is in HTMLElementStack's inScopeCommon() function,
where the use of matchesHTMLTag means that any of the inXXXScope()
calls now only match HTML tags.

Tests: html5lib/generated/run-namespace-sensitivity-data.html

html5lib/generated/run-namespace-sensitivity-write.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):
(WebCore::HTMLElementStack::inButtonScope):
(WebCore::HTMLElementStack::inSelectScope):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::popUntilPopped):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::matchesHTMLTag):
(HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):

LayoutTests:

  • html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
  • html5lib/generated/run-namespace-sensitivity-data.html: Added.
  • html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
  • html5lib/generated/run-namespace-sensitivity-write.html: Added.
  • html5lib/resources/namespace-sensitivity.dat: Added.
9:00 AM Changeset in webkit [147440] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Report memory usage for ShadowDistributedRules.
https://bugs.webkit.org/show_bug.cgi?id=109882

Reviewed by Dimitri Glazkov.

This is a follow-up patch for r142855.

No new tests, no behavior change for layout tests.

  • css/DocumentRuleSets.cpp:

(WebCore):
(WebCore::ShadowDistributedRules::reportMemoryUsage):
(WebCore::DocumentRuleSets::reportMemoryUsage):

  • css/DocumentRuleSets.h:

(ShadowDistributedRules):

8:58 AM Changeset in webkit [147439] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: Need to get line thickness from fraction on web
https://bugs.webkit.org/show_bug.cgi?id=113720

Reviewed by David Kilzer.

Expose the line thickness property for fractions, which is needed to
help determine the type of equation.

Test: platform/mac/accessibility/mathml-line-fraction.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::mathLineThickness):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mathLineThickness):
(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:48 AM Changeset in webkit [147438] by wangxianzhu@chromium.org
  • 2 edits in branches/chromium/1453/Source

Merge 147178 "[Chromium] Don't create SolidColorLayer for full t..."

[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524

Reviewed by James Robinson.

Source/WebCore:

Test: GraphicsLayerChromiumTest.setContentsToSolidColor

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):

Source/WebKit/chromium:

  • tests/GraphicsLayerChromiumTest.cpp:

(GraphicsLayerChromiumTest::setContentsToSolidColor):

TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/13430007

8:43 AM Changeset in webkit [147437] by abucur@adobe.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed.

Enable fast/regions/region-style-inline-background-color.html on Mountain Lion as it started to pass.

  • platform/chromium/TestExpectations:
8:24 AM Changeset in webkit [147436] by aelias@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r147389.
http://trac.webkit.org/changeset/147389
https://bugs.webkit.org/show_bug.cgi?id=113738

r147389 was temporary patch for Chromium branch management, needs
revert.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

8:21 AM Changeset in webkit [147435] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

New results for effect-reference-hw, due to slight pixel differences from http://src.chromium.org/viewvc/chrome?view=rev&revision=191067

  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium/TestExpectations:
8:18 AM Changeset in webkit [147434] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Hang when calling setCurrentTime on SVG with cyclic animation dependency chain
https://bugs.webkit.org/show_bug.cgi?id=113485

Patch by David Vest <davve@opera.com> on 2013-04-02
Reviewed by Stephen Chenney.

Source/WebCore:

If no exact match can be found, approximateBinarySearch may return
either adjacent value to the key. Selecting the lesser value when
there is a greater one may cause interval creation to fail in a
way that causes infinite loops during seeking. Detect and amend
this condition by selecting the greater value when possible.

Test: svg/animations/animation-dependency-hang.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

LayoutTests:

  • svg/animations/animation-dependency-hang-expected.txt: Added.
  • svg/animations/animation-dependency-hang.html: Added.
7:58 AM Changeset in webkit [147433] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: source location gets frozen after inspector reload
https://bugs.webkit.org/show_bug.cgi?id=113776

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.

No new tests.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):

7:47 AM Changeset in webkit [147432] by jesus@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded cpp file from CMake build. Rubber-stamp by Alexis Menard.

  • CMakeLists.txt: Remove FFTFrameStub.cpp, since adding this file or not

to your build is a platform decision.

7:44 AM Changeset in webkit [147431] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
https://bugs.webkit.org/show_bug.cgi?id=113708

Reviewed by Yury Semikhatsky.

  • make TimelineOverviewPane logic independent on overview mode;
  • show only one of 3 controls at one time;
  • attach overview controls to the same parent.
  • inspector/front-end/OverviewGrid.js: remove gridElement() and itemsGraphsElement(), no longer needed.

(WebInspector.OverviewGrid):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._innerSetMode):
(WebInspector.TimelineOverviewPane.prototype._createOverviewControl):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineOverviewBase.prototype.reset):
(WebInspector.TimelineOverviewBase.prototype.categoryVisibilityChanged):
(WebInspector.TimelineOverviewBase.prototype.addFrame):
(WebInspector.TimelineOverviewBase.prototype.getWindowTimes):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype.categoryVisibilityChanged):

  • inspector/front-end/timelinePanel.css:
7:41 AM Changeset in webkit [147430] by jchaffraix@webkit.org
  • 11 edits
    1 add in trunk

webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-column-row-get-set.html

ietestcenter/css3/grid/grid-column-002.htm

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Don't accept 0 as a valid <integer> position.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:

Extended our testing to cover setting grid-{start|end|before|after} to 0.

  • ietestcenter/css3/grid/grid-column-002.htm:
  • ietestcenter/css3/grid/testRunnerEnableGrid.js: Added.

Needed to dynamically enable CSS Grid Layout for the test to pass. The file
hosts the boiler-plate code which will be common to all tests.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:

Removed grid-column-002.htm from the test expectations.

7:36 AM Changeset in webkit [147429] by thiago.santos@intel.com
  • 3 edits
    5 adds
    4 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Added.
  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/efl/TestExpectations:
7:28 AM Changeset in webkit [147428] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: allow referencing of nodes that have not been pushed to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Nodes not yet pushed to front-end are referenced by BackendNodeId and retained.
One can group nodes when generating BackendNodeIds to release them all together later.

To resolve node references by BackendNodeId, frontend should use new pushNodeByBackendIdToFrontend method.
This will invalidate the generated BackendNodeId.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

7:28 AM Changeset in webkit [147427] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Web Inspector: Update test expectation for console-cross-origin-iframe-logging.html
https://bugs.webkit.org/show_bug.cgi?id=113756

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Pavel Feldman.

Simplified errors by not including the whole URL after r145692.

  • http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/efl/TestExpectations:
  • platform/qt/TestExpectations:
6:48 AM Changeset in webkit [147426] by abucur@adobe.com
  • 10 edits
    8 adds in trunk

[CSS Regions] Nested auto-height regions don't layout correctly
https://bugs.webkit.org/show_bug.cgi?id=111969

Reviewed by David Hyatt.

Source/WebCore:

The patch fixes the auto-height regions processing model to work with nested named flows. Currently
this use case doesn't work correctly because the order in which the computed height value is propagated
to the regions is incorrect. For example, in the case of two flows (f1 and f2) and two auto-height
regions (r1 and r2) with r2 a member of f1:

  1. the normal layout phase starts
  2. r1 is laid out with height = 0
  3. f1 is laid out including r2 with height = 0; overrideLogicalHeight for r1 is computed
  4. f2 is laid out; overrideLogicalHeight for r2 is computed
  5. the constrained layout phase starts
  6. r1 is laid out using the overrideLogicalHeight computed in the normal phase
  7. f1 is laid out including r2 with its overrideLogicalHeight
  8. f2 is laid out

The problem appears at step 6 because the overrideLogicalheight computed during step 3 assumes r2
has a height of 0. The patch changes the algorithm to update the auto-height regions in the reverse
order of their flow threads dependecies. Here is a high level overview of the new algorithm,
considering the named flows are sorted in the order of their dependencies:

  1. The flows are laid out from the outer flow to the inner flow. This successfully computes the outer

non-auto-height regions size so the inner flows have the necessary information to correctly fragment
the content.

  1. The flows are laid out from the inner flow to the outer flow. After an inner flow is laid out it

goes into the constrained layout phase and marks the auto-height regions they need layout. This
means the outer flows will relayout if they depend on regions with auto-height regions belonging to
inner flows. This step will correctly compute the overrideLogicalHeights for the auto-height regions.
It's possible for non-auto-height regions to relayout if they depend on auto-height regions. This
will invalidate the inner flow threads and mark them as needing layout.

  1. The last step is to do one last layout if there are pahtological dependencies between non-auto-height

regions and auto-height regions as detected in the previous step.

The patch also removes the layout phase flag from RenderView and moves it to the flow threads. This
happens because a flow needs to update its auto-height regions overrideLogicalHeight while updating
the logical height of the regions belonging to the inner flows that are laid out by the flow (i.e. the
outer flow is in the normal phase while the inner flows are in the constrained layout phase).

There's also a new flag on the RenderFlowThread that is set when the flow needs the constrained layout
phase. This could have been placed on the flow thread controller but I think it will be useful when doing
content balancing for the new multi-column implementation.

Another change is the moment we clear the overrideLogicalHeight value on empty auto-height regions because
we don't have to relayout a flow thread once it's in the constrained phase. We need to have the correct
flow thread portions correctly computed after the artificial forced break is applied at the end of the content.

Tests: fast/regions/autoheight-mixed-nested-complex-regions.html

fast/regions/autoheight-mixed-nested-regions.html
fast/regions/autoheight-mixed-parallel-regions.html
fast/regions/autoheight-nested-regions.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore):
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::applyBreakAfterContent): Apply an artificial break at the end of the content.
This way we can detect when the content ends and clear the overrideLogicalHeight on the empty auto-height regions.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalWidth):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

LayoutTests:

These tests cover various combinations of dependencies between flows and regions with
or without auto-height.

  • fast/regions/autoheight-mixed-nested-complex-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-nested-complex-regions.html: Added.
  • fast/regions/autoheight-mixed-nested-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-nested-regions.html: Added.
  • fast/regions/autoheight-mixed-parallel-regions-expected.txt: Added.
  • fast/regions/autoheight-mixed-parallel-regions.html: Added.
  • fast/regions/autoheight-nested-regions-expected.txt: Added.
  • fast/regions/autoheight-nested-regions.html: Added.
6:46 AM Changeset in webkit [147425] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ignore minimum record duration filter in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=113705

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._durationFilterChanged):

6:45 AM Changeset in webkit [147424] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Web Inspector: add tests for grouped messages filtration in console.
https://bugs.webkit.org/show_bug.cgi?id=113766

Added console groups to console filter test. Fixed minor bugs in other tests.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

  • inspector/console/console-filter-test-expected.txt:
  • inspector/console/console-filter-test.html:
  • inspector/console/console-preserve-log.html:
  • inspector/console/console-tests-expected.txt:
  • inspector/console/console-tests.html:
6:44 AM Changeset in webkit [147423] by mkwst@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Mac] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=113775

Tests need platform-specific rebaselines after r147402. :(

  • platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
6:19 AM Changeset in webkit [147422] by caseq@chromium.org
  • 9 edits in trunk

Web Inspector: display the number of dirty render objects in Layout timeline event
https://bugs.webkit.org/show_bug.cgi?id=95331

Reviewed by Pavel Feldman.

Source/WebCore:

Count the render objects that need layout in InspectorTimelineAgent::willLayout()
and display the number in popover over Layout record in Timeline panel.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):

  • inspector/TimelineRecordFactory.cpp:

(WebCore):
(WebCore::TimelineRecordFactory::createLayoutData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):

LayoutTests:

  • inspector/timeline/timeline-layout-expected.txt: rebaselined to include new properties;
6:15 AM Changeset in webkit [147421] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] Popover for codemirror
https://bugs.webkit.org/show_bug.cgi?id=113771

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

Implement methods TextEditor.cursorPositionToCoordinates, TextEditor.coordinatesToCursorPosition and
TextEditor.tokenAtTextPosition in CodeMirrorTextEditor to support popover
functionality. Add css classes to highlight popover anchoring text.

No new tests.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.CodeMirrorTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.CodeMirrorTextEditor.prototype.tokenAtTextPosition):

  • inspector/front-end/cm/cmdevtools.css:

(.CodeMirror .source-frame-eval-expression):
(.CodeMirror .source-frame-eval-expression-end):
(.CodeMirror .source-frame-eval-expression-start):

5:56 AM Changeset in webkit [147420] by thiago.santos@intel.com
  • 2 edits
    60 adds
    1 delete in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/compositing/contents-opaque/control-layer-expected.txt: Added.
  • platform/efl-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
  • platform/efl-wk2/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
  • platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
  • platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
  • platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.png: Added.
  • platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.txt: Added.
  • platform/efl-wk2/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
  • platform/efl-wk2/editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
  • platform/efl-wk2/editing/selection/move-by-character-6-expected.txt: Removed.
  • platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added.
  • platform/efl-wk2/fast/dom/icon-url-property-expected.txt: Added.
  • platform/efl-wk2/fast/dynamic/002-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/efl-wk2/fast/table/overflowHidden-expected.txt: Added.
  • platform/efl-wk2/fast/text/complex-text-opacity-expected.png: Added.
  • platform/efl-wk2/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/efl-wk2/fast/transforms/bounding-rect-zoom-expected.txt: Added.
  • platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/efl-wk2/http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
  • platform/efl-wk2/inspector/styles/paste-property-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt: Added.
  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
  • platform/efl-wk2/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/efl-wk2/transforms/2d/hindi-rotated-expected.txt: Added.
5:50 AM Changeset in webkit [147419] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for two Resource Timing layout tests

that regressed with r147387.

5:39 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
Qt Mountain Lion bot moved to Apple master (diff)
5:16 AM Changeset in webkit [147418] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()
https://bugs.webkit.org/show_bug.cgi?id=113763

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Rob Buis.

PR 318945
Internally reviewed by Jakob Petsovits.

And remove the BlackBerry specific methods
frameViewFrameRectDidChange and frameViewContentsSizeDidChange.

  • page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:

(WebCore::ScrollingCoordinatorBlackBerry::frameViewLayoutUpdated):
Called when the frame view has been laid out. Update the contents
rectangle and visible area of the scroll layer for the given frame
view.

  • page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h:

(ScrollingCoordinatorBlackBerry):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setFrameVisibleRect): Return early if
value hasn't changed.
(WebCore::LayerWebKitThread::setFrameContentsSize): Ditto.

5:06 AM Changeset in webkit [147417] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests after r147384 and r147388.

  • platform/qt/TestExpectations:
  • platform/qt/fast/table/overflowHidden-expected.txt: Rebaselining after 147374.
3:58 AM Changeset in webkit [147416] by zandobersek@gmail.com
  • 4 edits in trunk

Unreviewed, rolling out r147401.
http://trac.webkit.org/changeset/147401
https://bugs.webkit.org/show_bug.cgi?id=113767

The patch makes it extremely hard to set up the dependencies
properly on the GTK builders (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02

.:

  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules:
3:49 AM Changeset in webkit [147415] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of editor's DOM
https://bugs.webkit.org/show_bug.cgi?id=113412

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.

  • Use TextEditor.coordinatesToCursorPosition,

TextEditor.cursorPositionToCoordinates and TextEditor.tokenAtTextPosition to figure out
hovering area and create popover anchor.

  • Use TextEditor.highlightRange/TextEditor.removeHighlight methods to

highlight hovering text in editor.

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:
  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype.):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

  • inspector/front-end/inspector.css:

(.popover-anchor):
(.source-frame-eval-expression):

3:33 AM Changeset in webkit [147414] by mihnea@adobe.com
  • 10 edits in trunk/Source/WebCore

[CSSRegions] RenderFlowThread should not be created as a Document renderer
https://bugs.webkit.org/show_bug.cgi?id=113658

Reviewed by Julien Chaffraix.

After https://bugs.webkit.org/show_bug.cgi?id=107138, RenderFlowThread should not be constructed as a renderer for Document.
Since it does not have an element associated, it will be constructed using the pattern for anonymous blocks.
However, since I do not want the flow thread to be collapsed as anonymous blocks are, i changed RenderObject::isAnonymousBlock
to return false for a RenderFlowThread (the alternative would have been to patch more call sites to prevent RenderFlowThread
collapsing as anonymous block).

Covered by existing tests.

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::addChild):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::createAnonymous):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::createAnonymous):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock):

3:21 AM Changeset in webkit [147413] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r147383.
http://trac.webkit.org/changeset/147383
https://bugs.webkit.org/show_bug.cgi?id=112369

Speculative rollout because of lots of layout test failure

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::PumpSession::PumpSession):

  • html/parser/HTMLParserScheduler.h:
2:52 AM Changeset in webkit [147412] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [HeapProfiler] Table rows do not appear when resizing.
https://bugs.webkit.org/show_bug.cgi?id=113760

Reviewed by Yury Semikhatsky.

Analysis: custom-made split-view doesn't notify content panes about
resizing.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
Notify content pane about resize.

2:50 AM Changeset in webkit [147411] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] Clean-up RenderFlowThread::updateRegionsFlowThreadPortionRect
https://bugs.webkit.org/show_bug.cgi?id=113659

Reviewed by Julien Chaffraix.

RenderRegion::logicalHeightOfAllFlowThreadContent already contains the
override logical content height for auto-height regions in normal layout phase.
Therefore, there is no need to explicitly override region's rect height with
the region's overrideLogicalContentHeight as the region rect already contains
the right value.

No change in functionality, covered by existing tests.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):

2:50 AM Changeset in webkit [147410] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Empty tooltip shown when hovering over popup menu items
https://bugs.webkit.org/show_bug.cgi?id=113382

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Gyuyoung Kim.

Do not show the empty tooltip box if the text is null.

  • MiniBrowser/efl/main.c:

(popup_menu_populate):

2:47 AM Changeset in webkit [147409] by zarvai@inf.u-szeged.hu
  • 14 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147402.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2:33 AM Changeset in webkit [147408] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

TestExpectation was deleted wrongly. Let me revert it.

  • platform/chromium/TestExpectations:
2:08 AM Changeset in webkit [147407] by shinyak@chromium.org
  • 1 edit
    7 adds
    15 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac-lion/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
2:01 AM Changeset in webkit [147406] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[QT] Cleanup after r139447 and r145374.
https://bugs.webkit.org/show_bug.cgi?id=113671

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02

  • platform/qt/TestExpectations:
1:49 AM Changeset in webkit [147405] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt]REGRESSION?(r63191): http/tests/inspector/resource-har-conversion.html fails
https://bugs.webkit.org/show_bug.cgi?id=42162

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Csaba Osztrogonác.

Copy the results of http/tests/inspector/resource-har-conversion.html
to the qt platform dir.

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/inspector/resource-har-conversion-expected.txt: Added.
1:33 AM Changeset in webkit [147404] by shinyak@chromium.org
  • 159 edits
    7 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/TestExpectations:
1:32 AM Changeset in webkit [147403] by mikhail.pozdnyakov@intel.com
  • 82 edits in trunk/Source/WebKit2

[WK2] Remove repeating code in declaration of WK2 API classes
https://bugs.webkit.org/show_bug.cgi?id=112782

Reviewed by Benjamin Poulain.

The following two lines of code had been repeated in every WK2 API
object class:
1) static const Type APIType = SomeAPIType;
2) virtual Type type() const { return APIType; }

This patch introduces template class 'TypedAPIObject' inherited
from WebKit::APIObject and it contains the common functionality.
So the new pattern is that API object classes are inherited from
TypedAPIObject (rather than from WebKit::APIObject directly) passing
the corresponding API object type as a template parameter.

The existing API object classes are modified accordingly to the
proposed pattern.

  • Shared/APIObject.h:

(WebKit):
(TypedAPIObject):
(WebKit::TypedAPIObject::~TypedAPIObject):
(WebKit::TypedAPIObject::TypedAPIObject):

  • Shared/ImmutableArray.h:

(ImmutableArray):

  • Shared/ImmutableDictionary.h:

(ImmutableDictionary):

  • Shared/WebArchive.h:

(WebArchive):

  • Shared/WebArchiveResource.h:

(WebArchiveResource):

  • Shared/WebBackForwardListItem.h:

(WebBackForwardListItem):

  • Shared/WebBatteryStatus.h:

(WebBatteryStatus):

  • Shared/WebCertificateInfo.h:
  • Shared/WebConnection.h:

(WebConnection):

  • Shared/WebContextMenuItem.h:

(WebContextMenuItem):

  • Shared/WebData.h:
  • Shared/WebError.h:

(WebKit::WebError::errorCode):

  • Shared/WebGeolocationPosition.h:

(WebGeolocationPosition):

  • Shared/WebGeometry.h:
  • Shared/WebGraphicsContext.h:

(WebGraphicsContext):

  • Shared/WebHitTestResult.h:
  • Shared/WebImage.h:

(WebImage):

  • Shared/WebNetworkInfo.h:

(WebNetworkInfo):

  • Shared/WebNumber.h:
  • Shared/WebOpenPanelParameters.h:

(WebOpenPanelParameters):

  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.h:
  • Shared/WebSecurityOrigin.h:
  • Shared/WebSerializedScriptValue.h:

(WebSerializedScriptValue):

  • Shared/WebString.h:
  • Shared/WebURL.h:
  • Shared/WebURLRequest.h:

(WebURLRequest):

  • Shared/WebURLResponse.h:

(WebURLResponse):

  • Shared/WebUserContentURLPattern.h:
  • Shared/mac/ObjCObjectGraph.h:
  • UIProcess/Authentication/AuthenticationChallengeProxy.h:

(AuthenticationChallengeProxy):

  • UIProcess/Authentication/AuthenticationDecisionListener.h:

(AuthenticationDecisionListener):

  • UIProcess/Authentication/WebCredential.h:

(WebCredential):

  • UIProcess/Authentication/WebProtectionSpace.h:

(WebProtectionSpace):

  • UIProcess/Downloads/DownloadProxy.h:

(DownloadProxy):

  • UIProcess/GeolocationPermissionRequestProxy.h:

(GeolocationPermissionRequestProxy):

  • UIProcess/Notifications/NotificationPermissionRequest.h:

(NotificationPermissionRequest):

  • UIProcess/Notifications/WebNotification.h:

(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebBackForwardList.h:

(WebBackForwardList):

  • UIProcess/WebBatteryManagerProxy.h:

(WebBatteryManagerProxy):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebEditCommandProxy.h:

(WebEditCommandProxy):

  • UIProcess/WebFrameProxy.h:

(WebFrameProxy):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebGrammarDetail.h:

(WebGrammarDetail):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebNavigationData.h:

(WebNavigationData):

  • UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy):

  • UIProcess/WebOpenPanelResultListenerProxy.h:

(WebOpenPanelResultListenerProxy):

  • UIProcess/WebPageGroup.h:

(WebPageGroup):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

  • UIProcess/WebPreferences.h:

(WebPreferences):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/WebTextChecker.h:

(WebTextChecker):

  • UIProcess/WebVibrationProxy.h:

(WebVibrationProxy):

  • UIProcess/efl/WebPopupItemEfl.h:

(WebPopupItemEfl):

  • UIProcess/efl/WebView.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

(InjectedBundleNodeHandle):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:

(InjectedBundleRangeHandle):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:

(InjectedBundleDOMWindowExtension):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:

(InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:

(InjectedBundleScriptWorld):

  • WebProcess/WebPage/PageOverlay.h:

(PageOverlay):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebPageGroupProxy):

1:28 AM Changeset in webkit [147402] by mkwst@chromium.org
  • 22 edits in trunk

X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903

Reviewed by Adam Barth.

Source/WebCore:

This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Rather than redirecting to 'about:blank', redirect to
'data:text/html,<p></p>' which does not inherit the SecurityOrigin
of the parent.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't
inherit the parent's SecurityOrigin.

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
1:25 AM Changeset in webkit [147401] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282

Reviewed by Martin Robinson.

.:

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1:21 AM Changeset in webkit [147400] by shinyak@chromium.org
  • 224 edits
    2 copies
    13 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
1:12 AM Changeset in webkit [147399] by shinyak@chromium.org
  • 121 edits
    2 copies
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
1:02 AM Changeset in webkit [147398] by shinyak@chromium.org
  • 77 edits
    5 adds
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
12:53 AM Changeset in webkit [147397] by shinyak@chromium.org
  • 9 edits
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

rebaselined after r147390.

  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
12:11 AM Changeset in webkit [147396] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
https://bugs.webkit.org/show_bug.cgi?id=113685

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Martin Robinson.

MOZ_X11 is added unconditionally in OptionsCommon for UNIX
platforms, but not all UNIX platforms use X11 for plugins,
BlackBerry doesn't. The only port using cmake that uses X11 is EFL
and it already has checks for X11, so we can just move the
definition to OptionsEfl.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:

Apr 1, 2013:

11:49 PM Changeset in webkit [147395] by esprehn@chromium.org
  • 5 edits in trunk/Source/WebCore

RenderObject::offsetParent should return Element*
https://bugs.webkit.org/show_bug.cgi?id=113739

Reviewed by Abhishek Arya.

The offsetParent of a node should always be an Element, ensure this
by fixing RenderObject::offsetParent to return an Element* and clean up
the method to match the algorithm in the spec which lets us remove the
comments that were trying to explain what was going on.

This also hardens against badness where RenderObject::offsetParent
could have returned a renderer with a non-Element node which would result
in a bad cast in Element::offsetParent. We fixed all cases of this, but
this patch makes sure such things never happen again.

No new tests, no change in behavior.

  • dom/Element.cpp:

(WebCore::Element::offsetParent):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent): Now returns Element*.

  • rendering/RenderObject.h:

(RenderObject):

11:34 PM Changeset in webkit [147394] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Removing duplicated expectations to get rid of linting errors.
11:29 PM Changeset in webkit [147393] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectation for the svg/repaint/buffered-rendering-static-image.html

layout test added in r147348, most likely due to disabled subpixel layout on the GTK port.

  • platform/gtk/fast/table/overflowHidden-expected.png: Updating after r147245.
  • platform/gtk/fast/table/overflowHidden-expected.txt: Ditto.
11:28 PM Changeset in webkit [147392] by hclam@chromium.org
  • 4 edits in trunk/Source/WebCore

Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718

Reviewed by Adam Barth.

When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.

Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::repetitionCount):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::GIFImageReader):
(GIFImageReader):

11:23 PM Changeset in webkit [147391] by esprehn@chromium.org
  • 15 edits in trunk/Source/WebCore

Make all v8 weak callbacks type safe
https://bugs.webkit.org/show_bug.cgi?id=111802

Reviewed by Adam Barth.

Make all v8 handle weak callbacks typesafe by adding a new class WeakHandleListner
that uses templates to generate the callback proxies that have the correct type
arguments. Now getting the arguments wrong will fail compilation.

No new tests, no change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::::callback):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(DOMWrapperMap):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::::callback):
(WebCore::DOMWrapperWorld::makeContextWeak):

  • bindings/v8/ScriptState.cpp:

(WebCore::::callback):
(WebCore::ScriptState::ScriptState):

  • bindings/v8/ScriptState.h:

(ScriptState):

  • bindings/v8/ScriptWrappable.h:

(ScriptWrappable):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::::callback):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::::callback):
(WebCore::V8AbstractEventListener::setListenerObject):

  • bindings/v8/V8AbstractEventListener.h:

(V8AbstractEventListener):

  • bindings/v8/V8MutationCallback.cpp:

(WebCore::::callback):
(WebCore::V8MutationCallback::V8MutationCallback):

  • bindings/v8/V8MutationCallback.h:

(V8MutationCallback):

  • bindings/v8/V8NPObject.cpp:

(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::set):
(WebCore::::callback):
(WebCore::staticNPObjectMap):

  • bindings/v8/V8Utilities.h:

(WeakHandleListener):
(WebCore::WeakHandleListener::makeWeak):
(WebCore::WeakHandleListener::WeakHandleListener):
(WebCore::WeakHandleListener::invokeWeakCallback):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::::callback):
(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::::callback):
(WebCore::createInjectedScriptHostV8Wrapper):

11:16 PM Changeset in webkit [147390] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2013-04-01 <webkit.review.bot@gmail.com>

[chromium] Roll chromium deps to 191760.
https://bugs.webkit.org/show_bug.cgi?id=113745

Unreviewed, rolling deps.

  • DEPS:
11:16 PM Changeset in webkit [147389] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.

This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.

Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.

No new tests. Please revert immediately after landed.

  • platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

11:15 PM Changeset in webkit [147388] by cevans@google.com
  • 7 edits
    2 adds in trunk

Crash in Node::enclosingBlockFlowElement()
https://bugs.webkit.org/show_bug.cgi?id=113712

Reviewed by Abhishek Arya.

Source/WebCore:

Fix a bad Node assumption if we walk up to the document root.

Test: editing/execCommand/format-block-at-root.html

  • dom/Node.cpp:

(WebCore::Node::isBlockFlowElement): Check we found an Element Node and rename from isBlockFlow().
(WebCore::Node::enclosingBlockFlowElement): Use the new toElement().

  • editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::formatRange): Check for NULL.

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApplyForSingleParagraph):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::enclosingInline): Impact from method rename.

LayoutTests:

  • editing/execCommand/format-block-at-root-expected.txt: Added.
  • editing/execCommand/format-block-at-root.html: Added.
10:51 PM Changeset in webkit [147387] by simonjam@chromium.org
  • 7 edits
    2 adds in trunk

[Resource Timing] Expose timing information for iframes
https://bugs.webkit.org/show_bug.cgi?id=103927

Reviewed by Nate Chapin.

Source/WebCore:

The only catch with main documents is that we only want to record the load that was initiated by
adding the <iframe> to a document. We don't want any subsequent navigations within the iframe to
be reported.

Test: http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::loadDone): Make sure iframes are reported in the parent.

LayoutTests:

  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Fix timeout.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html: Added.
  • http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Remove bad line.
  • platform/chromium/TestExpectations: Unskip tests that relied on iframes.
10:48 PM Changeset in webkit [147386] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Move Path into it's own header
https://bugs.webkit.org/show_bug.cgi?id=113724

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.

Source/WebCore:

No behavioural change.

  • platform/graphics/blackberry/PathBlackBerry.cpp:

Source/WebKit/blackberry:

  • WebKitSupport/DefaultTapHighlight.cpp:
10:43 PM Changeset in webkit [147385] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] canvas is not rendering correctly for www.html5-benchmark.com
https://bugs.webkit.org/show_bug.cgi?id=113716

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.

PR 317205
Internally reivewed by: Mike Lattanzio, Jacky Jiang

This is a site issue where they detect physical pixels by multiplying
availWidth * devicePixelRatio. This gives us an invalid result since
we don't round the CSS pixels that are reported to availWidth and availHeight.

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::toUserSpace):

10:39 PM Changeset in webkit [147384] by hmuller@adobe.com
  • 12 edits
    2 adds in trunk

[CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
https://bugs.webkit.org/show_bug.cgi?id=113600

Reviewed by Dirk Schulze.

Source/WebCore:

ExclusionShapeInsideInfo classes need to depend on the ExclusionShape's padded boundary and
ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary. Added
a virtual method to the ExclusionShapeInfo that returns the ExclusionShape's logical bounding box -
computedShapeLogicalBoundingBox() - and overrode that method in the subclasses to return the
value of the appropriate ExclusionShape method. Added shapeMarginLogicalBoundingBox() and
shapePaddingLogicalBoundingBox() methods to ExclusionShape and removed the shapeLogicalBoundingBox()
method, which did not take shape-margin or shape-padding into account.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html

  • rendering/ExclusionPolygon.h: Defined the padding and margin bounding box virtual methods.
  • rendering/ExclusionRectangle.h: Defined the padding and margin bounding box virtual methods.
  • rendering/ExclusionShape.h: Added the padding and margin bounding box virtual abstract methods. Removed shapeLogicalBoundingBox().

(ExclusionShape):

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::shapeLogicalTop): Now calls computedShapeLogicalBoundingBox().
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalWidth): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalHeight): Ditto.
(ExclusionShapeInfo): Added computedShapeLogicalBoundingBox().

  • rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::computedShapeLogicalBoundingBox): Gets the padded shape's bounding box.

  • rendering/ExclusionShapeOutsideInfo.h:

(ExclusionShapeOutsideInfo):
(WebCore::ExclusionShapeOutsideInfo::computedShapeLogicalBoundingBox): Gets the margin shape's bounding box.

LayoutTests:

Corrected the expected values in the ellipse-margin-left and ellipse-margin-right tests because the
shape-outside float layout code now (correctly) takes into account the shape's margin boundary.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
10:34 PM Changeset in webkit [147383] by abarth@webkit.org
  • 6 edits in trunk

Assertion failure !m_lastChunkBeforeScript in HTMLDocumentParser during inspector/debugger/pause-in-inline-script.html
https://bugs.webkit.org/show_bug.cgi?id=112369

Reviewed by Eric Seidel.

Source/WebCore:

The threaded HTML parser wasn't correctly handling the nested event
loops that can arise from the JavaScript debugger and from
showModalDialog. When the parser received a chunk from the background
parser, it was always processing it immediately, which lead to
re-entrancy. Now, we'll queue the chunk in the speculation buffer and
process it once the stack unwinds.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::PumpSession::PumpSession):

  • html/parser/HTMLParserScheduler.h:

LayoutTests:

Unskip test that is now passing.

  • platform/chromium/TestExpectations:
10:31 PM Changeset in webkit [147382] by commit-queue@webkit.org
  • 4 edits in trunk

[JSC] IndexedDB: Exceptions not thrown for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113689

Patch by Michael Pruett <michael@68k.org> on 2013-04-01
Reviewed by Kentaro Hara.

Source/WebCore:

ScriptValue::serialize() should not clear exceptions thrown during
serialization. This change is needed to match behavior in V8.

Tests: storage/indexeddb/clone-exception.html

storage/indexeddb/exceptions.html
storage/indexeddb/structured-clone.html

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):

LayoutTests:

  • platform/gtk/TestExpectations:
10:29 PM Changeset in webkit [147381] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=113597

Reviewed by Adam Barth.

In the vein of wkbug.com/111233 and wkbug.com/110820 don't just comment that
some condition is true only in unit tests - ASSERT that Chromium's unitTestSupport()
is non-null to catch errors during development.

Exercised by Chromium's webkit_unit_tests.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):

10:06 PM Changeset in webkit [147380] by shinyak@chromium.org
  • 198 edits
    5 adds
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r147347.
http://trac.webkit.org/changeset/147347

broke Chromium Linux test
The same reason as the previous rollout.

  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium/TestExpectations:
9:54 PM Changeset in webkit [147379] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support some more integer arithmetic ops (negate, xor, urshift)
https://bugs.webkit.org/show_bug.cgi?id=113740

Reviewed by Geoffrey Garen.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildNeg):
(JSC::FTL::buildLShr):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::neg):
(JSC::FTL::Output::lShr):

9:46 PM Changeset in webkit [147378] by shinyak@chromium.org
  • 381 edits in trunk/LayoutTests

Unreviewed, rolling out r147351.
http://trac.webkit.org/changeset/147351

broke Chromium Linux test
The same reason as the previous rollout.

  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
9:28 PM Changeset in webkit [147377] by shinyak@chromium.org
  • 9 edits
    1 move
    1 delete in trunk/LayoutTests

Unreviewed, rolling out r147358.
http://trac.webkit.org/changeset/147358

broke Chromium Linux test
In the flakiness dashboard, this rebaseline looks good, however actually it broke Chromium Linux Test bots.
Maybe something bad is happening, but let me revert them again.

  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.
8:02 PM Changeset in webkit [147376] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
7:22 PM Changeset in webkit [147375] by roger_fong@apple.com
  • 3 edits
    1 add in trunk

VS2010 WebCoreGenerated build scripts should use new feature-defines script.
Update FEATURE_DEFINES string generation for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=113737.

Reviewed by Timothy Horton.

  • WebCore.vcxproj/build-generated-files.sh:
  • win/tools/scripts/feature-defines2010.sh: Added.
6:23 PM Changeset in webkit [147374] by ojan@chromium.org
  • 7 edits
    1 copy
    1 move
    1 add
    1 delete in trunk/LayoutTests

Test rebaselines after r147245.

  • fast/table/overflowHidden-expected.txt:
  • platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/overflowHidden-expected.txt: Copied from LayoutTests/fast/table/overflowHidden-expected.txt.
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win-7sp0/fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/win/fast/table/overflowHidden-expected.txt.
5:26 PM Changeset in webkit [147373] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770

Reviewed by David Levin.

Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.

Also, unconditionally start laying out from the minimum height, so that the
documentRect can shrink below its previous height if needed.

No new tests; autosizing is not currently exposed in a testable way on Mac.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

5:10 PM Changeset in webkit [147372] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Bot greening failed test from http://trac.webkit.org/changeset/147317.
The test should use testRunner, not layoutTestController.

Unreviewed.

  • fast/text/emphasis-height-crash.html:
5:03 PM Changeset in webkit [147371] by hayato@chromium.org
  • 15 edits in trunk

[Shadow DOM] Change the order of event dispatching at AT_TARGET phase.
https://bugs.webkit.org/show_bug.cgi?id=113676

Reviewed by Dimitri Glazkov.

Source/WebCore:

Change the order of event dispatching at AT_TARGET phase so that it mimics bubbling events.

The spec side bug is:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21404

Example:

Given the event path, from Node A (top-most) to Node G (target,
inner-most), where C and D are shadow hosts and G is the target,
the event dispatching order in the current WebKit implementation is:
(T: AT_TARGET, C: CAPTURING, B: BUBBLING)

For bubbling events:

A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 3 (T)
D 4 (C) 9 (B)
E (SH) 5 (T)
F 6 (C) 8 (B)
G (Target) 7 (T)

For non-bubbling events:

A 1 (C)
B 2 (C)
C (SH) 3 (T)
D 4 (C)
E (SH) 5 (T)
F 6 (C)
G (Target) 7 (T)

This patch has changed the order of event dispatching as follows:

For bubbling events:

A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 9 (T)
D 3 (C) 8 (B)
E (SH) 7 (T)
F 4 (C) 6 (B)
G (Target) 5 (T)

For non-bubbling events:

A 1 (C)
B 2 (C)
C (SH) 7 (T)
D 3 (C)
E (SH) 6 (T)
F 4 (C)
G (Target) 5 (T)

No new tests, updating existing layouts.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

  • dom/EventDispatcher.h:

(EventDispatcher):

LayoutTests:

  • fast/dom/shadow/cppevent-in-shadow-expected.txt:
  • fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
  • fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
  • fast/dom/shadow/gesture-tap-expected.txt:
  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
  • fast/dom/shadow/shadow-root-blur-expected.txt:
5:00 PM Changeset in webkit [147370] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::HTMLMediaElement::~HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=113531

Reviewed by Adam Barth.

No new tests, though this is intermittently reproducible with
http/tests/misc/delete-frame-during-readystatechange.html under ASAN.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear the media player manually

before the destructor exits. Clearing the media player may cancel a resource load,
which can trigger a readystatechange event. It's possible for the HTMLMediaElement
to attempt to fire an abort event within the readystatechange event, even though it is
now in an inconsistent state. Clearling the media player before finishing the destructor
ensures that the HTMLMediaElement will at least still be alive if this case is triggered.
Set m_completelyLoaded to true to ensure that if userCancelledLoad() is called, it doesn't
attempt to fire events while destructing.

4:35 PM Changeset in webkit [147369] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r146373.
http://trac.webkit.org/changeset/146373
https://bugs.webkit.org/show_bug.cgi?id=113731

broke autosizing shrinking past previous size (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

4:19 PM Changeset in webkit [147368] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support GetGlobalVar/PutGlobalVar
https://bugs.webkit.org/show_bug.cgi?id=113728

Reviewed by Gavin Barraclough.

Removed the macro magic for the globals absolute abstract heap, since for anything
with absolute addresses we can just share a common absolute abstract heap. It
would only be a problem if we for example were emitting an access to a global but
not using an absolute address, and then wanted to say that this access was
constrained to global variables. I don't believe we do that, and I don't believe we
ever will.

Then added Output::absolute(), a convenient way of building a typed pointer for an
absolute address.

Then added GetGlobalVar/PutGlobalVar.

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):
(AbstractHeapRepository):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetGlobalVar):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePutGlobalVar):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::absolute):
(Output):

3:41 PM Changeset in webkit [147367] by Nate Chapin
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update after r147357.

  • platform/chromium/TestExpectations:
3:02 PM Changeset in webkit [147366] by aelias@chromium.org
  • 2 edits in branches/chromium/1453/Source/WebKit/chromium

Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."

[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

  • src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190018

2:46 PM Changeset in webkit [147365] by roger_fong@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

  • platform/win/TestExpectations:
  • platform/win/fast/table: Added.
  • platform/win/fast/table/overflowHidden-expected.txt: Added.
2:36 PM Changeset in webkit [147364] by jchaffraix@webkit.org
  • 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderTableCell.cpp

Merge 145822 "REGRESSION(r145305) Performance: 1.3% mac-release-..."

REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
https://bugs.webkit.org/show_bug.cgi?id=112125

Reviewed by Julien Chaffraix.

When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

TBR=jchaffraix@webkit.org
Review URL: https://codereview.chromium.org/13393017

2:33 PM Changeset in webkit [147363] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

WebCache should do the normal initialization dance
https://bugs.webkit.org/show_bug.cgi?id=113722
<rdar://problem/13424530>

Reviewed by Anders Carlsson.

In case a WebKit1 client uses WebCache before creating a WebView (or any of the other
initialization-ready classes), we should do the initialization work in WebCache as well.

  • Misc/WebCache.mm:

(+[WebCache initialize]):

2:32 PM Changeset in webkit [147362] by timothy@apple.com
  • 5 edits in trunk/Source

Allow changing Web Inspector dock sides without undocking first.

https://webkit.org/b/113661
rdar://problem/13543127

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): Initialize m_dockSide.

(WebCore::InspectorFrontendClientLocal::canAttachWindow): If we are already attached, allow
attaching again to allow switching sides.

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Set m_dockSide.

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal): Added m_dockSide.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Send AttachedBottom and
AttachedRight messages so InspectorFrontendClientLocal knows which side we
are attached.

(WebKit::WebInspectorProxy::canAttach): If we are already attached, allow
attaching again to allow switching sides.

2:27 PM Changeset in webkit [147361] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Nor this! (Who reviewed this anyway!)

  • WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::storageArea):

2:19 PM Changeset in webkit [147360] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Didn't mean to commit this!

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
2:12 PM Changeset in webkit [147359] by ap@apple.com
  • 5 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=113721
<rdar://problem/13549181> REGRESSION (r146929): HTTP auth credentials not reused during session

Reviewed by Brady Eidson.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Added an override that we still need. It's not great, but causes no trouble for NetworkProcess. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Implement in terms of sync version to avoid duplicating logic.
1:56 PM Changeset in webkit [147358] by Nate Chapin
  • 9 edits
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed, chromium gardening.

  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium/css3/images/cross-fade-background-size-expected.png: Removed.
1:48 PM Changeset in webkit [147357] by aelias@chromium.org
  • 17 edits in trunk

[chromium] Delete code behind if (!applyXYZScaleInCompositor)
https://bugs.webkit.org/show_bug.cgi?id=111809

Reviewed by James Robinson.

Chromium is setting the flags applyPageScaleFactorInCompositor and
applyDeviceScaleFactorInCompositor permanently to true, so any code
in platform/chromium with the false setting is dead. Delete all of
it.

I also switched FrameTestHelpers and DumpRenderTree to always turn the
setting to true so that they test the code we're actually running.
This exposed a number of failing tests which I added in the
expectations file.

Note also that I made calls to setPageScaleFactor turn on
force-compositing-mode to make the layout tests work, as
pageScaleFactor is now ignored in non-composited mode.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/PageWidgetDelegate.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::scaledSize):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::contentsSize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebView):

  • tests/WebFrameTest.cpp:
  • tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):

1:33 PM Changeset in webkit [147356] by timothy@apple.com
  • 4 edits in trunk

Make 'this' evaluate to the correct object when paused in the Debugger.

https://webkit.org/b/113607
rdar://problem/13538351

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Bind 'this' to the expression function.

LayoutTests:

  • platform/mac/http/tests/inspector/console-resource-errors-expected.txt:
1:10 PM Changeset in webkit [147355] by vcarbune@chromium.org
  • 6 edits
    2 adds in trunk

TextTrackCue Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109821

Reviewed by Eric Carlson.

Source/WebCore:

The TextTrackCue gets a new attribute and setting, regionId, which specifies
to which region the cue belongs to. The attribute is guarded by WEBVTT_REGIONS
and is by default disabled in ports.

Test: media/track/regions-webvtt/text-track-cue-region-attribute.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue): Added member variable for the regionId attribute.
(WebCore):
(WebCore::TextTrackCue::setRegionId): Setter for the regionId attribute.
(WebCore::TextTrackCue::settingName): Added RegionId setting name.
(WebCore::TextTrackCue::setCueSettings): Parsed the "region:" cue setting.

  • html/track/TextTrackCue.h:

(TextTrackCue):
(WebCore::TextTrackCue::regionId): Getter for the regionId attribute.

  • html/track/TextTrackCue.idl: Updated to match the WebVTT Regions Extension.

LayoutTests:

  • media/track/captions-webvtt/header-regions.vtt: Updated to include cues with

settings for which the "region:" setting should be ignored (for backwards compatibility
regarding WebVTT rendering rules).

  • media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Added.
  • media/track/regions-webvtt/text-track-cue-region-attribute.html: Added.
1:05 PM Changeset in webkit [147354] by andersca@apple.com
  • 10 edits in trunk/Source

Apply changes from storage events locally
https://bugs.webkit.org/show_bug.cgi?id=111502

Reviewed by Sam Weinig.

Source/WebCore:

Add and export a helper function for setting an item without taking
into account the quota for the map. Also, reindent StorageMap.h

  • WebCore.exp.in:
  • storage/StorageMap.cpp:

(WebCore::StorageMap::setItemIgnoringQuota):
(WebCore):

  • storage/StorageMap.h:

(StorageMap):
(WebCore::StorageMap::quota):

Source/WebKit2:

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
Store the security origin as a member variable.

(WebKit::StorageAreaProxy::dispatchStorageEvent):
Set the item and call the appropriate event dispatch function.

(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
Add stubs.

  • WebProcess/Storage/StorageAreaProxy.h:
1:01 PM Changeset in webkit [147353] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove a couple of malloc from ExceptionBase construction
https://bugs.webkit.org/show_bug.cgi?id=113681

Reviewed by Darin Adler.

  • dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):
When the condition is true, we were creating a new String for
description.name. The constructor had already allocated a string for
that: m_name. Use that string instead of creating a new one.

When the condition is false, we were creating a String for typeName
just to use the string operators. This is a waste of time, we can use
makeString() to invoke the string concatenation functions directly.

12:59 PM Changeset in webkit [147352] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.5/Source/WebCore

Merged r147287. <rdar://problem/13541868>

12:52 PM Changeset in webkit [147351] by Nate Chapin
  • 381 edits
    2 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

  • platform/chromium-linux-x86/svg/dynamic-updates: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
12:49 PM Changeset in webkit [147350] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Move remaining marquee applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=113298

Reviewed by Allan Sandfeld Jensen.

Move applying logic for CSSPropertyWebkitMarqueeIncrement,
CSSPropertyWebkitMarqueeRepetition and CSSPropertyWebkitMarqueeSpeed
from StyleResolver::applyProperty.

No new tests, no change in functionality.

  • css/StyleBuilder.cpp:

(ApplyPropertyMarqueeIncrement):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::createHandler):
(WebCore):
(ApplyPropertyMarqueeRepetition):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::createHandler):
(ApplyPropertyMarqueeSpeed):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Move marquee applying logic from StyleResolver to StyleBuilder.

  • rendering/style/RenderStyle.h:

Change setMarqueeIncrement to pass Length by value instead of const
reference. This is consistent with other length setters and works with
the ApplyPropertyLength template.

12:39 PM Changeset in webkit [147349] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for JSC's APIs
https://bugs.webkit.org/show_bug.cgi?id=113651

Reviewed by Andreas Kling.

This removes a bunch of branches on initialization and when
filling the vector.

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackObjectFunctions.h:

(JSC::::construct):
(JSC::::call):

  • API/JSObjectRef.cpp:

(JSObjectCopyPropertyNames):

11:55 AM Changeset in webkit [147348] by pdr@google.com
  • 19 edits
    6 adds in trunk

[SVG2] Add support for the buffered-rendering hint
https://bugs.webkit.org/show_bug.cgi?id=104207

Reviewed by Stephen Chenney.

Source/WebCore:

This patch adds the SVG2 buffered-rendering property and implements it for the image
element. For reference, the spec can be found at:

https://svgwg.org/svg2-draft/single-page.html#painting-BufferedRendering

The buffered-rendering hint causes our implementation to create a temporary image buffer
for caching an element's foreground rendering. This behavior has been designed to support
other graphical and container elements in followup patches (such as the use and g elements).
This patch should not affect rendering, and a test has been added showing the image
results are unchanged.

The performance aspects of this patch can be tested using the following test:

http://philbit.com/bouncingTigers.html

Without the patch, rendering is below 1fps. With the patch, rendering is fluid.

Tests: svg/css/buffered-rendering.html

svg/repaint/buffered-rendering-dynamic-image.html
svg/repaint/buffered-rendering-static-image.html

Other than the changes to RenderSVGImage and SVGRenderingContext, the changes below are to
support the new buffered-rendering property:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/SVGCSSValueKeywords.in:
  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBufferedRendering):
(WebCore::SVGRenderStyle::setBufferedRendering):
(WebCore::SVGRenderStyle::bufferedRendering):
(WebCore::SVGRenderStyle::setBitDefaults):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

The foreground painting has been extracted out into a separate function. This has also
been changed so that if the buffered-rendering hint is present, bufferForeground
is used.

(WebCore::RenderSVGImage::paintForeground):
(WebCore):
(WebCore::RenderSVGImage::invalidateBufferedForeground):

This function could be replaced with "m_bufferedForeground.clear()" but other renderers
(such as container elements) will require more complex invalidation logic. To
maintain consistency with this future code, invalidateBufferedForeground has been used.

(WebCore::RenderSVGImage::imageChanged):

  • rendering/svg/RenderSVGImage.h:

(RenderSVGImage):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::bufferForeground):
(WebCore):

  • rendering/svg/SVGRenderingContext.h:

(SVGRenderingContext):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):

  • svg/svgattrs.in:

LayoutTests:

  • svg/css/buffered-rendering-expected.txt: Added.
  • svg/css/buffered-rendering.html: Added.
  • svg/repaint/buffered-rendering-dynamic-image-expected.html: Added.
  • svg/repaint/buffered-rendering-dynamic-image.html: Added.
  • svg/repaint/buffered-rendering-static-image-expected.html: Added.
  • svg/repaint/buffered-rendering-static-image.html: Added.
11:39 AM Changeset in webkit [147347] by Nate Chapin
  • 198 edits
    3 adds
    4 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

  • platform/chromium-linux-x86/fast/backgrounds/repeat: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium/TestExpectations:
11:24 AM Changeset in webkit [147346] by mkwst@chromium.org
  • 14 edits in trunk

CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation.
https://bugs.webkit.org/show_bug.cgi?id=113502

Reviewed by Adam Barth.

Source/WebCore:

Now that we're passing in 'effectiveDirective', we don't need the 'type'
parameter to generate the proper error message prefix when reporting
violations.

While I'm here, I'll slightly tweak the grammar for the error messages.
Changes are covered via rebaselines of existing tests.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Drop the 'type' parameter. We don't need to pass in a type since
we're now passing in the 'effectiveDirective'; we can use the latter
to generate the correct error message prefix.

(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):
(WebCore::CSPDirectiveList::allowBaseURI):

Drop the 'type' parameter from the callsites, which has the lovely
property of allowing us to throw away a bunch of statically allocated
strings that we don't need anymore.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-track-block-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • platform/chromium/media/csp-blocks-video-expected.txt:
11:24 AM Changeset in webkit [147345] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Move definition of nested classes that inherit enclosing class outside class definition.
https://bugs.webkit.org/show_bug.cgi?id=113454

Patch by Han Shen <shenhan@google.com> on 2013-04-01
Reviewed by Benjamin Poulain.

HashMap.h does not build on GCC 4.8. Inside this file,
HashMapKeysProxy and HashMapValuesProxy are defined as nested
class inside HashMap - which is legal - the illegal part is that
these 2 classes inherit HashMap, that is the enclosing class, that
causes "reference to in-complete definition" error.

The fix is to move outside the definition of these 2 classes, and
leave only declaration part inside HashMap as is illustrated below -

template class <typename T>
class HashMap {

... ...
... ...

private:

class HashMapKeysProxy;

ERROR - nested class inherits enclosing class.
class HashMapKeysProxy : private HashMap {

... ...

};
... ...
... ...
class HashMapKeysProxy : private HashMap {

... ...

};
... ...
... ...

};

Fixed as below:

template class <typename T>
class HashMap {

... ...
... ...

private:

class HashMapKeysProxy;
class HashMapValuesProxy;

... ...
... ...

};

template <typename T>
class HashMap<T>::HashMapKeysProxy : private HashMap<T> {

... ...

};

template <typename T>
class HashMap<T>::HashMapValuesProxy : private HashMap<T> {

... ...

};

  • wtf/HashMap.h:

(HashMap):
(WTF): Factor out nested class definition from enclosing class.

11:06 AM Changeset in webkit [147344] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13490123> Sandbox extension tracking is incorrect when restoring a session
https://bugs.webkit.org/show_bug.cgi?id=113709

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Added an assertion to catch extension tracking logic errors that could result in giving an extension to non-local pages. (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): Just like below, clearing m_pendingProvisionalSandboxExtension appears incorrect, even though I am not aware of any scenarios where this happens in practice. (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): The load may be failing exactly because a new one cancels it, so we shouldn't be preventing the new one from using its extension.
11:05 AM Changeset in webkit [147343] by commit-queue@webkit.org
  • 12 edits in trunk

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549

Patch by James Craig <james@cookiecrook.com> on 2013-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):

Source/WebCore/platform/gtk/po:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.

  • en_CA.po:
  • en_GB.po:

LayoutTests:

Updating the video/audio element's default accessibility labels to be less verbose.

  • platform/gtk/accessibility/media-controls-panel-title-expected.txt:
  • platform/gtk/accessibility/media-controls-panel-title.html:
  • platform/gtk/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
11:05 AM Changeset in webkit [147342] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

SharedMemory release build hardening.
<rdar://problem/13546860> and https://bugs.webkit.org/show_bug.cgi?id=113710

Reviewed by Anders Carlsson.

Successful creation of a memory entry with a size less than the size we requested should be treated
as a failure to create the SharedMemory object.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::createFromVMBuffer): Early return if the port we get is bogus for our needs.
(WebKit::SharedMemory::createHandle): Ditto.
(WebKit::SharedMemory::create): Guarantee we pass valid input in to mach_vm_map.

11:00 AM Changeset in webkit [147341] by pfeldman@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1410

Revert 140817 "Web Inspector: [Styles] Editing a property value ..."
BUG=225346

Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
https://bugs.webkit.org/show_bug.cgi?id=107936

Reviewed by Yury Semikhatsky.

Source/WebCore:

Restore the original CSS property value before editing.

Test: inspector/styles/edit-value-with-trimmed-url.html

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

  • inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
  • inspector/styles/edit-value-with-trimmed-url.html: Added.

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/13084008

10:57 AM Changeset in webkit [147340] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.5/Source

Versioning.

10:50 AM Changeset in webkit [147339] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.5

New Tag.

10:03 AM Changeset in webkit [147338] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r147319.
http://trac.webkit.org/changeset/147319
https://bugs.webkit.org/show_bug.cgi?id=113707

The unit test is still failing on the buildbot (Requested by
zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

  • Scripts/run-gtk-tests:

(TestRunner):

10:00 AM Changeset in webkit [147337] by fpizlo@apple.com
  • 7 edits
    5 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArithSub
https://bugs.webkit.org/show_bug.cgi?id=113675

Reviewed by Oliver Hunt.

This does the obvious bit of implementing ArithSub, but it also takes this
as an opportunity to clean up how intrinsics and common values (common types
and constants) are handled. Previously they were all lumped together in
FTL::Output. Now, in an effort to split up the files and make FTL::Output
less big, I created a thing called FTL::CommonValues which just tracks the
common values, and a thing called FTL::IntrinsicRepository which just tracks
intrinsics. These and FTL::Output are all related to each other in a linear
hierarchy. Moreover, IntrinsicRepository uses macro-fu to make it easy to
declare new intrinsics in the future.

I also out-of-lined some things and made .cpp files for each of these classes.
Initialize I wasn't going to do this but then I realized that FTL::Output is
already included in multiple places. Probably it's better if some of its guts
are not inline, and it's also good to now have .cpp "landing pads" if we ever
want to add more things to that class.

Note that a lot of how these things are designed has to do with the fact
that pretty soon here I'll have to switch us from using the LLVM global
context to using a context that we create. When that happens, anyone who
creates anything will have to know the context; that's why FTL::CommonValues
already knows the module but doesn't use it - in the future it will have to
do things with it.

(JSC::FTL::buildSub):

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCommonValues.cpp: Added.

(FTL):
(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h: Added.

(FTL):
(CommonValues):
(JSC::FTL::CommonValues::initialize):

  • ftl/FTLIntrinsicRepository.cpp: Added.

(FTL):
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):

  • ftl/FTLIntrinsicRepository.h: Added.

(FTL):
(IntrinsicRepository):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(LowerDFGToLLVM):

  • ftl/FTLOutput.cpp: Added.

(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):

  • ftl/FTLOutput.h:

(Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::sub):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::subWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):

9:54 AM Changeset in webkit [147336] by Nate Chapin
  • 3 edits in trunk/Source/WebCore

Make a bunch of DocumentLoader functions private
https://bugs.webkit.org/show_bug.cgi?id=113601

Reviewed by Alexey Proskuryakov.

No new tests, cleanup only.

  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
9:44 AM Changeset in webkit [147335] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixing borked VS 2010 project file

Unreviewed bot greening.

9:32 AM Changeset in webkit [147334] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

One more Windows build fix

Unreviewed.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
9:26 AM Changeset in webkit [147333] by kangil.han@samsung.com
  • 3 edits in trunk/Source/WebCore

Minor code cleanup by removing duplicated null checks
https://bugs.webkit.org/show_bug.cgi?id=113701

Reviewed by Darin Adler.

Duplicated null check is code redundancy, so delete those.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setFocusedNodeIfNeeded):

  • platform/Arena.cpp:

(WebCore::FreeArenaList):

9:18 AM Changeset in webkit [147332] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

More build fallout fixes.

Unreviewed build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Add new export symbols.
  • heap/SuperRegion.cpp: Windows didn't like "LLU".
9:14 AM Changeset in webkit [147331] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: follow up to r147323, popover is empty on network panel.
Not reviewed.

  • inspector/front-end/DOMExtension.js:

(Element.prototype.measurePreferredSize):

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

9:01 AM Changeset in webkit [147330] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

r147324 broke the world
https://bugs.webkit.org/show_bug.cgi?id=113704

Unreviewed build fix.

Remove a bunch of unused variables and use the correctly sized types for 32-bit platforms.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h:

(BlockAllocator):

  • heap/Heap.cpp:

(JSC::Heap::Heap):

  • heap/SuperRegion.cpp:

(JSC::SuperRegion::SuperRegion):

  • heap/SuperRegion.h:

(SuperRegion):

8:35 AM Changeset in webkit [147329] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

32-bit Windows build fix

Unreviewed build fix.

  • heap/SuperRegion.cpp:
  • heap/SuperRegion.h: Use uint64_t instead of size_t.

(SuperRegion):

8:28 AM Changeset in webkit [147328] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

EFL build fix

Unreviewed build fix.

  • CMakeLists.txt:
8:26 AM Changeset in webkit [147327] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Exception in console on attempt to filter javascript messages.
https://bugs.webkit.org/show_bug.cgi?id=113327

Fixed non-css filtration if console message groups are present. Message groups elements are always shown and are
never filtered out.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.updateRepeatCount):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._printResult):

8:25 AM Changeset in webkit [147326] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL doesn't need virtual register allocation
https://bugs.webkit.org/show_bug.cgi?id=113679

Reviewed by Mark Hahnenberg.

  • dfg/DFGDriver.cpp:

(JSC::DFG::dumpAndVerifyGraph):
(DFG):
(JSC::DFG::compile):

8:24 AM Changeset in webkit [147325] by vcarbune@chromium.org
  • 12 edits
    3 adds in trunk

Parsing WebVTT Region Header Metadata
https://bugs.webkit.org/show_bug.cgi?id=109818

Reviewed by Eric Carlson.

Source/WebCore:

This patch enables reading regions from the metadata section of
a WebVTT file. The work for defining generic metadata within the
WebVTT file header is still work in progress in the TextTrack CG.

As previous patches, everything is guarded by WEBVTT_REGIONS and
is by default disabled in all ports.

Test: media/track/regions-webvtt/text-track-region-parser.html

  • html/track/LoadableTextTrack.cpp:

(WebCore):
(WebCore::LoadableTextTrack::newRegionsAvailable): Added method
to be called as soon as regions have finished parsing.

  • html/track/LoadableTextTrack.h:

(LoadableTextTrack):

  • html/track/TextTrack.h: Changed the access modifiers.

(TextTrack):

  • html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::setRegionSettings): Entry point for
parsing the region settings from a string.
(WebCore):
(WebCore::TextTrackRegion::getSettingFromString): Maps a string
to a RegionSetting value.
(WebCore::TextTrackRegion::parseSettingValue): Parses the value
of a specific setting.
(WebCore::TextTrackRegion::parseSetting): Parses a setting string.

  • html/track/TextTrackRegion.h:
  • html/track/WebVTTParser.cpp:

(WebCore):
(WebCore::WebVTTParser::parseFloatPercentageValue): Helper method
to parse a float percentage value (e.g. "50.1%")
(WebCore::WebVTTParser::parseFloatPercentageValuePair): Helper method
to parse a float percentage value pair (e.g. "50.1%, 30.5%")
(WebCore::WebVTTParser::getNewRegions): Retrieves the new regions
available for processing.
(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectHeader): Generic function to collect
header in the metadata region.
(WebCore::WebVTTParser::createNewRegion): Creates new region using
the existing metadata header name and value.

  • html/track/WebVTTParser.h:

(WebVTTParserClient):
(WebVTTParser):

  • loader/TextTrackLoader.cpp:

(WebCore):
(WebCore::TextTrackLoader::newRegionsParsed): Called when the
regions have been succesfully parsed.
(WebCore::TextTrackLoader::getNewRegions): Gets the new regions.

  • loader/TextTrackLoader.h:

(TextTrackLoaderClient): Added methods that need to be implemented.
(TextTrackLoader):

LayoutTests:

  • media/track/captions-webvtt/header-regions.vtt: Added.
  • media/track/regions-webvtt/text-track-region-parser-expected.txt: Added.
  • media/track/regions-webvtt/text-track-region-parser.html: Added.
8:23 AM Changeset in webkit [147324] by mhahnenberg@apple.com
  • 18 edits
    2 adds in trunk/Source

Regions should be allocated from the same contiguous segment of virtual memory
https://bugs.webkit.org/show_bug.cgi?id=113662

Reviewed by Filip Pizlo.

Instead of letting the OS spread our Regions all over the place, we should allocate them all within
some range of each other. This change will open the door to some other optimizations, e.g. doing simple
range checks for our write barriers and compressing JSCell pointers to 32-bits.

Source/JavaScriptCore:

Added new SuperRegion class that encapsulates allocating Regions from a contiguous reserved chunk of
virtual address space. It functions very similarly to the FixedVMPoolExecutableAllocator class used by the JIT.

Also added two new subclasses of Region, NormalRegion and ExcessRegion.

NormalRegion is the type of Region that is normally allocated when there is available space remaining
in the SuperRegion. If we ever run out of space in the SuperRegion, we fall back to allocating
ExcessRegions, which are identical to how Regions have behaved up until now, i.e. they contain a
PageAllocationAligned.

We only use the SuperRegion (and NormalRegions) on 64-bit systems, since it doesn't make sense to reserve the
entire 4 GB address space on 32-bit systems just for the JS heap.

(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h:

(JSC):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::allocateCustomSize):
(JSC::BlockAllocator::deallocateCustomSize):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC):
(JSC::Heap::didExceedFixedHeapSizeLimit):

  • heap/Heap.h:

(Heap):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):

  • heap/Region.h:

(Region):
(JSC):
(NormalRegion):
(JSC::NormalRegion::base):
(JSC::NormalRegion::size):
(ExcessRegion):
(JSC::ExcessRegion::base):
(JSC::ExcessRegion::size):
(JSC::NormalRegion::NormalRegion):
(JSC::NormalRegion::tryCreate):
(JSC::NormalRegion::tryCreateCustomSize):
(JSC::NormalRegion::reset):
(JSC::ExcessRegion::ExcessRegion):
(JSC::ExcessRegion::~ExcessRegion):
(JSC::ExcessRegion::create):
(JSC::ExcessRegion::createCustomSize):
(JSC::ExcessRegion::reset):
(JSC::Region::Region):
(JSC::Region::initializeBlockList):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::~Region):
(JSC::Region::destroy):
(JSC::Region::reset):
(JSC::Region::deallocate):
(JSC::Region::base):
(JSC::Region::size):

  • heap/SuperRegion.cpp: Added.

(JSC):
(JSC::SuperRegion::SuperRegion):
(JSC::SuperRegion::getAlignedBase):
(JSC::SuperRegion::allocateNewSpace):
(JSC::SuperRegion::notifyNeedPage):
(JSC::SuperRegion::notifyPageIsFree):

  • heap/SuperRegion.h: Added.

(JSC):
(SuperRegion):

Source/WTF:

  • wtf/MetaAllocator.cpp: Changed the MetaAllocator to allow custom page sizes if the derived class wants to

use something other than the system page size.
(WTF::MetaAllocator::MetaAllocator):

  • wtf/MetaAllocator.h:

(MetaAllocator):

7:03 AM Changeset in webkit [147323] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
https://bugs.webkit.org/show_bug.cgi?id=113702

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMExtension.js:

(Element.prototype.measurePreferredSize):

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

  • inspector/front-end/ViewportControl.js:

(WebInspector.ViewportControl.prototype.refresh):

  • inspector/front-end/dialog.css:

(.dialog-contents):

5:52 AM Changeset in webkit [147322] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: [DTE] Convertion between text and coordinates
https://bugs.webkit.org/show_bug.cgi?id=113389

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/editor/text-editor-char-to-coordinates.html

Implement cursorPositionToCoordinates and coordinatesToCursorPosition
methods pair in DefaultTextEditor.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.DefaultTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.TextEditorMainPanel.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditorMainPanel.prototype.coordinatesToCursorPosition):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditor.prototype.coordinatesToCursorPosition):

LayoutTests:

Test to verify added functionality.

  • inspector/editor/text-editor-char-to-coordinates-expected.txt: Added.
  • inspector/editor/text-editor-char-to-coordinates.html: Added.
5:47 AM Changeset in webkit [147321] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Rename "Copy to Curl" menu item command to "Copy to cURL"
https://bugs.webkit.org/show_bug.cgi?id=113575

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

Fix the name to the offical way of capitalization.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

5:13 AM Changeset in webkit [147320] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
3:46 AM Changeset in webkit [147319] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-01
Reviewed by Carlos Garcia Campos.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.

3:39 AM Changeset in webkit [147318] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests added in r147249 and r147250 that fail

due to disabled subpixel layout. Adding failure expectations for tests that regressed with r147241.

  • platform/gtk/fast/events/event-attribute-expected.txt: Added the required baseline after r147205.
3:35 AM Changeset in webkit [147317] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: m_purgePreventCount when clicking text with emphasis marks
https://bugs.webkit.org/show_bug.cgi?id=85266

Patch by Koji Ishii <Koji Ishii> on 2013-04-01
Reviewed by Darin Adler.

Font::glyphDataAndPageForCharacter may call FontCache::getFontDataForCharacters
if system fallback occurs, which may return SimpleFontData with DoNotRetain,
so callers must prevent possible font cache purging.

Source/WebCore:

Test: fast/text/emphasis-height-crash.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::emphasisMarkAscent): Add FontCachePurgePreventer.
(WebCore::Font::emphasisMarkDescent): ditto.
(WebCore::Font::emphasisMarkHeight): ditto.
(WebCore::Font::drawEmphasisMarks): ditto.

LayoutTests:

  • fast/text/emphasis-height-crash-expected.txt: Added.
  • fast/text/emphasis-height-crash.html: Added.
3:32 AM Changeset in webkit [147316] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove an unused variable from the ARMv7 Assembler
https://bugs.webkit.org/show_bug.cgi?id=113653

Reviewed by Andreas Kling.

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):

3:29 AM Changeset in webkit [147315] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113677

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-01

  • platform/gtk/TestExpectations: Rebaseline after r147219.
3:25 AM Changeset in webkit [147314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fixed DOM Breakpoint pane styles.
https://bugs.webkit.org/show_bug.cgi?id=113688

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

2:41 AM Changeset in webkit [147313] by yurys@chromium.org
  • 2 edits in trunk/Source/WTF

Web Inspector: add memory instrumentation for StringBuffer
https://bugs.webkit.org/show_bug.cgi?id=113507

Reviewed by Pavel Feldman.

Added memory instrumentation for StringBuffer.

  • wtf/MemoryInstrumentationString.h:

(WTF):
(WTF::reportMemoryUsage):

2:39 AM Changeset in webkit [147312] by shinyak@chromium.org
  • 198 edits
    1 move
    4 adds
    19 deletes in trunk/LayoutTests

Unreviewed, rolling out r147298.
http://trac.webkit.org/changeset/147298

broke lots of layout tests

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
  • platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
  • platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.
2:27 AM Changeset in webkit [147311] by shinyak@chromium.org
  • 237 edits
    6 deletes in trunk/LayoutTests

Unreviewed, rolling out r147301.
http://trac.webkit.org/changeset/147301

broke lots of layout tests

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
2:18 AM Changeset in webkit [147310] by shinyak@chromium.org
  • 153 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r147302.
http://trac.webkit.org/changeset/147302

broke lots of layout tests

  • platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
2:02 AM Changeset in webkit [147309] by commit-queue@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed, rolling out r147307.
http://trac.webkit.org/changeset/147307
https://bugs.webkit.org/show_bug.cgi?id=113692

maybe broken lots of layout tests (Requested by
shinyak|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
1:13 AM Changeset in webkit [147308] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=113682

Reviewed by Yury Semikhatsky.

The calculation was extracted into entryToAnchorBox.

Drive by fixes: unnecessary members were removed.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Entry):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._entryToAnchorBox):
(WebInspector.FlameChart.prototype.draw):

12:19 AM Changeset in webkit [147307] by shinyak@chromium.org
  • 1 edit
    10 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
12:04 AM Changeset in webkit [147306] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Enable user-select:all for EFL port
https://bugs.webkit.org/show_bug.cgi?id=113494

.:

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.

Add a feature flag for user-select:all and enable it for EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

LayoutTests:

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.

Enable user-select:all for EFL port and update the TestExpectations.

  • platform/efl/TestExpectations:

Mar 31, 2013:

11:55 PM Changeset in webkit [147305] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/Tools

Unreviewed, rolling out r147289.
http://trac.webkit.org/changeset/147289
https://bugs.webkit.org/show_bug.cgi?id=113678

broke Win7 (dbg) build (Requested by shinyak|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-31

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.

(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

11:29 PM Changeset in webkit [147304] by abarth@webkit.org
  • 2 edits in trunk/Tools

configure-svn-config.sh fails
https://codereview.chromium.org/13392007/

Reviewed by Eric Seidel.

This script was trying to use "svn checkout" to dowload a file from
svn.webkit.org, but "svn checkout" only works with directories.
Instead, we should use "svn export".

  • EWSTools/configure-svn-config.sh:
11:14 PM FeatureFlags edited by tkent@chromium.org
VIEWSOURCE_ATTRIBUTE (diff)
10:54 PM Changeset in webkit [147303] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Gradient background does not get repainted when child box is expanded.
https://bugs.webkit.org/show_bug.cgi?id=113644

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.

The initial value for background-size is SizeNone and remains, unless it is
set explicitly. However, when the background shorthand is used,
the size property defaults to SizeLength. The repaint
logic in mustRepaintFillLayers expects to have this value set correctly.

Test: fast/repaint/background-shorthand-with-gradient-and-height-changes.html

  • rendering/RenderObject.cpp:

(WebCore::mustRepaintFillLayers): code cleanup. no functionality change.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer):

  • rendering/style/FillLayer.h: use SizeNone as initial value.

(WebCore::FillLayer::initialFillSizeType):
(WebCore::FillLayer::initialFillSize):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.

  • fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt: Added.
  • fast/repaint/background-shorthand-with-gradient-and-height-changes.html: Added.
10:23 PM Changeset in webkit [147302] by shinyak@chromium.org
  • 153 edits
    4 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

  • platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
9:48 PM Changeset in webkit [147301] by shinyak@chromium.org
  • 237 edits
    7 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
  • platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
9:35 PM Changeset in webkit [147300] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/WTF

https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.

Unreviewed.

Forgot to land these as part of http://trac.webkit.org/changeset/147299.

  • wtf/MathExtras.h:

(isGreaterThanNonZeroPowerOfTwo):

9:33 PM Changeset in webkit [147299] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.

Unreviewed.

  • ftl/FTLAbstractHeap.cpp:

(JSC::FTL::IndexedAbstractHeap::initialize):

  • ftl/FTLAbstractHeap.h:

(IndexedAbstractHeap):
(AbsoluteAbstractHeap):

  • ftl/FTLAbstractHeapRepository.h:

(AbstractHeapRepository):

9:29 PM Changeset in webkit [147298] by shinyak@chromium.org
  • 198 edits
    1 copy
    1 move
    18 adds
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

  • platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
  • platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
  • platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
  • platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scaled-expected.png:
  • platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-win/fast/borders/scaled-border-image-expected.png:
  • platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium/TestExpectations:
9:20 PM Changeset in webkit [147297] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should support GetByVal on Int32 arrays
https://bugs.webkit.org/show_bug.cgi?id=113668

Reviewed by Sam Weinig.

It actually already supported this, but needed to be told that it did.

Also adds an option to enable LICM (loop-invariant code motion, i.e.
http://llvm.org/docs/Passes.html#licm-loop-invariant-code-motion). LICM
isn't doing me any good right now, but I guess I'll have to play with
it more. And this adds the ability to tweak the LLVM optimization level
from the command-line.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

  • runtime/Options.h:

(JSC):

8:52 PM Changeset in webkit [147296] by shinyak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
8:44 PM Changeset in webkit [147295] by hayato@chromium.org
  • 4 edits
    2 adds in trunk

Text representation of pseudo elements, '::-webkit-distributed', is wrong in CSSSelector::selectorText().
https://bugs.webkit.org/show_bug.cgi?id=113560

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the text representation of distributed functional pseudo elements in CSSSelector::selectorText().

Test: fast/dom/shadow/distributed-pseudo-element-css-text.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(CSSSelector):

LayoutTests:

  • fast/dom/shadow/distributed-pseudo-element-css-text-expected.txt: Added.
  • fast/dom/shadow/distributed-pseudo-element-css-text.html: Added.
8:06 PM Changeset in webkit [147294] by abarth@webkit.org
  • 5 edits
    1 move in trunk/Source

[Chromium] Yarr should build using a separate GYP file from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=113652

Reviewed by Nico Weber.

Source/JavaScriptCore:

This patch moves JavaScriptCore.gyp to yarr.gyp because Chromium only
uses this GYP file to build yarr.

  • JavaScriptCore.gyp/JavaScriptCoreGTK.gyp:
  • JavaScriptCore.gypi:
  • yarr/yarr.gyp: Renamed from Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
    • Update references to yarr.gyp.
7:52 PM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
6:16 PM Changeset in webkit [147293] by kangil.han@samsung.com
  • 9 edits in trunk/Source

[EFL] Remove unused stdio.h includes
https://bugs.webkit.org/show_bug.cgi?id=113655

Reviewed by Andreas Kling.

We do not have to include unused header file.

Source/WebCore:

  • platform/efl/CursorEfl.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/ScrollbarThemeEfl.cpp:

Source/WebKit/efl:

  • ewk/ewk_tiled_backing_store.cpp:
  • ewk/ewk_tiled_matrix.cpp:
  • ewk/ewk_tiled_model.cpp:

(tile_account):

4:28 PM Changeset in webkit [147292] by fpizlo@apple.com
  • 6 edits
    5 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should supply TBAA meta-data to LLVM
https://bugs.webkit.org/show_bug.cgi?id=113656

Reviewed by Oliver Hunt.

This adds support for performing strong typing on the LLVM IR that the FTL
generates, by using TBAA meta-data. This will permit LLVM to do aggressive
GVN, load elimination, and LICM optimization even if it sees pointer store
side-effects. The goal is to precisely model all loads and stores we emit,
except for the super crazy ones (GetById that can go all-out polymorphic,
or for example a Call where we know nothing).

This is accomplished by introducing the notion of an AbstractHeap
typesystem. An AbstractHeap is a subset of all possible memory locations
that we might store to. For example, JSCell::m_structure and
JSObject::m_butterfly are two disjoint AbstractHeaps because we know that
a store to one cannot clobber the other. AbstractHeaps follow a
single-inheritance hierarchy. There is the root heap, which corresponds to
any possible memory location accessible to the JS engine, and then there
are heaps for all internal object fields, a heap for each global object,
and so on.

There are three other tidbits here that make this somewhat more interesting.
We have a notion of an AbstractHeap-with-offset, called AbstractField.
JSCell::m_structure is actually an AbstractField. This allows us to say
things like m_out.loadPtr(base, m_heaps.JSCell_structure); this both
gives you the offset of JSCell::m_structure and ascribes TBAA meta-data for
the JSCell::m_structure heap to the generated load instrction.

Another fun tidbit is the notion of Indexed, Numbered, and Absolute abstract
heaps. An indexed abstract heap corresponds to a set of locations that you
might access by index from some base. Virtual registers are a great example.
Though I call them just "variables" in the FTL. When we access a virtual
register, we know that we aren't interfering with accesses to
Structure-managed named properties, or with JSCell::m_structure, or with
other such disjoint heaps. But we also know that if we access a variable at
offset X and then another variable at offset Y and we know that X and Y are
unequal, then these two accesses are on disjoint subheaps of the variables
heap. This works out naturally for interference between, say, scoped variable
access and local variable access: if you access scoped variable r5 and then
access a local variable r5, these might interfere - and they will get the
same abstract subheap of the variables heap. IndexedAbstractHeaps
conveniently remember the size of the elements and will give you an
AbstractField (i.e. heap-with-offset) if you give it an index. This is great
for conveniently writing code that accesses contiguous arrays of well-typed
things. This allows you to literally do things like
m_out.load64(callFrameRegister, m_heaps.variables[operand]) and the right
thing will happen. You can also get the heap variables.atAnyIndex(), if
you're doing an access with an unknown index.

Numbered and Absolute abstract heaps are related except that they don't
assume that the value used to get the abstract subheap corresponds to any
meaningful offset from any base. Numbered heaps, like the properties heap
(for named properties tracked by Structure), are "numbered" (not indexed)
by the propertyNumber. So you can emit a GetByOffset by separately
computing the offset and the propertyNumber (both values are stored in the
StorageAccessData), and passing the offset directly to Output::address()
and passing m_heaps.properties[propertyNumber] as the field. Absolute heaps
are similar, but are keyed on absolute address. This is appropriate for
global variables, and possibly other things.

Finally, FTL::Output understands the notion of a pointer-with-TBAA-data,
and calls it a TypedPointer. TypedPointer is a tuple of a LLVMValueRef
referencing an intptr value and a pointer to an AbstractHeap. All load()
and store() operations now take a TypedPointer, and will perform the access
by casting the intptr to a pointer of the right type and then ascribing the
TBAA meta-data from the AbstractHeap.

(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(FTL):
(JSC::FTL::setMetadata):

  • ftl/FTLAbstractHeap.cpp: Added.

(FTL):
(JSC::FTL::AbstractHeap::tbaaMetadataSlow):
(JSC::FTL::AbstractHeap::decorateInstruction):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::~IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::baseIndex):
(JSC::FTL::IndexedAbstractHeap::atSlow):
(JSC::FTL::IndexedAbstractHeap::initialize):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::~NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::~AbsoluteAbstractHeap):

  • ftl/FTLAbstractHeap.h: Added.

(FTL):
(AbstractHeap):
(JSC::FTL::AbstractHeap::AbstractHeap):
(JSC::FTL::AbstractHeap::isInitialized):
(JSC::FTL::AbstractHeap::initialize):
(JSC::FTL::AbstractHeap::parent):
(JSC::FTL::AbstractHeap::heapName):
(JSC::FTL::AbstractHeap::tbaaMetadata):
(AbstractField):
(JSC::FTL::AbstractField::AbstractField):
(JSC::FTL::AbstractField::initialize):
(JSC::FTL::AbstractField::offset):
(IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::atAnyIndex):
(JSC::FTL::IndexedAbstractHeap::at):
(JSC::FTL::IndexedAbstractHeap::operator[]):
(JSC::FTL::IndexedAbstractHeap::returnInitialized):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::constructDeletedValue):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::isDeletedValue):
(NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::atAnyNumber):
(JSC::FTL::NumberedAbstractHeap::at):
(JSC::FTL::NumberedAbstractHeap::operator[]):
(AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::atAnyAddress):
(JSC::FTL::AbsoluteAbstractHeap::at):
(JSC::FTL::AbsoluteAbstractHeap::operator[]):

  • ftl/FTLAbstractHeapRepository.cpp: Added.

(FTL):
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
(JSC::FTL::AbstractHeapRepository::~AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h: Added.

(FTL):
(AbstractHeapRepository):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::addPtr):
(JSC::FTL::Output::address):
(JSC::FTL::Output::baseIndex):

  • ftl/FTLTypedPointer.h: Added.

(FTL):
(TypedPointer):
(JSC::FTL::TypedPointer::TypedPointer):
(JSC::FTL::TypedPointer::operator!):
(JSC::FTL::TypedPointer::heap):
(JSC::FTL::TypedPointer::value):

  • runtime/Options.h:

(JSC):

4:27 PM Changeset in webkit [147291] by rafaelw@chromium.org
  • 4 edits
    3 adds in trunk

HTMLLinkElement should resolve resource URLs when resources will be fetched
https://bugs.webkit.org/show_bug.cgi?id=113630

Source/WebCore:

HTMLLinkElement was resolving its URL when the href attribute was processed and caching it without ever
invalidating the cached URL. This patch removes the cached URL and adds getURL() which resolve the
URL dynamically.

Reviewed by Eric Seidel.

Test: fast/dom/HTMLLinkElement/resolve-url-on-insertion.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::getURL):
(WebCore):
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::shouldLoadLink):
(WebCore::HTMLLinkElement::process):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

LayoutTests:

Reviewed by Eric Seidel.

  • fast/dom/HTMLLinkElement/resolve-url-on-insertion-expected.txt: Added.
  • fast/dom/HTMLLinkElement/resolve-url-on-insertion.html: Added.
  • fast/dom/HTMLLinkElement/resources/stylesheet2.css: Added.

(#test2):

4:25 PM Changeset in webkit [147290] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix a comment. While thinking about TBAA for array accesses,
I realized that we have to be super careful about aliasing of typed arrays.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):

4:17 PM Changeset in webkit [147289] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/Tools

Allow WebUserMediaClientMock to be used by client
https://bugs.webkit.org/show_bug.cgi?id=113633

Patch by Wei Jia <wjia@chromium.org> on 2013-03-31
Reviewed by Adam Barth.

Export WebUserMediaClientMock.
Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.

(WebUserMediaClientMock):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

1:34 PM Changeset in webkit [147288] by aelias@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."

[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

  • src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190003

1:13 PM Changeset in webkit [147287] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks.
<rdar://problem/13541868> and https://bugs.webkit.org/show_bug.cgi?id=113664

Reviewed by Dan Bernstein.

In the "two-part" callbacks that involve waiting on a semaphore for the async block to finish,
the delegate might have been destroyed by the time the wait completes.

A RetainPtr<> protector will fix that up nicely.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionShouldUseCredentialStorage:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

12:33 PM Changeset in webkit [147286] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should be able to compile the Array.prototype.findGraphNode function in Kraken/ai-astar
https://bugs.webkit.org/show_bug.cgi?id=113646

Reviewed by Oliver Hunt.

This adds enough FTL support to compile Array.prototype.findGraphNode. This isn't
a speed-up, yet, because findGraphNode tends to be aggressively inlined by the DFG,
and the FTL can't yet compile the things into which it was inlined. In future
patches we will get to a point where we can compile the callers, and then we'll be
able to see what the performance effects are.

But the interesting thing is that it isn't a slow-down, either. This implies that
even if we FTL compile a CodeBlock that we shouldn't have (the fact that we
compiling things that end up being inlined is dumb, and the fact that the current
FTL tiering strategy launches LLVM for those things is even dumber), we still run
at OK performance.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowObject):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::lowStorage):
(JSC::FTL::LowerDFGToLLVM::isNotInt32):
(JSC::FTL::LowerDFGToLLVM::isNotCell):
(JSC::FTL::LowerDFGToLLVM::isNotBoolean):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateCell):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::accountedPointer):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::baseIndex):

Mar 30, 2013:

9:30 PM Changeset in webkit [147285] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused includes of stdio.h
https://bugs.webkit.org/show_bug.cgi?id=113650

Reviewed by Dimitri Glazkov.

We shouldn't include stdio.h. These includes aren't used anyway.

  • src/WebInputEvent.cpp:
  • src/x11/WebScreenInfoFactory.cpp:
9:11 PM Changeset in webkit [147284] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused include of RegularExpression.h
https://bugs.webkit.org/show_bug.cgi?id=113649

Reviewed by Dimitri Glazkov.

  • Modules/filesystem/DOMFilePath.cpp:
    • This include isn't used.
5:04 PM Changeset in webkit [147283] by fpizlo@apple.com
  • 9 edits
    4 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able to compile the Marsaglia random number generator
https://bugs.webkit.org/show_bug.cgi?id=113635

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Just adding missing functionality.

Also "fixed" OSR exit to use a call to abort() in addition to using Unreachable
since the latter doesn't actually mean trap - quite the opposite, it tells LLVM
that the code can never be reached.

The Marsaglia function runs ~60% faster with FTL, than DFG. Not a terrible start.

(FTL):
(JSC::FTL::voidType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::addExternFunction):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::buildMul):
(JSC::FTL::buildOr):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::mul):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):
(JSC::FTL::Output::extractValue):
(JSC::FTL::Output::call):
(JSC::FTL::Output::addWithOverflow32Function):
(JSC::FTL::Output::mulWithOverflow32Function):

  • ftl/FTLState.cpp: Added.

(FTL):
(JSC::FTL::State::dumpState):

  • ftl/FTLState.h:

(State):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/regress/marsaglia-expected.txt: Added.
  • fast/js/regress/marsaglia.html: Added.
  • fast/js/regress/script-tests/marsaglia.js: Added.

(marsaglia):

12:01 PM Changeset in webkit [147282] by mhahnenberg@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Move Region into its own header
https://bugs.webkit.org/show_bug.cgi?id=113617

Reviewed by Geoffrey Garen.

BlockAllocator.h is getting a little crowded. We should move the Region class into its own
header, since it's pretty independent from the BlockAllocator.

(JSC):

  • heap/Region.h: Added.

(JSC):
(DeadBlock):
(JSC::DeadBlock::DeadBlock):
(Region):
(JSC::Region::blockSize):
(JSC::Region::isFull):
(JSC::Region::isEmpty):
(JSC::Region::isCustomSize):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::Region):
(JSC::Region::~Region):
(JSC::Region::reset):
(JSC::Region::allocate):
(JSC::Region::deallocate):

11:31 AM Changeset in webkit [147281] by tsepez@chromium.org
  • 11 edits in trunk

Cross-Origin copy&paste / drag&drop allowing XSS via srcdoc attribute.
https://bugs.webkit.org/show_bug.cgi?id=113443

Reviewed by Adam Barth.

Source/WebCore:

Tested by LayoutTests/editing/pasteboard/paste-noscript.html

  • dom/Element.h:

(Element):
(WebCore::Element::isHTMLContentAttribute):
Adds an isHTMLContentAttribute() method to determine whether an attribute can contain
(potentially unsafe) HTML content. Currently, the iframe's srcdoc attribute is the only
such attribute, but clever folks might add more in the future.
Rename stripJavaScriptAttributes() method to stripScriptingAttributes(), to better reflect
the reality that scripting content may appear as above.
Adds missing consts and consolidate isJavaScriptAttribute() method.

  • dom/Element.cpp:

(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::stripScriptingAttributes):
Consolidated methods.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isHTMLContentAttribute):
(WebCore):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):
Indicate that for frames, the srcdoc attribute contains HTML content.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::setAttributes):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::setAttributes):
Rename stripJavaScriptAttribute calls to match Element.h

LayoutTests:

  • editing/pasteboard/paste-noscript-expected.txt:
  • editing/pasteboard/paste-noscript.html:

Adds a test that an iframe's srcdoc attribute is not pasted.

11:22 AM Changeset in webkit [147280] by tsepez@chromium.org
  • 8 edits in trunk

View-source iframes are dangerous (and not very useful).
https://bugs.webkit.org/show_bug.cgi?id=113345

Reviewed by Adam Barth.

Source/WebCore:

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
Conditionalize viewsource attribute on ENABLE(VIEWSOURCE_ATTRIBUTE).

Source/WebKit/chromium:

  • features.gypi:

Disable VIEWSOURCE_ATTRIBUTE for chromium.

Source/WTF:

  • wtf/FeatureDefines.h:

Default definition of ENABLE_VIEWSOURCE_ATTRIBUTE is enabled.

LayoutTests:

  • platform/chromium/TestExpectations:

Update expectations now that chromium excludes iframe's viewsource attribute.

6:08 AM Changeset in webkit [147279] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GTK] Should use GStreamer codec installation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34085

Reviewed by Martin Robinson.

Initial support for the GStreamer codec installer. The player will
handle missing-plugins messages and use the pbutils codec
installer facilities to install the missing GStreamer
plugins. Once the plugins are installed reset the pipeline state.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mediaPlayerPrivatePluginInstallerResultFunction): This
method is used to notify the player that the missing plugins were installed.
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Ignore
errors while installing plugins and handle the missing-plugin message.
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
This method is invoked after the installer finished its task.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

3:41 AM Changeset in webkit [147278] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

g_slist_reverse() may not be required in webKitWebAudioSrcLoop
https://bugs.webkit.org/show_bug.cgi?id=113568

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-30
Reviewed by Philippe Normand.

Decremental 'for' loop logic implemented to avoid using g_slist_reverse().

Original code - 2.025230 micro seconds per loop
Original code + patch - 1.964759 micro seconds per loop

This patch is covered by existing webaudio tests.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

1:59 AM Changeset in webkit [147277] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed buildfix after r147260.

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

1:34 AM Changeset in webkit [147276] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.
Desable the test (duplicate a rule from TestExpectations to override "webkit.org/b/90488 [ Debug ] inspector [ Slow ]").

  • inspector/console/console-css-warnings-expected.txt:
  • platform/chromium/TestExpectations:
1:24 AM Changeset in webkit [147275] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

  • inspector/front-end/breakpointsList.css:
  • inspector/front-end/dataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid td):
(.data-grid th.sort-ascending > div::after):
(.data-grid th.sort-descending > div::after):
(.data-grid button):

  • inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):

  • inspector/front-end/inspector.css:

(.toolbar-item):
(.toolbar-label):
(.console-message .bubble):
(.outline-disclosure > ol):
(.source-code):
(.scope-bar li):
(.sidebar-tree, .sidebar-tree .children):
(.sidebar-tree-section):
(li .status .bubble):
(.sidebar-tree-item.selected):
(.sidebar-tree-item .titles):
(.sidebar-tree-item .subtitle):
(.sidebar-tree-item.selected .subtitle):
(.source-frame-breakpoint-message):
(.soft-context-menu):

  • inspector/front-end/inspectorCommon.css:

(body):
(.resources-divider-label):

  • inspector/front-end/navigatorView.css:

(.navigator li):
(.navigator li.selected .selection):
(.navigator .base-navigator-tree-element-title):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
(.network-log-grid.data-grid th):
(.network-log-grid.data-grid select):
(.network-graph-label):
(.network-timeline-grid .resources-divider-label):
(.network-log-grid.data-grid .network-summary-bar td):

  • inspector/front-end/resourcesPanel.css:

(.resources.panel .sidebar li):
(.resources.panel .sidebar li.selected):
(.resources.panel .sidebar li.selected .selection):

  • inspector/front-end/sidebarPane.css:

(.sidebar-pane > .body .info):
(.sidebar-pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-subtitle):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

  • src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

1:14 AM Changeset in webkit [147274] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113586

Unreviewed, EFL gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-30

  • platform/efl/TestExpectations: Rebaseline after r147219.

Mar 29, 2013:

10:20 PM Changeset in webkit [147273] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css

Merge 146849 "Web Inspector: [Timeline] Records sidebar is clipped."
BUG=222683

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

  • inspector/front-end/timelinePanel.css:

(.timeline .sidebar): Make "bottom" value "important".

TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/13383002

10:12 PM Changeset in webkit [147272] by pfeldman@chromium.org
  • 4 edits in branches/chromium/1453

Merge 147028 "REGRESSION (r146588): Cannot correctly display Chi..."
BUG=223503

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13382002

9:51 PM Changeset in webkit [147271] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, release mode build fix.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):

9:41 PM Changeset in webkit [147270] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Change DO_NOT_INCLUDE_LLVM_CPP_HEADERS to LLVM_DO_NOT_INCLUDE_CPP_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=113634

Reviewed by Dan Bernstein.

  • ftl/FTLLLVMHeaders.h:
9:15 PM Changeset in webkit [147269] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Reviewed by Geoffrey Garen.

I forgot to make a couple of the requested review changes, so I'm making
them now!

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.h:
7:54 PM Changeset in webkit [147268] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r147251
https://bugs.webkit.org/show_bug.cgi?id=113631

Unreviewed build fix.

Add NETWORK_PROCESS guard.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

7:08 PM Changeset in webkit [147267] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r147263.
http://trac.webkit.org/changeset/147263
https://bugs.webkit.org/show_bug.cgi?id=113632

Breaks test fast/loader/display-image-unset-allows-cached-
image-load.html (Requested by mlam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

6:49 PM Changeset in webkit [147266] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
5:51 PM Changeset in webkit [147265] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

When releasing a CGImage, we should also remove it from the subimage cache.
https://bugs.webkit.org/show_bug.cgi?id=102453

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-29
Reviewed by Simon Fraser.

When we release an image(CGImageRef) from BitmapImage's cachedFrames, if the image was already
cached in subimage cache, it's ref count won't drop to 0 and the image won't be deleted. Usually,
the subimage cache will clear the whole cache in a timer with 1 sec delay. However, if WebCore has
to paint another subimage (not necessarily from the same CGImageRef) before this timer fires, we
will restart the timer and images inside the cache will stay longer than they should.

This patch does two things:

  • move SubimageCacheWithTimer and related helper struct into a separate file.
  • remove the image from subimage cache when we releasing the CGImageRef, this prevent subimage

cache holding the image after we released it.

No new tests, manually verified the CGImageRef is also removed from subimage cache
when we releasing the image from FrameData::clear.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::FrameData::clear): remove the image from subimage cache before we releasing it.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore):
(WebCore::GraphicsContext::drawNativeImage):

  • platform/graphics/cg/SubimageCacheWithTimer.cpp: Added.

(WebCore):
(SubimageRequest):
(WebCore::SubimageRequest::SubimageRequest):
(WebCore::SubimageCacheAdder::hash):
(SubimageCacheAdder):
(WebCore::SubimageCacheAdder::equal):
(WebCore::SubimageCacheAdder::translate):
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
(WebCore::SubimageCacheWithTimer::getSubimage):
(WebCore::SubimageCacheWithTimer::clearImage):
(WebCore::subimageCache):

  • platform/graphics/cg/SubimageCacheWithTimer.h: Added.

(WebCore):
(SubimageCacheWithTimer): Added a data member m_images to record which image and its subimages are cached.
(SubimageCacheEntry):
(SubimageCacheEntryTraits):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isEmptyValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::constructDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::hash):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::equal):
(SubimageCacheHash):

5:19 PM Changeset in webkit [147264] by fpizlo@apple.com
  • 4 edits
    2 adds in branches/dfgFourthTier

fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
https://bugs.webkit.org/show_bug.cgi?id=113452

Rubber stamped by Mark Hahnenberg.

Tools:

  • Scripts/copy-webkitlibraries-to-product-directory:
  • Scripts/export-llvm-build:

WebKitLibraries:

  • LLVMIncludesMountainLion.tar.bz2: Added.
  • LLVMLibrariesMountainLion.tar.bz2: Added.
5:04 PM Changeset in webkit [147263] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Let cached resources from file: schemes expire immediately
https://bugs.webkit.org/show_bug.cgi?id=113626

Reviewed by Brady Eidson

When a CachedResource was loaded from a file: URL, we would give it an
indefinite freshness lifetime. This means that we would continue to
serve a stale resource from the memory cache even if the file was
changed on disk. With the introduction of main resource caching, this
behavior broke at least one third-party WebKit app (see <rdar://problem/13313769>).

We should instead let file resources expire immediately. Modern
filesystems implement their own caching, so we should get good
performance for multiple reads of unmodified files without doing our
own caching.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime): file: URLs should have a
0 freshness lifetime.

4:41 PM Changeset in webkit [147262] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147257. <rdar://problem/13531679>

4:32 PM Changeset in webkit [147261] by ojan@chromium.org
  • 20 edits
    2 deletes in trunk

Source/WebCore: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Disallow auto as a valid min-size value.

  • css/html.css:

(input::-webkit-datetime-edit):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
Remove now unnecessary min-width: 0's.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
Set a flex-shrink: 0 to avoid shrinking these items below the designated height.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Remove all the unneeded SizeType arguments now that we don't need to
specially handle MinSize in all these functions.

  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
No longer need to explicitly set min-width:0.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Remove the code for specially handling auto.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::maxPageLogicalHeight):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
Remove all the now unneeded SizeType arguments.

  • rendering/style/RenderStyle.h:

Change the default min-size back to 0.

Source/WebKit2: Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Patch by Brady Eidson <beidson@apple.com> on 2013-03-29
Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

  • WebProcess/Network/WebResourceLoader.h:

LayoutTests: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

  • css3/flexbox/content-height-with-scrollbars.html:
  • css3/flexbox/cross-axis-scrollbar.html:

Set flex:none to avoid flex-shrinking.

  • css3/flexbox/flex-item-min-size-expected.txt: Removed.
  • css3/flexbox/flex-item-min-size.html: Removed.

These tests are now redundant with tests in fast/css-intrinsic-dimensions.

  • css3/flexbox/flexbox-baseline.html:

Set flex:none to avoid flex-shrinking.

  • css3/flexbox/line-wrapping.html:

Auto-size the flex items so that the column flexboxes have an auto-height.

  • css3/flexbox/preferred-widths.html:

Set flex:none to avoid flex-shrinking.

  • fast/css/auto-min-size-expected.txt:
  • fast/css/auto-min-size.html:

Update to no longer allow parsing auto as a valid value for min-width/min-height.

4:30 PM Changeset in webkit [147260] by ap@apple.com
  • 15 edits in trunk

Expose FeatureObserver data to WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=113613

Reviewed by Sam Weinig.

FeatureObserver used to depend on chromium-only HistogramSupport, which is not
really usable on Mac at least.

Instead of adding parallel feature reporting machinery, I'm adding a way to
generically relay the data from FeatureObserver to port code.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::reportMemoryUsage):
  • loader/FrameLoader.h: (WebCore::FrameLoader::previousURL): Exposed m_previousURL, renaming it to follow WebKit style.
  • page/FeatureObserver.cpp: (WebCore::FeatureObserver::~FeatureObserver): (WebCore::FeatureObserver::updateMeasurements):
  • page/FeatureObserver.h: (WebCore::FeatureObserver::accumulatedFeatureBits): Exposed the data to clients, and made reporting through HistogramSupport chromium only for clarity.
4:28 PM Changeset in webkit [147259] by fpizlo@apple.com
  • 16 edits
    14 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This is the initial version of the FTL JIT (Fourth Tier LLVM JIT).
It includes a lowering from the DFG IR to LLVM IR (FTL::lowerDFGToLLVM)
and a "backend" step that invokes the LLVM and wraps the resulting
function in a thunk (FTL::compile).

All LLVM IR building functions are wrapped up into a nicer FTL API.
First they're wrapped in an abbreviated API (FTLAbbreviations.h) and
then again into an object-oriented IR builder (FTLOutput.h).

This runs things. I don't know how fast it runs things. And I don't
make any claims of stability. The FTL is runtime-disabled by default;
you will enable it by doing --useExperimentalFTL=true. Probably if you
do this, you will run slower, because of the heavy thunking we do, the
fact that we don't have anything resembling a sensible tiering story,
and because we only compile ridiculously tiny functions.

Finally, this still requires a custom set of LLVM headers to build.
I am working on getting that up-streamed to LLVM, and separately I'll
make sure that we have a build checked into this branch.

  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Operands.h:

(Operands):
(JSC::Operands::Operands):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::needsTypeCheck):
(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):

  • dfg/DFGUseKind.h:

(JSC::DFG::shouldNotHaveTypeCheck):
(DFG):
(JSC::DFG::mayHaveTypeCheck):
(JSC::DFG::isDouble):
(JSC::DFG::isCell):

  • ftl: Added.
  • ftl/FTLAbbreviations.h: Added.

(FTL):
(JSC::FTL::int1Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::pointerType):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildAnd):
(JSC::FTL::buildXor):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildZExt):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildICmp):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):

  • ftl/FTLCapabilities.cpp: Added.

(FTL):
(JSC::FTL::canCompile):

  • ftl/FTLCapabilities.h: Added.

(FTL):

  • ftl/FTLCompile.cpp: Added.

(FTL):
(JSC::FTL::compileEntry):
(JSC::FTL::compile):

  • ftl/FTLCompile.h: Added.

(FTL):

  • ftl/FTLJITCode.cpp: Added.

(FTL):
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):

  • ftl/FTLJITCode.h: Added.

(FTL):
(JITCode):

  • ftl/FTLLLVMHeaders.h: Added.
  • ftl/FTLLowerDFGToLLVM.cpp: Added.

(FTL):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOpRoots):
(JSC::FTL::LowerDFGToLLVM::closeOverFlushedLocalOps):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOp):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalEdge):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compilePhantom):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::checkNotInt32):
(JSC::FTL::LowerDFGToLLVM::unboxInt32):
(JSC::FTL::LowerDFGToLLVM::boxInt32):
(JSC::FTL::LowerDFGToLLVM::checkNotCell):
(JSC::FTL::LowerDFGToLLVM::checkNotBoolean):
(JSC::FTL::LowerDFGToLLVM::unboxBoolean):
(JSC::FTL::LowerDFGToLLVM::boxBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateInt32):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(JSC::FTL::LowerDFGToLLVM::globalData):
(JSC::FTL::LowerDFGToLLVM::codeBlock):
(JSC::FTL::lowerDFGToLLVM):

  • ftl/FTLLowerDFGToLLVM.h: Added.

(FTL):

  • ftl/FTLOutput.h: Added.

(FTL):
(Output):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::param):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::add):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intCast):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::get):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::testNonZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):

  • ftl/FTLState.h: Added.

(FTL):
(State):
(JSC::FTL::State::State):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/Options.h:

(JSC):

Source/WTF:

Reviewed by Geoffrey Garen.

  • wtf/Platform.h:

Tools:

Reviewed by Geoffrey Garen.

Give the scripts the ability to find an LLVM build and use it.

Also added a script, export-llvm-build, that allows you to take your
own build of LLVM and package it for use by WebKit's build system.

The build system treats a "build" of LLVM as a pair of .tar.bz2's,
one for the library archives and one for the headers. It then unpacks
them into your built products directory in a mannner that is mostly
analogous to how WebKitSystemInterface works.

  • Scripts/build-jsc:
  • Scripts/copy-webkitlibraries-to-product-directory:

(unpackIfNecessary):
(dittoHeaders):

  • Scripts/export-llvm-build: Added.
4:24 PM Changeset in webkit [147258] by dgrogan@chromium.org
  • 1 edit in branches/chromium/1453/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors"

IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/13171005

4:02 PM Changeset in webkit [147257] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

  • WebProcess/Network/WebResourceLoader.h:
3:32 PM Changeset in webkit [147256] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r191432. Requested by
"Philip Rogers" <pdr@google.com> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

  • DEPS:
3:18 PM Changeset in webkit [147255] by acolwell@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add LayoutTests that verify MediaSource.duration behavior.
https://bugs.webkit.org/show_bug.cgi?id=113438

Reviewed by Eric Carlson.

  • http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Added.
  • http/tests/media/media-source/video-media-source-duration-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-duration.html: Added.
3:10 PM Changeset in webkit [147254] by jsbell@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] IndexedDB: Update terminated worker connection test
https://bugs.webkit.org/show_bug.cgi?id=113608

Reviewed by Tony Chang.

Update layout test only run under Chromium's content_shell that ensures that
worker termination does not result in stuck connections. The test was using
the obsolete setVersion() API.

  • storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt:
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:
  • storage/indexeddb/resources/pending-version-change-stuck.js:

(test.request.onblocked):
(test):

2:56 PM Changeset in webkit [147253] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Should never send events to plugins waiting on asynchronous initialization.
<rdar://problem/13538945> and https://bugs.webkit.org/show_bug.cgi?id=113612

Reviewed by Anders Carlsson.

Sending mouse and keyboard events to a plugin in the middle of asynchronous initialization is silly.

A quick audit of the sendSync() messages in PluginProxy suggests the following 8 can just have an early return:

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::handleEditingCommand):
(WebKit::PluginProxy::isEditingCommandEnabled):
(WebKit::PluginProxy::handlesPageScaleFactor):

2:37 PM Changeset in webkit [147252] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Objective-C API: Remove -[JSManagedValue managedValueWithValue:owner:]
https://bugs.webkit.org/show_bug.cgi?id=113602

Reviewed by Geoffrey Garen.

Since we put the primary way of keeping track of external object graphs (i.e. "managed" references)
in JSVirtualMachine, there is some overlap in the functionality of that interface and JSManagedValue.
Specifically, we no longer need the methods that include an owner, since ownership is now tracked
by JSVirtualMachine. These JSManagedValues will become weak pointers unless they are used
with [JSVirtualMachine addManagedReference:withOwner:], in which case their lifetime is tied to that
of their owner.

  • API/JSManagedValue.h:
  • API/JSManagedValue.mm:

(-[JSManagedValue init]):
(-[JSManagedValue initWithValue:]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots):

  • API/JSVirtualMachine.mm:

(getInternalObjcObject):

  • API/tests/testapi.mm:

(-[TextXYZ setOnclick:]):
(-[TextXYZ dealloc]):

2:32 PM Changeset in webkit [147251] by beidson@apple.com
  • 7 edits in trunk/Source/WebKit2

"Empty cache..." clears the disk cache from each WebProcess.
<rdar://problem/12456652> and https://bugs.webkit.org/show_bug.cgi?id=113603

Reviewed by Sam Weinig.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::terminate): Override ChildProcess::terminate to allow us to finish clearing the cache.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in: Add the ClearCacheForAllOrigins message.
  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::clearCacheForAllOrigins): Clear the disk cache.
(WebKit::NetworkProcess::platformTerminate): Wait for the clear to complete.

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Message the network process, also.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformClearResourceCaches): Don't clear the disk cache if we use the network process.

2:13 PM Changeset in webkit [147250] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Exclusions] shape outside segments not properly calculated for ellipses
https://bugs.webkit.org/show_bug.cgi?id=112587

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-29
Reviewed by Julien Chaffraix.

Source/WebCore:

When converting the line top coordinates from the parent's coordinate
space to the coordinate space of the float, the offset given by the
shape was not being accounted for. This patch accounts for that
offset.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine): Fix the coordinate conversion.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Ditto.

LayoutTests:

Check that shapes with a non-zero y value are properly wrapped.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Added.
  • fast/exclusions/resources/rounded-rectangle.js:

(generateSimulatedShapeOutsideOnFloat): For simulating, we ignore the
x and y values, since we're not attempting to draw the float's content
in the right place, we just want to simulate the shape's effect.

1:34 PM Changeset in webkit [147249] by hmuller@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Exclusions] Incorrect margin corner radii formula
https://bugs.webkit.org/show_bug.cgi?id=111186

Reviewed by Dirk Schulze.

Source/WebCore:

Corrected an error in the forumla for the margin ellipse's radii.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

  • rendering/ExclusionRectangle.cpp:

(WebCore::FloatRoundedRect::marginBounds):

LayoutTests:

  • fast/exclusions/resources/subpixel-utils.js:

(SubPixelLayout): Added an initSubPixelLayout() function so that inline test code doesn't have to wait until the DOMContentLoaded event.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.
1:26 PM Changeset in webkit [147248] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147179. <rdar://problem/13479890>

1:24 PM Changeset in webkit [147247] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147010. <rdar://problem/13479890>

1:22 PM Changeset in webkit [147246] by Lucas Forschler
  • 5 edits
    2 copies in tags/Safari-537.35.4/Source/WebKit2

Merged r147006. <rdar://problem/13479890>

1:12 PM Changeset in webkit [147245] by ojan@chromium.org
  • 13 edits
    2 adds in trunk

min-width/max-width of min-content/max-content don't work correctly if width is specified
https://bugs.webkit.org/show_bug.cgi?id=106143

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
Expose this so that we don't use the preferred widths when calculating intrinsic width
values since the preferred width will be the regular width value if it is set.
Also, simplified the logic around table cells and scrollbar widths. The old code was
wrong and unnecessarily complicated.

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use the new computeIntrinsicLogicalWidths method.

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Pass in the min/max values as out params so they can be called from computeIntrinsicLogicalWidths.
Also, make computeBlockPreferredLogicalWidths const.

  • rendering/RenderBlock.h:

LayoutTests:

  • css3/flexbox/box-sizing.html:

The old result was incorrectly using the preferred width as the min-content width of the flex items.
The new result is correctly resolving the min-content width to 0 and allowing the flex items to shrink.

  • fast/css-intrinsic-dimensions/intrinsic-sized-blocks-expected.txt: Added.
  • fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html: Added.
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:

The new result correctly adds the scrollbar width to the table cell intrinsic width.
The pixel result doesn't need ot be updated because the elements that changed are below
the fold, so they don't show up in the png.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:

Add tests that will need rebaselines.

  • scrollbars/custom-scrollbar-table-cell-expected.png:

The new result correctly adds the scrollbar width to the table cell intrinsic width.

12:56 PM Changeset in webkit [147244] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
https://bugs.webkit.org/show_bug.cgi?id=113594

Reviewed by Tony Chang.

Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.

Test: http/tests/inspector/indexeddb/database-structure.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close):

12:51 PM Changeset in webkit [147243] by timothy@apple.com
  • 2 edits in trunk/LayoutTests

Marking animation-delay-changed.html and reinserting-svg-into-document.html as flaky.

https://webkit.org/b/113598
https://webkit.org/b/113599

Unreviewed.

  • platform/mac/TestExpectations:
12:49 PM Changeset in webkit [147242] by Lucas Forschler
  • 21 edits in tags/Safari-537.35.4/Source

Merged r146544. <rdar://problem/13479890>

12:36 PM Changeset in webkit [147241] by jsbell@chromium.org
  • 3 edits
    2 adds in trunk

[V8] IndexedDB: Exceptions thrown inconsistently for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113091

Reviewed by Kentaro Hara.

Source/WebCore:

The exception thrown by SerializedScriptValue into the JS engine is not
observable by ScriptState. (We should fix that, but it appears non-trivial.)
Ask the SerializedScriptValue directly if it failed to clone. If so, don't
set an exception - one was already set so let that be processed normally.

Test: storage/indexeddb/clone-exception.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

LayoutTests:

  • storage/indexeddb/clone-exception-expected.txt: Added.
  • storage/indexeddb/clone-exception.html: Added.
12:31 PM Changeset in webkit [147240] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Snapshotted plugins must be able to restart on appropriate mouseup events
https://bugs.webkit.org/show_bug.cgi?id=113577

Reviewed by Tim Horton.

If the page content prevents the default behaviour of a mousedown event, then a snapshotted
plugin would never receive a click event, and thus be unable to restart. We have to also
look for a mouseup that happens with an associated mousedown, and trigger restart. This
won't call any page code - it's just behind the scenes.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize new member variable.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Track the state of mousedown and up pairs, and restart

if you see an appropriate mouseup.

  • rendering/RenderSnapshottedPlugIn.h: New member variable to track mouse state.
12:27 PM Changeset in webkit [147239] by Martin Robinson
  • 110 edits
    853 adds in trunk/Source/ThirdParty

Update the version of gyp in the repository
https://bugs.webkit.org/show_bug.cgi?id=113540

Reviewed by Nico Weber.

  • gyp: Update gyp to r1605.
12:26 PM Changeset in webkit [147238] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

removeViewportConstrainedLayer() should remove the layer from m_viewportConstrainedLayersNeedingUpdate too
https://bugs.webkit.org/show_bug.cgi?id=113596

Reviewed by Tim Horton.

It's possible, with some combination of position:fixed and opacity transitions
in iframes, to end up with a RenderLayer in m_viewportConstrainedLayersNeedingUpdate
that has been removed from m_viewportConstrainedLayers, which leads to later assertions
and/or crashes.

Fix by removing a layer from m_viewportConstrainedLayersNeedingUpdate when we
remove it from m_viewportConstrainedLayers.

I was not able to come up with a testcase that reliably reproduces this.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):

12:22 PM Changeset in webkit [147237] by Lucas Forschler
  • 19 edits in tags/Safari-537.35.4

Merged r146704. <rdar://problem/13337564>

12:14 PM Changeset in webkit [147236] by commit-queue@webkit.org
  • 20 edits in trunk

Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276

Patch by Greg Hughes <ghughes@apple.com> on 2013-03-29
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for accessibility search predicates to accept multiple search keys. The search will return the first item that matches any one of the provided search keys.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilitySearchCriteria):
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
(AccessibilityObject):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

Added support to test accessibility search predicates with multiple keys.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests:

Updated the search predicate test to test passing multiple search keys (link OR heading).

  • platform/mac/accessibility/search-predicate-expected.txt:
  • platform/mac/accessibility/search-predicate.html:
12:13 PM Changeset in webkit [147235] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.4/Source

Versioning.

12:12 PM Changeset in webkit [147234] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Simplified bytecode generation by unforking "condition context" codegen
https://bugs.webkit.org/show_bug.cgi?id=113554

Reviewed by Mark Hahnenberg.

Now, a node that establishes a condition context can always ask its child
nodes to generate into that context.

This has a few advantages:

(*) Removes a bunch of code;

(*) Optimizes a few missed cases like "if (!(x < 2))", "if (!!x)", and

"if (!x
!y)";

(*) Paves the way to removing more opcodes.

  • bytecode/Opcode.h:

(JSC): Separated out the branching opcodes for clarity.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ExpressionNode::emitBytecodeInConditionContext): All expressions
can be emitted in a condition context now -- the default behavior is
to branch based on the expression's value.

(JSC::LogicalNotNode::emitBytecodeInConditionContext):
(JSC::LogicalOpNode::emitBytecodeInConditionContext):
(JSC::ConditionalNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isSubtract):
(ExpressionNode):
(LogicalNotNode):
(LogicalOpNode): Removed lots of code for handling expressions
that couldn't generate into a condition context because all expressions
can now.

12:12 PM Changeset in webkit [147233] by jsbell@chromium.org
  • 7 edits in trunk/Source

IndexedDB: Bind lifetime of in-memory backing stores to IDBFactory backend
https://bugs.webkit.org/show_bug.cgi?id=110820

Reviewed by Tony Chang.

Source/WebCore:

Backing stores are dropped as soon as all connections are closed. That makes sense for
disk-backed stores to free up memory (although there's a performance trade-off...). But
for memory-backed stores, the expected lifetime should match the lifetime of the factory
so that an open/write/close/re-open/read yields the written data.

Test: Chromium's webkit_unit_tests, IDBFactoryBackendTest.MemoryBackingStoreLifetime

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore): Pass comparator into constructor since it was always
assigned immediately afterwards anyway.
(WebCore::IDBBackingStore::open): Split into three parts - open() which is disk-backed...
(WebCore::IDBBackingStore::openInMemory): ...explit in-memory creation (previously: specified by empty path)
(WebCore::IDBBackingStore::create): ... and the common logic which calls the constructor.

  • Modules/indexeddb/IDBBackingStore.h: Headers for the above.
  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore): Add in-memory backing stores to dependent set.

  • Modules/indexeddb/IDBFactoryBackendImpl.h: Add member to track dependent backing stores.

Source/WebKit/chromium:

  • tests/IDBBackingStoreTest.cpp:

(WebCore::IDBBackingStoreTest::SetUp): Use openInMemory rather than empty path.
(WebCore::TEST): Added IDBFactoryBackendTest.MemoryBackingStoreLifetime to verify refs.

11:54 AM Changeset in webkit [147232] by timothy@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/workers/worker-close-more.html, worker-document-leak.html and
worker-lifecycle.html as flaky on Windows.

http://webkit.org/b/106415

Unreviewed.

  • platform/win/TestExpectations:
11:52 AM Changeset in webkit [147231] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed. Rollout r146818.

  • win/tools/vsprops/FeatureDefines.props:
11:49 AM Changeset in webkit [147230] by timothy@apple.com
  • 2 edits in trunk/LayoutTests

Mark inspector/debugger/debugger-scripts-reload.html as flaky.

http://webkit.org/b/113589

Unreviewed.

  • platform/mac/TestExpectations:
11:40 AM Changeset in webkit [147229] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.4

New Tag.

11:10 AM Changeset in webkit [147228] by Nate Chapin
  • 3 edits
    2 adds in trunk

ASSERT d->m_defersLoading != defers on detik.com and drive.google.com
https://bugs.webkit.org/show_bug.cgi?id=111902

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/navigation/same-url-iframes-defer-crash.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setDefersLoading): If multiple DocumentLoaders are

using loading the same main resource, ensure only one of them can call
ResourceLoader::setDefersLoading.

LayoutTests:

  • http/tests/navigation/same-url-iframes-defer-crash-expected.txt: Added.
  • http/tests/navigation/same-url-iframes-defer-crash.html: Added.
10:24 AM Changeset in webkit [147227] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Content should not be lost when uiSourceCode's file was removed externally on file system.
https://bugs.webkit.org/show_bug.cgi?id=113581

Reviewed by Pavel Feldman.

  • inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.checkContentUpdated.contentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
(WebInspector.UISourceCode.prototype._commitContent):

10:06 AM Changeset in webkit [147226] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Prompt before closing dirty tab.
https://bugs.webkit.org/show_bug.cgi?id=113576

Reviewed by Pavel Feldman.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._maybeCloseTab):
(WebInspector.TabbedEditorContainer.prototype._closeTabs):
(WebInspector.EditorContainerTabDelegate):
(WebInspector.EditorContainerTabDelegate.prototype.closeTabs):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.setTabDelegate):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.allTabs):
(WebInspector.TabbedPane.prototype.otherTabs):
(WebInspector.TabbedPaneTab.prototype.setDelegate):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._closeTabs):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):
(WebInspector.TabbedPaneTabDelegate):
(WebInspector.TabbedPaneTabDelegate.prototype.closeTabs):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.resetWorkingCopy):

9:59 AM Changeset in webkit [147225] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix a typo in r147147 to fix Mac EWS.

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):

9:47 AM Changeset in webkit [147224] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox instead.
https://bugs.webkit.org/show_bug.cgi?id=113579

Reviewed by Pavel Feldman.

Initially I made a fake anchor element and moved it according to the highlighted element position.
It was a hack and after http://trac.webkit.org/changeset/147209 I'm able to remove it.

Drive by fix: the code was moved from onMouseMove to getPopoverAnchor.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
-(WebInspector.FlameChart.prototype._onMouseMove)

  • inspector/front-end/flameChart.css:
9:37 AM Changeset in webkit [147223] by zarvai@inf.u-szeged.hu
  • 41 edits
    16 copies
    5 moves
    128 adds
    21 deletes in trunk/LayoutTests

[Qt] Unreviewed gardneing. Updated png expected results after r146206.

  • platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/scrolled-within-boxshadow-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/translated-boxshadow-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/unscrolled-within-boxshadow-expected.png:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
  • platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/generated-content-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.png:
  • platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/masks/mask-of-clipped-layer-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/zero-size-overflow-expected.png:
  • platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-repaint-rect-expected.png:
  • platform/qt-5.0-wk2/compositing/repaint/requires-backing-repaint-expected.png:
  • platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/qt-5.0-wk2/compositing/z-order/negative-z-index-expected.png:
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Removed.
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
  • platform/qt-5.0-wk2/css3/filters/custom/custom-filter-clamp-css-color-matrix-expected.png:
  • platform/qt-5.0-wk2/css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.png:
  • platform/qt-5.0-wk2/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
  • platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png:
  • platform/qt-5.0-wk2/editing/selection/5099303-expected.png:
  • platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png:
  • platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
  • platform/qt-5.0-wk2/fast/backgrounds/size/zero-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/qt-5.0-wk2/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png: Added.
  • platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-paginate-empty-lines-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/reflections/inline-crash-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/reflections/reflection-masks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/reflections/reflection-masks-opacity-expected.png: Added.
  • platform/qt-5.0-wk2/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/background-misaligned-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/scale-page-shrink-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
  • platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
  • platform/qt-5.0-wk2/fast/text/font-initial-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/text/whitespace/003-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/006-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/008-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/009-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/012-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/whitespace/013-expected.png:
  • platform/qt-5.0-wk2/fast/text/whitespace/014-expected.png:
  • platform/qt-5.0-wk2/fast/writing-mode/block-level-images-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png: Added.
  • platform/qt-5.0-wk2/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/qt-5.0-wk2/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
  • platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2d-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-background-image/svg-as-background-2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
  • platform/qt-5.0-wk2/svg/batik/filters/feTile-expected.png: Added.
  • platform/qt-5.0-wk2/svg/batik/text/textDecoration-expected.png: Added.
  • platform/qt-5.0-wk2/svg/batik/text/textFeatures-expected.png: Added.
  • platform/qt-5.0-wk2/svg/css/group-with-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/createImageElement-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/createImageElement2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/js-update-image-and-display2-expected.png:
  • platform/qt-5.0-wk2/svg/custom/js-update-image-and-display3-expected.png:
  • platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
  • platform/qt-5.0-wk2/svg/custom/massive-coordinates-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/pattern-in-defs-expected.png:
  • platform/qt-5.0-wk2/svg/custom/pattern-rotate-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/pointer-events-image-css-transform-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/pointer-events-image-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/text-image-opacity-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/filters/big-sized-filter-expected.png: Added.
  • platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
  • platform/qt-5.0-wk2/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug12910-2-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1296-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug4093-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug97383-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/misc-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
  • platform/qt-5.0-wk2/transitions/cross-fade-border-image-expected.png: Added.
9:07 AM Changeset in webkit [147222] by commit-queue@webkit.org
  • 9 edits
    3 copies
    1 add in trunk/Source

[EFL][EGL] Add support for creating offscreen surface.
https://bugs.webkit.org/show_bug.cgi?id=113359

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-29
Reviewed by Noam Rosenthal.

This is in preparation for enabling EGL and GLES2
support for EFL port. This patch adds support for using
EGLPixmapSurface as an offscreensurface.

  • PlatformEfl.cmake:
  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):

  • platform/graphics/surfaces/efl/GLTransportSurface.cpp:

(WebCore::GLTransportSurface::createTransportSurface):

  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pixmapContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

Added logic to select EGLConfig supporting alpha and
opaque as needed. Moved Code related to display to
EGLHelper class.

  • platform/graphics/surfaces/egl/EGLHelper.cpp: Added.

(WebCore):
(EGLDisplayConnection):
(WebCore::EGLDisplayConnection::EGLDisplayConnection):
(WebCore::EGLDisplayConnection::~EGLDisplayConnection):
(WebCore::EGLDisplayConnection::display):
(WebCore::EGLDisplayConnection::terminate):
(WebCore::EGLHelper::eglDisplay):

  • platform/graphics/surfaces/egl/EGLHelper.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.

(WebCore):
(EGLHelper):

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLTransportSurface::createTransportSurface):
(WebCore::EGLTransportSurface::EGLTransportSurface):
(WebCore::EGLTransportSurface::attributes):
(WebCore::EGLTransportSurface::~EGLTransportSurface):
(WebCore::EGLTransportSurface::destroy):
(WebCore::EGLTransportSurface::configuration):
(WebCore::EGLOffScreenSurface::createOffScreenSurface):
(WebCore::EGLOffScreenSurface::EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::~EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::attributes):
(WebCore::EGLOffScreenSurface::configuration):
(WebCore::EGLOffScreenSurface::destroy):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(WebCore):
(EGLTransportSurface):
(EGLOffScreenSurface):

  • platform/graphics/surfaces/egl/EGLXSurface.cpp: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.cpp.

(WebCore):
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::~EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::swapBuffers):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLPixmapSurface::EGLPixmapSurface):
(WebCore::EGLPixmapSurface::~EGLPixmapSurface):
(WebCore::EGLPixmapSurface::destroy):

  • platform/graphics/surfaces/egl/EGLXSurface.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.

(WebCore):
(EGLWindowTransportSurface):
(EGLPixmapSurface):

EGLPixmapSurface implementation.

8:50 AM Changeset in webkit [147221] by commit-queue@webkit.org
  • 12 edits in trunk

Unreviewed, rolling out r147218.
http://trac.webkit.org/changeset/147218
https://bugs.webkit.org/show_bug.cgi?id=113585

We should rethink UI of this feature. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.populateWithProperties):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.set else):
(WebInspector.RemoteObjectProperty):

  • inspector/front-end/inspector.css:

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/debugger/properties-special-expected.txt:
  • inspector/debugger/properties-special.html:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/debugger/properties-special-expected.txt:
8:20 AM Changeset in webkit [147220] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: extract common base for 3 timeline overview controls (Events/Frames/Memory)
https://bugs.webkit.org/show_bug.cgi?id=113572

Reviewed by Yury Semikhatsky.

Refactoring, covered by existing tests.

  • introduce TimelineOverviewBase as a common base for 3 overview controls;
  • make every overview control a view.

This does not yet take advantage of common base (subject of the next patch).

  • inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.gridElement):
(WebInspector.OverviewGrid.prototype.itemsGraphsElement):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewBase):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):
(WebInspector.TimelineFrameOverview):
(WebInspector.TimelineFrameOverview.prototype.update):
(WebInspector.TimelineFrameOverview.prototype._renderBars):
(WebInspector.TimelineFrameOverview.prototype._drawFPSMarks):
(WebInspector.TimelineFrameOverview.prototype._renderBar):

8:09 AM Changeset in webkit [147219] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Web Inspector: Update test expectation for resource-har-conversion.html
https://bugs.webkit.org/show_bug.cgi?id=113460

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29
Reviewed by Vsevolod Vlasov.

The value of pageref and title had been changed after r105596.
(Use page ids, not document URLs in HAR entries to refer to pages.

Use page URL as a title field of a HAR page.)

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt:
  • platform/mac/http/tests/inspector/resource-har-conversion-expected.txt:
  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt:
8:02 AM Changeset in webkit [147218] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: gather accessor property getter and setter under a single tree node
https://bugs.webkit.org/show_bug.cgi?id=113357

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

A new tree element class AccessorPropertyTreeElemenet is added.
RemoteObjectProperty can now represent accessor property (if value is null).
New tree element is supported in CSS stylesheet.

Testing code is slightly modified for exploring new tree elements.

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.populateWithProperties):
(WebInspector.AccessorPropertyTreeElement):
(WebInspector.AccessorPropertyTreeElement.prototype.onattach):
(WebInspector.AccessorPropertyTreeElement.prototype.update):
(WebInspector.AccessorPropertyTreeElement.prototype.onpopulate):

  • inspector/front-end/RemoteObject.js:
  • inspector/front-end/inspector.css:

(.accessor-property-name):

LayoutTests:

Expectations are fixed with changed functionality and changed tests.

  • inspector/debugger/properties-special-expected.txt:
  • inspector/debugger/properties-special.html:
  • inspector/runtime/runtime-getProperties-expected.txt:
  • inspector/runtime/runtime-getProperties.html:
  • platform/chromium/inspector/debugger/properties-special-expected.txt:
7:21 AM Changeset in webkit [147217] by timothy@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed Windows gardening.

  • platform/win/fast/events/event-attribute-expected.txt: Added.

New baseline after r147205.

7:17 AM Changeset in webkit [147216] by timothy@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed Mac gardening.

  • platform/mac/fast/events/event-attribute-expected.txt: Added.

New baseline after r147205.

7:15 AM Changeset in webkit [147215] by kadam@inf.u-szeged.hu
  • 1 edit
    1 delete in trunk/LayoutTests

[Qt] Removal of misplaced stuff after r146692.

  • platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Removed.
  • platform/qt-unknown/svg/carto.net/tabgroup-expected.png: Removed.
7:14 AM Changeset in webkit [147214] by abucur@adobe.com
  • 2 edits
    6 adds in trunk/PerformanceTests

[CSS Regions] Add performance tests
https://bugs.webkit.org/show_bug.cgi?id=113303

Reviewed by Antti Koivisto.

Add simple performance tests for regions, without nested named flows: a region chain and a flow article.
The regions.js script is used to generate the tests and can set the following parameters: the number of regions,
the number of paragraphs, the regions width, height, max-height and the propability of a forced break after a paragraph.

The tests are skipped for now. They should be enabled once the regions performance is stable enough to create a baseline.

  • Layout/RegionsAuto.html: Added. A few regions with a short article. The regions have auto-height and some

paragraphs (80%) have forced breaks after. Stress test for the auto-height algorithm.

  • Layout/RegionsAutoMaxHeight.html: Added. A lot of regions with auto-height and max-height. Tests the impact of

max-height on the auto-height algorithm.

  • Layout/RegionsFixed.html: Added. A lot of regions with a long article. Some paragraphs (50%) have forced breaks after.

Stress test for the regions layout algorithm.

  • Layout/RegionsFixedShort.html: Added. A lot of short regions with a long content. Tests the impact of unforced breaks

on the layout speed.

  • Layout/resources/regions.css: Added.

(.articleInFlow):
(.articleNone):
(.region):
(.contentParagraph):
(.breakAfter):
(.regionContainer):

  • Layout/resources/regions.js: Added.

(.):

  • Skipped:
6:56 AM Changeset in webkit [147213] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Developers will have more clue
if two different profiles will have same colors for same functions.
https://bugs.webkit.org/show_bug.cgi?id=113410

Reviewed by Pavel Feldman.

The code related to color generator was extracted into a separate class.
The instance of the class was stored as static private member of the FlameChart class,
so all the profiles will share the same instance and will use same colors.
The colors itself were slightly adjusted.

Drive by fix: coordinatesToNodeIndex was fixed. The error was introduced in the patch about left padding.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.ColorGenerator):
(WebInspector.FlameChart.ColorGenerator.prototype._colorPairForID):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):

6:18 AM Changeset in webkit [147212] by charles.wei@torchmobile.com.cn
  • 11 edits in trunk

[BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=113562

Reviewed by George Staikos.
Internally reviewed by Mike Fenton and Gen Mak.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

No new tests, just disable CONTEXT_MENUS for blackberry porting.

  • platform/blackberry/ContextMenuBlackBerry.cpp:
  • platform/blackberry/ContextMenuItemBlackBerry.cpp:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ContextMenuClientBlackBerry.cpp:
  • WebCoreSupport/ContextMenuClientBlackBerry.h:
6:08 AM Changeset in webkit [147211] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Context menu doesn't showup anymore after rebase.
https://bugs.webkit.org/show_bug.cgi?id=113570

Reviewed by George Staikos.

The upstreaming patch for bug: 103058, reverses the return value of
Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
so we should reverse our logic in webkit part that calls it also.

This only applys to master_41 which is a new rebase, don't apply it to master_40.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

5:55 AM Changeset in webkit [147210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warning after r147022
https://bugs.webkit.org/show_bug.cgi?id=113567

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-03-29
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
No new tests, no change on behavior.

  • page/EventHandler.cpp:

(WebCore::expandSelectionToRespectUserSelectAll):

5:40 AM Changeset in webkit [147209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ability to use AnchorBox as an anchor for Popover
https://bugs.webkit.org/show_bug.cgi?id=113563

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
Reviewed by Pavel Feldman.

No new test: no change in behaviour.

  • Ability to pass AnchorBox instead of Element for popover anchor.
  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper.prototype._eventInHoverElement):

5:31 AM Changeset in webkit [147208] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: assign Scroll events to rendering category (was painting)
https://bugs.webkit.org/show_bug.cgi?id=113564

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePresentationModel.js: /ScrollLayer.*category/s/painting/rendering/

(WebInspector.TimelinePresentationModel._initRecordStyles):

5:27 AM Changeset in webkit [147207] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test after r147205.

  • platform/qt-5.0-wk1/TestExpectations:
4:28 AM Changeset in webkit [147206] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
https://bugs.webkit.org/show_bug.cgi?id=113512

Reviewed by Martin Robinson.

When the HTTP source element is slow downloading data for on-disk
buffering the playback position might reach an unbuffered region
and have bad consequences, pausing the pipeline beforehand
prevents this case to happen.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):

2:59 AM Changeset in webkit [147205] by keishi@webkit.org
  • 14 edits
    4 adds in trunk

Add the event handler content attributes that are defined in the spec to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=86363

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/events/event-attribute.html

We are missing some event handler content attributes from HTMLElement that are defined in the spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName): Returns event name for a given attribute name by looking it up on a HashMap.
(WebCore::HTMLElement::parseAttribute): Sets up event listeners for content attributes.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseAttribute): Removed event listener content attributes that was added to HTMLElement.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Ditto.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute): Ditto.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute): Ditto.

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute): Ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute): Ditto.

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute): Ditto.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Ditto.

LayoutTests:

  • fast/events/event-attribute-expected.txt: Added.
  • fast/events/event-attribute.html: Added. Tests that setting attribute creates event listeners.
  • fast/events/form-onchange-expected.txt: Added.
  • fast/events/form-onchange.html: Added. Test for Bug 24516.
2:44 AM Changeset in webkit [147204] by caseq@chromium.org
  • 16 edits in trunk

Web Inspector: timeline paint rectangles are off for transformed layers
https://bugs.webkit.org/show_bug.cgi?id=112919

Reviewed by Pavel Feldman.

Source/WebCore:

  • pass RenderObject instead of Frame to InspectorInstrumentation::didPaint;
  • take transforms into account and convert paint clip rect into quad;
  • emit quads, not rects as Paint and Layout record data;
  • adjust client to using quads, compute width/height from quad coords.
  • inspector/InspectorInstrumentation.cpp: Pass RenderObject, not frame to {will,did}Paint.

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Added.

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::localToPageQuad): Convert local clip rect to transformed quad.
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.cpp: Emit quads as Paint and Layout records data.

(WebCore::createQuad):
(WebCore):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::createLayoutData):

  • inspector/TimelineRecordFactory.h:

(WebCore):
(TimelineRecordFactory):

  • inspector/front-end/TimelinePanel.js: Highlight a quad iff formatted record has highlightQuad field.

(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightQuad):
(WebInspector.TimelinePanel.prototype._hideQuadHighlight):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record): Set highlightQuad for Paint and Layout
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.quadWidth):
(WebInspector.TimelinePresentationModel.quadHeight):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

  • adjust to changed record format;
  • simplify test using InspectorTest.evaluateWithTimeline().
  • http/tests/inspector/timeline-test.js:
  • inspector/timeline/timeline-layout-expected.txt:
  • inspector/timeline/timeline-paint-expected.txt:
  • inspector/timeline/timeline-paint.html:
2:33 AM Changeset in webkit [147203] by zarvai@inf.u-szeged.hu
  • 6 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
  • platform/qt/TestExpectations:
  • platform/qt/compositing/contents-opaque/control-layer-expected.txt: Rebaseline after r147127.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
2:25 AM Changeset in webkit [147202] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad()
https://bugs.webkit.org/show_bug.cgi?id=112911

Reviewed by Pavel Feldman.

  • added Quad type and DOMAgent.highlightQuad() to protocol;
  • retained DOMAgent.highlightRect(), but implement it via highlightQuad.
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::parseQuad):
(WebCore):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorOverlay.cpp: Mostly just renames of rect to quad.

(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reportMemoryUsage):

  • inspector/InspectorOverlay.h:

(InspectorOverlay):

  • inspector/InspectorOverlayPage.html: Ditto.
1:51 AM Changeset in webkit [147201] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a crashing expectation for the

ttp/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html layout test. Skipping the perf/ tests when
using the debug build.

  • platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt: Rebaselining after r147156.
12:59 AM Changeset in webkit [147200] by commit-queue@webkit.org
  • 3 edits
    19 adds in trunk/LayoutTests

[EFL] New baselines for accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=113510

Unreviewed, EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-29

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
  • platform/efl/accessibility/aria-checkbox-text-expected.txt: Added.
  • platform/efl/accessibility/aria-combobox-expected.txt: Added.
  • platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
  • platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
  • platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Added.
  • platform/efl/accessibility/aria-roles-expected.txt: Added.
  • platform/efl/accessibility/aria-tables-expected.txt: Added.
  • platform/efl/accessibility/aria-toggle-button-with-title-expected.txt: Added.
  • platform/efl/accessibility/canvas-description-and-role-expected.txt: Added.
  • platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
  • platform/efl/accessibility/image-link-expected.txt: Added.
  • platform/efl/accessibility/image-map1-expected.txt: Added.
  • platform/efl/accessibility/image-map2-expected.txt: Added.
  • platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
  • platform/efl/accessibility/legend-expected.txt: Added.
  • platform/efl/accessibility/menu-list-sends-change-notification-expected.txt: Added.
  • platform/efl/accessibility/notification-listeners-expected.txt: Added.
  • platform/efl/accessibility/svg-image-expected.txt: Added.
12:36 AM Changeset in webkit [147199] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
https://bugs.webkit.org/show_bug.cgi?id=113526

Source/WebCore:

It matches shipping Safari and Firefox behaviour.

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.

Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.

  • fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added.
  • fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added.
Note: See TracTimeline for information about the timeline view.