Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 9, 2013:

8:29 PM Changeset in webkit [149861] by fpizlo@apple.com

• 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG shouldn't allocate in the GC heap
​https://bugs.webkit.org/show_bug.cgi?id=115598

Reviewed by Geoffrey Garen.

I believe that we've now fixed this, and this patch just adds the relevant assertion.

• runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

7:45 PM Changeset in webkit [149860] by fpizlo@apple.com

• 12 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CodeBlock should be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=115594

Reviewed by Geoffrey Garen.

This makes it possible to have the currently-being-compiled CodeBlock not be
installed in Executable, while also allowing it to point to its intended
alternative(). So long as we were using ownership and not reference counting, it
would have been difficult to have both CodeBlock::m_alternative and
Executable::m_codeBlockForBlah point to the previous CodeBlock.

I also took the opportunity to clean up a bunch of code that appears to have
rotted.

• assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::operator==):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::releaseAlternative):
(JSC::CodeBlock::setAlternative):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

• heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

• heap/DFGCodeBlocks.h:

(DFGCodeBlocks):

• heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):

• heap/Heap.h:
• jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

• runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(EvalExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::codeBlockFor):

• runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

6:46 PM Changeset in webkit [149859] by commit-queue@webkit.org

• 6 edits in trunk/LayoutTests

Unskipped the webarchive tests for Mac that are not skipped for a reason other than
dumpDOMAsWebArchive not being implemented, which was fixed in r149692.
​https://bugs.webkit.org/show_bug.cgi?id=115819

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-09
Reviewed by Benjamin Poulain.

• platform/efl-wk2/TestExpectations:

Skip webarchive tests.

• platform/gtk-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-mac-wk2/TestExpectations:

Skip webarchive tests.

• platform/qt-5.0-wk2/TestExpectations:

Skip webarchive tests.

• platform/wk2/TestExpectations:

Removed universal skipping of webarchive tests, noted which tests are still skipped with bug numbers.

5:57 PM Changeset in webkit [149858] by Chris Fleizach

• 10 edits
  2 adds in trunk

AX: VoiceOver is no longer seeing items in poorly formed tables
​https://bugs.webkit.org/show_bug.cgi?id=115837

Reviewed by Darin Adler.

Source/WebCore:

In case the author didn't include the rows of a table as the
direct children, a table needs to dive down its descendant chain
until the rows are found.

I also took the opportunity to clean up a bit around what the different
meanings of table are in the accessibility classes.

Test: accessibility/poorly-formed-aria-table.html

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):
(WebCore::AccessibilityARIAGrid::addChildren):

• accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

• accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore):

• accessibility/AccessibilityARIAGridRow.h:

(AccessibilityARIAGridRow):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isTable):

• accessibility/AccessibilityTable.h:

(AccessibilityTable):
(WebCore::AccessibilityTable::isTable):
(WebCore::toAccessibilityTable):

• accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

• accessibility/poorly-formed-aria-table-expected.txt: Added.
• accessibility/poorly-formed-aria-table.html: Added.

5:12 PM Changeset in webkit [149857] by zoltan@webkit.org

• 6 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
​https://bugs.webkit.org/show_bug.cgi?id=115053

Reviewed by Alexandru Chiculita.

I changed the tests to use Ahem font (overflow will be the same on every port) and modify the markup in order to be the similar
for the two tests. The change fixes both tests and make them passing on Qt as well. I removed the tests from the TestExpectations.

• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
• fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
• fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
• fast/exclusions/shape-inside/shape-inside-percentage.html:
• platform/qt/TestExpectations:

4:55 PM Changeset in webkit [149856] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

REGRESSION: Disabled multiline select element now responds to (certain) clicks
​https://bugs.webkit.org/show_bug.cgi?id=115710

Patch by Yael Aharon <​yael.aharon@intel.com> on 2013-05-09
Reviewed by Kent Tamura.

Source/WebCore:

After ​http://trac.webkit.org/changeset/140286, select elements can scroll whether they
are disabled or not. While they scroll, they also change the selected item.
This patch allows the select element to scroll, but does not change the selection
if the select element is disabled.

Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
Test: fast/forms/select/listbox-disabled-no-autoscroll.html

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::stopAutoscroll):

LayoutTests:

Test that a disabled element does not change selection while scrolling.

• fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt: Added.
• fast/forms/select/listbox-disabled-scroll-no-onchange.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll.html: Added.
• fast/forms/select/listbox-disabled-no-autoscroll-expected.html: Added.

4:47 PM Changeset in webkit [149855] by Patrick Gansterer

• 4 edits in trunk/Tools

[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
​https://bugs.webkit.org/show_bug.cgi?id=92371

Reviewed by Brent Fulgham.

Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().

• DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
• DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem):
(dumpBackForwardList):

• DumpRenderTree/win/DumpRenderTree.vcproj:

4:41 PM Changeset in webkit [149854] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Clean up SecurityOrigin::databaseIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=115882

Reviewed by Beth Dakin.

Remove m_encodedHost and just call encodeHost from databaseIdentifier().
Also, use a StringBuilder when constructing the database identifier to avoid allocating
temporary String objects over and over.

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::databaseIdentifier):

• page/SecurityOrigin.h:

(SecurityOrigin):

4:21 PM Changeset in webkit [149853] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Remove m_securityOrigin from XMLHttpRequest
​https://bugs.webkit.org/show_bug.cgi?id=115881

Reviewed by Alexey Proskuryakov.

The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):

• xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:03 PM Changeset in webkit [149852] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

3:50 PM Changeset in webkit [149851] by fpizlo@apple.com

• 16 edits
  4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should have its own notion of StructureChain, and it should be possible to validate it after compilation finishes
​https://bugs.webkit.org/show_bug.cgi?id=115841

Reviewed by Oliver Hunt.

This adds IntendedStructureChain, which is like StructureChain, except that it holds a bit
more information and can be validated independantly of its owning Structure and lexical
GlobalObject, since it remembers both of those things. It's also malloc'd and RefCounted
rather than GC'd, so it can be allocated in a concurrent compilation thread.

Gave this class a bunch of methods to allow the following idiom:

• Snapshot a structure chain concurrently. This structure chain may end up being wrong in case of races, but in that case we will find out when we try to validate it.

• Perform validation on the structure chain itself, without recomputing the chain. Previously, many chain validation methods (prototypeChainMayInterceptStoreTo() for example) recomputed the chain, and hence, were inherently racy: you could build one chain and then validate against a different chain, and hence not realize that the chain you did build was actually broken for your purposes, because the chain you checked was a different one.

• Validate that the chain is still the right one at any time, allowing the cancellation of compilation if there was a race.

Also added DFG::DesiredStructureChains, which tracks those intended structure chains that
the compiler had already chosen to use. If any of those are invalid at link time, throw
out the compilation.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

• bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::chain):
(GetByIdStatus):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

• bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::structureChain):
(PutByIdStatus):

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDesiredStructureChains.cpp: Added.

(DFG):
(JSC::DFG::DesiredStructureChains::DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::~DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::areStillValid):

• dfg/DFGDesiredStructureChains.h: Added.

(DFG):
(DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::addLazily):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isStillValid):
(DFG):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• runtime/IntendedStructureChain.cpp: Added.

(JSC):
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::~IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::matches):
(JSC::IntendedStructureChain::chain):
(JSC::IntendedStructureChain::mayInterceptStoreTo):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):

• runtime/IntendedStructureChain.h: Added.

(JSC):
(IntendedStructureChain):
(JSC::IntendedStructureChain::head):
(JSC::IntendedStructureChain::size):
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
(JSC::IntendedStructureChain::last):

• runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

• runtime/Structure.h:

(Structure):

• runtime/StructureInlines.h:

(JSC::Structure::storedPrototypeObject):
(JSC):
(JSC::Structure::storedPrototypeStructure):

3:40 PM Changeset in webkit [149850] by Christophe Dumez

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r149836.

It broke at least EFL and GTK builds. Move new static members initialization
outside the class. Those need to have a definition outside the class because
their address is used (e.g. CodeCacheMap::nonGlobalWorkingSetMaxEntries).

• runtime/CodeCache.cpp:

(JSC):

• runtime/CodeCache.h:

(CodeCacheMap):

3:39 PM Changeset in webkit [149849] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Enable UI process storage
​https://bugs.webkit.org/show_bug.cgi?id=115879
<rdar://problem/12239765>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Flip the switch.

3:37 PM Changeset in webkit [149848] by andersca@apple.com

• 121 edits in trunk/Source/WebKit2

Remove extra spaces between right angle brackets in template declarations
​https://bugs.webkit.org/show_bug.cgi?id=115877

Reviewed by Beth Dakin.

C++11 doesn't require spaces between right angle brackets so remove all of them.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::sandboxExtensions):

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:

(NetworkBlobRegistry):

• NetworkProcess/HostRecord.h:

(HostRecord):

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):

• NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcess):

• NetworkProcess/NetworkProcess.h:

(NetworkProcess):

• NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):

• NetworkProcess/NetworkResourceLoadScheduler.h:
• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• NetworkProcess/SchedulableLoader.h:

(SchedulableLoader):

• Platform/CoreIPC/ArgumentCoders.h:
• Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

• Platform/CoreIPC/Connection.h:

(Connection):

• Platform/WorkQueue.h:

(WorkQueue):

• PluginProcess/PluginProcess.h:

(PluginProcess):

• Scripts/webkit2/messages_unittest.py:

(CoreIPC):

• Shared/BlockingResponseMap.h:

(BlockingResponseMap):

• Shared/ChildProcessProxy.h:

(ChildProcessProxy):

• Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):

• Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(ImmutableArray):

• Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

• Shared/ImmutableDictionary.h:

(ImmutableDictionary):

• Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

• Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

• Shared/SessionState.cpp:
• Shared/StatisticsData.h:

(StatisticsData):

• Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

• Shared/WebArchive.cpp:

(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

• Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

• Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

• UIProcess/API/mac/WKPrintingView.h:

(WebFrameProxy):

• UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _drawPreview:]):

• UIProcess/API/mac/WKView.mm:

(WebKit):

• UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):

• UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:

(GeolocationPermissionRequestManagerProxy):

• UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:

(DynamicLinkerEnvironmentExtractor):

• UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(CustomProtocolManagerProxy):

• UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:

(NotificationPermissionRequestManagerProxy):

• UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

• UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

• UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

• UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

• UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

• UIProcess/SharedWorkers/SharedWorkerProcessManager.h:

(SharedWorkerProcessManager):

• UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(SharedWorkerProcessProxy):

• UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

• UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::invalidateConnectionInternal):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

• UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

• UIProcess/WebBackForwardList.h:

(WebKit):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::enableProcessTermination):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

• UIProcess/WebContext.h:

(WebContext):

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

• UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

• UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

• UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

• UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

• UIProcess/WebFormClient.h:

(WebFormClient):

• UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

• UIProcess/WebLoaderClient.h:

(WebLoaderClient):

• UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

• UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

• UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

• UIProcess/WebPageProxy.cpp:

(ExceededDatabaseQuotaRecords):
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::pluginInformationDictionary):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::didReceiveEvent):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage):

• UIProcess/WebProcessProxy.h:

(WebProcessProxy):

• UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):

• WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):

• WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

• WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

• WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

(InjectedBundlePageEditorClient):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

(InjectedBundlePageFormClient):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

• WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

• WebProcess/Network/WebResourceLoadScheduler.h:

(WebResourceLoadScheduler):

• WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

• WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

(NPRuntimeObjectMap):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

• WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(NetscapePluginStream):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::runScriptsInPDFDocument):

• WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelAllStreams):

• WebProcess/Plugins/PluginView.h:

(PluginView):

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):

• WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

• WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

• WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::keyValueStorageOriginIdentifiers):

• WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::getClientPasteboardDataForRange):

• WebProcess/WebCoreSupport/WebEditorClient.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):

• WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findStringMatches):

• WebProcess/WebPage/FindController.h:

(FindController):

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit):

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

• WebProcess/WebPage/WebPage.h:

(WebKit):
(WebPage):

• WebProcess/WebPage/mac/LayerTreeHostMac.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::webPageGroup):
(WebKit::addCaseFoldedCharacters):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setTextCheckerState):

• WebProcess/WebProcess.h:

(WebProcess):

3:26 PM Changeset in webkit [149847] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Implement WebPlatformStrategies::transientLocalStorageNamespace
​https://bugs.webkit.org/show_bug.cgi?id=115876
<rdar://problem/13852871>

Reviewed by Beth Dakin.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
Return a session storage namespace for a random page when UI process storage is enabled,
otherwise call the base class implementation.

3:09 PM Changeset in webkit [149846] by roger_fong@apple.com

• 1 edit
  2 adds
  1 delete in trunk/LayoutTests

Unreviewed mac gardening.

• platform/mac/inspector/command-line-api-expected.txt: Removed.
• platform/mac/inspector/console: Added.
• platform/mac/inspector/console/command-line-api-expected.txt: Added.

2:47 PM Changeset in webkit [149845] by Christophe Dumez

• 17 edits in trunk

[NoInterfaceObject] extended attribute should be removed for several interfaces
​https://bugs.webkit.org/show_bug.cgi?id=115852

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove [NoInterfaceObject] extended attribute from the following Web IDL
interfaces: SecurityPolicy, History, Location, Navigator, Performance,
PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
PerformanceResourceTiming, PerformanceTiming and Screen.

These interfaces should not have the [NoInterfaceObject] extended attribute
according to their respective specifications:

• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
• ​http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
• ​https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
• ​http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
• ​http://www.w3.org/TR/navigation-timing/#performance
• ​https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
• ​http://www.w3.org/TR/navigation-timing/#performancenavigation
• ​http://www.w3.org/TR/navigation-timing/#performancetiming
• ​http://www.w3.org/TR/user-timing/#performancemark
• ​http://www.w3.org/TR/user-timing/#performancemeasure
• ​http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
• ​http://dev.w3.org/csswg/cssom-view/#the-screen-interface

The new behavior is consistent with the specifications, Firefox and soon Blink.

No new tests, already covered by existing tests.

• page/DOMSecurityPolicy.idl:
• page/History.idl:
• page/Location.idl:
• page/Navigator.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:

LayoutTests:

Rebaseline several layout tests whose output has changed now that a few more
global constructors are exposed.

• fast/dom/dom-constructors-expected.txt:
• fast/js/global-constructors-attributes-expected.txt:
• platform/efl/fast/js/global-constructors-attributes-expected.txt:

2:45 PM Changeset in webkit [149844] by robert@webkit.org

• 4 edits
  1 move
  3 deletes in trunk

REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
​https://bugs.webkit.org/show_bug.cgi?id=26394

Reviewed by David Hyatt.

Source/WebCore:

Text controls or any object that has scrollable content should not flex inside a table cell.
This makes our behaviour the same as IE, FF and Opera (Presto).

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

• fast/replaced/table-percent-height-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt.
• fast/replaced/table-percent-height-text-controls.html:
• platform/gtk/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
• platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.

2:35 PM Changeset in webkit [149843] by Patrick Gansterer

• 2 edits
  1 move in trunk/Tools

[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
​https://bugs.webkit.org/show_bug.cgi?id=92505

Reviewed by Brent Fulgham.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.

(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

• DumpRenderTree/pthreads: Removed.
• DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.

2:34 PM Changeset in webkit [149842] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Build fix.

• WebCore.exp.in:

2:18 PM Changeset in webkit [149841] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Update srcipt paths in editing/shadow/rightclick-on-meter-in-shadow-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=96223

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-05-09
Reviewed by Rob Buis.

The original paths don't exist at all.

• editing/shadow/rightclick-on-meter-in-shadow-crash.html:

2:03 PM Changeset in webkit [149840] by andersca@apple.com

• 14 edits in trunk/Source/WebCore

Add a StorageStrategy hook for creating transient local storage namespaces
​https://bugs.webkit.org/show_bug.cgi?id=115870

Reviewed by Geoffrey Garen.

• WebCore.exp.in:

Export symbol needed by WebKit2.

• dom/Document.cpp:

(WebCore::Document::topOrigin):

• dom/Document.h:
• dom/ScriptExecutionContext.h:
• workers/WorkerContext.h:

Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.

• page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):
Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.

• page/PageGroup.h:

Update HashMap declaration.

• storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::transientLocalStorageNamespace):
Add new implementation that will optionally call out to the storage strategy.

• storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
Move the default implementation here from PageGroup.

• storage/StorageStrategy.cpp:

(WebCore::StorageStrategy::transientLocalStorageNamespace):
Call the default implementation.

1:54 PM Changeset in webkit [149839] by enrica@apple.com

• 4 edits in trunk/Source/WebCore

A change in system environment should force all CSS properties to be recomputed.
​https://bugs.webkit.org/show_bug.cgi?id=115872
<rdar://problem/13781171>

Reviewed by Antti Koivisto.

When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.

• page/Page.cpp:

(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):

• page/Page.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):

1:35 PM Changeset in webkit [149838] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
<​http://webkit.org/b/115590>

Reviewed by Darin Adler.

Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.

• css/RuleSet.cpp:

(WebCore::RuleSet::findBestRuleSetAndAdd):

Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.

1:31 PM Changeset in webkit [149837] by roger_fong@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed mac port gardening.

• platform/mac-lion/fast/js: Added.
• platform/mac-lion/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/mac/inspector/command-line-api-expected.txt: Added.

1:03 PM Changeset in webkit [149836] by oliver@apple.com

• 17 edits
  3 adds in trunk

Code cache stores bogus var references for functions in eval code
​https://bugs.webkit.org/show_bug.cgi?id=115747

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Non-global eval now uses a per-CodeBlock cache, and only use it
when we're at the top of a function's scope. This means that we
will no longer cache the parsing of a single string across
multiple functions, and we won't cache when we're nested inside
constructs like |with| and |catch| where previously we would, which
is good because caching in those cases is unsound.

• bytecode/EvalCodeCache.h:

(JSC):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::codeCacheForEval):
(UnlinkedCodeBlock):
(RareData):

• debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

• interpreter/Interpreter.cpp:

(JSC::eval):

• runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache):
(JSC::CodeCache::generateBytecode):
(JSC):
(JSC::CodeCache::getCodeBlock):

• runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(CodeCacheMap):
(JSC::CodeCacheMap::canPruneQuickly):
(JSC::CodeCacheMap::prune):
(JSC::CodeCache::create):
(CodeCache):

• runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::compileInternal):

• runtime/Executable.h:

(JSC::EvalExecutable::create):
(EvalExecutable):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createEvalCodeBlock):

• runtime/JSGlobalObject.h:

(JSGlobalObject):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

(VM):

LayoutTests:

Many tests

• fast/js/eval-cache-scoped-lookup-expected.txt: Added.
• fast/js/eval-cache-scoped-lookup.html: Added.
• fast/js/script-tests/eval-cache-scoped-lookup.js: Added.

(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):

12:41 PM Changeset in webkit [149835] by mhahnenberg@apple.com

• 1 edit in trunk/LayoutTests/ChangeLog

Fixing botched rebase of ChangeLog

12:38 PM Changeset in webkit [149834] by mhahnenberg@apple.com

• 4 edits
  3 adds in trunk

DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes
​https://bugs.webkit.org/show_bug.cgi?id=115805

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

It checks the observed ArrayModes to see if we have seen any ArrayWith* first. If so, it assumes it's
an Array::Array, even if we've also observed any NonArrayWith* in the ArrayProfile. This leads to the
code generated by jumpSlowForUnwantedArrayMode to check the indexing type against (shape | IsArray)
instead of just shape, which can cause us to exit a lot in the case that we saw a NonArray.

To fix this we need to add a case that checks for both ArrayWith* and NonArrayWith* cases first, which
should then use Array::PossiblyArray, then do the checks we were already doing.

• bytecode/ArrayProfile.h:

(JSC::hasSeenArray):
(JSC::hasSeenNonArray):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):

LayoutTests:

Added regression test for array access over polymorphic array vs. non-array indexing types.
With the fix, we get 3.666x faster on this microbenchmark.

Reviewed by Geoffrey Garen.

• fast/js/regress/array-nonarray-polymorphic-access-expected.txt: Added.
• fast/js/regress/array-nonarray-polymorphic-access.html: Added.
• fast/js/regress/script-tests/array-nonarray-polymorphic-access.js: Added.

(f):
(run):

12:24 PM Changeset in webkit [149833] by Darin Adler

• 7 edits in trunk/Source

RenderQuote has giant function for language to quotes map
​https://bugs.webkit.org/show_bug.cgi?id=115807

Reviewed by Anders Carlsson.

Source/WebCore:

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
(WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
assertion with && in it into two separate assertions.
(WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
to check that the number of distinct quote characters is small enough to fit into
our fixed size array below.
(WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
Returns a pointer to a struct that contains the four quote characters. This new
function doesn't have the massive amount of code that the old one did. We use the
standard library bsearch function to do a binary search.
(WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
character; one string for any given character.
(WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
(WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
(WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
used to be in the quotesData function.
(WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
special case for the first quote in a RenderView; sharing the code is better and
there is no significant performance difference. Also use m_isAttached directly
when looking at predecessores so there is no need for an isAttached function.
(WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
(WebCore::RenderQuote::updateDepth): Ditto.

• rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since

we call the originalText function in the class and we don't want to do a virtual
function dispatch for that. Removed uneeded const from an argument. Removed a
stray semicolon. Removed the quotesData and isAttached functions, since they are no
longer needed. Renamed m_attached to m_isAttached.

• rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that

takes four quote strings. This was only used to build up the quotes table.

• rendering/style/QuotesData.h: Ditto.

Source/WTF:

• wtf/unicode/CharacterNames.h: Added a couple of character names.

12:03 PM Changeset in webkit [149832] by andersca@apple.com

• 15 edits in trunk/Source/WebKit2

Use explicit qualifiers for names in the std:: namespace
​https://bugs.webkit.org/show_bug.cgi?id=115868

Reviewed by Andreas Kling.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

• UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearAllSiteData):

• UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginForExtension):

• UIProcess/WebFrameProxy.cpp:
• UIProcess/WebProcessProxy.cpp:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):

• WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::deliverDataToPlugin):

• WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
• WebProcess/WebPage/DrawingAreaImpl.cpp:
• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):

• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::drawPDFPage):

• WebProcess/mac/WebProcessMac.mm:

12:00 PM Changeset in webkit [149831] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

• Api/InRegionScroller_p.h:
• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::transcode):

• Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::render):

• Api/WebPageCompositor.h:
• Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

• Api/WebSettings_p.h:

11:49 AM Changeset in webkit [149830] by commit-queue@webkit.org

• 14 edits
  3 adds in trunk

shouldUsePluginDocument() needs to be respected when a document is created
​https://bugs.webkit.org/show_bug.cgi?id=110308

Patch by Max Feil <​mfeil@rim.com> on 2013-05-09
Reviewed by Rob Buis.

Source/WebCore:

In DOMImplementation::createDocument() we should create
a PluginDocument for mime types that return "true" for
shouldAlwaysUsePluginDocument(), even if there is no pluginData
for them. This lets a client choose plugins for which the "missing
plugin" text or icon should appear more consistently. Otherwise
plugins referenced by iFrames will be treated as an HTMLDocument,
possibly resulting in binary files rendered as gibberish text.

Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Source/WebKit/blackberry:

This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):

• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/win:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit2:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

11:47 AM Changeset in webkit [149829] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Fix an exception when hovering native functions while paused in the debugger.

​https://webkit.org/b/115866
rdar://problem/13681982

Reviewed by Darin Adler and Joseph Pecoraro.

• inspector/InjectedScriptSource.js:

(InjectedScript.prototype.getFunctionDetails): Return an error if the details
is null or undefined.

11:42 AM Changeset in webkit [149828] by Darin Adler

• 2 edits in trunk/Source/WebCore

[Mac] CFError leak under Objective-C garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=115862

Reviewed by Benjamin Poulain.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
the CFError needs a CFRelease, not an -[NSObject release].

11:38 AM Changeset in webkit [149827] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
​https://bugs.webkit.org/show_bug.cgi?id=114953

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

data->layer needs a cast in order to call setHolePunchRect().

• plugins/blackberry/NPCallbacksBlackBerry.cpp:

(WebCore::npSetHolePunchHandler):

11:32 AM Changeset in webkit [149826] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update SelectionHandler to match check-webkit-style updates.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):

• WebKitSupport/SelectionHandler.h:

(SelectionHandler):

11:24 AM Changeset in webkit [149825] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Set up logging buffer on start of jsc executable
​https://bugs.webkit.org/show_bug.cgi?id=114688

Patch by Joe Mason <​jmason@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internal PR: 322715
Internally Reviewed By: Jeff Rogers

• jsc.cpp:

(main): call BB::Platform::setupApplicationLogging

11:13 AM Changeset in webkit [149824] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/graphics BlackBerry sources
to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
• platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::readPixelsIMG):
(WebCore::GraphicsContext3D::paintToCanvas):

• platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):

• platform/graphics/blackberry/IntRectBlackBerry.cpp:

(WebCore::IntRect::IntRect):

• platform/graphics/blackberry/LayerCompositingThread.h:

(WTF::::deref):

• platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::compositeLayersRecursive):

• platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setFrame):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

• platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::JPEGImageDecoder):

11:02 AM Changeset in webkit [149823] by mifenton@rim.com

• 5 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/network/blackberry
to match check-webkit-style updates.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleSetCookieHeader):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::shouldSendClientData):

• platform/network/blackberry/NetworkJob.h:

(NetworkJob):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::isRSSContent):
(WebCore::transcode):

10:59 AM Changeset in webkit [149822] by mifenton@rim.com

• 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/blackberry to match check-webkit-style updates.

No functional changes.

• platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

• platform/blackberry/CookieMap.h:

(WebCore::CookieMap::count):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/LoggingBlackBerry.cpp:
• platform/blackberry/PageClientBlackBerry.h:

(Platform):
(Graphics):
(WebCore):

• platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

• platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:

(WebCore::signedPublicKeyAndChallengeString):

• platform/blackberry/ScrollAnimatorBlackBerry.h:

10:40 AM Changeset in webkit [149821] by msaboff@apple.com

• 4 edits
  4 adds in trunk/Source

JSC: There should be a disassembler for ARM Thumb 2
​https://bugs.webkit.org/show_bug.cgi?id=115827

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. The opcode coverage is currently not complete. It covers all
of the integer instructions JSC currently emits, but only a limited number of
floating point opcodes. Currently that is just the 64 bit vmov and vmsr instructions.

The disassembler is structured as a base opcode class ARMv7DOpcode with sub-classes
for each instruction group. There is a public format method that does the bulk of
the disassembly work. There are two broad sub-classes, ARMv7D16BitOpcode and
ARMv7D32BitOpcode, for the 16 bit and 32 bit opcodes. There are sub-classes under
those two classes for individual and related groups of opcodes. Instructions are
"dispatched" to the right subclass via two arrays of linked lists in the inner classes
OpcodeGroup. There is one such inner class for each ARMv7D16BitOpcode and ARMv7D32BitOpcode.
Each OpcodeGroup has a mask and a pattern that it applies to the instruction to determine
that it matches a particular group. OpcodeGroup uses a static method to reinterpret_cast
the Opcode object to the right base class for the instruction group for formatting.
The cast eliminates the need of allocating an object for each decoded instruction.
Unknown instructions are formatted as ".word 1234" or ".long 12345678" depending whether
the instruction is 16 or 32 bit.

• JavaScriptCore.xcodeproj/project.pbxproj:
• disassembler/ARMv7: Added.
• disassembler/ARMv7/ARMv7DOpcode.cpp: Added.

(ARMv7Disassembler):
(OpcodeGroupInitializer):
(JSC::ARMv7Disassembler::ARMv7DOpcode::init):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::saveITConditionAt):
(JSC::ARMv7Disassembler::ARMv7DOpcode::fetchOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::disassemble):
(JSC::ARMv7Disassembler::ARMv7DOpcode::bufferPrintf):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendFPRegisterName):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::appendModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::appendImmShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::appendFPRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::format):

• disassembler/ARMv7/ARMv7DOpcode.h: Added.

(ARMv7Disassembler):
(ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::is32BitInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::isFPInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::conditionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::shiftName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::inITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startingITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::endITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionNameNoITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSeparator):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendCharacter):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendString):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftType):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendPCRelativeOffset):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftAmount):
(ARMv7D16BitOpcode):
(OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeAddRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rm):
(ARMv7DOpcodeAddSPPlusImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::immediate8):
(ARMv7DOpcodeAddSubtract):
(ARMv7DOpcodeAddSubtractT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rn):
(ARMv7DOpcodeAddSubtractImmediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::rn):
(ARMv7DOpcodeAddSubtractImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::immediate8):
(ARMv7DOpcodeBranchConditionalT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::offset):
(ARMv7DOpcodeBranchExchangeT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::rm):
(ARMv7DOpcodeBranchT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::immediate11):
(ARMv7DOpcodeCompareImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::immediate8):
(ARMv7DOpcodeCompareRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::rn):
(ARMv7DOpcodeCompareRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rm):
(ARMv7DOpcodeDataProcessingRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rdn):
(ARMv7DOpcodeGeneratePCRelativeAddress):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::immediate8):
(ARMv7DOpcodeLoadFromLiteralPool):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::immediate8):
(ARMv7DOpcodeLoadStoreRegisterImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
(ARMv7DOpcodeLoadStoreRegisterImmediateWordAndByte):
(ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord):
(ARMv7DOpcodeLoadStoreRegisterOffsetT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rt):
(ARMv7DOpcodeLoadStoreRegisterSPRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::immediate8):
(ARMv7DOpcodeLogicalImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::immediate5):
(ARMv7DOpcodeMiscAddSubSP):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::immediate7):
(ARMv7DOpcodeMiscByteHalfwordOps):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::op):
(ARMv7DOpcodeMiscBreakpointT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::immediate8):
(ARMv7DOpcodeMiscCompareAndBranch):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::immediate6):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::rn):
(ARMv7DOpcodeMiscHint16):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opA):
(ARMv7DOpcodeMiscIfThenT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::firstCondition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::mask):
(ARMv7DOpcodeMiscPushPop):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
(ARMv7DOpcodeMoveImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::immediate8):
(ARMv7DOpcodeMoveRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rm):
(ARMv7D32BitOpcode):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rn):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rt):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeBranchRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::immediate11):
(ARMv7DOpcodeConditionalBranchT3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::immediate6):
(ARMv7DOpcodeBranchOrBranchLink):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::immediate10):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::isBL):
(ARMv7DOpcodeDataProcessingLogicalAndRithmetic):
(ARMv7DOpcodeDataProcessingModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::immediate12):
(ARMv7DOpcodeDataProcessingShiftedReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::type):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tbBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tBit):
(ARMv7DOpcodeDataProcessingReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op2):
(ARMv7DOpcodeDataProcessingRegShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::opName):
(ARMv7DOpcodeDataProcessingRegExtend):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendAndAddName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::rotate):
(ARMv7DOpcodeDataProcessingRegParallel):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::opName):
(ARMv7DOpcodeDataProcessingRegMisc):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::opName):
(ARMv7DOpcodeHint32):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::isDebugHint):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::debugOption):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::op):
(ARMv7DOpcodeFPTransfer):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opH):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opC):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vn):
(ARMv7DOpcodeDataLoad):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::op):
(ARMv7DOpcodeLoadRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::immediate2):
(ARMv7DOpcodeLoadSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::immediate8):
(ARMv7DOpcodeLoadUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::immediate12):
(ARMv7DOpcodeLongMultipleDivide):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlalOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlaldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlsldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdLo):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdHi):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::nBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::mBit):
(ARMv7DOpcodeDataPushPopSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::op):
(ARMv7DOpcodeDataStoreSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::op):
(ARMv7DOpcodeStoreSingleImmediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::immediate12):
(ARMv7DOpcodeStoreSingleImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::immediate8):
(ARMv7DOpcodeStoreSingleRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::immediate2):
(ARMv7DOpcodeUnmodifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::shBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::bitNumOrSatImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate16):
(ARMv7DOpcodeVMOVDoublePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::vm):
(ARMv7DOpcodeVMOVSinglePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::vm):
(ARMv7DOpcodeVMSR):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::rt):

• disassembler/ARMv7Disassembler.cpp: Added.

(JSC::tryToDisassemble):

Source/WTF:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. Enabled the disassembler for IOS bulds.

• wtf/Platform.h:

9:54 AM Changeset in webkit [149820] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebPage and WebPageClient to match check-webkit-style updates.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):

• Api/WebPageClient.h:
• Api/WebPage_p.h:

9:51 AM Changeset in webkit [149819] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update BackingStore to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):

• Api/BackingStore_p.h:

(BackingStoreGeometry):

9:36 AM WebKit Team edited by simon.pena@samsung.com

Adding myself (diff)

9:16 AM Changeset in webkit [149818] by mifenton@rim.com

• 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.

• WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

• WebCoreSupport/CredentialManager.h:

(CredentialManager):

• WebCoreSupport/CredentialTransformData.cpp:
• WebCoreSupport/FrameLoaderClientBlackBerry.h:

(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):

• WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::onLocationUpdate):

• WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

• WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

9:13 AM Changeset in webkit [149817] by crogers@google.com

• 29 edits in trunk/Source/WebCore

Require use of AudioBus::create() to avoid ref-counting issues
​https://bugs.webkit.org/show_bug.cgi?id=115836

Reviewed by Andreas Kling.

There were a couple of places still embedding raw AudioBus objects as
member variables or local variables causing ref-counting problems
now that AudioBus is ref-counted. Make AudioBus constructor private
to enforce use of AudioBus::create().

Adapted from Blink patch:
​https://chromiumcodereview.appspot.com/14628008/

• Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
(LocalAudioInputProvider):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):

• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

• Modules/webaudio/ScriptProcessorNode.h:

(ScriptProcessorNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):

• platform/audio/AudioFIFO.h:

(AudioFIFO):

• platform/audio/AudioPullFIFO.cpp:

(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::fillBuffer):

• platform/audio/AudioPullFIFO.h:

(AudioPullFIFO):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):
(WebCore):

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

• platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::render):

• platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS):

• platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):

• platform/audio/mac/AudioDestinationMac.h:

(AudioDestinationMac):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

9:09 AM Changeset in webkit [149816] by zhajiang@rim.com

• 5 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-09.
Reviewed by Rob Buis.

Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'

within '

' [-Wparentheses].

SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].

• Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

• WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):

• WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):

9:02 AM Changeset in webkit [149815] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):

8:51 AM Changeset in webkit [149814] by commit-queue@webkit.org

• 9 edits
  4 adds in trunk/Source

[BlackBerry] Upstream the input popups
​https://bugs.webkit.org/show_bug.cgi?id=114608

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team, including:

Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang

Source/WebCore:

• Resources/blackberry/colorControlBlackBerry.css: Added.

(.color-picker-popup-area):
(.color-picker-content):
(.color-picker-block):
(#color-picker-swatch-block):
(.color-picker-switcher):
(.color-picker-check-mark):
(.color-picker-option):
(.color-picker-button):
(.color-picker-highlight):
(input):
(.color-picker-sharp):
(.color-picker-off):
(.color-picker-inactive-font):
(.color-picker-row):
(.color-picker-hex-style):
(.color-picker-input):
(.color-picker-well):
(.color-picker-input .color-picker-well):
(.color-picker-slider):
(.color-picker-slider-output):
(.color-picker-range):
(.color-picker-range::-webkit-slider-thumb):
(.color-picker-range::-webkit-slider-thumb:active):
(.red-ranger-bg):
(.green-ranger-bg):
(.blue-ranger-bg):
(@media only screen and (height: 768px)):
(@media only screen and (height: 720px)):

• Resources/blackberry/colorControlBlackBerry.js: Added.

(.):

• Resources/blackberry/popupControlBlackBerry.css:

(body):
(.popup-area):
(.popup-header):
(.popup-content):
(.popup-buttons):
(.popup-button):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/selectControlBlackBerry.css:

(.popup-content):
(@media (min-height: 918px)):
(.option):
(@media only screen and (width: 720px) and (height: 720px)):
(.contents):
(.option:active):
(.selected):
(.selected .contents::after):
(.text):
(.disabled):
(.optgroup):
(.optgroup-option):

• Resources/blackberry/selectControlBlackBerry.js:

(.):

• Resources/blackberry/timeControlBlackBerry.css: Added.

(#popup-content-time):
(.column):
(.column:not(:last-child)):
(.cell):
(.yearmonthdate .cell div:last-child):
(.row-highlight-container):
(.row-highlight-filler):
(.row-highlight):
(.tall-bit):
(@media only screen and (width: 720px) and (height: 720px)):

• Resources/blackberry/timeControlBlackBerry.js: Added.

(.):

Source/WebKit/blackberry:

• WebCoreSupport/ColorPickerClient.cpp:

(WebCore):
(WebCore::ColorPickerClient::generateHTML):

• WebCoreSupport/DatePickerClient.cpp:

(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):

• WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

• WebCoreSupport/SelectPopupClient.cpp:

(WebCore):
(WebCore::SelectPopupClient::generateHTML):

8:46 AM Changeset in webkit [149813] by rwlbuis@webkit.org

• 16 edits in trunk/Source/WebCore

[BlackBerry] texmap code generates warnings
​https://bugs.webkit.org/show_bug.cgi?id=115815

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-09
Reviewed by Benjamin Poulain.

Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
these files unconditionally.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
• platform/graphics/texmap/GraphicsLayerTextureMapper.h:
• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperBackingStore.cpp:
• platform/graphics/texmap/TextureMapperBackingStore.h:
• platform/graphics/texmap/TextureMapperFPSCounter.cpp:
• platform/graphics/texmap/TextureMapperFPSCounter.h:
• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperGL.h:
• platform/graphics/texmap/TextureMapperLayer.cpp:
• platform/graphics/texmap/TextureMapperLayer.h:
• platform/graphics/texmap/TextureMapperTile.cpp:
• platform/graphics/texmap/TextureMapperTile.h:
• platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
• platform/graphics/texmap/TextureMapperTiledBackingStore.h:

8:44 AM Changeset in webkit [149812] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

PluginDatabase: add plugin directory for the BlackBerry port.
​https://bugs.webkit.org/show_bug.cgi?id=114943

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

XP_UNIX is defined for the BlackBerry port, but we don't want to
share the same code here.

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

8:43 AM Changeset in webkit [149811] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update DOMSupport to match check-webkit-style updates.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

8:42 AM Changeset in webkit [149810] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
​https://bugs.webkit.org/show_bug.cgi?id=115843

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internally reviewed by Mary Wu.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:35 AM Changeset in webkit [149809] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update FatFingers to match check-webkit-style updates.

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):

• WebKitSupport/FatFingers.h:

(FatFingersResult):

8:26 AM Changeset in webkit [149808] by mifenton@rim.com

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.

• WebKitSupport/InRegionScrollableArea.cpp:
• WebKitSupport/TileIndexHash.h:
• WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

8:16 AM Changeset in webkit [149807] by commit-queue@webkit.org

• 8 edits
  2 deletes in trunk/Source/WebCore

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
​https://bugs.webkit.org/show_bug.cgi?id=115850

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.

Removed the Memory Instrumentation Code after r148921.

No new tests, no behavior change.

• inspector/compile-front-end.py:
• inspector/front-end/NativeMemorySnapshotView.js: Removed.
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

• inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

• inspector/front-end/SettingsScreen.js:
• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.css:
• inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

• inspector/front-end/nativeMemoryProfiler.css: Removed.

8:11 AM Changeset in webkit [149806] by mifenton@rim.com

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
​https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Styles fixes required for InputHandler based on updated
check-webkit-style.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

• WebKitSupport/InputHandler.h:

7:26 AM Changeset in webkit [149805] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r149796.

• GNUmakefile.am: Add a phony target for the window constructors file and include it among

the dependencies for the non-generated code.

7:03 AM Changeset in webkit [149804] by timothy@apple.com

• 2 edits in trunk/Source/WebKit2

Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.

​https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.

6:50 AM Changeset in webkit [149803] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

[CSSRegions] Change fast/regions/webkit-flow-inlines-inside-regions-bounds[-vertical] tests to make them platform independent
​https://bugs.webkit.org/show_bug.cgi?id=115851

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Modified tests to make them platform independent by using Ahem and no font smoothing.

• fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
• fast/regions/webkit-flow-inlines-inside-regions-bounds.html:

6:48 AM Changeset in webkit [149802] by commit-queue@webkit.org

• 10 edits in trunk/LayoutTests

[Qt][EFL][GTK] Failing CSS region tests
​https://bugs.webkit.org/show_bug.cgi?id=115785

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Updated tests to overcome platform differences
Unskip fixed CSS regions tests

• fast/regions/webkit-flow-double-pagination-float-push-expected.html:
• fast/regions/webkit-flow-double-pagination-float-push.html:
• fast/regions/webkit-flow-float-pushed-to-last-region-expected.html:
• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• fast/regions/webkit-flow-float-unable-to-push-expected.html:
• fast/regions/webkit-flow-float-unable-to-push.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds.html:
• platform/qt/TestExpectations:

6:12 AM Changeset in webkit [149801] by zarvai@inf.u-szeged.hu

• 9 edits
  10 copies
  36 adds in trunk/LayoutTests

[Qt] Unreviewed gardeing. Updating some png expected results.

• platform/qt-5.0-wk2/compositing/checkerboard-expected.png: Added.
• platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png: Added.
• platform/qt-5.0-wk2/editing/deleting/delete-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/inserting/typing-around-image-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-by-character-002-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
• platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-04-expecrted.png: Added.
• platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png: Added.
• platform/qt-5.0-wk2/fast/box-shadow/shadow-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/dom/34176-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
• platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png: Added.
• platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Added.
• platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png: Added.
• platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png: Added.
• platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
• platform/qt-5.0-wk2/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/add-table-overpaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png:
• platform/qt-5.0-wk2/fast/repaint/change-transform-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/inline-outline-repaint-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png:
• platform/qt-5.0-wk2/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
• platform/qt-5.0-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
• platform/qt-5.0-wk2/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
• platform/qt-5.0-wk2/fast/repaint/table-row-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
• platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
• platform/qt-5.0-wk2/svg/custom/repaint-on-image-bounds-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/custom/use-disappears-after-style-update-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dom/rect-modify-rx-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
• platform/qt-5.0-wk2/svg/repaint/svgsvgelement-repaint-children-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
• platform/qt-5.0-wk2/svg/text/tspan-dynamic-positioning-expected.png: Added.

6:11 AM Changeset in webkit [149800] by akling@apple.com

• 2 edits in trunk/Source/WebKit/qt

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<​http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

3:05 AM WebKitIDL edited by Christophe Dumez

Add documentation for [NoInterfaceObject] introduced in r149796 (diff)

2:40 AM WebKitIDL edited by Christophe Dumez

Move extended attribute to their correct place (diff)

2:18 AM Changeset in webkit [149799] by kadam@inf.u-szeged.hu

• 1 edit
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected file after r149758.

• platform/qt/fast/js/global-constructors-attributes-expected.txt: Added after r149758.

2:07 AM Changeset in webkit [149798] by mario@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Update Simon Pena email on his behalf.

• Scripts/webkitpy/common/config/contributors.json:

1:14 AM Changeset in webkit [149797] by Christophe Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt minimal build.

r149796 broke builds that have WEB_SOCKETS flag disabled.

• page/DOMWindow.idl:

12:38 AM Changeset in webkit [149796] by Christophe Dumez

• 215 edits
  4 deletes in trunk

Add support for [NoInterfaceObject] Web IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115714

Reviewed by Kentaro Hara.

.:

Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
optional argument.

• Source/cmake/WebKitMacros.cmake:

Source/WebCore:

*Constructor attributes on the global DOMWindow object are now automatically
generated for each non-callback interface that is not declared with the
[NoInterfaceObject] extended attribute. It is thus no longer needed for
developers to manually add *Constructor attributes for their new interfaces
unless they wish to register an "extra" constructor for their interface.

This patch does not modify at all the behavior on JS side. To achieve this,
[NoInterfaceObject] extended attribute is added to interfaces that should
not have it according to specification (e.g. History, Location, ...).
This can be improved later as the behavior should not change with this
patch.

No new tests, no behavior change.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeyNeededEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/filesystem/DOMFileSystem.idl:
• Modules/filesystem/DOMFileSystemSync.idl:
• Modules/filesystem/DirectoryEntry.idl:
• Modules/filesystem/DirectoryEntrySync.idl:
• Modules/filesystem/DirectoryReader.idl:
• Modules/filesystem/DirectoryReaderSync.idl:
• Modules/filesystem/Entry.idl:
• Modules/filesystem/EntryArray.idl:
• Modules/filesystem/EntryArraySync.idl:
• Modules/filesystem/EntrySync.idl:
• Modules/filesystem/FileEntry.idl:
• Modules/filesystem/FileEntrySync.idl:
• Modules/filesystem/FileWriter.idl:
• Modules/filesystem/FileWriterSync.idl:
• Modules/filesystem/Metadata.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Coordinates.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/geolocation/Geoposition.idl:
• Modules/geolocation/PositionError.idl:
• Modules/indexeddb/DOMWindowIndexedDatabase.idl:
• Modules/indexeddb/IDBAny.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediastream/DOMWindowMediaStream.idl: Removed.
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/MediaStreamTrackEvent.idl:
• Modules/mediastream/NavigatorUserMediaError.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDTMFToneChangeEvent.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCDataChannelEvent.idl:
• Modules/mediastream/RTCIceCandidateEvent.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/DOMWindowNotifications.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/speech/DOMWindowSpeech.idl: Removed.
• Modules/speech/DOMWindowSpeechSynthesis.idl:
• Modules/speech/SpeechGrammar.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechRecognitionAlternative.idl:
• Modules/speech/SpeechRecognitionError.idl:
• Modules/speech/SpeechRecognitionEvent.idl:
• Modules/speech/SpeechRecognitionResult.idl:
• Modules/speech/SpeechRecognitionResultList.idl:
• Modules/speech/SpeechSynthesis.idl:
• Modules/speech/SpeechSynthesisVoice.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioDestinationNode.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/AudioSourceNode.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/ChannelMergerNode.idl:
• Modules/webaudio/ChannelSplitterNode.idl:
• Modules/webaudio/ConvolverNode.idl:
• Modules/webaudio/DOMWindowWebAudio.idl: Removed.
• Modules/webaudio/DelayNode.idl:
• Modules/webaudio/DynamicsCompressorNode.idl:
• Modules/webaudio/GainNode.idl:
• Modules/webaudio/MediaElementAudioSourceNode.idl:
• Modules/webaudio/MediaStreamAudioDestinationNode.idl:
• Modules/webaudio/MediaStreamAudioSourceNode.idl:
• Modules/webaudio/OfflineAudioContext.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webaudio/ScriptProcessorNode.idl:
• Modules/webaudio/WaveShaperNode.idl:
• Modules/webaudio/WaveTable.idl:
• Modules/webdatabase/DOMWindowWebDatabase.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLError.idl:
• Modules/webdatabase/SQLResultSet.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/websockets/DOMWindowWebSocket.idl: Removed.
• Modules/websockets/WebSocket.idl:
• PlatformBlackBerry.cmake:
• UseJSC.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/IDLParser.pm:

(parseTypedef):

• bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):
(getFileContents):
(getPartialInterfaceNameFromIDL):
(isCallbackInterfaceFromIDL):
(trim):
(getInterfaceExtendedAttributesFromIDL):

• css/CSSFontFaceLoadEvent.idl:
• css/CSSFontFaceRule.idl:
• css/CSSSupportsRule.idl:
• css/CSSUnknownRule.idl:
• css/DOMWindowCSS.idl:
• css/FontLoader.idl:
• css/MediaQueryList.idl:
• css/MediaQueryListListener.idl:
• css/StyleMedia.idl:
• dom/CustomElementConstructor.idl:
• dom/DOMError.idl:
• dom/DOMNamedFlowCollection.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/NodeIterator.idl:
• dom/ShadowRoot.idl:
• dom/TreeWalker.idl:
• dom/WebKitNamedFlow.idl:
• fileapi/FileException.idl:
• fileapi/FileReaderSync.idl:
• html/HTMLAudioElement.idl:
• html/HTMLDetailsElement.idl:
• html/HTMLOptionElement.idl:
• html/MediaError.idl:
• html/MediaKeyError.idl:
• html/MicroDataItemValue.idl:
• html/RadioNodeList.idl:
• html/ValidityState.idl:
• html/canvas/CanvasRenderingContext.idl:
• html/canvas/DOMPath.idl:
• html/canvas/EXTDrawBuffers.idl:
• html/canvas/EXTTextureFilterAnisotropic.idl:
• html/canvas/OESElementIndexUint.idl:
• html/canvas/OESStandardDerivatives.idl:
• html/canvas/OESTextureFloat.idl:
• html/canvas/OESTextureHalfFloat.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/WebGLCompressedTextureATC.idl:
• html/canvas/WebGLCompressedTexturePVRTC.idl:
• html/canvas/WebGLCompressedTextureS3TC.idl:
• html/canvas/WebGLContextAttributes.idl:
• html/canvas/WebGLDebugRendererInfo.idl:
• html/canvas/WebGLDebugShaders.idl:
• html/canvas/WebGLDepthTexture.idl:
• html/canvas/WebGLLoseContext.idl:
• html/canvas/WebGLVertexArrayObjectOES.idl:
• html/track/AudioTrack.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrackRegionList.idl:
• html/track/VideoTrack.idl:
• html/track/VideoTrackList.idl:
• inspector/InjectedScriptHost.idl:
• inspector/InspectorFrontendHost.idl:
• inspector/JavaScriptCallFrame.idl:
• inspector/ScriptProfile.idl:
• inspector/ScriptProfileNode.idl:
• loader/appcache/DOMApplicationCache.idl:
• page/AbstractView.idl:
• page/BarInfo.idl:
• page/Console.idl:
• page/Crypto.idl:
• page/DOMSecurityPolicy.idl:
• page/DOMWindow.idl:
• page/History.idl:
• page/Location.idl:
• page/MemoryInfo.idl:
• page/Navigator.idl:
• page/PagePopupController.idl:
• page/Performance.idl:
• page/PerformanceEntry.idl:
• page/PerformanceEntryList.idl:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.idl:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.idl:
• page/Screen.idl:
• page/SpeechInputResult.idl:
• page/SpeechInputResultList.idl:
• page/WorkerNavigator.idl:
• page/make_settings.pl:

(generateInternalSettingsIdlFile):

• svg/ElementTimeControl.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGExternalResourcesRequired.idl:
• svg/SVGFilterPrimitiveStandardAttributes.idl:
• svg/SVGFitToViewBox.idl:
• svg/SVGLangSpace.idl:
• svg/SVGLocatable.idl:
• svg/SVGStyledElement.idl:
• svg/SVGTests.idl:
• svg/SVGTransformable.idl:
• svg/SVGURIReference.idl:
• testing/InternalSettings.idl:
• testing/Internals.idl:
• testing/MallocStatistics.idl:
• testing/TypeConversions.idl:
• workers/AbstractWorker.idl:
• workers/DedicatedWorkerContext.idl:
• workers/SharedWorker.idl:
• workers/SharedWorkerContext.idl:
• workers/WorkerContext.idl:
• workers/WorkerLocation.idl:
• xml/XPathExpression.idl:
• xml/XPathNSResolver.idl:

Tools:

Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

12:05 AM Changeset in webkit [149795] by commit-queue@webkit.org

• 5 edits in trunk

[GTK][AC] Buildfix after r149694
​https://bugs.webkit.org/show_bug.cgi?id=115797

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-05-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some interfaces, such as a return value and parameters of functions are changed.

No new tests since no functionality changed.

• platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

• platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

Tools:

Add CLUTTER_LIBS for linking TestWebCore.

• TestWebKitAPI/GNUmakefile.am:

May 8, 2013:

11:39 PM Changeset in webkit [149794] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Brent Fulgham.

Get rid of the following warning for BlackBerry:

NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

by not compiling any of the code to add protocols to the protocol whitelist.

• Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

11:38 PM Changeset in webkit [149793] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Windows] The function seekFile() is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=115246

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-08
Reviewed by Brent Fulgham.

Implemented seekFile() function for Windows.

• platform/win/FileSystemWin.cpp:

(WebCore::seekFile):

11:31 PM Changeset in webkit [149792] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Fix a typo in Settings.js
​https://bugs.webkit.org/show_bug.cgi?id=115849

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Joseph Pecoraro.

No new tests, no behavior change.

• inspector/front-end/Settings.js:

(WebInspector.Settings):

10:26 PM Changeset in webkit [149791] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

SecurityOrigin doesn’t need to forward declare or include Document
​https://bugs.webkit.org/show_bug.cgi?id=115847

Reviewed by Alexey Proskuryakov.

Merge ​https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.

Removed unused Document forward declaration+include from SecurityOrigin.

• page/SecurityOrigin.cpp:
• page/SecurityOrigin.h:

9:58 PM EFLWebKit edited by gyuyoung.kim@samsung.com

Update dependency pkgs (diff)

9:50 PM Changeset in webkit [149790] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Tools

[EFL] Remove unnecessary pkgs in EFL jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=114908

Reviewed by Laszlo Gombos.

p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.

• efl/jhbuild.modules:

8:52 PM Changeset in webkit [149789] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

BUILD FIX: Don't use adoptCF() with NSDictionary * object

Fixes the following build failure:

In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
/usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."

static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");

/usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here

return RetainPtr<T>(AdoptCF, o);

Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here

RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));

1 error generated.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Switch from adoptCF() to
adoptNS(). This is in USE(CFNETWORK) code, so it's not
exercised on the Mac.

8:12 PM Changeset in webkit [149788] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

8:00 PM Changeset in webkit [149787] by Lucas Forschler

• 1 copy in tags/Safari-537.41

New Tag.

7:12 PM Changeset in webkit [149786] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Disable SHADOW DOM feature in FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=115834

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Gyuyoung Kim.

• Scripts/webkitperl/FeatureList.pm:

6:11 PM Changeset in webkit [149785] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove Editor::setSelectionOffsets
​https://bugs.webkit.org/show_bug.cgi?id=115831

Reviewed by Andreas Kling.

Removed the function added in r120985 for Chromium Android port.

• editing/Editor.cpp:
• editing/Editor.h:

6:02 PM Changeset in webkit [149784] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix a typo in a comment.

Rubber-stamped by Darin Adler.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

5:49 PM Changeset in webkit [149783] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Remove bogus StorageAreaMap assertions
​https://bugs.webkit.org/show_bug.cgi?id=115838

Reviewed by Sam Weinig.

It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didClear):

5:24 PM Changeset in webkit [149782] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Get rid of duplicate entry line in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=115828

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08

• platform/efl/TestExpectations:

5:20 PM Changeset in webkit [149781] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Handle incoming clear operations
​https://bugs.webkit.org/show_bug.cgi?id=115829

Reviewed by Sam Weinig.

Handle clear by building up a new storage map with our pending changes.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::applyChange):

4:51 PM Changeset in webkit [149780] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Potential use-after-free of Frame
​https://bugs.webkit.org/show_bug.cgi?id=115774

Reviewed by Simon Fraser.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.

• page/Frame.cpp:

(WebCore::Frame::setPrinting):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::deviceOrPageScaleFactorChanged):

4:43 PM Changeset in webkit [149779] by roger_fong@apple.com

• 5 edits in trunk/Source/WebCore

Unreviewed build fix, AppleWin port.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
(WebCore):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

4:38 PM Changeset in webkit [149778] by xingnan.wang@intel.com

• 24 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::AudioNodeOutput::pull
​https://bugs.webkit.org/show_bug.cgi?id=111362

Reviewed by Chris Rogers.

• Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::createFromAudioFileData):

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

• Modules/webaudio/AudioNodeInput.h:

(AudioNodeInput):

• Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):

• Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

• Modules/webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

• platform/audio/AudioBus.h:

(AudioBus):

• platform/audio/AudioFileReader.h:

(WebCore):

• platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

• platform/audio/AudioResampler.h:

(AudioResampler):

• platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

• platform/audio/MultiChannelResampler.cpp:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

• platform/audio/Reverb.h:

(Reverb):

• platform/audio/efl/AudioBusEfl.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

• platform/audio/mac/AudioFileReaderMac.h:

(AudioFileReader):

• platform/audio/qt/AudioBusQt.cpp:

(WebCore::AudioBus::loadPlatformResource):

4:31 PM Changeset in webkit [149777] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Don't apply changes while we're clearing the database
​https://bugs.webkit.org/show_bug.cgi?id=115826

Reviewed by Darin Adler.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::openDatabase):
Only call didOpenDatabaseWithOrigin if we actually did open the database.

(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Create the database if needed.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
Send back a DidGetValues message.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
Initialize m_hasPendingClear.

(WebKit::StorageAreaMap::clear):
Set m_hasPendingClear to true.

(WebKit::StorageAreaMap::resetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.

(WebKit::StorageAreaMap::didGetValues):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::didClear):
Set m_hasPendingClear back to false.

(WebKit::StorageAreaMap::applyChange):
Don't apply the change if m_hasPendingClear is true.

• WebProcess/Storage/StorageAreaMap.messages.in:

Add DidGetValues message.

4:15 PM Changeset in webkit [149776] by Lucas Forschler

• 2 edits in trunk/Tools

Add Scheduler for Mac MtnLion 32bit Release builder.

Unreviewed.

• BuildSlaveSupport/build.webkit.org-config/config.json:

4:08 PM Changeset in webkit [149775] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
​https://bugs.webkit.org/show_bug.cgi?id=115808

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-05-08
Reviewed by Darin Adler.

The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.

• gdb/webkit.py:

(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.

3:41 PM Changeset in webkit [149774] by aestes@apple.com

• 5 edits
  2 adds in trunk

[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
​https://bugs.webkit.org/show_bug.cgi?id=115790

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

NSMutableSet does not support adding or removing nil objects, and
WTF::HashSet does not support adding, removing, or checking for null
WTF::Strings.

For the NSMutableSet case, make sure that we don't try to add or remove
nil NSStrings.

For the WTF::HashSet case, NSURL will return a nil NSString if we ask
it for its scheme when it is invalid, which we will convert to a null
WTF::String. Don't try to check if our HashSet of registered schemes
contains a null String.

• Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
isn't null. We reject null schemes at the WKBrowsingContextController level.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.

• UIProcess/API/mac/WKBrowsingContextController.mm:

(+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.

Tools:

Added two API tests:

1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):

3:40 PM Changeset in webkit [149773] by Lucas Forschler

• 2 edits in trunk/Tools

Teach buildbot how to compile 32-bit on Mac.

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):
(ExtractTestResultsAndLeaks):

3:34 PM Changeset in webkit [149772] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Apply remote changes to storage maps locally
​https://bugs.webkit.org/show_bug.cgi?id=115825

Reviewed by Beth Dakin.

• WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.

(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.

(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.

(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.

(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.

(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.

• WebProcess/Storage/StorageAreaMap.h:

3:26 PM Changeset in webkit [149771] by roger_fong@apple.com

• 2 edits
  1 copy in trunk/WebKitLibraries

Update WebKitLibraries/win to handle different architectures properly.

• win/lib32: Copied from win/lib.
• win/tools/WinTools.make:

3:08 PM Changeset in webkit [149770] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Simplify RetainPtrObjectHashTraits
​https://bugs.webkit.org/show_bug.cgi?id=115822

Reviewed by Benjamin Poulain.

RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.

• wtf/RetainPtr.h:

(WTF::RetainPtrObjectHashTraits::emptyValue):

3:05 PM Changeset in webkit [149769] by commit-queue@webkit.org

• 26 edits in trunk

[BlackBerry] Fix usage of BlackBerry::Platform::String
​https://bugs.webkit.org/show_bug.cgi?id=115781

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.

BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos

We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.

Source/WebCore:

• platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):

• platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):

• platform/blackberry/CursorBlackBerry.cpp:

(WebCore::Cursor::Cursor):

• platform/blackberry/PlatformBlob.cpp:

(WebCore::PlatformBlob::nextDataItem):

• platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:

(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):

• platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::Image::loadPlatformResource):

• platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):

• platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

• platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

• platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):

• platform/network/blackberry/rss/RSSFilterStream.h:
• platform/text/blackberry/StringBlackBerry.cpp:

(WTF::String::operator BlackBerry::Platform::String):

Source/WebKit/blackberry:

• Api/JavaScriptVariant.cpp:

(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):

• Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::base64Encode):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

• Api/WebPage.h:
• Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

• WebKitSupport/DefaultTapHighlight.cpp:

(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):

Tools:

• DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):

• DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setUserStyleSheetLocation):

• DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:

(LoadHTMLStringItem::invoke):

3:02 PM Changeset in webkit [149768] by andersca@apple.com

• 6 edits in trunk/Source

Assert at compile time that we don't pass Objective-C object pointers to adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115823

Reviewed by Geoffrey Garen.

Source/WebCore:

• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
Use adoptNS for CALayer.

Source/WebKit2:

Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.

• Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

Source/WTF:

static_assert in adoptCF that the object passed in is not an Objective-C object.

• wtf/RetainPtr.h:

2:56 PM Changeset in webkit [149767] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Tools: add new BlackBerry include dirs.
​https://bugs.webkit.org/show_bug.cgi?id=115514

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.

iType include dirs are missing, and HarfBuzz needs to be fixed.

• Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

1:53 PM Changeset in webkit [149766] by eric.carlson@apple.com

• 4 edits
  2 adds in trunk

TextTrackCue should support empty content
​https://bugs.webkit.org/show_bug.cgi?id=115821

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-cue-empty-text-crash.html

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render

cues with no content.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.

LayoutTests:

• media/track/track-cue-empty-text-crash-expected.txt: Added.
• media/track/track-cue-empty-text-crash.html: Added.

1:48 PM Changeset in webkit [149765] by weinig@apple.com

• 5 edits
  2 adds in trunk/Source/WebKit2

Add SPI to determine if a plugin is sandboxed
​https://bugs.webkit.org/show_bug.cgi?id=115810

Reviewed by Anders Carlsson.

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/Plugins/mac/PluginSandboxProfile.h: Added.
• Shared/Plugins/mac/PluginSandboxProfile.mm: Added.

(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:45 PM Changeset in webkit [149764] by roger_fong@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed AppleWin build fix.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):

1:33 PM Changeset in webkit [149763] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.

Get rid of the following warning for BlackBerry:

BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]

by using ASSERT_UNUSED instead of ASSERT.

• WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::create):

1:06 PM Changeset in webkit [149762] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
​https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>

Reviewed by Andreas Kling.

To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

1:02 PM Changeset in webkit [149761] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Coalesce WKView visibleRect changes
​https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>

Reviewed by Simon Fraser.

The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.

• UIProcess/WebPageProxy.h:

(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.

12:47 PM Changeset in webkit [149760] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove RetainPtr::adoptNS and RetainPtr::adoptCF
​https://bugs.webkit.org/show_bug.cgi?id=115817

Reviewed by Jessie Berlin.

These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.

Rewrite the move assignment operators to just call CFRelease explicitly.

• wtf/RetainPtr.h:

12:39 PM Changeset in webkit [149759] by zandobersek@gmail.com

• 12 edits in trunk

[GTK] Plumb the Automake build system for the Battery Status API feature
​https://bugs.webkit.org/show_bug.cgi?id=115718

Reviewed by Martin Robinson.

.:

• Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
• Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
• Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,

when the option is not given, is to disable the feature.

• Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
• Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.

Source/WebCore:

No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.

• GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.

Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.

• GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
• bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.

Tools:

• Scripts/webkitdirs.pm:

(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.

12:28 PM Changeset in webkit [149758] by Christophe Dumez

• 3 edits
  2 adds in trunk/LayoutTests

Add layout test that lists all global constructors
​https://bugs.webkit.org/show_bug.cgi?id=115724

Reviewed by Ryosuke Niwa.

Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.

• fast/js/global-constructors-attributes-expected.txt:
• fast/js/script-tests/global-constructors-attributes.js:

(classNameForObject):
(constructorPropertiesOnWindow):

• platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
• platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.

12:26 PM Changeset in webkit [149757] by rniwa@webkit.org

• 2 edits in trunk/Tools

new-run-webkit-websocketserver doesn't work after Chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115816

Reviewed by Joseph Pecoraro.

Fix the bug by instantiating the correct port object.

• Scripts/new-run-webkit-websocketserver:

(main):

12:19 PM Changeset in webkit [149756] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.

• fast/js/parse-error-external-script-in-eval.html:
• fast/js/parse-error-external-script-in-new-Function.html:

12:11 PM Changeset in webkit [149755] by roger_fong@apple.com

• 3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

11:54 AM Changeset in webkit [149754] by Darin Adler

• 4 edits in trunk

REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
​https://bugs.webkit.org/show_bug.cgi?id=115776

Reviewed by Anders Carlsson.

Source/WebCore:

I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0; if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.

LayoutTests:

• TestExpectations: Expect success again on this test.

11:52 AM Changeset in webkit [149753] by Lucas Forschler

• 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

Unreviewed. Fix duplicate builddir.

11:46 AM Changeset in webkit [149752] by Lucas Forschler

• 2 edits in trunk/Tools

Configure buildbot for 32bit builder.
​https://bugs.webkit.org/show_bug.cgi?id=115769

Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/config.json:

11:19 AM Changeset in webkit [149751] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
<rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices

Reviewed by Anders Carlsson.

• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more TextServices and NSInputManager directories.

10:35 AM Changeset in webkit [149750] by bfulgham@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Add my apple.com e-mail address to contributors.

10:16 AM Changeset in webkit [149749] by eric.carlson@apple.com

• 3 edits
  2 adds in trunk

Prevent crash when track is deleted during video element deletion.
​https://bugs.webkit.org/show_bug.cgi?id=106183

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-remove-crash.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we

do not process text track cues or dispatch related events.

LayoutTests:

• media/track/track-remove-crash-expected.txt: Added.
• media/track/track-remove-crash.html: Added.

10:03 AM Changeset in webkit [149748] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WebKit2

Remove BinarySemaphoreWin.cpp.

Rubber-stamped by Beth Dakin.

BinarySemaphoreWin has been moved to WTF, but the original was never removed.

• Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.

9:54 AM Changeset in webkit [149747] by andersca@apple.com

• 1 edit
  1 delete in trunk/Source/WTF

Remove ThreadingNone.cpp

Rubber-stamped by Beth Dakin.

ThreadingNone.cpp is empty and not used anywhere.

• wtf/ThreadingNone.cpp: Removed.

9:52 AM Changeset in webkit [149746] by ddkilzer@apple.com

• 1 edit
  1 delete in trunk/LayoutTests

Remove chromium test results added in r149743

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.

9:46 AM Changeset in webkit [149745] by ddkilzer@apple.com

• 2 edits in trunk/Tools

BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()

• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(concatenateAttributeAndValue): Switch to appendVector().

9:41 AM Changeset in webkit [149744] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] Unreviewed buildfix after r149741.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):

9:33 AM Changeset in webkit [149743] by ddkilzer@apple.com

• 1 edit
  11 adds in trunk/LayoutTests

Add layout tests for test cases in Bug 5206
<​http://webkit.org/b/5206>

Reviewed by Eric Seidel.

These issues were likely fixed in r89257 for Bug 62613.

• fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• fast/js/parse-error-external-script-in-eval.html: Added.
• fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.

• fast/js/parse-error-external-script-in-new-Function.html: Added.
• fast/js/resources/parse-error-external-script-in-eval.js: Added.
• fast/js/resources/parse-error-external-script-in-new-Function.js: Added.

• platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
• platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.

9:17 AM Changeset in webkit [149742] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Remove HashMap::deleteAllKeys
​https://bugs.webkit.org/show_bug.cgi?id=115806

Reviewed by Brent Fulgham.

This function was not used anywhere so let's get rid of it.

• wtf/HashMap.h:

9:06 AM Changeset in webkit [149741] by eric.carlson@apple.com

• 17 edits in trunk

[Mac] Inband text tracks are not in track menu on Lion
​https://bugs.webkit.org/show_bug.cgi?id=115740

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, covered by existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible

to false immediately, it will be reset to the appropriate value if necessary.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.

• html/HTMLMediaElement.h:

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove

HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Ditto.
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,

a legacy CC track is always Captions.

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP.

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks

only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->

AVFOUNDATION_MEDIA_SELECTION_GROUP

Source/WTF:

• wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP

LayoutTests:

• platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:

8:19 AM Changeset in webkit [149740] by sergio@webkit.org

• 3 edits
  2 adds in trunk

Allow blank spaces before colon (:) on CSS variable definition
​https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

• css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

• css3/css-variable-definition-expected.html: Added.
• css3/css-variable-definition.html: Added.

8:08 AM Changeset in webkit [149739] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

HashTraits<RefPtr<P> >::peek should consider empty value
​https://bugs.webkit.org/show_bug.cgi?id=115799

Reviewed by Darin Adler.

HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().

• wtf/HashTraits.h:

8:07 AM Changeset in webkit [149738] by mikhail.pozdnyakov@intel.com

• 2 edits in trunk/Source/WTF

Avoid unnecessary arguments copying inside GenericHashTraits methods
​https://bugs.webkit.org/show_bug.cgi?id=115733

Reviewed by Darin Adler.

Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.

The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.

The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.

• wtf/HashTraits.h:

(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):

7:36 AM Changeset in webkit [149737] by zarvai@inf.u-szeged.hu

• 1 edit
  16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
• platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
• platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.

7:28 AM WebKitGTK/2.0.x edited by kov@webkit.org

Adding a couple reasonably simple GStreamer backend fixes (diff)

6:44 AM Changeset in webkit [149736] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=115791

Unreviewed EFL gardening

Skip fast/regions/ test cases which are failing after r149668.

Patch by Rijubrata Bhaumik <​rijubrata.bhaumik@intel.com> on 2013-05-08

• platform/efl/TestExpectations:

6:41 AM Changeset in webkit [149735] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Does memory buffering even with preload set to none
​https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

6:07 AM Changeset in webkit [149734] by akling@apple.com

• 2 edits in trunk/Source/WebCore

SVGStyledElement::getPresentationAttribute() does not need to be virtual.

From Blink r149888 by <​cevans@chromium.org>
<​http://src.chromium.org/viewvc/blink?view=revision&revision=149888>

• svg/SVGStyledElement.h:

6:00 AM Changeset in webkit [149733] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

Crash when loading link to audio file
​https://bugs.webkit.org/show_bug.cgi?id=115794

Reviewed by Jocelyn Turcotte.

Do not access a null pointer frame.

• loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

5:56 AM Changeset in webkit [149732] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
​https://bugs.webkit.org/show_bug.cgi?id=115785

• platform/qt/TestExpectations:

5:20 AM Changeset in webkit [149731] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt][WTR] Fix the build on Mac after r149692

Unreviewed build fix.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

4:54 AM Changeset in webkit [149730] by g.czajkowski@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip two spelling tests as they started passing after r149366.

• platform/efl-wk2/TestExpectations:

Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html

• platform/efl/TestExpectations:

Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.

3:59 AM Changeset in webkit [149729] by Christophe Dumez

• 20 edits in trunk/Source/WebCore

Remove unused [TransferList] extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=115788

Reviewed by Kentaro Hara.

Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.

No new tests, no behavior change.

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

• bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
• bindings/scripts/test/CPP/WebDOMTestTypedefs.h:

(WebDOMTestTypedefs):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/TestTypedefs.idl:

3:38 AM Changeset in webkit [149728] by mario@webkit.org

• 3 edits in trunk/Tools

Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.

• Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
• Scripts/webkitpy/common/config/watchlist: Added myself.

3:37 AM WebKitIDL edited by Christophe Dumez

Remove [TransferList] (diff)

3:16 AM Changeset in webkit [149727] by sudarsana.nagineni@linux.intel.com

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip remaining Shadow DOM tests on the EFL port.

• platform/efl/TestExpectations:

2:50 AM Changeset in webkit [149726] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt] Build fails with clang
​https://bugs.webkit.org/show_bug.cgi?id=115741

Reviewed by Benjamin Poulain.

Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.

• qmake/mkspecs/features/unix/default_pre.prf:

2:41 AM Changeset in webkit [149725] by Darin Adler

• 3 edits in trunk/Tools

Fix one more place that needed to use adoptCF/NS
​https://bugs.webkit.org/show_bug.cgi?id=115778

Reviewed by Benjamin Poulain.

Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.

• WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.

• WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.

2:23 AM Changeset in webkit [149724] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests

that regressed when converted into reftests in r149668.

1:55 AM Changeset in webkit [149723] by commit-queue@webkit.org

• 7 edits in trunk

Make optional arguments in CanvasRenderingContext2D match the spec.
​https://bugs.webkit.org/show_bug.cgi?id=115723

Patch by Dongseong Hwang <​dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.

Source/WebCore:

WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.

[1] ​http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/

Covered by existing tests:

canvas/philip/tests/2d.missingargs.html
fast/canvas/canvas-overloads-strokeRect.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.

• fast/canvas/canvas-overloads-strokeRect-expected.txt:
• fast/canvas/script-tests/canvas-overloads-strokeRect.js:
• platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

1:54 AM WebKitIDL edited by Christophe Dumez

Rename JSCustomIsReachable to CustomIsReachable and … (diff)

1:50 AM WebKitIDL edited by Christophe Dumez

Remove JSCustomHeader (diff)

1:48 AM WebKitIDL edited by Christophe Dumez

Remove remaining mentions of V8 (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8DoNotCheckSignature (diff)

1:45 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIsReachable (diff)

1:43 AM WebKitIDL edited by Christophe Dumez

Remove [URL] (diff)

1:42 AM WebKitIDL edited by Christophe Dumez

Remove V8GenerateIsReachable and JSGenerateIsReachable (diff)

1:40 AM WebKitIDL edited by Christophe Dumez

Remove V8DependentLifeTime (diff)

1:39 AM WebKitIDL edited by Christophe Dumez

Remove V8CustomIndexedGetter (diff)

1:38 AM WebKitIDL edited by Christophe Dumez

Remove dead section from TOC (diff)

1:36 AM WebKitIDL edited by Christophe Dumez

Remove V8EnabledAtRuntime, V8EnabledPerContext from TOC (diff)

1:35 AM WebKitIDL edited by Christophe Dumez

Remove V8Unforgeable and V8OnProto (diff)

1:33 AM WebKitIDL edited by Christophe Dumez

Remove V8ReadOnly (diff)

1:29 AM WebKitIDL edited by Christophe Dumez

Remove mentions of JSCustom and V8Custom (diff)

1:28 AM Changeset in webkit [149722] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed, rolling out r149271.
​http://trac.webkit.org/changeset/149271
​https://bugs.webkit.org/show_bug.cgi?id=115780

The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-05-08

• BuildSlaveSupport/gtk/daemontools-buildbot.conf:

1:19 AM WebKitIDL edited by Christophe Dumez

Rename V8SkipVTableValidation to SkipVTableValidation (diff)

1:16 AM WebKitIDL edited by Christophe Dumez

Remove mentions of toV8() (diff)

1:14 AM Changeset in webkit [149721] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
​https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.

1:14 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

1:06 AM Changeset in webkit [149720] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115716

Reviewed by Andreas Kling.

WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.

• WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/NetworkInfo/WebNetworkInfoManager.h:

(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:

(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_networkInfoManager member variable and its getter method.

1:02 AM Changeset in webkit [149719] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Correct documentation for ewk_settings APIs
​https://bugs.webkit.org/show_bug.cgi?id=115507

Patch by Jose Lejin PJ <​jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.

Corrected documentation for ewk_settings APIs.

• ewk/ewk_settings.h:

1:01 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:58 AM Changeset in webkit [149718] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Remove unused method and de-virtualize others in Element.h
​https://bugs.webkit.org/show_bug.cgi?id=115770

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49

The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.

• WebCore.exp.in:
• dom/Element.h:

(WebCore::Element::hasAuthorShadowRoot):

12:52 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:51 AM Changeset in webkit [149717] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebBatteryManager a supplement to the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=115715

Reviewed by Andreas Kling.

WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.

• WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):

• WebProcess/Battery/WebBatteryManager.h:

(WebBatteryManager): Inherit from the WebProcessSupplement interface.

• WebProcess/WebCoreSupport/WebBatteryClient.cpp:

(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.

• WebProcess/WebProcess.h:

(WebProcess): Remove the m_batteryManager member variable and its getter method.

12:44 AM WebKitIDL edited by Christophe Dumez

Use more monospace (diff)

12:40 AM Changeset in webkit [149716] by Darin Adler

• 94 edits in trunk

Source/WebCore: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• platform/cf/win/CertificateCFWin.cpp:

(WebCore::copyCertificateToData):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):

• platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):

• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):

• platform/graphics/gstreamer/PlatformVideoWindowMac.mm:

(PlatformVideoWindow::PlatformVideoWindow):

• platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

• platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):

• platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawWindowsBitmap):

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):

• platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):

• platform/graphics/win/WKCAImageQueue.cpp:

(WebCore::WKCAImageQueue::WKCAImageQueue):

• platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile):

• platform/network/cf/AuthenticationCF.cpp:

(WebCore::core):

• platform/network/cf/CookieJarCFNet.cpp:

(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath):

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::urlFromPath):
(WebCore::getURL):

• platform/win/LocalizedStringsWin.cpp:

(WebCore::createWebKitBundle):
(WebCore::localizedString):

• platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):

• plugins/mac/PluginPackageMac.cpp:

(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

• plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

• rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.

Source/WebKit/win: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::Write):

• WebCache.cpp:

(WebCache::statistics):

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):

• WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

• WebDownloadCFNet.cpp:

(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):

• WebError.cpp:

(WebError::sslPeerCertificate):

• WebHistory.cpp:

(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):

• WebIconDatabase.cpp:

(postDidAddIconNotification):

• WebLocalizableStrings.cpp:

(cfBundleForStringsBundle):

• WebMutableURLRequest.cpp:

(WebMutableURLRequest::mutableCopy):

• WebPreferences.cpp:

(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):

• WebView.cpp:

(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.

Source/WebKit2: Use adoptCF and adoptNS in more places
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

• Shared/Downloads/cfnet/DownloadCFNet.cpp:

(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.

Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
​https://bugs.webkit.org/show_bug.cgi?id=115657

Reviewed by Sam Weinig.

This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):

• DumpRenderTree/cg/ImageDiffCG.cpp:

(createImageFromStdin):
(createDifferenceImage):
(main):

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(printPNG):
(dumpBitmap):

• DumpRenderTree/cg/PixelDumpSupportCG.h:

(BitmapContext::BitmapContext):

• DumpRenderTree/mac/MockWebNotificationProvider.mm:

(-[MockWebNotificationProvider init]):

• DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createBitmapContext):

• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):

• DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:

(createCFURLResponseFromResponseData):

• DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):

• DumpRenderTree/win/DumpRenderTree.cpp:

(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):

• DumpRenderTree/win/ImageDiffCairo.cpp:

(createImageFromStdin):
(main):

• DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):

• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

• TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:

(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

• TestWebKitAPI/Tests/mac/AttributedString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/BackForwardList.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:

(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):

• TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:

(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):

• TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

• TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SetDocumentURI.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

• TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):

• WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:

(WTR::testPathFromURL):

• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

• WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollBy):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage):

• WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.

12:36 AM WebKitIDL edited by Christophe Dumez

Start using monospace for IDL extended attributes (diff)

12:24 AM WebKitIDL edited by Christophe Dumez

Remove deprecated "in" keyword from IDL examples (diff)

12:05 AM Changeset in webkit [149715] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.

• TestExpectations:

12:04 AM WebKitIDL edited by Christophe Dumez

Update documentation for optional and [Default] (diff)

12:03 AM Changeset in webkit [149714] by zandobersek@gmail.com

• 2 edits in trunk

[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
​https://bugs.webkit.org/show_bug.cgi?id=115732

Reviewed by Gustavo Noronha Silva.

• GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending

the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.

12:00 AM Changeset in webkit [149713] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/mac

<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency

Reviewed by Sam Weinig.

• Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.

May 7, 2013:

11:24 PM Changeset in webkit [149712] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
​https://bugs.webkit.org/show_bug.cgi?id=115771

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Gyuyoung Kim.

Unit test is failing since r149702. Remove the test case related to shadow dom.

• tests/test_ewk_setting.cpp:

10:08 PM Changeset in webkit [149711] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

Clean up load interface in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=115622
Patch by Xuefei Ren <​xren@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internal PR:315535
Internal reviewed by Mary Wu

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):

• Api/WebPage.h:
• Api/WebPage_p.h:

(WebPagePrivate):

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:18 PM Changeset in webkit [149710] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
​https://bugs.webkit.org/show_bug.cgi?id=115764

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

CMYKA input is uncommon enough that we should not pay the price for
every CanvasStyle.
Make those values heap allocated and put the pointer in the union. Since
the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::isEquivalentCMYKA):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

• html/canvas/CanvasStyle.h:

(CanvasStyle):
(CMYKAValues):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
(WebCore::CanvasStyle::color):
(WebCore):

7:41 PM Changeset in webkit [149709] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues for requests in PluginView
​https://bugs.webkit.org/show_bug.cgi?id=115731

Reviewed by Sam Weinig.

• plugins/PluginView.cpp:

(WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
(WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
from m_requests rather than an explicit delete. Also use !isEmpty instead
of size > 0.
(WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
(WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.

• plugins/PluginView.h: Changed argument type of scheduleRequest to

PassOwnPtr, and m_requests to a Vector<OwnPtr>.

7:03 PM Changeset in webkit [149708] by Antti Koivisto

• 18 edits
  2 deletes in trunk/Source

Remove SelectRuleFeatureSet
​https://bugs.webkit.org/show_bug.cgi?id=115757

Reviewed by Benjamin Poulain.

This is dead code.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.exp.in:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore):
(WebCore::Element::didAffectSelector):

• dom/Element.h:

(Element):

• dom/ElementShadow.h:

(WebCore::ElementShadow::invalidateDistribution):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ContentDistributor):
(WebCore):

• html/shadow/ContentDistributor.h:

(ContentDistributor):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):

• html/shadow/InsertionPoint.h:

(InsertionPoint):

• html/shadow/SelectRuleFeatureSet.cpp: Removed.
• html/shadow/SelectRuleFeatureSet.h: Removed.
• testing/Internals.cpp:

(WebCore):

• testing/Internals.idl:

6:47 PM Changeset in webkit [149707] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Store the quotes in the same allocation as the QuotesData object
​https://bugs.webkit.org/show_bug.cgi?id=115768

Reviewed by Andreas Kling.

Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
they can just be stored after the class data.

• rendering/style/QuotesData.cpp:

(WebCore::sizeForQuotesDataWithQuoteCount):
Helper function for computing the allocation size.

(WebCore::QuotesData::create):
Use fastMalloc + placement new.

(WebCore::QuotesData::QuotesData):
Use placement new to allocate the quote pairs.

(WebCore::QuotesData::~QuotesData):
Destroy the quote pairs.

(WebCore::QuotesData::openQuote):
Stop using Vector.

(WebCore::QuotesData::closeQuote):
Ditto.

(WebCore::operator==):
Ditto.

• rendering/style/QuotesData.h:

6:42 PM Changeset in webkit [149706] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

We should not ref() the RefPtr twice in CanvasStyle

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Darin Adler.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.

6:41 PM Changeset in webkit [149705] by rniwa@webkit.org

• 14 edits in trunk/Source/WebCore

Devirtualize Document class type checking
​https://bugs.webkit.org/show_bug.cgi?id=115755

Reviewed by Benjamin Poulain.

Merge ​https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950

Document has a bunch of virtual bool is*Document() methods on it, but it also has
two bools for XHTML and HTML documents which is silly. We can merge them all
together into an enum of values and devirtualize the type checking methods.

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createElement):

• dom/Document.h:

(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::isHTMLDocument):
(WebCore::Document::isXHTMLDocument):
(WebCore::Document::isImageDocument):
(WebCore::Document::isSVGDocument):
(WebCore::Document::isPluginDocument):
(WebCore::Document::isMediaDocument):
(WebCore::Document):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::HTMLDocument):

• html/HTMLDocument.h:

(WebCore::HTMLDocument):

• html/ImageDocument.cpp:

(WebCore::ImageDocument::ImageDocument):

• html/ImageDocument.h:

(WebCore::ImageDocument):

• html/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):

• html/MediaDocument.h:

(WebCore::MediaDocument):

• html/PluginDocument.cpp:

(WebCore::PluginDocument::PluginDocument):

• html/PluginDocument.h:

(WebCore::PluginDocument):

• loader/PlaceholderDocument.h:

(WebCore::PlaceholderDocument::PlaceholderDocument):

• svg/SVGDocument.cpp:

(WebCore::SVGDocument::SVGDocument):

• svg/SVGDocument.h:

(WebCore::SVGDocument):

6:35 PM Changeset in webkit [149704] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix a memory leak introduced in r149692
​https://bugs.webkit.org/show_bug.cgi?id=115766

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Mark Rowe.

In r149692, the fix for <​http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.

6:26 PM Changeset in webkit [149703] by Darin Adler

• 2 edits in trunk/Tools

[Win] Fix storage leak in Windows DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=115651

Reviewed by Sam Weinig.

• DumpRenderTree/win/DumpRenderTree.cpp:

(lastPathComponent): Added a missing call to adoptCF.

6:13 PM Changeset in webkit [149702] by gyuyoung.kim@samsung.com

• 3 edits in trunk

[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
​https://bugs.webkit.org/show_bug.cgi?id=115712

Reviewed by Andreas Kling.

Nobody uses SHADOW_DOM in cmake.

• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

5:11 PM Changeset in webkit [149701] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

Add SPI to get an array of all the installed plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=115688

Reviewed by Anders Carlsson.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(createInfoDictionary):
Extract creation of info dictionary into helper.
(WKContextCopyPlugInInfoForBundleIdentifier):
Modified to use the new helper.
(WKContextGetInfoForInstalledPlugIns):
Added.

4:07 PM Changeset in webkit [149700] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Begin unraveling the mess that is QuotesData
​https://bugs.webkit.org/show_bug.cgi?id=115765

Reviewed by Andreas Kling.

Change QuotesData to be an immutable object and fix other things that are broken.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):
Update for renames.

• rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):
Remove the create overload that wasn't used. Add a new create overload that takes a Vector.

(WebCore::QuotesData::openQuote):
Rename this from getOpenQuote and clean it up.

(WebCore::QuotesData::closeQuote):
Rename this from getCloseQuote and clean it up.

(WebCore::operator==):
Replace the equals member function with a proper equality operator.

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
Stop calling QuotesData::equals. Use the same idiom as used for other properties.

(WebCore::RenderStyle::setQuotes):

• rendering/style/StyleRareInheritedData.cpp:

Use operator==.

(WebCore::quotesDataEquivalent):
Add helper function.

(WebCore::StyleRareInheritedData::operator==):
Call quotesDataEquivalent.

3:54 PM Changeset in webkit [149699] by hmuller@adobe.com

• 3 edits
  1 add
  1 delete in trunk/LayoutTests

[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115649

Reviewed by Dirk Schulze.

Another correction of a padded shape test that failed when subpixel layout was disabled.
This test puts a cross pattern made of five Ahem characters on three lines, within a padded
diamond polygon. The left edges of each line depend on the intersection of the padded polygon's
edges with the top of each line, which makes predicting the exact values unreliable. So we
just verify that the left edges of each line are within a pixel of the ideal value. This
change is very similar to the one made for bug 115490.

• fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Removed.
• fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
• fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html:
• platform/mac/TestExpectations:

3:41 PM Changeset in webkit [149698] by enrica@apple.com

• 3 edits
  3 adds in trunk

Support -webkit-system-font on OS X.
​https://bugs.webkit.org/show_bug.cgi?id=115758
<rdar://problem/13433854>

3:26 PM Changeset in webkit [149697] by commit-queue@webkit.org

• 2 edits in trunk/Tools

fixed a memory leak introduced by bug 42324 by using a RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=115760

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros

3:14 PM Changeset in webkit [149696] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Move CanvasGradient and CanvasPattern in the union of CanvasStyle
​https://bugs.webkit.org/show_bug.cgi?id=115759

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.

The Gradient and Pattern are exclusive with the other values, but they
were left out of the union because they are ref-counted.

This patch moves them in the union, and simply does the ref-counting manually.

• html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):

• html/canvas/CanvasStyle.h:

(CanvasStyle):
(WebCore::CanvasStyle::canvasGradient):
(WebCore::CanvasStyle::canvasPattern):

3:06 PM Changeset in webkit [149695] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Remove custom allocator support from PODArena
​https://bugs.webkit.org/show_bug.cgi?id=115762

Reviewed by Andreas Kling.

Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.

• platform/PODArena.h:

(WebCore::PODArena::PODArena):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(Chunk):

• platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::allocate):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):

3:04 PM Changeset in webkit [149694] by andersca@apple.com

• 12 edits in trunk/Source

Clean up KeyframeValueList and related classes
​https://bugs.webkit.org/show_bug.cgi?id=115738

Reviewed by Simon Fraser.

Source/WebCore:

Add static create() functions to the AnimationValue subclasses, and change a bunch of parameters
and return values that can never be null from pointer types to reference types to better indicate this.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
(WebCore::operationsAt):
(WebCore::GraphicsLayer::validateTransformOperations):

• platform/graphics/GraphicsLayer.h:

(AnimationValue):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(FloatAnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(TransformAnimationValue):
(WebCore::TransformAnimationValue::value):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::value):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(FilterAnimationValue):
(WebCore::KeyframeValueList::~KeyframeValueList):
(KeyframeValueList):
(WebCore::KeyframeValueList::at):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):

• platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

Source/WebKit2:

Update for WebCore changes.

• Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):

2:52 PM Changeset in webkit [149693] by andersca@apple.com

• 7 edits in trunk/Source

Add and remove databases and origins from the database tracker
​https://bugs.webkit.org/show_bug.cgi?id=115752

Reviewed by Andreas Kling.

Source/WebCore:

Add symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Rename m_databaseFilename to m_databasePath.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Rename m_databaseFilename to m_databasePath.

• UIProcess/Storage/LocalStorageDatabase.h:

Rename m_databaseFilename to m_databasePath.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databasePath):
Rename databaseFilename to databasePath.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
Call addDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Call removeDatabaseWithOriginIdentifier.

(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
Call databasePath instead of databaseFile.

(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Bail if the database is already open.

(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Call addDatabaseWithOriginIdentifier if this is an origin we don't know about.

(WebKit::LocalStorageDatabaseTracker::addDatabaseWithOriginIdentifier):
Add the database to the Origins table.

(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
remove the database from the Origins table and delete it.

(WebKit::LocalStorageDatabaseTracker::pathForDatabaseWithOriginIdentifier):
Helper function that looks up a database path given its identifier.

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

Rename databaseFile to databasePath.

2:26 PM Changeset in webkit [149692] by commit-queue@webkit.org

• 6 edits
  4 adds in trunk/Tools

WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
​https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Added dumpDOMAsWebArchive JavaScript function to be called by test cases.

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.

• Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.

• Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.

• Tools/WebKitTestRunner/cf: Added.
• Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.

Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):

• Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.

Copied from Tools/DumpRenderTree/cf for used symbol declarations.

• Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.

Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):

2:12 PM Changeset in webkit [149691] by Beth Dakin

• 3 edits in trunk/Source/WebCore

Still possible to fire paint-related LayoutMilestones before CA has committed the
changes
​https://bugs.webkit.org/show_bug.cgi?id=115753
-and corresponding-
<rdar://problem/13822315>

Reviewed by Simon Fraser.

To ensure we wait for the CA commit, we should wait until the end of the runloop
with a zero-delay timer.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
(WebCore):

• rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

2:09 PM Changeset in webkit [149690] by Chris Fleizach

• 2 edits in trunk/Source/WebCore

Bug 115694 - Fix bad cast to RenderHTMLCanvas
​https://bugs.webkit.org/show_bug.cgi?id=115694

Reviewed by Ryosuke Niwa.

Don't cast to RenderHTML until we check what kind of object it is.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

1:30 PM Changeset in webkit [149689] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase the padding size for caret based scrolling.
​https://bugs.webkit.org/show_bug.cgi?id=115749

Reviewed by Rob Buis.

PR 322670.

Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1:07 PM Performance Tests edited by rwlbuis@webkit.org

(diff)

12:42 PM Changeset in webkit [149688] by andersca@apple.com

• 7 edits in trunk/Source

The storage database tracker should know when databases come and go
​https://bugs.webkit.org/show_bug.cgi?id=115748

Reviewed by Andreas Kling.

Source/WebCore:

Export symbol needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::openDatabase):
If we've opened the database successfully, call LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Remove a FIXME; we run all storage related things on the same thread.

(WebKit::LocalStorageDatabase::close):
Close the database. If it's empty, call LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin.

(WebKit::LocalStorageDatabase::databaseIsEmpty):
Helper function for determining whether a database is empty.

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Add ".localstorage" to the filename.

(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Add empty stubs.

12:11 PM Changeset in webkit [149687] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Add JoinExistingSession to the Networking XPC.
<rdar://problem/12902288> and ​https://bugs.webkit.org/show_bug.cgi?id=114991

Reviewed by Sam Weinig.

• NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
• NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:

12:08 PM Changeset in webkit [149686] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
​https://bugs.webkit.org/show_bug.cgi?id=115745

Patch by Alex Christensen <​achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.

• DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(compareResourceURLs):
Updated style.

11:52 AM Changeset in webkit [149685] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Maintain touch event state throughout processing
​https://bugs.webkit.org/show_bug.cgi?id=115663

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Otto Cheung and Genevieve Mak.

PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):

• Api/WebPage_p.h:

(WebPagePrivate):

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:42 AM Changeset in webkit [149684] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SVGResourcesCache
​https://bugs.webkit.org/show_bug.cgi?id=115729

Reviewed by Benjamin Poulain.

• rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::~SVGResourcesCache): Removed call to deleteAllValues.
(WebCore::SVGResourcesCache::addResourcesFromRenderObject): Use adoptPtr and release
to create new SVGResources object.
(WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Use take to remove
the SVGResources from the map rather than a get combined with delete/take.
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Removed unneeded
call to contains, since get already returns 0 if there is no item in the map.
(WebCore::SVGResourcesCache::resourceDestroyed): Use typedef for the map type so
we don't have to repeat the type.

• rendering/svg/SVGResourcesCache.h: Added typedef CacheMap, and changed value

type to OwnPtr.

11:30 AM Changeset in webkit [149683] by andersca@apple.com

• 4 edits in trunk/Source

REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
​https://bugs.webkit.org/show_bug.cgi?id=115711

Reviewed by Andreas Kling.

Source/WebCore:

Export SQLiteDatabase::close.

• WebCore.exp.in:

Source/WebKit2:

Handle setting the local storage directory more than once.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Close the database (if necessary) and clear the origins map before importing the origin identifiers.

11:12 AM Changeset in webkit [149682] by Antoine Quint

• 4 edits in trunk/Source/WebKit2

Re-establish autostart timeout extension on user interaction
​https://bugs.webkit.org/show_bug.cgi?id=113232

Change WebProcess::pluginDidReceiveUserInteraction to use a tuple of
(pluginOrigin, pageOrigin, mimeType) arguments like the other similar
WebProcess methods and gather these arguments from the PlugInView's
plug-in element.

Reviewed by Dean Jackson.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginDidReceiveUserInteraction):
Cast the m_pluginElement to a HTMLPlugInImageElement so we can obtain the
tuple of (pluginOrigin, pageOrigin, mimeType) to pass to pluginDidReceiveUserInteraction().

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::plugInDidReceiveUserInteraction):

• WebProcess/WebProcess.h:

(WebProcess):
Update method signature to a tuple of (pluginOrigin, pageOrigin, mimeType)
and obtain the plug-in origin hash from that.

10:58 AM Changeset in webkit [149681] by ap@apple.com

• 26 edits
  1 delete in trunk/LayoutTests

Combine html and js parts fast/url script-tests
​https://bugs.webkit.org/show_bug.cgi?id=115739

Rubber-stamped by Brady Eidson.

• fast/url/anchor.html:
• fast/url/file-http-base.html:
• fast/url/file.html:
• fast/url/host-lowercase-per-scheme.html:
• fast/url/host.html:
• fast/url/idna2003.html:
• fast/url/idna2008.html:
• fast/url/invalid-urls-utf8.html:
• fast/url/ipv4.html:
• fast/url/ipv6.html:
• fast/url/mailto.html:
• fast/url/path-url.html:
• fast/url/path.html:
• fast/url/port.html:
• fast/url/query.html:
• fast/url/relative-unix.html:
• fast/url/relative-win.html:
• fast/url/relative.html:
• fast/url/safari-extension.html:
• fast/url/scheme.html:
• fast/url/script-tests: Removed.
• fast/url/script-tests/TEMPLATE.html: Removed.
• fast/url/script-tests/anchor.js: Removed.
• fast/url/script-tests/file-http-base.js: Removed.
• fast/url/script-tests/file.js: Removed.
• fast/url/script-tests/host.js: Removed.
• fast/url/script-tests/idna2003.js: Removed.
• fast/url/script-tests/idna2008.js: Removed.
• fast/url/script-tests/ipv4.js: Removed.
• fast/url/script-tests/ipv6.js: Removed.
• fast/url/script-tests/mailto.js: Removed.
• fast/url/script-tests/path-url.js: Removed.
• fast/url/script-tests/path.js: Removed.
• fast/url/script-tests/port.js: Removed.
• fast/url/script-tests/query.js: Removed.
• fast/url/script-tests/relative-unix.js: Removed.
• fast/url/script-tests/relative-win.js: Removed.
• fast/url/script-tests/relative.js: Removed.
• fast/url/script-tests/scheme.js: Removed.
• fast/url/script-tests/segments-from-data-url.js: Removed.
• fast/url/script-tests/segments.js: Removed.
• fast/url/script-tests/standard-url.js: Removed.
• fast/url/script-tests/trivial-segments.js: Removed.
• fast/url/script-tests/trivial.js: Removed.
• fast/url/segments-from-data-url.html:
• fast/url/segments.html:
• fast/url/standard-url.html:
• fast/url/trivial-segments.html:
• fast/url/trivial.html:

10:45 AM Changeset in webkit [149680] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Each local storage database should know its origin
​https://bugs.webkit.org/show_bug.cgi?id=115737

Reviewed by Andreas Kling.

Store the security origin in a member variable. It'll be used to communicate database state changes to the tracker.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:

(LocalStorageDatabase):

10:42 AM Changeset in webkit [149679] by rniwa@webkit.org

• 8 edits in trunk

Add an 'isReadOnly' member to IDL parse tree structure
​https://bugs.webkit.org/show_bug.cgi?id=115704

Reviewed by Kentaro Hara.

Source/WebCore:

Add an 'isReadOnly' member to IDL parse tree structure by merging
​https://chromium.googlesource.com/chromium/blink/+/d6add80ecd08bcd88a6ae0e1698d929830b3bd8b
and update Objective-C, C++, and GObject binding generators to use isReadOnly.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorGObject.pm:

(GetWriteableProperties):
(GenerateProperty):
(GenerateFunctions):

• bindings/scripts/CodeGeneratorJS.pm:

(IsReadonly):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/IDLParser.pm:

(parseAttributeRest):
(parseExceptionField):
(parseAttributeRestOld):

Tools:

Use newly added isReadOnly attribute.

• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):

10:10 AM Changeset in webkit [149678] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Remove some unnecessary soft linking in NetworkProcess. (Take 2)
<rdar://problem/13821779> and ​https://bugs.webkit.org/show_bug.cgi?id=115683

Reviewed by Dean Jackson and owned by Andreas Kling.

As a followup to r149651, include the private headers conditionally.
Also, fix a bug introduced with r149651 (bool vs CFBooleanRef).

• NetworkProcess/mac/DiskCacheMonitor.mm:
• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

9:54 AM Changeset in webkit [149677] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SMILTimeContainer
​https://bugs.webkit.org/show_bug.cgi?id=115730

Reviewed by Geoffrey Garen.

• svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::~SMILTimeContainer): Removed call to deleteAllValues.
(WebCore::SMILTimeContainer::schedule): Use add instead of get/set to put a new
AnimationsVector into the map as needed.
(WebCore::SMILTimeContainer::setElapsed): Added get since values are OwnPtr now.
(WebCore::SMILTimeContainer::updateAnimations): Ditto.

• svg/animation/SMILTimeContainer.h: Changed value type of GroupedAnimationsMap

to OwnPtr instead of raw pointer.

9:53 AM Changeset in webkit [149676] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Take advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
​https://bugs.webkit.org/show_bug.cgi?id=115722

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-07
Reviewed by Oliver Hunt.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8PostInc):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load16PostInc):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::movwMemRegIn):
(SH4Assembler):
(JSC::SH4Assembler::movbMemRegIn):
(JSC::SH4Assembler::printInstr):

9:24 AM Changeset in webkit [149675] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Read-only fields should not get keyboard focus
​https://bugs.webkit.org/show_bug.cgi?id=115725

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.

• WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):

• WebKitSupport/DOMSupport.h:
• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):

• WebKitSupport/InputHandler.h:

9:18 AM Changeset in webkit [149674] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Expand spellcheck logging
​https://bugs.webkit.org/show_bug.cgi?id=115482

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

9:01 AM Changeset in webkit [149673] by andersca@apple.com

• 30 edits
  1 delete in trunk

Remove AlwaysInline.h from WTF
​https://bugs.webkit.org/show_bug.cgi?id=115727

Reviewed by Brent Fulgham.

The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
to keep AlwaysInline.h around anymore.

Source/JavaScriptCore:

• jit/JSInterfaceJIT.h:
• parser/Lexer.h:
• runtime/JSCJSValue.h:
• runtime/SymbolTable.h:

Source/WebCore:

• WebCore.vcproj/WebCore.vcproj:
• bindings/js/JSDOMWindowCustom.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• platform/graphics/filters/FEConvolveMatrix.h:
• rendering/InlineIterator.h:
• rendering/InlineTextBox.cpp:
• rendering/RenderBlockLineLayout.cpp:
• rendering/RenderText.cpp:

Source/WTF:

• WTF.vcproj/WTF.vcproj:
• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/AlwaysInline.h: Removed.
• wtf/BloomFilter.h:
• wtf/FastMalloc.cpp:
• wtf/PassRefPtr.h:
• wtf/dtoa.cpp:
• wtf/gobject/GRefPtr.h:

Tools:

• DumpRenderTree/qt/DumpRenderTreeMain.cpp:
• WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

8:53 AM Changeset in webkit [149672] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Curl] POST requests sometimes fail.
​https://bugs.webkit.org/show_bug.cgi?id=111844

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-07
Reviewed by Brent Fulgham.

Curl adds the header 'Expect: 100-Continue' when sending a POST request.
When we receive the header 'HTTP/1.1 100 Continue', we should not call
ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
because the MIME type is empty in this case, causing the POST request to fail.
This header is only sent as an info header, or provisional response.

In addition, this patch changes the classification of http code 304 (Not modified).
It is not reported as a redirect anymore, but as a response
(ResourceHandleClient::didReceiveResponse() is called.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::isHttpInfo): Added helper method to determine if http code is http info.
(WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
(WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.

8:33 AM Changeset in webkit [149671] by allan.jensen@digia.com

• 3 edits in trunk/Source/WebKit/qt

Crash when calling QWebFrame::evaluateJavaScript
​https://bugs.webkit.org/show_bug.cgi?id=113434

Reviewed by Simon Hausmann.

Ensure we hold the JSLock when converting JSValue to JSValueRef.

• Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):

• WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::evaluateJavaScript):

8:13 AM Changeset in webkit [149670] by ryuan.choi@samsung.com

• 6 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk APIs for setting and getting user agent
​https://bugs.webkit.org/show_bug.cgi?id=114429

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Andreas Kling.

Provide ewk_view_user_agent_get/set APIs which wraps WK APIs.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::setUserAgent):

• UIProcess/API/efl/EwkView.h:

(EwkView::userAgent):
(EwkView):

• UIProcess/API/efl/ewk_view.cpp:

(ewk_view_user_agent_get):
(ewk_view_user_agent_set):

• UIProcess/API/efl/ewk_view.h:
• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

8:07 AM Changeset in webkit [149669] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[X11][BlackBerry] Check if MOZ_X11 is defined instead of XP_UNIX npruntime_internal.h
​https://bugs.webkit.org/show_bug.cgi?id=113687

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-05-07
Reviewed by Anders Carlsson.

It's assumed that all UNIX platforms use X11 for plugins, which is
not the case of BlackBerry.

• bridge/npruntime_internal.h: Use MOZ_X11 instead of XP_UNIX.

7:41 AM Changeset in webkit [149668] by commit-queue@webkit.org

• 3 edits
  4 adds
  32 deletes in trunk/LayoutTests

[CSS Regions] Convert remaining fast/regions/webkit-flow* pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=115422

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-07
Reviewed by Andreas Kling.

Converted following tests from pixel tests to ref tests:

• webkit-flow-double-pagination-float-push
• webkit-flow-float-pushed-to-last-region
• webkit-flow-float-unable-to-push
• webkit-flow-floats-inside-regions-bounds

• fast/regions/webkit-flow-double-pagination-float-push-expected.html: Added.
• fast/regions/webkit-flow-float-pushed-to-last-region-expected.html: Added.
• fast/regions/webkit-flow-float-pushed-to-last-region.html:
• fast/regions/webkit-flow-float-unable-to-push-expected.html: Added.
• fast/regions/webkit-flow-float-unable-to-push.html:
• fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html: Added.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
• platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
• platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.

4:01 AM Changeset in webkit [149667] by abecsi@webkit.org

• 2 edits in trunk/Tools

[Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=114808

Reviewed by Jocelyn Turcotte.

QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
(​https://codereview.qt-project.org/#change,54234)

• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

12:42 AM Changeset in webkit [149666] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/gtk

[GTK] Initialize WebKitWebPlugin path to prevent double-free
​https://bugs.webkit.org/show_bug.cgi?id=115624

Patch by Tomas Popela <​tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.

Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.

• webkit/webkitwebplugin.cpp:

(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):

• webkit/webkitwebpluginprivate.h:

12:23 AM Changeset in webkit [149665] by mikhail.pozdnyakov@intel.com

• 41 edits in trunk/Source

HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance
​https://bugs.webkit.org/show_bug.cgi?id=115646

Reviewed by Darin Adler.

Source/JavaScriptCore:

• bytecompiler/StaticPropertyAnalyzer.h:

(JSC::StaticPropertyAnalyzer::putById):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebCore:

No new tests, no new functionality.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::remove):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::objectFromAXID):

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::getImage):

• css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elementForAlias):

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::findInsertionPointFor):

• loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForURL):

• loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::archiveResourceForURL):

• page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateMaskLayer):

• platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::getBlobDataFromURL):

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):

• rendering/RenderCounter.cpp:

(WebCore::makeCounterNode):
(showCounterRendererTree):

• svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::getEffectById):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebKit/mac:

• Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::pluginInstance):

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WebKit2:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):

• NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::hostForURL):

• Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
(WebKit::StorageManager::findStorageArea):

• UIProcess/WebContext.h:

(WebKit::WebContext::supplement):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::webBackForwardItem):
(WebKit::WebProcessProxy::webFrame):

• UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::ewkDownloadJob):

• WebProcess/Network/WebResourceLoadScheduler.h:

(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamFromID):

• WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelStreamLoad):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

• WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::itemForID):
(WebKit::WebBackForwardListProxy::itemAtIndex):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::webUndoStep):
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPage):
(WebKit::WebProcess::webPageGroup):

Updated accordingly to new HashMap<.., RefPtr>::get() semantics.

Source/WTF:

HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we
can obviate multiple RefPtr copying when invoking HashMap<.., RefPtr>::get()
method.

• wtf/HashTraits.h:

May 6, 2013:

11:31 PM Changeset in webkit [149664] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149637.

• Target.pri:

11:13 PM Changeset in webkit [149663] by Christophe Dumez

• 2 edits in trunk/Tools

Unreviewed. Add my email to EFL and BindingsScripts watchlists.

• Scripts/webkitpy/common/config/watchlist:

10:20 PM Changeset in webkit [149662] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
​https://bugs.webkit.org/show_bug.cgi?id=115711

Rubber-stamped by Anders Carlsson.

Temporarily removed the assertion. Andres is going to investigate it tomorrow.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):

9:31 PM Changeset in webkit [149661] by Darin Adler

• 6 edits in trunk/Source

Use OwnPtr instead of deleteAllValues in KeyframeValueList
​https://bugs.webkit.org/show_bug.cgi?id=115652

Reviewed by Simon Fraser.

Source/WebCore:

Also made a few related style fixes in the functions touched.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::KeyframeValueList::insert): Change argument type to PassOwnPtr
and update use of m_values since it has OwnPtr now instead of raw pointer.

• platform/graphics/GraphicsLayer.h: Move conditional includes to a

separate paragraph, removed an unneeded forward class declaration.
(WebCore::AnimationValue::AnimationValue): Marked this constructor explicit
and removed an unneeded if statement.
(WebCore::AnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::FloatAnimationValue::clone): Changed this to return a PassOwnPtr.
(WebCore::TransformAnimationValue::TransformAnimationValue): Marked explicit.
(WebCore::TransformAnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::FilterAnimationValue::FilterAnimationValue): Marked explicit.
(WebCore::FilterAnimationValue::clone): Changed to use adoptPtr and PassOwnPtr.
(WebCore::KeyframeValueList::KeyframeValueList): Marked explicit.
(WebCore::KeyframeValueList::~KeyframeValueList): Removed, since the default
destructor works without an explicit deleteAllValues call.
(WebCore::KeyframeValueList::at): Added call to get needed since the vector
contains OwnPtr now.
(WebCore::KeyframeValueList::insert): Changed to take PassOwnPtr and then
removed now-redundant comment saying "takes ownership of the pointer".
(WebCore::KeyframeValueList::m_values): Changed type to Vector<OwnPtr>.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation): Added adoptPtr next to the
all the places new was done before calling KeyframeValueList::insert. Also
simplified the booleans and #if in this function.
(WebCore::RenderLayerBacking::startTransition): Ditto.

Source/WebKit2:

• Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::ArgumentCoder<GraphicsLayerAnimation>::decode): Added adoptPtr
next to new when calling KeyframeValueList::insert.

9:15 PM Changeset in webkit [149660] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

[Replaceable] attributes must be readonly
​https://bugs.webkit.org/show_bug.cgi?id=115692

Reviewed by Kentaro Hara.

Merge ​https://chromium.googlesource.com/chromium/blink/+/ac61fbfe875d3c3c37d529683139ceb0ad4330bb.

Web IDL specification says [Replaceable] attributes are readonly:
​http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Replaceable

Update the two instances of [Replaceable] in WebCore that didn't have readonly modifier to match
the specifcation and the rest of WebCore. There should be no behavioral changes as the code generator
already assumed [Replaceable] attributes are readonly.

• html/HTMLDocument.idl:
• page/DOMWindow.idl:

9:05 PM Changeset in webkit [149659] by kangil.han@samsung.com

• 4 edits in trunk/Tools

[EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=115645

Reviewed by Gyuyoung Kim.

To run performance tests in wk1, we need --no-timeout option implementation.
So adopt it from gtk+ port.

• DumpRenderTree/efl/DumpRenderTree.cpp:

(shouldSetWaitToDumpWatchdog):
(parseCommandLineOptions):

• DumpRenderTree/efl/DumpRenderTreeEfl.h:
• DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setWaitToDump):

8:13 PM Changeset in webkit [149658] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Source/WebKit2

Unreviewed, build fix on EFL port

• CMakeLists.txt: Add LocalStorageDatabaseTracker.cpp

7:18 PM Changeset in webkit [149657] by Philippe Normand

• 2 edits in trunk/Source/WebKit2

Unreviewed, GTK build fix after r149637.

• GNUmakefile.list.am: Add LocalStorageDatabaseTracker sources to

the build.

6:36 PM Changeset in webkit [149656] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit/win

Unreviewed. AppleWin build fix.

• WebKit.vcproj/WebKitExports.def.in:

5:46 PM Changeset in webkit [149655] by mark.lam@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix broken 32-bit build + some clean up in JITStubs.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=115684.

Reviewed by Geoffrey Garen.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/JITStubs.cpp:
• removed unneeded stubs for CPU(X86_64) && USE(JSVALUE32_64).
• added some line breaks to more clearly delineate between ports/configurations of stub code.

5:45 PM Changeset in webkit [149654] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in DocumentMarkerController
​https://bugs.webkit.org/show_bug.cgi?id=115655

Reviewed by Andreas Kling.

• dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::~DocumentMarkerController): Added here
so the destructor isn't implicitly inline.
(WebCore::DocumentMarkerController::detach): Removed now-unneeded code to
call deleteAllValues. Also moved code to set m_possiblyExistingMarkerTypes
to after clearing m_markers to be consistent with how other functions do it.
(WebCore::DocumentMarkerController::addMarker): Changed code to use the
add idiom to avoid double hash table lookup. Changed to use adoptPtr since
the map now contains OwnPtr.
(WebCore::DocumentMarkerController::removeMarkers): Removed explicit calls
to delete list since removing the entry from the map now deletes the list.
Moved the code to check if m_markers has become empty so it's only called
when we actually remove something from m_markers.
(WebCore::DocumentMarkerController::markerContainingPoint): Added get().
(WebCore::DocumentMarkerController::renderedRectsForMarkers): Added get().
(WebCore::DocumentMarkerController::removeMarkers): Changed to use a new
interface to removeMarkersFromList. This eliminated the need to copy the
entire map when removing markers; instead we can just copy the keys.
(WebCore::DocumentMarkerController::removeMarkersFromList): Changed to use
an iterator instead of being passed the key/value pair from the map. Also
rearranged the logic so there is less repeated code and removed some now-
unneeded comments.
(WebCore::DocumentMarkerController::repaintMarkers): Added get().
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
Added get().
(WebCore::DocumentMarkerController::showMarkers): Added get().

• dom/DocumentMarkerController.h: Removed implementation of the destructor

that called the detach function; that was just sharing the now-unneeded
call to deleteAllValues. Changed the type of the map to use an OwnPtr for
the value. Changed the interface of removeMarkersFromList to take a map
iterator instead of a key/value pair.

5:33 PM Changeset in webkit [149653] by Beth Dakin

• 5 edits in trunk/Source/WebCore

Reproducible crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent()
​https://bugs.webkit.org/show_bug.cgi?id=115685
-and corresponding-
<rdar://problem/13700734>

Reviewed by Sam Weinig.

This fix here is just to rollout the change that caused this regression, which is
​http://trac.webkit.org/changeset/147395 . That change was not intended to cause any
behavioral differences. The change made it so RenderObject::offsetParent() returned
an Element* instead of a RenderBoxModelObject*. However, can muddle things when the
object we are returning is a continuation. Multiple RenderObjects have the same
Element in a continuation, so this new code can lead to a crash in
adjustedPositionRelativeToOffsetParent() when we expect to walk the RenderObject
chain and find the offsetParent in the Element’s parent chain. But we might crash in
some complicated continuation scenarios because we lost this disambiguation of which
RenderObject to start with.

Roll out.

• dom/Element.cpp:

(WebCore::Element::offsetParent):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

• rendering/RenderObject.h:

(RenderObject):

5:20 PM Changeset in webkit [149652] by rniwa@webkit.org

• 25 edits in trunk/Source/WebCore

Unify ways to cache named item in HTMLCollections
​https://bugs.webkit.org/show_bug.cgi?id=115584

Reviewed by Antti Koivisto.

Refactor the code to share the same infrastructure for both id and name attributes maps.

Also get rid of shouldRegisterAsNamedItem and shouldRegisterAsExtraNamedItem from various Element subclasses
as these member functions were duplicating the information in HTMLNameCollection.cpp. Nevertheless, HTMLImageElement
and HTMLObjectElement still update HTMLDocument's window and document name getter maps when their presence as named
item changes due to an attribute change and children changes respectively.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter): Use windowNamedItemMap().containsSingle() instead of collection->hasExactlyOneItem() to
avoid instantiating HTMLCollection until we know for sure we're returning multiple items.
(WebCore::JSDOMWindow::getOwnPropertySlot): Call windowNamedItemMap().contains() instead of document->hasNamedItem()
since the latter has been removed.
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): Ditto.
(WebCore::JSDOMWindow::getOwnPropertyDescriptor): Ditto.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName): Call documentNamedItemMap().contains() instead of
document->hasExtraNamedItem() since the latter has been removed.
(WebCore::JSHTMLDocument::nameGetter): Use documentNamedItemMap().containsSingle() instead of
collection->hasExactlyOneItem() to avoid instantiating HTMLCollection when we're returning the first item.

• dom/Document.cpp:

(WebCore::Document::windowNamedItems): Instantiate WindowNameCollection, which is a subclass of HTMLNameCollection,
instead of HTMLNameCollection since the latter class no longer has a public constructor.
(WebCore::Document::documentNamedItems): Ditto; instantiate DocumentNameCollection.

• dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesName): Added for name attribute.
(WebCore::keyMatchesWindowNamedItem): Added for window name getter.
(WebCore::keyMatchesDocumentNamedItem): Added for document name getter.
(WebCore::DocumentOrderedMap::getElementByName): Added for name attribute.
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem): Added for window name getter.
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem): Added for document name getter.

• dom/DocumentOrderedMap.h:

(WebCore::DocumentOrderedMap::containsSingle): Added.
(WebCore::DocumentOrderedMap::containsMultiple): Fixed the bug that containsMultiple returns true even when
the duplicate count has been reduced to 1. Unfortunately this behavior change is not testable because the old code
worked properly (though less efficient) even if this function returned a wrong value.

• dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName): Added. Updates TreeScope's name attribute map as well as HTMLDocument's window name
and document name maps.
(WebCore::Element::updateId): Added the code to update HTMLDocument's window name and document name maps.

• dom/Element.h:

(Element): Removed shouldRegisterAsNamedItem, shouldRegisterAsExtraNamedItem, updateNamedItemRegistration, and
updateExtraNamedItemRegistration as they're no longer used.

• dom/TreeScope.cpp:

(SameSizeAsTreeScope):
(WebCore::TreeScope::getElementByName): Added.
(WebCore::TreeScope::addElementByName): Added.
(WebCore::TreeScope::removeElementByName): Added.

• dom/TreeScope.h:

(WebCore::TreeScope::hasElementWithName): Added.
(WebCore::TreeScope::containsMultipleElementsWithName): Added.

• html/HTMLAppletElement.h:

(HTMLAppletElement):

• html/HTMLCollection.cpp:

(WebCore::isMatchingElement): Use HTMLNameCollection subclasses' nodeMatches.
(WebCore::HTMLCollection::namedItem): Added a fast path for named item.
(WebCore::HTMLCollection::hasNamedItem): Use namedItem to avoid the work in the fast path.

• html/HTMLCollection.h:

(HTMLCollection): Removed checkForNameMatch.

• html/HTMLDocument.cpp:

(WebCore): Removed various member functions related to m_namedItemCounts and m_extraNamedItemCounts.

• html/HTMLDocument.h:

(WebCore::HTMLDocument::documentNamedItemMap): Added.
(WebCore::HTMLDocument::windowNamedItemMap): Added.
(HTMLDocument): Replaced m_namedItemCounts and m_extraNamedItemCounts by m_documentNamedItem and m_windowNamedItem.
Note that they're not one to one.

• html/HTMLEmbedElement.h:

(HTMLEmbedElement):

• html/HTMLFormElement.h:

(HTMLFormElement):

• html/HTMLIFrameElement.cpp: Removed the code to track the element's name since we already do this in Element.

(WebCore::HTMLIFrameElement::parseAttribute):

• html/HTMLIFrameElement.h:

(HTMLIFrameElement):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Update the HTMLDocument's maps when the name attribute's existence
changes its presence on window and document name getters in turn. This behavior change, again, appears to be
untestable due to the old being more graceful when DocumentOrderedMap returned a wrong value.

• html/HTMLImageElement.h:

• html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection): No longer overrides itemAfter. This enables backwards traversals
of the tree along with other optimizations in HTMLCollection.

(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch): Added. Used in Element::updateName to determine
whether add() or remove() should be called on HTMLDocument's maps.
(WebCore::WindowNameCollection::nodeMatches): Added.

(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch): Added. Used in Element::updateName to determine
whether add() or remove() should be called on HTMLDocument's maps.
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch): Ditto.
(WebCore::DocumentNameCollection::nodeMatches): Added.

• html/HTMLNameCollection.h:

(HTMLNameCollection): Removed create since this class shouldn't be instantiated on its own.

(WebCore::WindowNameCollection): Added.
(WebCore::WindowNameCollection::create): Added.
(WebCore::WindowNameCollection::nodeMatches): Added.
(WebCore::WindowNameCollection::nodeMatchesIfIdAttributeMatch): Added.
(WebCore::WindowNameCollection::WindowNameCollection): Added.
(WebCore::DocumentNameCollection): Added.
(WebCore::DocumentNameCollection::create): Added.
(WebCore::DocumentNameCollection::nodeMatches): Added.
(WebCore::DocumentNameCollection::DocumentNameCollection): Added.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem): Update both window and document getter maps of HTMLDocument when
the visibility of this element changes due to the DOM mutations in the subtree.

• html/HTMLObjectElement.h:

(WebCore::HTMLObjectElement):
(WebCore::toHTMLObjectElement): Added.

5:05 PM Changeset in webkit [149651] by beidson@apple.com

• 3 edits in trunk/Source/WebKit2

Remove some unnecessary soft linking in NetworkProcess.
<rdar://problem/13821779> and ​https://bugs.webkit.org/show_bug.cgi?id=115683

Reviewed by Sam Weinig.

Replace some unneeded soft linking with forward declarations.

• NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor):

• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

4:55 PM Changeset in webkit [149650] by commit-queue@webkit.org

• 1 edit
  8 deletes in trunk/Tools

Unreviewed, rolling out r149547.
​http://trac.webkit.org/changeset/149547
​https://bugs.webkit.org/show_bug.cgi?id=115682

Added unittests that fail on bots and spits out text into
stdout (Requested by rniwa on #webkit).

• Scripts/import-w3c-tests: Removed.
• Scripts/webkitpy/w3c/init.py: Removed.
• Scripts/webkitpy/w3c/test_converter.py: Removed.
• Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
• Scripts/webkitpy/w3c/test_importer.py: Removed.
• Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
• Scripts/webkitpy/w3c/test_parser.py: Removed.
• Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.

4:38 PM Changeset in webkit [149649] by ggaren@apple.com

• 64 edits
  2 adds in branches/dfgFourthTier

Cherry-pick merged some patches to the FTL branch.

Unreviewed.

Source/JavaScriptCore:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

Source/WebCore:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

Source/WTF:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

LayoutTests:

r147184
r147190
r147234
r147658
r147669
r147677
r147887
r147892
r149236
r149247
r149418

4:21 PM Changeset in webkit [149648] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Flaky Test: fast/frames/crash-remove-iframe-during-object-beforeload.html
<​http://webkit.org/b/115674>

Reviewed by Alexey Proskuryakov.

Don't cache the Document::renderer() in a local since layout may blow it away.

• dom/Document.cpp:

(WebCore::Document::implicitClose):

4:06 PM Changeset in webkit [149647] by andersca@apple.com

• 5 edits in trunk/Source

More work on LocalStorageDatabaseTracker
​https://bugs.webkit.org/show_bug.cgi?id=115680

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Call the new databaseFilename that takes a string.

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Assert that we don't call this more than once. Dispatch a call to import origin identifiers.

(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
New helper function that returns the tracker database path.

(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Open the database and create the Origins table if needed.

(WebKit::LocalStorageDatabaseTracker::importOriginIdentifiers):
Open the database and import the origin identifiers from it, then synchronize it with whatever files are on disk.

(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Bring the tracker database up to date from the database files on disk.

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

(LocalStorageDatabaseTracker):

3:49 PM Changeset in webkit [149646] by ap@apple.com

• 5 edits in trunk/Source/WebKit2

<rdar://problem/13479806> [Mac] Pass information about open pages to LaunchServices
​https://bugs.webkit.org/show_bug.cgi?id=115665

Reviewed by Darin Adler.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): Moved repeated check for frame->isMainFrame() to the top, matching oter similar functions. Call updateActivePages().

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::networkProcessConnectionClosed): Removed an obsolete FIXME. (WebKit::WebProcess::updateActivePages): Empty implementation for platforms that don't need to do anything here.

• WebProcess/WebProcess.h: Added updateActivePages().

• WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::updateActivePages): Collect user visible origins of pages in the process and pass them to LS.

3:47 PM Changeset in webkit [149645] by kov@webkit.org

• 2 edits in trunk/Tools

[jhbuild] bump jhbuild version to take advantage of new improvements
​https://bugs.webkit.org/show_bug.cgi?id=115558

Reviewed by Martin Robinson.

One of the important improvements is jhbuild no longer fetches git
repositories if they are already at the expected revision, which should
make the EWS bots more robust to git servers unavailability.

• jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.

3:33 PM Changeset in webkit [149644] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/13775921> Switch off a deprecated API.

Reviewed by Oliver Hunt.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::setProcessSuppressionEnabled): When disabling process suppression,
begin an activity that doesn't disable idle sleep, sudden termination or automatic termination.
When enabling process suppression, end the activity.

2:43 PM Changeset in webkit [149643] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Move local storage directory handling to LocalStorageDatabaseTracker
​https://bugs.webkit.org/show_bug.cgi?id=115676

Reviewed by Andreas Kling.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:

(WebCore):
(LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectory):
(WebKit):
(WebKit::LocalStorageDatabaseTracker::databaseFilename):
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):

• UIProcess/Storage/LocalStorageDatabaseTracker.h:

(WebCore):
(LocalStorageDatabaseTracker):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::setLocalStorageDirectory):

• UIProcess/Storage/StorageManager.h:

(StorageManager):

2:20 PM Changeset in webkit [149642] by commit-queue@webkit.org

• 19 edits in trunk

[GTK] Add webkit_uri_scheme_request_finish_error
​https://bugs.webkit.org/show_bug.cgi?id=94316

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-06
Reviewed by Anders Carlsson.

Source/WebCore:

No behaviour change, covered by existing tests.

• platform/network/soup/ResourceError.h:

(ResourceError): Rename genericIOError() to genericGError().

• platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::httpError): Use genercicGError() instead of
genericIOError().
(WebCore::ResourceError::genericGError): Use error domain instead of
always return a G_IO_ERROR.

• platform/network/soup/ResourceHandleSoup.cpp: Use genericGError()

instead of genericIOError().
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

Source/WebKit2:

This new method will allow to finish WebKitURISchemeRequest with a
GError that will be passed to the WebKitWebView through the
"load-failed" signal.

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_finish_error): Implement new method using
WebSoupRequestManagerProxy::didFailURIRequest().

• UIProcess/API/gtk/WebKitURISchemeRequest.h: Add new method header.
• UIProcess/API/gtk/WebKitWebContext.cpp: Include the usage of the new

method in the code example at webkit_web_context_register_uri_scheme()
documentation.

• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the new

method.

• UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(loadFailedCallback): Set m_error to monitor it from the tests.
(LoadTrackingTest::loadURI): Clear m_error before each load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
(LoadTrackingTest::reload): Ditto.
(LoadTrackingTest::goBack): Ditto.
(LoadTrackingTest::goForward): Ditto.

• UIProcess/API/gtk/tests/LoadTrackingTest.h: Add new member m_error.
• UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextURIScheme): Modify test to check the behavior of the new
method.

• UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::didFailURIRequest):
(WebKit): Implement new method using
WebSoupRequestManager::DidFailURIRequest().

• UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy): Add new method header.

• WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit):
(WebKit::WebSoupRequestManager::didFailURIRequest): Implement new method
setting the error and completing the request.

• WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager): Add new method header.

• WebProcess/soup/WebSoupRequestManager.messages.in: Add new method

signature.

Tools:

• MiniBrowser/gtk/main.c:

(miniBrowserErrorQuark): Add function to create a global quark for
MiniBrowser.
(aboutURISchemeRequestCallback): Update MiniBrowser to use the new
function webkit_uri_scheme_request_finish_error().

2:18 PM Changeset in webkit [149641] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Heap-use-after-free in WebCore::InlineFlowBox::deleteLine
​https://bugs.webkit.org/show_bug.cgi?id=114772

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-06
Reviewed by David Hyatt.

Source/WebCore:

Fix the new use after free issues in Ruby.

Test: fast/ruby/ruby-svg-crash.html

• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

LayoutTests:

Test case generated by the fuzzer. Will only crash when run in a
vulnerable configuration with a memory checking lib enabled.

• fast/ruby/ruby-svg-crash-expected.txt: Added.
• fast/ruby/ruby-svg-crash.html: Added.

2:16 PM Changeset in webkit [149640] by robert@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r140024): child of fixed div inside of absolute div does not get resized when window is resized
​https://bugs.webkit.org/show_bug.cgi?id=115379

Reviewed by David Hyatt.

Source/WebCore:

When detecting whether a fixed pos object needed to move with an absolute ancestor we checked
whether the logical width of the fixed pos object had changed. This check prevented the fixed pos
object from detecting later on that it needed to relayout its children in layoutBlock(). So recompute the width
for our check instead of updating it.

Test: fast/block/positioning/child-of-fixed-pos-after-movement.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):

LayoutTests:

• fast/block/positioning/child-of-fixed-pos-after-movement-expected.txt: Added.
• fast/block/positioning/child-of-fixed-pos-after-movement.html: Added.

2:07 PM Changeset in webkit [149639] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Every LocalStorageDatabase should know about its tracker
​https://bugs.webkit.org/show_bug.cgi?id=115673

Reviewed by Andreas Kling.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):

1:56 PM Changeset in webkit [149638] by commit-queue@webkit.org

• 10 edits in trunk

[BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=113808

Patch by Mike Lattanzio <​mlattanzio@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

.:

Set the ENABLE_TEXT_AUTOSIZING default to ON for BlackBerry.

• Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

Added TextAutosizer.cpp to the BlackBerry build.

• PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Create a WebSetting for text autosizing. The default is off.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

• Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
(BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):

• Api/WebSettings.h:

Tools:

Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
to true for BlackBerry.

• Scripts/webkitperl/FeatureList.pm:

1:48 PM Changeset in webkit [149637] by andersca@apple.com

• 4 edits
  2 adds in trunk/Source/WebKit2

Add LocalStorageDatabaseTracker class
​https://bugs.webkit.org/show_bug.cgi?id=115671

Reviewed by Andreas Kling.

Somewhat unsurprisingly, this class will be used for tracking local storage databases.

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp: Added.

(WebKit::LocalStorageDatabaseTracker::create):
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
(WebKit::LocalStorageDatabaseTracker::~LocalStorageDatabaseTracker):

• UIProcess/Storage/LocalStorageDatabaseTracker.h: Added.

(LocalStorageDatabaseTracker):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageManager):
Create a local storage database tracker.

• WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:48 PM Changeset in webkit [149636] by ggaren@apple.com

• 89 edits in branches/dfgFourthTier

Rolled back in r149527 with crash fixed.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

This fixes a bunch of Sputnik tests, and some bad pointer access.

The new model is that the callee always performs 'this' value conversion.

My ultimate goal is to break up resolve_with_this into single-result
opcodes. This step avoids having to add a special form of convert_this
that distinguishes callers vs callees.

Only the callee knows whether it uses 'this' and/or whether 'this'
conversion should use StrictMode, so it's most natural to perform
convert_this in the callee.

• API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call): Perform 'this' value conversion for our callee, since it may observe 'this'.

• API/JSCallbackObjectFunctions.h: (JSC::::call): Ditto.

• API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): Use a proxy 'this' object in global scope even when we're not in the browser. This eliminates some odd cases where API clients used to be able to get a direct reference to an environment record. Now, any reference to an environment record unambiguously means that the VM resolved that record in the scope chain.

(JSContextGetGlobalObject): Removed an incorrect comment. Now that JSC
participates in the proxy 'this' object scheme, the behavior is not
WebCore-only.

• API/JSObjectRef.cpp: (JSObjectSetPrototype): (JSObjectCallAsFunction): Don't perform 'this' value conversion in the caller; the callee will do it if needed.

• JavaScriptCore.order: Order!

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: What are the chances that this will work?

• bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock): Renamed convert_this to to_this, to match our other conversion opcodes.

• bytecode/CodeOrigin.h: (CodeOrigin): (InlineCallFrame): (JSC::CodeOrigin::codeOriginOwner): Use the more precise type for our executable, so compilation can discover where we're in strict mode.

• bytecode/Opcode.h: (JSC::padOpcodeName): Updated for rename.

• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Always emit to_this when 'this' is in use -- strict mode still needs to convert environment records to 'undefined'.

• dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::executeEffects):
• dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
• dfg/DFGCapabilities.h: (JSC::DFG::canCompileOpcode): Updated for renames.

• dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): Tightened up this code to consider strict mode (a new requirement) and to consider the global object (which was always a requirement).

• dfg/DFGGraph.h: (JSC::DFG::Graph::globalThisObjectFor): (JSC::DFG::Graph::executableFor):
• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
• dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
• dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): Ditto.

• interpreter/Interpreter.cpp: (JSC::eval): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall):
• interpreter/Interpreter.h: Don't ASSERT about 'this' -- it's our job to fix it up if needed.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
• jit/JIT.h: (JIT):
• jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_this): (JSC::JIT::emitSlow_op_to_this):
• jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_to_this): (JSC::JIT::emitSlow_op_to_this):
• jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
• jit/JITStubs.h: Removed special-case code for various kinds of conversions. The baseline fast path is now final objects only. It hurt my brain to think through how to keep the other fast paths working, and our benchmarks do not object.

• llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
• llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):
• llint/LLIntSlowPaths.h: (LLInt):
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm: Updated for renames. Removed some special case code, as in the JIT above.

• profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
• runtime/CallData.cpp: (JSC::call):
• runtime/ClassInfo.h: (MethodTable):
• runtime/Completion.cpp: (JSC::evaluate):
• runtime/DatePrototype.cpp: (JSC::dateProtoFuncToJSON): The callee performs 'this' conversion, not the caller.

• runtime/GetterSetter.cpp: (JSC::callGetter): (JSC::callSetter):
• runtime/GetterSetter.h: Added helper functions for invoking getters and setters from C++ code, since this was duplicated in a bunch of places.

• runtime/JSActivation.cpp: (JSC::JSActivation::toThis):
• runtime/JSActivation.h: (JSActivation):
• runtime/JSCJSValue.cpp: (JSC::JSValue::toThisSlowCase): (JSC::JSValue::putToPrimitive):
• runtime/JSCJSValue.h: (JSValue):
• runtime/JSCJSValueInlines.h: (JSC::JSValue::toThis):
• runtime/JSCell.cpp: (JSC::JSCell::toThis):
• runtime/JSCell.h: (JSCell):
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::toThis):
• runtime/JSGlobalObject.h: (JSGlobalObject): Filled out runtime support for converting 'this' values as needed, according to the appropriate strictness, using helper functions where getter/setter code was duplicated.

• runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncProtoGetter): (JSC::globalFuncProtoSetter): Perform 'this' value conversion, since we observe 'this'.

• runtime/JSNameScope.cpp: (JSC::JSNameScope::toThis):
• runtime/JSNameScope.h: (JSNameScope): Same as JSActivation.

• runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::setPrototypeWithCycleCheck): Bug fix. Don't peform 'this' value conversion in this helper function. The proto setter does this for us, since it's the function that logically observes 'this' -- and we can ASSERT so. Also, the previous code used "globalExec()->thisValue()", which is a read past the beginning of a buffer! I don't think this ever worked on purpose.

(JSC::JSObject::toThis):
(JSC::JSObject::fillGetterPropertySlot):

• runtime/JSObject.h: (JSC::JSObject::inlineGetOwnPropertySlot):
• runtime/JSScope.cpp: (JSC::JSScope::resolveWithThis):
• runtime/JSString.cpp: (JSC::JSString::toThis):
• runtime/JSString.h: (JSString):
• runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
• runtime/PropertySlot.h: (JSC): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot):
• runtime/SparseArrayValueMap.cpp: (JSC::SparseArrayEntry::get): (JSC::SparseArrayEntry::put):
• runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::toThis):
• runtime/StrictEvalActivation.h: (StrictEvalActivation): Ditto.

Source/WebCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit/mac:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit2:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

LayoutTests:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

1:32 PM Changeset in webkit [149635] by jberlin@webkit.org

• 3 edits in trunk/Tools

check-webkit-style should complain about a layering violation if platform-specific guards are
used in WebCore outside of the platform directory
​https://bugs.webkit.org/show_bug.cgi?id=115567

Reviewed by Benjamin Poulain.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_for_webcore_platform_layering_violation):
If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
(process_line):
Add the check_for_webcore_platform_layering_violation.
(CppChecker):
List the new check.

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_webcore_platform_layering_violation):
Add tests.

1:28 PM Changeset in webkit [149634] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Misc bugfix and cleaning in sh4 base JIT.
​https://bugs.webkit.org/show_bug.cgi?id=115627

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-06
Reviewed by Oliver Hunt.

Get rid of loadX(RegisterID r0, RegisterID src, RegisterID dest) functions.
Remove misplaced extuw() implementation from MacroAssemblerSH4.
Add movbRegMemr0 and movwRegMemr0 functions in SH4Assembler.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::add32): Skip operation when first operand is a zero immediate.
(JSC::MacroAssemblerSH4::sub32): Skip operation when first operand is a zero immediate.
(JSC::MacroAssemblerSH4::load32): Fix wrong usage of r0 register.
(JSC::MacroAssemblerSH4::load8Signed): Handle "base == r0" case.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16): Handle "base == r0" case.
(JSC::MacroAssemblerSH4::load16Unaligned): Use extuw() implementation from SH4Assembler.
(JSC::MacroAssemblerSH4::load16Signed): Cosmetic change.
(JSC::MacroAssemblerSH4::store8): Fix unhandled BaseIndex offset and handle (base == r0) case.
(JSC::MacroAssemblerSH4::store16): Fix unhandled BaseIndex offset and handle (base == r0) case.
(JSC::MacroAssemblerSH4::store32):

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::movwRegMemr0):
(SH4Assembler):
(JSC::SH4Assembler::movbRegMemr0):
(JSC::SH4Assembler::placeConstantPoolBarrier): Cosmetic change.
(JSC::SH4Assembler::maxJumpReplacementSize):
(JSC::SH4Assembler::replaceWithJump): Correct branch range and save an opcode.
(JSC::SH4Assembler::printInstr):

1:17 PM Changeset in webkit [149633] by andersca@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Stop using WTF::deleteAllValues in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=115670

Reviewed by Oliver Hunt.

Change the Vectors used to Vectors of OwnPtrs instead.

• heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

1:15 PM Changeset in webkit [149632] by Darin Adler

• 3 edits in trunk/Source/WebCore

Use OwnPtr instead of deleteAllValues in SVGAttributeToPropertyMap
​https://bugs.webkit.org/show_bug.cgi?id=115653

Reviewed by Andreas Kling.

Also made a few style fixes to the code at the same time.

• svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::addProperties): Changed argument to
const because there was no reason for it to be non-const. Added calls to
get() since the items in the map are now OwnPtr. Added a couple FIXMEs
about performance mistakes.
(WebCore::SVGAttributeToPropertyMap::addProperty): Added a FIXME about
a small performance mistake, and updated to use OwnPtr instead of raw
pointers.
(WebCore::SVGAttributeToPropertyMap::synchronizeProperties): Added a call
to get().

• svg/properties/SVGAttributeToPropertyMap.h: Removed now-unneeded

constructor and destructor definitions. Changed the type for the
addProperties to be const&. Added a comment about incorrect function
naming. Changed the type of the map data member to use OwnPtr.

1:13 PM Changeset in webkit [149631] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Handle closing the local storage database
​https://bugs.webkit.org/show_bug.cgi?id=115669

Reviewed by Beth Dakin.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Initialize m_isClosed.

(WebKit::LocalStorageDatabase::~LocalStorageDatabase):
Assert that m_isClosed is false.

(WebKit::LocalStorageDatabase::close):
Set m_isClosed to true and write any pending changes to disk.

(WebKit::LocalStorageDatabase::updateDatabase):
Compute the changed items and pass them to updateDatabaseWithChangedItems.

(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Split out the code that actually writes to the database from updateDatabase and into this function.

• UIProcess/Storage/LocalStorageDatabase.h:
• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::~StorageArea):
Call close().

12:49 PM Changeset in webkit [149630] by ddkilzer@apple.com

• 3 edits in trunk/Tools

webkit-patch: fix 'upload' command with Bugzilla 4.2.5
<​http://webkit.org/b/115667>

Reviewed by Dirk Pranke.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._check_create_bug_response): Update regex to work with
Bugzilla 3.2.3 and 4.2.5.

• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(testcheck_create_bug_response): Add new test that covers both
old and new <title> variations.

12:38 PM Changeset in webkit [149629] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Ensure document is attached before accessing its FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=115565

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR 312101
We need to make sure that the node and document
are attached before accessing the FrameSelection. This was
handled earlier but not all call paths were covered.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):

• WebKitSupport/InputHandler.h:

12:37 PM Changeset in webkit [149628] by Antti Koivisto

• 12 edits in trunk/Source

Remove more code that was only needed for younger/older shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=115662

Reviewed by Andreas Kling.

This is dead code.

• WebCore.exp.in:
• dom/ComposedShadowTreeWalker.cpp:

(WebCore::nodeCanBeDistributed):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):

• dom/EventPathWalker.cpp:

(WebCore::EventPathWalker::moveToParent):

• html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::ScopeContentDistribution):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
(WebCore):
(WebCore::ScopeContentDistribution::hasInsertionPoint):
(WebCore::ContentDistributor::invalidate):

• html/shadow/ContentDistributor.h:

(ScopeContentDistribution):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::contains):
(WebCore::resolveReprojection):
(WebCore::collectInsertionPointsWhereNodeIsDistributed):

• html/shadow/InsertionPoint.h:
• testing/Internals.cpp:

(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

12:36 PM Changeset in webkit [149627] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not spellcheck when composition is active.
​https://bugs.webkit.org/show_bug.cgi?id=115562

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR331344
Typing can trigger rechecking since layout changes. Ensure
extra work is only done when we need it, and that it won't
be triggered when composition is active. If the user hasn't
finished a word yet, it is likely future key events will be
arriving, so checking the string at this point is extraneous.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

12:31 PM Changeset in webkit [149626] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reduce the spellcheck checking range
​https://bugs.webkit.org/show_bug.cgi?id=115479

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR332773
Previously we were spellchecking the entire field on focus. If relayouting
occurred we rechecked this region, which is very costly. Switch to check
only a small region around the caret in both cases, which should alleviate
much of the delays experienced in very large contenteditable fields. This
allows for faster key input response and less time processing these requests
on the WebKit thread.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.cpp:

(WebKit):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):

• WebKitSupport/SpellingHandler.h:

(SpellingHandler):

12:29 PM Changeset in webkit [149625] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use a more descriptive timer name
​https://bugs.webkit.org/show_bug.cgi?id=115481

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-06
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

Changing m_timer to m_iterationDelayTimer.

• WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::SpellingHandler):
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):

• WebKitSupport/SpellingHandler.h:

(SpellingHandler):

12:13 PM Changeset in webkit [149624] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Update HTML5 progress bar UX.
​https://bugs.webkit.org/show_bug.cgi?id=115284.

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-06
Reviewed by Rob Buis.

BlackBerry PR 331729.
Internally Reviewed by Jeff Rogers.

Use GL render to paint progress bar to meet UX specs.
Also change the slider range to GL render.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintProgressTrackRect):
(WebCore::drawProgressTexture):
(WebCore::RenderThemeBlackBerry::paintProgressBar):

• platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

12:11 PM Changeset in webkit [149623] by commit-queue@webkit.org

• 12 edits
  5 deletes in trunk

[CSS Exclusions] remove unused -webkit-wrap property
​https://bugs.webkit.org/show_bug.cgi?id=102105

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-06
Reviewed by Darin Adler.

Source/WebCore:

Remove -webkit-wrap property and all mentions. This property doesn't
exist in the spec anymore, and was never implemented more than just
parsing the property.

• WebCore.order:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

• css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

• css/StylePropertyShorthand.h:

(WebCore):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Delete tests for the -webkit-wrap property.

• fast/exclusions/css-exclusions-disabled.html: Remove use of -webkit-wrap.
• fast/exclusions/script-tests/wrap-parsing.js: Removed.
• fast/exclusions/wrap-parsing-expected.txt: Removed.
• fast/exclusions/wrap-parsing.html: Removed.
• svg/css/style-change-crash-expected.txt: Removed.
• svg/css/style-change-crash.html: Removed.

11:49 AM Changeset in webkit [149622] by abecsi@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Build with GCC 4.8 fails because of -Wmaybe-uninitialized
​https://bugs.webkit.org/show_bug.cgi?id=115648

Reviewed by Michael Saboff.

Initialize values in Options::setOption since from
there we end up calling OptionRange::init with
uninitialized members.

• runtime/Options.cpp:

11:46 AM Changeset in webkit [149621] by roger_fong@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed. AppleWin VS2010 build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

11:44 AM Changeset in webkit [149620] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebNetworkInfoManagerProxy a supplement to the WebContext
​https://bugs.webkit.org/show_bug.cgi?id=115654

Reviewed by Andreas Kling.

Rather than holding a RefPtr to the WebNetworkInfoManagerProxy object in WebContext, change the WebNetworkInfoManagerProxy
to implement the WebContextSupplement interface and handle the object as such in WebContext, simplifying its
construction and cleanup, removing the specific RefPtr member variable and its correlating getter method.

• UIProcess/API/C/WKContext.cpp:

(WKContextGetNetworkInfoManager): Retrieve the WebNetworkInfoManagerProxy object from the suppplements of the WebContext.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Add the WebNetworkInfoManagerProxy object as a supplement instead of assigning it to
the now-removed member variable.
(WebKit::WebContext::~WebContext): No need for the specific cleanup, the equivalent is achieved when iterating through the
supplements vector.
(WebKit::WebContext::disconnectProcess): Ditto.

• UIProcess/WebContext.h:

(WebContext): Remove the WebNetworkInfoManagerProxy RefPtr member variable and its getter method.

• UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::supplementName): Specift the supplement's name.
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy): Initialize as a WebContextSupplement.
(WebKit::WebNetworkInfoManagerProxy::providerDidChangeNetworkInformation): Adjust to use the context() method instead of
accessing the private m_context directly.
(WebKit::WebNetworkInfoManagerProxy::contextDestroyed): Stop updating when invoked.
(WebKit::WebNetworkInfoManagerProxy::processDidClose): Ditto.
(WebKit::WebNetworkInfoManagerProxy::refWebContextSupplement): Call APIObject::ref.
(WebKit::WebNetworkInfoManagerProxy::derefWebContextSupplement): Call APIObject::deref.

• UIProcess/WebNetworkInfoManagerProxy.h:

(WebNetworkInfoManagerProxy): Inherit from WebContextSupplement, declare the newly-inherited methods.

11:40 AM Changeset in webkit [149619] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/13479806> [Mac] Pass plug-in bundle ID to LaunchServices
​https://bugs.webkit.org/show_bug.cgi?id=115483

Reviewed by Darin Adler.

• PluginProcess/PluginProcess.h: Added m_pluginBundleIdentifier. We now need it in multiple places, so it's easier to pre-compute it.

• PluginProcess/mac/PluginProcessMac.mm: (WebKit::loadSandboxProfileForDirectory): Changed to use precomputed bundle ID. (WebKit::loadSandboxProfile): Ditto. (WebKit::PluginProcess::platformInitializeProcess): Pre-compute bundle ID. (WebKit::PluginProcess::initializeProcessName): Pass it to LaunchServices. (WebKit::PluginProcess::initializeSandbox): Pass precomputed bundle ID instead of a path.

11:38 AM Changeset in webkit [149618] by andersca@apple.com

• 4 edits in trunk/Source/WebKit2

Handle removeItem and clear in LocalStorageDatabase
​https://bugs.webkit.org/show_bug.cgi?id=115664

Reviewed by Darin Adler.

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::removeItem):
Call itemDidChange with a null value, indicating that we want to remove this item.

(WebKit::LocalStorageDatabase::clear):
Clear items, set m_shouldClearItems and schedule a database update.

(WebKit::LocalStorageDatabase::updateDatabase):
If m_shouldClearItems is true, clear all items.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::removeItem):
Call through to the local storage database.

(WebKit::StorageManager::StorageArea::clear):
Ditto.

11:13 AM Changeset in webkit [149617] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
​https://bugs.webkit.org/show_bug.cgi?id=115661

Reviewed by Ryosuke Niwa.

The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.

• TestResultServer/static-dashboards/flakiness_dashboard.js:
• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

11:12 AM Changeset in webkit [149616] by Christophe Dumez

• 1 edit
  1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Add EFL-specific result for fast/events/event-attribute.html as global expectation
was changed in r149088.

• platform/efl/fast/events/event-attribute-expected.txt: Added.

11:10 AM Changeset in webkit [149615] by andersca@apple.com

• 6 edits in trunk/Source

Write storage changes to disk
​https://bugs.webkit.org/show_bug.cgi?id=115660

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

• WebCore.exp.in:

Source/WebKit2:

• UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Initialize new member variables.

(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Disable database threading checks.

(WebKit::LocalStorageDatabase::importItems):
Only import the items once.

(WebKit::LocalStorageDatabase::setItem):
Call itemDidChange.

(WebKit::LocalStorageDatabase::itemDidChange):
Record the change and schedule a database update.

(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):
Use WorkQueue::dispatchAfterDelay to schedule a datbase update.

(WebKit::LocalStorageDatabase::updateDatabase):
Write changes to disk. If there are more than 100 pending items, only write the first 100 and then schedule
another database update for the remaining items.

• UIProcess/Storage/LocalStorageDatabase.h:

Add new member variables.

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::setItem):
Call LocalStorageDatabase::setItem.

11:05 AM Changeset in webkit [149614] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Update HTML5 progress bar UX.
​https://bugs.webkit.org/show_bug.cgi?id=115284.

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-06
Reviewed by Rob Buis.

BlackBerry PR 331729.
Internally Reviewed by Jeff Rogers.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::createLinearGradient):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderTrackRect):
(WebCore::RenderThemeBlackBerry::paintProgressBar):

• platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

11:03 AM Changeset in webkit [149613] by Christophe Dumez

• 3 edits
  3 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases for EFL port.

• platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
• platform/efl/editing/selection/extend-inside-transforms-backward-expected.png: Added.
• platform/efl/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
• platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.png:
• platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

10:56 AM Changeset in webkit [149612] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several test cases as failing after r149292 due to missing repaint rect
dumping.

• platform/efl/TestExpectations:

10:55 AM Changeset in webkit [149611] by zandobersek@gmail.com

• 4 edits in trunk/Tools

[Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
​https://bugs.webkit.org/show_bug.cgi?id=114603

Reviewed by Ryosuke Niwa.

• TestResultServer/generate_builders_json.py:

(insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
to represent these to be 'layout-test', for backwards compatibility.
(main): Remove all the build.chromium.org masters.

• TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.

(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):

• TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the

test-running builders from the webkit.org master.

10:49 AM Changeset in webkit [149610] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
​https://bugs.webkit.org/show_bug.cgi?id=114988

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium

and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.

• TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,

mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.

10:49 AM Changeset in webkit [149609] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Cherry-pick fixes to bignum from upstream
​https://bugs.webkit.org/show_bug.cgi?id=115658

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-05-06
Reviewed by Darin Adler.

Cherry-picked the following change lists:

Fix bug in bignum implementation
​http://codereview.chromium.org/13454019

Make VS2005 project files compile without errors
​http://codereview.chromium.org/6286135

• wtf/dtoa/bignum.cc:

10:48 AM Changeset in webkit [149608] by Christophe Dumez

• 17 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip repaint test that regressed after r149292.

• platform/efl/TestExpectations:

10:46 AM Changeset in webkit [149607] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip repaint test that regressed after r149292.

• platform/efl/TestExpectations:

10:44 AM Changeset in webkit [149606] by Christophe Dumez

• 17 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several repaint test cases after r149292.

• fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
• fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
• fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
• fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:
• fast/repaint/layer-full-repaint-expected.txt:
• fast/repaint/overflow-flipped-writing-mode-table-expected.txt:
• fast/repaint/reflection-table-layout-expected.txt:
• fast/repaint/selection-gap-absolute-child-expected.txt:
• fast/repaint/selection-gap-fixed-child-expected.txt:
• fast/repaint/selection-gap-flipped-absolute-child-expected.txt:
• fast/repaint/selection-gap-flipped-fixed-child-expected.txt:
• fast/repaint/selection-gap-transformed-absolute-child-expected.txt:
• fast/repaint/selection-gap-transformed-fixed-child-expected.txt:
• fast/repaint/transform-table-layout-expected.txt:
• platform/efl/fast/images/repaint-subrect-grid-expected.txt:
• svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:

10:44 AM Changeset in webkit [149605] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Remove the remaining traces of platform modifier unions
​https://bugs.webkit.org/show_bug.cgi?id=114954

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
modifier unions in the list of modifiers.
(generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.

10:32 AM Changeset in webkit [149604] by zandobersek@gmail.com

• 3 edits in trunk/Tools

[Flakiness Dashboard] Simplify builder-name-based platform recognition
​https://bugs.webkit.org/show_bug.cgi?id=114957

Reviewed by Ryosuke Niwa.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(determineBuilderPlatform): Renamed from nonChromiumPlatform.
(chromiumPlatform): Removed, unnecessary.
(platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
the builder operates with debug builds, no webkit.org builders are named this way.

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.

10:15 AM Changeset in webkit [149603] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip remaining Shadow DOM test and new accessibility test introduced in
r115659.

• platform/efl/TestExpectations:

9:41 AM Changeset in webkit [149602] by mikhail.pozdnyakov@intel.com

• 3 edits in trunk/Source/WTF

Change HashTraits<RefPtr<P> >::PassOutType to PassRefPtr for better performance
​https://bugs.webkit.org/show_bug.cgi?id=115410

Reviewed by Darin Adler.

The type HashTraits<RefPtr<P> >::PassOutType is PassRefPtr now to
avoid extra ref/unrefing on return from HashMap methods that transfer
ownership, such as take.

• wtf/HashTable.h:

(WTF::IdentityHashTranslator::equal):

• wtf/HashTraits.h:

9:37 AM Changeset in webkit [149601] by rgabor@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

JSC ARM traditional failing on Octane NavierStokes test
​https://bugs.webkit.org/show_bug.cgi?id=115626

Reviewed by Zoltan Herczeg.

Change the ARM traditional assembler to use double precision on value
conversions.

• assembler/ARMAssembler.h:

9:17 AM Changeset in webkit [149600] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebKit2

[WK2] Make the WebBatteryManagerProxy a supplement to the WebContext
​https://bugs.webkit.org/show_bug.cgi?id=115625

Reviewed by Andreas Kling.

Rather than holding a RefPtr to the WebBatteryManagerProxy object in WebContext, change the WebBatteryManagerProxy
to implement the WebContextSupplement interface and handle the object as such in WebContext, simplifying its
construction and cleanup, removing the specific RefPtr member variable and its correlating getter method.

• UIProcess/API/C/WKContext.cpp:

(WKContextGetBatteryManager): Retrieve the WebBatteryManagerProxy object from the supplements of the WebContext.

• UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::supplementName): Specify the supplement's name.
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy): Initialize as a WebContextSupplementable.
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus): Adjust to use the context() method instead of accessing
the private m_context directly.
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus): Ditto.
(WebKit::WebBatteryManagerProxy::contextDestroyed): Stop updating when invoked.
(WebKit::WebBatteryManagerProxy::processDidClose): Ditto.
(WebKit::WebBatteryManagerProxy::refWebContextSupplement): Call APIObject::ref.
(WebKit::WebBatteryManagerProxy::derefWebContextSupplement): Call APIObject::deref.
(WebKit::WebBatteryManagerProxy::startUpdating): Fire up the provider if not yet updating.
(WebKit::WebBatteryManagerProxy::stopUpdating): Wind down the provider if updating.

• UIProcess/WebBatteryManagerProxy.h:

(WebBatteryManagerProxy): Inherit from WebContextSupplement, declare the newly-inherited methods.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Add the WebBatteryManagerProxy object as a supplement instead of assigning it to
the now-removed member variable.
(WebKit::WebContext::~WebContext): No need for the specific cleanup, the equivalent is achieved when iterating through the
supplements vector.
(WebKit::WebContext::disconnectProcess): Ditto.

• UIProcess/WebContext.h:

(WebContext): Remove the WebBatteryManagerProxy RefPtr member variable and its getter method.

8:43 AM Changeset in webkit [149599] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[texmap] draw content if graphics layer displays a video
​https://bugs.webkit.org/show_bug.cgi?id=114742

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-05-06
Reviewed by Noam Rosenthal.

Bug #86410 focuses on having composited/accelerated video using the
TextureMapper. But the video is not rendered fast by using the
repaint() method. In the case of the TextureMapper it is required to
call a content display as fast as possible.

This patch adds the class TextureMapperPlatformLayer::Client with the
method setLayerNeedsDisplay(). The GraphicsLayerTextureMapper
implements this new class and the new method calls
setContentsNeedsDisplay(), causing a faster content display when
requested.

No new tests. Covered by existing tests.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToMedia): sets itself
as the TextureMapperPlatformLayer's client

• platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::setLayerNeedsDisplay):
TextureMapperPlatformLayer::Client::setLayerNeedsDisplay implementation
(GraphicsLayerTextureMapper):

• platform/graphics/texmap/TextureMapperPlatformLayer.h:

(Client): New class
(WebCore::TextureMapperPlatformLayer::TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::setClient): client setter
(WebCore::TextureMapperPlatformLayer::setLayerNeedsDisplay): facade
for client's method

8:28 AM Changeset in webkit [149598] by hmuller@adobe.com

• 7 edits in trunk/LayoutTests

[CSS Exclusions] shape-inside rounded rectangle tests fail when subpixel layout is disabled
​https://bugs.webkit.org/show_bug.cgi?id=115490

Second round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off. This set of changes just restores four ref-tests that place
a single square Ahem character cell within a circle or an ellipse. When subpixel layout isn't
enabled the expected origin of the character is adjusted.

Reviewed by Dirk Schulze.

• fast/exclusions/shape-inside/shape-inside-circle-expected.html:
• fast/exclusions/shape-inside/shape-inside-circle-padding-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse-padding-expected.html:
• fast/exclusions/shape-inside/shape-inside-ellipse.html:
• platform/mac/TestExpectations:

8:23 AM Changeset in webkit [149597] by hyatt@apple.com

• 3 edits in trunk/Source/WebCore

Improve the performance of RenderDeprecatedFlexibleBox.
​https://bugs.webkit.org/show_bug.cgi?id=115543.

Optimize deprecated flexible box layout to be much faster. This patch implements
the following optimizations in the deprecated flexible box:

(1) Defer repainting of children until they have been placed into their final
positions. This is done by collecting all of the old frame rects into a Vector
and then doing a walk after layout is finished to repaint any of the children if
they moved from that position. This code matches the new RenderFlexibleBox's system
for repainting moved children.

(2) Implement support for layout deltas. We keep a Vector of layout deltas for each
child as we shift them around, and every time we lay a child out again, we apply that
child's current layout delta to avoid repainting at the new position. RenderFlexibleBox
does not have support for layout deltas yet, so we'll need to implement this in the
new flexbox code as well.

(3) Optimize flexible objects to avoid laying them out unflexed. When laying out
horizontal and vertical boxes now, we lay out the inflexible items first. We then
check to see if the inflexible extent of all those children has changed.

If this extent didn't change, and the flexible items either don't need layout or there
is only one flexing item, then we avoid laying out the item in an unflexed state
and simply lay out one time with the flex applied instead. The new RenderFlexibleBox
does not have these optimizations and would benefit from them in the block-direction box
case (it uses preferred logical widths in the inline-direction box case, and so avoided
layouts in that direction already).

Reviewed by Beth Dakin.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::appendChildFrameRects):
Cache all of the old child frame rects so that we can compare them with the final
positions for repaintDuringLayoutIfMoved. This collection is identical to what the
new flexbox code does.

(WebCore::appendChildLayoutDeltas):
Build up a vector that tracks layout deltas. We apply these layout deltas every
time we lay out a child so that any repainting done during layout ignores our shifted
position and just keeps using the old position. The new flexbox does not have this
code yet.

(WebCore::repaintChildrenDuringLayoutIfMoved):
After final placement of children, we do a single pass over all of the children and
repaint them if they shifted their positions. This matches how the new flexbox works.

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Collect the frame rects and layout deltas, and defer repainting of children to the
end of layout.

(WebCore::gatherFlexChildrenInfo):
Don't clear flex overrides when gathering flex information. Add additional information
such as the number of flexing items so that we can use it to optimize flex layout.

(WebCore::layoutChildIfNeededApplyingDelta):
A helper for applying your current layout delta for a child when laying that child out.

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Both methods are patched to aggregate layout deltas as children move around during
the multiple passes. In addition we now optimize layout in a couple of cases, such
as when the inflexible space stays the same (thus giving a flexible object the
same amount of available space, avoiding a need to lay out unflexed first).

(WebCore::RenderDeprecatedFlexibleBox::placeChild):
Patched to add to our cached layout delta for that child when we do a movement.

• rendering/RenderDeprecatedFlexibleBox.h:

Changes to method signatures.

6:54 AM Changeset in webkit [149596] by Christophe Dumez

• 2 edits in trunk

[EFL] Shadow DOM should be disabled at compile time
​https://bugs.webkit.org/show_bug.cgi?id=115635

Reviewed by Andreas Kling.

Disable Shadow DOM at compile time for EFL port. Shadow DOM code
is being removed from the tree.

• Source/cmake/OptionsEfl.cmake:

6:27 AM Changeset in webkit [149595] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Remove duplicate Shadow DOM test cases from TestExpectation files.

• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

5:50 AM Changeset in webkit [149594] by Christophe Dumez

• 3 edits in trunk/LayoutTests

Unreviewed. Remove duplicate tests from EFL TestExpectation files.

• platform/efl-wk2/TestExpectations:
• platform/efl/TestExpectations:

5:40 AM Changeset in webkit [149593] by Christophe Dumez

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip Shadow DOM tests for EFL port as the feature is being removed.

• platform/efl/TestExpectations:

4:14 AM Changeset in webkit [149592] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding new failure expectations and adjusting an old one.

3:45 AM Changeset in webkit [149591] by zandobersek@gmail.com

• 3 edits
  2 adds in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148720, r149088 and r149407.

• platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
• platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
• platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.
• platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

3:32 AM Changeset in webkit [149590] by aestes@apple.com

• 1 edit
  2 adds in trunk/Tools

Added two files I neglected to commit in r149589.

• TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
• TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.

3:29 AM Changeset in webkit [149589] by aestes@apple.com

• 8 edits in trunk

REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=115609

Reviewed by Oliver Hunt.

Source/WebCore:

When a window created by window.open() is navigated, the embedder might
close it in decidePolicyForNavigationAction. If this happens, we end up
with a pointer to a deleted Frame.

Fix this by keeping a strong reference to the Frame created by
createWindow(). We can later determine if the window was closed by
checking if the new Frame has a detached Page.

Added an API test: WebKit1.CloseNewWindowInNavigationPolicyDelegate.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

Tools:

Added an API test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.

(+[TestDelegate shared]):
(-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[TestDelegate webView:createWebViewWithRequest:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.

2:46 AM Changeset in webkit [149588] by zandobersek@gmail.com

• 7 edits in trunk/Source

[GTK] Move GeolocationProviderGeoclue into libPlatform
​https://bugs.webkit.org/show_bug.cgi?id=115591

Reviewed by Martin Robinson.

Source/Platform:

• GNUmakefile.am: List the Source/WebCore/platform/geoclue directory under platform_webcore_cppflags.

Add Geoclue dependency CPPFLAGS to the list of libPlatform's CPPFLAGS.

Source/WebCore:

No new tests - no new functionality.

• GNUmakefile.am: Remove the Source/WebCore/platform/geoclue directory from the webkitgtk_cppflags list.
• GNUmakefile.list.am: Move the GeolocationProviderGeoclue(Client) sources under platform_sources.

Source/WebKit/gtk:

• GNUmakefile.am: Add platform_webcore_cppflags to the list of libwebkitgtk's CPPFLAGS.

1:41 AM Changeset in webkit [149587] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/Source/WebCore

[Qt][Win] Unreviewed buildfix after r149579.

• plugins/win/PluginDatabaseWin.cpp:

(WebCore::addQtWebKitPluginPath):

1:31 AM WebKit Team edited by yuqiang.xian@intel.com

(diff)

1:24 AM Changeset in webkit [149586] by Antoine Quint

• 18 edits in trunk

Manage the presentation of the snapshotted plug-in using JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=115548

Reviewed by Dean Jackson.

Source/WebCore:

• Resources/plugIns.js:

(createOverlay):
Implement the createOverlay(shadowRoot, titleText, subtitleText) method
that is called from WebCore (HTMLPlugInImageElement::didAddUserAgentShadowRoot)
to allow the injected script to customize the shadow root for a snapshotted
plug-in. This is a default implementation, clients are expected to customize
this by providing their own JS file with enhanced behavior.

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
Since we no longer have a default shadow tree generated in C++, it makes little
sense for clients to extend the default snapshotted plug-in stylesheet, so we
only insert it if no custom one is provided by the chrome client.

• css/plugIns.css:

Better styling of the default snapshotted plug-in overlay look by using CSS
flex boxes. Also using more explicit selector as an optimization.

• dom/Document.cpp:

(WebCore::Document::ensurePlugInsInjectedScript):
Expose a new method to allow HTMLPlugInImageElement instances to ensure that
the JavaScript code required to customize the snapshotted plug-in's shadow root
is indeed injected in the current document. The actual injection would only
happen once per document so all snapshotted plug-ins share the same scripting
context.

• dom/Document.h:

Expose the new ensurePlugInsInjectedScript method and the m_hasInjectedPlugInsScript
property used to ensure injection happens only once per document.

• html/HTMLPlugInImageElement.cpp:

(WebCore::titleText):
(WebCore::subtitleText):
Store the localized strings for each mime-type in a static hash map as it can be
costly to retrieve them each time from the client. It is expected the chrome client
will want to provide localized strings taking into account the snapshotted plug-in's
mime-type, so we're adding this as a parameter.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus):
Dispatch a "resize" event to the shadow root to notify the injected script that the
snapshotted plug-in's metrics have changed and to allow the overlay to update itself
as a result.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Remove all the DOM generation code in favor of an approach where we create a shared
DOM scripting world in which we inject JavaScript code that will perform the same
task but will additionally be provided by the client in order to provide a completely
custom overlay for the snapshotted plug-in. The sole contract is for the JavaScript
to implement a createOverlay(shadowRoot, titleText, subtitleText) method.
(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay):
Renamed method to be generic to the overlay as opposed to text labels and use the
element with CSS class name "snapshot-overlay" as the comparison node.

• html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement):
Removing a couple of unused members since we no longer generate the shadow DOM from C++
and rename the partOfSnapshotLabel method to partOfSnapshotOverlay.

• page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelTitle):
(WebCore::ChromeClient::plugInStartLabelSubtitle):
(WebCore::ChromeClient::plugInExtraScript):
Pass in the mime-type to plugInStartLabelTitle and plugInStartLabelSubtitle and expose
a new plugInExtraScript method to allow the chrome client to provide a custom JS file
for the management of the shadow root.

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent):
Update the terminology from "label" to "overlay" per the changes made in HTMLPlugInImageElement.

Source/WebKit2:

Expose a new plugInExtraScript method to support the injection of
a JS file from the chrome client to customize the rendering of a
snapshotted plug-in's shadow tree. Additionally, it is expected
the chrome client will want to provide localized strings taking
into account the snapshotted plug-in's mime-type, so we're adding
this as a parameter to both plugInStartLabelTitle and
plugInStartLabelSubtitle methods.

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
(WebKit::InjectedBundlePageUIClient::plugInExtraScript):

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelTitle):
(WebKit::WebChromeClient::plugInStartLabelSubtitle):
(WebKit::WebChromeClient::plugInExtraScript):

• WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Tools:

Take into account the new plugInExtraScript method added to support
the injection of a JS file from the chrome client to customize the
rendering of a snapshotted plug-in's shadow tree.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

12:32 AM Changeset in webkit [149585] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r140907) - Backport blink r149612 to fix vertical-align and rowspan issue
​https://bugs.webkit.org/show_bug.cgi?id=115611

Source/WebCore:

Patch by Julien Chaffraix.
Patch by Robert Hogan <​robert@webkit.org> on 2013-05-06
Reviewed by Benjamin Poulain.

Backport phttps://src.chromium.org/viewvc/blink?view=rev&revision=149612 from
​https://chromiumcodereview.appspot.com/14105010

Fix the rows' height computation with vertical-align: baseline and rowspan.
r140907 was careful in avoiding updating the baseline descent for
spanning cells. However it still added the non-spanning cells baseline
descent to the spanning cells' row height computation.
This change avoids the previous issue by not adding the baseline
descent in this case.

Test: fast/table/baseline-align-rowspan.html

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Patch by Robert Hogan <​robert@webkit.org> on 2013-05-06
Reviewed by Benjamin Poulain.

• fast/table/baseline-align-rowspan-expected.txt: Added.
• fast/table/baseline-align-rowspan.html: Added.

May 5, 2013:

10:43 PM Changeset in webkit [149584] by Chris Fleizach

• 2 edits in trunk/Source/WebKit2

WEB SPEECH: deny file-read-data /Library/Speech/Synthesizers
​https://bugs.webkit.org/show_bug.cgi?id=115621

Reviewed by Alexey Proskuryakov.

Allow access to the location where 3rd party speech synthesizers are stored.

• WebProcess/com.apple.WebProcess.sb.in:

9:10 PM Changeset in webkit [149583] by andersca@apple.com

• 13 edits in trunk/Source

Remove Vector::prepend
​https://bugs.webkit.org/show_bug.cgi?id=115618

Reviewed by Geoffrey Garen.

Source/WebCore:

Replace calls to Vector::prepend with either Vector::insert,
or a combination of Vector::append and Vector::reverse.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToGlobalPoint):

• css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):

• css/CSSValueList.h:

(WebCore::CSSValueList::prepend):

• dom/Document.cpp:

(WebCore::Document::iconURLs):

• editing/TextIterator.cpp:

(WebCore::SearchBuffer::prependContext):

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):

• history/HistoryItem.cpp:

(WebCore::HistoryItem::padDailyCountsForNewVisit):
(WebCore::HistoryItem::collapseDailyVisitsToWeekly):

• inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::addInspectedObject):

• platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

Source/WTF:

Given the performance characteristics of prepending something to a Vector, not having prepend
will hopefully make developers think about whether prepending is necessary at all. For example,
the functions in HexNumber.h were easily converted to using Vector::append and then Vector::reverse.

• wtf/HexNumber.h:

(WTF::appendUnsignedAsHex):
(WTF::appendUnsignedAsHexFixedSize):

• wtf/Vector.h:

(Vector):

5:22 PM Changeset in webkit [149582] by weinig@apple.com

• 5 edits in trunk/Source/WebCore

Remove empty function SQLiteFileSystem::registerSQLiteVFS() and its callers
​https://bugs.webkit.org/show_bug.cgi?id=115619

Reviewed by Dan Bernstein.

• Modules/webdatabase/DatabaseTracker.cpp:
• platform/sql/SQLiteFileSystem.cpp:
• platform/sql/SQLiteFileSystem.h:
• storage/StorageTracker.cpp:

4:25 PM Changeset in webkit [149581] by Chris Fleizach

• 4 edits
  2 adds in trunk

AX: aria-checked not exposed correctly on menuitemcheckbox or menuitemradio roles
​https://bugs.webkit.org/show_bug.cgi?id=115499

Reviewed by Tim Horton.

Source/WebCore:

Expose isChecked() for menu item objects.
Return the Mac-platform specific value that you find on menu items for "checked" menu items.

Test: platform/mac/accessibility/aria-menuitem-checked-value.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isChecked):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

• platform/mac/accessibility/aria-menuitem-checked-value-expected.txt: Added.
• platform/mac/accessibility/aria-menuitem-checked-value.html: Added.

3:11 PM Changeset in webkit [149580] by timothy_horton@apple.com

• 4 edits in trunk/Source

[wk2] Page Overlays: deviceScaleFactor doesn't update when the display changes
​https://bugs.webkit.org/show_bug.cgi?id=115577
<rdar://problem/13762583>

Reviewed by Darin Adler.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Invalidate the page overlay layers' device scale factor when
TiledCoreAnimationDrawingArea is notified that it has changed.

• WebCore.exp.in:

Export GraphicsLayer::noteDeviceOrPageScaleFactorChangedIncludingDescendants

12:03 PM Changeset in webkit [149579] by andersca@apple.com

• 42 edits in trunk

Remove the Vector::append overload that takes a Vector
​https://bugs.webkit.org/show_bug.cgi?id=115535

Reviewed by Andreas Kling.

Source/WebCore:

Use Vector::appendVector instead.

• Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::putIndexDataForRecord):

• Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::clear):
(WebCore::AudioContext::scheduleNodeDeletion):

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cells):

• css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::add):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

• dom/DocumentStyleSheetCollection.cpp:

(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

• dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

• html/FormController.cpp:

(WebCore::FormController::getReferencedFilePaths):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineDash):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):

• html/track/WebVTTToken.h:

(WebCore::WebVTTToken::addNewClass):
(WebCore::WebVTTToken::addNewAnnotation):

• page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::preferredLanguages):

• platform/FileChooser.cpp:

(WebCore::FileChooserSettings::acceptTypes):

• platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunk):

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getSitesInMediaCache):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateSublayerList):

• platform/mac/PasteboardMac.mm:

(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::writeSelectionForTypes):

• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::generateUniqueBoundaryString):

• plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):

• svg/SVGGlyphMap.h:

(WebCore::SVGGlyphMap::collectGlyphsForString):

• xml/XPathNodeSet.h:

(WebCore::XPath::NodeSet::append):

Source/WebKit2:

Use Vector::appendVector instead.

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):

• NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::dispatchMessages):

• UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::pluginsDirectories):

Source/WTF:

The Vector::append overload that takes a Vector conflicts with rvalues in C++11, so remove it and
replace calls to it with calls to appendVector.

• wtf/Vector.h:

(Vector):

Tools:

Use Vector::appendVector instead.

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(concatenateAttributeAndValue):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::concatenateAttributeAndValue):

10:48 AM Changeset in webkit [149578] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

Make plugIns.js have a non-zero length.

• Resources/plugIns.js: