Timeline
Sep 30, 2013:
- 11:37 PM Changeset in webkit [156700] by
-
- 18 edits in trunk/Source
Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139
Reviewed by Anders Carlsson.
Get rid of more uses of OwnPtr and PassOwnPtr.
Source/WebCore:
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::beginPaint):
- platform/graphics/surfaces/GraphicsSurface.h:
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
Source/WebKit2:
- Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
- Shared/API/c/qt/WKImageQt.cpp:
(WKImageCreateFromQImage):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeImage):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy):
- UIProcess/CoordinatedGraphics/WebView.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):
- 11:12 PM Changeset in webkit [156699] by
-
- 3 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
Reviewed by Darin Adler.
Speculative partial fix.
I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.
- media/click-volume-bar-not-pausing-expected.txt:
- media/click-volume-bar-not-pausing.html:
- Add video URL after initial content fully loads to avoid races with that.
- Added some state logging for clarity.
- Only listen for "playing" event once. If playback already started, we have a playing event already queued, and would add another one with pause()/play().
- 10:58 PM Changeset in webkit [156698] by
-
- 5 edits2 adds in trunk
AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451
Patch by Sam White <Samuel White> on 2013-09-30
Reviewed by Chris Fleizach.
Source/WebCore:
Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.
Test: platform/mac/accessibility/element-busy-changed.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.
- platform/mac/accessibility/element-busy-changed-expected.txt: Added.
- platform/mac/accessibility/element-busy-changed.html: Added.
- 10:16 PM Changeset in webkit [156697] by
-
- 2 edits in trunk/Source/WebKit/efl
Fix the build.
- ewk/ewk_settings.cpp:
- 10:10 PM Changeset in webkit [156696] by
-
- 2 edits in trunk/Source/WebCore
Fixing the build.
- GNUmakefile.list.am:
- 9:59 PM Changeset in webkit [156695] by
-
- 5 edits in trunk/Source/WebCore
More build fixing.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/InspectorAllInOne.cpp:
- inspector/InstrumentingAgents.h:
- 9:57 PM Changeset in webkit [156694] by
-
- 3 edits in trunk/Tools
check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474
Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 9:47 PM Changeset in webkit [156693] by
-
- 4 edits in trunk/Source/WebCore
Fix the Efl and Gtk builds.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- 9:33 PM Changeset in webkit [156692] by
-
- 75 edits51 deletes in trunk
Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Files elided *
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/efl:
- ewk/ewk_settings.cpp:
(ewk_settings_file_system_path_set):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
- fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
- fast/filesystem: Removed.
- fast/filesystem/async-operations-expected.txt: Removed.
- fast/filesystem/async-operations.html: Removed.
- fast/filesystem/cross-filesystem-op-expected.txt: Removed.
- fast/filesystem/cross-filesystem-op.html: Removed.
- fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
- fast/filesystem/directory-entry-to-uri.html: Removed.
- fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
- fast/filesystem/entry-points-missing-arguments.html: Removed.
- fast/filesystem/file-after-reload-crash-expected.txt: Removed.
- fast/filesystem/file-after-reload-crash.html: Removed.
- fast/filesystem/file-entry-to-uri-expected.txt: Removed.
- fast/filesystem/file-entry-to-uri.html: Removed.
- fast/filesystem/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/file-from-file-entry.html: Removed.
- fast/filesystem/file-metadata-after-write-expected.txt: Removed.
- fast/filesystem/file-metadata-after-write.html: Removed.
- fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
- fast/filesystem/file-writer-abort-continue.html: Removed.
- fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
- fast/filesystem/file-writer-abort-depth.html: Removed.
- fast/filesystem/file-writer-abort-expected.txt: Removed.
- fast/filesystem/file-writer-abort.html: Removed.
- fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/file-writer-empty-blob.html: Removed.
- fast/filesystem/file-writer-events-expected.txt: Removed.
- fast/filesystem/file-writer-events.html: Removed.
- fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/file-writer-gc-blob.html: Removed.
- fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/file-writer-truncate-extend.html: Removed.
- fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/file-writer-write-overlapped.html: Removed.
- fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
- fast/filesystem/filesystem-missing-arguments.html: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
- fast/filesystem/filesystem-reference-expected.txt: Removed.
- fast/filesystem/filesystem-reference.html: Removed.
- fast/filesystem/filesystem-unserializable-expected.txt: Removed.
- fast/filesystem/filesystem-unserializable.html: Removed.
- fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
- fast/filesystem/filesystem-uri-origin.html: Removed.
- fast/filesystem/flags-passing-expected.txt: Removed.
- fast/filesystem/flags-passing.html: Removed.
- fast/filesystem/input-access-entries-expected.txt: Removed.
- fast/filesystem/input-access-entries.html: Removed.
- fast/filesystem/not-enough-arguments-expected.txt: Removed.
- fast/filesystem/not-enough-arguments.html: Removed.
- fast/filesystem/op-copy-expected.txt: Removed.
- fast/filesystem/op-copy.html: Removed.
- fast/filesystem/op-get-entry-expected.txt: Removed.
- fast/filesystem/op-get-entry.html: Removed.
- fast/filesystem/op-get-metadata-expected.txt: Removed.
- fast/filesystem/op-get-metadata.html: Removed.
- fast/filesystem/op-get-parent-expected.txt: Removed.
- fast/filesystem/op-get-parent.html: Removed.
- fast/filesystem/op-move-expected.txt: Removed.
- fast/filesystem/op-move.html: Removed.
- fast/filesystem/op-read-directory-expected.txt: Removed.
- fast/filesystem/op-read-directory.html: Removed.
- fast/filesystem/op-remove-expected.txt: Removed.
- fast/filesystem/op-remove.html: Removed.
- fast/filesystem/op-restricted-chars-expected.txt: Removed.
- fast/filesystem/op-restricted-chars.html: Removed.
- fast/filesystem/op-restricted-names-expected.txt: Removed.
- fast/filesystem/op-restricted-names.html: Removed.
- fast/filesystem/op-restricted-unicode-expected.txt: Removed.
- fast/filesystem/op-restricted-unicode.html: Removed.
- fast/filesystem/read-directory-expected.txt: Removed.
- fast/filesystem/read-directory.html: Removed.
- fast/filesystem/resources: Removed.
- fast/filesystem/resources/async-operations.js: Removed.
- fast/filesystem/resources/directory-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
- fast/filesystem/resources/file-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
- fast/filesystem/resources/file-from-file-entry.js: Removed.
- fast/filesystem/resources/file-writer-abort-continue.js: Removed.
- fast/filesystem/resources/file-writer-abort-depth.js: Removed.
- fast/filesystem/resources/file-writer-abort.js: Removed.
- fast/filesystem/resources/file-writer-empty-blob.js: Removed.
- fast/filesystem/resources/file-writer-events.js: Removed.
- fast/filesystem/resources/file-writer-gc-blob.js: Removed.
- fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
- fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-utils.js: Removed.
- fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
- fast/filesystem/resources/fs-test-util.js: Removed.
- fast/filesystem/resources/fs-worker-common.js: Removed.
- fast/filesystem/resources/op-copy.js: Removed.
- fast/filesystem/resources/op-get-entry.js: Removed.
- fast/filesystem/resources/op-get-metadata.js: Removed.
- fast/filesystem/resources/op-get-parent.js: Removed.
- fast/filesystem/resources/op-move.js: Removed.
- fast/filesystem/resources/op-read-directory.js: Removed.
- fast/filesystem/resources/op-remove.js: Removed.
- fast/filesystem/resources/op-restricted-chars.js: Removed.
- fast/filesystem/resources/op-restricted-names.js: Removed.
- fast/filesystem/resources/op-restricted-unicode.js: Removed.
- fast/filesystem/resources/op-tests-helper.js: Removed.
- fast/filesystem/resources/shared-worker-stub.js: Removed.
- fast/filesystem/resources/simple-persistent-sync.js: Removed.
- fast/filesystem/resources/simple-persistent.js: Removed.
- fast/filesystem/resources/simple-readonly.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
- fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
- fast/filesystem/resources/simple-temporary-sync.js: Removed.
- fast/filesystem/resources/simple-temporary.js: Removed.
- fast/filesystem/resources/sync-operations.js: Removed.
- fast/filesystem/script-tests: Removed.
- fast/filesystem/script-tests/TEMPLATE.html: Removed.
- fast/filesystem/script-tests/filesystem-reference.js: Removed.
- fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
- fast/filesystem/script-tests/flags-passing.js: Removed.
- fast/filesystem/script-tests/read-directory.js: Removed.
- fast/filesystem/simple-persistent-expected.txt: Removed.
- fast/filesystem/simple-persistent.html: Removed.
- fast/filesystem/simple-readonly-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object.html: Removed.
- fast/filesystem/simple-readonly.html: Removed.
- fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
- fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getfile.html: Removed.
- fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
- fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-remove.html: Removed.
- fast/filesystem/simple-temporary-expected.txt: Removed.
- fast/filesystem/simple-temporary.html: Removed.
- fast/filesystem/workers: Removed.
- fast/filesystem/workers/async-operations-expected.txt: Removed.
- fast/filesystem/workers/async-operations.html: Removed.
- fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
- fast/filesystem/workers/detached-frame-crash.html: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry.html: Removed.
- fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-empty-blob.html: Removed.
- fast/filesystem/workers/file-writer-events-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
- fast/filesystem/workers/file-writer-events.html: Removed.
- fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-gc-blob.html: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
- fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
- fast/filesystem/workers/resources: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
- fast/filesystem/workers/simple-persistent-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync.html: Removed.
- fast/filesystem/workers/simple-persistent.html: Removed.
- fast/filesystem/workers/simple-temporary-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync.html: Removed.
- fast/filesystem/workers/simple-temporary.html: Removed.
- fast/filesystem/workers/sync-operations-expected.txt: Removed.
- fast/filesystem/workers/sync-operations.html: Removed.
- fast/forms/file/input-file-entries-expected.txt: Removed.
- fast/forms/file/input-file-entries.html: Removed.
- http/tests/filesystem: Removed.
- http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
- http/tests/filesystem/no-cache-filesystem-url.html: Removed.
- http/tests/filesystem/resolve-uri-expected.txt: Removed.
- http/tests/filesystem/resolve-uri.html: Removed.
- http/tests/filesystem/resources: Removed.
- http/tests/filesystem/resources/fs-test-util.js: Removed.
- http/tests/filesystem/resources/fs-worker-common.js: Removed.
- http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
- http/tests/filesystem/script-tests: Removed.
- http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/script-tests/resolve-uri.js: Removed.
- http/tests/filesystem/workers: Removed.
- http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync.html: Removed.
- http/tests/filesystem/workers/resolve-url.html: Removed.
- http/tests/filesystem/workers/script-tests: Removed.
- http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
- http/tests/inspector/filesystem: Removed.
- http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
- http/tests/inspector/filesystem/delete-entry.html: Removed.
- http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
- http/tests/inspector/filesystem/directory-tree.html: Removed.
- http/tests/inspector/filesystem/filesystem-test.js: Removed.
- http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-directory-content.html: Removed.
- http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-file-content.html: Removed.
- http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
- http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
- http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
- http/tests/inspector/filesystem/request-metadata.html: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
- http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
- http/tests/security/filesystem-iframe-from-remote.html: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
- http/tests/workers/resources/sync-operations.js:
(onmessage):
- http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
- http/tests/workers/terminate-during-sync-operation.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:47 PM Changeset in webkit [156691] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix afer r156688.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.
- 6:37 PM Changeset in webkit [156690] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- 6:24 PM Changeset in webkit [156689] by
-
- 3 edits in trunk/Tools
More build fixage for builds with SDKs.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 5:59 PM Changeset in webkit [156688] by
-
- 93 edits in trunk/Source
Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136
Reviewed by Antti Koivisto.
Source/WebCore:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- WebCore.exp.in:
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
- fileapi/Blob.h:
(WebCore::Blob::create):
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- fileapi/ThreadableBlobRegistry.h:
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob):
- platform/network/BlobData.cpp:
(WebCore::BlobDataHandle::BlobDataHandle):
- platform/network/BlobData.h:
(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/BlobRegistryImpl.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
Source/WebKit2:
- NetworkProcess/AsynchronousNetworkLoaderClient.h:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/ArgumentEncoder.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::setImportanceAssertion):
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- Platform/CoreIPC/mac/ImportanceAssertion.h:
(CoreIPC::ImportanceAssertion::ImportanceAssertion):
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):
- PluginProcess/WebProcessConnection.h:
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- Shared/BlockingResponseMap.h:
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):
- Shared/Downloads/Download.cpp:
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
- Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):
- Shared/FileAPI/BlobRegistrationData.h:
- Shared/Plugins/NPObjectMessageReceiver.cpp:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/ShareableBitmap.h:
- Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
- Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/BackingStore.cpp:
- UIProcess/BackingStore.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
(WKBundlePageBannerCreateBannerWithCALayer):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getFindIndicatorBitmapAndRect):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- 5:48 PM Changeset in webkit [156687] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041
Reviewed by Andreas Kling.
In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- 4:42 PM Changeset in webkit [156686] by
-
- 1 copy in branches/safari-537.73-branch
New Branch.
- 4:13 PM Changeset in webkit [156685] by
-
- 1 edit36 adds in trunk/Tools
Add initial version of a new Buildbot dashboard view.
https://bugs.webkit.org/show_bug.cgi?id=122131
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
- 3:52 PM Changeset in webkit [156684] by
-
- 2 edits in trunk/Source/JavaScriptCore
<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124
Reviewed by Darin Adler.
- API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to
ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.
- 3:43 PM Changeset in webkit [156683] by
-
- 46 edits in trunk
Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
- css/StyleScopeResolver.cpp:
- css/StyleScopeResolver.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/ShadowRoot.h:
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
- html/HTMLStyleElement.h:
- html/HTMLStyleElement.idl:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
- 2:56 PM Changeset in webkit [156682] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032
Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.
Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.
No new tests needed.
- rendering/InlineBox.h:
(WebCore::InlineBox::parent):
- 2:54 PM Changeset in webkit [156681] by
-
- 2 edits in trunk/Source/WebCore
Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.
With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.
No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- 2:42 PM Changeset in webkit [156680] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>
Reviewed by Geoffrey Garen.
The ObjectPrototype constructor was only using the ExecState to get
to the VM.
- 2:41 PM Changeset in webkit [156679] by
-
- 6 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>
Reviewed by Geoffrey Garen.
The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.
- 1:47 PM Changeset in webkit [156678] by
-
- 2 edits in trunk/LayoutTests
Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121
Reviewed by Ryosuke Niwa.
Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.
- resources/js-test-pre.js:
(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
- 1:38 PM Changeset in webkit [156677] by
-
- 21 edits1 add in trunk/Source/JavaScriptCore
Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065
Reviewed by Mark Hahnenberg.
This mostly just kills a bunch of code.
But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.
But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.
Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:
a: ExtractOSREntryLocal(loc1)
b: SetLocal(@a, loc1)
c: ExtractOSRentryLocal(loc2)
d: SetLocal(@c, loc2)
Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:
a: ExtractOSREntryLocal(loc1)
b: ExtractOSREntryLocal(loc2)
c: SetLocal(@a, loc1)
d: SetLocal(@b, loc2)
e: SetLocal(@a, loc1)
f: SetLocal(@b, loc2)
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeOrigin.h:
- bytecode/ValueRecovery.cpp: Added.
(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):
- bytecode/ValueRecovery.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGNode.h:
(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
- interpreter/Register.h:
(JSC::Register::unboxedStrictInt52):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
- 1:32 PM Changeset in webkit [156676] by
-
- 19 edits1 delete in trunk/Source/WebCore
Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118
Reviewed by Alexey Proskuryakov.
Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBCursor.cpp:
- Modules/indexeddb/IDBDatabase.cpp:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactory.cpp:
- Modules/indexeddb/IDBIndex.cpp:
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBTracing.h: Removed.
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/IDBBindingUtilities.cpp:
- 1:10 PM Changeset in webkit [156675] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108
Reviewed by Darin Adler.
The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.
- UserInterface/LayerTreeDataGrid.js:
(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.
- UserInterface/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().
- 1:07 PM Changeset in webkit [156674] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix for Win64.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added correct 64-bit BitmapImage::create symbol.
- 1:07 PM Changeset in webkit [156673] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575
Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.
Reviewed by Darin Adler.
- UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
- 1:06 PM Changeset in webkit [156672] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105
Reviewed by Darin Adler.
Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.
- UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.
- 12:51 PM Changeset in webkit [156671] by
-
- 2 edits in trunk/Source/JavaScriptCore
Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.
- jit/JITStubsMSVC64.asm:
Implemented getHostCallReturnValue for Windows x86_64 processors.
- 12:44 PM Changeset in webkit [156670] by
-
- 2 edits in trunk/Source/WebKit2
NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110
Reviewed by Darin Adler.
- NetworkProcess/NetworkResourceLoader.messages.in:
- 12:35 PM Changeset in webkit [156669] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.
- WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.
- 11:58 AM Changeset in webkit [156668] by
-
- 11 edits in trunk/Source
Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>
Reviewed by Darin Adler.
RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
JSC release binary size -= 120 bytes(!)
- 11:13 AM Changeset in webkit [156667] by
-
- 2 edits in trunk/Source/WebKit
[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link
declarations missed in r156655.
- 11:09 AM Changeset in webkit [156666] by
-
- 9 edits in trunk
Fix the build when building against an SDK.
Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:58 AM Changeset in webkit [156665] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.
- 10:56 AM Changeset in webkit [156664] by
-
- 11 edits in trunk
Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.png:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/media/media-controls-clone-expected.png:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- 10:38 AM Changeset in webkit [156663] by
-
- 3 edits3 deletes in trunk/LayoutTests
editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.
Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.
- editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
- platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
- platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- 10:36 AM Changeset in webkit [156662] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.
- WinLauncher/WinLauncher.cpp:
(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.
- 9:59 AM Changeset in webkit [156661] by
-
- 5 edits in trunk
Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111
Broke several media tests (Requested by ap on #webkit).
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 9:50 AM Changeset in webkit [156660] by
-
- 7 edits in trunk/Source/WebCore
Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086
Reviewed by Darin Adler.
- loader/ProgressTracker.cpp:
- loader/ProgressTracker.h:
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):
- page/Page.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
- page/PageGroup.h:
- 9:32 AM Changeset in webkit [156659] by
-
- 3 edits in trunk/LayoutTests
[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.
Unskipped accessibility/heading-level.html. It passes after r156551.
- platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:
- 9:30 AM Changeset in webkit [156658] by
-
- 7 edits2 deletes in trunk
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961
Reviewed by Csaba Osztrogonác.
Get rid of the unused WebKit2QML library
.:
- Source/api.pri:
Source/WebKit2:
- Target.pri:
- WebKit2.pro:
- WebKit2QML.pri: Removed.
Tools:
- qmake/mkspecs/features/webkit_modules.prf:
- qmake/mkspecs/modules/webkit2qml.prf: Removed.
- 9:21 AM Changeset in webkit [156657] by
-
- 14 edits1 delete in trunk/Source/WebCore
Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088
Reviewed by Andreas Kling.
This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.cpp:
(WebCore::useBackslashAsYenSignForFamily):
Move the family set to Font.cpp.
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):
Keep the cached boolean up to date.
- platform/graphics/Font.h:
(WebCore::Font::useBackslashAsYenSymbol):
Use descriptive name instead of talking about "transcoding".
- platform/text/transcoder: Removed.
- platform/text/transcoder/FontTranscoder.cpp: Removed.
- platform/text/transcoder/FontTranscoder.h: Removed.
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):
Rename for clarity.
Avoid unnecessary hash lookup, just check the cached bit in Font.
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):
"Transcoding" here was just a simple character replacement.
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):
Renamed.
- rendering/RenderText.h:
- 9:09 AM Changeset in webkit [156656] by
-
- 5 edits in trunk
REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049
Reviewed by Eric Carlson.
Source/WebCore:
Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no
audioTracks are present, and vice versa.
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 8:43 AM Changeset in webkit [156655] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the Windows build.
- WebFrame.cpp:
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):
- 8:42 AM Changeset in webkit [156654] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102
Reviewed by Geoffrey Garen.
_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.
- jit/JITOperationWrappers.h:
- 8:39 AM Changeset in webkit [156653] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Mac-Lion build fix.
Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
- 8:17 AM Changeset in webkit [156652] by
-
- 6 edits5 adds in trunk
[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/audio-track.html
Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.
- WebCore.xcodeproj/project.pbxproj:
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate
so that the underlying media track can be (dis|en)abled.
- platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.
(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.
(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from
the associated AVPlayerItemTrack and its AVAssetTrack.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from
MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks
have been added or removed and notify the clients accordingly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into
AudioTrackPrivateAVFObjC::languageForAVAssetTrack.
LayoutTests:
- media/track/audio-track-expected.txt: Added.
- media/track/audio-track.html: Added.
- 7:57 AM Changeset in webkit [156651] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107
Unreviewed EFL gardening.
fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl/TestExpectations:
- platform/efl/fast/forms/textarea-metrics-expected.txt: Added.
- 7:05 AM Changeset in webkit [156650] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r153927.
- WebView.cpp:
(WebView::WebView):
- 6:58 AM Changeset in webkit [156649] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r155289.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
- 6:57 AM Changeset in webkit [156648] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r154178.
- WebView.cpp:
(WebView::wndProc):
- 6:15 AM Changeset in webkit [156647] by
-
- 4 edits in trunk
[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.
Tools:
Previously used two types of recording time, which conflicted with each other.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseUp):
LayoutTests:
After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.
- platform/efl/TestExpectations:
- 4:49 AM Changeset in webkit [156646] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096
Unreviewed EFL gardening.
Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 3:56 AM Changeset in webkit [156645] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.
- platform/gtk-wk2/TestExpectations: Removed passing tests.
- 3:46 AM Changeset in webkit [156644] by
-
- 2 edits in trunk/LayoutTests
[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk2/TestExpectations:
- 3:44 AM Changeset in webkit [156643] by
-
- 2 edits in trunk/LayoutTests
[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.
Test passes after r156532.
- platform/efl/TestExpectations:
- 3:39 AM Changeset in webkit [156642] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055
Reviewed by Antti Koivisto.
Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().
No new tests, no behavior changes.
- css/CSSCalculationValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCalcValue):
- css/StyleResolver.cpp:
(WebCore::hasVariableReference):
- 2:33 AM Changeset in webkit [156641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- 1:26 AM Changeset in webkit [156640] by
-
- 3 edits in trunk/Tools
[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089
Reviewed by Gyuyoung Kim.
Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):
- 1:21 AM Changeset in webkit [156639] by
-
- 9 edits in trunk/Source/WebCore
Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080
Reviewed by Andreas Kling.
This is ugly and shows up in profiles too. Use a bit in RenderElement instead.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.
(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Tighten the interface.
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObject.h:
Remove the static map.
- 1:14 AM Changeset in webkit [156638] by
-
- 9 edits2 adds in trunk
[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334
Reviewed by Andreas Kling.
Source/WebCore:
Based on Blink r151684 by <jchaffraix@chromium.org>
Test: fast/css-grid-layout/grid-item-area-get-set.html
Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
From Blink r151684 by <jchaffraix@chromium.org>
- fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-area-get-set.html: Added.
- 1:10 AM Changeset in webkit [156637] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):
- 12:35 AM Changeset in webkit [156636] by
-
- 8 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060
Reviewed by Antti Koivisto.
As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.
No new tests, no behavior change.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- 12:12 AM Changeset in webkit [156635] by
-
- 3 edits2 adds in trunk
user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159
Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.
When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).
During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.
Test: editing/caret/selection-with-caret-type-progress.html
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.
LayoutTests:
Test case added to verify that explicitly set cursor style
is retained on performing text selection.
- editing/caret/selection-with-caret-type-progress-expected.txt: Added.
- editing/caret/selection-with-caret-type-progress.html: Added.
Sep 29, 2013:
- 11:32 PM Changeset in webkit [156634] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
- 10:40 PM Changeset in webkit [156633] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.
No new tests, no behavior change.
- css/CSSCanvasValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCanvasValue):
- 10:38 PM Changeset in webkit [156632] by
-
- 5 edits in trunk/Source/ThirdParty
Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087
Reviewed by Mark Rowe.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
- src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
an unused function and get a warning.
- 10:30 PM Changeset in webkit [156631] by
-
- 9 edits in trunk
Fix the Lion build.
Ensure that C++ and Objective-C++ files build with the right compiler flags.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:28 PM Changeset in webkit [156630] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054
Reviewed by Darin Adler.
As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.
No new tests, no behavior changes.
- css/CSSLineBoxContainValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 10:26 PM Changeset in webkit [156629] by
-
- 4 edits in trunk/Source/WebCore
Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057
Reviewed by Antti Koivisto.
Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.
No new tests, no behavior changes.
- css/CSSCrossfadeValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- 10:22 PM Changeset in webkit [156628] by
-
- 6 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.
No new tests, no behavior changes.
- css/CSSFilterImageValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSInitialValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::generatedOrPendingFromValue):
- 9:57 PM Changeset in webkit [156627] by
-
- 2 edits in trunk/Source/WebCore
Fix crashes caused by my recent attempt at a Windows build fix.
- bindings/js/WebCoreTypedArrayController.cpp: (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to WebCore::toJS, otherwise this function just calls itself infinitely recursively.
- 9:56 PM Changeset in webkit [156626] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
- 9:36 PM Changeset in webkit [156625] by
-
- 14 edits in trunk/Source/WebCore
Cleanup PageThrottler and PageConsole a bit
https://bugs.webkit.org/show_bug.cgi?id=122085
Reviewed by Anders Carlsson.
- html/HTMLMediaElement.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/SubresourceLoader.h:
Store the PageActivityAssertionToken as a std::unique_ptr.
- page/Page.cpp:
(WebCore::Page::Page):
Use createOwned and pass this by reference for the PageThrottler and PageConsole.
(WebCore::Page::~Page):
Remove unnecessary clearing of an OwnPtr that is about to be destroyed.
- page/Page.h:
Make m_pageThrottler const and return it as a reference.
- page/PageActivityAssertionToken.cpp:
(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):
- page/PageActivityAssertionToken.h:
Take the PageThrottler by reference in the constructor. It is never null.
- page/PageConsole.cpp:
(WebCore::PageConsole::PageConsole):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::addMessage):
- page/PageConsole.h:
Pass and store the Page as a reference and remove an extraneous null check. Remove
the create function.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::createActivityToken):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::addActivityToken):
(WebCore::PageThrottler::removeActivityToken):
- page/PageThrottler.h:
Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
to aid encapsulation.
- 8:45 PM Changeset in webkit [156624] by
-
- 52 edits in trunk/Source
Pass VM instead of JSGlobalObject to function constructors.
<https://webkit.org/b/122082>
Reviewed by Darin Adler.
Functions don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
This patch is mostly mechanical, I just changed the signature of
InternalFunction and worked my way from there until it built.
JSC release binary size -= 4840 bytes.
- 7:54 PM Changeset in webkit [156623] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Windows build.
- bindings/js/WebCoreTypedArrayController.cpp: Windows has a symbol named Handle, so we need to call JSC::Handle out by name. To fix that, I removed "using namespace JSC" entirely. And just for fun, sort of "rewrote" this file. (WebCore::WebCoreTypedArrayController::WebCoreTypedArrayController): Removed unneeded explicit initialization of m_owner. (WebCore::WebCoreTypedArrayController::~WebCoreTypedArrayController): Fixed formatting. (WebCore::WebCoreTypedArrayController::toJS): Added lots of explicit JSC and got rid of local. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots): Cut down on locals, used auto& for type, and called it "wrapper" since that's what JSArrayBuffer is. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize): More of the same.
- 7:40 PM Changeset in webkit [156622] by
-
- 138 edits in trunk/Source
Use RenderElement instead of RenderObject in many places
https://bugs.webkit.org/show_bug.cgi?id=122078
Reviewed by Andreas Kling.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.
Source/WebCore:
- WebCore.exp.in: Updated for name changes.
- dom/ContainerNode.h: Moved renderer() here from Element.
- dom/Element.h: Moved renderer() from here to ContainerNode.
- render/RenderElement.h: Moved renderer() from Element to ContainerNode.
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore::AccessibilityImageMapLink::detachFromParent):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _font]):
(-[DOMElement _imageTIFFRepresentation]):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):
- css/CSSCanvasValue.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):
- css/CSSCrossfadeValue.h:
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::knownToBeOpaque):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::filterImageChanged):
- css/CSSFilterImageValue.h:
- css/CSSFontSelector.cpp:
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::knownToBeOpaque):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::fixedSize):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSImageGeneratorValue.h:
(WebCore::CSSImageGeneratorValue::clients):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
- css/CSSImageValue.h:
- css/DeprecatedStyleBuilder.cpp:
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):
- dom/Element.cpp:
(WebCore::localZoomForRenderer):
(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetParent):
(WebCore::Element::updateExistingPseudoElement):
- dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::ensureRareData):
- editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
(WebCore::Editor::baseWritingDirectionForSelectionStart):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/htmlediting.cpp:
(WebCore::directionOfEnclosingBlock):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/markup.cpp:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::setFocus):
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFrameOwnerElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::defaultEventHandler):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::renderMeter):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::didRecalcStyle):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellAbove):
- html/HTMLTextFormControlElement.cpp:
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- html/InputType.h:
- html/parser/HTMLResourcePreloader.cpp:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlElement::setDisplayType):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterInnerElement::rendererIsNeeded):
- inspector/InspectorOverlay.cpp:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
- loader/cache/CachedImage.h:
- mathml/MathMLElement.cpp:
- page/ContextMenuController.cpp:
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::selectCursor):
(WebCore::layerForNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearGestureScrollNodes):
- page/EventHandler.h:
- page/FocusController.cpp:
- page/Frame.cpp:
(WebCore::Frame::ownerRenderer):
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::nodeImage):
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintSlowRepaintObjects):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
- page/FrameView.h:
- page/PageSerializer.cpp:
(WebCore::PageSerializer::addImageToResources):
- page/PageSerializer.h:
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::renderer):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::crossfadeBlend):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::create):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- page/animation/KeyframeAnimation.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::snapshotDragImage):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::paint):
- rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
- rendering/CounterNode.h:
(WebCore::CounterNode::owner):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
(WebCore::FilterEffectRenderer::build):
- rendering/FilterEffectRenderer.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::image):
- rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
- rendering/LayoutRepainter.h:
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
- rendering/LineWidth.h:
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
(WebCore::isNonRenderBlockInline):
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderCounter.cpp:
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::rendererForRootBackground):
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::initialize):
- rendering/RenderImageResource.h:
- rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::initialize):
- rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::create):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
(WebCore::RenderLayerCompositor::requiresCompositingForBlending):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
- rendering/RenderLayerCompositor.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::mustRepaintFillLayers):
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
- rendering/RenderScrollbarPart.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableCell.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
- rendering/style/FillLayer.h:
- rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
(WebCore::StyleCachedImage::image):
(WebCore::StyleCachedImage::knownToBeOpaque):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::addClient):
(WebCore::StyleCachedImageSet::removeClient):
(WebCore::StyleCachedImageSet::image):
(WebCore::StyleCachedImageSet::knownToBeOpaque):
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
(WebCore::StyleGeneratedImage::knownToBeOpaque):
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
(WebCore::StyleImage::imagesEquivalent):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::computeIntrinsicDimensions):
- testing/Internals.cpp:
(WebCore::Internals::boundingBox):
(WebCore::Internals::isSelectPopupVisible):
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Use RenderElement instead of RenderObject where it was easy to do so.
For local variables holding the return value of renderer() functions,
use auto instead, so the most-specific possible type will be used,
without having to figure out what that is in each case. Also use some
more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
cryptic short local variable names with words.
- 5:57 PM Changeset in webkit [156621] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
<https://webkit.org/b/122079>
Reviewed by Geoffrey Garen.
ArrayPrototype doesn't need the global object for anything during
construction, so reduce the amount of loads by just passing the VM.
- 3:20 PM Changeset in webkit [156620] by
-
- 31 edits in trunk/Source
Pass VM instead of ExecState to simple builtin constructors.
<https://webkit.org/b/122077>
Reviewed by Sam Weinig.
None of the simple builtins need the ExecState for anything during
their construction, so reduce the amount of loads by just passing
the VM around instead.
- 3:16 PM Changeset in webkit [156619] by
-
- 8 edits3 adds in trunk
Repaint borders and outlines on pseudo content changes
https://bugs.webkit.org/show_bug.cgi?id=122070
Reviewed by Andreas Kling.
Source/WebCore:
This patch fixes a regression from wkrev.com/150259 where pseudo content with
borders or outlines would fail to repaint if the color property changed.
The root bug is that border-color and outline-color properties use 'color' if
no explicit border-color or outline-color are given, and changing color should
repaint borders and outlines even if the text content is empty.
Relevant spec sections:
border: http://www.w3.org/TR/CSS1/#border-color
outline: http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
This patch also renames StyleDifferenceRepaintIfText to
StyleDifferenceRepaintIfTextOrBorderOrOutline and updates the relevant functions.
Test: fast/repaint/hover-pseudo-borders.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):
This function has been renamed to reflect that it returns true for borders
or outlines as well.
(WebCore::RenderElement::shouldRepaintForStyleDifference):
- rendering/RenderElement.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
These have also been renamed to reflect the new borders and outlines check.
LayoutTests:
- fast/repaint/hover-pseudo-borders.html: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Added.
- 1:50 PM Changeset in webkit [156618] by
-
- 6 edits in trunk/Source/WebCore
Tighten typing in inline rendering
https://bugs.webkit.org/show_bug.cgi?id=122076
Reviewed by Andreas Kling.
More RenderElement, const, &, etc.
- dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::isLastChildForRenderer):
(WebCore::isAncestorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::isEmptyInline):
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::canBreakAtThisPosition):
(WebCore::LineBreaker::nextSegmentBreak):
- rendering/shapes/ShapeInsideInfo.h:
(WebCore::LineSegmentIterator::LineSegmentIterator):
- 12:31 PM Changeset in webkit [156617] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor code for finding x86 scratch register.
https://bugs.webkit.org/show_bug.cgi?id=122072
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::store16):
- 11:04 AM Changeset in webkit [156616] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Skip the IndexedDB tests for now as the feature is going
through substantial changes that don't ensure constant proper functionality.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
Sep 28, 2013:
- 11:02 PM Changeset in webkit [156615] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Merge ScriptControllerBase into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=122071
Reviewed by Antti Koivisto.
There is no need for ScriptControllerBase. Remove it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: Removed.
- bindings/ScriptControllerBase.h: Removed.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/js/ScriptController.h:
- 10:42 PM Changeset in webkit [156614] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r156613 for ports enabling CSS3_TEXT.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::requiresIndent): Use the RenderStyle reference.
- 9:34 PM Changeset in webkit [156613] by
-
- 21 edits in trunk/Source/WebCore
Switch inline boxes to use const RenderStyle&
https://bugs.webkit.org/show_bug.cgi?id=122068
Reviewed by Sam Weinig.
- 1:20 PM Changeset in webkit [156612] by
-
- 12 edits in trunk/Source/WebCore
Add first()/last() to ElementIteratorAdapters
https://bugs.webkit.org/show_bug.cgi?id=122067
Reviewed by Darin Adler.
Add a convenient way for getting the first and last element if it exists.
Use it in some places.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- dom/Document.cpp:
(WebCore::Document::childrenChanged):
(WebCore::Document::removeTitle):
- dom/ElementChildIterator.h:
(WebCore::::first):
(WebCore::::last):
- dom/ElementDescendantIterator.h:
(WebCore::::first):
(WebCore::::last):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::associatedControl):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::selectMediaResource):
- svg/SVGElement.cpp:
(WebCore::SVGElement::title):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
- 1:01 PM Changeset in webkit [156611] by
-
- 18 edits2 copies in trunk
Fix some failures with newer versions of clang.
Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
Reviewed by Dan Bernstein.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
- DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- 12:15 PM Changeset in webkit [156610] by
-
- 17 edits in trunk/Source
Take Xcode's advice and enable some extra warnings.
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItemNS): Use the correct constant.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- WebKit2.xcodeproj/project.pbxproj:
Source/WTF:
- Configurations/Base.xcconfig:
- WTF.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [156609] by
-
- 4 edits in trunk/Source/WebCore
CTTE: VisitedLinkState should hold a Document&
https://bugs.webkit.org/show_bug.cgi?id=122066
Reviewed by Antti Koivisto.
The Document can never be null, so use a reference.
- 11:30 AM Changeset in webkit [156608] by
-
- 23 edits in trunk/Source/WebCore
Clean up code for getting first line style
https://bugs.webkit.org/show_bug.cgi?id=122037
Reviewed by Andreas Kling.
We have confusing RenderObject::style(bool firstLine). Get rid of it in favour of
just using RenderObject::firstLineStyle() where appropriate.
Also switch to RenderStyle references in many places and move first line style caching
code down to RenderElement.
- 10:19 AM Changeset in webkit [156607] by
-
- 44 edits in trunk/Source
Add Frame::mainFrame and Frame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=122064
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in: Removed exports of FrameView::isMainFrameView and
Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
does not need to be exported.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
These two were the only functions I found that really wanted the equivalent
of Page::frameIsMainFrame, so wrote it out here instead of using a function
call.
- inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
- inspector/InspectorAgent.h: Removed declarations of a few nonexistent or
unused private member functions. Also removed the InjectedScriptForOriginMap
typedef: It's mor readable to use the type directly
- loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than
calling frame().isMainFrame() directly.
- page/Frame.cpp:
(WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
the MainFrame alive as long as any of its subframes is alive.
(WebCore::Frame::~Frame): Call selfOnlyDeref.
(WebCore::Frame::createView): Use isMainFrame.
(WebCore::Frame::setPageAndTextZoomFactors): Ditto.
- page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
- page/FrameView.h: Removed the isMainFrameView function. It's not better than
calling frame().isMainFrame() directly.
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
(WebCore::MainFrame::selfOnlyRef): Added.
(WebCore::MainFrame::selfOnlyDeref): Added.
(WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
count reaches 0 to avoid a reference cycle with subframes.
- page/MainFrame.h: Added new data members as mentioned above. Also, the
definition of the Frame::isMainFrame inline function goes here, since it can't
compile without the MainFrame class definition. This means that callers of
isMainFrame need to include MainFrame.h, which seems reasonable and is easy
to do.
- page/Page.cpp:
- page/Page.h: Added assertion to Page::mainFrame since it returns a reference.
Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
on the frame.
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):
(WebCore::Document::ensurePlugInsInjectedScript):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::shouldShrinkToFit):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didClearWindowObjectInWorld):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::didLayout):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::loadProgressingStatusChanged):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
- loader/icon/IconController.cpp:
(WebCore::IconController::startLoader):
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::stopAutoscrollTimer):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- page/DOMWindow.cpp:
(WebCore::allowsBeforeUnloadListeners):
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::allowedToChangeWindowGeometry):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):
- page/FrameTree.cpp:
(WebCore::FrameTree::find):
(WebCore::FrameTree::traverseNextWithWrap):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
(WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
(WebCore::FrameView::beginDeferredRepaints):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::pagination):
(WebCore::FrameView::visibleContentScaleFactor):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::paintOverhangAreas):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Use the new functions where possible instead of Page::frameIsMainFrame,
Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.
Source/WebKit/blackberry:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Call isMainFrame.
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::updateGlobalHistory):
Call isMainFrame.
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
Call isMainFrame.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canHandleRequest):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrameView.mm:
(-[WebFrameView _install]):
Call isMainFrame.
Source/WebKit2:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
Call isMainFrame.
- 9:14 AM Changeset in webkit [156606] by
-
- 3 edits8 adds in trunk
filter: drop-shadow doesnot support viewport units
https://bugs.webkit.org/show_bug.cgi?id=122053
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.
Source/WebCore:
drop-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin units.
Tests: fast/css/drop-shadow-viewport-height.html
fast/css/drop-shadow-viewport-vmax.html
fast/css/drop-shadow-viewport-vmin.html
fast/css/drop-shadow-viewport-width.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
Calculating the drop-shadow values which has been specified in viewport
units.The vh/vw units are calcultated as percent of viewport height and
viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-height.html: Added.
- fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-vmax.html: Added.
- fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-vmin.html: Added.
- fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-width.html: Added.
Added new tests for verifying that drop-shadow properties are applied
when its values are viewport units.
- 9:10 AM Changeset in webkit [156605] by
-
- 5 edits16 adds in trunk
REGRESSION (r154614): Setting the document scroll position isn't symmetric; can successfully set document.body.scrollTop, but can only read from document.documentElement.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=121876
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.
Source/WebCore:
Non-Quirks mode should set/get scrolltop/scrollleft through
document.documentElement.scrollTop/document.documentElement.scrollLeft
Quirks mode should set/get scrolltop/scrollleft through
document.body.scrollTop/document.body.scrollLeft.
Tests: fast/dom/Element/body-scrollLeft-Quirks.html
fast/dom/Element/body-scrollLeft.html
fast/dom/Element/body-scrollTop-Quirks.html
fast/dom/Element/body-scrollTop.html
fast/dom/Element/documentElement-scrollLeft-Quirks.html
fast/dom/Element/documentElement-scrollLeft.html
fast/dom/Element/documentElement-scrollTop-Quirks.html
fast/dom/Element/documentElement-scrollTop.html
- dom/Element.cpp:
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Need to set the scrollTop and scrollLeft after checking if document
is in quirks or non-quirks mode. Incase it is body.scrollLeft/
body.scrollTop set only if document is in quirks mode. If document is
non-quirks mode set documentElement.scrollLeft/documentElement.scrollTop.
LayoutTests:
- fast/dom/Element/body-scrollLeft-Quirks-expected.txt: Added.
- fast/dom/Element/body-scrollLeft-Quirks.html: Added.
- fast/dom/Element/body-scrollLeft-expected.txt: Added.
- fast/dom/Element/body-scrollLeft.html: Added.
- fast/dom/Element/body-scrollTop-Quirks-expected.txt: Added.
- fast/dom/Element/body-scrollTop-Quirks.html: Added.
- fast/dom/Element/body-scrollTop-expected.txt: Added.
- fast/dom/Element/body-scrollTop.html: Added.
- fast/dom/Element/documentElement-scrollLeft-Quirks-expected.txt: Added.
- fast/dom/Element/documentElement-scrollLeft-Quirks.html: Added.
- fast/dom/Element/documentElement-scrollLeft-expected.txt: Added.
- fast/dom/Element/documentElement-scrollLeft.html: Added.
- fast/dom/Element/documentElement-scrollTop-Quirks-expected.txt: Added.
- fast/dom/Element/documentElement-scrollTop-Quirks.html: Added.
- fast/dom/Element/documentElement-scrollTop-expected.txt: Added.
- fast/dom/Element/documentElement-scrollTop.html: Added.
Added test cases for verifying that Non-Quirks mode should set
scrolltop/scrollleft through document.documentElement.scrollTop/
document.documentElement.scrollLeft and Quirks mode should set/get
scrolltop/scrollleft through document.body.scrollTop/document.body.scrollLeft.
- fast/multicol/scrolling-overflow.html:
Rebaselining existing tests as per the new behavior. To set
document.body.scrollLeft document to be in Quirks mode.
- 8:05 AM Changeset in webkit [156604] by
-
- 7 edits in trunk/Source/WebKit2
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041
Reviewed by Andreas Kling.
In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- 8:02 AM Changeset in webkit [156603] by
-
- 5 edits in trunk/Source
Unreviewed GTK build fix after r156560.
Source/WebKit/gtk:
- WebCoreSupport/AcceleratedCompositingContext.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 7:15 AM Changeset in webkit [156602] by
-
- 25 edits in trunk/Source
Pass VM instead of ExecState to JSFunction constructors.
<https://webkit.org/b/122014>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
JSFunction doesn't need the ExecState for anything during its
construction, so reduce the amount of loads by just passing the
VM around instead.
Factored out putDirectNonIndexAccessor() from the existing
putDirectAccessor() to avoid snowballing the patch (and because
it's kinda neat to avoid the extra branch.)
JSC release binary size -= 9680 bytes.
Source/WebCore:
Updated for new JSFunction::create() signature.
- 6:27 AM Changeset in webkit [156601] by
-
- 10 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSImageValue
https://bugs.webkit.org/show_bug.cgi?id=122051
Reviewed by Andreas Kling.
Clean up static_cast<CSSImageValue*> type casts. It will help to
detect bad cast as well as improve code readability.
Removed unnecessary local variables as well.
No new tests, no behavior changes.
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
- 3:26 AM Changeset in webkit [156600] by
-
- 21 edits in trunk/Source/WebCore
WebCore fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- Modules/indexeddb/IDBIndex.cpp: Remove an unused constant.
- Modules/indexeddb/IDBObjectStore.cpp: Ditto.
- Modules/webaudio/AudioContext.cpp: Ditto.
- Modules/webaudio/ScriptProcessorNode.cpp: Ditto.
- Modules/webdatabase/SQLResultSet.cpp: Ditto.
- Modules/webdatabase/SQLTransactionBackend.cpp: Ditto.
- Modules/websockets/WebSocketHandshake.cpp: Ditto.
- bindings/objc/DOM.mm: Disable a warning about overriding a protocol method in a cateogry around the one
place we do it. I don't understand why this generates a warning, nor can I see a different approach that
would not result in the warning being emitted.
- css/CSSGrammar.y.in: #if a function that's only used inside an #if.
- html/track/TextTrackCue.cpp: Remove an unused constant.
- loader/TextResourceDecoder.cpp: Remove two unused functions.
- page/ContentSecurityPolicy.cpp: Add #if's around constants and functions that are only used when CSP_NEXT is enabled.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Reorder the ifs slightly to make the #if'ing easier.
- page/ContentSecurityPolicy.h: Add #if's around functions that are only used when CSP_NEXT is enabled.
- page/DOMSecurityPolicy.cpp: Ditto.
- page/DOMSecurityPolicy.h: Ditto.
- page/animation/CSSPropertyAnimation.cpp: Remove an unused function.
- platform/mac/DisplaySleepDisabler.cpp: Add an #if around a constant that's only used on iOS.
- platform/mac/WebCoreFullScreenWarningView.mm: Remove three unused constants.
- rendering/RenderLayer.cpp: Remove two unused constants.
- rendering/RenderLayerCompositor.cpp:
(WebCore::compositingLogEnabled): Move the #if around the function definition.
- svg/SVGAnimatedAngle.cpp: Remove an unused function.
- svg/SVGUseElement.cpp: #if a function that's only used inside an ASSERT.
- xml/XPathStep.cpp: Ditto.
- 3:25 AM Changeset in webkit [156599] by
-
- 6 edits in trunk/Source/WebKit/mac
WebKit fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- Carbon/HIWebView.mm: Remove an unused function.
- History/BinaryPropertyList.cpp: #if a constant that's only used in 64-bit.
- Misc/WebIconDatabase.mm: Remove two unused constants.
- Plugins/WebBaseNetscapePluginView.mm: Remove an unused constant.
- WebCoreSupport/WebEditorClient.mm: Ditto.
- 3:23 AM Changeset in webkit [156598] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2 fails to build with newer versions of clang.
Reviewed by Anders Carlsson.
- Shared/VisitedLinkTable.cpp: #if a function that's only used inside an ASSERT.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Remove an unused constant.
- UIProcess/mac/WKFullScreenWindowController.mm: Ditto.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Ditto.
- WebProcess/WebPage/FindController.cpp: Ditto.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: Remove two unused constants.
- 3:22 AM Changeset in webkit [156597] by
-
- 6 edits in trunk/Source/JavaScriptCore
JavaScriptCore fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- interpreter/Interpreter.cpp: Remove an unused function.
- parser/SourceProvider.cpp: Ditto.
- runtime/GCActivityCallback.cpp: #if a constant that's only used on non-CF platforms.
- runtime/JSCJSValue.cpp: Remove an unused constant.
- runtime/JSString.cpp: Ditto.
- 3:19 AM Changeset in webkit [156596] by
-
- 5 edits in trunk/Source/WTF
<rdar://problem/15079224> WTF fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- wtf/DateMath.cpp: Remove some unused constants.
- wtf/FastMalloc.cpp: #if some constants and functions that are unused in some configurations.
Remove a function that's unused on all platforms.
- wtf/TCSystemAlloc.cpp: Remove some unused constants.
(TCMalloc_SystemRelease): Remove an if whose body is never executed.
- wtf/dtoa.cpp: #if things such that storeInc is only defined when USE_LONG_LONG is undefined.
Remove an unused constant.
Sep 27, 2013:
- 10:35 PM Changeset in webkit [156595] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Restore accidentally removed ChangeLog lines.
- 9:08 PM Changeset in webkit [156594] by
-
- 11 edits in trunk/Source/JavaScriptCore
Get rid of SetMyScope/SetCallee; use normal variables for the scope and callee of inlined call frames of closures
https://bugs.webkit.org/show_bug.cgi?id=122047
Reviewed by Oliver Hunt.
Currently we have the DFG reserve space for inline call frames at exactly the same stack
offsets that you would have gotten if the baseline interpreter/JIT had made the calls.
We need to get rid of that. One of the weirder parts of this is that we have special DFG
operations for accessing these inlined call frame headers. It's really hard for any
analysis of DFG IR to see what the liveness of any of those frame header "variables" is;
the liveness behaves like flushed arguments (it's all live until end of the inlinee) but
we don't have anything like a Flush node for those special variables.
This patch gets rid of the special operations for accessing inline call frame headers.
GetMyScope and GetCallee still remain, and are only for accessing the machine call
frame's scope/callee entries. The inline call frame's scope/callee now behave like
normal variables, and have Flush behavior just like inline arguments.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:32 PM Changeset in webkit [156593] by
-
- 3 edits10 adds in trunk/LayoutTests
[CSS Shapes] New positioning model: Positive margins
https://bugs.webkit.org/show_bug.cgi?id=118089
Reviewed by Alexandru Chiculita.
The remaining tests for shape-outside with positive margins. These
have all been imported from the CSSWG's repo.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 5:11 PM Changeset in webkit [156592] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/media-controller-playback.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122042
- platform/mac/TestExpectations: Marked as such.
- 5:03 PM Changeset in webkit [156591] by
-
- 5 edits in trunk/Source
Versioning.
- 4:45 PM Changeset in webkit [156590] by
-
- 32 edits in trunk/Source/WebCore
IndexedDB IDL Refactoring.
https://bugs.webkit.org/show_bug.cgi?id=121996
Reviewed by Alexey Proskuryakov.
This includes:
1 - Leveraging EventTarget.idl inheritance
2 - Removing comments
3 - Reordering to match the spec's IDLs
4 - Removing nonstandard, WebKit-specific methods
5 - Updating interfaces to match the spec (versions are only uint64_t's now...)
6 - Updating implementation code as needed (versions are only uint64_t's now...)
IDL changes:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/indexeddb/IndexedDB.h: Add new enum to represent version nullness.
Adapt to new IDLs, and also refactor representation of initial, null versioning:
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::version):
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseCallbacks.h:
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBOpenDBRequest.h:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):
Keep leveldb building with minimal adaptations to the new IDLs,
but note that the LevelDB implementation is now incompatible with the spec:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::openInternal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendLevelDB::processPendingCalls):
(WebCore::IDBDatabaseBackendLevelDB::openConnection):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabase):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeAbortOperation::perform):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
- inspector/InspectorIndexedDBAgent.cpp: Update for metadata change.
- 4:40 PM Changeset in webkit [156589] by
-
- 2 edits in trunk/Source/WebKit2
CookieStorageShim should be PLATFORM(MAC) guarded
https://bugs.webkit.org/show_bug.cgi?id=121423
Reviewed by Darin Adler.
Original patch by Kwang Yul Seo <skyul@company100.com>.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 4:29 PM Changeset in webkit [156588] by
-
- 22 edits in trunk/Source
Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818
Reviewed by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::WebContentReader::addFragment):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readFilenames):
(WebCore::Editor::WebContentReader::readHTML):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readImage):
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/ios/PasteboardIOS.mm:
(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::count):
(WebCore::PlatformPasteboard::readBuffer):
(WebCore::PlatformPasteboard::readString):
(WebCore::PlatformPasteboard::readURL):
- platform/mac/PasteboardMac.mm:
(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
- platform/mac/PlatformPasteboardMac.mm:
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::changeCount):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::decodeSharedBuffer):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
(WebKit::WebContext::readStringFromPasteboard):
(WebKit::WebContext::readURLFromPasteboard):
(WebKit::WebContext::readBufferFromPasteboard):
(WebKit::WebContext::getPasteboardItemsCount):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::changeCount):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 4:19 PM Changeset in webkit [156587] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build fix following r156560.
- WebView.h:
- 4:17 PM Changeset in webkit [156586] by
-
- 12 edits4 adds in trunk
Crash on shape-outside when using calc()
https://bugs.webkit.org/show_bug.cgi?id=121020
Reviewed by Dirk Schulze.
Source/WebCore:
This change prevents a crash caused by specifying a CSS Shape geometry
Length attribute with a calc() expression. It adds support for converting
Lengths to CSSPrimitive Values, in large part by migrating Blink changes
made to the calc classes since the split. Doing so required a few supporting
changes in some related classes, notably CSSPrimitiveValue.
Tests: fast/shapes/shape-inside/shape-inside-calc-crash.html
css3/calc/simplification.html
- css/BasicShapeFunctions.cpp:
(WebCore::convertToCSSPrimitiveValue): Effectively use the new CSSPrimtiveValue(length,style) constructor to convert Lengths to CSSValues.
(WebCore::valueForBasicShape): Use the convertToCSSPrimitiveValue() function.
(WebCore::convertToLength): Added the CalculatedConversion convertToLength() flag to enable support for calc() valued Length Shape attributes.
- css/BasicShapeFunctions.h:
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
(WebCore::buildCssText):
(WebCore::CSSCalcValue::clampToPermittedRange):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcExpressionNode::~CSSCalcExpressionNode):
(WebCore::CSSCalcPrimitiveValue::create):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::primitiveType):
(WebCore::CSSCalcPrimitiveValue::CSSCalcPrimitiveValue):
(WebCore::determineCategory):
(WebCore::isIntegerResult):
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::createSimplified):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(WebCore::CSSCalcBinaryOperation::buildCssText):
(WebCore::CSSCalcBinaryOperation::primitiveType):
(WebCore::CSSCalcBinaryOperation::CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::getNumberSide):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcBinaryOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcValue::createExpressionNode):
(WebCore::CSSCalcValue::create):
- css/CSSCalculationValue.h:
(WebCore::CSSCalcExpressionNode::category):
(WebCore::CSSCalcValue::create):
(WebCore::CSSCalcValue::isInt):
(WebCore::CSSCalcValue::permittedValueRange):
(WebCore::CSSCalcValue::expressionNode):
(WebCore::CSSCalcValue::CSSCalcValue):
(WebCore::toCSSCalcValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Pass the style along to the new valueForBasicShape() function.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::unitCategory): Made this function public so that CSSCalculationValue could use it.
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor): Ditto.
(WebCore::CSSPrimitiveValue::primitiveType): Cleared trailing whitespace.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::CSSPrimitiveValue::init): The common part of the two Length CSSPrimitiveValue constructors.
(WebCore::CSSPrimitiveValue::computeLengthDouble): Moved the case labels to the left per check-webkit-style.
(WebCore::CSSPrimitiveValue::getStringValue): Ditto.
(WebCore::CSSPrimitiveValue::getDoubleValue): Removed trailing whitespace.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::toCSSPrimitiveValue): Check the CSSValue*'s validity with ASSERT_WITH_SECURITY_IMPLICATION before casting to CSSPrimitiveValue*.
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createValue): A new overload that delegates to the new CSSPrimitiveValue(length,style) constructor.
- platform/CalculationValue.h:
(WebCore::CalculationValue::operator==):
(WebCore::CalculationValue::isNonNegative):
(WebCore::CalculationValue::expression):
(WebCore::CalcExpressionNumber::value):
(WebCore::toCalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::length):
(WebCore::toCalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::leftSide):
(WebCore::CalcExpressionBinaryOperation::rightSide):
(WebCore::CalcExpressionBinaryOperation::getOperator):
(WebCore::toCalcExpressionBinaryOperation):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::from):
(WebCore::CalcExpressionBlendLength::to):
(WebCore::CalcExpressionBlendLength::progress):
(WebCore::toCalcExpressionBlendLength):
LayoutTests:
Specifying a CSS Shape geometry Length attribute with a calc() expression
or looking up the value with getComputedStyle(), caused crashes.
- fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Added.
- fast/shapes/shape-inside/shape-inside-calc-crash.html: Added.
- css3/calc/simplification-expected.txt: Added
- css3/calc/simplification.html: Added
- LayoutTests/css3/calc/cssom-expected.txt:
- 4:09 PM Changeset in webkit [156585] by
-
- 2 edits in trunk/LayoutTests
Layout Test animations/combo-transform-translate+scale.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122040
- platform/mac/TestExpectations: Marking as such.
- 4:05 PM Changeset in webkit [156584] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/track/track-cue-overlap-snap-to-lines-not-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122039
- platform/mac/TestExpectations: Marking as such.
- 4:01 PM Changeset in webkit [156583] by
-
- 2 edits in trunk/LayoutTests
animations/transform-non-accelerated.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122038
- platform/mac/TestExpectations: Marking as such.
- 3:34 PM Changeset in webkit [156582] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r154219): 30% more malloc memory used on html5-full-render.
<https://webkit.org/b/122034>
Reviewed by Antti Koivisto.
canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.
This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.
Fixed it by added an explicit null check of Frame::page().
- 3:24 PM Changeset in webkit [156581] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed linker symbols I broke last time.
- 3:14 PM Changeset in webkit [156580] by
-
- 22 edits in trunk/Source/WebCore
Updating bindings test results after KURL->URL rename.
Includes were now in the wrong order.
- bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
- bindings/scripts/test/CPP/WebDOMTestException.cpp:
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm:
- bindings/scripts/test/ObjC/DOMTestCallback.mm:
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm:
- bindings/scripts/test/ObjC/DOMTestEventConstructor.mm:
- bindings/scripts/test/ObjC/DOMTestEventTarget.mm:
- bindings/scripts/test/ObjC/DOMTestException.mm:
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
- 3:05 PM Changeset in webkit [156579] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
Add supporting logic for r156570.
- 3:01 PM Changeset in webkit [156578] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156569.
http://trac.webkit.org/changeset/156569
https://bugs.webkit.org/show_bug.cgi?id=122035
broke a lot of mismatch tests (Requested by thorton on
#webkit).
Tools:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
- 2:54 PM Changeset in webkit [156577] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix for Win64.
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-27
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added and fixed 64-bit linker symbols.
- 2:52 PM Changeset in webkit [156576] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/video-duration-known-after-eos.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122033
- platform/mac/TestExpectations: Marked as such.
- 2:29 PM Changeset in webkit [156575] by
-
- 2 edits in trunk/Source/WebCore
Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122029
After MediaStream cleanup commit, it was not building anymore.
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.
No new tests needed.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- 2:18 PM Changeset in webkit [156574] by
-
- 4 edits in trunk/Source/WebCore
Storing a reference to MediaStreamTrack in RTCStatsRequest
https://bugs.webkit.org/show_bug.cgi?id=122030
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.
The spec[1] says that the stats is related to a MediaStreamTrack object.
It also says: "Evaluate the need for other selectors than MediaStreamTrack".
So a MediaStreamTrack object is more suitable in this case.
[1]http://dev.w3.org/2011/webrtc/editor/webrtc.html#stats-selector
No new tests needed.
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore::RTCStatsRequestImpl::track):
- Modules/mediastream/RTCStatsRequestImpl.h:
- platform/mediastream/RTCStatsRequest.h:
- 2:15 PM Changeset in webkit [156573] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r156546): 18 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021
- platform/mac/TestExpectations: Adding one more test, media/track/track-cue-rendering-vertical.html
- 2:11 PM Changeset in webkit [156572] by
-
- 2 edits in trunk/LayoutTests
[Mac] Intermittent crash on media/video-controls-captions-trackmenu.html
https://bugs.webkit.org/show_bug.cgi?id=110173
This code got rewritten, and the test now just fails. Fixing and re-enabling it
is tracked in a different bug.
- platform/mac/TestExpectations: Removing superfluous entry which was confusing the parser.
- 1:48 PM Changeset in webkit [156571] by
-
- 2 edits in trunk/Tools
Don't retry failures on Apple MountainLion Release WK1 tester
https://bugs.webkit.org/show_bug.cgi?id=122026
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
on this bot.
- 1:47 PM Changeset in webkit [156570] by
-
- 3 edits in trunk/Tools
Don't hardcode builder specific configuration in buildbot master.cfg
https://bugs.webkit.org/show_bug.cgi?id=122023
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
property to Qt Mountain Lion Release, making it run pixel tests.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start): Use additionalArguments.
(RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
- 1:47 PM Changeset in webkit [156569] by
-
- 3 edits2 adds in trunk
[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.
Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
- 1:44 PM Changeset in webkit [156568] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/animation/request-animation-frame-time-unit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122031
- platform/mac/TestExpectations: Marking as such. Dean is going to look into
related issues soon.
- 1:25 PM Changeset in webkit [156567] by
-
- 12 edits in trunk/Source
[Nix] Updating Nix trunk files
https://bugs.webkit.org/show_bug.cgi?id=121752
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Benjamin Poulain.
Source/WebCore:
No new tests needed.
- page/nix/EventHandlerNix.cpp:
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
- platform/DragImage.h:
- platform/graphics/GraphicsContext3D.h:
- platform/nix/DragImageNix.cpp:
(WebCore::createDragImageFromImage):
- platform/nix/GamepadsNix.cpp:
(WebCore::sampleGamepads):
- platform/nix/LanguageNix.cpp:
(WebCore::platformLanguage):
- platform/nix/LocalizedStringsNix.cpp:
(WebCore::unacceptableTLSCertificate):
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::types):
- platform/nix/RenderThemeNix.cpp:
(WebCore::toColor):
(WebCore::themeEngine):
(WebCore::webCanvas):
(WebCore::getWebThemeState):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):
Source/WTF:
- wtf/nix/FeatureDefinesNix.h:
- 1:06 PM Changeset in webkit [156566] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] fix build after r156560
https://bugs.webkit.org/show_bug.cgi?id=122028
Fixing build.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-09-27
Reviewed by Anders Carlsson.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 12:22 PM Changeset in webkit [156565] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix Windows build.
- 11:49 AM Changeset in webkit [156564] by
-
- 4 edits in trunk/Source/JavaScriptCore
Deoptimize 32-bit deoptimization
https://bugs.webkit.org/show_bug.cgi?id=122025
Reviewed by Oliver Hunt.
Just simplifying a bunch of code. I don't want the old, super-complicated,
deoptimization code to get in the way of changes I'll be making to DFG stack layout.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- 11:48 AM Changeset in webkit [156563] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 11:46 AM Changeset in webkit [156562] by
-
- 1 copy in tags/Safari-537.60.3
New Tag.
- 11:41 AM Changeset in webkit [156561] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r156546): 17 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021
Unreviewed gardening; add failing tests to TestExpectations while triaging new failures.
- platform/mac/TestExpectations:
- 11:38 AM Changeset in webkit [156560] by
-
- 27 edits in trunk/Source
Use std::unique_ptr for GraphicsLayer creation
https://bugs.webkit.org/show_bug.cgi?id=122020
Reviewed by Antti Koivisto.
Source/WebCore:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayerFactory.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::createGraphicsLayer):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::hasScrollingLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
- rendering/RenderLayerCompositor.h:
Source/WebKit2:
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
- 11:36 AM Changeset in webkit [156559] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed Win64 build after r156184.
https://bugs.webkit.org/show_bug.cgi?id=121994
Reviewed by Oliver Hunt.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupTwoStubArgsGPR):
(JSC::CCallHelpers::setupTwoStubArgsFPR):
Renamed from setupTwoStubArgs.
Visual Studio x64 compiler fails to see that this is an overloaded template function.
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupArguments):
(JSC::CCallHelpers::setupArgumentsWithExecState):
Use setupTwoStubArgsGPR or setupTwoStubArgsFPR instead of setupTwoStubArgs.
- 11:34 AM Changeset in webkit [156558] by
-
- 23 edits in trunk/Source
ScrollbarPainterController should adopt the api to lock overlay scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=121928
Reviewed by Sam Weinig.
Source/WebCore:
ScrollbarPainterController should adopt the api to lock overlay scrollbar state.
This will allow the ScrollbarPainterController and ScrollAnimatorMac to have
control over knowing whether or not the scrollbars are currently active, which
will allow us to remove a bunch of functions previously implemented in
ScrollableArea subclasses to answer that question.
ScrollableArea::scrollbarsCanBeActive() is not longer virtual. It used to
implemented on ScrollableArea subclasses, but now ScrollableArea can just get the
information from the ScrollAnimator.
- WebCore.exp.in:
When ScrollableArea subclasses implemented scrollbarsCanBeActive(), they would
check to see if the document was in the page cache. Instead of that model, this
patch adopts a model where ScrollbarPainterController is told directly whether or
not it is active via shouldLockOverlayScrollbarsToHidden(bool).
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
setAnimatorsAreActive() is no longer necessary. The functionality can be bundled
into shouldLockOverlayScrollbarsToHidden(bool).
(WebCore::Document::documentDidResumeFromPageCache):
Remove implementations of scrollbarsCanBeActive(), setAnimatorsAreActive(), and
scrollbarAnimationsAreSuppressed().
- page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
- page/FrameView.h:
setShouldSuppressScrollbarAnimations(bool) now calls
setShouldLockOverlayScrollbars(bool).
- page/Page.cpp:
(WebCore::Page::setShouldSuppressScrollbarAnimations):
(WebCore::Page::setShouldLockOverlayScrollbars):
- page/Page.h:
setIsActive() is now implemented in the ScrollAnimator instead of ScrollableArea
subclasses. finishCurrentScrollAnimations() is replaced by
lockOverlayScrollbarStateToHidden(bool).
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimator::scrollbarsCanBeActive):
New enum ScrollbarOverlayState.
- platform/ScrollTypes.h:
Go to the animator for both of these functions.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollableArea::scrollbarsCanBeActive):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):
Three new pieces of ScrollbarPainterController api.
- platform/mac/NSScrollerImpDetails.h:
Instead of asking the ScrollableArea if scrollbars can be active, just find out if
the ScrollbarPaintController has been locked.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimatorMac::scrollbarsCanBeActive):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
Remove implementations of scrollbarsCanBeActive() and
scrollbarAnimationsAreSuppressed().
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
Source/WebKit2:
This function no longer needs to be implemented by ScrollablArea subclasses.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- 11:22 AM Changeset in webkit [156557] by
-
- 9 edits in trunk/Source/WebCore
Move line grid functionality from RenderBlock into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121502
Reviewed by Dean Jackson.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::establishLineGrid):
- rendering/LayoutState.h:
(WebCore::LayoutState::lineGrid):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::layoutLineGridBox):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):
- rendering/RenderBlockLineLayout.cpp:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSnapAdjustment):
- 10:52 AM Changeset in webkit [156556] by
-
- 2 edits in trunk/Source/WebCore
Re-indent Settings.h
Rubber-stamped by Anders Carlsson.
- 10:42 AM Changeset in webkit [156555] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin
https://bugs.webkit.org/show_bug.cgi?id=121121
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-27
Reviewed by Gustavo Noronha Silva.
The chromedevtools plugin (http://code.google.com/p/chromedevtools/) requires a specific
json format to connect to the webkit inspector.
The current format is missing some required fields that make the connection with the plugin
fail.
The format expected by the plugin is as follows:
{
"title": "Foo",
"url": "http://foo",
"devtoolsFrontendUrl": "/Main.html?ws=localhost:9222/devtools/page/1",
"webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"
}
The current format is missing the entries for "devtoolsFrontendUrl" and
"webSocketDebuggerUrl".
The plugin also sends an HTTP GET request to http://host:port/json instead of
http://host:port/pagelist.json when retrieving the pages list.
This patch fixes the issues by adding support for the missing fields and accepting requests
for "/json" alongside "/pagelist.json".
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
Also accept requests for "/json" alongside "pagelist.json".
(WebKit::WebInspectorServer::buildPageList):
Add fields required by chromedevtools plugin.
- 10:40 AM Changeset in webkit [156554] by
-
- 9 edits in trunk
[MediaStream API] update SourceInfo object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121941
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing test updated.
- Modules/mediastream/SourceInfo.cpp:
(WebCore::SourceInfo::kind): Get rid of "none".
- Modules/mediastream/SourceInfo.h:
(WebCore::SourceInfo::sourceId): Renamed from "id".
- Modules/mediastream/SourceInfo.idl:
- platform/mediastream/MediaStreamTrackSourcesRequestClient.h:
(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): "facing" isn't a part of sourceInfo.
Return a non-NULL ID because a source must always have one.
LayoutTests:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt:
- fast/mediastream/MediaStreamTrack-getSources.html:
- 10:26 AM Changeset in webkit [156553] by
-
- 9 edits in trunk
Provide 2D Matrix decomposition for animation
https://bugs.webkit.org/show_bug.cgi?id=112824
<rdar://problem/15091882>
Reviewed by Eric Carlson (and Ian Henderson offline).
Source/WebCore:
Implement a new 2d matrix blend, which is triggered
when animating between two affine 3d matrices. This
is intended to be the official algorithm that gets
put into the W3C Transforms specification.
The old code is renamed with a 4 prefix (indicating
it is a blend between 3d matrices using quaternions),
and new methods and structures for 2d blending were added.
I also took the opportunity to clean up a lot of
bad WebKit style.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use 3d decomposition.
- platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::PerspectiveTransformOperation::blend): Ditto.
- platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend): Ditto.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose2): New method to decompose an affine 3d matrix
into X/Y scale + translate, a rotation angle, plus some extracted
a,b,c,d fields from the affine section.
(WebCore::decompose4): New name for the old function.
(WebCore::TransformationMatrix::blend2): Perform linear interpolation
between two 2d decompositions.
(WebCore::TransformationMatrix::blend4): New name for the old function.
(WebCore::TransformationMatrix::blend): Call blend2 or blend4 depending
on the type of matrix.
(WebCore::TransformationMatrix::decompose2): Calls into the decompose2
method above.
(WebCore::TransformationMatrix::decompose4): New name.
(WebCore::TransformationMatrix::recompose2): Recomposes a 3d matrix from
a 2d decomposition.
(WebCore::TransformationMatrix::recompose4): New name.
- platform/graphics/transforms/TransformationMatrix.h: All the changes
for the new methods above.
LayoutTests:
This test was only exercising the fact that our
software decomposition did not match our hardware
decomposition (although that required visual inspection).
Now that our 2d decomposition is correct, update the
test and its expected result.
- animations/transform-non-accelerated-expected.txt:
- animations/transform-non-accelerated.html:
- 10:24 AM Changeset in webkit [156552] by
-
- 1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
Attempt to fix windows build.
- 9:59 AM Changeset in webkit [156551] by
-
- 5 edits in trunk
[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106924
Reviewed by Chris Fleizach.
Tools:
Consider headings levels as values to be returned in intValue()
both in DRT and WKTR, so we can share more tests with other ports.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::intValue): Consider headings too.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::intValue): Ditto.
LayoutTests:
Removed accesibility/heading-level.html from failure expectations.
- platform/gtk/TestExpectations: Removed test now passing.
- 9:39 AM Changeset in webkit [156550] by
-
- 840 edits7 moves in trunk
rename KURL to URL
https://bugs.webkit.org/show_bug.cgi?id=16214
Reviewed by Andreas Kling.
Source/WebCore:
- many files: Renamed, using script.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Let the script to try to rename here.
Source/WebKit/blackberry:
- many files: Renamed, using script.
Source/WebKit/efl:
- many files: Renamed, using script.
Source/WebKit/gtk:
- many files: Renamed, using script.
Source/WebKit/mac:
- many files: Renamed, using script.
Source/WebKit/qt:
- many files: Renamed, using script.
Source/WebKit/win:
- many files: Renamed, using script.
Source/WebKit/wince:
- many files: Renamed, using script.
Source/WebKit2:
- many files: Renamed, using script.
Tools:
- many files: Renamed, using script.
- 9:37 AM Changeset in webkit [156549] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt alignment problem on ARM in debug mode
https://bugs.webkit.org/show_bug.cgi?id=122012
Reviewed by Michael Saboff.
Force GCC to put the LLInt code to .text section.
- llint/LowLevelInterpreter.cpp:
- 9:34 AM Changeset in webkit [156548] by
-
- 2 edits in trunk/Tools
Fix Python scripts test failures.
- Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests now, not by the checker itself.
- 9:12 AM Changeset in webkit [156547] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused method parameters from TupleCoder.
https://bugs.webkit.org/show_bug.cgi?id=122009
Reviewed by Anders Carlsson.
In case of TupleCoder<0, Elements...> the parameter
names for encoder, decoder and tuple are not used.
By removing the paramter names the unusued paramter
warning will disappear.
- Platform/CoreIPC/Arguments.h:
- 9:05 AM Changeset in webkit [156546] by
-
- 45 edits8 adds2 deletes in trunk
[Mac] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=120895
Reviewed by Dean Jackson.
Source/JavaScriptCore:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Re-implement the existing MediaControls constellation of classes in JavaScript
and CSS. This will allow different ports to configure their controls without
dependencies on the layout requirements of any other port's controls.
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT:
- Configurations/FeatureDefines.xcconfig:
Add new source files to the project:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Add a new class MediaControlsHost which the script controls can use to
communicate with the HTMLMediaElement without exposing private interfaces
to web facing scripts:
- Modules/mediacontrols/MediaControlsHost.cpp: Added.
(WebCore::MediaControlsHost::automaticKeyword): Static method.
(WebCore::MediaControlsHost::forcedOnlyKeyword): Ditto.
(WebCore::MediaControlsHost::alwaysOnKeyword): Ditto.
(WebCore::MediaControlsHost::create): Simple factory.
(WebCore::MediaControlsHost::MediaControlsHost): Simple constructor.
(WebCore::MediaControlsHost::~MediaControlsHost): Simple destructor.
(WebCore::MediaControlsHost::sortedTrackListForMenu): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::displayNameForTrack): Ditto.
(WebCore::MediaControlsHost::captionMenuOffItem): Pass through to TextTrack.
(WebCore::MediaControlsHost::captionMenuAutomaticItem): Ditto.
(WebCore::MediaControlsHost::captionDisplayMode): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::setSelectedTextTrack): Pass through to HTMLMediaElement.
(WebCore::MediaControlsHost::textTrackContainer): Lazily create a MediaControlTextTrackContainerElement.
(WebCore::MediaControlsHost::updateTextTrackContainer): Pass through to MediaControlTextTrackContainerElement.
- Modules/mediacontrols/MediaControlsHost.h: Added.
- Modules/mediacontrols/MediaControlsHost.idl: Added.
- Modules/mediacontrols/mediaControlsApple.css: Added.
Add convenience methods for adding a MediaControlsHost to a VM.
- bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
Add the new controller .js implementation:
- Modules/mediacontrols/mediaControlsApple.js: Added.
(createControls): Global method to create a new Controller object.
(Controller): Constructor. Create and configure the default set of controls.
(Controller.prototype.addListeners): Adds event listeners to the this.video object.
(Controller.prototype.removeListeners): Removes listeners from same.
(Controller.prototype.handleEvent): Makes Controller an EventHandler, making registration and
deregistration simpler.
(Controller.prototype.createBase): Creates the base controls object and the text track container.
(Controller.prototype.createControls): Creates the controls panel object and controller UI.
(Controller.prototype.setControlsType): Switches between Full Screen and Inline style of controller.
(Controller.prototype.disconnectControls): Disconnects all UI elements from the DOM.
(Controller.prototype.configureInlineControls): Configures existing controls for Inline mode.
(Controller.prototype.configureFullScreenControls): Ditto, for Full Screen Mode.
Add listeners for HTMLMediaElement events:
(Controller.prototype.onloadstart): Update the status display.
(Controller.prototype.onerror): Ditto.
(Controller.prototype.onabort): Ditto.
(Controller.prototype.onsuspend): Ditto.
(Controller.prototype.onprogress): Ditto.
(Controller.prototype.onstalled): Ditto.
(Controller.prototype.onwaiting): Ditto.
(Controller.prototype.onreadystatechange): Ditto.
(Controller.prototype.ontimeupdate): Update the timeline and time displays.
(Controller.prototype.ondurationchange): Ditto.
(Controller.prototype.onplaying): Update the play button.
(Controller.prototype.onplay): Ditto.
(Controller.prototype.onpause): Ditto.
(Controller.prototype.onratechange): Ditto.
(Controller.prototype.onvolumechange): Update the volume and mute UI.
(Controller.prototype.ontexttrackchange): Update the text track container and captions button.
(Controller.prototype.ontexttrackadd): Ditto.
(Controller.prototype.ontexttrackremove): Ditto.
(Controller.prototype.ontexttrackcuechange): Ditto.
(Controller.prototype.onfullscreenchange): Reconfigure the controls.
Add listeners for UI element events:
(Controller.prototype.onwrappermousemove): Show the controls and start the hide timer.
(Controller.prototype.onwrappermouseout): Hide the controls and stop the hide timer.
(Controller.prototype.onrewindbuttonclicked): Rewind.
(Controller.prototype.onplaybuttonclicked): Toggle pause.
(Controller.prototype.ontimelinechange): Update the currentTime.
(Controller.prototype.ontimelinedown):
(Controller.prototype.ontimelineup):
(Controller.prototype.ontimelinemouseover): Show the thumbnail view if available.
(Controller.prototype.ontimelinemouseout): Hide same.
(Controller.prototype.ontimelinemousemove): Move the thumbnail view.
(Controller.prototype.onmutebuttonclicked): Mute audio.
(Controller.prototype.onminbuttonclicked): Increase volume to max.
(Controller.prototype.onmaxbuttonclicked): Decrease volume to min.
(Controller.prototype.onvolumesliderchange): Update the current volume.
(Controller.prototype.oncaptionbuttonclicked): Show or hide the track menu.
(Controller.prototype.onfullscreenbuttonclicked): Enter or exit fullscreen.
(Controller.prototype.oncontrolschange): Show or hide the controls panel.
(Controller.prototype.onseekbackmousedown): Start seeking and enable the seek timer.
(Controller.prototype.onseekbackmouseup): Stop seeking and disable the seek timer.
(Controller.prototype.onseekforwardmousedown): Start seekind and enable the seek timer.
(Controller.prototype.onseekforwardmouseup): Stop seekind and disable the seek timer.
Add action methods (which are mostly self explanatory):
(Controller.prototype.updateDuration):
(Controller.prototype.updatePlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.removeControls):
(Controller.prototype.addControls):
(Controller.prototype.updateTime):
(Controller.prototype.updateReadyState):
(Controller.prototype.setStatusHidden):
(Controller.prototype.updateThumbnailTrack):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.updateCaptionContainer):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.captionItemSelected):
(Controller.prototype.destroyCaptionMenu):
(Controller.prototype.updateVolume):
Add utility methods:
(Controller.prototype.isFullScreen):
(Controller.prototype.canPlay):
(Controller.prototype.nextRate):
(Controller.prototype.seekBackFaster):
(Controller.prototype.seekForwardFaster):
(Controller.prototype.formatTime):
(Controller.prototype.trackHasThumbnails):
Add the stylesheet for the javascript controls (which are mostly) copied from
the (deleted) mediaControlsQuickTime.css and fullscreenQuickTime.css files:
- Modules/mediacontrols/mediaControlsApple.css: Added.
- css/fullscreenQuickTime.css: Removed.
- css/mediaControlsQuickTime.css: Removed.
Inject new stylesheets into UA sheets:
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
Use the new javascript controls rather than MediaControls:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer): Use the javascript controls if available.
(WebCore::HTMLMediaElement::updateTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.
(WebCore::HTMLMediaElement::createMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::ensureIsolatedWorld): Create a new VM for the controls script.
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Inject the media controls script into the VM.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Inject the MediaControlsHost into the VM and call
the scripts global factory function.
- html/HTMLMediaElement.h:
Remove most of the drawing code from RenderThemeMac and RenderThemeWin and
add accessors for the new .js and .css file data:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsStyleSheet): Empty virtual method.
(WebCore::RenderTheme::mediaControlsScript): Ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsStyleSheet): Add accessor for mediaControlsApple.css.
(WebCore::RenderThemeMac::mediaControlsScript): Add accessor for mediaControlsApple.js.
(WebCore::RenderThemeMac::adjustSliderThumbSize): Remove the call to adjustMediaSliderThumbSize.
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::mediaControlsStyleSheet):
(WebCore::RenderThemeWin::mediaControlsScript):
- rendering/RenderThemeWin.h:
Source/WebKit/mac:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- wtf/FeatureDefines.h:
LayoutTests:
Rebaseline changed tests and add new (failing) tests to
TestExpectations.
- media/audio-delete-while-slider-thumb-clicked.html:
- platform/mac/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.png:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/fullscreen/video-controls-override-expected.txt: Added.
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.png:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.png:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.png:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.png:
- platform/mac/media/controls-without-preload-expected.txt:
- platform/mac/media/media-controls-clone-expected.png:
- platform/mac/media/media-controls-clone-expected.txt:
- webarchive/loading/video-in-webarchive-expected.txt:
- 8:55 AM Changeset in webkit [156545] by
-
- 7 edits2 adds in trunk
[css-shapes] Shapes are not resolved the same way in shape-inside and clip-path
https://bugs.webkit.org/show_bug.cgi?id=121922
Reviewed by Andreas Kling.
Source/WebCore:
Fix computation of a percentage radius for circle shape-outside to
match the CSS Shapes spec.
Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
LayoutTests:
Add new test for circular shape-outside with percentage radius.
Update the nested container with unresolved height test because with a
circle it isn't really testing just for unresolved height behavior.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html:
- fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:
- 8:34 AM Changeset in webkit [156544] by
-
- 2 edits in trunk/LayoutTests
Unrehued mac-lion rebaseline.
- platform/mac-lion/js/dom/global-constructors-attributes-expected.txt:
- 8:09 AM Changeset in webkit [156543] by
-
- 119 edits2 adds in trunk
Add empty MainFrame class
https://bugs.webkit.org/show_bug.cgi?id=121770
Reviewed by Andreas Kling.
Source/WebCore:
For now, MainFrame simply derives from Frame and adds nothing.
Next, we will make each Frame point back to its MainFrame.
- CMakeLists.txt: Added MainFrame.cpp/h.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.exp.in: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/Frame.cpp:
(WebCore::Frame::Frame): Use references instead of pointers for constructor.
(WebCore::Frame::create): Pass references instead of pointers to constructor.
- page/Frame.h: Made constructor protected instead of private, and marked
destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.
- page/MainFrame.cpp: Added.
- page/MainFrame.h: Added.
- page/Page.cpp:
(WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
(WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
(WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
(WebCore::Page::checkSubframeCountConsistency): Ditto.
- page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to
be a RefPtr<MainFrame>.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- bindings/js/PageScriptDebugServer.cpp:
- bindings/js/ScriptProfiler.cpp:
- bindings/js/ScriptState.cpp:
- css/MediaQueryEvaluator.cpp:
- dom/Document.cpp:
- history/CachedFrame.cpp:
- history/CachedPage.cpp:
- history/PageCache.cpp:
- html/HTMLPlugInImageElement.cpp:
- inspector/InspectorAgent.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorClient.cpp:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInputAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- loader/FrameLoader.cpp:
- loader/HistoryController.cpp:
- loader/archive/mhtml/MHTMLArchive.cpp:
- page/AutoscrollController.cpp:
- page/Chrome.cpp:
- page/ContextMenuController.cpp:
- page/DOMWindow.cpp:
- page/DragController.cpp:
- page/EventHandler.cpp:
- page/FocusController.cpp:
- page/FrameTree.cpp:
- page/FrameView.cpp:
- page/GestureTapHighlighter.cpp:
- page/PageGroup.cpp:
- page/PageGroupLoadDeferrer.cpp:
- page/PageSerializer.cpp:
- page/PageThrottler.cpp:
- page/Settings.cpp:
- page/SpatialNavigation.cpp:
- page/mac/DragControllerMac.mm:
- page/mac/PageMac.cpp:
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
- plugins/DOMMimeType.cpp:
- storage/StorageEventDispatcher.cpp:
- svg/graphics/SVGImage.cpp:
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/efl:
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
- WebCoreSupport/InspectorClientEfl.cpp:
- ewk/ewk_view.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/gtk:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/GtkAdjustmentWatcher.cpp:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebview.cpp:
- webkit/webkitviewportattributes.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebCoreSupport/WebPlatformStrategies.mm:
- WebView/WebFrame.mm:
- WebView/WebHTMLView.mm:
- WebView/WebView.mm:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/qt:
- Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
- Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/win:
- win/WebCoreSupport/WebDragClient.cpp:
- win/WebCoreSupport/WebContextMenuClient.cpp:
- win/WebDropSource.cpp:
- win/WebFrame.cpp:
- win/WebView.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit2:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Storage/StorageAreaMap.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/PageOverlay.cpp:
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
Include MainFrame.h instead of Frame.h as needed.
- 7:31 AM Changeset in webkit [156542] by
-
- 10 edits in trunk/Source/WebCore
Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776
Reviewed by Andreas Kling.
CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.
No new tests, no behavior change.
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
(WebCore::toWebKitCSSArrayFunctionValue):
- css/WebKitCSSFilterValue.h:
(WebCore::toWebKitCSSFilterValue):
- css/WebKitCSSMatFunctionValue.h:
(WebCore::toWebKitCSSMatFunctionValue):
- css/WebKitCSSMixFunctionValue.h:
(WebCore::toWebKitCSSMixFunctionValue):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 6:48 AM Changeset in webkit [156541] by
-
- 4 edits in trunk
[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-27
Reviewed by Mario Sanchez Prada.
Tools:
Fixed an issue in AccessibilityNotificationHandler where the destructor
was not disconnecting accessibility event callbacks if logging was on.
The decision of disconnecting events can solely rely on the existence of
notification handlers because logging uses the global notification
handler.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
disconnection when logging is on.
LayoutTests:
Removed some accessibility tests from the expectations file that were
failing before this fix.
- platform/gtk-wk2/TestExpectations:
- 6:40 AM Changeset in webkit [156540] by
-
- 7 edits in trunk/Source
Pass VM instead of ExecState to JSDateMath functions.
<https://webkit.org/b/121997>
Reviewed by Geoffrey Garen.
The JSC date math functions only need the VM, so pass that from
callers instead of the whole ExecState.
- 6:31 AM Changeset in webkit [156539] by
-
- 3 edits in trunk/LayoutTests
[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
https://bugs.webkit.org/show_bug.cgi?id=121831
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-27
- platform/efl-wk2/TestExpectations:
- platform/efl/editing/selection/fake-doubleclick-expected.txt:
- 6:01 AM Changeset in webkit [156538] by
-
- 2 edits2 adds1 delete in trunk/Tools
Add general CMakeLists.txt for DRT
https://bugs.webkit.org/show_bug.cgi?id=119268
Reviewed by Gyuyoung Kim.
The new file allows better sharing between ports.
- CMakeLists.txt:
- DumpRenderTree/CMakeLists.txt: Added.
- DumpRenderTree/PlatformEfl.cmake: Added.
- DumpRenderTree/efl/CMakeLists.txt: Removed.
- 5:58 AM Changeset in webkit [156537] by
-
- 1 copy in releases/WebKitGTK/webkit-2.2.0
Tagging the WebKitGTK+ 2.2.0 release
- 5:47 AM Changeset in webkit [156536] by
-
- 5 edits2 adds in trunk
Unexpected word wrapping for wrapped content then raw content.
https://bugs.webkit.org/show_bug.cgi?id=121130
Reviewed by Darin Adler.
When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
This patch introduces a map to keep track of the uncommitted widths.
Source/WebCore:
Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html
- rendering/LineWidth.cpp:
(WebCore::LineWidth::uncommittedWidthForObject):
(WebCore::LineWidth::addUncommittedWidth):
- rendering/LineWidth.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
- 5:16 AM Changeset in webkit [156535] by
-
- 6 edits in trunk
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961
Reviewed by Csaba Osztrogonác.
Source/WebKit/qt:
- WebCoreSupport/QWebFrameAdapter.h:
Source/WebKit2:
Do not add strict ordering for webkit2qml. It is not needed and causes
Target.pri to be built out of order.
- WebKit2.pro:
Tools:
Reenable force_static_libs_as_shared when building WebKit2.
- qmake/mkspecs/features/default_post.prf:
- 4:57 AM Changeset in webkit [156534] by
-
- 3 edits in trunk/Tools
[Qt] Mock implementations of positioning and orientation not used
https://bugs.webkit.org/show_bug.cgi?id=121956
Reviewed by Csaba Osztrogonác.
Move production_build checks to sanitizeFeatures where its value is actually known.
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/features.pri:
- 3:40 AM Changeset in webkit [156533] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.2.0 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 2:44 AM Changeset in webkit [156532] by
-
- 23 edits2 adds in trunk
[ATK] Protect entry points in the ATK wrapper against outdated render trees
https://bugs.webkit.org/show_bug.cgi?id=121558
Reviewed by Chris Fleizach.
Source/WebCore:
Make sure that we protect every entry point in the ATK wrapper
against outdated render trees, before using the WebCore's
accessibility API, since that might lead to problems (and crashes)
if the render and accessibility trees are not stable.
Thus, call AccessibilityObject::updateBackingStore() in those
entry points and check whether the ATK wrapper is detached or not
after that, to decide whether to continue or not.
Besides providing a new test to check that it WebKit does not
crash in a given scenario (which actually triggered the
investigation here), solving this situation also fixes other tests
that were previously failing (aria-used-on-image-maps.html) or
that were printing wrong results, not detected until now due to
wrong platform specific expectations (file-upload-button-stringvalue
and deleting-iframe-destroys-axcache).
Test: accessibility/heading-crash-after-hidden.html
- accessibility/atk/WebKitAccessibleUtil.h: Added two new macros
to inject the needed code at the beginning of each entry point to
allow gracefully exit those functions when the render tree is
unstable. Inspired by g_return_if_fail and g_return_val_if_fail, we
called them returnIfWebKitAccessibleIsInvalid and returnValIfWebKitAccessibleIsInvalid.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(webkitAccessibleHyperlinkActionDoAction): Protect entry point.
(webkitAccessibleHyperlinkActionGetNActions): Ditto.
(webkitAccessibleHyperlinkActionGetDescription): Ditto.
(webkitAccessibleHyperlinkActionGetKeybinding): Ditto.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Ditto.
(webkitAccessibleHyperlinkGetObject): Ditto.
(webkitAccessibleHyperlinkGetStartIndex): Ditto.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
(webkitAccessibleHyperlinkIsValid): Ditto.
(webkitAccessibleHyperlinkGetNAnchors): Ditto.
(webkitAccessibleHyperlinkIsSelectedLink): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionDoAction): Ditto.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentRefAccessibleAtPoint): Ditto.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentGetAttributeValue): Ditto.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextSetRunAttributes): Ditto.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink): Ditto.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition): Ditto.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionAddSelection): Ditto.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): Ditto.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue): Ditto.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(core): Removed, as it's not actually needed.
(webkitAccessibleGetName): Protect entry point.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleGetParent): Ditto.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Ditto.
(webkitAccessibleGetRole): Ditto.
(webkitAccessibleRefStateSet): Ditto.
(webkitAccessibleRefRelationSet): Ditto.
(webkitAccessibleGetObjectLocale): Ditto.
(webkitAccessibleDetach): Ditto.
(webkitAccessibleIsDetached): New helper function, to be used from
the newly added macros. We need to check whether the wrapper is
detached and not just the wrapper AccessibilityObject since once
the detachment happens we can't trust anything but the AtkObject
from the wrapper (the AccessibilityObject might be invalid).
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
Assert that the render tree is neither being updated nor in need
of being updated before trying to compute the text under a given
element, since that might lead to crashes due to the constructor
of TextIterator calling updateLayoutIgnorePendingStylesheets().
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement): Assert that
the render tree is neither being updated nor needing updating.
LayoutTests:
Added a new test to check that we do not crash in certain
scenarios when hiding objects and retriving accessibility
information about it.
- accessibility/heading-crash-after-hidden-expected.txt: Added.
- accessibility/heading-crash-after-hidden.html: Added.
Rebaselined expectations that were wrong before, since they were
not returning the actual value that they should be returning when
called AccessibilityUIElement::stringValue().
- platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:
Updated, since the actual text being returned should be the actual
value of the file chooser (e.g. "(None)") and not the text in the
upload botton (e.g. "Choose files").
- platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
- platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto..
- platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:
Updated, since the iframe should be exposed at all after deleting it.
Removed accesibility test now passing after fixing this issue.
- platform/gtk/TestExpectations: Removed accessibility/aria-used-on-image-maps.html.
- 2:07 AM Changeset in webkit [156531] by
-
- 3 edits in trunk/Tools
[ATK] Normalize checks in entry points for DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=121959
Reviewed by Chris Fleizach.
Always check if we have a proper instance of AtkObject,
implementing the interfaces that we might need for each case, at
the entry point of every method of AccessibilityUIElement for ATK,
and do those checks in an uniform way across DRT and WKTR, to
avoid confusion and issues when modifying these files in the future.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::getChildren): Use normalized checks.
(AccessibilityUIElement::getChildrenWithRange): Ditto.
(AccessibilityUIElement::rowCount): Ditto.
(AccessibilityUIElement::columnCount): Ditto.
(AccessibilityUIElement::childrenCount): Ditto.
(AccessibilityUIElement::elementAtPoint): Ditto.
(AccessibilityUIElement::getChildAtIndex): Ditto.
(AccessibilityUIElement::allAttributes): Ditto.
(AccessibilityUIElement::titleUIElement): Ditto.
(AccessibilityUIElement::parentElement): Ditto.
(AccessibilityUIElement::attributesOfChildren): Ditto.
(AccessibilityUIElement::role): Ditto.
(AccessibilityUIElement::title): Ditto.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::stringValue): Ditto.
(AccessibilityUIElement::language): Ditto.
(AccessibilityUIElement::x): Ditto.
(AccessibilityUIElement::y): Ditto.
(AccessibilityUIElement::width): Ditto.
(AccessibilityUIElement::height): Ditto.
(AccessibilityUIElement::orientation): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(indexRangeInTable): Ditto.
(AccessibilityUIElement::cellForColumnAndRow): Ditto.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::press): Ditto.
(AccessibilityUIElement::documentEncoding): Ditto.
(AccessibilityUIElement::documentURI): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::indexRangeInTable): Use normalized checks.
(WTR::alterCurrentValue): Ditto.
(WTR::AccessibilityUIElement::getChildren): Ditto.
(WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
(WTR::AccessibilityUIElement::childrenCount): Ditto.
(WTR::AccessibilityUIElement::elementAtPoint): Ditto.
(WTR::AccessibilityUIElement::indexOfChild): Ditto.
(WTR::AccessibilityUIElement::childAtIndex): Ditto.
(WTR::AccessibilityUIElement::titleUIElement): Ditto.
(WTR::AccessibilityUIElement::parentElement): Ditto.
(WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
(WTR::AccessibilityUIElement::allAttributes): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::role): Ditto.
(WTR::AccessibilityUIElement::title): Ditto.
(WTR::AccessibilityUIElement::description): Ditto.
(WTR::AccessibilityUIElement::orientation): Ditto.
(WTR::AccessibilityUIElement::stringValue): Ditto.
(WTR::AccessibilityUIElement::language): Ditto.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
(WTR::AccessibilityUIElement::rowCount): Ditto.
(WTR::AccessibilityUIElement::columnCount): Ditto.
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
(WTR::AccessibilityUIElement::press): Ditto.
(WTR::AccessibilityUIElement::documentEncoding): Ditto.
(WTR::AccessibilityUIElement::documentURI): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
- 1:58 AM Changeset in webkit [156530] by
-
- 5 edits in trunk
[ATK] accessibility/aria-sort.html is failing after r156409
https://bugs.webkit.org/show_bug.cgi?id=121947
Reviewed by Chris Fleizach.
Source/WebCore:
The WAI-ARIA spec says to translate the value as is from the
attribute, so do just that instead of mapping values from the
AccessibilitySortDirection enumeration into strings.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.
Tools:
Implement AccessibilityUIElement::isSupported for the ATK
platforms, just by checking whether we have an associated object
attribute exposed for the wrapper object matching the required
attribute in the layout test (e.g "AXSortDirection" -> "sort").
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isAttributeSupported): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
- 1:47 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [156529] by
-
- 2 edits in trunk/Source/WTF
[GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=121999
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-27
Reviewed by Benjamin Poulain.
- wtf/StdLibExtras.h:
Sep 26, 2013:
- 8:26 PM Changeset in webkit [156528] by
-
- 3 edits in trunk/Source/WebCore
Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
https://bugs.webkit.org/show_bug.cgi?id=121886
Reviewed by Darin Adler.
toWebKitCSSShaderValue() behavior is different from other to CSSFooValue().
It shouldn't return null. The type checking should be done before doing type cast.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- 7:02 PM Changeset in webkit [156527] by
-
- 32 edits in trunk
Move m_style to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121936
Source/WebCore:
Reviewed by Andreas Kling.
Text renderers always have the same style as their parent. They can get their style via the parent pointer
rather than having a member of their own.
This shrinks RenderText by a pointer.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
Text renderers have no independent style. No need to set it.
- editing/ApplyBlockElementCommand.cpp:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
Avoid getting style from text child before it is added to tree.
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::setText):
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
Don't set text style anymore.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::setStyle):
Notify child text renderers of style change.
(WebCore::RenderElement::setAnimatableStyle):
(WebCore::RenderElement::setPseudoStyle):
Push down to RenderElement, remove text branches.
(WebCore::RenderElement::addChild):
Notify text renderers of style change when added to tree.
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
- rendering/RenderElement.h:
(WebCore::RenderElement::style):
(WebCore::RenderElement::setStyleInternal):
Move m_style from RenderObject.
(WebCore::RenderObject::style):
Inline this in RenderElement.h instead of making it virtual.
- rendering/RenderInline.cpp:
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):
Tighten typing to call RenderElement::setStyle.
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Change assert. This can get legitimately called during layout for the first letter renderers.
This was previously avoided by luck.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):
Don't set text style anymore.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::hasEntirelyFixedBackground):
(WebCore::RenderObject::container):
(WebCore::RenderObject::cachedFirstLineStyle):
Switch to style(), avoid unnecessary repetition.
Move code out.
- rendering/RenderObject.h:
Move functions to RenderElement.
(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):
Avoid accessing style for text renderers as these are called before the renderer
is added to tree.
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::setObjectStyleInRegion):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::updateCancelButtonVisibility):
- rendering/RenderText.cpp:
- rendering/RenderText.h:
Remove setStyle.
(WebCore::RenderText::style):
Get style from parent.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/style/ContentData.cpp:
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):
Pseudo style for RenderText subclasses comes from parent without any explicit setting.
- style/StyleResolveTree.cpp:
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::resolveLocal):
(WebCore::Style::updateTextStyle):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):
No need to set or update text renderer style separately.
LayoutTests:
Reviewed by Andreas Kling.
Progressions from text style updating correctly in all cases.
- compositing/contents-opaque/hidden-with-visible-text-expected.txt:
- compositing/contents-opaque/visibility-hidden-expected.txt:
Can't figure out why these progress but they do. The new rendering (showing nothing)
is correct and matches Firefox.
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/mac/svg/custom/getTransformToElement-expected.txt:
- platform/mac/svg/custom/text-ctm-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- platform/mac/svg/text/append-text-node-to-tspan-expected.txt:
- 6:58 PM Changeset in webkit [156526] by
-
- 2 edits in trunk/Source/WTF
"Build fix".
We can't use std::move. Explicitly destroy the old value and then construct the new in place.
- wtf/HashTable.h:
- 6:56 PM Changeset in webkit [156525] by
-
- 5 edits in trunk
Fixed a version number string in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122004
Reviewed by Gavin Barraclough.
PerformanceTests/SunSpider:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html: 1.0.2!
Websites/webkit.org:
- perf/sunspider-1.0.2/sunspider-1.0.2/results.html: 1.0.2!
- 6:51 PM Changeset in webkit [156524] by
-
- 2 edits in trunk/Source/WTF
Use the move assignment operator when reinserting values in the hash map
https://bugs.webkit.org/show_bug.cgi?id=122003
Reviewed by Alexey Proskuryakov.
Using the move assignment operator ensures that the existing values will be destroyed correctly.
- wtf/HashTable.h:
- 6:46 PM Changeset in webkit [156523] by
-
- 4 edits39 adds in trunk
Tentative SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122002
Reviewed by Gavin Barraclough.
PerformanceTests/SunSpider:
Be even more aggressive about asking for zero delay between tests by
setting a timeout at the beginning of a test instead of the end. This is
another step toward reducing noise -- particularly noise caused by
power management -- just like the step down from 10ms to 0ms.
Browsers typically put a 4ms floor on timers. The sooner we set
our timer, the sooner it will fire.
- make-hosted:
- resources/driver-TEMPLATE.html: Changed the driver to set the timeout
earlier.
- tests/sunspider-1.0.2: Added. These tests are unchanged from 1.0.1.
Websites/webkit.org:
See comments in PerformanceTests/SunSpider.
- perf/sunspider-1.0.2: Added.
- 6:08 PM Changeset in webkit [156522] by
-
- 29 edits4 adds in trunk
[MediaStream] make MediaStream testable
https://bugs.webkit.org/show_bug.cgi?id=121967
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing tests updated.
- CMakeLists.txt: Add MockMediaStreamCenter.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/MediaStreamTrack.idl: Add SkipVTableValidation.
- Modules/mediastream/NavigatorUserMediaError.idl: Add JSGenerateToJSObject.
- WebCore.exp.in: Export MockMediaStreamCenter::registerMockMediaStreamCenter.
- WebCore.xcodeproj/project.pbxproj: Add MockMediaStreamCenter.
- dom/DOMError.h: Make the destructor virtual because it has a derived class.
- dom/DOMError.idl:
- platform/mock/MockMediaStreamCenter.cpp: Added.
- platform/mock/MockMediaStreamCenter.h: Added.
- testing/Internals.cpp: Register the mock stream center.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Add WebUserMediaClient.
Source/WebKit/mac:
- WebCoreSupport/WebUserMediaClient.h: Added.
- WebCoreSupport/WebUserMediaClient.mm: Added.
- WebView/WebUIDelegatePrivate.h: Declare decidePolicyForUserMediaRequestFromOrigin:listener:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Register WebUserMediaClient.
(-[WebView _setUserMediaClient:]): New.
(-[WebView _userMediaClient]): New.
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
Tools:
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
user media request policy delegate.
LayoutTests:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html: Make the test results more understandable
to simplify debugging failures.
- fast/mediastream/MediaStream-onended-expected.txt:
- fast/mediastream/MediaStream-onended.html: Ditto. Fix a test error: stopping stream A should
not stop stream B even when it was created from stream A.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html: Make the test results more understandable. Fix a
logic errors: webkitMediaStream is an object, not a function. JSC does not support
object.constructor.name, use object.constructor.toString() instead.
- fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
- fast/mediastream/MediaStreamTrackEvent-constructor.html: Update now that getUserMedia() works.
- fast/mediastream/argument-types-expected.txt: Updated with "Failing" results because the correct
behavior is unknown. The spec says "the syntax for getUserMedia() is still under discussion".
- 5:39 PM Changeset in webkit [156521] by
-
- 8 edits in trunk/Source/JavaScriptCore
GetterSetter construction should take a VM instead of ExecState.
<https://webkit.org/b/121993>
Reviewed by Sam Weinig.
Pass VM& instead of ExecState* to GetterSetter. Updated surrounding
code at touched sites to cache VM in a local for fewer loads.
JSC release binary size -= 4120 bytes.
- 5:27 PM Changeset in webkit [156520] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: dissociate old content views that are spliced from back/forward list
https://bugs.webkit.org/show_bug.cgi?id=121987
Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Timothy Hatcher.
There was a bug where old back/forward list entries were not being dissociated when
the newly-shown content view was already in the list. Instead, dissociation should be
skipped if the old list entry is not already in the list.
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
- 5:27 PM Changeset in webkit [156519] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/inspector/network/network-iframe-load-and-delete.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121998
- platform/mac/TestExpectations: Marking as such.
- 5:23 PM Changeset in webkit [156518] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make GCC happy
- 4:51 PM Changeset in webkit [156517] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed Build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing
symbol export to support tests.
- 4:37 PM Changeset in webkit [156516] by
-
- 2 edits in trunk/Source/WTF
[Windows] Work around missing C++11 features of MSVC by providing an implementation for
std::is_trivially_destructible based on the existing std::has_trivial_destructor.
Rubber-stamped by Anders Carlsson.
- wtf/StdLibExtras.h: Add implementation for is_trivially_destructable for MSVC 2010 and prior.
- 4:36 PM Changeset in webkit [156515] by
-
- 5 edits in trunk/Source/WebCore
Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
https://bugs.webkit.org/show_bug.cgi?id=121986
Reviewed by Andreas Kling.
MatchRequest is an internal type of ElementRuleCollector now, move the definition
to ElementRuleCollector.
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::MatchRequest::MatchRequest):
- css/StyleResolver.h:
- 4:32 PM Changeset in webkit [156514] by
-
- 19 edits12 adds in trunk
2013-09-25 Oliver Hunt <oliver@apple.com>
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Relanding with fix after rollout
- 4:16 PM Changeset in webkit [156513] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix after r156487.
Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- 4:00 PM Changeset in webkit [156512] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r156510.
http://trac.webkit.org/changeset/156510
https://bugs.webkit.org/show_bug.cgi?id=121989
Landed in-progress code along with build fix. (Requested by
bfulgham on #webkit).
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::writeToFile):
- platform/graphics/win/DIBPixelData.h:
- 3:53 PM Changeset in webkit [156511] by
-
- 68 edits in trunk/Source/JavaScriptCore
VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732
Reviewed by Geoffrey Garen.
This is a refactoring change. Changed VirtualRegister from an enum to a class.
Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
and the similar functions for locals to VirtualRegister class.
This is in preparation for changing the offset for the first local register from
0 to -1. This is needed since most native calling conventions have the architected
frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
pointer. Local values start below that address.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
- bytecode/MethodOfGettingAValueProfile.cpp:
- bytecode/Operands.h:
- bytecode/UnlinkedCodeBlock.cpp:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/ValueRecovery.h:
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/RegisterID.h:
- debugger/DebuggerCallFrame.cpp:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h:
- dfg/DFGArgumentPosition.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCode.cpp:
- dfg/DFGNode.h:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGRegisterBank.h:
- dfg/DFGScoreBoard.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueRecoveryOverride.h:
- dfg/DFGVariableAccessData.h:
- dfg/DFGVariableEvent.h:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- ftl/FTLExitArgumentForOperand.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExit.cpp:
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- jit/AssemblyHelpers.h:
- jit/JIT.h:
- jit/JITCall.cpp:
- jit/JITCall32_64.cpp:
- jit/JITInlines.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITPropertyAccess32_64.cpp:
- jit/JITStubs.cpp:
- llint/LLIntSlowPaths.cpp:
- profiler/ProfilerBytecodeSequence.cpp:
- runtime/CommonSlowPaths.cpp:
- runtime/JSActivation.cpp:
- 3:49 PM Changeset in webkit [156510] by
-
- 7 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix after r156487.
Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::writeToFile):
- platform/graphics/win/DIBPixelData.h:
- 3:47 PM Changeset in webkit [156509] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193
- platform/mac/TestExpectations: Marking as flaky. Dean says that such tests are
currently broken by design.
- 3:45 PM Changeset in webkit [156508] by
-
- 8 edits2 deletes in trunk/Source/WebKit2
Remove Windows code
https://bugs.webkit.org/show_bug.cgi?id=121988
Reviewed by Antti Koivisto.
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/win/ConnectionWin.cpp: Removed.
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/win/SharedMemoryWin.cpp: Removed.
- Platform/win/WorkQueueWin.cpp: Removed.
- Shared/ChildProcess.cpp:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
- WebProcess/WebProcess.cpp:
- 3:37 PM Changeset in webkit [156507] by
-
- 5 edits in trunk/Source/WTF
Remove needsDestruction from vector and hash traits
https://bugs.webkit.org/show_bug.cgi?id=121983
Reviewed by Sam Weinig.
For Vector, use std::is_trivially_destructible to determine whether to call the destructor.
For HashTable, always call the destructor; if it is trivial then no code will be generated for it and the loops will be folded away.
Removing this does break the ability to store objects with non-trivial destructors in vectors and hash maps
and have their destructors not be called when removed, but we've never used this feature in WebKit so the extra
code complexity is not worth it.
- wtf/HashTable.h:
(WTF::::deallocateTable):
- wtf/HashTraits.h:
- wtf/Vector.h:
(WTF::VectorTypeOperations::destruct):
- wtf/VectorTraits.h:
- 3:29 PM Changeset in webkit [156506] by
-
- 6 edits2 adds in trunk
Expose a setting to disable hardware accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=121978
<rdar://problem/15091284>
Reviewed by Eric Carlson.
Source/WebCore:
Expose acceleratedCompositedAnimationsEnabled
to disable CoreAnimation animations.
Test: LayoutTests/animations/transform-non-accelerated.html
- WebCore.exp.in: Export new method.
- page/Settings.in: Add new setting.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation): Don't go
to GraphicsLayer if the setting is false.
LayoutTests:
- animations/resources/animation-test-helpers.js: Add a callback
for when the tests finish. Minor cleanup.
(endTest):
(.else):
(runAnimationTest):
- animations/transform-non-accelerated.html: New test.
- animations/transform-non-accelerated-expected.txt: Result.
- 3:25 PM Changeset in webkit [156505] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore: Work around another MSVC bug.
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyObjectStructureForPrototype):
Source/WTF: Build fixes.
Fix a paste-o.
- wtf/StdLibExtras.h:
(std::make_unique):
- 3:20 PM Changeset in webkit [156504] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempt to fix the FTL build.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::atSlow):
- 3:19 PM Changeset in webkit [156503] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build after r156487.
https://bugs.webkit.org/show_bug.cgi?id=121984
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Anders Carlsson.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- 3:15 PM Changeset in webkit [156502] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebKit/win
Merged r156433. <rdar://problem/15092137>
- 3:13 PM Changeset in webkit [156501] by
-
- 5 edits in branches/safari-537.60-branch/Source
Merged r156416. <rdar://problem/15092135>
- 3:01 PM Changeset in webkit [156500] by
-
- 4 edits in trunk/Source/WebCore
Don't mutate style in RenderCombineText
https://bugs.webkit.org/show_bug.cgi?id=121979
Reviewed by Andreas Kling.
Text renderers should always have the same style as the parent.
- rendering/InlineTextBox.cpp:
(WebCore::fontToUse):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
Select the modified font for text-combine.
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::combineText):
- rendering/RenderCombineText.h:
Move the text-combine specific font style to a member of its own.
- 2:45 PM Changeset in webkit [156499] by
-
- 26 edits in trunk/Source/WebCore/bindings/scripts/test/JS
Update expected binding test results after r156498.
- 2:43 PM Changeset in webkit [156498] by
-
- 56 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to many finishCreation() functions.
<https://webkit.org/b/121975>
Reviewed by Sam Weinig.
Reduce unnecessary loads by passing the VM to object creation
functions that don't need the ExecState.
There are tons of opportunities in this area, I'm just scratching
the surface.
- 2:27 PM Changeset in webkit [156497] by
-
- 19 edits12 deletes in trunk
Unreviewed, rolling out r156464 and r156480.
http://trac.webkit.org/changeset/156464
http://trac.webkit.org/changeset/156480
https://bugs.webkit.org/show_bug.cgi?id=121981
Leaking too much and killi
ng buildbot. (Requested by xenon on
#webkit).
Source/JavaScriptCore:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
- runtime/JSONObject.h:
LayoutTests:
- js/destructuring-assignment-expected.txt: Removed.
- js/destructuring-assignment.html: Removed.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Removed.
- js/regress/destructuring-arguments-length-expected.txt: Removed.
- js/regress/destructuring-arguments-length.html: Removed.
- js/regress/destructuring-arguments.html: Removed.
- js/regress/destructuring-swap-expected.txt: Removed.
- js/regress/destructuring-swap.html: Removed.
- js/regress/script-tests/destructuring-arguments-length.js: Removed.
- js/regress/script-tests/destructuring-arguments.js: Removed.
- js/regress/script-tests/destructuring-swap.js: Removed.
- js/script-tests/destructuring-assignment.js: Removed.
- sputnik/Conformance/13_Function_Definition/S13_A5.html:
- 2:25 PM Changeset in webkit [156496] by
-
- 2 edits in trunk/Source/WTF
Remove the hash table mover
https://bugs.webkit.org/show_bug.cgi?id=121980
Reviewed by Andreas Kling.
Use std::move instead.
- wtf/HashTable.h:
- 2:07 PM Changeset in webkit [156495] by
-
- 3 edits1 copy1 add in trunk/LayoutTests
Layout Test plugins/access-after-page-destroyed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121976
Reviewed by Anders Carlsson.
Clean up the test.
- plugins/access-after-page-destroyed-2-expected.txt: Added.
- plugins/access-after-page-destroyed-2.html: Copied from LayoutTests/plugins/access-after-page-destroyed.html.
This was testing two distinct issues, the second one unfittingly piled onto the first.
Split the test in two.
- plugins/access-after-page-destroyed-expected.txt:
- plugins/access-after-page-destroyed.html:
Modernized the test with js-test scripts, added a gc() call for predictability,
changed the test to fail quickly in the flaky case.
- 1:59 PM Changeset in webkit [156494] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- 1:54 PM Changeset in webkit [156493] by
-
- 2 edits in trunk/Tools
build-webkit --inspector-frontend should copy WebInspectorUI files
https://bugs.webkit.org/show_bug.cgi?id=117851
Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Joseph Pecoraro.
Change the --inspector-frontend build option to additionally build/copy
WebInspectorUI by setting it as the only project that needs to be built.
- Scripts/build-webkit:
- 1:44 PM Changeset in webkit [156492] by
-
- 15 edits in trunk/Source
Change a couple of HashMap value types from OwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121973
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):
- API/JSClassRef.h:
- bytecode/SamplingTool.h:
- ftl/FTLAbstractHeap.h:
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::create):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::executionCounterFor):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
- runtime/JSGlobalObject.h:
Source/WTF:
- wtf/RefPtrHashMap.h:
Add a missing std::forward.
- wtf/StdLibExtras.h:
(std::make_unique):
Add more overloads.
- 1:32 PM Changeset in webkit [156491] by
-
- 4 edits2 copies in tags/Safari-538.1
Merged r156404. <rdar://problem/15081686>
- 1:27 PM Changeset in webkit [156490] by
-
- 29 edits7 copies4 deletes in trunk/Source/JavaScriptCore
Move DFG inline caching logic into jit/.
https://bugs.webkit.org/show_bug.cgi?id=121749.
Reviewed by Geoffrey Garen.
Relanding http://trac.webkit.org/changeset/156235 after rebasing to latest
revision and fixing build breakages on Windows.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Removed.
- dfg/DFGRepatch.cpp: Removed.
- dfg/DFGRepatch.h: Removed.
- dfg/DFGScratchRegisterAllocator.h: Removed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSRExitCompiler.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::writeBarrier):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Copied from Source/JavaScriptCore/jit/JITOperationWrappers.h.
- jit/JITOperations.cpp: Copied from Source/JavaScriptCore/jit/JITOperations.cpp.
(JSC::getHostCallReturnValueWithExecState):
- jit/JITOperations.h: Copied from Source/JavaScriptCore/jit/JITOperations.h.
- jit/RegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.
- jit/Repatch.cpp: Copied from Source/JavaScriptCore/jit/Repatch.cpp.
(JSC::tryBuildGetByIDList):
- jit/Repatch.h: Copied from Source/JavaScriptCore/jit/Repatch.h.
- jit/ScratchRegisterAllocator.h: Copied from Source/JavaScriptCore/jit/ScratchRegisterAllocator.h.
- jit/ThunkGenerators.cpp:
(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
- jit/ThunkGenerators.h:
- 12:48 PM Changeset in webkit [156489] by
-
- 7 edits2 deletes in trunk/Source
Remove PassWeak.h
https://bugs.webkit.org/show_bug.cgi?id=121971
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/PassWeak.h: Removed.
- heap/WeakInlines.h:
Source/WebCore:
- ForwardingHeaders/heap/PassWeak.h: Removed.
- 12:37 PM Changeset in webkit [156488] by
-
- 8 edits6 adds in trunk/Source/WebCore
[MediaStream API] implement VideoStreamTrack and AudioStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=121950
Reviewed by Dean Jackson.
No new tests, blocked by https://bugs.webkit.org/show_bug.cgi?id=121967
- CMakeLists.txt: Add new files.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/AudioStreamTrack.cpp: Added.
- Modules/mediastream/AudioStreamTrack.h: Added.
- Modules/mediastream/AudioStreamTrack.idl: Added.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Create an AudioStreamTrack or a VideoStreamTrack.
(WebCore::MediaStream::addRemoteSource): Ditto.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create): Removed.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/VideoStreamTrack.cpp: Added.
- Modules/mediastream/VideoStreamTrack.h: Added.
- Modules/mediastream/VideoStreamTrack.idl: Added.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- 12:23 PM Changeset in webkit [156487] by
-
- 19 edits in trunk/Source
Stop using PassWeak
https://bugs.webkit.org/show_bug.cgi?id=121968
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- heap/Weak.h:
Remove all knowledge of PassWeak.
(JSC::Weak::Weak):
These constructors don't need to be explicit.
- heap/WeakInlines.h:
(JSC::weakAdd):
Change Value to be an rvalue reference and use std::forward.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
Remove PassWeak.
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
Use Weak instead of PassWeak.
- runtime/SimpleTypedArrayController.cpp:
Change add and set to take Weak by value and std::move into place.
- runtime/WeakGCMap.h:
(JSC::WeakGCMap::get):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::add):
Source/WebCore:
Update for JavaScriptCore changes.
- bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::cacheWrapper):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
- bindings/js/ScriptWrappableInlines.h:
(WebCore::ScriptWrappable::setWrapper):
- bindings/js/WebCoreTypedArrayController.cpp:
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::addRuntimeObject):
Source/WebKit2:
Update for JavaScriptCore changes.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
- 12:14 PM Changeset in webkit [156486] by
-
- 2 edits in trunk/LayoutTests
fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744
Reviewed by Dan Bernstein.
- fast/css/font-face-data-uri.html: There is no need to keep retrying, we can just
wait for onload - as long as the font load starts early enough.
- 12:09 PM Changeset in webkit [156485] by
-
- 28 edits in trunk/Source
Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
https://bugs.webkit.org/show_bug.cgi?id=121934
Reviewed by Geoffrey Garen.
../WebCore:
Reduce unnecessary loads by passing the JSC::VM to object creation/access functions
that don't need the ExecState.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.h:
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::setInlineCachedWrapper):
(WebCore::createWrapper):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::image):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
- bindings/js/ScriptWrappable.h:
- bindings/js/ScriptWrappableInlines.h:
(WebCore::ScriptWrappable::setWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):
- bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::newRuntimeObject):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::newRuntimeObject):
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):
- bridge/objc/objc_instance.mm:
(ObjcInstance::newRuntimeObject):
- bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
- bridge/runtime_array.h:
(JSC::RuntimeArray::createPrototype):
- bridge/runtime_method.h:
(JSC::RuntimeMethod::createPrototype):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
- bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::create):
(JSC::Bindings::RuntimeObject::createPrototype):
../WebKit/mac:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::newRuntimeObject):
- Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::create):
- Plugins/Hosted/ProxyRuntimeObject.mm:
(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):
- 11:59 AM Changeset in webkit [156484] by
-
- 1 copy in tags/Safari-538.1
New Tag.
- 11:40 AM Changeset in webkit [156483] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Activity viewer not properly reset when reloading
https://bugs.webkit.org/show_bug.cgi?id=121958
Reviewed by Darin Adler.
Reset the resources count and accumulated size when we detect the main frame
has changed, which will work with documents where there are no resources besides
frames in which case WebInspector.Frame.Event.AllResourcesRemoved was not fired
and our counts wouldn't be reset correctly.
- UserInterface/DashboardManager.js:
(WebInspector.DashboardManager):
(WebInspector.DashboardManager.prototype._mainResourceDidChange):
- 11:31 AM Changeset in webkit [156482] by
-
- 65 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r156474.
http://trac.webkit.org/changeset/156474
https://bugs.webkit.org/show_bug.cgi?id=121966
Broke the builds. (Requested by xenon on #webkit).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::createActivation):
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isKnownNotImmediate):
(JSC::CodeBlock::setThisRegister):
(JSC::CodeBlock::thisRegister):
(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::uncheckedArgumentsRegister):
(JSC::CodeBlock::setActivationRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::uncheckedActivationRegister):
(JSC::CodeBlock::usesArguments):
(JSC::CodeBlock::isCaptured):
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::operator!):
(JSC::LazyOperandValueProfileKey::hash):
(JSC::LazyOperandValueProfileKey::operand):
(JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
(JSC::LazyOperandValueProfile::LazyOperandValueProfile):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/Operands.h:
(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
(JSC::Operands::operand):
(JSC::Operands::hasOperand):
(JSC::Operands::setOperand):
(JSC::Operands::operandForIndex):
(JSC::Operands::setOperandFirstTime):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::setThisRegister):
(JSC::UnlinkedCodeBlock::setActivationRegister):
(JSC::UnlinkedCodeBlock::setArgumentsRegister):
(JSC::UnlinkedCodeBlock::usesArguments):
(JSC::UnlinkedCodeBlock::argumentsRegister):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::globalObjectRegister):
(JSC::UnlinkedCodeBlock::thisRegister):
(JSC::UnlinkedCodeBlock::activationRegister):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):
- bytecode/VirtualRegister.h:
(WTF::printInternal):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC::BytecodeGenerator::emitGetArgumentsLength):
(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
- bytecompiler/RegisterID.h:
(JSC::RegisterID::RegisterID):
(JSC::RegisterID::setIndex):
(JSC::RegisterID::index):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::thisObject):
- dfg/DFGAbstractHeap.h:
(JSC::DFG::AbstractHeap::Payload::Payload):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):
- dfg/DFGArgumentPosition.h:
(JSC::DFG::ArgumentPosition::dump):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
(JSC::DFG::FlushLivenessAnalysisPhase::setForNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(JSC::DFG::Graph::valueProfileFor):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::tryAllocate):
(JSC::DFG::RegisterBank::allocateSpecific):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::isInUse):
(JSC::DFG::RegisterBank::dump):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
(JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateCPS):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGValueRecoveryOverride.h:
(JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::operand):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::flushFormat):
- dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::setLocal):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLExitArgumentForOperand.h:
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operand):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::argumentsRegisterFor):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::emitGetVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
- 11:29 AM Changeset in webkit [156481] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Keep DOM tree expanded on page reload
https://bugs.webkit.org/show_bug.cgi?id=121665
Reviewed by Darin Adler.
Allow the node that was selected before reloading the page to be selected
at the page is reloaded. Credit goes to Joseph Pecoraro for the fix.
- UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._rootDOMNodeAvailable.selectNode):
- 11:13 AM Changeset in webkit [156480] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix MSVC build
- 11:13 AM Changeset in webkit [156479] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Crash at at com.apple.WebKit2: WebKit::VoidCallback::invalidate + 46
https://bugs.webkit.org/show_bug.cgi?id=121910
Reviewed by Darin Adler.
Store a copy of the VoidCallback passed to WKPage, and invalidate the callback
during dealloc. The VoidCallback class assumes that it will only ever be
invalidated or invoked once, so change the ASSERTs into an early return.
- UIProcess/GenericCallback.h:
(WebKit::VoidCallback::performCallback): Exit early if previously invalidated.
(WebKit::VoidCallback::invalidate): Ditto.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController dealloc]): Invalidate the repaint callback if present.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Ditto & create a new callback.
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Clear the callback.
- 11:13 AM Changeset in webkit [156478] by
-
- 20 edits1 delete in trunk
Unreviewed, rolling out r156451.
http://trac.webkit.org/changeset/156451
https://bugs.webkit.org/show_bug.cgi?id=121965
Broke two fast/multicol tests. (Requested by kling on
#webkit).
Source/WebCore:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::updateRegionForRenderLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRequiresLayerForCompositing):
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
LayoutTests:
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Removed.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Removed.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Removed.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Removed.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Removed.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-update.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index.html: Removed.
- 11:09 AM Changeset in webkit [156477] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] JSValue* exception is unused since r70703 in JITStackFrame.
https://bugs.webkit.org/show_bug.cgi?id=121962
This is a cosmetic change, but it could avoid people reading sh4 part to
waste time to understand why there is a JSValue* here.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Darin Adler.
- jit/JITStubs.h:
- 11:00 AM Changeset in webkit [156476] by
-
- 2 edits in trunk/Source/JavaScriptCore
WeakGCMap should not inherit from HashMap
https://bugs.webkit.org/show_bug.cgi?id=121964
Reviewed by Geoffrey Garen.
Add the HashMap as a member variable instead and implement the missing member functions.
- runtime/WeakGCMap.h:
- 10:57 AM Changeset in webkit [156475] by
-
- 3 edits in trunk/Tools
XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951
Reviewed by Carlos Garcia Campos.
Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
500 layout tests that trigger accelerated compositing to be used.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):
- 10:50 AM Changeset in webkit [156474] by
-
- 65 edits in trunk/Source/JavaScriptCore
VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732
Reviewed by Geoffrey Garen.
This is a refactoring change. Changed VirtualRegister from an enum to a class.
Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
and the similar functions for locals to VirtualRegister class.
This is in preparation for changing the offset for the first local register from
0 to -1. This is needed since most native calling conventions have the architected
frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
pointer. Local values start below that address.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
- bytecode/MethodOfGettingAValueProfile.cpp:
- bytecode/Operands.h:
- bytecode/UnlinkedCodeBlock.cpp:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/ValueRecovery.h:
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/RegisterID.h:
- debugger/DebuggerCallFrame.cpp:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h:
- dfg/DFGArgumentPosition.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCode.cpp:
- dfg/DFGNode.h:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGRegisterBank.h:
- dfg/DFGScoreBoard.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueRecoveryOverride.h:
- dfg/DFGVariableAccessData.h:
- dfg/DFGVariableEvent.h:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- ftl/FTLExitArgumentForOperand.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExit.cpp:
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- jit/AssemblyHelpers.h:
- jit/JIT.h:
- jit/JITCall.cpp:
- jit/JITInlines.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITStubs.cpp:
- llint/LLIntSlowPaths.cpp:
- profiler/ProfilerBytecodeSequence.cpp:
- runtime/CommonSlowPaths.cpp:
- runtime/JSActivation.cpp:
- 10:43 AM Changeset in webkit [156473] by
-
- 34 edits2 adds3 deletes in trunk/Source/WebCore
[MediaStream] Cleanup platform interface
https://bugs.webkit.org/show_bug.cgi?id=121935
Reviewed by Jer Noble.
No new tests, tests will be updated in the next patch.
- CMakeLists.txt: Remove MediaStreamComponent.cpp.
- GNUmakefile.list.am: Remove MediaStreamComponent.h|cpp and MediaStreamSourcesQueryClient.h.
Add MediaStreamConstraintsValidationClient.h and MediaStreamCreationClient.h.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack): Duplicate MediaStreamSource when necessary to work around bug 121954.
(WebCore::createFromSourceVectors): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::MediaStream): *Components -> *Streams.
(WebCore::MediaStream::setEnded): New.
(WebCore::MediaStream::stop): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::addTrack): Append the track parameter rather than duplicating it, as per spec.
(WebCore::MediaStream::removeTrack): *Components -> *Streams.
(WebCore::MediaStream::trackDidEnd): Renamed from trackEnded.
(WebCore::MediaStream::streamDidEnd): Renamed from streamEnded.
(WebCore::MediaStream::addRemoteSource): Renamed from addRemoteTrack. *Components -> *Streams.
(WebCore::MediaStream::removeRemoteSource): Renamed from removeRemoteTrack. *Components -> *Streams.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create): *Component -> *Stream.
(WebCore::MediaStreamTrack::MediaStreamTrack): Don't assume source is valid.
(WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
(WebCore::MediaStreamTrack::kind): Ditto. AtomicString -> const AtomicString&.
(WebCore::MediaStreamTrack::setSource): Moved from .h file.
(WebCore::MediaStreamTrack::id): Don't assume source is valid. Create ID when the source doesn't have one.
(WebCore::MediaStreamTrack::label): Don't assume source is valid.
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled): *Component -> *Stream. MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::readyState): "muted" is not a readyState, but "new" is.
(WebCore::MediaStreamTrack::getSources): MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::ended): *Component -> *Stream.
(WebCore::MediaStreamTrack::sourceChangedState): Dispatch "started" and "unmuted" events.
(WebCore::MediaStreamTrack::trackDidEnd): Renamed from didEndTrack. m_component -> m_source.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::create): track->component() -> track->source();
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Ditto.
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Ditto.
(WebCore::RTCStatsRequestImpl::component): Removed, it was unused.
- Modules/mediastream/RTCStatsRequestImpl.h:
- Modules/mediastream/UserMediaClient.h:
- Modules/mediastream/UserMediaController.h:
(WebCore::UserMediaController::requestPermission): Renamed from requestUserMedia, get rid of source
vector parameters.
(WebCore::UserMediaController::cancelRequest): Renamed from cancelUserMediaRequest.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::parseOptions): MediaConstraintsImpl -> MediaConstraints.
(WebCore::UserMediaRequest::create): Ditto.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::UserMediaRequest::securityOrigin): New.
(WebCore::UserMediaRequest::start): Request constraint validation.
(WebCore::UserMediaRequest::constraintsValidated): New. Callback from media engine when constraints
can be supported.
(WebCore::UserMediaRequest::requestPermission): New. Ask user media client for permission to access media.
(WebCore::UserMediaRequest::userMediaAccessGranted): New. Access has been granted.
(WebCore::UserMediaRequest::createMediaStream): New. Allowed to access media, ask media engine
to create stream sources.
(WebCore::UserMediaRequest::userMediaAccessDenied): New. User media client has denied access request.
(WebCore::UserMediaRequest::constraintsInvalid): New. Media engine can not support constraints.
(WebCore::UserMediaRequest::didCreateStream): New. Media engine has created stream sources.
(WebCore::UserMediaRequest::callSuccessHandler): New. Create stream from sources and call success handler.
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError): Renamed from constraintFailure.
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError): Renamed from permissionFailure.
(WebCore::UserMediaRequest::callErrorHandler):
(WebCore::UserMediaRequest::contextDestroyed): cancelUserMediaRequest -> cancelRequest.
- Modules/mediastream/UserMediaRequest.h:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): localAudio->component()->source() -> localAudio->source().
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): MediaStreamSource::TypeAudio ->
MediaStreamSource::Audio, MediaStreamSource::ReadyStateLive -> MediaStreamSource::Live.
MediaStreamCenter::instance -> MediaStreamCenter::shared.
- WebCore.exp.in: Export new symbols.
- WebCore.xcodeproj/project.pbxproj: Add new files and remove deleted files.
- dom/EventNames.h: Define "started" event.
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::mediaStreamCenterOverride): Make it possible to override the shared stream center. Will
be used for testing in a later patch.
(WebCore::MediaStreamCenter::shared): Renamed from instance. Return current stream center.
(WebCore::MediaStreamCenter::setSharedStreamCenter): Override current stream center.
(WebCore::MediaStreamCenter::endLocalMediaStream): Never call the descriptor client, always call
the descriptor and let it deal with the client.
- platform/mediastream/MediaStreamCenter.h:
- platform/mediastream/MediaStreamComponent.cpp: Removed.
- platform/mediastream/MediaStreamComponent.h: Removed.
- platform/mediastream/MediaStreamConstraintsValidationClient.h: Added.
- platform/mediastream/MediaStreamCreationClient.h: Added.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource): *Component -> *Source.
(WebCore::MediaStreamDescriptor::removeSource): Ditto.
(WebCore::MediaStreamDescriptor::addRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::removeRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
(WebCore::MediaStreamDescriptor::setEnded): Ditto. Set source readyStates to Ended.
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::MediaStreamSource): Initialize new member variables.
(WebCore::MediaStreamSource::setReadyState): Early return when the state hasn't changed.
(WebCore::MediaStreamSource::setStream): New.
(WebCore::MediaStreamSource::setMuted): New.
- platform/mediastream/MediaStreamSource.h:
- platform/mediastream/MediaStreamSourcesQueryClient.h: Removed.
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCStatsRequest.h:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Update for new MediaStreamCenter API.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Ditto.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp: Ditto.
- platform/mediastream/mac/MediaStreamCenterMac.h:
- 10:34 AM Changeset in webkit [156472] by
-
- 25 edits in trunk
Tiled drawing should not imply threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=121874
<rdar://problem/15071494>
Reviewed by Sam Weinig.
- Shared/DrawingAreaInfo.h:
We can have DrawingAreaTypeTiledCoreAnimation without threaded scrolling.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetThreadedScrollingEnabled):
(WKPreferencesGetThreadedScrollingEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
Add a preference for threaded scrolling.
- UIProcess/API/mac/WKView.mm:
(-[WKView WebKit::]):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
Make it so we can use TiledCoreAnimationDrawingArea without ENABLE(THREADED_SCROLLING).
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUseTiledBackingForFrame):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Override shouldUseTiledBackingForFrame; ask the drawing area if we want a tiled backing for the given frame.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
- WebProcess/WebPage/WebPage.h:
Move attaching and detaching the scrolling tree into WebPage.
Store whether or not this page is going to use threaded scrolling once, as this
cannot change through the life of a page.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
Move attaching and detaching the scrolling tree into WebPage.
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
Only do scrolling coordinator work if we have a scrolling coordinator.
(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrame):
TiledCoreAnimationDrawingArea always wants a tiled backing for the main frame.
No new tests; a near-future patch is going to put the majority of layout
tests into the tiled-drawing-without-threaded-scrolling mode.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldUseTiledBackingForFrame):
Add a ChromeClient callback to determine whether a given frame wants a TiledBacking for its contents.
- page/FrameView.h:
- WebCore.exp.in:
Make isMainFrameView public and export it for use in WebKit2.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Make use of shouldUseTiledBackingForFrame instead of predicating the
main frame using a tile cache on whether we have a scrolling coordinator.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiled): Added.
(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
All of these checks for existence of a scrollingCoordinator should actually
key off whether we're using tiled drawing at the root; they have nothing
to do with threaded scrolling.
- rendering/RenderLayerCompositor.h:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
The existing tiled-drawing layout tests require threaded scrolling to be enabled.
- 10:33 AM Changeset in webkit [156471] by
-
- 2 edits in trunk/Source/WebCore
Mark IDBDatabase "FINAL" now that http://webkit.org/b/121747 is fixed.
Rubberstamped by Andreas Kling
- Modules/indexeddb/IDBDatabase.h: Mark this class FINAL.
- 10:24 AM Changeset in webkit [156470] by
-
- 2 edits in trunk/LayoutTests
One more IndexedDB rebaseline.
- js/dom/global-constructors-attributes-expected.txt:
- 10:19 AM Changeset in webkit [156469] by
-
- 5 edits in trunk/Source/JavaScriptCore
Weak should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=121963
Reviewed by Oliver Hunt.
This is the first step towards getting rid of PassWeak.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- heap/Weak.h:
- heap/WeakInlines.h:
(JSC::::Weak):
(JSC::::leakImpl):
- runtime/SimpleTypedArrayController.cpp:
(JSC::SimpleTypedArrayController::toJS):
- 10:16 AM Changeset in webkit [156468] by
-
- 16 edits in trunk
op_to_this shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121920
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is
to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables
during nursery collections.
This patch adds an inline cache for the Structure of to_this so it no longer depends on the ValueProfile's
m_singletonValue. Since nobody uses m_singletonValue now, this patch also removes m_singletonValue from
ValueProfile.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
- bytecode/LazyOperandValueProfile.h:
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::briefDescription):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
LayoutTests:
Updated a couple tests that waited for two DFG compiles, but with this patch we
don't do two compiles any more, so we don't want to wait forever.
- js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js:
- js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js:
- 10:06 AM Changeset in webkit [156467] by
-
- 3 edits in trunk/LayoutTests
Rebaseline some tests after IndexedDB was enabled.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-shared-worker-expected.txt:
- 9:57 AM Changeset in webkit [156466] by
-
- 4 edits8 adds in trunk
Inset box-shadows fail to round around corners when border-radius is set in vh/vw units.
https://bugs.webkit.org/show_bug.cgi?id=119187
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-26
Reviewed by Darin Adler.
Source/WebCore:
Border-radius properties were not applied incase its values
were given in vh, vw, vmax, vmin units.
Tests: fast/css/border-radius-inset-box-shadow-viewportlength.html
fast/css/border-radius-viewport-height.html
fast/css/border-radius-viewport-vmax.html
fast/css/border-radius-viewport-vmin.html
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
- css/StyleResolver.h:
Calculating the border-radius values which has been specified
in viewport units.The vh/vw units are calcultated as percent of
viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/border-radius-inset-box-shadow-viewportlength-expected-mismatch.html: Added.
- fast/css/border-radius-inset-box-shadow-viewportlength.html: Added.
- fast/css/border-radius-viewport-height-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-height.html: Added.
- fast/css/border-radius-viewport-vmax-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-vmax.html: Added.
- fast/css/border-radius-viewport-vmin-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-vmin.html: Added.
Added new tests for verifying that box-shadow and border-radius properties
are applied when its values are viewport units.
- 9:53 AM Changeset in webkit [156465] by
-
- 2 edits in trunk/Source/WebCore
Fix ordered comparison warnings in BitmapImage::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=121945
Reviewed by Darin Adler.
No new tests, no behavior change.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
- 9:52 AM Changeset in webkit [156464] by
-
- 19 edits12 adds in trunk
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This is mostly simple - the semantics of deconstruction are already
present in the language, so most of the complexity (if you call it
that) is addition of new AST nodes, and parsing the syntax.
In order to get correct semantics for the parameter lists, FunctionParameters
now needs to store refcounted references to the parameter patterns.
There's also a little work to ensure that variable creation and assignment
occurs in the correct order while the BytecodeGenerator is being constructed.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::DeconstructionPatternNode::~DeconstructionPatternNode):
(JSC::ArrayPatternNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::toString):
(JSC::ArrayPatternNode::collectBoundIdentifiers):
(JSC::ObjectPatternNode::toString):
(JSC::ObjectPatternNode::emitBytecode):
(JSC::ObjectPatternNode::collectBoundIdentifiers):
(JSC::BindingNode::emitBytecode):
(JSC::BindingNode::toString):
(JSC::BindingNode::collectBoundIdentifiers):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::createDeconstructingAssignment):
(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::appendArrayPatternSkipEntry):
(JSC::ASTBuilder::appendArrayPatternEntry):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createBindingLocation):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
(JSC::DeconstructionPatternNode::DeconstructionPatternNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ArrayPatternNode::create):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::ObjectPatternNode::create):
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
(JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::ExpressionNode::isDeconstructionNode):
(JSC::ArrayNode::elements):
(JSC::CommaNode::append):
(JSC::ParameterNode::pattern):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::patterns):
(JSC::DeconstructionPatternNode::isBindingNode):
(JSC::DeconstructionPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::appendIndex):
(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectPatternNode::Entry::Entry):
(JSC::BindingNode::boundProperty):
(JSC::BindingNode::isBindingNode):
(JSC::DeconstructingAssignmentNode::bindings):
(JSC::DeconstructingAssignmentNode::isLocation):
(JSC::DeconstructingAssignmentNode::isDeconstructionNode):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareBoundParameter):
(JSC::Parser::declareBoundParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::addVar):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
(JSC::escapeStringToBuilder):
- runtime/JSONObject.h:
LayoutTests:
Add enw tests, and update old ones.
- js/destructuring-assignment-expected.txt: Added.
- js/destructuring-assignment.html: Added.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Added.
- js/regress/destructuring-arguments-length-expected.txt: Added.
- js/regress/destructuring-arguments-length.html: Added.
- js/regress/destructuring-arguments.html: Added.
- js/regress/destructuring-swap-expected.txt: Added.
- js/regress/destructuring-swap.html: Added.
- js/regress/script-tests/destructuring-arguments-length.js: Added.
(foo):
- js/regress/script-tests/destructuring-arguments.js: Added.
(foo):
- js/regress/script-tests/destructuring-swap.js: Added.
(foo):
- js/script-tests/destructuring-assignment.js: Added.
(testDestructuring):
(testDeconstructArgs):
(testDeconstructArgLength):
- 9:46 AM Changeset in webkit [156463] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Unskip media/context-menu-actions.html which is passing now.
- platform/gtk-wk2/TestExpectations:
- 9:36 AM Changeset in webkit [156462] by
-
- 2 edits in trunk
[GTK] Tons of warnings caused by using FORTIFY_SOURCE in an unoptimized build
https://bugs.webkit.org/show_bug.cgi?id=121836
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-26
Reviewed by Martin Robinson.
- Source/autotools/SetupCompilerFlags.m4: only consider enabling FORTIFY_SOURCE if optimizations have
been enabled, since they are required for FORTIFY_SOURCE to work, and enabling FORTIFY_SOURCE unconditionally
generates warnings in newer glibc.
- 9:18 AM Changeset in webkit [156461] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r156457.
http://trac.webkit.org/changeset/156457
https://bugs.webkit.org/show_bug.cgi?id=121960
Broke webkitpy tests. (Requested by kling on #webkit).
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- 8:16 AM Changeset in webkit [156460] by
-
- 3 edits in trunk/LayoutTests
[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Unreviewed gardening again. Now moving the expected flakiness to
the WebKit2GTK+ port, where it actually belongs to.
- platform/gtk-wk2/TestExpectations: Added expectations.
- platform/gtk/TestExpectations: Removed expectations.
- 8:02 AM Changeset in webkit [156459] by
-
- 2 edits in trunk/LayoutTests
[GTK] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Unreviewed gardening. Marking accessibility tests as flaky while
an issue with the logging of accessibility events is investigated.
- platform/gtk/TestExpectations: Added flaky expectations.
- 7:24 AM Changeset in webkit [156458] by
-
- 8 edits14 deletes in trunk/Source/WebCore
Remove empty JSFooCustom.cpp files.
<https://webkit.org/b/121955>
Reviewed by Anders Carlsson.
There's no sense in slowing down build times with empty files that
still include a bunch of headers.
- bindings/js/JSAudioBufferCustom.cpp: Removed.
- bindings/js/JSCSSFontFaceRuleCustom.cpp: Removed.
- bindings/js/JSCSSImportRuleCustom.cpp: Removed.
- bindings/js/JSCSSMediaRuleCustom.cpp: Removed.
- bindings/js/JSCSSPageRuleCustom.cpp: Removed.
- bindings/js/JSCSSStyleRuleCustom.cpp: Removed.
- bindings/js/JSDOMImplementationCustom.cpp: Removed.
- bindings/js/JSDOMTokenListCustom.cpp: Removed.
- bindings/js/JSHTMLStyleElementCustom.cpp: Removed.
- bindings/js/JSMediaListCustom.cpp: Removed.
- bindings/js/JSProcessingInstructionCustom.cpp: Removed.
- bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Removed.
- bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Removed.
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: Removed.
- 6:30 AM Changeset in webkit [156457] by
-
- 2 edits in trunk/Tools
XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951
Reviewed by Carlos Garcia Campos.
Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
500 layout tests that trigger accelerated compositing to be used.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- 4:50 AM Changeset in webkit [156456] by
-
- 2 edits in trunk/Source/WTF
[Qt] Remove PassTraits.h from WTF.pro.
https://bugs.webkit.org/show_bug.cgi?id=121946
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Andreas Kling.
- WTF.pro: Remove PassTraits.h as this file disappeared in r156298.
- 4:18 AM Changeset in webkit [156455] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html
https://bugs.webkit.org/show_bug.cgi?id=112152
Unreviewed GTK gardening. Removed crash expectations now passing.
- platform/gtk/TestExpectations: Removed crashing expectations
- 4:13 AM Changeset in webkit [156454] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Remove failure expectation for test passing after r156209.
- platform/gtk-wk2/TestExpectations: Removed failure expectation.
- 1:58 AM Changeset in webkit [156453] by
-
- 3 edits in trunk/LayoutTests
[EFL] Remove inappropriate expectations for tests that are now passing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=121897
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 1:41 AM Changeset in webkit [156452] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Add baselines for editing/selection/paragraph-granularity.html
https://bugs.webkit.org/show_bug.cgi?id=121842
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
- platform/efl/TestExpectations: Removing the corresponding entry.
- platform/efl/editing/selection/paragraph-granularity-expected.txt: Added.
- 1:20 AM Changeset in webkit [156451] by
-
- 20 edits21 adds in trunk
[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457
Patch by Mihai Maerean <Mihai Maerean> on 2013-09-26
Reviewed by David Hyatt.
Source/WebCore:
This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review
The composited layers inside the named flow threads are collected as part of the regions.
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderFlowThread::updateAllLayerToRegionMappings).
Tests: fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html
fast/regions/layers/accelerated-compositing/z-index.html: Added.
fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushRenderFlowThread):
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): The RenderNamedFlowThread is ignored when we calculate the bounds
of the RenderView.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's inside an out of flow Flow Thread.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::enclosingFlowThreadAncestor):
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly. We
are going to collect composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a region.
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderElement.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRequiresLayerForCompositing):
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderRegion.h:
(WebCore::toRenderRegion):
- rendering/RenderRegionSet.h:
(WebCore::RenderRegionSet::requiresLayer): Never.
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
LayoutTests:
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Added.
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Added.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Added.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Added.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Added.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Added.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Added.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Added.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Added.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Added.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
- 12:58 AM Changeset in webkit [156450] by
-
- 3 edits4 adds in trunk
[CSSRegions] Unable to collect html element in a named flow
https://bugs.webkit.org/show_bug.cgi?id=121878
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/regions/collect-html-in-named-flow.html
fast/regions/iframe-html-collected.html
It should be possible to collect the html element in a named flow.
However, before we check whether adding a child is not restricted
by its original parent, we have to make sure that the original parent
is an element to safely perform the check.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::isChildAllowed):
LayoutTests:
Use an iframe with a html element collected in a named flow
to test that is does not crash or assert.
- fast/regions/collect-html-in-named-flow-expected.txt: Added.
- fast/regions/collect-html-in-named-flow.html: Added.
- fast/regions/iframe-html-collected-expected.txt: Added.
- fast/regions/iframe-html-collected.html: Added.
