Timeline
Oct 8, 2013:
- 11:23 PM Changeset in webkit [157158] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix EFL buildbreak since r157152.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::adjustForTouchEvent):
- 10:26 PM Changeset in webkit [157157] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when puttin objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 7:36 PM Changeset in webkit [157156] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for geolocation test that has been timing out.
- platform/gtk-wk2/TestExpectations:
- 7:07 PM Changeset in webkit [157155] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Move http/tests/loading/307-after-303-after-post.html failure
expectation to the global gtk expectations file, since it's also true for gtk-wk2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 6:16 PM Changeset in webkit [157154] by
-
- 8 edits1 delete in trunk
Improved WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122536
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
Source/WebCore:
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::cookieJarPath):
Put cookies.dat into the AppData directory on Windows.
Tools:
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
- WinLauncher/PrintWebUIDelegate.h: Removed stubs.
- WinLauncher/WinLauncher.cpp:
(createCrashReport): Use the executable name instead of "WinLauncher".
- WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
- win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
- 5:45 PM Changeset in webkit [157153] by
-
- 2 edits in trunk/Source/WebCore
Remove the code erroneously in the previous commit.
- dom/EventDispatcher.h:
(WebCore::EventPath::contextAt):
- 5:41 PM Changeset in webkit [157152] by
-
- 8 edits in trunk/Source/WebCore
Turn EventPath into a real class
https://bugs.webkit.org/show_bug.cgi?id=122533
Reviewed by Antti Koivisto.
Turned EventPath into a real class and made EventRetargeter::calculateEventPath its constructor.
We can turn a lot of functions in EventRetargeter.cpp member functions of EventPath since many
of them manipulate EventPath in one way or another.
- dom/EventContext.h:
(WebCore::toMouseOrFocusEventContext):
(WebCore::toTouchEventContext):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
(WebCore::EventPath::hasEventListeners):
- dom/EventDispatcher.h:
(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::item):
(WebCore::EventPath::targetRespectingTargetRules):
(WebCore::EventPath::shrink):
(WebCore::EventPath::lastContextIfExists):
- dom/EventRetargeter.cpp:
(WebCore::EventPath::EventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::eventHasListeners):
- inspector/InspectorInstrumentation.h:
- 5:38 PM Changeset in webkit [157151] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. The 64 bits release bot has been made to use 8 bpp depth, so
fast/dom/Window/window-screen-properties.html won't pass there.
- platform/gtk/TestExpectations:
- 5:24 PM Changeset in webkit [157150] by
-
- 12 edits in trunk
Convert for-of iteration to in-band signalling so we can trivially avoid unnecessary object allocation
https://bugs.webkit.org/show_bug.cgi?id=122532
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Switch for-of enumeration to use in band signalling to determine the end
of iteration. This allows us to trivially remove an otherwise unnecessary
object allocation, and paves the way for optimised thunks in future.
We can re-add explicit .next() functions in future that would marshall
the true iteration functions, but for now we'll ignore them.
This results in a huge improvement in the performance of for-of (in the order
of 2x) but there's still a long way to go in order to get the performance to
a satisfactory level.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForOfNode::emitBytecode):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
- runtime/JSObject.h:
(JSC::JSFinalObject::create):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
LayoutTests:
Update tests to reflect our non-exposure of .next()
- js/array-iterators-expected.txt:
- js/script-tests/array-iterators.js:
- 5:21 PM Changeset in webkit [157149] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Make platform-specific expectation file apply only to gtk-wk1, since
gtk-wk2 gets the output right.
- platform/gtk-wk1/fast/loader/show-only-one-beforeunload-dialog-expected.txt: Renamed from LayoutTests/platform/gtk/fast/loader/show-only-one-beforeunload-dialog-expected.txt.
- 5:08 PM Changeset in webkit [157148] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update gtk-wk2-specific expectations for a couple of
fast/dom/Window tests:
- fast/dom/Window/window-postmessage-clone.html (times out)
- fast/dom/Window/open-window-min-size.html (fails)
- platform/gtk-wk2/TestExpectations:
- 5:05 PM Changeset in webkit [157147] by
-
- 9 edits in trunk/Source
Source/JavaScriptCore: Fixed compile errors while compiling without the JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- jit/JITOperations.cpp:
Protected with #if ENABLE(JIT) like the rest of the JIT source.
Source/ThirdParty/ANGLE: Generate pdb files for debugging ANGLE DLLs.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- ANGLE.vcxproj/libEGLCommon.props:
- ANGLE.vcxproj/libGLESv2Common.props:
Generate debug information.
Source/WebCore: Enabled all necessary files for Win64 build.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
Enabled MediaPlayerPrivateFullscreenWindow and
RenderLayerModelObject to be built in Win64 build.
Source/WebKit: Fixed Win64 linking.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added 64-bit linker symbols.
- 4:49 PM Changeset in webkit [157146] by
-
- 14 edits in trunk/Source
Consolidate findString functions
https://bugs.webkit.org/show_bug.cgi?id=122480
Reviewed by Darin Adler.
../WebCore:
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::executeFindString):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::find):
- page/Page.cpp:
- page/Page.h:
Fix a long standing FIXME.
../WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_text_search):
- ewk/ewk_view.cpp:
(ewk_view_text_search):
../WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_search_text):
../WebKit/win:
- WebView.cpp:
(WebView::searchFor):
- 4:25 PM Changeset in webkit [157145] by
-
- 2 edits in trunk/LayoutTests
Upgrade accessibility/title-ui-element-correctness.html from crash (wk2-specific)
to fail (gtk-wide) expectation.
- platform/gtk-wk2/TestExpectations:
- 4:20 PM Changeset in webkit [157144] by
-
- 13 edits in trunk/Source/WebCore
Move m_floatingObjects to RenderBlockFlow from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=122512
Reviewed by David Hyatt.
Floats are part of block flow, not every RenderBlock can contain
floars. This change makes it so that RenderBlock no longer can contain
floats, only RenderBlockFlow can.
This also moves a bunch of line layout stuff over to RenderBlockFlow,
but makes no effort to move all of line layout, as all of that is
destined to move out of both RenderBlockFlow and RenderBlock into its
own class.
No new tests, no behavior change.
- rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
- rendering/LineWidth.cpp:
(WebCore::LineWidth::LineWidth):
- rendering/LineWidth.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::shouldSkipCreatingRunsForObject):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlock::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::clipOutFloatingObjects):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::containsFloat):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::styleWillChange):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::createFloatingObjects):
(WebCore::RenderBlockFlow::removeFloatingObjects):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::newLine):
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasOverhangingFloats):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::LineBreaker):
(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::appendFloatingObjectToLastLine):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::restartLayoutRunsAndFloatsInRange):
(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::repaintDirtyFloats):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::determineEndPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::updateSegmentsForShapes):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outermostBlockContainingFloatingObject):
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
- 4:05 PM Changeset in webkit [157143] by
-
- 2 edits in trunk/Source/WTF
Turn threaded scrolling on for all Mac ports.
Rubber-stamped by Simon Fraser and Sam Weinig.
- wtf/FeatureDefines.h:
- 4:01 PM Changeset in webkit [157142] by
-
- 3 edits130 moves in trunk/LayoutTests
[CSSRegions] Move autoheight* tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122514
Reviewed by Sam Weinig.
Move tests, fix include paths, change TestExpectations when necessary.
- fast/regions/auto-size/abspos-autoheight-nested-region-expected.txt: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region-expected.txt.
- fast/regions/auto-size/abspos-autoheight-nested-region.html: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region.html.
- fast/regions/auto-size/autoheight-abspos-bottom-align-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align-expected.txt.
- fast/regions/auto-size/autoheight-abspos-bottom-align.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align.html.
- fast/regions/auto-size/autoheight-abspos-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region-expected.html.
- fast/regions/auto-size/autoheight-abspos-region.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region.html.
- fast/regions/auto-size/autoheight-allregions-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks.html.
- fast/regions/auto-size/autoheight-allregions.html: Renamed from LayoutTests/fast/regions/autoheight-allregions.html.
- fast/regions/auto-size/autoheight-break-after-expected.html: Renamed from LayoutTests/fast/regions/autoheight-break-after-expected.html.
- fast/regions/auto-size/autoheight-break-after.html: Renamed from LayoutTests/fast/regions/autoheight-break-after.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight-expected.txt.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight.html.
- fast/regions/auto-size/autoheight-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected-expected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected-expected.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected.html.
- fast/regions/auto-size/autoheight-dynamic-update-expected.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update-expected.html.
- fast/regions/auto-size/autoheight-dynamic-update.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways-expected.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways.html.
- fast/regions/auto-size/autoheight-flexbox-expected.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox-expected.html.
- fast/regions/auto-size/autoheight-flexbox.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox.html.
- fast/regions/auto-size/autoheight-floatright-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region-expected.html.
- fast/regions/auto-size/autoheight-floatright-region.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region.html.
- fast/regions/auto-size/autoheight-horizontal-bt-expected.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt-expected.html.
- fast/regions/auto-size/autoheight-horizontal-bt.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto.html.
- fast/regions/auto-size/autoheight-maxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-maxheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region-expected.html.
- fast/regions/auto-size/autoheight-maxheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region.html.
- fast/regions/auto-size/autoheight-maxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break.html.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-middleregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion-expected.html.
- fast/regions/auto-size/autoheight-middleregion.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion.html.
- fast/regions/auto-size/autoheight-minheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region-expected.html.
- fast/regions/auto-size/autoheight-minheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions.html.
- fast/regions/auto-size/autoheight-mixed-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions.html.
- fast/regions/auto-size/autoheight-mixed-parallel-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-parallel-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions.html.
- fast/regions/auto-size/autoheight-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-nested-regions.html.
- fast/regions/auto-size/autoheight-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region.html.
- fast/regions/auto-size/autoheight-region-decrease-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight.html.
- fast/regions/auto-size/autoheight-region-decrease-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight.html.
- fast/regions/auto-size/autoheight-region-decrease-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width.html.
- fast/regions/auto-size/autoheight-region-increase-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight.html.
- fast/regions/auto-size/autoheight-region-increase-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight.html.
- fast/regions/auto-size/autoheight-region-increase-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width.html.
- fast/regions/auto-size/autoheight-region-new-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl.html.
- fast/regions/auto-size/autoheight-region-new-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight.html.
- fast/regions/auto-size/autoheight-region-new-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr.html.
- fast/regions/auto-size/autoheight-region-new-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight.html.
- fast/regions/auto-size/autoheight-region-remove-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight.html.
- fast/regions/auto-size/autoheight-region-remove-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight.html.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes.html.
- fast/regions/auto-size/autoheight-regions-mark-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regions-mark-expected.txt.
- fast/regions/auto-size/autoheight-regions-mark.html: Renamed from LayoutTests/fast/regions/autoheight-regions-mark.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside-expected.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside.html.
- fast/regions/auto-size/autoheight-secondregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-expected.html.
- fast/regions/auto-size/autoheight-secondregion.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks-expected.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002.html.
- fast/regions/auto-size/autoheight-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr-expected.html.
- fast/regions/auto-size/autoheight-vertical-lr.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr.html.
- fast/regions/auto-size/autoheight-vertical-rl-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl-expected.html.
- fast/regions/auto-size/autoheight-vertical-rl.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl.html.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:40 PM Changeset in webkit [157141] by
-
- 4 edits in trunk/Websites/webkit.org
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- perf/sunspider-1.0.2/sunspider.css:
(#frameparent):
(#countdown):
- 3:40 PM Changeset in webkit [157140] by
-
- 4 edits in trunk/PerformanceTests/SunSpider
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
- hosted/sunspider.css:
(#frameparent):
(#countdown):
- resources/TEMPLATE.html: Provide an explicit countdown element in the
parent, instead of hacking it into each child frame.
- resources/driver-TEMPLATE.html: Be more explicit about how we respond
to power management. Just moving setTimeout(0) inside the loop is a
little too subtle, and may not work across browsers.
Also, leave a little extra time after changing the countdown graphic,
to give the browser some time to paint.
- 2:57 PM Changeset in webkit [157139] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followup to https://bugs.webkit.org/show_bug.cgi?id=122523
This test now passes, so updating expected file.
- fast/canvas/webgl/webgl-unprefixed-context-id-expected.txt:
- 2:17 PM Changeset in webkit [157138] by
-
- 4 edits2 adds in trunk
Support unprefixed WebGL context creation
https://bugs.webkit.org/show_bug.cgi?id=122523
<rdar://problem/15179463>
Reviewed by Simon Fraser.
Source/WebCore:
Add support for the unprefixed "webgl" canvas context type.
Test: fast/canvas/webgl/unprefixed-context.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::is3dType):
- inspector/InjectedScriptCanvasModuleSource.js:
LayoutTests:
Tests that we can create a context without the
"experimental-" prefix. Meanwhile, most of the other
WebGL tests should start to use the unprefixed
form automatically (the helper script attempts
"webgl" first).
- fast/canvas/webgl/unprefixed-context-expected.txt: Added.
- fast/canvas/webgl/unprefixed-context.html: Added.
- 2:05 PM Changeset in webkit [157137] by
-
- 15 edits in trunk/Source/WebKit2
WebProcess crash on SAP WebCycle web app
https://bugs.webkit.org/show_bug.cgi?id=122520
<rdar://problem/15030605>
Reviewed by Darin Adler.
Stop trying to use RunLoop to manage the top-level run loop and just have the child process and their
delegate subclasses start and stop the run loops. This fixes a bug with showModalDialog where we would
unintentionally call -[NSApp stop] when closing a modal dialog.
This also lets us move all knowledge of NSApplication from RunLoop. (Both the web process and plug-in process
need to use -[NSApp run] and -[NSApp stop:]).
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop. Add a startRunLoop override that calls
-[NSApp run].
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- PluginProcess/PluginProcess.h:
Add stopRunLoop() override on Mac.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::stopRunLoop):
Add default implementation that just calls RunLoop::main()->stop().
(WebKit::ChildProcess::terminate):
Call stopRunLoop().
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
Add startRunLoop member function and call it instead of RunLoop::run().
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
(WebKit::ChildProcessMainDelegate::startRunLoop):
Call RunLoop::run().
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
Add startRunLoop override that calls -[NSApp run].
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
Call stopRunLoop().
- WebProcess/WebProcess.h:
Add stopRunLoop override.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- 1:58 PM Changeset in webkit [157136] by
-
- 18 edits in trunk/Source/WebCore
Rename EventDispatchMediator::dispatchEvent to mediateAndDispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122522
Reviewed by Darin Adler.
Renamed EventDispatchMediator::dispatchEvent to EventDispatchMediator::mediateAndDispatchEvent
to make the future refactoring easier.
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEventDispatchMediator::mediateAndDispatchEvent):
- Modules/indieui/UIRequestEvent.h:
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::mediateAndDispatchEvent):
- dom/EventDispatchMediator.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::BlurEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusInEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusOutEventDispatchMediator::mediateAndDispatchEvent):
- dom/FocusEvent.h:
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::mediateAndDispatchEvent):
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::mediateAndDispatchEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent):
- dom/MouseEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEventDispatchMediator::mediateAndDispatchEvent):
- dom/TouchEvent.h:
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::mediateAndDispatchEvent):
- dom/WheelEvent.h:
- 1:42 PM Changeset in webkit [157135] by
-
- 2 edits in trunk/Source/WebCore
[MathML] Use of floating point floor/ceil on LayoutUnits seems wrong
https://bugs.webkit.org/show_bug.cgi?id=122367
Reviewed by Darin Adler.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paintCharacter): Use member methods to compute
correct floor/ceil values for LayoutUnits.
- 1:38 PM Changeset in webkit [157134] by
-
- 2 edits in trunk/LayoutTests
Skip a new WebGL test along with the others.
- platform/gtk/TestExpectations:
- 1:34 PM Changeset in webkit [157133] by
-
- 3 edits2 adds in trunk
Video -> pixel buffer output should not manage color spaces
https://bugs.webkit.org/show_bug.cgi?id=122486
Reviewed by Tim Horton.
Source/WebCore:
On Mac, when we draw a video into a canvas or WebGL, the
output of the video should not be color managed. Instead, leave it
as DeviceRGB so that it matches other colors in those elements.
We'll hopefully solve this properly soon - making everything sRGB.
Test: media/video-canvas-drawing-output.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Pass on
a CGImageRef via CGImageCreateCopyWithColorSpace rather than the raw data.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Tell CoreImage
to allocate a pixel buffer that is unmanaged.
LayoutTests:
- media/video-canvas-drawing-output-expected.txt: Added.
- media/video-canvas-drawing-output.html: Added.
- 1:30 PM Changeset in webkit [157132] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Fix segfault in initializeMockSources()
https://bugs.webkit.org/show_bug.cgi?id=122517
Reviewed by Darin Adler.
Calling release() and a member function on the same RefPtr
as arguments to a function can lead to segfaults if the release
call is evaluated first.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::initializeMockSources):
- 1:26 PM Changeset in webkit [157131] by
-
- 3 edits in trunk/Tools
Fix ruby LoadError when running run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=122519.
Reviewed by Mark Hahnenberg.
The scripts needed to explicitly require 'rubygems' for older versions of ruby
(versions before 1.9).
- Scripts/jsc-stress-test-helpers/profiler-test-helper:
- Scripts/run-jsc-stress-tests:
- 1:25 PM Changeset in webkit [157130] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/gtk/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html
failing.
- 1:03 PM Changeset in webkit [157129] by
-
- 4 edits in trunk
[CSSRegions] Regions with overflow: hidden should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122389
Reviewed by Alexandru Chiculita.
Source/WebCore:
As a follow-up from https://bugs.webkit.org/show_bug.cgi?id=122321, a region should not
be a normal flow layer when it has overflow clip. Change existing test by adding overflow:hidden
to the region element.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
LayoutTests:
Add overflow: hidden to the region to test that it does not move to the normal flow layers.
- fast/regions/layers/region-normalflow-stacking-context.html:
- 12:58 PM Changeset in webkit [157128] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, these tests had a couple pixels shift at some point,
needing a new baseline.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- 12:44 PM Changeset in webkit [157127] by
-
- 2 edits in trunk/Source/WebCore
Simplify the loop in EventRetargeter::calculateEventPath
https://bugs.webkit.org/show_bug.cgi?id=122500
Reviewed by Antti Koivisto.
Replaced the convoluted loop by two nested loops to make semantics clear.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- 12:27 PM Changeset in webkit [157126] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unskip editing/spelling/spelling-changed-text.html
https://bugs.webkit.org/show_bug.cgi?id=122502
Unreviewed gardening.
- platform/mac/TestExpectations:
spelling-changed.html is passing after r156901.
- 12:13 PM Changeset in webkit [157125] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. A couple of media-query tests rely on 3d transforms,
so skip them along with the 3d transforms tests.
- platform/gtk/TestExpectations:
- 11:25 AM Changeset in webkit [157124] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
https://bugs.webkit.org/show_bug.cgi?id=122506
Reviewed by Gustavo Noronha Silva.
Gdk event returned by gtk_get_current_event should be freed after using it.
No functionality changed.
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):
- 11:03 AM Changeset in webkit [157123] by
-
- 6 edits in trunk/Source/WebCore
Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules
https://bugs.webkit.org/show_bug.cgi?id=122494
Reviewed by Antti Koivisto.
Use referenecs instead of pointers in ventRetargeter's calculateEventPath and eventTargetRespectingTargetRules.
Also replace Vector<EventTarget*, 32> targetStack by a single pointer since we only append an item to
the vector when it's empty and we always use the last item.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
- dom/Node.cpp:
(WebCore::Node::dispatchScopedEventDispatchMediator):
- 10:59 AM Changeset in webkit [157122] by
-
- 2 edits in trunk/Tools
Unreviewed, add my new email to contributors.json.
Patch by Christophe Dumez <Christophe Dumez> on 2013-10-08
- Scripts/webkitpy/common/config/contributors.json:
- 10:33 AM Changeset in webkit [157121] by
-
- 8 edits2 adds in trunk
[CSSRegions] Computed z-Index should return 0 instead of auto for a region
https://bugs.webkit.org/show_bug.cgi?id=122405
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/layers/region-zIndex-computedStyle.html
Adjust the z-index value for a region. Also, since a box with a z-Index
that is non-auto receives a layer, i removed the requiresLayer override
in RenderRegion and RenderMultiColumnSet.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/regions/layers/region-zIndex-computedStyle-expected.txt: Added.
- fast/regions/layers/region-zIndex-computedStyle.html: Added.
- 10:33 AM Changeset in webkit [157120] by
-
- 5 edits2 adds in trunk
[CSS Regions] Widows don't work if the first line in a region is aligned with the top of the region
https://bugs.webkit.org/show_bug.cgi?id=122450
Reviewed by David Hyatt.
Source/WebCore:
The patch adds a new function updateRegionForLine that updates the containing region for a line and the
flag used to determine if it's the first line in that region. This is necessary because the code in
adjustLinePositionForPagination is not sufficient to determine when an unforced break occurs and the line
being positioned is the first one in the fragmentation container or not.
Test: fast/regions/regions-widows-float-top-aligned.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination): Added FIXME comment.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlockFlow::updateRegionForLine): New function used to update the containing region and
the first line flag.
LayoutTests:
Simple test veryfing that widows are correctly computed when there is a float affecting the lines
and when they are vertically aligned with the regions height.
- fast/regions/regions-widows-float-top-aligned-expected.html: Added.
- fast/regions/regions-widows-float-top-aligned.html: Added.
- 10:25 AM Changeset in webkit [157119] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSManagedValue should be able to store non-object JSValues
https://bugs.webkit.org/show_bug.cgi?id=122351
Reviewed by Oliver Hunt.
We decided not to support this because we thought it didn't make sense to have a
"weak" JSValue that wasn't an object.
Our general thought process was if you have a JSObject-ObjC object pair (i.e. an
Obj-C object that you exported to JavaScript-land), it makes more sense to store
a non-object JSValue on the JavaScript-land version of the object rather than as
an ivar in the Objective-C object.
In retrospect, this may not have been a good decision at least w.r.t. consistency
in client code. If you're storing a bag of JSValues off an Obj-C object, you'd
like to store all of them either in ObjC-land or JavaScript-land, but doing some
in one and some in the other doesn't sound too good. Also, what if the object you
want to hang these values off of doesn't have a corresponding object in JavaScript-
land in which to store them?
The solution is to fix JSManagedValue to be able to reference non-object JSValues.
Right now, all JSManagedValues contain a Weak<JSObject>. We'll change this so that
they can contain either a non-cell JSValue or a JSObject*, along with a weak
reference to the JSGlobalObject for reconstructing a JSValue later on.
- API/JSManagedValue.mm:
(PrimitiveOrObject::PrimitiveOrObject):
(PrimitiveOrObject::~PrimitiveOrObject):
(PrimitiveOrObject::clear):
(PrimitiveOrObject::isClear):
(PrimitiveOrObject::isSet):
(PrimitiveOrObject::isPrimitive):
(PrimitiveOrObject::isObject):
(PrimitiveOrObject::setPrimitive):
(PrimitiveOrObject::setObject):
(PrimitiveOrObject::object):
(PrimitiveOrObject::primitive):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):
(-[JSManagedValue disconnectValue]):
- 10:16 AM Changeset in webkit [157118] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Adding ImageOnlyFailure expectations to:
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html
- platform/gtk/TestExpectations:
- 10:12 AM Changeset in webkit [157117] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/styles/add-new-rule-with-style-after-body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122510
- platform/mac/TestExpectations: Marking as such.
- 10:05 AM Changeset in webkit [157116] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/debugger/debugger-activation-crash2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122509
- platform/mac/TestExpectations: Marking as such.
- 9:52 AM Changeset in webkit [157115] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/video/video-reflection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122508
- platform/mac/TestExpectations: Marking as such.
- 9:47 AM Changeset in webkit [157114] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/track/track-cue-rendering.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122507
- platform/mac/TestExpectations: Marking as such.
- 9:43 AM Changeset in webkit [157113] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, rolling out r157080.
http://trac.webkit.org/changeset/157080
Not a proper baseline
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Removed.
- 9:42 AM Changeset in webkit [157112] by
-
- 2 edits in trunk/Tools
Unreviewed build correction.
- Scripts/webkitpy/port/win.py:
(WinPort.write_registry_value): Use string representation of error message to avoid
format conversion problem.
- 9:38 AM Changeset in webkit [157111] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/video-layer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=114744
- platform/mac/TestExpectations: Marking as such.
- 9:36 AM Changeset in webkit [157110] by
-
- 3 edits in trunk/Source/WebCore
Get EFL and GTK compiling with media stream enabled
https://bugs.webkit.org/show_bug.cgi?id=122505
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Philippe Normand.
After r157068
No new tests needed.
- GNUmakefile.list.am:
- UseJSC.cmake:
- 9:31 AM Changeset in webkit [157109] by
-
- 3 edits in trunk/Source/WebKit/mac
WebNetscapePluginView should no longer use deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122495
Reviewed by Anders Carlsson.
- Plugins/WebNetscapePluginView.h: Use unique_ptr for both the pointer to
the timers hash table, and for the values in the hash table.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]): Rewrote loop so it works with unique_ptr.
(-[WebNetscapePluginView startTimers]): Ditto.
(-[WebNetscapePluginView fini]): Removed unneeded code to delete timers.
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): Make
the timers hash table with make-unique. Fixed the loop that chooses the timer
ID so it won't ever try to use a deleted value, although that never happens
in practice. Use HashMap::add instead of using both contains and set.
Rearranged code so we don't need to make a raw pointer for the timer.
(-[WebNetscapePluginView unscheduleTimer:]): Use remove instead of take/delete,
since remove takes care of the deletion automatically since we are using the
unique_ptr class.
- 8:56 AM Changeset in webkit [157108] by
-
- 3 edits2 adds in trunk
Composited layer that painted into composited ancestor is not repainted after moving
https://bugs.webkit.org/show_bug.cgi?id=114655
Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-10-08
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/repaint/absolute-painted-into-composited-ancestor.html
Composited layers are currently skipping repainting after layout,
if the repaint status is not NeedsFullRepaint. However, in case layers
were painted into composited ancestor, they need to repaint.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldRepaintAfterLayout):
LayoutTests:
Add a text repaint test to check the repainting of composited layer
that painted into composited ancestor.
- compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Added.
- compositing/repaint/absolute-painted-into-composited-ancestor.html: Added.
- 8:51 AM Changeset in webkit [157107] by
-
- 3 edits in trunk/Tools
[Win] Add checks for proper build and test environment
https://bugs.webkit.org/show_bug.cgi?id=122466
Reviewed by Darin Adler.
This patch makes two changes:
- Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or error messages so that people know what to fix to get things working.
- Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure the various environment settings are properly configured for our test environment.
- Scripts/webkitdirs.pm:
(checkInstalledTools): Add checks for some common Cygwin configuration problems that have
caused problems in the past.
(setupAppleWinEnv):
- Scripts/webkitpy/port/win.py:
(WinPort):
(WinPort.read_registry_string): Parameterize for run architecture and registry root.
(WinPort.write_registry_value): Parameterize registry writing by data type (string versus
DWORD, etc.)
(WinPort.write_registry_string): Revise to call new generic registry write function.
(WinPort.setup_crash_log_saving): Revise for new API
(WinPort.restore_crash_log_saving): Ditto
(WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
servers from running.
(WinPort.allow_error_dialogs): Ditto.
(WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
(WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
- 8:45 AM Changeset in webkit [157106] by
-
- 2 edits in trunk/Tools
[GStreamer] enable v4l2 plugin
https://bugs.webkit.org/show_bug.cgi?id=122503
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Enable the plugin, it now builds fine since
we updated our GStreamer version to 1.0.8.
- 8:28 AM Changeset in webkit [157105] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r157090.
http://trac.webkit.org/changeset/157090
https://bugs.webkit.org/show_bug.cgi?id=122504
Caused crashes in many plug-in tests (Requested by ap on
#webkit).
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):
- Shared/Plugins/NPRemoteObjectMap.h:
- 8:15 AM Changeset in webkit [157104] by
-
- 2 edits in trunk
[GTK] Re-enable MathML for release builds
https://bugs.webkit.org/show_bug.cgi?id=122361
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-10-08
Reviewed by Darin Adler.
- Source/autotools/SetupWebKitFeatures.m4: Enable MathML for release builds.
- 8:12 AM Changeset in webkit [157103] by
-
- 5 edits in tags/Safari-538.1.3/Source
Versioning.
- 8:10 AM Changeset in webkit [157102] by
-
- 1 copy in tags/Safari-538.1.3
New Tag.
- 7:56 AM Changeset in webkit [157101] by
-
- 3 edits in trunk/Source/WebKit/mac
Eliminate use of deleteAllValues in ProxyInstance
https://bugs.webkit.org/show_bug.cgi?id=122499
Reviewed by Anders Carlsson.
- Plugins/Hosted/ProxyInstance.h: Use unique_ptr for map values in m_fields and m_methods.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::~ProxyInstance): Removed calls to deleteAllValues.
(WebKit::ProxyInstance::methodNamed): Use make_unique and get to deal with map entries
that are unique_ptr. Also fixed a bug where this would do an expensive no-op if the map
already had an entry with a null in it. We would call the plug-in, but eventually
isNewEntry would be false so we would return null.
(WebKit::ProxyInstance::fieldNamed): Use make_unique and get to deal with map entries
that are unique_ptr.
- 7:39 AM Changeset in webkit [157100] by
-
- 5 edits2 deletes in trunk
Unreviewed. Rollout of r156536. ~5% regression in inline layout performance.
Source/WebCore:
- rendering/LineWidth.cpp:
- rendering/LineWidth.h:
(WebCore::LineWidth::addUncommittedWidth):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Removed.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Removed.
- 5:57 AM Changeset in webkit [157099] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Unskip tests that are already passing.
- platform/efl-wk1/TestExpectations: Mark unskipped test as failing for WK1.
- platform/efl/TestExpectations:
- 5:07 AM Changeset in webkit [157098] by
-
- 12 edits in trunk/Source/WebCore
Use toCSSFooValue() instead of using static_cast<const CSSFooValue*>
https://bugs.webkit.org/show_bug.cgi?id=122491
Reviewed by Andreas Kling.
static_cast<const CSSFooValue*> wasn't cleanup. So, we need to use toCSSFooValue() for it.
To use toCSSValue() will help to detect bad type-cast.
Besides static_cast<const WebKitCSSFooValue*> helper functions need to be added to support this use.
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSValue.cpp:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::serializeResolvingVariables):
(WebCore::CSSValue::cloneForCSSOM):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 4:39 AM Changeset in webkit [157097] by
-
- 2 edits in trunk/Source/WebCore
Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122482
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Eric Carlson.
r157068 was including a nonexistent header
No new tests needed.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- 3:55 AM Changeset in webkit [157096] by
-
- 5 edits in trunk
[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
https://bugs.webkit.org/show_bug.cgi?id=122104
Reviewed by Chris Fleizach.
Source/WebCore:
Map invalid state of an AccessibilityObject to the proper AtkState.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject): Add the mapping.
Tools:
Updated stringAttributeValue to double check that the exposure of
aria-invalid as a state is consistent with its exposure as a text
attribute as well, when it applies (implementations of AtkText).
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringAttributeValue): Add double check.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
- 3:45 AM Changeset in webkit [157095] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Name for tables are now properly showing
up when exposing information for the parent of a table's cell.
- platform/gtk/accessibility/table-cells-expected.txt: Updated.
- 2:56 AM Changeset in webkit [157094] by
-
- 12 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
https://bugs.webkit.org/show_bug.cgi?id=122414
Reviewed by Ryosuke Niwa.
On Mac, first call of 'initSpellTest' from spelling/resources/util.js
often fails while checking spelling marker.
Use shouldBecomeDifferent instead of calling timers in the tests.
It should have been done at r156137 when shouldBecomeEqual/Different
was used in asynchronous spell checking tests.
- editing/spelling/resources/util.js:
Use shouldBecomeDifferent instead of timers.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-should-select-multiple-words-expected.txt:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
Rebaseline the tests which include util.js due to
shouldBecomeDifferent outputs more logs.
- platform/mac/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for Mac.
- 2:41 AM Changeset in webkit [157093] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-08
Reviewed by Darin Adler.
Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
always true'.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.
- 2:01 AM Changeset in webkit [157092] by
-
- 1 edit32 moves1 add in trunk/LayoutTests
[CSSRegions] Move autosize and autowidth tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122493
Reviewed by Andreas Kling.
Simple move, changed paths in 2 tests.
- fast/regions/auto-size/autosize-abspos-anchoredregion-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr.html.
- fast/regions/auto-size/autosize-abspos-anchoredregion.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion.html.
- fast/regions/auto-size/autosize-region-container-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize-expected.html.
- fast/regions/auto-size/autosize-region-container-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize.html.
- fast/regions/auto-size/autosize-region-window-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize-expected.html.
- fast/regions/auto-size/autosize-region-window-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize.html.
- fast/regions/auto-size/autowidth-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain.html.
- fast/regions/auto-size/autowidth-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-abspos.html.
- fast/regions/auto-size/autowidth-attachedinvalidregion-expected.txt: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion-expected.txt.
- fast/regions/auto-size/autowidth-attachedinvalidregion.html: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion.html.
- fast/regions/auto-size/autowidth-float-expected.html: Renamed from LayoutTests/fast/regions/autowidth-float-expected.html.
- fast/regions/auto-size/autowidth-float.html: Renamed from LayoutTests/fast/regions/autowidth-float.html.
- fast/regions/auto-size/autowidth-inlineblock-expected.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock-expected.html.
- fast/regions/auto-size/autowidth-inlineblock.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos-expected.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow-expected.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow.html.
- fast/regions/auto-size/autowidth-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl-expected.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl.html.
- fast/regions/auto-size/autowidth-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow.html.
- 1:07 AM Changeset in webkit [157091] by
-
- 4 edits in trunk
[GTK] media/video-src-blob.html
https://bugs.webkit.org/show_bug.cgi?id=102586
Reviewed by Martin Robinson.
Source/WebCore:
Add support for loading videos using blob URLs.
Fixes media/video-src-blob.html.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Use BufferData buffering policy for blob
URLs.
(webKitWebSrcGetProtocols): Add blob to the list of supported
protocols.
(webKitWebSrcSetUri): Consider blob URLs as valid.
LayoutTests:
- platform/gtk/TestExpectations: Unskip
media/video-src-blob.html.
- 12:58 AM Changeset in webkit [157090] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when putting objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 12:45 AM Changeset in webkit [157089] by
-
- 7 edits in trunk/Source/WebKit/mac
Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122492
Reviewed by Andreas Kling.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin): Use auto so this works with
unique_ptr instead of auto_ptr.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCGetScriptableNPObjectReply): Use make_unique instead of using new directly.
(WKPCBooleanReply): Ditto.
(WKPCBooleanAndDataReply): Ditto.
(WKPCInstantiatePluginReply): Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Changed m_replies to map to unique_ptr
instead of to a raw pointer.
(WebKit::NetscapePluginInstanceProxy::setCurrentReply): Changed to take a unique_ptr
instead of a raw pointer since this takes ownership of the pointer.
(WebKit::NetscapePluginInstanceProxy::waitForReply): Changed to return a unique_ptr
instead of a auto_ptr because that's better. Use unique_ptr inside the function
too to avoid the need for an explicit delete.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Removed the call to
deleteAllValues.
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Removed unneeded initialization
of a local variable that was already set in all code paths.
(WebKit::NetscapePluginInstanceProxy::wheelEvent): Use auto so this works with unique_ptr
instead of auto_ptr.
(WebKit::NetscapePluginInstanceProxy::print): Ditto.
(WebKit::NetscapePluginInstanceProxy::snapshot): Ditto. Ditto.
(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Changed to return
a unique_ptr. Also removed an unneeded assertion.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Use auto so this works
with unique_ptr instead of auto_ptr.
- Plugins/Hosted/ProxyInstance.h: Changed return type of waitForReply to unique_ptr.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke): Use auto so this works with unique_ptr instead of auto_ptr.
(WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
(WebKit::ProxyInstance::supportsConstruct): Ditto.
(WebKit::ProxyInstance::getPropertyNames): Ditto.
(WebKit::ProxyInstance::methodNamed): Ditto.
(WebKit::ProxyInstance::fieldNamed): Ditto.
(WebKit::ProxyInstance::fieldValue): Ditto.
(WebKit::ProxyInstance::setFieldValue): Ditto.
Oct 7, 2013:
- 11:14 PM Changeset in webkit [157088] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Removed a duplicate expectation that I overlooked
at first. Note that having separate expectations for Debug and Release doesn't
appear to work.
- 11:09 PM Changeset in webkit [157087] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Updated expectations to cover debug assertions,
and that this is not limited to Lion.
- 11:03 PM Changeset in webkit [157086] by
-
- 2 edits in trunk/LayoutTests
Layout Test mathml/very-large-stretchy-operators.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122490
- platform/mac/TestExpectations: Skipped the test. It's faiing with a timeout and
taking up to 80 seconds.
- 9:44 PM Changeset in webkit [157085] by
-
- 3 edits in trunk/Source/WebCore
EventDispatchBehavior is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=122483
Reviewed by Andreas Kling.
Removed EventDispatchBehavior and changed the return type of determineDispatchBehavior to bool.
Also renamed it to shouldEventCrossShadowBoundary to reflect the semantics more clear.
- dom/EventRetargeter.cpp:
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
- 8:43 PM Changeset in webkit [157084] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests progress meter should update more quickly on older Rubies
https://bugs.webkit.org/show_bug.cgi?id=122459
Reviewed by Darin Adler.
- Scripts/run-jsc-stress-tests:
- 8:38 PM Changeset in webkit [157083] by
-
- 3 edits in trunk/Source/WebCore
Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
https://bugs.webkit.org/show_bug.cgi?id=122477
Reviewed by Antti Koivisto.
Make EventRetargeter::buildRelatedNodeMap and EventRetargeter::findRelatedNode static local functions
in EventRetargeter.cpp since they're only called in EventRetargeter::calculateAdjustedNodes and don't
depend on any oher member function or variable (EventRetarger doesn't have any member variables).
Also get rid of Vector local variables in both functions as they're redundant.
- dom/EventRetargeter.cpp:
(WebCore::buildRelatedNodeMap): Moved. Replaced Vector<Node*, 32> relatedNodeStack by a single pointer
since the only time we add an item to this Vector is when it's empty, and we always use or remove the
last item.
(WebCore::addRelatedNodeForUnmapedTreeScopes): Renamed from EventRetargeter::findRelatedNode. Removed
Vector<TreeScope*, 32> parentTreeScopes since it only contains the ancestor tree scopes of scope up to
a tree scope already in relatedNodeMap. We could simply remember this tree scope and re-traverse the
ancestor tree scopes in the second loop.
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- 8:29 PM Changeset in webkit [157082] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to JSNotAnObject constructor.
<https://webkit.org/b/122474>
Reviewed by Sam Weinig.
JSNotAnObject was only using the ExecState to find the VM.
- 8:28 PM Changeset in webkit [157081] by
-
- 5 edits in trunk/Source/WebCore
CTTE: EditCommand always has a Document.
<https://webkit.org/b/122473>
Reviewed by Anders Carlsson.
Store a Ref<Document> in EditComment since it's never null.
Since Ref enforces more const consistency than RefPtr, I had to make
document() and frame() non-const here. Only a single method depended
on the old half-const behavior.
- 8:26 PM Changeset in webkit [157080] by
-
- 1 edit5 adds in trunk/LayoutTests
Gardening: add baselines for new tests.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Added.
- 7:49 PM Changeset in webkit [157079] by
-
- 2 edits in trunk/LayoutTests
Gardening: skip audio/video track tests, since those are not yet supported by our
media player.
- platform/gtk/TestExpectations:
- 7:40 PM Changeset in webkit [157078] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marking svg/animations/svglengthlist-animation-3.html as flaky.
- platform/gtk/TestExpectations:
- 6:59 PM Changeset in webkit [157077] by
-
- 4 edits in trunk/Source/WTF
Improve HashMap::add comment and other similar comments
https://bugs.webkit.org/show_bug.cgi?id=122432
Reviewed by Andreas Kling.
- wtf/HashCountedSet.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
Updated comment wording. They were a bit old and out of date.
They also featured the word "interator".
- 6:37 PM Changeset in webkit [157076] by
-
- 2 edits in trunk/Source/WebCore
Update test again.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 6:34 PM Changeset in webkit [157075] by
-
- 29 edits in trunk/Source/WebCore
Unreviewed, rolling out r157061.
http://trac.webkit.org/changeset/157061
https://bugs.webkit.org/show_bug.cgi?id=122479
Broke worker tests (Requested by andersca on #webkit).
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::create):
(WebCore::DeliverPendingCallbackTask::performTask):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create):
(WebCore::ProcessMessagesSoonTask::performTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::create):
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerThreadActivityReportTask::performTask):
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 6:28 PM Changeset in webkit [157074] by
-
- 4 edits in trunk/Source
Make Vector::insert work for move-only types
https://bugs.webkit.org/show_bug.cgi?id=122429
Reviewed by Anders Carlsson.
Source/WebCore:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::padDailyCountsForNewVisit): Call insertVector.
Also added some inline capacity, which should make this faster.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::insert): Take an rvalue reference instead of a const reference.
(WTF::Vector::insertVector): Renamed to avoid overloading troubles, analogous
to what we did for appendVector.
- 6:24 PM Changeset in webkit [157073] by
-
- 2 edits in trunk/Tools
[buildbot] parse tests that are reported as crashed correctly for GTK+
https://bugs.webkit.org/show_bug.cgi?id=122476
Reviewed by Martin Robinson.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
as a failure of the API tests.
- 6:21 PM Changeset in webkit [157072] by
-
- 2 edits in trunk/Tools
Unreviewed. Skipping API test that is causing the next one to crash,
see https://bugs.webkit.org/show_bug.cgi?id=121970.
- Scripts/run-gtk-tests:
(TestRunner):
- 6:04 PM Changeset in webkit [157071] by
-
- 2 edits in trunk/Source/WebCore
Update test results.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 5:36 PM Changeset in webkit [157070] by
-
- 19 edits8 adds in trunk
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Source/WebCore:
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css:
Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 4:56 PM Changeset in webkit [157069] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests does not distinguish between failure and crashes
https://bugs.webkit.org/show_bug.cgi?id=122135
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
The GTK+ API test runner does not distinguish between failures and crashes. This change
makes it do that, so it's easier for us to spot the more important/higher priority crash
case.
- Scripts/run-gtk-tests:
(TestRunner._run_test_command): return the exit code instead of a boolean true/false,
so we have more information on how the process ended.
(TestRunner._run_test): check the exit code to distinguish between crashes and failures.
(TestRunner.run_tests): report crashes.
- 4:48 PM Changeset in webkit [157068] by
-
- 38 edits27 adds in trunk
[MediaStream API] update MediaStreamTrack object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121940
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing test updated.
Add new source files to the project:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
New capability dictionary objects:
- Modules/mediastream/AllAudioCapabilities.h: Added.
- Modules/mediastream/AllAudioCapabilities.idl: Added.
- Modules/mediastream/AllVideoCapabilities.h: Added.
- Modules/mediastream/AllVideoCapabilities.idl: Added.
- Modules/mediastream/AudioStreamTrack.cpp:
(WebCore::AudioStreamTrack::create): New version that takes a MediaStreamTrack*.
- Modules/mediastream/AudioStreamTrack.h:
New object for a capability range:
- Modules/mediastream/CapabilityRange.cpp: Added.
- Modules/mediastream/CapabilityRange.h: Added.
- Modules/mediastream/CapabilityRange.idl: Added.
- Modules/mediastream/MediaConstraintsImpl.h: Make initialize() public.
New object for the current states for a media source.
- Modules/mediastream/MediaSourceStates.cpp: Added.
- Modules/mediastream/MediaSourceStates.h: Added.
- Modules/mediastream/MediaSourceStates.idl: Added.
Don't call the media stream center to notify it when the state of other
objects change.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack): Remove the stream source duplication hack.
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
- Modules/mediastream/MediaStream.h:
New object for the capabilities of a source.
- Modules/mediastream/MediaStreamCapabilities.cpp: Added.
- Modules/mediastream/MediaStreamCapabilities.h: Added.
- Modules/mediastream/MediaStreamCapabilities.idl: Added.
Update interface to match spec.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Define a copy constructor to use in clone().
(WebCore::MediaStreamTrack::setSource): Call removeObserver if the track already has a source.
Initialize m_muted from new source's muted state.
(WebCore::MediaStreamTrack::id): Allow source to provide ID as the spec suggests.
(WebCore::MediaStreamTrack::setEnabled): Add some spec text to clarify logic. Always call
source->setEnabled, it can figure out if nothing needs to be done.
(WebCore::MediaStreamTrack::muted): Don't call the stream center when muted changes, the
source can take care of notifying interested parties.
(WebCore::MediaStreamTrack::readonly): New.
(WebCore::MediaStreamTrack::remote): New.
(WebCore::MediaStreamTrack::constraints): New.
(WebCore::MediaStreamTrack::states): New.
(WebCore::MediaStreamTrack::capabilities): New.
(WebCore::MediaStreamTrack::applyConstraints): New.
(WebCore::MediaStreamTrack::clone): New.
(WebCore::MediaStreamTrack::stopProducingData): New.
(WebCore::MediaStreamTrack::sourceStateChanged): Renamed from sourceChangedState.
(WebCore::MediaStreamTrack::sourceMutedChanged): New.
(WebCore::MediaStreamTrack::sourceEnabledChanged): New.
(WebCore::MediaStreamTrack::configureTrackRendering): New.
(WebCore::MediaStreamTrack::stopped): New.
(WebCore::MediaStreamTrack::stop): Call stopProducingData.
(WebCore::MediaStreamTrack::scheduleEventDispatch): New.
(WebCore::MediaStreamTrack::dispatchQueuedEvents): New.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/MediaTrackConstraint.cpp: Added.
- Modules/mediastream/MediaTrackConstraint.h: Added.
- Modules/mediastream/MediaTrackConstraint.idl: Added.
Add empty classes/IDL for track constraint objects.
- Modules/mediastream/MediaTrackConstraintSet.cpp: Added.
- Modules/mediastream/MediaTrackConstraintSet.h: Added.
- Modules/mediastream/MediaTrackConstraintSet.idl: Added.
- Modules/mediastream/MediaTrackConstraints.cpp: Added.
- Modules/mediastream/MediaTrackConstraints.h: Added.
- Modules/mediastream/MediaTrackConstraints.idl: Added.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler): Don't call the stream center, the
stream can take care of notifying interested parties.
Add a constructor and create() that take a MediaStreamTrack*.
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):
- Modules/mediastream/VideoStreamTrack.h:
Create a MediaStreamSource subclass for WebAudio
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): Call isAudioStreamSource instead
of checking deviceID.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Create a
MediaStreamAudioSource instead of a MediaStreamSource.
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSource.cpp: Added.
- Modules/webaudio/MediaStreamAudioSource.h: Added.
(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
Add new generated files.
- bindings/js/JSMediaSourceStatesCustom.cpp: Added.
- bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Added.
- dom/EventNames.h: Defined 'overconstrained' event.
- platform/mediastream/MediaStreamCenter.h: Get rid of all of the methods nobody uses.
It isn't clear that they are necessary, and we can add them back if/when we need them.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor): Clear the all source streams.
(WebCore::MediaStreamDescriptor::removeSource): Clear the source stream.
- platform/mediastream/MediaStreamDescriptor.h:
Make MediaStreamSource an abstract base class, and remove everyting WebAudio-specific
to MediaStreamAudioSource.
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::MediaStreamSource): Remove readyState and requiresConsumer
parameters. Create new UUID for id if non was passed.
(WebCore::MediaStreamSource::reset): Reset internal state to just-constructed. Used for testing.
(WebCore::MediaStreamSource::setReadyState): sourceChangedState -> sourceStateChanged.
(WebCore::MediaStreamSource::setStream): Remove the ASSERT that check for a source being
added to a new stream. This is still a problem, but it is required for testing and will
be fixed as a part of bug 121954.
(WebCore::MediaStreamSource::setConstraints): Added.
(WebCore::MediaStreamSource::setMuted): Notify observers when muted changes.
(WebCore::MediaStreamSource::setEnabled): Notify observers when enabled changes.
(WebCore::MediaStreamSource::readonly): New.
(WebCore::MediaStreamSource::stop): New. Set state to Ended when all of the observers has
stopped.
- platform/mediastream/MediaStreamSource.h:
Define platform versions of the Capabilities classes.
- platform/mediastream/MediaStreamSourceCapabilities.h: Added.
Update the non-functional platform stream centers for the API changes.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
- platform/mediastream/mac/MediaStreamCenterMac.h:
Update the Mock stream center for the API changes. Add a concrete mock MediaStreamSource
subclass.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockSource::MockSource): New, the mock media stream source.
(WebCore::MockSource::~MockSource):
(WebCore::MockSource::capabilities):
(WebCore::MockSource::states):
(WebCore::mockSourceMap):
(WebCore::mockAudioSourceID):
(WebCore::mockVideoSourceID):
(WebCore::initializeMockSources): Create one audio and one video mock source.
(WebCore::MockMediaStreamCenter::registerMockMediaStreamCenter): Call initializeMockSources.
(WebCore::MockMediaStreamCenter::createMediaStream): Use the already allocated mock media
sources.
(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): Ditto.
- platform/mock/MockMediaStreamCenter.h:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt:
- fast/mediastream/MediaStreamTrack-getSources.html:
- 4:43 PM Changeset in webkit [157067] by
-
- 2 edits in trunk/Tools
[GTK] Missing packages for APT on install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=121555
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-10-07
Reviewed by Martin Robinson.
- gtk/install-dependencies: add packages that are needed for
building WebKit itself and the jhbuild dependencies.
- 4:33 PM Changeset in webkit [157066] by
-
- 2 edits in trunk/Source/WTF
Fix Windows build.
- wtf/StdLibExtras.h:
(std::make_unique):
- 4:05 PM Changeset in webkit [157065] by
-
- 35 edits in trunk/Source/WebCore
CTTE: Live node lists always have an owner Node.
<https://webkit.org/b/122470>
Reviewed by Anders Carlsson.
Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr
and have all constructors take Node&.
- 4:01 PM Changeset in webkit [157064] by
-
- 3 edits in trunk/Source/WebKit2
Reduce duplicated code in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=122230
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2013-10-07
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): move duplicate code to resetState and call it.
(WebKit::WebPageProxy::resetState): new private method for code that is shared between
close and resetStateAfterProcessExited.
(WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState
and call it.
- UIProcess/WebPageProxy.h:
- 3:58 PM Changeset in webkit [157063] by
-
- 3 edits in trunk/Tools
Fix test failures.
- Scripts/webkitpy/port/base.py:
(Port.to.start_helper):
- Scripts/webkitpy/port/mock_drt.py:
(MockDRTPort.start_helper):
- 3:46 PM Changeset in webkit [157062] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL memory allocator should be able to allocate data sections in non-executable memory
https://bugs.webkit.org/show_bug.cgi?id=116189
Reviewed by Sam Weinig.
Use a RefCountedArray<int64_t> for data sections. This works out great because
RefCountedArray<> knows its own size and because the reference counting makes passing
it around very easy (you don't have to stress out about ownership).
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::addDataSection):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::dataSections):
- 3:37 PM Changeset in webkit [157061] by
-
- 29 edits in trunk/Source/WebCore
Clean up ScriptExecutionContext::Task and subclasses
https://bugs.webkit.org/show_bug.cgi?id=122469
Reviewed by Andreas Kling.
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 3:25 PM Changeset in webkit [157060] by
-
- 4 edits in trunk/Source
Modify WTF and JavaScriptCore makefiles for x64 build.
https://bugs.webkit.org/show_bug.cgi?id=122467.
<rdar://problem/15169174>.
Reviewed by Brent Fulgham.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- 3:08 PM Changeset in webkit [157059] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
https://bugs.webkit.org/show_bug.cgi?id=122363
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-07
Reviewed by Filip Pizlo.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 1:34 PM Changeset in webkit [157058] by
-
- 61 edits in trunk/Source
CTTE: Use references in and around DragController
https://bugs.webkit.org/show_bug.cgi?id=122427
Patch by Sam Weinig <sam@webkit.org> on 2013-10-07
Reviewed by Andreas Kling.
Source/WebCore:
Use references to indicate non-nullness of DragController related
objects.
Source/WebKit/efl:
- WebCoreSupport/DragClientEfl.cpp:
(WebCore::DragClientEfl::willPerformDragDestinationAction):
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::actionMaskForDrag):
(WebCore::DragClientEfl::startDrag):
- WebCoreSupport/DragClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::willPerformDragDestinationAction):
(WebKit::DragClient::willPerformDragSourceAction):
(WebKit::DragClient::actionMaskForDrag):
(WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- webkit/webkitwebview.cpp:
(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
- WebView/WebFrame.mm:
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- WebView/WebView.mm:
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
Source/WebKit/win:
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
(dragExitedCallback):
(webkitWebViewBaseDragDrop):
- UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- 1:28 PM Changeset in webkit [157057] by
-
- 5 edits in trunk/Tools
Always force discrete mode when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=122465
Reviewed by Tim Horton.
This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Link with IOKit.
- DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):
Check installColorProfile.
(restoreUserColorProfile):
Check installColorProfile.
(lockDownDiscreteGraphics):
New function to force discrete graphics.
(main):
Add '--install-color-profile' option.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
Always start the helper, but pass self._options.pixel_tests to it.
- Scripts/webkitpy/port/mac.py:
(MacPort.start_helper):
Pass --install-color-profile' to the helper if pixel_tests is true.
- 1:27 PM Changeset in webkit [157056] by
-
- 9 edits in trunk/Source
Animated images are not restarted when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=122464
<rdar://problem/14293474>
Reviewed by Simon Fraser.
Always kickstart animated images when the page visibility changes,
which can occur via window occlusion, and which is independent of in-window
state, which we were previously using to advance animation.
No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Move this call to resumeAnimatingImages() up to Page.
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
Move this call to resumeAnimatingImages() up to Page.
- WebCore.exp.in
- page/FrameView.h:
- page/Page.h:
Move resumeAnimatingImages() itself up to Page.
- page/Page.cpp:
(WebCore::Page::setIsInWindow):
Resume animated images when we move in-window.
(WebCore::Page::setVisibilityState):
Resume animated images when we become visible.
This is the one we were previously missing.
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
Resume animated images when we're told to.
(WebCore::Page::resumeAnimatingImages):
Kickstart any animated images in all frames.
- 1:04 PM Changeset in webkit [157055] by
-
- 4 edits3 adds in trunk
[Mac] Drawing video into canvas doesn't work on the first attempt
https://bugs.webkit.org/show_bug.cgi?id=122404
Patch by Jer Noble <jer.noble@apple.com> on 2013-10-07
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-canvas-drawing.html
If creating and painting from an AVPlayerItemVideoOutput fails, fall back
to the (much slower) AVAssetImageGenerator path. Make sure to revert to the
AVPlayerItemVideoOutput path when that object begins to have available
images, however.
To do so, remove the "MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around
the AVAssetImageGenerator code, and allow both the image generator and video
output to exist simultaneously.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
LayoutTests:
- media/video-canvas-drawing-expected.png: Added.
- media/video-canvas-drawing-expected.txt: Added.
- media/video-canvas-drawing.html: Added.
- 12:12 PM Changeset in webkit [157054] by
-
- 5 edits6 moves in trunk/Source/WebCore
URLMediaSource.idl and URLMediaStream.idl are wrong
https://bugs.webkit.org/show_bug.cgi?id=122301
Reviewed by Philippe Normand.
Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream,
respectively.
Update the build files:
- CMakeLists.txt: Rename URL -> DOMURL.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
Rename the .idl and implementation files:
- Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp.
(WebCore::DOMURLMediaSource::createObjectURL):
- Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h.
- Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl.
- Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp.
(WebCore::DOMURLMediaStream::createObjectURL):
- Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h.
- Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl.
- 11:58 AM Changeset in webkit [157053] by
-
- 2 edits in trunk/LayoutTests
css3/images/cross-fade-svg-with-opacity.html fails with colorspace mismatch on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=122456
- platform/mac-wk2/TestExpectations:
Mark the test as failing for now.
- 11:52 AM Changeset in webkit [157052] by
-
- 3 edits in trunk/Tools
Properly count binding test failures as failures.
Fix the total for multiple failures in different steps too by avoiding undefined.
https://bugs.webkit.org/show_bug.cgi?id=122232
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 11:50 AM Changeset in webkit [157051] by
-
- 1 edit36 moves1 add in trunk/LayoutTests
[CSSRegions] Move region styling tests into fast/regions/region-styling
https://bugs.webkit.org/show_bug.cgi?id=122451
Reviewed by Sam Weinig.
Create region-styling folder under fast/regions and move related region styling tests.
- fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt.
- fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html.
- fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt.
- fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html.
- fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html.
- fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html.
- fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html.
- fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html.
- fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html.
- fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html.
- fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html.
- fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html.
- fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html.
- fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html.
- fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html.
- fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html.
- fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html.
- fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html.
- fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html.
- fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html.
- fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html.
- fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html.
- fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html.
- fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html.
- fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html.
- fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html.
- fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt.
- fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html.
- fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt.
- fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html.
- fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html.
- fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html.
- fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt.
- fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html.
- fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt.
- fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html.
- 11:20 AM Changeset in webkit [157050] by
-
- 17 edits in trunk/Source/JavaScriptCore
Transition stack check JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122289
Reviewed by Filip Pizlo.
Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with
jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck.
Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call
these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers()
and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in
their caller frame when the stack is exhausted.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- interpreter/CallFrame.h:
(JSC::ExecState::hostCallFrameFlag):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheckWithCallFrameRollback):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 11:07 AM Changeset in webkit [157049] by
-
- 3 edits in trunk/Source/WTF
Remove passIn and passOut from HashTraits
https://bugs.webkit.org/show_bug.cgi?id=122452
Reviewed by Sam Weinig.
Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the
passIn and passOut functions and related typedefs.
- wtf/HashTraits.h:
- wtf/RefPtrHashMap.h:
- 10:45 AM Changeset in webkit [157048] by
-
- 3 edits in trunk/Source/WebCore
Conditional support in bindings code generator for overloaded functions
https://bugs.webkit.org/show_bug.cgi?id=122443
Patch by Philippe Normand <pnormand@igalia.com> on 2013-10-07
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunction): Generate conditional for overloaded
function, if it's present in the idl.
(GenerateImplementation): Close the last overloaded function
conditional before generating the distpatch function.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
Rebaseline overloaded function tests.
- 10:42 AM Changeset in webkit [157047] by
-
- 4 edits in trunk
ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122419
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is
both a int32 and a uint32 (it's in the range [0, 231)). The UInt32ToNumber node is
instead dealing with an input that is always represented as a int32 but that has the
meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Oliver Hunt.
- js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
- 9:59 AM Changeset in webkit [157046] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
https://bugs.webkit.org/show_bug.cgi?id=120007
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.
Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJumpToMove):
- 9:48 AM Changeset in webkit [157045] by
-
- 3 edits2 adds in trunk
-webkit-cross-fade paints SVGs at full opacity during cross-fade
https://bugs.webkit.org/show_bug.cgi?id=122441
<rdar://problem/13973162>
Reviewed by Simon Fraser.
Test: css3/images/cross-fade-svg-with-opacity.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
Factor the image painting out into a function.
Conditionally use a transparency layer around painting if the image
we're drawing is an SVG (SVGImage is the only Image subclass that will
not respect the context's opacity).
Add a test that ensures that -cross-fade with SVG images draws correctly.
- css3/images/cross-fade-svg-with-opacity-expected.html: Added.
- css3/images/cross-fade-svg-with-opacity.html: Added.
- 9:26 AM Changeset in webkit [157044] by
-
- 251 edits in trunk/Source
Add OVERRIDE and virtual where appropriate
https://bugs.webkit.org/show_bug.cgi?id=122439
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
- API/JSAPIWrapperObject.mm:
- API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::~JSCallbackObjectData):
- API/JSManagedValue.mm:
- API/JSScriptRef.cpp:
(OpaqueJSScript::~OpaqueJSScript):
- bytecode/CodeBlock.h:
- bytecode/StructureStubClearingWatchpoint.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGFailedFinalizer.h:
- dfg/DFGJITCode.h:
- dfg/DFGJITFinalizer.h:
- dfg/DFGSaneStringGetByValSlowPathGenerator.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGSpeculativeJIT64.cpp:
- heap/Heap.h:
- heap/IncrementalSweeper.h:
- heap/SuperRegion.h:
- jit/ClosureCallStubRoutine.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/GCAwareJITStubRoutine.h:
- jit/JITCode.h:
- jit/JITStubs.cpp:
- jit/JITToDFGDeferredCompilationCallback.h:
- jit/JumpReplacementWatchpoint.h:
- parser/Nodes.h:
- runtime/DataView.h:
- runtime/GCActivityCallback.h:
- runtime/GenericTypedArrayView.h:
- runtime/RegExpCache.h:
- runtime/SimpleTypedArrayController.h:
- runtime/WeakMapData.h:
Source/WebCore:
- Modules/encryptedmedia/MediaKeys.h:
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioProcessingEvent.h:
- Modules/webaudio/BiquadDSPKernel.h:
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DelayDSPKernel.h:
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/OfflineAudioCompletionEvent.h:
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperProcessor.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListOption.h:
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/AccessibilityTableRow.h:
- bindings/js/JSEventListener.h:
- bindings/js/WebCoreTypedArrayController.h:
- bridge/c/c_class.h:
- bridge/c/c_instance.h:
- bridge/c/c_runtime.h:
- bridge/runtime_root.h:
- css/CSSBasicShapes.h:
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleSheet.h:
- dom/Attr.h:
- dom/BeforeTextInsertedEvent.h:
- dom/CDATASection.h:
- dom/ChildNodeList.h:
- dom/DatasetDOMStringMap.h:
- dom/Document.h:
- dom/DocumentEventQueue.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/ErrorEvent.h:
- dom/KeyboardEvent.h:
- dom/Node.h:
- dom/PageTransitionEvent.h:
- dom/ProgressEvent.h:
- dom/PseudoElement.h:
- dom/ScriptExecutionContext.h:
- dom/ShadowRoot.h:
- dom/StyledElement.h:
- dom/TagNodeList.h:
- dom/Text.h:
- dom/TextEvent.h:
- dom/TransitionEvent.h:
- dom/UIEvent.h:
- dom/WebKitAnimationEvent.h:
- dom/WebKitTransitionEvent.h:
- editing/ApplyBlockElementCommand.h:
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.h:
- editing/CompositeEditCommand.h:
- editing/SpellingCorrectionCommand.h:
- fileapi/File.h:
- fileapi/FileThreadTask.h:
- history/BackForwardList.h:
- html/BaseCheckableInputType.h:
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLCollection.h:
- html/HTMLElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElementWithState.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLImageElement.h:
- html/HTMLImageLoader.h:
- html/HTMLInputElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.h:
- html/HTMLProgressElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTableElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.h:
- html/HTMLVideoElement.h:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.h:
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- html/track/AudioTrackList.h:
- html/track/TextTrackList.h:
- html/track/TrackListBase.h:
- inspector/InspectorValues.h:
- loader/EmptyClients.h:
- loader/ImageLoader.h:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/cf/LegacyWebArchive.h:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h:
- loader/cache/CachedImageClient.h:
- loader/cache/CachedSVGDocumentClient.h:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/CachedXSLStyleSheet.h:
- page/Chrome.h:
- page/DOMWindow.h:
- page/FrameView.h:
- page/animation/ImplicitAnimation.h:
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
- platform/ScrollView.h:
- platform/Scrollbar.h:
- platform/Timer.h:
- platform/animation/TimingFunction.h:
(WebCore::LinearTimingFunction::~LinearTimingFunction):
(WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction):
(WebCore::StepsTimingFunction::~StepsTimingFunction):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/HRTFPanner.h:
- platform/audio/mac/AudioDestinationMac.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.h:
- platform/network/ResourceHandle.h:
- rendering/AutoTableLayout.h:
- rendering/ClipPathOperation.h:
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.h:
- rendering/RenderImage.h:
- rendering/RenderLayer.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderObject.h:
- rendering/RenderReplaced.h:
- rendering/RenderSlider.h:
- rendering/RenderTable.h:
- rendering/RenderTableCell.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderView.h:
- rendering/RootInlineBox.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/style/BasicShapes.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGShape.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGDocument.h:
- svg/SVGElement.h:
- svg/SVGElementInstance.h:
- svg/SVGFontElement.h:
- svg/SVGGElement.h:
- svg/SVGGraphicsElement.h:
- svg/SVGTransformable.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGListPropertyTearOff.h:
- svg/properties/SVGPropertyTearOff.h:
- workers/WorkerGlobalScope.h:
Source/WTF:
- wtf/Compiler.h:
- wtf/FilePrintStream.h:
- wtf/StringPrintStream.h:
- 8:50 AM Changeset in webkit [157043] by
-
- 4 edits in trunk
Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122420
Source/JavaScriptCore:
Reviewed by Michael Saboff.
For the (-231/-1)|0 case, we were returning the left operand (i.e. -231) but we were
failing to account for the possibility that this operand has high-bit garbage and
int32Result() requires that the high bits are zero.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
LayoutTests:
Reviewed by Michael Saboff.
- js/script-tests/integer-division-neg2tothe32-by-neg1.js:
- 8:47 AM Changeset in webkit [157042] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] UserMediaClientGtk needs API update
https://bugs.webkit.org/show_bug.cgi?id=122324
Reviewed by Martin Robinson.
Update UserMediaClientGtk API after changes made in the parent
class in r156473.
- WebCoreSupport/UserMediaClientGtk.cpp:
(WebKit::UserMediaClientGtk::requestPermission):
(WebKit::UserMediaClientGtk::cancelRequest):
- WebCoreSupport/UserMediaClientGtk.h:
- 8:32 AM Changeset in webkit [157041] by
-
- 3 edits in trunk/Source/WebCore
URLMediaStream is unguarded by ENABLE(MEDIA_STREAM)
https://bugs.webkit.org/show_bug.cgi?id=122444
Reviewed by Martin Robinson.
- Modules/mediastream/URLMediaStream.cpp: Added missing
conditional guards.
- Modules/mediastream/URLMediaStream.h: Ditto.
- 8:29 AM Changeset in webkit [157040] by
-
- 4 edits in trunk/Source/WebCore
[GTK] webkit_dom_html_style_element_{s,g}et_scoped was removed
https://bugs.webkit.org/show_bug.cgi?id=122446
Reviewed by Martin Robinson.
Added skeleton functions warning of removed functionality for
the <style scoped> GObject DOM binding.
- bindings/gobject/WebKitDOMCustom.cpp:
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 8:24 AM Changeset in webkit [157039] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed buildfix for GCC 4.6.
Changed override to OVERRIDE and final to FINAL.
- page/PageSerializer.cpp:
- workers/AbstractWorker.h:
- workers/SharedWorker.h:
- workers/Worker.h:
- 8:10 AM Changeset in webkit [157038] by
-
- 3 edits2 adds in trunk
AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
https://bugs.webkit.org/show_bug.cgi?id=122252
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When an author uses a control-type ARIA role (like button), but then hides a native control-type inside,
AXPress needs to operate on the inside node if possible.
Test: accessibility/axpress-on-aria-button.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::isNodeActionElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):
LayoutTests:
- accessibility/axpress-on-aria-button-expected.txt: Added.
- accessibility/axpress-on-aria-button.html: Added.
- 7:51 AM Changeset in webkit [157037] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build with jhbuild with newer system glib
https://bugs.webkit.org/show_bug.cgi?id=122132
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
started relying on. glib is not a dependency that should change test results, and is provided in
jhbuild with the intention of supporting the other bits that do, so using a newer stable release
should not be an issue.
- gtk/jhbuild.modules:
- 7:44 AM Changeset in webkit [157036] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
https://bugs.webkit.org/show_bug.cgi?id=122437
Reviewed by Antoine Quint.
- Scripts/run-jsc-stress-tests:
- 7:36 AM Changeset in webkit [157035] by
-
- 12 edits in trunk
ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122418
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is pretty awesome. With stack compression, Arguments created in the DFG will point
their m_registers pointers into a different slab of stack than they would have in byte
code.
Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously
neglected to do so. This patch fixes that.
Fixing this unveiled another bug: the stack reversal broke the reification of inlined
phantom arguments.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Arguments.h:
(JSC::Arguments::offsetOfNumArguments):
(JSC::Arguments::offsetOfRegisters):
(JSC::Arguments::offsetOfSlowArgumentData):
(JSC::Arguments::offsetOfOverrodeLength):
LayoutTests:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- js/script-tests/dfg-arguments-osr-exit.js:
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
- 4:37 AM Changeset in webkit [157034] by
-
- 2 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901.
https://bugs.webkit.org/show_bug.cgi?id=122414
Unreviewed gardening.
- platform/mac/TestExpectations:
Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky.
Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1
- 2:01 AM Changeset in webkit [157033] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed debug build fix for ports enabling the <template> element support.
- html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required
by the assertions in the Element type casts for HTMLTemplateElement.
- 1:26 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [157032] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build fix after r157002
https://bugs.webkit.org/show_bug.cgi?id=122434
Reviewed by Sam Weinig.
- editing/markup.cpp: Changed override to OVERRIDE.
- 12:29 AM Changeset in webkit [157031] by
-
- 9 edits in releases/WebKitGTK/webkit-2.2/Source
Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
- page/gtk/EventHandlerGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
- 12:29 AM Changeset in webkit [157030] by
-
- 4 edits in trunk/Source/WebCore
MediaStreamTrack can't be FINAL
https://bugs.webkit.org/show_bug.cgi?id=122322
Reviewed by Darin Adler.
Marked the MediaStreamTrack subclasses as final.
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/VideoStreamTrack.h:
- 12:27 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:25 AM Changeset in webkit [157029] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
- 12:24 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:02 AM Changeset in webkit [157028] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519
Reviewed by Michael Saboff.
This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:01 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:01 AM Changeset in webkit [157027] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.
The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.
- API/tests/testapi.c:
(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):
- runtime/VM.cpp:
(JSC::VM::throwException):
- 12:00 AM Changeset in webkit [157026] by
-
- 35 edits4 copies2 deletes in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326
Reviewed by Oliver Hunt.
Rolling r154804 back in after fixing no-LLInt build.
Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).
Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.
Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.
Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.
This patch solves these problems by reducing all of that complexity into just
three primitives:
- Executable::newCodeBlock(). This gives you a new code block, either for call or for construct, and either to serve as the baseline code or the optimized code. The new code block is then owned by the caller; Executable doesn't register it anywhere. The new code block has no JITCode and isn't callable, but it has all of the bytecode.
- CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and produces a JITCode, and then installs the JITCode into the CodeBlock. This method takes a JITType, and always compiles with that JIT. If you ask for JITCode::InterpreterThunk then you'll get JITCode that just points to the LLInt entrypoints. Once this returns, it is possible to call into the CodeBlock if you do so manually - but the Executable still won't know about it so JS calls to that Executable will still be routed to whatever CodeBlock is associated with the Executable.
- Executable::installCode(). This takes a CodeBlock and makes it the code-for- entry for that Executable. This involves unlinking the Executable's last CodeBlock, if there was one. This also tells the GC about any effect on memory usage and does a bunch of weird data structure rewiring, since Executable caches some of CodeBlock's fields for the benefit of virtual call fast paths.
This functionality is then wrapped around three convenience methods:
- Executable::prepareForExecution(). If there is no code block for that Executable, then one is created (newCodeBlock()), compiled (CodeBlock::prepareForExecution()) and installed (installCode()).
- CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that can serve as an optimized replacement of the current one.
- CodeBlock::install(). Asks the Executable to install this code block.
This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.
It also allows me to work on FTL OSR entry and tier-up:
- FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist to do some compilation, but it will require the DFG::Worklist to do something different than what JITStubs.cpp would want, once the compilation finishes. This patch introduces a callback mechanism for that purpose.
- FTL OSR entry: this will involve creating a special auto-jettisoned CodeBlock that is used only for FTL OSR entry. The new set of primitives allows for this: Executable can vend you a fresh new CodeBlock, and you can ask that CodeBlock to compile itself with any JIT of your choosing. Or you can take that CodeBlock and compile it yourself. Previously the act of producing a CodeBlock-for-optimization and the act of compiling code for it were tightly coupled; now you can separate them and you can create such auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasBaselineJITProfiling):
- bytecode/DeferredCompilationCallback.cpp: Added.
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
- bytecode/DeferredCompilationCallback.h: Added.
- dfg/DFGDriver.cpp:
(JSC::DFG::tryCompile):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
- dfg/DFGFailedFinalizer.cpp:
(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):
- dfg/DFGFailedFinalizer.h:
- dfg/DFGFinalizer.h:
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
- dfg/DFGJITFinalizer.h:
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
- dfg/DFGPlan.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- heap/Heap.h:
(JSC::Heap::isDeferred):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JITDriver.h: Removed.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
- jit/JITToDFGDeferredCompilationCallback.cpp: Added.
(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
- jit/JITToDFGDeferredCompilationCallback.h: Added.
- llint/LLIntEntrypoints.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
- llint/LLIntEntrypoints.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/CommonSlowPaths.cpp:
- runtime/CompilationResult.cpp:
(WTF::printInternal):
- runtime/CompilationResult.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Executable.h:
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
- runtime/ExecutionHarness.h: Removed.
Oct 6, 2013:
- 11:56 PM Changeset in webkit [157025] by
-
- 90 edits in releases/WebKitGTK/webkit-2.2
Merge r154797 - Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gardening of exception throws. The act of throwing an exception was being handled in
different ways depending on whether the code was running in the LLint, Baseline JIT,
or the DFG Jit. This made development in the vm exception and error objects difficult.
- runtime/VM.cpp:
(JSC::appendSourceToError):
This function moved from the interpreter into the VM. It views the developers code
(if there is a codeBlock) to extract what was trying to be evaluated when the error
occurred.
(JSC::VM::throwException):
This function takes in the error object and sets the following:
1: The VM's exception stack
2: The VM's exception
3: Appends extra information on the error message(via appendSourceToError)
4: The error object's line number
5: The error object's column number
6: The error object's sourceURL
7: The error object's stack trace (unless it already exists because the developer
created the error object).
(JSC::VM::getExceptionInfo):
(JSC::VM::setExceptionInfo):
(JSC::VM::clearException):
(JSC::clearExceptionStack):
- runtime/VM.h:
(JSC::VM::exceptionOffset):
(JSC::VM::exception):
(JSC::VM::addressOfException):
(JSC::VM::exceptionStack):
VM exception and exceptionStack are now private data members.
- interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
Created this structure to temporarily clear the exception within the VM. This
needed to see if addition errors occur when setting the debugger as we are
unwinding the stack.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
Removed the code that would try to add error information if it did not exist.
All of this functionality has moved into the VM and all error information is set
at the time the error occurs.
The rest of these functions reference the new calling convention to throw an error.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::call):
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::defaultValue):
(JSC::::put):
(JSC::::putByIndex):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::customHasInstance):
(JSC::::call):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
- debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::callCheck):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- interpreter/CallFrame.h:
(JSC::ExecState::clearException):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):
- interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::loadVarargs):
(JSC::stackTraceAsString):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
- jit/JITCode.cpp:
(JSC::JITCode::execute):
- jit/JITExceptions.cpp:
(JSC::genericThrow):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp:
(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
(JSC::cti_vm_handle_exception):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- jsc.cpp:
(functionRun):
(functionLoad):
(functionCheckSyntax):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- runtime/Completion.cpp:
(JSC::evaluate):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwTypeError):
(JSC::throwSyntaxError):
- runtime/Error.h:
(JSC::throwVMError):
- runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):
- runtime/Executable.cpp:
(JSC::EvalExecutable::create):
(JSC::FunctionExecutable::produceCodeBlockFor):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::push):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::putToPrimitive):
- runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::create):
(JSC::::createUninitialized):
(JSC::::validateRange):
(JSC::::setWithSpecificType):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):
- runtime/JSNameScope.cpp:
(JSC::JSNameScope::put):
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::throwTypeError):
- runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/StringObject.cpp:
(JSC::StringObject::defineOwnProperty):
- runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gets column information from the error object for reporting exceptions.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackFromException):
Moved setting an exception into the vm, These functions changed to use the new functionality.
- bindings/js/JSAudioBufferSourceNodeCustom.cpp:
(WebCore::JSAudioBufferSourceNode::setBuffer):
- bindings/js/JSBiquadFilterNodeCustom.cpp:
(WebCore::JSBiquadFilterNode::setType):
- bindings/js/JSCryptoCustom.cpp:
(WebCore::JSCrypto::getRandomValues):
- bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate):
(WebCore::JSJavaScriptCallFrame::setVariableValue):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSOscillatorNodeCustom.cpp:
(WebCore::JSOscillatorNode::setType):
- bindings/js/JSPannerNodeCustom.cpp:
(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):
- bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::throwStackOverflow):
(WebCore::CloneDeserializer::throwValidationError):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::toJSPrimitive):
- bridge/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):
- bridge/objc/objc_utility.mm:
(JSC::Bindings::throwError):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtField::valueFromInstance):
(JSC::Bindings::QtField::setValueToInstance):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::throwInvalidAccessError):
Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invokeMethod):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::throwInvalidAccessError):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Column/line information was added into these results.
- fast/events/window-onerror4-expected.txt:
- fast/js/global-recursion-on-full-stack-expected.txt:
fixed a variable name in a case when shouldThrowType failed.
- fast/js/mozilla/resources/js-test-pre.js:
(shouldThrowType):
Sorted the properties to allow the results always show in the same order.
- fast/js/script-tests/exception-properties.js:
- fast/js/exception-properties-expected.txt:
This test needed to be modified to have the line numbers match on the output across
wk and wk2. This test is inherently flaky because is relies on size of the available
native stack. To account for the flakiness an additional call was made to force the
results to match.
This patch now records and outputs the line number where the errors were occurring.
This was causing the test results to no longer match because of the line numbers.
By changing how to account for the flakiness, the results match again.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
- 11:39 PM Changeset in webkit [157024] by
-
- 10 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408
Reviewed by Andreas Kling.
As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.
No new tests, no behavior changes.
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 9:48 PM Changeset in webkit [157023] by
-
- 2 edits in trunk/Source/WebKit
No? Okay, let's try that again..
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 9:35 PM Changeset in webkit [157022] by
-
- 2 edits in trunk/Source/WebKit
Attempt to fix the Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 9:34 PM Changeset in webkit [157021] by
-
- 2 edits in trunk/LayoutTests
Remove an unnecessary test expectation, as the test was removed
along with the code it tested.
- platform/mac/TestExpectations:
- 9:00 PM Changeset in webkit [157020] by
-
- 3 edits in trunk/LayoutTests
results.html doesn't support non-HTML reference tests or references with external resources
https://bugs.webkit.org/show_bug.cgi?id=122426
Reviewed by Ryosuke Niwa.
- fast/harness/results.html:
Factor splitExtension() out of stripExtension(), so we can retrieve
the extension as well as strip it.
Factor layoutTestsBasePath() out of testLink(), so we can use it for
ref test expectation files as well.
Use layoutTestsBasePath() to link to ref test expectation files, and
use the extension of the test for the expectation, instead of hardcoding
HTML reference files.
This will work on the bots because we already use the same mechanism for
the link to the test itself.
- fast/harness/resources/results-test.js:
Update the harness result viewer test results.
- 8:46 PM Changeset in webkit [157019] by
-
- 2 edits in trunk/Source/ThirdParty
Build against the Xcode default toolchain when targeting OS X 10.8.
This fixes the build after r156632 in configurations that use another toolchain
by default.
- gtest/xcode/Config/General.xcconfig:
- 8:39 PM Changeset in webkit [157018] by
-
- 38 edits in trunk/Source
Range constructors should take a Document&.
<https://webkit.org/b/122435>
Reviewed by Sam Weinig.
Source/WebCore:
Make all Range constructors take Document& instead of a PassRefPtr.
This removes one null check at every call site.
Also use a Ref<Document> for storage in Range.
Source/WTF:
Give Ref an assignment operator.
- 8:37 PM Changeset in webkit [157017] by
-
- 4 edits in trunk/LayoutTests
jsc-layout-tests.yaml/js/script-tests/dfg-arguments-osr-exit.js.layout-dfg-eager-no-cjit fails in release mode on the bots
https://bugs.webkit.org/show_bug.cgi?id=122436
Unreviewed, green the bots by not running the eager variants of these tests.
Will unskip when I land the fix for https://bugs.webkit.org/show_bug.cgi?id=122418.
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- js/script-tests/dfg-arguments-osr-exit.js:
- 7:37 PM Changeset in webkit [157016] by
-
- 2 edits in trunk/Tools
Unreviewed, fix build on old Rubies.
- Scripts/run-jsc-stress-tests:
- 7:17 PM Changeset in webkit [157015] by
-
- 7 edits2 adds in trunk/Source/WebCore
Factor text paint style computation out from InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=122433
Reviewed by Andreas Kling.
Move it to TextPaintStyle.h/cpp. Other parts of the code may use it in the future.
- 7:14 PM Changeset in webkit [157014] by
-
- 11 edits3 adds1 delete in trunk
Unified test infrastructure via the jsc shell
https://bugs.webkit.org/show_bug.cgi?id=120696
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Add a mozilla-tests.yaml list. This is autogenerated by create-mozilla-js-test-list.
I think it's better to leave this checked in; we may even just edit it directly in
the future. Also generating it is not cheap.
Fix some low-hanging fruit bugs that I caught by introducing more test coverage.
- We were not emitting labels for CFA-unreachable blocks, which caused link errors. It's possible for a CFA-unreachable block to be jumped to, if the thing that causes it to be unreachable is a speculation in a Branch or peephole compare.
- The register allocation assertions didn't handle peephole branches correctly. Since the peephole branch handling returns early from compile(), the clearBlahbittyBlah() method wasn't being called.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- tests/mozilla/mozilla-tests.yaml: Added.
Tools:
Reviewed by Oliver Hunt.
Make run-jsc-stress-tests smart enough to be able to handle different styles of test
output (silent or noisy) and different styles of test failure (just bad exit code,
text diff, filtering for some magical text, etc.). This allows me to get rid of the
layout-test-helper. It also allows me to switch all of the old Mozilla tests to
running in run-jsc-stress-tests.
Also removes all of the code paths that defended against not having shellwords. Just
install the shellwords gem if you want to run tests.
Also removes the non-parallel test running code. No reason for it to exist anymore.
This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
as part of this patch, and left three more as new bugzillas.
- Scripts/create-mozilla-js-test-list: Added.
- Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
- Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Oliver Hunt.
Suppress running the no-cjit and dfg-eager variants of these tests because there are
still some hard bugs to fix; they were revealed by the increase in test coverage.
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
- js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
- js/script-tests/integer-division-neg2tothe32-by-neg1.js:
- 5:43 PM Changeset in webkit [157013] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Get rid of use of deleteAllValues in GtkDragAndDropHelper
https://bugs.webkit.org/show_bug.cgi?id=122417
Reviewed by Andreas Kling.
- platform/gtk/GtkDragAndDropHelper.cpp: Removed unneeded typedefs.
(WebCore::GtkDragAndDropHelper::~GtkDragAndDropHelper): Removed call to
deleteAllValues.
(WebCore::GtkDragAndDropHelper::handleDragEnd): Use remove directly instead
of using find then remove. I believe this fixes a storage leak.
(WebCore::GtkDragAndDropHelper::handleGetDragData): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragLeaveLater): Remove the explicit
delete since remove will automatically delete.
(WebCore::GtkDragAndDropHelper::handleDragLeave): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragMotion): Use add instead of a
combination of find and set. Also user nullptr instead of 0.
(WebCore::GtkDragAndDropHelper::handleDragDataReceived): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragDrop): Use get instead of find.
- platform/gtk/GtkDragAndDropHelper.h: Use nullptr instead of 0. Change value
type of m_droppingContexts to be a std::unique_ptr.
- 4:26 PM Changeset in webkit [157012] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt.
- page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage):
- 3:55 PM Changeset in webkit [157011] by
-
- 34 edits in trunk/Source/WebCore
Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371
Reviewed by Darin Adler.
RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.
This also requires some type tightening elsewhere in the code.
- 3:28 PM Changeset in webkit [157010] by
-
- 3 edits in trunk/Source/WebCore
Don't try to dispatch resize events for SVG images
https://bugs.webkit.org/show_bug.cgi?id=122410
Reviewed by Darin Adler.
Tested by avoiding assertion in svg/custom/large-image-pattern-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
Bail out for SVG images. They have scripting disabled so the event wouldn't do anything anyway.
Use of FrameView mechanisms is just an implementation detail for SVG images, they are not
meant to act like real frames.
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
Switch to Element iterator. This will take NoEventDispatchAssertion verifying the change.
- 3:07 PM Changeset in webkit [157009] by
-
- 2 edits in trunk/PerformanceTests
DoYouEvenBench: Make it work on Internet Explorer 11 Release Preview
https://bugs.webkit.org/show_bug.cgi?id=122406
Reviewed by Darin Adler.
On Internet Explorer 11, $(elem).closest('li').data('id') fails to find the containig li of elem once
the first item is marked complete or deleted until we get back to the event loop in the jQuery/TodoMVC.
Worked around this limitation by overriding app.getTodo to use each item's id computed in advance.
Also use $.text instead of execCommand('InsertText') in FlightJS/MailClient since Internet Explorer
doesn't support execCommand('InsertText'). Also select the recipient to avoid exceptions.
- DoYouEvenBench/benchmark.html:
- 2:29 PM Changeset in webkit [157008] by
-
- 5 edits in trunk/Source/WebCore
Element ancestor iterator should have a first() for convenience.
<https://webkit.org/b/122425>
Reviewed by Antti Koivisto.
Added an easy way to get the first element ancestor of a certain type
and put it to use in a few places.
- 2:07 PM Changeset in webkit [157007] by
-
- 8 edits in trunk/Source/WebCore
CTTE: FrameLoader::notifier() should return a reference.
<https://webkit.org/b/122424>
Reviewed by Anders Carlsson.
It was just returning the address of an inline member, so we should
use a reference instead. Also made the backpointer to Frame in
ResourceLoadNotifier a reference.
- 1:53 PM Changeset in webkit [157006] by
-
- 2 edits in trunk/Source/WebCore
Avoid layout in window.scroll{Y,X} when at topmost/leftmost position.
<https://webkit.org/b/122423>
Reviewed by Antti Koivisto.
Add a fast path for these properties to skip synchronous layout when
we are just going to return 0 anyway.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
- 1:11 PM Changeset in webkit [157005] by
-
- 7 edits in trunk/Source/WebCore
Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=122421
Reviewed by Andreas Kling.
Replace uses of OwnPtr with std::unique_ptr and get rid of the ContentData::create overloads.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/ContentData.cpp:
(WebCore::ContentData::clone):
- rendering/style/ContentData.h:
(WebCore::ContentData::setNext):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::appendContent):
(WebCore::RenderStyle::setContent):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
- 12:48 PM Changeset in webkit [157004] by
-
- 7 edits in trunk/Source/WebCore
Be a bit shouty about final classes while we look into why the bots don't like it.
- dom/Comment.h:
- dom/ProcessingInstruction.h:
- editing/markup.cpp:
- page/PageSerializer.cpp:
- workers/SharedWorker.h:
- workers/Worker.h:
- 12:35 PM Changeset in webkit [157003] by
-
- 3 edits in trunk/Source/WebCore
Fix windows build.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):
- 12:18 PM Changeset in webkit [157002] by
-
- 47 edits in trunk/Source
CTTE: Thread references through markup.h
https://bugs.webkit.org/show_bug.cgi?id=122403
Reviewed by Darin Adler and Andreas Kling.
Source/WebCore:
Highlights:
- Removed createFragmentFromMarkupWithContext(), it was unused.
- Moved createFragmentFromNodes() into its one caller (in WebKit/mac)
- Add a bunch more toFoo() overloads.
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
(-[DOMNode markupString]):
(-[DOMRange markupString]):
- WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
- 12:01 PM Changeset in webkit [157001] by
-
- 55 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/Modules/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122281
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/Modules/.
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/geolocation/Geolocation.idl:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediasource/WebKitMediaSource.idl:
- Modules/mediasource/WebKitSourceBuffer.idl:
- Modules/mediasource/WebKitSourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.idl:
- Modules/networkinfo/NetworkInfoConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/notifications/NotificationCenter.idl:
- Modules/proximity/DeviceProximityEvent.idl:
- Modules/quota/StorageInfo.idl:
- Modules/quota/StorageQuota.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/speech/SpeechSynthesis.idl:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PannerNode.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/DatabaseSync.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- Modules/websockets/WebSocket.idl:
- 11:47 AM Changeset in webkit [157000] by
-
- 9 edits in trunk/Source/WebCore
Tighten AbstractWorker and subclasses a bit.
<https://webkit.org/b/122402>
Reviewed by Darin Adler.
- Make the Worker and SharedWorker classes final.
- Have constructors take ScriptExecutionContext by reference.
- Remove unnecessary AbstractWorker::contextDestroyed() override.
- Make eventTargetInterface() inline.
Inlining eventTargetInterface() is quite neat - since we only ever
call this on tightly typed pointers from generated code, combining
final and inline turns the virtual call into a compile-time constant.
- 11:18 AM Changeset in webkit [156999] by
-
- 49 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/html/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122280
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/html/.
- html/DOMFormData.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLOutputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLVideoElement.idl:
- html/MediaController.idl:
- html/RadioNodeList.idl:
- html/TimeRanges.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.idl:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrackList.idl:
- 11:16 AM Changeset in webkit [156998] by
-
- 7 edits in trunk/Source
Pass VM instead of ExecState to StringObject constructor.
<https://webkit.org/b/122395>
Reviewed by Sam Weinig.
StringObject() only uses the ExecState to find the VM.
- 11:10 AM Changeset in webkit [156997] by
-
- 32 edits in trunk/Source/WebCore
[WebIIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122279
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/svg/.
- svg/SVGAngle.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGColor.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGException.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGGraphicsElement.idl:
- svg/SVGLength.idl:
- svg/SVGLengthList.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGMatrix.idl:
- svg/SVGNumberList.idl:
- svg/SVGPaint.idl:
- svg/SVGPathElement.idl:
- svg/SVGPathSegList.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPoint.idl:
- svg/SVGPointList.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStringList.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGTransform.idl:
- svg/SVGTransformList.idl:
- 11:07 AM Changeset in webkit [156996] by
-
- 15 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/page/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122278
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/page/.
- page/Console.idl:
- page/Crypto.idl:
- page/DOMSecurityPolicy.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Performance.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResultList.idl:
- page/WindowBase64.idl:
- page/WindowTimers.idl:
- 10:58 AM Changeset in webkit [156995] by
-
- 1 edit6 moves in trunk/LayoutTests
[CSSRegions] Rename parsing tests to match current css properties
https://bugs.webkit.org/show_bug.cgi?id=122413
Reviewed by Sam Weinig.
Simple renaming of files, inline with the current stable version of properties.
- fast/regions/script-tests/webkit-flow-from-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js.
- fast/regions/script-tests/webkit-flow-into-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/webkit-flow-parsing.js.
- fast/regions/webkit-flow-from-parsing-expected.txt: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt.
- fast/regions/webkit-flow-from-parsing.html: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing.html.
- fast/regions/webkit-flow-into-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-parsing-expected.txt.
- fast/regions/webkit-flow-into-parsing.html: Renamed from LayoutTests/fast/regions/webkit-flow-parsing.html.
- 10:52 AM Changeset in webkit [156994] by
-
- 2 edits in trunk/Source/WebCore
- rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle): Added a comment possibly relevant
to current failures seen on Windows bot.
- 10:44 AM Changeset in webkit [156993] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r156988.
http://trac.webkit.org/changeset/156988
https://bugs.webkit.org/show_bug.cgi?id=122415
Broke debug build (Requested by ap on #webkit).
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 10:41 AM Changeset in webkit [156992] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Removed export of non-existent Node::treeScope function returning
a TreeScope*. Probably will have to add an export to fix the next failure.
- 10:37 AM Changeset in webkit [156991] by
-
- 11 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to ShadowValue to generate toCSSShadowValue
https://bugs.webkit.org/show_bug.cgi?id=122409
Reviewed by Darin Adler.
To generate toCSSShadowValue(), we need to add *CSS* prefix to ShadowValue.
It is also to be sync with a naming rule of CSS child value.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForShadow):
- css/CSSParser.cpp:
(WebCore::ShadowParseContext::commitValue):
- css/CSSShadowValue.cpp: Renamed from Source/WebCore/css/ShadowValue.cpp.
(WebCore::CSSShadowValue::CSSShadowValue):
(WebCore::CSSShadowValue::customCSSText):
(WebCore::CSSShadowValue::equals):
- css/CSSShadowValue.h: Renamed from Source/WebCore/css/ShadowValue.h.
(WebCore::CSSShadowValue::create):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createFilterOperations):
- 10:29 AM Changeset in webkit [156990] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/spelling/context-menu-suggestions-multiword-selection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122414
- platform/mac/TestExpectations: Marked as such.
- 10:15 AM Changeset in webkit [156989] by
-
- 16 edits3 deletes in trunk/Source
Remove unneeded ScriptGCEvent class
https://bugs.webkit.org/show_bug.cgi?id=122390
Reviewed by Anders Carlsson.
Source/ThirdParty:
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update this file.
Not really part of this bug fix, but good to land anyway.
Source/WebCore:
- GNUmakefile.list.am: Removed ScriptGCEvent files.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.exp.in: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/ScriptGCEvent.cpp: Removed.
- bindings/js/ScriptGCEvent.h: Removed.
- inspector/InspectorMemoryAgent.cpp: Removed include.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start): Removed GC event listening.
Some day we might add it back, but for now it is dead code.
(WebCore::InspectorTimelineAgent::stop): Ditto.
(WebCore::usedHeapSize): Renamed from getUsedHeapSize and put the
implementation here instead of indirecting through ScriptGCEvent.
(WebCore::InspectorTimelineAgent::setDOMCounters): Updated for above changes.
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): Ditto.
(WebCore::InspectorTimelineAgent::pushCurrentRecord): Ditto.
- inspector/InspectorTimelineAgent.h: Removed include.
- inspector/ScriptGCEventListener.h: Removed.
- testing/MemoryInfo.h: Updated to get heap capacity and size directly
instead of going through ScriptGCEvent.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Replaced symbol from ScriptGCEvent with symbol from JSDOMWindowBase.
- 10:03 AM Changeset in webkit [156988] by
-
- 9 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408
Reviewed by Darin Adler.
As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.
No new tests, no behavior changes.
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 1:37 AM Changeset in webkit [156987] by
-
- 5 edits in trunk/Source/WebCore
CTTE: Teach CompositeEditCommand that link Nodes are always Elements.
<https://webkit.org/b/122400>
Reviewed by Sam Weinig.
Make pushAnchorElementDown() take an Element& instead of a Node* and
tweak the surrounding code a tiny bit.
- 1:37 AM Changeset in webkit [156986] by
-
- 4 edits in trunk/Source/WebCore
CTTE: Node::enclosingLinkEventParentOrSelf() should return an Element.
<https://webkit.org/b/122401>
Reviewed by Sam Weinig.
Only Elements are ever linked, so make enclosingLinkEventParentOrSelf()
return an Element* instead of a Node*. The only call site was already
doing toElement() on the return value without checking, so this makes
things look a bit nicer.
- 12:33 AM Changeset in webkit [156985] by
-
- 10 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and use it
https://bugs.webkit.org/show_bug.cgi?id=122204
Reviewed by Darin Adler.
*CSS* prefix needs to be added to FontFeatureValue class in order to generate toCSSFontFeatureValue().
static_cast<FontFeatureValue*> is changed with toCSSFontFeatureValue() by using this change.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontFeatureValue.cpp: Renamed from Source/WebCore/css/FontFeatureValue.cpp.
(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):
(WebCore::CSSFontFeatureValue::equals):
- css/CSSFontFeatureValue.h: Renamed from Source/WebCore/css/FontFeatureValue.h.
(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):
(WebCore::CSSFontFeatureValue::value):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Oct 5, 2013:
- 9:22 PM Changeset in webkit [156984] by
-
- 51 edits4 adds in trunk/Source/JavaScriptCore
Compress DFG stack layout
https://bugs.webkit.org/show_bug.cgi?id=122024
Reviewed by Oliver Hunt.
The DFG needs to be able to store things at a known offset from frame pointer so that
the runtime can read those things. Prior to this patch, the DFG would use the exact
offsets that the bytecode asked for, even in the case of inlining, where it would use
the callsite stack offset to shift all of the inlined function's variables over just as
they would have been if a bytecode interpreter had really made the call.
But this won't work once WebKit-LLVM integration is complete. LLVM has no notion of
storing things at a fixed offset from the frame pointer. We could try to hack LLVM to do
that, but it would seriously complicate LLVM's stack layout. But what we might be able
to do is have LLVM tell us (via an addressof intrinsic and a side-channel) where some
alloca landed relative to the frame pointer. Hence if the DFG can put all of its flushed
variables in a contiguous range that can be expressed to LLVM as a struct that we
alloca, then all of this can still work just fine.
Previously the flushed variables didn't fit in a contiguous range, but this patch makes
them contiguous by allowing the stack layout to be compressed.
What this really means is that there is now a distinction between where the DFG saw a
variable stored in bytecode and where it will actually store it in the resulting machine
code. Henceforth when the DFG says "local" or "virtual register" it means the variable
according to bytecode (with the stack offsetting for inlined code as before), but when
it says "machine local" or "machine virtual register" it means the actual place where it
will store things in the resulting machine code. All of the OSR exit, inlined arguments,
captured variables, and various stack unwinding machine now knows about all of this.
Note that the DFG's abstract interpretation still uses bytecode variables rather than
machine variables. Same for CSE and abstract heaps. This makes sense since it means that
we don't have to decide on machine variable allocation just to do those optimizations.
The decision of what a local's machine location becomes is deferred to very late in
compilation. We only need to assign machine locations to variables that must be stored
to the stack. It's now mandatory to run some kind of "stack layout phase" that makes the
decision and updates all data structures.
So far the way that this is being used is just to compress the DFG stack layout, which
is something that we should have done anyway, a long time ago. And the compression isn't
even that good - the current StackLayoutPhase just identifies local indices that are
unused in machine code and slides all other variables towards zero. This doesn't achieve
particularly good compression but it is better than nothing. Note that this phase makes
it seem like the bytecode-machine mapping is based on bytecode local indices; for
example if bytecode local 4 is mapped to machine local 3 then it always will be. That's
true for the current StackLayoutPhase but it _will not_ be true for all possible stack
layout phases and it would be incorrect to assume that it should be true. This is why
the current data structures have each VariableAccessData hold its own copy of the
machine virtual register, and also have each InlineCallFrame report their own machine
virtual registers for the various things. The DFG backend is likely to always use the
dumb StackLayoutPhase since it is very cheap to run, but the FTL backend is likely to
eventually get a better one, where we do some kind of constraint-based coloring: we
institute constraints where some VariableAccessData's must have the same indices as some
other ones, and also must be right next to some other ones; then we process all
VariableAccessData's and attempt to assign them machine locals while preserving those
constraints. This could lead to two VariableAccessDatas for the same bytecode local
ending up with different machine locals.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::framePointerOffsetToGetActivationRegisters):
(JSC::CodeBlock::machineSlowArguments):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasSlowArguments):
- bytecode/CodeOrigin.cpp:
(JSC::CodeOrigin::dump):
(JSC::InlineCallFrame::calleeForCallFrame):
(JSC::InlineCallFrame::dumpInContext):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::InlineCallFrame):
(JSC::InlineCallFrame::calleeConstant):
- bytecode/Operands.h:
(JSC::Operands::indexForOperand):
- dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::SSAData::SSAData):
- dfg/DFGBasicBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
- dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDesiredWriteBarriers.cpp:
(JSC::DFG::DesiredWriteBarrier::trigger):
- dfg/DFGDesiredWriteBarriers.h:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
(JSC::DFG::FlushLivenessAnalysisPhase::run):
(JSC::DFG::FlushLivenessAnalysisPhase::process):
(JSC::DFG::FlushLivenessAnalysisPhase::reportError):
- dfg/DFGFlushedAt.cpp: Added.
(JSC::DFG::FlushedAt::dump):
(JSC::DFG::FlushedAt::dumpInContext):
- dfg/DFGFlushedAt.h: Added.
(JSC::DFG::FlushedAt::FlushedAt):
(JSC::DFG::FlushedAt::operator!):
(JSC::DFG::FlushedAt::format):
(JSC::DFG::FlushedAt::virtualRegister):
(JSC::DFG::FlushedAt::operator==):
(JSC::DFG::FlushedAt::operator!=):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::bytecodeRegisterForArgument):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::machineArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
(JSC::DFG::Graph::machineActivationRegister):
(JSC::DFG::Graph::uncheckedMachineActivationRegister):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::machineLocal):
(JSC::DFG::Node::hasUnlinkedMachineLocal):
(JSC::DFG::Node::setUnlinkedMachineLocal):
(JSC::DFG::Node::unlinkedMachineLocal):
(JSC::DFG::Node::hasInlineStartData):
(JSC::DFG::Node::inlineStartData):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
(JSC::DFG::OSREntryReshuffling::OSREntryReshuffling):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::framePointerOffsetToGetActivationRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp: Added.
(JSC::DFG::StackLayoutPhase::StackLayoutPhase):
(JSC::DFG::StackLayoutPhase::run):
(JSC::DFG::performStackLayout):
- dfg/DFGStackLayoutPhase.h: Added.
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::machineLocal):
(JSC::DFG::VariableAccessData::flushedAt):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsInt52):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::virtualRegister):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):
(JSC::FTL::ValueSource::virtualRegister):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::createArguments):
(JSC::StackVisitor::Frame::existingArguments):
- interpreter/StackVisitor.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::offsetOfArgumentsIncludingThis):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::tryDeleteArgument):
(JSC::Arguments::isDeletedArgument):
(JSC::Arguments::isArgument):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):
- runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
- runtime/JSFunction.cpp:
(JSC::RetrieveArgumentsFunctor::operator()):
- 8:16 PM Changeset in webkit [156983] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should be less verbose
https://bugs.webkit.org/show_bug.cgi?id=122397
Reviewed by Sam Weinig.
It now just prints something like:
965/1831 ....
Where the first number is the number of tests that completed, the second number is the
number of tests total, and the dots are the number of tests running right now - which is
useful towards the end when you're waiting for the last slow tests to finish.
It will also print out the output from failing tests and it will print a line for skipped
tests (to annoy you into getting them into a shape where they can be unskipped). For
example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
- Scripts/run-jsc-stress-tests:
- 7:32 PM Changeset in webkit [156982] by
-
- 3 edits in trunk/Source/WebCore
FrameSelection: Remove two unused member functions.
Rubber-stamped by Anders Carlsson.
- rootEditableElementOrTreeScopeRootNode()
- rootEditableElementRespectingShadowTree()
- 7:30 PM Changeset in webkit [156981] by
-
- 45 edits in trunk/Source/WebCore
CTTE: Node::treeScope() should return a reference.
<https://webkit.org/b/122399>
Reviewed by Superlative Sam.
Every Node belongs to a TreeScope. To enforce this, I've made
treeScope() return a TreeScope&, and setTreeScope() now takes a
TreeScope& so there is no way to clear it.
- 6:08 PM Changeset in webkit [156980] by
-
- 45 edits in trunk/Source/WebCore
CTTE: Use references more for the Document parser
https://bugs.webkit.org/show_bug.cgi?id=122398
Reviewed by Andreas Kling.
Clarify the construction semantics of Document parsers.
- 5:34 PM Changeset in webkit [156979] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Default initialize Settings::setFixedPositionCreatesStackingContext() to true
https://bugs.webkit.org/show_bug.cgi?id=122338
<rdar://problem/14908151>
Reviewed by Darin Adler.
On iOS we always want an element with a fixed position to create a stacking context.
See <rdar://problem/9813262> for more details.
- page/Settings.cpp: Define constant defaultFixedPositionCreatesStackingContext to
be true when building for iOS and false otherwise.
- page/Settings.in: Initialize the setting fixedPositionCreatesStackingContext with
the value of the constant defaultFixedPositionCreatesStackingContext.
- 4:59 PM Changeset in webkit [156978] by
-
- 17 edits in trunk/Source
CTTE: Pass DocumentWriter around as a reference
https://bugs.webkit.org/show_bug.cgi?id=122396
Reviewed by Andreas Kling.
../WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::appendBytes):
(WebCore::DecodedDataDocumentParser::flush):
- dom/DecodedDataDocumentParser.h:
- dom/DocumentParser.h:
- dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::flush):
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::appendBytes):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocumentParser::appendBytes):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::writer):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::addData):
(WebCore::DocumentWriter::end):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- loader/SinkDocument.cpp:
(WebCore::SinkDocumentParser::appendBytes):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
../WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]):
- 4:56 PM Changeset in webkit [156977] by
-
- 4 edits in trunk/Source/WebCore
FrameView: Remove code for disabling repaints.
<https://webkit.org/b/122393>
Reviewed by Sam Weinig.
Nobody uses this mode for anything so let's just remove it.
It was added back in r110469 to fix an issue with SVGImageCache
and its only user disappeard in the cache overhaul in r142765.
- 4:53 PM Changeset in webkit [156976] by
-
- 6 edits in trunk
Allow skipping of run-jsc-stress-tests that are configured using yaml files
https://bugs.webkit.org/show_bug.cgi?id=122385
Tools:
Reviewed by Sam Wieinig.
Make tests run via YAML be able to do the parse-for-commands trick that allows
us to skip tests and do other custom per-test stuff.
- Scripts/jsc-stress-test-helpers/layout-test-helper:
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Sam Weinig.
The way that we "skip" tests is by having a custom command at the top using @ notation,
and then use "@ skip". But the machinery to do that also allows us to do things like
run tests in a no-concurrent-JIT mode - so I've also implemented that in this patch.
Use the skip machinery to skip large-expressions.js.
- js/script-tests/large-expressions.js:
- jsc-layout-tests.yaml:
- 4:02 PM Changeset in webkit [156975] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove IFrameShimSupport, it was only used by dead ports.
Rubber-stamped by Anders Carlsson.
- plugins/IFrameShimSupport.cpp: Removed.
- plugins/IFrameShimSupport.h: Removed.
- 3:57 PM Changeset in webkit [156974] by
-
- 34 deletes in trunk
Remove remaining Qt files.
Rubber-stamped by Anders Carlsson.
- 2:57 PM Changeset in webkit [156973] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the GTK+ build.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::platformInitialize):
- 2:53 PM Changeset in webkit [156972] by
-
- 19 edits in trunk/Source
Clean up MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=122392
Reviewed by Andreas Kling.
Source/WebCore:
Update for changes to MessageQueue, mostly changing create functions to return std::unique_ptr.
I intentionally avoided using std::make_unique in a couple of places because I didn't want to make nested classes
public, and I believe that we can change some of this code to use std::function.
- Modules/webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::runLoop):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
- Modules/webaudio/AsyncAudioDecoder.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(WebCore::DatabaseBackend::DatabaseTransactionTask::create):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):
- Modules/webdatabase/DatabaseThread.h:
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
- dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
- fileapi/FileThread.cpp:
(WebCore::FileThread::postTask):
(WebCore::SameInstancePredicate::operator()):
(WebCore::FileThread::runLoop):
- fileapi/FileThread.h:
- fileapi/FileThreadTask.h:
(WebCore::createFileThreadTask):
- storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
- workers/WorkerRunLoop.cpp:
(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::create):
- workers/WorkerRunLoop.h:
Source/WTF:
Make MessageQueue use std::unique_ptr and change findIf and removeIf to take const references.
- wtf/Deque.h:
Change findIf to take an rvalue reference.
- wtf/MessageQueue.h:
(WTF::::append):
(WTF::::appendAndKill):
(WTF::::appendAndCheckEmpty):
(WTF::::prepend):
(WTF::::removeIf):
- 12:27 PM Changeset in webkit [156971] by
-
- 4 edits in trunk/Source/WebCore
[WebGL] program should not be able to link if a bad shader is attached
https://bugs.webkit.org/show_bug.cgi?id=94036
Reviewed by Darin Adler.
If you attempt to link a program when bad shaders are attached, the
link should fail. WebGL also requires that the previously linked
program should remain intact. We were doing the former, but not
the latter.
Fix this by not calling glLinkProgram if we know we have bad
shaders, and synthesize a bad link status instead.
Test: WebGL conformance test conformance/programs/program-test.html
(found in LayoutTests/webgl)
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compileShader): Mark a shader as valid
if it compiled ok.
(WebCore::WebGLRenderingContext::linkProgram): Don't call into GraphicsContext3D::linkProgram
if we know that we don't have valid shaders.
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader): Initialize m_isValid.
- html/canvas/WebGLShader.h:
(WebCore::WebGLShader::isValid): New member variable getter and setter.
(WebCore::WebGLShader::setValid):
- 12:21 PM Changeset in webkit [156970] by
-
- 3 edits in trunk/Source/WebCore
Undo texture unit code refactoring - it is ok to bind a texture to multiple locations
https://bugs.webkit.org/show_bug.cgi?id=122369
<rdar://problem/15158465>
Reviewed by Darin Adler.
The optimisation in r152351 (http://webkit.org/b/117868) incorrectly
assumes that a texture cannot be bound to more than one location.
That's true only within the same program object. It's legal to
address TEXTURE_BINDING_2D and TEXTURE_BINDING_CUBE_MAP with the
same texture in different programs.
See https://github.com/KhronosGroup/WebGL/pull/391 for more information.
This change reverts the optimisation, but also does some minor
cleanup (0 -> nullptr, class -> struct).
Covered by the following Khronos WebGL 1.0.1 tests, which
now pass:
- conformance/more/functions/texImage2DHTML.html
- conformance/more/functions/texSubImage2D.html
- conformance/more/functions/texSubImage2DHTML.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
- html/canvas/WebGLRenderingContext.h:
- 12:02 PM Changeset in webkit [156969] by
-
- 2 edits in trunk/Source/WTF
Try to #define final to sealed when building with MSVC
https://bugs.webkit.org/show_bug.cgi?id=122386
Reviewed by Darin Adler.
- wtf/Compiler.h:
- 11:59 AM Changeset in webkit [156968] by
-
- 34 edits in trunk/Source
Remove createOwned
https://bugs.webkit.org/show_bug.cgi?id=122388
Reviewed by Darin Adler.
Source/JavaScriptCore:
- profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::save):
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):
- dom/Document.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::AnimationController):
- page/animation/AnimationController.h:
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC):
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC):
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/RenderSVGResourceMasker.h:
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlayCreate):
Source/WTF:
Since we're going with std::unique_ptr instead of OwnPtr, there's no need for makeOwned to exist.
Get rid of it and replace it with calls to std::make_unique.
- wtf/FilePrintStream.cpp:
(WTF::FilePrintStream::open):
- wtf/FilePrintStream.h:
- wtf/HashTable.h:
(WTF::::HashTable):
- wtf/ListHashSet.h:
(WTF::::ListHashSet):
- wtf/OwnPtr.h:
- wtf/Threading.cpp:
(WTF::compatEntryPoint):
(WTF::createThread):
- wtf/ThreadingPthreads.cpp:
(WTF::wtfThreadEntryPoint):
(WTF::createThreadInternal):
- wtf/unicode/Collator.h:
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 11:32 AM Changeset in webkit [156967] by
-
- 10 edits in trunk/Source
Remove COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES) since it's required now
https://bugs.webkit.org/show_bug.cgi?id=122387
Reviewed by Anders Carlsson.
Source/WebCore:
- html/canvas/CanvasStyle.h: Take out conditionals.
Source/WebKit2:
- UIProcess/API/cpp/WKRetainPtr.h: Take out conditionals.
Source/WTF:
- wtf/RefPtr.h:
- wtf/RetainPtr.h:
- wtf/Vector.h:
- wtf/text/AtomicString.h:
- wtf/text/WTFString.h:
Take out conditionals.
- 11:31 AM Changeset in webkit [156966] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed GTK build fix after r156946. The framePolicyFunction is an attribute
on the WebKitWebPolicyDecisionPrivate object.
- webkit/webkitwebpolicydecision.cpp:
(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):
- 11:22 AM Changeset in webkit [156965] by
-
- 22 edits in trunk/Source
Add AtomicString::number and use it
https://bugs.webkit.org/show_bug.cgi?id=122384
Reviewed by Anders Carlsson.
Source/WebCore:
- css/CSSGrammar.y.in: Use AtomicString::number instead of String::number since
we are creating an AtomicString. This can save a memory allocation if the string
happens to already be in the atomic string table.
- dom/Element.cpp:
(WebCore::Element::setIntegralAttribute): Ditto.
(WebCore::Element::setUnsignedIntegralAttribute): Ditto.
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Ditto.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto): Use setIntegralAttribute instead of
a local homegrown equivalent.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::setHeight): Ditto.
(WebCore::HTMLCanvasElement::setWidth): Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setTabIndex): Ditto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setHeight): Ditto.
(WebCore::HTMLImageElement::setWidth): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setMaxLength): Ditto.
(WebCore::HTMLInputElement::setSize): Same, but setUnsignedIntegralAttribute.
(WebCore::HTMLInputElement::setHeight): Ditto.
(WebCore::HTMLInputElement::setWidth): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerSetSize): Ditto.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin): More of the same.
(WebCore::HTMLMeterElement::setMax): Ditto.
(WebCore::HTMLMeterElement::setValue): Ditto.
(WebCore::HTMLMeterElement::setLow): Ditto.
(WebCore::HTMLMeterElement::setHigh): Ditto.
(WebCore::HTMLMeterElement::setOptimum): Ditto.
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::setStart): Ditto.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::setValue): Ditto.
(WebCore::HTMLProgressElement::setMax): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute): Ditto.
(WebCore::HTMLSelectElement::setSize): Ditto.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::setColSpan): Ditto.
(WebCore::HTMLTableCellElement::setRowSpan): Ditto.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::setSpan): Ditto.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setMaxLength): Ditto.
(WebCore::HTMLTextAreaElement::setCols): Ditto.
(WebCore::HTMLTextAreaElement::setRows): Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::setDuration): Ditto.
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::number): Added.
- wtf/text/AtomicString.h: Ditto.
- wtf/text/IntegerToStringConversion.h: Simplify includes, renamed ConversionTrait to
IntegerToStringConversionTrait. Changed String version to use String since we no longer
need to use PassRefPtr to efficiently handle return values. Replaced UnsignedIntegerTrait
with std::make_unsigned. Added AtomicString support. Use nullptr instead of 0.
- 11:04 AM Changeset in webkit [156964] by
-
- 16 edits in trunk/Source
Cut down on use of String::number
https://bugs.webkit.org/show_bug.cgi?id=122382
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::putByIndex): Use Identifier::from instead of calling
String::number and creating an identifier from that. Can save creating and then
destroying a string if an identifier already exists.
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlotByIndex): Ditto.
(JSC::Arguments::getOwnPropertyNames): Ditto.
(JSC::Arguments::putByIndex): Ditto.
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::getOwnPropertyNames): Ditto.
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames): Ditto.
Source/WebCore:
- css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::customCSSText): Use StringBuilder::appendNumber,
instead of creating a string and then appending it.
(WebCore::CSSRadialGradientValue::customCSSText): Ditto.
- css/CSSParser.cpp:
(WebCore::CSSParser::createKeyframe): Ditto.
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI): Use ASCII literals instead of
converting numeric constants to strings at runtime with String::number.
(WebCore::DeleteButtonController::show): Ditto.
- svg/SVGNumberList.cpp:
(WebCore::SVGNumberList::valueAsString): Use StringBuilder::appendNumber.
- svg/SVGPointList.cpp:
(WebCore::SVGPointList::valueAsString): Ditto.
- svg/SVGRect.h: Ditto.
Source/WebKit2:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers): Use StringBuilder::appendNumber.
Source/WTF:
- wtf/DateMath.cpp:
(WTF::appendTwoDigitNumber): Added. Replaces twoDigitStringFromNumber, which returned a
String and also allocated a temporary string for any number 10 or higher.
(WTF::makeRFC2822DateString): Updated to use the new function.
- 10:45 AM Changeset in webkit [156963] by
-
- 6 edits in trunk/Source
Test the waters and begin using lambdas
https://bugs.webkit.org/show_bug.cgi?id=121809
Reviewed by Andreas Kling.
Source/WebCore:
Use lambdas instead of static functions and function objects.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::sortedListDump):
Use std::less instead of a custom lessThan function.
- 10:07 AM Changeset in webkit [156962] by
-
- 2 edits8 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selecting text ignoring region content
https://bugs.webkit.org/show_bug.cgi?id=122353
Reviewed by Darin Adler.
Add new reftests for selecting text in texts wrapping a region, where
the region content is ignored. It compares the behavior (highlighted
text and selected content) in regions and absolute positions.
Absolute positioned elements do not fill the gaps on the right during
the selection, unlike regular elements. This is the reason why some
regular elements are floated in order to avoid such problems in the
reftests.
Provided layout tests for different writing models.
- fast/regions/resources/region-style.css: New CSS classes required for these tests.
- fast/regions/selection/selecting-text-ignoring-region-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-rl.html: Added.
- fast/regions/selection/selecting-text-ignoring-region.html: Added.
- 10:06 AM Changeset in webkit [156961] by
-
- 11 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to FontValue to generate toCSSFontValue()
https://bugs.webkit.org/show_bug.cgi?id=122201
Reviewed by Darin Adler.
*CSS* prefix needs to be added to FontValue class in order to generate toCSSFontValue().
static_cast<FontValue*> is changed with toCSSFontValue() by this change.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontValue.cpp: Renamed from Source/WebCore/css/FontValue.cpp.
(WebCore::CSSFontValue::customCSSText):
(WebCore::CSSFontValue::equals):
- css/CSSFontValue.h: Renamed from Source/WebCore/css/FontValue.h.
(WebCore::CSSFontValue::create):
(WebCore::CSSFontValue::CSSFontValue):
- css/CSSParser.cpp:
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 10:02 AM Changeset in webkit [156960] by
-
- 2 edits in trunk/Source/WebKit2
Fix cut and paste errors.
- Configurations/WebKit2.xcconfig:
- 9:55 AM Changeset in webkit [156959] by
-
- 2 edits in trunk/Source/WebKit2
Add the rest of the std::function weak symbols in an attempt to fix the Lion build.
- Configurations/WebKit2.xcconfig:
- 9:48 AM Changeset in webkit [156958] by
-
- 2 edits in trunk/Tools
Unreviewed, fix tests on older Rubies.
- Scripts/run-jsc-stress-tests:
- 9:46 AM Changeset in webkit [156957] by
-
- 4 edits in trunk
Source/WebKit2: Another attempt at fixing the Lion build.
- Configurations/WebKit2.xcconfig:
Tools: Don't filter the weak symbols.
- Scripts/check-for-weak-vtables-and-externals:
- 9:32 AM Changeset in webkit [156956] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to fix the Lion build.
- Configurations/WebKit2.xcconfig:
Try unexporting one of the weak symbols for now. If this succeeds, I'll add the rest.
- 9:27 AM Changeset in webkit [156955] by
-
- 4 edits2 adds in trunk
Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
https://bugs.webkit.org/show_bug.cgi?id=122376
Tools:
Reviewed by Mark Hahnenberg.
- Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
- Scripts/run-javascriptcore-tests:
(printThingsFound):
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg.
Add a yaml file describing which directories contain JS LayoutTests. run-jsc-stress-tests
will use this file.
- jsc-layout-tests.yaml: Added.
- 8:55 AM Changeset in webkit [156954] by
-
- 34 edits in trunk/Source/WebCore
Unreviewed, rolling out r156952.
http://trac.webkit.org/changeset/156952
https://bugs.webkit.org/show_bug.cgi?id=122381
Made svg/custom/large-image-pattern-crash.html assert
(Requested by ap on #webkit).
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::shouldPaintWithinRoot):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
- rendering/RenderBox.h:
- rendering/RenderElement.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paint):
- rendering/RenderLineBreak.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paint):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
(WebCore::RenderReplaced::shouldPaint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTableCol.h:
- rendering/RenderText.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::paint):
(WebCore::RenderView::paintBoxDecorations):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
- rendering/svg/SVGRenderingContext.h:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::rendererClipChild):
- svg/SVGUseElement.h:
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
- 8:01 AM Changeset in webkit [156953] by
-
- 5 edits2 adds in trunk
Need to check if some HTML child elements are HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=120297
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/media/media-disable-crash.html
- dom/make_names.pl:
(printConstructorInterior): Added additional comments about the
wrapperOnlyIfMediaIsAvailable feature.
(printTypeHelpers): Added an isHTMLUnknownElement check to the check helper
functions for tags with the wrapperOnlyIfMediaIsAvailable feature.
(printWrapperFunctions): Instead of redoing the media player check and the
settings check, and possibly making a wrapper of the wrong type, call
isHTMUnknownElement, guaranteeing that the wrapper will match the element
it is wrapping.
- html/HTMLElement.h: Move HTMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can be use the HTMLElement class and
other things defined in this file.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::paused): Added an assertion that made the regression
test reliably assert, rather than intermittently (for me, non-reproducibly) crash.
LayoutTests:
Based on a test written by Zan Dobersek <zdobersek@igalia.com>.
- fast/media/media-disable-crash-expected.txt: Added.
- fast/media/media-disable-crash.html: Added.
- 4:58 AM Changeset in webkit [156952] by
-
- 34 edits in trunk/Source/WebCore
Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371
Reviewed by Darin Adler.
RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.
This also requires some type tightening elsewhere in the code.
- 2:41 AM Changeset in webkit [156951] by
-
- 2 edits28 adds in trunk/PerformanceTests
DoYouEvenBench: Add Facebook's React TodoMVC test case
https://bugs.webkit.org/show_bug.cgi?id=122379
Reviewed by Andreas Kling.
Add React/TodoMVC as a new test case. Somehow we beat Firefox on this one as well.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/todomvc/labs: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Added.
Oct 4, 2013:
- 11:54 PM Changeset in webkit [156950] by
-
- 2 edits in trunk/Source/WebCore
Fix an assertion failure introduced in r156925.
Add HTMLImageElement to the document-wide map only if it's in the document.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
- 11:40 PM Changeset in webkit [156949] by
-
- 2 edits in trunk/Source/WebKit/mac
Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly
https://bugs.webkit.org/show_bug.cgi?id=122329
Reviewed by Darin Adler.
- WebView/WebView.mm: (-[WebView setContinuousSpellCheckingEnabled:]): Don't do any
work if preference didn't change (continuousSpellCheckingEnabled is a static that
starts with false).
- 11:38 PM Changeset in webkit [156948] by
-
- 18 edits2 adds in trunk
text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)
https://bugs.webkit.org/show_bug.cgi?id=21312
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/text/text-transform-turkish-and-azeri.html
This patch covers text-transform: uppercase and text-transform: lowercase.
More changes will be needed to cover text-transform: capitalize.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode): Use String::upper instead of String::makeUpper.
- page/EventHandler.cpp:
(WebCore::findDropZone): Use String::lower instead of String::makeLower.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use String::upper instead of String::makeUpper.
- platform/network/blackberry/rss/RSS10Parser.cpp: [Seriously, how is an RSS parser
part of WebKit's networking layer? Where are the tests that cover this? Seems wrong
to have this code in the project.]
(WebCore::RSS10Parser::parseXmlDoc): Use lower instead of makeLower.
(WebCore::RSS10Parser::parseItem): Ditto.
(WebCore::RSS10Parser::parseFeed): Ditto.
- platform/network/blackberry/rss/RSS20Parser.cpp:
(WebCore::RSS20Parser::parseXmlDoc): Ditto.
(WebCore::RSS20Parser::parseItem): Ditto.
(WebCore::RSS20Parser::parseFeed): Ditto.
(WebCore::RSS20Parser::parseEnclosure): Ditto.
- platform/network/blackberry/rss/RSSAtomParser.cpp:
(WebCore::RSSAtomParser::parseXmlDoc): Ditto.
(WebCore::RSSAtomParser::parseItem): Ditto.
(WebCore::RSSAtomParser::parseFeed): Ditto.
(WebCore::RSSAtomParser::parseLink): Ditto.
(WebCore::RSSAtomParser::parseContent): Ditto.
(WebCore::RSSAtomParser::parseAuthor): Ditto.
(WebCore::RSSAtomParser::parseCategory): Ditto.
- platform/text/win/LocaleWin.cpp:
(WebCore::convertLocaleNameToLCID): Use String::lower instead of String::makeLower.
- rendering/RenderText.cpp:
(WebCore::applyTextTransform): Use String::upper and String::lower instead of
String::makeUpper and String::makeLower, and also pass in the locale to each.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Changed this so it doesn't call
upper just to return an already known string constant.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::doCommand): Use StringImpl::upper instead of
StringImpl::makeUpper.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper): Removed an extra call that would unnecessarily reallocate
a StringImpl in the general non-ASCII case. Added an overload that takes a locale identifier.
(WTF::StringImpl::lower): Ditto.
- wtf/text/StringImpl.h: Ditto.
- wtf/text/WTFString.cpp:
(WTF::String::lower): Ditto.
(WTF::String::upper): Ditto.
- wtf/text/WTFString.h: Ditto. Also deleted the makeLower and makeUpper functions since they
offer no advantages over the lower and upper functions. Also added a constructor that takes
a RefPtr<StringImpl> with move construction to help.
LayoutTests:
- fast/text/text-transform-turkish-and-azeri-expected.html: Added.
- fast/text/text-transform-turkish-and-azeri.html: Added.
- 11:32 PM Changeset in webkit [156947] by
-
- 19 edits8 deletes in trunk
Roll out r156930 and r156937, they caused 34 assertion failures on bots.
- 9:52 PM Changeset in webkit [156946] by
-
- 23 edits in trunk/Source
FramePolicyFunction should be an std::function
https://bugs.webkit.org/show_bug.cgi?id=122362
Reviewed by Darin Adler.
Source/WebCore:
This makes policy callback handling simpler inside WebKit.
- loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- loader/FrameLoaderClient.h:
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchWillSubmitForm):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkitwebpolicydecision.cpp:
(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::receivedPolicyDecision):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
- 9:48 PM Changeset in webkit [156945] by
-
- 6 edits in trunk/Source/WebCore
CTTE: IconController and IconLoader should have Frame& backpointer.
<https://webkit.org/b/122372>
Reviewed by Anders Carlsson.
Also slap IconLoader with FINAL glove.
- 9:30 PM Changeset in webkit [156944] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r156924
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::platformInitialize):
- 9:24 PM Changeset in webkit [156943] by
-
- 2 edits in trunk/Tools
It should be even easier to run and debug a failing JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=122337
Reviewed by Oliver Hunt.
If a test fails, you can now just say:
sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
and get the reproduction. You don't have to set any environment variables like before.
Also if you want to debug the failing test you can now just say:
sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
Broadly, any arguments passed to the reproduction script are prepended to the command to
run the test. This is sort of quirky and won't work for some tests (for example the
profiler tests run a ruby script that runs some other stuff) but it'll work for most of
them and that's good enough for now.
- Scripts/run-jsc-stress-tests:
- 8:50 PM Changeset in webkit [156942] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderScrollbar DOM owner is always an Element.
<https://webkit.org/b/122348>
Reviewed by Antti Koivisto.
When RenderScrollbar is owned by a DOM node, it's always Element.
Tighten the code a bit with this knowledge.
Also marked the class FINAL and beat it with the OVERRIDE stick.
- 8:34 PM Changeset in webkit [156941] by
-
- 7 edits in trunk/Source/WebCore
TypingCommand helpers should take Document&.
<https://webkit.org/b/122370>
Reviewed by Anders Carlsson.
Instead of taking a Document* and immediately asserting that it's
non-null, just take Document&.
- 7:59 PM Changeset in webkit [156940] by
-
- 18 edits in trunk/Source/WebCore
Use more references instead of pointers in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=122368
Reviewed by Andreas Kling.
Use AtomicStringImpl& instead of AtomicString* or AtomicString& to eliminate
assertions and nullity checks.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
- dom/Document.cpp:
(WebCore::Document::addImageElementByLowercasedUsemap):
(WebCore::Document::removeImageElementByLowercasedUsemap):
(WebCore::Document::imageElementByLowercasedUsemap):
- dom/Document.h:
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):
- dom/DocumentOrderedMap.h:
(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):
- dom/Element.cpp:
(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForTreeScope):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::updateLabel):
- dom/IdTargetObserverRegistry.cpp:
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):
- dom/IdTargetObserverRegistry.h:
(WebCore::IdTargetObserverRegistry::notifyObservers):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::removeElementById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::removeElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::removeImageMap):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::addLabel):
(WebCore::TreeScope::removeLabel):
(WebCore::TreeScope::labelElementForId):
- dom/TreeScope.h:
(WebCore::TreeScope::hasElementWithId):
(WebCore::TreeScope::containsMultipleElementsWithId):
(WebCore::TreeScope::hasElementWithName):
(WebCore::TreeScope::containsMultipleElementsWithName):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::removeDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):
(WebCore::HTMLDocument::removeWindowNamedItem):
- html/HTMLDocument.h:
(WebCore::HTMLDocument::documentNamedItem):
(WebCore::HTMLDocument::hasDocumentNamedItem):
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements):
(WebCore::HTMLDocument::windowNamedItem):
(WebCore::HTMLDocument::hasWindowNamedItem):
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::parseAttribute):
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):
- 7:06 PM Changeset in webkit [156939] by
-
- 4 edits in trunk/Source/WebCore
CTTE: PolicyChecker backpointer to Frame should be a reference.
<https://webkit.org/b/122354>
Reviewed by Anders Carlsson.
PolicyChecker is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.
- 6:06 PM Changeset in webkit [156938] by
-
- 3 edits in trunk/Source/WebCore
Editor should use reference-getting document() internally.
<https://webkit.org/b/122364>
Reviewed by Darin Adler.
Instead of grabbing at Editor::m_frame.document(), use the nice
Editor::document() helper that always returns a Document&.
Calling Editor methods on a Frame's editor() while there is no
Document in the Frame is a programming error and this is covered
by an assertion in document().
This removes a bunch of null checks and enables further cleanup.
- 6:03 PM Changeset in webkit [156937] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r156930.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paintCharacter): Use ceilf and floorf to avoid issues
with overload collisions and implicit casts of LayoutUnits.
- 5:51 PM Changeset in webkit [156936] by
-
- 19 edits8 adds in trunk
Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121969.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- debugger/Debugger.cpp:
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callerFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):
(JSC::DebuggerCallFrame::thisValue):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::evaluateWithCallFrame):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::positionForCallFrame):
(JSC::DebuggerCallFrame::sourceIdForCallFrame):
(JSC::DebuggerCallFrame::thisValueForCallFrame):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::create):
(JSC::DebuggerCallFrame::exec):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
(JSC::DebuggerCallFrame::position):
(JSC::DebuggerCallFrame::isValid):
- interpreter/StackVisitor.cpp:
Source/WebCore:
Tests: inspector-protocol/debugger/call-frame-function-name.html
inspector-protocol/debugger/call-frame-this-host.html
inspector-protocol/debugger/call-frame-this-nonstrict.html
inspector-protocol/debugger/call-frame-this-strict.html
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::thisObject):
- bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::type):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::dynamicGlobalObject):
(WebCore::JavaScriptCallFrame::thisValue):
(WebCore::JavaScriptCallFrame::evaluate):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::DebuggerCallFrameScope::DebuggerCallFrameScope):
(WebCore::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentDebuggerCallFrame):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
Source/WebKit/mac:
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
(-[WebScriptCallFrame functionName]):
(-[WebScriptCallFrame exception]):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector-protocol/debugger/call-frame-function-name-expected.txt: Added.
- inspector-protocol/debugger/call-frame-function-name.html: Added.
- inspector-protocol/debugger/call-frame-this-host-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-host.html: Added.
- inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-nonstrict.html: Added.
- inspector-protocol/debugger/call-frame-this-strict-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-strict.html: Added.
- inspector/debugger/pause-in-internal-script-expected.txt:
- 5:40 PM Changeset in webkit [156935] by
-
- 2 edits in trunk/Source/WTF
Remove Qt definitions from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=122349
Reviewed by Anders Carlsson.
- wtf/Platform.h: Remove unused PLATFORM(QT) stanzas from file.
- 5:40 PM Changeset in webkit [156934] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence compiler warning when building 64-bit (on Windows)
Reviewed by Geoffrey Garen.
- jit/JSInterfaceJIT.h: Add a static cast for assignment.
- 5:35 PM Changeset in webkit [156933] by
-
- 2 edits in trunk/Source/WTF
[Win] Turn off FastMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=122352
Reviewed by Darin Adler.
- wtf/Platform.h: Enable USE_SYSTEM_MALLOC when building on
Windows to stick to the MSVCRT allocator/deallocator.
- 5:35 PM Changeset in webkit [156932] by
-
- 18 edits in trunk/Source
Ref-ify more stack guards.
<https://webkit.org/b/122360>
Reviewed by Anders Carlsson.
Make another pass turning RefPtr<T> into Ref<T> where possible.
- 5:26 PM Changeset in webkit [156931] by
-
- 4 edits in trunk/Source/WTF
Remove WTF smart pointers 'const_pointer_cast'
https://bugs.webkit.org/show_bug.cgi?id=122325
Reviewed by Darin Adler.
Removed WTF smart pointers 'const_pointer_cast' functions as:
- they were not used
- their implementation was wrong as they tried to cast to a different pointer type
- wtf/PassOwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RefPtr.h:
- 5:08 PM Changeset in webkit [156930] by
-
- 19 edits8 adds in trunk
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Source/WebCore:
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css:
Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 5:00 PM Changeset in webkit [156929] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r156925. It collided with r156903.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- 4:58 PM Changeset in webkit [156928] by
-
- 2 edits in trunk/Tools
[Windows] Correct run-path when using 64-bit binaries.
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
directory. Otherwise use the existing 'bin32' directory.
- 4:47 PM Changeset in webkit [156927] by
-
- 8 edits in trunk/Source/WebCore
Clean out some FrameLoaderClient hooks that no ports were using.
<https://webkit.org/b/122356>
Reviewed by Anders Carlsson.
Removed the following hooks that were leftovers from dead ports:
- didExhaustMemoryAvailableForScript
- didNotAllowScript
- didNotAllowPlugins
- willCheckAndDispatchMessageEvent
- didChangeName
- dispatchWillInsertBody
- dispatchDidChangeResourcePriority
- 4:34 PM Changeset in webkit [156926] by
-
- 2 edits in trunk/Tools
Teach webkitdirs.pm to honor the --64-bit flag
https://bugs.webkit.org/show_bug.cgi?id=122357
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration): Modify to check if --64-bit is supplied
by the user.
(findMatchingArguments): Added.
(hasArgument): Added.
(checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
findMatchingArguments subroutine.
- 4:33 PM Changeset in webkit [156925] by
-
- 8 edits in trunk/Source/WebCore
FocusController::advanceFocus spends a lot of time in HTMLMapElement::imageElement
https://bugs.webkit.org/show_bug.cgi?id=122313
Reviewed by Andreas Kling.
The bug was caused by HTMLMapElement::imageElement traversing the entire document to look for
the image element associated with a given map element. Because HTMLCollection used to find the
image element is not cached, it traversed the entire document on every area element we visit,
resulting in O(n2) behavior.
Fixed the bug by adding the name-to-image-element map on document to avoid the traversal in
HTMLMapElement::imageElement.
- dom/Document.cpp:
(WebCore::Document::addImageElementByLowercasedUsemap): Added.
(WebCore::Document::removeImageElementByLowercasedUsemap): Added.
(WebCore::Document::imageElementByLowercasedUsemap): Added.
- dom/Document.h: Added m_imagesByUsemap.
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesLowercasedUsemap): Added.
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap): Added.
- dom/DocumentOrderedMap.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Update the name-to-usemap map. The code to parse
the usemap attribute and strip # was moved from HTMLMapElement::imageElement.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesLowercasedUsemap): Added; called by DocumentOrderedMap.
- html/HTMLImageElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement): Call Document::imageElementByUsemap instead of
looking through all image elements in the document.
- 4:25 PM Changeset in webkit [156924] by
-
- 22 edits in trunk/Source
../WebCore: Unify rubberband control
https://bugs.webkit.org/show_bug.cgi?id=122341
Reviewed by Tim Horton.
- Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
- WebCore.exp.in:
- page/Page.cpp:
- page/Page.h:
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::isRubberBandInProgress):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::shouldRubberBandInDirection):
../WebKit2: Unify rubber-band control
https://bugs.webkit.org/show_bug.cgi?id=122341
Reviewed by Tim Horton.
- Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
- Adds SPI to control whether you can rubber band on the left or right edge.
- Add a linked-on-or-after check to control whether we use the legacy implicit rubber band control based on back/forward.
- UIProcess/API/C/WKPage.cpp:
(WKPageRubberBandsAtLeft):
(WKPageSetRubberBandsAtLeft):
(WKPageRubberBandsAtRight):
(WKPageSetRubberBandsAtRight):
(WKPageRubberBandsAtBottom):
(WKPageSetRubberBandsAtBottom):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::rubberBandsAtLeft):
(WebKit::WebPageProxy::setRubberBandsAtLeft):
(WebKit::WebPageProxy::rubberBandsAtRight):
(WebKit::WebPageProxy::setRubberBandsAtRight):
(WebKit::WebPageProxy::rubberBandsAtTop):
(WebKit::WebPageProxy::setRubberBandsAtTop):
(WebKit::WebPageProxy::rubberBandsAtBottom):
(WebKit::WebPageProxy::setRubberBandsAtBottom):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::shouldUseLegacyImplicitRubberBandControl):
(WebKit::WebPageProxy::platformInitialize):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:01 PM Changeset in webkit [156923] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: pressing the Cmd key over a CSS property should underline it immediately (jump to definition mode)
https://bugs.webkit.org/show_bug.cgi?id=119012
Reviewed by Joseph Pecoraro.
We add an "enabled" state to the tokenTrackingController to indicate that we're interested
in tracking hovered tokens. The tokenTrackingController is now only enabled in the
CSSStyleDeclarationTextEditor when the Cmd key is pressed and in the SourceCodeTextEditor
when either the Cmd key is pressed (NonSymbolTokens mode) or when the debugger is paused
(JavaScriptExpression mode).
The tokenTrackingController is now smarter about how it tracks mouse events when it's enabled,
tracking "mouseenter" and "mouseleave" events to enable tracking allowing immediate detection of
tokens being hovered or no longer being hovered even with quick mouse movements. Additioanlly,
using the new top-level mouse coordinates tracking, we can detect a hovered token as soon as
it's being enabled to provide instant feedback to the user.
This new top-level mouse coordinates tracking couple with tracking of modifier keys also fixes
http://webkit.org/b/119011.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed and enable
the tokenTrackingController if we're dealing with a non-read-only editor. When the Cmd key is
released, disable the tokenTrackingController.
- UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.get enabled):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set enabled):
New enabled state for the tokenTrackingController which indicates whether it should be tracking
mouse events to track hovered tokens in the editor. Upon being enabled, the tokenTrackingController
looks up the mouse coordinates continuously tracked at the window level to check for a token
at the last known mouse coordinates in case we're already over a token that may be highlighted.
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightLastHoveredRange):
New public method allowing to highlight the last know candidate range, if any. This is used from
editor code when the Cmd key is pressed and we want to force the last know candidate to be
highlighted.
(WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
(WebInspector.CodeMirrorTokenTrackingController.prototype._stopTracking):
Make these two methods private now that they're automatically called by the "mouseenter" and
"mouseleave" event handling when we're in the "enabled" state. Additionally, the public
"tracking" property has been removed since it is no longer useful to the developer.
(WebInspector.CodeMirrorTokenTrackingController.prototype.handleEvent):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseLeft):
New handlers for the "mouseenter" and "mouseleave" events enabling tracking of hovered tokens.
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOverEditor):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Refactor _mouseMovedOverEditor() into two methods with the new _updateHoveredTokenInfo()
allowing to customize the mouse coordinates to be used since we may call
_updateHoveredTokenInfo() outside of the context of a mouse event (ie. a keypress event).
(WebInspector.CodeMirrorTokenTrackingController.prototype._windowLostFocus):
(WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
New private method combining all the various states that need to be reset when tracking
is turned off, including the removal of the highlighted range if any. This is now called
when the window loses focus.
- UserInterface/Main.js:
(WebInspector.loaded):
(WebInspector._mouseMoved):
Add a new window-level "mousemove" event handler to always track mouse coordinates and key modifier
states. This ensures that we may have the most accurate information possible for key modifiers and
allow code to query the last recorded mouse position in situations where it wouldn't be possible
to have dealt with a mouse event, as is the case when the tokenTrackingController just started tracking.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerEnabled):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._enableJumpToSymbolTrackingModeSettings):
(WebInspector.SourceCodeTextEditor.prototype._disableJumpToSymbolTrackingModeSettings):
Update the "enabled" state on the tokenTrackingController when it may have changed based
on those two conditions: we should have either an active debugger call frame or the
Cmd key should have been pressed. This ensures we only track hovered tokens as needed.
(WebInspector.SourceCodeTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed.
- 3:49 PM Changeset in webkit [156922] by
-
- 4 edits in trunk/Source/WebCore
CTTE: SubframeLoader backpointer to Frame should be a reference.
<https://webkit.org/b/122350>
Reviewed by Anders Carlsson.
SubframeLoader is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.
- 3:46 PM Changeset in webkit [156921] by
-
- 7 edits in trunk/Source
Remove some unneeded code from WidgetMac
https://bugs.webkit.org/show_bug.cgi?id=122355
Reviewed by Dan Bernstein.
Source/WebCore:
Remove code to manage the visible rect, it's not needed anymore.
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::~Widget):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setPlatformWidget):
Source/WebKit/mac:
Remove code to handle the visible rect changing, it's not needed anymore since we always put Netscape plug-ins into their own layers now.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
- 3:45 PM Changeset in webkit [156920] by
-
- 5 edits1 add in trunk/LayoutTests
Update all the tests, and include new file.
- 3:45 PM Changeset in webkit [156919] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL: Add support for ValueToInt32(bool(x))
https://bugs.webkit.org/show_bug.cgi?id=122346
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-04
Reviewed by Geoffrey Garen.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
- 3:41 PM Changeset in webkit [156918] by
-
- 24 edits8 adds in trunk/Source
[iOS] Upstream disk image cache
https://bugs.webkit.org/show_bug.cgi?id=121985
Reviewed by Joseph Pecoraro.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::isUsingDiskImageCache):
- loader/ResourceBuffer.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::canUseDiskImageCache): Added.
(WebCore::CachedImage::useDiskImageCache): Added.
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::isSafeToMakePurgeable):
(WebCore::CachedResource::isUsingDiskImageCache): Added.
- loader/cache/CachedResource.h:
(WebCore::CachedResource::canUseDiskImageCache): Added.
(WebCore::CachedResource::useDiskImageCache): Added.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::flushCachedImagesToDisk): Added.
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
- loader/cache/MemoryCache.h:
(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
- loader/ios/DiskImageCacheClientIOS.h: Added.
- loader/ios/DiskImageCacheIOS.h: Added.
- loader/ios/DiskImageCacheIOS.mm: Added.
- platform/Logging.h:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::~SharedBuffer):
(WebCore::SharedBuffer::isAllowedToBeMemoryMapped): Added.
(WebCore::SharedBuffer::allowToBeMemoryMapped): Added.
(WebCore::SharedBuffer::failedMemoryMap): Added.
(WebCore::SharedBuffer::markAsMemoryMapped): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallbackData): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::setMemoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::buffer):
(WebCore::SharedBuffer::getSomeData):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::isMemoryMapped): Added.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
- ios/WebCoreSupport/WebDiskImageCacheClientIOS.h: Added.
- ios/WebCoreSupport/WebDiskImageCacheClientIOS.mm: Added.
Source/WebKit/mac:
- Misc/WebCache.mm:
(+[WebCache statistics]):
- WebView/WebDataSource.mm:
(BufferMemoryMapped): Added.
(-[WebDataSource _setAllowToBeMemoryMapped]): Added.
(-[WebDataSource setDataSourceDelegate:]): Added.
(-[WebDataSource dataSourceDelegate]): Added.
(-[WebDataSource dealloc]):
- WebView/WebDataSourcePrivate.h: Declared private delegate
protocol, WebDataSourcePrivateDelegate.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences diskImageCacheEnabled]): Added.
(-[WebPreferences setDiskImageCacheEnabled:]): Added.
(-[WebPreferences diskImageCacheMinimumImageSize]): Added.
(-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
(-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
(-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
(-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
(-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
- 3:25 PM Changeset in webkit [156917] by
-
- 2 edits in trunk/Tools
Update svn-config for new Visual Studio extensions
https://bugs.webkit.org/show_bug.cgi?id=122344
Reviewed by Brent Fulgham.
- svn-config: Add new Visual Studio extensions.
- 3:25 PM Changeset in webkit [156916] by
-
- 4 edits2 adds in trunk
[CSS Shapes] Basic shapes should be animatable for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=122343
Reviewed by Dirk Schulze.
Source/WebCore:
Test: fast/shapes/shape-outside-floats/shape-outside-animation.html
Add shape outside to the list of animatable properties. The infrastructure
is already in place for animating basic shapes on shape-inside and clipping
paths. See https://bugs.webkit.org/show_bug.cgi?id=101854.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
LayoutTests:
Add tests checking that shape-outside basic shape values correctly tween
between values.
- animations/resources/animation-test-helpers.js:
(getPropertyValue): Add shape-outside to list of properties that do not parse
with the default behavior.
(comparePropertyValue): Compare shape-outsides after parsing their shape notation.
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-animation.html: Added.
- 3:22 PM Changeset in webkit [156915] by
-
- 4 edits in trunk/Source/WebCore
Tighten typing in some RenderLayer code.
<https://webkit.org/b/122342>
Reviewed by Antti Koivisto.
Use tighter types instead of Node and RenderObject inside RenderLayer
where applicable.
- 2:59 PM Changeset in webkit [156914] by
-
- 3 edits6 adds in trunk/LayoutTests
[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
https://bugs.webkit.org/show_bug.cgi?id=122327
Reviewed by Alexandru Chiculita.
Add versions for other writing modes (horizontal-bt, vertical-lr and
vertical-rl) for test
fast/regions/selection/selecting-text-in-2-regions.html.
- fast/regions/resources/helper.js:
(selectContentByIdsVert): Add new method when selecting context in a
vertical writing mode.
- fast/regions/resources/region-style.css: Add some new CSS classes for
vertical writing mode.
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
Added.
- 2:52 PM Changeset in webkit [156913] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 1:46 PM Changeset in webkit [156912] by
-
- 3 edits2 adds in trunk
Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-04
Reviewed by Antti Koivisto.
Change CSSStyleSheet::didMutateRules to not invalidate all node's styles when inserting a
@-webkit-keyframes rule, and to instead insert the rule directly into the StyleResolver.
Test: animation/keyframes-dynamic.html: adds and removes keyframe rules using JavaScript and
validates that the correct elements are animated.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):
- css/CSSStyleSheet.h:
- 1:37 PM Changeset in webkit [156911] by
-
- 5 edits1 add in trunk/Tools
Made WinLauncher have better error handling, crash reporting, and modifiability.
https://bugs.webkit.org/show_bug.cgi?id=122319
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-04
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.cpp:
(WinLauncherWebHost::didFailProvisionalLoadWithError):
Don't display the numerous "Cancelled" messages that are obviously from the user.
(createCrashReport): Added.
(dllLauncherEntryPoint):
Made main loop back into while loop and write a crash report if it crashes.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
Added WinLauncherReplace.h.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
Added linking to DbgHelp.lib.
- WinLauncher/WinLauncherReplace.h:
Added to make modifying WinLauncher behaviour and appearance easy.
(processCrashDump): Added.
- 1:35 PM Changeset in webkit [156910] by
-
- 29 edits11 adds in trunk
Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add support for for-of syntax to JSC. As part of doing this I had to make
us support unique empty strings as identifiers. In a follow on patch i'm
going to remove the distinction entirely as it's purely a complicating
separation.
Otherwise the logic here is fairly self-explanatory.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitCall):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
- jit/JITOperations.cpp:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createForOfLoop):
- parser/NodeConstructors.h:
(JSC::EnumerationNode::EnumerationNode):
(JSC::ForInNode::ForInNode):
(JSC::ForOfNode::ForOfNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
- parser/Parser.h:
(JSC::Parser::isofToken):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForOfLoop):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorPrototypeIterate):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::finishCreation):
- runtime/ArrayPrototype.h:
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::from):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContext):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
- runtime/PrivateName.h:
(JSC::PrivateName::PrivateName):
- runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
Source/WTF:
Update assertions and add a helper function to StringImpl
to save repeated unique or identifier calls.
- wtf/text/StringImpl.h:
(WTF::StringImpl::isIdentifierOrUnique):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::setIsAtomic):
LayoutTests:
Add test cases for the one type that supports for-of so far
- js/basic-for-of-expected.txt: Added.
- js/basic-for-of.html: Added.
- js/regress/for-of-iterate-array-entries.html: Added.
- js/regress/for-of-iterate-array-keys.html: Added.
- js/regress/for-of-iterate-array-values.html: Added.
- js/regress/script-tests/for-of-iterate-array-entries.js: Added.
(foo):
- js/regress/script-tests/for-of-iterate-array-keys.js: Added.
(foo):
- js/regress/script-tests/for-of-iterate-array-values.js: Added.
(foo):
- 1:33 PM Changeset in webkit [156909] by
-
- 6 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/fileapi/.
- fileapi/Blob.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- 1:31 PM Changeset in webkit [156908] by
-
- 47 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/dom/.
- dom/CharacterData.idl:
- dom/ChildNode.idl:
- dom/ClientRectList.idl:
- dom/Clipboard.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DOMStringMap.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/MutationObserver.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeIterator.idl:
- dom/NodeList.idl:
- dom/Range.idl:
- dom/RangeException.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/TouchList.idl:
- dom/TreeWalker.idl:
- dom/UIEvent.idl:
- dom/WebKitNamedFlow.idl:
- dom/WheelEvent.idl:
- 1:22 PM Changeset in webkit [156907] by
-
- 12 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/xml/.
- xml/DOMParser.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestUpload.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathException.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- xml/XSLTProcessor.idl:
- 12:36 PM Changeset in webkit [156906] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
https://bugs.webkit.org/show_bug.cgi?id=122336
Reviewed by Geoffrey Garen.
Changed code in change set r156900 to use the operand() accessor instead of operator[].
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- 12:31 PM Changeset in webkit [156905] by
-
- 4 edits4 adds in trunk
[CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197
Reviewed by Alexandru Chiculita.
Source/WebCore:
Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html
When shape outside is modified, dependent content needs to relayout. This patch
removes the float from the float lists and marks dependents for layout using
RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
method used when switching from float: left to float: right and vice versa
(see RenderElement::styleWillChange).
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
for layout.
- rendering/RenderBox.h:
(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
affected by this shape-outside for relayout.
LayoutTests:
Test that a shape can be dynamically added, modified, or removed and that
content does a proper relayout.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.
- 12:22 PM Changeset in webkit [156904] by
-
- 5 edits in trunk/Source/WebCore
Tighten markContainingBlocksForLayout
https://bugs.webkit.org/show_bug.cgi?id=122326
Reviewed by Anders Carlsson.
- 11:51 AM Changeset in webkit [156903] by
-
- 98 edits in trunk/Source/WebCore
Node: removedFrom() and insertedInto() should use references.
<https://webkit.org/b/122315>
Reviewed by Anders Carlsson.
ContainerNode* -> ContainerNode&
- 11:41 AM Changeset in webkit [156902] by
-
- 2 edits in trunk/Source/WebCore
Optimize strings copies in srcset parser
https://bugs.webkit.org/show_bug.cgi?id=121899
Patch by Romain Perier <Romain Perier> on 2013-10-04
Reviewed by Alexey Proskuryakov.
No new tests, covered by existing ones.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
image.imageURL at each loop iteration, save indexes instead.
(WebCore::bestFitSourceForImageAttributes): Make a String for
the URL only when the corresponding candidate is chosen
by the selection algorithm. It reduces the number of copies
significantly and improves performance
(around 30% with the "Release" profile and 60% with the "Debug" one).
- 11:40 AM Changeset in webkit [156901] by
-
- 14 edits4 moves in trunk/LayoutTests
Tests added in r141354 erroneously assume correction suggestion to be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742
Reviewed by Ryosuke Niwa.
Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.
Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.
However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.
- editing/spelling/resources/util.js:
(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-changed-text.html:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-double-clicked-word.html:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-exactly-selected-word.html:
Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
- editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
- editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.
Adapt those tests for platforms which populate spell check suggestion
in the context menu.
- platform/efl-wk2/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Update tests path due to rename.
- 11:38 AM Changeset in webkit [156900] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index
https://bugs.webkit.org/show_bug.cgi?id=122332
Reviewed by Oliver Hunt.
Changed the uses of .offset(), which returns a negative number for locals, to be
toLocal() which returns a local's ordinal number.
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- 11:34 AM Changeset in webkit [156899] by
-
- 2 edits in trunk/Tools
remove dpranke from webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=122331
Reviewed by Brent Fulgham.
- Scripts/webkitpy/common/config/watchlist:
- 11:30 AM Changeset in webkit [156898] by
-
- 3 edits in trunk/Tools
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299
Reviewed by Beth Dakin.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
- 11:26 AM Changeset in webkit [156897] by
-
- 2 edits in trunk/Tools
Watchlist is broken after <http://trac.webkit.org/r156880>
- Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
- 11:20 AM Changeset in webkit [156896] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add callOperation to Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122306
Reviewed by Geoffrey Garen.
Created baseline JIT compatible versions for a few flavors of callOperation().
Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).
- dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
- dfg/DFGOperations.h:
- jit/JIT.h:
(JSC::JIT::appendCall):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_regexp):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- 11:20 AM Changeset in webkit [156895] by
-
- 29 edits3 deletes in trunk/Tools
Remove Qt features from build and test tools
https://bugs.webkit.org/show_bug.cgi?id=122312
Reviewed by Anders Carlsson.
- Scripts/build-dumprendertree:
- Scripts/build-jsc:
- Scripts/build-webkit:
- Scripts/build-webkittestrunner:
- Scripts/old-run-webkit-tests:
(openDumpTool):
(buildPlatformResultHierarchy):
(buildPlatformTestHierarchy):
(readSkippedFiles):
- Scripts/run-launcher:
- Scripts/run-qtwebkit-tests: Removed.
- Scripts/run-webkit-tests:
(useNewRunWebKitTests):
- Scripts/update-webkit:
- Scripts/webkit-build-directory:
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(setupCygwinEnv):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_virtual_ports_filtered):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_reviewer_text):
- Scripts/webkitpy/common/config/watchlist:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port._port_flag_for_scripts):
(Port._wk2_port_name):
- Scripts/webkitpy/port/builders.py:
- Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
(PortFactory._default_port):
- Scripts/webkitpy/port/factory_unittest.py:
(FactoryTest.test_gtk):
- Scripts/webkitpy/port/qt.py: Removed.
- Scripts/webkitpy/port/qt_unittest.py: Removed.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker):
- Scripts/webkitpy/style/checkers/cpp.py:
(_classify_include):
(check_include_line):
(check_identifier_name_in_declaration):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_classify_include):
(WebKitStyleTest.test_names):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
- Scripts/webkitpy/tool/main.py:
(WebKitPatch):
- 10:00 AM Changeset in webkit [156894] by
-
- 2 edits in trunk/Source/WebCore
Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
show up as unversioned all the time.
- inspector/Scripts: Added property svn:ignore.
- 9:15 AM Changeset in webkit [156893] by
-
- 2 edits in trunk/Source/WebCore
[Win][WebGL] Crash on exit
https://bugs.webkit.org/show_bug.cgi?id=120764
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
Reviewed by Martin Robinson.
On exit, libGLESv2.dll is detached from the process and relevant memory is released
before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
The GL context cleanup code was originally written to avoid a X server crash on exit,
so it's only needed for PLATFORM(X11).
- platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):
- 9:14 AM Changeset in webkit [156892] by
-
- 6 edits in trunk
[GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.
- GNUmakefile.list.am:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
- UIProcess/API/gtk/PageClientImpl.h:
LayoutTests:
- platform/gtk-wk2/TestExpectations: Corrected the expectations
with the new results.
- 9:02 AM Changeset in webkit [156891] by
-
- 6 edits2 adds in trunk
[CSSRegions] Regions as stacking contexts should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122321
Reviewed by Alexandru Chiculita.
Source/WebCore:
Test: fast/regions/layers/region-normalflow-stacking-context.html
Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
LayoutTests:
Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.
- fast/regions/autoheight-regions-mark-expected.txt:
- fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
- fast/regions/layers/region-normalflow-stacking-context.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- 8:26 AM Changeset in webkit [156890] by
-
- 3 edits1 delete in trunk/Source/WebKit
Remove WebAssertions.h
https://bugs.webkit.org/show_bug.cgi?id=122328
Reviewed by Jessie Berlin.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Misc/WebAssertions.h: Removed.
- 8:22 AM Changeset in webkit [156889] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Remove failure expectations from tests that are passing.
- platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
- platform/efl/TestExpectations:
- 7:22 AM Changeset in webkit [156888] by
-
- 4 edits in trunk
[EFL] Enable correct behaviour for deleting regional indicator symbols
https://bugs.webkit.org/show_bug.cgi?id=122209
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
Reviewed by Gyuyoung Kim.
Source/WebCore:
Regional indicator symbols that are combined should behave as a single character when deleting.
Removed unused variable initialState.
- rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):
LayoutTests:
Now editing/deleting/regional-indicators.html is passing on EFL port.
- platform/efl/TestExpectations:
- 7:16 AM Changeset in webkit [156887] by
-
- 12 edits in trunk/Source/WebKit2
Remove Qt leftovers from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122317
Patch by Sergio Correia <Sergio Correia> on 2013-10-04
Reviewed by Anders Carlsson.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
- Shared/API/c/WKBase.h:
- Shared/NativeWebTouchEvent.h:
- UIProcess/API/C/WebKit2_C.h:
- UIProcess/BackingStore.h:
- UIProcess/InspectorServer/WebInspectorServer.cpp:
(WebKit::WebInspectorServer::inspectorUrlForPageID):
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/WebSocketServer.cpp:
- UIProcess/InspectorServer/WebSocketServer.h:
- UIProcess/WebPageProxy.cpp:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPaint):
- 5:23 AM Changeset in webkit [156886] by
-
- 21 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122276
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/css/.
- css/CSSHostRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSSupportsRule.idl:
- css/CSSValueList.idl:
- css/DOMWindowCSS.idl:
- css/FontLoader.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- css/WebKitCSSTransformValue.idl:
- 4:59 AM Changeset in webkit [156885] by
-
- 2 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/loader/appcache/.
- loader/appcache/DOMApplicationCache.idl:
- 4:55 AM Changeset in webkit [156884] by
-
- 4 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122273
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/plugins/.
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- 4:51 AM Changeset in webkit [156883] by
-
- 3 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122272
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/storage/.
- storage/Storage.idl:
- storage/StorageEvent.idl:
- 4:41 AM Changeset in webkit [156882] by
-
- 5 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122270
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/workers/.
- workers/DedicatedWorkerGlobalScope.idl:
- workers/Worker.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- 1:49 AM Changeset in webkit [156881] by
-
- 5 edits2 adds in trunk
[CSS Regions] Infinite loop when computing widows
https://bugs.webkit.org/show_bug.cgi?id=122215
Reviewed by David Hyatt.
Source/WebCore:
The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
break a block more than once to account for widows. This can happen if, for example, some lines are moved
to the next container and there the content breaks in another container again without respecting the widows property.
This is in line with the idea of not leaving empty fragmentation containers during layout.
Test: fast/regions/regions-widows-stack-overflow.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
flag to m_didBreakAtLineToAvoidWidow.
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
LayoutTests:
Test there is no stack overflow when trying to break for widows that are caused by other widows.
- fast/regions/regions-widows-stack-overflow-expected.html: Added.
- fast/regions/regions-widows-stack-overflow.html: Added.
