Timeline
Oct 28, 2013:
- 10:18 PM Changeset in webkit [158181] by
-
- 5 edits in trunk/Source/WebCore
applyTextTransform() should take a const RenderStyle&.
<https://webkit.org/b/123434>
This function is always called with an existing RenderStyle object.
Reviewed by Anders Carlsson.
- 10:14 PM Changeset in webkit [158180] by
-
- 19 edits in trunk/Source/WebCore
RenderSVGResource::applyResource() should take a const RenderStyle&.
<https://webkit.org/b/123433>
These functions are always called with an existing RenderStyle object
so let them take a const reference instead of a raw pointer.
Also sprinkled some missing OVERRIDEs.
Reviewed by Anders Carlsson.
- 10:13 PM Changeset in webkit [158179] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix bug URL in ChangeLog.
- 10:09 PM Changeset in webkit [158178] by
-
- 6 edits in trunk/Source/WebCore
Remove unused RenderTextControl::textBaseStyle().
<https://webkit.org/b/123423>
Reviewed by Anders Carlsson.
- 9:42 PM Changeset in webkit [158177] by
-
- 2 edits in trunk/LayoutTests
Fix path for xss-DENIED-xsl-document-redirect test, and mark
editing/selection/5057506-2.html as image-only failure.
- platform/mac-wk2/TestExpectations:
- 9:38 PM Changeset in webkit [158176] by
-
- 2 edits in trunk/Tools
Floating left the header broke other pages, and this CSS has no way to customize
per-page.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
- 9:34 PM Changeset in webkit [158175] by
-
- 2 edits in trunk/Tools
Remove underlines on the bot names in the header.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(td.LastBuild a):
- 9:33 PM Changeset in webkit [158174] by
-
- 3 edits1 add in trunk/Tools
Add EFL release bots to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=123430
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
- 9:32 PM Changeset in webkit [158173] by
-
- 2 edits in trunk/Tools
More waterfall tweaking.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body > .header):
(td.LastBuild):
(td.LastBuild a):
(td.LastBuild,td.Activity a,td.Change a,td.Builder a):
- 9:27 PM Changeset in webkit [158172] by
-
- 2 edits in trunk/Tools
More waterfall tweaking.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
(body > hr):
(div.content h1):
(body > .header):
(td.Activity a,td.Change a,td.Builder a):
(td.Builder):
- 9:20 PM Changeset in webkit [158171] by
-
- 51 edits in trunk/Source/WebCore
HTML input type objects should be managed through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123160
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-28
Reviewed by Darin Adler.
Make the constructors of the InputType subclasses public. This makes it possible to use std::make_unique on these classes
and makes the T::create() helpers redundant. New instances of these classes are now managed through std::unique_ptr.
InputType::create() now uses a NeverDestroyed InputTypeFactoryMap that maps type names to InputTypeFactoryFunctions and
gets populated when the method is first called and the map is still empty. Certain types are not added to the factory map
if they're disabled at runtime.
The factory is used to create the new InputType object if the requested type was found in the map, and TextInputType is used otherwise.
- html/ButtonInputType.cpp:
- html/ButtonInputType.h:
(WebCore::ButtonInputType::ButtonInputType):
- html/CheckboxInputType.cpp:
- html/CheckboxInputType.h:
(WebCore::CheckboxInputType::CheckboxInputType):
- html/ColorInputType.cpp:
- html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType):
- html/DateInputType.cpp:
- html/DateInputType.h:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
(WebCore::DateTimeInputType::DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
- html/DateTimeLocalInputType.h:
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
- html/EmailInputType.cpp:
- html/EmailInputType.h:
(WebCore::EmailInputType::EmailInputType):
- html/FileInputType.cpp:
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/HTMLInputElement.h:
- html/HiddenInputType.cpp:
- html/HiddenInputType.h:
(WebCore::HiddenInputType::HiddenInputType):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::ImageInputType):
- html/ImageInputType.h:
- html/InputType.cpp:
(WebCore::createInputType): A templated helper that constructs a new InputType subclass object through std::make_unique.
(WebCore::populateInputTypeFactoryMap): Populates the passed-in map with type-createInputType<T> pairs.
(WebCore::InputType::create): Get the InputTypeFactoryFunction for the specified type, or fall back to TextInputType.
(WebCore::InputType::createText):
- html/InputType.h:
- html/MonthInputType.cpp:
- html/MonthInputType.h:
(WebCore::MonthInputType::MonthInputType):
- html/NumberInputType.cpp:
- html/NumberInputType.h:
(WebCore::NumberInputType::NumberInputType):
- html/PasswordInputType.cpp:
- html/PasswordInputType.h:
(WebCore::PasswordInputType::PasswordInputType):
- html/RadioInputType.cpp:
- html/RadioInputType.h:
(WebCore::RadioInputType::RadioInputType):
- html/RangeInputType.cpp:
- html/RangeInputType.h:
- html/ResetInputType.cpp:
- html/ResetInputType.h:
(WebCore::ResetInputType::ResetInputType):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
- html/SearchInputType.h:
- html/SubmitInputType.cpp:
- html/SubmitInputType.h:
(WebCore::SubmitInputType::SubmitInputType):
- html/TelephoneInputType.cpp:
- html/TelephoneInputType.h:
(WebCore::TelephoneInputType::TelephoneInputType):
- html/TextInputType.cpp:
- html/TextInputType.h:
(WebCore::TextInputType::TextInputType):
- html/TimeInputType.cpp:
- html/TimeInputType.h:
- html/URLInputType.cpp:
- html/URLInputType.h:
(WebCore::URLInputType::URLInputType):
- html/WeekInputType.cpp:
- html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):
- 9:19 PM Changeset in webkit [158170] by
-
- 24 edits in trunk/Source
Refactor IDB factory creation.
https://bugs.webkit.org/show_bug.cgi?id=123347
Reviewed by Andreas Kling.
- Rework how database directory location is passed around.
- Make (some) SecurityOrigin arguments be references instead of pointers.
- Add two SecurityOrigin arguments to opening databases for future use.
Source/WebCore:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/PageGroupIndexedDatabase.cpp:
(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):
- Modules/indexeddb/PageGroupIndexedDatabase.h:
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:
(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::open):
(WebCore::IDBBackingStoreLevelDB::openInMemory):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendLevelDB::IDBFactoryBackendLevelDB):
(WebCore::IDBFactoryBackendLevelDB::getDatabaseNames):
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::openBackingStore):
(WebCore::IDBFactoryBackendLevelDB::open):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
(WebCore::IDBFactoryBackendLevelDB::create):
- WebCore.exp.in:
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend):
- platform/DatabaseStrategy.h:
Source/WebKit2:
- Shared/Databases/IndexedDB/IDBUtilities.cpp:
(WebKit::uniqueDatabaseIdentifier):
- Shared/Databases/IndexedDB/IDBUtilities.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::open):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
(WebKit::WebIDBFactoryBackend::create):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 9:16 PM Changeset in webkit [158169] by
-
- 3 edits in trunk/Tools
Apply changes to default.css, revert buildbot.css which seems to be unused.
- BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
(body):
(body, td):
(a:link,a:visited,a:active):
(td.Time):
(td.Activity):
(.exception, td.offline):
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
(.auth):
(td.LastBuild):
(td.Time):
(td.Activity):
(.offline,td.offline,.retry):
- 9:03 PM Changeset in webkit [158168] by
-
- 2 edits in trunk/Tools
Prettify the waterfall page, and make it a little more space-efficient.
- BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
(body, td):
(body.interface):
(.auth):
(.header):
(div.content h1):
(a):
(a:link,a:active):
(a:link,a:visited,a:active):
(td.LastBuild):
(td.Time):
(td.Activity):
(.exception, td.offline, .retry):
- 8:29 PM Changeset in webkit [158167] by
-
- 2 edits in trunk/Tools
Fix Lion readableName (spotted by Dan Bernstein).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- 8:18 PM Changeset in webkit [158166] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r157561. <rdar://problem/15292382>
- 8:10 PM Changeset in webkit [158165] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r157298. <rdar://problem/15292359>
- 8:05 PM Changeset in webkit [158164] by
-
- 4 edits4 copies in branches/safari-537.73-branch
Merged r155554. <rdar://problem/15292361>
- 7:58 PM Changeset in webkit [158163] by
-
- 260 edits in trunk/Source
RenderElement::style() should return a reference.
<https://webkit.org/b/123414>
Now that renderers always have style, go ahead and make style()
return a RenderStyle&.
There are countless opportunities for further cleanup enabled by
this change. I'm simply passing &style() in many cases where we
can really do something nicer instead.
Reviewed by Anders Carlsson.
- 7:52 PM Changeset in webkit [158162] by
-
- 7 edits2 copies in branches/safari-537.73-branch
Merged r155665. <rdar://problem/15109475>
- 7:45 PM Changeset in webkit [158161] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155664. <rdar://problem/15168243>
- 7:45 PM Changeset in webkit [158160] by
-
- 10 edits in trunk/Source
Make TileController create the appropriate PlatformCALayer subclasses
https://bugs.webkit.org/show_bug.cgi?id=123418
Reviewed by Simon Fraser.
Add PlatformCALayer::createCompatibleLayer, which is overridden in
each of the subclasses to create a PlatformCALayer instance of the same
subclass. This is used in TileController to make bare PlatformCALayers
of the correct type (Mac, Win, or Remote).
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::createCompatibleLayer):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::createCompatibleLayer):
- platform/graphics/ca/win/PlatformCALayerWin.h:
Add createCompatibleLayer and implement it in the subclasses.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tiledScrollingIndicatorLayer):
(WebCore::TileController::createTileLayer):
Make use of createCompatibleLayer when creating PlatformCALayers.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::createCompatibleLayer):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Add createCompatibleLayer and implement it in the subclasses.
- 7:38 PM Changeset in webkit [158159] by
-
- 13 edits2 adds in trunk
Web Inspector: CSS Regions: Add protocol API to expose content nodes addition/removal
https://bugs.webkit.org/show_bug.cgi?id=123424
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector-protocol/model/content-flow-content-nodes.html
Adding two new inspector-protocol APIs to handle the cases when new elements are
added or removed from a named flow. These APIs will trigger even though there
is no region associated with the named flow.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElementImpl):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElementImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
Source/WebInspectorUI:
Exposed the new CSS Agent events to the ContentFlow class that will now maintain
a list of nodes in the "contentNodes" property.
- UserInterface/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionOversetChanged):
(WebInspector.CSSObserver.prototype.registeredNamedFlowContentElement):
(WebInspector.CSSObserver.prototype.unregisteredNamedFlowContentElement):
- UserInterface/ContentFlow.js:
(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.set overset):
(WebInspector.ContentFlow.prototype.get contentNodes):
(WebInspector.ContentFlow.prototype.insertContentNodeBefore):
(WebInspector.ContentFlow.prototype.appendContentNode):
(WebInspector.ContentFlow.prototype.removeContentNode):
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):
(WebInspector.DOMTreeManager.prototype.registeredNamedFlowContentElement):
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
- UserInterface/InspectorBackendCommands.js:
LayoutTests:
Added test to check that the two new events are triggered correctly and can be used to maintain
the flow content nodes list on the inspector side.
- inspector-protocol/model/content-flow-content-nodes-expected.txt: Added.
- inspector-protocol/model/content-flow-content-nodes.html: Added.
- 7:37 PM Changeset in webkit [158158] by
-
- 7 edits2 deletes in branches/safari-537.73-branch
rollout r158067.
- 7:13 PM Changeset in webkit [158157] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r156099. <rdar://problem/15168245>
- 7:10 PM Changeset in webkit [158156] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r156479. <rdar://problem/15168235>
- 7:07 PM Changeset in webkit [158155] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r156222. <rdar://problem/15168254>
- 7:05 PM Changeset in webkit [158154] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r157231. <rdar://problem/15333294>
- 6:53 PM Changeset in webkit [158153] by
-
- 2 edits in branches/safari-537.73-branch/WebKitLibraries
Merged r157608. <rdar://problem/15323809>
- 6:50 PM Changeset in webkit [158152] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r155717. <rdar://problem/15292366>
- 6:38 PM Changeset in webkit [158151] by
-
- 3 edits in trunk/Tools
Add tooltips to the platform icons in Dashboard
https://bugs.webkit.org/show_bug.cgi?id=123429
Reviewed by Alexey Proskuryakov.
Add a human readable name to Buildbot.Platform entries, and use it to
show a tooltip on the ring image.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
- 6:38 PM Changeset in webkit [158150] by
-
- 2 edits in trunk/LayoutTests
Last few Mavericks WK2 failures.
- platform/mac-wk2/TestExpectations:
- 6:34 PM Changeset in webkit [158149] by
-
- 6 edits in branches/safari-537.73-branch
Merged r157830. <rdar://problem/15303898>
- 6:15 PM Changeset in webkit [158148] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Debug build correction after r158124.
- runtime/JSObject.h:
(JSC::JSObject::setStructure): Use external hasIndexingHeader function since
the member function did not exist at the time of this branch.
- 5:56 PM Changeset in webkit [158147] by
-
- 1 edit1 delete in trunk/Source/WebCore
Web Inspector: Remove unused inspector/inline-javascript-imports.py
https://bugs.webkit.org/show_bug.cgi?id=123425
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
- inspector/inline-javascript-imports.py: Removed.
- 5:52 PM Changeset in webkit [158146] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Web Inspector: Remove unused "externs" files and generators
https://bugs.webkit.org/show_bug.cgi?id=123427
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptExterns.js: Removed.
- inspector/generate_protocol_externs.py: Removed.
- 4:52 PM Changeset in webkit [158145] by
-
- 2 edits in trunk/LayoutTests
Mark some more Mavericks/WK2 tests as failing.
We have no way currently to land new results for just
WK2 on Mavericks.
- platform/mac-wk2/TestExpectations:
- 4:14 PM Changeset in webkit [158144] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 4:13 PM Changeset in webkit [158143] by
-
- 1 copy in tags/Safari-537.60.4
New Tag.
- 3:44 PM Changeset in webkit [158142] by
-
- 2 edits in branches/safari-537.60-branch/WebKitLibraries
Merged r157608. <rdar://problem/15323836>
- 3:32 PM Changeset in webkit [158141] by
-
- 13 edits in trunk/Source/JavaScriptCore
OSRExit::m_watchpointIndex should be in OSRExitCompilationInfo
https://bugs.webkit.org/show_bug.cgi?id=123423
Reviewed by Mark Hahnenberg.
Also enable ExitKind to tell you if it's a watchpoint.
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
(JSC::isWatchpoint):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendExitInfo):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompilationInfo.h:
(JSC::DFG::OSRExitCompilationInfo::OSRExitCompilationInfo):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:22 PM Changeset in webkit [158140] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r156433. <rdar://problem/15109489>
- 3:20 PM Changeset in webkit [158139] by
-
- 5 edits in branches/safari-537.73-branch/Source
Merged r156416. <rdar://problem/15109488>
- 3:13 PM Changeset in webkit [158138] by
-
- 5 edits in branches/safari-537.73-branch/Source
Merged r156219. <rdar://problem/15109342>
- 3:08 PM Changeset in webkit [158137] by
-
- 19 edits2 adds in trunk/Source
Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces
https://bugs.webkit.org/show_bug.cgi?id=123411
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
Source/WebCore:
Include an InspectorClient hook for when node searching is enabled / disabled.
- inspector/InspectorClient.h:
(WebCore::InspectorClient::didSetSearchingForNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setSearchingForNode):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::didSetSearchingForNode):
- inspector/InspectorOverlay.h:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Upstream iOS node highlighting and view indication.
- WebCoreSupport/WebInspectorClient.h:
- WebInspector/WebInspector.h:
- WebInspector/WebInspector.mm:
- WebInspector/WebNodeHighlight.h:
- WebInspector/WebNodeHighlight.mm:
(-[WebHighlightLayer initWithHighlightView:webView:]):
(-[WebHighlightLayer layoutSublayers]):
(-[WebHighlightLayer actionForKey:]):
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]):
(-[WebNodeHighlight attach]):
- WebInspector/WebNodeHighlightView.h:
- WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView initWithWebNodeHighlight:]):
(-[WebNodeHighlightView dealloc]):
(-[WebNodeHighlightView _attach:numLayers:]):
(findIntersectionOnLineBetweenPoints):
(quadIntersection):
(layerPathWithHole):
(layerPath):
(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
(-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
(-[WebNodeHighlightView layoutSublayers:]):
- WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):
- WebView/WebIndicateLayer.h: Added.
- WebView/WebIndicateLayer.mm: Added.
(-[WebIndicateLayer layoutSublayers]):
(-[WebIndicateLayer actionForKey:]):
- WebView/WebView.mm:
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setHostApplicationBundleId:name:]):
(-[WebView hostApplicationBundleId]):
(-[WebView hostApplicationName]):
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- 3:01 PM Changeset in webkit [158136] by
-
- 4 edits in trunk/Tools
Allow explicit sort order for Dashboard platforms
https://bugs.webkit.org/show_bug.cgi?id=123419
Reviewed by Tim Hatcher.
Assign a specific sort order to Dashboard platforms, rather than
just using object property order.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
- 3:00 PM Changeset in webkit [158135] by
-
- 2 edits in trunk/LayoutTests
Add skipped or failing expectations for Mavericks WK2.
- platform/mac-wk2/TestExpectations:
- 2:55 PM Changeset in webkit [158134] by
-
- 20 edits in branches/safari-537.73-branch
Merged r156302.
- 2:43 PM Changeset in webkit [158133] by
-
- 20 edits in branches/safari-537.60-branch
Merged r156302.
- 2:32 PM Changeset in webkit [158132] by
-
- 1 edit2 adds in branches/safari-537.73-branch/LayoutTests
Merge r155471.
https://bugs.webkit.org/show_bug.cgi?id=123409.
Missing files from previous merge commit for r155471.
- inspector-protocol/debugger/resources: Added.
- inspector-protocol/debugger/resources/exception.js: Added.
(exceptionBasic):
(exceptionDOM):
(throwString):
(throwParam):
(exceptionInHostFunction):
(catchNested):
(noException):
- 2:27 PM Changeset in webkit [158131] by
-
- 2 edits in trunk/LayoutTests
WebGL flake.
- platform/mac/TestExpectations:
- 2:24 PM Changeset in webkit [158130] by
-
- 2 edits in trunk/Tools
Tidy up main http://build.webkit.org page
https://bugs.webkit.org/show_bug.cgi?id=123413
Reviewed by Alexey Proskuryakov.
Break the list of links into sections. Add some font style.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 2:19 PM Changeset in webkit [158129] by
-
- 9 edits in trunk/Source
Rename applyPageScaleFactorInCompositor to delegatesPageScaling
https://bugs.webkit.org/show_bug.cgi?id=123417
Reviewed by Simon Fraser.
Source/WebCore:
- page/Frame.cpp:
(WebCore::Frame::frameScaleFactor):
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentScaleFactor):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- page/Settings.in:
- platform/ScrollView.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:09 PM Changeset in webkit [158128] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r156933. <rdar://problem/15323812>
- 2:05 PM Changeset in webkit [158127] by
-
- 22 edits3 adds in trunk
Parsing support for -webkit-text-decoration-skip: ink
https://bugs.webkit.org/show_bug.cgi?id=123358
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-28
Reviewed by Dean Jackson.
Source/JavaScriptCore:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Adds initial parsing support for parsing -webkit-text-decoration-skip with
values of "none" and "ink". This work is behind the new
ENABLE(CSS3_TEXT_DECORATION) compile-time flag.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
- Configurations/FeatureDefines.xcconfig: Adding ENABLE(CSS3_TEXT_DECORATION)
- css/CSSComputedStyleDeclaration.cpp: Mapping internal representation of text-decoration-skip
to a CSSValue
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp: Actually parsing tokens
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextDecorationSkip):
- css/CSSParser.h:
- css/CSSPropertyNames.in: adding -webkit-text-decoration-skip
- css/CSSValueKeywords.in: adding ink
- css/DeprecatedStyleBuilder.cpp: Mapping from CSSValue to internal representation
(WebCore::ApplyPropertyTextDecorationSkip::valueToDecorationSkip):
(WebCore::ApplyPropertyTextDecorationSkip::applyValue):
(WebCore::ApplyPropertyTextDecorationSkip::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp: decoration-skip uses DeprecatedStyleBuilder
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h: Adding functions for modifying and accessing decoration-skip properties
- rendering/style/RenderStyleConstants.h: Definition of internal representation
- rendering/style/StyleRareInheritedData.cpp: Setting up constructors and comparators
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Holds actual value of internal representation
Source/WebKit/mac:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Tools:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Adds a test which makes sure that we can parse the
-webkit-text-decoration-skip CSS property, as well
as values for "ink" and "none". We can use the CSSOM
to test the roundtrip of these values
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: Added.
- 1:59 PM Changeset in webkit [158126] by
-
- 2 edits in branches/safari-537.60-branch/Source/WTF
Merged r156933.
- 1:56 PM Changeset in webkit [158125] by
-
- 8 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r154508. <rdar://problem/15109410>
- 1:30 PM Changeset in webkit [158124] by
-
- 5 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Merged r154366. <rdar://problem/15109352>
- 1:10 PM Changeset in webkit [158123] by
-
- 6 edits in trunk/Source
RunLoop::dispatch should take an std::function
https://bugs.webkit.org/show_bug.cgi?id=123407
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- platform/RunLoop.cpp:
(WebCore::RunLoop::performWork):
(WebCore::RunLoop::dispatch):
- platform/RunLoop.h:
Source/WTF:
- wtf/FunctionDispatcher.h:
- 1:01 PM Changeset in webkit [158122] by
-
- 32 edits2 deletes in trunk/Source
Make TileController manipulate PlatformCALayers instead of CALayers
https://bugs.webkit.org/show_bug.cgi?id=123279
Reviewed by Simon Fraser.
In the interest of making TileController more platform-independent
(so that it can be used with the remote layer tree, and maybe Windows),
move TileController onto our PlatformCALayer abstraction instead of
direct manipulation of CALayers.
Some fallout from this includes getting rid of special Mac-specific
TileController-specific CALayer subclasses, and reworking tile
painting to work in a more generic way.
This is a first step, and doesn't get us all the way to a platform independent
TileController, but more patches are forthcoming.
No new tests, just a (largeish) refactor.
- WebCore.exp.in:
The signature of some methods has changed.
- WebCore.xcodeproj/project.pbxproj:
Remove WebTileLayer.*
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
Use the "isTile" key on the CALayer dictionary instead of the layer's
class to determine if it's a tile. TileController will set this on a tile
when it is created, for now.
- platform/graphics/TiledBacking.h:
tiledScrollingIndicatorLayer() should return a PlatformCALayer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
- platform/graphics/ca/PlatformCALayerClient.h:
The PlatformCALayerClient paintContents and incrementRepaintCount callbacks
should include the platformCALayer that caused the callback.
- platform/graphics/ca/PlatformCALayer.h:
Add LayerTypeSimpleLayer, which is similar to LayerTypeWebLayer
except it just calls back its client to paint, instead of doing
complicated things with repaint rects. This is so that TileController
doesn't re-enter drawLayerContents when asking its GraphicsLayer
to paint for each PlatformCALayer (it will be entering drawLayerContents
for the first time for each layer). It also happens to be useful
for things like the tile controller overlay, which don't need
all that complication.
Add LayerTypeTiledBackingTileLayer, which is used simply to distinguish
TileController Tile layers from other LayerTypeSimpleLayers.
- platform/graphics/ca/mac/LayerPool.h:
- platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::addLayer):
(WebCore::LayerPool::takeLayerWithSize):
LayerPool should operate on PlatformCALayers now.
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
Set the "isTile" key on the CALayer to true for TiledBackingTileLayers,
so that the scrolling performance logging can tell a tile apart from
any other layer, on the scrolling thread, without touching PlatformCALayers
or the TileController or any other main-thread data structures.
(PlatformCALayerMac::setEdgeAntialiasingMask): Added.
- platform/graphics/ca/mac/TileController.h:
Remove references to Objective-C classes; instead use PlatformCALayer everywhere.
TileController is now a PlatformCALayerClient, and the layers it owns are
all PlatformCALayers (and it is constructed with a PlatformCALayer, etc.).
Hand in the tile debug border color as a WebCore color, instead of a CGColorRef.
blankPixelCountForTiles() now operates on a list of PlatformLayers instead of
WebTileLayers specifically, since WebTileLayer is gone.
Make drawTileMapContents private because WebTileCacheMapLayer no longer exists.
(WebCore::TileController::platformCALayerDrawsContent):
All of the layers who have TileController as their client paint their contents.
(WebCore::TileController::platformCALayerContentsOpaque):
This will only be called for layers which paint via drawLayerContents,
so it's OK that we don't special-case the debugging overlay here.
(WebCore::TileController::owningGraphicsLayer):
Return the GraphicsLayer that owns the TileController's main
layer, via its conformance to PlatformCALayerClient. This is
a bit strange (because it's not strictly a GraphicsLayer, despite
always being so at the moment), but is done for clarity inside
TileController itself.
- platform/graphics/ca/mac/TileController.mm:
Remove CALayer (WebCALayerDetails), WebTiledScrollingIndicatorLayer,
and a bunch of includes that we don't need anymore.
(WebCore::TileController::create):
(WebCore::TileController::TileController):
TileController is passed a PlatformCALayer for the tile cache root layer,
instead of a WebTiledBackingLayer. It also creates a PlatformCALayer with
LayerTypeLayer instead of a bare CALayer for the container layer.
It's OK to remove the transaction because it was only used to stop
the implicit animation, which PlatformCALayer will do for us.
(WebCore::TileController::~TileController):
Clear the owner of the PlatformCALayers which the TileController previously owned,
so they don't try to call back a destroyed TileController.
(WebCore::TileController::tileCacheLayerBoundsChanged):
(WebCore::TileController::setNeedsDisplay):
Straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::setTileNeedsDisplayInRect):
Adjustments towards use of PlatformCALayer; we need FloatRects so we can
pass pointers to PlatformCALayer::setNeedsDisplay.
(WebCore::TileController::platformCALayerPaintContents):
Replace drawLayer with platformCALayerPaintContents, which will be called
back from our various WebSimpleLayers. If the PlatformCALayer is our
tiled scrolling debug indicator, paint that. Otherwise, it's a tile.
Make use of drawLayerContents() to paint the tile contents.
Make use of drawRepaintIndicator() to paint the repaint indicator if needed.
Move scrolling performance logging code that used to be in WebTileLayer here.
(WebCore::TileController::platformCALayerDeviceScaleFactor):
(WebCore::TileController::platformCALayerShowDebugBorders):
(WebCore::TileController::platformCALayerShowRepaintCounter):
Forward these to the owning GraphicsLayerCA, because it will have the right answers.
(WebCore::TileController::setScale):
Adjustments towards use of PlatformCALayer; remove some code that Simon
caused to be unused in 156291 but did not remove.
(WebCore::TileController::setAcceleratesDrawing):
(WebCore::TileController::setTilesOpaque):
(WebCore::TileController::setVisibleRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::setTileDebugBorderWidth):
(WebCore::TileController::setTileDebugBorderColor):
(WebCore::TileController::bounds):
(WebCore::TileController::blankPixelCount):
(WebCore::TileController::blankPixelCountForTiles):
(WebCore::queueTileForRemoval):
(WebCore::TileController::setNeedsRevalidateTiles):
(WebCore::TileController::ensureTilesForRect):
(WebCore::TileController::retainedTileBackingStoreMemory):
Straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::updateTileCoverageMap):
Adjustments towards use of PlatformCALayer; rename backgroundColor
to visibleRectIndicatorColor, since it's actually a border, not a background.
(WebCore::TileController::tiledScrollingIndicatorLayer):
Create a LayerTypeSimpleLayer PlatformCALayer for the tiled scrolling indicator.
It will be asked to paint straightforwardly, like a CALayer would.
Create a LayerTypeLayer PlatformCALayer for the visible rect indicator.
It doesn't need to paint anything, so it doesn't get an owner.
(WebCore::TileController::createTileLayer):
When creating a new tile layer, adopt it by setting its owner.
Otherwise, straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::platformCALayerIncrementRepaintCount):
Manage repaint counts for tiles in TileController now.
(WebCore::TileController::drawTileMapContents):
Adjustments towards use of PlatformCALayer.
- platform/graphics/ca/mac/WebTileLayer.h: Removed.
- platform/graphics/ca/mac/WebTileLayer.mm: Removed.
We don't need WebTileLayer anymore, tiles are now just WebSimpleLayers
owned by TileController. Its behavior has been moved into TileController.
- platform/graphics/ca/mac/WebTiledBackingLayer.h:
- platform/graphics/ca/mac/WebTiledBackingLayer.mm:
(-[WebTiledBackingLayer createTileController:]):
Add createTileController: so that the WebTiledBackingLayer's owner can
hand the TileController the PlatformCALayer for the WebTiledBackingLayer
without propagating additional usage of PlatformCALayer::platformCALayer(),
which we need to remove in light of the remote layer tree work.
(-[WebTiledBackingLayer setBorderColor:]):
- platform/graphics/ca/win/PlatformCALayerWin.h:
Add an empty implementation of setEdgeAntialiasingMask.
We'll probably want to implement it before adopting TileController on Windows.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerPaintContents):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerIncrementRepaintCount):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.
- platform/graphics/mac/WebLayer.h:
Add WebSimpleLayer, which inherits directly from CALayer, and make
our standard WebLayer (which is used for compositing layers in web content)
inherit from that.
- platform/graphics/mac/WebLayer.mm:
Move most of the behavior of WebLayer onto WebSimpleLayer, except for its
complex painting code. That stays as an override on WebLayer.
(WebCore::drawLayerContents):
Use the PlatformCALayer's PlatformLayer - if it exists - to extract
fine-grained repaint rects. If it doesn't, we'll just use the CGContext's
clip rect as our single repaint rect.
Rename platformLayer to platformCALayer for accuracy.
Remove special code for CATiledLayer since we ought not use it on Mac anymore.
(WebCore::drawRepaintIndicator):
Factor repaint indicator code out into its own function so that TileController
can use it. It can't be called from drawLayerContents for TileController, since
the PlatformCALayer that TileController passes in to drawLayerContents is actually
that of the tile cache's root layer, not the tile itself.
Also, add a custom background color parameter so TileController can override
the default green color with its own standard purple.
(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):
- platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer drawInContext:]):
Removed a param from drawLayerContents because it's trivially acquirable
from the PlatformCALayer.
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerPaintContents):
(FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::dump):
Support the new LayerTypes.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setEdgeAntialiasingMask):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Add an empty implementation of setEdgeAntialiasingMask.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
Removed a parameter from drawLayerContents.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):
TiledCoreAnimationDrawingArea still operates in terms of CALayers, so
grab the PlatformLayer out from TileController's indicator.
- 12:22 PM Changeset in webkit [158121] by
-
- 7 edits in trunk/Source/WebCore
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=123318
Reviewed by David Hyatt.
- rendering/LineLayoutState.h:
Move FloatWithRect from RenderBlock.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
Move pagination and float functions.
- 11:48 AM Changeset in webkit [158120] by
-
- 2 edits in trunk/LayoutTests
Expunge Lion and SnowLeopard from TestExpectations.
- platform/mac/TestExpectations:
- 11:46 AM Changeset in webkit [158119] by
-
- 2 edits in trunk/LayoutTests
Some test expectations for Mavericks.
- platform/mac/TestExpectations:
- 11:42 AM Changeset in webkit [158118] by
-
- 2 edits in trunk/Tools
Add additional Apple Mavericks test bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:31 AM Changeset in webkit [158117] by
-
- 5 edits6 copies in branches/safari-537.73-branch
Merge r155471.
https://bugs.webkit.org/show_bug.cgi?id=123409.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Re-implemented fix based on the frame iteration mechanhism before the
StackVisitor was available.
2013-09-10 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: [JSC] Caught exception is treated as uncaught
https://bugs.webkit.org/show_bug.cgi?id=93607
Reviewed by Geoff Garen.
Check up the entire call stack to see if there is an exception handler.
- interpreter/Interpreter.cpp: (JSC::GetExceptionHandlerFunctor::GetExceptionHandlerFunctor): (JSC::GetExceptionHandlerFunctor::handler): (JSC::GetExceptionHandlerFunctor::operator()):
LayoutTests:
Re-based test results from merge.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.checkForError): This is needed for the merged tests.
2013-09-10 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: [JSC] Caught exception is treated as uncaught
https://bugs.webkit.org/show_bug.cgi?id=93607
Reviewed by Geoff Garen.
Add tests for different inspector pause on exceptions states.
- inspector-protocol/debugger/resources/exception.js: Added.
- inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-all.html: Added.
- inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-none.html: Added.
- inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-uncaught.html: Added.
- 11:03 AM Changeset in webkit [158116] by
-
- 16 edits in trunk/Source/JavaScriptCore
Get rid of InlineStart so that I don't have to implement it in FTL
https://bugs.webkit.org/show_bug.cgi?id=123302
Reviewed by Geoffrey Garen.
InlineStart was a special instruction that we would insert at the top of inlined code,
so that the backend could capture the OSR state of arguments to an inlined call. It used
to be that only the backend had this information, so this instruction was sort of an ugly
callback from the backend for filling in some data structures.
But in the time since when that code was written (two years ago?), we rationalized how
variables work. It's now the case that variables that the runtime must know about are
treated specially in IR (they are "flushed") and we know how we will represent them even
before we get to the backend. The last place that makes changes to their representation
is the StackLayoutPhase.
So, this patch gets rid of InlineStart, but keeps around the special meta-data that the
instruction had. Instead of handling the bookkeeping in the backend, we handle it in
StackLayoutPhase. This means that the DFG and FTL can share code for handling this
bookkeeping. This also means that now the FTL can compile code blocks that had inlining.
Of course, giving the FTL the ability to handle code blocks that had inlining means that
we're going to have new bugs. Sure enough, the FTL's linker didn't handle inline call
frames. This patch also fixes that.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
- dfg/DFGNode.h:
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- 10:35 AM Changeset in webkit [158115] by
-
- 10 edits6 adds in trunk
[CSS Grid Layout] Add support for order inside grid items
https://bugs.webkit.org/show_bug.cgi?id=123208
Reviewed by Antti Koivisto.
Source/WebCore:
Based on Blink r153457 and r153536 by <jchaffraix@chromium.org>
Added support for sorting grid items by using -webkit-order
property. Used OrderIterator to implement it so it had to be moved
out of RenderFlexibleBox to be shared with RenderGrid.
Tests: fast/css-grid-layout/grid-item-order-auto-flow-resolution.html
fast/css-grid-layout/grid-item-order-paint-order.html
- CMakeLists.txt: Added new file.
- GNUmakefile.list.am: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/OrderIterator.cpp: Added. Ripped out of RenderFlexibleBox.
(WebCore::OrderIterator::OrderIterator):
(WebCore::OrderIterator::setOrderValues): Use std::move semantics.
(WebCore::OrderIterator::first): Use an integer as iterator.
(WebCore::OrderIterator::next): Ditto.
(WebCore::OrderIterator::reset): Ditto.
- rendering/OrderIterator.h: Added.
(WebCore::OrderIterator::currentChild):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::paintChildren):
- rendering/RenderGrid.h:
LayoutTests:
From Blink r153536 by <jchaffraix@chromium.org>
Added a couple of tests to verify that we respect the specified
order of grid items both in the auto-placement algorithm and in
the final painting.
- fast/css-grid-layout/grid-item-order-auto-flow-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-order-auto-flow-resolution.html: Added.
- fast/css-grid-layout/grid-item-order-paint-order-expected.html: Added.
- fast/css-grid-layout/grid-item-order-paint-order.html: Added.
- 10:20 AM Changeset in webkit [158114] by
-
- 2 edits in trunk/Source/JavaScriptCore
The GetById->GetByOffset AI-based optimization should actually do things
https://bugs.webkit.org/show_bug.cgi?id=123299
Reviewed by Oliver Hunt.
20% speed-up on Octane/gbemu.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.
- 9:15 AM Changeset in webkit [158113] by
-
- 337 edits in trunk
Methods on window.internals shouldn't pass a document.
https://bugs.webkit.org/show_bug.cgi?id=107301
Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-10-28
Reviewed by Alexey Proskuryakov.
Each 'Internals' instance is associated with a 'Document'. So, it
is not necessary to pass a document as argument. Only nodesFromRect and
layerTreeAsText methods were kept because, in some Layout Tests, the
'Document' object is not the same used by Internals::contextDocument.
Source/WebCore:
- testing/Internals.cpp: Removed 'document' parameter.
(WebCore::Internals::animationsAreSuspended):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setScrollViewPosition):
(WebCore::Internals::setPagination):
(WebCore::Internals::configurationForViewport):
(WebCore::Internals::paintControlTints):
(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):
(WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
(WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):
(WebCore::Internals::wheelEventHandlerCount):
(WebCore::Internals::touchEventHandlerCount):
(WebCore::Internals::setBatteryStatus):
(WebCore::Internals::setNetworkInformation):
(WebCore::Internals::setDeviceProximity):
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::toggleOverwriteModeEnabled):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::hasGrammarMarker):
(WebCore::Internals::numberOfScrollableAreas):
(WebCore::Internals::isPageBoxVisible):
(WebCore::Internals::repaintRectsAsText):
(WebCore::Internals::scrollingStateTreeAsText):
(WebCore::Internals::mainThreadScrollingReasons):
(WebCore::Internals::nonFastScrollableRects):
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):
(WebCore::Internals::shortcutIconURLs):
(WebCore::Internals::allIconURLs):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):
(WebCore::Internals::webkitWillEnterFullScreenForElement):
(WebCore::Internals::webkitDidEnterFullScreenForElement):
(WebCore::Internals::webkitWillExitFullScreenForElement):
(WebCore::Internals::webkitDidExitFullScreenForElement):
(WebCore::Internals::startTrackingRepaints):
(WebCore::Internals::stopTrackingRepaints):
(WebCore::Internals::getCurrentCursorInfo):
- testing/Internals.h:
(WebCore::Internals::setPagination):
- testing/Internals.idl:
LayoutTests:
- animations/added-while-suspended.html: Removed 'document' parameter.
- animations/play-state-suspend.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-resume-animation.html:
- animations/suspend-transform-animation.html:
- batterystatus/resources/event-after-navigation-new.html:
- batterystatus/script-tests/add-listener-from-callback.js:
(firstListener):
- batterystatus/script-tests/basic-all-types-of-events.js:
- batterystatus/script-tests/basic-operation.js:
- batterystatus/script-tests/multiple-frames.js:
- batterystatus/script-tests/updates.js:
(setBatteryStatus):
- compositing/columns/ancestor-clipped-in-paginated.html:
- compositing/columns/clipped-in-paginated.html:
- compositing/columns/composited-columns-vertical-rl.html:
- compositing/columns/composited-in-paginated-rl.html:
- compositing/columns/composited-in-paginated-writing-mode-rl.html:
- compositing/columns/composited-in-paginated.html:
- compositing/columns/composited-lr-paginated-repaint.html:
- compositing/columns/composited-rl-paginated-repaint.html:
- compositing/columns/geometry-map-paginated-assert.html:
- compositing/columns/hittest-composited-in-paginated.html:
- compositing/columns/rotated-in-paginated.html:
- compositing/columns/untransformed-composited-in-paginated.html:
- compositing/iframes/iframe-composited-scrolling.html:
- compositing/layer-creation/fixed-position-in-view-dynamic.html:
- compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
- compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
- compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
- compositing/overflow/dynamic-composited-scrolling-status.html:
- compositing/overflow/scrolling-without-painting.html:
- compositing/overflow/updating-scrolling-content.html:
- compositing/repaint/absolute-painted-into-composited-ancestor.html:
- compositing/repaint/fixed-background-scroll.html:
- compositing/repaint/invalidations-on-composited-layers.html:
- compositing/repaint/positioned-movement.html:
- compositing/repaint/repaint-on-layer-grouping-change.html:
- compositing/repaint/resize-repaint.html:
- compositing/repaint/scroll-fixed-layer-no-content.html:
- compositing/repaint/scroll-fixed-layer-out-of-view.html:
- editing/caret/selection-with-caret-type-progress.html:
- editing/execCommand/overtype.html:
- editing/selection/block-cursor-overtype-mode.html:
- editing/spelling/design-mode-spellcheck-off.html:
- editing/spelling/grammar-edit-word-expected.txt:
- editing/spelling/grammar-edit-word.html:
- editing/spelling/grammar-markers-hidpi.html:
- editing/spelling/grammar-markers.html:
- editing/spelling/grammar.html:
- editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
- editing/spelling/script-tests/spelling-attribute-at-child.js:
(childHasSpellingMarker):
- editing/spelling/script-tests/spelling-attribute-change.js:
(testSpellCheckingEnabled):
- editing/spelling/script-tests/spelling-backspace-between-lines.js:
(testWithDelete):
(testWithForwardDelete):
- editing/spelling/script-tests/spelling-hasspellingmarker.js:
(hasMarked):
- editing/spelling/spellcheck-async-mutation.html:
- editing/spelling/spellcheck-attribute-expected.txt:
- editing/spelling/spellcheck-attribute.html:
- editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- editing/spelling/spellcheck-paste-continuous-disabled.html:
- editing/spelling/spellcheck-paste-disabled-expected.txt:
- editing/spelling/spellcheck-paste-disabled.html:
- editing/spelling/spellcheck-sequencenum.html:
- editing/spelling/spelling-attribute-change-expected.txt:
- editing/spelling/spelling-backspace-between-lines-expected.txt:
- editing/spelling/spelling-linebreak.html:
- fast/box-shadow/shadow-repaint.html:
- fast/css/webkit-mask-crash-fieldset-legend.html:
- fast/css/webkit-mask-crash-figure.html:
- fast/css/webkit-mask-crash-table.html:
- fast/css/webkit-mask-crash-td-2.html:
- fast/css/webkit-mask-crash-td.html:
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch.html:
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- fast/events/mouse-cursor-change.html:
- fast/events/mouse-cursor-image-set.html:
- fast/events/mouse-cursor-multiframecur.html:
- fast/events/mouse-cursor-no-mousemove.html:
- fast/events/mouse-cursor.html:
- fast/events/touch/touch-handler-count-expected.txt:
- fast/events/touch/touch-handler-count.html:
- fast/events/touch/touch-input-element-change-documents-expected.txt:
- fast/events/touch/touch-input-element-change-documents.html:
- fast/multicol/hit-test-gap-between-pages-flipped.html:
- fast/multicol/hit-test-gap-between-pages.html:
- fast/multicol/pagination-h-horizontal-bt.html:
- fast/multicol/pagination-h-horizontal-tb.html:
- fast/multicol/pagination-h-vertical-lr.html:
- fast/multicol/pagination-h-vertical-rl.html:
- fast/multicol/pagination-v-horizontal-bt.html:
- fast/multicol/pagination-v-horizontal-tb.html:
- fast/multicol/pagination-v-vertical-lr.html:
- fast/multicol/pagination-v-vertical-rl.html:
- fast/multicol/pagination/BottomToTop-bt.html:
- fast/multicol/pagination/BottomToTop-lr.html:
- fast/multicol/pagination/BottomToTop-rl.html:
- fast/multicol/pagination/BottomToTop-tb.html:
- fast/multicol/pagination/LeftToRight-bt.html:
- fast/multicol/pagination/LeftToRight-lr.html:
- fast/multicol/pagination/LeftToRight-rl.html:
- fast/multicol/pagination/LeftToRight-tb.html:
- fast/multicol/pagination/RightToLeft-bt.html:
- fast/multicol/pagination/RightToLeft-lr.html:
- fast/multicol/pagination/RightToLeft-rl.html:
- fast/multicol/pagination/RightToLeft-tb.html:
- fast/multicol/pagination/TopToBottom-bt.html:
- fast/multicol/pagination/TopToBottom-lr.html:
- fast/multicol/pagination/TopToBottom-rl.html:
- fast/multicol/pagination/TopToBottom-tb.html:
- fast/multicol/shrink-to-column-height-for-pagination.html:
- fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
- fast/repaint/obscured-background-no-repaint.html:
- fast/repaint/resources/text-based-repaint.js:
(runRepaintTest):
- fast/scrolling/resources/scrollable-area.js:
(end):
- fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html:
- fast/viewport/viewport-1.html:
- fast/viewport/viewport-10.html:
- fast/viewport/viewport-100.html:
- fast/viewport/viewport-101.html:
- fast/viewport/viewport-102.html:
- fast/viewport/viewport-103.html:
- fast/viewport/viewport-104.html:
- fast/viewport/viewport-105.html:
- fast/viewport/viewport-106.html:
- fast/viewport/viewport-107.html:
- fast/viewport/viewport-108.html:
- fast/viewport/viewport-109.html:
- fast/viewport/viewport-11.html:
- fast/viewport/viewport-110.html:
- fast/viewport/viewport-111.html:
- fast/viewport/viewport-112.html:
- fast/viewport/viewport-113.html:
- fast/viewport/viewport-114.html:
- fast/viewport/viewport-115.html:
- fast/viewport/viewport-116.html:
- fast/viewport/viewport-117.html:
- fast/viewport/viewport-118.html:
- fast/viewport/viewport-119.html:
- fast/viewport/viewport-12.html:
- fast/viewport/viewport-120.html:
- fast/viewport/viewport-121.html:
- fast/viewport/viewport-122.html:
- fast/viewport/viewport-123.html:
- fast/viewport/viewport-124.html:
- fast/viewport/viewport-125.html:
- fast/viewport/viewport-126.html:
- fast/viewport/viewport-127.html:
- fast/viewport/viewport-128.html:
- fast/viewport/viewport-129.html:
- fast/viewport/viewport-13.html:
- fast/viewport/viewport-130.html:
- fast/viewport/viewport-131.html:
- fast/viewport/viewport-132.html:
- fast/viewport/viewport-133.html:
- fast/viewport/viewport-134.html:
- fast/viewport/viewport-14.html:
- fast/viewport/viewport-15.html:
- fast/viewport/viewport-16.html:
- fast/viewport/viewport-17.html:
- fast/viewport/viewport-18.html:
- fast/viewport/viewport-19.html:
- fast/viewport/viewport-2.html:
- fast/viewport/viewport-20.html:
- fast/viewport/viewport-21.html:
- fast/viewport/viewport-22.html:
- fast/viewport/viewport-23.html:
- fast/viewport/viewport-24.html:
- fast/viewport/viewport-25.html:
- fast/viewport/viewport-26.html:
- fast/viewport/viewport-27.html:
- fast/viewport/viewport-28.html:
- fast/viewport/viewport-29.html:
- fast/viewport/viewport-3.html:
- fast/viewport/viewport-30.html:
- fast/viewport/viewport-31.html:
- fast/viewport/viewport-32.html:
- fast/viewport/viewport-33.html:
- fast/viewport/viewport-34.html:
- fast/viewport/viewport-35.html:
- fast/viewport/viewport-36.html:
- fast/viewport/viewport-37.html:
- fast/viewport/viewport-38.html:
- fast/viewport/viewport-39.html:
- fast/viewport/viewport-4.html:
- fast/viewport/viewport-40.html:
- fast/viewport/viewport-41.html:
- fast/viewport/viewport-42.html:
- fast/viewport/viewport-43.html:
- fast/viewport/viewport-44.html:
- fast/viewport/viewport-45.html:
- fast/viewport/viewport-46.html:
- fast/viewport/viewport-47.html:
- fast/viewport/viewport-48.html:
- fast/viewport/viewport-49.html:
- fast/viewport/viewport-5.html:
- fast/viewport/viewport-50.html:
- fast/viewport/viewport-51.html:
- fast/viewport/viewport-52.html:
- fast/viewport/viewport-53.html:
- fast/viewport/viewport-54.html:
- fast/viewport/viewport-55.html:
- fast/viewport/viewport-56.html:
- fast/viewport/viewport-57.html:
- fast/viewport/viewport-58.html:
- fast/viewport/viewport-59.html:
- fast/viewport/viewport-6.html:
- fast/viewport/viewport-60.html:
- fast/viewport/viewport-61.html:
- fast/viewport/viewport-62.html:
- fast/viewport/viewport-63.html:
- fast/viewport/viewport-64.html:
- fast/viewport/viewport-65.html:
- fast/viewport/viewport-66.html:
- fast/viewport/viewport-67.html:
- fast/viewport/viewport-68.html:
- fast/viewport/viewport-69.html:
- fast/viewport/viewport-7.html:
- fast/viewport/viewport-70.html:
- fast/viewport/viewport-71.html:
- fast/viewport/viewport-72.html:
- fast/viewport/viewport-73.html:
- fast/viewport/viewport-74.html:
- fast/viewport/viewport-75.html:
- fast/viewport/viewport-76.html:
- fast/viewport/viewport-77.html:
- fast/viewport/viewport-78.html:
- fast/viewport/viewport-79.html:
- fast/viewport/viewport-8.html:
- fast/viewport/viewport-80.html:
- fast/viewport/viewport-81.html:
- fast/viewport/viewport-82.html:
- fast/viewport/viewport-83.html:
- fast/viewport/viewport-84.html:
- fast/viewport/viewport-85.html:
- fast/viewport/viewport-86.html:
- fast/viewport/viewport-87.html:
- fast/viewport/viewport-88.html:
- fast/viewport/viewport-9.html:
- fast/viewport/viewport-90.html:
- fast/viewport/viewport-91.html:
- fast/viewport/viewport-legacy-handheldfriendly.html:
- fast/viewport/viewport-legacy-mobileoptimized-2.html:
- fast/viewport/viewport-legacy-mobileoptimized-3.html:
- fast/viewport/viewport-legacy-mobileoptimized.html:
- fast/viewport/viewport-legacy-ordering-1.html:
- fast/viewport/viewport-legacy-ordering-2.html:
- fast/viewport/viewport-legacy-ordering-3.html:
- fast/viewport/viewport-legacy-ordering-4.html:
- fast/viewport/viewport-legacy-ordering-5.html:
- fast/viewport/viewport-legacy-ordering-6.html:
- fast/viewport/viewport-legacy-ordering-7.html:
- fast/viewport/viewport-legacy-ordering-8.html:
- fast/viewport/viewport-legacy-ordering-9.html:
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
- fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
- fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
- fast/viewport/viewport-legacy-xhtmlmp.html:
- fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
- fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
- fast/viewport/viewport-warnings-1.html:
- fast/viewport/viewport-warnings-2.html:
- fast/viewport/viewport-warnings-3.html:
- fast/viewport/viewport-warnings-4.html:
- fast/viewport/viewport-warnings-5.html:
- fast/viewport/viewport-warnings-6.html:
- fullscreen/video-cursor-auto-hide-expected.txt:
- fullscreen/video-cursor-auto-hide.html:
- http/tests/inspector-enabled/resources/console-clear-arguments-test.js:
(dumpConsoleMessageArgumentCounts):
- http/tests/inspector/elements-test.js:
- networkinformation/resources/event-after-navigation-new.html:
- networkinformation/script-tests/add-listener-from-callback.js:
(firstListener):
- networkinformation/script-tests/basic-all-types-of-events.js:
- networkinformation/script-tests/basic-operation.js:
- networkinformation/script-tests/multiple-frames.js:
- networkinformation/script-tests/updates.js:
(setNetworkInformation):
- platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html:
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars.html:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html:
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html:
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html:
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling.html:
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html:
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html:
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
- platform/mac/editing/spelling/delete-into-misspelled-word.html:
- platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
- platform/mac/editing/spelling/editing-word-with-marker-1.html:
- platform/mac/editing/spelling/editing-word-with-marker-2.html:
- platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
- platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
- printing/page-format-data-expected.txt:
- printing/page-format-data.html:
- proximity/add-listener-from-callback.html:
- proximity/basic-operation.html:
- proximity/multiple-frames.html:
- proximity/resources/event-after-navigation-new.html:
- proximity/updates.html:
- scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
(runNonFastScrollableRegionTest):
- touchadjustment/big-div.html:
- touchadjustment/event-triggered-widgets.html:
- touchadjustment/iframe.html:
- touchadjustment/nested-shadow-node.html:
- touchadjustment/resources/touchadjustment.js:
(testTouchPoint):
(testTouchPointContextMenu):
(adjustTouchPoint):
(adjustTouchPointContextMenu):
- touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
- touchadjustment/scroll-offset.html:
- touchadjustment/search-cancel.html:
- touchadjustment/zoom-basic.html:
- touchadjustment/zoom-fatfinger.html:
- transitions/created-while-suspended.html:
- transitions/started-while-suspended.html:
- transitions/suspend-transform-transition.html:
- userscripts/insert-stylesheets.html:
- 9:11 AM Changeset in webkit [158112] by
-
- 10 edits2 deletes in trunk
Remove HTMLMediaElement.startTime
https://bugs.webkit.org/show_bug.cgi?id=123264
Reviewed by Eric Carlson.
Source/WebCore:
Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/32583003
startTime has been removed from the HTMLMediaElement and its use
in the rest of components.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleRewindButtonClicked):
(Controller.prototype.handleTimelineMouseMove):
(Controller.prototype.updateDuration):
(Controller.prototype.updateTime): Removed used of startTime().
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_get_start_time):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::isBlockedOnMediaController): Removed
use of startTime()
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl: Removed startTime()
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSliderThumb): Removed use of
startTime()
LayoutTests:
Removed test about startTime.
Blink review URL: https://codereview.chromium.org/32583003
- media/media-startTime-expected.txt: Removed.
- media/media-startTime.html: Removed.
- 8:48 AM Changeset in webkit [158111] by
-
- 5 edits in trunk/Source
RenderElement::m_style should be a Ref.
<https://webkit.org/b/123401>
Source/WebCore:
Made RenderElement::m_style a Ref. This codifies the fact that it
can never be null after construction.
Removed a couple of unnecessary null checks that were exposed as
compilation failures.
Reviewed by Antti Koivisto.
Source/WTF:
Added a Ref::replace() so we can Indiana Jones the new style in
RenderElement::setStyle() while keeping a handle on the old style
for a while longer.
Reviewed by Antti Koivisto.
- 8:22 AM Changeset in webkit [158110] by
-
- 16 edits in trunk
Name all the GLib timeout sources
https://bugs.webkit.org/show_bug.cgi?id=123229
Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
Reviewed by Anders Carlsson.
Source/WebCore:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
No new tests, no change in functionality.
Source/WebKit/gtk:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
Source/WebKit2:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
Tools:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
- 8:16 AM Changeset in webkit [158109] by
-
- 2 edits in trunk/Source/WebCore
MediaStreamTrackPrivate's m_client uninitialized
https://bugs.webkit.org/show_bug.cgi?id=123403
Reviewed by Eric Carlson.
No new tests, no change in functionality.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
Initialize the m_client member variable.
- 6:44 AM Changeset in webkit [158108] by
-
- 9 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files to compilation.
Source/WebCore:
- GNUmakefile.am: Add crypto idl files to EXTRA_DIST and remove
css/fullscreenQuickTime.css that was removed.
Source/WebKit2:
- GNUmakefile.am: Add messages.in files in
UIProcess/Network/CustomProtocols/ to EXTRA_DIST.
- GNUmakefile.list.am: Remove
WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp from
compilation because it depends on code generated only when
database process is enabled.
Source/WTF:
- GNUmakefile.list.am: Remove unexistent file from compilation.
- 6:39 AM Changeset in webkit [158107] by
-
- 13 edits in trunk/Source/WebCore
Prepare simple line layout to support multiple runs per line
https://bugs.webkit.org/show_bug.cgi?id=123400
Reviewed by Andreas Kling.
Bunch of renaming and some refactoring for future support for text runs.
SimpleLineLayout::Lines -> SimpleLineLayout::Layout and becomes a class instead of a typedef.
SimpleLineLayout::Resolver::Line -> SimpleLineLayout::Resolver::Run
SimpleLineLayout::createLines() -> SimpleLineLayout::create()
RenderBlockFlow::simpleLines() -> RenderBlockFlow::simpleLineLayout()
RenderText::simpleLines() -> RenderText::simpleLineLayout()
Added resolver construction functions:
SimpleLineLayout::runResolver()
SimpleLineLayout::lineResolver()
- 5:32 AM Changeset in webkit [158106] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
fast/canvas/webgl/drawingbuffer-test.html is passing on efl-wk2.
Move it to efl-wk1 TestExpectations file.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 3:36 AM Changeset in webkit [158105] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] [GTK] Allow running the web process with an arbitrary prefix command
https://bugs.webkit.org/show_bug.cgi?id=123201
Reviewed by Carlos Garcia Campos.
Launch the web process using WEB_PROCESS_CMD_PREFIX as a
prefix. Useful for debugging the web process with gdb, valgrind,
etc.
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/gtk/WebProcessProxyGtk.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- 2:57 AM Changeset in webkit [158104] by
-
- 5 edits1 move1 delete in trunk
[GTK] Expose title and alternative text for links in image maps
https://bugs.webkit.org/show_bug.cgi?id=84045
Reviewed by Chris Fleizach.
Source/WebCore:
Change the way we decide when the title attribute should be
used for the accessible description, by not relying in the
titleTagShouldBeUsedInDescriptionField() helper function but
in whether we have found a visible text for it or not.
This actually mimics what the Mac port does and so makes possible
to share both the layout test and its expected results.
- accessibility/atk/WebKitAccessibleUtil.cpp:
(accessibilityDescription): Update the method to determine
whether the title attribute should be used for the description.
LayoutTests:
Share test expectations among Mac, GTK and EFL ports and
remove expected failures for GTK and EFL.
- accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
- platform/gtk/accessibility/image-map1-expected.txt: Removed.
- platform/efl/TestExpectations: Removed failure expectations.
- platform/gtk/TestExpectations: Ditto.
- 2:29 AM Changeset in webkit [158103] by
-
- 12 edits in trunk
Replace 0 timeouts g_timeout_add() by g_idle_add()
https://bugs.webkit.org/show_bug.cgi?id=123260
Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
Reviewed by Carlos Garcia Campos.
A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
without the nagging feeling that the wrong API was used.
Source/WebCore:
No new tests, no change in functionality.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Use g_idle_add() instead
of 0-timer.
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
- platform/gtk/GtkDragAndDropHelper.cpp: Ditto.
(WebCore::GtkDragAndDropHelper::handleDragLeave):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp: Use g_idle_add() instead
of 0-timer.
(WebKit::ChromeClient::closeWindowSoon):
(WebKit::ChromeClient::widgetSizeChanged):
- WebCoreSupport/GtkAdjustmentWatcher.cpp: Ditto.
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
- webkit/webkitwebview.cpp: Ditto.
(webkit_web_view_get_subresources):
Source/WTF:
- wtf/gtk/MainThreadGtk.cpp: Use g_idle_add() instead
of 0-timer.
(WTF::scheduleDispatchFunctionsOnMainThread):
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
of 0-timer.
(topLoadingFrameLoadFinished):
- DumpRenderTree/gtk/EventSender.cpp: Ditto.
(scheduleAsynchronousClickCallback):
(scheduleAsynchronousKeyDownCallback):
- 12:29 AM Changeset in webkit [158102] by
-
- 4 edits in trunk/Source
Re-enable simple line layout for GTK
https://bugs.webkit.org/show_bug.cgi?id=123388
Reviewed by Andreas Kling.
Source/WebCore:
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
can use the simple line layout.
Source/WTF:
- wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.
Oct 27, 2013:
- 10:42 PM Changeset in webkit [158101] by
-
- 5 edits in trunk/Source/WebKit2
WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375
Reviewed by Alexey Proskuryakov.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes about private browsing
sessions, notify the context’s WebIconDatabase about the change in value.
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setDatabasePath): Prime the IconDatabase with an initial private browsing value.
(WebKit::WebIconDatabase::setAnyPageGroupMightHavePrivateBrowsingEnabled):
- UIProcess/WebIconDatabase.h:
- 6:59 PM Changeset in webkit [158100] by
-
- 2 edits in trunk/Source/WebCore
Fix 4 asserting SVG tests after r158097.
RenderElement::setStyle() is, quite surprisingly, a virtual function
with a single override in RenderSVGBlock.
To match the old behavior, we have to rewrite the display type from
any inline type to block instead.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle):
- 5:17 PM Changeset in webkit [158099] by
-
- 2 edits in trunk/Source/WebCore
Tone down overzealous assertion from r158097.
RenderElement::initializeStyle() really only cares that there are no
text renderers that we should be calling styleDidChange() on.
Tweak the code to only check that there are no text children.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle):
- 4:06 PM Changeset in webkit [158098] by
-
- 4 edits in trunk/Source/WebCore
Enable center and right text alignment for simple lines
https://bugs.webkit.org/show_bug.cgi?id=123398
Reviewed by Andreas Kling.
Support text-align:center and text-align:right on simple line layout path.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
text-align:justify is still not supported.
(WebCore::SimpleLineLayout::computeLineLeft):
(WebCore::SimpleLineLayout::createLines):
Do a rounding dance that matches the line boxes.
- rendering/SimpleLineLayout.h:
Add left position to lines.
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::Resolver::Line::rect):
We now do rounding during layout.
(WebCore::SimpleLineLayout::Resolver::Line::baseline):
- 3:54 PM Changeset in webkit [158097] by
-
- 346 edits in trunk/Source/WebCore
Renderers should receive their style at construction.
<https://webkit.org/b/123396>
Pass the RenderStyle to all non-text renderer constructors.
After construction, initializeStyle() must be called (as a stopgap
measure) until we are able to do style-derived initialization
without virtual function calls.
With this change, RenderElement::m_style is never null. Subsequent
patches will add enforcement for this and also make style() return
a RenderStyle&.
I'm adding three FIXME's in this patch:
- createRendererIfNeeded() calls AnimationController to set up the initial style manually instead of asking RenderElement's setAnimatedStyle() to do it. This can probably be done in a nicer way, but it's not clear yet how.
- ImageContentData::createRenderer() does a bit of unnecessary work. This should be easy to clean up but got too distracting to be part of this patch.
- Document::createRenderTree() creates the RenderView with an initial dummy RenderStyle. I've done this because resolving the document style assumes we already have a RenderView.
For styleWillChange() implementations to detect that they are
reacting to the initial style, I've added a hasInitializedStyle()
function on RenderElement. This will return false until you've
called initializeStyle() on the renderer. This should go away
along with initializeStyle() eventually.
Reviewed by Antti Koivisto.
Oct 26, 2013:
- 7:36 PM Changeset in webkit [158096] by
-
- 8 edits in trunk/Source
[mac] Remove WebTiledLayer
https://bugs.webkit.org/show_bug.cgi?id=123395
Reviewed by Anders Carlsson.
Source/WebCore:
Mac doesn't use CATiledLayer at all anymore. We have to keep
LayerTypeTiledLayer around for Windows, for now, but we can
get rid of WebTiledLayer and some related Mac-specific code.
No new tests, just removing dead code.
- WebCore.xcodeproj/project.pbxproj:
Remove WebTiledLayer.*
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
Remove synchronouslyDisplayTilesInRect, which was only used for WebTiledLayer on Mac.
Remove WebTiledLayer instantiation and setup code.
- platform/graphics/mac/WebTiledLayer.h: Removed.
- platform/graphics/mac/WebTiledLayer.mm: Removed.
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove synchronouslyDisplayTilesInRect.
- 5:48 PM Changeset in webkit [158095] by
-
- 4 edits in trunk/Websites/test-results
Make new bug link in flakiness dashboard configurable
https://bugs.webkit.org/show_bug.cgi?id=123386
Reviewed by Alexey Proskuryakov.
- config.json: Added Bugzilla as the default destination for new bugs.
- public/api/manifest.php: Include newBugLinks in the manifest.
- public/index.html:
(TestResultsView): Initialize _newBugLinks.
(TestResultsView.setNewBugLinks): Added.
(TestResultsView._populateTestPane):
(TestResultsView._createTestResultRow): Replaced the hard-coded Bugzilla URL by the code
to generate hyper-links based on _newBugLinks. Also added a nullity check while formatting
revision checks so that we don't blow up when some build doesn't contain all revision info.
(TestResultsView._populateBuilderPane):
- 5:48 PM Changeset in webkit [158094] by
-
- 3 edits in trunk/Websites/test-results
New flakiness dashboard should support substring matching
https://bugs.webkit.org/show_bug.cgi?id=123393
Reviewed by Alexey Proskuryakov.
Addressed the use cases by
- Always showing the candidate even when there is exactly one test matching the current value.
- Adding all tests that match the current value upon the user pressing enter key.
- public/index.html:
(fetchManifest): Add all tests that match the current value. Confirm whether the user really
want to add all the tests when there are more than 15 tests to add.
- public/js/autocompleter.js:
(Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
(Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
exactly one test that matches the criteria so that the user can select this test.
- 5:47 PM Changeset in webkit [158093] by
-
- 2 edits in trunk/Websites/test-results
New flakiness dashboard shouldn't treat tests with right expectations as failing
https://bugs.webkit.org/show_bug.cgi?id=123385
Reviewed by Alexey Proskuryakov.
We define failing tests to be tests with wrong expectations whose actual results are not PASS
since tests with TEXT, IMAGE, etc... failures do not turn the bots red as long as the expectation
of the same type is specified in TestExpectation files.
- public/include/test-results.php:
(FailingResultsJSONWriter): Inherit from WrongExpectationsResultsJSONWriter.
- 1:42 PM Changeset in webkit [158092] by
-
- 2 edits in trunk/LayoutTests
Crashy WebGL test is crashy.
- platform/mac/TestExpectations:
- 1:23 PM Changeset in webkit [158091] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[WKBackForwardList forwardItem] returns the back item
https://bugs.webkit.org/show_bug.cgi?id=123391
Reviewed by Mark Rowe.
- UIProcess/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList forwardItem]): Changed back to forward.
- 11:59 AM Changeset in webkit [158090] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderImageResourceStyleImage always has a StyleImage.
<https://webkit.org/b/123390>
Codify the fact that RenderImageResourceStyleImage always wraps an
existing StyleImage object.
Reviewed by Antti Koivisto.
- 11:45 AM Changeset in webkit [158089] by
-
- 2 edits in trunk/LayoutTests
Skip two WebGL tests that either crash or fail.
- platform/mac/TestExpectations:
- 11:39 AM Changeset in webkit [158088] by
-
- 4 edits in trunk/Source/WebCore
Revert some accidental changes.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp:
- css/CSSFontSelector.h:
- 10:09 AM Changeset in webkit [158087] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed, rolling out r158075.
http://trac.webkit.org/changeset/158075
https://bugs.webkit.org/show_bug.cgi?id=123389
Broke WebKit2.PrivateBrowsingPushStateNoHistoryCallback API
test (Requested by ap on #webkit).
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing):
(WebKit::WebContext::willStopUsingPrivateBrowsing):
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
- UIProcess/WebIconDatabase.h:
- 9:11 AM Changeset in webkit [158086] by
-
- 2 edits in trunk/Source/WebCore
Gardening: fixed broken build.
https://bugs.webkit.org/show_bug.cgi?id=123354.
- css/CSSFontSelector.h:
- 8:44 AM Changeset in webkit [158085] by
-
- 7 edits in trunk
Source/WebCore: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
Reviewed by Andreas Kling.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Don't enable simple line layout if the primary font is loading. The code expects
to use the primary font metrics for all lines but those won't match the fallbacks
when font is not loaded.
LayoutTests: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
Reviewed by Andreas Kling.
- TestExpectations: Remove failure expectation
- 8:17 AM Changeset in webkit [158084] by
-
- 2 edits in trunk/Source/WebKit2
Remove Coordinated Graphics bits from DrawingAreaProxyImpl
https://bugs.webkit.org/show_bug.cgi?id=123382
Reviewed by Anders Carlsson.
As of r156861, Coordinated Graphics does not use DrawingAreaProxyImpl.
So, Coordinated Graphics bits should be removed from DrawingAreaProxyImpl.
- UIProcess/DrawingAreaProxyImpl.h:
- 4:02 AM Changeset in webkit [158083] by
-
- 14 edits in trunk/Source/WebCore
[GTK] Deprecate public dispatch_event method in objects implementing EventTarget interface
https://bugs.webkit.org/show_bug.cgi?id=123261
Reviewed by Gustavo Noronha Silva.
The interface function should be used instead.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetFunctionDeprecationInformation): Helper function to return the
version when the function was deprecated and the function
replacing the deprecated one.
(GenerateFunction): Check if the function is deprecated to mark it
as such in the header and API docs.
- bindings/scripts/gobject-generate-headers.pl: Replace the unused
WEBKIT_OBSOLETE_API macro with new macros to mark function as
deprecated, using the glib macros so that we don't need checks for
the platform.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/GObject/WebKitDOMattribute.h:
- 12:16 AM Changeset in webkit [158082] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] clang static analyzer warns about object being autoreleased too many times in +[WKNSArray web_arrayWithImmutableArray:]
https://bugs.webkit.org/show_bug.cgi?id=123384
Reviewed by Mark Rowe.
- Shared/Cocoa/WKNSArray.h: Annotated -web_initWithImmutableArray: as an init method.
Oct 25, 2013:
- 11:37 PM Changeset in webkit [158081] by
-
- 3 edits in trunk/Source/WebKit2
Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
https://bugs.webkit.org/show_bug.cgi?id=123330
Reviewed by Darin Adler.
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- 11:13 PM Changeset in webkit [158080] by
-
- 2 edits in trunk/Websites/test-results
Build fix. The query results weren't sorted by the latest commit time,
yielding wrong set of tests to be listed in the builder pane.
- public/include/test-results.php:
- 10:50 PM Changeset in webkit [158079] by
-
- 2 edits in trunk/Websites/test-results
Links in new flakiness dashboard could benefit from tooltips
https://bugs.webkit.org/show_bug.cgi?id=123381
Reviewed by Alexey Proskuryakov.
Add title content attribute on each hyperlink in the builder pane.
- public/index.html:
(TestResultsView._populateBuilderPane):
- 10:41 PM Changeset in webkit [158078] by
-
- 2 edits1 move1 add1 delete in trunk/LayoutTests
REGRESSION (r158069): platform/mac/fast/loader/file-url-mimetypes.html
is failing on all Mountain Lion bots.
- platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Removed.
- platform/mac-mountainlion/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from LayoutTests/platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt.
Mountain Lion results for platform/mac tests need to be in this crazy place apparently.
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Removed.
Mavericks results should be in platform/mac, not platform/mac/platform/mac.
Yes, the latter works and takes precedence, but it's wrong.
- 6:23 PM Changeset in webkit [158077] by
-
- 2 edits in trunk/Websites/test-results
Commit the right change.
- public/index.html:
- 6:19 PM Changeset in webkit [158076] by
-
- 2 edits in trunk/Websites/test-results
The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363
Reviewed by Simon Fraser.
Sort the forgotten builders in the menu.
- public/index.html:
- 5:29 PM Changeset in webkit [158075] by
-
- 5 edits in trunk/Source/WebKit2
WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375
Reviewed by Beth Dakin.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes, notify WebIconDatabase.
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setPrivateBrowsingEnabled):
- UIProcess/WebIconDatabase.h:
- 5:25 PM Changeset in webkit [158074] by
-
- 3 edits in trunk/Source/JavaScriptCore
Refactor parser rollback logic
https://bugs.webkit.org/show_bug.cgi?id=123372
Reviewed by Brady Eidson.
Add a sane abstraction for rollbacks in the parser.
- parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseObjectLiteral):
- parser/Parser.h:
(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):
- 5:02 PM Changeset in webkit [158073] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r156315. <rdar://problem/15109335>
- 4:53 PM Changeset in webkit [158072] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: PrettyPrinting tool should have save button
https://bugs.webkit.org/show_bug.cgi?id=123371
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.
Add buttons to save as a URL to share or to save/clear to
localStorage for easier reloads testing local changes.
- Tools/PrettyPrinting/index.html:
- 4:46 PM Changeset in webkit [158071] by
-
- 2 edits in trunk/LayoutTests
Tweak some test expectations.
- platform/mac/TestExpectations:
- 4:35 PM Changeset in webkit [158070] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark skipped webgl conformance tests as either flakey or failures.
Also reorganize expectations for WebGL a bit.
- platform/mac/TestExpectations:
- 4:33 PM Changeset in webkit [158069] by
-
- 2 edits1 copy8 adds in trunk/LayoutTests
Add Mavericks-specific results for some tests.
- platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Added.
- platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
- 4:29 PM Changeset in webkit [158068] by
-
- 3 edits3 copies2 adds in branches/safari-537.73-branch
Merged r156214. <rdar://problem/15109485>
- 4:22 PM Changeset in webkit [158067] by
-
- 7 edits2 copies in branches/safari-537.73-branch
Merged r155665. <rdar://problem/15109475>
- 4:16 PM Changeset in webkit [158066] by
-
- 2 edits in trunk/LayoutTests
Mark some CSS filters and SVG ref tests as failing, and two WebGL tests are flakey.
- platform/mac/TestExpectations:
- 4:03 PM Changeset in webkit [158065] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r155608. <rdar://problem/15109361>
- 3:52 PM Changeset in webkit [158064] by
-
- 2 edits1 copy8 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
- platform/mac-mountainlion/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
- 3:45 PM Changeset in webkit [158063] by
-
- 3 edits4 copies in branches/safari-537.73-branch
Merged r155546. <rdar://problem/15109351>
- 3:24 PM Changeset in webkit [158062] by
-
- 2 edits2 adds in trunk/LayoutTests
Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager
https://bugs.webkit.org/show_bug.cgi?id=123361
Reviewed by Timothy Hatcher.
Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
and removed.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
with "FAIL" or "PASS" depending on the value.
(InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.
- inspector-protocol/model/content-flow-list-expected.txt: Added.
- inspector-protocol/model/content-flow-list.html: Added.
- 3:23 PM Changeset in webkit [158061] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Command+Click on url(…) should go to image not source line
https://bugs.webkit.org/show_bug.cgi?id=123362
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.
CodeMirror changed "url" from being type "variable-2" to "string-2".
- UserInterface/CodeMirrorAdditions.js:
- 3:10 PM Changeset in webkit [158060] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155468.
- 3:08 PM Changeset in webkit [158059] by
-
- 8 edits4 copies in branches/safari-537.73-branch
Merged r155461. <rdar://problem/15109345>
- 3:03 PM Changeset in webkit [158058] by
-
- 3 edits in trunk/Source/WebCore
DatabaseManager's ProposedDatabases need to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=123313.
Reviewed by Geoffrey Garen.
No new tests.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
- 3:01 PM Changeset in webkit [158057] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Win] Javascript crash with DFG JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=121001
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Geoffrey Garen.
On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::storeDouble): Assert if we try to generate code which writes to a null pointer.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator): Ditto.
- 3:01 PM Changeset in webkit [158056] by
-
- 2 edits in trunk/Websites/test-results
The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363
Reviewed by Simon Fraser.
Sort builders and tests by their name in each pane.
- public/index.html:
(TestResultsView._populateTestPane): Lexicologically sort builders by their name.
(TestResultsView._sortObjectsByName): Added.
(TestResultsView._populateBuilderPane): Lexicologically sort builders by their name.
- 2:57 PM Changeset in webkit [158055] by
-
- 4 edits in trunk/Websites/test-results
Merge revision columns in flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123360
Reviewed by Simon Fraser.
Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
Also add colors for missing & audio failures so that they won't be an empty cell.
- public/index.html:
(TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
(TestResultsView._createTestResultRow): Use single td for all revision numbers.
- public/js/build.js:
(.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.
- public/main.css:
(.resultsTable .AUDIO a): Added.
(.resultsTable .MISSING a): Added.
- 2:54 PM Changeset in webkit [158054] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r155212. <rdar://problem/15109471>
- 2:51 PM Changeset in webkit [158053] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r155153. <rdar://problem/15109457>
- 2:32 PM Changeset in webkit [158052] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155127. <rdar://problem/15109454>
- 2:31 PM Changeset in webkit [158051] by
-
- 7 edits in trunk
Fix a number of problems with destructuring of arguments
https://bugs.webkit.org/show_bug.cgi?id=123357
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This renames the destructuring node's emitBytecode to bindValue
in order to remove the existing confusion over what was happening.
We then fix an incorrect fall through in the destructuring arguments
logic, and fix the then exposed bug where we placed the index rather
than value into the bound property.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::bindValue):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ObjectPatternNode::bindValue):
(JSC::BindingNode::bindValue):
- parser/Nodes.h:
LayoutTests:
Add additional testing
- js/destructuring-assignment-expected.txt:
- js/script-tests/destructuring-assignment.js:
- 1:59 PM Changeset in webkit [158050] by
-
- 25 edits16 adds in trunk/Source
Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
https://bugs.webkit.org/show_bug.cgi?id=123111
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/ios:
iOS does not have a local inspector, only remote. So give it a custom
implementation separate from the WebKit/mac WebInspectorClient
implementation which handles an attaching/detaching local inspector.
- WebKit.xcodeproj/project.pbxproj:
- ios/WebCoreSupport/WebInspectorClientIOS.mm: Added.
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):
(WebInspectorClient::closeInspectorFrontend):
(WebInspectorClient::didResizeMainFrame):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::attachAvailabilityChanged):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(WebInspectorFrontendClient::setToolbarHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Source/WebKit/mac:
The actual implementation at the WebCoreSupport/WebInspectorClient level
is the same as INSPECTOR_SERVER. Give debuggable pages a pageIdentifer.
- Configurations/FeatureDefines.xcconfig:
- Misc/WebKitLogging.h:
Misc.
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::pageId):
(WebInspectorClient::setPageId):
Give WebInspectorClient's a page identifier.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
A WebInspectorClient can be either local or remote. Add handling
for remote connections.
- WebInspector/remote/WebInspectorClientRegistry.h: Added.
- WebInspector/remote/WebInspectorClientRegistry.mm: Added.
(+[WebInspectorClientRegistry sharedRegistry]):
(-[WebInspectorClientRegistry init]):
(-[WebInspectorClientRegistry _getNextAvailablePageId]):
(-[WebInspectorClientRegistry registerClient:]):
(-[WebInspectorClientRegistry unregisterClient:]):
(-[WebInspectorClientRegistry clientForPageId:]):
(-[WebInspectorClientRegistry inspectableWebViews]):
Registry for all potentially debuggable pages. All WebInspectorClient instances.
- WebInspector/remote/WebInspectorRelayDefinitions.h: Added.
Constants (message keys) shared between WebKit and the XPC process.
- WebInspector/remote/WebInspectorServer.h: Added.
- WebInspector/remote/WebInspectorServer.mm: Added.
(-[WebInspectorServer init]):
(-[WebInspectorServer dealloc]):
(-[WebInspectorServer start]):
(-[WebInspectorServer stop]):
(-[WebInspectorServer isEnabled]):
(-[WebInspectorServer xpcConnection]):
(-[WebInspectorServer setupXPCConnectionIfNeeded]):
(-[WebInspectorServer pushListing]):
(-[WebInspectorServer hasActiveDebugSession]):
(-[WebInspectorServer setHasActiveDebugSession:]):
(-[WebInspectorServer xpcConnection:receivedMessage:userInfo:]):
(-[WebInspectorServer xpcConnectionFailed:]):
(-[WebInspectorServer didRegisterClient:]):
(-[WebInspectorServer didUnregisterClient:]):
Singleton to start/stop remote inspection. Handles the connection to the XPC
and hands off connections to the connection controller.
- WebInspector/remote/WebInspectorServerWebViewConnection.h: Added.
- WebInspector/remote/WebInspectorServerWebViewConnection.mm: Added.
(-[WebInspectorServerWebViewConnection initWithController:connectionIdentifier:destination:identifier:]):
(-[WebInspectorServerWebViewConnection setupChannel]):
(-[WebInspectorServerWebViewConnection dealloc]):
(-[WebInspectorServerWebViewConnection connectionIdentifier]):
(-[WebInspectorServerWebViewConnection identifier]):
(-[WebInspectorServerWebViewConnection clearChannel]):
(-[WebInspectorServerWebViewConnection sendMessageToFrontend:]):
(-[WebInspectorServerWebViewConnection sendMessageToBackend:]):
(-[WebInspectorServerWebViewConnection receivedData:]):
(-[WebInspectorServerWebViewConnection receivedDidClose:]):
An individual remote debug session connection.
- WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Added.
- WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Added.
(-[WebInspectorServerWebViewConnectionController initWithServer:]):
(-[WebInspectorServerWebViewConnectionController dealloc]):
(-[WebInspectorServerWebViewConnectionController closeAllConnections]):
(-[WebInspectorServerWebViewConnectionController _listingForWebView:pageId:registry:]):
(-[WebInspectorServerWebViewConnectionController _pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing]):
(-[WebInspectorServerWebViewConnectionController _receivedSetup:]):
(-[WebInspectorServerWebViewConnectionController _receivedData:]):
(-[WebInspectorServerWebViewConnectionController _receivedDidClose:]):
(-[WebInspectorServerWebViewConnectionController _receivedGetListing:]):
(-[WebInspectorServerWebViewConnectionController _receivedIndicate:]):
(-[WebInspectorServerWebViewConnectionController _receivedConnectionDied:]):
(-[WebInspectorServerWebViewConnectionController receivedMessage:userInfo:]):
(-[WebInspectorServerWebViewConnectionController connectionClosing:]):
(-[WebInspectorServerWebViewConnectionController sendMessageToFrontend:userInfo:]):
ConnectionController:
- Holds all the current ongoing remote debug connections.
- Simplifies multi-threaded work on iOS.
- Dispatches incoming messages from the remote connection.
- WebInspector/remote/WebInspectorRemoteChannel.h: Added.
- WebInspector/remote/WebInspectorRemoteChannel.mm: Added.
(+[WebInspectorRemoteChannel createChannelForPageId:connection:]):
(-[WebInspectorRemoteChannel initWithRemote:local:]):
(-[WebInspectorRemoteChannel closeFromLocalSide]):
(-[WebInspectorRemoteChannel closeFromRemoteSide]):
(-[WebInspectorRemoteChannel sendMessageToFrontend:]):
(-[WebInspectorRemoteChannel sendMessageToBackend:]):
Thin interface between the remote connection and web inspector client.
This simplifies breaking the connection from either side, e.g. the
page closing, or the remote connection disconnecting.
- WebInspector/remote/WebInspectorXPCWrapper.h: Added.
- WebInspector/remote/WebInspectorXPCWrapper.m: Added.
(-[WebInspectorXPCWrapper initWithConnection:]):
(-[WebInspectorXPCWrapper close]):
(-[WebInspectorXPCWrapper dealloc]):
(-[WebInspectorXPCWrapper _deserializeMessage:]):
(-[WebInspectorXPCWrapper _handleEvent:]):
(-[WebInspectorXPCWrapper sendMessage:userInfo:]):
(-[WebInspectorXPCWrapper available]):
- WebKit.exp:
XPC Connection wrapper handling a simple message format.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView sharedWebInspectorServer]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView canBeRemotelyInspected]):
(-[WebView allowsRemoteInspection]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setRemoteInspectorUserInfo:]):
(-[WebView remoteInspectorUserInfo]):
Remote inspector private API.
- Enable / disable globally
- Allow / disallow per webview
- Optionally attach a userInfo dictionary on the WebView that is published with listing.
- Indicate a WebView (implementation to land later)
(-[WebView _didCommitLoadForFrame:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveTitle):
Pages changed, pushed page listing.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 1:41 PM Changeset in webkit [158049] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r157995.
- 1:40 PM Changeset in webkit [158048] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157815.
- 1:39 PM Changeset in webkit [158047] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157687.
- 1:38 PM Changeset in webkit [158046] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157553.
- 1:37 PM Changeset in webkit [158045] by
-
- 5 edits in branches/safari-537-branch/Tools
Merged r154450.
- 1:36 PM Changeset in webkit [158044] by
-
- 12 edits3 adds2 deletes in trunk
[CSS Shapes] CORS-enabled fetch for shape image values
https://bugs.webkit.org/show_bug.cgi?id=123114
Reviewed by Andreas Kling.
Source/WebCore:
Access to shape images is now controlled by CORS CSS shape per
http://dev.w3.org/csswg/css-shapes/#shape-outside-property.
Previously shape images had to be same-origin.
Shape image URL access is defined by the same logic that defines
canvas tainting: same-origin and data URLs are allowed and images
with a "Access-Control-Allow-Origin:" header that's either "*" or
that matches the document's origin.
A PotentiallyCrossOriginEnabled RequestOriginPolicy was added to
ResourceLoaderOptions, to indicate that a "potentially CORS-enabled fetch"
was to be undertaken. The CSSImageValue::cachedImage() method handles this
option by effectively setting the "Origin:" request header (see
updateRequestForAccessControl() in CrossOriginAccessControl.cpp).
StyleResolver::loadPendingShapeImage() uses the new ResourceLoaderOption.
The static ShapeInsideInfo and ShapeOutsideInfo isEnabledFor() method
now performs the CORS check for image valued shapes. The private
isOriginClean() method from CanvasRenderingContext2D has been moved to
the CachedImage class so that it can be shared by the Canvas and Shape
implementations. It checks the response headers per the CORS spec.
Test: http/tests/security/shape-image-cors.html
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): Handle the new ResourceLoaderOption.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage): Set the new ResourceLoaderOption.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern): Use the CachedImage::isOriginClean().
- loader/ResourceLoaderOptions.h: Added PotentiallyCrossOriginEnabled to RequestOriginPolicy.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::isOriginClean): Migrated from CanvasRenderingContext2D.
- loader/cache/CachedImage.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::checkImageOrigin): Do the CORS check and log an error message if neccessary.
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::isEnabledFor): Call checkImageOrigin() for images.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::isEnabledFor): Ditto.
LayoutTests:
Verify that images not allowed by CORS don't affect the layout
and that same-origin images, data URLs, and images with a
"Access-Control-Allow-Origin: *" header do define the layout.
Added a simple PHP script that optionally adds the allow origin header.
Replaced and renamed the original shape same-origin-only test.
- http/tests/security/resources/image-access-control.php: Added.
- http/tests/security/shape-image-cors-expected.html: Added.
- http/tests/security/shape-image-cors.html: Added.
- http/tests/security/shape-inside-image-origin-expected.txt: Removed.
- http/tests/security/shape-inside-image-origin.html: Removed.
- 1:36 PM Changeset in webkit [158043] by
-
- 2 edits in branches/safari-537.73-branch/Tools
Merged r157995.
- 1:35 PM Changeset in webkit [158042] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157815.
- 1:35 PM Changeset in webkit [158041] by
-
- 7 edits6 copies8 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
- platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
- platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
- platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
- platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
- platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
- platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
- platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/text/drawBidiText-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- 1:35 PM Changeset in webkit [158040] by
-
- 6 edits in trunk/Source/WebCore
[MSE] Fix runtime errors caused by mediasource IDL attributes.
https://bugs.webkit.org/show_bug.cgi?id=123352
Reviewed by Eric Carlson.
Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediasource/WebKitMediaSource.idl:
- Modules/mediasource/WebKitSourceBufferList.idl:
- 1:34 PM Changeset in webkit [158039] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157687.
- 1:33 PM Changeset in webkit [158038] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157553.
- 1:32 PM Changeset in webkit [158037] by
-
- 5 edits in branches/safari-537.73-branch/Tools
Merged r154450.
- 1:16 PM Changeset in webkit [158036] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix or disable some deprecation warnings.
Reviewed by Darin Adler.
- Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel cancel:]): On newer OS versions, use the modern API.
(-[WebAuthenticationPanel logIn:]): Ditto.
(-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Ditto. Translate the
response code in to the form that -sheetDidEnd:responseCode:contextInfo: expects.
- WebView/WebClipView.mm:
(-[WebClipView initWithFrame:]): Disable deprecation warnings since it's not obvious
how to avoid calling -releaseGState here.
- 12:55 PM Changeset in webkit [158035] by
-
- 1 edit3 moves2 adds in trunk/LayoutTests
Apparently we need results in platform/mac-mountainlion/platform/mac/ for MountionLion.
- platform/mac-mountainlion/accessibility/aria-readonly-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/accessibility/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt.
- platform/mac-mountainlion/platform/mac/accessibility/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt.
- platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt.
- 12:44 PM Changeset in webkit [158034] by
-
- 4 edits in trunk/Source/WebKit2
Merge viewInWindowStateDidChange into viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123351
Reviewed by Tim Horton.
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
- viewInWindowStateDidChange -> viewStateDidChange
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- removed viewInWindowStateDidChange, renamed parameter to viewStateDidChange
- UIProcess/WebPageProxy.h:
- removed viewInWindowStateDidChange, named parameter to viewStateDidChange
- 12:15 PM Changeset in webkit [158033] by
-
- 2 edits in trunk/Source/WebKit2
One more URTBF for GTK after r158028.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseMap):
(webkitWebViewBaseUnmap):
- 12:07 PM Changeset in webkit [158032] by
-
- 4 edits in trunk/Source/WebKit2
URTBF from non-Mac platforms after r158028.
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowFocusInEvent):
(toplevelWindowFocusOutEvent):
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseSetFocus):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setActive):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):
- 12:06 PM Changeset in webkit [158031] by
-
- 2 edits in trunk/LayoutTests
fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
- TestExpectations: Skip for now.
- 11:42 AM Changeset in webkit [158030] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube
https://bugs.webkit.org/show_bug.cgi?id=123349
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-10-25.
Reviewed by George Staikos.
Internally reviewed by George Staikos, Konrad Piascik, Eli Fidler and Arvid Nilsson.
Browser crashed when dereferencing null PlatformGraphicsContext*.
In FrameView::paintControlTints(), we intentionally constructed GraphicsContext
with null PlatformGraphicsContext* and disabled painting by doing
context.setUpdatingControlTints(true). So we should not go further in
GraphicsContext::drawLineForText() if painting is disabled.
Check paintingDisabled() for the other functions in PathBlackBerry.cpp
as well; otherwise, it is likely we will crash at those places.
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
- 11:38 AM Changeset in webkit [158029] by
-
- 45 edits44 copies35 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
- platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
- platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
- platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
- platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
- platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
- platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
- platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
- platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
- platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
- platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
- platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
- platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
- platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
- platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
- platform/mac-mountainlion/fast/table/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/003-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
- platform/mac-mountainlion/fast/table/spanOverlapRepaint-expected.txt: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.txt.
- platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
- platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
- platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
- platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
- platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
- platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
- platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
- platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
- platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
- platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
- platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
- platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/isindex-001-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/parser/document-write-option-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/selectors/064-expected.txt:
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/text/updateNewFont-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/platform/mac/fast/text/systemFont-expected.txt:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/transforms/2d/zoom-menulist-expected.txt:
- platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
- 11:26 AM Changeset in webkit [158028] by
-
- 5 edits1 add in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Reviewed by Sam Weinig.
WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.
- Shared/ViewState.h: Added.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:24 AM Changeset in webkit [158027] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Unreviewed
Rolling out 158026 - landed extra chnages!
- Shared/ViewState.h: Removed.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewInWindowStateDidChange):
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:20 AM Changeset in webkit [158026] by
-
- 5 edits1 add in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Reviewed by Sam Weinig.
WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.
- Shared/ViewState.h: Added.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:06 AM Changeset in webkit [158025] by
-
- 2 edits1 copy9 adds in trunk/LayoutTests
New results for some accessibility tests.
- platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
- platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt: Added.
- platform/mac/accessibility/aria-readonly-expected.txt: Added.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
- 11:04 AM Changeset in webkit [158024] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154915. <rdar://problem/15109453>
- 11:02 AM Changeset in webkit [158023] by
-
- 9 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154914. <rdar://problem/15109453>
- 11:01 AM Changeset in webkit [158022] by
-
- 2 edits in trunk/Source/WebInspectorUI
Ran update-localizable-strings after changes made in r157947.
Rubber-stamped by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- 10:59 AM Changeset in webkit [158021] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC again
- 10:47 AM Changeset in webkit [158020] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154890. <rdar://problem/15109453>
- 10:44 AM Changeset in webkit [158019] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r154856. <rdar://problem/15109399>
- 10:35 AM Changeset in webkit [158018] by
-
- 11 edits2 adds in trunk/Source/WebCore
Adding platform implementation of MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=123301
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-25
Reviewed by Eric Carlson.
No new tests needed.
- CMakeLists.txt:
- Modules/mediastream/AudioStreamTrack.cpp:
(WebCore::AudioStreamTrack::create): Create method now receives a MediaStreamTrackPrivate as parameter.
(WebCore::AudioStreamTrack::AudioStreamTrack):
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Constructor now iterates through a set of MediaStreamTrackPrivate
instances to create each MediaStreamTrack of MediaStream.
(WebCore::MediaStream::addRemoteSource): Calling AudioStreamTrack and VideoStreamTrack with
MediaStreamTrackPrivate as parameter.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Constructor now receives a MediaStreamTrackPrivate, instead of a
MediaStreamSource.
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::setSource): Ditto.
(WebCore::MediaStreamTrack::id): Ditto.
(WebCore::MediaStreamTrack::label): Ditto.
(WebCore::MediaStreamTrack::enabled): Ditto.
(WebCore::MediaStreamTrack::setEnabled): Ditto.
(WebCore::MediaStreamTrack::muted): Ditto.
(WebCore::MediaStreamTrack::readonly): Ditto.
(WebCore::MediaStreamTrack::remote): Ditto.
(WebCore::MediaStreamTrack::readyState): Ditto.
(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::capabilities):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended): Ditto.
(WebCore::MediaStreamTrack::sourceStateChanged): Ditto.
(WebCore::MediaStreamTrack::sourceMutedChanged): Ditto.
(WebCore::MediaStreamTrack::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::stopped): Ditto.
(WebCore::MediaStreamTrack::trackDidEnd): Setting Ended ready state in MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::trackReadyStateChanged): Dispatches Live or Ended event.
(WebCore::MediaStreamTrack::trackMutedChanged): Dispatches Muted event.
- Modules/mediastream/MediaStreamTrack.h: Now inheriting from MediaStreamTrackPrivateClient.
(WebCore::MediaStreamTrack::source): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::privateTrack):
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack): Create method now receives a MediaStreamTrackPrivate as parameter.
- Modules/mediastream/VideoStreamTrack.h:
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Stores the private tracks in a Vector (property of
MediaStreamDescriptor class).
(WebCore::MediaStreamDescriptor::addTrack): Adds a private track to the tracks' Vector
(WebCore::MediaStreamDescriptor::removeTrack): Removes a private track from the tracks' Vector
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::numberOfAudioSources): Renamed from numberOfAudioStreams.
(WebCore::MediaStreamDescriptor::audioSources): Renamed from audioStreams.
(WebCore::MediaStreamDescriptor::numberOfVideoSources): Renamed from numberOfVideoStreams.
(WebCore::MediaStreamDescriptor::videoSources): Renamed from videoStreams.
(WebCore::MediaStreamDescriptor::numberOfAudioTracks): Returns the number of audio tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::audioTracks): Returns a audio track, given an index
(WebCore::MediaStreamDescriptor::numberOfVideoTracks): Returns the number of video tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::videoTracks): Returns a video track, given an index
- platform/mediastream/MediaStreamTrackPrivate.cpp: Added.
- platform/mediastream/MediaStreamTrackPrivate.h: Added.
- 10:30 AM Changeset in webkit [158017] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC
- 10:27 AM Changeset in webkit [158016] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with multiple regions
<https://webkit.org/b/123210>
Reviewed by David Hyatt.
I simplified the determination of the next region part of updateShapeAndSegmentsForCurrentLineInFlowThread's implementation
in order to make the code more straightforward. I also tried to avoid using regionAtBlockOffset(...) function where it's possible,
since it's not always that reliable, what I'll will report in a separate bug.
No new tests, covered by existing tests.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
- 10:26 AM Changeset in webkit [158015] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with the first lines
<https://bugs.webkit.org/show_bug.cgi?id=123275>
Reviewed by David Hyatt.
We have a complex condition in updateShapeAndSegmentsForCurrentLineInFlowThread, which is
adjusting the first line to the shape's top. This patch adds two boolean to make that clear.
No new tests, no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
- 10:13 AM Changeset in webkit [158014] by
-
- 207 edits in trunk
Improve JSC Parser error messages
https://bugs.webkit.org/show_bug.cgi?id=123341
Reviewed by Andreas Kling.
Source/JavaScriptCore:
This patch moves away from the current cludgy mechanisms used to produce
error messages and moves to something closer to case by case errors.
This results in a large change size as previously we may just have
'failIfFalse(foo)', but now the logic becomes either
'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
Or alternatively
if (!foo)
check for 'interesting' errors, before falling back to generic error
This means that this patch is large, but produces no semantic changes, and
only hits slow (e.g. error) paths.
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::stringForFunctionMode):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::operatorString):
(JSC::::parseUnaryExpression):
(JSC::::printUnexpectedTokenText):
- parser/Parser.h:
(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::hasDeclaredParameter):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::hasDeclaredParameter):
(JSC::Parser::setErrorMessage):
LayoutTests:
Update a vast array of layout test results
- fast/events/window-onerror5-expected.txt:
- js/basic-strict-mode-expected.txt:
- js/break-ASI-expected.txt:
- js/dom/assign-expected.txt:
- js/dom/object-extra-comma-expected.txt:
- js/dom/parse-error-external-script-in-eval-expected.txt:
- js/dom/parse-error-external-script-in-new-Function-expected.txt:
- js/dom/reserved-words-as-property-expected.txt:
- js/function-constructor-error-expected.txt:
- js/function-declaration-expected.txt:
- js/function-toString-object-literals-expected.txt:
- js/function-toString-parentheses-expected.txt:
- js/js-continue-break-restrictions-expected.txt:
- js/kde/garbage-n-expected.txt:
- js/kde/parse-expected.txt:
- js/no-semi-insertion-at-end-of-script-expected.txt:
- js/object-literal-syntax-expected.txt:
- js/parser-xml-close-comment-expected.txt:
- js/regexp-compile-crash-expected.txt:
- js/script-tests/function-constructor-error.js:
- js/script-tests/reserved-words-strict.js:
(isReserved):
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
- sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
- sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:
- 9:37 AM Changeset in webkit [158013] by
-
- 9 edits in trunk/Source/WebKit2
[GTK][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123325
Reviewed by Carlos Garcia Campos.
DrawingArea::visibilityDidChange was removed in favour of a new
message called SetIsVisible which is sent to the WebPage. This
means that {suspend|resume}Paiting are now implemented in a
cross-platform way in WebPage and do not require specific code
from the DrawingArea implementations.
This means that we have to track the toplevel window visibility
and notify the WebPage appropriately about its changes.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isWindowVisible):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseIsWindowVisible):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndWebPageAreFocused):
- 8:58 AM Changeset in webkit [158012] by
-
- 5 edits in trunk/Source/WebCore
Faster way for simple line layout to check if text has fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=123342
Reviewed by Andreas Kling.
Don't use RenderText::knownToHaveNoOverflowAndNoFallbackFonts as it is slow.
Simple text code path test already guarantees there is no overflow. Test for fallback
fonts explicitly.
- platform/graphics/SimpleFontData.h:
Make FINAL.
- rendering/RenderText.cpp:
- rendering/RenderText.h:
Remove knownToHaveNoOverflowAndNoFallbackFonts() as it has no clients.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Check if all characters can be found from the primary font.
- 7:42 AM Changeset in webkit [158011] by
-
- 7 edits in trunk/Source/WebCore
SVGResourcesCache::clientDestroyed() should take a RenderElement&.
<https://webkit.org/b/123339>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:52 AM Changeset in webkit [158010] by
-
- 8 edits in trunk/Source/WebCore
SVGResourcesCache::clientLayoutChanged() should take a RenderElement&.
<https://webkit.org/b/123336>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:49 AM Changeset in webkit [158009] by
-
- 9 edits in trunk/Source/WebCore
SVGResourcesCache::clientStyleChanged() should take a RenderElement&.
<https://webkit.org/b/123335>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:48 AM Changeset in webkit [158008] by
-
- 14 edits in trunk/Source/WebCore
SVG: postApplyResource() should take a RenderElement&.
<https://webkit.org/b/123334>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:46 AM Changeset in webkit [158007] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=123309
Reviewed by Andreas Kling.
Disable simple line layout on non-Mac plaforms for now.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 6:20 AM Changeset in webkit [158006] by
-
- 2 edits in trunk/Websites/test-results
One more build fix. Put each latest revision information in an actual td.
- public/index.html:
- 5:43 AM Changeset in webkit [158005] by
-
- 3 edits in trunk/Websites/test-results
Yet another set of build fixes.
- Manually strip / from revisions JSON if there is any.
- Suppress warnings from ob_end_flush.
- Allow "+" in actual and expected results as used in "TEXT+IMAGE".
- public/api/report.php:
- public/include/test-results.php:
- 5:28 AM Changeset in webkit [158004] by
-
- 20 edits in trunk/Source/WebCore
SVG: applyResource() should take a RenderElement&.
<https://webkit.org/b/123286>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 5:00 AM Changeset in webkit [158003] by
-
- 15 edits in trunk/Source/WebCore
RenderElement::styleWillChange() should pass newStyle as reference.
<https://webkit.org/b/123332>
When styleWillChange() is called, there is always a new style getting
set so there's no need to handle the null style case.
This flushed out a couple of unnecessary checks.
Reviewed by Antti Koivisto.
- 4:57 AM Changeset in webkit [158002] by
-
- 4 edits in trunk
[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-25
Reviewed by Martin Robinson.
Source/WebKit2:
Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Tools:
- Scripts/run-gtk-tests:
(TestRunner):
- 4:49 AM Changeset in webkit [158001] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=123269
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Csaba Osztrogonác.
- platform/graphics/win/ImageCairoWin.cpp: Added new parameter to BitmapImage::draw() calls.
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- 4:19 AM Changeset in webkit [158000] by
-
- 1 edit1 move in trunk/Websites/test-results
Another build fix. Move .htaccess to public.
- .htaccess: Removed.
- public/.htaccess: Copied from .htaccess.
- 3:31 AM Changeset in webkit [157999] by
-
- 4 edits1 add in trunk
Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=118620
Reviewed by Antti Koivisto.
PerformanceTests:
From Blink r152960 by <ojan@chromium.org>
New performance test for layouts in flexboxes.
- Layout/flexbox-lots-of-data.html: Added.
Source/WebCore:
Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.
Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
- 2:52 AM Changeset in webkit [157998] by
-
- 2 edits in trunk/Source/WebCore
Non-SVG build broken after r157950
https://bugs.webkit.org/show_bug.cgi?id=123328
Reviewed by Xan Lopez.
The isSVGInlineTest() check should be done only if SVG is enabled.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 2:50 AM Changeset in webkit [157997] by
-
- 11 edits in trunk/LayoutTests
[CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
https://bugs.webkit.org/show_bug.cgi?id=123327
Reviewed by Mihnea Ovidenie.
For consistency with Blink we use Vertical instead of Vert in CSS
classes and JS methods related to the selection layout tests for CSS
Regions.
- fast/regions/resources/helper.js:
(selectContentByIdsVertical):
- fast/regions/resources/region-style.css:
- fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
- 1:44 AM Changeset in webkit [157996] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123324
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-10-25
Reviewed by Tim Horton.
Since r157967 and r157972, visibilityDidChange was removed from DrawingAreaProxy.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::visibilityDidChange):
Removed common logic which r157967 moved to WebProcess.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
Make visibilityDidChange to public method.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setVisible):
(WebKit::WebView::isWindowVisible): Added.
- UIProcess/CoordinatedGraphics/WebView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setWindowIsVisible):
- WebProcess/WebPage/WebPage.h:
Moved m_windowIsVisible to use at all WK2 based port.
(WebKit::WebPage::windowIsVisible):
- WebProcess/WebPage/WebPage.messages.in:
Moved SetWindowIsVisible message to use at all WK2 based port.
- 1:32 AM Changeset in webkit [157995] by
-
- 2 edits in trunk/Tools
Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
- Scripts/webkitpy/port/base.py:
(Port.repository_paths):
- 1:31 AM Changeset in webkit [157994] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-25
- platform/gtk-wk2/TestExpectations:
- 12:47 AM Changeset in webkit [157993] by
-
- 2 edits in trunk/Websites/test-results
It turns out that the current instruction only works on Mountain Lion.
Also fixed some typos.
- Install.md:
- 12:13 AM Changeset in webkit [157992] by
-
- 5 edits in trunk
[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137
Reviewed by Eric Carlson.
Source/WTF:
Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.
- wtf/MediaTime.cpp:
(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.
- wtf/MediaTime.h:
(WTF::operator*): Added non-class version of operator*.
Tools:
Add tests for new MediaTime operators.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 12:07 AM Changeset in webkit [157991] by
-
- 7 edits2 copies in trunk/Source
[Mac] Add helper methods to convert CMTime <--> MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123285
Reviewed by Eric Carlson.
Source/WebCore:
Add utility methods to convert between CMTime (a rational time class) and MediaTime.
Once there, PlatformClockCM can now vend and accept MediaTimes for currentTime.
- platform/mac/MediaTimeMac.h:
- platform/mac/MediaTimeMac.cpp:
(WebCore::toMediaTime): Added conversion utility method.
(WebCore::toCMTime): Ditto.
- platform/mac/PlatformClockCM.h:
- platform/mac/PlatformClockCM.mm:
(PlatformClockCM::setCurrentMediaTime): Added.
(PlatformClockCM::currentMediaTime): Added.
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
Source/WTF:
Add a #ifdef header_h protector.
- wtf/MediaTime.h:
Oct 24, 2013:
- 10:17 PM Changeset in webkit [157990] by
-
- 2 edits1 move1 add in trunk/Websites/test-results
Add an instruction on how to setup test-results app
https://bugs.webkit.org/show_bug.cgi?id=123321
Rubber-stamped by Stephanie Lewis.
Added Install.md and updated config.json accordingly.
Also moved init-database.sql out of public/include since it doesn't need to be accessible via httpd.
- Install.md: Added.
- config.json:
- init-database.sql: Moved from public/include/init-database.sql.
- 9:43 PM Changeset in webkit [157989] by
-
- 2 edits1 copy7 moves1 add1 delete in trunk/Websites/test-results
Move everything except ChangeLog and config.json into public directory.
https://bugs.webkit.org/show_bug.cgi?id=123319
Rubber-stamped by Stephanie Lewis.
- admin: Removed.
- admin/admin.css: Removed.
- admin/builders.php: Removed.
- admin/index.php: Removed.
- admin/repositories.php: Removed.
- api: Removed.
- api/failing-tests.php: Removed.
- api/manifest.php: Removed.
- api/report.php: Removed.
- api/results.php: Removed.
- common.css: Removed.
- config.json: Copied from include/config.json.
- include: Removed.
- include/admin-footer.php: Removed.
- include/admin-header.php: Removed.
- include/config.json: Removed.
- include/db.php: Removed.
- include/init-database.sql: Removed.
- include/json-shared.php: Removed.
- include/test-results.php: Removed.
- index.html: Removed.
- js: Removed.
- js/autocompleter.js: Removed.
- js/build.js: Removed.
- js/dom.js: Removed.
- main.css: Removed.
- public: Added.
- public/admin: Copied from admin.
- public/api: Copied from api.
- public/common.css: Copied from common.css.
- public/include: Copied from include.
- public/include/config.json: Removed.
- public/include/db.php:
- public/index.html: Copied from index.html.
- public/js: Copied from js.
- public/main.css: Copied from main.css.
- 9:22 PM Changeset in webkit [157988] by
-
- 9 edits in trunk/Websites/test-results
Showing lists of flaky tests for a builder takes too long
https://bugs.webkit.org/show_bug.cgi?id=123311
Reviewed by Sam Weinig.
Generate JSONs for tests failing, flaky, or with wrong expectation at the time a builder reports results
instead when the frontend requests to those those results since it takes multiple seconds or minutes to
generate those JSON files.
- api/failing-tests.php: Moved and renamed to manually generate all JSON files for a given builder.
(main):
- api/report.php: Manually flush and end the request (to avoid blocking run-webkit-tests on the other side
for minutes), then generate JSONs for tests that are failing, are flaky, and have wrong expectations.
- api/results.php: Merge format_result_rows here since it's not used anywhere else.
- include/config.json: Added the path to the data directory into which JSON files are generated.
- include/db.php:
(configPath): Takes a relative path value from config.json, and resolves it.
- include/json-shared.php:
(echo_success): Extracted from exit_with_success.
(exit_with_success):
- include/test-results.php:
(add_builder): Extracted from add_build.
(add_build):
(ResultsJSONWriter): Extracted from api/failing-tests.php.
(ResultsJSONWriter.construct):
(ResultsJSONWriter.start):
(ResultsJSONWriter.end):
(ResultsJSONWriter.add_results_for_test_if_matches):
(ResultsJSONWriter.pass_for_failure_type):
(FailingResultsJSONWriter): Extracted from index.html's TestResultsView._matchesFailureType.
(FailingResultsJSONWriter.construct):
(FailingResultsJSONWriter.pass_for_failure_type):
(FlakyResultsJSONWriter): Ditto.
(FlakyResultsJSONWriter.construct):
(FlakyResultsJSONWriter.pass_for_failure_type):
(WrongExpectationsResultsJSONWriter): Ditto.
(WrongExpectationsResultsJSONWriter.construct):
(WrongExpectationsResultsJSONWriter.pass_for_failure_type):
(ResultsJSONGenerator): Ditto.
(ResultsJSONGenerator.construct):
(ResultsJSONGenerator.generate):
(ResultsJSONGenerator.open_json_for_failure_type):
(ResultsJSONGenerator.write_jsons):
- index.html:
(TestResultsView):
(TestResultsView.setBuilders):
(TestResultsView._createResultCell): Add a hyperlink to results.html in the tooltip.
(TestResultsView.fetchFailingTestsForBuilder): Fetch the generated JSON files.
- 9:04 PM Changeset in webkit [157987] by
-
- 44 edits in trunk
Remove references to OS X 10.7 from Xcode configuration settings.
Now that we're not building for OS X 10.7 they're no longer needed.
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebContentProcess.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 8:59 PM Changeset in webkit [157986] by
-
- 20 edits19 copies6 adds in trunk/LayoutTests
New Mavericks results for editing and fast/html, with MountainLion fallbacks.
- platform/mac-mountainlion/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
- platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/4806874-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/4806874-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
- platform/mac-mountainlion/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
- platform/mac-mountainlion/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
- platform/mac-mountainlion/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
- platform/mac-mountainlion/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
- platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
- platform/mac-mountainlion/editing/selection/select-from-textfield-outwards-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.txt.
- platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
- platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
- platform/mac-mountainlion/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
- platform/mac-mountainlion/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
- platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- 7:33 PM Changeset in webkit [157985] by
-
- 5 edits in trunk/Source/WebCore
Cache line layout path
https://bugs.webkit.org/show_bug.cgi?id=123298
Reviewed by Sam Weinig.
Determining the path can be non-trivial. Avoid computing it repeatedly on relayouts.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::invalidateLineLayoutPath):
(WebCore::RenderBlock::removeChild):
Invalidate the path when children change.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):
Invalidate the path when style changes.
(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
Invalidate the path when text changes.
- 6:48 PM Changeset in webkit [157984] by
-
- 3 edits in trunk/Source/WebKit2
Coalesce calls to viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123307
Reviewed by Tim Horton.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
- coalesce calls to viewStateDidChange
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- handle changes to view visibility & active state in correct order.
- 6:46 PM Changeset in webkit [157983] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154694. <rdar://problem/15109413>
- 6:44 PM Changeset in webkit [157982] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154693. <rdar://problem/15109413>
- 6:42 PM Changeset in webkit [157981] by
-
- 44 edits in trunk
<rdar://problem/15312643> Prepare for the mysterious future.
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebContentProcess.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 6:41 PM Changeset in webkit [157980] by
-
- 3 edits1 copy in branches/safari-537.73-branch
Merged r154681. <rdar://problem/15109418>
- 6:35 PM Changeset in webkit [157979] by
-
- 5 edits in trunk/Source/WebCore
DocumentLoader::cachedResourceLoader() should return a reference.
<https://webkit.org/b/123303>
..and while we're at it, make DocumentLoader::m_cachedResourceLoader
a Ref, and have CachedResourceLoader::create return a PassRef.
Reviewed by Sam Weinig.
- 6:34 PM Changeset in webkit [157978] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r154655. <rdar://problem/15109412>
- 6:32 PM Changeset in webkit [157977] by
-
- 35 edits1 delete in branches/safari-537.73-branch
Merged r154647. <rdar://problem/15109412>
- 6:27 PM Changeset in webkit [157976] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit
Merged r154642. <rdar://problem/15109339>
- 6:25 PM Changeset in webkit [157975] by
-
- 1 edit3 copies in branches/safari-537.73-branch/Source/WebKit/win
Merged r154634. <rdar://problem/15109339>
- 6:23 PM Changeset in webkit [157974] by
-
- 10 edits2 copies in branches/safari-537.73-branch/Source/WebKit
Merged r154627. <rdar://problem/15109339>
- 6:21 PM Changeset in webkit [157973] by
-
- 24 edits in branches/safari-537.73-branch
Merged r154527. <rdar://problem/15109367>
- 6:17 PM Changeset in webkit [157972] by
-
- 8 edits in trunk/Source/WebKit2
Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273
Patch by Anders Carlsson <andersca@apple.com> on 2013-10-24
Reviewed by Andreas Kling.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 6:15 PM Changeset in webkit [157971] by
-
- 143 edits in trunk/Source
Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273
Reviewed by Andreas Kling.
Source/WebCore:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore::AudioBufferSourceNode::totalPitchRate):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
(WebCore::AudioScheduledSourceNode::stop):
- Modules/webaudio/AudioSummingJunction.cpp:
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/OscillatorNode.cpp:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::dopplerRate):
- Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::processCurve):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
- Modules/websockets/WebSocket.cpp:
(WebCore::saturateAdd):
- Modules/websockets/WebSocketChannel.cpp:
- Modules/websockets/WebSocketFrame.cpp:
(WebCore::WebSocketFrame::parseFrame):
- accessibility/AccessibilityARIAGrid.cpp:
- accessibility/AccessibilityARIAGridCell.cpp:
- accessibility/AccessibilityARIAGridRow.cpp:
- accessibility/AccessibilityList.cpp:
- accessibility/AccessibilityListBox.cpp:
- accessibility/AccessibilityListBoxOption.cpp:
- accessibility/AccessibilityNodeObject.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
- accessibility/AccessibilityTableCell.cpp:
- accessibility/AccessibilityTableColumn.cpp:
- accessibility/AccessibilityTableHeaderContainer.cpp:
- accessibility/AccessibilityTableRow.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getOwnPropertyNames):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::setTimeout):
(WebCore::setMaximumAge):
- bindings/js/ScriptController.cpp:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::readString):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSGradientValue.cpp:
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
- css/CSSReflectValue.cpp:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
- css/PropertySetCSSStyleDeclaration.cpp:
- css/SVGCSSParser.cpp:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::viewportPercentageValue):
- dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
- dom/ContainerNode.cpp:
- dom/Document.cpp:
(WebCore::Document::minimumLayoutDelay):
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
- dom/Range.cpp:
(WebCore::Range::toString):
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/StyledElement.cpp:
(WebCore::StyledElement::makePresentationAttributeCacheKey):
- dom/Text.cpp:
- dom/ViewportArguments.cpp:
(WebCore::clampLengthValue):
(WebCore::clampScaleValue):
(WebCore::ViewportArguments::resolve):
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore::restrictMinimumScaleFactorToViewportSize):
- editing/AlternativeTextController.cpp:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
(WebCore::Editor::compositionRange):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::CharacterIterator::string):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
- editing/htmlediting.cpp:
- editing/markup.cpp:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveResponse):
(WebCore::FileReaderLoader::didReceiveData):
- history/BackForwardList.cpp:
(WebCore::BackForwardList::backListWithLimit):
(WebCore::BackForwardList::forwardListWithLimit):
- history/PageCache.cpp:
(WebCore::PageCache::setCapacity):
- html/BaseDateAndTimeInputType.cpp:
- html/FTPDirectoryDocument.cpp:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::parseColorStringWithCrazyLegacyRules):
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::textTrackAddCue):
(WebCore::HTMLMediaElement::textTrackRemoveCue):
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::duration):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::updateListBoxSelection):
- html/HTMLSourceElement.cpp:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionStart):
(WebCore::HTMLTextFormControlElement::setSelectionEnd):
(WebCore::HTMLTextFormControlElement::select):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- html/HTMLTrackElement.cpp:
- html/ImageDocument.cpp:
(WebCore::ImageDocument::scale):
- html/InputType.cpp:
(WebCore::InputType::valueAsDouble):
- html/MediaController.cpp:
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::updateReadyState):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::setValueAsDouble):
(WebCore::NumberInputType::setValueAsDecimal):
(WebCore::NumberInputType::createStepRange):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::startSearchEventTimer):
- html/StepRange.cpp:
(WebCore::StepRange::clampValue):
(WebCore::StepRange::parseStep):
- html/TimeRanges.cpp:
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::adjustBubblePosition):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
- html/shadow/MediaControlsApple.cpp:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- inspector/ContentSearchUtils.cpp:
- inspector/DOMEditor.cpp:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::diff):
- inspector/InjectedScriptHost.cpp:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::incrementProgress):
- loader/cache/CachedImage.cpp:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- page/EventHandler.cpp:
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
- page/FrameTree.cpp:
- page/FrameView.cpp:
(WebCore::FrameView::adjustedDeferredRepaintDelay):
(WebCore::FrameView::autoSizeIfEnabled):
- page/PrintContext.cpp:
(WebCore::PrintContext::computeAutomaticScaleFactor):
- page/SpatialNavigation.cpp:
(WebCore::entryAndExitPointsForDirection):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFilterOperations):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::extend):
(WebCore::FloatRect::fitToPoints):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
(WebCore::GlyphPageTreeNode::getChild):
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
(WebCore::IntRect::uniteIfNonZero):
- platform/graphics/LayoutRect.cpp:
(WebCore::LayoutRect::intersect):
(WebCore::LayoutRect::unite):
(WebCore::LayoutRect::uniteIfNonZero):
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplySoftware):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- platform/text/TextCodecICU.cpp:
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderTableCell.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
- style/StyleFontSizeFunctions.cpp:
(WebCore::Style::fontSizeForKeyword):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentTime):
Source/WebKit/mac:
- WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView _horizontalPageScrollDistance]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _scaleFactorForPrintOperation:]):
- WebView/WebView.mm:
(+[WebView _setCacheModel:]):
(+[WebView _maxCacheModelInAnyInstance]):
(+[WebView _cacheModelChangedNotification:]):
(+[WebView _preferencesRemovedNotification:]):
Source/WebKit2:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 6:12 PM Changeset in webkit [157970] by
-
- 2 edits1 delete in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=123304
The focus-option-control-on-page.html test has behavior that depends on the system
"Full Keyboard Access" prefs, so mark it as passing or failing, and remove a bogus
result that I added.
- platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Removed.
- platform/mac/TestExpectations:
- 5:48 PM Changeset in webkit [157969] by
-
- 57 edits56 copies41 adds in trunk/LayoutTests
More new test results for Mavericks, and MountainLion results where necessary.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
- platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
- platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
- platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
- platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- 5:43 PM Changeset in webkit [157968] by
-
- 4 edits in trunk/Source/WebKit2
Simplify window occlusion detection code
https://bugs.webkit.org/show_bug.cgi?id=123300
Reviewed by Tim Horton.
Currently the WKView tries to maintain a copy of the window's occluded state,
but forced to NO when occlusion detection is disabled (and capable of handling
dectection being dynamically toggled). Simpler to just rely on the actual value
from the window, && the enabled setting. Cleaning this up revealed that we're
not sending a viewStateDidChange to the WebPageProxy when the occlusion state
changes, which we probably should be.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
- check the real value of occlusion state from the window.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- don't update cached value.
(-[WKView _windowDidChangeOcclusionState:]):
- don't update cached value, but do send viewStateDidChange to the WebPageProxy.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- removed _isWindowOccluded.
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
- Just toggle the flag - no cached state to update any more.
- UIProcess/API/mac/WKViewInternal.h:
- removed _isWindowOccluded.
- 5:42 PM Changeset in webkit [157967] by
-
- 12 edits in trunk/Source/WebKit2
SetIsVisible message should be sent to WebPage
https://bugs.webkit.org/show_bug.cgi?id=123296
Reviewed by Tim Horton.
- UIProcess/DrawingAreaProxy.h:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- Send view visibility updates to the WebPage, not the drawing area.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::suspendPainting):
(WebKit::DrawingArea::resumePainting):
- WebProcess/WebPage/DrawingArea.messages.in:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewIsVisible):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- Added SetViewIsVisible message.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
- Moved animation suspend code out to WebPage.
- 5:15 PM Changeset in webkit [157966] by
-
- 2 edits in trunk/Source/WebInspectorUI
Allow editing CSS resources after they have been pretty printed.
https://bugs.webkit.org/show_bug.cgi?id=123297
Reviewed by Joseph Pecoraro.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor): Remove the need for _readOnly.
(WebInspector.TextEditor.prototype.set readOnly): Set CodeMirror readOnly directly.
(WebInspector.TextEditor.prototype.set formatted): Don't call _updateCodeMirrorReadOnly.
(WebInspector.TextEditor.prototype._updateCodeMirrorReadOnly): Removed.
(WebInspector.TextEditor.prototype._contentChanged): Clear _formatted and _formatterSourceMap
on edit and notify the delegate and fire the FormattingDidChange event.
- 5:14 PM Changeset in webkit [157965] by
-
- 3 edits3 copies in branches/safari-537.73-branch
Merged r154346. <rdar://problem/15109376>
- 5:06 PM Changeset in webkit [157964] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore/dfg
Merge fix for <rdar://problem/15109401>
- 5:02 PM Changeset in webkit [157963] by
-
- 4 edits8 deletes in branches/safari-537.73-branch
Rollout r157962.
- 4:59 PM Changeset in webkit [157962] by
-
- 4 edits8 copies in branches/safari-537.73-branch
Merged r154344. <rdar://problem/15109401>
- 4:45 PM Changeset in webkit [157961] by
-
- 99 edits97 copies26 adds in trunk/LayoutTests
Update fast/forms tests for Mavericks, adding results for MountainLion when necessary.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
- platform/mac-mountainlion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
- platform/mac-mountainlion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
- platform/mac-mountainlion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
- platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
- platform/mac-mountainlion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
- platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
- platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
- platform/mac-mountainlion/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
- platform/mac-mountainlion/fast/forms/input-baseline-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
- platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
- platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
- platform/mac-mountainlion/fast/forms/input-set-composition-scroll-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
- platform/mac-mountainlion/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/input-type-text-min-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-type-text-min-width-expected.txt.
- platform/mac-mountainlion/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
- platform/mac-mountainlion/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
- platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
- platform/mac-mountainlion/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
- platform/mac-mountainlion/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
- platform/mac-mountainlion/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
- platform/mac-mountainlion/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
- platform/mac-mountainlion/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/select-empty-option-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt.
- platform/mac-mountainlion/fast/forms/select-initial-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt.
- platform/mac-mountainlion/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- platform/mac-mountainlion/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
- platform/mac-mountainlion/fast/forms/select/popup-closes-on-blur-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/stuff-on-my-optgroup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt.
- platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
- platform/mac-mountainlion/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/forms/attributed-strings-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/forms/input-number-click-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/basic-selects-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-align-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/button-white-space-expected.txt:
- platform/mac/fast/forms/control-clip-expected.txt:
- platform/mac/fast/forms/control-clip-overflow-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/hidden-listbox-expected.txt:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.txt: Added.
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-field-text-truncated-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/input-width-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/listbox-width-change-expected.txt:
- platform/mac/fast/forms/menulist-no-overflow-expected.txt:
- platform/mac/fast/forms/menulist-option-wrap-expected.txt:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt: Added.
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-align-expected.txt:
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/mac/fast/forms/select-disabled-appearance-expected.txt:
- platform/mac/fast/forms/select-empty-option-height-expected.txt:
- platform/mac/fast/forms/select-initial-position-expected.txt:
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
- platform/mac/fast/forms/select-selected-expected.txt:
- platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/text-style-color-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- 4:35 PM Changeset in webkit [157960] by
-
- 11 edits in trunk/Source/WebCore
Uncomplicate some of SVGTextRunRenderingContext.
<https://webkit.org/b/123294>
This class was weird about a few things, so I've taken these steps
to clear things up:
- FINAL and OVERRIDE all the things.
- Constructor now takes a RenderObject&.
- renderer() now returns a RenderObject&.
- drawSVGGlyphs() no longer takes a TextRun.
- glyphDataForCharacter() no longer takes a TextRun.
To expand on the last two, there was also some awkward hoop-jumping
where we'd go through the TextRun passed by argument to find its
rendering context, which was really just |this| all along.
Reviewed by Antti Koivisto.
- 4:14 PM Changeset in webkit [157959] by
-
- 4 edits in trunk
Add texture level dependent size checks to textureImage2D calls.
https://bugs.webkit.org/show_bug.cgi?id=123290
<rdar://problem/15201382>
Reviewed by Dean Jackson.
Test covered by WebGL Conformance suite 1.0.2 test, textures/texture-size-limit.html.
There are different size limits when calling textureImage2D on different texture levels.
We should be throwing an error if our texture size exceeds these limits.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
- platform/mac/TestExpectations: Unskip now passing test texture-size-limit.html.
- 3:22 PM Changeset in webkit [157958] by
-
- 9 edits in trunk/Source/WebCore
[MediaStream API] allow a stream source to be shared
https://bugs.webkit.org/show_bug.cgi?id=121954
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-24
Reviewed by Eric Carlson.
Now, the MediaStreamSource don't know about the MediaStream that owns it,
since there can be more than one MediaStream that has it as source for some track.
MediaStreamTrack classes now have observers registered, in case there are more than
one MediaStream owning that track
No new tests, no change in functionality.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Adding the MediaStream as an observer for each track it owns.
(WebCore::MediaStream::addTrack): Now adding the MediaStream as an observer the new added track
and adding the source to the MediaStreamDescriptor.
(WebCore::MediaStream::removeTrack): Instead of removing the source right away, we first check if
there isn't any other track using that source, if not we remove the source.
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::addRemoteSource): MediaStreamSource has no information about the MediaStream
that uses it, so now we don't set the stream in the source anymore.
(WebCore::MediaStream::removeRemoteSource): There can be more than on track using the source. So we
get each track that is using the source and then remove it and fire the ended event.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::addObserver):
(WebCore::MediaStreamTrack::removeObserver):
(WebCore::MediaStreamTrack::trackDidEnd): Does not get the client from the MediaStreamDescriptor, it now
notify each of its observers that the track ended.
- Modules/mediastream/MediaStreamTrack.h: Adding Observer class.
- platform/mediastream/MediaStreamDescriptor.cpp: Destructor now does nothing. Previously it was setting
each MediaStreamSource's descriptor to null.
(WebCore::MediaStreamDescriptor::removeSource): Not setting the stream in source anymore.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
(WebCore::MediaStreamDescriptor::setEnded): Not setting the state of the source to Ended
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor):
- platform/mediastream/MediaStreamSource.cpp: Removing references to MediaStream object
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::reset):
- platform/mediastream/MediaStreamSource.h:
- 2:40 PM Changeset in webkit [157957] by
-
- 4 edits2 adds in trunk
Crash in WebCore::NavigationScheduler::startTimer()
https://bugs.webkit.org/show_bug.cgi?id=123288
<rdar://problem/14055644>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Currently NavigationScheduler::startTimer() synchronously notifies the client
before the Web Inspector of a scheduled redirect. If a client cancels this
redirect then NavigationScheduler::m_redirect will become null and we'll
subsequently crash when informing the Web Inspector of this formerly scheduled
redirect. Instead, NavigationScheduler::startTimer() should notify the Web
Inspector before it notifies the client of a scheduled redirect.
As a side benefit of this change, the Web Inspector is notified of a scheduled
redirect before being notified of it being canceled when a client chooses to cancel
a scheduled redirect.
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::startTimer):
Tools:
Add API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
- TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
- 2:31 PM Changeset in webkit [157956] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r154308. <rdar://problem/15109394>
- 2:28 PM Changeset in webkit [157955] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Merged r154303. <rdar://problem/15109405>
- 2:23 PM Changeset in webkit [157954] by
-
- 11 edits3 adds in branches/safari-537.73-branch
Merge fix for <rdar://problem/15109389>
- 1:55 PM Changeset in webkit [157953] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the Mountain Lion build.
- Shared/API/Cocoa/WKFoundation.h:
- 1:46 PM Changeset in webkit [157952] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build without CSS_SHAPES.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 1:39 PM Changeset in webkit [157951] by
-
- 8 edits in trunk/Source/WebKit2
[Cocoa] Add -[WKBrowsingContextController goToBackForwardItem:]
https://bugs.webkit.org/show_bug.cgi?id=123289
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKFoundation.h: Defined WK_API_CLASS.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared -goToBackForwardListItem:.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController goToBackForwardListItem:]): Added.
- UIProcess/Cocoa/WKBackForwardList.h: Deployed WK_API_CLASS to make the class exported.
- UIProcess/Cocoa/WKBackForwardListItem.h: Ditto.
- UIProcess/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem _item]): Added. Returns the underlying WebBackForwardListItem.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h: Declared _item.
- 1:31 PM Changeset in webkit [157950] by
-
- 15 edits5 adds in trunk/Source/WebCore
Simple line layout
https://bugs.webkit.org/show_bug.cgi?id=122458
Reviewed by Darin Adler.
Line box based inline layout is powerful but also rather slow and memory intensive. Simple line layout
is a compact alternative data structure and fast code path to cover common cases without requiring line
boxes.
This patch handles a case single left-aligned text renderer inside flow with no floats. Even this very basic
case is sufficiently common to handle up to 25% of all text lines on some popular new sites. The decision
which path to use is made per block flow (paragraph).
Simple line layout aims to produce pixel-exact rendering result when compared to the line box layout.
The goal is to handle everything that requires line level access in cases that allow use of simple lines.
This is not quite the case yet. For example selections and outline painting are not supported. In these
cases we seamlessly switch to the line boxes.
The simple line data structure currently uses 12 bytes per line. Lineboxes take ~160 bytes minimum per line.
Laying out the lines is also several times faster as is iterating over them.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::getInlineBoxAndOffset):
Creating positions within a simple line flow causes switch to line boxes.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
TextIterator traverses line boxes if available. In case simple line case we need to replicate the
same results (for compatibility but especially to avoid changing test results). This is done here
by just traversing the string without actually using the layout.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
Select the layout path to use.
(WebCore::RenderBlockFlow::deleteLines):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::firstLineBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::clearTruncation):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines):
(WebCore::RenderBlockFlow::layoutSimpleLines):
Do simple layout.
(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):
This function switches from simple lines to line boxes. The switching can be done outside normal layout.
This is used to cover some cases that are not yet supported by simple lines (like selections).
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::simpleLines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutLineBoxes):
Rename the line box layout function.
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RenderText.cpp:
(WebCore::RenderText::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::knownToHaveNoOverflowAndNoFallbackFonts):
(WebCore::RenderText::setSelectionState):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::ensureLineBoxes):
(WebCore::RenderText::simpleLines):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):
(WebCore::RenderText::selectionRectForRepaint):
(WebCore::RenderText::caretMinOffset):
(WebCore::RenderText::caretMaxOffset):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil):
(WebCore::RenderText::containsRenderedCharacterOffset):
(WebCore::RenderText::containsCaretOffset):
(WebCore::RenderText::hasRenderedText):
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeSimpleLine):
(WebCore::write):
- rendering/SimpleLineLayout.cpp: Added.
(WebCore::SimpleLineLayout::canUseFor):
This check for the cases supported by the simple line layout path.
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::createLines):
The main layout functions that breaks text to lines. It only handles the cases allowed by
SimpleLineLayout::canUseFor. What it handles it aims to break exactly as line box layout does.
- rendering/SimpleLineLayout.h: Added.
- rendering/SimpleLineLayoutFunctions.cpp: Added.
(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeTextBoundingBox):
- rendering/SimpleLineLayoutFunctions.h: Added.
(WebCore::SimpleLineLayout::computeFlowHeight):
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
(WebCore::SimpleLineLayout::lineHeightFromFlow):
Support functions called from RenderBlockFlow and RenderText. They are equivalent to
similar line box functions.
(WebCore::SimpleLineLayout::baselineFromFlow):
- rendering/SimpleLineLayoutResolver.h: Added.
(WebCore::SimpleLineLayout::Resolver::Line::Line):
(WebCore::SimpleLineLayout::Resolver::Line::rect):
(WebCore::SimpleLineLayout::Resolver::Line::baseline):
(WebCore::SimpleLineLayout::Resolver::Line::text):
(WebCore::SimpleLineLayout::Resolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator++):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator--):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator==):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator*):
Lazy iterator for deriving line metrics. This keeps the line data structure small as
we don't need to keep easily derived values around.
(WebCore::SimpleLineLayout::Resolver::Resolver):
(WebCore::SimpleLineLayout::Resolver::size):
(WebCore::SimpleLineLayout::Resolver::begin):
(WebCore::SimpleLineLayout::Resolver::end):
(WebCore::SimpleLineLayout::Resolver::last):
(WebCore::SimpleLineLayout::Resolver::operator[]):
- 12:59 PM Changeset in webkit [157949] by
-
- 7 edits in trunk/LayoutTests
dumpAsText() is unnecessarily called in spellchecking tests
https://bugs.webkit.org/show_bug.cgi?id=123266
Reviewed by Darin Adler.
dumpAsText is already called either by notifyDone (js-test-post.js) or
by finishJSTest() when asynchrononous spell checking is used.
- editing/spelling/spellcheck-async-mutation.html:
- editing/spelling/spellcheck-async.html:
- editing/spelling/spellcheck-attribute-expected.txt:
- editing/spelling/spellcheck-attribute.html:
- editing/spelling/spelling-insert-html.html:
- editing/spelling/spelling-unified-emulation.html:
- 12:53 PM Changeset in webkit [157948] by
-
- 4 edits2 adds in trunk
Gaps between underlines in adjacent underlined text runs
https://bugs.webkit.org/show_bug.cgi?id=123236
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-24
Reviewed by Simon Fraser and Darin Adler.
Source/WebCore:
There are two pieces to this change. The first piece is in
InlineTextBox::paint(). We were putting floating-point
extents into a LayoutSize, which simply uses ints (for now),
and then immediately converting this back to a FloatSize.
Instead, we should be using floats throughout all of
this code.
In addition, inside GraphicsContext::drawLineForText(), we are
rounding the underline to pixel boundaries so that it appears
very crisp on the screen. However, we should round once after
performing computations, rather than rounding twice and then
performing computations on the rounded numbers.
Test: fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Change rounding mode
to perform computations before rounding
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Don't convert to a LayoutSize
just to convert to a FloatSize
LayoutTests:
Added a test that checks that we have accurate precision in our
floating-point computations. We should perform calculations before
rounding, instead of rouding twice and performing calculations on
the rounded values.
- fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html: Added.
- platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.png: Added.
- platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.txt: Added.
- 12:39 PM Changeset in webkit [157947] by
-
- 2 edits in trunk/Source/WebInspectorUI
Adjust the precision of byte strings in Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=123281
Reviewed by Joseph Pecoraro.
- UserInterface/Utilities.js:
(Number.bytesToString): More precision for MB and less precision for 10..1023 KB.
- 12:38 PM Changeset in webkit [157946] by
-
- 2 edits in trunk/LayoutTests
Fix unnecessary alerted value leaking into another test.
Rubber-stamped by Alexey Proskuryakov.
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html:
- 12:36 PM Changeset in webkit [157945] by
-
- 10 edits in trunk/Source/WebCore
SVGRenderingContext should wrap a RenderElement.
<https://webkit.org/b/123283>
The SVG rendering context class is never used with text renderers
so we can have it wrap a RenderElement for tighter code.
Also renamed SVGRenderingContext::m_object to m_renderer.
Reviewed by Antti Koivisto.
- 12:18 PM Changeset in webkit [157944] by
-
- 3 edits2 adds in trunk
[contenteditable] Content after non-editable element disappears when merging lines using backspace
https://bugs.webkit.org/show_bug.cgi?id=122748
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
In case of paragraph merging after deletion if second paragraph
contains non-editable element, then content after the non-editable
element(including non-editable element) will be removed while the
content before the element will be merged with the first paragraph.
This happens becasue endOfParagraphToMove calculation in merging function
stop at editing boundary so endOfParagraphToMove becomes position just
before non-editable content.
With this patch now endOfParagraphToMove is calculated by skipping
over the non-editable element.
Test: editing/deleting/merge-paragraph-contatining-noneditable.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): use CanSkipOverEditingBoundary
condition while calculating endOfParagraphToMove.
LayoutTests:
Adding test to verify that on merging the paragraph containing
non-editable element does not cause loss of non-editable content after
merging.
- editing/deleting/merge-paragraph-contatining-noneditable-expected.txt: Added.
- editing/deleting/merge-paragraph-contatining-noneditable.html: Added.
- 12:12 PM Changeset in webkit [157943] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r157931.
http://trac.webkit.org/changeset/157931
https://bugs.webkit.org/show_bug.cgi?id=123284
Seems to have caused a lot of assertions on debug bots
(Requested by ap on #webkit).
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 12:10 PM Changeset in webkit [157942] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Inspector doesn't show webkitTransitionEnd events in the timeline
https://bugs.webkit.org/show_bug.cgi?id=123263
Reviewed by Timothy Hatcher.
A legacy event type is only set on an event in EventTarget::fireEventListeners(Event*)
which is called after we used to call InspectorInstrumentation::willDispatchEvent(), the method
that would ultimately yield the creation of a TimelineRecord for the event in the Web Inspector
frontend, and as a result we would try to dispatch an event with an unprefixed event type to
the frontend, which wouldn't even happen because most likely it wouldn't have listeners for this
unprefixed type.
We now move the call to InspectorInstrumentation::willDispatchEvent() in
EventTarget::fireEventListeners(Event*, EventTargetData*, EventListenerVector&) such that the
correct event type and list of listeners is used to determine what event to dispatch to the frontend.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
Remove calls to InspectorInstrumentation::willDispatchEvent() and InspectorInstrumentation::didDispatchEvent().
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
Add call to InspectorInstrumentation::willDispatchEvent() before we go through each listener and
call InspectorInstrumentation::willHandleEvent(). Additionally, we refactor some code since we're
getting references to the ScriptExecutionContext and Document upfront now.
- 11:58 AM Changeset in webkit [157941] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/regions/propagate-region-box-shadow-border-padding-for-video.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123282
- platform/mac/TestExpectations: Marking as such.
- 11:41 AM Changeset in webkit [157940] by
-
- 20 edits in trunk/Source/WebCore
SVG: RenderElement-ize intersectRepaintRectWithResources().
<https://webkit.org/b/123278>
SVGRenderSupport::intersectRepaintRectWithResources() is only ever
called with non-text renderers so make it take RenderElement&.
Had to tweak RenderSVGResource::resourceBoundingBox() to take the
renderer by reference.
Reviewed by Antti Koivisto.
- 11:22 AM Changeset in webkit [157939] by
-
- 5 edits2 adds in trunk
Web Inspector: Breakpoints in sourceURL named scripts do not work
https://bugs.webkit.org/show_bug.cgi?id=123231
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-24
Reviewed by Timothy Hatcher.
Source/WebCore:
Remember a Script's sourceURL and sourceMappingURL. When setting a
breakpoint by URL, check it against the sourceURL or original URL.
If a script had a sourceURL that would have been the only URL sent
to the frontend, so that receives priority.
Test: inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
LayoutTests:
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL-expected.txt: Added.
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html: Added.
- 10:08 AM Changeset in webkit [157938] by
-
- 6 edits5 adds in trunk
Web Inspector: Add a way to test the Manager and model classes
https://bugs.webkit.org/show_bug.cgi?id=123223
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Moved some global functions out of Main.js, so that they can be used in the
layout tests without including Main.js.
- UserInterface/Main.html: Referenced the new JS files.
- UserInterface/Main.js:
- UserInterface/MessageDispatcher.js: Added.
(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend):
- UserInterface/URLUtilities.js: Added.
(removeURLFragment):
(relativePath):
(parseURL):
(absoluteURL):
(parseLocationQueryParameters):
(parseQueryString):
(WebInspector.displayNameForURL):
(WebInspector.displayNameForHost):
- UserInterface/Utilities.js:
LayoutTests:
Added the first new WebInspector layout test file. The test is using InspectorTest.importInspectorScripts
to bootstrap some of the managers/observers/models from the new WebInspector.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.importScript):
(InspectorTest.importInspectorScripts):
- inspector-protocol/model/main-frame-resource-expected.txt: Added.
- inspector-protocol/model/main-frame-resource.html: Added.
- 10:05 AM Changeset in webkit [157937] by
-
- 6 edits in trunk/Source/JavaScriptCore
Better way to fix part of broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.
Reviewed by Geoffrey Garen.
Undoing offline asm hackery.
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- offlineasm/instructions.rb:
- 10:05 AM Changeset in webkit [157936] by
-
- 5 edits8 adds in trunk/Source/WebCore
Add CryptoKey base class and bindings
https://bugs.webkit.org/show_bug.cgi?id=123216
Reviewed by Sam Weinig.
- crypto/CryptoKey.idl: Added.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
Process the IDL.
- WebCore.xcodeproj/project.pbxproj: Added files.
- bindings/js/JSCryptoKeyCustom.cpp: Added.
(WebCore::JSCryptoKey::algorithm): Use a visitor to build algorithm dictionary
for the key.
- crypto/CryptoAlgorithmDescriptionBuilder.cpp: Added.
- crypto/CryptoAlgorithmDescriptionBuilder.h: Added.
An interface for a visitor we'll use to expose CrytoKey.algorithm in bindings,
and possibly also for storage serialization. Not complete yet, we'll need support
for a few more simple types, and less trivially, for nested algorithms.
- bindings/js/JSCryptoAlgorithmBuilder.cpp: Added.
- bindings/js/JSCryptoAlgorithmBuilder.h: Added.
An implementation that builds an algorithm description dictionary for JS bindings.
- crypto/CryptoKey.cpp: Added.
(WebCore::CryptoKey::~CryptoKey):
(WebCore::CryptoKey::buildAlgorithmDescription):
- crypto/CryptoKey.h: Added.
Added an almost empty implementation. Some of the functions that are currently
marked as pure virtual will likely be implemented in this base class.
- 9:38 AM Changeset in webkit [157935] by
-
- 2 edits in trunk/LayoutTests
Freshly landed webgl-1.0.1 tests are failing.
- platform/mac/TestExpectations: Correcting a late-night typo in TetExpectations.
It's [Failure], not [Fail].
- 9:35 AM Changeset in webkit [157934] by
-
- 4 edits1 delete in trunk
Unreviewed, rolling out r157916.
http://trac.webkit.org/changeset/157916
https://bugs.webkit.org/show_bug.cgi?id=123274
Broke Layout/flexbox-lots-of-data.html on perfbot (Requested
by ap on #webkit).
PerformanceTests:
- Layout/flexbox-lots-of-data.html: Removed.
Source/WebCore:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
- 9:22 AM Changeset in webkit [157933] by
-
- 2 edits in trunk/Source/WebCore
Comment in ScopedEventQueue::dispatchEvent is unnecessarily verbose
https://bugs.webkit.org/show_bug.cgi?id=123252
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-24
Reviewed by Darin Adler.
Shorten the comment about the crash avoidance in ScopedEventQueue::dispatchEvent due to
the calling convention in C++ is left unspecified. The problem was already fixed in r157219
and later adjusted in r157401, but the comment could have been shorter and simpler in both cases.
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::dispatchEvent):
- 9:10 AM Changeset in webkit [157932] by
-
- 11 edits in trunk/Source/JavaScriptCore
Fix broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.
Reviewed by Michael Saboff.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus): Added an UNUSED_PARAM().
(JSC::CodeBlock::dumpBytecode): Added #if ENABLE(JIT) to JIT only code.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Added an UNUSED_PARAM().
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor): Added an UNUSED_PARAM().
- bytecode/StructureStubInfo.h:
- Added a stub StubInfoMap for non-JIT builds. StubInfoMap is still used in function prototypes even when !ENABLE(JIT). Rather that adding #if's in many places, we just provide a stub/placeholder implementation that is unused but keeps the compiler happy.
- jit/JITOperations.h: Added #if ENABLE(JIT).
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- The putByVal() macro reifies a slow path which is never taken in one case. This translates into a label that is never used in the C Loop LLINT. The C++ compiler doesn't like unused labels. So, we fix this by adding a cloopUnusedLabel offline asm instruction that synthesizes the following:
if (false) goto unusedLabel;
This keeps the C++ compiler happy without changing code behavior.
- offlineasm/cloop.rb: Implementing cloopUnusedLabel.
- offlineasm/instructions.rb: Declaring cloopUnusedLabel.
- runtime/Executable.cpp:
(JSC::setupJIT): Added UNUSED_PARAM()s.
(JSC::ScriptExecutable::prepareForExecutionImpl):
- run-javascriptcore-tests have phases that forces the LLINT to be off which in turn asserts that the JIT is enabled. With the C Loop LLINT, this combination is illegal. So, we override the setup code here to always use the LLINT if !ENABLE(JIT) regardless of what options are passed in.
- 9:09 AM Changeset in webkit [157931] by
-
- 2 edits in trunk/Source/WTF
Remove PCRE workaround.
https://bugs.webkit.org/show_bug.cgi?id=123265
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Darin Adler.
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 9:06 AM Changeset in webkit [157930] by
-
- 2 edits in trunk/Source/JavaScriptCore
Uninitialized member causes crash when DFG JIT is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=123270
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-24
Reviewed by Brent Fulgham.
The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
This causes an early crash on Windows, which doesn't have DFG JIT enabled.
- runtime/VM.cpp:
(JSC::VM::VM): Initialize sizeOfLastScratchBuffer member regardless of whether DFG JIT is enabled.
- 9:00 AM Changeset in webkit [157929] by
-
- 2 edits in trunk/Tools
[GTK] Disable css-image-orientation
https://bugs.webkit.org/show_bug.cgi?id=123257
Reviewed by Martin Robinson.
CSS image orientation isn't stable yet. So, test regression happen since r157909.
This feature should be enabled again after it is stable.
- Scripts/webkitperl/FeatureList.pm:
- 7:32 AM Changeset in webkit [157928] by
-
- 3 edits3 deletes in trunk/Source/WebCore
Removed unused ThreadSafeCoordinatedSurface and CertificateInfoCurl files.
https://bugs.webkit.org/show_bug.cgi?id=123246
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-24
Reviewed by Noam Rosenthal.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Removed references to ThreadSafeCoordinatedSurface and CertificateInfoCurl.
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Removed.
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Removed.
- platform/network/curl/CertificateInfoCurl.cpp: Removed.
- 7:27 AM Changeset in webkit [157927] by
-
- 2 edits in trunk/Source/WTF
Remove Clang workaround.
https://bugs.webkit.org/show_bug.cgi?id=123262
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Anders Carlsson.
- wtf/CheckedArithmetic.h:
(WTF::Checked::Checked):
- 6:30 AM Changeset in webkit [157926] by
-
- 2 edits in trunk/Source/WebCore
Removed Qt workaround.
https://bugs.webkit.org/show_bug.cgi?id=123258
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.
No change of functionality, no new tests needed.
!$defines case can be removed, because Qt and Android aren't in WebKit trunk,
all ports (Mac,EFL,GTK,Windows) call this script with --defines option now
- css/make-css-file-arrays.pl:
- 6:28 AM Changeset in webkit [157925] by
-
- 2 edits in trunk/Source/WebCore
Remove a stray space.
Not reviewed.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addImageMapChildren):
- 6:26 AM Changeset in webkit [157924] by
-
- 49 edits in trunk/Source/WebCore
Element iterator functions should take reference
https://bugs.webkit.org/show_bug.cgi?id=123267
Reviewed by Andreas Kling.
The argument has to be non-null.
- 5:26 AM Changeset in webkit [157923] by
-
- 3 edits in trunk/Tools
Fix argument passing for jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=123253
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Gustavo Noronha Silva.
The update-webkit-libs-jhbuild previously didn't allowed
extra arguments to be passed to jhbuild.
- Scripts/update-webkit-libs-jhbuild:
(runJhbuild):
- Scripts/update-webkitefl-libs:
- 4:41 AM Changeset in webkit [157922] by
-
- 2 edits in trunk/Tools
[EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
https://bugs.webkit.org/show_bug.cgi?id=123251
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.
Replace %llu by PRIu64 macro to print an uint64_t value and silent a
compilation warning on 64-Bit.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
- 3:26 AM Changeset in webkit [157921] by
-
- 2 edits3 adds in trunk/LayoutTests
[GTK] Removing flags for tests fixed in bug 121828
https://bugs.webkit.org/show_bug.cgi?id=122967
Unreviewed GTK gardening. Rebaselining after r156767.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-24
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- 3:01 AM Changeset in webkit [157920] by
-
- 21 edits in trunk
[EFL] Build break with latest EFL 1.8 libraries.
https://bugs.webkit.org/show_bug.cgi?id=123245
Reviewed by Gyuyoung Kim.
After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
Eo typedef and splitted header files which contain version macro.
.:
- Source/cmake/EFLHelpers.cmake: Checked whether include path exist.
- Source/cmake/FindEcore.cmake: Added 1.8 Header which have version macro.
- Source/cmake/FindEdje.cmake: Ditto.
- Source/cmake/FindEina.cmake: Ditto.
- Source/cmake/FindEo.cmake: Ditto.
- Source/cmake/FindEvas.cmake: Ditto.
Source/JavaScriptCore:
- PlatformEfl.cmake: Added EO path to include directories.
- heap/HeapTimer.h: Changed Ecore_Timer typedef when EO exist.
Source/WebCore:
- platform/Widget.h: Changed Eo typedef.
- platform/efl/EflScreenUtilities.h: Ditto.
- platform/graphics/Image.h: Ditto.
Source/WTF:
- wtf/OwnPtrCommon.h: Changed Eo typedef.
- wtf/efl/RefPtrEfl.h: Ditto.
Tools:
- TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
- WebKitTestRunner/PlatformWebView.h: Ditto.
- 2:59 AM Changeset in webkit [157919] by
-
- 6 edits in trunk/Source/WebCore
RenderSVGResource: Pass RenderElement to fill/strokePaintingResource.
<https://webkit.org/b/123242>
We never pass text renderers to these functions, so make them take
RenderElement instead.
Reviewed by Anders Carlsson.
- 2:08 AM Changeset in webkit [157918] by
-
- 14 edits in trunk
[GObject bindings] Make EventTarget interface introspectable
https://bugs.webkit.org/show_bug.cgi?id=77835
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to be
used by GObject instrospection bindings. Instead of receving a
GCallback, which makes the function not introspectable, they
receive a GClosure.
- bindings/gobject/GObjectEventListener.cpp:
(WebCore::GObjectEventListener::GObjectEventListener):
(WebCore::GObjectEventListener::~GObjectEventListener):
(WebCore::GObjectEventListener::gobjectDestroyed):
(WebCore::GObjectEventListener::handleEvent):
(WebCore::GObjectEventListener::operator==):
- bindings/gobject/GObjectEventListener.h:
(WebCore::GObjectEventListener::addEventListener):
(WebCore::GObjectEventListener::removeEventListener):
- bindings/gobject/WebKitDOMEventTarget.cpp:
(webkit_dom_event_target_dispatch_event):
(webkit_dom_event_target_add_event_listener):
(webkit_dom_event_target_remove_event_listener):
(webkit_dom_event_target_add_event_listener_with_closure):
(webkit_dom_event_target_remove_event_listener_with_closure):
- bindings/gobject/WebKitDOMEventTarget.h:
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateEventTargetIface):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
(webkit_dom_test_event_target_add_event_listener):
(webkit_dom_test_event_target_remove_event_listener):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(webkit_dom_test_node_dispatch_event):
(webkit_dom_test_node_add_event_listener):
(webkit_dom_test_node_remove_event_listener):
Source/WTF:
Add support for use GRefPtr with GClosure.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
- wtf/gobject/GTypedefs.h:
Tools:
- Scripts/webkitpy/style/checker.py: Add exceptions for custom
GObject DOM bindings headers.
- 12:10 AM Changeset in webkit [157917] by
-
- 357 edits25 deletes in trunk/LayoutTests
Revert <http://trac.webkit.org/changeset/157893>
(Mavericks test results mega-patch).
It didn't fix Mavericks, which still has dozens of failures, and it broke Mountain
Lion bots, which need to remain green for tools like EWS to work.
At a glance, there are multiple systemic issues with this change:
- some results went to broken locations like platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png;
- WK2 expectations also went to platform/mac/platform/mac-wk2/TestExpectations.
- some tests like js/dom/global-constructors-attributes.html used to match cross-platform
baseline, but copying Mavericks results over to platform/mac made it so that those results
are now ignored on Mountain Lion.
I think that starting over will be easier that fixing these issues incrementally.
