Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Dec 3, 2013:

11:56 PM Changeset in webkit [160073] by zoltan@webkit.org

• 4 edits in trunk/Source/WebCore

Remove BreakingContext's friendship from RenderBlockFlow
<​https://webkit.org/b/124958>

Reviewed by David Hyatt.

BreakingContext uses only 2 functions from RenderBlockFlow: insertFloatingObject/positionNewFloatOnLine. I added helper
functions to LineBreaker, what is already a friend of RenderBlockFlow, so BreakingContext doesn't need to be anymore.

No new tests, no behavior change.

• rendering/RenderBlockFlow.h:
• rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleFloat):

• rendering/line/LineBreaker.h:

(WebCore::LineBreaker::insertFloatingObject):
(WebCore::LineBreaker::positionNewFloatOnLine):

11:44 PM Changeset in webkit [160072] by rniwa@webkit.org

• 5 edits in trunk/Source/WebCore

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
​https://bugs.webkit.org/show_bug.cgi?id=125208

Reviewed by Antti Koivisto.

Merge ​https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf

These member functions of HTMLBodyElement were only used by corresponding functions in HTMLDocument
since they had the Reflect option specified in HTMLBodyElement.idl.

Removed the functions and directly called getAttribute and setAttribute in relevant functions in
HTMLDocument. The optimization to avoid assignment is no longer needed here since we've added that
optimization to setAttributeInternal a while ago.

• html/HTMLBodyElement.cpp:
• html/HTMLBodyElement.h:
• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):

• html/HTMLDocument.h:

10:50 PM Changeset in webkit [160071] by mitz@apple.com

• 2 edits in trunk/Tools

Fixed a test timing out after r160040.

• TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

(-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
Updated for the delegate method rename.

9:33 PM Changeset in webkit [160070] by akling@apple.com

• 4 edits in trunk/Source/WebCore

Add a CSSProperty::isDirectionAwareProperty() helper.
<​https://webkit.org/b/125202>

Move the block of case labels for checking whether a CSS property ID
is a directional property into a separate function. Also removed an
outdated comment about CSS variables.

Reviewed by Antti Koivisto.

9:25 PM Changeset in webkit [160069] by Simon Fraser

• 3 edits in trunk/Source/WebKit2

WKContentView should just use InitializeWebKit2()
​https://bugs.webkit.org/show_bug.cgi?id=125209

Reviewed by Benjamin Poulain.

Rather than calling an motley selection of init fuctions,
WKContentView should use the one true init function, InitializeWebKit2().

• Shared/WebKit2Initialize.cpp: On iOS, we need to call InitWebCoreThreadSystemInterface().

(WebKit::InitializeWebKit2):

• UIProcess/API/ios/WKContentView.mm: Remove various unused #imports.

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

9:24 PM Changeset in webkit [160068] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Revert the inadvertently committed change.

• html/HTMLElement.idl:

9:20 PM Changeset in webkit [160067] by rniwa@webkit.org

• 5 edits in trunk/Source/WebCore

Remove nodeIsDetachedFromDocument and visualWordMovementEnabled in FrameSelection
​https://bugs.webkit.org/show_bug.cgi?id=125210

Reviewed by Antti Koivisto.

Inspired by ​https://chromium.googlesource.com/chromium/blink/+/92409870f0ff8fafe31217830db0838a9e1ffb98

Removed some unused code.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::textWasReplaced):

• editing/FrameSelection.h:
• page/Settings.in:

9:05 PM Changeset in webkit [160066] by Seokju Kwon

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove '_attachedWindowHeight' property in InspectorFrontendHostStub.js
​https://bugs.webkit.org/show_bug.cgi?id=125204

Reviewed by Timothy Hatcher.

'_attachedWindowHeight' property is not used anywhere, so remove it.

• UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):

8:21 PM Changeset in webkit [160065] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Potential crash in RenderView::selectionBounds and RenderView::repaintSelection
​https://bugs.webkit.org/show_bug.cgi?id=125207

Reviewed by Simon Fraser.

Merge ​https://chromium.googlesource.com/chromium/blink/+/f9e6e288a5aa959f05c374806121aaf0fc52d440

Update style in FrameSelection instead of RenderView's member functions. These are the last two
member functions of RenderView that updates the style.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::bounds):

• rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::repaintSelection):

7:23 PM Changeset in webkit [160064] by mrowe@apple.com

• 11 edits in trunk/Source/WebCore

<​https://webkit.org/b/125143> Improve the formatting in the generated Objective-C headers.

Add a space between @property and any parenthesized attributes.
Prefer strong over retain when specifying memory management semantics.

Reviewed by Darin Adler.

• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:

(GetPropertyAttributes): Generate strong instead of retain. Include a
space before the parenthesis.

• bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
• bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
• bindings/scripts/test/ObjC/DOMTestException.h:
• bindings/scripts/test/ObjC/DOMTestInterface.h:
• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMattribute.h:

6:19 PM Changeset in webkit [160063] by mark.lam@apple.com

• 4 edits in trunk/Source

testapi test crashes on Windows in WTF::Vector<wchar_t,64,WTF::UnsafeVectorOverflow>::size().
​https://bugs.webkit.org/show_bug.cgi?id=121972.

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• interpreter/JSStack.cpp:

(JSC::JSStack::~JSStack):

• Reverting the change from r160004 since it's better to fix OSAllocatorWin to be consistent with OSAllocatorPosix.

Source/WTF:

• wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::decommit):
(WTF::OSAllocator::releaseDecommitted):

• Added a check to ensure that the bytes to decommit / release is not 0. On Windows, a 0 length passed to VirtualFree() has a special meaning, and it's not "decommit / release nothing" as one would expect. Adding this check makes OSAllocatorWin consistent with OSAllocatorPosix for these 2 functions.

5:18 PM Changeset in webkit [160062] by mark.lam@apple.com

• 5 edits
  1 add in trunk/Source/JavaScriptCore

Fix LLINT_C_LOOP build for Win64.
​https://bugs.webkit.org/show_bug.cgi?id=125186.

Reviewed by Michael Saboff.

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• jit/JITOperationsMSVC64.cpp: Added.

(JSC::getHostCallReturnValueWithExecState):

• Win64 will build JITStubMSVC64.asm even when !ENABLE(JIT). This results in a linkage error due to a missing getHostCallReturnValueWithExecState(). So, we add a stub getHostCallReturnValueWithExecState() here to satisfy that linkage. This function will never be called. The alternative to providing such a stub is to make the MSVC project recognize if the JIT is enabled or not, and exclude JITStubMSVC64.asm if it's not enabled. We don't currently set ENABLE(JIT) via the MSVC project and the work to do that is too much trouble for what we're trying to achieve here. So, we're opting for this simpler workaround instead.

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

• Don't build callToJavaScript if we're building the C loop. Otherwise, the C loop won't build if !ENABLE(COMPUTE_GOTO_OPCODES).

4:51 PM Changeset in webkit [160061] by ap@apple.com

• 20 edits
  4 adds in trunk

Update WebCrypto JWK mapping to newer proposal
​https://bugs.webkit.org/show_bug.cgi?id=124218

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/jwk-export-use-values.html

crypto/subtle/jwk-import-use-values.html

1. "extractable" renamed to "ext" in JWK.
2. New values for "use" mapping, which can now be combined into comma separated lists,

and cover all possible WebCrypto usages.

• bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileUsages):
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
(WebCore::processUseValue):
(WebCore::JSCryptoKeySerializationJWK::addJWKUseToJSON):
(WebCore::JSCryptoKeySerializationJWK::serialize):

LayoutTests:

• crypto/subtle/jwk-export-use-values-expected.txt: Added.
• crypto/subtle/jwk-export-use-values.html: Added.
• crypto/subtle/jwk-import-use-values-expected.txt: Added.
• crypto/subtle/jwk-import-use-values.html: Added.

New tests for "use" mapping.

• crypto/subtle/aes-cbc-import-jwk.html:
• crypto/subtle/aes-cbc-unwrap-rsa.html:
• crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html:
• crypto/subtle/aes-cbc-wrap-rsa.html:
• crypto/subtle/aes-export-key-expected.txt:
• crypto/subtle/aes-export-key.html:
• crypto/subtle/hmac-export-key-expected.txt:
• crypto/subtle/hmac-export-key.html:
• crypto/subtle/hmac-import-jwk.html:
• crypto/subtle/import-jwk-expected.txt:
• crypto/subtle/import-jwk.html:
• crypto/subtle/rsa-export-key-expected.txt:
• crypto/subtle/rsa-export-key.html:
• crypto/subtle/rsa-export-private-key-expected.txt:
• crypto/subtle/rsa-export-private-key.html:
• crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
• crypto/subtle/rsa-oaep-key-manipulation.html:

4:51 PM Changeset in webkit [160060] by matthew_hanson@apple.com

• 3 edits in tags/Safari-538.7.1/Source/JavaScriptCore

Merge of 159593.

4:36 PM Changeset in webkit [160059] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

PageOverlayClientImpl should be a proper API::Client
​https://bugs.webkit.org/show_bug.cgi?id=125199

Reviewed by Tim Horton.

• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::PageOverlayClientImpl):
(PageOverlayClientImpl::setAccessibilityClient):
(PageOverlayClientImpl::willMoveToWebPage):
(PageOverlayClientImpl::didMoveToWebPage):
(PageOverlayClientImpl::drawRect):
(PageOverlayClientImpl::mouseEvent):
(PageOverlayClientImpl::copyAccessibilityAttributeValue):
(PageOverlayClientImpl::copyAccessibilityAttributeNames):
(WKBundlePageOverlayCreate):
(WKBundlePageOverlaySetAccessibilityClient):

4:19 PM Changeset in webkit [160058] by matthew_hanson@apple.com

• 5 edits in tags/Safari-538.7.1/Source

Versioning.

4:13 PM Changeset in webkit [160057] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Initialize the PageBannerClientImpl API::Client
​https://bugs.webkit.org/show_bug.cgi?id=125198

Reviewed by Tim Horton.

• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(PageBannerClientImpl::PageBannerClientImpl):

3:56 PM Changeset in webkit [160056] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

ARM64: Crash in JIT code due to improper reuse of cached memory temp register
​https://bugs.webkit.org/show_bug.cgi?id=125181

Reviewed by Geoffrey Garen.

Changed load8() and load() to invalidate the memory temp CachedTempRegister when the
destination of an absolute load is the memory temp register since the source address
is also the memory temp register. Change branch{8,32,64} of an AbsoluteAddress with
a register to use the dataTempRegister as the destinate of the absolute load to
reduce the chance that we need to invalidate the memory temp register cache.
In the process, found and fixed an outright bug in branch8() where we'd load into
the data temp register and then compare and branch on the memory temp register.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load8):
(JSC::MacroAssemblerARM64::branch32):
(JSC::MacroAssemblerARM64::branch64):
(JSC::MacroAssemblerARM64::branch8):
(JSC::MacroAssemblerARM64::load):

3:54 PM Changeset in webkit [160055] by matthew_hanson@apple.com

• 1 copy in tags/Safari-538.7.1

New tag.

3:44 PM Changeset in webkit [160054] by bshafiei@apple.com

• 5 edits in branches/safari-537.60-branch/Source

Versioning.

3:41 PM Changeset in webkit [160053] by ryuan.choi@samsung.com

• 2 edits in trunk

[EFL] Disable RTTI for release build
​https://bugs.webkit.org/show_bug.cgi?id=125138

Reviewed by Gyuyoung Kim.

Binary size will be reduced about 1M bytes without RTTI.
ewebkit.so : 43,449,275 -> 42,510,224
ewebkit2.so: 46,715,870 -> 45,653,989

• Source/cmake/OptionsEfl.cmake: Added -fno-rtti option to CMAKE_CXX_FLAGS_RELEASE.

3:28 PM Changeset in webkit [160052] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit2

Remote Layer Tree: Force repaint
​https://bugs.webkit.org/show_bug.cgi?id=125189
<rdar://problem/15541789>

Reviewed by Anders Carlsson.

• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::forceRepaint):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):
Implement WebProcess-synchronous force repaint.
We don't need the async variant because it is only needed
to synchronize with the WebProcess-side threaded scrolling
tree, which is not a component of the remote layer tree model.
The UI process will not handle the callback until after
RemoteLayerTreeHost::commit is complete, ensuring that the commit
is actually done.

3:26 PM Changeset in webkit [160051] by fpizlo@apple.com

• 2 edits in trunk/Tools

REGRESSION: repro scripts disappear when you rerun tests
​https://bugs.webkit.org/show_bug.cgi?id=125184

Reviewed by Mark Hahnenberg.

This bug made it difficult to quickly see if a test that recently failed is still
failing while also running a new batch of tests.

Repro scripts are supposed to stay around until you delete them explicitly. This
patch accomplishes that.

• Scripts/run-jsc-stress-tests:

3:25 PM Changeset in webkit [160050] by Simon Fraser

• 7 edits in trunk/Source

Remove some iOS-related documentScale code
​https://bugs.webkit.org/show_bug.cgi?id=125194

Source/WebCore:

Reviewed by Enrica Casucci.

Remove exports of nonexistent documentScale-related functions on Frame.

• WebCore.exp.in:

Source/WebKit2:

Reviewed by Enrica Casucci.

Upstream bits of removal of Frame::documentScale on iOS.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Whitespace.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didFinishZooming): Don't call setDocumentScale().

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Remove minimumDocumentScale().
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm: Ditto.

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea): We delegate page scaling on iOS.
(WebKit::RemoteLayerTreeDrawingArea::setDeviceScaleFactor):

3:21 PM Changeset in webkit [160049] by ap@apple.com

• 2 edits in trunk/LayoutTests

Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=125195

• platform/mac/TestExpectations: Marking as such.

3:20 PM Changeset in webkit [160048] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
​https://bugs.webkit.org/show_bug.cgi?id=125111

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-12-03
Reviewed by Filip Pizlo.

Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.

• Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
• Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.

3:19 PM Changeset in webkit [160047] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

PageBannerClientImpl should be an API::Client
​https://bugs.webkit.org/show_bug.cgi?id=125190

Reviewed by Tim Horton.

• WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(PageBannerClientImpl::PageBannerClientImpl):
(PageBannerClientImpl::~PageBannerClientImpl):
(WKBundlePageBannerCreateBannerWithCALayer):

3:03 PM Changeset in webkit [160046] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

Fix regression caused by r158599
​https://bugs.webkit.org/show_bug.cgi?id=125188

Reviewed by Jer Noble.

• html/HTMLMediaElement.cpp:

(HTMLMediaElement::clearMediaPlayer): Do not clear m_player when PLUGIN_PROXY_FOR_VIDEO

is enabled.

2:50 PM Changeset in webkit [160045] by commit-queue@webkit.org

• 15 edits in trunk/Source/WebCore

Nix Upstream: Updating WebCore files
​https://bugs.webkit.org/show_bug.cgi?id=124981

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-12-03
Reviewed by Benjamin Poulain.

Just to sync our github repo files and the trunk, as part of the upstream process

No new tests needed.

• PlatformNix.cmake:
• css/mediaControlsNix.css:

(audio):
(video::-webkit-media-controls):
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media):
(audio:-webkit-full-page-media, video:-webkit-full-page-media):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-media-slider-container > div):
(input[type="range"]::-webkit-media-slider-thumb):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-controls-fullscreen-volume-slider):
(audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media-controls-fullscreen-volume-min-button):
(audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media-controls-fullscreen-volume-max-button):
(video::-webkit-media-text-track-container):
(video::cue):
(video::-webkit-media-text-track-region):
(video::-webkit-media-text-track-region-container):
(video::-webkit-media-text-track-region-container.scrolling):
(video::-webkit-media-text-track-display):
(video::cue(:future)):
(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):

• editing/Editor.cpp:

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyImage):

• editing/Editor.h:
• html/HTMLCanvasElement.h:
• platform/Cursor.h:
• platform/audio/FFTFrame.h:
• platform/audio/nix/AudioBusNix.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/graphics/GLContext.h:
• platform/nix/CursorNix.cpp:

(WebCore::Cursor::ensurePlatformCursor):

• platform/nix/GamepadsNix.cpp:

(WebCore::sampleGamepads):

• platform/nix/RenderThemeNix.cpp:

(WebCore::toIntSize):
(WebCore::toNixRect):
(WebCore::RenderThemeNix::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeNix::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeNix::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeNix::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeNix::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeNix::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeNix::platformInactiveTextSearchHighlightColor):
(WebCore::RenderThemeNix::platformFocusRingColor):
(WebCore::RenderThemeNix::platformTapHighlightColor):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::setCheckboxSize):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::setRadioSize):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintSliderTrack):
(WebCore::RenderThemeNix::paintSliderThumb):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):
(WebCore::RenderThemeNix::extraMediaControlsStyleSheet):
(WebCore::RenderThemeNix::paintMediaPlayButton):
(WebCore::RenderThemeNix::paintMediaMuteButton):
(WebCore::RenderThemeNix::paintMediaSeekBackButton):
(WebCore::RenderThemeNix::paintMediaSeekForwardButton):
(WebCore::RenderThemeNix::paintMediaSliderTrack):
(WebCore::RenderThemeNix::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeNix::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeNix::paintMediaRewindButton):

• platform/nix/RenderThemeNix.h:
• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

2:43 PM Changeset in webkit [160044] by commit-queue@webkit.org

• 6 edits in trunk/Source

Typo: FixedPositionConstaint -> FixedPositionConstraint
​https://bugs.webkit.org/show_bug.cgi?id=125171

Patch by Ralph Thomas <​ralpht@gmail.com> on 2013-12-03
Reviewed by Simon Fraser.

Source/WebCore:

No new tests, no change in behavior.

• page/scrolling/ScrollingConstraints.h:
• page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

Source/WebKit/ios:

• WebCoreSupport/WebFixedPositionContent.mm:

(-[WebFixedPositionContent scrollOrZoomChanged:]):

2:38 PM Changeset in webkit [160043] by rniwa@webkit.org

• 2 edits in trunk/Tools

Add a script to automatically configure a git clone
​https://bugs.webkit.org/show_bug.cgi?id=110073

Revert the change to use https for now since git.webkit.org is setup with http.

• Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):

2:38 PM Changeset in webkit [160042] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

jit/JITArithmetic.cpp doesn't build for non-X86 ports
​https://bugs.webkit.org/show_bug.cgi?id=125185

Rubber stamped by Mark Hahnenberg.

Removed unused declarations and related UNUSED_PARAM().

• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_mod):

2:35 PM Changeset in webkit [160041] by Manuel Rego Casasnovas

• 2 edits in trunk/PerformanceTests

[CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
​https://bugs.webkit.org/show_bug.cgi?id=124963

Reviewed by Ryosuke Niwa.

Layout/RegionsSelection.html introduced in r159488 was not working in
Mac platform because of it was trying to use mouse events out of the
window dimensions. Use collapse() and extend() methods from Selection
object to solve the issue.

• Layout/resources/regions.js: Use collapse() and extend() instead of

mouse events.

2:32 PM Changeset in webkit [160040] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Give two load delegate methods more conventional names
​https://bugs.webkit.org/show_bug.cgi?id=125183

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame): Updated for rename.
(didFailLoadWithErrorForFrame): Ditto.

• UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Renamed

-browsingContextControllerDidFailProvisionalLoad:withError: to
-browsingContextController:didFailProvisionalLoadWithError: and
-browsingContextControllerDidFailLoad:withError: to
-browsingContextController:didFailLoadWithError:.

2:29 PM Changeset in webkit [160039] by rniwa@webkit.org

• 2 edits
  1 add in trunk/Tools

Add a script to automatically configure a git clone
​https://bugs.webkit.org/show_bug.cgi?id=110073

Reviewed by Benjamin Poulain.

Added "webkit-patch setup-git-clone" to setup a brand new Git clone.

This command runs various commands listed on ​http://trac.webkit.org/wiki/UsingGitWithWebKit

• Scripts/webkitpy/tool/commands/init.py:
• Scripts/webkitpy/tool/commands/setupgitclone.py: Added.

(SetupGitClone):
(SetupGitClone.execute):

2:24 PM Changeset in webkit [160038] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

ObjectAllocationProfile is racy and the DFG should be cool with that
​https://bugs.webkit.org/show_bug.cgi?id=125172
<rdar://problem/15233487>

Reviewed by Mark Hahnenberg.

We would previously sometimes get a null Structure because checking if the profile is non-null and loading
the structure from it were two separate operations.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setFuturePossibleStructure):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• runtime/JSFunction.h:

(JSC::JSFunction::allocationProfile):
(JSC::JSFunction::allocationStructure):

2:19 PM Changeset in webkit [160037] by rniwa@webkit.org

• 3 edits
  8 adds in trunk/LayoutTests/imported/w3c

Import the XHTML parsing and serialization tests for template elements
​https://bugs.webkit.org/show_bug.cgi?id=125131

Reviewed by Antti Koivisto.

Import the tests for parsing XHTML documents and fragments at f744661dbd0c29bb6a54c1530f9843838eec1300
after self-closing link elements in template-child-nodes-div.xhtml and template-child-nodes-nested.xhtml
as these two files would encounter parser errors otherwise (I'll be merging these changes back into
the web-platform-tests repository later).

This completes the importation of W3C tests for the HTML template element.

• html-templates/additions-to-parsing-xhtml-documents: Added.
• html-templates/additions-to-parsing-xhtml-documents/node-document-expected.txt: Added.
• html-templates/additions-to-parsing-xhtml-documents/node-document.html: Added.
• html-templates/additions-to-parsing-xhtml-documents/template-child-nodes-expected.txt: Added.
• html-templates/additions-to-parsing-xhtml-documents/template-child-nodes.html: Added.
• html-templates/additions-to-serializing-xhtml-documents: Added.
• html-templates/additions-to-serializing-xhtml-documents/outerhtml-expected.txt: Added.
• html-templates/additions-to-serializing-xhtml-documents/outerhtml.html: Added.
• html-templates/resources/template-child-nodes-div.xhtml:
• html-templates/resources/template-child-nodes-nested.xhtml:

1:53 PM Changeset in webkit [160036] by andersca@apple.com

• 9 edits in trunk

Deprecate WKNotificationProvider
​https://bugs.webkit.org/show_bug.cgi?id=125178

Reviewed by Sam Weinig.

Source/WebKit2:

• Shared/API/c/WKDeclarationSpecifiers.h:

Add WK_DEPRECATED and WK_ENUM_DEPRECATED macros so we can things as deprecated.

• UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerSetProvider):

• UIProcess/API/C/WKNotificationManager.h:

WKNotificationManagerSetProvider now takes a WKNotificationProviderBase.

• UIProcess/API/C/WKNotificationProvider.h:

Deprecate WKNotificationProvider and kWKNotificationProviderCurrentVersion.

Tools:

Update for WebKit2 changes.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

• WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::provider):

• WebKitTestRunner/WebNotificationProvider.h:

1:50 PM Changeset in webkit [160035] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Support 64-bit Application Support Libraries Location
​https://bugs.webkit.org/show_bug.cgi?id=125179

Reviewed by Tim Horton.

Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
on Windows until an official distribution is available that properly creates registry settings
to specify these locations.

• Scripts/webkitdirs.pm:

(setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
(setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
(appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
running 64-bit builds.

1:49 PM Changeset in webkit [160034] by bshafiei@apple.com

• 1 copy in tags/Safari-537.60.9

New tag.

1:21 PM Changeset in webkit [160033] by beidson@apple.com

• 9 edits in trunk/Source/WebKit2

Indexed Database work should be done on a non-main queue
​https://bugs.webkit.org/show_bug.cgi?id=125127

Reviewed by Darin Adler.

Add a non-main WorkQueue to the DatabaseProcess:

• DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::queue):

• DatabaseProcess/DatabaseProcess.h:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::enqueueDatabaseQueueRequest): Add an AsyncRequest to the deque then schedule performing

the requests on the background WorkQueue.

(WebKit::UniqueIDBDatabase::processDatabaseRequestQueue): Processes all enqueued database requests.
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata): Renamed from getIDBDatabaseMetadata().
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadataInternal): For doing i/o on a background queue/thread.

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Add a creator that takes the abort handler as an argument, and rename requestedCompleted()
to completeRequest(). This makes more sense in more situations:

• Shared/AsyncRequest.cpp:

(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):

• Shared/AsyncRequest.h:

(WebKit::AsyncRequest::completeRequest):

Update for the AsyncRequest rename:

• WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):

12:58 PM Changeset in webkit [160032] by Samuel White

• 7 edits
  2 adds in trunk

AXPress event coordinates are always sent as (0, 0)
​https://bugs.webkit.org/show_bug.cgi?id=76677

Reviewed by Simon Fraser.

Make sure a press targets an element's center point.

• accessibility/press-targets-center-point-expected.txt: Added.
• accessibility/press-targets-center-point.html: Added.

Set the coordinates of a simulated press equal to the center of the target
element when the simulated press does not have a related mouse event.

Test: accessibility/press-targets-center-point.html

• dom/Element.cpp: (WebCore::Element::clientRect): (WebCore::Element::screenRect):
• dom/Element.h:
• dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick):
• dom/MouseEvent.cpp: (WebCore::SimulatedMouseEvent::create): (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
• dom/MouseEvent.h:

12:37 PM Changeset in webkit [160031] by timothy_horton@apple.com

• 4 edits
  4 deletes in trunk/Source/WebKit2

Remove TiledCoreAnimationDrawingArea(Proxy)IOS
​https://bugs.webkit.org/show_bug.cgi?id=125176

Reviewed by Simon Fraser.

Remove unused code.

• UIProcess/API/ios/WKContentView.mm:
• UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.h: Removed.
• UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm: Removed.
• Shared/DrawingAreaInfo.h:
• WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

• WebProcess/WebPage/ios/TiledCoreAnimationDrawingAreaIOS.h: Removed.
• WebProcess/WebPage/ios/TiledCoreAnimationDrawingAreaIOS.mm: Removed.

12:21 PM Changeset in webkit [160030] by dino@apple.com

• 17 edits
  6 adds in trunk

[WebGL] Implement OES texture float linear
​https://bugs.webkit.org/show_bug.cgi?id=124871

Reviewed by Brent Fulgham.

Source/WebCore:

Implement the OES_texture_float_linear extension. Generally
we'd also enable OES_texture_half_float_linear at the same
time, but that's blocked on webkit.org/b/110936.

Test: fast/canvas/webgl/oes-texture-float-linear.html

• CMakeLists.txt: Add new files.
• DerivedSources.cpp: Ditto.
• DerivedSources.make: Generate new file from IDL.
• GNUmakefile.list.am: Add new files.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• WebCore.xcodeproj/project.pbxproj: New files for OESTextureFloatLinear.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Map the new name into the appropriate type.

• html/canvas/OESTextureFloatLinear.cpp: Added. This is a very simple class

that's mostly empty.
(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):
(WebCore::OESTextureFloatLinear::~OESTextureFloatLinear):
(WebCore::OESTextureFloatLinear::getName):
(WebCore::OESTextureFloatLinear::create):

• html/canvas/OESTextureFloatLinear.h: Added.
• html/canvas/OESTextureFloatLinear.idl: Added.

• html/canvas/WebGLExtension.h: Declare the new name in the enum of extensions.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::drawArrays): Call new name.
(WebCore::WebGLRenderingContext::drawElements): Call new name.
(WebCore::WebGLRenderingContext::getExtension): Create the new extension if asked.
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Renamed from handleNPOTTextures. Now
checks for the type of the texture too.

• html/canvas/WebGLRenderingContext.h: Member variable for new extension.

• html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Takes an extra parameter which indicates
if it has an extension enabled.
(WebCore::WebGLTexture::update): Note it is a float type when updating.

• html/canvas/WebGLTexture.h: New flag to indicate float type.

• platform/graphics/Extensions3D.h: New flag type.
• platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Add a comment about the extension.

LayoutTests:

Add the Khronos test files for this extension.

Add the JS test file for OES_texture_float_linear and OES_texture_half_float_linear
even though it's only used for the former at the moment.

• fast/canvas/webgl/oes-texture-float-linear.html: Added.
• fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js: Added.

12:18 PM Changeset in webkit [160029] by ap@apple.com

• 5 edits
  2 adds in trunk

Support exporting private WebCrypto RSA keys
​https://bugs.webkit.org/show_bug.cgi?id=124483

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/rsa-export-private-key.html

It might be better to have our own bignum implementation in WTF, but we currently
don't, and the need for this computation is Common Crypto specific anyway.

• crypto/CommonCryptoUtilities.h:
• crypto/CommonCryptoUtilities.cpp:

(WebCore::CCBigNum::CCBigNum):
(WebCore::CCBigNum::~CCBigNum):
(WebCore::CCBigNum::operator=):
(WebCore::CCBigNum::data):
(WebCore::CCBigNum::operator-):
(WebCore::CCBigNum::operator%):
(WebCore::CCBigNum::inverse):
Added a minimal wrapper around CommonCrypto BigNum.

• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::getPrivateKeyComponents): Compute missing parts using CCBigNum.
(WebCore::CryptoKeyRSA::exportData): Implemented private key case.

LayoutTests:

• crypto/subtle/rsa-export-private-key-expected.txt: Added.
• crypto/subtle/rsa-export-private-key.html: Added.

12:12 PM Changeset in webkit [160028] by andersca@apple.com

• 4 edits
  2 deletes in trunk/Source/WebKit2

Remove old WebKit::APIClient cruft
​https://bugs.webkit.org/show_bug.cgi?id=125173

Reviewed by Antti Koivisto.

• Shared/APIClient.h:
• Shared/APIClientTraits.cpp: Removed.
• Shared/APIClientTraits.h: Removed.
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

12:05 PM Changeset in webkit [160027] by ap@apple.com

• 2 edits in trunk/LayoutTests

WebCrypto HMAC doesn't check key algorithm's hash
​https://bugs.webkit.org/show_bug.cgi?id=125114

Update layout test result for a last minute change in test content.

• crypto/subtle/hmac-check-algorithm-expected.txt:

12:01 PM Changeset in webkit [160026] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix for iOS.

Reviewed by Tim Horton.

• Shared/WebCoreArgumentCoders.cpp: Added missing header.

11:51 AM Changeset in webkit [160025] by commit-queue@webkit.org

• 21 edits in trunk/Source/WebInspectorUI

Web Inspector: restore navigation panel state across reloads and reopens
​https://bugs.webkit.org/show_bug.cgi?id=122125

Patch by Brian J. Burg <Brian Burg> on 2013-12-03
Reviewed by Timothy Hatcher.

The previous strategy for restoring content views after inspector
re-open did not consider the active sidebar and its selection, and
tried to recreate the appropriate selection from the saved content
view. However, doesn't work for tree elements in the sidebar panel
that don't change views when selected, such as script breakpoints,
special breakpoints, call stack, timeline sections, etc.

This patch implements a new strategy that saves the navigation
sidebar panel's view state by serializing the identity of the
selected element's represented object. Relevant represented
object classes implement the saveIdentityToCookie() method. Each
represented object class also adds a TypeIdentifier property to
its constructor, to aid inexact matching based on represented
object type, rather than its complete identity.

When restoring, the navigation sidebar attempts to match added
tree elements against the pending cookie, and selects the element
if it matches. A represented object matches if its serialized
identity matches the previously saved serialized identity.

The inspector view state is now only saved on the page hide event
(for saving across reopen) and when the main frame commits its
provisional load (for saving across same-page reloads). It
consolidates similar view state settings into a single setting.

• UserInterface/ApplicationCacheFrame.js:

(WebInspector.ApplicationCacheFrame): Add cookie keys and type identifier.
(WebInspector.ApplicationCacheFrame.prototype.saveIdentityToCookie): Added.

• UserInterface/ApplicationCacheManager.js: remove objectForCookie().
• UserInterface/Breakpoint.js:

(WebInspector.Breakpoint): Add cookie keys and type identifier.
(WebInspector.Breakpoint.prototype.saveIdentityToCookie):

• UserInterface/CookieStorageObject.js:

(WebInspector.CookieStorageObject.prototype.saveIdentityToCookie): Added.

• UserInterface/DOMStorageObject.js:

(WebInspector.DOMStorageObject): Add cookie keys and type identifier.
(WebInspector.DOMStorageObject.prototype.saveIdentityToCookie): Added.

• UserInterface/DatabaseObject.js:

(WebInspector.DatabaseObject): Add cookie keys and type identifier.
(WebInspector.DatabaseObject.prototype.saveIdentityToCookie): Added.

• UserInterface/DatabaseTableObject.js:

(WebInspector.DatabaseTableObject): Add cookie keys and type identifier.
(WebInspector.DatabaseTableObject.prototype.saveIdentityToCookie): Added.

• UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie): Added.
(WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie): Added.

• UserInterface/Frame.js:

(WebInspector.Frame): Add cookie keys and type identifier.
(WebInspector.Frame.prototype.saveIdentityToCookie): Added.

• UserInterface/FrameResourceManager.js: remove objectForCookie().
• UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel.prototype.showTimelineForRecordType):
Return the shown timeline, if any.

(WebInspector.InstrumentSidebarPanel.prototype.saveStateToCookie): Added.
(WebInspector.InstrumentSidebarPanel.prototype.restoreStateFromCookie): Added.
(WebInspector.InstrumentSidebarPanel.prototype.showProfile):
Return the shown profile, if any.

• UserInterface/Main.js:

(WebInspector): Added cookie keys for the selected sidebar and
typeidentifier of the sidebar's selected tree element.

(WebInspector.contentLoaded): Remove callbacks for
resolveAndShowPendingContentViewCookie(). Consolidate all saved
inspector view state into one Setting. Move special-cased
restoring of the console to the restoration method. Move saving
of last opened navigation panel to the saving method.

(WebInspector._mainResourceDidChange): Try to restore saved view
state when the main resource changes.

(WebInspector._provisionalLoadCommitted): Update the saved view
state when the navigation commits. This is the last chance to save
it before the main resource changes and the navigation panel view
state is discarded and rebuilt.

(WebInspector._pageHidden): Update the saved view state when the
inspector page is hidden, but before state is discarded.

(WebInspector._navigationSidebarPanelSelected): Don't save last
navigation sidebar panel.
(WebInspector._updateCookieForInspectorViewState): Renamed from
_updateCurrentContentViewCookie. It delegates view state
serialization to the currently open navigation sidebar, rather
than the current content view.

(WebInspector._contentBrowserRepresentedObjectsDidChange): Don't
spuriously serialize the current view state cookie on every
ContentView change.

(WebInspector._restoreInspectorViewStateFromCookie): Renamed from
_showContentViewForCookie. It now restores a specific navigation
panel and delegates remaining view state restoration to the panel
itself. Last-resort selection of any tree element with the same
type identifier was moved to the navigation panel's restore method.

• UserInterface/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline):
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
Save references to all created TreeOutlines in a Set, so we can
restore any tree's selection.

(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
Added. Find the selected tree element from all tree outlines and
ask it to serialize its identity.

(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
Added. Eagerly search existing tree elements for a matching
representedObject. If none exists, save the pending cookie and
schedule last-resort matching using the provided timeout interval.

(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
Check if the added tree element matches a pending view state
cookie, if one exists.

(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
Added. Check if the tree element's representedObject matches the
pending view state cookie.

(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
Added. For each provided tree element, check if the tree
element's represented object produces the same serialized identity
as the pending view state cookie that we are trying to resolve.
If a match is found (possibly by relaxing to matching anything
with the same type), select the tree element and clear both the
pending view state cookie and last-resort selection timer.

• UserInterface/Resource.js:

(WebInspector.Resource): Add cookie keys and type identifier.
(WebInspector.Resource.prototype.saveIdentityToCookie): Added.

• UserInterface/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.saveToCookie):
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie):
Since identity state is serialized by the representedObject, these
methods only need to save view-specific state, such as the visible
subview. Remove extraneous state.

• UserInterface/Script.js:

(WebInspector.Script): Add cookie keys and type identifier.
(WebInspector.Script.prototype.saveIdentityToCookie): Added.

• UserInterface/StorageManager.js: remove objectForCookie().
• UserInterface/TimelineManager.js: remove objectForCookie().
• UserInterface/TimelinesContentView.js:

(WebInspector.TimelinesContentView.prototype.saveToCookie):
(WebInspector.TimelinesContentView.prototype.restoreFromCookie):
Since identity state is serialized by the representedObject, these
methods only need to save view-specific state, such as the visible
subview. Remove extraneous state.

• UserInterface/TreeOutline.js: Add TreeOutline.prototype.constructor

so other code can assume the constructor property exists.

11:44 AM Changeset in webkit [160024] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

XML fragment parsing algorithm doesn't use the context element's default namespace URI
​https://bugs.webkit.org/show_bug.cgi?id=125132

Reviewed by Darin Adler.

Source/WebCore:

Always use the context element's namespace as the default namespace URI when one is not specified by xmlns.

The new behavior matches that of Internet Explorer and the specified behavior in HTML5:
​http://www.w3.org/TR/2013/CR-html5-20130806/the-xhtml-syntax.html#parsing-xhtml-fragments

"The default namespace is the namespace for which the DOM isDefaultNamespace() method on the element would
return true."

Test: fast/parser/fragment-parsing-in-document-without-xmlns.html

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test for parsing a markup fragment inside a XHTML document without xmlns.
The parsed fragment should use the context element's namespace as the default namespace.

• fast/parser/fragment-parsing-in-document-without-xmlns-expected.txt: Added.
• fast/parser/fragment-parsing-in-document-without-xmlns.html: Added.

11:43 AM Changeset in webkit [160023] by commit-queue@webkit.org

• 5 edits in trunk/Source

Remove some CSS Variables leftovers
​https://bugs.webkit.org/show_bug.cgi?id=125167

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-03
Reviewed by Darin Adler.

Source/WebCore:

No new tests needed. Only removing leftover code.

• css/CSSBasicShapes.cpp:
• css/CSSBasicShapes.h:

Source/WebKit/blackberry:

• WebCoreSupport/AboutDataEnableFeatures.in:

11:37 AM Changeset in webkit [160022] by commit-queue@webkit.org

• 32 edits in trunk/Source/WebKit2

Remove WTF:: prefix from types in messages.in files.
​https://bugs.webkit.org/show_bug.cgi?id=124578

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Anders Carlsson.

The WTF:: prefixes are removed from the messages.in files, and the
messages.py now handles unprefixed non-template WTF classes (only
the WTF::String class is used currently). Tests are also updated.

• DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkProcess.messages.in:
• PluginProcess/PluginControllerProxy.messages.in:
• PluginProcess/PluginProcess.messages.in:
• Scripts/webkit2/messages.py:

(forward_declarations_and_headers):
(class_template_headers):
(argument_coder_headers_for_type):

• Scripts/webkit2/messages_unittest.py:

(std):

• Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
• UIProcess/Downloads/DownloadProxy.messages.in:
• UIProcess/Plugins/PluginProcessProxy.messages.in:
• UIProcess/Storage/StorageManager.messages.in:
• UIProcess/WebContext.messages.in:
• UIProcess/WebCookieManagerProxy.messages.in:
• UIProcess/WebDatabaseManagerProxy.messages.in:
• UIProcess/WebIconDatabase.messages.in:
• UIProcess/WebInspectorProxy.messages.in:
• UIProcess/WebMediaCacheManagerProxy.messages.in:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessProxy.messages.in:
• WebProcess/Cookies/WebCookieManager.messages.in:
• WebProcess/Geolocation/WebGeolocationManager.messages.in:
• WebProcess/MediaCache/WebMediaCacheManager.messages.in:
• WebProcess/Notifications/WebNotificationManager.messages.in:
• WebProcess/Plugins/PluginProcessConnection.messages.in:
• WebProcess/Plugins/PluginProxy.messages.in:
• WebProcess/Storage/StorageAreaMap.messages.in:
• WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
• WebProcess/WebPage/WebInspector.messages.in:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebProcess.messages.in:
• WebProcess/soup/WebSoupRequestManager.messages.in:

11:37 AM Changeset in webkit [160021] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Checking second-to-last bit in address is a typo
​https://bugs.webkit.org/show_bug.cgi?id=125162

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-12-03
Reviewed by Darin Adler.

After talking with the original author of this line,
is was a typo to make sure that the second-to-last bit
in an address is 0. Instead, we want to make sure that
the address is aligned to a 4-byte boundary

No behavior change, so no test is necessary

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

11:36 AM Changeset in webkit [160020] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Tweak build fixes.

• Shared/APIClient.h:

11:34 AM Changeset in webkit [160019] by Brent Fulgham

• 2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r160017.

2013-12-03 Brent Fulgham <Brent Fulgham>

[Win] WebKit.make Makefile doesn't copy resource bundle to DSTROOT
​https://bugs.webkit.org/show_bug.cgi?id=125160

Reviewed by Tim Horton.

• WebKit.vcxproj/WebKit.make: Add copy command for resource bundle.

11:31 AM Changeset in webkit [160018] by dbates@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

ANGLE fails to build with trunk clang: unused constant kTraceBufferLen
​https://bugs.webkit.org/show_bug.cgi?id=125164
​https://code.google.com/p/angleproject/issues/detail?id=534

Reviewed by Darin Adler.

Move the definition of the constant kTraceBufferLen under the macro
guard TRACE_ENABLED since it's only referenced in code guarded by
TRACE_ENABLED.

• src/compiler/debug.cpp:

11:26 AM Changeset in webkit [160017] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] WebKit.make Makefile doesn't copy resource bundle to DSTROOT
​https://bugs.webkit.org/show_bug.cgi?id=125160

Reviewed by Tim Horton.

• WebKit.vcxproj/WebKit.make: Add copy command for resource bundle.

11:04 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

(diff)

10:51 AM Changeset in webkit [160016] by mhahnenberg@apple.com

• 2 edits
  1 add in trunk/Tools

run-jsc-stress-tests only supports host environments that have make installed
​https://bugs.webkit.org/show_bug.cgi?id=124550

Reviewed by Darin Adler.

This might not be the case for all hosts, so this patch implements an alternate "backend"
for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at
least somewhat competitive with the make-based test runner, the shell backend uses subshells
run in the background to allow tests to run in parallel. Since the concurrency primitives
in shell scripting are rather coarse, the overhead of this parallelism is higher than that
of the make-based runner.

• Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into

the bundle and controls all of the parallel aspects of the shell-based test runner.

• Scripts/run-jsc-stress-tests:

10:44 AM Changeset in webkit [160015] by Chris Fleizach

• 2 edits in trunk/Source/WebKit/mac

AX: Crash in accessibilityRoot when Document goes away
​https://bugs.webkit.org/show_bug.cgi?id=125113

Reviewed by Tim Horton.

The AXObjectCache can sometimes be null if the render tree has been detached from the document.

• WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

10:28 AM Changeset in webkit [160014] by stavila@adobe.com

• 3 edits
  4 adds in trunk

The overflow border of a relatively positioned element inside a region is not painted
​https://bugs.webkit.org/show_bug.cgi?id=124919

Source/WebCore:

Relative positioned elements have self-painting layers that don't propagate the visual overflow
so the layer's position should be used when determining the clipping rectangle for box decorations.

Reviewed by Mihnea Ovidenie.

Test: fast/regions/relative-borders-overflow.html

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):

LayoutTests:

Added new tests for correct painting of the borders of a relatively positioned element inside a region.

Reviewed by Mihnea Ovidenie.

• fast/regions/relative-borders-overflow-expected.html: Added.
• fast/regions/relative-borders-overflow.html: Added.
• fast/regions/relative-in-absolute-borders-overflow-expected.html: Added.
• fast/regions/relative-in-absolute-borders-overflow.html: Added.

10:09 AM Changeset in webkit [160013] by Seokju Kwon

• 3 edits in trunk/Source/WebCore

Web Inspector: Get rid of 'hasFrontend()' in InspectorController and WorkerInspectorController
​https://bugs.webkit.org/show_bug.cgi?id=125135

Reviewed by Darin Adler.

Remove 'hasFrontend()' from InspectorController and WorkerInspectorController
as it's never called.

No new tests, no behavior changes.

• inspector/InspectorController.h:
• inspector/WorkerInspectorController.h:

10:08 AM Changeset in webkit [160012] by Seokju Kwon

• 7 edits in trunk/Source/WebCore

Web Inspector: webViewResized() is not used anywhere in WebInspectorUI
​https://bugs.webkit.org/show_bug.cgi?id=125137

Reviewed by Darin Adler.

Remove leftover code.

No new tests, no behavior changes.

• inspector/InspectorController.cpp:
• inspector/InspectorController.h:
• inspector/InspectorOverlay.cpp:
• inspector/InspectorOverlay.h:
• inspector/InspectorPageAgent.cpp:
• inspector/InspectorPageAgent.h:

9:40 AM Changeset in webkit [160011] by Chris Fleizach

• 1 edit
  2 adds in trunk/LayoutTests

AX: aria-hidden=false does not work as expected
​https://bugs.webkit.org/show_bug.cgi?id=98787

Reviewed by Beth Dakin.

These tests were part of this patch added over a year ago, but the patch was rolled out, and when it was rolled back in
the tests were never added. So I'm adding them back again.

• accessibility/aria-hidden-negates-no-visibility.html: Added.
• platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.

9:29 AM Changeset in webkit [160010] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

ASSERTION FAILED: !value

(value->isPrimitiveValue()) in WebCore::StyleProperties::getLayeredShorthandValue.

​https://bugs.webkit.org/show_bug.cgi?id=125146

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-03
Reviewed by Darin Adler.

Source/WebCore:

Do not presume that |yValue| is primitive if |value| is implicit in StylePropertySerializer.
An implicit y-value can become explicit if specified as a separate longhand.
At the same time, its new value can be non-primitive.

Backported from Blink:
​http://src.chromium.org/viewvc/blink?view=rev&rev=153678

Test: fast/css/webkit-mask-crash-implicit.html

• css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue):

LayoutTests:

• fast/css/webkit-mask-crash-implicit-expected.txt: Added.
• fast/css/webkit-mask-crash-implicit.html: Added.

9:26 AM Changeset in webkit [160009] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebCore

Fix build break after r160007.

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):

9:25 AM Changeset in webkit [160008] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix EFL build error in WK2 (159965)
​https://bugs.webkit.org/show_bug.cgi?id=125153

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-12-03
Reviewed by Darin Adler.

• Shared/APIClient.h:

9:18 AM Changeset in webkit [160007] by rwlbuis@webkit.org

• 17 edits
  2 adds in trunk

[css shapes] layout for new ellipse syntax
​https://bugs.webkit.org/show_bug.cgi?id=124621

Source/WebCore:

Reviewed by Dirk Schulze.

Implement support for doing layout with the new ellipse shape syntax,
including basic animation support.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Convert new ellipse to a layout shape.

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend): Ignore ellipses with values that

cannot be interpolated.

(WebCore::BasicShapeEllipse::floatValueForRadiusInBox): Helper function to calculate

either radiusX or radiusY, shared by clip-path and shape code paths.

(WebCore::BasicShapeEllipse::path):

• rendering/style/BasicShapes.h:

LayoutTests:

Add a new test for the new ellipse syntax. Also update existing shape-inside, animation, and clip-path tests to
test the new ellipse syntax for clipping and shape-inside.

Reviewed by Dirk Schulze.

• animations/resources/animation-test-helpers.js:

(parseBasicShape):

• css3/masking/clip-path-animation-expected.txt:
• css3/masking/clip-path-animation.html:
• css3/masking/clip-path-ellipse.html:
• fast/shapes/shape-inside/shape-inside-animation-expected.txt:
• fast/shapes/shape-inside/shape-inside-animation.html:
• fast/shapes/shape-inside/shape-inside-ellipse-padding.html:
• fast/shapes/shape-inside/shape-inside-ellipse.html:
• fast/shapes/shape-inside/shape-inside-empty-expected.html:
• fast/shapes/shape-inside/shape-inside-empty.html:
• fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
• fast/shapes/shape-outside-floats/shape-outside-animation.html:
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html: Added.

9:15 AM Changeset in webkit [160006] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Remove function from TextChecker
​https://bugs.webkit.org/show_bug.cgi?id=125148

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Darin Adler.

The process_file_data is used only from the unit tests, so it is simply moved there.

• Scripts/webkitpy/style/checkers/text.py:

(TextChecker.check):

• Scripts/webkitpy/style/checkers/text_unittest.py:

(TextStyleTestCase.process_file_data):
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError):

9:12 AM Changeset in webkit [160005] by commit-queue@webkit.org

• 14 edits
  1 copy
  7 adds in trunk

Add an MathMLSelectElement class to implement <maction> and <semantics>.
<​https://webkit.org/b/120058>

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-12-03
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: mathml/presentation/maction-dynamic.html

mathml/presentation/maction.html
mathml/presentation/semantics.html

This adds a new MathMLSelectElement class to prepare the implementation
of the <maction> and <semantics> elements, for which only one "selected"
child is visible. We now simply display the first child of the
<semantics> element instead of hiding the annotations and this allows to
handle the use case of SVG-in-MathML as generated by Instiki when
bug 124128 is fixed ; Gecko's selection algorithm will be implemented
later (bug 100626). We now also rely on the @actiontype and @selection
attributes to select the visible <maction> child ; It remains to deal
with the user interaction (bug 85734).

• CMakeLists.txt: add the new files.
• GNUmakefile.list.am: ditto
• Target.pri: ditto
• WebCore.vcxproj/WebCore.vcxproj: ditto
• WebCore.vcxproj/WebCore.vcxproj.filters: ditto
• WebCore.xcodeproj/project.pbxproj: ditto
• css/mathml.css: remove the CSS rule for annotation/annotation-xml.
• mathml/MathMLAllInOne.cpp: add the new cpp file.
• mathml/MathMLSelectElement.cpp: Added.

(WebCore::MathMLSelectElement::MathMLSelectElement):
(WebCore::MathMLSelectElement::create):
(WebCore::MathMLSelectElement::createRenderer):
(WebCore::MathMLSelectElement::childShouldCreateRenderer):
(WebCore::MathMLSelectElement::finishParsingChildren):
(WebCore::MathMLSelectElement::childrenChanged):
(WebCore::MathMLSelectElement::attributeChanged):
(WebCore::MathMLSelectElement::updateSelectedChild): basic implementation for maction, semantics, maction@actiontype and maction@selection.

• mathml/MathMLSelectElement.h: Added.
• mathml/mathattrs.in: add actiontype and selection attributes.
• mathml/mathtags.in: set element classes for maction, semantics, annotation and annotation-xml.

LayoutTests:

New tests for the selection of the visible child in the <maction> and <semantics> elements.

• mathml/presentation/maction-dynamic-expected.html: Added.
• mathml/presentation/maction-dynamic.html: Added.
• mathml/presentation/maction-expected.html: Added.
• mathml/presentation/maction.html: Added.
• mathml/presentation/semantics-expected.html: Added.
• mathml/presentation/semantics.html: Added.

9:09 AM Changeset in webkit [160004] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

testapi test crashes on Windows in WTF::Vector<wchar_t,64,WTF::UnsafeVectorOverflow>::size()
​https://bugs.webkit.org/show_bug.cgi?id=121972

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-12-03
Reviewed by Michael Saboff.

The reason for the crash is that the wrong memory block is decommitted.
This can happen if no memory has been committed in the reserved block before the JSStack object is destroyed.
In the JSStack destructor, the pointer to decommit then points to the end of the block (or the start of the next), and the decommit size is zero.
If there is a block just after the block we are trying to decommit, this block will be decommitted, since Windows will decommit the whole block,
if the decommit size is zero (see VirtualFree). When somebody tries to read/write to this block later, we crash.

• interpreter/JSStack.cpp:

(JSC::JSStack::~JSStack): Don't decommit memory if nothing has been committed.

7:53 AM Changeset in webkit [160003] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Guard JIT include.
​https://bugs.webkit.org/show_bug.cgi?id=125063

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-03
Reviewed by Filip Pizlo.

• llint/LLIntThunks.cpp:

7:02 AM Changeset in webkit [160002] by Seokju Kwon

• 2 edits in trunk/Source/WebKit2

Debug build fix : Add '<algorithm>' for 'std::is_sorted' after r159965.
​https://bugs.webkit.org/show_bug.cgi?id=125140

Reviewed by Csaba Osztrogonác.

• Shared/APIClient.h:

6:24 AM Changeset in webkit [160001] by commit-queue@webkit.org

• 2 edits
  6 adds in trunk/Source/WebCore

Nix Upstream: Adding missing nix new files to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=124987

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-12-03
Reviewed by Benjamin Poulain.

No new tests needed.

• PlatformNix.cmake:
• platform/nix/ErrorsNix.cpp: Added.
• platform/nix/ErrorsNix.h: Added.
• platform/nix/FileSystemNix.cpp: Added.
• platform/nix/MIMETypeRegistryNix.cpp: Added.
• platform/nix/SharedTimerNix.cpp: Added.
• platform/nix/TemporaryLinkStubs.cpp: Added.

4:44 AM Changeset in webkit [160000] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix EFL build with INPUT_TYPE_COLOR disabled.
​https://bugs.webkit.org/show_bug.cgi?id=125065

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Zoltan Herczeg.

• UIProcess/API/efl/ewk_color_picker.cpp:

4:42 AM Changeset in webkit [159999] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Correct broken build on efl port with --no-netscape-plugin-api
configuration.
​https://bugs.webkit.org/show_bug.cgi?id=123997

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-12-03
Reviewed by Zoltan Herczeg.

Build failed on efl port with --no-netscape-plugin-api configuration
as ld did not found some methods. The configuration uses a minimal
empty implementation of the class, which is now extended with empty
method implementations.

• plugins/PluginPackageNone.cpp:

(WebCore::PluginPackage::createPackage):

Returns NULL pointer.

(WebCore::PluginPackage::hash):

Returns 0.

(WebCore::PluginPackage::equal):

Returns true (equals).

(WebCore::PluginPackage::compare):

Returns 0 (equals).

(WebCore::PluginPackage::~PluginPackage):

Do nothing.

4:40 AM Changeset in webkit [159998] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove get_test() and reference test names directly instead.
​https://bugs.webkit.org/show_bug.cgi?id=124962

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(Base.init):
(Base.get_basic_tests):
(assert_exp):
(MiscTests.test_multiple_results):
(MiscTests.test_category_expectations):
(MiscTests.test_get_modifiers):
(MiscTests.test_get_expectations_string):
(MiscTests.test_get_test_set):
(MiscTests.test_parse_warning):
(MiscTests.test_pixel_tests_flag.match):

4:30 AM Changeset in webkit [159997] by Csaba Osztrogonác

• 3 edits in trunk/Tools

Style Checker false pass.
​https://bugs.webkit.org/show_bug.cgi?id=112456

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."

• Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_no_new_tests):

2:29 AM Changeset in webkit [159996] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

Add spatial navigation API in EFL port
​https://bugs.webkit.org/show_bug.cgi?id=125002

Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-12-03
Reviewed by Gyuyoung Kim.

API enables capability of turning on and off spatial navigation
and check is state.
Spatial navigation is the ability to navigate between focusable
elements by keyboard.

• UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):

• UIProcess/API/efl/ewk_settings.h:
• UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

2:28 AM Changeset in webkit [159995] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Merge mips and arm/sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
​https://bugs.webkit.org/show_bug.cgi?id=125067

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-12-03
Reviewed by Michael Saboff.

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

12:01 AM Changeset in webkit [159994] by zandobersek@gmail.com

• 29 edits in trunk/Source/WebKit2

Build fixes for GCC-using ports after r159965 and later
​https://bugs.webkit.org/show_bug.cgi?id=125136

GCC doesn't process API::ClientTraits template instantiations unless they're done
inside the API namespace.

• Shared/WebConnectionClient.h:
• UIProcess/Notifications/WebNotificationProvider.h:
• UIProcess/WebContextClient.h:
• UIProcess/WebContextConnectionClient.h:
• UIProcess/WebContextInjectedBundleClient.h:
• UIProcess/WebCookieManagerProxyClient.h:
• UIProcess/WebDatabaseManagerProxyClient.h:
• UIProcess/WebDownloadClient.h:
• UIProcess/WebFindClient.h:
• UIProcess/WebFormClient.h:
• UIProcess/WebGeolocationProvider.h:
• UIProcess/WebHistoryClient.h:
• UIProcess/WebIconDatabaseClient.h:
• UIProcess/WebLoaderClient.h:
• UIProcess/WebOriginDataManagerProxyChangeClient.h:
• UIProcess/WebPageContextMenuClient.h:
• UIProcess/WebPolicyClient.h:
• UIProcess/WebUIClient.h:
• WebProcess/InjectedBundle/InjectedBundleClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

Dec 2, 2013:

10:20 PM Changeset in webkit [159993] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Build fix.

• UIProcess/API/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS initWithContext:]):

9:53 PM Changeset in webkit [159992] by commit-queue@webkit.org

• 6 edits
  2 copies in trunk/Source/WebKit2

Add ability to iterate over API::Array
​https://bugs.webkit.org/show_bug.cgi?id=124533

Patch by Martin Hock <​mhock@apple.com> on 2013-12-02
Reviewed by Sam Weinig.

• GNUmakefile.list.am:
• Shared/APIArray.h:
• Shared/FilterIterator.h:
• Shared/IteratorPair.h:
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::toStringVector):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

8:25 PM Changeset in webkit [159991] by mitz@apple.com

• 4 edits
  2 adds in trunk/Source/WebKit2

[Cocoa] WebProtectionSpace has a generic wrapper
​https://bugs.webkit.org/show_bug.cgi?id=125125

Reviewed by Anders Carlsson.

Added WKNSURLProtectionSpace.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKNSURLProtectionSpace if the object is a
WebProtectionSpace.

• Shared/Cocoa/WKNSURLProtectionSpace.h: Added.

(WebKit::wrapper): Added. Returns a WebProtecitonSpace’s wrapper as an NSURLProtectionSpace.

• Shared/Cocoa/WKNSURLProtectionSpace.mm: Added.

(-[WKNSURLProtectionSpace copyWithZone:]): Retains self.

• UIProcess/Authentication/WebProtectionSpace.h:

(WebKit::WebProtectionSpace::protectionSpace): Added an accessor for the
WebCore::ProtectionSpace.

• WebKit2.xcodeproj/project.pbxproj: Added references to new files.

8:19 PM Changeset in webkit [159990] by fpizlo@apple.com

• 2 edits in trunk/Tools

run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
​https://bugs.webkit.org/show_bug.cgi?id=125130

Reviewed by Geoffrey Garen.

• Scripts/run-jsc-stress-tests:

7:19 PM Changeset in webkit [159989] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Avoid setting style twice for generated image content.
<​https://webkit.org/b/125128>

Take care of a FIXME I added in r158097 and avoid redundant work in
ImageContentData::createRenderer().

I changed the inheritance helper RenderImage::setPseudoStyle() into
a new createStyleInheritingFromPseudoStyle() function instead so it
can be used from both PseudoElement and ImageContentData.

Reviewed by Antti Koivisto.

6:36 PM Changeset in webkit [159988] by andersca@apple.com

• 91 edits in trunk/Source/WebKit2

Replace uses of WebKit::APIClient with API::Client
​https://bugs.webkit.org/show_bug.cgi?id=125129

Reviewed by Andreas Kling.

• Shared/API/c/WKConnectionRef.cpp:

(WKConnectionSetConnectionClient):

• Shared/WebConnection.cpp:

(WebKit::WebConnection::initializeConnectionClient):

• Shared/WebConnection.h:
• Shared/WebConnectionClient.cpp:

(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):

• Shared/WebConnectionClient.h:
• UIProcess/API/C/WKContext.cpp:

(WKContextSetClient):
(WKContextSetInjectedBundleClient):
(WKContextSetHistoryClient):
(WKContextSetDownloadClient):
(WKContextSetConnectionClient):

• UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetClient):

• UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

• UIProcess/API/C/WKGeolocationManager.cpp:

(WKGeolocationManagerSetProvider):

• UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):

• UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerSetProvider):

• UIProcess/API/C/WKOriginDataManager.cpp:

(WKOriginDataManagerSetChangeClient):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageFindMatchesClient):
(WKPageSetPageFormClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):

• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::initializeProvider):

• UIProcess/Notifications/WebNotificationManagerProxy.h:
• UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::show):
(WebKit::WebNotificationProvider::cancel):
(WebKit::WebNotificationProvider::didDestroyNotification):
(WebKit::WebNotificationProvider::clearNotifications):
(WebKit::WebNotificationProvider::addNotificationManager):
(WebKit::WebNotificationProvider::removeNotificationManager):
(WebKit::WebNotificationProvider::notificationPermissions):

• UIProcess/Notifications/WebNotificationProvider.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeClient):
(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::initializeConnectionClient):
(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::initializeDownloadClient):

• UIProcess/WebContext.h:
• UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged):
(WebKit::WebContextClient::networkProcessDidCrash):
(WebKit::WebContextClient::plugInInformationBecameAvailable):

• UIProcess/WebContextClient.h:
• UIProcess/WebContextConnectionClient.cpp:

(WebKit::WebContextConnectionClient::didCreateConnection):

• UIProcess/WebContextConnectionClient.h:
• UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

• UIProcess/WebContextInjectedBundleClient.h:
• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::initializeClient):

• UIProcess/WebCookieManagerProxy.h:
• UIProcess/WebCookieManagerProxyClient.cpp:

(WebKit::WebCookieManagerProxyClient::cookiesDidChange):

• UIProcess/WebCookieManagerProxyClient.h:
• UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):

• UIProcess/WebDatabaseManagerProxy.h:
• UIProcess/WebDatabaseManagerProxyClient.cpp:

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

• UIProcess/WebDatabaseManagerProxyClient.h:
• UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didReceiveAuthenticationChallenge):
(WebKit::WebDownloadClient::didReceiveResponse):
(WebKit::WebDownloadClient::didReceiveData):
(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
(WebKit::WebDownloadClient::didFail):
(WebKit::WebDownloadClient::didCancel):
(WebKit::WebDownloadClient::processDidCrash):

• UIProcess/WebDownloadClient.h:
• UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::didFindString):
(WebKit::WebFindClient::didFailToFindString):
(WebKit::WebFindClient::didCountStringMatches):
(WebKit::WebFindMatchesClient::didFindStringMatches):
(WebKit::WebFindMatchesClient::didGetImageForMatchResult):

• UIProcess/WebFindClient.h:
• UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

• UIProcess/WebFormClient.h:
• UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::initializeProvider):

• UIProcess/WebGeolocationManagerProxy.h:
• UIProcess/WebGeolocationProvider.cpp:

(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):
(WebKit::WebGeolocationProvider::setEnableHighAccuracy):

• UIProcess/WebGeolocationProvider.h:
• UIProcess/WebHistoryClient.cpp:

(WebKit::WebHistoryClient::didNavigateWithNavigationData):
(WebKit::WebHistoryClient::didPerformClientRedirect):
(WebKit::WebHistoryClient::didPerformServerRedirect):
(WebKit::WebHistoryClient::didUpdateHistoryTitle):
(WebKit::WebHistoryClient::populateVisitedLinks):

• UIProcess/WebHistoryClient.h:
• UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::initializeIconDatabaseClient):

• UIProcess/WebIconDatabase.h:
• UIProcess/WebIconDatabaseClient.cpp:

(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):

• UIProcess/WebIconDatabaseClient.h:
• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

• UIProcess/WebLoaderClient.h:
• UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::setChangeClient):

• UIProcess/WebOriginDataManagerProxy.h:
• UIProcess/WebOriginDataManagerProxyChangeClient.cpp:

(WebKit::WebOriginDataManagerProxyChangeClient::didChange):

• UIProcess/WebOriginDataManagerProxyChangeClient.h:
• UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::customContextMenuItemSelected):
(WebKit::WebPageContextMenuClient::contextMenuDismissed):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit::WebPageContextMenuClient::hideContextMenu):

• UIProcess/WebPageContextMenuClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializePolicyClient):
(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::initializeFindClient):
(WebKit::WebPageProxy::initializeFindMatchesClient):
(WebKit::WebPageProxy::initializeContextMenuClient):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
(WebKit::WebPolicyClient::unableToImplementPolicy):

• UIProcess/WebPolicyClient.h:
• UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):
(WebKit::WebUIClient::showPage):
(WebKit::WebUIClient::close):
(WebKit::WebUIClient::takeFocus):
(WebKit::WebUIClient::focus):
(WebKit::WebUIClient::unfocus):
(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):
(WebKit::WebUIClient::setStatusText):
(WebKit::WebUIClient::mouseDidMoveOverElement):
(WebKit::WebUIClient::unavailablePluginButtonClicked):
(WebKit::WebUIClient::didNotHandleKeyEvent):
(WebKit::WebUIClient::didNotHandleWheelEvent):
(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):
(WebKit::WebUIClient::setWindowFrame):
(WebKit::WebUIClient::windowFrame):
(WebKit::WebUIClient::runBeforeUnloadConfirmPanel):
(WebKit::WebUIClient::didDraw):
(WebKit::WebUIClient::pageDidScroll):
(WebKit::WebUIClient::exceededDatabaseQuota):
(WebKit::WebUIClient::runOpenPanel):
(WebKit::WebUIClient::decidePolicyForGeolocationPermissionRequest):
(WebKit::WebUIClient::decidePolicyForNotificationPermissionRequest):
(WebKit::WebUIClient::headerHeight):
(WebKit::WebUIClient::footerHeight):
(WebKit::WebUIClient::drawHeader):
(WebKit::WebUIClient::drawFooter):
(WebKit::WebUIClient::printFrame):
(WebKit::WebUIClient::runModal):
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
(WebKit::WebUIClient::shouldInterruptJavaScript):
(WebKit::WebUIClient::showColorPicker):
(WebKit::WebUIClient::hideColorPicker):

• UIProcess/WebUIClient.h:
• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetClient):

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):
(WKBundlePageSetEditorClient):
(WKBundlePageSetFormClient):
(WKBundlePageSetPageLoaderClient):
(WKBundlePageSetResourceLoadClient):
(WKBundlePageSetPolicyClient):
(WKBundlePageSetUIClient):
(WKBundlePageSetFullScreenClient):
(WKBundlePageSetDiagnosticLoggingClient):

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::initializeClient):

• WebProcess/InjectedBundle/InjectedBundle.h:
• WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didCreatePage):
(WebKit::InjectedBundleClient::willDestroyPage):
(WebKit::InjectedBundleClient::didInitializePageGroup):
(WebKit::InjectedBundleClient::didReceiveMessage):
(WebKit::InjectedBundleClient::didReceiveMessageToPage):

• WebProcess/InjectedBundle/InjectedBundleClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

• WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):

• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
(WebKit::InjectedBundlePageEditorClient::didBeginEditing):
(WebKit::InjectedBundlePageEditorClient::didEndEditing):
(WebKit::InjectedBundlePageEditorClient::didChange):
(WebKit::InjectedBundlePageEditorClient::didChangeSelection):
(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard):
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
(WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):

• WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayout):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
(WebKit::InjectedBundlePageLoaderClient::shouldForceUniversalAccessFromLocalURL):
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
(WebKit::InjectedBundlePageLoaderClient::willDestroyFrame):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):

• WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse):
(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage):

• WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldGenerateFileForUpload):
(WebKit::InjectedBundlePageUIClient::generateFileForUpload):
(WebKit::InjectedBundlePageUIClient::statusBarIsVisible):
(WebKit::InjectedBundlePageUIClient::menuBarIsVisible):
(WebKit::InjectedBundlePageUIClient::toolbarsAreVisible):
(WebKit::InjectedBundlePageUIClient::didReachApplicationCacheOriginQuota):
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
(WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet):
(WebKit::InjectedBundlePageUIClient::plugInExtraScript):

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleContextMenuClient):
(WebKit::WebPage::initializeInjectedBundleEditorClient):
(WebKit::WebPage::initializeInjectedBundleFormClient):
(WebKit::WebPage::initializeInjectedBundleLoaderClient):
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
(WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
(WebKit::WebPage::initializeInjectedBundleUIClient):
(WebKit::WebPage::initializeInjectedBundleFullScreenClient):
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):

• WebProcess/WebPage/WebPage.h:

5:32 PM Changeset in webkit [159987] by mark.lam@apple.com

• 12 edits in trunk/Source

Build failure when disabling JIT, YARR_JIT, and ASSEMBLER.
​https://bugs.webkit.org/show_bug.cgi?id=123809.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Also fixed build when disabling the DISASSEMBLER.
Added some needed #if's and some comments.

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

• dfg/DFGDisassembler.cpp:
• dfg/DFGDisassembler.h:

(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::setStartOfCode):
(JSC::DFG::Disassembler::setForBlockIndex):
(JSC::DFG::Disassembler::setForNode):
(JSC::DFG::Disassembler::setEndOfMainPath):
(JSC::DFG::Disassembler::setEndOfCode):
(JSC::DFG::Disassembler::dump):
(JSC::DFG::Disassembler::reportToProfiler):

• disassembler/Disassembler.cpp:
• disassembler/X86Disassembler.cpp:
• jit/FPRInfo.h:
• jit/GPRInfo.h:
• jit/JITDisassembler.cpp:
• jit/JITDisassembler.h:

(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::reportToProfiler):

Source/WTF:

• wtf/Platform.h:
• Ensure that the ASSEMBLER is enabled when the DISASSEMBLER is enabled.

5:27 PM Changeset in webkit [159986] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
​https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

FrameLoader::loadProgressingStatusChanged() might be called while the Frame has a null FrameView.

It’s unclear how to reproduce, but there’s no harm in a null check.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

5:12 PM Changeset in webkit [159985] by enrica@apple.com

• 17 edits in trunk/Source/WebKit2

Merging some more iOS WebKit2 stuff.
​https://bugs.webkit.org/show_bug.cgi?id=125119

Reviewed by Tim Horton.

• Shared/EditorState.h:
• Shared/NativeWebKeyboardEvent.h:
• Shared/NativeWebMouseEvent.h:
• Shared/NativeWebTouchEvent.h:
• Shared/mac/RemoteLayerBackingStore.h:
• Shared/mac/RemoteLayerTreePropertyApplier.mm:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:
• UIProcess/PageClient.h:
• UIProcess/ios/TiledCoreAnimationDrawingAreaProxyIOS.mm:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
• UIProcess/mac/SecItemShimProxy.messages.in:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

5:11 PM Changeset in webkit [159984] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Add versioned structs for the remaining clients
​https://bugs.webkit.org/show_bug.cgi?id=125123

Reviewed by Andreas Kling.

• UIProcess/API/C/WKContext.h:
• UIProcess/API/C/WKContextConnectionClient.h:
• UIProcess/API/C/WKContextDownloadClient.h:
• UIProcess/API/C/WKContextHistoryClient.h:
• UIProcess/API/C/WKContextInjectedBundleClient.h:
• UIProcess/API/C/WKOriginDataManager.h:

4:54 PM Changeset in webkit [159983] by andersca@apple.com

• 3 edits
  4 adds in trunk/Source/WebKit2

Move WKContext clients to separate files
​https://bugs.webkit.org/show_bug.cgi?id=125121

Reviewed by Andreas Kling.

• UIProcess/API/C/WKContext.h:
• UIProcess/API/C/WKContextConnectionClient.h: Added.
• UIProcess/API/C/WKContextDownloadClient.h: Added.
• UIProcess/API/C/WKContextHistoryClient.h: Added.
• UIProcess/API/C/WKContextInjectedBundleClient.h: Added.
• WebKit2.xcodeproj/project.pbxproj:

4:43 PM Changeset in webkit [159982] by weinig@apple.com

• 8 edits in trunk/Source/WebKit2

WebPageGroups should keep track of what processes they are being used by
​https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Anders Carlsson.

• UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addProcess):
(WebKit::WebPageGroup::disconnectProcess):

• UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::webPageGroup):
(WebKit::WebProcessProxy::addWebPageGroup):

• UIProcess/WebProcessProxy.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

4:40 PM Changeset in webkit [159981] by andersca@apple.com

• 26 edits in trunk/Source/WebKit2

Add versioned structs for all clients except the ones in WKContext.h
​https://bugs.webkit.org/show_bug.cgi?id=125120

Reviewed by Andreas Kling.

• Shared/API/c/WKConnectionRef.h:
• UIProcess/API/C/WKCookieManager.h:
• UIProcess/API/C/WKDatabaseManager.h:
• UIProcess/API/C/WKGeolocationManager.h:
• UIProcess/API/C/WKIconDatabase.h:
• UIProcess/API/C/WKNotificationProvider.h:
• UIProcess/API/C/WKPageContextMenuClient.h:
• UIProcess/API/C/WKPageFindClient.h:
• UIProcess/API/C/WKPageFindMatchesClient.h:
• UIProcess/API/C/WKPageFormClient.h:
• UIProcess/API/C/WKPageLoaderClient.h:
• UIProcess/API/C/WKPagePolicyClient.h:
• UIProcess/API/C/WKPageUIClient.h:
• WebProcess/InjectedBundle/API/c/WKBundle.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
• WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:

4:36 PM Changeset in webkit [159980] by Samuel White

• 18 edits
  2 adds in trunk

AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
​https://bugs.webkit.org/show_bug.cgi?id=124561

Reviewed by Chris Fleizach.

Added test to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute
works as it should and updated existing test that has exposes this new attribute.

• platform/mac/accessibility/bounds-for-range-expected.txt:
• platform/mac/accessibility/search-predicate-element-count-expected.txt: Added.
• platform/mac/accessibility/search-predicate-element-count.html: Added.

Added ability to fetch the number of elements that match a specific criteria. This will enable VoiceOver
to interface with WebKit much more dynamically. We can now get an idea of how many interesting elements
exist on a page, and then fetch them in chunks as needed.

Test: platform/mac/accessibility/search-predicate-element-count.html

• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
• accessibility/AccessibilityObject.h: (WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute): (-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.

• DumpRenderTree/AccessibilityUIElement.cpp: (uiElementCountForSearchPredicateCallback): (uiElementForSearchPredicateCallback): (AccessibilityUIElement::getJSClass):
• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
• DumpRenderTree/ios/AccessibilityUIElementIOS.mm: (AccessibilityUIElement::uiElementCountForSearchPredicate):
• DumpRenderTree/mac/AccessibilityUIElementMac.mm: (searchPredicateParameterizedAttributeForSearchCriteria): (AccessibilityUIElement::uiElementCountForSearchPredicate): (AccessibilityUIElement::uiElementForSearchPredicate):
• DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::uiElementCountForSearchPredicate):
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::searchPredicateParameterizedAttributeForSearchCriteria): (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): (WTR::AccessibilityUIElement::uiElementForSearchPredicate):

4:10 PM Changeset in webkit [159979] by Bem Jones-Bey

• 32 edits
  12 adds in trunk

[css shapes] Layout support for new circle shape syntax
​https://bugs.webkit.org/show_bug.cgi?id=124619

Reviewed by Dirk Schulze.

Source/WebCore:

Implement support for doing layout with the new circle shape syntax,
inclduing basic animation support.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html
fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html

• css/BasicShapeFunctions.cpp:

(WebCore::floatValueForCenterCoordinate): Used by both the CSS Shapes

layout code and the clip path code.

• css/BasicShapeFunctions.h:
• css/CSSBasicShapes.cpp:

(WebCore::buildCircleString): Update to use appendLiteral, and remove

call to reserveCapacity - if we find that it's actually slow when
doing performance tests, we can hopefully do something smarter and
less ugly than that.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeRadius): Fix a logic error that caused

the radius keywords not to work properly.

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Convert new circle to a layout shape.

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend): Ignore circles with values that

cannot be interpolated.

(WebCore::BasicShapeCircle::floatValueForRadiusInBox): Convert circle

radius keywords to a float value.

(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeCircle::blend):

• rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::canBlend):
(WebCore::BasicShapeRadius::canBlend):

LayoutTests:

Add a few tests for the new circle syntax. The old tests in
LayoutTests/csswg will be removed when the old syntax is removed.

Also update existing shape-inside, animation, and clip-path tests to
test the new syntax.

• animations/resources/animation-test-helpers.js:

(parseBasicShape):

• LayoutTests/animations/resources/animation-test-helpers.js:
• LayoutTests/css3/masking/clip-path-animation-expected.txt:
• LayoutTests/css3/masking/clip-path-animation.html:
• LayoutTests/css3/masking/clip-path-circle-filter.html:
• LayoutTests/css3/masking/clip-path-circle-overflow-hidden.html:
• LayoutTests/css3/masking/clip-path-circle-overflow.html:
• LayoutTests/css3/masking/clip-path-circle-relative-overflow.html:
• LayoutTests/css3/masking/clip-path-circle.html:
• LayoutTests/css3/masking/clip-path-restore.html:
• LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt:
• LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt:
• LayoutTests/fast/shapes/parsing/parsing-test-utils.js:
• LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt:
• LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt:
• LayoutTests/fast/shapes/shape-inside/shape-inside-calc-crash.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-circle-padding.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-circle.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-dynamic-nested.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html:
• LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html:
• fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
• fast/shapes/shape-outside-floats/shape-outside-animation.html:
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-000-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-001-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-001.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-002-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-002.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-003-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-003.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-004-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-004.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-005-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-circle-005.html: Added.

3:55 PM Changeset in webkit [159978] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
​https://bugs.webkit.org/show_bug.cgi?id=124714

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

• Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.write_failure):
(FailureText):
(FailureText.write_failure):
(FailureAudio):
(FailureAudio.write_failure):
(FailureCrash.write_failure):
(FailureMissingResult):
(FailureTextMismatch):
(FailureMissingImageHash.write_failure):
(FailureMissingImage.write_failure):
(FailureImageHashMismatch.write_failure):
(FailureReftestMismatch.write_failure):
(FailureReftestMismatchDidNotOccur.write_failure):
(FailureMissingAudio):
(FailureAudioMismatch):

3:52 PM Changeset in webkit [159977] by commit-queue@webkit.org

• 5 edits in trunk/Tools

Remove the stderr_write attribute from StyleProcessorConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Ryosuke Niwa.

Remove the stderr_write attribute from this class in checker and
replace its use with calls to a logging module logger. We Should
use logging module instead of writing to stderr directly.

• Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.

(check_webkit_style_configuration):
(CheckerDispatcher.dispatch): Remove FIXME comment.
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):

• Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(StyleProcessorConfigurationTest):
(StyleProcessorConfigurationTest._style_checker_configuration):
(StyleProcessorConfigurationTest.test_init):
(StyleProcessorConfigurationTest.test_write_style_error_emacs):
(StyleProcessorConfigurationTest.test_write_style_error_vs7):
(StyleProcessor_EndToEndTest.with):
(StyleProcessor_EndToEndTest.test_init):
(StyleProcessor_EndToEndTest.test_process):
(StyleProcessor_CodeCoverageTest.setUp):

• Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.

(DefaultStyleErrorHandler.call):

• Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.

There is an "ERROR" prefix in log messiges from now.
(DefaultStyleErrorHandlerTest):
(DefaultStyleErrorHandlerTest.setUp):
(DefaultStyleErrorHandlerTest._mock_increment_error_count):
(DefaultStyleErrorHandlerTest._style_checker_configuration):
(DefaultStyleErrorHandlerTest._check_initialized):
(DefaultStyleErrorHandlerTest.test_non_reportable_error):
(DefaultStyleErrorHandlerTest.test_max_reports_per_category):
(DefaultStyleErrorHandlerTest.test_line_numbers):

3:48 PM Changeset in webkit [159976] by andersca@apple.com

• 3 edits
  9 adds in trunk/Source/WebKit2

Split bundle page clients out into separate headers
​https://bugs.webkit.org/show_bug.cgi?id=125115

Reviewed by Andreas Kling.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h: Added.
• WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h: Added.

3:43 PM Changeset in webkit [159975] by ap@apple.com

• 3 edits
  2 adds in trunk

WebCrypto HMAC doesn't check key algorithm's hash
​https://bugs.webkit.org/show_bug.cgi?id=125114

Reviewed by Anders Carlsson.

Source/WebCore:

Test: crypto/subtle/hmac-check-algorithm.html

• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches): Check it.

LayoutTests:

• crypto/subtle/hmac-check-algorithm-expected.txt: Added.
• crypto/subtle/hmac-check-algorithm.html: Added.

3:30 PM Changeset in webkit [159974] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Possible crash in ProgressTracker::progressHeartbeatTimerFired(Timer<ProgressTracker>*)
​https://bugs.webkit.org/show_bug.cgi?id=125110

Reviewed by Darin Adler.

It’s possible to have a null m_originatingProgressFrame when the heartbeat timer fires.

On the surface this seems impossible because the only time m_originatingProgressFrame is cleared
out the heartbeat timer is also stopped.

But there’s likely still a race condition in multi-threaded environments.

There’s no harm in null-checking m_originatingProgressFrame before accessing its loader.

• loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

3:17 PM Changeset in webkit [159973] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
​https://bugs.webkit.org/show_bug.cgi?id=125107

Reviewed by Mark Hahnenberg.

Just killing dead code.

• jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_div):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_get_callee):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):

3:03 PM Changeset in webkit [159972] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[WK2] Improve readability of 'generate_message_handler' function
​https://bugs.webkit.org/show_bug.cgi?id=125085

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Sam Weinig.

• Scripts/webkit2/messages.py:

(generate_message_handler):

2:59 PM Changeset in webkit [159971] by commit-queue@webkit.org

• 2 edits
  7 adds in trunk/Source/Platform

Nix Upstream: Updating Platform files
​https://bugs.webkit.org/show_bug.cgi?id=124982

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-12-02
Reviewed by Benjamin Poulain.

Adding new Platform files that are missing in the trunk.

• PlatformNix.cmake:
• nix/public/AudioDestinationConsumer.h: Added.

(Nix::AudioDestinationConsumer::~AudioDestinationConsumer):

• nix/public/MediaConstraints.h: Added.
• nix/public/MediaStream.h: Added.
• nix/public/MediaStreamAudioSource.h: Added.
• nix/public/MediaStreamCenter.h: Added.
• nix/public/MediaStreamSource.h: Added.
• nix/public/PrivatePtr.h: Added.

2:56 PM Changeset in webkit [159970] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Add more CachedPage null checks
​https://bugs.webkit.org/show_bug.cgi?id=125106

Reviewed by Sam Weinig.

Only some functions in PageCache.cpp null-check the CachedPages in HistoryItems.

Every part that manipulates the CachedPage should.

• history/PageCache.cpp:

(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):

2:53 PM Changeset in webkit [159969] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk/Tools

Add JavaScript style checker and teach checker.py about .js files
​https://bugs.webkit.org/show_bug.cgi?id=125049

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Joseph Pecoraro.

Add a JavaScript file type, extension, and checker (JSChecker).
Use TextChecker for JavaScript tests, libraries, website resources,
etc. and use JSChecker for files within WebInspectorUI/UserInterface.

Amended tests for TextChecker to reflect the rule above.

• Scripts/webkitpy/style/checker.py:

(_all_categories): Add categories defined by JSChecker.
(FileType): Add file type for JS and re-number the enum.
(CheckerDispatcher._file_type): Detect .js files as JavaScript.
(CheckerDispatcher._create_checker):
Create a JSChecker or TextChecker depending on the file's path.

• Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.assert_checker_js): Added.
(CheckerDispatcherDispatchTest.test_js_paths): Added.
(CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
that end in .js but should be checked with TextChecker.

• Scripts/webkitpy/style/checkers/js.py: Added.

(JSChecker):
(JSChecker.init):
(JSChecker.check):

• Scripts/webkitpy/style/checkers/js_unittest.py: Added.

(JSTestCase):
(JSTestCase.assertNoError):
(JSTestCase.assertNoError.error_for_test):
(JSTestCase.assertError):
(JSTestCase.assertError.error_for_test):
(JSTestCase.test_no_error):
(JSTestCase.test_error):

2:48 PM Changeset in webkit [159968] by zoltan@webkit.org

• 19 edits in trunk

[CSS Shapes] Support inset parsing
​https://bugs.webkit.org/show_bug.cgi?id=124903

Reviewed by David Hyatt.

Source/WebCore:

In this patch I added support for inset shape parsing for CSS Shapes. Inset is defined
by CSS Shapes Level 1 (​http://dev.w3.org/csswg/css-shapes-1/#supported-basic-shapes).
Inset is going to be used by shape-outside (bug #124905), and eventually by shape-inside.

No new tests, I updated existing tests to cover the changes.

• css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Add support for inset.
(WebCore::basicShapeForValue): Add support for inset.

• css/CSSBasicShapes.cpp:

(WebCore::buildInsetString): Create inset css string.
(WebCore::CSSBasicShapeInset::cssText): Convert inset shape to a CSS string.
(WebCore::CSSBasicShapeInset::equals): Compare two inset rectangles.
(WebCore::CSSBasicShapeInset::serializeResolvingVariables): Create an inset string, with CSS variables resolved.
(WebCore::CSSBasicShapeInset::hasVariableReference): Determine if this inset has any CSS Variable references.

• css/CSSBasicShapes.h: Add inset class.

(WebCore::CSSBasicShapeInset::create):
(WebCore::CSSBasicShapeInset::top):
(WebCore::CSSBasicShapeInset::right):
(WebCore::CSSBasicShapeInset::bottom):
(WebCore::CSSBasicShapeInset::left):
(WebCore::CSSBasicShapeInset::topLeftRadius):
(WebCore::CSSBasicShapeInset::topRightRadius):
(WebCore::CSSBasicShapeInset::bottomRightRadius):
(WebCore::CSSBasicShapeInset::bottomLeftRadius):
(WebCore::CSSBasicShapeInset::setTop):
(WebCore::CSSBasicShapeInset::setRight):
(WebCore::CSSBasicShapeInset::setBottom):
(WebCore::CSSBasicShapeInset::setLeft):
(WebCore::CSSBasicShapeInset::setTopLeftRadius):
(WebCore::CSSBasicShapeInset::setTopRightRadius):
(WebCore::CSSBasicShapeInset::setBottomRightRadius):
(WebCore::CSSBasicShapeInset::setBottomLeftRadius):
(WebCore::CSSBasicShapeInset::CSSBasicShapeInset):

• css/CSSParser.cpp:

(WebCore::completeBorderRadii): Move static function before parseInsetBorderRadius.
(WebCore::CSSParser::parseInsetRoundedCorners): I added this helper function for parsing the rounded corners
(WebCore::CSSParser::parseBasicShapeInset): Parse inset.
(WebCore::CSSParser::parseBasicShape): Add call to parse inset.

• css/CSSParser.h:
• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add constructor for LengthSize.
(WebCore::CSSPrimitiveValue::init): Initialize LengthSize.

• css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create): Add support for creating PrimitiveValue from LengthSize.

• css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue): Add support for LengthSize.

• platform/LengthSize.h:

(WebCore::LengthSize::blend): Add blend for LengthSize.

• rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor): Keep inset disabled for shape-inside now.

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeInset::path): Calculate path for an inset.
(WebCore::BasicShapeInset::blend): Blend two insets.

• rendering/style/BasicShapes.h: Add higher level inset.

(WebCore::BasicShapeInset::create):
(WebCore::BasicShapeInset::top):
(WebCore::BasicShapeInset::right):
(WebCore::BasicShapeInset::bottom):
(WebCore::BasicShapeInset::left):
(WebCore::BasicShapeInset::topLeftRadius):
(WebCore::BasicShapeInset::topRightRadius):
(WebCore::BasicShapeInset::bottomRightRadius):
(WebCore::BasicShapeInset::bottomLeftRadius):
(WebCore::BasicShapeInset::setTop):
(WebCore::BasicShapeInset::setRight):
(WebCore::BasicShapeInset::setBottom):
(WebCore::BasicShapeInset::setLeft):
(WebCore::BasicShapeInset::setTopLeftRadius):
(WebCore::BasicShapeInset::setTopRightRadius):
(WebCore::BasicShapeInset::setBottomRightRadius):
(WebCore::BasicShapeInset::setBottomLeftRadius):
(WebCore::BasicShapeInset::BasicShapeInset):

LayoutTests:

• fast/shapes/parsing/parsing-shape-inside-expected.txt:
• fast/shapes/parsing/parsing-shape-lengths-expected.txt:
• fast/shapes/parsing/parsing-shape-lengths.html:
• fast/shapes/parsing/parsing-shape-outside-expected.txt:
• fast/shapes/parsing/parsing-test-utils.js:

2:42 PM Changeset in webkit [159967] by timothy_horton@apple.com

• 7 edits in trunk/Source/WebKit2

Remote Layer Tree: Support cloning layers
​https://bugs.webkit.org/show_bug.cgi?id=124874
<rdar://problem/15349468>

Reviewed by Simon Fraser.

We use PlatformCALayer::clone for CSS reflections, so implement it.

Also, since many reflections testcases also use masks,
working on this revealed that masks weren't working, because
we weren't flushing mask layers.

• Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Rename maskLayer->maskLayerID since it's a LayerID.

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
Don't try to look up the layer if it's null.

• Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
Keep track of all properties that have ever been changed on a layer.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::clone):
Copy all of the layer properties from the original to the clone,
and mark all properties that have ever been modified as
needing to be flushed to the UI process.

(PlatformCALayerRemote::recursiveBuildTransaction):
Flush our mask layer, if we have one.

(PlatformCALayerRemote::setMask):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Store the mask layer we're given. Our owning GraphicsLayer will
hold on to it for us.

2:36 PM Changeset in webkit [159966] by ap@apple.com

• 9 edits
  7 adds in trunk

Support WebCrypto AES-KW
​https://bugs.webkit.org/show_bug.cgi?id=125105

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/aes-kw-key-manipulation.html

crypto/subtle/aes-kw-wrap-unwrap-aes.html

• WebCore.xcodeproj/project.pbxproj: Added new files.

• crypto/CryptoAlgorithmIdentifier.h: (WebCore::CryptoAlgorithmIdentifier): Added AES-KW.

It's not standardized yet, but there appears to be a consensus that it will be specified.

• bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
Added AES-KW cases everywhere.

• bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
Support importing/exporting AES-KW keys in JWK.

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
Added some accidentally forgotten std::moves.

• crypto/algorithms/CryptoAlgorithmAES_KW.cpp: Added.
• crypto/algorithms/CryptoAlgorithmAES_KW.h: Added.
• crypto/mac/CryptoAlgorithmAES_KWMac.cpp: Added.

• crypto/keys/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::CryptoKeyAES): Allow AES-KW

as valid algorithm for AES keys.

• crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-KW.

LayoutTests:

• crypto/subtle/aes-kw-key-manipulation-expected.txt: Added.
• crypto/subtle/aes-kw-key-manipulation.html: Added.
• crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt: Added.
• crypto/subtle/aes-kw-wrap-unwrap-aes.html: Added.

2:35 PM Changeset in webkit [159965] by andersca@apple.com

• 11 edits in trunk/Source/WebKit2

WKPageLoaderClient should be versioned
​https://bugs.webkit.org/show_bug.cgi?id=125104

Reviewed by Sam Weinig.

Add multiple versions of the WKPageLoaderClient struct. In a subsequent patch,
WKPageLoaderClient and kWKPageLoaderClientCurrentVersion will be deprecated. Instead,
users of the API are supposed to explicitly choose a version and a versioned struct.

• Shared/APIClient.h:

Add a new API::Client class with a new ClientTraits template that uses std::tuple for versions.

• Shared/APIClientTraits.cpp:
• Shared/APIClientTraits.h:

Remove WKPageLoaderClient interface sizes.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
Add an explicit cast to WKPageLoaderClientBase. In an upcoming patch, WKPageSetPageLoaderClient
will be changed to take a WKPageLoaderClientBase instead.

• UIProcess/API/C/WKPageLoaderClient.h:

Add new versions.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):
Use an explicit version.

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didLayout):
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::WebLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::WebLoaderClient::didRunInsecureContentForFrame):
(WebKit::WebLoaderClient::didDetectXSSForFrame):
(WebKit::WebLoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebLoaderClient::processDidBecomeResponsive):
(WebKit::WebLoaderClient::processDidCrash):
(WebKit::WebLoaderClient::didChangeBackForwardList):
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem):
(WebKit::WebLoaderClient::willGoToBackForwardListItem):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Go through client.base everywhere.

• UIProcess/WebLoaderClient.h:

Add API::ClientTraits specialization. Change WebLoaderClient to derive from API::Client<WKPageLoaderClientBase>.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):
This now takes a WKPageLoaderClientBase*.

2:33 PM Changeset in webkit [159964] by mhahnenberg@apple.com

• 2 edits in trunk/Tools

run-jsc-stress-tests always copies the VM
​https://bugs.webkit.org/show_bug.cgi?id=125092

Reviewed by Filip Pizlo.

This can be slow, especially with full debug builds. It should just symlink the VM into the
bundle by default and do a full copy only when asked.

• Scripts/run-jsc-stress-tests:

2:31 PM Changeset in webkit [159963] by Beth Dakin

• 2 edits in trunk/Source/WebKit

Attempted build fix. I think this is no longer needed.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

2:25 PM Changeset in webkit [159962] by bshafiei@apple.com

• 5 edits in branches/safari-537.60-branch/Source

Versioning.

2:21 PM Changeset in webkit [159961] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Port run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=124801

Reviewed by Filip Pizlo.

• Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl

command on Windows so that stress tests can run.

2:06 PM WebInspectorCodingStyleGuide edited by timothy@apple.com

(diff)

1:53 PM Changeset in webkit [159960] by Beth Dakin

• 11 edits in trunk/Source

Add a setting to opt into a mode where the background extends and fixed elements
don't move on rubber-band
​https://bugs.webkit.org/show_bug.cgi?id=124745

Reviewed by Tim Horton.

Source/WebCore:

New setting backgroundShouldExtendBeyondPage() will cause the tile cache to have a
margin, and it will also cause fixed elements and backgrounds to stick to the
viewport on scroll instead of sticking to the document.

• WebCore.exp.in:
• page/FrameView.cpp:

(WebCore::FrameView::scrollBehaviorForFixedElements):

• page/Settings.in:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Source/WebKit:

Keep Windows happy.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

Add SPI to enable the new setting.

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBackgroundShouldExtendBeyondPage):
(WKPreferencesGetBackgroundShouldExtendBeyondPage):

• UIProcess/API/C/WKPreferencesPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:44 PM Changeset in webkit [159959] by bshafiei@apple.com

• 1 copy in tags/Safari-537.60.8

New tag.

1:41 PM Changeset in webkit [159958] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[MediaStream] Use iterator-based loops instead of index-based loops
​https://bugs.webkit.org/show_bug.cgi?id=125021

Patch by Roger Zanoni <​rogerzanoni@gmail.com> on 2013-12-02
Reviewed by Eric Carlson.

Also, changing iterator variable names from iter to it and
initializing an 'end' variable in each loop instead of evaluating
'collection.end()' multiple times.

No new tests, covered by existing ones.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::scheduledEventTimerFired):

1:15 PM Changeset in webkit [159957] by mhahnenberg@apple.com

• 2 edits in trunk/Tools

Build fix after r159955

• Scripts/run-jsc-stress-tests:

12:56 PM Changeset in webkit [159956] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit2

Remote Layer Tree: Hook up setLayerTreeStateIsFrozen
​https://bugs.webkit.org/show_bug.cgi?id=124872

Reviewed by Brent Fulgham.

setLayerTreeStateIsFrozen is the mechanism used to ensure that
layer property changes (including new backing store) aren't committed
while e.g. the page is reconfigured for printing.

• WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
• WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::flushLayers):
(WebKit::RemoteLayerTreeContext::setIsFlushingSuspended):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):

12:55 PM Changeset in webkit [159955] by mhahnenberg@apple.com

• 3 edits
  1 delete in trunk/Tools

run-jsc-stress-tests should be able to package its tests and move them places
​https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

• Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation

of grep -i -q

• Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
• Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.

We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.

12:52 PM Changeset in webkit [159954] by commit-queue@webkit.org

• 13 edits in trunk

[css shapes] Parse new ellipse shape syntax
​https://bugs.webkit.org/show_bug.cgi?id=124620

Patch by Rob Buis <​rob.buis@samsung.com> on 2013-12-02
Reviewed by Dirk Schulze.

Source/WebCore:

Implement parsing of the new ellipse shape syntax. This closely follows the patch
for the new circle syntax (​https://bugs.webkit.org/show_bug.cgi?id=124618), with
some refactoring of functionality shared by both.

Updated existing parsing tests to cover this.

• css/BasicShapeFunctions.cpp:

(WebCore::BasicShapeRadiusToCSSValue):
(WebCore::valueForBasicShape):
(WebCore::CSSValueToBasicShapeRadius):
(WebCore::basicShapeForValue):

• css/CSSBasicShapes.cpp:

(WebCore::buildEllipseString):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::buildDeprecatedEllipseString):
(WebCore::CSSDeprecatedBasicShapeEllipse::cssText):
(WebCore::CSSDeprecatedBasicShapeEllipse::equals):

• css/CSSBasicShapes.h:

(WebCore::CSSDeprecatedBasicShapeEllipse::create):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerX):
(WebCore::CSSDeprecatedBasicShapeEllipse::centerY):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::radiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setCenterY):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusX):
(WebCore::CSSDeprecatedBasicShapeEllipse::setRadiusY):
(WebCore::CSSDeprecatedBasicShapeEllipse::CSSDeprecatedBasicShapeEllipse):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedBasicShapeEllipse):
(WebCore::CSSParser::parseBasicShape):

• css/CSSParser.h:
• rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

• rendering/style/BasicShapes.cpp:

(WebCore::DeprecatedBasicShapeEllipse::path):
(WebCore::DeprecatedBasicShapeEllipse::blend):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeEllipse::blend):

• rendering/style/BasicShapes.h:

(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(WebCore::DeprecatedBasicShapeEllipse::create):
(WebCore::DeprecatedBasicShapeEllipse::DeprecatedBasicShapeEllipse):

LayoutTests:

Test that the new ellipse syntax is properly parsed.

• fast/shapes/parsing/parsing-shape-inside-expected.txt:
• fast/shapes/parsing/parsing-shape-outside-expected.txt:
• fast/shapes/parsing/parsing-test-utils.js:

12:44 PM Changeset in webkit [159953] by Brent Fulgham

• 2 edits in branches/safari-537.60-branch/Source/WebKit

Merge r159941.

2013-12-02 Brent Fulgham <Brent Fulgham>

[Win] WebKit Project doesn't copy resource bundle
​https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

• WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:

12:40 PM Changeset in webkit [159952] by Antoine Quint

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: popover can overlap target frame
​https://bugs.webkit.org/show_bug.cgi?id=125069

Reviewed by Joseph Pecoraro.

Fix a regression introduced in ​http://trac.webkit.org/changeset/159286. We should only
offset the frame of the popover in the y-axis if the target edge is on the x-axis, and
vice versa. We also remove the needsToDrawBackground check since it incorrectly disregarded
the anchor point. We now always draw the background which is a lot safer and guarantees
we'll always draw an adequate frame and anchor point.

• UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):
(WebInspector.Popover.prototype._bestMetricsForEdge):

12:28 PM Changeset in webkit [159951] by ap@apple.com

• 4 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

• crypto/CommonCryptoUtilities.h:
• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoKeyRSAMac.cpp:

12:11 PM Changeset in webkit [159950] by commit-queue@webkit.org

• 5 edits in trunk

Use GenericEventQueue in TrackListBase and reduce code duplication with scheduleTrackEvent()
​https://bugs.webkit.org/show_bug.cgi?id=124811

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-12-02
Reviewed by Eric Carlson.

Source/WebCore:

No new tests because this is just refactoring.

• html/track/TrackListBase.cpp:

(TrackListBase::TrackListBase): Replace event code with a GenericEventQueue.
(TrackListBase::scheduleTrackEvent): Factor out duplicate code in schedule{Add,Remove}TrackEvent functions.
(TrackListBase::scheduleAddTrackEvent): Same.
(TrackListBase::scheduleRemoveTrackEvent): Same.
(TrackListBase::scheduleChangeEvent): Use GenericEventQueue.

• html/track/TrackListBase.h: Replace event code with GenericEventQueue.

LayoutTests:

• platform/mac/TestExpectations: Unskip onremovetrack test which was fixed a long time ago.

12:05 PM Changeset in webkit [159949] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Build fix.

• WebCore.xcodeproj/project.pbxproj: Fix an automatic merge failure by re-adding

CryptoAlgorithmRsaOaepParams.h.

12:00 PM Changeset in webkit [159948] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Disable direct image compositing
​https://bugs.webkit.org/show_bug.cgi?id=124875
<rdar://problem/15446024>

Reviewed by Simon Fraser.

• WebProcess/WebPage/mac/GraphicsLayerCARemote.h:

Image-as-layer-contents is not implemented for the remote layer tree.

11:58 AM Changeset in webkit [159947] by vjaquez@igalia.com

• 2 edits in trunk/Source/WebCore

[Gstreamer] update webkitvideosink metadata
​https://bugs.webkit.org/show_bug.cgi?id=125082

Reviewed by Philippe Normand.

No new tests, no behavior changes.

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_class_init):

11:55 AM Changeset in webkit [159946] by Antoine Quint

• 7 edits in trunk/Source/WebInspectorUI

Web Inspector: add a method to add padding around a WebInspector.Rect
​https://bugs.webkit.org/show_bug.cgi?id=125072

Reviewed by Joseph Pecoraro.

Add a new WebInspector.Rect.prototype.pad() method which does not alter
the rectangle it's called and returns a new rect much like .inset(). I've
checked all call sites and there was no reuse of the rectangle that was
padded so this patch won't have any side effects.

• UserInterface/Breakpoint.js:

(WebInspector.Breakpoint.prototype._showEditBreakpointPopover):

• UserInterface/CSSStyleDeclarationTextEditor.js:
• UserInterface/Geometry.js:

(WebInspector.Rect.prototype.pad):

• UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._updatePopoverForSelectedNode):

• UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopover):

• UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):

11:55 AM Changeset in webkit [159945] by vjaquez@igalia.com

• 4 edits in trunk/Source/WebCore

Simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
​https://bugs.webkit.org/show_bug.cgi?id=125077

Remove the method's unused parameter.
Remove the GStreamer 0.10.22 run-time validation, since we are using
GStreamer 1.0 officially.
Remove the creation of a spurious Bin for the video sink, since
either the fpssink or the webkitsink are valid sink elements.
Change fpsink to a GRefPtr.

Now, createVideoSink() returns a simple pointer to the created sink
element.

Reviewed by Philippe Normand.

No new tests, no behavior changes.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

11:50 AM Changeset in webkit [159944] by ap@apple.com

• 11 edits
  12 adds in trunk

Add support for WebCrypto RSA-OAEP
​https://bugs.webkit.org/show_bug.cgi?id=125084

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/rsa-oaep-key-manipulation.html

crypto/subtle/rsa-oaep-plaintext-length.html
crypto/subtle/rsa-oaep-wrap-unwrap-aes.html

• WebCore.xcodeproj/project.pbxproj: Added new files.

• bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createRsaOaepParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
Added RSA-OAEP parameters.

• bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
Support RSA-OAEP in JWK. It is more limited than general WebCrypto, as JWK only
allows SHA-1 as hash.

• crypto/CommonCryptoUtilities.cpp: Added. (WebCore::getCommonCryptoDigestAlgorithm):
• crypto/CommonCryptoUtilities.h: Added.

Extracted some shared code and forward declarations for CommonCrypto.

• crypto/CryptoAlgorithmParameters.h: (WebCore::CryptoAlgorithmParameters::Class):
• crypto/parameters/CryptoAlgorithmRsaOaepParams.h: Added.

Added RsaOaepParams.

• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: Added.
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h: Added.
• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp: Added.

• crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::getCommonCryptoHMACAlgorithm):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoKeyMac.cpp:
• crypto/mac/CryptoKeyRSAMac.cpp:

Use CommonCryptoUtilities.

• crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register RSA-OAEP.

LayoutTests:

• crypto/subtle/rsa-oaep-key-manipulation-expected.txt: Added.
• crypto/subtle/rsa-oaep-key-manipulation.html: Added.
• crypto/subtle/rsa-oaep-plaintext-length-expected.txt: Added.
• crypto/subtle/rsa-oaep-plaintext-length.html: Added.
• crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Added.
• crypto/subtle/rsa-oaep-wrap-unwrap-aes.html: Added.

11:49 AM Changeset in webkit [159943] by fpizlo@apple.com

• 18 edits
  4 adds in trunk

Stores to local captured variables should be intercepted
​https://bugs.webkit.org/show_bug.cgi?id=124883

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Previously, in bytecode, you could assign to a captured variable just as you would
assign to any other kind of variable. This complicates closure variable constant
inference because we don't have any place where we can intercept stores to captured
variables in the LLInt.

This patch institutes a policy that only certain instructions can store to captured
variables. If you interpret those instructions and you are required to notifyWrite()
then you need to check if the relevant variable is captured. Those instructions are
tracked in CodeBlock.cpp's VerifyCapturedDef. The main one is simply op_captured_mov.
In the future, we'll probably modify those instructions to have a pointer directly to
the VariableWatchpointSet; but for now we just introduce the captured instructions as
placeholders.

In order to validate that the placeholders are inserted correctly, this patch improves
the CodeBlock validation to be able to inspect every def in the bytecode. To do that,
this patch refactors the liveness analysis' use/def calculator to be reusable; it now
takes a functor for each use or def.

In the process of refactoring the liveness analysis, I noticed that op_enter was
claiming to def all callee registers. That's wrong; it only defs the non-temporary
variables. Making that change revealed preexisting bugs in the liveness analysis, since
now the validator would pick up cases where the bytecode claimed to use a temporary and
the def calculator never noticed the definition (or the converse - where the bytecode
was actually not using a temporary but the liveness analysis thought that it was a
use). This patch fixes a few of those bugs.

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::stepOverInstruction):

• bytecode/BytecodeUseDef.h: Added.

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::validate):

• bytecode/CodeBlock.h:
• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::isCaptured):
(JSC::BytecodeGenerator::local):
(JSC::BytecodeGenerator::constLocal):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):

• bytecompiler/BytecodeGenerator.h:

(JSC::Local::Local):
(JSC::Local::isCaptured):
(JSC::Local::captureMode):
(JSC::BytecodeGenerator::captureMode):
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::pushOptimisedForIn):

• bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/SymbolTable.h:

(JSC::SymbolTable::isCaptured):

LayoutTests:

Reviewed by Mark Hahnenberg.

• js/regress/captured-assignments-expected.txt: Added.
• js/regress/captured-assignments.html: Added.
• js/regress/script-tests/captured-assignments.js: Added.

11:09 AM Changeset in webkit [159942] by fpizlo@apple.com

• 29 edits in trunk/Source/JavaScriptCore

Instead of watchpointing activation allocation, we should watchpoint entry into functions that have captured variables
​https://bugs.webkit.org/show_bug.cgi?id=125052

Reviewed by Mark Hahnenberg.

This makes us watch function entry rather than activation creation. We only incur the
costs of doing so for functions that have captured variables, and only on the first two
entries into the function. This means that closure variable constant inference will
naturally work even for local uses of the captured variable, like:

(function(){

var blah = 42;
... stuff
function () { ... blah /* we can fold this to 42 */ }
... blah we can also fold this to 42.

})();

Previously, only the nested use would have been foldable.

• bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecode/Watchpoint.h:

(JSC::WatchpointSet::touch):
(JSC::InlineWatchpointSet::touch):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasSymbolTable):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_touch_entry):

• llint/LowLevelInterpreter.asm:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• runtime/JSActivation.h:

(JSC::JSActivation::create):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

• runtime/SymbolTable.h:

10:47 AM Changeset in webkit [159941] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Win] WebKit Project doesn't copy resource bundle
​https://bugs.webkit.org/show_bug.cgi?id=125078

Reviewed by Jer Noble.

• WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Correct post-build step

to copy WebKit.resources to build target.

10:23 AM Changeset in webkit [159940] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
​https://bugs.webkit.org/show_bug.cgi?id=125075

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Michael Saboff.

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall): added UNUSED_PARAM(pc).
(JSC::LLInt::setUpCall): Doesn't pass 'pc' to LLINT_CALL macros.
(JSC::LLInt::LLINT_SLOW_PATH_DECL): Ditto.

9:49 AM Changeset in webkit [159939] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[GTK] Fails to build with freetype 2.5.1
​https://bugs.webkit.org/show_bug.cgi?id=125074

Patch by Andres Gomez <Andres Gomez> on 2013-12-02
Reviewed by Carlos Garcia Campos.

FreeType specifies a canonical way of including their own
headers. Now, we are following this recommendation so the
compilation won't be broken again due to an upgrade in FeeType's
including paths.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:
• platform/graphics/freetype/SimpleFontDataFreeType.cpp:
• platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

9:28 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

9:20 AM Changeset in webkit [159938] by lauro.neto@openbossa.org

• 5 edits
  1 move
  1 add
  1 delete in trunk/LayoutTests

[MediaStream] Update layout tests to newer spec.
​https://bugs.webkit.org/show_bug.cgi?id=124985

Reviewed by Eric Carlson.

• TestExpectations:
• fast/mediastream/MediaStream-onended-expected.txt: Removed.
• fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
• fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
• fast/mediastream/RTCPeerConnection-ice-expected.txt:
• fast/mediastream/RTCPeerConnection-state-expected.txt:
• fast/mediastream/RTCSessionDescription-expected.txt:

9:14 AM Changeset in webkit [159937] by commit-queue@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

Remove stdio.h from JSC files.
​https://bugs.webkit.org/show_bug.cgi?id=125066

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

Remove stdio.h, when it is not necessary to be included.

• bytecode/CodeBlock.cpp:
• bytecode/StructureSet.h:
• profiler/LegacyProfiler.cpp:
• profiler/Profile.cpp:
• profiler/ProfileNode.cpp:
• yarr/YarrInterpreter.cpp:

8:51 AM Changeset in webkit [159936] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unused include files when building without JIT.
​https://bugs.webkit.org/show_bug.cgi?id=125062

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Michael Saboff.

We should organize the includes, and guard JIT methods
in ValueRecovery.

• bytecode/ValueRecovery.cpp: Guard include files.
• bytecode/ValueRecovery.h: Guard JIT methods.

8:41 AM Changeset in webkit [159935] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[MIPS] Small stack frame causes regressions.
​https://bugs.webkit.org/show_bug.cgi?id=124945

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-12-02
Reviewed by Michael Saboff.

Fix stack space for LLInt on MIPS.

• llint/LowLevelInterpreter32_64.asm:

8:38 AM Changeset in webkit [159934] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

jsc: implement a native readFile function
​https://bugs.webkit.org/show_bug.cgi?id=125059

Patch by Brian J. Burg <Brian Burg> on 2013-12-02
Reviewed by Filip Pizlo.

This adds a native readFile() function to jsc, used to slurp
an entire file into a JavaScript string.

• jsc.cpp:

(GlobalObject::finishCreation): Add readFile() to globals.
(functionReadFile): Added.

7:36 AM Changeset in webkit [159933] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

JSC does not build if OPCODE_STATS is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=125011

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-12-02
Reviewed by Filip Pizlo.

• bytecode/Opcode.cpp:

6:19 AM Changeset in webkit [159932] by Chris Fleizach

• 4 edits
  2 adds in trunk

AX: Crash at WebCore::commonTreeScope
​https://bugs.webkit.org/show_bug.cgi?id=125042

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When an AX text marker that references a node in a detached document is used to create a text marker range, a crash occurs
because the method to determine commonTreeScopes does not account for when there are no common tree scopes.

Test: platform/mac/accessibility/ordered-textmarker-crash.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions):

• dom/TreeScope.cpp:

(WebCore::commonTreeScope):

LayoutTests:

• platform/mac/accessibility/ordered-textmarker-crash-expected.txt: Added.
• platform/mac/accessibility/ordered-textmarker-crash.html: Added.

5:58 AM Changeset in webkit [159931] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Fix a crash in the webaudio source provider when the audio track is going away.
​https://bugs.webkit.org/show_bug.cgi?id=124975

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-12-02
Reviewed by Philippe Normand.

Merged ​https://chromium.googlesource.com/chromium/blink/+/b21838b32bf11b1a972dfc449ddde71115490c23

Before this patch, it was hitting a use-after-free crash when the audio
track in the media stream is going away and the webaudio mediastreamsourcenode
is still running.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Passing audio track
pointer to MediaStreamAudioSourceNode constructor.

• Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

• Modules/webaudio/MediaStreamAudioSourceNode.h: Added

MediaStreamTrack class variable and change the constructor to receive
it as parameter.

3:34 AM Changeset in webkit [159930] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Adding failure expectations for the

fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html reftest.

3:30 AM Changeset in webkit [159929] by gyuyoung.kim@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline since r159915.

Error messages are changed. So, test results need to be updated.

• platform/efl/fast/forms/validation-message-appearance-expected.txt:
• platform/efl/fast/forms/validationMessage-expected.txt:

3:27 AM Changeset in webkit [159928] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Remove unneeded autoconf macros
​https://bugs.webkit.org/show_bug.cgi?id=125044

Compilers that do not support const/inline/volatile and
systems with pre-C89-headers are anyway not supported.

Patch by Adrian Bunk <​bunk@stusta.de> on 2013-12-02
Reviewed by Gustavo Noronha Silva.

• Source/autotools/CheckSystemAndBasicDependencies.m4:

2:47 AM Changeset in webkit [159927] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159926 - [GTK] GTK2 paint code path does not render AC layers
​https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

• webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:45 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

2:44 AM Changeset in webkit [159926] by Gustavo Noronha Silva

• 2 edits in trunk/Source/WebKit/gtk

[GTK] GTK2 paint code path does not render AC layers
​https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

• webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

2:40 AM Changeset in webkit [159925] by commit-queue@webkit.org

• 12 edits
  1 add in trunk

[ATK] Support active state for listbox elements.
​https://bugs.webkit.org/show_bug.cgi?id=125009

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2013-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ATK_STATE_ACTIVE for listbox elements.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isSelectedOptionActive):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

Establish expectations for the test (all PASS).

• accessibility/multiselect-list-reports-active-option-expected.txt: Added.
• platform/efl-wk1/TestExpectations:
• platform/efl-wk2/TestExpectations:

2:24 AM Changeset in webkit [159924] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed GTK gardening.

• Scripts/run-gtk-tests:

(TestRunner): Skip two unit tests that are causing the subsequent test to crash.

2:12 AM Changeset in webkit [159923] by Seokju Kwon

• 3 edits in trunk/Source/WebCore

Web Inspector: Remove unused functions from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=125061

Reviewed by Antoine Quint.

Get rid of unused functions, redundant inclusion and forward declaration.

No new tests, no behavior changes.

• inspector/InspectorAgent.cpp:
• inspector/InspectorAgent.h:

2:04 AM Changeset in webkit [159922] by Carlos Garcia Campos

• 46 edits in releases/WebKitGTK/webkit-2.2

Merge r155201 - REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=120781

Reviewed by Mark Hahnenberg.

Roll this back in with a build fix.

• Use some method table hacks to detect if the CheckStructure optimization is valid for to_this.

• Introduce a FinalObjectUse and use it for ToThis->Identity conversion.

This looks like it might be perf-neutral on the major benchmarks, but it
introduces some horrible performance cliffs. For example if you add methods to
the Array prototype, you'll get horrible performance cliffs. As in virtual calls
to C++ every time you call a JS function even if it's inlined.
LongSpider/3d-cube appears to hit this.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::speculate):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGUseKind.cpp:

(WTF::printInternal):

• dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

2:00 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:58 AM Changeset in webkit [159921] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix build warning in EventHandler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=125010

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-12-02
Reviewed by Csaba Osztrogonác.

• page/EventHandler.cpp:

(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

1:38 AM WebKitGTK/2.2.x edited by Andres Gomez

(diff)

1:28 AM Changeset in webkit [159920] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r159843 - REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
​https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

• tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
• webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

1:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:24 AM Changeset in webkit [159919] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159615 - [GTK] Cannot scroll in option menu when it larger than the screen
​https://bugs.webkit.org/show_bug.cgi?id=124671

Reviewed by Martin Robinson.

The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.

• platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.

1:21 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:20 AM Changeset in webkit [159918] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159811 - [GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
​https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

• UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

1:18 AM Changeset in webkit [159917] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/LayoutTests

Merge r159686 - Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

• platform/gtk/TestExpectations:

1:17 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

1:15 AM Changeset in webkit [159916] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r159572 - [GTK] Remove Chromium as user agent and claim to be Safari in OS X
​https://bugs.webkit.org/show_bug.cgi?id=124229

Reviewed by Martin Robinson.

​http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.

• platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

1:08 AM Changeset in webkit [159915] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

HTML5 required attribute validation messages implemented.
​https://bugs.webkit.org/show_bug.cgi?id=125003

Patch by Attila Dusnoki <​adusnoki@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.

• platform/efl/LocalizedStringsEfl.cpp:

(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):

12:59 AM Changeset in webkit [159914] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r158687 - Fix register allocation inside control flow in GetByVal String
​https://bugs.webkit.org/show_bug.cgi?id=123816

Reviewed by Geoffrey Garen.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

12:58 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:56 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:26 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

Dec 1, 2013:

11:48 PM Changeset in webkit [159913] by ChangSeok Oh

• 5 edits in trunk/Source/WebKit2

Unreviewed Gtk port Build fix after r159903

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):

• UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

9:44 PM Changeset in webkit [159912] by akling@apple.com

• 3 edits in trunk/Source/WebCore

SVG: Intersection/enclosure checks should use RenderElement.
<​https://webkit.org/b/125058>

Make RenderSVGModelObject's checkIntersection() and checkEnclosure()
take RenderElement* instead of RenderObject*. They are only ever
called with SVGElement's renderers.

Reviewed by Sam Weinig.

9:43 PM Changeset in webkit [159911] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove unreachable labels for -webkit-margin-*-collapse properties.
<​https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.

9:41 PM Changeset in webkit [159910] by akling@apple.com

• 2 edits in trunk/Source/WebCore

CSSFunctionValue constructors should return PassRef.
<​https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.

7:36 PM Changeset in webkit [159909] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r159764.
​http://trac.webkit.org/changeset/159764
​https://bugs.webkit.org/show_bug.cgi?id=125055

appears to hurt html5-full-render times (Requested by kling on
#webkit).

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

• html/parser/HTMLConstructionSite.h:

7:36 PM Changeset in webkit [159908] by weinig@apple.com

• 9 edits in trunk/Source/WebKit2

Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)
​https://bugs.webkit.org/show_bug.cgi?id=125053

Reviewed by Dan Bernstein.

• Give the UserMessageEncoders a process reference.
• Switch UserMessageDecoders to storing a process reference, rather than pointer.

• Shared/UserMessageCoders.h:
• Shared/mac/ObjCObjectGraphCoders.h:
• Shared/mac/ObjCObjectGraphCoders.mm:
• UIProcess/WebConnectionToWebProcess.cpp:
• UIProcess/WebContext.cpp:
• UIProcess/WebContextUserMessageCoders.h:
• UIProcess/WebPageProxy.cpp:
• WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

6:47 PM Changeset in webkit [159907] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Make more computed style helpers return PassRef.
<​https://webkit.org/b/125043>

Reduce branchiness in computed style code by making more of the
file-local helpers return PassRef instead of PassRefPtr.

Reviewed by Anders Carlsson.

5:53 PM Changeset in webkit [159906] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

[Cocoa] The PageLoadState::Observer is not being set on iOS
​https://bugs.webkit.org/show_bug.cgi?id=125051

Reviewed by Dan Bernstein.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::platformInitialize):
Add missing call to _finishInitialization.

5:16 PM Changeset in webkit [159905] by ryuan.choi@samsung.com

• 9 edits in trunk/Source/WebKit2

Unreviewed EFL Build fix attempt after r159903

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::CoordinatedDrawingAreaProxy::update):
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):

• UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):

• UIProcess/WebTextChecker.cpp:

(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):

• UIProcess/WebTextChecker.h:
• UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):

• UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

• UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

• UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

5:04 PM Changeset in webkit [159904] by weinig@apple.com

• 4 edits in trunk/Source/WebKit2

Fix the iOS build.

• UIProcess/API/ios/WKContentView.mm:
• UIProcess/API/ios/WKInteractionView.mm:
• UIProcess/ios/WebPageProxyIOS.mm:

4:50 PM Changeset in webkit [159903] by weinig@apple.com

• 33 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebProcessProxy is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125047

Reviewed by Dan Bernstein.

• UIProcess/API/C/WKPage.cpp:
• UIProcess/API/C/mac/WKPagePrivateMac.cpp:
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:
• UIProcess/API/mac/WKView.mm:
• UIProcess/Downloads/DownloadProxy.cpp:
• UIProcess/Downloads/DownloadProxy.h:
• UIProcess/Downloads/DownloadProxyMap.cpp:
• UIProcess/Downloads/DownloadProxyMap.h:
• UIProcess/DrawingAreaProxy.cpp:
• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
• UIProcess/Network/NetworkProcessProxy.cpp:
• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
• UIProcess/Notifications/WebNotificationManagerProxy.cpp:
• UIProcess/WebContext.cpp:
• UIProcess/WebContext.h:
• UIProcess/WebEditCommandProxy.cpp:
• UIProcess/WebFrameProxy.cpp:
• UIProcess/WebFullScreenManagerProxy.cpp:
• UIProcess/WebInspectorProxy.cpp:
• UIProcess/WebPageGroup.h:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:
• UIProcess/WebProcessProxy.h:
• UIProcess/cf/WebPageProxyCF.cpp:
• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
• UIProcess/mac/RemoteLayerTreeHost.mm:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
• UIProcess/mac/WebFullScreenManagerProxyMac.mm:
• UIProcess/mac/WebInspectorProxyMac.mm:
• UIProcess/mac/WebPageProxyMac.mm:

4:50 PM Changeset in webkit [159902] by mitz@apple.com

• 4 edits in trunk/Tools

[Mac] Transition MiniBrowser to the Cocoa API: policy delegate
​https://bugs.webkit.org/show_bug.cgi?id=125046

Reviewed by Sam Weinig.

• MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
(-[BrowserAppDelegate openDocument:]): Ditto.

• MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the

interface to the implementation.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
the policy client.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
Moved policy client implementation into this delegate method.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
Ditto.

3:40 PM Changeset in webkit [159901] by ryuan.choi@samsung.com

• 3 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
​https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

11:14 AM WebInspectorCodingStyleGuide edited by Brian Burg

Fix tt styles, add links to mechanization tracking bug, repository … (diff)

11:00 AM WebInspectorCodingStyleGuide edited by Brian Burg

Add protected (diff)

10:46 AM WikiStart edited by Brian Burg

Move and relabel Web Inspector links; add inspector style guide (diff)

9:03 AM Changeset in webkit [159900] by mitz@apple.com

• 3 edits
  2 deletes in trunk/Tools

[Mac] Remove the MiniBrowser injected bundle
​https://bugs.webkit.org/show_bug.cgi?id=125041

Reviewed by Anders Carlsson.

It had no ops!

• MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
• MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
• MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):

• MiniBrowser/mac/WebBundle/Info.plist: Removed.
• MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.

5:45 AM Changeset in webkit [159899] by Philippe Normand

• 4 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159896.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView):

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

12:07 AM Changeset in webkit [159898] by ryuan.choi@samsung.com

• 4 edits in trunk/Source/WebKit2

Unreviewed build fix after r159896.

• UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

Nov 30, 2013:

11:05 PM Changeset in webkit [159897] by ryuan.choi@samsung.com

• 4 edits in trunk/Source/WebCore

[EFL] Implement scrollbarThickness for opaque scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=125034

Reviewed by Gyuyoung Kim.

Implemented scrollbarThickness to support opaque scrollbar.
Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
in ScrollbarThemeEfl.cpp.

No new tests, no behavior changes with default theme.

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::loadTheme):
Update thickness of scrollbar when theme was loaded.

• platform/efl/ScrollbarThemeEfl.cpp:
• platform/efl/ScrollbarThemeEfl.h:

(WebCore::ScrollbarThemeEfl::setScrollbarThickness):
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

10:40 PM Changeset in webkit [159896] by weinig@apple.com

• 17 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125038

Reviewed by Dan Bernstein.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):

• UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController browsingContextGroup]):

• UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):

• UIProcess/WebContext.h:
• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorProxy::isInspectorPage):

• UIProcess/WebInspectorProxy.h:
• UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::createNonNull):

• UIProcess/WebPageGroup.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::preferencesDidChange):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageGroup):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/WebProcessProxy.h:
• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):

• UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::pageIsProcessSuppressible):

10:24 PM Changeset in webkit [159895] by mitz@apple.com

• 6 edits in trunk/Source/WebKit2

Added a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take a base URL and switched all callers to it.
​https://bugs.webkit.org/show_bug.cgi?id=125040

Reviewed by Sam Weinig.

• Shared/Cocoa/WKNSURLExtras.h: Declared new method.
• Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Added helper function.
(+[NSURL _web_URLWithWTFString:]): Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Changed to use helper function.

• UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to call new method.
(-[WKBackForwardListItem originalURL]): Ditto.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Ditto.
(setUpPagePolicyClient): Ditto.

• UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

10:02 PM Changeset in webkit [159894] by mitz@apple.com

• 4 edits in trunk/Source/WebKit2

[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
​https://bugs.webkit.org/show_bug.cgi?id=125036

Reviewed by Sam Weinig.

• Shared/Cocoa/WKNSURLExtras.h: Declared new method.
• Shared/Cocoa/WKNSURLExtras.mm:

(-[NSURL _web_originalDataAsWTFString]): Added. Returns a WTF::String with the receiver’s
bytes.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController _pageRef]):
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):

7:52 PM Changeset in webkit [159893] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159865.
​http://trac.webkit.org/changeset/159865
​https://bugs.webkit.org/show_bug.cgi?id=125037

the position of mouse events are wrong at MiniBrowser/efl
(Requested by ryuan on #webkit).

• UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):

7:33 PM Changeset in webkit [159892] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[Win] Some JavaScript date tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=124946

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-30
Reviewed by Brent Fulgham.

Use native Win32 api functions to compute Daylight saving time offset.

• wtf/DateMath.cpp:

(WTF::UnixTimeToFileTime): Added method to calculate Win32 specific struct FILETIME from time_t value.
(WTF::calculateDSTOffset): Use native Win32 api functions to compute Daylight saving time offset.

6:25 PM Changeset in webkit [159891] by weinig@apple.com

• 7 edits in trunk/Source/WebKit2

[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored in a Ref
​https://bugs.webkit.org/show_bug.cgi?id=125035

Reviewed by Dan Bernstein.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetBackForwardList):

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Remove null check.

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::currentItem): Constify.
(WebKit::WebBackForwardList::backItem): Constify.
(WebKit::WebBackForwardList::forwardItem): Constify.
(WebKit::WebBackForwardList::itemAtIndex): Constify.

• UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::create):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::backForwardList):

12:15 PM Changeset in webkit [159890] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159889.

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::viewWidget): Adjust the static cast of the PageClient reference to PageClientImpl.

11:14 AM Changeset in webkit [159889] by weinig@apple.com

• 15 edits in trunk/Source/WebKit2

[CTTE] WebPageProxy should store the PageClient as a reference
​https://bugs.webkit.org/show_bug.cgi?id=125030

Reviewed by Dan Bernstein.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

• UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

• UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:

(WebKit::WebPageProxy::didFindZoomableArea):

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

• UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

• UIProcess/WebContext.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::displayView):
(WebKit::WebPageProxy::canScrollView):
(WebKit::WebPageProxy::scrollView):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::viewSize):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::screenToWindow):
(WebKit::WebPageProxy::windowToScreen):
(WebKit::WebPageProxy::pageDidRequestScroll):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setFindIndicator):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::initializeCreationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

• UIProcess/WebPageProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

• UIProcess/WebProcessProxy.h:
• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::mainDocumentDidReceiveMobileDocType):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::didChangeViewportArguments):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedData):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::wkView):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

10:55 AM Changeset in webkit [159888] by weinig@apple.com

• 6 edits in trunk/Source/WebKit2

[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
​https://bugs.webkit.org/show_bug.cgi?id=125029

Reviewed by Dan Bernstein.

• UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::GeolocationPermissionRequestManagerProxy):
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):

• UIProcess/GeolocationPermissionRequestManagerProxy.h:
• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):

• UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Do some additional modernization while we are here.

10:49 AM Changeset in webkit [159887] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSError’s userInfo, including NSErrorFailingURLKey
​https://bugs.webkit.org/show_bug.cgi?id=125016

Reviewed by Anders “happy name day” Carlsson.

• Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData): Encode all string- and URL-valued keys as a dictionary.
(CoreIPC::::decodePlatformData): Decode user info as a dictionary.

9:23 AM Changeset in webkit [159886] by fpizlo@apple.com

• 28 edits in trunk/Source/JavaScriptCore

Finally remove those DFG_ENABLE things
​https://bugs.webkit.org/show_bug.cgi?id=125025

Rubber stamped by Sam Weinig.

This removes a bunch of unused and untested insanity.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

• dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

• dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

• dfg/DFGCommon.h:

(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldDumpGraphAtEachPhase):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

• dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

• dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

• dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::appendAndLog):

• dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

9:05 AM Changeset in webkit [159885] by mrowe@apple.com

• 3 edits in trunk/Websites/webkit.org

<​https://webkit.org/b/125027> Update the analytics account used by webkit.org

Switch to a Google Analytics id that's accessible to someone that's involved with the WebKit project.

Reviewed by Sam Weinig.

• footer.inc: Remove the old analytics code.
• header.inc: Add the new stuff.

Nov 29, 2013:

11:41 PM Changeset in webkit [159884] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix for EFL and GTK WK2 builds.

• Scripts/generate-forwarding-headers.pl: Add Cocoa to the list of platform prefixes.

8:17 PM Changeset in webkit [159883] by fpizlo@apple.com

• 6 edits in trunk/Source/JavaScriptCore

FTL IC should nop-fill to make up the difference between the actual IC size and the requested patchpoint size
​https://bugs.webkit.org/show_bug.cgi?id=124960

Reviewed by Sam Weinig.

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::size):

• assembler/X86Assembler.h:

(JSC::X86Assembler::fillNops):

• dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

• ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):

• jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

8:13 PM Changeset in webkit [159882] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit2

Fix build warnings in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

• Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::SocketEventSource::eventCallback):

• Shared/API/c/WKDeprecatedFunctions.cpp:

(WKArrayIsMutable):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

6:04 PM Changeset in webkit [159881] by weinig@apple.com

• 10 edits in trunk/Source/WebKit2

[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
​https://bugs.webkit.org/show_bug.cgi?id=125024

Reviewed by Dan Bernstein.

Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using
std::aligned_storage.

• Shared/Cocoa/WKNSArray.mm:
• Shared/Cocoa/WKNSDictionary.mm:
• Shared/Cocoa/WKObject.h:
• UIProcess/API/Cocoa/WKBackForwardList.mm:
• UIProcess/API/Cocoa/WKBackForwardListItem.mm:
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:
• UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
• UIProcess/API/Cocoa/WKNavigationData.mm:
• UIProcess/API/Cocoa/WKProcessGroup.mm:

5:46 PM Changeset in webkit [159880] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Fix crashing API tests.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):

4:56 PM Changeset in webkit [159879] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Fix some style boo-boos.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:53 PM Changeset in webkit [159878] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Fix the iOS build.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

4:27 PM Changeset in webkit [159877] by weinig@apple.com

• 9 edits in trunk/Source/WebKit2

[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
​https://bugs.webkit.org/show_bug.cgi?id=125022

Reviewed by Dan Bernstein.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/mac/ObjCObjectGraphCoders.mm:

Add support for WKProcessGroup.

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
Replace call to _browsingContextControllerForPageRef: with wrapper.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.

(-[WKBrowsingContextController dealloc]):
Add explicit destructor call.

(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
Lazily set up the load and policy clients only once a delegate has been set to allow
continued use of the C-SPI clients for WebKitTestRunner.

(-[WKBrowsingContextController _finishInitialization]):
Move remaining work that was done in the initialize (setting up the observer) here,
and have the WebPageProxy call it.

• UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
_initWithPageRef: and _browsingContextControllerForPageRef: helpers.

• UIProcess/API/Cocoa/WKProcessGroup.mm:

(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
Switch to using wrapper().

• UIProcess/API/ios/WKContentView.mm:
• UIProcess/API/mac/WKView.mm:

Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
as the WebPageProxy.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitialize):
Inform the wrapper that it is safe to finish initialization.

3:21 PM Changeset in webkit [159876] by mitz@apple.com

• 8 edits
  2 adds in trunk/Source/WebKit2

[Cocoa] Add a way to recover from load errors
​https://bugs.webkit.org/show_bug.cgi?id=125020

Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
the given error, adding two keys to the user info dictionary: the context controller under
the recovery attempter key, and the frame under a private key.
(didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
(didFailLoadWithErrorForFrame): Ditto.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
frame from the error.

• UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting

recovery from errors and declares the error user info dictionary key under which an object
conforming to this protocol may be stored.

• UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines

WKRecoveryAttempterErrorKey.

• UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.

• UIProcess/WebFrameProxy.h:

• WebKit2.xcodeproj/project.pbxproj: Added references to new files.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.

1:15 PM Changeset in webkit [159875] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Expose loadAlternateHTMLString via the API
​https://bugs.webkit.org/show_bug.cgi?id=125019

Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
Calls WebPageProxy::loadAlternateHTMLString.

12:54 PM Changeset in webkit [159874] by weinig@apple.com

• 2 edits
  22 moves in trunk/Source/WebKit2

Move API files shared between Mac and iOS to the Cocoa directory
​https://bugs.webkit.org/show_bug.cgi?id=125017

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
• UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
• UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
• UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
• UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
• UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
• UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
• UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
• UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
• UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
• UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
• UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
• UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
• UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
• UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
• UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
• UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
• UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
• UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
• UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
• UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
• UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
• UIProcess/API/mac/WKBrowsingContextController.h: Removed.
• UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
• UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
• UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
• UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
• UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
• UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
• UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
• UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
• UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
• UIProcess/API/mac/WKConnection.h: Removed.
• UIProcess/API/mac/WKConnection.mm: Removed.
• UIProcess/API/mac/WKConnectionInternal.h: Removed.
• UIProcess/API/mac/WKProcessGroup.h: Removed.
• UIProcess/API/mac/WKProcessGroup.mm: Removed.
• UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
• UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
• UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
• UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
• UIProcess/API/mac/WKView.h: Removed.
• UIProcess/API/mac/WKViewPrivate.h: Removed.
• UIProcess/API/mac/WebKit2.h: Removed.
• WebKit2.xcodeproj/project.pbxproj:

10:50 AM Moving to Git edited by kallisti5@unixzen.com

(diff)

9:25 AM Changeset in webkit [159873] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
​https://bugs.webkit.org/show_bug.cgi?id=124936

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
src FPRegister and are likely to be more efficient than the current generic implementation
using the stack.

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

6:32 AM Changeset in webkit [159872] by commit-queue@webkit.org

• 3 edits in trunk/Tools

check-webkit-style should check for extraneous newline between config.h and primary header.
​https://bugs.webkit.org/show_bug.cgi?id=124821

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-11-29
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_line_break_after_own_header):
(OrderOfIncludesTest):
(OrderOfIncludesTest.test_check_line_break_before_own_header):

6:16 AM Changeset in webkit [159871] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
​https://bugs.webkit.org/show_bug.cgi?id=124892

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.

4:23 AM Changeset in webkit [159870] by Michał Pakuła vel Rutka

• 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Accessibility rebaselines after r159848.

• platform/efl-wk1/accessibility/table-detection-expected.txt:
• platform/efl-wk2/accessibility/table-detection-expected.txt:

4:06 AM Changeset in webkit [159869] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove Symbian specific code.
​https://bugs.webkit.org/show_bug.cgi?id=124939

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

Symbian is not supported, remove leftover code.

• plugins/npapi.h:

3:41 AM Changeset in webkit [159868] by Csaba Osztrogonác

• 2 edits in trunk/Tools

test-webkit-scripts should show the failing tests and use an appropriate exit code
​https://bugs.webkit.org/show_bug.cgi?id=124840

Patch by Jozsef Berta <​jberta@inf.u-szeged.hu> on 2013-11-29
Reviewed by Ryosuke Niwa.

A fixme in test-webkit-scripts asked that the script should display success or failiure
and exit with a 0 or 1 value accordingly after all of the tests have completed.

• Scripts/test-webkit-scripts:

(ScriptsTester.run_test_script):
The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
because at this point we don't need to pass on more information other than success or failiure.
(ScriptsTester.main):
The return values are now stored for each script and when all tests have completed successfully,
the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.

3:38 AM Changeset in webkit [159867] by commit-queue@webkit.org

• 4 edits
  2 moves in trunk

[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
​https://bugs.webkit.org/show_bug.cgi?id=124923

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-11-29
Reviewed by Mario Sanchez Prada.

Tools:

Added missing implementation of isAttributeSettable. Using
ATK_STATE_EDITABLE for checking whether attribute is settable.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSettable):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSettable):

LayoutTests:

Test could be reused by EFL and GTK as well.

• accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
• accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.

3:26 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com

changeset 159572 is controversial (diff)

2:51 AM Changeset in webkit [159866] by commit-queue@webkit.org

• 3 edits in trunk

[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
​https://bugs.webkit.org/show_bug.cgi?id=124899

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-29
Reviewed by Gyuyoung Kim.

• Source/cmake/FindCairo.cmake:
• Source/cmake/FindGStreamer.cmake:

12:37 AM Changeset in webkit [159865] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL] viewport must be same with the size of webview
​https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <Hunseop Jeong> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

• UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.